⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 27, 2010:

11:52 PM Changeset in webkit [61981] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows (Cairo) build fix.
Add missing ENABLE_WEB_TIMING feature define.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:49 PM Changeset in webkit [61980] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix.
Disable ENABLE_WEB_TIMING on Windows.

  • win/tools/vsprops/FeatureDefines.vsprops:
11:37 PM Changeset in webkit [61979] by mrowe@apple.com
  • 4 edits in trunk/WebKit2

Update guards related to blocks to check whether BLOCKS is defined, rather than checking its value.

Rubber-stamped by Maciej Stachowiak.

This matches how similar checks are performed in system headers, and avoids a compile error when BLOCKS
is not defined.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
10:45 PM Changeset in webkit [61978] by morrita@google.com
  • 2 edits in trunk/WebKitTools

2010-06-27 MORITA Hajime <​morrita@google.com>

Unreviewed.

Some never-called @staticmethods touched self.
Fixed it to replace these self with a class.

  • Scripts/webkitpy/common/checkout/scm.py:
10:34 PM Changeset in webkit [61977] by morrita@google.com
  • 3 edits in trunk/WebKitTools

2010-06-27 MORITA Hajime <​morrita@google.com>

Unreviewed.

Fixed exception raising syntax that is pointed out at
​https://bugs.webkit.org/show_bug.cgi?id=41153

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py: Removed a bad line that I accidentally checked-in at last revision.
10:15 PM Changeset in webkit [61976] by morrita@google.com
  • 4 edits in trunk/WebKitTools

2010-06-24 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

rebaseline-chromium-webkit-tests should add or remove files to local git repository
​https://bugs.webkit.org/show_bug.cgi?id=41153

  • Added SCM.add() and SCM.remove()
  • Replaced "svn add" and "svn remove" rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
  • add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py for debugging purpose.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
6:59 PM Changeset in webkit [61975] by yuzo@google.com
  • 29 edits in trunk

2010-06-25 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
​https://bugs.webkit.org/show_bug.cgi?id=41150

  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:

2010-06-25 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.

Default page size and orientation have been hard-coded.
Instead, pass default page size and margins to
WebCore::Document::pageSizeAndMarginsInPixels to handle auto page size
and margins specified as percentages.
Return margins instead of page rect.

​https://bugs.webkit.org/show_bug.cgi?id=41150

  • WebCore.base.exp:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName):
  • css/html.css: (@page):
  • dom/Document.cpp: (WebCore::Document::pageSizeAndMarginsInPixels):
  • dom/Document.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • page/PrintContext.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSizeType): (WebCore::InheritedFlags::setPageSizeType): (WebCore::InheritedFlags::resetPageSizeType):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h: (WebCore::):

2010-06-25 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
​https://bugs.webkit.org/show_bug.cgi?id=41150

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageSizeAndMarginsInPixels):
  • src/WebFrameImpl.h:

2010-06-25 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
​https://bugs.webkit.org/show_bug.cgi?id=41150

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):

2010-06-25 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
​https://bugs.webkit.org/show_bug.cgi?id=41150

  • DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (parsePageNumberSizeMarings): (pageSizeAndMarginsInPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageSizeAndMarginsInPixels):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
4:19 PM Changeset in webkit [61974] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Clean up some loose ends in HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41265

This patch cleans up a few loose ends in HTML5 tree builder.
Technically, we could do each of these as individual patches, but that
didn't seem worth while.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
    • Add missing break before default case statement. I don't think this change is observable.

(WebCore::HTMLTreeBuilder::processComment):

  • Originally I thought that comments had special processing in the InHeadNoscriptMode, but it turns out that when you unwind the definitions, it amounts to exactly the same thing.

(WebCore::HTMLTreeBuilder::processEndOfFile):

  • Add missing break before default case statement. I don't think this change is observable.

(WebCore::HTMLTreeBuilder::insertComment):

  • Eliminate one unnecessary ref/deref pair.

(WebCore::HTMLTreeBuilder::insertSelfClosingElement):

  • When we insert self-closing elements, there's no reason to push them onto the stack of open elements just to pop them off again. This change saves a malloc/free pair as well as a ref/deref pair. Go team.
  • html/HTMLTreeBuilder.h:
    • Remove unused function.
3:45 PM Changeset in webkit [61973] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement remaining StartTag processing for InHeadNoscriptMode
​https://bugs.webkit.org/show_bug.cgi?id=41264

The InHeadNoscriptMode processes some start tags "as if" the tree
builder were in the InHeadMode. This is an idiom we'll see more of
later. My approach is this patch is to factor all the logic for
processing start tags in the InHeadMode into a separate function that
can be called from both locations. This seems cleaner than just
splitting out the parts that are actually used by both modes.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::insertSelfClosingElement):
  • html/HTMLTreeBuilder.h:
3:20 PM Changeset in webkit [61972] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for <title> and <style> elements
​https://bugs.webkit.org/show_bug.cgi?id=41263

These elements use the generic RCDATA and RawText algorithms,
respectively.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
3:09 PM Changeset in webkit [61971] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Actually insert Doctype elements
​https://bugs.webkit.org/show_bug.cgi?id=41262

This code is pretty much the same as in the old tree builder.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::publicIdentifier): (WebCore::AtomicHTMLToken::systemIdentifier):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertDoctype):
10:10 AM Changeset in webkit [61970] by commit-queue@webkit.org
  • 5 edits in trunk

2010-06-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: Ignore calls to drawImage() with non-finite parameters
​https://bugs.webkit.org/show_bug.cgi?id=38929

Rebaseline (and unskip for Qt) the now working test.

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • canvas/philip/tests/2d.drawImage.nonfinite-expected.txt:
  • platform/qt/Skipped:

2010-06-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: Ignore calls to drawImage() with non-finite parameters
​https://bugs.webkit.org/show_bug.cgi?id=38929

This also fixes a Qt assert when using the raster graphics system.

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
9:36 AM Changeset in webkit [61969] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-27 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Turn ENABLE(SINGLE_THREADED) on.
​https://bugs.webkit.org/show_bug.cgi?id=41135

Brew MP does not support preemptive multi-threading.
Disable threading for Brew MP.

  • wtf/Platform.h:
7:14 AM Changeset in webkit [61968] by commit-queue@webkit.org
  • 4 edits in trunk

2010-06-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
​https://bugs.webkit.org/show_bug.cgi?id=41025

Unskip editing/execCommand/copy-without-selection.html for Qt.

  • platform/qt/Skipped:

2010-06-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
​https://bugs.webkit.org/show_bug.cgi?id=41025

The problem was that when getting data back via Clipboard::getData(),
the String::String(const char*, int) constructor was called
with UTF-16 data.

The solution is to use QMimeData's text() and setText() for "text/plain".

setText() which makes sure Qt passes the string in proper format to the
system clipboard. (The previous implementation would convert it to UTF-8)

text() makes sure that the correct encoding is used (UTF-16) and that
we get back whatever we originally put in there.

  • platform/qt/ClipboardQt.cpp: (WebCore::isTextMimeType): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData):
3:05 AM Changeset in webkit [61967] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-27 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed, mark fast/js/Object-create.html as crashing on Cr Linux, will look into it.

  • platform/chromium/test_expectations.txt:
1:38 AM Changeset in webkit [61966] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder should be able to execute inline scripts
​https://bugs.webkit.org/show_bug.cgi?id=41257

This patch implements enough machinery so that we can execute inline
scripts in extremely simple documents such as the following:

<html>
<script>
alert(1);
</script>

To get this to work, I had to flesh out a surprising amount of the data
structures for processing the <head>. No tests because this is
already covered by most LayoutTests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementRecord::ElementRecord): (WebCore::HTMLTreeBuilder::ElementRecord::element): (WebCore::HTMLTreeBuilder::ElementRecord::next): (WebCore::HTMLTreeBuilder::ElementRecord::releaseNext): (WebCore::HTMLTreeBuilder::ElementRecord::setNext): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::top): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::currentElement):

Jun 26, 2010:

11:45 PM Changeset in webkit [61965] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[Qt] Prospective build fix for MSVC

In order for the forward declaration of QWebScriptWorldPrivate
to work with QExplicitlySharedDataPointer, then copy constructor
and assignment operators must not be compiler generated, to
avoid them ending up in places where the private class is not
declared.

  • Api/qwebscriptworld.cpp:

(QWebScriptWorld::QWebScriptWorld):
(QWebScriptWorld::operator=):

  • Api/qwebscriptworld.h:
3:59 PM Changeset in webkit [61964] by beidson@apple.com
  • 14 edits
    3 adds in trunk/WebCore

beforeProcess event needs to fire before inline scripts/stylesheets take effect
<rdar://problem/8084335> and ​https://bugs.webkit.org/show_bug.cgi?id=40484

Reviewed by Darin Adler.

This patch adds the Event, the onBeforeProcess attribute, and hooks the attribute up in a few places.
Besides that, no change in behavior.

Layout tests will come with the actual implementations as a followup to this patch.

Project file nonsense:

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Scaffolding for the event itself:

  • dom/BeforeProcessEvent.cpp: Added.

(WebCore::BeforeProcessEvent::text):
(WebCore::BeforeProcessEvent::setText):

  • dom/BeforeProcessEvent.h: Added.

(WebCore::BeforeProcessEvent::create):
(WebCore::BeforeProcessEvent::initBeforeProcessEvent):
(WebCore::BeforeProcessEvent::BeforeProcessEvent):

  • dom/BeforeProcessEvent.idl: Added.
  • dom/EventNames.h:

Respect the onBeforeProcess attribute:

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseMappedAttribute):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseMappedAttribute):

2:12 PM Changeset in webkit [61963] by Darin Adler
  • 8 edits in trunk/WebCore

Try to fix Chromium build by adding back function used only by Chromium WebKit.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultChecked): Added back.

  • html/HTMLInputElement.h: Added defaultChecked function.
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::httpEquiv): Added back.

  • html/HTMLMetaElement.h: Added httpEquiv function.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::defaultSelected): Added back.

  • html/HTMLOptionElement.h: Added defaultSelected function.
  • rendering/style/StyleRareNonInheritedData.h: Fixed incorrect struct vs. class

here as seen in warnings on Chromium Windows bot.

1:57 PM Changeset in webkit [61962] by Darin Adler
  • 3 edits in trunk/WebCore

Try to fix Windows build by adding back function used only by Windows WebKit.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::label): Added back.

  • html/HTMLOptionElement.h: Added label function.
1:54 PM Changeset in webkit [61961] by Darin Adler
  • 3 edits in trunk/WebCore

Try to fix Qt build by adding back function used only by Qt WebKit.

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content): Added back.

  • html/HTMLMetaElement.h: Added content function.
1:48 PM Changeset in webkit [61960] by Darin Adler
  • 2 edits in trunk/WebCore
  • html/HTMLFormElement.h: Removed stray character that got in here before landing.
1:42 PM Changeset in webkit [61959] by Darin Adler
  • 99 edits in trunk/WebCore

2010-06-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add more use of reflection, remove unused functions
​https://bugs.webkit.org/show_bug.cgi?id=41255

Also noticed that HTMLDirectoryElement was missing its create function
and added that so the element will get the correct class.

  • html/HTMLBaseFontElement.idl: Use reflection for the size attribute in the Objective-C code path too.
  • html/HTMLSelectElement.idl: Use reflection for disabled and autofocus attributes. Also removed spaces and indenting to match other IDL files.
  • html/HTMLStyleElement.idl: Use reflection for disabled attribute.
  • html/HTMLTableCellElement.idl: Use reflection for noWrap attribute.
  • html/HTMLTextAreaElement.idl: Use reflection for disabled, autofocus, readOnly, and required attributes.
  • html/HTMLUListElement.idl: Use reflection for compact attribute.
  • html/HTMLDirectoryElement.cpp: (WebCore::HTMLDirectoryElement::HTMLDirectoryElement): Made inline. (WebCore::HTMLDirectoryElement::create): Added.
  • html/HTMLDirectoryElement.h: Added create, made constructor private, removed unused functions.
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::parseMappedAttribute): Removed code to set unused m_media data member.
  • html/HTMLStyleElement.h: Removed unused functions and m_media data member. Also made some functions private.
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.cpp:
  • html/HTMLAreaElement.h:
  • html/HTMLBaseFontElement.cpp:
  • html/HTMLBaseFontElement.h:
  • html/HTMLButtonElement.cpp:
  • html/HTMLButtonElement.h:
  • html/HTMLDListElement.cpp:
  • html/HTMLDListElement.h:
  • html/HTMLDivElement.cpp:
  • html/HTMLDivElement.h:
  • html/HTMLFontElement.cpp:
  • html/HTMLFontElement.h:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp: Also removed an incorrect FIXME comment here after I did a little research to disprove it.
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:
  • html/HTMLHRElement.h:
  • html/HTMLHeadElement.cpp:
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.cpp:
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLHtmlElement.h:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp:
  • html/HTMLIsIndexElement.h:
  • html/HTMLLIElement.cpp:
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.cpp:
  • html/HTMLMapElement.h:
  • html/HTMLMenuElement.cpp:
  • html/HTMLMenuElement.h:
  • html/HTMLMetaElement.cpp:
  • html/HTMLMetaElement.h:
  • html/HTMLModElement.cpp:
  • html/HTMLModElement.h:
  • html/HTMLOListElement.cpp:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionElement.h:
  • html/HTMLParagraphElement.cpp:
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.cpp:
  • html/HTMLParamElement.h:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:
  • html/HTMLPreElement.h:
  • html/HTMLQuoteElement.cpp:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • html/HTMLTableCaptionElement.cpp:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp:
  • html/HTMLTableRowElement.h:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextAreaElement.h:
  • html/HTMLUListElement.cpp:
  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:
  • html/HTMLVideoElement.h: Removed unused functions.
11:42 AM Changeset in webkit [61958] by mnaganov@chromium.org
  • 4 edits in trunk/LayoutTests

2010-06-26 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed text expectations update.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/html5lib/runner-expected.txt:
10:23 AM Changeset in webkit [61957] by commit-queue@webkit.org
  • 4 edits
    5 deletes in trunk/WebKit/chromium

2010-06-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61943.
​http://trac.webkit.org/changeset/61943
​https://bugs.webkit.org/show_bug.cgi?id=41251

Totally breaks webkit_unit_tests on Chromium linux and mac
(Requested by mnaganov on #webkit).

  • WebKit.gyp:
  • src/WebFrameImpl.cpp: (WebKit::frameContentAsPlainText):
  • tests/RunAllTests.cpp: (main):
  • tests/WebFrameTest.cpp: Removed.
  • tests/data/iframes_test.html: Removed.
  • tests/data/invisible_iframe.html: Removed.
  • tests/data/visible_iframe.html: Removed.
  • tests/data/zero_sized_iframe.html: Removed.
9:49 AM Changeset in webkit [61956] by tonyg@chromium.org
  • 7 edits in trunk

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Add a document.write to script-line-number test to ensure its new lines are excluded.
​https://bugs.webkit.org/show_bug.cgi?id=41060

  • fast/js/script-line-number-expected.txt:
  • fast/js/script-line-number.html:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Exclude line numbers for sources which are not from the network.
​https://bugs.webkit.org/show_bug.cgi?id=41060

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::write):
7:18 AM Changeset in webkit [61955] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed complementary fix for r61818. It added StaticHashSetListNode.cpp|h to the system,
but did not added it to chromium build system.

  • WebCore.gypi:
6:25 AM Changeset in webkit [61954] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-06-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ScripsPanel.prototype.editScriptSource uses old addBreakpoint signature.

​https://bugs.webkit.org/show_bug.cgi?id=41247

  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.removeBreakpoint): (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.set condition):
  • inspector/front-end/Object.js: (WebInspector.Object.prototype.addEventListener): (WebInspector.Object.prototype.removeEventListener): (WebInspector.Object.prototype.removeAllListeners):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource):
3:52 AM Changeset in webkit [61953] by robert@webkit.org
  • 10 edits in trunk

2010-06-26 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Support for setCustomPolicyDelegate

​https://bugs.webkit.org/show_bug.cgi?id=39564

Unskips:

LayoutTests/fast/loader/policy-delegate-action-hit-test-zoomed.html
LayoutTests/fast/loader/onload-policy-ignore-for-frame.html
LayoutTests/fast/loader/reload-policy-delegate.html
LayoutTests/fast/loader/javascript-url-hierarchical-execution.html
LayoutTests/http/tests/misc/policy-delegate-called-twice.html

  • platform/qt/Skipped:

2010-06-26 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Support for setCustomPolicyDelegate

​https://bugs.webkit.org/show_bug.cgi?id=39564

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setCustomPolicyDelegate):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::navigationTypeToString): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Support for setCustomPolicyDelegate

​https://bugs.webkit.org/show_bug.cgi?id=39564

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setCustomPolicyDelegate):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:16 AM WebKit Team edited by andreas.kling@nokia.com
(diff)
3:10 AM Changeset in webkit [61952] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-26 Robert Hogan <​robert@webkit.org>

Unreviewed, Qt build fix following ​http://trac.webkit.org/changeset/61879

Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
exported.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2:10 AM Changeset in webkit [61951] by mnaganov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-06-26 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed text expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:49 AM Changeset in webkit [61950] by tonyg@chromium.org
  • 29 edits
    6 adds in trunk

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add an --enable-web-timing flag which guards Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

This flag is disabled by default.
See: ​http://dev.w3.org/2006/webapi/WebTiming/

  • configure.ac:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • Configurations/FeatureDefines.xcconfig:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add a guarded window.performance.timing binding which is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=38924

This is where Web Timing support will be implemented. Web Timing is a
draft spec for exposing load times to web pages. It will be enabled
once the spec and implementaiton are solidified. See:
​http://dev.w3.org/2006/webapi/WebTiming/

No new tests because guarded behind a #DEFINE. Will add tests as
functionality is landed.

  • Android.mk:
  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::performance):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalPerformance):
  • page/DOMWindow.idl:
  • page/NavigationTiming.cpp: Added. (WebCore::NavigationTiming::NavigationTiming): (WebCore::NavigationTiming::frame): (WebCore::NavigationTiming::disconnectFrame): (WebCore::NavigationTiming::navigationStart):
  • page/NavigationTiming.h: Added. (WebCore::NavigationTiming::create):
  • page/NavigationTiming.idl: Added.
  • page/Performance.cpp: Added. (WebCore::Performance::Performance): (WebCore::Performance::frame): (WebCore::Performance::disconnectFrame): (WebCore::Performance::timing):
  • page/Performance.h: Added. (WebCore::Performance::create):
  • page/Performance.idl: Added.

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Disable Web Timing support by default for chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • features.gypi:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • Configurations/FeatureDefines.xcconfig:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • Configurations/FeatureDefines.xcconfig:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add a VS macro for enabling Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • win/tools/vsprops/FeatureDefines.vsprops:

2010-06-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add a build-webkit option for enabling Web Timing support.
​https://bugs.webkit.org/show_bug.cgi?id=38924

  • Scripts/build-webkit:
12:10 AM Changeset in webkit [61949] by zmo@google.com
  • 3 edits
    2 adds in trunk

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

activeTexture wrongly generates error with legal input.
​https://bugs.webkit.org/show_bug.cgi?id=41227

  • fast/canvas/webgl/texture-active-bind-expected.txt: Added.
  • fast/canvas/webgl/texture-active-bind.html: Added.

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

activeTexture wrongly generates error with legal input.
​https://bugs.webkit.org/show_bug.cgi?id=41227

Test: fast/canvas/webgl/texture-active-bind.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::activeTexture): Fix the upper limit test for test units.
Note: See TracTimeline for information about the timeline view.