Timeline
Jun 28, 2010:
- 11:55 PM Changeset in webkit [62091] by
-
- 4 edits3 deletes in trunk
2010-06-28 Adam Barth <abarth@webkit.org>
Unreviewed.
Removed webkit-runner.html now that the HTML5 tree builder can handle
the real version of the test suite. Good times.
- html5lib/runner-expected-html5.txt:
- html5lib/webkit-runner-expected-html5.txt: Removed.
- html5lib/webkit-runner-expected.txt: Removed.
- html5lib/webkit-runner.html: Removed.
2010-06-28 Adam Barth <abarth@webkit.org>
Unreviewed.
Switch test-html5-parser back to using runner.html.
- Scripts/test-html5-parser:
- 11:48 PM Changeset in webkit [62090] by
-
- 7 edits in trunk
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 tree builder shouldn't ASSERT on HTML5lib test suite
https://bugs.webkit.org/show_bug.cgi?id=41335
Sketch out the EndTag handling for InBodyMode.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::inScope): (WebCore::HTMLTreeBuilder::clearActiveFormatingElementsUpToLastMarker): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 tree builder shouldn't ASSERT on HTML5lib test suite
https://bugs.webkit.org/show_bug.cgi?id=41335
Enable the remainder of the test suite and update expectations.
- html5lib/webkit-runner-expected-html5.txt:
- html5lib/webkit-runner-expected.txt:
- html5lib/webkit-runner.html:
- 11:43 PM Changeset in webkit [62089] by
-
- 2 edits in trunk/WebCore
- rendering/RenderObject.h: Add missing forward declaration.
Reviewed by NOBODY (chromium build fix).
- 11:12 PM Changeset in webkit [62088] by
-
- 2 edits in trunk/LayoutTests
2010-06-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41061
Make the test work on both Mac and Linux.
- fast/events/popup-when-select-change.html:
- 10:46 PM Changeset in webkit [62087] by
-
- 7 edits4 deletes in trunk/LayoutTests
2010-06-28 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
A meter flip issue was resolved by Chromium r51096.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
- platform/chromium/test_expectations.txt:
- 10:05 PM Changeset in webkit [62086] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Unreviewed.
I accidently gave up my ref and tried to dereference a null pointer.
This code is keeping an extra ref that it doesn't need, but that fact
was somewhat hidden before.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::legacyParserAddChild):
- dom/ContainerNode.h:
- 9:42 PM Changeset in webkit [62085] by
-
- 1 edit2 adds in trunk/LayoutTests
These baselines were added for other platforms in http://trac.webkit.org/changeset/62076
Most unfortunately, v8 reports errors on different line numbers than jsc, so chromium
needs a different baseline.
Reviewed by NOBODY (test expectations update for chromium).
- platform/chromium-mac/html5lib/webkit-runner-expected.txt: Added.
- platform/chromium-win/html5lib/webkit-runner-expected.txt: Added.
- 9:37 PM Changeset in webkit [62084] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Unreviewed.
Refactor common code into addChildCommon
https://bugs.webkit.org/show_bug.cgi?id=41326
Eric asked that we share the common code between these codepaths.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::addChild):
- dom/ContainerNode.h:
- 9:37 PM Changeset in webkit [62083] by
-
- 5 edits54 adds in trunk/LayoutTests
Updated expectations due to tests whose results changed after http://trac.webkit.org/changeset/62035.
Looking at the various results, they appear fine.
Reviewed by NOBODY (test expectations update for WebKit change).
- platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-radius-constraints-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Added.
- platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
- platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
- platform/chromium-mac/fast/forms/basic-selects-expected.checksum: Added.
- platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-clip-expected.checksum: Added.
- platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum: Added.
- platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum: Added.
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum: Added.
- platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum: Added.
- platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Added.
- platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
- platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
- platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Added.
- platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
- 9:31 PM Changeset in webkit [62082] by
-
- 3 edits in trunk/WebCore
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTMLTreeBuilder::reconstructTheActiveFormattingElements
https://bugs.webkit.org/show_bug.cgi?id=41319
Restructure the code to not use in-band data, which is what
got us in trouble with a signed/unsigned mismatch before.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
- html/HTMLTreeBuilder.h:
- 8:55 PM Changeset in webkit [62081] by
-
- 2 edits in trunk/WebCore
2010-06-28 Daniel Bates <dbates@rim.com>
Unreviewed, attempt to fix Qt bots.
Attempt to fix the build after changeset 62079 <http://trac.webkit.org/changeset/62079>
(https://bugs.webkit.org/show_bug.cgi?id=41324).
Rename some more call sites that were missed in the initial landing.
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
- 8:33 PM Changeset in webkit [62080] by
-
- 3 edits in trunk/WebCore
2010-06-28 Daniel Bates <dbates@rim.com>
Unreviewed, build fix.
Change return type of method HTMLTreeBuilder::reconstructTheActiveFormattingElements()
from int to unsigned.
Attempt to fix the build after changeset 62077 <https://trac.webkit.org/changeset/62077>
(https://bugs.webkit.org/show_bug.cgi?id=41319).
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::indexOfLastOpenFormattingElementOrMarker): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
- html/HTMLTreeBuilder.h:
- 8:25 PM Changeset in webkit [62079] by
-
- 20 edits in trunk/WebCore
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only intended use
https://bugs.webkit.org/show_bug.cgi?id=41324
A bunch of places in the code were calling ContainerNode::addChild.
I don't think they actually want to be doing that, as it has special
form-related handling which is part of LegacyHTMLTreeBuilder.
No functional changes, thus no tests.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::legacyParserAddChild):
- dom/ContainerNode.h:
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- dom/Node.cpp: (WebCore::Node::legacyParserAddChild):
- dom/Node.h:
- html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::legacyParserAddChild):
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::legacyParserAddChild):
- html/HTMLTableRowElement.h:
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::legacyParserAddChild):
- html/HTMLTableSectionElement.h:
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
- 8:04 PM Changeset in webkit [62078] by
-
- 6 edits in trunk/JavaScriptCore
2010-06-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QScriptEngine API should contain a newArray function
https://bugs.webkit.org/show_bug.cgi?id=39115
- qt/api/qscriptengine.cpp: (QScriptEngine::newArray):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::newArray):
- qt/api/qscriptengine_p.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newArray):
- 7:52 PM Changeset in webkit [62077] by
-
- 3 edits in trunk/WebCore
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTMLTreeBuilder::reconstructTheActiveFormattingElements
https://bugs.webkit.org/show_bug.cgi?id=41319
This is basically a direct transcription of HTML5 TreeBuilder spec:
This code is covered by various tests in html5lib/runner which we
can't run yet due to other asserts. Adam and I are working on
getting rid of those ASSERTS so that this (and other code) will
be better tested shortly.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertFormatingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::contains): (WebCore::HTMLTreeBuilder::FormatingElementEntry::FormatingElementEntry): (WebCore::HTMLTreeBuilder::FormatingElementEntry::): (WebCore::HTMLTreeBuilder::FormatingElementEntry::isMarker): (WebCore::HTMLTreeBuilder::FormatingElementEntry::element): (WebCore::HTMLTreeBuilder::FormatingElementEntry::replaceElement):
- 7:00 PM Changeset in webkit [62076] by
-
- 9 edits1 add in trunk
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix ASSERT so we can run more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=41325
Uncomment <title> tag that was triggering ASSERT.
Uncomment test groups that were triggering ASSERTs.
Update expected results to show how many more tests we have left to
fix. :)
- html5lib/webkit-runner-expected-html5.txt:
- html5lib/webkit-runner.html:
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix ASSERT so we can run more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=41325
We can't call Node::addChild because that function contains a bunch of
logic from the old parser. Instead, this patch creates a new version
of addChild that's does less validating (that's the tree builder's
job).
- dom/ContainerNode.cpp: (WebCore::ContainerNode::parserAddChild):
- dom/ContainerNode.h:
- dom/Node.cpp: (WebCore::Node::parserAddChild):
- dom/Node.h:
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
- 6:36 PM Changeset in webkit [62075] by
-
- 5 edits in branches/safari-533.17-branch
Versioning.
- 6:35 PM Changeset in webkit [62074] by
-
- 1 copy in tags/Safari-533.17
New tag.
- 6:13 PM Changeset in webkit [62073] by
-
- 2 edits in trunk/WebCore
- bindings/v8/ScriptEventListener.h: Changed forward declaration to correspond to the code change doing in r62052.
Reviewed by NOBODY (chromium build fix).
- 6:04 PM Changeset in webkit [62072] by
-
- 3 edits2 adds in branches/safari-533.17-branch
Merge r61045.
- 6:04 PM Changeset in webkit [62071] by
-
- 5 edits in branches/safari-533.17-branch
Merge r61750.
- 6:04 PM Changeset in webkit [62070] by
-
- 4 edits in branches/safari-533.17-branch
Merge r61450.
- 6:04 PM Changeset in webkit [62069] by
-
- 3 edits3 adds in branches/safari-533.17-branch
Merge r60990.
- 5:52 PM Changeset in webkit [62068] by
-
- 1 edit6 adds in branches/safari-533.17-branch/LayoutTests
Merge r59146.
- 5:52 PM Changeset in webkit [62067] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Merge r59143.
- 5:51 PM Changeset in webkit [62066] by
-
- 2 edits in branches/safari-533.17-branch/LayoutTests
Merge r59142.
- 5:51 PM Changeset in webkit [62065] by
-
- 3 edits in branches/safari-533.17-branch/LayoutTests
Merge r59141.
- 5:51 PM Changeset in webkit [62064] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Merge r59140.
- 5:51 PM Changeset in webkit [62063] by
-
- 3 edits in branches/safari-533.17-branch/LayoutTests
Merge r59139.
- 5:51 PM Changeset in webkit [62062] by
-
- 2 edits in branches/safari-533.17-branch/WebKit/mac
Merge r59138.
- 5:51 PM Changeset in webkit [62061] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Merge r59137.
- 5:51 PM Changeset in webkit [62060] by
-
- 16 edits3 copies4 adds1 delete in branches/safari-533.17-branch
Merge r59136.
- 5:51 PM Changeset in webkit [62059] by
-
- 4 edits in branches/safari-533.17-branch/WebCore
Merge r59134.
- 5:51 PM Changeset in webkit [62058] by
-
- 3 edits in branches/safari-533.17-branch/WebCore
Merge r59133.
- 5:51 PM Changeset in webkit [62057] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Merge r59132.
- 5:51 PM Changeset in webkit [62056] by
-
- 5 edits in branches/safari-533.17-branch/LayoutTests
Merge r59131.
- 5:50 PM Changeset in webkit [62055] by
-
- 1 edit1 copy1 move11 adds1 delete in branches/safari-533.17-branch/LayoutTests
Merge r59130.
- 5:50 PM Changeset in webkit [62054] by
-
- 5 edits in branches/safari-533.17-branch/WebCore
Merge r59129.
- 5:47 PM Changeset in webkit [62053] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Install jsc as jsc-X where X is the major API version to allow
parallel installation of both GTK+ 2.x and 3.x versions.
- GNUmakefile.am:
- 5:38 PM Changeset in webkit [62052] by
-
- 8 edits in trunk/WebCore
Support for https://bugs.webkit.org/show_bug.cgi?id=40484
Reviewed by Alexey Proskuryakov.
In working on adding beforeProcess, it becomes necessary for JSLazyEventListeners to always know what their
original Node* was, even if it was a window event listener.
For HTMLFrameSet, HTMLBody, and SVGSVG elements, a second form of createAttributeEventListener was used that
took a Frame* argument and didn't set the original Node* on the JSLazyEventListener.
This patch changes that form of the function to createWindowAttributeEventListener, and passes the Node* along
for later use by the beforeProcess mechanism.
No new tests. (No change in behavior)
- bindings/js/ScriptEventListener.cpp:
(WebCore::createWindowAttributeEventListener): Renamed from createAttributeEventListener, takes a Node* instead
of a Frame*, and figures out the Frame* itself internally.
- bindings/js/ScriptEventListener.h:
- bindings/v8/ScriptEventListener.cpp:
(WebCore::createWindowAttributeEventListener): Renamed from createAttributeEventListener, takes a Node* instead
of a Frame*, and figures out the Frame* itself internally. Note that V8LazyEventListener doesn't allow us to
pass the Element* argument in so this beforeprocess feature won't fully work on V8 builds until this is changed.
- bindings/v8/ScriptEventListener.h:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute): Use createWindowAttributeEventListener instead.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute): Ditto.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute): Ditto. Also add some missing copyright dates that
svn logproves
should be there.
- 5:23 PM Changeset in webkit [62051] by
-
- 3 edits2 adds in trunk
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Restore webkit-runner.html for use with new tree builder
https://bugs.webkit.org/show_bug.cgi?id=41317
webkit-runner.html is very similar to runner.html, but it avoids some
tricky cases that are causing asserts. Using this simplified harness
will help us bring up the tree builder. We can remove it once we're up
to speed.
- html5lib/webkit-runner-expected-html5.txt: Added.
- html5lib/webkit-runner.html: Added.
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Restore webkit-runner.html for use with new tree builder
https://bugs.webkit.org/show_bug.cgi?id=41317
For now, we just want to run webkit-runner when we test-html5-parser.
- Scripts/test-html5-parser:
- 5:02 PM Changeset in webkit [62050] by
-
- 2 edits in trunk/WebKit2
2010-06-28 John Gregg <johnnyg@google.com>
Unreviewed, build fix (removing merge conflict from previous).
- Configurations/FeatureDefines.xcconfig:
- 4:53 PM Changeset in webkit [62049] by
-
- 19 edits in trunk
2010-06-28 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- Configurations/FeatureDefines.xcconfig:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- features.gypi:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- Configurations/FeatureDefines.xcconfig:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
2010-06-28 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- configure.ac:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- Scripts/build-webkit:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
- Configurations/FeatureDefines.xcconfig:
- 4:29 PM Changeset in webkit [62048] by
-
- 2 edits in trunk/WebKitTools
2010-06-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Xan Lopez.
Update webkitdirs's knowledge of our library's name.
- Scripts/webkitdirs.pm:
- 4:11 PM Changeset in webkit [62047] by
-
- 2 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't use the new tree builder for fragments
https://bugs.webkit.org/show_bug.cgi?id=41316
We need to walk before we can run. After this change, we can run the
runner.html tests (with the ASSERT caveat).
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- 3:59 PM Changeset in webkit [62046] by
-
- 6 edits in trunk/LayoutTests
2010-06-28 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Update baselines after r62034.
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 3:56 PM Changeset in webkit [62045] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The new tree builder should actually finish building the tree
https://bugs.webkit.org/show_bug.cgi?id=41314
Again, this patch makes progress on runner.html, but I haven't removed
the ASSERT yet.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::finished):
- html/HTMLTreeBuilder.h:
- 3:46 PM Changeset in webkit [62044] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Revert to build jsc, since the tests expect this.
- GNUmakefile.am:
- 3:36 PM Changeset in webkit [62043] by
-
- 3 edits in trunk/WebCore
Fix a race condition that can happen when using DBs in workers.
https://bugs.webkit.org/show_bug.cgi?id=41105
Reviewed by Eric Seidel.
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
- storage/DatabaseTracker.h:
- 3:24 PM Changeset in webkit [62042] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add text nodes to the DOM
https://bugs.webkit.org/show_bug.cgi?id=41306
Actually add some text nodes to the DOM when parsing a document. We're
going to need to do something fancier here eventually, but this gets us
past the error we're seeing currently in runner.html.
Unfortunately, this patch "regresses" runner.html in the sense that we
now hit an assert, but it's still an improvement... I'll update the
HTML5 expectations once we get past the assert.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertTextNode):
- html/HTMLTreeBuilder.h:
- 3:00 PM Changeset in webkit [62041] by
-
- 1 copy in branches/safari-533.17-branch
New branch.
- 2:56 PM Changeset in webkit [62040] by
-
- 2 edits in trunk/WebCore
Build fix for non-PATH_BASED_BORDER_RADIUS_DRAWING platforms.
- rendering/RenderBoxModelObject.cpp:
- 2:50 PM Changeset in webkit [62039] by
-
- 10 edits1 delete in trunk/WebKit/chromium
2010-06-28 Zhe Su <suzhe@chromium.org>
Reviewed by Jian Li.
[chromium]Remove deprecated code related to input method.
https://bugs.webkit.org/show_bug.cgi?id=41244
Also update TestWebWidget in tests/PopupMenuTest.cpp to add missing implementations.
- WebKit.gyp:
- public/WebCompositionCommand.h: Removed.
- public/WebViewClient.h:
- public/WebWidget.h:
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- tests/PopupMenuTest.cpp: (WebKit::TestWebWidget::setComposition): (WebKit::TestWebWidget::confirmComposition): (WebKit::TestWebWidget::textInputType): (WebKit::TestWebWidget::caretOrSelectionBounds):
- 2:39 PM Changeset in webkit [62038] by
-
- 2 edits in trunk/WebKit/qt
2010-06-28 Laszlo Gombos <Laszlo Gombos>
Unreviewed Symbian build fix.
[Qt] Update the def file after r61879.
- symbian/eabi/QtWebKitu.def:
- 2:24 PM Changeset in webkit [62037] by
-
- 4 edits in trunk
2010-06-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use HTML5-conformant gradient interpolation mode
https://bugs.webkit.org/show_bug.cgi?id=41298
Unskip now working test:
- canvas/philip/tests/2d.gradient.interpolate.colouralpha.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors-and-styles
- platform/qt/Skipped:
2010-06-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use HTML5-conformant gradient interpolation mode
https://bugs.webkit.org/show_bug.cgi?id=41298
Change the Qt Gradient implementation to use ComponentInterpolation mode.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors-and-styles
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- 2:07 PM Changeset in webkit [62036] by
-
- 6 edits in trunk/WebKit/chromium
2010-06-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Get the selected text from plugins for right click menu
https://bugs.webkit.org/show_bug.cgi?id=41242
- public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
- public/WebPlugin.h: (WebKit::WebPlugin::selectedText):
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::selectedText):
- src/WebPluginContainerImpl.h:
- 1:53 PM Changeset in webkit [62035] by
-
- 32 edits in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=9197 CSS3: Borders
with border-radius and double, groove, or ridge styles should look
better
Reviewed by Sam Weinig.
This patch re-works border radius painting to stroke paths instead
of arcs.
Added new function clipConvexPolygon(). Added static
addConvexPolygonToContext so that code can be shared between
drawConvexPolygon() and clipConvexPolygon().
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::addConvexPolygonToContext):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
Shells of implementations on non-CG platforms.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
This new helper function determines if the inner corners of the
border will arch in or meet at a right angle.
- rendering/RenderBoxModelObject.cpp:
(WebCore::borderWillArcInnerEdge):
This function is re-written so that, for each side of the border,
if borderWillArcInnerEdge() is true, we go down a brand new code
path of clipping to a convex polygon for the border side and then
we paint the side using the new function drawBoxSideFromPath(). If
borderWillArcInnerEdge() is false, then we call into the old
familiar drawLineForBoxSide() which relies on the rounder clip
rects we have set up to arch the outer edge of the border.
(WebCore::RenderBoxModelObject::paintBorder):
This new function does the math to figure out the convex polygon
to clip to in the case where we need to arch the inner edge of the
border. This calls into a new GraphicsContext function that is only
implemented on CG at this time. This is the reason we are keeping
around an old version of paintBorder() for now.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
- rendering/RenderBoxModelObject.h:
borderInnerRect() is a new convenience function called from
RenderObject and RenderBoxModelObject to determine the rect of the
inside edge of the border.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::borderInnerRect):
This new function re-works drawArcForBoxSide to draw from Paths
when appropriate instead of stroking arcs.
(WebCore::RenderObject::drawBoxSideFromPath):
Keep this around for that do not HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until
GraphicsContext::clipConvexPolygon() is implemented.
(WebCore::RenderObject::drawArcForBoxSide):
- rendering/RenderObject.h:
New function
RenderStyle::getInnerBorderRadiiForRectWithBorderWidths() gets the
inner radius values for a rect. It takes border widths a parameters
rather than using the style's border widths so that it can be used
in inner radius calculations for double and groove/ridge
calculations. The W3C corner constraining rules were moved to a
static function that can be called from both getBorderRadiiForRect
() and getInnerBorderRadiiForRectWithBorderWidths().
- rendering/style/RenderStyle.cpp:
(WebCore::constrainCornerRadiiForRect):
(WebCore::RenderStyle::getBorderRadiiForRect):
(WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
- rendering/style/RenderStyle.h:
LayoutTests: Tests with new results after
https://bugs.webkit.org/show_bug.cgi?id=9197 CSS3: Borders
with border-radius and double, groove, or ridge styles should look
better
Reviewed by Sam Weinig.
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed02-expected.png:
- platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed03-expected.png:
- platform/mac/fast/borders/borderRadiusDotted01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted01-expected.png:
- platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble01-expected.png:
- 1:43 PM Changeset in webkit [62034] by
-
- 8 edits3 adds in trunk
[GTK] Add support for the progress bar tag
https://bugs.webkit.org/show_bug.cgi?id=41014
Reviewed by Xan Lopez.
WebCore:
Add support for rendering the progress tag for WebKit GTK+.
- GNUmakefile.am:
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):
Added. Currently progress bar animations are disabled. As it looks like
there may not be a good way to support this with Mozilla's theme drawing code.
(WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto.
(WebCore::RenderThemeGtk::adjustProgressBarStyle): Added.
(WebCore::RenderThemeGtk::paintProgressBar): Added.
- platform/gtk/RenderThemeGtk.h: Add declarations for new methods.
- platform/gtk/gtk2drawing.c:
(moz_gtk_get_progress_widget): Expose the progress widget so that the chunk can be positioned properly.
- platform/gtk/gtkdrawing.h: Added declaration for moz_gtk_get_progress_widget.
LayoutTests:
Unskip tests which are now passing after adding support for rendering the progress tag.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt.
- platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
- 1:30 PM Changeset in webkit [62033] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 Regression: Crash in insert()
https://bugs.webkit.org/show_bug.cgi?id=41281
We need to call endIfDelayed() outside of the script nesting block
because endIfDelayed() might call end(), which deletes the
HTMLDocumentParser. If we try to exit the script nesting block after
the HTMLDocumentParser has been deleted, we'll decrement unallocated
memory, which is bad times.
Moving endIfDelayed outside of the script nesting block also lets us
avoid ending if inWrite() is true. If we're inWrite(), then there's
folks above us on the stack who will crash of the HTMLDocumentParser is
deallocated. Adding this check matches the LegacyHTMLDocumentParser
and the logic in attemptToEnd, facilitating a small refactoring of the
common logic for improved readability.
I don't know of any test case that changes in behavior because of this
patch, but this bug exists on the same line of code that the reliablity
tests crashed. I'm not sure whether this patch will fix that crash,
but removing bugs (even theoretical ones) seems like a good idea.
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::shouldDelayEnd):
- 1:22 PM Changeset in webkit [62032] by
-
- 6 edits in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
Build up WebKitTestRunner output in the InjectedBundle
Reviewed by Anders Carlsson.
Simplify WebKitTestRunner by building up the output in the InjectedBundle
and sending it over postMessage when done, instead of using the async
WKPageRenderTreeExternalRepresentation.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::didRecieveMessage):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::os):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::WKStringToUTF8):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::WKStringToUTF8):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
- 1:17 PM Changeset in webkit [62031] by
-
- 3 edits in trunk/JavaScriptCore
Only one character lookahead should be enough for the lexer
https://bugs.webkit.org/show_bug.cgi?id=41213
Reviewed by Oliver Hunt.
The lexer had 4 character lookahead before, which required
a complex shifting mechanism. This can be improved by using
only one character lookahead for most decisions, and a
peek() function as a fallback when it is absolutely necessary.
- parser/Lexer.cpp:
(JSC::Lexer::currentCharacter):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setCode):
(JSC::Lexer::shift):
(JSC::Lexer::peek):
(JSC::Lexer::getUnicodeCharacter):
(JSC::Lexer::shiftLineTerminator):
(JSC::Lexer::lastTokenWasRestrKeyword):
(JSC::Lexer::lex):
(JSC::Lexer::scanRegExp):
(JSC::Lexer::skipRegExp):
- parser/Lexer.h:
- 1:10 PM Changeset in webkit [62030] by
-
- 2 edits in trunk/WebCore
2010-06-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
MediaPlayerPrivate::getSupportedTypes does not return "modern" MIME types
https://bugs.webkit.org/show_bug.cgi?id=41287
<rdar://problem/8137402>
No new test because getSupportedTypes is used privately by MediaPlayer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::getSupportedTypes): Build hash set with both common and modern types.
- 1:08 PM Changeset in webkit [62029] by
-
- 2 edits in trunk/WebCore
2010-06-28 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
REGRESSION(53790): Neopets page with mismatched elements misrenders
https://bugs.webkit.org/show_bug.cgi?id=41181
Misnested formatting tags require fixup in order to create a valid DOM. Because this takes
O(N2) time in some cases, http://trac.webkit.org/changeset/53790 added an iteration limit
of 5 to this algorithm to avoid hangs. This limit is too low for neopets, but a limit of
7 is sufficient. This raises the limit to 10 to have a bit of breathing room. HTML5
defines the fixup algorithm http://www.whatwg.org/specs/web-apps/current-work/#adoptionAgency
but doesn't specify any particular iteration limit.
- html/LegacyHTMLTreeBuilder.cpp:
- 1:05 PM Changeset in webkit [62028] by
-
- 6 edits in trunk
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The new tree builder needs to call attach() on elements it attaches to
the DOM
https://bugs.webkit.org/show_bug.cgi?id=41293
Update expected results to show that the contents of the iframe
actually get created. This only gets us a few lines down the test
harness before erroring out again, but I'll take it.
- html5lib/runner-expected-html5.txt:
- html5lib/webkit-resumer-expected-html5.txt:
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The new tree builder needs to call attach() on elements it attaches to
the DOM
https://bugs.webkit.org/show_bug.cgi?id=41293
Apparently Nodes expect to have their attach() method called when they
are attached to the DOM. The new tree builder is happy to oblige.
Making this call requires some fancy footwork with RefPtr/PassRefPtr to
avoid extra ref churn while keeping each function small.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertCommentOnDocument): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertSelfClosingElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
- 1:01 PM Changeset in webkit [62027] by
-
- 4 edits in trunk
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version to 1.3.2.
- configure.ac:
WebKit/gtk:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.3.2.
- NEWS:
- 12:30 PM Changeset in webkit [62026] by
-
- 2 edits in trunk/WebCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Fix distcheck.
- GNUmakefile.am:
- 12:28 PM Changeset in webkit [62025] by
-
- 2 edits in trunk/WebKit2
Rubber-stamped Geoffrey Garen.
Add WKBundleFrameIsMainFrame to exports file.
- mac/WebKit2.exp:
- 12:24 PM Changeset in webkit [62024] by
-
- 4 edits in trunk
2010-06-28 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r62021.
http://trac.webkit.org/changeset/62021
https://bugs.webkit.org/show_bug.cgi?id=41261
Broke http/navigation tests among other
- platform/qt/Skipped:
2010-06-28 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r62021.
http://trac.webkit.org/changeset/62021
https://bugs.webkit.org/show_bug.cgi?id=41261
Broke http/navigation tests among other
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText):
- 12:22 PM Changeset in webkit [62023] by
-
- 2 edits1 add in trunk/WebKitTools
Add run-webkittestrunner to run WebKitTestRunner with the appropriate
environment.
Reviewed by Anders Carlsson.
- Scripts/run-webkittestrunner: Added.
- Scripts/webkitdirs.pm:
- 12:21 PM Changeset in webkit [62022] by
-
- 2 edits in trunk
2010-06-28 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Bump gobject-introspection required version to 0.6.15, since we
are now shipping version 1.1 gir files.
- configure.ac:
- 12:07 PM Changeset in webkit [62021] by
-
- 4 edits in trunk
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump frames in ascending alphabetical order of title
Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html
- platform/qt/Skipped:
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump frames in ascending alphabetical order of title
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText):
- 11:46 AM Changeset in webkit [62020] by
-
- 5 edits in trunk
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump bf history of child windows
Unskip http/tests/navigation/new-window-redirect-history.html
- platform/qt/Skipped:
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump bf history of child windows
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- 11:32 AM Changeset in webkit [62019] by
-
- 12 edits2 adds in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
WebKit2: Add frame API for InjectedBundle code
Reviewed by Anders Carlsson.
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Added.
(WKBundleFrameIsMainFrame):
(WKBundleFrameGetURL):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetMainFrame):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::isMainFrame):
(WebKit::WebFrame::url):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::mainFrame):
- mac/WebKit2.exp:
- win/WebKit2.vcproj:
WebKitTools:
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame):
- 10:41 AM Changeset in webkit [62018] by
-
- 5 edits2 adds in trunk
2010-06-28 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Index validation caches buffer size information too aggressively
https://bugs.webkit.org/show_bug.cgi?id=41092
Test: fast/canvas/webgl/index-validation-with-resized-buffer.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateRenderingState):
- Compute the number of valid elements each time based on the latched buffer.
(WebCore::WebGLRenderingContext::vertexAttribPointer):
- Do not cache the buffer size, only the attributes used to compute the number of required elements.
- html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
- Ditto.
2010-06-28 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Index validation caches buffer size information too aggressively
https://bugs.webkit.org/show_bug.cgi?id=41092
- fast/canvas/webgl/index-validation-with-resized-buffer-expected.txt: Added.
- fast/canvas/webgl/index-validation-with-resized-buffer.html: Added.
- fast/canvas/webgl/resources/webgl-test.js: (assertMsg): (glErrorShouldBe):
- 10:13 AM Changeset in webkit [62017] by
-
- 2 edits in trunk/WebCore
2010-06-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Replace single treat-as-space characters with normal space
https://bugs.webkit.org/show_bug.cgi?id=41278
This keeps Qt from attempting glyph substitution and loading a bunch
of extra fonts when encountering entities.
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::floatWidthForComplexText):
- 10:00 AM Changeset in webkit [62016] by
-
- 5 edits in trunk/WebCore
2010-06-28 Robin Cao <robin.cao@torchmobile.com.cn>
Reviewed by Dan Bernstein.
canvas fillText with @font-face crashes
https://bugs.webkit.org/show_bug.cgi?id=35486
The font object in CanvasRenderingContext2D may become invalid at some point.
Override recalcStyle() in HTMLCanvasElement, and update the font object from there if needed.
A test already exists: canvas/philip/tests/2d.text.draw.fontface.repeat.html
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::recalcStyle):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::updateFont):
- html/canvas/CanvasRenderingContext2D.h:
- 9:58 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 9:49 AM Writing Layout Tests for DumpRenderTree edited by
- Add example of running make-script-test-wrappers (diff)
- 9:23 AM Changeset in webkit [62015] by
-
- 9 edits in trunk
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.
- wtf/efl/MainThreadEfl.cpp: (WTF::timeoutFired): Return Eina_Bool instead of int.
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.
- efl/EWebLauncher/main.c:
- efl/ewk/ewk_view.cpp: (_ewk_view_zoom_animator_cb): Return Eina_Bool instead of int.
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.
No new functionality, so no new tests.
- platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent): Return Eina_Bool instead of int.
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.
- cmake/FindEFL.cmake: Bump version of Ecore dependency.
- 9:11 AM Changeset in webkit [62014] by
-
- 2 edits in trunk/WebCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Fix build with GTK+ older than 2.18
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect):
- 9:02 AM Changeset in webkit [62013] by
-
- 5 edits in trunk/WebCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Adam Barth.
[GTK] Push NULL context on every DOM bindings entry point
https://bugs.webkit.org/show_bug.cgi?id=39967
Update GObject DOM bindings to push the NULL context on every API
entry point, and update bindings test results.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- 9:01 AM Changeset in webkit [62012] by
-
- 2 edits1 add in trunk/WebCore
2010-06-28 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Adam Roben.
[WinCairo] Text box backgrounds do not render in partially opaque layers
https://bugs.webkit.org/show_bug.cgi?id=41113
Tests:
manual-tests/partially-opaque-text-input.html
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::releaseWindowsContext): When restoring a context which does not support alpha blending, manually set the alpha channel of the HBITMAP to fully opaque. This will effectively ignore the alpha channel of the HBITMAP, which is necessary because GDI drawing functions set the alpha value to be fully transparent (0).
- 9:00 AM Changeset in webkit [62011] by
-
- 2 edits1 add in trunk/WebCore
2010-06-28 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Adam Roben.
[WinCairo] Rendering of themed elements on a layer with opacity produces nothing
https://bugs.webkit.org/show_bug.cgi?id=41111
Tests:
manual-tests/partially-opaque-form-elements.html
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::releaseWindowsContext): Preform a cairo_save() and a cairo_restore() around code modifying the transformation matrix of the Cairo surface. Also set the destination coordinates before adjusting the transformation matrix scale, so that the destination coordinates are not scaled as well.
- 8:47 AM Changeset in webkit [62010] by
-
- 3 edits in trunk
2010-06-28 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayerQt delay seems unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=40846
- compositing/animation/busy-indicator-no.png: Added.
- compositing/animation/busy-indicator.html: Added.
- compositing/animation/busy-indicator.png: Added.
2010-06-28 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayerQt delay seems unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=40846
Test: compositing/animation/busy-indicator.html
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::GraphicsLayerQt::addAnimation):
- 8:35 AM Changeset in webkit [62009] by
-
- 2 edits in trunk/WebKitTools
2010-06-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
https://bugs.webkit.org/show_bug.cgi?id=38597
Fix behavior so reload button really acts as a load and a reload button.
- QtTestBrowser/mainwindow.cpp: (MainWindow::changeLocation):
- 8:31 AM Changeset in webkit [62008] by
-
- 2 edits in trunk/WebKit
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Simplify zoom setting by narrowing with WebCore API.
Instead of creating a zoom_text_only field, use the already defined enum
by WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40993
- efl/ewk/ewk_frame.cpp: sd->zoom_text_only => sd->zoom_mode (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
- 8:19 AM Changeset in webkit [62007] by
-
- 6 edits in trunk/JavaScriptCore
2010-06-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QScriptValue should have API for accessing object properties
https://bugs.webkit.org/show_bug.cgi?id=40903
Make possible to access properties inside QScriptValues. While this
still doesn't support the ResolveLocal parameter, it is already useful
for testing the API.
The tests from upstream QtScript weren't imported since most of them
depend on the setProperty() function as well. A simple test was created.
- qt/api/qscriptvalue.cpp: (QScriptValue::property):
- qt/api/qscriptvalue.h: (QScriptValue::):
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::property):
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::propertySimple):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- 8:08 AM Changeset in webkit [62006] by
-
- 3 edits in trunk/WebKit
2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement download requests
When a download request arrives through FrameLoaderClient, forward it to
browser in order to be possible to download files.
https://bugs.webkit.org/show_bug.cgi?id=40967
- efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::download): get file names and forward to ewk_view_download_request()
- efl/ewk/ewk_private.h: export private function to WebCoreSupport
- 8:05 AM Changeset in webkit [62005] by
-
- 2 edits in trunk/LayoutTests
2010-06-28 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed test expectations update. Remove now passing fast/events/popup-allowed-from-gesture-initiated-form-submit.html
- platform/chromium/test_expectations.txt:
- 7:39 AM Changeset in webkit [62004] by
-
- 4 edits in trunk/WebCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Until now we were adding the event listeners for a given object in
the wrap method, since that's the first moment we have accoss to
the core WebCore object. The problem is that we only install the
listeners that the topmost class in the class hierarchy needs (eg,
HTMLParagrahElement for a P element), when most of the actual
event attributes are defined in the base classes (Node, Element,
...).
To fix this set the core object as a construct/write-only property
on the wrapper GObject, and set the eventlisteners in the cGObject
'construct' method, chaining up through all the class hierarchy
until the end. This way we'll get all the eventlisteners defined
in all the superclasses of our object, which is what we want.
- bindings/gobject/WebKitDOMObject.cpp: (webkit_dom_object_get_property): (webkit_dom_object_set_property): (webkit_dom_object_class_init):
- bindings/scripts/CodeGeneratorGObject.pm:
- dom/Node.idl:
- 7:32 AM Changeset in webkit [62003] by
-
- 2 edits in trunk/WebCore
2010-06-28 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- platform/gtk/RenderThemeGtk.cpp:
- 7:18 AM Changeset in webkit [62002] by
-
- 14 edits in trunk
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Add automake flag to signal whether we are building with GTK+ 2.x
or 3.x.
- configure.ac:
WebCore:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Fix build with GSEAL enabled.
- GNUmakefile.am:
- platform/gtk/GtkVersioning.h:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::systemColor):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformRemoveChild): (WebCore::ScrollView::visibleContentRect):
- platform/gtk/gtk2drawing.c: (ensure_toggle_button_widget): (ensure_combo_box_widgets): (ensure_combo_box_entry_widgets): (ensure_tree_header_cell_widget): (moz_gtk_button_paint): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_trough_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_spin_paint): (moz_gtk_spin_updown_paint): (moz_gtk_scale_paint): (moz_gtk_scale_thumb_paint): (moz_gtk_gripper_paint): (moz_gtk_hpaned_paint): (moz_gtk_vpaned_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_sort_arrow_paint): (moz_gtk_treeview_expander_paint): (moz_gtk_expander_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_container_paint): (moz_gtk_toggle_label_paint): (moz_gtk_toolbar_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_tooltip_paint): (moz_gtk_resizer_paint): (moz_gtk_frame_paint): (moz_gtk_progressbar_paint): (moz_gtk_progress_chunk_paint): (moz_gtk_get_tab_thickness): (moz_gtk_tab_paint): (moz_gtk_tabpanels_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_popup_paint): (moz_gtk_menu_separator_paint): (moz_gtk_menu_item_paint): (moz_gtk_menu_arrow_paint):
WebKit/gtk:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Fix build with GSEAL enabled.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- webkit/webkitsoupauthdialog.c: (show_auth_dialog):
WebKitTools:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Fix build with GSEAL enabled.
- DumpRenderTree/gtk/EventSender.cpp: (gtk_widget_get_window): (prepareMouseButtonEvent): (mouseMoveToCallback): (mouseWheelToCallback): (keyDownCallback):
- 6:58 AM Changeset in webkit [62001] by
-
- 12 edits1 move in trunk
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Add --with-gtk configure flag, defaulting to support for GTK+ 2.x.
- GNUmakefile.am:
- configure.ac:
WebCore:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Adapt build system for 3.x support.
- GNUmakefile.am:
WebKit/gtk:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Adapt build system for 3.x support, allow the JSCore gir and webkit
pc files to be configurable at build time for different API
versions.
- JSCore-1.0.gir: Removed.
- JSCore.gir.in: Added.
- docs/GNUmakefile.am:
- webkit.pc.in:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Suffix jsc with the API version of the library, so that
libwebkitgtk 1.x and 3.x can install jsc.
- GNUmakefile.am:
WebKitTools:
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Adapt build system for 3.x support.
- GNUmakefile.am:
- 6:16 AM Changeset in webkit [62000] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-28 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium debugger tests.
- src/js/Tests.js: (.TestSuite.prototype.testDebugIntrinsicProperties):
- 6:07 AM Changeset in webkit [61999] by
-
- 2 edits in trunk/LayoutTests
2010-06-28 MORITA Hajime <morrita@google.com>
Unreviewd. Skipped a test for qt at this time due to outdated expectation.
We need to rebaseline it.
- platform/qt/Skipped:
- 5:49 AM Changeset in webkit [61998] by
-
- 2 edits in trunk/LayoutTests
2010-06-28 MORITA Hajime <morrita@google.com>
Unreviewed text expectations update after r61993.
- platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- 5:46 AM QtWebKitDocContrib edited by
- (diff)
- 5:36 AM Changeset in webkit [61997] by
-
- 4 edits2 adds in trunk
2010-06-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: properties of scope variables are flattened while on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=41214
- inspector/debugger-proto-property-expected.txt: Added.
- inspector/debugger-proto-property.html: Added.
- platform/qt/Skipped:
2010-06-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: properties of scope variables are flattened while on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=41214
Test: inspector/debugger-proto-property.html
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): object proxy with non-empty path cannot be scope proxy.
- 5:30 AM Changeset in webkit [61996] by
-
- 6 edits3 adds in trunk/LayoutTests
2010-06-28 MORITA Hajime <morrita@google.com>
Unreviewed text expectations update after r61993.
- platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
- platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- 5:21 AM Changeset in webkit [61995] by
-
- 2 edits in trunk/WebKitTools
[QT][S60] build-webkit scripts picks wrong make spec for windows build
https://bugs.webkit.org/show_bug.cgi?id=41198
Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-10
Reviewed by Simon Hausmann.
Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds.
- Scripts/webkitdirs.pm:
(determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
- 4:40 AM Changeset in webkit [61994] by
-
- 2 edits in trunk/WebCore
2010-06-28 MORITA Hajime <morrita@google.com>
Unreviewed attempt to fix windows build.
- page/DOMWindow.idl:
- 4:20 AM Changeset in webkit [61993] by
-
- 9 edits in trunk
2010-06-22 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<progress> should be styled with -webkit-progress-bar-value
https://bugs.webkit.org/show_bug.cgi?id=40823
Added cases for various style combinations, and explanations for
that cases.
- fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/qt/Skipped:
2010-06-22 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<progress> should be styled with -webkit-progress-bar-value
https://bugs.webkit.org/show_bug.cgi?id=40823
Fixed to peek styles of the shadow node pseudo class to fallback
to non-styled painting.
- css/html.css: (progress): Added defaul background-color. (progress::-webkit-progress-bar-value): Added defaul background-color.
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::updatePartsState):
Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
- 3:30 AM Changeset in webkit [61992] by
-
- 2 edits in trunk/WebCore
2010-06-28 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Kent Tamura.
GCC suggest parentheses around && within - rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
- 3:01 AM Changeset in webkit [61991] by
-
- 3 edits in trunk/LayoutTests
2010-06-28 Eric Seidel <eric@webkit.org>
Unreviewed. Update test-html5-parser results to
match the results from the new treebuilder.
These results were otherwise useless now that we
have he HTML5 Tokenizer on by default.
- html5lib/runner-expected-html5.txt:
- html5lib/webkit-resumer-expected-html5.txt:
- 2:56 AM Changeset in webkit [61990] by
-
- 2 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't dump contents of <script> elements in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=41277
Apparently we need to tell each element when we start and stop parsing
its children. If we don't do this, we see the contents of every script
and style element in dumpAsText LayoutTests. (This patch is *well*
covered by LayoutTests.)
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push):
- 2:44 AM Changeset in webkit [61989] by
-
- 12 edits in trunk
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276
Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.
test-html5-parser now tests this code path.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::finished):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: (WebCore::Settings::setHTML5TreeBuilderEnabled_DO_NOT_USE): (WebCore::Settings::html5TreeBuilderEnabled):
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276
Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.
test-html5-parser now tests this code path.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences html5TreeBuilderEnabled]): (-[WebPreferences setHTML5TreeBuilderEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276
Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.
test-html5-parser now tests this code path.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
- Scripts/test-html5-parser:
- 2:40 AM QtWebKitDocContrib edited by
- (diff)
- 2:34 AM QtWebKitDocContrib edited by
- (diff)
- 2:29 AM Changeset in webkit [61988] by
-
- 3 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make the html5lib runner.html not assert
https://bugs.webkit.org/show_bug.cgi?id=41273
This patch gets us closer to being able to run the parser tests. We
still don't get parsing correct, but at least we don't assert. :)
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::insertCommentOnDocument):
- html/HTMLTreeBuilder.h:
- 2:16 AM QtWebKitDocContrib edited by
- (diff)
- 1:47 AM Changeset in webkit [61987] by
-
- 3 edits in trunk/WebCore
2010-06-28 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt to fix Chromium and Qt builders.
Add a new baseclass for XML, HTML and Text DocumentParsers to clean up DocumentParser call sites
https://bugs.webkit.org/show_bug.cgi?id=41141
No functional changes, thus no tests.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::stopParsing):
- 1:15 AM Changeset in webkit [61986] by
-
- 2 edits in trunk/WebCore
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for parsing attributes
https://bugs.webkit.org/show_bug.cgi?id=41272
This patch lets use parse the following document:
<script src="data:text/javascript,alert('PASS')"></script>
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::insertScriptElement): (WebCore::HTMLTreeBuilder::createElement):
- 12:56 AM Changeset in webkit [61985] by
-
- 27 edits3 copies1 add in trunk/WebCore
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Add a new baseclass for XML, HTML and Text DocumentParsers to clean up DocumentParser call sites
https://bugs.webkit.org/show_bug.cgi?id=41141
By splitting ScriptableDocumentParser and DecodedDataDocumentParser
out from DocumentParser we've made the DocumentParser and
RawDataDocumentParser classes simpler.
No functional change, thus no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber):
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
- dom/Document.cpp: (WebCore::Document::scriptableDocumentParser): (WebCore::Document::open): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::removePendingSheet):
- dom/Document.h: (WebCore::Document::parser):
- dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser):
- dom/DocumentParser.h: (WebCore::DocumentParser::asScriptableDocumentParser):
- dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finishWasCalled):
- dom/ScriptableDocumentParser.cpp: Copied from WebCore/html/HTMLEntityParser.h. (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
- dom/ScriptableDocumentParser.h: Added. (WebCore::ScriptableDocumentParser::isExecutingScript): (WebCore::ScriptableDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::ScriptableDocumentParser::xssAuditor): (WebCore::ScriptableDocumentParser::setXSSAuditor): (WebCore::ScriptableDocumentParser::processingContentWrittenByScript): (WebCore::ScriptableDocumentParser::asScriptableDocumentParser):
- dom/ViewportArguments.cpp: (WebCore::parserLineNumber): (WebCore::reportViewportWarning):
- dom/XMLDocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
- html/HTMLDocumentParser.h:
- html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::parseTag):
- html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::processingContentWrittenByScript):
- html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
- loader/DocumentLoader.cpp:
- loader/DocumentWriter.cpp:
- loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::finish):
- svg/SVGDocumentExtensions.cpp: (WebCore::parserLineNumber): (WebCore::reportMessage): (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
- 12:35 AM Changeset in webkit [61984] by
-
- 3 edits in trunk/WebKit/qt
2010-06-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QGraphicsWebView crash when calling setScale() before setUrl()
https://bugs.webkit.org/show_bug.cgi?id=40000
Check 'page' before dereference in _q_scaleChanged()
Autotest included.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_scaleChanged):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl):
- 12:26 AM Changeset in webkit [61983] by
-
- 5 edits1 add in trunk/WebCore
2010-06-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Mark Rowe.
WebKit2 build exceeds address space on 32-bit Windows builders
https://bugs.webkit.org/show_bug.cgi?id=41270
Add all-in-one file for render-related SVG files.
Clean up other all-in-one files by adding missing files, excluding matching files from the vcproj.
Reduces release WebCore.lib size by 10% (160MB).
- DerivedSources.cpp:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSBindingsAllInOne.cpp:
- html/HTMLElementsAllInOne.cpp:
- rendering/RenderSVGAllInOne.cpp: Added.
- 12:18 AM Changeset in webkit [61982] by
-
- 3 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sketch out the InBodyMode for the tree builder
https://bugs.webkit.org/show_bug.cgi?id=41271
This gives us some basic behavior for the InBodyMode. I've implemented
some of the easier logic. The more complicated logic will be in
subsequent patches.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::insertFormatingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
- html/HTMLTreeBuilder.h:
Jun 27, 2010:
- 11:52 PM Changeset in webkit [61981] by
-
- 2 edits in trunk/WebKitLibraries
Windows (Cairo) build fix.
Add missing ENABLE_WEB_TIMING feature define.
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 11:49 PM Changeset in webkit [61980] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix.
Disable ENABLE_WEB_TIMING on Windows.
- win/tools/vsprops/FeatureDefines.vsprops:
- 11:37 PM Changeset in webkit [61979] by
-
- 4 edits in trunk/WebKit2
Update guards related to blocks to check whether BLOCKS is defined, rather than checking its value.
Rubber-stamped by Maciej Stachowiak.
This matches how similar checks are performed in system headers, and avoids a compile error when BLOCKS
is not defined.
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPagePrivate.h:
- 10:45 PM Changeset in webkit [61978] by
-
- 2 edits in trunk/WebKitTools
2010-06-27 MORITA Hajime <morrita@google.com>
Unreviewed.
Some never-called @staticmethods touched self.
Fixed it to replace these self with a class.
- Scripts/webkitpy/common/checkout/scm.py:
- 10:34 PM Changeset in webkit [61977] by
-
- 3 edits in trunk/WebKitTools
2010-06-27 MORITA Hajime <morrita@google.com>
Unreviewed.
Fixed exception raising syntax that is pointed out at
https://bugs.webkit.org/show_bug.cgi?id=41153
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py: Removed a bad line that I accidentally checked-in at last revision.
- 10:15 PM Changeset in webkit [61976] by
-
- 4 edits in trunk/WebKitTools
2010-06-24 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
rebaseline-chromium-webkit-tests should add or remove files to local git repository
https://bugs.webkit.org/show_bug.cgi?id=41153
- Added SCM.add() and SCM.remove()
- Replaced "svn add" and "svn remove" rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
- add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py for debugging purpose.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 6:59 PM Changeset in webkit [61975] by
-
- 29 edits in trunk
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150
- printing/page-format-data-expected.txt:
- printing/page-format-data.html:
- printing/page-rule-selection-expected.txt:
- printing/page-rule-selection.html:
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
Default page size and orientation have been hard-coded.
Instead, pass default page size and margins to
WebCore::Document::pageSizeAndMarginsInPixels to handle auto page size
and margins specified as percentages.
Return margins instead of page rect.
- WebCore.base.exp:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName):
- css/html.css: (@page):
- dom/Document.cpp: (WebCore::Document::pageSizeAndMarginsInPixels):
- dom/Document.h:
- page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
- page/PrintContext.h:
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSizeType): (WebCore::InheritedFlags::setPageSizeType): (WebCore::InheritedFlags::resetPageSizeType):
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h: (WebCore::):
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageSizeAndMarginsInPixels):
- src/WebFrameImpl.h:
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150
- DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (parsePageNumberSizeMarings): (pageSizeAndMarginsInPixelsCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageSizeAndMarginsInPixels):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
- 4:19 PM Changeset in webkit [61974] by
-
- 3 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Clean up some loose ends in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41265
This patch cleans up a few loose ends in HTML5 tree builder.
Technically, we could do each of these as individual patches, but that
didn't seem worth while.
- html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
- Add missing break before default case statement. I don't think this change is observable.
(WebCore::HTMLTreeBuilder::processComment):
- Originally I thought that comments had special processing in the InHeadNoscriptMode, but it turns out that when you unwind the definitions, it amounts to exactly the same thing.
(WebCore::HTMLTreeBuilder::processEndOfFile):
- Add missing break before default case statement. I don't think this change is observable.
(WebCore::HTMLTreeBuilder::insertComment):
- Eliminate one unnecessary ref/deref pair.
(WebCore::HTMLTreeBuilder::insertSelfClosingElement):
- When we insert self-closing elements, there's no reason to push them onto the stack of open elements just to pop them off again. This change saves a malloc/free pair as well as a ref/deref pair. Go team.
- html/HTMLTreeBuilder.h:
- Remove unused function.
- 3:45 PM Changeset in webkit [61973] by
-
- 3 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement remaining StartTag processing for InHeadNoscriptMode
https://bugs.webkit.org/show_bug.cgi?id=41264
The InHeadNoscriptMode processes some start tags "as if" the tree
builder were in the InHeadMode. This is an idiom we'll see more of
later. My approach is this patch is to factor all the logic for
processing start tags in the InHeadMode into a separate function that
can be called from both locations. This seems cleaner than just
splitting out the parts that are actually used by both modes.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::insertSelfClosingElement):
- html/HTMLTreeBuilder.h:
- 3:20 PM Changeset in webkit [61972] by
-
- 2 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for <title> and <style> elements
https://bugs.webkit.org/show_bug.cgi?id=41263
These elements use the generic RCDATA and RawText algorithms,
respectively.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
- 3:09 PM Changeset in webkit [61971] by
-
- 3 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Actually insert Doctype elements
https://bugs.webkit.org/show_bug.cgi?id=41262
This code is pretty much the same as in the old tree builder.
- html/HTMLToken.h: (WebCore::AtomicHTMLToken::publicIdentifier): (WebCore::AtomicHTMLToken::systemIdentifier):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertDoctype):
- 10:10 AM Changeset in webkit [61970] by
-
- 5 edits in trunk
2010-06-27 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Canvas: Ignore calls to drawImage() with non-finite parameters
https://bugs.webkit.org/show_bug.cgi?id=38929
Rebaseline (and unskip for Qt) the now working test.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
- canvas/philip/tests/2d.drawImage.nonfinite-expected.txt:
- platform/qt/Skipped:
2010-06-27 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Canvas: Ignore calls to drawImage() with non-finite parameters
https://bugs.webkit.org/show_bug.cgi?id=38929
This also fixes a Qt assert when using the raster graphics system.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
- 9:36 AM Changeset in webkit [61969] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Turn ENABLE(SINGLE_THREADED) on.
https://bugs.webkit.org/show_bug.cgi?id=41135
Brew MP does not support preemptive multi-threading.
Disable threading for Brew MP.
- wtf/Platform.h:
- 7:14 AM Changeset in webkit [61968] by
-
- 4 edits in trunk
2010-06-27 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025
Unskip editing/execCommand/copy-without-selection.html for Qt.
- platform/qt/Skipped:
2010-06-27 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025
The problem was that when getting data back via Clipboard::getData(),
the String::String(const char*, int) constructor was called
with UTF-16 data.
The solution is to use QMimeData's text() and setText() for "text/plain".
setText() which makes sure Qt passes the string in proper format to the
system clipboard. (The previous implementation would convert it to UTF-8)
text() makes sure that the correct encoding is used (UTF-16) and that
we get back whatever we originally put in there.
- platform/qt/ClipboardQt.cpp: (WebCore::isTextMimeType): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData):
- 3:05 AM Changeset in webkit [61967] by
-
- 2 edits in trunk/LayoutTests
2010-06-27 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed, mark fast/js/Object-create.html as crashing on Cr Linux, will look into it.
- platform/chromium/test_expectations.txt:
- 1:38 AM Changeset in webkit [61966] by
-
- 3 edits in trunk/WebCore
2010-06-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 tree builder should be able to execute inline scripts
https://bugs.webkit.org/show_bug.cgi?id=41257
This patch implements enough machinery so that we can execute inline
scripts in extremely simple documents such as the following:
<html>
<script>
alert(1);
</script>
To get this to work, I had to flesh out a surprising amount of the data
structures for processing the <head>. No tests because this is
already covered by most LayoutTests.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementRecord::ElementRecord): (WebCore::HTMLTreeBuilder::ElementRecord::element): (WebCore::HTMLTreeBuilder::ElementRecord::next): (WebCore::HTMLTreeBuilder::ElementRecord::releaseNext): (WebCore::HTMLTreeBuilder::ElementRecord::setNext): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::top): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::currentElement):
