Timeline
Jun 30, 2010:
- 11:42 PM Changeset in webkit [62231] by
-
- 4 edits in trunk/LayoutTests
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436
This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 11:24 PM Changeset in webkit [62230] by
-
- 4 edits in trunk/WebKit/gtk
2010-06-30 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r62226.
http://trac.webkit.org/changeset/62226
https://bugs.webkit.org/show_bug.cgi?id=40333
This change caused 13 new crashers.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
- 11:22 PM Changeset in webkit [62229] by
-
- 2 edits in trunk/WebCore
2010-06-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTokenizer's whitespace checks are very redundant
https://bugs.webkit.org/show_bug.cgi?id=41434
This patch adds isTokenizerWhitespace, which replaces a lot of
redundant logic in nextToken.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
- 11:07 PM Changeset in webkit [62228] by
-
- 3 edits in trunk/WebCore
2010-06-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Crash when uploading document to Google Docs
https://bugs.webkit.org/show_bug.cgi?id=40795
Fix bug where the local file wasn't opened (for POSTing)
if it were the first element in the form.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::FormDataIODevice::moveToNextElement): (WebCore::FormDataIODevice::openFileForCurrentElement):
- platform/network/qt/QNetworkReplyHandler.h:
- 10:53 PM Changeset in webkit [62227] by
-
- 5 edits in trunk
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432
- html5lib/runner-expected-html5.txt:
- Test 2.28 is now fixed.
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432
This fixes one subtest in html5lib/runner.html and positively
effects a couple others.
More code sharing will be needed here. For the moment
we're using copy/paste code, but that will soon be shared.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::generateImpliedEndTagsWithExclusion): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):
- html/HTMLTreeBuilder.h:
- 10:44 PM Changeset in webkit [62226] by
-
- 4 edits in trunk/WebKit/gtk
2010-06-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333
Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
- 10:38 PM Changeset in webkit [62225] by
-
- 4 edits in trunk/LayoutTests
2010-06-30 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Update GTK+ expected results after r62215.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 10:26 PM Changeset in webkit [62224] by
-
- 2 edits in trunk/LayoutTests
2010-06-30 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix Sam's brokeness.
AFAIK, this new expected result is ok (especially given that it still
says PASS).
- fast/dom/Window/window-postmessage-clone-expected.txt:
- 5:26 PM Changeset in webkit [62223] by
-
- 5 edits in trunk/LayoutTests
Unreviewed fix. Update Qt specific expected files after r62215.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 5:07 PM Changeset in webkit [62222] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix after r62196 and r62214.
- html/HTMLElementStack.cpp: Put !ENABLE(SVG) guard instead of
!ENABLE(SVG_FOREIGN_OBJECT) around include of SVGNames.h.
- 5:05 PM Changeset in webkit [62221] by
-
- 2 edits in trunk/WebCore
Really fix the windows build.
- bindings/js/JSBindingsAllInOne.cpp:
- 5:00 PM Changeset in webkit [62220] by
-
- 2 edits in trunk/WebCore
Another Chromium build fix.
- page/DOMWindow.idl:
- 4:59 PM Changeset in webkit [62219] by
-
- 2 edits in trunk/WebCore
Fix Chromium build.
- WebCore.gyp/WebCore.gyp:
- 4:52 PM Changeset in webkit [62218] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- bindings/js/JSBindingsAllInOne.cpp:
- 4:50 PM Changeset in webkit [62217] by
-
- 2 edits2 adds in trunk/LayoutTests
Added chromium-mac specific results due to new tests added in r62200.
Reviewed by NOBODY (baseline updates corresponding to newly added tests).
- platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
- platform/chromium/test_expectations.txt: Added failures due to bug 41311.
- 4:39 PM Changeset in webkit [62216] by
-
- 2 edits in trunk/WebCore
Fix Gtk build.
- GNUmakefile.am:
- 4:15 PM Changeset in webkit [62215] by
-
- 22 edits13 adds in trunk
WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property
Reviewed by Dan Bernstein.
Tests: fast/dom/dataset-xhtml.xhtml
fast/dom/dataset.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMStringMapCustom.cpp: Added.
(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):
- bindings/js/JSDOMStringMapCustom.h: Added.
- dom/DOMStringMap.cpp: Added.
(WebCore::DOMStringMap::~DOMStringMap):
- dom/DOMStringMap.h: Added.
(WebCore::DOMStringMap::DOMStringMap):
- dom/DOMStringMap.idl: Added.
- dom/DatasetDOMStringMap.cpp: Added.
(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):
(WebCore::DatasetDOMStringMap::ref):
(WebCore::DatasetDOMStringMap::deref):
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
(WebCore::DatasetDOMStringMap::setItem):
(WebCore::DatasetDOMStringMap::deleteItem):
- dom/DatasetDOMStringMap.h: Added.
(WebCore::DatasetDOMStringMap::create):
(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):
- dom/Element.cpp:
(WebCore::Element::dataset):
- dom/Element.h:
- dom/Element.idl:
- dom/ElementRareData.h:
- page/DOMWindow.idl:
LayoutTests: Test changes for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property
Reviewed by Dan Bernstein.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/dataset-expected.txt: Added.
- fast/dom/dataset-xhtml-expected.txt: Added.
- fast/dom/dataset-xhtml.xhtml: Added.
- fast/dom/dataset.html: Added.
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/dataset-xhtml.js: Added.
- fast/dom/script-tests/dataset.js: Added.
- fast/dom/script-tests/domListEnumeration.js:
- fast/js/global-constructors-expected.txt:
- 4:10 PM Changeset in webkit [62214] by
-
- 2 edits in trunk/WebCore
More Qt build fix.
- html/HTMLElementStack.cpp: Put !ENABLE(SVG_FOREIGN_OBJECT) around
include of SVGNames.h too.
- 4:09 PM Changeset in webkit [62213] by
-
- 5 edits in trunk
2010-06-30 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422
- wtf/PassRefPtr.h: Tweaked formatting. Added a new adopted function, called on the pointer by adoptRef, with an empty inline default version, meant to be overloaded. Unified the inlining with a macro named REF_DEREF_INLINE to make it clearer what's going on in the refIfNotNull/derefIfNotNull functions. Renamed releaseRef to leakRef, but left the old name in for compatibility for now.
- wtf/RefCounted.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_REF_COUNTED define in this header. Later we can turn it on once we get everything working without asserting.
2010-06-30 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422
- platform/TreeShared.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_TREE_SHARED define in this header. Later we can turn it on once we get everything working without asserting. Note also that it only works for objects with an initial reference count of 1.
- 3:58 PM Changeset in webkit [62212] by
-
- 6 edits4 adds in trunk/WebKit2
Patch for https://bugs.webkit.org/show_bug.cgi?id=41426
Add ImmutableArray class and WKArrayRef API to go with it. This will be used
in a few follow up patches.
Reviewed by Darin Adler.
- Shared/ImmutableArray.cpp: Added.
(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):
- Shared/ImmutableArray.h: Added.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKArray.cpp: Added.
- UIProcess/API/C/WKArray.h: Added.
- UIProcess/API/C/WKBase.h:
- WebKit2.xcodeproj/project.pbxproj:
- mac/WebKit2.exp:
- win/WebKit2.vcproj:
- 3:57 PM Changeset in webkit [62211] by
-
- 2 edits in trunk/LayoutTests
2010-06-30 Albert J. Wong <ajwong@chromium.org>
Not reviewed. Chromium: Disable flaky test.
Add an IMAGE failure to linux standalone-image-drag-to-editable.html.
Test has been flaky on build.
- platform/chromium/test_expectations.txt:
- 3:48 PM Changeset in webkit [62210] by
-
- 3 edits in trunk/WebKitTools
2010-06-30 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Allow MiniBrowser to open local files
https://bugs.webkit.org/show_bug.cgi?id=41104
Wire up the openDocument: message with an NSOpenPanel, so we can open
local files.
Also change the xib so that the window remembers its size.
- MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate frontmostBrowserWindowController]): (-[BrowserAppDelegate openDocument:]): (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
- MiniBrowser/mac/English.lproj/BrowserWindow.xib:
- 3:34 PM Changeset in webkit [62209] by
-
- 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj
fix build problem for audio branch
- 3:24 PM Changeset in webkit [62208] by
-
- 2 edits in trunk/WebCore
2010-06-30 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) after r62196.
https://bugs.webkit.org/show_bug.cgi?id=41429
- html/HTMLElementStack.cpp:
- 2:45 PM Changeset in webkit [62207] by
-
- 4 edits in trunk/WebCore
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add new popUntil(tagName) function and deploy
https://bugs.webkit.org/show_bug.cgi?id=41405
Add a new popUntil function to share some common code
between states. There is more code to share here, but this
is a start.
I also filled in a couple similar states to these with the
hope of sharing more code, but decided to wait for a later
patch.
No test changes, since this code doesn't do enough yet to
pass any more subtests. Lack of generateImpliedEndTags is the main
blocking issue.
- html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popUntil):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
- 2:44 PM Changeset in webkit [62206] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-30 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Roll forward Chromium DEPS to r51287
https://bugs.webkit.org/show_bug.cgi?id=41430
- DEPS:
- 2:24 PM Changeset in webkit [62205] by
-
- 3 edits in branches/audio/WebCore/audio
Implement the actual unity gain summing junction code for AudioNodeInput
- still not handling generic AudioNode case
- optimizations not yet there, but current implementation will hold us for awhile
- 2:24 PM Changeset in webkit [62204] by
-
- 1 edit in branches/audio/WebCore/audio/performance_timer.cc
Fix performance timer to work multiple times
- 2:24 PM Changeset in webkit [62203] by
-
- 5 edits2 copies1 add in branches/audio/WebCore
Add AudioGainNode
- 2:24 PM Changeset in webkit [62202] by
-
- 4 edits in branches/audio/WebCore/audio
Make sure to handle ownership properly (with reference counting) in AudioBufferSourceNode
- 2:24 PM Changeset in webkit [62201] by
-
- 13 edits in branches/audio/WebCore/audio
Initial architectural changes to support unity-gain summing junctions for AudioNode inputs
- this helps simplifies the javascript API (along with AudioGainNode) so we can get rid of AudioMixerNode and AudioMixerInputNode
- more work needed to actually do the summing
- we won't optimize all paths initially, but performance will be adequate
- 1:49 PM Changeset in webkit [62200] by
-
- 1 edit80 adds in trunk/LayoutTests
20 tests to (at least temporarily) satisfy https://bugs.webkit.org/show_bug.cgi?id=41303 Need way more border-radius tests
Reviewed by Dan Bernstein.
- fast/borders/border-radius-circle.html: Added.
- fast/borders/border-radius-groove-01.html: Added.
- fast/borders/border-radius-groove-02.html: Added.
- fast/borders/border-radius-groove-03.html: Added.
- fast/borders/border-radius-wide-border-01.html: Added.
- fast/borders/border-radius-wide-border-02.html: Added.
- fast/borders/border-radius-wide-border-03.html: Added.
- fast/borders/border-radius-wide-border-04.html: Added.
- fast/borders/borderRadiusDashed04.html: Added.
- fast/borders/borderRadiusDashed05.html: Added.
- fast/borders/borderRadiusDashed06.html: Added.
- fast/borders/borderRadiusDotted04.html: Added.
- fast/borders/borderRadiusDotted05.html: Added.
- fast/borders/borderRadiusDotted06.html: Added.
- fast/borders/borderRadiusDouble04.html: Added.
- fast/borders/borderRadiusDouble05.html: Added.
- fast/borders/borderRadiusDouble06.html: Added.
- fast/borders/borderRadiusDouble07.html: Added.
- fast/borders/borderRadiusDouble08.html: Added.
- fast/borders/borderRadiusDouble09.html: Added.
- platform/mac/fast/borders/border-radius-circle-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-circle-expected.png: Added.
- platform/mac/fast/borders/border-radius-circle-expected.txt: Added.
- platform/mac/fast/borders/border-radius-groove-01-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-groove-01-expected.png: Added.
- platform/mac/fast/borders/border-radius-groove-01-expected.txt: Added.
- platform/mac/fast/borders/border-radius-groove-02-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-groove-02-expected.png: Added.
- platform/mac/fast/borders/border-radius-groove-02-expected.txt: Added.
- platform/mac/fast/borders/border-radius-groove-03-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-groove-03-expected.png: Added.
- platform/mac/fast/borders/border-radius-groove-03-expected.txt: Added.
- platform/mac/fast/borders/border-radius-wide-border-01-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
- platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Added.
- platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
- platform/mac/fast/borders/border-radius-wide-border-02-expected.txt: Added.
- platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
- platform/mac/fast/borders/border-radius-wide-border-03-expected.txt: Added.
- platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
- platform/mac/fast/borders/border-radius-wide-border-04-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDashed04-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDashed04-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDashed05-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDashed05-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDashed05-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDashed06-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDashed06-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDotted04-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDotted04-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDotted04-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDotted05-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDotted05-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDotted05-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDotted06-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDotted06-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble04-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble04-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble04-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble05-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble05-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble05-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble06-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble06-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble06-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble07-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble07-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble07-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble08-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble08-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble08-expected.txt: Added.
- platform/mac/fast/borders/borderRadiusDouble09-expected.checksum: Added.
- platform/mac/fast/borders/borderRadiusDouble09-expected.png: Added.
- platform/mac/fast/borders/borderRadiusDouble09-expected.txt: Added.
- 1:48 PM Changeset in webkit [62199] by
-
- 3 edits1 add in trunk/WebKitTools
Add debug-webkittestrunner and cleanup related scripts.
Rubber-stamped by Anders Carlsson.
- Scripts/debug-webkittestrunner: Added.
- Scripts/run-webkittestrunner:
- Scripts/webkitdirs.pm:
- 1:11 PM Changeset in webkit [62198] by
-
- 4 edits in trunk
WebCore:
2010-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495
Fix typo in custom function detection method.
- bindings/scripts/CodeGeneratorGObject.pm:
WebKit/gtk:
2010-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495
Add unit test for webkit_dom_node_remove_child.
- tests/testdomnode.c: (test_dom_node_insertion):
- 1:11 PM Changeset in webkit [62197] by
-
- 2 edits in trunk/WebKit/gtk
2010-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495
Add unit tests for node insertion and replacement methods.
- tests/testdomnode.c: (test_dom_node_insertion): (main):
- 1:02 PM Changeset in webkit [62196] by
-
- 7 edits in trunk
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402
Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.
- html5lib/runner-expected-html5.txt:
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402
Implemented the 4 needed "in scope" functions for HTML5.
3 for the different sets of scope markers, and one for
doing exact element comparisons instead of tag name searches.
I deployed inScope("body") for </body> and </html> in InBody.
Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.
- html/HTMLElementStack.cpp: (WebCore::inScopeCommon): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::inListItemScope): (WebCore::HTMLElementStack::inTableScope):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
- html/HTMLTreeBuilder.h:
- 12:50 PM Changeset in webkit [62195] by
-
- 9 edits2 adds in trunk/WebCore
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split HTMLElementStack out into its own file
https://bugs.webkit.org/show_bug.cgi?id=41399
No functional change, thus no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElementStack.cpp: Added. (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::~HTMLElementStack): (WebCore::HTMLElementStack::popHTMLHeadElement): (WebCore::HTMLElementStack::pop): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::pushHTMLHeadElement): (WebCore::HTMLElementStack::pushHTMLBodyElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::top): (WebCore::HTMLElementStack::removeHTMLHeadElement): (WebCore::HTMLElementStack::remove): (WebCore::HTMLElementStack::contains): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::headElement): (WebCore::HTMLElementStack::bodyElement): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonFirstCommon):
- html/HTMLElementStack.h: Added.
- html/HTMLTreeBuilder.h:
- 12:17 PM Changeset in webkit [62194] by
-
- 4 edits2 adds in trunk
2010-06-30 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040
Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.
Test: fast/canvas/webgl/array-buffer-view-crash.html
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
- bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
2010-06-30 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040
Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.
- fast/canvas/webgl/array-buffer-view-crash-expected.txt: Added.
- fast/canvas/webgl/array-buffer-view-crash.html: Added.
- 11:49 AM Changeset in webkit [62193] by
-
- 3 edits in trunk/WebKit/qt
2010-06-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure we catch closed QComboBox popups.
https://bugs.webkit.org/show_bug.cgi?id=39019
The way it works currently is using the QComboBox::show/hidePopup
virtual method to catch popup requests in the middle. There is
some cases however that the popup widget gets closed without
going through the hidePopup method.
This patch adds an event filter to the popup's view to know when
it gets closed and calls hidePopup to call our handling code.
This may get hidePopup called twice but this shouldn't have any
effect.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo): (WebCore::QtFallbackWebPopupCombo::eventFilter):
- WebCoreSupport/QtFallbackWebPopup.h:
- 10:53 AM Changeset in webkit [62192] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after recent changes to LayoutTestController.
- 10:33 AM Changeset in webkit [62191] by
-
- 7 edits in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
Make WebKitTestRunner work with more than one test at a time.
Reviewed by Anders Carlsson.
This converts WebKitTestRunner to a similar model as DumpRenderTree,
where there is a single WKView and each test is run it, rather than
the design I was using where each test got its own WKView.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didRecieveMessage):
(WTR::InjectedBundle::reset):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::_didRecieveMessageFromInjectedBundle):
(WTR::TestController::didRecieveMessageFromInjectedBundle):
- WebKitTestRunner/TestController.h:
(WTR::TestController::mainWebView):
(WTR::TestController::pageNamespace):
(WTR::TestController::context):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
- 10:00 AM Changeset in webkit [62190] by
-
- 7 edits in trunk/WebKit2
Add reviewer.
- 10:00 AM Changeset in webkit [62189] by
-
- 2 edits in trunk/WebCore
2010-06-30 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
[chromium] update webcore gyp to use v8 dll for chromium multi dll build.
- WebCore.gyp/WebCore.gyp:
- 9:38 AM Changeset in webkit [62188] by
-
- 2 edits in trunk
2010-06-30 Leandro Pereira <leandro@profusion.mobi>
Unreviewed.
Generate CSSValueKeywords.cpp instead of CSSValueKeywords.c to avoid
recompilation and relinking of WebCore when no files were changed.
- cmake/WebKitGenerators.cmake:
- 9:26 AM UsingGitWithWebKit edited by
- (diff)
- 8:52 AM Changeset in webkit [62187] by
-
- 2 edits1 add in trunk/WebCore
2010-06-30 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add OOP font loading to FontPlatformDataChromiumMac.
On OS X, with font management software installed. Fonts
can reside in an arbitrary path on disk which is blocked by
Chromium's sandbox.
This change adds hooks to FontPlaformData which allow cross-process
font loading in case of need.
Not possible to test - requires sandboxing which DRT doesn't support.
- WebCore.gypi:
- platform/graphics/chromium/FontPlatformDataChromiumMac.mm: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::description):
- 8:29 AM Changeset in webkit [62186] by
-
- 3 edits in trunk/WebCore
2010-06-30 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dan Bernstein.
Minor tweaks to FontPlatformDataMac & SimpleFontDataMac.mm
- Avoid an extra FontPlatformData copy in SimpleFontDataMac.mm
- Fix a typo in FontPlatformDataMac.mm
No behavior changes so no new tests.
- platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::copyFontTableForTag):
- 8:16 AM Changeset in webkit [62185] by
-
- 5 edits in trunk/WebCore
2010-06-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
https://bugs.webkit.org/show_bug.cgi?id=41407
Only disallow calling SetWindow more than once if we're using Flash 9 or older.
This fixes resizing of YouTube videos via the player's own button.
Removed copy-pasted logic in PluginViewGtk since the issue only exists
when running Flash with a non-Gtk toolkit.
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
- plugins/PluginQuirkSet.h: (WebCore::):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Remove unnecessary logic copy-pasted from PluginViewQt.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 7:20 AM Changeset in webkit [62184] by
-
- 4 edits in trunk/WebCore
2010-06-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antti Koivisto.
[Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
https://bugs.webkit.org/show_bug.cgi?id=41406
NPRect has right/bottom instead of width/height.
This was fixed in PluginViewMac with http://trac.webkit.org/changeset/45815
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 7:02 AM Changeset in webkit [62183] by
-
- 2 edits2 deletes in trunk/LayoutTests
2010-06-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62182.
http://trac.webkit.org/changeset/62182
https://bugs.webkit.org/show_bug.cgi?id=41408
GTK build brekage (Requested by pfeldman on #webkit).
- inspector/debugger-eval-while-paused-expected.txt: Removed.
- inspector/debugger-eval-while-paused.html: Removed.
- platform/qt/Skipped:
- 6:11 AM Changeset in webkit [62182] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-06-30 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add layout test for console evaluations with paused script
https://bugs.webkit.org/show_bug.cgi?id=41336
- inspector/debugger-eval-while-paused-expected.txt: Added.
- inspector/debugger-eval-while-paused.html: Added.
- platform/qt/Skipped:
- 6:04 AM Changeset in webkit [62181] by
-
- 5 edits in trunk/LayoutTests
Update Windows test results after r62092
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 6:03 AM Changeset in webkit [62180] by
-
- 2 edits in trunk/WebKit
2010-06-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=40876
- efl/WebCoreSupport/ChromeClientEfl.cpp: Implements two methods to change window size.
(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):
- 5:38 AM Changeset in webkit [62179] by
-
- 5 edits3 adds in trunk
2010-06-30 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Spatial Navigation: make elements in inner frames nested more than 1 level deep focusable
https://bugs.webkit.org/show_bug.cgi?id=41160
Patch addresses the problem of spatial navigation not work properly with nested
inner frames by adding the isNodeDeepDescendantOfDocument function. It recursively checks
if a give node is descendant of a given document or any parent of it.
Test: fast/events/spatial-navigation/snav-iframe-nested.html
- page/FocusController.cpp: (WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/SpatialNavigation.cpp: (WebCore::isNodeDeepDescendantOfDocument):
- page/SpatialNavigation.h:
- fast/events/spatial-navigation/resources/iframe.html: Added.
- fast/events/spatial-navigation/snav-iframe-nested-expected.txt: Added.
- fast/events/spatial-navigation/snav-iframe-nested.html: Added.
- 5:27 AM Changeset in webkit [62178] by
-
- 10 edits in trunk
2010-06-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chrome DevTools: Finalize migration to new WebView constructor
(devtools agent is now created within WebViewImpl only).
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
- tests/PopupMenuTest.cpp: (WebKit::SelectPopupMenuTest::SetUp):
- 5:15 AM Changeset in webkit [62177] by
-
- 3 edits in trunk/LayoutTests
2010-06-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
- platform/chromium-mac/html5lib/runner-expected.txt:
- platform/chromium-win/html5lib/runner-expected.txt:
- 5:01 AM Changeset in webkit [62176] by
-
- 2 edits in trunk/WebKitTools
[Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
https://bugs.webkit.org/show_bug.cgi?id=40446
Reviewed by Laszlo Gombos.
We quickly run out of memory on Symbian when loading web pages. This is
caused by the default heap size, which is not suited for a web browser.
This change bumps the max heap size to 32MB.
- QtTestBrowser/QtTestBrowser.pro:
- 3:27 AM Changeset in webkit [62175] by
-
- 3 edits in trunk/WebCore
2010-06-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTokenizer should use fewer macros
https://bugs.webkit.org/show_bug.cgi?id=41397
Macros are sadness. Inline functions are the new hotness.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::emitAndResumeIn): (WebCore::HTMLTokenizer::emitAndReconsumeIn): (WebCore::HTMLTokenizer::emitEndOfFile): (WebCore::HTMLTokenizer::flushBufferedEndTag): (WebCore::HTMLTokenizer::flushEmitAndResumeIn): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::bufferCharacter): (WebCore::HTMLTokenizer::bufferCodePoint): (WebCore::HTMLTokenizer::bufferParseError): (WebCore::HTMLTokenizer::bufferCurrentToken): (WebCore::HTMLTokenizer::bufferEndOfFile):
- html/HTMLTokenizer.h:
- 3:10 AM Changeset in webkit [62174] by
-
- 8 edits1 delete in trunk/WebCore
2010-06-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Remove dead binding code
https://bugs.webkit.org/show_bug.cgi?id=41388
Removed BindingElement because it was obsoleted by r59866.
- WebCore.gypi:
- bindings/generic/BindingElement.h: Removed.
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8DatabaseCustom.cpp:
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
- 2:46 AM Changeset in webkit [62173] by
-
- 3 edits in trunk/LayoutTests
2010-06-30 Eric Seidel <eric@webkit.org>
Unreviewed. Just updating test expectations.
HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344
Update results after EndOfFile support.
The final pump will always have one character,
which is the EOF character.
- inspector/timeline-parse-html-expected.txt:
- 2:14 AM Changeset in webkit [62172] by
-
- 4 edits in trunk/WebCore
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344
EndOfFile support uncovered a bug in our implementation of finish().
finish() may be called more than once if the first call does not
result in end() being called (and parsing thus actually stopping).
SegmentedString::close() should have ASSERTed that it was not already
closed when close() is called. I've added such an assert now.
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::close):
- platform/text/SegmentedString.h:
- 1:54 AM Changeset in webkit [62171] by
-
- 2 edits in trunk/WebKit/qt
Unreviewed Symbian build fix.
[Qt] Update the def files to link DumpRenderTree.
- symbian/eabi/QtWebKitu.def:
- 1:45 AM Changeset in webkit [62170] by
-
- 3 edits in trunk/WebKitTools
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch land allow the user to continue even if the builders are red
https://bugs.webkit.org/show_bug.cgi?id=41395
I don't think it's good that we've been teaching people
to always pass --ignore-builders. At least land is now
useable w/o --ignore-builders.
- Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
- 1:35 AM Changeset in webkit [62169] by
-
- 2 edits in trunk/WebKit/qt
2010-06-30 Samuel Nevala <samuel.nevala@digia.com>
Reviewed by Simon Hausmann.
[Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
https://bugs.webkit.org/show_bug.cgi?id=38720
Load qttest_p4.prf under QTDIR_build.
- tests/tests.pri:
- 1:28 AM Changeset in webkit [62168] by
-
- 10 edits in trunk
2010-06-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344
We now pass an additional 60 subtests for the
html5lib test suite. Boo-ya.
- html5lib/runner-expected.txt:
2010-06-29 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344
We're using \0 as the EndOfFile marker as HTML5 replaces
all other \0 with \0xFFFD. Added some special case logic
to InputStreamPreprocessor::peek not to replace \0 when
its being used at the end of a stream.
This fixed 60 subtests in html5lib/runner.html.
There are still at least two states (BogusCommentState and
CDATASectionState) which do not have proper EOF support.
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled):
- html/HTMLInputStream.h: (WebCore::HTMLInputStream::markEndOfFile): (WebCore::HTMLInputStream::haveSeenEndOfFile):
- html/HTMLToken.h: (WebCore::HTMLToken::makeEndOfFile):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitEndOfFile):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek): (WebCore::HTMLTokenizer::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
- 1:23 AM Changeset in webkit [62167] by
-
- 2 edits in trunk/WebKit/gtk
2010-06-30 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256
Make sure the set_filename function is called after handling the
'download-requested' signal for the asynchronous test. This change
is needed because it could happen, with the current code, that the
set_filename () function got called too early in the mainloop,
therefore screwing the tests because the 'theDownload' global
variable wouldn't be properly set yet.
With this modification we ensure the set_filename() function gets
called always after handling the download-requested signal,
therefore avoiding potentialproblems.
- tests/testdownload.c: (set_filename): (handle_download_requested_cb): (download_requested_cb): (download_requested_asynch_cb): (test_webkit_download_perform):
- 1:18 AM Changeset in webkit [62166] by
-
- 6 edits in trunk
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337
- html5lib/resources/webkit01.dat: Add a test for double body.
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337
Had to teach ElementStack to store pointers to html, head, and body
elements.
This fixed a few tests in LayoutTests/html5lib.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::mergeAttributesFromTokenIntoElement): (WebCore::HTMLTreeBuilder::insertHTMLStartTagInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::createElementAndAttachToCurrent): (WebCore::HTMLTreeBuilder::insertHTMLHtmlElement): (WebCore::HTMLTreeBuilder::insertHTMLHeadElement): (WebCore::HTMLTreeBuilder::insertHTMLBodyElement): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::ElementStack): (WebCore::HTMLTreeBuilder::ElementStack::popHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHtmlElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLBodyElement): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::removeHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::ElementStack::htmlElement): (WebCore::HTMLTreeBuilder::ElementStack::headElement): (WebCore::HTMLTreeBuilder::ElementStack::bodyElement): (WebCore::HTMLTreeBuilder::ElementStack::pushCommon): (WebCore::HTMLTreeBuilder::ElementStack::popCommon): (WebCore::HTMLTreeBuilder::ElementStack::removeNonFirstCommon):
- 1:15 AM Changeset in webkit [62165] by
-
- 2 edits in trunk/LayoutTests
2010-06-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed: update Chromium test expectations with a crashing test.
- platform/chromium/test_expectations.txt:
- 1:12 AM Changeset in webkit [62164] by
-
- 4 edits in trunk
2010-06-30 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528
Implemented the get_run_attributes and get_default_attributes
functions for the ATK_TEXT role.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getAttributeSetForAccessibilityObject): (compareAttribute): (attributeSetDifference): (accessibilityObjectLength): (getAccessibilityObjectForOffset): (getRunAttributesFromAccesibilityObject): (webkit_accessible_text_get_run_attributes): (webkit_accessible_text_get_default_attributes):
2010-06-30 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528
Added new tests for accessible text attributes
- tests/testatk.c: (compAtkAttribute): (compAtkAttributeName): (atkAttributeSetAttributeHasValue): (atkAttributeSetAreEqual): (testWebkitAtkTextAttributes): (main):
- 1:00 AM Changeset in webkit [62163] by
-
- 2 edits in trunk/WebCore
2010-06-30 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix Sec-WebSocketKey{1,2} headers.
According to WebSocket specification, a value of Sec-WebSocketKey{1,2} header
should not start or end with a space.
WebSocket: Malformed handshake headers in a worker due to rand_s failing
https://bugs.webkit.org/show_bug.cgi?id=41327
No new tests. ASSERT should catch the problem.
- websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey):
- 12:43 AM Changeset in webkit [62162] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-06-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed: provide custom expectations and reenable the test for Chromium.
- platform/chromium/editing/pasteboard/5761530-1-expected.txt: Added.
Jun 29, 2010:
- 11:47 PM Changeset in webkit [62161] by
-
- 3 edits2 adds in trunk
2010-06-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 41339 - unicode-range property only with a descending range
causes a crash
- fast/css/font-face-descending-unicode-range-expected.txt: Added.
- fast/css/font-face-descending-unicode-range.html: Added.
2010-06-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 41339 - unicode-range property only with a descending range
causes a crash
Test: fast/css/font-face-descending-unicode-range.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
- 10:13 PM Changeset in webkit [62160] by
-
- 4 edits in trunk/LayoutTests
2010-06-29 MORITA Hajime <morrita@google.com>
Unreviewed. Updated test expectations for change at r62156
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/chromium/test_expectations.txt:
- 8:49 PM QtWebKitBackportingFixes edited by
- (diff)
- 8:46 PM Changeset in webkit [62159] by
-
- 2 edits in trunk/WebCore
2010-06-29 Abhinav Mithal <abhinav.mithal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Fix doube-deallocation while destroying PluginContainerSymbian
https://bugs.webkit.org/show_bug.cgi?id=37303
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformDestroy):
- 7:28 PM Changeset in webkit [62158] by
-
- 16 edits in trunk
2010-06-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172
- fast/canvas/webgl/gl-object-get-calls-expected.txt: Add a test case for getAttachedShaders().
- fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.
2010-06-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172
- bindings/js/JSWebGLRenderingContextCustom.cpp: JS binding for getAttachedShaders(). (WebCore::JSWebGLRenderingContext::getAttachedShaders):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: V8 binding for getAttachedShaders(). (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Implementation of getAttachedShaders(). (WebCore::WebGLRenderingContext::findShader): Helper function to find a shader object from its name.
- html/canvas/WebGLRenderingContext.h: Declaration of getAttachedShaders().
- html/canvas/WebGLRenderingContext.idl: Ditto.
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::getAttachedShaders): Implementation of getAttachedShaders().
2010-06-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172
- public/WebGraphicsContext3D.h: Declaration of getAttachedShaders().
- src/GraphicsContext3D.cpp: Implementation of getAttachedShaders().
- src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
- src/WebGraphicsContext3DDefaultImpl.h: Declaration of getAttachedShaders().
- 6:52 PM Changeset in webkit [62157] by
-
- 3 edits in trunk
2010-06-29 Antoine Labour <piman@chromium.org>
Reviewed by Dimitri Glazkov.
Only call Windows-specific PlatformSkiaContext functions on Windows.
- WebCore/platform/graphics/chromium/LayerChromium.cpp:
- WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:
- 6:29 PM Changeset in webkit [62156] by
-
- 4 edits in trunk
2010-06-29 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: [Chromium] <progress> appearance on windows looks not good
https://bugs.webkit.org/show_bug.cgi?id=41343
Skipped a test with outdated expectation. We need to rebaseline it.
- platform/chromium/test_expectations.txt:
2010-06-29 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: [Chromium] <progress> appearance on windows looks not good
https://bugs.webkit.org/show_bug.cgi?id=41343
RenderThemeChromiumWin::paintProgressBar() should return false,
which indicates the widget is painted.
Test: fast/dom/HTMLProgressElement/progress-element.html
- rebaselined with a wrong expectation.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
- 6:16 PM Changeset in webkit [62155] by
-
- 6 edits in trunk
2010-06-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Fix http/tests/local/blob/send-data-blob.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=41228
Fix a regression bug in the line-conversion code.
Rewrite the line-conversion function with simpler functions to
make it less error prone.
No new tests as this is for bug fixes.
- platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString):
2010-06-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Fix http/tests/local/blob/send-data-blob.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=41228
Fix the cgi code to make it work with cygwin perl.
Also fix test expectations for Windows.
- http/tests/resources/post-and-verify-hybrid.cgi:
- platform/chromium/test_expectations.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 6:03 PM Changeset in webkit [62154] by
-
- 2 edits in trunk/LayoutTests
2010-06-29 James Robinson <jamesr@chromium.org>
Unreviewed chromium expectations update.
Mark fast/parser/residual-style-hang.html as slow on windows debug because it is.
- platform/chromium/test_expectations.txt:
- 5:30 PM Changeset in webkit [62153] by
-
- 17 edits in trunk
WebCore: Implementing DatabaseSync::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=40607
Reviewed by Darin Fisher.
- Moved some common code from Database to AbstractDatabase.
- Made performOpenAndVerify() virtual, since DatabaseSync doesn't need to interact with DatabaseThread.
- Removed the m_creationCallback field, since it's only needed in the openDatabase{Sync} methods.
- storage/AbstractDatabase.cpp:
(WebCore::retrieveTextResultFromDatabase):
(WebCore::setTextValueInDatabase):
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::closeDatabase):
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::scriptExecutionContext):
(WebCore::AbstractDatabase::securityOrigin):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::databaseVersionKey):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::versionMatchesExpected):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::disableAuthorizer):
(WebCore::AbstractDatabase::enableAuthorizer):
(WebCore::AbstractDatabase::setAuthorizerReadOnly):
(WebCore::AbstractDatabase::lastActionChangedDatabase):
(WebCore::AbstractDatabase::lastActionWasInsert):
(WebCore::AbstractDatabase::resetDeletes):
(WebCore::AbstractDatabase::hadDeletes):
(WebCore::AbstractDatabase::resetAuthorizer):
- storage/AbstractDatabase.h:
(WebCore::AbstractDatabase::opened):
(WebCore::AbstractDatabase::isNew):
(WebCore::AbstractDatabase::databaseDebugName):
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
(WebCore::Database::stop):
(WebCore::Database::performOpenAndVerify):
- storage/Database.h:
(WebCore::Database::sqliteDatabase):
- storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::denyBasedOnTableName):
- storage/DatabaseAuthorizer.h:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::markAsDeletedAndClose):
(WebCore::CloseSyncDatabaseOnContextThreadTask::create):
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask):
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask):
(WebCore::DatabaseSync::closeImmediately):
- storage/DatabaseSync.h:
- storage/DatabaseTask.cpp:
(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):
- storage/DatabaseTask.h:
(WebCore::DatabaseOpenTask::create):
WebKit/chromium: Simplify the WebDatabase interface.
https://bugs.webkit.org/show_bug.cgi?id=40607
Reviewed by Darin Fisher.
Do not ref()/deref() the private AbstractDatabase member. This
allows us to use WebDatabase in the destructors of the DB
classes.
- public/WebDatabase.h:
(WebKit::WebDatabase::WebDatabase):
- src/WebDatabase.cpp:
(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::WebDatabase):
LayoutTests: Uncomment some test cases in open-database-sync-inputs, and
comment out for now the ones that fail in V8.
https://bugs.webkit.org/show_bug.cgi?id=40607
Reviewed by Darin Fisher.
- fast/workers/storage/open-database-sync-inputs-expected.txt:
- fast/workers/storage/resources/open-database-sync-inputs.js:
(catch):
- 3:57 PM Changeset in webkit [62152] by
-
- 7 edits in trunk
2010-06-29 François Sausset <François Sausset>
Reviewed by Darin Adler.
Add a test when a msubsup element is wrapped in a mrow element
https://bugs.webkit.org/show_bug.cgi?id=36525
- mathml/presentation/subsup.xhtml:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
2010-06-29 François Sausset <François Sausset>
Reviewed by Darin Adler.
Fix a bug when a msubsup element is inside a mrow element
https://bugs.webkit.org/show_bug.cgi?id=36525
Test: mathml/presentation/subsup.xhtml
- mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
- 3:27 PM Changeset in webkit [62151] by
-
- 5 edits in tags/Safari-534.1.4
Versioning.
- 3:22 PM Changeset in webkit [62150] by
-
- 4 edits2 adds in trunk
2010-06-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
uniformmatrix* should generate INVALID_VALUE with transpose = true
https://bugs.webkit.org/show_bug.cgi?id=41235
- fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Added.
- fast/canvas/webgl/gl-uniformmatrix4fv.html: Added.
2010-06-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
uniformmatrix* should generate INVALID_VALUE with transpose = true
https://bugs.webkit.org/show_bug.cgi?id=41235
Test: fast/canvas/webgl/gl-uniformmatrix4fv.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniformMatrix2fv): Call validateUniformMatrixParameters instead. (WebCore::WebGLRenderingContext::uniformMatrix3fv): Ditto. (WebCore::WebGLRenderingContext::uniformMatrix4fv): Ditto. (WebCore::WebGLRenderingContext::validateUniformMatrixParameters): Validate input parameters for uniformMatrix*().
- html/canvas/WebGLRenderingContext.h: Declare validateUniformMatrixParameters().
- 3:19 PM Changeset in webkit [62149] by
-
- 1 copy in tags/Safari-534.1.4
New tag.
- 3:01 PM Changeset in webkit [62148] by
-
- 4 edits in trunk/JavaScriptCore
2010-06-29 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Bug 41238 - RegExp performance slow on Dromaeo benchmark
Other javascript engines appear to cache prior results of regular
expression operations.
Suggest adding some sort of caching mechanism to regular expression
processing.
Added a single entry cache of match() results to RegExp class.
Also added performance improvements to UString == operator.
First check the impls for equality. Then get the length of
each of the non-null impls. Next check the sizes for equality.
Then check the data for the case of different impls that point
to the same data (most likely due to substrings from the beginning of
another string). Lastly we check the underlying data for equality.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
- runtime/RegExp.h:
- runtime/UString.h: (JSC::operator==):
- 2:27 PM BuildBot edited by
- (diff)
- 2:25 PM Changeset in webkit [62147] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-06-29 Robert Hogan <robert@webkit.org>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Update test expectations for tests added in r62134.
- platform/qt/fast/text/setData-dirty-lines-expected.txt: Added.
- platform/qt/fast/text/splitText-dirty-lines-expected.txt: Added.
- 1:47 PM Changeset in webkit [62146] by
-
- 6 edits in trunk/LayoutTests
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Results for editing/pasteboard/5761530-1.html are wrong
Qt seems to have the correct result here. So unskip on Qt and
skip on other platforms so can be fixed.
- editing/pasteboard/5761530-1-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 1:16 PM Changeset in webkit [62145] by
-
- 11 edits2 adds in trunk
2010-06-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398
Added support for UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixel store
parameters to texImage2D and texSubImage2D entry points taking ArrayBufferView.
More cleanly separated the unpacking and packing phases of user-supplied pixel data
in GraphicsContext3D, and added support for unpack alignment. Fixed bug in handling
of unpackAlignment in GraphicsContext3D::flipVertically. Necessarily added
validation of the amount of data passed to texImage2D and texSubImage2D. Modified
fast/canvas/webgl/tex-image-with-format-and-type.html to include premultiplied alpha
tests for relevant source formats; added new test which exercises all combinations
of UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL, and UNPACK_ALIGNMENT pixel
store parameters.
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::validateTexFuncData):
- html/canvas/WebGLRenderingContext.h:
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::GraphicsContext3D::flipVertically): (WebCore::doUnpackingAndPacking): (WebCore::computeIncrementParameters): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
2010-06-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398
Added support for UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixel store
parameters to texImage2D and texSubImage2D entry points taking ArrayBufferView.
More cleanly separated the unpacking and packing phases of user-supplied pixel data
in GraphicsContext3D, and added support for unpack alignment. Fixed bug in handling
of unpackAlignment in GraphicsContext3D::flipVertically. Necessarily added
validation of the amount of data passed to texImage2D and texSubImage2D. Modified
fast/canvas/webgl/tex-image-with-format-and-type.html to include premultiplied alpha
tests for relevant source formats; added new test which exercises all combinations
of UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL, and UNPACK_ALIGNMENT pixel
store parameters.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
- fast/canvas/webgl/tex-image-with-format-and-type-expected.txt:
- fast/canvas/webgl/tex-image-with-format-and-type.html:
- 1:08 PM Changeset in webkit [62144] by
-
- 2 edits in trunk/WebCore
2010-06-29 Patrick Gansterer <paroga@paroga.com>
Reviewed by Dirk Schulze.
Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) after r61667.
https://bugs.webkit.org/show_bug.cgi?id=41367
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): Add missing ENABLE(SVG_FOREIGN_OBJECT).
- 1:01 PM Changeset in webkit [62143] by
-
- 2 edits in trunk/WebKit2
2010-06-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a private Message class template
https://bugs.webkit.org/show_bug.cgi?id=41370
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::Message): (CoreIPC::Connection::Message::arguments):
- 12:52 PM Changeset in webkit [62142] by
-
- 2 edits in trunk/WebCore
2010-06-29 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix after r62118.
https://bugs.webkit.org/show_bug.cgi?id=41365
- rendering/RenderSVGRoot.cpp: Inlude missing RenderSVGResource.h.
- 12:38 PM Changeset in webkit [62141] by
-
- 2 edits in trunk/LayoutTests
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] http/tests/security/mixedContent tests now pass
- platform/qt/Skipped:
- 11:37 AM Changeset in webkit [62140] by
-
- 10 edits in trunk
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] implement dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260
Unskip fast/preloader tests.
- platform/qt/Skipped:
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpResourceResponseMIMETypes):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
- WebCoreSupport/FrameLoaderClientQt.h:
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpResourceResponseMIMETypes):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:31 AM Changeset in webkit [62139] by
-
- 8 edits in trunk/WebCore
2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62052.
http://trac.webkit.org/changeset/62052
https://bugs.webkit.org/show_bug.cgi?id=41357
Causes crashes in JSLazyEventListener::initializeFunction (see
bug 41352) (Requested by aroben on #webkit).
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/js/ScriptEventListener.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/v8/ScriptEventListener.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- 11:30 AM Changeset in webkit [62138] by
-
- 3 edits in trunk/JavaScriptCore
2010-06-29 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Geoffrey Garen.
WTF::HashSet iterators are quasi-mutable. Changing the value through
dereferencing an iterator will not change the behavior of methods like
contains or find, but will change the behavior of iterating.
- wtf/HashSet.h: (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::remove):
- wtf/HashTable.h:
- 11:30 AM Changeset in webkit [62137] by
-
- 2 edits in trunk/WebCore
2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62129.
http://trac.webkit.org/changeset/62129
https://bugs.webkit.org/show_bug.cgi?id=41362
Needed to roll out r62052 (see bug 41357) (Requested by aroben
on #webkit).
- bindings/js/ScriptEventListener.cpp: (WebCore::createWindowAttributeEventListener):
- 11:08 AM Changeset in webkit [62136] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-29 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Fisher.
A crash caused by the patch of bug 40608.
https://bugs.webkit.org/show_bug.cgi?id=41334
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds):
- 10:46 AM Changeset in webkit [62135] by
-
- 2 edits in trunk/WebCore
Speculative fix for <rdar://problem/8071558> CrashTracer: [USER]
2300+ crashes in Safari at com.apple.WebCore:
WebCore::FrameView::scheduleRelayout + 352
Reviewed by Darin Adler.
Unfortunately, we don't have a reproducible case for this bug, and
therefore, we do not have a layout test either. It is pretty clear
from the logs that m_frame->settings() is null in
FrameView::scheduleRelayout() in the crashing case.
m_frame->settings() is null whenever page is null. Everywhere else
in FrameView.cpp we null-check either page or settings before using
settings. It seems plausible to me that scheduleRelayout could be
called when page is null, so the fix is just to add null-checks.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
- 10:42 AM Changeset in webkit [62134] by
-
- 4 edits8 adds in trunk
<rdar://problem/7975842> Certain text is repeated after using splitText()
Reviewed by Darin Adler.
WebCore:
Tests: fast/text/setData-dirty-lines.html
fast/text/splitText-dirty-lines.html
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Call RenderText::setTextWithOffset() rather than
setText(), because only the former correctly dirties line boxes.
- dom/Text.cpp:
(WebCore::Text::splitText): Ditto.
LayoutTests:
- fast/text/setData-dirty-lines-expected.checksum: Added.
- fast/text/setData-dirty-lines-expected.png: Added.
- fast/text/setData-dirty-lines-expected.txt: Added.
- fast/text/setData-dirty-lines.html: Added.
- fast/text/splitText-dirty-lines-expected.checksum: Added.
- fast/text/splitText-dirty-lines-expected.png: Added.
- fast/text/splitText-dirty-lines-expected.txt: Added.
- fast/text/splitText-dirty-lines.html: Added.
- 10:40 AM Changeset in webkit [62133] by
-
- 13 edits in trunk/WebKit/chromium
2010-06-29 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
[chromium]: Update webkit for chromium multi dll build.
- Export more webkit APIs for chromium multi dll build.
- Update DumpRenderTree sources so it can build with webkit.dll
- Temp disable webkit unit tests for chromium multi dll build.
- WebKit.gyp:
- public/WebAccessibilityCache.h:
- public/WebAccessibilityObject.h:
- public/WebEventListener.h:
- public/WebGeolocationServiceMock.h:
- public/WebGraphicsContext3D.h:
- public/WebIDBDatabaseError.h: (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
- public/WebNotification.h:
- public/WebPasswordFormData.h:
- public/WebSearchableFormData.h:
- public/WebStorageEventDispatcher.h:
- public/WebString.h: (WebKit::WebString::WebString): (WebKit::WebString::operator=):
- 10:26 AM Changeset in webkit [62132] by
-
- 2 edits in trunk/WebCore
2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62073.
http://trac.webkit.org/changeset/62073
https://bugs.webkit.org/show_bug.cgi?id=41359
Necessary to fix chromium build when r62052 is rolled out.
(Requested by dave_levin on #webkit).
- bindings/v8/ScriptEventListener.h:
- 10:11 AM Changeset in webkit [62131] by
-
- 3 edits in trunk/LayoutTests
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Gustavo Noronha Silva.
platform/gtk/accessibility/name-from-label test needs updating
https://bugs.webkit.org/show_bug.cgi?id=41355
Updated test and expected results to match changes introduced
with patch for bug 40009 (make it more coherent with other ports)
- platform/gtk/accessibility/name-from-label-expected.txt:
- platform/gtk/accessibility/name-from-label.html:
- 10:11 AM Changeset in webkit [62130] by
-
- 15 edits in trunk
2010-06-29 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Hooking up WebGL layers to the gpu-compositor. Implement missing
methods to set the contents of a GraphicsLayer with a platform specific WebGL
Layer, and to update the contents of the WebGL Layer when needed.
https://bugs.webkit.org/show_bug.cgi?id=41243
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToWebGL):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::removeAllSublayers): No need to call setNeedsCommit() from here as the previous call to layer->removeFromSuperlayer() will have that effect (and we only need to notify the owner if there were actually any sublayers removed).
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::create): (WebCore::WebGLLayerChromium::updateTextureContents): (WebCore::WebGLLayerChromium::setContext):
- 10:03 AM Changeset in webkit [62129] by
-
- 2 edits in trunk/WebCore
2010-06-29 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Nikolas Zimmermann.
Buildfix for --minimal build after r62052
https://bugs.webkit.org/show_bug.cgi?id=41338
- bindings/js/ScriptEventListener.cpp: #if ENABLE(SVG) guards added. (WebCore::createWindowAttributeEventListener):
- 9:30 AM Changeset in webkit [62128] by
-
- 2 edits in trunk/WebCore
Build fix. Not reviewd.
CGColor is only used for PLATFORM(CG). Conditionalize include
to correct build failure for WinCairo.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
Conditionalize use of CGColor.
- 9:24 AM Changeset in webkit [62127] by
-
- 9 edits in trunk/LayoutTests
2010-06-29 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed text expectations update after r62121.
- platform/chromium-linux/fast/css/font-face-opentype-expected.checksum:
- platform/chromium-linux/fast/css/font-face-opentype-expected.png:
- platform/chromium-linux/fast/css/font-face-woff-expected.checksum:
- platform/chromium-linux/fast/css/font-face-woff-expected.png:
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:20 AM Changeset in webkit [62126] by
-
- 2 edits in trunk
Fix two small typos in my most recent ChangeLog entries.
- 9:09 AM Changeset in webkit [62125] by
-
- 4 edits in trunk
2010-06-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Clean up the source lists in the GNUMakefile.am files
https://bugs.webkit.org/show_bug.cgi?id=41229
Clean up the GNUMakefile.ac a little bit. Alphabetize and conglomerate
the source lists.
- GNUmakefile.am:
2010-06-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Clean up the source lists in the GNUMakefile.am files
https://bugs.webkit.org/show_bug.cgi?id=41229
Clean up the GNUMakefile.ac a little bit. Alphabetize and conglomerate
the source lists.
- GNUmakefile.am:
- 8:38 AM Changeset in webkit [62124] by
-
- 3 edits in trunk/WebCore
2010-06-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DragDataGtk should use DataObjectGtk as the platformDragData
https://bugs.webkit.org/show_bug.cgi?id=40307
Use DataObjectGtk as the platformDragData for DragDataGtk. DataObjectGtk
contains all the information necessary to keep track of drops in progress.
- platform/DragData.h: Use a DataObjectGtk* as the platform drag data.
- platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles): Retrieve information via platformDragData. (WebCore::DragData::asFilenames): Ditto. (WebCore::DragData::containsPlainText): Ditto. (WebCore::DragData::asPlainText): Ditto. (WebCore::DragData::createClipboard): Create the Clipboard with the platformDragData. (WebCore::DragData::containsCompatibleContent): Retrieve information via platformDragData. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto. (WebCore::DragData::asFragment): Ditto.
- 8:36 AM Changeset in webkit [62123] by
-
- 2 edits in trunk/LayoutTests
2010-06-29 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Update baseline r62111.
- platform/gtk/accessibility/name-from-label-expected.txt:
- 8:31 AM WebKit Team edited by
- (diff)
- 8:22 AM Changeset in webkit [62122] by
-
- 2 edits in trunk/WebCore
2010-06-29 Adam Langley <agl@chromium.org>
Build fix. Not reviewd.
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint): The name of the Skia function changed between writing this patch and commiting it.
- 8:01 AM Changeset in webkit [62121] by
-
- 8 edits in trunk
2010-06-29 Adam Langley <agl@chromium.org>
Reviewed by Kent Tamura.
[chromium] Support forced autohinting.
Freetype (the typical font rendering on Linux) includes an 'autohinter':
an algorithm for hinting glyph shapes without using the embedded hinting
bytecode in a font.
Some people prefer the autohinter's results, so we support forcing its
use.
This change also fixes a bug where two FontPlatformData structures would
compare equal, even if their rendering styles were different.
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint): In order to compare FontPlatformData structures we need to make sure that they are initialised. (WebCore::FontPlatformData::operator==):
- platform/graphics/chromium/FontRenderStyle.h: (WebCore::FontRenderStyle::FontRenderStyle): (WebCore::FontRenderStyle::operator==): This fixes the case where two FontPlatformData structures, differing only by rendering style, would compare equal.
- 7:42 AM Changeset in webkit [62120] by
-
- 2 edits in trunk/WebCore
2010-06-29 Laszlo Gombos <Laszlo Gombos>
Unreviewed, Symbian build fix.
Add more directories to USERINCLUDE so that they get included
before the Symbian system headers.
This is a workaround to some toolchain problems; bug 31273 is used to
find a better solution.
No new tests as there is no new functionality.
- WebCore.pro:
- 7:32 AM Changeset in webkit [62119] by
-
- 3 edits in trunk/JavaScriptCore
2010-06-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix QtScript build after QScriptValuePrivate ctor changes
https://bugs.webkit.org/show_bug.cgi?id=41307
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::prototype):
- qt/benchmarks/qscriptengine/qscriptengine.pro:
- 7:26 AM Changeset in webkit [62118] by
-
- 34 edits in trunk/WebCore
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Cleanup SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=41347
Remove SVGRenderBase base class from all SVG renderers. It was meant as temporary solution until all SVG renderers inherit from RenderSVGModelObject,
though this is not going to happen. RenderSVGModelObject inherits from RenderObject, making it impossible to inherit eg. RenderSVGImage from it, as
it already indirectly inherits from RenderObject, through RenderImage. Other examples are RenderForeignObject (RenderBlock inheritance),
RenderSVGInlineText (RenderText inheritance) etc.
Rename SVGRenderBase to SVGRenderSupport, just like the file is named, remove all free functions, and make them all static functions in SVGRenderSupport.
We can still share code between all SVG renderers, but don't need a special base class for all renderers -> shrink size of all SVG renderers.
Doesn't affect any test.
- rendering/RenderBox.cpp: Remove localTransform() override, not needed at all.
- rendering/RenderBox.h: Ditto.
- rendering/RenderForeignObject.cpp: s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::clippedOverflowRectForRepaint): (WebCore::RenderForeignObject::computeRectForRepaint): (WebCore::RenderForeignObject::nodeAtFloatPoint): (WebCore::RenderForeignObject::mapLocalToContainer):
- rendering/RenderPath.cpp: (WebCore::BoundingRectStrokeStyleApplier::strokeStyle): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::RenderPath::paint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderPath::nodeAtFloatPoint): Ditto. (WebCore::RenderPath::updateCachedBoundaries): Ditto.
- rendering/RenderSVGBlock.h: Remove SVGRenderBase inheritance.
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): layoutChildren is a static function in SVGRenderSupport now. (WebCore::RenderSVGContainer::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport. (WebCore::RenderSVGContainer::objectBoundingBox): computeContainerBoundingBox is a static function in SVGRenderSupport now. (WebCore::RenderSVGContainer::strokeBoundingBox): Ditto. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): Remove call to computeContainerBoundingBox, use strokeBoundingBox instead, for consistency. (WebCore::RenderSVGContainer::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now.
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout): layoutChildren is a static function in SVGRenderSupport now.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): prepareToRenderSVGContent/finishRenderSVGContent are static functions in SVGRenderSupport now. (WebCore::RenderSVGImage::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGImage::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now. (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): intersectRepaintRectWithResources is a static function in SVGRenderSupport now. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGImage::computeRectForRepaint): Ditto. (WebCore::RenderSVGImage::mapLocalToContainer): Ditto.
- rendering/RenderSVGImage.h: Remove SVGRenderBase inheritance.
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): findTextRootObject is a static function in SVGRenderSupport now. (WebCore::RenderSVGInline::strokeBoundingBox): Ditto. (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): Ditto. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGInline::computeRectForRepaint): Ditto,. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto. (WebCore::RenderSVGInline::absoluteQuads): findTextRootObject is a static function in SVGRenderSupport now.
- rendering/RenderSVGInline.h: Remove SVGRenderBase inheritance.
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGModelObject::computeRectForRepaint): Ditto. (WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto. (WebCore::RenderSVGModelObject::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport.
- rendering/RenderSVGModelObject.h: Remove SVGRenderBase inheritance.
- rendering/RenderSVGResource.cpp: (WebCore::invalidatePaintingResource): Moved here from SVGRenderSupport (static inline helper function). (WebCore::RenderSVGResource::invalidateAllResourcesOfRenderer): Moved here from SVGRenderSupport and renamed from deregisterFromResources.
- rendering/RenderSVGResource.h: Expose invalidateAllResourcesOfRenderer function.
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData): renderSubtreeToImage is a static function in SVGRenderSupport now. (WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): findTextRootObject is a static function in SVGRenderSupport now. (WebCore::clipToTextMask): Ditto. (WebCore::RenderSVGResourceGradient::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::RenderSVGResourceGradient::postApplyResource): findTextRootObject is a static function in SVGRenderSupport now.
- rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::applyViewportClip): s/SVGRenderBase/SVGRenderSupport/
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::createMaskImage): renderSubtreeToImage is a static function in SVGRenderSupport now.
- rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::clampImageBufferSizeToViewport): Moved here from SVGRenderSupport. (WebCore::RenderSVGResourcePattern::createTileImage): renderSubtreeToImage is a static function in SVGRenderSupport now.
- rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): layoutChildren is a static function in SVGRenderSupport now. (WebCore::RenderSVGRoot::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport. (WebCore::RenderSVGRoot::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates): Remove call to computeContainerBoundingBox, use strokeBoundingBox instead, for consistency.
- rendering/RenderSVGRoot.h: Remove localTransform() override, no longer needed. Remove SVGRenderBase inheritance. (WebCore::RenderSVGRoot::objectBoundingBox): Inlined for speeed. (WebCore::RenderSVGRoot::strokeBoundingBox): computeContainerBoundingBox is a static function in SVGRenderSupport now.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGText::computeRectForRepaint): Ditto. (WebCore::RenderSVGText::mapLocalToContainer): Ditto. (WebCore::RenderSVGText::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now. (WebCore::RenderSVGText::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGText::repaintRectInLocalCoordinates): intersectRepaintRectWithResources is a static function in SVGRenderSupport now.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): pointInClippingArea is a static function in SVGRenderSupport now.
- rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport.
- rendering/SVGRenderSupport.cpp: Make it impossible to construct the class. Remove virtual destructor, made all methods static. (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::SVGRenderSupport::computeRectForRepaint): Ditto. (WebCore::SVGRenderSupport::mapLocalToContainer): Ditto. (WebCore::SVGRenderSupport::prepareToRenderSVGContent): Ditto. (WebCore::SVGRenderSupport::finishRenderSVGContent): Ditto. (WebCore::SVGRenderSupport::renderSubtreeToImage): Made static. (WebCore::SVGRenderSupport::computeContainerBoundingBox): Ditto. (WebCore::SVGRenderSupport::layoutChildren): Ditto. (WebCore::SVGRenderSupport::isOverflowHidden): s/SVGRenderBase/SVGRenderSupport/ (WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Ditto. (WebCore::SVGRenderSupport::pointInClippingArea): Made static. (WebCore::SVGRenderSupport::dashArrayFromRenderingStyle): Ditto. (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Ditto. (WebCore::SVGRenderSupport::findTextRootObject): Ditto.
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): dashArrayFromRenderingStyle is a static function in SVGRenderSupport now.
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): s/SVGRenderBase/SVGRenderSupport/
- rendering/SVGRootInlineBox.h: Remove SVGRenderBase inheritance.
- svg/SVGFEImageElement.cpp: Add RenderObject.h include, otherwhise it won't build anymore. (WebCore::SVGFEImageElement::build): renderSubtreeToImage is a static function in SVGRenderSupport now.
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport.
- 7:26 AM Changeset in webkit [62117] by
-
- 2 edits in trunk/LayoutTests
2010-06-29 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed test expectations update for stable passing tests.
- platform/chromium/test_expectations.txt:
- 7:19 AM Changeset in webkit [62116] by
-
- 3 edits in trunk/WebKitTools
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Resize scene when Qt DRT WebPage receives a geometry change request
https://bugs.webkit.org/show_bug.cgi?id=41173
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::setViewGeometry):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- 7:03 AM Changeset in webkit [62115] by
-
- 3 edits in trunk/WebKitTools
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Deal with postEvent in case of graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=41174
QGraphicsScene does not have a postEvent method, so make scene
send the event, in case of graphics based DRT, and delete it after that.
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::scheduleAsynchronousClick): (EventSender::replaySavedEvents): (EventSender::postEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 6:58 AM Changeset in webkit [62114] by
-
- 2 edits in trunk/WebCore
2010-06-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[PNG decoder] direct access to jmpbuf is deprecated in libpng >= 1.4.0beta103
https://bugs.webkit.org/show_bug.cgi?id=40907
Define a JMPBUF macro to cope with deprecation of the jmpbuf
attribute in libpng >= 1.4.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::decodingFailed): (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 6:51 AM Changeset in webkit [62113] by
-
- 2 edits in trunk/WebKitTools
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=41172
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::switchFocus):
- 6:28 AM Changeset in webkit [62112] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing pixel test results.
- platform/mac/fast/css/nested-rounded-corners-expected.checksum: Added.
- platform/mac/fast/css/nested-rounded-corners-expected.png: Added.
- platform/mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
- platform/mac/fast/js/missing-title-end-tag-js-expected.png: Added.
- 6:27 AM Changeset in webkit [62111] by
-
- 11 edits in trunk
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Make DRT more coherent with other ports to allow reusing more tests
https://bugs.webkit.org/show_bug.cgi?id=40009
Update GTK a11y tests to follow new prefixes coming from DRT
- platform/gtk/accessibility/object-attributes-expected.txt:
- platform/gtk/accessibility/object-attributes.html:
- platform/gtk/accessibility/object-with-title-expected.txt:
- platform/gtk/accessibility/object-with-title.html:
- platform/gtk/accessibility/table-hierarchy-expected.txt:
- platform/gtk/accessibility/table-hierarchy.html:
- platform/gtk/accessibility/title-and-alt-expected.txt:
- platform/gtk/accessibility/title-and-alt.html:
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Make DRT more coherent with other ports to allow reusing more tests
https://bugs.webkit.org/show_bug.cgi?id=40009
Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
are used when returning those values, for coherency with other ports.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description):
- 6:16 AM Changeset in webkit [62110] by
-
- 2 edits in trunk/WebKitTools
2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62106.
http://trac.webkit.org/changeset/62106
https://bugs.webkit.org/show_bug.cgi?id=41346
"Broke editing tests" (Requested by xan_ on #webkit).
- Scripts/old-run-webkit-tests:
- 6:08 AM Changeset in webkit [62109] by
-
- 1 edit in trunk/WebCore/ChangeLog
[Qt/Symbian] Fixed deployment paths for WebKit declarative plugin.
Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2010-06-29
Reviewed by Simon Hausmann.
- WebCore.pro:
- 6:08 AM Changeset in webkit [62108] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fixed deployment paths for WebKit declarative plugin.
Signed-off-by: Simon Hausmann <simon.hausmann@nokia.com>
- 5:49 AM Changeset in webkit [62107] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-06-29 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed test expectations update.
- platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Added.
- platform/chromium-win/svg/css/text-shadow-multiple-expected.png: Added.
- platform/chromium-win/svg/css/text-shadow-multiple-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:39 AM Changeset in webkit [62106] by
-
- 2 edits in trunk/WebKitTools
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
- Scripts/old-run-webkit-tests:
- 5:25 AM Changeset in webkit [62105] by
-
- 2 edits in trunk/WebCore
2010-06-29 Yury Semikhatsky <yurys@chromium.org>
Unreviewed: Chromium Win and Mac build fix.
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
- 5:14 AM Changeset in webkit [62104] by
-
- 77 edits2 adds in trunk/WebCore
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Move PaintInfo/PaintPhase into their own headers, out of RenderObject
https://bugs.webkit.org/show_bug.cgi?id=41342
1) Move enums PaintPhase/PaintBehaviorFlags and the PaintBehaviour typedef from RenderObject into PaintPhase.h.
Move PaintInfo from RenderObject into PaintInfo.h. Replace s/RenderObject::PaintInfo/PaintInfo/ throughout WebCore/.
Also move the OverlapTestRequestMap typedef into PaintInfo.h, and replace s/RenderObject::OverlapTestRequestMap/OverlapTestRequestMap/ everywhere.
2) Move "RenderObject* paintingRootForChildren(PaintInfo& paintInfo) const" from RenderObject to PaintInfo
and modify it to take a renderer: "void updatePaintingRootForChildren(const RenderObject* renderer)".
This changes a common idiom:
- info.paintingRoot = paintingRootForChildren(paintInfo); + info.updatePaintingRootForChildren(this);
We save resetting the paintingRoot to 0 if it was 0 already and thus do less work.
3) Move "bool shouldPaintWithinRoot(PaintInfo& paintInfo) const" from RenderObject to PaintInfo
and modify it to take a renderer: "bool shouldPaintWithinRoot(const RenderObject* renderer) const".
This changes a common idiom:
- if (!shouldPaintWithinRoot(paintInfo)) + if (!paintInfo.shouldPaintWithinRoot(this))
4) Move "void applyTransformToPaintInfo(RenderObject::PaintInfo&, const AffineTransform& localToChildTransform)"
from SVGRenderSupport to PaintInfo and rename it to "applyTransform", guarded with ENABLE(SVG) blocks.
This changes a common idiom:
- applyTransformToPaintInfo(childPaintInfo, localToParentTransform()); + childPaintInfo.applyTransform(localToParentTransform());
Add PaintInfo.h / PaintPhase.h to all build systems that list headers.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/android/RenderThemeAndroid.cpp: (WebCore::getCanvasFromInfo): (WebCore::RenderThemeAndroid::paintCheckbox): (WebCore::RenderThemeAndroid::paintButton): (WebCore::RenderThemeAndroid::paintRadio): (WebCore::RenderThemeAndroid::paintTextField): (WebCore::RenderThemeAndroid::paintTextArea): (WebCore::RenderThemeAndroid::paintSearchField): (WebCore::RenderThemeAndroid::paintCombo): (WebCore::RenderThemeAndroid::paintMenuList): (WebCore::RenderThemeAndroid::paintMenuListButton):
- platform/android/RenderThemeAndroid.h:
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::paintCheckbox): (WebCore::RenderThemeEfl::paintRadio): (WebCore::RenderThemeEfl::paintButton): (WebCore::RenderThemeEfl::paintMenuList): (WebCore::RenderThemeEfl::paintTextField): (WebCore::RenderThemeEfl::paintTextArea): (WebCore::RenderThemeEfl::paintSearchFieldDecoration): (WebCore::RenderThemeEfl::paintSearchFieldResultsButton): (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration): (WebCore::RenderThemeEfl::paintSearchFieldCancelButton): (WebCore::RenderThemeEfl::paintSearchField):
- platform/efl/RenderThemeEfl.h:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintTextArea): (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintSearchField): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::paintMediaFullscreenButton): (WebCore::RenderThemeGtk::paintMediaMuteButton): (WebCore::RenderThemeGtk::paintMediaPlayButton): (WebCore::RenderThemeGtk::paintMediaSeekBackButton): (WebCore::RenderThemeGtk::paintMediaSeekForwardButton): (WebCore::RenderThemeGtk::paintMediaSliderTrack): (WebCore::RenderThemeGtk::paintMediaSliderThumb): (WebCore::RenderThemeGtk::paintProgressBar):
- platform/gtk/RenderThemeGtk.h:
- platform/haiku/RenderThemeHaiku.cpp: (WebCore::RenderThemeHaiku::paintCheckbox): (WebCore::RenderThemeHaiku::paintRadio): (WebCore::RenderThemeHaiku::paintMenuList):
- platform/haiku/RenderThemeHaiku.h:
- platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::RenderThemeQt::paintCheckbox): (WebCore::RenderThemeQt::paintRadio): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintTextArea): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintProgressBar): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::paintSearchFieldCancelButton): (WebCore::RenderThemeQt::paintSearchFieldDecoration): (WebCore::RenderThemeQt::paintSearchFieldResultsDecoration): (WebCore::RenderThemeQt::paintMediaFullscreenButton): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSeekBackButton): (WebCore::RenderThemeQt::paintMediaSeekForwardButton): (WebCore::RenderThemeQt::paintMediaCurrentTime): (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): (WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
- platform/qt/RenderThemeQt.h:
- platform/wx/RenderThemeWx.cpp: (WebCore::RenderThemeWx::paintCheckbox): (WebCore::RenderThemeWx::paintRadio): (WebCore::RenderThemeWx::paintButton): (WebCore::RenderThemeWx::paintTextField): (WebCore::RenderThemeWx::paintMenuList): (WebCore::RenderThemeWx::paintMenuListButton):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
- rendering/EllipsisBox.h:
- rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
- rendering/InlineTextBox.h:
- rendering/PaintInfo.h: Added. (WebCore::PaintInfo::PaintInfo): (WebCore::PaintInfo::updatePaintingRootForChildren): (WebCore::PaintInfo::shouldPaintWithinRoot): (WebCore::PaintInfo::applyTransform):
- rendering/PaintPhase.h: Added. (WebCore::):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::layoutColumns):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::performOverlapTests): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintList): (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
- rendering/RenderLineBoxList.h:
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderMediaControls.h:
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaMuteButton): (WebCore::paintMediaPlayButton): (WebCore::paintMediaSlider): (WebCore::paintMediaSliderThumb): (WebCore::paintMediaVolumeSlider): (WebCore::paintMediaVolumeSliderThumb): (WebCore::paintMediaTimelineContainer): (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- rendering/RenderMediaControlsChromium.h:
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
- rendering/RenderSVGResourceMarker.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::paintMeter):
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintCapsLockIndicator): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::paintInnerSpinButton): (WebCore::RenderTheme::paintOuterSpinButton): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton): (WebCore::RenderTheme::paintProgressBar): (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb): (WebCore::RenderTheme::paintSearchField): (WebCore::RenderTheme::paintSearchFieldCancelButton): (WebCore::RenderTheme::paintSearchFieldDecoration): (WebCore::RenderTheme::paintSearchFieldResultsDecoration): (WebCore::RenderTheme::paintSearchFieldResultsButton): (WebCore::RenderTheme::paintMediaFullscreenButton): (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSeekBackButton): (WebCore::RenderTheme::paintMediaSeekForwardButton): (WebCore::RenderTheme::paintMediaSliderTrack): (WebCore::RenderTheme::paintMediaSliderThumb): (WebCore::RenderTheme::paintMediaVolumeSliderContainer): (WebCore::RenderTheme::paintMediaVolumeSliderTrack): (WebCore::RenderTheme::paintMediaVolumeSliderThumb): (WebCore::RenderTheme::paintMediaRewindButton): (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): (WebCore::RenderTheme::paintMediaControlsBackground): (WebCore::RenderTheme::paintMediaCurrentTime): (WebCore::RenderTheme::paintMediaTimeRemaining):
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb): (WebCore::RenderThemeChromiumSkia::paintProgressBar):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintTextField): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintProgressBar):
- rendering/RenderThemeChromiumWin.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintCapsLockIndicator): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::paintProgressBar): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaRewindButton): (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): (WebCore::RenderThemeMac::paintMediaControlsBackground): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::paintSliderTrack): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderTrack): (WebCore::RenderThemeSafari::paintMediaSliderThumb):
- rendering/RenderThemeSafari.h:
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::paintSearchField): (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton): (WebCore::RenderThemeWin::paintMediaFullscreenButton): (WebCore::RenderThemeWin::paintMediaMuteButton): (WebCore::RenderThemeWin::paintMediaPlayButton): (WebCore::RenderThemeWin::paintMediaSeekBackButton): (WebCore::RenderThemeWin::paintMediaSeekForwardButton): (WebCore::RenderThemeWin::paintMediaSliderTrack): (WebCore::RenderThemeWin::paintMediaSliderThumb): (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
- rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::paintCheckbox): (WebCore::RenderThemeWin::paintRadio): (WebCore::RenderThemeWin::paintTextArea): (WebCore::RenderThemeWin::paintSearchFieldDecoration):
- rendering/RenderThemeWince.cpp: (WebCore::RenderThemeWince::paintButton): (WebCore::RenderThemeWince::paintTextField): (WebCore::RenderThemeWince::paintMenuList): (WebCore::RenderThemeWince::paintMenuListButton): (WebCore::RenderThemeWince::paintSearchField): (WebCore::RenderThemeWince::paintSearchFieldCancelButton): (WebCore::RenderThemeWince::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWince::paintSearchFieldResultsButton): (WebCore::RenderThemeWince::paintSliderTrack): (WebCore::RenderThemeWince::paintSliderThumb): (WebCore::RenderThemeWince::paintMediaFullscreenButton): (WebCore::RenderThemeWince::paintMediaMuteButton): (WebCore::RenderThemeWince::paintMediaPlayButton): (WebCore::RenderThemeWince::paintMediaSeekBackButton): (WebCore::RenderThemeWince::paintMediaSeekForwardButton): (WebCore::RenderThemeWince::paintMediaSliderTrack): (WebCore::RenderThemeWince::paintMediaSliderThumb):
- rendering/RenderThemeWince.h: (WebCore::RenderThemeWince::paintCheckbox): (WebCore::RenderThemeWince::paintRadio): (WebCore::RenderThemeWince::paintTextArea): (WebCore::RenderThemeWince::paintSearchFieldDecoration):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
- rendering/RootInlineBox.h:
- rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
- rendering/SVGInlineFlowBox.h:
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint):
- rendering/SVGInlineTextBox.h:
- rendering/SVGMarkerLayoutInfo.cpp: (WebCore::SVGMarkerLayoutInfo::drawMarkers):
- rendering/SVGMarkerLayoutInfo.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::renderSubtreeToImage):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
- rendering/SVGRootInlineBox.h:
- 3:37 AM Changeset in webkit [62103] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-06-29 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed test expectations update.
- platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum: Added.
- platform/chromium-linux/svg/css/text-shadow-multiple-expected.png: Added.
- platform/chromium-linux/svg/css/text-shadow-multiple-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:36 AM Changeset in webkit [62102] by
-
- 2 edits in trunk/WebCore
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Sort Xcode project file.
- WebCore.xcodeproj/project.pbxproj:
- 2:45 AM Changeset in webkit [62101] by
-
- 3 edits2 adds2 deletes in trunk/LayoutTests
2010-06-29 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed test expectations update.
- platform/chromium-mac/fast/forms/select-empty-option-height.checksum: Added.
- platform/chromium-mac/fast/forms/select-empty-option-height.png: Added.
- platform/chromium-mac/html5lib/webkit-runner-expected.txt: Removed.
- platform/chromium-win/html5lib/webkit-runner-expected.txt: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:23 AM Changeset in webkit [62100] by
-
- 4 edits in trunk/WebCore
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Provide floating-point support for text selection framework
https://bugs.webkit.org/show_bug.cgi?id=40665
Rename 'glyphScale' to 'horizontalGlyphStretch' upon Dans' request.
Also guard the variables in ENABLE(SVG) blocks. Initialize variable to 1 instead of 1.0f, as that's the new style rule.
No functional changes, thus no new tests.
- platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::horizontalGlyphStretch): (WebCore::TextRun::setHorizontalGlyphStretch): (WebCore::TextRun::spacingDisabled):
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPosition):
- 2:16 AM Changeset in webkit [62099] by
-
- 6 edits4 adds in trunk
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: text-shadow CSS applied to SVG no longer works
https://bugs.webkit.org/show_bug.cgi?id=40960
Readd text-shadow support, this time supporting multiple shadows.
It's not exactly like HTML, because SVG draws fill/stroke phases seperated - the png shows the difference.
Tests: svg/css/text-shadow-multiple.xhtml
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::applyShadowToGraphicsContext): Refactored from paintTextWithShadows(), so SVG can reuse. (WebCore::paintTextWithShadows): Use refactored applyShadowToGraphicsContext() function.
- rendering/InlineTextBox.h:
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintTextWithShadows): Added. (WebCore::SVGInlineTextBox::paintText): Call paintTextWithShadows() instead of directly drawing the text.
- rendering/SVGInlineTextBox.h:
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: text-shadow CSS applied to SVG no longer works
https://bugs.webkit.org/show_bug.cgi?id=40960
Add testcase covering multiple text-shadow applied to SVG, in comparision with HTML.
- platform/mac/svg/css/text-shadow-multiple-expected.checksum: Added.
- platform/mac/svg/css/text-shadow-multiple-expected.png: Added.
- platform/mac/svg/css/text-shadow-multiple-expected.txt: Added.
- svg/css/text-shadow-multiple.xhtml: Added.
- 2:04 AM Changeset in webkit [62098] by
-
- 3 edits in trunk/LayoutTests
2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update mac-lepard specific result for a SVG test using border-radii, after the painting changes.
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
- 1:56 AM Changeset in webkit [62097] by
-
- 8 edits in trunk/LayoutTests
Unreviewed trivial fix. Update platform specific expectded files after r62092.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 1:33 AM Changeset in webkit [62096] by
-
- 6 edits in trunk/LayoutTests
Unreviewed trivial fix. Update expectded files after r62092.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:22 AM Rebaseline edited by
- (diff)
- 12:43 AM Changeset in webkit [62095] by
-
- 19 edits in trunk
2010-06-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: show actual breakpoint position in UI.
When user sets breakpoint from UI, javascript engine may actually set
it on a different line. If so, move breakpoint to the correct position
in frontend.
https://bugs.webkit.org/show_bug.cgi?id=40781
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::dispatchDidPause):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::currentCallFrame):
- bindings/v8/ScriptDebugServer.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didSetBreakpoint):
- inspector/InspectorFrontend.h:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.removeOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.setBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.removeBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpoint): (WebInspector.BreakpointManager.prototype._removeBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend.didSetBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.setBreakpoint):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
2010-06-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: return line number where breakpoint was actually set by v8 from setBreakpoint function.
https://bugs.webkit.org/show_bug.cgi?id=40781
- src/js/DebuggerScript.js: ():
- 12:39 AM Changeset in webkit [62094] by
-
- 11 edits in trunk
WebCore: Catch toString() exceptions in all DB-related code.
https://bugs.webkit.org/show_bug.cgi?id=41297
Reviewed by Adam Barth.
- bindings/v8/custom/V8BindingMacros.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::openDatabaseCallback):
(WebCore::V8WorkerContext::openDatabaseSyncCallback):
LayoutTests: Remove a Chromium-specific expectations file.
https://bugs.webkit.org/show_bug.cgi?id=41297
Reviewed by Adam Barth.
- platform/chromium/storage/sql-error-codes-expected.txt:
- storage/sql-error-codes.js:
(testBindParameterOfWrongType):
- 12:26 AM Changeset in webkit [62093] by
-
- 2 edits in trunk/WebCore
Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=5861
Rubber-stamped by Nikolas Zimmermann.
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::build):
- 12:05 AM Changeset in webkit [62092] by
-
- 28 edits3 adds in trunk
WebCore: Add ConvolveMatrix SVG filter effect
https://bugs.webkit.org/show_bug.cgi?id=5861
Reviewed by Nikolas Zimmermann.
The patch was originally started by Dirk Schulze,
and the .cpp and .h files are mostly his work.
I updated the build systems and do some minor updates
to the source files as well. The patch does not contain
the implementation of the filter: this is intended,
and will be landed in a follow-up patch.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- page/DOMWindow.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGFEConvolveMatrixElement.cpp: Added.
(WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
(WebCore::SVGFEConvolveMatrixElement::~SVGFEConvolveMatrixElement):
(WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute):
(WebCore::SVGFEConvolveMatrixElement::setOrder):
(WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
(WebCore::SVGFEConvolveMatrixElement::build):
- svg/SVGFEConvolveMatrixElement.h: Added.
- svg/SVGFEConvolveMatrixElement.idl: Added.
- svg/graphics/filters/SVGFEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::kernelSize):
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::targetOffset):
(WebCore::FEConvolveMatrix::setTargetOffset):
(WebCore::operator<<):
(WebCore::FEConvolveMatrix::externalRepresentation):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
(WebCore::):
- svg/svgattrs.in:
- svg/svgtags.in:
WebKit/mac: Add ConvolveMatrixElement to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=5861
Reviewed by Nikolas Zimmermann.
- MigrateHeaders.make:
LayoutTests: Updating expected values for convolve matrix filter
https://bugs.webkit.org/show_bug.cgi?id=5861
Reviewed by Nikolas Zimmermann.
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- svg/custom/global-constructors-expected.txt:
- svg/custom/js-svg-constructors-expected.txt:
- svg/custom/js-svg-constructors.svg:
