⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 4, 2010:

11:56 PM Changeset in webkit [62475] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark fast/js/function-apply-many-args.html as
having wrong output in debug mode.

  • platform/chromium/test_expectations.txt:
9:45 PM Changeset in webkit [62474] by eric@webkit.org
  • 6 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41587

  • html5lib/runner-expected-html5.txt:
    • <tr> tags now show up, imagine that.

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41587

This also adds a (currently untestable?)
popUntilTableBodyScopeMarker code path.
Any tags which would be between a tbody a <tr> would end up
foster parented outside the <table>. I think the spec was
just being over-cautious with popUntilTableBodyScopeMarker.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
7:37 PM Changeset in webkit [62473] by pkasting@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [62472] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
4:15 PM Changeset in webkit [62471] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

Add simple command line parser and pass mode argument to the web process
​https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):
Add CommandLine class.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

  • WebKit2.xcodeproj/project.pbxproj:

Add CommandLine to the xcode project.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(webProcessMain):
(main):
Parse the command line and check the mode.

3:06 PM Changeset in webkit [62470] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

Fix Qt Minimal build. SVGNames.h should always
be generated, even when SVG is off, however that's
not how things currently work.

  • html/HTMLTreeBuilder.cpp:
2:54 PM Changeset in webkit [62469] by eric@webkit.org
  • 9 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41581

  • html5lib/runner-expected-html5.txt:
    • Update expectations now that we pass 6 more tests.

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41581

There is still a bunch of low-hanging fruit left for this
mode, but even this most-basic support lets us pass 6 more tests. :)

It's a progression, ship it! :)

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::appendMarker):
  • html/HTMLFormattingElementList.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
2:15 PM Changeset in webkit [62468] by eric@webkit.org
  • 13 edits
    1 add in trunk

2010-07-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

Added new adoption01 suite for testing adoption agency
bugs. Right now only the simplest adoption test passes.
I'll be adding more in future commits.

  • html5lib/resources/adoption01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

2010-07-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

This changes some test results, but only makes the simplest
adoption agency cases pass. I think the code is likely
very close, but further iteration to make this change larger
seems counter-productive. I recommend we check in this
progression and work from here.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon):
    • Make sure callers don't assume this will reparent.

(WebCore::ContainerNode::parserAddChild):

  • Update comment to document lack of reparenting behavior.
  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::~ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::ElementRecord::isAbove):
    • Added for debugging.

(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::insertAbove):

  • Needed for the adoption agency.

(WebCore::HTMLElementStack::topRecord):
(WebCore::HTMLElementStack::bottom):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::headElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):

  • Fix the name to match top/bottom.
  • html/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext):
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::closestElementInScopeWithName): (WebCore::HTMLFormattingElementList::contains): (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::remove):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::isEmpty): (WebCore::HTMLFormattingElementList::size):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
    • Part of the Adoption Agency algorithm.

(WebCore::HTMLTreeBuilder::findFosterParentFor):

  • Used to move mis-nested content out of tables. This doesn't seem to work quite right yet.

(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

  • The ridiculously long/complicated adoption agency algorithm from HTML5.

(WebCore::HTMLTreeBuilder::processEndTag):

  • html/HTMLTreeBuilder.h:
10:44 AM Changeset in webkit [62467] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-07-04 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: ​http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:22 AM Changeset in webkit [62466] by jschuh@chromium.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-07-04 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: ​http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:06 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
9:04 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
6:38 AM Changeset in webkit [62465] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Robert Hogan <​robert@webkit.org>

[Qt] Triage failing HTTP tests in Qt Skipped list

Unreviewed, sorting tests and adding comments to skipped list.

  • platform/qt/Skipped:
4:48 AM Changeset in webkit [62464] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix after r62456.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

3:38 AM Changeset in webkit [62463] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

​https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of ​http://trac.webkit.org/changeset/61505

3:16 AM Changeset in webkit [62462] by yurys@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <​yury@yurys-imac.local>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
2:41 AM Changeset in webkit [62461] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-07-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

WebProcess crashes in release for simple layout tests
​https://bugs.webkit.org/show_bug.cgi?id=41575

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl* before taking it out of its parent String, to avoid returning freed memory.

Jul 3, 2010:

10:09 PM Changeset in webkit [62460] by abarth@webkit.org
  • 7 edits in trunk

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41561

Test coverage of this mode was a bit ... lacking, shall we say? This
patch adds a test for it.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41561

This mode is almost unobservable. The main way to observe it seems to
be seeing where comment nodes get attached to the DOM.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
9:53 PM Changeset in webkit [62459] by mjs@apple.com
  • 2 edits in trunk/WebKit2

Add stdint.h include to fix WebKitTestRunner build.

Rubber stamped by Anders Carlsson.

  • UIProcess/API/C/WKPage.h:
6:33 PM Changeset in webkit [62458] by zmo@google.com
  • 5 edits in trunk

2010-07-03 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
​https://bugs.webkit.org/show_bug.cgi?id=41572

  • platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.

2010-07-03 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
​https://bugs.webkit.org/show_bug.cgi?id=41572

  • html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code. (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  • html/canvas/WebGLRenderingContext.h: Helper function declaration.
5:11 PM Changeset in webkit [62457] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.

Reviewed by Darin Adler.

  • MSVC does not ensure the buffers are null terminated as the unix versions do.
  • runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
  • runtime/UString.cpp: Clean up includes.

(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.

  • wtf/StringExtras.h:

(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.

4:49 PM Changeset in webkit [62456] by Darin Adler
  • 5 edits in trunk

2010-07-03 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
the interpreter as well as the JIT.

​https://bugs.webkit.org/show_bug.cgi?id=41351
rdar://problem/8142141

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Fix signed integer overflow problem in op_load_varargs handling. 0xFFFFFFFF was read as -1.

2010-07-03 Darin Adler <Darin Adler>

Added test cases for edge cases in apply function on arrays.
​https://bugs.webkit.org/show_bug.cgi?id=41351

  • fast/js/function-apply-expected.txt: Updated to expect success.
  • fast/js/script-tests/function-apply.js: Added test cases.
4:02 PM Changeset in webkit [62455] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Ugh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.

  • storage/IDBKey.h:

(WebCore::IDBKey::~IDBKey):

4:00 PM Changeset in webkit [62454] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-03 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Simon Hausmann.

[Qt] Fix DumpRenderTree userStyleSheet handling.
​https://bugs.webkit.org/show_bug.cgi?id=41570

DumpRenderTree did only set the userStyleSheet at
layoutTestController.setUserStyleSheetEnabled().

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:48 PM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
3:48 PM Changeset in webkit [62453] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Build fix. Forgot destructor.

  • storage/IDBKey.cpp:

(WebCore::IDBKey::~IDBKey):

3:46 PM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
3:45 PM UpdatingBugzilla edited by ddkilzer@webkit.org
Updated Update section for bzr (diff)
3:37 PM UpdatingBugzilla edited by ddkilzer@webkit.org
Switched from CVS to bzr for upstream Bugzilla repository. (diff)
3:18 PM Changeset in webkit [62452] by jorlow@chromium.org
  • 20 edits
    6 copies
    5 adds in trunk

2010-06-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=41252

Set the role to Private.

2010-06-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=41252

It'll take some time to get data persistence working for IndexedDB,
so until then, we'll just store everything in an in memory tree.
The tree uses WTF::AVLTree and is a template so that it can be used by
object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
IDBKey). This class will be used in a subsequent patch.

Also add an IDBKey type that represents one of these keys. We use a
custom toJS function in a way similar to IDBAny to convert from WebCore
to a JS value. For converting the other way, we have to teach the code
generators what to do (unfortunately). This is done in a way similar
to serialized script value. Unlike serialized script value, IDBKey is
in WebCore and only a helper function is JS engine specific.

This code is not accessable from layout tests. (Will fix in
​https://bugs.webkit.org/show_bug.cgi?id=41250) The bindings tests
show us that the generated bindings are what we expect.

  • ForwardingHeaders/wtf/AVLTree.h: Added.
  • bindings/js/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/js/IDBBindingUtilities.h: Added.
  • bindings/js/JSIDBKeyCustom.cpp: Added. (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::idbKey):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_idb_key):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionIdbKey):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj idbKey:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::idbKeyCallback): (WebCore::):
  • bindings/v8/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/v8/IDBBindingUtilities.h: Added.
  • bindings/v8/custom/V8IDBKeyCustom.cpp: Added. (WebCore::toV8):
  • storage/IDBCallbacks.h:
  • storage/IDBKey.cpp: Added. (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::~IDBKey):
  • storage/IDBKey.h: Added. (WebCore::IDBKey::create): (WebCore::IDBKey::): (WebCore::IDBKey::type): (WebCore::IDBKey::string): (WebCore::IDBKey::number):
  • storage/IDBKey.idl: Added.
  • storage/IDBKeyTree.h: Added. (WebCore::IDBKeyTree::create): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::null): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node): (WebCore::::IDBKeyTree): (WebCore::::~IDBKeyTree): (WebCore::::AVLTreeAbstractor::compare_key_key): (WebCore::::get): (WebCore::::insert): (WebCore::::remove):
2:57 PM Changeset in webkit [62451] by jhoneycutt@apple.com
  • 14 edits in trunk

The missing plug-in indicator should be clickable

​https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>

From an original patch by Kevin Decker.

Reviewed by Darin Adler.

WebCore:

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.

  • page/ChromeClient.h:

(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.

  • rendering/RenderEmbeddedObject.h:

(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.

  • WebView/WebUIDelegatePrivate.h:

Declare didPressMissingPluginButton.

WebKit/win:

  • Interfaces/IWebUIDelegatePrivate.idl:

Added a new delegate interface, and declare a function
didPressMissingPluginButton().

  • Interfaces/WebKit.idl:

Touch this file to force interfaces to be rebuilt.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

2:36 PM Changeset in webkit [62450] by robert@webkit.org
  • 4 edits in trunk

2010-07-03 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Unskip fast/history/self-is-visited.html

​https://bugs.webkit.org/show_bug.cgi?id=40445

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Object property names such as 'background-color' need to be returned in camel
case, i.e. backgroundColor so that JS can reference them. Add support for this
to DumpRenderTreeSupportQt.

​https://bugs.webkit.org/show_bug.cgi?id=40445

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
1:30 PM Changeset in webkit [62449] by oliver@apple.com
  • 9 edits in trunk

Move BOM handling out of the lexer and parser
​https://bugs.webkit.org/show_bug.cgi?id=41539

Reviewed by Geoffrey Garen.

JavaScriptCore:

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::copyStringWithoutBOMs):

WebCore:

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • loader/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):

  • loader/CachedScript.h:

(WebCore::CachedScript::):

CachedScript now stores decoded data with the BOMs stripped,
and caches the presence of BOMs across memory purges.

12:20 PM Changeset in webkit [62448] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-07-03 Xan Lopez <​xlopez@igalia.com>

Include DerivedSources/WebCore before DerivedSources/

Recently DerivedSources generation was changed, with some files no
longer being generated in the toplevel DerivedSources
directory. Since that directory is first in the -I flags the build
can be broken in some cases by including old files unless a 'make
clean' is done. Change the -I order to fix the build in the 32 bit
Release bot.

  • GNUmakefile.am:
7:08 AM Changeset in webkit [62447] by arv@chromium.org
  • 7 edits
    1 add in trunk

2010-07-03 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target if
the context menu was shown due to pressing the context menu key
(or Shift+F10).

Split sendContextMenuForEvent into one case for keyboard events and use
that when the contextmenu event should be dispatched due to a keypress.

For the keboard case we now use the focused node as the target for the
event and use the clipped rect to determine the position of the menu.

​https://bugs.webkit.org/show_bug.cgi?id=38129

Use manual test since DRT does not handle context menu keys.

  • manual-tests/win/contextmenu-key.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::sendContextMenuEventForKey):
  • page/EventHandler.h:

2010-07-03 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

​https://bugs.webkit.org/show_bug.cgi?id=38129

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

2010-07-03 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

  • WebView.cpp: (WebView::handleContextMenuEvent):
5:03 AM Changeset in webkit [62446] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-07-03 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
3:42 AM Changeset in webkit [62445] by robert@webkit.org
  • 10 edits in trunk/LayoutTests

2010-07-03 Robert Hogan <​robert@webkit.org>

[Qt] Update Qt expected results after r62444

Unreviewed, update test results.

​http://trac.webkit.org/changeset/62444
​https://bugs.webkit.org/show_bug.cgi?id=41088

Qt expected results for various fast/ tests updated to reflect
support for dumpChildFrameScrollPositions(). Checked against Mac results
and they are all good.

I have not updated the .png and .checksum files for the tests. This is
because I suspect I will not get the same pixel results as the Qt build
bot.

  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
3:00 AM Changeset in webkit [62444] by robert@webkit.org
  • 7 edits in trunk

2010-07-03 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

​https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

​https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFrameScrollPosition): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFrameScrollPositions):
1:45 AM Changeset in webkit [62443] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-07-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port Widget
​https://bugs.webkit.org/show_bug.cgi?id=41538

Make Widget a dummy class. WebKit Brew MP uses the full screen mode
and does not use the window system introduced in Brew MP.

  • platform/Widget.h:
  • platform/brew/WidgetBrew.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
1:30 AM Changeset in webkit [62442] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-07-03 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
​https://bugs.webkit.org/show_bug.cgi?id=41411

  • wtf/unicode/wince/UnicodeWince.cpp: (WTF::Unicode::isAlphanumeric):
  • wtf/unicode/wince/UnicodeWince.h: (WTF::Unicode::isArabicChar):
1:17 AM Changeset in webkit [62441] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
​https://bugs.webkit.org/show_bug.cgi?id=41524

Print "WebKit CRASH" before crashing.

  • wtf/Assertions.h:
12:17 AM Changeset in webkit [62440] by abarth@webkit.org
  • 4 edits in trunk

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41560

It's somewhat hard to observe this state, so I'm not surprised that the
diff to the expected results are small. We still fail this test
because we don't handle whitespace correctly.

  • html5lib/runner-expected-html5.txt:

2010-07-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41560

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
12:03 AM Changeset in webkit [62439] by abarth@webkit.org
  • 4 edits in trunk

2010-07-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41559

And the tests keep progressing.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
​https://bugs.webkit.org/show_bug.cgi?id=41559

Pretty straighforward. We still don't handle character tokens
correctly.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
Note: See TracTimeline for information about the timeline view.