⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 5, 2010:

11:48 PM Changeset in webkit [62529] by hamaji@chromium.org
  • 11 edits in trunk/WebCore

2010-07-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
11:43 PM Changeset in webkit [62528] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium build.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
11:29 PM Changeset in webkit [62527] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Move processStartTagForInBody to its own function.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.cpp.orig: Added.
  • html/HTMLTreeBuilder.h:
11:29 PM Changeset in webkit [62526] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-07-05 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
​https://bugs.webkit.org/show_bug.cgi?id=41612

  • Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
11:14 PM Changeset in webkit [62525] by eric@webkit.org
  • 4 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
​https://bugs.webkit.org/show_bug.cgi?id=41654

  • html5lib/runner-expected-html5.txt:
    • Fix two sub-tests!

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
​https://bugs.webkit.org/show_bug.cgi?id=41654

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:05 PM Changeset in webkit [62524] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Eric Seidel <​eric@webkit.org>

Unreviewed. Just fixing proess to process.
Clearly Adam and I can't spell. Thankfully MikeSmith can.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakeStartTag): (WebCore::HTMLTreeBuilder::processFakeEndTag): (WebCore::HTMLTreeBuilder::processIsindexStartTagForBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
11:01 PM Changeset in webkit [62523] by eric@webkit.org
  • 9 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

  • html5lib/resources/tests2.dat:
    • Make the expected wording match the HTML5 spec. Not sure why the wording in this test diverged.
  • html5lib/resources/isindex.dat:
    • Cover more isindex cases.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

Covered by html5lib/runner.html including a new
isindex.dat test suite.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
    • Support passing attributes to the constructor.

(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::takeAtributes):

  • Reduces ref-churn, and makes it possible for callers to modify attributes w/o affecting future uses of the attributes.

(WebCore::AtomicHTMLToken::usesName):

  • Used by ASSERTS.

(WebCore::AtomicHTMLToken::usesAttributes):

  • Used by ASSERTS.
  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle):
    • Can't be const, now that we use takeAttributes()

(WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML):
(WebCore::HTMLTreeBuilder::proesssFakeStartTag):

  • New function. I'm not sure this is the perfect design (I'd kinda like AtomicHTMLToken to be copyable so we can have create functions for it), but this makes the callsites using fake tokens much more readable.

(WebCore::HTMLTreeBuilder::proesssFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakeCharacters):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::insertScriptElement):

  • Use takeAttributes() for less ref-churn.

(WebCore::HTMLTreeBuilder::createElement): ditto
(WebCore::HTMLTreeBuilder::finished):

  • Remove bogus use of AtomicHTMLToken constructor which wasn't even being used now that we support emitting EOF tokens from the Tokenizer directly.
  • html/HTMLTreeBuilder.h:
10:38 PM Changeset in webkit [62522] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ASSERT that we're processing the correct type of token
​https://bugs.webkit.org/show_bug.cgi?id=41647

Making these asserts work required a small (non-observable) tweak to
some old code.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
10:31 PM Changeset in webkit [62521] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
​https://bugs.webkit.org/show_bug.cgi?id=41646

Add some tests for this mode. We fail all these tests currently
because there's no way to get into this mode. :(

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
​https://bugs.webkit.org/show_bug.cgi?id=41646

This mode is mostly a fall-through to the InSelectMode.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
10:14 PM Changeset in webkit [62520] by abarth@webkit.org
  • 9 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
​https://bugs.webkit.org/show_bug.cgi?id=41623

  • html5lib/resources/webkit01.dat:
    • This test had incorrect expected results according to the spec and to Minefield.
  • html5lib/runner-expected-html5.txt:
    • Update expected results to show test progression. In some cases, we continue to fail tests, but in new (also wrong) ways. I think that's ok though.
  • html5lib/runner-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.
  • html5lib/webkit-resumer-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
​https://bugs.webkit.org/show_bug.cgi?id=41623

This patch isn't the end-all, be-all of text node coalescing, but it's
a good start.

  • dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
  • dom/CharacterData.h:
    • Added a new method to dance around mutation events.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertTextNode):
9:58 PM Changeset in webkit [62519] by abarth@webkit.org
  • 4 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
​https://bugs.webkit.org/show_bug.cgi?id=41627

Massive test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
​https://bugs.webkit.org/show_bug.cgi?id=41627

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
9:57 PM Changeset in webkit [62518] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We should be able to specify a bug to block for webkit-patch upload
​https://bugs.webkit.org/show_bug.cgi?id=41648

This will be useful for working on the HTML5 parser.

  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/options.py:
9:21 PM Changeset in webkit [62517] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-05 Yuzo Fujishima <​yuzo@google.com>

Unreviewed test expectation update.

Fix: On Leopard run-webkit-tests complains: Skipped list contained
'compositing/iframes/composited-iframe.html', but no file of that name
could be found

  • platform/mac-leopard/Skipped: Removed the above test.
8:34 PM Changeset in webkit [62516] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-07-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

We were discussing this test case, so I figured I might as well add it
to the suite.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
8:11 PM Changeset in webkit [62515] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-07-05 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement downloadURL in ContextMenuClientEfl
When user selects a download menu from context menu, send the download
request to application.
​https://bugs.webkit.org/show_bug.cgi?id=41149

  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::downloadURL): Get url for downloading file and Send it to application.
  • efl/WebCoreSupport/ContextMenuClientEfl.h:
7:03 PM Changeset in webkit [62514] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-07-05 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=40857

  • platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Added.
  • svg/css/svg-ellipse-render-crash.html: Added.

2010-07-05 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=40857

Test: svg/css/svg-ellipse-render-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged):
6:06 PM Changeset in webkit [62513] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Reproducible crash with Optimize Legibility extension
​https://bugs.webkit.org/show_bug.cgi?id=41585

Reviewed by Sam Weinig.

WebCore:

Test: fast/css/text-rendering-priority.html

Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.

  • css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests:

  • fast/css/text-rendering-priority-expected.txt: Added.
  • fast/css/text-rendering-priority.html: Added.
5:53 PM Changeset in webkit [62512] by alice.liu@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
​https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

  • platform/win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
  • platform/win/fast/text/uniscribe-item-boundary-crash.html: Added.
5:51 PM Applications using WebKit edited by onny_silvester@yahoo.com
(diff)
5:22 PM Changeset in webkit [62511] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=41641

Reviewed by Sam Weinig.

Update compile flags to allow use of ExecutableAllocatorFixedVMPool on platforms
other than x86-64 (this may be useful on 32-bit platforms, too).

Simplify ifdefs by dividing into thwo broad allocation strategies
(ENABLE_EXECUTABLE_ALLOCATOR_FIXED & ENABLE_EXECUTABLE_ALLOCATOR_DEMAND).

Rename constant used in the code to have names descriptive of their purpose,
rather than their specific value on a given platform.

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::free):
(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • wtf/Platform.h:
5:11 PM Changeset in webkit [62510] by mitz@apple.com
  • 2 edits in trunk/WebCore

optimizeLegibility doesn't play nice with fonts that do not have a space glyph
​https://bugs.webkit.org/show_bug.cgi?id=41599

Reviewed by Sam Weinig.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.

2:39 PM Changeset in webkit [62509] by abarth@webkit.org
  • 5 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
​https://bugs.webkit.org/show_bug.cgi?id=41628

This has some minimal testing. One from my previous
</table> patch, and a few from the main suite.

Mostly resetInsertionModeAppropriately isn't used yet
but we're about to add a bunch of states which do use it
and our test coverage will expand further as we do.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
​https://bugs.webkit.org/show_bug.cgi?id=41628

Fixes a bunch of subtests!

  • html5lib/runner-expected-html5.txt:
2:34 PM Changeset in webkit [62508] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Chromium missing method. Filed bug 41632 to track.

  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCache):
2:25 PM Changeset in webkit [62507] by abarth@webkit.org
  • 7 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41591

resetInsertionModeAppropriately isn't implemented yet, however
I've added a test for the usage I added.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41591

Add tests for </table> in "in table" mode, and
one for ignored close tags.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
2:08 PM Changeset in webkit [62506] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Missed GTK's build file.

  • GNUmakefile.am:
2:00 PM Changeset in webkit [62505] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Pass a blank ResourceResponse instead of passing 0.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
1:47 PM Changeset in webkit [62504] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Forward declare ApplicationCache for Chromium.

  • loader/appcache/ApplicationCacheHost.h:
1:32 PM Changeset in webkit [62503] by Joseph Pecoraro
  • 16 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
​https://bugs.webkit.org/show_bug.cgi?id=24529

Parts of this patch were written by Kavita Kanetkar <​kkanetkar@chromium.org>.

Part 2: Pulling ApplicationCache Resources to Display in the Inspector.

The InspectorApplicationCacheAgent gathers the information it
needs and forwards it on to the inspector.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): get information about the resources. (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): gathers all the information from the ApplicationCacheHost. (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h: defines structures to hold information about caches and resources. (WebCore::InspectorApplicationCacheAgent::ApplicationCacheInfo::ApplicationCacheInfo): (WebCore::InspectorApplicationCacheAgent::ResourceInfo::ResourceInfo): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCacheForInspector): new convention, public cache accessor for the inspector. (WebCore::ApplicationCacheHost::documentLoader): added const.

The User Interface uses a DataGrid, like Cookies.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.numberCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.localeCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

The usual frontend pull workflow, except this goes through
InspectorApplicationCacheAgent instead of InspectorController.

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getApplicationCaches): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetApplicationCaches):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.hasChildNodes): style fix. (WebInspector.DOMAgent.prototype.nodeForId): style fix. (WebInspector.ApplicationCache.getApplicationCachesAsync): pull. (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.updateManifest): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addAppCacheDomain): (WebInspector.reset):

Miscellaneous. Localized Strings and fixes.

  • English.lproj/localizedStrings.js: "Type", "%s (%s)"
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/InspectorController.h:
1:32 PM Changeset in webkit [62502] by Joseph Pecoraro
  • 19 edits
    4 adds in trunk/WebCore

2010-07-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
​https://bugs.webkit.org/show_bug.cgi?id=24529

Part 1: Backend -> Frontend Messages. ApplicationCache Status and Connectivity Status.

This patch adds an InspectorApplicationCacheAgent to monitor application
cache changes, starts a UI in the Storage panel, handles the boilerplate
of adding new files.

Added an agent to encapsulate and handle the application cache logic.
This is similar to the timeline agent.

  • inspector/InspectorApplicationCacheAgent.cpp: Added. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse): (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus): (WebCore::InspectorApplicationCacheAgent::updateNetworkState):
  • inspector/InspectorApplicationCacheAgent.h: Added.

InspectorController owns an InspectorApplicationCacheAgent. This
handles its lifetime management.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): create the agent with a frontend. (WebCore::InspectorController::disconnectFrontend): remove the agent when closing. (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h:

User Interface for ApplicationCache in the StoragePanel. This follows
very closely to Cookies, it will have a sortable table of items. The
status bar contains connectivity and application cache status
indicators which update when backend messages are received. There
are some stubs which the next part will implement.

  • inspector/front-end/ApplicationCacheItemsView.js: Added. (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): refresh, delete, connectivity, application cache status. (WebInspector.ApplicationCacheItemsView.prototype.show): (WebInspector.ApplicationCacheItemsView.prototype.hide): (WebInspector.ApplicationCacheItemsView.prototype.updateStatus): this is the application cache status indicator. (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState): this is the online/offline connectivity indicator. (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid): (WebInspector.ApplicationCacheItemsView.prototype.resize): (WebInspector.ApplicationCacheItemsView.prototype._deleteButtonClicked): (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback): (WebInspector.ApplicationCacheItemsView.prototype._refreshButtonClicked):

The usual dispatch flow from the backend, to the frontend, to the
panel, and then to the visible view. Some slight refactoring to
eliminate duplicated code.

  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::didGetApplicationCaches): (WebCore::InspectorFrontend::updateApplicationCacheStatus):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.StoragePanel.prototype.showDOMStorage): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.StoragePanel.prototype.showApplicationCache): (WebInspector.StoragePanel.prototype._genericViewSetup): (WebInspector.StoragePanel.prototype.updateApplicationCacheStatus): (WebInspector.StoragePanel.prototype.updateNetworkState): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle): (WebInspector.ApplicationCacheSidebarTreeElement): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get subtitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch): (WebInspector._addAppCacheDomain): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):

Notify the InspectorApplicationCacheAgent on application cache changes
or specifics. Notify the InspectorController on generic resource events.
That is because ApplicationCacheController is a ResourceClient and needs
to trigger the resource events normally handled by ResourceLoader.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::inspectorUpdateApplicationCacheStatus): helper method to prevent duplicated code. (WebCore::ApplicationCacheGroup::setNewestCache): status change. (WebCore::ApplicationCacheGroup::makeObsolete): status change. (WebCore::ApplicationCacheGroup::update): status change. (WebCore::ApplicationCacheGroup::createResourceHandle): resource event. (WebCore::ApplicationCacheGroup::willSendRequest): resource event. (WebCore::ApplicationCacheGroup::didReceiveResponse): resource event. (WebCore::ApplicationCacheGroup::didReceiveData): resource event. (WebCore::ApplicationCacheGroup::didFinishLoading): resource event. (WebCore::ApplicationCacheGroup::didFail): resource event. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): resource event. (WebCore::ApplicationCacheGroup::manifestNotFound): status change. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): status change. (WebCore::ApplicationCacheGroup::setUpdateStatus): single access point for status changes.
  • loader/appcache/ApplicationCacheGroup.h:
  • page/Page.cpp: (WebCore::networkStateChanged): connectivity status change.

Final inspector details to add the new file, style new elements,
images, and localized strings.

  • inspector/front-end/inspector.css: (.application-cache-sidebar-tree-item .icon): (.timeline-records-counter, .storage-application-cache-status, .storage-application-cache-connectivity): (.storage-application-cache-status-icon, .storage-application-cache-connectivity-icon): (.status-bar-divider): (.storage-application-cache-status, .storage-application-cache-connectivity):
  • inspector/front-end/inspector.html:
  • inspector/front-end/Images/applicationCache.png: Added.
  • English.lproj/localizedStrings.js: "APPLICATION CACHE", "No Application Cache information available.", "Online", "Offline"

Updated build files.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/WebKit.qrc:
1:17 PM Changeset in webkit [62501] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-07-05 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit2 triple click
​https://bugs.webkit.org/show_bug.cgi?id=41629

QtWebkit2 triple click implementation.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseDoubleClickEvent): (QWKPage::timerEvent):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
1:03 PM Changeset in webkit [62500] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

Test the new <col> support. Turns out the old treebuilder doesn't
handle <table><col> correctly.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
1:02 PM Changeset in webkit [62499] by abarth@webkit.org
  • 8 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> and <th> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41588

Also fixed <td> or <th> as a direct child of <table>.

Most of this was covered by html5lib/runner.html tests,
but I had to add a new tables01.dat to cover the <th> cases.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41588

Added tables01.dat to test a previously untested
<table><th> case. I expect we'll add many more table
tests there as we complete our implementation.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • html5lib/resources/tables01.dat: Added.
12:42 PM Changeset in webkit [62498] by eric@webkit.org
  • 7 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
​https://bugs.webkit.org/show_bug.cgi?id=41582

  • html5lib/resources/inbody01.dat: Added.
  • html5lib/runner-expected-html5.txt:
    • Update the one result which was affected by this. That test would pass if we had text node coalescing.
  • html5lib/runner-expected.txt:
    • Update to add the extra test suite.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
​https://bugs.webkit.org/show_bug.cgi?id=41582

I believe I found a "bug" in the HTML5 spec when writing this:
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
11:32 AM Changeset in webkit [62497] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-07-05 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Add a missing slash to the list of generated sources. This
was missing from a previous build fix.

  • GNUmakefile.am:
11:04 AM Changeset in webkit [62496] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: preserve scroll positions in source frame when switching between panes.

​https://bugs.webkit.org/show_bug.cgi?id=41620

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
10:57 AM Changeset in webkit [62495] by yurys@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

2010-07-05 Yury Semikhatsky <​yury@yurys-imac.local>

Unreviewed. Provide Chromium specific expectations for new svg tests.

  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.txt: Added.
10:50 AM Changeset in webkit [62494] by commit-queue@webkit.org
  • 2 edits
    2 copies
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add stubs

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: Copied from WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Added. (WebKit::InjectedBundle::load):
10:10 AM Changeset in webkit [62493] by steveblock@google.com
  • 2 edits in trunk/JavaScriptCore

2010-07-05 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

ThreadingPthreads.cpp should use JNIUtility.h on Android, not outdated jni_utility.h
​https://bugs.webkit.org/show_bug.cgi?id=41594

  • wtf/ThreadingPthreads.cpp:
10:01 AM Changeset in webkit [62492] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-05 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

IE SVG test fails
​https://bugs.webkit.org/show_bug.cgi?id=41619

Make SVGSVGElement.createSVGTransform create a SVGTransform with the
right type, thereby fixing the IE test.

Test: svg/custom/svg-createsvgtransform-type.html

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform):
9:54 AM Changeset in webkit [62491] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add WebErrorsQt

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Added. (WebKit::): (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError):
8:29 AM Changeset in webkit [62490] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-07-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
​https://bugs.webkit.org/show_bug.cgi?id=41017

  • Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
  • Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
8:12 AM Changeset in webkit [62489] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: computed style pane is not updated when styles pane is collapsed.

​https://bugs.webkit.org/show_bug.cgi?id=41615

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
7:32 AM Changeset in webkit [62488] by Nikolas Zimmermann
  • 44 edits
    12 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=41566

Add logic to all SVG elements which create renderes to expose a method
"bool selfHasRelativeLengths()", that returns whether the element uses relative
lengths (eg. <rect x="50%"...). This will be used soon to avoid relayouts of
container children, when the bounds have not changed.

A new method SVGStyledElement::updateRelativeLengthsInformation() is added,
which is called from the various svgAttributeChanged() methods and insertedIntoDocument/removedFromDocument.
It will be implemented in a follow-up patch. This patch does not affect any test behaviour related
to relayouting. As SVGFilterElement finally got a proper svgAttributeChanged() method, it now
properly invalidates clients on attribute changes - covered by a new test.

Tests: svg/custom/relative-sized-inner-svg.xhtml

svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml
svg/filters/filter-width-update.svg


  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Rename hasRelativeValues to hasRelativeLengths.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Ditto. (WebCore::RenderSVGRoot::calcViewport): Ditto.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Ditto
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Call updateRelativeLengthsInformation() if any attribute which may contain relative lengths changes. (WebCore::SVGCircleElement::selfHasRelativeLengths): Ditto. Same for all other SVG*Elements below.
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::selfHasRelativeLengths):
  • svg/SVGEllipseElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::selfHasRelativeLengths):
  • svg/SVGFilterElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::selfHasRelativeLengths):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::selfHasRelativeLengths):
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::selfHasRelativeLengths):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::selfHasRelativeLengths):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::selfHasRelativeLengths):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::selfHasRelativeLengths):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::selfHasRelativeLengths):
  • svg/SVGPatternElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::selfHasRelativeLengths):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::selfHasRelativeLengths):
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::insertedIntoDocument): Call updateRelativeLengthsInformation(). (WebCore::SVGStyledElement::removedFromDocument): Ditto. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Not implemented so far. Will land in a follow-up patch, together with the render tree changes.
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): Devirtualized. For now, just call selfHasRelativeLengths() - this will change in a follow-up patch. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): (WebCore::SVGStyledElement::selfHasRelativeLengths): Renamed from hasRelativeValues().
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::selfHasRelativeLengths):
  • svg/SVGSymbolElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selfHasRelativeLengths):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::insertedIntoDocument): Call right base class' method. Skipped one in the hierachy before. (WebCore::SVGTextPathElement::selfHasRelativeLengths):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::listContainsRelativeValue): New helper funtion that checks wheter a SVGLengthList contains relative lengths. (WebCore::SVGTextPositioningElement::selfHasRelativeLengths):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): Call right base class' method. Skipped on in the hierachy before. (WebCore::SVGUseElement::removedFromDocument): Ditto. (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateRelativeLengthsInformation() after building the shadow tree. (WebCore::SVGUseElement::selfHasRelativeLengths): Same as all other methods, except that it includes the shadow tree root element.
  • svg/SVGUseElement.h:

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=41566

Add two new relative-sized-*.svg tests that would break, when relative sized kids aren't layout correctly.
Add new test covering that filters update their clients, if any attribute changes.

  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/mac/svg/filters/filter-width-update-expected.png: Added.
  • platform/mac/svg/filters/filter-width-update-expected.txt: Added.
  • svg/custom/relative-sized-inner-svg.xhtml: Added.
  • svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml: Added.
  • svg/filters/filter-width-update.svg: Added.
7:23 AM Changeset in webkit [62487] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Problem with copying a code from Scripts panel.

​https://bugs.webkit.org/show_bug.cgi?id=40432

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._selectionToPosition):
7:07 AM Changeset in webkit [62486] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add Qt C API integration.

  • UIProcess/API/cpp/qt/WKStringQt.cpp: Added. (WKStringCreateWithQString): (WKStringCopyQString):
  • UIProcess/API/cpp/qt/WKStringQt.h: Added.
  • UIProcess/API/cpp/qt/WKURLQt.cpp: Added. (WKURLCreateWithQUrl): (WKURLCopyQUrl):
  • UIProcess/API/cpp/qt/WKURLQt.h: Added.
6:41 AM Changeset in webkit [62485] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add the Qt process launcher.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Added. (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::terminateProcess): (WebKit::webThreadBody): (WebKit::ProcessLauncher::createWebThread): (webProcessMain):
5:48 AM Changeset in webkit [62484] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze / Darin Adler.

Node.cloneNode does not work on SVG nodes
​https://bugs.webkit.org/show_bug.cgi?id=41421

Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.

Test: svg/custom/clone-element-with-animated-svg-properties.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
5:31 AM Changeset in webkit [62483] by antti.j.koivisto@nokia.com
  • 5 edits in trunk

Revert unplanned project file change.

.:

  • WebKit.pro:

WebCore:

  • WebCore.pri:
  • WebCore.pro:
5:27 AM Changeset in webkit [62482] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Darin Adler.

Memory corruption with SVG <use> element
​https://bugs.webkit.org/show_bug.cgi?id=40994

Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
datastructure with the points attribute, no matter if there are changes are not. This should be
furhter optimized, but this fix is sane and fixes the root of the evil races.

Test: svg/custom/use-property-synchronization-crash.svg

  • svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged):
5:26 AM Changeset in webkit [62481] by antti.j.koivisto@nokia.com
  • 5 edits
    4 adds in trunk

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/qt: Added.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/qt: Added.
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

3:50 AM Changeset in webkit [62480] by morrita@google.com
  • 3 edits in trunk/WebKitTools

2010-07-04 MORITA Hajime <​morrita@google.com>

rebaseline-chromium-webkit-tests: UnicodeDecodeError
​https://bugs.webkit.org/show_bug.cgi?id=41589

  • run() method can result non-utf-8 bytes, that causes utf-8 decoding fail. Fixed to disable decoding.
  • Fixed Git.find_checkout_root() to make a test pass.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
3:05 AM Changeset in webkit [62479] by yurys@chromium.org
  • 4 edits in trunk

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
​https://bugs.webkit.org/show_bug.cgi?id=41595

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
​https://bugs.webkit.org/show_bug.cgi?id=41595

  • src/js/DebuggerScript.js:
3:03 AM Changeset in webkit [62478] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-04 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

SVG polygons should draw polygons up to the first parsing error
​https://bugs.webkit.org/show_bug.cgi?id=41140

Render polygons up until the first parsing error.

Test: svg/custom/poly-parsing-error.html

  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::parseMappedAttribute):
2:49 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:32 AM Changeset in webkit [62477] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
​https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

Test: platform/win/fast/text/uniscribe-item-boundary-crash.html

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.

12:18 AM Changeset in webkit [62476] by Philippe Normand
  • 4 edits in trunk/WebKit/mac

2010-06-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] on Mac OS use a runloop observer to process the glib context iterations
​https://bugs.webkit.org/show_bug.cgi?id=35747

If VIDEO and GSTREAMER are enabled, make the WebView start a
runloop observer that will trigger the glib main context
iterations. Those are needed by the GStreamer player only at the
moment but could later be used for other GLib-dependant components
if required.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _close]): (-[WebView _clearGlibLoopObserver]): (glibContextIterationCallback): (-[WebView _scheduleGlibContextIterations]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Jul 4, 2010:

11:56 PM Changeset in webkit [62475] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark fast/js/function-apply-many-args.html as
having wrong output in debug mode.

  • platform/chromium/test_expectations.txt:
9:45 PM Changeset in webkit [62474] by eric@webkit.org
  • 6 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41587

  • html5lib/runner-expected-html5.txt:
    • <tr> tags now show up, imagine that.

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41587

This also adds a (currently untestable?)
popUntilTableBodyScopeMarker code path.
Any tags which would be between a tbody a <tr> would end up
foster parented outside the <table>. I think the spec was
just being over-cautious with popUntilTableBodyScopeMarker.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
7:37 PM Changeset in webkit [62473] by pkasting@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [62472] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
4:15 PM Changeset in webkit [62471] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

Add simple command line parser and pass mode argument to the web process
​https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):
Add CommandLine class.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

  • WebKit2.xcodeproj/project.pbxproj:

Add CommandLine to the xcode project.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(webProcessMain):
(main):
Parse the command line and check the mode.

3:06 PM Changeset in webkit [62470] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

Fix Qt Minimal build. SVGNames.h should always
be generated, even when SVG is off, however that's
not how things currently work.

  • html/HTMLTreeBuilder.cpp:
2:54 PM Changeset in webkit [62469] by eric@webkit.org
  • 9 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41581

  • html5lib/runner-expected-html5.txt:
    • Update expectations now that we pass 6 more tests.

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41581

There is still a bunch of low-hanging fruit left for this
mode, but even this most-basic support lets us pass 6 more tests. :)

It's a progression, ship it! :)

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::appendMarker):
  • html/HTMLFormattingElementList.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
2:15 PM Changeset in webkit [62468] by eric@webkit.org
  • 13 edits
    1 add in trunk

2010-07-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

Added new adoption01 suite for testing adoption agency
bugs. Right now only the simplest adoption test passes.
I'll be adding more in future commits.

  • html5lib/resources/adoption01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

2010-07-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
​https://bugs.webkit.org/show_bug.cgi?id=41453

This changes some test results, but only makes the simplest
adoption agency cases pass. I think the code is likely
very close, but further iteration to make this change larger
seems counter-productive. I recommend we check in this
progression and work from here.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon):
    • Make sure callers don't assume this will reparent.

(WebCore::ContainerNode::parserAddChild):

  • Update comment to document lack of reparenting behavior.
  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::~ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::ElementRecord::isAbove):
    • Added for debugging.

(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::insertAbove):

  • Needed for the adoption agency.

(WebCore::HTMLElementStack::topRecord):
(WebCore::HTMLElementStack::bottom):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::headElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):

  • Fix the name to match top/bottom.
  • html/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext):
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::closestElementInScopeWithName): (WebCore::HTMLFormattingElementList::contains): (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::remove):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::isEmpty): (WebCore::HTMLFormattingElementList::size):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
    • Part of the Adoption Agency algorithm.

(WebCore::HTMLTreeBuilder::findFosterParentFor):

  • Used to move mis-nested content out of tables. This doesn't seem to work quite right yet.

(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

  • The ridiculously long/complicated adoption agency algorithm from HTML5.

(WebCore::HTMLTreeBuilder::processEndTag):

  • html/HTMLTreeBuilder.h:
10:44 AM Changeset in webkit [62467] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-07-04 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: ​http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:22 AM Changeset in webkit [62466] by jschuh@chromium.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-07-04 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: ​http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:06 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
9:04 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
6:38 AM Changeset in webkit [62465] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Robert Hogan <​robert@webkit.org>

[Qt] Triage failing HTTP tests in Qt Skipped list

Unreviewed, sorting tests and adding comments to skipped list.

  • platform/qt/Skipped:
4:48 AM Changeset in webkit [62464] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix after r62456.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

3:38 AM Changeset in webkit [62463] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

​https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of ​http://trac.webkit.org/changeset/61505

3:16 AM Changeset in webkit [62462] by yurys@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <​yury@yurys-imac.local>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
2:41 AM Changeset in webkit [62461] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-07-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

WebProcess crashes in release for simple layout tests
​https://bugs.webkit.org/show_bug.cgi?id=41575

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl* before taking it out of its parent String, to avoid returning freed memory.
Note: See TracTimeline for information about the timeline view.