⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 6, 2010:

11:58 PM Changeset in webkit [62627] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8163651> Wrong value type being supplied for kCTTypesetterOptionForcedEmbeddingLevel key

Reviewed by Jon Honeycutt.

No change in behavior, so no new test.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Use CFNumber instances
as the values of the kCTTypesetterOptionForcedEmbeddingLevel key, instead of CFBooleans.

10:53 PM Changeset in webkit [62626] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix production builds on Mac OS X.

  • DerivedSources.make: Don't try and generate the export file during the installhdrs build phase.

It's not useful until much later in the build process, and it's not possible to generate it until
after the tool has been compiled anyway.

  • WebCore.xcodeproj/project.pbxproj: Tweak how the ICU and forwarding headers are copied so that it

works in production builds once more.

10:42 PM Changeset in webkit [62625] by sfalken@apple.com
  • 10 edits in trunk

WebCore: Expose URL matching from WebUserContentURLPattern
​https://bugs.webkit.org/show_bug.cgi?id=41726
<rdar://problem/7910144>

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export UserContentURLPattern::matches for use in WebKit.

WebKit/mac: Expose URL matching from WebUserContentURLPattern
​https://bugs.webkit.org/show_bug.cgi?id=41726
<rdar://problem/7910144>

Reviewed by Simon Fraser.

We previously had a way to construct WebUserContentURLPattern
instances via WebKit, but no way for callers to perform matching.
This patch adds the matchesURL functionality to allow for this.

  • Misc/WebUserContentURLPattern.h: Added matchesURL.
  • Misc/WebUserContentURLPattern.mm:

(-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches.

WebKit/win: Expose URL matching from WebUserContentURLPattern
​https://bugs.webkit.org/show_bug.cgi?id=41726
<rdar://problem/7910144>

Reviewed by Simon Fraser.

We previously had a way to construct WebUserContentURLPattern
instances via WebKit, but no way for callers to perform matching.
This patch adds the matchesURL functionality to allow for this.

  • Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
  • Interfaces/IWebView.idl: Touch to force a build.
  • WebUserContentURLPattern.cpp:

(WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.

  • WebUserContentURLPattern.h: Added matchesURL.
10:08 PM Changeset in webkit [62624] by abarth@webkit.org
  • 5 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix <nobr><nobr> case in HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41735

We were both not handling <nobr> correctly, as well as
never hitting the <nobr> case because our formatting
elements check was overzealous.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement start table tag in table mode
​https://bugs.webkit.org/show_bug.cgi?id=41736

  • html5lib/runner-expected-html5.txt:
10:05 PM Changeset in webkit [62623] by eric@webkit.org
  • 7 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix <nobr><nobr> case in HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41735

  • html5lib/runner-expected-html5.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix <nobr><nobr> case in HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41735

We were both not handling <nobr> correctly, as well as
never hitting the <nobr> case because our formatting
elements check was overzealous.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
9:50 PM Changeset in webkit [62622] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2010-07-06 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Update expectation files for fast/forms/indeterminate.html. Chromium
started to support them on Windows and Linux recently.

  • platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-win/fast/forms/indeterminate-expected.checksum:
  • platform/chromium-win/fast/forms/indeterminate-expected.png:
  • platform/chromium/test_expectations.txt:
9:43 PM Changeset in webkit [62621] by abarth@webkit.org
  • 7 edits in trunk

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "act as if the banana has been peeled" (for lack of a better term)
​https://bugs.webkit.org/show_bug.cgi?id=41734

The spec has a tricky passage that says "whenever a node would be
inserted into the current node, it must instead be foster parented."
This patch attempts to implement that requirement.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertHTMLHeadElement): (WebCore::HTMLConstructionSite::insertHTMLBodyElement): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::RedirectToFosterParentGuard): (WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::~RedirectToFosterParentGuard):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processEndTagForInTable):
  • html/HTMLTreeBuilder.h:

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "act as if the banana has been peeled" (for lack of a better term)
​https://bugs.webkit.org/show_bug.cgi?id=41734

Massive test progression.

  • html5lib/runner-expected-html5.txt:
9:41 PM Changeset in webkit [62620] by tkent@chromium.org
  • 5 edits in trunk/WebKitTools

2010-07-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix a wrong dup detection of rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=41644

rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
tolerance. We don't need tolerance for rebaseline.

  • Scripts/webkitpy/layout_tests/port/base.py: Add optional tolerance parameter to diff_image().
  • Scripts/webkitpy/layout_tests/port/test.py: Add optional tolerance parameter to diff_image().
  • Scripts/webkitpy/layout_tests/port/webkit.py: Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: diff_files() always calls diff_image() with tolerance=0. diff_files() is used only by rebaseline-chromium-webkit-tests.
9:32 PM Changeset in webkit [62619] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-06 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Remove menulist-no-overflow.html, width100percent-checkbox.html, width100percent-radio.html, and button-sizes.html. They have been passed since Chromium r51096, test_shell flip issue.
9:23 PM Changeset in webkit [62618] by eric@webkit.org
  • 7 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix </optgroup> in "in select" mode
​https://bugs.webkit.org/show_bug.cgi?id=41733

  • html5lib/runner-expected-html5.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix </optgroup> in "in select" mode
​https://bugs.webkit.org/show_bug.cgi?id=41733

I had to add a oneBelowTop() accessor.
I added some ASSERTs after looking at the fragment case
documentation. I'm now convinced that top() and oneBeforeTop()
should never be NULL, so we just ASSERT they aren't.

This is a very obscure corner of the HTML spec, but at least
we have a test for it. This makes one more html5lib test pass.

  • html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::oneBelowTop):
  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::topRecord): (WebCore::HTMLElementStack::top): (WebCore::HTMLElementStack::oneBelowTop):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
8:48 PM Changeset in webkit [62617] by eric@webkit.org
  • 3 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix "in row" "Anything else" handling of end tags
​https://bugs.webkit.org/show_bug.cgi?id=41731

I also fixed </br> handling to follow the spec more closely
since it implementation was old and didn't use all our
new processFake* hotness.

This is already covered by 3 tests, however we don't
pass them yet, due to lack of table foster parenting
code (which Adam is working on as we speak).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
8:40 PM Changeset in webkit [62616] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix clean builds on Mac OS X.

Since "Copy Forwarding and ICU Headers" was split in to a separate target
from the WebCore framework it no longer had automatica access to the
PRIVATE_HEADERS_FOLDER_PATH variable. This caused it to copy the header
files in to the wrong location. Fix that by giving PRIVATE_HEADERS_FOLDER_PATH
its correct value and ensuring that the path exists.

  • WebCore.xcodeproj/project.pbxproj:
7:16 PM Changeset in webkit [62615] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Gtk build.

  • GNUmakefile.am:
7:12 PM Changeset in webkit [62614] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix.

Don't use WebCore's LDFLAGS when building WebCoreExportFileGenerator.

  • WebCore.xcodeproj/project.pbxproj:
6:49 PM Changeset in webkit [62613] by eric@webkit.org
  • 6 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

"In cell" does not correctly handle <td><tr> or <td><td>
​https://bugs.webkit.org/show_bug.cgi?id=41729

  • html5lib/resources/tables01.dat:
    • Added a case for <td><tr> since it was missing from the rest of the suite.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

"In cell" does not correctly handle <td><tr> or <td><td>
​https://bugs.webkit.org/show_bug.cgi?id=41729

This change is mostly cleanup to try and prevent forgetting
tag name checks in the future by using inlines to reduce
copy/paste code.

3 little bugs in InCellMode:

  • Missing trTag from the long or statement (reason for the cleanup)
Used
instead of &&
  • Forgot to reprocess the tag after closeTheCell()
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag):
6:35 PM Changeset in webkit [62612] by oliver@apple.com
  • 12 edits in trunk/JavaScriptCore

2010-07-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Make it possible to have both the JIT and Interpreter available in a single build
​https://bugs.webkit.org/show_bug.cgi?id=41722

Separate the concept of !ENABLE(JIT) and ENABLE(INTERPRETER) and make it possible
to have both JIT and INTERPRETER enabled at the same time. This doesn't add
support for mix mode execution, but it does allow a single build to contain all
the code needed to use either the interpreter or the jit.

If both ENABLE(INTERPRETER) and ENABLE(JIT) are true then setting the environment
variable JSC_FORCE_INTERPRETER will force JSC to use the interpreter.

This patch basically consists of replacing !ENABLE(JIT) with ENABLE(INTERPRETER),
or converting #if ENABLE(JIT) ... #else ... into #if ENABLE(JIT) ... #endif
#if ENABLE(INTERPRETER), etc. There are also a few functions that need to be
renamed to resolve return type ambiguity.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h:
  • interpreter/CallFrame.h: (JSC::ExecState::returnVPC):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
  • interpreter/Interpreter.h:
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::EvalExecutable::generateJITCode): (JSC::ProgramExecutable::generateJITCode): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/JSFunction.cpp:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::canUseJIT):
  • wtf/Platform.h:
6:34 PM Changeset in webkit [62611] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move fosterParent to HTMLConstructionSite
​https://bugs.webkit.org/show_bug.cgi?id=41728

This paves the way for handling the default case of InTableMode
properly.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
6:16 PM Changeset in webkit [62610] by abarth@webkit.org
  • 10 edits
    2 copies in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move HTMLConstructionSite to its own file. No behavior change.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLConstructionSite.cpp: Copied from WebCore/html/HTMLTreeBuilder.cpp. (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::~HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
  • html/HTMLConstructionSite.h: Copied from WebCore/html/HTMLTreeBuilder.h.
  • html/HTMLTreeBuilder.cpp:
  • html/HTMLTreeBuilder.h:
6:08 PM Changeset in webkit [62609] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

The path to the generated file needs to be relative to the built product directory,
not to the project file.

  • WebCore.xcodeproj/project.pbxproj:
6:01 PM Changeset in webkit [62608] by mrowe@apple.com
  • 3 edits
    1 move
    1 add
    20 deletes in trunk/WebCore

<​http://webkit.org/b/41725> REGRESSION(r62283): No longer possible to build for Tiger from SnowLeopard due to export file shenanigans

Reviewed by Darin Adler.

Change how the exports file is generated. Rather than having the logic for which symbols
to include be encoded in a Makefile that concatenated separate files, the logic is now
encoded as #if's in the base exports file. This ensures that the exact same preprocessor
settings are used when determining which symbols to export as when compiling the code that
defines the symbols.

  • DerivedSources.make: Remove logic that determines which export files to concatenate.

Replace with an invocation of WebCoreExportFileGenerator.

  • WebCore.3DRendering.exp: Removed.
  • WebCore.AcceleratedCompositing.exp: Removed.
  • WebCore.ClientBasedGeolocation.exp: Removed.
  • WebCore.ContextMenus.exp: Removed.
  • WebCore.DashboardSupport.exp: Removed.
  • WebCore.DragSupport.exp: Removed.
  • WebCore.Geolocation.exp: Removed.
  • WebCore.Inspector.exp: Removed.
  • WebCore.JNI.exp: Removed.
  • WebCore.NPAPI.exp: Removed.
  • WebCore.OrientationEvents.exp: Removed.
  • WebCore.PluginHostProcess.exp: Removed.
  • WebCore.ProtectionSpaceAuthCallback.exp: Removed.
  • WebCore.SVG.Animation.exp: Removed.
  • WebCore.SVG.Filters.exp: Removed.
  • WebCore.SVG.ForeignObject.exp: Removed.
  • WebCore.SVG.exp: Removed.
  • WebCore.Tiger.exp: Removed.
  • WebCore.Video.exp: Removed.
  • WebCore.VideoProxy.exp: Removed.
  • WebCore.exp.in: Renamed from WebCore/WebCore.base.exp. Merge the individual .exp

files in, wrapping the appropriate parts with the necessary #if's.

  • WebCore.xcodeproj/project.pbxproj:
  • make-exports-file-generator: Added.
5:46 PM Changeset in webkit [62607] by weinig@apple.com
  • 10 edits
    3 adds in trunk/WebCore

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41723
Add BackForwardController class

Reviewed by Anders Carlsson.

  • Add BackForwardController which currently only forwards to the existing BackForwardList implementation. This is a first step toward allowing for a proxying BackForwardList implementation.
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • history/BackForwardController.cpp: Added.

(WebCore::BackForwardController::BackForwardController):
(WebCore::BackForwardController::~BackForwardController):

  • history/BackForwardController.h: Added.

(WebCore::BackForwardController::client):
(WebCore::BackForwardController::list):

  • history/BackForwardControllerClient.h: Added.

(WebCore::BackForwardControllerClient::~BackForwardControllerClient):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::backForwardList):
(WebCore::Page::goBack):
(WebCore::Page::goForward):
(WebCore::Page::canGoBackOrForward):
(WebCore::Page::goBackOrForward):
(WebCore::Page::getHistoryLength):

  • page/Page.h:
5:17 PM Changeset in webkit [62606] by vitalyr@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-06 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Update more expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [62605] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows WebKit2 build.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::mimeTypeFromExtension):

4:20 PM Changeset in webkit [62604] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed.

Fixes regression on API test by disabling the scrollbars before
configuring the adjustments.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
4:08 PM Changeset in webkit [62603] by eric@webkit.org
  • 7 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add support for <li>, <dd> and <dt> nested tag closing
​https://bugs.webkit.org/show_bug.cgi?id=41720

  • html5lib/resources/webkit01.dat:
    • Add test for <dd><dt> since this wasn't well covered.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add support for <li>, <dd> and <dt> nested tag closing
​https://bugs.webkit.org/show_bug.cgi?id=41720

li, dd, and dt have nearly identical logic in HTML5, so I
attempted to make them share as much code as possible.

This fixes a bunch of subtests for html5lib/runner.html

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
  • html/HTMLTreeBuilder.h:
4:03 PM Changeset in webkit [62602] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit/qt

Client errors should set "WebKitErrorDomain" domain instead of "WebKit" to match Mac.

Rubber-stamped by Kenneth Rohde Christiansen.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):

4:02 PM Changeset in webkit [62601] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-06 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Update expectations.

  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [62600] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Add PluginInfoStore::findPlugin
​https://bugs.webkit.org/show_bug.cgi?id=41719

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::getPlugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::pathExtension):
(WebKit::PluginInfoStore::findPlugin):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::mimeTypeFromExtension):

3:51 PM Changeset in webkit [62599] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor HTMLConstructionSite out of HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41716

The HTMLContructionSite is the model object on which the
HTMLTreeBuilder (a controller) acts.

No behavior change. I'll move this class into its own file in a
followup patch.

  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::at):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody): (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInScope): (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::closeTheCell): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement): (WebCore::HTMLTreeBuilder::findFosterParentFor): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processTrEndTagForInRow): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processDefaultForBeforeHTMLMode): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLConstructionSite::insertDoctype): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnDocument): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::createElementAndAttachToCurrent): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertHTMLHeadElement): (WebCore::HTMLConstructionSite::insertHTMLBodyElement): (WebCore::HTMLConstructionSite::insertElement): (WebCore::HTMLConstructionSite::insertSelfClosingElement): (WebCore::HTMLConstructionSite::insertFormattingElement): (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLTreeBuilder::processScriptStartTag): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements): (WebCore::HTMLTreeBuilder::generateImpliedEndTagsWithExclusion): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLConstructionSite::currentElement): (WebCore::HTMLConstructionSite::openElements): (WebCore::HTMLConstructionSite::activeFormattingElements): (WebCore::HTMLConstructionSite::head): (WebCore::HTMLConstructionSite::form): (WebCore::HTMLConstructionSite::releaseForm): (WebCore::HTMLConstructionSite::setForm): (WebCore::HTMLConstructionSite::fragmentScriptingPermission): (WebCore::HTMLConstructionSite::attach):
3:32 PM Changeset in webkit [62598] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Scrollbars sometimes go dead and stop scrolling the view
​https://bugs.webkit.org/show_bug.cgi?id=41711

Fixes GtkScrolledWindow scrollbars not actually scrolling the page
in certain conditions. No tests because it is hard to reproduce,
and depends on interaction with a widget that is outside of the
WebView, which is tricky.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
2:26 PM Changeset in webkit [62597] by vitalyr@chromium.org
  • 3 edits
    11 adds in trunk/LayoutTests

2010-07-06 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Update expectations.

  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt: Added.
2:21 PM Changeset in webkit [62596] by Darin Adler
  • 8 edits in trunk/WebCore

2010-07-06 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Simplify access to element attribute map, removing unneeded functions
​https://bugs.webkit.org/show_bug.cgi?id=41703

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the attributeMap function instead of the mappedAttributes function. (WebCore::CSSStyleSelector::styleForElement): Ditto.
  • dom/Element.cpp: (WebCore::Element::~Element): Renamed namedAttrMap to m_attributeMap. (WebCore::Element::removeAttribute): Ditto. (WebCore::Element::getAttribute): Ditto. (WebCore::Element::setAttribute): Ditto. (WebCore::Element::setAttributeMap): Ditto. (WebCore::Element::hasAttributes): Ditto. (WebCore::Element::createAttributeMap): Ditto. (WebCore::Element::insertedIntoDocument): Ditto. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::getURLAttribute): Ditto.
  • dom/Element.h: Removed unneeded virtual attributes function. Made read-only argument to attributes function default to false. (Later, we'll eliminate this.) Renamed namedAttrMap to m_attributeMap and made it private instead of protected.
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): Use attributeMap function instead of namedAttrMap data member or mappedAttributes function. (WebCore::StyledElement::classAttributeChanged): Ditto. (WebCore::StyledElement::parseMappedAttribute): Ditto.
  • dom/StyledElement.h: Removed mappedAttributes function and changed callers to use attributeMap function instead.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Use attributeMap instead of mappedAttributes.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
2:13 PM Changeset in webkit [62595] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix MiniBrowser build.

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:
2:02 PM Changeset in webkit [62594] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add a build rule that removes the old generated Obj-C bindings for PluginArray and MimeTypeArray.

Reviewed by Sam Weinig.

  • DerivedSources.make:
1:58 PM Changeset in webkit [62593] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Unreviewed.

Make the remaining insertion modes explicit.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
1:51 PM Changeset in webkit [62592] by ap@apple.com
  • 4 edits in trunk

Not reviewed, fixing a simple copy/paste mistake.

​https://bugs.webkit.org/show_bug.cgi?id=41156
Cross origin XMLHttpRequest should log the reason why connection failed

Covered by xmlhttprequest/access-control-basic-non-simple-deny-cached.html

  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): Fix incorrectly copy/pasted header field name.
1:51 PM Changeset in webkit [62591] by weinig@apple.com
  • 3 edits in trunk/WebKitTools

Add support for dumping the contents of messages to the console to WebKitTestRunner

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_addMessageToConsole):
(WTR::InjectedBundlePage::addMessageToConsole):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1:43 PM Changeset in webkit [62590] by weinig@apple.com
  • 10 edits
    2 moves
    2 adds in trunk/WebKit2

Add injected bundle API for exposing console messages.

Reviewed by Anders Carlsson.

  • Split WKBundlePageClient into multiple clients matching WKPage. (For now we only have a loader client and a UI client)
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetLoaderClient):
(WKBundlePageSetUIClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: Copied from WebProcess/InjectedBundle/InjectedBundlePageClient.cpp.

(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
(WebKit::InjectedBundlePageLoaderClient::initialize):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: Copied from WebProcess/InjectedBundle/InjectedBundlePageClient.h.
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Added.

(WebKit::InjectedBundlePageUIClient::InjectedBundlePageUIClient):
(WebKit::InjectedBundlePageUIClient::initialize):
(WebKit::InjectedBundlePageUIClient::addMessageToConsole):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageToConsole):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleLoaderClient):
(WebKit::WebPage::initializeInjectedBundleUIClient):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleLoaderClient):
(WebKit::WebPage::injectedBundleUIClient):

  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
1:31 PM Changeset in webkit [62589] by Darin Adler
  • 2 edits in trunk/WebKit/chromium

Try to fix build.

Why do the Chromium bots stop after the first error they encounter?

  • src/WebWorkerImpl.cpp:

(WebKit::WebWorkerImpl::postMessageToWorkerContextTask): Removed
unneeded release called on a PassOwnPtr to pass it as an argument of
type PassOwnPtr.

1:30 PM Changeset in webkit [62588] by kov@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Adding webkit bugzilla reference for 62546

1:27 PM Changeset in webkit [62587] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Fix crash caused by my fix to the Qt build.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::closeWindow): Release pointer into
a local OwnPtr instead of calling clear. Another fix, probably better,
would be to change OwnPtr::clear to zero out the pointer before deleting,
but that affects many more call sites, so I will do that separately.

1:23 PM Changeset in webkit [62586] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Xan Lopez <​xlopez@igalia.com>

GTK+ fixes for the DOM plug-in renaming Apocalypse.

  • GNUmakefile.am:
1:18 PM Changeset in webkit [62585] by Darin Adler
  • 3 edits in trunk/WebKit/chromium

Try to fix build.

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::dispatchTaskToMainThread): Use leakPtr instead
of release.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask): Removed
unneeded release called on a PassOwnPtr to pass it as an argument of
type PassOwnPtr.

1:14 PM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
1:05 PM Changeset in webkit [62584] by andersca@apple.com
  • 2 edits in trunk/WebCore

Yet another Windows build fix.

  • DerivedSources.cpp:
12:57 PM Changeset in webkit [62583] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
12:39 PM Changeset in webkit [62582] by andersca@apple.com
  • 3 edits in trunk/WebCore

More build fixes.

  • WebCore.gypi:
  • WebCore.pro:
12:33 PM Changeset in webkit [62581] by andersca@apple.com
  • 2 edits in trunk/WebCore

Try to fix Qt build.

  • WebCore.pro:
12:32 PM Changeset in webkit [62580] by andersca@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix GTK+ build.

  • GNUmakefile.am:
12:29 PM Changeset in webkit [62579] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Address reviewer comments from ​https://bugs.webkit.org/show_bug.cgi?id=41671

Deploy isTableBodyContextTag where possible. No behavior change.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag):
12:27 PM Changeset in webkit [62578] by andersca@apple.com
  • 3 edits in trunk/WebCore

Build fixes.

  • WebCore.gypi:
  • bindings/js/JSBindingsAllInOne.cpp:
12:13 PM Changeset in webkit [62577] by andersca@apple.com
  • 12 edits
    15 moves in trunk/WebCore

DOM plug-in related renames
​https://bugs.webkit.org/show_bug.cgi?id=41709

Reviewed by Sam Weinig.

This is in preparation for using "Plugin" for something other than a DOM object.

MimeType => DOMMimeType
MimeTypeArray => DOMMimeTypeArray
Plugin => DOMPlugin
PluginArray => DOMPluginArray

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMMimeTypeArrayCustom.cpp: Added.

(WebCore::JSDOMMimeTypeArray::canGetItemsForName):
(WebCore::JSDOMMimeTypeArray::nameGetter):

  • bindings/js/JSDOMPluginArrayCustom.cpp: Added.

(WebCore::JSDOMPluginArray::canGetItemsForName):
(WebCore::JSDOMPluginArray::nameGetter):

  • bindings/js/JSDOMPluginCustom.cpp: Added.

(WebCore::JSDOMPlugin::canGetItemsForName):
(WebCore::JSDOMPlugin::nameGetter):

  • bindings/js/JSMimeTypeArrayCustom.cpp: Removed.
  • bindings/js/JSPluginArrayCustom.cpp: Removed.
  • bindings/js/JSPluginCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
  • page/Navigator.cpp:

(WebCore::Navigator::plugins):
(WebCore::Navigator::mimeTypes):

  • page/Navigator.h:
  • page/Navigator.idl:
  • plugins/DOMMimeType.cpp: Added.

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):
(WebCore::DOMMimeType::type):
(WebCore::DOMMimeType::suffixes):
(WebCore::DOMMimeType::description):
(WebCore::DOMMimeType::enabledPlugin):

  • plugins/DOMMimeType.h: Added.

(WebCore::DOMMimeType::create):
(WebCore::DOMMimeType::mimeClassInfo):

  • plugins/DOMMimeType.idl: Added.
  • plugins/DOMMimeTypeArray.cpp: Added.

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):
(WebCore::DOMMimeTypeArray::~DOMMimeTypeArray):
(WebCore::DOMMimeTypeArray::length):
(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::canGetItemsForName):
(WebCore::DOMMimeTypeArray::namedItem):
(WebCore::DOMMimeTypeArray::getPluginData):

  • plugins/DOMMimeTypeArray.h: Added.

(WebCore::DOMMimeTypeArray::create):
(WebCore::DOMMimeTypeArray::disconnectFrame):

  • plugins/DOMMimeTypeArray.idl: Added.
  • plugins/DOMPlugin.cpp: Added.

(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):
(WebCore::DOMPlugin::name):
(WebCore::DOMPlugin::filename):
(WebCore::DOMPlugin::description):
(WebCore::DOMPlugin::length):
(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::canGetItemsForName):
(WebCore::DOMPlugin::namedItem):

  • plugins/DOMPlugin.h: Added.

(WebCore::DOMPlugin::create):
(WebCore::DOMPlugin::pluginInfo):

  • plugins/DOMPlugin.idl: Added.
  • plugins/DOMPluginArray.cpp: Added.

(WebCore::DOMPluginArray::DOMPluginArray):
(WebCore::DOMPluginArray::~DOMPluginArray):
(WebCore::DOMPluginArray::length):
(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::canGetItemsForName):
(WebCore::DOMPluginArray::namedItem):
(WebCore::DOMPluginArray::refresh):
(WebCore::DOMPluginArray::pluginData):

  • plugins/DOMPluginArray.h: Added.

(WebCore::DOMPluginArray::create):
(WebCore::DOMPluginArray::disconnectFrame):

  • plugins/DOMPluginArray.idl: Added.
  • plugins/MimeType.cpp: Removed.
  • plugins/MimeType.h: Removed.
  • plugins/MimeType.idl: Removed.
  • plugins/MimeTypeArray.cpp: Removed.
  • plugins/MimeTypeArray.h: Removed.
  • plugins/MimeTypeArray.idl: Removed.
  • plugins/Plugin.cpp: Removed.
  • plugins/Plugin.h: Removed.
  • plugins/Plugin.idl: Removed.
  • plugins/PluginArray.cpp: Removed.
  • plugins/PluginArray.h: Removed.
  • plugins/PluginArray.idl: Removed.
12:10 PM Changeset in webkit [62576] by ap@apple.com
  • 35 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41156
Cross origin XMLHttpRequest should log the reason why connection failed

Covered by multiple existing tests.

  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::parse): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
  • loader/CrossOriginPreflightResultCache.h: Functions that check requests now take a string argument for error explanation.
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Make an informative error if crossOriginRequestPolicy is DenyCrossOriginRequests. This doesn't currently go anywhere, since XMLHttpRequest is the only client that logs from didFail(), and it of course supports cross origin requests. (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Make an informative error when trying to e.g. send a cross origin XMLHttpRequest to ​ftp://. (WebCore::DocumentThreadableLoader::didReceiveResponse): Pass error explanation from cross origin access control code. (WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
  • loader/DocumentThreadableLoader.h: preflightFailure() now takes arguments.
  • platform/network/ResourceErrorBase.cpp:
  • platform/network/ResourceErrorBase.h: Added a constant for WebKit error domain.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFail): Report the error to console. One day we'll be able to also provide script file and line number here, so it's best to pass error all the way down to XHR for reporting.
11:52 AM Changeset in webkit [62575] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: convert script offset to webkit format in v8 ScriptDebugServer
​https://bugs.webkit.org/show_bug.cgi?id=41696

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
11:34 AM Changeset in webkit [62574] by Darin Adler
  • 2 edits in trunk/WebKit/chromium

Fix build.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask): Removed unneeded release
called on a PassOwnPtr to pass it as an argument of type PassOwnPtr.

11:33 AM Changeset in webkit [62573] by abarth@webkit.org
  • 6 edits in trunk

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InTableBodyMode
​https://bugs.webkit.org/show_bug.cgi?id=41671

In the process of implementing this patch, Eric and I discussed some of
the high-level organization of the HTMLTreeBuilder class. We'd like to
split it up into smaller pieces. In the meantime, I've reordered some
of the declarations in the header to make the relations between the
different kinds of functions clearer.

  • html/HTMLElementStack.cpp:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
  • html/HTMLTreeBuilder.h:

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InTableBodyMode
​https://bugs.webkit.org/show_bug.cgi?id=41671

  • html5lib/runner-expected-html5.txt:
11:25 AM Changeset in webkit [62572] by weinig@apple.com
  • 3 edits in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41708
Add dumpAsText support for WebKitTestRunner

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
API to dump the main frames text.

11:18 AM Changeset in webkit [62571] by leandro@webkit.org
  • 4 edits in trunk

2010-07-06 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

[EFL] Generate code for RemoteInspector.

  • CMakeLists.txt:

2010-07-06 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

[EFL] Add macro to generate inspector code.

  • cmake/WebKitGenerators.cmake:
11:12 AM Changeset in webkit [62570] by Darin Adler
  • 2 edits in trunk/WebKitTools

Fix Chromium build.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didCreateDataSource): Call leakPtr instead of release.
(WebViewHost::didNavigateWithinPage): Ditto.
(WebViewHost::updateURL): Ditto.

11:10 AM Changeset in webkit [62569] by Darin Adler
  • 2 edits in trunk/WebKit/chromium

Fix build.

  • src/WebDataSourceImpl.cpp:

(WebKit::WebDataSourceImpl::setNextPluginLoadObserver): Call leakPtr
here instead of release. Comment makes it really unclear why it's OK!

11:10 AM Changeset in webkit [62568] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2010-07-06 Varun Jain <​varunjain@chromium.org>

Reviewed by Oliver Hunt.

Implementing CURVE_TO_CUBIC specification for SVG Path Segments. Currently,
curves specified in relative cordinates such as using createCurvetoCubicRel()
javascript function are not displayed.

SVG CurvetoCubic Path not implemented for relative cordinates
​https://bugs.webkit.org/show_bug.cgi?id=41294

  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt: Added.
  • svg/custom/svg-curve-with-relative-cordinates.html: Added.

2010-07-06 Varun Jain <​varunjain@chromium.org>

Reviewed by Oliver Hunt.

Implementing CURVE_TO_CUBIC specification for SVG Path Segments. Currently,
curves specified in relative cordinates such as using createCurvetoCubicRel()
javascript function are not displayed.

SVG CurvetoCubic Path not implemented for relative cordinates
​https://bugs.webkit.org/show_bug.cgi?id=41294

Test: svg/custom/svg-curve-with-relative-cordinates.html

  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
11:09 AM Changeset in webkit [62567] by weinig@apple.com
  • 6 edits in trunk/WebKit2

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41707
Add ability to dump frame inner text for the test runner

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyInnerText):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::innerText):

  • WebProcess/WebPage/WebFrame.h:
  • mac/WebKit2.exp:
10:52 AM Changeset in webkit [62566] by ap@apple.com
  • 3 edits in trunk/WebCore

Roll out patch for ​https://bugs.webkit.org/show_bug.cgi?id=41348 "Remove global variables
from XSLTProcessorLibxslt.cpp", as it causes crashes on buildbot.

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::xslStylesheet): (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
10:51 AM Changeset in webkit [62565] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-06 Xan Lopez <​xlopez@igalia.com>

Skip flakey a11y test.

  • platform/gtk/Skipped:
10:44 AM Changeset in webkit [62564] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-07-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] build-webkit should not run autogen.sh unconditionally
​https://bugs.webkit.org/show_bug.cgi?id=41704

  • Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile doesn't exist. Autotools should re-run autogen.sh when necessary. Also do some very minor cleanup.
10:28 AM Changeset in webkit [62563] by abarth@webkit.org
  • 10 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add processing for "in cell" mode and end tag processing for "in row"
​https://bugs.webkit.org/show_bug.cgi?id=41688

I added several new table tests, not all of which pass yet.
Remaining failures exist due to lack of full "in table body" mode
support, which Adam has an outstanding patch for.
I believe all of the various branches added by this change are
covered now by our tests.

  • html/HTMLElementStack.cpp:
    • Added QualifiedName versions of inScope functions. Using tagName.localName() is wrong for non-HTML elements, in preparation for supporting foreign content we should centralize our handling of QualifiedName in these functions instead of sprinkling more .localName() calls around the code.

(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):

  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::Entry::operator==): (WebCore::HTMLFormattingElementList::Entry::operator!=):
    • Calling element() on markers will assert, so use m_element.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::closeTheCell):
    • Implemented per the spec.

(WebCore::HTMLTreeBuilder::processStartTag):

  • Use isTableBodyContextTag where possible.
  • Add InCellMode.

(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

  • Use isTableBodyContextTag where possible.

(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):

  • This code is needed from at least two callsites.

(WebCore::HTMLTreeBuilder::processEndTag):

  • Add InCellMode and InRowMode

(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/HTMLTreeBuilder.h:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add processing for "in cell" mode and end tag processing for "in row"
​https://bugs.webkit.org/show_bug.cgi?id=41688

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
10:25 AM Changeset in webkit [62562] by abarth@webkit.org
  • 4 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make <a> auto-close any parent <a> tag
​https://bugs.webkit.org/show_bug.cgi?id=41684

I first fixed <a> to auto-close surrounding <a> tags.
That caused about 3 more test passes and one new test failure.
The test failure was due to <marque> not adding a marker
to the active formatting elements.

So I made a one-line change to fix <marque>. However that hit an
ASSERT due to a bug in indexOfFirstUnopenFormattingElement.
Fixing indexOfFirstUnopenFormattingElement fixed another bunch of
Adoption Agency related tests (clearly this was the second typo
which was causing all the adoption agency failures).


However fixing <marque> and indexOfFirstUnopenFormattingElement,
added yet another failure due to missing support for </p>
automatically adding an implicit <p> tag. Fixing </p> finally
got the tests to a stable (all improving) state.

In the end, these 4 minor (and very well tested) tweaks fixed a total
of 9 subtests in html5lib/runner.html.
Another subtest progressed, but did not fully pass due to missing
<table> foster-parenting support.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement):

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make <a> auto-close any parent <a> tag
​https://bugs.webkit.org/show_bug.cgi?id=41684

  • html5lib/runner-expected-html5.txt:
    • Update expectations now that we pass 9 more subtests.
10:16 AM Changeset in webkit [62561] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-07-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez

[GStreamer] can't seek past maxTimeLoaded value
​https://bugs.webkit.org/show_bug.cgi?id=40526

Extended the seekable range to the whole media. This allows video
played with progressive download to be seeked past the current
buffered position.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
10:09 AM Changeset in webkit [62560] by andersca@apple.com
  • 7 edits
    4 copies
    3 moves
    1 add
    1 delete in trunk/WebKit2

Only export a single WebKitMain function for the Web Process to call
​https://bugs.webkit.org/show_bug.cgi?id=41702

Reviewed by Sam Weinig.

  • Shared/CommandLine.h:

Add windows CommandLine::parse overload.

  • Shared/win/CommandLineWin.cpp: Added.

(WebKit::CommandLine::parse):
Move parse overload from WebProcess/win/WebProcessMain.cpp.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):
Pass the right mode to.

  • WebKit2.xcodeproj/project.pbxproj:

Update for moves.

  • WebProcess/Launching/mac/WebProcessMain.mm: Removed.
  • WebProcess/Launching/win/WebProcessWinMain.cpp: Removed.
  • WebProcess/WebKitMain.cpp: Added.

(WebKitMain):
(enableTerminationOnHeapCorruption):
Add WebKitMain functions for Mac and Windows.

  • WebProcess/WebProcessMain.h: Added.
  • WebProcess/mac/WebProcessMainMac.mm: Added.

(WebKit::WebProcessMain):
Add Mac version of WebProcessMain.

  • WebProcess/win/WebProcessMain.cpp: Removed.
  • WebProcess/win/WebProcessMain.h: Removed.
  • WebProcess/win/WebProcessMainWin.cpp: Added.

(WebKit::WebProcessMain):
Add Windows version of WebProcessMain.

  • mac/MainMac.cpp: Added.

(main):
Add Mac WebProcess main function.

  • mac/WebKit2.exp:

Remove functions that we don't need to export.

  • win/MainWin.cpp: Added.

(wWinMain):
Add Windows WebProcess main function.

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

Update for moves.

10:05 AM Changeset in webkit [62559] by ap@apple.com
  • 3 edits in trunk/WebCore

2010-07-06 Andreas Wictor <​andreas.wictor@xcerion.com>

Reviewed by Alexey Proskuryakov.

Remove global variables from XSLTProcessorLibxslt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=41348

Remove the globalProcessor and globalDocLoader global variables
by using the _private field that exists on most libxml structs.

No new tests, existing tests covers this.

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::sourceNode): (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::registredXSLTProcessors): (WebCore::registredXSLStyleSheets): (WebCore::docLoaderFunc): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
9:45 AM Changeset in webkit [62558] by Darin Adler
  • 2 edits in trunk/WebKit/chromium

Fix build.

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerRepository::connect): Remove unneeded release
called on a PassOwnPtr to pass it as an argument of type PassOwnPtr.

9:38 AM Changeset in webkit [62557] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Cairo build.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::createPlatformShadow): Removed unnneded release
in code that passes a PassOwnPtr to another PassOwnPtr.

9:36 AM Changeset in webkit [62556] by Darin Adler
  • 2 edits in trunk/WebKitTools

Try to fix Chromium build.

  • DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
9:35 AM Changeset in webkit [62555] by Darin Adler
  • 2 edits in trunk/WebKitTools

Fix build.

  • WebKitAPITest/TestsController.cpp:

(WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.

9:32 AM Changeset in webkit [62554] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Fix Qt build.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::closeWindow): Call clear instead of
calling delete on the result of leakPtr.

9:31 AM Changeset in webkit [62553] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Chromium build.

  • platform/graphics/skia/SkiaUtils.cpp:

(WebCore::scratchContext): Use leakPtr instead of release.

9:28 AM Changeset in webkit [62552] by Martin Robinson
  • 4 edits in trunk

2010-07-06 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Build fix after r62549.

  • GNUmakefile.am: Remove new variable that is no longer used.

2010-07-06 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Build fix after r62549.

  • GNUmakefile.am: Generate RemoteInspector files by manually listing them instead of building them into libWebCoreJS.la.
9:14 AM Changeset in webkit [62551] by Darin Adler
  • 32 edits in trunk

2010-07-06 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Add adoptPtr and leakPtr functions for OwnPtr and PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=41320

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): Use assignment instead of set since the result of reparseExceptionInfo is now a PassOwnPtr.
  • bytecode/CodeBlock.h: Change extractExceptionInfo to return a PassOwnPtr instead of a raw pointer.
  • runtime/Executable.cpp: (JSC::FunctionExecutable::reparseExceptionInfo): Return a PassOwnPtr. (JSC::EvalExecutable::reparseExceptionInfo): Ditto. (JSC::ProgramExecutable::reparseExceptionInfo): Added. This was in the header before, but it's better to not have it there to reduce header dependencies. Return a PassOwnPtr.
  • runtime/Executable.h: Made reparseExceptionInfo return a PassOwnPtr, and put it in the private sections of classes other than the base class.
  • wtf/MessageQueue.h: (WTF::MessageQueue::append): Use leakPtr instead of release. (WTF::MessageQueue::appendAndCheckEmpty): Ditto. (WTF::MessageQueue::prepend): Ditto.
  • wtf/OwnPtr.h: Tweaked formatting. Changed the release function to return a PassOwnPtr rather than a raw pointer. Added a leakPtr function that returns a raw pointer. Put the constructor that takes a raw pointer and the set function into a section guarded by LOOSE_OWN_PTR. Adapted to the new adoptPtr function from PassOwnPtr.h.
  • wtf/PassOwnPtr.h: Tweaked formatting. Renamed the release function to leakPtr. Added an adoptPtr function that creates a new PassOwnPtr. Put the constructor and assignment operators that take a raw pointer into a section guarded by LOOSE_PASS_OWN_PTR.

2010-07-06 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Add adoptPtr and leakPtr functions for OwnPtr and PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=41320

Made code changes required because of the change to the release function.
The equivalent to the old release function is now named leakPtr and
should be used sparingly. The new release function returns a PassOwnPtr.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Changed code to call leakPtr instead of release.
  • css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Ditto.
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::getFontData): Removed unneeded type casting. Not sure why this changed the type to FontData* and then casted back to SimpleFontData*.
  • css/MediaQuery.cpp: (WebCore::MediaQuery::MediaQuery): Removed call to release on a PassOwnPtr, since the data member is now an OwnPtr. (WebCore::MediaQuery::~MediaQuery): Removed now-unneeded delete.
  • css/MediaQuery.h: Changed m_expressions to be an OwnPtr.
  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken): Use assignment instead of the set function since there are no raw pointers involved.
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable): Ditto.
  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCache::appendEntry): Use leakPtr instead of release, and also add FIXME about deleting the old value if the original and URL are already in the map. I believe dealing with this FIXME may fix a storage leak.
  • loader/CrossOriginPreflightResultCache.h: Change the argument to be PassOwnPtr instead of a raw pointer, since this function does take ownership.
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Use assignment instead of the set function since there are no raw pointers involved.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): Ditto.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::decode): Ditto. (WebCore::TextResourceDecoder::flush): Ditto.
  • page/DOMTimer.cpp: (WebCore::DOMTimer::fired): Use OwnPtr instead of an explicit delete.
  • platform/CrossThreadCopier.h: Removed explicit code that tried to copy PassOwnPtr in a complicated way. It did nothing different from just returning the PassOwnPtr. This presumably was done because PassRefPtr has issues when copied cross-thread, but there are no similar issues for PassOwnPtr. Someone with more experience than I might be able to remove the specialization altogether, because CrossThreadCopierPassThrough does the right thing in this case.
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::adoptPurgeableBuffer): Changed argument to be a PassOwnPtr. (WebCore::SharedBuffer::releasePurgeableBuffer): Changed result to be a PassOwnPtr.
  • platform/SharedBuffer.h: Updated for changes above.
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): Changed one site to use assignment instead of the set function since there are no raw pointers involved. Changed another site to use leakPtr instead of release.
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use assignment instead of the set function since there are no raw pointers involved.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Use leakPtr instead of release. (WebCore::RenderStyle::setBoxShadow): Ditto.
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::DefaultSharedWorkerRepository::connectToWorker): Removed unneeded call to release function in a code path that passes a PassOwnPtr to a function that takes a PassOwnPtr.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::setTimeout): Changed argument type to PassOwnPtr. (WebCore::WorkerContext::setInterval): Ditto.
  • workers/WorkerContext.h: Updated for changes above.
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Removed unneeded call to release function in code paths that pass a PassOwnPtr to a function that takes a PassOwnPtr.
8:47 AM Changeset in webkit [62550] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Update comment in StringExtras.h to be more accurate.

Reviewed by Darin Adler

  • wtf/StringExtras.h:
8:04 AM Changeset in webkit [62549] by loislo@chromium.org
  • 21 edits
    2 adds in trunk

2010-07-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: generator part of the patch for bug 40675.
On the way to Remote Debugging we want to support JSON serialization
on both sides of WebInspector transport.
As far as InspectorFrontend class is a simple proxy to WebInspector
it would be better to generate it from an IDL file.
We have generator infrastructure for binding and will reuse it for
new generator.
​https://bugs.webkit.org/show_bug.cgi?id=41692

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::startTimelineProfiler):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontend2.idl: Added.
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject): (WebCore::InspectorTimelineAgent::addRecordToTimeline):
  • inspector/InspectorTimelineAgent.h:
7:58 AM Changeset in webkit [62548] by vitalyr@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-06 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Update expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/svg/hixie/error/013-expected.txt:
6:55 AM Changeset in webkit [62547] by commit-queue@webkit.org
  • 8 edits in trunk/JavaScriptCore/qt

2010-07-06 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of QScriptValue properties accessors.

The patch contains implementation of the QScriptValue::property() and
the QScriptValue::setProperty(). It is not full functionality, as these
method are too complex for one patch, but it is enough to cover about
95% of use cases.

Missing functionality:

  • Few of the PropertyFlags are ignored.
  • Only a public part of the ResolveFlags can be used (ResolveLocal, ResolvePrototype).

A lot of new test cases were added.

[Qt] QScriptValue should have API for accessing object properties
​https://bugs.webkit.org/show_bug.cgi?id=40903

  • api/qscriptconverter_p.h: (QScriptConverter::toPropertyFlags):
  • api/qscriptstring_p.h: (QScriptStringPrivate::operator JSStringRef):
  • api/qscriptvalue.cpp: (QScriptValue::property): (QScriptValue::setProperty):
  • api/qscriptvalue.h: (QScriptValue::):
  • api/qscriptvalue_p.h: (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::property): (QScriptValuePrivate::hasOwnProperty): (QScriptValuePrivate::setProperty): (QScriptValuePrivate::deleteProperty):
  • tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::getPropertySimple_data): (tst_QScriptValue::getPropertySimple): (tst_QScriptValue::setPropertySimple): (tst_QScriptValue::getPropertyResolveFlag): (tst_QScriptValue::getSetProperty): (tst_QScriptValue::setProperty_data): (tst_QScriptValue::setProperty):
  • tests/qscriptvalue/tst_qscriptvalue.h:
5:52 AM Changeset in webkit [62546] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Crash when hitting back on some pages
​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236

Also NULL-check document, in hopes of fixing this hard to
reproduce crash that we are getting reported quite a bit.

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
5:11 AM Changeset in webkit [62545] by rolandsteiner@chromium.org
  • 7 edits
    3 copies
    3 adds in trunk/WebKitTools

2010-07-06 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=40558

Upstream DevTools for Chromium DRT.
(original Chromium files rev. 51287)

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added. (DRTDevToolsAgent::DRTDevToolsAgent): (DRTDevToolsAgent::setWebView): (DRTDevToolsAgent::sendMessageToFrontend): (DRTDevToolsAgent::forceRepaint): (DRTDevToolsAgent::runtimeFeatureStateChanged): (DRTDevToolsAgent::injectedScriptSource): (DRTDevToolsAgent::injectedScriptDispatcherSource): (DRTDevToolsAgent::debuggerScriptSource): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::call): (DRTDevToolsAgent::webDevToolsAgent): (DRTDevToolsAgent::attach): (DRTDevToolsAgent::detach): (DRTDevToolsAgent::setTimelineProfilingEnabled): (DRTDevToolsAgent::evaluateInWebInspector): (DRTDevToolsAgent::dispatchMessageLoop):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h: Added. (DRTDevToolsAgent::~DRTDevToolsAgent): (DRTDevToolsAgent::hostIdentifier):
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h: (DRTDevToolsCallArgs::DRTDevToolsCallArgs): (DRTDevToolsCallArgs::~DRTDevToolsCallArgs): (DRTDevToolsCallArgs::callsCount):
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added. (DRTDevToolsClient::DRTDevToolsClient): (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::sendMessageToAgent): (DRTDevToolsClient::sendDebuggerCommandToAgent): (DRTDevToolsClient::activateWindow): (DRTDevToolsClient::closeWindow): (DRTDevToolsClient::dockWindow): (DRTDevToolsClient::undockWindow): (DRTDevToolsClient::asyncCall): (DRTDevToolsClient::call): (DRTDevToolsClient::allMessagesProcessed):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::closeWebInspector): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::~TestShell): (TestShell::createDRTDevToolsClient): (TestShell::showDevTools): (TestShell::closeDevTools): (TestShell::runFileTest): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::drtDevToolsAgent): (TestShell::drtDevToolsClient):
  • DumpRenderTree/chromium/config.h:
4:34 AM Changeset in webkit [62544] by commit-queue@webkit.org
  • 7 edits in trunk/JavaScriptCore

2010-07-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62511.
​http://trac.webkit.org/changeset/62511
​https://bugs.webkit.org/show_bug.cgi?id=41686

Breaks Linux/64bit compilation (Requested by xan_ on #webkit).

  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): (JSC::FixedVMPoolAllocator::free): (JSC::ExecutablePool::systemAlloc):
  • jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutableAllocator::reprotectRegion): (JSC::ExecutableAllocator::cacheFlush):
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • wtf/Platform.h:
4:12 AM Changeset in webkit [62543] by Csaba Osztrogonác
  • 5 edits
    6 adds in trunk/LayoutTests

Unreviewed.

[Qt] png/checksums for tests need to be updated after r62444
​https://bugs.webkit.org/show_bug.cgi?id=41568

  • platform/qt/fast/dynamic/anchor-lock-expected.checksum: Added.
  • platform/qt/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.checksum: Added.
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Updated.
  • platform/qt/fast/repaint/fixed-tranformed-expected.png: Updated.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Updated.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png: Updated.
  • platform/qt/transforms/2d/transform-fixed-container-expected.checksum: Added.
  • platform/qt/transforms/2d/transform-fixed-container-expected.png: Added.
3:33 AM Changeset in webkit [62542] by loislo@chromium.org
  • 16 edits in trunk

2010-07-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: On the way to Remote Debuging we want to support JSON
serialization on both sides of WebInspector transport. As far as
InspectorFrontend class is a simple proxy to WebInspector it would
be better to generate it from an IDL file. We have generator
infostructure for binding and will reuse it for new generator.
​https://bugs.webkit.org/show_bug.cgi?id=40675

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStack.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createGCEventData): (WebCore::TimelineRecordFactory::createFunctionCallData): (WebCore::TimelineRecordFactory::createEventDispatchData): (WebCore::TimelineRecordFactory::createGenericTimerData): (WebCore::TimelineRecordFactory::createTimerInstallData): (WebCore::TimelineRecordFactory::createXHRReadyStateChangeData): (WebCore::TimelineRecordFactory::createXHRLoadData): (WebCore::TimelineRecordFactory::createEvaluateScriptData): (WebCore::TimelineRecordFactory::createMarkTimelineData): (WebCore::TimelineRecordFactory::createScheduleResourceRequestData): (WebCore::TimelineRecordFactory::createResourceSendRequestData): (WebCore::TimelineRecordFactory::createResourceReceiveResponseData): (WebCore::TimelineRecordFactory::createResourceFinishData): (WebCore::TimelineRecordFactory::createReceiveResourceData): (WebCore::TimelineRecordFactory::createPaintData): (WebCore::TimelineRecordFactory::createParseHTMLData):
  • inspector/TimelineRecordFactory.h:
2:43 AM Changeset in webkit [62541] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-06 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Don't pass image hash to DRT when pixel tests are disabled.
​https://bugs.webkit.org/show_bug.cgi?id=41597

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2:20 AM Changeset in webkit [62540] by abarth@webkit.org
  • 5 edits in trunk

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InColgroupMode
​https://bugs.webkit.org/show_bug.cgi?id=41663

  • html5lib/runner-expected-html5.txt:

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InColgroupMode
​https://bugs.webkit.org/show_bug.cgi?id=41663

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
  • html/HTMLTreeBuilder.h:
1:54 AM Changeset in webkit [62539] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-06 Eric Seidel <​eric@webkit.org>

Unreviewed. Update test expectations for the LegacyTreeBuilder codepath.

Implement bookmarking for HTML5 Adoption Agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41659

  • html5lib/runner-expected.txt:
1:27 AM Changeset in webkit [62538] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-06 Yuzo Fujishima <​yuzo@google.com>

Unreviewed test expectation update.

unicode-range doesn't seem to be implemented for Qt.

  • platform/qt/Skipped:
1:16 AM Changeset in webkit [62537] by eric@webkit.org
  • 7 edits in trunk

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement bookmarking for HTML5 Adoption Agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41659

Added 3 new adoption tests because the suite didn't
cover all the bookmarking cases.

  • html5lib/runner-expected-html5.txt:
    • Fixes tests!
  • html5lib/resources/adoption01.dat

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement bookmarking for HTML5 Adoption Agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41659

Was easier than I expected it to be.
Fixes a bunch of html5lib/runner.html tests.

  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::bookmarkFor): (WebCore::HTMLFormattingElementList::insertAt):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::Bookmark::Bookmark): (WebCore::HTMLFormattingElementList::Bookmark::moveToAfter): (WebCore::HTMLFormattingElementList::Bookmark::elementBefore): (WebCore::HTMLFormattingElementList::Bookmark::elementAfter):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
1:06 AM Changeset in webkit [62536] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement more of InTableMode
​https://bugs.webkit.org/show_bug.cgi?id=41652

By the time we got around to landing this patch, it turns out to be
just a bit of cleanup (the functional changes where landed already.)

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
12:54 AM Changeset in webkit [62535] by commit-queue@webkit.org
  • 11 edits in trunk/WebCore

2010-07-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62529.
​http://trac.webkit.org/changeset/62529
​https://bugs.webkit.org/show_bug.cgi?id=41661

http/tests/inspector/resource-har-conversion.html is broken
(Requested by yutak on #webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): (WebCore::InspectorController::removeResource):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::create):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-scripts, .resources-category-xhr, .resources-category-fonts, .resources-category-other):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
12:53 AM Changeset in webkit [62534] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2010-07-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing layout test result.

  • svg/css/svg-ellipse-render-crash-expected.txt: Added.
12:39 AM Changeset in webkit [62533] by abarth@webkit.org
  • 5 edits in trunk

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InCaptionMode
​https://bugs.webkit.org/show_bug.cgi?id=41660

Implementing this mode also turned up a subtle bug in the adoption
agency code.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement):
    • We're supposed to reutrn the first *unopened* formatting element. The old code returned the first *opened* formatting element.
  • html/HTMLTreeBuilder.h:

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InCaptionMode
​https://bugs.webkit.org/show_bug.cgi?id=41660

Massive test progression due to fixing Mr. Adoption Agency.

  • html5lib/runner-expected-html5.txt:
12:35 AM Changeset in webkit [62532] by abarth@webkit.org
  • 5 edits in trunk

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement defaut cases for InTableMode
​https://bugs.webkit.org/show_bug.cgi?id=41656

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:

2010-07-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement defaut cases for InTableMode
​https://bugs.webkit.org/show_bug.cgi?id=41656

  • html5lib/runner-expected-html5.txt:
12:28 AM Changeset in webkit [62531] by Nikolas Zimmermann
  • 12 edits in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderContainer forces too many kids to relayout
​https://bugs.webkit.org/show_bug.cgi?id=15391

Fixing a long-standing performance issue. We should only ever need to relayout container children when the parent bounds change.
The bounds of a container can only change, if the outermost RenderSVGRoot container uses relative length values and its size changes.
This can either happen when the window resizes for standalone SVG documents, or if an enclosing RenderBox changes width/height values.

Only relayout container children if the container has selfNeedsLayout() true, or if the parent bounds change.
Lively Kernel doesn't do any relayouts anymore, except if you change the Safari window size, this is a great progression.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): No need to special case Path updates, if the element uses relative lengths. SVGRenderSupport now handles this case.
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): Fix some style issues.
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::setDrawsContents): Inlined for speed. (WebCore::RenderSVGContainer::drawsContents): Ditto.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): Initialize m_isLayoutSizeChanged to false. (WebCore::RenderSVGRoot::layout): Set m_isLayoutSizeChanged=true when the RenderSVGRoot size changes during layout. (WebCore::RenderSVGRoot::calcViewport): Remove hasRelativeLengths() special case.
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::isLayoutSizeChanged): New function, which returns true during layout() if the outermost <svg> size changes.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Cleanup code, and remove obsolete hasRelativeLengths() special case.
  • rendering/SVGRenderSupport.cpp: (WebCore::svgRootTreeObject): Added helper function, that returns the RenderSVGRoot for a given RenderObject. (WebCore::SVGRenderSupport::layoutChildren): Remove FIXME, only relayout container children, if the parent bounds change and the child uses relative lengths.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Implemented this function. Keeps track of relative lengths elements, so that the

hasRelativeLengths() information is always up2date.

  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): Don't call the virtual selfHasRelativeLengths() information, just return wheter m_elementsWithRelativeLengths is not empty.
12:09 AM Changeset in webkit [62530] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-07-05 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 41509 - Ranges for @font-face unicode-range must be separated by commas
​https://bugs.webkit.org/show_bug.cgi?id=41509

  • fast/css/beforeSelectorOnCodeElement.html: Fixed the space-separated ranges.
  • fast/css/font-face-multiple-ranges-for-unicode-range-expected.txt: Added.
  • fast/css/font-face-multiple-ranges-for-unicode-range.html: Added.
  • fast/css/text-security.html: Fixed the space-separated ranges.
  • fast/events/updateLayoutForHitTest.html: Fixed the space-separated ranges.
  • fast/text/capitalize-boundaries.html: Fixed the space-separated ranges.
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css: (@font-face): Fixed the space-separated ranges.

2010-07-05 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 41509 - Ranges for @font-face unicode-range must be separated by commas
​https://bugs.webkit.org/show_bug.cgi?id=41509

Test: fast/css/font-face-multiple-ranges-for-unicode-range.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):

Jul 5, 2010:

11:48 PM Changeset in webkit [62529] by hamaji@chromium.org
  • 11 edits in trunk/WebCore

2010-07-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
11:43 PM Changeset in webkit [62528] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium build.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
11:29 PM Changeset in webkit [62527] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Move processStartTagForInBody to its own function.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.cpp.orig: Added.
  • html/HTMLTreeBuilder.h:
11:29 PM Changeset in webkit [62526] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-07-05 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
​https://bugs.webkit.org/show_bug.cgi?id=41612

  • Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
11:14 PM Changeset in webkit [62525] by eric@webkit.org
  • 4 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
​https://bugs.webkit.org/show_bug.cgi?id=41654

  • html5lib/runner-expected-html5.txt:
    • Fix two sub-tests!

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
​https://bugs.webkit.org/show_bug.cgi?id=41654

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:05 PM Changeset in webkit [62524] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Eric Seidel <​eric@webkit.org>

Unreviewed. Just fixing proess to process.
Clearly Adam and I can't spell. Thankfully MikeSmith can.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakeStartTag): (WebCore::HTMLTreeBuilder::processFakeEndTag): (WebCore::HTMLTreeBuilder::processIsindexStartTagForBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
11:01 PM Changeset in webkit [62523] by eric@webkit.org
  • 9 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

  • html5lib/resources/tests2.dat:
    • Make the expected wording match the HTML5 spec. Not sure why the wording in this test diverged.
  • html5lib/resources/isindex.dat:
    • Cover more isindex cases.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
​https://bugs.webkit.org/show_bug.cgi?id=41650

Covered by html5lib/runner.html including a new
isindex.dat test suite.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
    • Support passing attributes to the constructor.

(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::takeAtributes):

  • Reduces ref-churn, and makes it possible for callers to modify attributes w/o affecting future uses of the attributes.

(WebCore::AtomicHTMLToken::usesName):

  • Used by ASSERTS.

(WebCore::AtomicHTMLToken::usesAttributes):

  • Used by ASSERTS.
  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle):
    • Can't be const, now that we use takeAttributes()

(WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML):
(WebCore::HTMLTreeBuilder::proesssFakeStartTag):

  • New function. I'm not sure this is the perfect design (I'd kinda like AtomicHTMLToken to be copyable so we can have create functions for it), but this makes the callsites using fake tokens much more readable.

(WebCore::HTMLTreeBuilder::proesssFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakeCharacters):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::insertScriptElement):

  • Use takeAttributes() for less ref-churn.

(WebCore::HTMLTreeBuilder::createElement): ditto
(WebCore::HTMLTreeBuilder::finished):

  • Remove bogus use of AtomicHTMLToken constructor which wasn't even being used now that we support emitting EOF tokens from the Tokenizer directly.
  • html/HTMLTreeBuilder.h:
10:38 PM Changeset in webkit [62522] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ASSERT that we're processing the correct type of token
​https://bugs.webkit.org/show_bug.cgi?id=41647

Making these asserts work required a small (non-observable) tweak to
some old code.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
10:31 PM Changeset in webkit [62521] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
​https://bugs.webkit.org/show_bug.cgi?id=41646

Add some tests for this mode. We fail all these tests currently
because there's no way to get into this mode. :(

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
​https://bugs.webkit.org/show_bug.cgi?id=41646

This mode is mostly a fall-through to the InSelectMode.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
10:14 PM Changeset in webkit [62520] by abarth@webkit.org
  • 9 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
​https://bugs.webkit.org/show_bug.cgi?id=41623

  • html5lib/resources/webkit01.dat:
    • This test had incorrect expected results according to the spec and to Minefield.
  • html5lib/runner-expected-html5.txt:
    • Update expected results to show test progression. In some cases, we continue to fail tests, but in new (also wrong) ways. I think that's ok though.
  • html5lib/runner-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.
  • html5lib/webkit-resumer-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
​https://bugs.webkit.org/show_bug.cgi?id=41623

This patch isn't the end-all, be-all of text node coalescing, but it's
a good start.

  • dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
  • dom/CharacterData.h:
    • Added a new method to dance around mutation events.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertTextNode):
9:58 PM Changeset in webkit [62519] by abarth@webkit.org
  • 4 edits in trunk

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
​https://bugs.webkit.org/show_bug.cgi?id=41627

Massive test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
​https://bugs.webkit.org/show_bug.cgi?id=41627

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
9:57 PM Changeset in webkit [62518] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We should be able to specify a bug to block for webkit-patch upload
​https://bugs.webkit.org/show_bug.cgi?id=41648

This will be useful for working on the HTML5 parser.

  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/options.py:
9:21 PM Changeset in webkit [62517] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-05 Yuzo Fujishima <​yuzo@google.com>

Unreviewed test expectation update.

Fix: On Leopard run-webkit-tests complains: Skipped list contained
'compositing/iframes/composited-iframe.html', but no file of that name
could be found

  • platform/mac-leopard/Skipped: Removed the above test.
8:34 PM Changeset in webkit [62516] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-07-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

We were discussing this test case, so I figured I might as well add it
to the suite.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
8:11 PM Changeset in webkit [62515] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-07-05 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement downloadURL in ContextMenuClientEfl
When user selects a download menu from context menu, send the download
request to application.
​https://bugs.webkit.org/show_bug.cgi?id=41149

  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::downloadURL): Get url for downloading file and Send it to application.
  • efl/WebCoreSupport/ContextMenuClientEfl.h:
7:03 PM Changeset in webkit [62514] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-07-05 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=40857

  • platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Added.
  • svg/css/svg-ellipse-render-crash.html: Added.

2010-07-05 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=40857

Test: svg/css/svg-ellipse-render-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged):
6:06 PM Changeset in webkit [62513] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Reproducible crash with Optimize Legibility extension
​https://bugs.webkit.org/show_bug.cgi?id=41585

Reviewed by Sam Weinig.

WebCore:

Test: fast/css/text-rendering-priority.html

Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.

  • css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests:

  • fast/css/text-rendering-priority-expected.txt: Added.
  • fast/css/text-rendering-priority.html: Added.
5:53 PM Changeset in webkit [62512] by alice.liu@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
​https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

  • platform/win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
  • platform/win/fast/text/uniscribe-item-boundary-crash.html: Added.
5:51 PM Applications using WebKit edited by onny_silvester@yahoo.com
(diff)
5:22 PM Changeset in webkit [62511] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=41641

Reviewed by Sam Weinig.

Update compile flags to allow use of ExecutableAllocatorFixedVMPool on platforms
other than x86-64 (this may be useful on 32-bit platforms, too).

Simplify ifdefs by dividing into thwo broad allocation strategies
(ENABLE_EXECUTABLE_ALLOCATOR_FIXED & ENABLE_EXECUTABLE_ALLOCATOR_DEMAND).

Rename constant used in the code to have names descriptive of their purpose,
rather than their specific value on a given platform.

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::free):
(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • wtf/Platform.h:
5:11 PM Changeset in webkit [62510] by mitz@apple.com
  • 2 edits in trunk/WebCore

optimizeLegibility doesn't play nice with fonts that do not have a space glyph
​https://bugs.webkit.org/show_bug.cgi?id=41599

Reviewed by Sam Weinig.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.

2:39 PM Changeset in webkit [62509] by abarth@webkit.org
  • 5 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
​https://bugs.webkit.org/show_bug.cgi?id=41628

This has some minimal testing. One from my previous
</table> patch, and a few from the main suite.

Mostly resetInsertionModeAppropriately isn't used yet
but we're about to add a bunch of states which do use it
and our test coverage will expand further as we do.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
​https://bugs.webkit.org/show_bug.cgi?id=41628

Fixes a bunch of subtests!

  • html5lib/runner-expected-html5.txt:
2:34 PM Changeset in webkit [62508] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Chromium missing method. Filed bug 41632 to track.

  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCache):
2:25 PM Changeset in webkit [62507] by abarth@webkit.org
  • 7 edits in trunk

2010-07-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41591

resetInsertionModeAppropriately isn't implemented yet, however
I've added a test for the usage I added.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41591

Add tests for </table> in "in table" mode, and
one for ignored close tags.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
2:08 PM Changeset in webkit [62506] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Missed GTK's build file.

  • GNUmakefile.am:
2:00 PM Changeset in webkit [62505] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Pass a blank ResourceResponse instead of passing 0.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
1:47 PM Changeset in webkit [62504] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Forward declare ApplicationCache for Chromium.

  • loader/appcache/ApplicationCacheHost.h:
1:32 PM Changeset in webkit [62503] by Joseph Pecoraro
  • 16 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
​https://bugs.webkit.org/show_bug.cgi?id=24529

Parts of this patch were written by Kavita Kanetkar <​kkanetkar@chromium.org>.

Part 2: Pulling ApplicationCache Resources to Display in the Inspector.

The InspectorApplicationCacheAgent gathers the information it
needs and forwards it on to the inspector.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): get information about the resources. (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): gathers all the information from the ApplicationCacheHost. (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h: defines structures to hold information about caches and resources. (WebCore::InspectorApplicationCacheAgent::ApplicationCacheInfo::ApplicationCacheInfo): (WebCore::InspectorApplicationCacheAgent::ResourceInfo::ResourceInfo): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCacheForInspector): new convention, public cache accessor for the inspector. (WebCore::ApplicationCacheHost::documentLoader): added const.

The User Interface uses a DataGrid, like Cookies.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.numberCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.localeCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

The usual frontend pull workflow, except this goes through
InspectorApplicationCacheAgent instead of InspectorController.

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getApplicationCaches): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetApplicationCaches):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.hasChildNodes): style fix. (WebInspector.DOMAgent.prototype.nodeForId): style fix. (WebInspector.ApplicationCache.getApplicationCachesAsync): pull. (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.updateManifest): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addAppCacheDomain): (WebInspector.reset):

Miscellaneous. Localized Strings and fixes.

  • English.lproj/localizedStrings.js: "Type", "%s (%s)"
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/InspectorController.h:
1:32 PM Changeset in webkit [62502] by Joseph Pecoraro
  • 19 edits
    4 adds in trunk/WebCore

2010-07-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
​https://bugs.webkit.org/show_bug.cgi?id=24529

Part 1: Backend -> Frontend Messages. ApplicationCache Status and Connectivity Status.

This patch adds an InspectorApplicationCacheAgent to monitor application
cache changes, starts a UI in the Storage panel, handles the boilerplate
of adding new files.

Added an agent to encapsulate and handle the application cache logic.
This is similar to the timeline agent.

  • inspector/InspectorApplicationCacheAgent.cpp: Added. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse): (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus): (WebCore::InspectorApplicationCacheAgent::updateNetworkState):
  • inspector/InspectorApplicationCacheAgent.h: Added.

InspectorController owns an InspectorApplicationCacheAgent. This
handles its lifetime management.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): create the agent with a frontend. (WebCore::InspectorController::disconnectFrontend): remove the agent when closing. (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h:

User Interface for ApplicationCache in the StoragePanel. This follows
very closely to Cookies, it will have a sortable table of items. The
status bar contains connectivity and application cache status
indicators which update when backend messages are received. There
are some stubs which the next part will implement.

  • inspector/front-end/ApplicationCacheItemsView.js: Added. (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): refresh, delete, connectivity, application cache status. (WebInspector.ApplicationCacheItemsView.prototype.show): (WebInspector.ApplicationCacheItemsView.prototype.hide): (WebInspector.ApplicationCacheItemsView.prototype.updateStatus): this is the application cache status indicator. (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState): this is the online/offline connectivity indicator. (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid): (WebInspector.ApplicationCacheItemsView.prototype.resize): (WebInspector.ApplicationCacheItemsView.prototype._deleteButtonClicked): (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback): (WebInspector.ApplicationCacheItemsView.prototype._refreshButtonClicked):

The usual dispatch flow from the backend, to the frontend, to the
panel, and then to the visible view. Some slight refactoring to
eliminate duplicated code.

  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::didGetApplicationCaches): (WebCore::InspectorFrontend::updateApplicationCacheStatus):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.StoragePanel.prototype.showDOMStorage): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.StoragePanel.prototype.showApplicationCache): (WebInspector.StoragePanel.prototype._genericViewSetup): (WebInspector.StoragePanel.prototype.updateApplicationCacheStatus): (WebInspector.StoragePanel.prototype.updateNetworkState): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle): (WebInspector.ApplicationCacheSidebarTreeElement): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get subtitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch): (WebInspector._addAppCacheDomain): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):

Notify the InspectorApplicationCacheAgent on application cache changes
or specifics. Notify the InspectorController on generic resource events.
That is because ApplicationCacheController is a ResourceClient and needs
to trigger the resource events normally handled by ResourceLoader.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::inspectorUpdateApplicationCacheStatus): helper method to prevent duplicated code. (WebCore::ApplicationCacheGroup::setNewestCache): status change. (WebCore::ApplicationCacheGroup::makeObsolete): status change. (WebCore::ApplicationCacheGroup::update): status change. (WebCore::ApplicationCacheGroup::createResourceHandle): resource event. (WebCore::ApplicationCacheGroup::willSendRequest): resource event. (WebCore::ApplicationCacheGroup::didReceiveResponse): resource event. (WebCore::ApplicationCacheGroup::didReceiveData): resource event. (WebCore::ApplicationCacheGroup::didFinishLoading): resource event. (WebCore::ApplicationCacheGroup::didFail): resource event. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): resource event. (WebCore::ApplicationCacheGroup::manifestNotFound): status change. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): status change. (WebCore::ApplicationCacheGroup::setUpdateStatus): single access point for status changes.
  • loader/appcache/ApplicationCacheGroup.h:
  • page/Page.cpp: (WebCore::networkStateChanged): connectivity status change.

Final inspector details to add the new file, style new elements,
images, and localized strings.

  • inspector/front-end/inspector.css: (.application-cache-sidebar-tree-item .icon): (.timeline-records-counter, .storage-application-cache-status, .storage-application-cache-connectivity): (.storage-application-cache-status-icon, .storage-application-cache-connectivity-icon): (.status-bar-divider): (.storage-application-cache-status, .storage-application-cache-connectivity):
  • inspector/front-end/inspector.html:
  • inspector/front-end/Images/applicationCache.png: Added.
  • English.lproj/localizedStrings.js: "APPLICATION CACHE", "No Application Cache information available.", "Online", "Offline"

Updated build files.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/WebKit.qrc:
1:17 PM Changeset in webkit [62501] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-07-05 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit2 triple click
​https://bugs.webkit.org/show_bug.cgi?id=41629

QtWebkit2 triple click implementation.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseDoubleClickEvent): (QWKPage::timerEvent):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
1:03 PM Changeset in webkit [62500] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

Test the new <col> support. Turns out the old treebuilder doesn't
handle <table><col> correctly.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
1:02 PM Changeset in webkit [62499] by abarth@webkit.org
  • 8 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> and <th> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41588

Also fixed <td> or <th> as a direct child of <table>.

Most of this was covered by html5lib/runner.html tests,
but I had to add a new tables01.dat to cover the <th> cases.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> insertion
​https://bugs.webkit.org/show_bug.cgi?id=41588

Added tables01.dat to test a previously untested
<table><th> case. I expect we'll add many more table
tests there as we complete our implementation.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • html5lib/resources/tables01.dat: Added.
12:42 PM Changeset in webkit [62498] by eric@webkit.org
  • 7 edits
    1 add in trunk

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
​https://bugs.webkit.org/show_bug.cgi?id=41582

  • html5lib/resources/inbody01.dat: Added.
  • html5lib/runner-expected-html5.txt:
    • Update the one result which was affected by this. That test would pass if we had text node coalescing.
  • html5lib/runner-expected.txt:
    • Update to add the extra test suite.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
​https://bugs.webkit.org/show_bug.cgi?id=41582

I believe I found a "bug" in the HTML5 spec when writing this:
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
11:32 AM Changeset in webkit [62497] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-07-05 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Add a missing slash to the list of generated sources. This
was missing from a previous build fix.

  • GNUmakefile.am:
11:04 AM Changeset in webkit [62496] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: preserve scroll positions in source frame when switching between panes.

​https://bugs.webkit.org/show_bug.cgi?id=41620

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
10:57 AM Changeset in webkit [62495] by yurys@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

2010-07-05 Yury Semikhatsky <​yury@yurys-imac.local>

Unreviewed. Provide Chromium specific expectations for new svg tests.

  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.txt: Added.
10:50 AM Changeset in webkit [62494] by commit-queue@webkit.org
  • 2 edits
    2 copies
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add stubs

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: Copied from WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Added. (WebKit::InjectedBundle::load):
10:10 AM Changeset in webkit [62493] by steveblock@google.com
  • 2 edits in trunk/JavaScriptCore

2010-07-05 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

ThreadingPthreads.cpp should use JNIUtility.h on Android, not outdated jni_utility.h
​https://bugs.webkit.org/show_bug.cgi?id=41594

  • wtf/ThreadingPthreads.cpp:
10:01 AM Changeset in webkit [62492] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-05 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

IE SVG test fails
​https://bugs.webkit.org/show_bug.cgi?id=41619

Make SVGSVGElement.createSVGTransform create a SVGTransform with the
right type, thereby fixing the IE test.

Test: svg/custom/svg-createsvgtransform-type.html

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform):
9:54 AM Changeset in webkit [62491] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add WebErrorsQt

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Added. (WebKit::): (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError):
8:29 AM Changeset in webkit [62490] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-07-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
​https://bugs.webkit.org/show_bug.cgi?id=41017

  • Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
  • Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
8:12 AM Changeset in webkit [62489] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: computed style pane is not updated when styles pane is collapsed.

​https://bugs.webkit.org/show_bug.cgi?id=41615

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
7:32 AM Changeset in webkit [62488] by Nikolas Zimmermann
  • 44 edits
    12 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=41566

Add logic to all SVG elements which create renderes to expose a method
"bool selfHasRelativeLengths()", that returns whether the element uses relative
lengths (eg. <rect x="50%"...). This will be used soon to avoid relayouts of
container children, when the bounds have not changed.

A new method SVGStyledElement::updateRelativeLengthsInformation() is added,
which is called from the various svgAttributeChanged() methods and insertedIntoDocument/removedFromDocument.
It will be implemented in a follow-up patch. This patch does not affect any test behaviour related
to relayouting. As SVGFilterElement finally got a proper svgAttributeChanged() method, it now
properly invalidates clients on attribute changes - covered by a new test.

Tests: svg/custom/relative-sized-inner-svg.xhtml

svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml
svg/filters/filter-width-update.svg


  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Rename hasRelativeValues to hasRelativeLengths.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Ditto. (WebCore::RenderSVGRoot::calcViewport): Ditto.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Ditto
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Call updateRelativeLengthsInformation() if any attribute which may contain relative lengths changes. (WebCore::SVGCircleElement::selfHasRelativeLengths): Ditto. Same for all other SVG*Elements below.
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::selfHasRelativeLengths):
  • svg/SVGEllipseElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::selfHasRelativeLengths):
  • svg/SVGFilterElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::selfHasRelativeLengths):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::selfHasRelativeLengths):
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::selfHasRelativeLengths):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::selfHasRelativeLengths):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::selfHasRelativeLengths):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::selfHasRelativeLengths):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::selfHasRelativeLengths):
  • svg/SVGPatternElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::selfHasRelativeLengths):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::selfHasRelativeLengths):
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::insertedIntoDocument): Call updateRelativeLengthsInformation(). (WebCore::SVGStyledElement::removedFromDocument): Ditto. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Not implemented so far. Will land in a follow-up patch, together with the render tree changes.
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): Devirtualized. For now, just call selfHasRelativeLengths() - this will change in a follow-up patch. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): (WebCore::SVGStyledElement::selfHasRelativeLengths): Renamed from hasRelativeValues().
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::selfHasRelativeLengths):
  • svg/SVGSymbolElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selfHasRelativeLengths):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::insertedIntoDocument): Call right base class' method. Skipped one in the hierachy before. (WebCore::SVGTextPathElement::selfHasRelativeLengths):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::listContainsRelativeValue): New helper funtion that checks wheter a SVGLengthList contains relative lengths. (WebCore::SVGTextPositioningElement::selfHasRelativeLengths):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): Call right base class' method. Skipped on in the hierachy before. (WebCore::SVGUseElement::removedFromDocument): Ditto. (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateRelativeLengthsInformation() after building the shadow tree. (WebCore::SVGUseElement::selfHasRelativeLengths): Same as all other methods, except that it includes the shadow tree root element.
  • svg/SVGUseElement.h:

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=41566

Add two new relative-sized-*.svg tests that would break, when relative sized kids aren't layout correctly.
Add new test covering that filters update their clients, if any attribute changes.

  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/mac/svg/filters/filter-width-update-expected.png: Added.
  • platform/mac/svg/filters/filter-width-update-expected.txt: Added.
  • svg/custom/relative-sized-inner-svg.xhtml: Added.
  • svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml: Added.
  • svg/filters/filter-width-update.svg: Added.
7:23 AM Changeset in webkit [62487] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Problem with copying a code from Scripts panel.

​https://bugs.webkit.org/show_bug.cgi?id=40432

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._selectionToPosition):
7:07 AM Changeset in webkit [62486] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add Qt C API integration.

  • UIProcess/API/cpp/qt/WKStringQt.cpp: Added. (WKStringCreateWithQString): (WKStringCopyQString):
  • UIProcess/API/cpp/qt/WKStringQt.h: Added.
  • UIProcess/API/cpp/qt/WKURLQt.cpp: Added. (WKURLCreateWithQUrl): (WKURLCopyQUrl):
  • UIProcess/API/cpp/qt/WKURLQt.h: Added.
6:41 AM Changeset in webkit [62485] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Add the Qt process launcher.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Added. (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::terminateProcess): (WebKit::webThreadBody): (WebKit::ProcessLauncher::createWebThread): (webProcessMain):
5:48 AM Changeset in webkit [62484] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze / Darin Adler.

Node.cloneNode does not work on SVG nodes
​https://bugs.webkit.org/show_bug.cgi?id=41421

Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.

Test: svg/custom/clone-element-with-animated-svg-properties.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
5:31 AM Changeset in webkit [62483] by antti.j.koivisto@nokia.com
  • 5 edits in trunk

Revert unplanned project file change.

.:

  • WebKit.pro:

WebCore:

  • WebCore.pri:
  • WebCore.pro:
5:27 AM Changeset in webkit [62482] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Darin Adler.

Memory corruption with SVG <use> element
​https://bugs.webkit.org/show_bug.cgi?id=40994

Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
datastructure with the points attribute, no matter if there are changes are not. This should be
furhter optimized, but this fix is sane and fixes the root of the evil races.

Test: svg/custom/use-property-synchronization-crash.svg

  • svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged):
5:26 AM Changeset in webkit [62481] by antti.j.koivisto@nokia.com
  • 5 edits
    4 adds in trunk

[Qt] Initial WebKit2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/qt: Added.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/qt: Added.
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

3:50 AM Changeset in webkit [62480] by morrita@google.com
  • 3 edits in trunk/WebKitTools

2010-07-04 MORITA Hajime <​morrita@google.com>

rebaseline-chromium-webkit-tests: UnicodeDecodeError
​https://bugs.webkit.org/show_bug.cgi?id=41589

  • run() method can result non-utf-8 bytes, that causes utf-8 decoding fail. Fixed to disable decoding.
  • Fixed Git.find_checkout_root() to make a test pass.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
3:05 AM Changeset in webkit [62479] by yurys@chromium.org
  • 4 edits in trunk

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
​https://bugs.webkit.org/show_bug.cgi?id=41595

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-07-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
​https://bugs.webkit.org/show_bug.cgi?id=41595

  • src/js/DebuggerScript.js:
3:03 AM Changeset in webkit [62478] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-04 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

SVG polygons should draw polygons up to the first parsing error
​https://bugs.webkit.org/show_bug.cgi?id=41140

Render polygons up until the first parsing error.

Test: svg/custom/poly-parsing-error.html

  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::parseMappedAttribute):
2:49 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:32 AM Changeset in webkit [62477] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
​https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

Test: platform/win/fast/text/uniscribe-item-boundary-crash.html

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.

12:18 AM Changeset in webkit [62476] by Philippe Normand
  • 4 edits in trunk/WebKit/mac

2010-06-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] on Mac OS use a runloop observer to process the glib context iterations
​https://bugs.webkit.org/show_bug.cgi?id=35747

If VIDEO and GSTREAMER are enabled, make the WebView start a
runloop observer that will trigger the glib main context
iterations. Those are needed by the GStreamer player only at the
moment but could later be used for other GLib-dependant components
if required.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _close]): (-[WebView _clearGlibLoopObserver]): (glibContextIterationCallback): (-[WebView _scheduleGlibContextIterations]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
Note: See TracTimeline for information about the timeline view.