Context Navigation

← Previous Period
Next Period →

Timeline

Jul 11, 2010:

11:29 PM Changeset in webkit [63062] by dbates@webkit.org

3 edits in trunk/WebKitTools

2010-07-11 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

Enable executable support for svn-apply and svn-unapply
https://bugs.webkit.org/show_bug.cgi?id=39409

Connect up the Git and SVN executable bit support in parseDiff() so that
executable bit changes are propagated via the returned diff hash to the
patch function in svn-apply and svn-unapply.

Scripts/VCSUtils.pm:
- Modified parseDiff() to call parseSvnDiffProperties when it finds the start of an SVN property change diff.
- Removed FIXME comment above parseSvnDiffProperties() since it is now being used by parseDiff().
- Export method scmToggleExecutableBit() now that we added the executableBitDelta hash key. (This should have been exported when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated results for: "rename (with executable bit change)"
  - Test value of executableBitDelta (now that we have support).
  "SVN: binary file (isBinary true)"
  - Remove the property change diff from svnConvertedText. We plan to remove svnConvertedText in the future. So, we decided against adding such support to any new code, such as the property parsing routines. Therefore, we do not keep SVN converted text for property change diffs.
- Added unit tests: "SVN: file change diff with property change diff" "SVN: file change diff, followed by property change diff on different file" "SVN: property diff, followed by file change diff" "SVN: copied file with property change" "SVN: two consecutive property diffs" "SVN: binary file with executable bit change" "SVN: binary file followed by property change on different file" "SVN: binary file followed by file change on different file" "SVN: file change diff with property change, followed by property change diff" "SVN: file change diff with property change, followed by file change diff"

8:41 PM Changeset in webkit [63061] by mjs@apple.com

7 edits in trunk/WebKitTools

2010-07-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Implement waitUntilDone and notifyDone for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42049

With this fix, most of the DOM tests pass.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didCreatePage): Track the main page. Not a great way to do it in the future case where we may get multiple pages - we really need a way to send it over from the ui process.
WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::page): A way to get the main page.
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we are loading. (WTR::InjectedBundlePage::dump): Factor into a method so this can be called by the layout test controller. Also, cancel any pending watchdogs. (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump to false. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate the watchdog. (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer. (WTR::LayoutTestController::setWaitToDump): Set the flag. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case where waitUntilDone times out. (WTR::LayoutTestController::notifyDone): Dump, if loading is done. (WTR::waitUntilDoneCallback): JS glue for waitUntilDone. (WTR::notifyDoneCallback): JS glue for notifyDone. (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone to the layoutController.
WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.

7:35 PM Changeset in webkit [63060] by commit-queue@webkit.org

2 edits in trunk/WebKit

2010-07-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Fix style errors in ewk_private.h.
https://bugs.webkit.org/show_bug.cgi?id=41742

efl/ewk/ewk_private.h:

5:09 PM Changeset in webkit [63059] by abarth@webkit.org

1 edit
1 add in trunk/WebCore

2010-07-11 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel

Add a complete list of the HTML5 entities in JSON format.

html/HTMLEntityNames.json: Added.

10:37 AM Changeset in webkit [63058] by Martin Robinson

8 edits in trunk

2010-07-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843

Add support for dropping content onto GTK+ WebViews.

No new tests, as the DRT does not support simulating drops yet.

platform/gtk/ClipboardUtilitiesGtk.cpp: (WebCore::dragOperationToGdkDragAction): Added. (WebCore::gdkDragActionToDragOperation): Properly detect DragOperationEvery.
platform/gtk/ClipboardUtilitiesGtk.h: Add declaration for dragOperationToGdkDragAction.
platform/gtk/PasteboardHelper.cpp: Add new target atom and rename the markup target type to match the others. Add a method which fills a data object from drop data. (WebCore::PasteboardHelper::initializeTargetList): Add support for new atoms. (WebCore::selectionDataToUTF8String): Added this helper. (WebCore::PasteboardHelper::getClipboardContents): Use the selectionDataToUTF8String helper. (WebCore::PasteboardHelper::targetListForDataObject): Change to reflect markup atom rename. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Added. (WebCore::PasteboardHelper::dropAtoms): Added.
platform/gtk/PasteboardHelper.h: Add declarations of new methods.

2010-07-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843

Add support for dropping content onto GTK+ WebViews.

webkit/webkitprivate.h: Add a DroppingContext struct to keep track of drop data while the drop is in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper. (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper. (webkit_web_view_dispose): Properly clean up droppingContexts member. (webkit_web_view_finalize): Delete droppingContext member. (globalPointForClientPoint): Added. (doDragLeaveLater): Added. (webkit_web_view_drag_leave): Added. (webkit_web_view_drag_motion): Added. (webkit_web_view_drag_data_received): Added. (webkit_web_view_drag_drop): Added. (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition. (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.

4:46 AM MathML 3 testsuite results edited by François Sausset

(diff)

4:13 AM MathML 3 testsuite results edited by François Sausset

(diff)

Jul 10, 2010:

11:54 PM Changeset in webkit [63057] by Darin Adler

27 edits
3 adds in trunk

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
https://bugs.webkit.org/show_bug.cgi?id=42040

Test: fast/dom/URL-attribute-reflection.html

Changed syntax from [ReflectURL] to [Reflect,URL] and also added support for
a new option, NonEmpty, which implements the non-empty URL concept from the
HTML5 specification.

bindings/scripts/CodeGenerator.pm: Changed code to expect the Reflect and URL extended attributes to come in separately. The URL one simply means "the string of this attribute is a URL", since we don't have a distinct type for URL. Also added a new NonEmpty extended attribute.

bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded code to handle ReflectURL.
bindings/scripts/CodeGeneratorV8.pm: Ditto.

bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated for new added test cases and the fix I made to the reflectedCustomURLAttr test.
bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
bindings/scripts/test/JS/JSTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
bindings/scripts/test/V8/V8TestObj.cpp: Ditto. Also, for some reason the V8 bindig writes out the keywords into the generated file as comments, so the keyword change had a direct efffect on the output file.

bindings/scripts/test/TestObj.idl: Changed the test cases for ReflectURL to use the new syntax. Added test cases for NonEmpty. Fixed the name of reflectedNonEmptyURLAttr, which accidentally was repeating reflectedURLAttr instead; never noticed because we never compile the test output.

dom/Element.cpp: (WebCore::Element::getNonEmptyURLAttribute): Added. For use by NonEmpty and also by any code that wants to implement the non-empty URL content attribute semantic.
dom/Element.h: Ditto.

html/HTMLAnchorElement.idl: Use Reflect,URL instead of ReflectURL.
html/HTMLAreaElement.idl: Ditto.
html/HTMLFrameElement.idl: Ditto.
html/HTMLImageElement.idl: Ditto.
html/HTMLInputElement.idl: Ditto.
html/HTMLLinkElement.idl: Ditto.
html/HTMLMediaElement.idl: Ditto.
html/HTMLObjectElement.idl: Ditto.
html/HTMLScriptElement.idl: Ditto.
html/HTMLVideoElement.idl: Ditto.

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
https://bugs.webkit.org/show_bug.cgi?id=42040

The current test results show many failures, and we should follow up with fixes
either to the DOM implementation, or to the test result expectations.

fast/dom/URL-attribute-reflection-expected.txt: Added.
fast/dom/URL-attribute-reflection.html: Added.
fast/dom/script-tests/URL-attribute-reflection.js: Added.

6:14 PM Changeset in webkit [63056] by oliver@apple.com

6 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

HAVE_COMPUTED_GOTO is dependent on the interpreter being enabled
https://bugs.webkit.org/show_bug.cgi?id=42039

Separate the existence of computed goto support in the compiler
from whether or not we are using the interpreter. All the current
HAVE(COMPUTED_GOTO) guards are for the interpreter, but I'd like
the option of using it elsewhere. The interpreter now uses
ENABLE(COMPUTED_GOTO_INTERPRETER)

bytecode/Instruction.h: (JSC::Instruction::Instruction):
bytecode/Opcode.h:
interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::isOpcode): (JSC::Interpreter::privateExecute):
interpreter/Interpreter.h: (JSC::Interpreter::getOpcode): (JSC::Interpreter::getOpcodeID):
wtf/Platform.h:

5:11 PM Changeset in webkit [63055] by oliver@apple.com

3 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove switches from inner expression loops in the parser
https://bugs.webkit.org/show_bug.cgi?id=42035

Use bitmasks and flags on the token types to identify unary and
binary operators, rather than switching on the token type to
identify them.

parser/JSParser.cpp: (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator):
parser/JSParser.h: (JSC::):

4:11 PM Changeset in webkit [63054] by tonyg@chromium.org

2 edits in trunk/WebCore

2010-07-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Add missing derrived sources to xcode project
https://bugs.webkit.org/show_bug.cgi?id=42034

This allows --web-timing to work with build-webkit on OSX with JSC.
This should have been done in bug 41442.

No new tests because no new functionality.

WebCore.xcodeproj/project.pbxproj:

3:31 PM MathML 3 testsuite results edited by François Sausset

(diff)

3:28 PM Changeset in webkit [63053] by andersca@apple.com

6 edits in trunk

Don't initialize plug-ins until allowed by the page
https://bugs.webkit.org/show_bug.cgi?id=42033

Reviewed by Sam Weinig.

WebCore:

WebCore.exp.in:

Export Document::addMediaCanStartListener and Document::removeMediaCanStartListener.

WebKit2:

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::paint):
(WebKit::NetscapePlugin::geometryDidChange):
Assert that the plug-in is started.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_isWaitingUntilMediaCanStart.

(WebKit::PluginView::~PluginView):
If necessary, remove the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::initializePlugin):
If we're not allowed to initialize the plug-in, add the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::paint):
Check that the plug-in is initialized.

(WebKit::PluginView::viewGeometryDidChange):
Ditto.

(WebKit::PluginView::mediaCanStart):
Initialize the plug-in.

WebProcess/Plugins/PluginView.h:

2:47 PM Changeset in webkit [63052] by andersca@apple.com

9 edits in trunk/WebKit2

Have the plug-in view initialize the plug-in
https://bugs.webkit.org/show_bug.cgi?id=42030

Reviewed by Dan Bernstein.

WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::initialize):

WebProcess/Plugins/DummyPlugin.h:

Plugin::initialize now takes a struct.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):

WebProcess/Plugins/Netscape/NetscapePlugin.h:

Plugin::initialize now takes a struct.

WebProcess/Plugins/Plugin.h:

Add Parameters struct.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Add Parameters parameter.

(WebKit::PluginView::~PluginView):
Add m_plugin null check.

(WebKit::PluginView::initializePlugin):
Try to initialize the plug-in and zero out the plug-in if initialization fails.

(WebKit::PluginView::paint):
Add m_plugin null check.

(WebKit::PluginView::setParent):
Initialize the plug-in.

WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::create):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Don't initialize the plug-in here.

2:38 PM Changeset in webkit [63051] by weinig@apple.com

3 edits
3 adds in trunk

WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

Test: fast/dom/Node/isEqualNode.html

dom/Node.cpp:

(WebCore::Node::isEqualNode): Add DocumentType logic from the DOM3 spec.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

fast/dom/Node/isEqualNode-expected.txt: Added.
fast/dom/Node/isEqualNode.html: Added.
fast/dom/Node/script-tests/isEqualNode.js: Added.

2:18 PM Changeset in webkit [63050] by dbates@webkit.org

9 edits
1 add in trunk/WebCore

2010-07-10 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
https://bugs.webkit.org/show_bug.cgi?id=39339

Moved the enum ReasonForCallingCanExecuteScripts, which was
defined in both the JSC and V8 ScriptController.h file, into
a shared file called ScriptControllerBase.h.

No functionality was changed, so no new tests.

GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/ScriptControllerBase.h: Added. (WebCore::):
bindings/js/ScriptController.h: #include ScriptControllerBase.h
bindings/v8/ScriptController.h: Ditto.

1:18 PM MathML 3 testsuite results edited by François Sausset

(diff)

12:39 PM Changeset in webkit [63049] by andersca@apple.com

7 edits in trunk/WebKit2

Call Page::canStartMedia when the WKView is added to/removed from a window
https://bugs.webkit.org/show_bug.cgi?id=42029

Reviewed by Oliver Hunt.

Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):
Add SetIsInWindow.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):
Call setIsInWindow.

(-[WKView _updateVisibility]):
Call setIsInWindow.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize m_isInWindow.

(WebKit::WebPageProxy::setIsInWindow):
Send WebPageMessage::SetIsInWindow.

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):
Call Page::canStartMedia.

(WebKit::WebPage::didReceiveMessage):
Handle the SetIsInWindow message.

WebProcess/WebPage/WebPage.h:

10:57 AM Changeset in webkit [63048] by mitz@apple.com

6 edits
4 adds in trunk

<rdar://problem/8153214> Continuation outlines in layers do not paint correctly

Reviewed by Anders Carlsson.

WebCore:

Test: fast/inline/continuation-outlines-with-layers-2.html

Continuation outlines are normally painted by the containing block. However, when the
block and the inline are not enclosed by the same self-painting layer, the inline has to
paint its own outlines. This was handled correctly only for the case where the inline had
its own self-painting layer, but now when an ancestor inline had the self-painting layer.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint): Instead of testing for having a self-painting layer, test
whether any intermediate box between the inline and the containing block has a self-painting
layer.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Ditto.

rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingBoxModelObject): Added this utility method.

rendering/RenderObject.h:

LayoutTests:

fast/inline/continuation-outlines-with-layers-2.html: Added.
platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.

10:33 AM Changeset in webkit [63047] by andersca@apple.com

6 edits in trunk/WebKit2

Reuse initialized NetscapePluginModules, pass parameters to NPP_New
https://bugs.webkit.org/show_bug.cgi?id=42028

Reviewed by Dan Bernstein.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Let the plug-in module know that a plug-in has been created.

(WebKit::NetscapePlugin::~NetscapePlugin):
Let the plug-in module know that a plug-in has been destroyed.

(WebKit::NetscapePlugin::initialize):
Pass the MIME type and parameters to the plug-in.

WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::initializedNetscapePluginModules):
Add list of initialized plug-in modules.

(WebKit::NetscapePluginModule::NetscapePluginModule):
Initialize m_pluginCount to 0.

(WebKit::NetscapePluginModule::~NetscapePluginModule):
Assert that we're not in the list of initialized plug-ins.

(WebKit::NetscapePluginModule::pluginCreated):
Increment the plug-in count.

(WebKit::NetscapePluginModule::pluginDestroyed):
Decrement the plug-in count and call shutdown if it's 0.

(WebKit::NetscapePluginModule::shutdown):
Call NP_Shutdown and remove the plug-in from the list of initialized plug-ins.

(WebKit::NetscapePluginModule::getOrCreate):
Look for an already initialized plug-in module before creating one.

(WebKit::NetscapePluginModule::load):
Set m_isInitialized to true.

WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp:

(WebKit::NetscapePluginModule::unload):
Leak the CFBundleRef to avoid possible crashes.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Call getOrCreate instead of create.

9:02 AM Changeset in webkit [63046] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Build fix: syntax and typo issues
https://bugs.webkit.org/show_bug.cgi?id=41859

html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):

5:02 AM MathML 3 testsuite results edited by François Sausset

(diff)

2:01 AM Changeset in webkit [63045] by eric@webkit.org

5 edits in trunk

2010-07-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
https://bugs.webkit.org/show_bug.cgi?id=42022

html5lib/runner-expected-html5.txt:
- We now pass 3 more tests.

2010-07-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
https://bugs.webkit.org/show_bug.cgi?id=42022

To add adjust foreign attributes support I had to add an
AtomicString (prefixed name) to QualifiedName hash. Once I had
done that, I decided it would be best for the other "adjust" functions
to share the same hash logic, so I moved them to using the same
AtomicString -> QualifiedName hash as well.