Timeline
Jul 12, 2010:
- 11:53 PM Changeset in webkit [63180] by
-
- 2 edits in trunk/WebCore
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests
https://bugs.webkit.org/show_bug.cgi?id=42143
Covered by a zillion layout tests.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
- 11:41 PM Changeset in webkit [63179] by
-
- 10 edits in trunk
2010-07-12 Jay Civelli <jcivelli@chromium.org>
Reviewed by Kent Tamura.
Adding right aligned text called labels to PopupMenus.
https://bugs.webkit.org/show_bug.cgi?id=41964
- platform/PopupMenuClient.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemLabel):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemLabel):
- rendering/RenderTextControlSingleLine.h:
2010-07-12 Jay Civelli <jcivelli@chromium.org>
Reviewed by Kent Tamura.
Making the autofill popup use labels to show the label
associated with an item.
https://bugs.webkit.org/show_bug.cgi?id=41964
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::getLabel): (WebKit::AutoFillPopupMenuClient::itemLabel): (WebKit::AutoFillPopupMenuClient::setSuggestions): (WebKit::AutoFillPopupMenuClient::convertListIndexToInternalIndex):
- src/AutoFillPopupMenuClient.h:
- 11:32 PM Changeset in webkit [63178] by
-
- 4 edits in trunk
2010-07-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
https://bugs.webkit.org/show_bug.cgi?id=40922
Always build WebKit2 on Windows. Necessary since our WebKit build on
Windows is packaged into a DLL with WebKit2.
- Scripts/build-webkit: Always build WebKit2 on Windows.
2010-07-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
https://bugs.webkit.org/show_bug.cgi?id=40922
Add additional dependent projects. Necessary since our WebKit build on
Windows is packaged into a DLL with WebKit2.
- WebKit2.sln:
- 11:24 PM Changeset in webkit [63177] by
-
- 3 edits in trunk/WebKitTools
One http test timing out on Windows can cause all future tests to time out
https://bugs.webkit.org/show_bug.cgi?id=42146
Reviewed by Steve Falkenburg.
There have been multiple times on the Windows bots where one http test timing out causes all future
http tests to time out. This is because the httpd process becomes unresponsive. When an http test
times out, we should restart httpd on Cygwin to prevent this.
- Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
- Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
using kill fails.
- 11:21 PM Changeset in webkit [63176] by
-
- 4 edits6 adds in trunk
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Incorrect Test for Text Fill
https://bugs.webkit.org/show_bug.cgi?id=42123
Unskip tests which cover text stroking and add pixel dump results for
them via the GTK+ port.
- platform/gtk/Skipped: Unskip passing tests.
- platform/gtk/fast/text/stroking-decorations-expected.checksum: Added.
- platform/gtk/fast/text/stroking-decorations-expected.png: Added.
- platform/gtk/fast/text/stroking-decorations-expected.txt: Added.
- platform/gtk/fast/text/stroking-expected.checksum: Added.
- platform/gtk/fast/text/stroking-expected.png: Added.
- platform/gtk/fast/text/stroking-expected.txt: Added.
2010-07-12 Mihnea Ovidenea <mihnea@adobe.com>
Reviewed by Dirk Schulze.
[Cairo] Incorrect Test for Text Fill
https://bugs.webkit.org/show_bug.cgi?id=42123
Correct test used for text shadow. It currently checks for
equality with cTextFill. However, this test fails if the
text drawing mode is set to 'cTextFill | cTextStroke'. Fix
is to modify the test to be like other Cairo uses of the
text drawing mode, and check for the cTextFill bit being
set, not for equality with the bit.
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- 11:05 PM Changeset in webkit [63175] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Fix a small error in the Skipped list.
- platform/gtk/Skipped:
- 11:01 PM Changeset in webkit [63174] by
-
- 1 edit in trunk/WebKit2/Platform/win/WorkQueueWin.cpp
Windows build fix.
- 10:54 PM Changeset in webkit [63173] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63171.
http://trac.webkit.org/changeset/63171
https://bugs.webkit.org/show_bug.cgi?id=42144
Broke Chromium canary (Requested by tkent on #webkit).
- WebKit.gyp:
- 10:41 PM Changeset in webkit [63172] by
-
- 2 edits4 adds in trunk/LayoutTests
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaseline chromium tests.
- platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.checksum.
- platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.png.
- platform/chromium-win-xp/fast/gradients/radial-centered-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.txt.
- platform/chromium/test_expectations.txt:
- 10:37 PM Changeset in webkit [63171] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-12 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
[Chromium] Upstreaming inspector_resources target
https://bugs.webkit.org/show_bug.cgi?id=41669
'inspector_resource' is currently in src/webkit/webkit.gyp of
Chromium tree. We move it to WebKit tree because:
- DumpRenderTree in WebKit tree needs it, and
- It's hard to refer to WebKit.gypi and WebCore.gypi from webkit_support in both cases of Chromium-tree build and WebKit-tree build.
- WebKit.gyp:
- 10:30 PM Changeset in webkit [63170] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-12 Viet-Trung Luu <viettrungluu@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Pass key down events on to plugins.
https://bugs.webkit.org/show_bug.cgi?id=42113
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- 10:24 PM Changeset in webkit [63169] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add failing animation and canvas tests to WebKit2 Skipped list
https://bugs.webkit.org/show_bug.cgi?id=42141
- platform/mac-wk2/Skipped:
- 10:10 PM Changeset in webkit [63168] by
-
- 4 edits in trunk
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Fix a typo in the adoption agency causing test failures
https://bugs.webkit.org/show_bug.cgi?id=42133
- html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Fix a typo in the adoption agency causing test failures
https://bugs.webkit.org/show_bug.cgi?id=42133
The new behavior actually differs from old webkit.
<p><b><p>TEST
was not bold in the old parser, but is bold now.
This matches Minefield and the HTML5 spec.
Covered by two tests in html5lib/runner.html.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 9:27 PM Changeset in webkit [63167] by
-
- 2 edits in trunk/WebKit2
Fix WebKit2 to use the same compiler-selection logic as the other projects.
Rubber-stamped by Maciej Stachowiak.
- WebKit2.xcodeproj/project.pbxproj: Don't hard-code WebKit2 to build with GCC 4.2.
- 9:04 PM Changeset in webkit [63166] by
-
- 11 edits in trunk
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: provide starts and ends for network phases instead of duration.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::buildObjectForTiming):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::setWasCached):
- platform/network/ResourceResponseBase.h:
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: provide starts and ends for network phases instead of duration.
- public/WebURLLoadTiming.h:
- public/WebURLResponse.h:
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::proxyStart): (WebKit::WebURLLoadTiming::setProxyStart): (WebKit::WebURLLoadTiming::proxyEnd): (WebKit::WebURLLoadTiming::setProxyEnd): (WebKit::WebURLLoadTiming::dnsStart): (WebKit::WebURLLoadTiming::setDNSStart): (WebKit::WebURLLoadTiming::dnsEnd): (WebKit::WebURLLoadTiming::setDNSEnd): (WebKit::WebURLLoadTiming::connectStart): (WebKit::WebURLLoadTiming::setConnectStart): (WebKit::WebURLLoadTiming::connectEnd): (WebKit::WebURLLoadTiming::setConnectEnd): (WebKit::WebURLLoadTiming::sendStart): (WebKit::WebURLLoadTiming::setSendStart): (WebKit::WebURLLoadTiming::sendEnd): (WebKit::WebURLLoadTiming::setSendEnd): (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart): (WebKit::WebURLLoadTiming::receiveHeadersEnd): (WebKit::WebURLLoadTiming::setReceiveHeadersEnd): (WebKit::WebURLLoadTiming::sslStart): (WebKit::WebURLLoadTiming::setSSLStart): (WebKit::WebURLLoadTiming::sslEnd): (WebKit::WebURLLoadTiming::setSSLEnd):
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasCached): (WebKit::WebURLResponse::setWasCached):
- 8:41 PM Changeset in webkit [63165] by
-
- 5 edits in trunk
2010-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 Parser: document.write after onload blows away document
https://bugs.webkit.org/show_bug.cgi?id=40745
Update test to expect new behavior.
- http/tests/misc/write-while-waiting.html:
2010-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 Parser: document.write after onload blows away document
https://bugs.webkit.org/show_bug.cgi?id=40745
Rather than blowing away the document when we get a document.write call
after the document is closed, we new ignore the write. This
technically violates the spec (which requires us to blow away the
document), but blowing away the document breaks too many web sites.
Rather than this patch, we could go back to our old behavior (which was
to append the bytes just before EOF), but implementing this approach
(suggested by Henri) will let us gather data about whether his approach
is workable.
See also: http://www.w3.org/Bugs/Public/show_bug.cgi?id=9767
- dom/Document.cpp: (WebCore::Document::write):
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::insert):
- 8:39 PM Changeset in webkit [63164] by
-
- 3 edits in trunk/WebKitTools
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Remove use of auto_ptr in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42134
Replaced auto_ptr with PassOwnPtr / OwnPtr.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::WKStringToUTF8): (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::addMessageToConsole):
- WebKitTestRunner/TestInvocation.cpp: (WTR::WKStringToUTF8): (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
- 8:13 PM Changeset in webkit [63163] by
-
- 3 edits2 adds in trunk
Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
https://bugs.webkit.org/show_bug.cgi?id=42132
Reviewed by Sam Weinig.
WebKitTools:
- Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
platform directories.
LayoutTests:
- platform/mac-wk2: Added.
- platform/mac-wk2/Skipped: Added. Initially add the accessibility
directory (with two blocking bugs).
- 7:57 PM Changeset in webkit [63162] by
-
- 2 edits in trunk/WebCore
2010-07-12 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Oliver Hunt.
Strip BOMs from source before passing to V8
https://bugs.webkit.org/show_bug.cgi?id=42102
This extra copy may carry a performance penalty. We should investigate
whether this allows any simplification in v8/scanner.cc:SkipJavaScriptWhiteSpace().
No new tests because no new functionality.
- bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
- 7:45 PM Changeset in webkit [63161] by
-
- 2 edits in trunk/WebCore
2010-07-12 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed. make distcheck fix.
- GNUmakefile.am:
- 7:45 PM Changeset in webkit [63160] by
-
- 8 edits8 deletes in trunk/WebKit/chromium
2010-07-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63156.
http://trac.webkit.org/changeset/63156
https://bugs.webkit.org/show_bug.cgi?id=42129
broke chromium compile (Requested by jamesr on #webkit).
- WebKit.gyp:
- public/WebAccessibilityObject.h:
- public/WebAttribute.h: Removed.
- public/WebDocumentType.h: Removed.
- public/WebElement.h:
- public/WebNamedNodeMap.h: Removed.
- public/WebNode.h:
- public/WebRenderStyle.h: Removed.
- src/WebAccessibilityObject.cpp:
- src/WebAttribute.cpp: Removed.
- src/WebDocumentType.cpp: Removed.
- src/WebElement.cpp:
- src/WebNamedNodeMap.cpp: Removed.
- src/WebNode.cpp:
- src/WebRenderStyle.cpp: Removed.
- 7:42 PM Changeset in webkit [63159] by
-
- 4 edits3 adds in trunk
2010-07-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix crash caused by unintentional deletion of worker bridge and channel.
WebSocket: Crash caused by calling close() within onmessage handler
https://bugs.webkit.org/show_bug.cgi?id=41507
- websocket/tests/workers/close-in-onmessage-crash-expected.txt: Added.
- websocket/tests/workers/close-in-onmessage-crash.html: Added.
- websocket/tests/workers/resources/close-in-onmessage-crash.js: Added. (runTests.try.ws.onopen): (runTests.try.ws.onmessage): Calling close() inside the onmessage handler causes the crash. (runTests.try.ws.onclose): (runTests):
2010-07-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix crash caused by unintentional deletion of worker bridge and channel.
WebSocket: Crash caused by calling close() within onmessage handler
https://bugs.webkit.org/show_bug.cgi?id=41507
Test: websocket/tests/workers/close-in-onmessage-crash.html
- websockets/WebSocket.cpp: (WebCore::WebSocket::close): bufferedAmount() may call WebSocket::didClose(), which causes m_channel to get freed.
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::send): Add reference to the bridge because waitForMethodCompletion() may dereference the bridge. (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount): Ditto. (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion): The root cause is a call to WorkerRunLoop::runInMode in this function. It may call WebSocket::didClose() even inside WebSocket::close(), which frees everything including the worker bridge and the channel.
- 7:05 PM Changeset in webkit [63158] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Eric Seidel <eric@webkit.org>
Unreviewed. Just skipping a test on Gtk due to missing DRT features.
REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
https://bugs.webkit.org/show_bug.cgi?id=41797
- platform/gtk/Skipped:
- Gtk is missing DRT api.
- 6:58 PM Changeset in webkit [63157] by
-
- 2 edits in trunk/WebKit2
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
WKView should override setFrameSize: instead of setFrame:
https://bugs.webkit.org/show_bug.cgi?id=42127
- UIProcess/API/mac/WKView.mm: (-[WKView setFrameSize:]): Override this method instead of setFrame:, since that is the right way to do it.
- 6:45 PM Changeset in webkit [63156] by
-
- 8 edits8 copies in trunk/WebKit/chromium
2010-07-12 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Darin Fisher.
Add methods to WebAccessibilityObject to access the Node and
Document, and then add methods to access some document, node,
and element properties needed for Windows accessibility.
- WebKit.gyp:
- public/WebAccessibilityObject.h:
- public/WebAttribute.h: Added. (WebKit::WebAttribute::~WebAttribute): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::operator=):
- public/WebDocumentType.h: Added. (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::assign):
- public/WebElement.h:
- public/WebNamedNodeMap.h: Added. (WebKit::WebNamedNodeMap::~WebNamedNodeMap): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::operator=):
- public/WebNode.h:
- public/WebRenderStyle.h: Added. (WebKit::WebRenderStyle::~WebRenderStyle): (WebKit::WebRenderStyle::WebRenderStyle): (WebKit::WebRenderStyle::operator=):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::node): (WebKit::WebAccessibilityObject::document):
- src/WebAttribute.cpp: Added. (WebKit::WebAttribute::reset): (WebKit::WebAttribute::assign): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::localName): (WebKit::WebAttribute::value):
- src/WebDocumentType.cpp: Added. (WebKit::WebDocumentType::name): (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):
- src/WebElement.cpp: (WebKit::WebElement::attributes):
- src/WebNamedNodeMap.cpp: Added. (WebKit::WebNamedNodeMap::reset): (WebKit::WebNamedNodeMap::assign): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::length): (WebKit::WebNamedNodeMap::attributeItem):
- src/WebNode.cpp: (WebKit::WebNode::element): (WebKit::WebNode::hasComputedStyle): (WebKit::WebNode::computedStyle):
- src/WebRenderStyle.cpp: Added. (WebKit::WebRenderStyle::reset): (WebKit::WebRenderStyle::assign): (WebKit::WebRenderStyle::WebRenderStyle): (WebKit::WebRenderStyle::display):
- 6:36 PM Changeset in webkit [63155] by
-
- 6 edits in trunk/WebKitTools
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Make WebKitTestRunner resize the view specially for the W3C SVG tests.
https://bugs.webkit.org/show_bug.cgi?id=42126
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): Store the path as a C string for later use. (WTR::TestInvocation::~TestInvocation): (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper size, depending on whether this is a W3C SVG test. (WTR::TestInvocation::invoke): Call the size function.
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::resizeTo): Implement.
- WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::resizeTo): Placeholder.
- 6:28 PM Changeset in webkit [63154] by
-
- 3 edits2 adds in trunk
2010-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
https://bugs.webkit.org/show_bug.cgi?id=41797
This test is a bit subtle, but it captures a reduction of what I think
is going on with the site.
Essentially, the real parser doesn't see the <img> tag, but the preload
scanner does. Prior to this patch, we were preload scanning this
region of the document even though we weren't supposed to.
- http/tests/loading/preload-slow-loading-expected.txt: Added.
- http/tests/loading/preload-slow-loading.php: Added.
2010-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
https://bugs.webkit.org/show_bug.cgi?id=41797
Once we resume parsing after script execution, we want to clear the
preload scanner so we don't scan any bytes it might have accumulated.
Test: http/tests/loading/preload-slow-loading.php
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- 6:15 PM Changeset in webkit [63153] by
-
- 2 edits in trunk/WebCore
Reviewed by Jian Li.
Adding directional property enums back into
CSSComputedStyleDeclaration::getPropertyCSSValue().
https://bugs.webkit.org/show_bug.cgi?id=42122
The four directional -webkit- properties -- CSSPropertyWebkitMarginEnd,
CSSPropertyWebkitMarginStart, CSSPropertyWebkitPaddingEnd, and
CSSPropertyWebkitPaddingStart -- are resolved into other css
properties before the swtich statement via a call to
CSSProperty::resolveDirectionAwareProperty(). Thus, they are never
seen by the switch statement. However, if you leave out a potential
enum value from the switch, gcc will generate a warning if -Wall is
specified. This warning breaks the Chromium build. To avoid this,
we add in the enum values and ASSERT_NOT_REACHED() if they are hit.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 5:58 PM Changeset in webkit [63152] by
-
- 5 edits11 adds in branches/safari-533.17-branch
Merge r63149.
- 5:54 PM Changeset in webkit [63151] by
-
- 10 edits26 moves1 add5 deletes in trunk
WebKit/win: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
https://bugs.webkit.org/show_bug.cgi?id=40921
Reviewed by Alice Liu.
Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
This is a first step. We'll likely want to migrate the remainder of
the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
- WebKit.vcproj/WebKit.def: Removed.
- WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
- WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
Renamed project name to WebKitLib to avoid confusion and naming conflicts.
Generate intermediate pdb file for debuggability of static lib.
Removed DLL-related options.
- WebKit.vcproj/deleteButton.png: Removed.
- WebKit.vcproj/deleteButtonPressed.png: Removed.
- WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
- WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
- WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
- WebKit.vcproj/fsVideoPause.png: Removed.
- WebKit.vcproj/fsVideoPlay.png: Removed.
- WebKit.vcproj/missingImage.png: Removed.
- WebKit.vcproj/nullplugin.png: Removed.
- WebKit.vcproj/panEastCursor.png: Removed.
- WebKit.vcproj/panIcon.png: Removed.
- WebKit.vcproj/panNorthCursor.png: Removed.
- WebKit.vcproj/panNorthEastCursor.png: Removed.
- WebKit.vcproj/panNorthWestCursor.png: Removed.
- WebKit.vcproj/panSouthCursor.png: Removed.
- WebKit.vcproj/panSouthEastCursor.png: Removed.
- WebKit.vcproj/panSouthWestCursor.png: Removed.
- WebKit.vcproj/panWestCursor.png: Removed.
- WebKit.vcproj/searchCancel.png: Removed.
- WebKit.vcproj/searchCancelPressed.png: Removed.
- WebKit.vcproj/searchMagnifier.png: Removed.
- WebKit.vcproj/searchMagnifierResults.png: Removed.
- WebKit.vcproj/textAreaResizeCorner.png: Removed.
- WebKit.vcproj/verticalTextCursor.png: Removed.
- WebKit.vcproj/zoomInCursor.png: Removed.
- WebKit.vcproj/zoomOutCursor.png: Removed.
WebKit2: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
https://bugs.webkit.org/show_bug.cgi?id=40921
Reviewed by Alice Liu.
Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
This is a first step. We'll likely want to migrate the remainder of
the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
- UIProcess/API/C/WKBase.h: Updated to new BUILDING_ name.
- WebProcess/InjectedBundle/API/c/WKBundleBase.h: Updated to new BUILDING_ name.
- WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Removed.
- WebProcess/win/DllMain.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
- WebProcess/win/WebLocalizableStrings.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
- WebProcess/win/WebLocalizableStrings.h: Removed. Overlaps with implementation in WebKitLib.lib.
- win/WebKit2.def: Added. Copied from WebKit project.
- win/WebKit2.rc: Added resources previously in WebKit.
- win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll.
Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain).
- win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name.
Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll.
- win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming.
- win/deleteButton.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButton.png.
- win/deleteButtonPressed.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButtonPressed.png.
- win/fsVideoAudioVolumeHigh.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeHigh.png.
- win/fsVideoAudioVolumeLow.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeLow.png.
- win/fsVideoExitFullscreen.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoExitFullscreen.png.
- win/fsVideoPause.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPause.png.
- win/fsVideoPlay.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPlay.png.
- win/missingImage.png: Copied from ../WebKit/win/WebKit.vcproj/missingImage.png.
- win/nullplugin.png: Copied from ../WebKit/win/WebKit.vcproj/nullplugin.png.
- win/panEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panEastCursor.png.
- win/panIcon.png: Copied from ../WebKit/win/WebKit.vcproj/panIcon.png.
- win/panNorthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthCursor.png.
- win/panNorthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthEastCursor.png.
- win/panNorthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthWestCursor.png.
- win/panSouthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthCursor.png.
- win/panSouthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthEastCursor.png.
- win/panSouthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthWestCursor.png.
- win/panWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panWestCursor.png.
- win/searchCancel.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancel.png.
- win/searchCancelPressed.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancelPressed.png.
- win/searchMagnifier.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifier.png.
- win/searchMagnifierResults.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifierResults.png.
- win/textAreaResizeCorner.png: Copied from ../WebKit/win/WebKit.vcproj/textAreaResizeCorner.png.
- win/verticalTextCursor.png: Copied from ../WebKit/win/WebKit.vcproj/verticalTextCursor.png.
- win/zoomInCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomInCursor.png.
- win/zoomOutCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomOutCursor.png.
- 5:53 PM Changeset in webkit [63150] by
-
- 3 edits3 adds in branches/safari-533.17-branch
Merge r63112.
- 5:40 PM Changeset in webkit [63149] by
-
- 5 edits10 adds in trunk
2010-07-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Don't go into compositing mode for 0x0 plugins
https://bugs.webkit.org/show_bug.cgi?id=34009
Don't use compositing for small (0-height or width, or 1x1) plugins, or iframes whose
height or width is zero.
Previously we made all compositing decisions inside styleChanged(). However,
now that plugin and iframe compositing behavior depends on renderer size, we have
to wait until layout before deciding whether to composite these. This behavior
change is controlled by the m_compositingDependsOnGeometry flag. When set,
updateCompositingLayers() always does a hierarchy update.
Tests: compositing/iframes/iframe-size-from-zero.html
compositing/iframes/iframe-size-to-zero.html
compositing/plugins/1x1-composited-plugin.html
compositing/plugins/large-to-small-composited-plugin.html
compositing/plugins/small-to-large-composited-plugin.html
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): No longer bail if usesCompositing() is false; we have to always enter updateCompositingLayers(). (WebCore::FrameView::repaintFixedElementsAfterScrolling): Ditto (WebCore::FrameView::enterCompositingMode): Remove bogus return of a void.
- rendering/RenderLayerCompositor.h: Add m_compositingDependsOnGeometry.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Initialize m_compositingDependsOnGeometry to false. (WebCore::RenderLayerCompositor::updateCompositingLayers): If m_compositingDependsOnGeometry is true, we always need to run through the layer hierarchy looking for things which need to be composited, even if we're not (yet) in compositing mode.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Because we can enter compositing mode
on the fly inside updateCompositingLayers() now, the state of willBeComposited needs to be updated
when processing the root layer, for the case where the compositing mode changes.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Set the m_compositingDependsOnGeometry
flag if we see a potentially-composited plugin. Once we have layout information, only composite the plugin
if height * width > 1.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Set the m_compositingDependsOnGeometry
flag if we see a potentially-composited iframe. Once we have layout information, only composite the plugin
if height or width is greater than zero.
- 5:37 PM Changeset in webkit [63148] by
-
- 16 edits in trunk/WebKit2
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Get rid of auto_ptr use in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42119
Replace all use of auto_ptr with OwnPtr/PassOwnPtr.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::sendOutgoingMessages): (CoreIPC::Connection::dispatchMessages):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::Message): (CoreIPC::Connection::send): (CoreIPC::Connection::sendSync): (CoreIPC::Connection::waitFor):
- Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::sendOutgoingMessage): (CoreIPC::createArgumentDecoder): (CoreIPC::Connection::receiveSourceEventHandler):
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
- Platform/CoreIPC/win/ConnectionWin.cpp: (CoreIPC::Connection::readEventHandler): (CoreIPC::Connection::sendOutgoingMessage):
- Platform/RunLoop.cpp: (RunLoop::performWork): (RunLoop::scheduleWork):
- Platform/RunLoop.h:
- Platform/WorkItem.h: (WorkItem::create):
- Platform/WorkQueue.h:
- Platform/mac/WorkQueueMac.cpp: (WorkQueue::executeWorkItem): (WorkQueue::scheduleWork): (WorkQueue::EventSource::EventSource): (WorkQueue::registerMachPortEventHandler):
- Platform/qt/WorkQueueQt.cpp: (WorkQueue::connectSignal): (WorkQueue::scheduleWork):
- Platform/win/WorkQueueWin.cpp: (WorkQueue::registerHandle): (WorkQueue::scheduleWork): (WorkQueue::performWork):
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send):
- 5:37 PM Changeset in webkit [63147] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, build fix.
[chromium] rebaseline new test expectations.
- platform/chromium-mac/media/video-source-expected.txt:
- platform/chromium-mac/media/video-src-expected.txt:
- platform/chromium-win/media/video-source-expected.txt:
- platform/chromium-win/media/video-src-expected.txt:
- 5:29 PM Changeset in webkit [63146] by
-
- 3 edits2 adds in branches/safari-533.17-branch
Merge r62302.
- 5:22 PM Changeset in webkit [63145] by
-
- 3 edits2 adds in branches/safari-533.17-branch
Merge r62271.
- 5:18 PM Changeset in webkit [63144] by
-
- 3 edits3 moves in branches/safari-533.17-branch
Merge r62304.
- 5:14 PM Changeset in webkit [63143] by
-
- 2 edits in branches/safari-533.17-branch/JavaScriptCore
Merge r62464.
- 5:14 PM Changeset in webkit [63142] by
-
- 5 edits in branches/safari-533.17-branch
Merge r62456.
- 5:14 PM Changeset in webkit [63141] by
-
- 2 edits in branches/safari-533.17-branch/LayoutTests
Merge r62433.
- 5:14 PM Changeset in webkit [63140] by
-
- 6 edits3 adds in branches/safari-533.17-branch
Merge r62432.
- 4:53 PM Changeset in webkit [63139] by
-
- 2 edits in trunk/WebCore
AX converts AtomicStrings to .string() more than needed
https://bugs.webkit.org/show_bug.cgi?id=42056
- 4:38 PM Changeset in webkit [63138] by
-
- 3 edits2 adds in trunk
2010-07-12 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
crash in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=41196
- scrollbars/hidden-iframe-scrollbar-crash-expected.txt: Added.
- scrollbars/hidden-iframe-scrollbar-crash.html: Added.
2010-07-12 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
crash in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=41196
Test: scrollbars/hidden-iframe-scrollbar-crash.html
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
- 4:20 PM Changeset in webkit [63137] by
-
- 5 edits in branches/safari-533.17-branch
Versioning.
- 4:19 PM Changeset in webkit [63136] by
-
- 1 copy in tags/Safari-533.17.4
New tag.
- 4:16 PM Changeset in webkit [63135] by
-
- 6 edits in trunk
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML tags should break out of foreign content
https://bugs.webkit.org/show_bug.cgi?id=42106
- html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML tags should break out of foreign content
https://bugs.webkit.org/show_bug.cgi?id=42106
Implement another paragraph of the spec to pass another
bunch of foreign content tests.
This fixes a bunch of tests in html5lib/runner.html.
After this change we only have 4 remaining foreign content failures.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 4:13 PM Changeset in webkit [63134] by
-
- 7 edits in trunk
2010-07-12 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Bring bufferData and clear to GLES2 compliant
https://bugs.webkit.org/show_bug.cgi?id=41574
- fast/canvas/webgl/invalidPassedParams-expected.txt: Add wrong param test cases for bufferData and clear.
- fast/canvas/webgl/invalidPassedParams.html: Ditto.
- fast/canvas/webgl/resources/desktop-gl-constants.js: Add ACCUM_BUFFER_BIT enum.
2010-07-12 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Bring bufferData and clear to GLES2 compliant
https://bugs.webkit.org/show_bug.cgi?id=41574
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): Call validateBufferDataUsage(). (WebCore::WebGLRenderingContext::clear): Check mask. (WebCore::WebGLRenderingContext::validateBufferDataUsage): Check usage.
- html/canvas/WebGLRenderingContext.h: Declare validateBufferDataUsage.
- 3:51 PM Changeset in webkit [63133] by
-
- 2 edits in trunk/WebKitTools
2010-07-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
- Scripts/old-run-webkit-tests:
- 3:37 PM Changeset in webkit [63132] by
-
- 2 edits in trunk/WebKit2
Build fix. Copy WKArray.h to the include directory.
- win/WebKit2Generated.make:
- 3:24 PM Changeset in webkit [63131] by
-
- 2 edits in trunk/WebCore
2010-07-12 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt to fix Chromium Windows build.
Always generate SVGNames and MathMLNames for all ports (to support HTML5)
https://bugs.webkit.org/show_bug.cgi?id=42050
Another way to fix this might be to mark all the .in files with
svn:eol=native. But fixing the perl to be more robust against
stray whitespace seems to be a better long-term fix.
No functional change, thus no tests.
- bindings/scripts/InFilesParser.pm:
- 3:22 PM Changeset in webkit [63130] by
-
- 6 edits1 copy in trunk/WebKitTools
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] Support pixel tests
https://bugs.webkit.org/show_bug.cgi?id=31518
Finish support for pixel tests on GTK+.
- DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only works on CoreFoundation systems) and add missing cstdio include.
- DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found in JSC library. MD5.cpp and MD5.h are only available for the Windows build. (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported by the ANSI standard and this fails on Linux, so unroll the loop here.
- DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior. (BitmapContext::BitmapContext): There is no reason to check the value of the m_context member in the constructor and it certainly should not be freed. Instead just initialize it with the incoming value.
- DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes. (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to dump pixels.
- DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added. (createBitmapContextFromWebView):
- GNUmakefile.am: Add new files to the build.
- 3:12 PM Changeset in webkit [63129] by
-
- 2 edits in trunk/WebKit2
Re-do an Xcode project change that Xcode decided not to save.
- WebKit2.xcodeproj/project.pbxproj: Remove WebKit2.exp from the project.
For some reason it was being copied in to the framework wrapper.
- 3:07 PM Changeset in webkit [63128] by
-
- 2 edits in trunk/WebKit/gtk
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] r63100 broke the testwebview test
https://bugs.webkit.org/show_bug.cgi?id=42114
- tests/testwebview.c: Disable a failing assertion in test_webkit_web_view_adjustments until we can get to the bottom of the failure.
- 3:06 PM Changeset in webkit [63127] by
-
- 11 edits in branches/audio/WebCore
Allow AudioContext to operate without need for <xaudio>
- created constructor for AudioContext
- AudioContext signs up for notifications from Document to stop playing when document goes away
- CachedAudio now can deal directly with AudioContext
- still need to remove the now obsolete <xaudio> files
- 3:01 PM Changeset in webkit [63126] by
-
- 3 edits in trunk/WebCore
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Remove dependency on PlatformString.h in Color.h
https://bugs.webkit.org/show_bug.cgi?id=42109
- platform/graphics/Color.cpp:
- platform/graphics/Color.h:
- 2:58 PM Changeset in webkit [63125] by
-
- 5 edits1 delete in trunk/WebKit2
Remove the exports file from WebKit2.
Reviewed by Sam Weinig.
- Configurations/Base.xcconfig: Have symbols default to hidden visibility.
- Configurations/WebKit2.xcconfig: Remove the export file.
- UIProcess/API/mac/WKView.h: Export the WKView class.
- WebProcess/WebKitMain.cpp: Export the WebKitMain function.
- mac/WebKit2.exp: Removed.
- 2:58 PM Changeset in webkit [63124] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Rubber-stamped by Sam Weinig.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 2:45 PM Changeset in webkit [63123] by
-
- 2 edits in trunk/WebCore
2010-07-12 Eric Seidel <eric@webkit.org>
Unreviewed, build fix.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
Fix the Windows project file to build MathMLNames.*.
Also added MathMLElementFactory.* which is a NOOP now, but will
prevent folks from breaking the build when they turn MathML on.
- WebCore.vcproj/WebCore.vcproj:
- 2:38 PM Changeset in webkit [63122] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Enable xmlhttprequest/failed-auth.html on Windows. It now passes on my machine.
- platform/win/Skipped: Also removed two userscript tests that don't exist (run-webkit-tests loudly complained about those).
- 2:33 PM Changeset in webkit [63121] by
-
- 1 edit in trunk/WebKit2/win/WebKit2.vcproj
Windows build fix.
- 2:32 PM Changeset in webkit [63120] by
-
- 15 edits in trunk
2010-07-09 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
String to number coercion is not spec compliant
https://bugs.webkit.org/show_bug.cgi?id=31349
ToNumber should ignore NBSP (\u00a0)
https://bugs.webkit.org/show_bug.cgi?id=25490
- runtime/JSGlobalObjectFunctions.cpp: (JSC::parseIntOverflow): Added a version that works on UChar.
- runtime/JSGlobalObjectFunctions.h: Ditto.
- runtime/UString.cpp: (JSC::isInfinity): Added helper functions. (JSC::UString::toDouble): Use isStrWhiteSpace instead of isSASCIISpace to define what we should skip. Got rid of the code that used CString and UTF8String, instead processing the UChar of the string directly, except for when we call strtod. For strtod, use our own home-grown conversion function that does not try to do any UTF-16 processing. Tidied up the logic a bit as well.
2010-07-09 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
String to number coercion is not spec compliant
https://bugs.webkit.org/show_bug.cgi?id=31349
- fast/js/ToNumber-expected.txt: Updated to expect more tests to pass.
- fast/js/parseFloat-expected.txt: Ditto.
- fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A2-expected.txt: Ditto.
- fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T1-expected.txt: Ditto.
- fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T2-expected.txt: Ditto.
- fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T10-expected.txt: Ditto.
- fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T3-expected.txt: Ditto.
- fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T8-expected.txt: Ditto.
- fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T9-expected.txt: Ditto.
- fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A6-expected.txt: Ditto.
- 2:26 PM Changeset in webkit [63119] by
-
- 20 edits2 deletes in trunk
2010-07-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Update media element's handling of empty 'src' attribute
https://bugs.webkit.org/show_bug.cgi?id=42001
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return getNonEmptyURLAttribute(). (WebCore::HTMLMediaElement::selectMediaResource): Call noneSupported() for empty 'src'. (WebCore::HTMLMediaElement::selectNextSourceChild): Use getNonEmptyURLAttribute() to convert 'src' to URL instead of document()->completeURL(). Don't consider a <source> with an empty 'src'.
- html/HTMLMediaElement.idl: Add 'NonEmpty' option to 'src' attribute.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return getNonEmptyURLAttribute(). (WebCore::HTMLSourceElement::isURLAttribute): New, 'src' is a URL attribute.
- html/HTMLSourceElement.h:
- html/HTMLSourceElement.idl: Add 'NonEmpty' option to 'src' attribute.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Use getNonEmptyURLAttribute() to convert 'poster' to URL instead of document()->completeURL().
- html/HTMLVideoElement.idl: Add 'NonEmpty' option to 'poster' attribute.
2010-07-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (OOPS!).
Update media element's handling of empty 'src' attribute
https://bugs.webkit.org/show_bug.cgi?id=42001
- fast/dom/URL-attribute-reflection-expected.txt: Update results now that audio, video, and source return 'non-empty URL'.
- media/video-poster-expected.txt:
- media/video-poster.html: Test empty poster url.
- media/video-source-error-no-candidate-expected.txt:
- media/video-source-error-no-candidate.html: Empty 'src' should fires an error event.
- media/video-source-expected.txt:
- media/video-source.html: Test <source> element's 'src' attribute and property as well as currentSrc.
- media/video-src-empty-expected.txt: Removed.
- media/video-src-empty.html: Removed, the test is no longer valid.
- media/video-src-none-expected.txt:
- media/video-src-none.html: Updated to test empty 'src'. Add tests to ensure that an error is fired when load() is called and the 'src' is empty, but not when 'src' is missing.
- media/video-src.html:
- media/video-src-expected.txt: Test 'src' attribute and property as well as currentSrc.
- 2:24 PM Changeset in webkit [63118] by
-
- 4 edits in trunk
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] make dist is broken because of missing headers and other miscellaneous reasons
https://bugs.webkit.org/show_bug.cgi?id=42107
- GNUmakefile.am: Add missing header to the sources list.
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] make dist is broken because of missing headers and other miscellaneous reasons
https://bugs.webkit.org/show_bug.cgi?id=42107
- GNUmakefile.am: Remove InspectorFrontend2.idl from the list of IDL files, so that it is not built into libWebCoreJS. Add missing header to the source list. Make sure to distribute the new file: WebCore/inspector/CodeGeneratorInspector.pm.
- 2:20 PM Changeset in webkit [63117] by
-
- 4 edits in trunk
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump to 1.3.3
- configure.ac:
WebKit/gtk:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.3.3
- NEWS:
- 2:13 PM Changeset in webkit [63116] by
-
- 6 edits in trunk
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs to support mixing SVG and MathML content
https://bugs.webkit.org/show_bug.cgi?id=42096
- html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs to support mixing SVG and MathML content
https://bugs.webkit.org/show_bug.cgi?id=42096
This is just a direct transcription of another paragraph of the
HTML5 spec.
This improved a couple results in html5lib/runner.html, but more
work to do yet to pass all the foreign content tests.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processUsingSecondaryInsertionModeAndAdjustInsertionMode):
- html/HTMLTreeBuilder.h:
- mathml/mathtags.in:
- 2:09 PM Changeset in webkit [63115] by
-
- 5 edits in trunk
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
We pass a bunch more tests now that our MathML code path is enabled.
- html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
Fix the HTMLTreeBuilder MathML code path to compile and remove
the MathML and SVG guards now that SVGNames and MathMLNames are
always compiled into ever port after:
https://bugs.webkit.org/show_bug.cgi?id=42050
This fixed a whole bunch of libhtml5 tests now that we have the
mathml code paths enabled.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- Always init SVGNames and MathML names.
- 2:06 PM Changeset in webkit [63114] by
-
- 2 edits in trunk/WebKitTools
2010-07-12 Adam Barth <abarth@webkit.org>
Unreviewed.
Remove stray "raise e" that got included in a previous patch. This
caused the EWS bots to turn red instead of purple when a patch failed
to apply.
- Scripts/webkitpy/tool/commands/stepsequence.py:
- 2:06 PM Changeset in webkit [63113] by
-
- 1 edit in trunk/WebKit2/win/WebKit2.vcproj
Windows build fix
- 2:02 PM Changeset in webkit [63112] by
-
- 3 edits3 adds in trunk
2010-07-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Need to do a layout when RenderLayers come and go because of compositing
https://bugs.webkit.org/show_bug.cgi?id=42108
If we create or destroy RenderLayers for reasons other than style changes
(e.g. because of composited iframes or plugins), then we need to ensure
that we do a layout.
Test: compositing/iframes/layout-on-compositing-change.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::adjustStyleDifference):
- 1:53 PM Changeset in webkit [63111] by
-
- 6 edits in trunk/WebCore
2010-07-11 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Always generate SVGNames and MathMLNames for all ports (to support HTML5)
https://bugs.webkit.org/show_bug.cgi?id=42050
Historically, FOONames has only been generate when ENABLE(FOO) is defined.
However, for HTML5 parser support, we need to have access to the SVG
and MathML tag names regardless of whether we the engine is configured
to render SVG or MathML content.
This change enables generation of SVGNames and MathMLNames on all ports and
makes it so that ports can include FOOElementFactory.* regardless of whether
ENABLE(FOO) is defined (and have it do the right thing).
No functional change (yet) so no tests.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.pri:
- dom/make_names.pl:
- 1:53 PM Changeset in webkit [63110] by
-
- 2 edits in trunk/WebKitTools
2010-07-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63101.
http://trac.webkit.org/changeset/63101
https://bugs.webkit.org/show_bug.cgi?id=42103
Broke one API test (Requested by xan_ on #webkit).
- Scripts/old-run-webkit-tests:
- 1:50 PM Changeset in webkit [63109] by
-
- 2 edits in trunk/WebCore
2010-07-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
make_names.pl should always generate all names in Names.* files
https://bugs.webkit.org/show_bug.cgi?id=42023
Only the *ElementFactory files need to have conditional contents
based on enabled features. WebCore should always have all known
names for SVG, MathML, XML, XLink, HTML, etc. generated in the
various *Names files, even if features are disabled.
make_names.pl is kinda a big hack at this point. I tried to clean
up a little as I went. The way I made *Names include all names was to
read the .in files twice, once using the preprocessor and once without.
- dom/make_names.pl:
- 1:39 PM Changeset in webkit [63108] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Fix crashes in Windows DumpRenderTree.
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge() again on a destroyed sender.
- 1:33 PM Changeset in webkit [63107] by
-
- 2 edits in trunk/WebKitTools
Windows failure-to-launch fix
- DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
we already do for CoreFoundation, CFNetwork, etc.
- 1:18 PM Changeset in webkit [63106] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, build fix
[chromium] update test_expectations, and rebaseline a changed svg test.
- platform/chromium-win/fast/gradients/radial-centered-expected.checksum:
- platform/chromium-win/fast/gradients/radial-centered-expected.png:
- platform/chromium-win/fast/gradients/radial-centered-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:09 PM UsingGitWithWebKit edited by
- (diff)
- 1:05 PM Changeset in webkit [63105] by
-
- 2 edits1 copy in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
The fix doesn't help Tiger, update results of one test and skip another.
- platform/mac-tiger/Skipped: Skip 401-alternative-content.php.
- platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from http/tests/xmlhttprequest/failed-auth-expected.txt, updated for failure result in async case.
- 12:22 PM Changeset in webkit [63104] by
-
- 2 edits4 adds in trunk/WebKit2
Move WebKit2.vcproj's settings into .vsprops files
This makes it easier to make changes that affect all configurations.
Fixes <http://webkit.org/b/42097> WebKit2 should use .vsprops files
Reviewed by Steve Falkenburg.
- win/WebKit2.vcproj: Moved settings from here to the files below.
- win/WebKit2Apple.vsprops: Added. Links against Apple-specific
libraries.
- win/WebKit2CFLite.vsprops: Added. Links against CFLite.
- win/WebKit2Common.vsprops: Added. Contains settings shared by all
configurations.
- win/WebKit2DirectX.vsprops: Added. Contains settings to help with
linking against DirectX.
- 12:21 PM Changeset in webkit [63103] by
-
- 6 edits in trunk
Stop generating stripped symbols for Release builds
It turns out we can strip the symbols after-the-fact using PDBCopy.
Fixes <http://webkit.org/b/42085>.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Removed the pre-link event, which just created the public\sym
directory.
WebKit2:
- win/WebKit2.vcproj: Removed the no-longer-needed Release override of
the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)
WebKitLibraries:
- win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
attribute, which caused link.exe to generate a stripped PDB file for
each project.
- 11:34 AM Changeset in webkit [63102] by
-
- 6 edits in trunk/WebCore
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
Canvas: Move fillRect() save/restore into GraphicsContext implementations
https://bugs.webkit.org/show_bug.cgi?id=42088
Saving the platform painter state is an expensive operation,
so don't do it in fillRect() for platforms that don't need it. (CG, Qt)
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRect):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::fillRect):
- 11:18 AM Changeset in webkit [63101] by
-
- 2 edits in trunk/WebKitTools
2010-07-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
- Scripts/old-run-webkit-tests:
- 11:14 AM Changeset in webkit [63100] by
-
- 4 edits3 adds in trunk
2010-07-12 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Ensure that a cache policy that forces validation is cleared once
the load event is fired, rather than only doing so at the next
navigation. This leads to a lot of unnecessary load on AJAX-y
websites.
Test: http/tests/xmlhttprequest/cache-headers-after-reload.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Reset m_loadType to FrameLoadTypeStandard. (WebCore::FrameLoader::addExtraFieldsToRequest): Only respect the original request's cache policy if the
DocumentLoader is still loading, and handle the other cache policy settings that were scattered around the loader.
(WebCore::FrameLoader::loadResourceSynchronously): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.
- 11:00 AM Changeset in webkit [63099] by
-
- 4 edits in trunk/WebCore
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
CSS color parsing optimizations
https://bugs.webkit.org/show_bug.cgi?id=42073
- Avoid instantiating a CSSParser in parseColor() unless necessary.
- Fixed hex color fast-path to support strings starting with '#'.
- Avoid allocating a new string for the value part of a '#' color.
- css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
- platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): (WebCore::Color::Color):
- platform/graphics/Color.h:
- 10:49 AM WikiStart edited by
- Link to HackingWebInspector added. (diff)
- 10:42 AM Changeset in webkit [63098] by
-
- 2 edits in trunk
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Suffix .mo files with the GTK+ API version so that they can be
parallel installable.
- configure.ac:
- 10:33 AM HackingWebInspector edited by
- (diff)
- 10:31 AM Changeset in webkit [63097] by
-
- 3 edits in trunk/WebKit2
WebKit2 build fix for Windows.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Remove some stub function definitions.
- win/WebKit2.vcproj: Add PluginController.h to the vcproj.
- 10:29 AM HackingWebInspector edited by
- (diff)
- 10:28 AM WebKit Team edited by
- Adding Justin, Chris (google security team) who have committer access (diff)
- 10:28 AM Changeset in webkit [63096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Some inspector test fail intermittently
https://bugs.webkit.org/show_bug.cgi?id=42090
Add tests to the Skipped list until fix to avoid false positive alarms.
- platform/qt/Skipped:
- inspector/timeline-layout.html skipped.
- inspector/timeline-parse-html.html skipped.
- inspector/timeline-recalculate-styles.html skipped.
- 10:12 AM HackingWebInspector edited by
- Move images from my host to the attachments (diff)
- 10:05 AM HackingWebInspector created by
- 9:57 AM Changeset in webkit [63095] by
-
- 11 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
- 9:52 AM Changeset in webkit [63094] by
-
- 12 edits1 copy in trunk
Add a PluginController class, use it for invalidation and getting the user agent
https://bugs.webkit.org/show_bug.cgi?id=42084
Reviewed by Adam Roben.
WebCore:
- WebCore.exp.in:
Export Widget::convertToContainingWindow.
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
Add PluginController.h
- WebProcess/Plugins/DummyPlugin.cpp:
(WebKit::DummyPlugin::initialize):
- WebProcess/Plugins/DummyPlugin.h:
Pass the PluginController to initialize.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
Implement NPN_UserAgent, NPN_MemAlloc, NPN_MemFree, NPN_InvalidateRect and NPN_InvalidateRegion.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginController to null.
(WebKit::NetscapePlugin::invalidate):
Ask the plug-in controller to invalidate.
(WebKit::NetscapePlugin::userAgent):´
Ask the plug-in controller for the user agent.
(WebKit::NetscapePlugin::initialize):
Set the m_pluginController member variable.
- WebProcess/Plugins/Plugin.h:
Make initialize take a PluginController.
- WebProcess/Plugins/PluginController.h: Added.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
Pass the PluginController to initialize.
(WebKit::PluginView::invalidateRect):
Tell the host window to invalidate the given rect.
(WebKit::PluginView::invalidate):
Call invalidateRect.
(WebKit::PluginView::userAgent):
Ask the frame loader client for the user agent.
- WebProcess/Plugins/PluginView.h:
- 9:41 AM Changeset in webkit [63093] by
-
- 5 edits in trunk/JavaScriptCore
Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
https://bugs.webkit.org/show_bug.cgi?id=42086
Reviewed by Dan Bernstein.
- wtf/OwnPtr.h:
- wtf/PassOwnPtr.h:
- wtf/PassRefPtr.h:
(WTF::PassRefPtr::releaseRef):
(WTF::NonNullPassRefPtr::leakRef):
(WTF::NonNullPassRefPtr::releaseRef):
- wtf/RetainPtr.h:
(WTF::RetainPtr::releaseRef):
- 9:07 AM Changeset in webkit [63092] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations updated.
- platform/chromium/test_expectations.txt:
- 8:48 AM Changeset in webkit [63091] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations updated.
- platform/chromium/test_expectations.txt:
- 8:40 AM Changeset in webkit [63090] by
-
- 4 edits in trunk/WebKitTools
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=42082
- QtTestBrowser/main.cpp: (LauncherWindow::createChrome):
- QtTestBrowser/mainwindow.cpp: (MainWindow::openLocation):
- QtTestBrowser/mainwindow.h:
- 8:18 AM Changeset in webkit [63089] by
-
- 4 edits in trunk
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
https://bugs.webkit.org/show_bug.cgi?id=41457
Rebaseline test now that Qt doesn't corrupt non-breaking spaces on clipboard roundtrip.
- platform/qt/editing/pasteboard/onpaste-text-html-expected.txt:
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
https://bugs.webkit.org/show_bug.cgi?id=41457
Treat non-special-cased mime-types as Unicode strings in ClipboardQt's getData()
Fixes corruption when retrieving data that was set with anything other than text/plain
Also use QMimeData::setHtml() when applicable to be consistent with PasteboardQt.
- platform/qt/ClipboardQt.cpp: (WebCore::isHtmlMimeType): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData):
- 8:06 AM Changeset in webkit [63088] by
-
- 2 edits in trunk/WebCore
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
add ANDROID to STORE_FONT_CUSTOM_PLATFORM_DATA
https://bugs.webkit.org/show_bug.cgi?id=32273
Tested by existing tests, just adding ANDROID to the list of platforms that use this feature.
- loader/CachedFont.cpp:
- 7:58 AM Changeset in webkit [63087] by
-
- 2 edits in trunk/WebKitTools
Make the Python autoinstaller not use a dead SourceForge server
Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
offline SourceForge server
Reviewed by Anders Carlsson.
- Scripts/webkitpy/thirdparty/init.py: Use
surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
which seems to be down.
- 7:54 AM Changeset in webkit [63086] by
-
- 3 edits13 adds3 deletes in trunk/LayoutTests
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaseline chromium layout tests.
- platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
- platform/chromium-linux/fast/gradients/radial-centered-expected.checksum:
- platform/chromium-linux/fast/gradients/radial-centered-expected.png:
- platform/chromium-linux/fast/gradients/radial-centered-expected.txt: Added.
- platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
- platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
- platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
- platform/chromium-mac/fast/gradients/radial-centered-expected.checksum: Removed.
- platform/chromium-mac/fast/gradients/radial-centered-expected.png: Removed.
- platform/chromium-mac/fast/gradients/radial-centered-expected.txt: Removed.
- platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
- platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Added.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Added.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Added.
- 7:49 AM Changeset in webkit [63085] by
-
- 2 edits in trunk/WebKitTools
Make run-webkit-tests print how many tests timed out when exiting early
The number of timed-out tests is taken into account when deciding
whether to exit early. Leaving it out of the output just makes the
script look buggy (because it might say something like "Exiting early
after 0 crashes.").
Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
messages when exiting early due to crashes and time-outs
Reviewed by Anders Carlsson.
- Scripts/old-run-webkit-tests:
(stopRunningTestsEarlyIfNeeded): When stopping, print the number of
timed-out tests, too.
- 7:27 AM Changeset in webkit [63084] by
-
- 3 edits in trunk/WebCore
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed.
[EFL] Move ScriptConcotrollerEfl.cpp from CMakeLists.txt to
CMakeListsEfl.txt.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- 7:23 AM Changeset in webkit [63083] by
-
- 4 edits in trunk
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix after r60050.
- CMakeLists.txt: Add WebCore/bindings to the include path.
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix after r60050.
- CMakeLists.txt: Add WebCore/bindings to the include path.
- 7:19 AM Changeset in webkit [63082] by
-
- 2 edits in trunk/WebCore
2010-07-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when going back with page cache in unknown circunstances
https://bugs.webkit.org/show_bug.cgi?id=41710
Could not yet find a way to reproduce this in a layout test. The
issue is document being NULL, so this NULL-check should be enough
to get rid of the crash. We are working on trying to find a better
solution for these null cases, like attaching the document earlier
when openning a cached page.
- page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
- 7:13 AM Changeset in webkit [63081] by
-
- 2 edits2 adds in trunk/WebKit2
Windows build fix
- WebProcess/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Added.
(WebKit::NetscapePluginModule::tryLoad):
(WebKit::NetscapePluginModule::unload):
Stubbed these out.
- win/WebKit2.vcproj: Added a Netscape filter beneath
WebProcess/Plugins, and moved NetscapePlugin into it. Added
NetscapePluginModule to the new Netscape filter. Added
WebProcess/Plugins to the include path for all configurations (it was
only added to Release and Debug_Internal previously) and added
WebProcess/Plugins/Netscape to the include path for all
configurations.
- 7:07 AM Changeset in webkit [63080] by
-
- 5 edits in trunk
2010-07-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] Crash when stepping on a breakpoint while debugging Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=41958
WebCore:
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
WebKit/chromium:
- src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
- 6:20 AM Changeset in webkit [63079] by
-
- 8 edits in trunk
2010-07-12 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Test the mathsize MathML attribute.
https://bugs.webkit.org/show_bug.cgi?id=42067
- mathml/presentation/attributes.xhtml:
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
2010-07-12 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Make the mathsize MathML attribute handle values in em, px, pt,...
https://bugs.webkit.org/show_bug.cgi?id=42067
Test: mathml/presentation/attributes.xhtml
- css/mathml.css: (math[mathsize="small"], mstyle[mathsize="small"], mo[mathsize="small"], mn[mathsize="small"], mi[mathsize="small"], mtext[mathsize="small"], mspace[mathsize="small"], ms[mathsize="small"]): (math[mathsize="normal"], mstyle[mathsize="normal"], mo[mathsize="normal"], mn[mathsize="normal"], mi[mathsize="normal"], mtext[mathsize="normal"], mspace[mathsize="normal"], ms[mathsize="normal"]): (math[mathsize="big"], mstyle[mathsize="big"], mo[mathsize="big"], mn[mathsize="big"], mi[mathsize="big"], mtext[mathsize="big"], mspace[mathsize="big"], ms[mathsize="big"]):
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::parseMappedAttribute):
- 6:18 AM MathML 3 testsuite results edited by
- (diff)
- 5:52 AM Changeset in webkit [63078] by
-
- 5 edits in trunk
WebCore:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compilation with sealed GTK+.
- platform/gtk/GtkVersioning.h:
- platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillDataObjectFromDropData):
WebKit/gtk:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compilation with sealed GTK+.
- webkit/webkitwebview.cpp: (webkit_web_view_drag_motion): (webkit_web_view_drag_data_received): (webkit_web_view_drag_drop):
- 5:51 AM Changeset in webkit [63077] by
-
- 2 edits in trunk
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add another include path to the scanner to avoid warnings related
to undefined types. It wasn't picking up <webkit/foo.h>-like
headers.
- GNUmakefile.am:
- 5:45 AM Changeset in webkit [63076] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Fix duplicate test expectations
https://bugs.webkit.org/show_bug.cgi?id=42072
- platform/chromium/test_expectations.txt:
- 5:43 AM Changeset in webkit [63075] by
-
- 4 edits in trunk/LayoutTests
2010-07-12 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Update of the results to the test introduced here:
https://bugs.webkit.org/show_bug.cgi?id=41626
as they were outdated in the commit.
- platform/mac/mathml/presentation/tokenElements-expected.checksum:
- platform/mac/mathml/presentation/tokenElements-expected.png:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- 5:31 AM Changeset in webkit [63074] by
-
- 12 edits in trunk
2010-07-12 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Update tests to check that msqrt and mfrac use style color to draw themselves
https://bugs.webkit.org/show_bug.cgi?id=41889
- mathml/presentation/fractions.xhtml:
- mathml/presentation/roots.xhtml:
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
2010-07-12 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Fix a bug preventing msqrt and mfrac to use style color to draw themselves.
In mfrac, the fraction bar is now using the color defined by the element style instead of black.
In msqrt, the radical was always drawn in black due to a colorSpace problem.
https://bugs.webkit.org/show_bug.cgi?id=41889
Test: mathml/presentation/roots.xhtml
Test: mathml/presentation/fractions.xhtml
- mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
- mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
- 5:17 AM Changeset in webkit [63073] by
-
- 4 edits in trunk
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antti Koivisto.
Canvas: arc() with startAngle == endAngle shouldn't add to the path
https://bugs.webkit.org/show_bug.cgi?id=41420
Unskip (for Qt) test that now passes:
- canvas/philip/tests/2d.path.stroke.prune.arc.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke
- platform/qt/Skipped:
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antti Koivisto.
Canvas: arc() with startAngle == endAngle shouldn't add to the path
https://bugs.webkit.org/show_bug.cgi?id=41420
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
- 5:08 AM Changeset in webkit [63072] by
-
- 2 edits in trunk/LayoutTests
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Somehow the updated expectations got dropped form the original patch. Added.
- storage/indexeddb/idb-objectstore-request-expected.txt:
- 4:46 AM Changeset in webkit [63071] by
-
- 10 edits in trunk
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Ojan Vafai.
Update padding on Windows?
https://bugs.webkit.org/show_bug.cgi?id=38016
- platform/chromium/test_expectations.txt:
- platform/win/Skipped:
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Ojan Vafai.
Update padding on Windows?
https://bugs.webkit.org/show_bug.cgi?id=38016
Remove internal padding and add 1px vertical padding for Windows.
- css/themeWin.css: (input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
- rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
- rendering/RenderTheme.h:
- rendering/RenderThemeWin.cpp:
- rendering/RenderThemeWin.h:
- rendering/RenderThemeWince.cpp:
- rendering/RenderThemeWince.h:
- 4:18 AM Changeset in webkit [63070] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put the expected result for Win.
REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452
- platform/win/printing/page-rule-in-media-query-expected.txt: Added.
- 4:15 AM Changeset in webkit [63069] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Speculative fix for visual studio retardedness.
- public/WebCommon.h:
- 4:10 AM Changeset in webkit [63068] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put wrong results for Mac and Win instead of Skipped list.
Results for editing/pasteboard/5761530-1.html are wrong
https://bugs.webkit.org/show_bug.cgi?id=38437
- platform/mac/Skipped:
- platform/mac/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
- platform/win/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
- 3:50 AM Changeset in webkit [63067] by
-
- 2 edits in trunk/WebCore
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix.
[Chromium, V8] r63057 regressed url tests.
- bindings/scripts/CodeGeneratorV8.pm:
- 3:47 AM MathML 3 testsuite results edited by
- (diff)
- 3:43 AM MathML 3 testsuite results edited by
- (diff)
- 3:42 AM Changeset in webkit [63066] by
-
- 3 edits2 adds in trunk
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
XPath substring function does not correctly handle non-positive values for the position argument
https://bugs.webkit.org/show_bug.cgi?id=41913
This patch changes the behavior of the XPath evaluate function when a non-positive
position argument is supplied and no length argument is supplied. In this case,
we reset the position to 1. This follows the spec and matches the current behaviour
when a length argument is supplied.
Test: fast/xpath/substring-non-positive-postion.html
- xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstring::evaluate):
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
XPath substring function does not correctly handle non-positive values for the position argument
https://bugs.webkit.org/show_bug.cgi?id=41913
- fast/xpath/substring-non-positive-postion-expected.txt: Added.
- fast/xpath/substring-non-positive-postion.html: Added.
- 3:39 AM Changeset in webkit [63065] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Build fix. Add an include.
- public/WebCommon.h:
- 3:00 AM Changeset in webkit [63064] by
-
- 53 edits2 copies in trunk
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Modify existing test to provide basic coverage for get/put/remove functions.
- storage/indexeddb/script-tests/idb-objectstore-request.js: (test): (openSuccess): (createSuccess): (addSuccess): (getSuccess): (removeSuccess):
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Implement these functions in IDBObjectStore,
add plumbing, teach IDBAny/Callbacks how to deal
with IDBKey, and a few small bits of cleanup.
Test: Modified existing test to provide basic coverage.
Will add much more extensive layout test coverage
in future patches.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- storage/IDBAny.cpp: (WebCore::IDBAny::idbKey): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBAny.idl:
- storage/IDBCallbacks.h:
- storage/IDBDatabaseRequest.h:
- storage/IDBDatabaseRequest.idl:
- storage/IDBKeyRange.h:
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::):
- storage/IDBObjectStoreImpl.cpp: (WebCore::IDBObjectStoreImpl::IDBObjectStoreImpl): (WebCore::IDBObjectStoreImpl::get): (WebCore::IDBObjectStoreImpl::set): (WebCore::IDBObjectStoreImpl::remove):
- storage/IDBObjectStoreImpl.h:
- storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::get): (WebCore::IDBObjectStoreRequest::add): (WebCore::IDBObjectStoreRequest::modify): (WebCore::IDBObjectStoreRequest::addOrModify): (WebCore::IDBObjectStoreRequest::remove):
- storage/IDBObjectStoreRequest.h:
- storage/IDBObjectStoreRequest.idl:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Plumbing for new features, IDBKey, and added support
for both invalid (i.e. not serializable) and null
(i.e. the RefPtr was 0) to SerializedScriptValue.
- WebKit.gyp:
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
- public/WebIDBKey.h: Added. (WebKit::WebIDBKey::WebIDBKey): (WebKit::WebIDBKey::operator=): (WebKit::WebIDBKey::):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::set): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex):
- public/WebSerializedScriptValue.h:
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::set): (WebCore::IDBObjectStoreProxy::remove):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBKey.cpp: Added. (WebKit::WebIDBKey::~WebIDBKey): (WebKit::WebIDBKey::createNull): (WebKit::WebIDBKey::createInvalid): (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::assignNull): (WebKit::WebIDBKey::assignInvalid): (WebKit::WebIDBKey::type): (WebKit::WebIDBKey::string): (WebKit::WebIDBKey::number): (WebKit::WebIDBKey::WebIDBKey): (WebKit::WebIDBKey::operator=): (WebKit::WebIDBKey::operator PassRefPtr<IDBKey>):
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::set): (WebKit::WebIDBObjectStoreImpl::remove):
- src/WebIDBObjectStoreImpl.h:
- src/WebSerializedScriptValue.cpp: (WebKit::WebSerializedScriptValue::createInvalid):
- 12:57 AM Changeset in webkit [63063] by
-
- 11 edits in trunk
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
- WebCore.exp.in: Export Document::getElementById for WebKit2's benefit.
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
animation tests were hanging otherwise.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::numberOfActiveAnimations): (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::LayoutTestController::staticFunctions):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
Implemented some helpers for WebKitTestRunner;
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetNumberOfActiveAnimations): (WKBundleFramePauseAnimationOnElementWithId):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::numberOfActiveAnimations): (WebKit::WebFrame::pauseAnimationOnElementWithId):
- WebProcess/WebPage/WebFrame.h:
- mac/WebKit2.exp:
- 12:08 AM WebKit Team edited by
- Adding myself (diff)
Jul 11, 2010:
- 11:29 PM Changeset in webkit [63062] by
-
- 3 edits in trunk/WebKitTools
2010-07-11 Daniel Bates <dbates@rim.com>
Reviewed by David Kilzer.
Enable executable support for svn-apply and svn-unapply
https://bugs.webkit.org/show_bug.cgi?id=39409
Connect up the Git and SVN executable bit support in parseDiff() so that
executable bit changes are propagated via the returned diff hash to the
patch function in svn-apply and svn-unapply.
- Scripts/VCSUtils.pm:
- Modified parseDiff() to call parseSvnDiffProperties when it finds the start of an SVN property change diff.
- Removed FIXME comment above parseSvnDiffProperties() since it is now being used by parseDiff().
- Export method scmToggleExecutableBit() now that we added the executableBitDelta hash key. (This should have been exported when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated results for:
"rename (with executable bit change)"
- Test value of executableBitDelta (now that we have support).
- Remove the property change diff from svnConvertedText. We plan to remove svnConvertedText in the future. So, we decided against adding such support to any new code, such as the property parsing routines. Therefore, we do not keep SVN converted text for property change diffs.
- Added unit tests: "SVN: file change diff with property change diff" "SVN: file change diff, followed by property change diff on different file" "SVN: property diff, followed by file change diff" "SVN: copied file with property change" "SVN: two consecutive property diffs" "SVN: binary file with executable bit change" "SVN: binary file followed by property change on different file" "SVN: binary file followed by file change on different file" "SVN: file change diff with property change, followed by property change diff" "SVN: file change diff with property change, followed by file change diff"
- Updated results for:
"rename (with executable bit change)"
- 8:41 PM Changeset in webkit [63061] by
-
- 7 edits in trunk/WebKitTools
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement waitUntilDone and notifyDone for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42049
With this fix, most of the DOM tests pass.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didCreatePage): Track the main page. Not a great way to do it in the future case where we may get multiple pages - we really need a way to send it over from the ui process.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::page): A way to get the main page.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we are loading. (WTR::InjectedBundlePage::dump): Factor into a method so this can be called by the layout test controller. Also, cancel any pending watchdogs. (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump to false. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate the watchdog. (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer. (WTR::LayoutTestController::setWaitToDump): Set the flag. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case where waitUntilDone times out. (WTR::LayoutTestController::notifyDone): Dump, if loading is done. (WTR::waitUntilDoneCallback): JS glue for waitUntilDone. (WTR::notifyDoneCallback): JS glue for notifyDone. (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone to the layoutController.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
- 7:35 PM Changeset in webkit [63060] by
-
- 2 edits in trunk/WebKit
2010-07-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Adam Barth.
[EFL] Fix style errors in ewk_private.h.
https://bugs.webkit.org/show_bug.cgi?id=41742
- efl/ewk/ewk_private.h:
- 5:09 PM Changeset in webkit [63059] by
-
- 1 edit1 add in trunk/WebCore
2010-07-11 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel
Add a complete list of the HTML5 entities in JSON format.
- html/HTMLEntityNames.json: Added.
- 10:37 AM Changeset in webkit [63058] by
-
- 8 edits in trunk
2010-07-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843
Add support for dropping content onto GTK+ WebViews.
No new tests, as the DRT does not support simulating drops yet.
- platform/gtk/ClipboardUtilitiesGtk.cpp: (WebCore::dragOperationToGdkDragAction): Added. (WebCore::gdkDragActionToDragOperation): Properly detect DragOperationEvery.
- platform/gtk/ClipboardUtilitiesGtk.h: Add declaration for dragOperationToGdkDragAction.
- platform/gtk/PasteboardHelper.cpp: Add new target atom and rename the markup target type to match the others. Add a method which fills a data object from drop data. (WebCore::PasteboardHelper::initializeTargetList): Add support for new atoms. (WebCore::selectionDataToUTF8String): Added this helper. (WebCore::PasteboardHelper::getClipboardContents): Use the selectionDataToUTF8String helper. (WebCore::PasteboardHelper::targetListForDataObject): Change to reflect markup atom rename. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Added. (WebCore::PasteboardHelper::dropAtoms): Added.
- platform/gtk/PasteboardHelper.h: Add declarations of new methods.
2010-07-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843
Add support for dropping content onto GTK+ WebViews.
- webkit/webkitprivate.h: Add a DroppingContext struct to keep track of drop data while the drop is in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
- webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper. (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper. (webkit_web_view_dispose): Properly clean up droppingContexts member. (webkit_web_view_finalize): Delete droppingContext member. (globalPointForClientPoint): Added. (doDragLeaveLater): Added. (webkit_web_view_drag_leave): Added. (webkit_web_view_drag_motion): Added. (webkit_web_view_drag_data_received): Added. (webkit_web_view_drag_drop): Added. (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition. (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.
- 4:46 AM MathML 3 testsuite results edited by
- (diff)
- 4:13 AM MathML 3 testsuite results edited by
- (diff)
