Context Navigation

← Previous Period
Next Period →

Timeline

Jul 18, 2010:

10:39 PM Changeset in webkit [63644] by mjs@apple.com

2 edits in trunk/LayoutTests

2010-07-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Add more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42551

platform/mac-wk2/Skipped:

10:16 PM Changeset in webkit [63643] by andersca@apple.com

2 edits in trunk/WebCore

Fix Build.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):

9:51 PM Changeset in webkit [63642] by andersca@apple.com

2 edits in trunk/WebCore

Always set the current NSGraphicsContext before calling drawWithFrame
https://bugs.webkit.org/show_bug.cgi?id=42542

Reviewed by Dan Bernstein.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

8:49 PM Changeset in webkit [63641] by andreas.kling@nokia.com

2 edits in trunk/WebKit/qt

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebPage fails cursorMovements and textSelection
https://bugs.webkit.org/show_bug.cgi?id=42531

Correct the HTML used by these tests.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::textEditing):

6:10 PM Changeset in webkit [63640] by andersca@apple.com

2 edits in trunk/WebKit2

Another attempt at fixing the Windows build.

WebProcess/Plugins/NPJSObjectMap.h:

5:13 PM Changeset in webkit [63639] by andersca@apple.com

2 edits in trunk/WebKit2

Try to fix Windows build.

win/WebKit2.vcproj:

5:11 PM WebKit Team edited by ddkilzer@webkit.org

(diff)

5:09 PM Changeset in webkit [63638] by andersca@apple.com

10 edits
1 move
1 delete in trunk

Move PluginWidget to WebKit
https://bugs.webkit.org/show_bug.cgi?id=42530

Reviewed by Sam Weinig.

WebCore:

Rename the PluginWidget class to PluginViewBase and make it an abstract base class.

This is a stopgap measure until we have a single PluginView class that we can use everywhere.

WebCore.exp.in:

Remove PluginWidget symbols.

WebCore.xcodeproj/project.pbxproj:

Update.

platform/Widget.h:

(WebCore::Widget::isPluginViewBase):
Return false.

plugins/PluginViewBase.h: Added.

(WebCore::PluginViewBase::platformLayer):
Always return 0 here now.

(WebCore::PluginViewBase::isPluginViewBase):
Return true.

plugins/PluginWidget.h: Removed.
plugins/mac/PluginWidgetMac.mm: Removed.
rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
Cast to PluginWidgetBase instead.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Cast to PluginWidgetBase instead.

WebKit/mac:

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView pluginLayer]):
Add default pluginLayer implementation.

WebCoreSupport/WebFrameLoaderClient.mm:

(PluginWidget::PluginWidget):
(PluginWidget::invalidateRect):
Move the guts of PluginWidget here from WebCore.

(NetscapePluginWidget::platformLayer):
Get the layer from the plug-in view.

4:45 PM WebKit Team edited by ddkilzer@webkit.org

(diff)

3:55 PM Changeset in webkit [63637] by andreas.kling@nokia.com

2 edits in trunk/WebKit/qt

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527

Correct the HTML used by these tests.

tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::firstChildNextSibling): (tst_QWebElement::lastChildPreviousSibling):

3:27 PM Changeset in webkit [63636] by andersca@apple.com

5 edits in trunk/WebKit2

More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526

Reviewed by Sam Weinig.

WebProcess/Plugins/NPJSObjectMap.cpp:

(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
Check if the JSObject has the given property.

(WebKit::NPJSObject::getProperty):
Add stubbed out function.

(WebKit::NPJSObject::npClass):
Add NP_HasProperty and NP_GetProperty.

(WebKit::NPJSObject::NP_HasProperty):
Call NPJSObject::hasProperty.

(WebKit::NPJSObject::NP_GetProperty):
Call NPJSObject::getProperty.

WebProcess/Plugins/NPRuntimeUtilities.cpp:

(WebKit::releaseNPVariantValue):
Release the given NPVariant.

WebProcess/Plugins/NPRuntimeUtilities.h:
WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetProperty):
Call the NPClass GetProperty function.

(WebKit::NPN_HasProperty):
Call the NPClass HasProperty function.

(WebKit::NPN_ReleaseVariantValue):
Call releaseNPVariantValue.

3:25 PM Changeset in webkit [63635] by dino@apple.com

3 edits in trunk/LayoutTests

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed (although this was discussed with SimonF in
original review).

https://bugs.webkit.org/show_bug.cgi?id=41259

Unfortunately the test in the previous commit is platform
specific (I was hoping it would not be) and is failing
the bots. This update exercises the same thing, but doesn't
check for exact values.

fast/transforms/scrollIntoView-transformed-expected.txt:
fast/transforms/scrollIntoView-transformed.html:

3:01 PM Changeset in webkit [63634] by dino@apple.com

2 edits in trunk/WebCore

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed.

Remove the unwanted extra line that Xcode
added in my last commit.

WebCore.xcodeproj/project.pbxproj:

2:55 PM Changeset in webkit [63633] by dino@apple.com

5 edits
2 adds in trunk

2010-07-18 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=41259
Interacting with a <select> element within a transformed and clipped
container scrolls the container

The Node::getRect and ContainerNode::getRect functions were not
transform-aware. This fixes both, and has a test to make sure
we're not breaking any existing scrollToView code. This means
that a <select> popup will appear in the correct place if it
is within a transformed and scrolled container.

The test makes sure that existing scrollToView
code doesn't break, but also checks that a <select> popup will appear
in the correct place.

Test: fast/transforms/scrollIntoView-transformed.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms.
dom/Node.cpp: (WebCore::Node::getRect):
make sure localToAbsolute gets told to look for transforms.

2:38 PM Changeset in webkit [63632] by ddkilzer@apple.com

7 edits in trunk/WebKit/mac

<http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods

Reviewed by Dan Bernstein.

Carbon/CarbonWindowAdapter.mm:

(-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):

Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):

Misc/WebNSPasteboardExtras.mm:

(-[NSFilePromiseDragSource initWithSource:]):

WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation init]):

WebView/WebPreferences.mm:

(-[WebPreferences init]):

WebView/WebView.mm:

(-[WebView UIDelegate]):
(-[WebView resourceLoadDelegate]):
(-[WebView downloadDelegate]):
(-[WebView policyDelegate]):
(-[WebView frameLoadDelegate]):

2:33 PM Changeset in webkit [63631] by andersca@apple.com

6 edits
2 adds in trunk

Add NPJSObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=42524

Reviewed by Sam Weinig.

WebCore:

Export ScriptController functions.

WebCore.exp.in:

WebKit2:

WebKit2.xcodeproj/project.pbxproj:

Add files.

WebProcess/Plugins/NPJSObjectMap.cpp: Added.
WebProcess/Plugins/NPJSObjectMap.h: Added.

Add NPJSObjectMap, a map which contains NPObjects that wrap JavaScript objects.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize the map.

(WebKit::PluginView::~PluginView):
Invalidate the map.

(WebKit::PluginView::frame):
Add frame getter.

(WebKit::PluginView::windowScriptNPObject):
Wrap the window object.

(WebKit::PluginView::pluginElementNPObject):
Wrap the plug-in element object.

WebProcess/Plugins/PluginView.h:

12:44 PM Changeset in webkit [63630] by andersca@apple.com

3 edits
2 adds in trunk/WebKit2

Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520

Reviewed by Sam Weinig.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/NPRuntimeUtilities.cpp: Added.
WebProcess/Plugins/NPRuntimeUtilities.h: Added.

Add new file with NPRuntime related utility functions.

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_CreateObject):
(WebKit::NPN_RetainObject):
(WebKit::NPN_ReleaseObject):
Call the corresponding NPRuntimeUtilities functions.

11:57 AM Changeset in webkit [63629] by andersca@apple.com

7 edits in trunk/WebKit2

Begin work on NPRuntime support
https://bugs.webkit.org/show_bug.cgi?id=42519

Reviewed by Dan Bernstein.

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle NPNVWindowNPObject and NPNVPluginElementNPObject.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
Call the plug-in controller.

WebProcess/Plugins/PluginController.h:

Add new windowScriptNPObject and pluginElementNPObject functions.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
Add stubbed out functions.

10:45 AM Changeset in webkit [63628] by andersca@apple.com

4 edits in trunk

Implement some NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42518

Reviewed by Dan Bernstein.

WebCore:

WebCore.exp.in:

Export IdentifierRep functions.

WebKit2:

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetStringIdentifier):
(WebKit::NPN_GetStringIdentifiers):
(WebKit::NPN_GetIntIdentifier):
(WebKit::NPN_IdentifierIsString):
(WebKit::NPN_UTF8FromIdentifier):
(WebKit::NPN_IntFromIdentifier):
(WebKit::NPN_CreateObject):

10:01 AM Changeset in webkit [63627] by andersca@apple.com

10 edits in trunk

Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516

Reviewed by Dan Bernstein.

WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Add setStatusbarText callback to WKBundlePageUIClient.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::setStatusbarText):
Call setStatusbarText.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):
Call the bundle page UI client.

WebKitTools:

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.

(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.

(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.

9:32 AM Changeset in webkit [63626] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-07-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: get actual breakpoint location from v8 and pass it
to ScripDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=42452

src/js/DebuggerScript.js:

7:35 AM Changeset in webkit [63625] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed one more expectation to
reflect changes in r63616.

platform/chromium/test_expectations.txt:

6:49 AM Changeset in webkit [63624] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed test expectations (reflected changes
in r63616).

platform/chromium/test_expectations.txt:

Jul 17, 2010:

7:33 PM Changeset in webkit [63623] by andreas.kling@nokia.com

5 edits in trunk/LayoutTests

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

Import new version of 2d.pattern.image.string.html from Philip Taylor.
The original test was buggy and we now pass it.

canvas/philip/tests/2d.pattern.image.string-expected.txt:
canvas/philip/tests/2d.pattern.image.string.html:
platform/mac/Skipped:
platform/qt/Skipped:

6:59 PM Changeset in webkit [63622] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-17 TJ Lee <tjlee0909@gmail.com>

Reviewed by Timothy Hatcher.

HTMLLinkElement ignores dnsPrefetchingEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=42500

Changed the HTML Link tag to check that the browser
has DNS-prefetching enabled before calling ResourceHandle::prepareForURL.

There are no test cases for this patch because it was unclear how to test
this using a layout test. A possible test case would be to
clear the DNS cache on the client's machine before loading a page with
<link rel="dns-prefetch" href="SomeSiteThatsNotTheCurrentOne.com"> and
then check the number of DNS cache entries.

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

6:39 PM Changeset in webkit [63621] by andersca@apple.com

14 edits in trunk

WebKit2: WebKitTestRunner should load the test plug-in
https://bugs.webkit.org/show_bug.cgi?id=42509

Reviewed by Maciej Stachowiak.

UIProcess/API/C/WKContext.cpp:

(_WKContextSetAdditionalPluginPath):
Add a private function for setting a single additional plug-in path. the WebKit1 SPI that does the
same thing takes an array of paths, but this is good enough for now.

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::setAdditionalPluginPaths):
Set the additional plug-in paths vector and refresh the database.

(WebKit::PluginInfoStore::loadPluginsIfNecessary):
First try to load plug-ins in the additional plug-in paths.

UIProcess/WebContext.cpp:

(WebKit::WebContext::setAdditionalPluginPath):
Call PluginInfoStore::setAdditionalPluginPaths.

UIProcess/WebContext.h:

(WebKit::WebContext::pluginInfoStore):
Make the plug-in info store per context instead of having a single shared info store.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):
(WebKit::WebProcessProxy::getPluginHostConnection):

UIProcess/WebProcessProxy.h:

Get the plug-in info store from the context.

WebKitTools: * WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Get the test plug-in path and set it on the context.

Reviewed by Maciej Stachowiak.

WebKitTestRunner/TestController.h:
WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::initializeInjectedBundlePath):
Simplify this code by using NSBundle.

(WTR::TestController::testPluginPath):
Return the test plug-in path.

WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::testPluginPath):
Ditto.

5:15 PM Changeset in webkit [63620] by mjs@apple.com

3 edits in trunk/WebCore

2010-07-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Asynchronous policy checks make FrameLoader think it is done loading prematurely
https://bugs.webkit.org/show_bug.cgi?id=42489

This caused many (~100) layout tsts to fail under WebKit2.

loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe): Right after loading a new subframe, if m_complete is true, do not consider it done if it has a provisional loader. This will happen in the case where the policy check is asynchronous.
loader/FrameLoader.cpp: (WebCore::FrameLoader::subframeIsLoading): For similar reasons, consider a subframe to be loading if it has a policy decision pending.

5:11 PM Changeset in webkit [63619] by andreas.kling@nokia.com

2 edits in trunk/LayoutTests

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

[Qt] Reskip 2d.path.quadraticCurveTo.scaled.html

This test fails with the Qt version running on the bot.

platform/qt/Skipped:

4:48 PM Changeset in webkit [63618] by andersca@apple.com

2 edits in trunk/LayoutTests

Another attempt at fixing this test.

plugins/npruntime/browser-object-identity.html:

3:11 PM Changeset in webkit [63617] by andreas.kling@nokia.com

2 edits in trunk/LayoutTests

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Unskipped two canvas tests that are passing

canvas/philip/tests/2d.path.arc.twopie.3.html
canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html

platform/qt/Skipped:

2:51 PM Changeset in webkit [63616] by andersca@apple.com

4 edits
13 moves
5 deletes in trunk/LayoutTests

Move platform specific plug-ins to platform/
https://bugs.webkit.org/show_bug.cgi?id=42506

Reviewed by Sam Weinig.

platform/gtk/Skipped:
platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Removed.
platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Removed.
platform/mac/plugins/call-as-function-test-expected.txt: Renamed from LayoutTests/plugins/call-as-function-test-expected.txt.
platform/mac/plugins/call-as-function-test.html: Renamed from LayoutTests/plugins/call-as-function-test.html.
platform/mac/plugins/jsobjc-dom-wrappers-expected.txt: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers-expected.txt.
platform/mac/plugins/jsobjc-dom-wrappers.html: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers.html.
platform/mac/plugins/jsobjc-simple-expected.txt: Renamed from LayoutTests/plugins/jsobjc-simple-expected.txt.
platform/mac/plugins/jsobjc-simple.html: Renamed from LayoutTests/plugins/jsobjc-simple.html.
platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Removed.
platform/mac/plugins/qt-qwidget-plugin-expected.png: Removed.
platform/mac/plugins/qt-qwidget-plugin-expected.txt: Removed.
platform/mac/plugins/root-object-premature-delete-crash-expected.txt: Renamed from LayoutTests/plugins/root-object-premature-delete-crash-expected.txt.
platform/mac/plugins/root-object-premature-delete-crash.html: Renamed from LayoutTests/plugins/root-object-premature-delete-crash.html.
platform/mac/plugins/throw-on-dealloc-expected.txt: Renamed from LayoutTests/plugins/throw-on-dealloc-expected.txt.
platform/mac/plugins/throw-on-dealloc.html: Renamed from LayoutTests/plugins/throw-on-dealloc.html.
platform/mac/plugins/undefined-property-crash-expected.txt: Renamed from LayoutTests/plugins/undefined-property-crash-expected.txt.
platform/mac/plugins/undefined-property-crash.html: Renamed from LayoutTests/plugins/undefined-property-crash.html.
platform/qt/Skipped:
platform/qt/plugins/qt-qwidget-plugin.html: Renamed from LayoutTests/plugins/qt-qwidget-plugin.html.
platform/win/Skipped:

2:44 PM Changeset in webkit [63615] by andersca@apple.com

2 edits in trunk/LayoutTests

[EFL] Unreviewed build system cleanup.

Patch by Leandro Pereira <leandro@profusion.mobi> on 2010-07-16
Remove reference to "mediaControlsGtk.css".

cmake/WebKitGenerators.cmake:

2:32 PM Changeset in webkit [63614] by andreas.kling@nokia.com

4 edits in trunk

2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

FillRect with shadow need take alpha information from fillstyle

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):

2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

Remove the following test case from Skipped:
canvas/philip/tests/2d.shadow.alpha.5.html
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.transparent.1.html
canvas/philip/tests/2d.shadow.image.scale.html
canvas/philip/tests/2d.shadow.pattern.alpha.html
canvas/philip/tests/2d.shadow.pattern.transparent.1.html

platform/qt/Skipped:

2:21 PM Changeset in webkit [63613] by andersca@apple.com

4 edits
34 moves
3 adds
1 delete in trunk/LayoutTests

Move NPRuntime related tests to plugins/npruntime
https://bugs.webkit.org/show_bug.cgi?id=42505

Reviewed by Dan Bernstein.

platform/gtk/Skipped:
platform/mac-snowleopard/Skipped:
platform/win/Skipped:

Update skipped lists.

plugins/netscape-identifier-conversion.html: Removed.
plugins/npruntime/bindings-test-expected.txt: Renamed from LayoutTests/plugins/bindings-test-expected.txt.
plugins/npruntime/bindings-test.html: Renamed from LayoutTests/plugins/bindings-test.html.
plugins/npruntime/browser-object-identity-expected.txt: Renamed from LayoutTests/plugins/netscape-browser-object-identity-expected.txt.
plugins/npruntime/browser-object-identity.html: Renamed from LayoutTests/plugins/netscape-browser-object-identity.html.
plugins/npruntime/construct-expected.txt: Renamed from LayoutTests/plugins/netscape-construct-expected.txt.
plugins/npruntime/construct.html: Renamed from LayoutTests/plugins/netscape-construct.html.
plugins/npruntime/embed-property-expected.txt: Renamed from LayoutTests/plugins/embed-property-expected.txt.
plugins/npruntime/embed-property.html: Renamed from LayoutTests/plugins/embed-property.html.
plugins/npruntime/enumerate-expected.txt: Renamed from LayoutTests/plugins/netscape-enumerate-expected.txt.
plugins/npruntime/enumerate.html: Renamed from LayoutTests/plugins/netscape-enumerate.html.
plugins/npruntime/get-int-identifier-special-values-expected.txt: Renamed from LayoutTests/plugins/getintidentifier-special-values-expected.txt.
plugins/npruntime/get-int-identifier-special-values.html: Renamed from LayoutTests/plugins/getintidentifier-special-values.html.
plugins/npruntime/get-property-return-value-expected.txt: Renamed from LayoutTests/plugins/netscape-get-property-return-value-expected.txt.
plugins/npruntime/get-property-return-value.html: Renamed from LayoutTests/plugins/netscape-get-property-return-value.html.
plugins/npruntime/identifier-conversion-expected.txt: Renamed from LayoutTests/plugins/netscape-identifier-conversion-expected.txt.
plugins/npruntime/identifier-conversion.html: Renamed from LayoutTests/plugins/netscape-identifier-conversion.html.
plugins/npruntime/invoke-browserfuncs-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs-expected.txt.
plugins/npruntime/invoke-browserfuncs.html: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs.html.
plugins/npruntime/invoke-default-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-default-expected.txt.
plugins/npruntime/invoke-default.html: Renamed from LayoutTests/plugins/netscape-invoke-default.html.
plugins/npruntime/invoke-expected.txt: Renamed from LayoutTests/plugins/invoke-expected.txt.
plugins/npruntime/invoke-failure-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-failure-expected.txt.
plugins/npruntime/invoke-failure.html: Renamed from LayoutTests/plugins/netscape-invoke-failure.html.
plugins/npruntime/invoke.html: Renamed from LayoutTests/plugins/invoke.html.
plugins/npruntime/npruntime-expected.txt: Renamed from LayoutTests/plugins/npruntime-expected.txt.
plugins/npruntime/npruntime.html: Renamed from LayoutTests/plugins/npruntime.html.
plugins/npruntime/round-trip-npobject-expected.txt: Renamed from LayoutTests/plugins/round-trip-npobject-expected.txt.
plugins/npruntime/round-trip-npobject.html: Renamed from LayoutTests/plugins/round-trip-npobject.html.
plugins/npruntime/script-tests/TEMPLATE.html: Renamed from LayoutTests/plugins/script-tests/TEMPLATE.html.
plugins/npruntime/script-tests/browser-object-identity.js: Renamed from LayoutTests/plugins/script-tests/netscape-browser-object-identity.js.

(description.gc):

plugins/npruntime/script-tests/identifier-conversion.js: Renamed from LayoutTests/plugins/script-tests/netscape-identifier-conversion.js.
plugins/npruntime/set-property-expected.txt: Renamed from LayoutTests/plugins/setProperty-expected.txt.
plugins/npruntime/set-property.html: Renamed from LayoutTests/plugins/setProperty.html.
plugins/npruntime/throw-exception-expected.txt: Renamed from LayoutTests/plugins/netscape-throw-exception-expected.txt.
plugins/npruntime/throw-exception.html: Renamed from LayoutTests/plugins/netscape-throw-exception.html.

1:47 PM Changeset in webkit [63612] by andersca@apple.com

4 edits in trunk/WebKit2

Stop all NPStreams before destroying a plug-in
https://bugs.webkit.org/show_bug.cgi?id=42504

Reviewed by Dan Bernstein.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):
Go through all streams and stop them.

(WebKit::NetscapePlugin::destroy):
Call stopAllStreams.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add stopAllStreams.

WebProcess/Plugins/Netscape/NetscapePluginStream.h:

Make stop public.

1:20 PM Changeset in webkit [63611] by andersca@apple.com

3 edits in trunk/WebKit2

Open streams should not keep a plug-in view alive
https://bugs.webkit.org/show_bug.cgi?id=42503

Reviewed by Dan Bernstein.

PluginView::Stream now has a weak reference to its PluginView.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::~Stream):
Assert that the plug-in view is null.

(WebKit::PluginView::Stream::didFail):
After calling removeStream, set the plug-in view member variable to 0. This is OK to do
since we keep a reference to the Stream, so we're sure that the call to removeStream does not
destroy the stream.

(WebKit::PluginView::Stream::didFinishLoading):
Ditto .

(WebKit::PluginView::~PluginView):
Cancel all streams.

(WebKit::PluginView::cancelAllStreams):
Cancel all streams.

11:11 AM Changeset in webkit [63610] by johnnyg@google.com