Timeline
Jul 19, 2010:
- 11:54 PM Changeset in webkit [63725] by
-
- 1 edit7 adds in trunk/LayoutTests
2010-07-19 Dirk Schulze <krit@webkit.org>
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Unreviewed update of Win baseline.
- platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
- platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/win/svg/custom/use-css-events-expected.txt: Added.
- platform/win/svg/dom: Added.
- platform/win/svg/dom/path-parser-expected.txt: Added.
- 11:41 PM Changeset in webkit [63724] by
-
- 5 edits in trunk/LayoutTests
2010-07-19 Dirk Schulze <krit@webkit.org>
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Unreviewed update of Qt baseline.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 11:28 PM Changeset in webkit [63723] by
-
- 7 edits2 adds in trunk
2010-07-19 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Added a simple implementation of VideoLayerChromium. Uses the
LayerChromium::updateTextureRect() to send video frames to the
GPU.
https://bugs.webkit.org/show_bug.cgi?id=42234
- WebCore.gypi: Added include for VideoLayerChromium.
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToMedia): Implemented setContentsToMedia, though it does not seem to trigger a repaint correctly.
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp: Added. (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents):
- platform/graphics/chromium/VideoLayerChromium.h: Added. (WebCore::VideoLayerChromium::drawsContent):
2010-07-19 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Updated WebMediaPlayer to support accelerated rendering and to
create and return a VideoChromiumLayer as its platform layer.
https://bugs.webkit.org/show_bug.cgi?id=42234
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::create):
- src/WebMediaPlayerClientImpl.h: (WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
- 11:23 PM Changeset in webkit [63722] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed test expectation fix.
fast/css/font-face-download-error.html should be skipped for Qt like
other @font-face tests.
https://bugs.webkit.org/show_bug.cgi?id=42342
- platform/qt/Skipped:
- 10:37 PM Changeset in webkit [63721] by
-
- 52 edits7 adds in trunk
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Added piOverTwo to MathExtras.
- wtf/MathExtras.h:
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Cleanup the parsing code for SVG Paths. Move classes out of the convoluted SVGParserUtilities.cpp
in their own files. Make use of WebCore specific objects in parsing code like FloatPoint, AffineTransform,
etc. instead of using home-brewn solutions.
The SVGPathParser parses a path data string and delivers the parsed segments and values to the SVGPathConsumer.
SVGPathConsumer is the base class for SVGPathBuilder and SVGPathSegListBuilder, that either build the platform
Path object or a SVGPathSegList out of the segments.
We're now directly parsing floats instead of truncating precision to float afterwards.
SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448
If one of the radii on the elliptic arc are zero, we should draw a line from the starting point to
the end point according to the spec. Fixed this bug with this patch, because an is zero check and
an DRT check was neccessary with the current clean-up.
Extended svg/dom/path-parser.xhml to check the correct behavior.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): Follow WebKit style and use multiple lines for the function. (WebCore::FloatPoint::scale): Scale FloatPoint. (WebCore::operator+=): (WebCore::operator+): Add two FloatPoints and give back the sum as FloatPoint.
- svg/SVGAllInOne.cpp: Added new created files.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): Use new PathParser to create a PathSegList.
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): Use new PathParser to create a Path.
- svg/SVGGlyphElement.cpp: (WebCore::parsePathData): Use new PathParser to create a Path.
- svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): Removed parseArcFlag(double&), we parse in float now.
- svg/SVGParserUtilities.h: Removed path parsing code and a lot of unneccessary includes.
- svg/SVGPathBuilder.cpp: Added. (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::build): Builds a normalized Path. (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
- svg/SVGPathBuilder.h: Added. We just create normalized Paths, so this functions should never be reached. (WebCore::SVGPathBuilder::lineToHorizontal): (WebCore::SVGPathBuilder::lineToVertical): (WebCore::SVGPathBuilder::curveToCubicSmooth): (WebCore::SVGPathBuilder::curveToQuadratic): (WebCore::SVGPathBuilder::curveToQuadraticSmooth): (WebCore::SVGPathBuilder::arcTo):
- svg/SVGPathConsumer.h: Added. Base class of SVGPathBuilder and SVGPathSegListBuilder. (WebCore::): (WebCore::SVGPathConsumer::SVGPathConsumer): (WebCore::SVGPathConsumer::~SVGPathConsumer):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute): Use new PathParser to create a PathSegList.
- svg/SVGPathParser.cpp: Added. (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::~SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataString): (WebCore::SVGPathParser::decomposeArcToCubic): Normalizes an arc to multiple cubic curves.
- svg/SVGPathParser.h: Added.
- svg/SVGPathSegListBuilder.cpp: Added. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::build): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
- svg/SVGPathSegListBuilder.h: Added.
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Parsing values as float instead of double causes some minimal changes on DRT results and
pixel results. Even if the values get shrinked to float before the calculation of arc and
others. But the calculation itself transforms the values back to double and shrinks it to
floats again right before the drawing.
SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448
Extended svg/dom/path-parser.xhml to check the correct behavior. We draw a line from the
current point to the given end point.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/mac/svg/custom/use-css-events-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/hixie/perf/007-expected.checksum:
- platform/mac/svg/hixie/perf/007-expected.png:
- platform/mac/svg/hixie/perf/007-expected.txt:
- svg/custom/path-getTotalLength-expected.txt:
- svg/dom/path-parser-expected.txt:
- svg/dom/script-tests/path-parser.js:
- 10:28 PM Changeset in webkit [63720] by
-
- 3 edits in trunk/LayoutTests
Unreviewed trivial fix after r63684.
https://bugs.webkit.org/show_bug.cgi?id=30464
- fast/dom/Window/window-properties-expected.txt: Updated.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- 10:10 PM Changeset in webkit [63719] by
-
- 4 edits2 adds in trunk
2010-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342
- fast/css/font-face-download-error-expected.txt: Added.
- fast/css/font-face-download-error.html: Added.
2010-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342
Test: fast/css/font-face-download-error.html
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::isValid): Valid if at least one font face is valid. (WebCore::CSSSegmentedFontFace::getFontData): Check validity for each font face.
- css/CSSSegmentedFontFace.h: Make isValid private.
- 9:33 PM Changeset in webkit [63718] by
-
- 2 edits in trunk/WebCore
2010-07-19 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42568
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::systemFontSize): (WebCore::pointsToPixels): (WebCore::querySystemBlinkInterval): (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
- 9:32 PM Changeset in webkit [63717] by
-
- 2 edits in trunk/WebCore
(Hopefully the last) Windows build fix.
Version of CoreServices.h in WebKit Support Libraries uses
pragma once, unlike the version I have locally. Switch based
on COLORSYNCDEPRECATED instead.
- WebCorePrefix.h:
- 9:17 PM Changeset in webkit [63716] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- WebCorePrefix.h:
- 9:09 PM Changeset in webkit [63715] by
-
- 2 edits in trunk/LayoutTests
Remove now passing tests from the skipped list.
Reviewed by Maciej Stachowiak.
- platform/mac-wk2/Skipped:
- 9:05 PM Changeset in webkit [63714] by
-
- 2 edits in trunk/WebKitTools
Fix build.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Paths of generated files should be relative to the build product.
- 8:42 PM Changeset in webkit [63713] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-19 Mike Moretti <mike.moretti@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] Build fix after r63404.
Implement isValid() function for the Symbian executable allocator.
- jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::isValid):
- 8:24 PM Changeset in webkit [63712] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCorePrefix.h:
- 8:14 PM Changeset in webkit [63711] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCorePrefix.h:
- 8:01 PM Changeset in webkit [63710] by
-
- 12 edits in trunk
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements support for markerTextForListItem in the Windows port.
- DOMCoreClasses.cpp: (DOMElement::markerTextForListItem): Added.
- DOMCoreClasses.h:
- Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
- Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
- Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
- WebView.cpp: (WebView::elementFromJS): Added.
- WebView.h:
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Remove skipped layout tests now that we have DRT support.
- platform/win/Skipped:
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements DRT support for markerTextForListItem in the Windows port.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::markerTextForListItem): Implemented.
- 8:00 PM Changeset in webkit [63709] by
-
- 7 edits in trunk/WebCore
Windows Build fixes for new ColorSync API.
We support both new and old APIs, since the newer headers aren't in the tree yet.
- WebCorePrefix.h: Removed include of CoreServices.h. Included via ColorSyncPriv.h instead, since header may not be present.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::createCGColor): Conditionally use new ColorSync API.
- platform/graphics/opentype/OpenTypeUtilities.cpp: Define Fixed if CoreServices.h doesn't.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::updateLayerDrawsContent): Use 0 instead of nil, since nil is no longer present via CoreServices.h.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Include AssertMacros.h.
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::operator CFErrorRef): Use 0 instead of nil, since nil is no longer present via CoreServices.h.
- 7:40 PM Changeset in webkit [63708] by
-
- 3 edits2 adds in trunk/WebKit2
WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
https://bugs.webkit.org/show_bug.cgi?id=42356
Reviewed by Sam Weinig.
Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
Call setMachPortQueueLength.
- Platform/mac/MachUtilities.cpp: Added.
(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.
- Platform/mac/MachUtilities.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add MachUtilities.cpp and MachUtilities.h
- 7:37 PM Changeset in webkit [63707] by
-
- 2 edits in trunk/WebCore
2010-07-19 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Dimitri Glazkov.
Only set unloadEventEnd when the unload event is actually fired
https://bugs.webkit.org/show_bug.cgi?id=42607
r63689 introduced this ASSERT and it began failing on Qt and Mac debug.
For some reason, it did not fail on Windows (which is where I was
testing). The ASSERT was disabled in r63699.
Test: page-cache related layout tests don't crash in debug mode on Mac.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 7:03 PM Changeset in webkit [63706] by
-
- 2 edits in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
https://bugs.webkit.org/show_bug.cgi?id=42513
Avoid making unnecessary deep-copies of QPainterPaths that will
be discarded after use.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- 6:44 PM Changeset in webkit [63705] by
-
- 4 edits in trunk
2010-07-19 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719
Fixed compiler warning introduced by original patch.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2010-07-19 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719
Fixed compiler warning introduced by original patch. No new tests;
covered by existing tests.
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- 6:19 PM Changeset in webkit [63704] by
-
- 10 edits in trunk
Handle NP_ASFILE and NP_ASFILEONLY transfer modes
https://bugs.webkit.org/show_bug.cgi?id=42587
Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.
WebCore:
- WebCore.exp.in:
Export functions from FileSystem.h
- platform/mac/FileSystemMac.mm:
(WebCore::openTemporaryFile):
Try to create a temporary file using mkstemp.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_StreamAsFile):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add NPP_ wrapper.
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_fileHandle.
(WebKit::isSupportedTransferMode):
NP_ASFILE and NP_ASFILEONLY is now supported.
(WebKit::NetscapePluginStream::deliverData):
Call deliverDataToFile if necessary.
(WebKit::NetscapePluginStream::deliverDataToFile):
Create a temporary file and write the data into it.
(WebKit::NetscapePluginStream::stop):
If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to
call NPP_StreamAsFile and close the file and delete it.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cancelStreamLoad):
Keep a reference to the Stream since cancelling it will remove it from the map.
- 6:01 PM Changeset in webkit [63703] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
- WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeTestPluginPath):
- 5:25 PM Changeset in webkit [63702] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update one more expected result missed in r63684.
- platform/mac-leopard/accessibility/media-element-expected.txt:
- 5:07 PM Changeset in webkit [63701] by
-
- 9 edits in trunk
Implement NPN_PostURLNotify
https://bugs.webkit.org/show_bug.cgi?id=42602
Reviewed by Sam Weinig.
WebCore:
Export symbols needed by WebKit2.
- WebCore.exp.in:
WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
Read the buffer from a file if necessary and parse it.
(WebKit::NPN_GetURLNotify):
Add extra arguments.
(WebKit::NPN_PostURLNotify):
Parse the post buffer, then call NetscapePlugin::loadURL.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
Pass the method, the header fields and form data along.
(WebKit::NetscapePlugin::allowPopups):
Just return false for now.
(WebKit::NetscapePlugin::initialize):
Pass extra arguments to loadURL.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PluginController.h:
Add method, header fields and form data.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
Set the method, add the header fields and set the body.
- 4:55 PM Changeset in webkit [63700] by
-
- 6 edits in trunk/WebKitTools
Remove dependency on getopt from WebKitTestRunner.
Reviewed by Jon Honeycutt.
- Simplify options parsing and eliminate unused options.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
- WebKitTestRunner/TestController.h:
(WTR::TestController::testPluginPath):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
- 4:54 PM Changeset in webkit [63699] by
-
- 2 edits in trunk/WebCore
2010-07-19 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Remove overzealous ASSERT from r63689
https://bugs.webkit.org/show_bug.cgi?id=42606
No new tests because no new functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 4:36 PM Changeset in webkit [63698] by
-
- 3 edits in trunk/WebKitTools
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
[Qt] MiniBrowser: Progress indication at address bar
https://bugs.webkit.org/show_bug.cgi?id=42565
Reviewed by Antonio Gomes.
Make possible to see load progress at address bar based on
QtTestBrowser solution
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadProgress):
- MiniBrowser/qt/BrowserWindow.h:
- 4:35 PM Changeset in webkit [63697] by
-
- 3 edits in trunk/WebKitTools
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
https://bugs.webkit.org/show_bug.cgi?id=42564
Reviewed by Antonio Gomes.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserView::load): (BrowserWindow::BrowserWindow): (BrowserWindow::titleChanged): (BrowserWindow::urlChanged):
- MiniBrowser/qt/BrowserWindow.h:
- 4:19 PM Changeset in webkit [63696] by
-
- 2 edits in trunk/WebCore
2010-07-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Mark Rowe.
Web Inspector: Do Not Copy *.re2js Inspector Resources in XCode Build Phase
https://bugs.webkit.org/show_bug.cgi?id=42601
Remove *.re2js files after copying them over in the Build Phase. We do
the same to remove the WebKit.qrc file.
- WebCore.xcodeproj/project.pbxproj:
- 3:38 PM Changeset in webkit [63695] by
-
- 4 edits in branches/safari-533.17-branch/WebCore
Revert r63029 to address <rdar://problem/8202667>.
- 3:38 PM Changeset in webkit [63694] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Revert r63030 to address <rdar://problem/8202667>.
- 3:23 PM Changeset in webkit [63693] by
-
- 8 edits10 adds in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
Reviewed by Adam Roben.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Added.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
- WebKitTestRunner/InjectedBundle/Bindings: Added.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
- WebKitTestRunner/win/build-generated-files.sh: Added.
- 3:21 PM Changeset in webkit [63692] by
-
- 6 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed.
[chromium] Update test expectations after r63681.
Add new expected results for the clearly correct cases after r63684.
- platform/chromium-mac/media/video-load-networkState-expected.txt:
- platform/chromium-mac/media/video-src-change-expected.txt:
- platform/chromium-win/media/video-load-networkState-expected.txt:
- platform/chromium-win/media/video-src-change-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:16 PM Changeset in webkit [63691] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update more tests/results missed in r63684.
- accessibility/media-element.html:
- media/unsupported-rtsp-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- 2:58 PM Changeset in webkit [63690] by
-
- 2 edits in trunk/WebKitTools
Clean up the buildbot configuration a little.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 2:55 PM Changeset in webkit [63689] by
-
- 16 edits3 adds in trunk
2010-07-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512
- fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document. (checkTimingNotChanged): (): (loadHandler):
- fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
- fast/dom/webtiming-navigate-within-document-expected.txt: Added.
- fast/dom/webtiming-navigate-within-document.html: Added.
- platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.
2010-07-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512
Test: fast/dom/webtiming-navigate-within-document.html
- loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader. (WebCore::DocumentLoader::documentLoadTiming):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up. (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document. (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
- loader/FrameLoader.h: Get rid of FrameLoadTimeline.
- loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable. (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
- page/Navigation.cpp: (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
- page/Timing.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks. (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::redirectStart): (WebCore::Timing::redirectEnd): (WebCore::Timing::fetchStart): (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart): (WebCore::Timing::responseEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd): (WebCore::Timing::documentLoader): (WebCore::Timing::documentLoadTiming): (WebCore::Timing::resourceLoadTiming): (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
- page/Timing.h:
- 2:18 PM Changeset in webkit [63688] by
-
- 8 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.
LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.
- 2:05 PM Changeset in webkit [63687] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Simon Fraser <Simon Fraser>
Reviewed by Brady Eidson.
Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591
Hook up various loading notifications to update the URL bar in MiniBrowser.
- MiniBrowser/mac/BrowserWindowController.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): (-[BrowserWindowController didStartProvisionalLoadForFrame:]): (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): (-[BrowserWindowController didFailLoadWithErrorForFrame:]): (-[BrowserWindowController didCommitLoadForFrame:]):
- 1:53 PM Changeset in webkit [63686] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update tests/results missed in r63684.
- media/video-error-does-not-exist-expected.txt:
- media/video-load-networkState-expected.txt:
- media/video-load-networkState.html:
- 1:38 PM Changeset in webkit [63685] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree
Updating test results.
- platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: There are custom results for Tiger, adding new printout to it, as well.
- platform/gtk/http/tests/misc: Added.
- platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
- platform/gtk/http/tests/xmlhttprequest: Added.
- platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
- platform/qt/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt. These platforms don't seem to have auth delegate calls, so we can't log auth dialogs.
- 1:11 PM Changeset in webkit [63684] by
-
- 19 edits in trunk
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_completelyLoaded. (WebCore::HTMLMediaElement::parseMappedAttribute): Don't deal with 'load' event. (WebCore::HTMLMediaElement::prepareForLoad): Set m_completelyLoaded to false. (WebCore::HTMLMediaElement::setNetworkState): Don't post 'load' event. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if m_networkState != NETWORK_LOADING. (WebCore::HTMLMediaElement::userCancelledLoad): No more NETWORK_LOADED state.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
- html/HTMLMediaElement.idl: Remove NETWORK_LOADING.
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>
- media/audio-delete-while-slider-thumb-clicked.html: Trigger test on 'canplaythrough' instead of 'load'.
- media/audio-delete-while-step-button-clicked.html: Ditto.
- media/event-attributes-expected.txt:
- media/event-attributes.html: Correct logic to check that 'progress' event(s) are fired while loading file, but not when src set to invalid file. 'abort' event is fired when the src is changed.
- media/invalid-media-url-crash-expected.txt:
- media/media-constants-expected.txt: No more NETWORK_LOADED state.
- media/media-constants.html: No more NETWORK_LOADED state. Clean up test.
- media/remove-from-document-expected.txt:
- media/remove-from-document.html: Ditto.
- media/video-controls-visible-audio-only.html: Trigger test on 'canplaythrough' instead of 'load'.
- media/video-source-none-supported-expected.txt: No more NETWORK_LOADED state.
- media/video-src-change-expected.txt: Ditto.
- media/video-src-none-expected.txt:
- media/video-src-none.html: No more NETWORK_LOADED state. Fix bogus test that generated "FAIL" in results.
- 1:08 PM Changeset in webkit [63683] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed.
[chromium] Update test_expectations with passing/flaky tests.
Add new chromium expected result from r63680.
- platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:08 PM Changeset in webkit [63682] by
-
- 8 edits in trunk/WebKit2
Add local storage support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42584
Reviewed by Darin Adler.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::swap):
- Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLocalStorageEnabled):
(WKPreferencesGetLocalStorageEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setLocalStorageEnabled):
(WebKit::WebPreferences::localStorageEnabled):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):
- 1:03 PM Changeset in webkit [63681] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" case.
- 11:46 AM Changeset in webkit [63680] by
-
- 9 edits5 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=40996
Progress event should not be fired during synchronous XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=17502
Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange
Tests: http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html
http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): We now only dispatch readystatechange event for synchronous requests in states UNSENT, OPENED and DONE. I'm not sure what exactly the spec draft says about readystatechange for sync requests, but this seems to be the most logical and backwards compatible behavior. (WebCore::XMLHttpRequest::didReceiveData): Don't dispatch progress events for sync requests. Note that we already don't dispatch upload progress events for those.
- 11:09 AM Changeset in webkit [63679] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
- platform/qt/Skipped: Add tests again until fix which were unskipped by r63657.
- 10:45 AM Changeset in webkit [63678] by
-
- 6 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed. Update expectations from http://trac.webkit.org/changeset/63672
and cleanup some unexpected passes.
- platform/chromium-linux/fast/forms/hidden-listbox-expected.checksum:
- platform/chromium-linux/fast/forms/hidden-listbox-expected.png:
- platform/chromium-win/fast/forms/hidden-listbox-expected.checksum:
- platform/chromium-win/fast/forms/hidden-listbox-expected.png:
- platform/chromium/test_expectations.txt:
- 10:34 AM Changeset in webkit [63677] by
-
- 2 edits in trunk/WebKit2
2010-07-19 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Uae an OwnPtr for the drawing area in WebPage (fixes a leak!).
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::drawingArea):
- 10:26 AM Changeset in webkit [63676] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] refactor npapi plugin copy step
https://bugs.webkit.org/show_bug.cgi?id=42493
This is to avoid duplicate copy rules in the Linux make build.
- WebKit.gyp:
- DEPS: 52483:52869
- 10:19 AM Changeset in webkit [63675] by
-
- 3 edits in trunk/JavaScriptCore
2010-07-16 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Use OwnPtr for CodeBlock objects
https://bugs.webkit.org/show_bug.cgi?id=42490
- runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): Moved this here and made it non-inline. Eliminated the code that used to initialize the raw pointer since it's now an OwnPtr. (JSC::EvalExecutable::~EvalExecutable): Removed the explicit delete here. (JSC::ProgramExecutable::ProgramExecutable): Ditto. (JSC::ProgramExecutable::~ProgramExecutable): Ditto. (JSC::FunctionExecutable::FunctionExecutable): Ditto. (JSC::FunctionExecutable::~FunctionExecutable): Ditto. (JSC::EvalExecutable::compileInternal): Added use of adoptPtr and get. (JSC::ProgramExecutable::compileInternal): Ditto. (JSC::FunctionExecutable::compileForCallInternal): Ditto. (JSC::FunctionExecutable::compileForConstructInternal): Ditto. (JSC::FunctionExecutable::recompile): Use clear instead of delete followed by assignment of 0.
- runtime/Executable.h: Moved constructors to the cpp file and changed raw pointers to OwnPtr.
- 10:18 AM Changeset in webkit [63674] by
-
- 7 edits3 deletes in trunk/WebKitTools
2010-07-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63671.
http://trac.webkit.org/changeset/63671
https://bugs.webkit.org/show_bug.cgi?id=42575
broke windows (Requested by weinig on #webkit).
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Removed.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setWaitToDump): (WTR::displayCallback): (WTR::dumpAsTextCallback): (WTR::dumpStatusCallbacksCallback): (WTR::waitUntilDoneCallback): (WTR::notifyDoneCallback): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::repaintSweepHorizontallyCallback): (WTR::testRepaintCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): (WTR::LayoutTestController::dumpStatusCallbacks): (WTR::LayoutTestController::setDumpStatusCallbacks): (WTR::LayoutTestController::setTestRepaint): (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 10:13 AM Changeset in webkit [63673] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix eol-style propety for the following file, otherwise svn-apply will fail.
https://bugs.webkit.org/show_bug.cgi?id=42573
- canvas/philip/tests.js: Added property svn:eol-style.
- 9:48 AM Changeset in webkit [63672] by
-
- 4 edits8 adds in trunk
<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
https://bugs.webkit.org/show_bug.cgi?id=34913
Reviewed by Simon Fraser.
WebCore:
Tests: fast/repaint/view-background-from-body-1.html
fast/repaint/view-background-from-body-2.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.
LayoutTests:
- fast/repaint/view-background-from-body-1.html: Added.
- fast/repaint/view-background-from-body-2.html: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
- 9:43 AM Changeset in webkit [63671] by
-
- 7 edits8 adds in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
Reviewed by Adam Roben.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Added.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
- WebKitTestRunner/InjectedBundle/Bindings: Added.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 9:39 AM Changeset in webkit [63670] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
fix chromium linux compile on ubuntu maverick
https://bugs.webkit.org/show_bug.cgi?id=42528
- Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
- 9:23 AM Changeset in webkit [63669] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-19 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Live edit is not working in chromium.
https://bugs.webkit.org/show_bug.cgi?id=42572
- src/js/DebuggerScript.js:
- 9:21 AM Changeset in webkit [63668] by
-
- 4 edits in trunk/WebKitTools
When dumping a response's MIME type, print its URL's last path component rather than its suitable-for-test-result form
This matches the Mac behavior.
Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows
Reviewed by Anders Carlsson.
- DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.
- 9:21 AM Changeset in webkit [63667] by
-
- 2 edits in trunk/WebCore
Fix an assertion when a plugin returns -1 from NPP_Write
We were forgetting to call setDefersLoading(false) before destroying
the PluginStream. In the process of destroying the stream, someone
would call setDefersLoading(true), and we would assert because we were
already deferring loads.
Fixes <http://webkit.org/b/42563> Assertion failure in
ResourceHandle::setDefersLoading when running
plugins/return-negative-one-from-write.html on Windows
Reviewed by Anders Carlsson.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::deliverData): Call setDefersLoading(false)
before destroying the stream, to match the setDefersLoading(true) call
earlier in this function. (We already call setDefersLoading(false) in
the non-error case later on.)
- 9:06 AM Changeset in webkit [63666] by
-
- 2 edits in trunk/WebCore
2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Fix some EFL theme issues
https://bugs.webkit.org/show_bug.cgi?id=42569
Keep a pointer to theme filename and check for it correctly.
Reduce the scope of some variables.
Don't test for platformWidget() since we are not using it.
No new tests, no new functionality.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyCursor): (WebCore::Widget::setCursor):
- 8:52 AM Changeset in webkit [63665] by
-
- 2 edits in trunk/WebCore
2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add ifdef to compile code just on presence of Ecore_X
https://bugs.webkit.org/show_bug.cgi?id=42567
No new tests since there's no new functionality.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::setEvasObject): Add #ifdef HAVE_ECORE_X to it.
- 8:29 AM Changeset in webkit [63664] by
-
- 19 edits2 copies in trunk
WebKit2 does not have application cache
https://bugs.webkit.org/show_bug.cgi?id=42552
Reviewed by Adam Roben.
WebKit2:
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add SetApplicationCacheDirectory.
- Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
add offlineWebApplicationCacheEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetOfflineWebApplicationCacheEnabled):
(WKPreferencesGetOfflineWebApplicationCacheEnabled):
- UIProcess/API/C/WKPreferences.h:
Add getters/setters for whether the application cache is enabled.
- UIProcess/WebContext.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setOfflineWebApplicationCacheEnabled):
Update the store and call update().
- UIProcess/WebPreferences.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
Ask the web process to set the application cache directory.
- UIProcess/mac/WebContextMac.mm: Added.
(WebKit::WebContext::applicationCacheDirectory):
Return the application cache directory.
- UIProcess/win/WebContextWin.cpp: Added.
(WebKit::WebContext::applicationCacheDirectory):
Ditto.
- WebKit2.xcodeproj/project.pbxproj:
Add WebContextMac.mm
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
(WebKit::WebPage::didReceiveMessage):
Handle PreferencesDidChange. Get rid of the default: case statement so we'll
get warnings if we have unhandled message kinds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setApplicationCacheDirectory):
Set the application cache directory.
(WebKit::WebProcess::didReceiveMessage):
Handle SetApplicationCacheDirectory.
win/WebKit2.vcproj:
Add WebContextWin.cpp
WebKitTools:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.
(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.
- WebKitTestRunner/TestInvocation.h:
LayoutTests:
- platform/mac-wk2/Skipped:
Remove http/tests/appcache from skipped list.
- 8:23 AM Changeset in webkit [63663] by
-
- 5 edits in trunk
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[chromium] inspector/console-trace.html failing on windows after r63548
https://bugs.webkit.org/show_bug.cgi?id=42485
- inspector/console-trace.html: call dumpConsoleMessages sycnhronously right after console.trace
- platform/chromium/test_expectations.txt:
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add/removeStyleClass shouldn't increase number of spaces between class names.
https://bugs.webkit.org/show_bug.cgi?id=42485
- inspector/front-end/utilities.js: (Element.prototype.removeStyleClass):
- 8:19 AM Changeset in webkit [63662] by
-
- 15 edits in trunk/WebCore
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show stack trace for uncaught exceptions when Web Inspector is open.
https://bugs.webkit.org/show_bug.cgi?id=42560
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/v8/ScriptController.h:
- bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
- bindings/v8/V8ConsoleMessage.h:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype.toString):
- inspector/front-end/inspector.css: (.console-message.repeated-message > ol.stack-trace): (.section .properties ol, .event-properties ol, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.section .properties ol.expanded, .event-properties ol.expanded, .stack-trace ol, ol.stack-trace):
- page/Console.cpp: (WebCore::Console::addMessage):
- page/Console.h: (WebCore::):
- 8:12 AM Changeset in webkit [63661] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Roben.
Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Specifying python explicitly.
- 8:05 AM Changeset in webkit [63660] by
-
- 2 edits in trunk/WebCore
2010-07-19 Robin Burchell <robin.burchell@collabora.co.uk>
Reviewed by Antonio Gomes
[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.
Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: https://bugs.webkit.org/show_bug.cgi?id=42392
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
- 7:52 AM Changeset in webkit [63659] by
-
- 4 edits in trunk/WebCore
2010-07-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check
https://bugs.webkit.org/show_bug.cgi?id=42284
New name is isEquivalentColor(CanvasStyle).
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle):
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
- html/canvas/CanvasStyle.h:
- 7:50 AM Changeset in webkit [63658] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Remove non-existent files from Skipped list.
- platform/qt/Skipped:
- Unskip fast/dynamic/flash-replacement-test.html, because it was removed by r61289
- Rename fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2.html after r63284
- Unskip inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r63314
- Unskip media/video-src-empty.html, because it was removed by r63119
- 7:27 AM Changeset in webkit [63657] by
-
- 5 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510
Unskip:
- canvas/philip/tests/2d.shadow.canvas.alpha.html
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- canvas/philip/tests/2d.shadow.canvas.transparent.2.html
- canvas/philip/tests/2d.shadow.image.alpha.html
- canvas/philip/tests/2d.shadow.image.transparent.1.html
- canvas/philip/tests/2d.shadow.image.transparent.2.html
- platform/qt/Skipped:
- 7:24 AM Changeset in webkit [63656] by
-
- 4 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508
Unskip:
- canvas/philip/tests/2d.shadow.canvas.basic.html
Reskip (bug now exposed):
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- platform/qt/Skipped:
- 7:12 AM Changeset in webkit [63655] by
-
- 1 edit45 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add platform specific expected results for new passing SVG tests.
Compared to Mac png files and Mac expected files.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
- platform/qt/svg/custom/convolution-crash-expected.checksum: Added.
- platform/qt/svg/custom/convolution-crash-expected.png: Added.
- platform/qt/svg/custom/convolution-crash-expected.txt: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.checksum: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.png: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt.
- platform/qt/svg/custom/recursive-gradient-expected.checksum: Added.
- platform/qt/svg/custom/recursive-gradient-expected.png: Added.
- platform/qt/svg/custom/recursive-gradient-expected.txt: Added.
- platform/qt/svg/custom/recursive-mask-expected.checksum: Added.
- platform/qt/svg/custom/recursive-mask-expected.png: Added.
- platform/qt/svg/custom/recursive-mask-expected.txt: Added.
- platform/qt/svg/custom/recursive-pattern-expected.checksum: Added.
- platform/qt/svg/custom/recursive-pattern-expected.png: Added.
- platform/qt/svg/custom/recursive-pattern-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.png: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.png: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.checksum: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.png: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.txt: Added.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.checksum.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt.
- platform/qt/svg/filters/filter-empty-g-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.checksum.
- platform/qt/svg/filters/filter-empty-g-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
- platform/qt/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
- platform/qt/svg/filters/filter-width-update-expected.checksum: Added.
- platform/qt/svg/filters/filter-width-update-expected.png: Added.
- platform/qt/svg/filters/filter-width-update-expected.txt: Added.
- 7:08 AM Changeset in webkit [63654] by
-
- 4 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973
Remove erroneous optimization that ignored painting calls when
the stroke/fill color had an alpha value of zero.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973
Unskip fast/canvas/canvas-composite-alpha.html
- platform/qt/Skipped:
- 7:06 AM Changeset in webkit [63653] by
-
- 3 edits1 add in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
CSS3 background: Number of layers should be determined by background-image element count
https://bugs.webkit.org/show_bug.cgi?id=41201
Manual test: css3-background-layer-count.html
- manual-tests/css3-background-layer-count.html: Added.
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): Don't repeat image properties, they determine the total number of layers. (WebCore::FillLayer::cullEmptyLayers): Change culling logic to discard all layers after the first one without an image set.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): Call fillUnsetProperties() before cullEmptyLayers() (WebCore::InheritedFlags::adjustMaskLayers): Ditto.
- 5:45 AM Changeset in webkit [63652] by
-
- 2 edits in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid QImage::pixel() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=42463
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Use QImage::scanLine() instead of fetching data pixel-by-pixel.
- 5:43 AM Changeset in webkit [63651] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-19 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix build on 64-bit systems. According to
JavaScriptCore/wtf/Platform.h, x86_64 uses fixed allocator, which
needs jit/ExecutableAllocatorFixedVMPool.cpp to be included in build
system.
https://bugs.webkit.org/show_bug.cgi?id=42559
- CMakeListsEfl.txt: add missing file for x86_64.
- 5:28 AM Changeset in webkit [63650] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] Fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=42556
text-rotated-gradient.svg is flaky on linux, and clip-path-child-changes.svg
isn't actually flaky.
- platform/chromium/test_expectations.txt:
- 5:17 AM Changeset in webkit [63649] by
-
- 2 edits in trunk/WebCore
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: hide "toggle debugger" button when debugger is always enabled
https://bugs.webkit.org/show_bug.cgi?id=42558
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- 4:52 AM Changeset in webkit [63648] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-07-19 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
Remove chromium rebaselines for document.all layout test.
https://bugs.webkit.org/show_bug.cgi?id=42557
V8 changed behavior to match JSC completely on document.all. Remove
chromium rebaseline.
- platform/chromium-mac/fast/dom/undetectable-document-all-expected.txt: Removed.
- platform/chromium-win/fast/dom/undetectable-document-all-expected.txt: Removed.
- 3:54 AM Changeset in webkit [63647] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Kent Hansen <kent.hansen@nokia.com>
Unreviewed, fix failure introduced in r63645.
Ignore jscprint property since it only appears in
debug builds (as per window-property-descriptors test).
- fast/dom/Window/window-properties.html:
- 2:40 AM Changeset in webkit [63646] by
-
- 3 edits in trunk/WebCore
2010-07-19 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
https://bugs.webkit.org/show_bug.cgi?id=42466
(Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447)
No new functionality so no new tests.
- dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Move here to avoid needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h.
- dom/DeviceOrientationEvent.h:
- 1:23 AM Changeset in webkit [63645] by
-
- 5 edits in trunk/LayoutTests
2010-07-19 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Sam Weinig.
Improve coverage of fast/dom/Window/window-properties test
https://bugs.webkit.org/show_bug.cgi?id=42258
Use Object.getOwnPropertyNames to cover ECMA properties
and other native properties.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
Jul 18, 2010:
- 10:39 PM Changeset in webkit [63644] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Add more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42551
- platform/mac-wk2/Skipped:
- 10:16 PM Changeset in webkit [63643] by
-
- 2 edits in trunk/WebCore
Fix Build.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
- 9:51 PM Changeset in webkit [63642] by
-
- 2 edits in trunk/WebCore
Always set the current NSGraphicsContext before calling drawWithFrame
https://bugs.webkit.org/show_bug.cgi?id=42542
Reviewed by Dan Bernstein.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- 8:49 PM Changeset in webkit [63641] by
-
- 2 edits in trunk/WebKit/qt
2010-07-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebPage fails cursorMovements and textSelection
https://bugs.webkit.org/show_bug.cgi?id=42531
Correct the HTML used by these tests.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::textEditing):
- 6:10 PM Changeset in webkit [63640] by
-
- 2 edits in trunk/WebKit2
Another attempt at fixing the Windows build.
- WebProcess/Plugins/NPJSObjectMap.h:
- 5:13 PM Changeset in webkit [63639] by
-
- 2 edits in trunk/WebKit2
Try to fix Windows build.
- win/WebKit2.vcproj:
- 5:11 PM WebKit Team edited by
- (diff)
- 5:09 PM Changeset in webkit [63638] by
-
- 10 edits1 move1 delete in trunk
Move PluginWidget to WebKit
https://bugs.webkit.org/show_bug.cgi?id=42530
Reviewed by Sam Weinig.
WebCore:
Rename the PluginWidget class to PluginViewBase and make it an abstract base class.
This is a stopgap measure until we have a single PluginView class that we can use everywhere.
- WebCore.exp.in:
Remove PluginWidget symbols.
- WebCore.xcodeproj/project.pbxproj:
Update.
- platform/Widget.h:
(WebCore::Widget::isPluginViewBase):
Return false.
- plugins/PluginViewBase.h: Added.
(WebCore::PluginViewBase::platformLayer):
Always return 0 here now.
(WebCore::PluginViewBase::isPluginViewBase):
Return true.
- plugins/PluginWidget.h: Removed.
- plugins/mac/PluginWidgetMac.mm: Removed.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
Cast to PluginWidgetBase instead.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Cast to PluginWidgetBase instead.
WebKit/mac:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView pluginLayer]):
Add default pluginLayer implementation.
- WebCoreSupport/WebFrameLoaderClient.mm:
(PluginWidget::PluginWidget):
(PluginWidget::invalidateRect):
Move the guts of PluginWidget here from WebCore.
(NetscapePluginWidget::platformLayer):
Get the layer from the plug-in view.
- 4:45 PM WebKit Team edited by
- (diff)
- 3:55 PM Changeset in webkit [63637] by
-
- 2 edits in trunk/WebKit/qt
2010-07-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527
Correct the HTML used by these tests.
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::firstChildNextSibling): (tst_QWebElement::lastChildPreviousSibling):
- 3:27 PM Changeset in webkit [63636] by
-
- 5 edits in trunk/WebKit2
More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526
Reviewed by Sam Weinig.
- WebProcess/Plugins/NPJSObjectMap.cpp:
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
Check if the JSObject has the given property.
(WebKit::NPJSObject::getProperty):
Add stubbed out function.
(WebKit::NPJSObject::npClass):
Add NP_HasProperty and NP_GetProperty.
(WebKit::NPJSObject::NP_HasProperty):
Call NPJSObject::hasProperty.
(WebKit::NPJSObject::NP_GetProperty):
Call NPJSObject::getProperty.
- WebProcess/Plugins/NPRuntimeUtilities.cpp:
(WebKit::releaseNPVariantValue):
Release the given NPVariant.
- WebProcess/Plugins/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetProperty):
Call the NPClass GetProperty function.
(WebKit::NPN_HasProperty):
Call the NPClass HasProperty function.
(WebKit::NPN_ReleaseVariantValue):
Call releaseNPVariantValue.
- 3:25 PM Changeset in webkit [63635] by
-
- 3 edits in trunk/LayoutTests
2010-07-18 Dean Jackson <dino@apple.com>
Unreviewed (although this was discussed with SimonF in
original review).
Unfortunately the test in the previous commit is platform
specific (I was hoping it would not be) and is failing
the bots. This update exercises the same thing, but doesn't
check for exact values.
- fast/transforms/scrollIntoView-transformed-expected.txt:
- fast/transforms/scrollIntoView-transformed.html:
- 3:01 PM Changeset in webkit [63634] by
-
- 2 edits in trunk/WebCore
2010-07-18 Dean Jackson <dino@apple.com>
Unreviewed.
Remove the unwanted extra line that Xcode
added in my last commit.
- WebCore.xcodeproj/project.pbxproj:
- 2:55 PM Changeset in webkit [63633] by
-
- 5 edits2 adds in trunk
2010-07-18 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=41259
Interacting with a <select> element within a transformed and clipped
container scrolls the container
The Node::getRect and ContainerNode::getRect functions were not
transform-aware. This fixes both, and has a test to make sure
we're not breaking any existing scrollToView code. This means
that a <select> popup will appear in the correct place if it
is within a transformed and scrolled container.
The test makes sure that existing scrollToView
code doesn't break, but also checks that a <select> popup will appear
in the correct place.
Test: fast/transforms/scrollIntoView-transformed.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms.
- dom/Node.cpp: (WebCore::Node::getRect):
- make sure localToAbsolute gets told to look for transforms.
- 2:38 PM Changeset in webkit [63632] by
-
- 7 edits in trunk/WebKit/mac
<http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
Reviewed by Dan Bernstein.
- Carbon/CarbonWindowAdapter.mm:
(-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]):
- Misc/WebNSPasteboardExtras.mm:
(-[NSFilePromiseDragSource initWithSource:]):
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation init]):
- WebView/WebPreferences.mm:
(-[WebPreferences init]):
- WebView/WebView.mm:
(-[WebView UIDelegate]):
(-[WebView resourceLoadDelegate]):
(-[WebView downloadDelegate]):
(-[WebView policyDelegate]):
(-[WebView frameLoadDelegate]):
- 2:33 PM Changeset in webkit [63631] by
-
- 6 edits2 adds in trunk
Add NPJSObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=42524
Reviewed by Sam Weinig.
WebCore:
Export ScriptController functions.
- WebCore.exp.in:
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- WebProcess/Plugins/NPJSObjectMap.cpp: Added.
- WebProcess/Plugins/NPJSObjectMap.h: Added.
Add NPJSObjectMap, a map which contains NPObjects that wrap JavaScript objects.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Initialize the map.
(WebKit::PluginView::~PluginView):
Invalidate the map.
(WebKit::PluginView::frame):
Add frame getter.
(WebKit::PluginView::windowScriptNPObject):
Wrap the window object.
(WebKit::PluginView::pluginElementNPObject):
Wrap the plug-in element object.
- WebProcess/Plugins/PluginView.h:
- 12:44 PM Changeset in webkit [63630] by
-
- 3 edits2 adds in trunk/WebKit2
Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/NPRuntimeUtilities.cpp: Added.
- WebProcess/Plugins/NPRuntimeUtilities.h: Added.
Add new file with NPRuntime related utility functions.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_CreateObject):
(WebKit::NPN_RetainObject):
(WebKit::NPN_ReleaseObject):
Call the corresponding NPRuntimeUtilities functions.
- 11:57 AM Changeset in webkit [63629] by
-
- 7 edits in trunk/WebKit2
Begin work on NPRuntime support
https://bugs.webkit.org/show_bug.cgi?id=42519
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle NPNVWindowNPObject and NPNVPluginElementNPObject.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
Call the plug-in controller.
- WebProcess/Plugins/PluginController.h:
Add new windowScriptNPObject and pluginElementNPObject functions.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
Add stubbed out functions.
- 10:45 AM Changeset in webkit [63628] by
-
- 4 edits in trunk
Implement some NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42518
Reviewed by Dan Bernstein.
WebCore:
- WebCore.exp.in:
Export IdentifierRep functions.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetStringIdentifier):
(WebKit::NPN_GetStringIdentifiers):
(WebKit::NPN_GetIntIdentifier):
(WebKit::NPN_IdentifierIsString):
(WebKit::NPN_UTF8FromIdentifier):
(WebKit::NPN_IntFromIdentifier):
(WebKit::NPN_CreateObject):
- 10:01 AM Changeset in webkit [63627] by
-
- 10 edits in trunk
Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516
Reviewed by Dan Bernstein.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add setStatusbarText callback to WKBundlePageUIClient.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::setStatusbarText):
Call setStatusbarText.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setStatusbarText):
Call the bundle page UI client.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.
(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.
(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.
- 9:32 AM Changeset in webkit [63626] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[V8] Web Inspector: get actual breakpoint location from v8 and pass it
to ScripDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=42452
- src/js/DebuggerScript.js:
- 7:35 AM Changeset in webkit [63625] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium: fixed one more expectation to
reflect changes in r63616.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [63624] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium: fixed test expectations (reflected changes
in r63616).
- platform/chromium/test_expectations.txt:
