⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 20, 2010:

11:53 PM Changeset in webkit [63805] by yurys@chromium.org
  • 11 edits
    2 adds in trunk

2010-07-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

console.assert should include stack trace with line numbers.
​https://bugs.webkit.org/show_bug.cgi?id=22556

Test: inspector/console-assert.html

  • bindings/v8/ScriptCallStack.cpp: (WebCore::getTopFrameLocation): (WebCore::toScriptCallFramesVector): (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement):
  • page/Console.cpp: (WebCore::Console::lastWMLErrorMessage):
  • page/Console.idl:

2010-07-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

console.assert should include stack trace with line numbers.
​https://bugs.webkit.org/show_bug.cgi?id=22556

  • inspector/console-assert-expected.txt: Added.
  • inspector/console-assert.html: Added.
11:29 PM Changeset in webkit [63804] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Use log functions instead of fprintf
​https://bugs.webkit.org/show_bug.cgi?id=42576

Use LOG and LOG_ERROR instead of fprintf.

No new tests, no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
11:04 PM Changeset in webkit [63803] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=42523

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
9:28 PM Changeset in webkit [63802] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Re-save vsprops file after no-op edit in Visual Studio
to fix manual edit issues.

  • WebCore.vcproj/WebCoreCommon.vsprops:
9:26 PM Changeset in webkit [63801] by sfalken@apple.com
  • 4 edits in trunk/JavaScriptCore

Re-save vsprops files after no-op edits in Visual Studio
to fix manual edit issues.

9:12 PM Changeset in webkit [63800] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Re-save vcproj file after no-op edit in Visual Studio
to fix manual edit issues.

  • WebCore.vcproj/WebCore.vcproj:
7:41 PM Changeset in webkit [63799] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update expected results for a "tricky" test
​https://bugs.webkit.org/show_bug.cgi?id=42604

Originally, I created these expectations using Minefield. However, it
appears that Minefield parses this case incorrectly according to the
spec. I've filed <​https://bugzilla.mozilla.org/show_bug.cgi?id=580091>.

This patch updates our expected results to what I believe is correct.

  • html5lib/resources/tricky01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
7:30 PM Changeset in webkit [63798] by abarth@webkit.org
  • 6 edits
    1 add in trunk

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Include attributes when reconstructing elements in HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42594

  • html5lib/runner-expected-html5.txt:

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Include attributes when reconstructing elements in HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42594

Remove FIXME now that we have a test.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromElementRecord):
6:43 PM Changeset in webkit [63797] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix obvious typo.

Reviewed by Jon Honeycutt.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.

6:29 PM Changeset in webkit [63796] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-20 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] by default, dumpAsText should disable pixel results
​https://bugs.webkit.org/show_bug.cgi?id=42715

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
6:20 PM Changeset in webkit [63795] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-07-20 Tony Chang <​tony@chromium.org>

Not reviewed, chromium test expectation.

[chromium] put back baseline for http/tests/inspector/resource-parameters.html
​https://bugs.webkit.org/show_bug.cgi?id=42720

r63791 put in a failing baseline for webkit win, but chromium-win
falls back to webkit win before the result next to the test file.
Just put another copy in chromium-win of the original expected
results.

  • platform/chromium/http/tests/inspector/resource-parameters-expected.txt: Copied from LayoutTests/http/tests/inspector/resource-parameters-expected.txt.
6:03 PM Changeset in webkit [63794] by weinig@apple.com
  • 4 edits in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=42719
Make Acid2 pass in WebKit2

Reviewed by Brady Eidson.

WebCore:

  • WebCore.exp.in: Update exported functions.

WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType): Check for supported image mimetypes
before falling back to plugins.

6:02 PM Changeset in webkit [63793] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Import HTML5 parsing tests from html5test.com
​https://bugs.webkit.org/show_bug.cgi?id=42713

  • html5lib/resources/html5test-com.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
5:26 PM Changeset in webkit [63792] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

2010-07-20 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
​https://bugs.webkit.org/show_bug.cgi?id=42651

The miscategorization caused onloads to issue early, so you see x,
y as 0, 0 in the buggy version.

  • fast/dom/HTMLLinkElement/onload-completion-test-expected.txt: Added.
  • fast/dom/HTMLLinkElement/onload-completion-test.html: Added.
  • fast/dom/HTMLLinkElement/resources: Added.
  • fast/dom/HTMLLinkElement/resources/nick.jpg: Added.

2010-07-20 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
​https://bugs.webkit.org/show_bug.cgi?id=42651

While I was in the area, I saw that CachedResource::schedule() was dead, so I have removed it.

Test: fast/dom/HTMLLinkElement/onload-completion-test.html

  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.h:
  • loader/CachedImage.h:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h: (WebCore::CachedResource::isPrefetch):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
5:05 PM Changeset in webkit [63791] by bweinstein@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Land failing results for http/tests/inspector/resource-parameters.html. It has been
failing for a while. Fixing these results is being tracked by
<​https://bugs.webkit.org/show_bug.cgi?id=42718>.

Rubber-stamped by Adam Roben.

  • platform/win/http/tests/inspector: Added.
  • platform/win/http/tests/inspector/resource-parameters-expected.txt: Added.
5:00 PM Changeset in webkit [63790] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny

WebKit.lib instead of the old, dusty WebKit2.lib.

4:44 PM Changeset in webkit [63789] by Adam Roben
  • 2 edits in trunk/WebKit/win

Add WebKitTestRunner and friends to WebKit.sln

We added these projects to WebKit2.sln in r63585, but removed them
again in r63600 because WebKitTestRunner required getopt, which
doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
(which has replaced WebKit2.sln).

Fixes <​http://webkit.org/b/42711> WebKit.sln should build
WebKitTestRunner

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.sln: Added the following projects to the end of

the build order (in first-built to last-built order):
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
removed an unnecessary dependency from testapi on WebKit2WebProcess.

4:40 PM Changeset in webkit [63788] by Adam Roben
  • 2 edits in trunk/WebKitTools

Stop linking WebKitTestRunner against getopt

Use of getopt was removed in r63700.

Fixes <​http://webkit.org/b/42714> WebKitTestRunner links against
getopt, but doesn't need to

Reviewed by Sam Weinig.

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib

from all configurations.

4:33 PM Changeset in webkit [63787] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add a few more items to the WebKit2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=42712

Reviewed by Maciej Stachowiak.

  • platform/mac-wk2/Skipped:
4:23 PM Changeset in webkit [63786] by jhawkins@chromium.org
  • 6 edits in trunk

2010-07-16 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebFormElement::wasUserSubmitted(). This is used to
verify that the user submitted the form instead of JS when saving form
data in AutoFill.
​https://bugs.webkit.org/show_bug.cgi?id=42479

  • public/WebFormElement.h:
  • src/WebFormElement.cpp: (WebKit::WebFormElement::wasUserSubmitted):

2010-07-16 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

Expose the form submission trigger on the HTMLFormElement object. This
is used to verify that the user submitted the form instead of JS when
saving form data in Chrome AutoFill.
​https://bugs.webkit.org/show_bug.cgi?id=42479

No new tests as this is only used by the Chromium WebKit API.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::submissionTrigger):
  • html/HTMLFormElement.h:
4:06 PM Changeset in webkit [63785] by Adam Roben
  • 2 edits
    1 add in trunk/WebKitTools

Make run-webkit-tests --webkit-test-runner "work" on Windows

WebKitTestRunner crashes on launch, but at least the scripts build and
launch it!

Fixes <​http://webkit.org/b/42709> run-webkit-tests
--webkit-test-runner bails with an error on Windows

Reviewed by Anders Carlsson.

  • Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on

Windows.

  • WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following

projects (from first-built to last-built): FindSafari, ImageDiff,
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.

4:05 PM Changeset in webkit [63784] by Adam Roben
  • 3 edits
    1 delete in trunk

Remove WebKit2.sln

WebKit.sln builds all the same projects.

Rubber-stamped in advance by Steve Falkenburg.

WebKit2:

  • WebKit2.sln: Removed.

WebKitTools:

Change build-webkit back to building WebKit.sln on Windows

WebKit.sln builds all the same projects as WebKit2.sln, and the latter
is being removed.

  • Scripts/build-webkit:
4:04 PM Changeset in webkit [63783] by crogers@google.com
  • 8 edits in branches/audio/WebCore

Fixes to Chrome build and run-time due to recent API changes

4:02 PM Changeset in webkit [63782] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-20 Adam Barth <​abarth@webkit.org>

Unreviewed.

Fix fast/dom/title-content-write-set.html for HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42668

Address some late-breaking review comments.

  • dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::replaceData):
  • dom/CharacterData.h:
3:39 PM Changeset in webkit [63781] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

make dump-as-markup work better on subframes and allow dumping a subtree
​https://bugs.webkit.org/show_bug.cgi?id=42673

  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup.html:
  • resources/dump-as-markup.js: (Markup.description): (Markup._getSelectionFromNode): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
3:23 PM Changeset in webkit [63780] by evan@chromium.org
  • 9 edits in trunk

2010-07-20 Daniel Erat <​derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
​https://bugs.webkit.org/show_bug.cgi?id=42220

Layout test addition to check that Chromium Linux honors fontconfig
settings enabling or disabling subpixel rendering per-strike.

  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt:
  • platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:

2010-07-20 Daniel Erat <​derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
​https://bugs.webkit.org/show_bug.cgi?id=42220

Explicitly initialize global Chromium Linux isSkiaSubpixelGlyphs
flag to false for clarity.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

2010-07-20 Daniel Erat <​derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
​https://bugs.webkit.org/show_bug.cgi?id=42220

Honor Fontconfig subpixel rendering setting on Chromium Linux.

  • src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
3:12 PM Changeset in webkit [63779] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix fast/dom/title-content-write-set.html for HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42668

When I split parserAppendData from appendData, it was tempting to cut
the function at dispatchModifiedEvent, but that's not quite right. We
still need to notify the parent that it's children have changed.

  • dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
  • dom/CharacterData.h:
2:56 PM Changeset in webkit [63778] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
2:55 PM Changeset in webkit [63777] by Adam Roben
  • 2 edits in trunk/WebKit2

Make the web process break into the debugger when Ctrl-Alt-Shift is held during launch

Fixes <​http://webkit.org/b/42670> Would like a way to break into the
debugger when the web process launches

Reviewed by Anders Carlsson.

  • WebProcess/WebKitMain.cpp:

(WebKitMain): If the Control, Alt, and Shift keys are held down in a
Debug build, call DebugBreak() so that we will break into the
debugger.

2:55 PM Changeset in webkit [63776] by Adam Roben
  • 2 edits in trunk/WebKit2

Teach Connection how to handle a slow receiver

Fixes <​http://webkit.org/b/42667> Assertion in
Connection::sendOutgoingMessage when browser or web process is paused

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage): If WriteFile returns FALSE
and the last error is ERROR_IO_PENDING, Windows will write the data as
soon as the current write operation is completed. We don't need to do
anything special in this case, so there's no need to assert about it.

2:45 PM Changeset in webkit [63775] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-07-20 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix zoom in/out on EFL after r62666. The patch for adding viewport
missed the initialization of zoom_range.user_scalable. In case browser
doesn't care about the viewport and does not listen to the signal,
user_scalable will be always false, thus inhibiting zoom in/out.
​https://bugs.webkit.org/show_bug.cgi?id=42656

  • efl/EWebLauncher/main.c: (on_viewport_changed): when listening to signal about viewport meta tag, it's not sufficient to receive the parameters. One needs also to enforce these parameters in WebKit.
  • efl/ewk/ewk_view.cpp: (_ewk_view_priv_new): initialize user_scalable parameter to allow browser zooming in and out.
2:34 PM Changeset in webkit [63774] by Chris Fleizach
  • 3 edits
    2 adds in trunk

CrashTracer: [USER] 300 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 573
​https://bugs.webkit.org/show_bug.cgi?id=42652

Reviewed by Beth Dakin.

WebCore:

When a table cell accesses its parent table, we should not use getOrCreate, because creating an AXTable inspects its render tree state
which may be out of date, leading to a crash.
By using only get(), it implies that the AXTable must be created before AXTableCells. This should
always be the case when AT clients access a table.

Test: accessibility/updating-attribute-in-table-causes-crash.html

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):

LayoutTests:

  • accessibility/updating-attribute-in-table-causes-crash-expected.txt: Added.
  • accessibility/updating-attribute-in-table-causes-crash.html: Added.
2:11 PM Changeset in webkit [63773] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-07-20 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Check the node is a text node before doing the static cast
for editing commands.
​https://bugs.webkit.org/show_bug.cgi?id=42655

Test: editing/execCommand/editing-nontext-node-crash.xhtml

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

2010-07-20 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Tests that applying an editing command on a non text node does not
result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=42655

  • editing/execCommand/editing-nontext-node-crash-expected.txt: Added.
  • editing/execCommand/editing-nontext-node-crash.xhtml: Added.
1:37 PM Changeset in webkit [63772] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-07-20 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by David Hyatt.

Don't merge Anonymous block whose first child is inline run-in.
Make run-in recalculate its style after its renderer is destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=41375.

Test: fast/runin/crash-when-reparent-sibling.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren):

2010-07-20 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by David Hyatt.

Test case to verify ​https://bugs.webkit.org/show_bug.cgi?id=41375.
Test passes if expected result occurs without crash.
​https://bugs.webkit.org/show_bug.cgi?id=41375.

  • fast/runin/crash-when-reparent-sibling-expected.txt: Added.
  • fast/runin/crash-when-reparent-sibling.html: Added.
1:27 PM Changeset in webkit [63771] by steveblock@google.com
  • 2 edits in trunk/WebCore

Unreviewed Qt test fix.

Qt should not use PREEMPT_GEOLOCATION_PERMISSION until Bug 42027 is fixed.
​https://bugs.webkit.org/show_bug.cgi?id=42068

No new tests, test fix only.

  • WebCore.pro:
1:23 PM Changeset in webkit [63770] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-20 Darin Fisher <​darin@chromium.org>

Fix Chromium build bustage.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge): Add implementation of this method that always returns false.
12:56 PM Changeset in webkit [63769] by darin@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-07-20 Darin Fisher <​darin@chromium.org>

Reviewed by Jian Li.

[Chromium] Add interface for downloading to a file. This can be used
in the future to support XMLHttpRequest.responseBlob, but it also
serves a use case in Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=42657

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::willSendRequest): (WebKit::WebURLLoaderClient::didSendData): (WebKit::WebURLLoaderClient::didReceiveResponse): (WebKit::WebURLLoaderClient::didDownloadData): (WebKit::WebURLLoaderClient::didReceiveData): (WebKit::WebURLLoaderClient::didFinishLoading): (WebKit::WebURLLoaderClient::didFail):
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
12:55 PM Changeset in webkit [63768] by commit-queue@webkit.org
  • 3 edits in trunk

2010-07-20 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Enable Ecore-X on compile time
​https://bugs.webkit.org/show_bug.cgi?id=42600

Check for a flag received from cmake configure and disable it
if necessary. Also disable it if Ecore-X wasn't found.

EFL port does not support automated tests yet.

  • cmake/FindEFL.cmake:
  • cmake/OptionsEfl.cmake:
12:53 PM Changeset in webkit [63767] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63764.
​http://trac.webkit.org/changeset/63764
​https://bugs.webkit.org/show_bug.cgi?id=42658

have broken Chromium linux build (Requested by loislo on
#webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
12:48 PM Changeset in webkit [63766] by ap@apple.com
  • 8 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=41531
Asynchronous cross origin XMLHttpRequest doesn't expose 401 response when withCredentials is false

This doesn't match Firefox, but it matches our sync case, XHR2 spec and common sense.

Test: http/tests/xmlhttprequest/cross-origin-no-authorization.html (updated results).

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Instead of canceling the request, continue without credentials - if the platform has a necessary method on ResourceHandle.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Don't ask resource loader client for credentials if subresource loader client already took care of those.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge):
  • platform/network/ResourceHandle.h: Added an accessor to check whether ResourceHandle is currently waiting for credentials.
12:29 PM Changeset in webkit [63765] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Build SVGPathBuilder, SVGPathParser and SVGPathSegListBuilder.
Add websockets include directory.

The EFL port doesn't yet support automated tests.

  • CMakeLists.txt:
12:27 PM Changeset in webkit [63764] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=42523

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
12:23 PM Changeset in webkit [63763] by Joseph Pecoraro
  • 6 edits
    5 adds in trunk

2010-07-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
​https://bugs.webkit.org/show_bug.cgi?id=42613

  • platform/mac/fast/objc/script-tests/TEMPLATE.html: Added.
  • platform/mac/fast/objc/script-tests/webScriptObject-hasWebScriptKey.js: Added.
  • platform/mac/fast/objc/webScriptObject-hasWebScriptKey-expected.txt: Added.
  • platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html: Added.

2010-07-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
​https://bugs.webkit.org/show_bug.cgi?id=42613

Test: platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html

Add private API "hasWebScriptKey" to check for key existence in
a WebScriptObject. Like JavaScript's in syntax. This is intended
to be made public eventually.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject hasWebScriptKey:]):
  • bindings/objc/WebScriptObjectPrivate.h:

2010-07-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
​https://bugs.webkit.org/show_bug.cgi?id=42613

Normal ObjCController workflow for a WebScriptObject test.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testHasWebScriptKey:]):
12:18 PM Changeset in webkit [63762] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder needs to call dispatchDocumentElementAvailable
​https://bugs.webkit.org/show_bug.cgi?id=42654

This patch fixes the follout LayoutTests with --html5-treebuilder:

  • userscripts/script-not-run-for-fragments.html
  • userscripts/script-run-at-start.html
  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
11:59 AM Changeset in webkit [63761] by commit-queue@webkit.org
  • 6 edits in trunk

2010-07-20 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Need to be able to configure Geolocation policy regarding user permissions
​https://bugs.webkit.org/show_bug.cgi?id=42068

If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default

  • wtf/Platform.h:

2010-07-20 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Need to be able to configure Geolocation policy regarding user permissions
​https://bugs.webkit.org/show_bug.cgi?id=42068

Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service

This change does not introduce any change in behavior for any platform. So there are no new tests
added.

  • WebCore.pro:
  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
  • page/Geolocation.h:
11:28 AM Changeset in webkit [63760] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 tree builder should restore form state
​https://bugs.webkit.org/show_bug.cgi?id=42644

We need to tell self-closing tags that we're done parsing their
children. This patch fixes the following LayoutTests when run with
--html5-treebuilder:

fast/forms/button-state-restore.html
fast/forms/state-restore-to-non-autocomplete-form.html
fast/forms/state-restore-to-non-edited-controls.html
fast/history/saves-state-after-fragment-nav.html
http/tests/navigation/restore-form-state-https.html

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
11:12 AM Changeset in webkit [63759] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
​http://trac.webkit.org/changeset/63750
​https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
​http://trac.webkit.org/changeset/63750
​https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:
10:54 AM Changeset in webkit [63758] by senorblanco@chromium.org
  • 56 edits
    4 adds
    2 deletes in trunk/LayoutTests

2010-07-20 Stephen White <​senorblanco@chromium.org>

Unreviewed; pixel test results fix.

Updated pixel test results after r63721.

  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum:
  • platform/chromium-linux/svg/custom/path-getTotalLength-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/chromium-linux/svg/dom: Added.
  • platform/chromium-linux/svg/dom/path-parser-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/007-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/007-expected.png:
  • platform/chromium-linux/svg/hixie/perf/007-expected.txt:
  • platform/chromium-mac/fast/backgrounds/svg-as-background-5-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.checksum:
  • platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/hixie/perf/007-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/007-expected.png:
  • platform/chromium-win/svg/hixie/perf/007-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
10:53 AM Changeset in webkit [63757] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: It is possible to show full call stack instead of top frame for Caller
and Call Site properties in Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=42620

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
  • inspector/front-end/inspector.css: (.timeline-details): (.timeline-function-name): (.timeline-stacktrace-title):
10:50 AM Changeset in webkit [63756] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Implement NPN_GetURL and NPN_PostURL
​https://bugs.webkit.org/show_bug.cgi?id=42650

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Add a FIXME about deleting the file.

(WebKit::makeURLString):
Move this static method before NPN_GetURL.

(WebKit::NPN_GetURL):
Call NetscapePLugin::LoadURL.

(WebKit::NPN_PostURL):
Ditto.

(WebKit::NPN_PostURLNotify):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

Remove unreached code.

(WebKit::NetscapePluginStream::deliverDataToPlugin):
Stop the stream if the plug-in returns -1 from NPP_Write.

10:42 AM Changeset in webkit [63755] by victorw@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-07-19 Victor Wang <​victorw@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add webkit api reset to WebIDBDatabaseError and WebIDBKey
and refactor their destructors for chromium multi dll build.

​https://bugs.webkit.org/show_bug.cgi?id=42574

  • public/WebIDBDatabaseError.h: (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
  • public/WebIDBKey.h: (WebKit::WebIDBKey::~WebIDBKey):
  • src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::reset):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::reset):
10:38 AM Changeset in webkit [63754] by cmarrin@apple.com
  • 2 edits in trunk/WebKitTools

2010-07-20 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=42118
Disable compositing/webgl tests if WebGL is not enabled

  • Scripts/old-run-webkit-tests:
10:35 AM Changeset in webkit [63753] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-07-20 Leon Clarke <​leonclarke@google.com>

Reviewed by Pavel Feldman.

Make things compile again when the inspector is disabled, following
recent inspector improvements.
​https://bugs.webkit.org/show_bug.cgi?id=42632

No new tests. Fixing a build break.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • inspector/InspectorController.h: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
10:31 AM Changeset in webkit [63752] by chang.shu@nokia.com
  • 5 edits
    20 moves
    7 adds in trunk/LayoutTests

2010-07-20 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Adler.

Move the canvas security tests to http tests to simulate remote host
access and then pass the tests. Remove them from Mac and Qt's skipped files.
​https://bugs.webkit.org/show_bug.cgi?id=41279

10:20 AM Changeset in webkit [63751] by antonm@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Allow handles to be disposed and WebKit objects to be dereferenced even if their map is already destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=42634

Currently DOMDataStore could be destroyed even if it has some mappings (it gets destroyed
when its isolated context gets GCed). However in this case, handles allocated for
such objects would never be disposed as we require presence of mapping from wrapped
WebKit object to handle being collected in the map and now map is gone. That leads to
zombie objects in both WebKit (wrapped WebKit object doesn't get dereferenced) and V8
(both handle and V8 wrapper object could not be destroyed).

See ​http://code.google.com/p/chromium/issues/detail?id=47125 for further discussion.

  • bindings/v8/DOMData.h: (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::~WeakReferenceMap):
10:08 AM Changeset in webkit [63750] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-20 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
​https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-20 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
​https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
9:44 AM Changeset in webkit [63749] by antonm@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-20 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Print additional information about exception if failed to connect to apache (in verbose mode).
​https://bugs.webkit.org/show_bug.cgi?id=42627

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
9:30 AM Changeset in webkit [63748] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-07-20 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] only pass --force to gclient sync if explicitly stated
​https://bugs.webkit.org/show_bug.cgi?id=42581

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should

always pass --force since it's hard to do manual cleanups

  • Scripts/update-webkit-chromium: only pass --force if --force is

passed in

9:16 AM Changeset in webkit [63747] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-07-20 Hayato Ito <​hayato@chromium.org>

Reviewed by Darin Adler.

Fixed a crash when deeply nested CSS selector is used.
​https://bugs.webkit.org/show_bug.cgi?id=41129

This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.

  • fast/css/css-selector-deeply-nested-expected.txt: Added.
  • fast/css/css-selector-deeply-nested.html: Added.

2010-07-20 Hayato Ito <​hayato@chromium.org>

Reviewed by Darin Adler.

Fixed a crash when deeply nested CSS selector is used.
​https://bugs.webkit.org/show_bug.cgi?id=41129

This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.

Test: fast/css/css-selector-deeply-nested.html

  • css/CSSSelector.cpp: (WebCore::CSSSelectorBag::~CSSSelectorBag): (WebCore::CSSSelectorBag::isEmpty): (WebCore::CSSSelectorBag::append): (WebCore::CSSSelectorBag::takeAny): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::specificity):
  • css/CSSSelector.h:
8:17 AM Changeset in webkit [63746] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error
​https://bugs.webkit.org/show_bug.cgi?id=42642

  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
8:09 AM Changeset in webkit [63745] by abecsi@webkit.org
  • 6 edits in trunk

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63742.
​http://trac.webkit.org/changeset/63742
​https://bugs.webkit.org/show_bug.cgi?id=42641

Broke Leopard Intel build. (Requested by bbandix on #webkit).

  • wtf/Platform.h:

2010-07-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63742.
​http://trac.webkit.org/changeset/63742
​https://bugs.webkit.org/show_bug.cgi?id=42641

Broke Leopard Intel build. (Requested by bbandix on #webkit).

  • WebCore.pro:
  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
  • page/Geolocation.h:
7:51 AM Changeset in webkit [63744] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-20 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

Modify test_expectations after r63721 and r63728.

  • platform/chromium/test_expectations.txt:
7:51 AM Changeset in webkit [63743] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed case of "Name" attribute.
7:24 AM Changeset in webkit [63742] by abecsi@webkit.org
  • 6 edits in trunk

Need to be able to configure Geolocation policy regarding user permissions
​https://bugs.webkit.org/show_bug.cgi?id=42068

Patch by Mahesh Kulkarni <​mahesh.kulkarni@nokia.com> on 2010-07-20
Reviewed by Steve Block.

JavaScriptCore:

If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default

  • wtf/Platform.h:

WebCore:

Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service

This change does not introduce any change in behavior for any platform. So there are no new tests
added.

  • WebCore.pro:
  • page/Geolocation.cpp:

(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::startUpdating):

  • page/Geolocation.h:
5:21 AM Changeset in webkit [63741] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Inspector: Resources Search Should Search Only Filtered Resources
​https://bugs.webkit.org/show_bug.cgi?id=28290

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews):
  • inspector/front-end/inspector.js: (WebInspector.performSearch): (WebInspector.doPerformSearch):
5:11 AM Changeset in webkit [63740] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/qt

2010-07-20 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

[Qt] Add API to define device-width and height for use with the viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=42597

Reviewed by Antonio Gomes.

Add a new API for setting the deviceSize for use in conjunction with
out viewport meta tag API.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setDeviceSize): (QGraphicsWebView::deviceSize):
  • Api/qgraphicswebview.h:
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::windowRect):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
5:01 AM Changeset in webkit [63739] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Incorrect absolute URLs in tooltips of links in the ElementsTreeOutline
​https://bugs.webkit.org/show_bug.cgi?id=42626

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeHTML):
4:46 AM Changeset in webkit [63738] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-20 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT sideeffect revealed by r63657
​https://bugs.webkit.org/show_bug.cgi?id=42578

Don't set an automatic timeout for notifications when running in DRT.
This fixes an issue with cancel() notifications in unrelated tests.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::displayNotification):
3:17 AM Changeset in webkit [63737] by alex
  • 2 edits in trunk/LayoutTests

2010-07-20 Alejandro G. Castro <​alex@igalia.com>

Unreviewed.

Skipping the svg/dom/path-parser.html test for gtk, bug submitted:
​https://bugs.webkit.org/show_bug.cgi?id=42624

  • platform/gtk/Skipped:
2:24 AM Changeset in webkit [63736] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed comment fix. The comment in IDL should be , not # .

Code generator: ensure generated constants match their corresponding enums.
​https://bugs.webkit.org/show_bug.cgi?id=42250

  • dom/OverflowEvent.idl:
2:14 AM Changeset in webkit [63735] by commit-queue@webkit.org
  • 11 edits in trunk

2010-07-20 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
​https://bugs.webkit.org/show_bug.cgi?id=42380

RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.

No new functionality so no new tests.

  • Android.mk:

2010-07-20 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
​https://bugs.webkit.org/show_bug.cgi?id=42380

RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.

No new functionality so no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp: Remove #if USE(V8), as RuntimeEnabledFeatures.cpp is no longer V8-only.
  • websockets/WebSocket.h: Ditto.
1:43 AM Changeset in webkit [63734] by tony@chromium.org
  • 6 edits in trunk/WebCore

2010-07-20 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

clean up style in ClipboardWin and PasteboardWin
​https://bugs.webkit.org/show_bug.cgi?id=42609

No new tests since this is just a style cleanup.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCFHTML): (WebCore::getURL): (WebCore::getPlainText): (WebCore::getTextHTML): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCFHTML): (WebCore::fragmentFromHTML):
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp: (WebCore::pathRemoveBadFSCharacters): (WebCore::createGlobalHDropContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::writeURL): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeRange):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create): (WebCore::ClipboardWin::dataObject):
  • platform/win/PasteboardWin.cpp: (WebCore::PasteboardOwnerWndProc): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
1:31 AM Changeset in webkit [63733] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
​https://bugs.webkit.org/show_bug.cgi?id=42348

This doesn't work in the HTML5 parser. We cover this behavior in
parsing tests. Sadly, the test still fails under the HTML5 parser, but
for a different reason.

  • fast/events/focusingUnloadedFrame.html:
1:30 AM Changeset in webkit [63732] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-07-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: jump to source is broken for call frames logged by console.trace
​https://bugs.webkit.org/show_bug.cgi?id=42619

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
  • inspector/front-end/treeoutline.js: allow passing HTML element as a title. (TreeElement.prototype.set title): (TreeElement.prototype.set shouldRefreshChildren): (TreeElement.prototype._setListItemNodeContent): (TreeElement.prototype._attach):
1:17 AM Changeset in webkit [63731] by tony@chromium.org
  • 6 edits
    3 adds
    2 deletes in trunk

2010-07-20 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

[chromium] crash in Position::getInlineBoxAndOffset
​https://bugs.webkit.org/show_bug.cgi?id=42202

  • editing/selection/firstRect-crash-expected.txt: Added.
  • editing/selection/firstRect-crash.html: Added.
  • platform/mac/editing/input/caret-primary-bidi-expected.txt: Fix some negative ranges.
  • platform/mac/editing/input/range-for-empty-document-expected.txt:
  • platform/mac/editing/selection/move-left-right-expected.txt: Removed since we now match the shared expected results.
  • platform/win/editing/selection/move-left-right-expected.txt: Removed since it's the same as the shared expected results.

2010-07-20 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

[chromium] crash in Position::getInlineBoxAndOffset
​https://bugs.webkit.org/show_bug.cgi?id=42202

Test: editing/selection/firstRect-crash.html
Manual test: win/contextmenu-key2.html

  • page/EventHandler.cpp: Code no longer needed
  • page/Frame.cpp: (WebCore::Frame::firstRectForRange): Normalize Positions to VisiblePositions because

Positions may be pointing to nodes that have no renderer. If there's no renderer,
getInlineBoxAndOffset will crash.

12:47 AM Changeset in webkit [63730] by Nikolas Zimmermann
  • 87 edits in trunk/LayoutTests

2010-07-20 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Maciej Stachowiak.

svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
​https://bugs.webkit.org/show_bug.cgi?id=42376

Finally generate pixel teset results again for svg/dynamic-updates. We have some regressions, tracked by master bug 42618.

  • fast/js/resources/js-test-pre.js: Pass 'window.enablePixelTesting' as argument to setDumpAsText() - the svg/dynamic-updates tests set this value to true before importing js-test-pre.js
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • svg/dynamic-updates/resources/SVGTestCase.js: Set 'window.enablePixelTesting' to true, forcing setDumpAsText() to generate pixel test results.
  • svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-gradientUnits-attr.js: Tweak this test, to make it work as expected.
  • svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-gradientUnits-prop.js: Ditto.
  • svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-gradientUnits-attr.js: Update expected result description.
  • svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-gradientUnits-prop.js: Ditto.
12:33 AM Changeset in webkit [63729] by abarth@webkit.org
  • 5 edits in trunk

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Foster parenting depends on the current element at insertion time
​https://bugs.webkit.org/show_bug.cgi?id=42599

  • html5lib/runner-expected-html5.txt:

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Foster parenting depends on the current element at insertion time
​https://bugs.webkit.org/show_bug.cgi?id=42599

We need to consider the current element at insertion-time when deciding
whether to redirect insertion to the foster parent. Previously, we
were considering the current element *both* at insertion-time and at
the time we created the guard.

  • html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::RedirectToFosterParentGuard):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::defaultForInTableText):
12:20 AM Changeset in webkit [63728] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Import a number of fast/invalid tests into html5lib for easy of fixing
​https://bugs.webkit.org/show_bug.cgi?id=42590

Working with these DOM dumps is much easier than staring at render
trees. Also, this infrastructure lets us cross-test with other
browsers.

  • html5lib/resources/tricky01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
12:07 AM Changeset in webkit [63727] by commit-queue@webkit.org
  • 5 edits in trunk

2010-07-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Failing 2d.path.stroke.prune.curve philip canvas test
​https://bugs.webkit.org/show_bug.cgi?id=42190

  • platform/mac/Skipped: Unskipped now passing tests.

2010-07-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Failing 2d.path.stroke.prune.curve philip canvas test
​https://bugs.webkit.org/show_bug.cgi?id=42190

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath): Added check to make sure there's a non-trivial path to close. Since there is currently no way to check if the current point is the start point, or similarly if there is only 1 point in the current subpath (since these are both sufficient conditions for a trivial subpath), then checking that the bounding rectangle has both zero width and height proves also to be a sufficient condition for a trivial path. (WebCore::CanvasRenderingContext2D::quadraticCurveTo): Added in simple bounds as per the spec. (WebCore::CanvasRenderingContext2D::bezierCurveTo): Added in simple bounds as per the spec.
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::closeSubpath): Moved the check for an empty path up on level to make it platform independent and remove redundancy.
12:03 AM Changeset in webkit [63726] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Add a few more items to the WK2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=42595

  • platform/mac-wk2/Skipped:

Jul 19, 2010:

11:54 PM Changeset in webkit [63725] by krit@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-07-19 Dirk Schulze <​krit@webkit.org>

SVG CleanUp of SVGPathData parsing
​https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Win baseline.

  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/use-css-events-expected.txt: Added.
  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/path-parser-expected.txt: Added.
11:41 PM Changeset in webkit [63724] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2010-07-19 Dirk Schulze <​krit@webkit.org>

SVG CleanUp of SVGPathData parsing
​https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Qt baseline.

  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
11:28 PM Changeset in webkit [63723] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2010-07-19 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Added a simple implementation of VideoLayerChromium. Uses the
LayerChromium::updateTextureRect() to send video frames to the
GPU.
​https://bugs.webkit.org/show_bug.cgi?id=42234

  • WebCore.gypi: Added include for VideoLayerChromium.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToMedia): Implemented setContentsToMedia, though it does not seem to trigger a repaint correctly.
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: Added. (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents):
  • platform/graphics/chromium/VideoLayerChromium.h: Added. (WebCore::VideoLayerChromium::drawsContent):

2010-07-19 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Updated WebMediaPlayer to support accelerated rendering and to
create and return a VideoChromiumLayer as its platform layer.
​https://bugs.webkit.org/show_bug.cgi?id=42234

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h: (WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
11:23 PM Changeset in webkit [63722] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Yuzo Fujishima <​yuzo@google.com>

Unreviewed test expectation fix.

fast/css/font-face-download-error.html should be skipped for Qt like
other @font-face tests.
​https://bugs.webkit.org/show_bug.cgi?id=42342

  • platform/qt/Skipped:
10:37 PM Changeset in webkit [63721] by krit@webkit.org
  • 52 edits
    7 adds in trunk

2010-07-19 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
​https://bugs.webkit.org/show_bug.cgi?id=41410

Added piOverTwo to MathExtras.

  • wtf/MathExtras.h:

2010-07-19 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
​https://bugs.webkit.org/show_bug.cgi?id=41410

Cleanup the parsing code for SVG Paths. Move classes out of the convoluted SVGParserUtilities.cpp
in their own files. Make use of WebCore specific objects in parsing code like FloatPoint, AffineTransform,
etc. instead of using home-brewn solutions.
The SVGPathParser parses a path data string and delivers the parsed segments and values to the SVGPathConsumer.
SVGPathConsumer is the base class for SVGPathBuilder and SVGPathSegListBuilder, that either build the platform
Path object or a SVGPathSegList out of the segments.
We're now directly parsing floats instead of truncating precision to float afterwards.

SVG Path with an arc with radius of 0 does not render
​https://bugs.webkit.org/show_bug.cgi?id=40448

If one of the radii on the elliptic arc are zero, we should draw a line from the starting point to
the end point according to the spec. Fixed this bug with this patch, because an is zero check and
an DRT check was neccessary with the current clean-up.
Extended svg/dom/path-parser.xhml to check the correct behavior.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): Follow WebKit style and use multiple lines for the function. (WebCore::FloatPoint::scale): Scale FloatPoint. (WebCore::operator+=): (WebCore::operator+): Add two FloatPoints and give back the sum as FloatPoint.
  • svg/SVGAllInOne.cpp: Added new created files.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): Use new PathParser to create a PathSegList.
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): Use new PathParser to create a Path.
  • svg/SVGGlyphElement.cpp: (WebCore::parsePathData): Use new PathParser to create a Path.
  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): Removed parseArcFlag(double&), we parse in float now.
  • svg/SVGParserUtilities.h: Removed path parsing code and a lot of unneccessary includes.
  • svg/SVGPathBuilder.cpp: Added. (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::build): Builds a normalized Path. (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
  • svg/SVGPathBuilder.h: Added. We just create normalized Paths, so this functions should never be reached. (WebCore::SVGPathBuilder::lineToHorizontal): (WebCore::SVGPathBuilder::lineToVertical): (WebCore::SVGPathBuilder::curveToCubicSmooth): (WebCore::SVGPathBuilder::curveToQuadratic): (WebCore::SVGPathBuilder::curveToQuadraticSmooth): (WebCore::SVGPathBuilder::arcTo):
  • svg/SVGPathConsumer.h: Added. Base class of SVGPathBuilder and SVGPathSegListBuilder. (WebCore::): (WebCore::SVGPathConsumer::SVGPathConsumer): (WebCore::SVGPathConsumer::~SVGPathConsumer):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute): Use new PathParser to create a PathSegList.
  • svg/SVGPathParser.cpp: Added. (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::~SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataString): (WebCore::SVGPathParser::decomposeArcToCubic): Normalizes an arc to multiple cubic curves.
  • svg/SVGPathParser.h: Added.
  • svg/SVGPathSegListBuilder.cpp: Added. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::build): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Added.

2010-07-19 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
​https://bugs.webkit.org/show_bug.cgi?id=41410

Parsing values as float instead of double causes some minimal changes on DRT results and
pixel results. Even if the values get shrinked to float before the calculation of arc and
others. But the calculation itself transforms the values back to double and shrinks it to
floats again right before the drawing.

SVG Path with an arc with radius of 0 does not render
​https://bugs.webkit.org/show_bug.cgi?id=40448

Extended svg/dom/path-parser.xhml to check the correct behavior. We draw a line from the
current point to the given end point.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • svg/custom/path-getTotalLength-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js:
10:28 PM Changeset in webkit [63720] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed trivial fix after r63684.
​https://bugs.webkit.org/show_bug.cgi?id=30464

  • fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
10:10 PM Changeset in webkit [63719] by yuzo@google.com
  • 4 edits
    2 adds in trunk

2010-07-15 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
​https://bugs.webkit.org/show_bug.cgi?id=42342

  • fast/css/font-face-download-error-expected.txt: Added.
  • fast/css/font-face-download-error.html: Added.

2010-07-15 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
​https://bugs.webkit.org/show_bug.cgi?id=42342

Test: fast/css/font-face-download-error.html

  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::isValid): Valid if at least one font face is valid. (WebCore::CSSSegmentedFontFace::getFontData): Check validity for each font face.
  • css/CSSSegmentedFontFace.h: Make isValid private.
9:33 PM Changeset in webkit [63718] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=42568

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::systemFontSize): (WebCore::pointsToPixels): (WebCore::querySystemBlinkInterval): (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
9:32 PM Changeset in webkit [63717] by sfalken@apple.com
  • 2 edits in trunk/WebCore

(Hopefully the last) Windows build fix.

Version of CoreServices.h in WebKit Support Libraries uses
pragma once, unlike the version I have locally. Switch based
on COLORSYNCDEPRECATED instead.

  • WebCorePrefix.h:
9:17 PM Changeset in webkit [63716] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCorePrefix.h:
9:09 PM Changeset in webkit [63715] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Remove now passing tests from the skipped list.

Reviewed by Maciej Stachowiak.

  • platform/mac-wk2/Skipped:
9:05 PM Changeset in webkit [63714] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Paths of generated files should be relative to the build product.

8:42 PM Changeset in webkit [63713] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-07-19 Mike Moretti <​mike.moretti@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] Build fix after r63404.

Implement isValid() function for the Symbian executable allocator.

  • jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::isValid):
8:24 PM Changeset in webkit [63712] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCorePrefix.h:
8:14 PM Changeset in webkit [63711] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCorePrefix.h:
8:01 PM Changeset in webkit [63710] by dbates@webkit.org
  • 12 edits in trunk

2010-07-19 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
​https://bugs.webkit.org/show_bug.cgi?id=37930

Implements support for markerTextForListItem in the Windows port.

  • DOMCoreClasses.cpp: (DOMElement::markerTextForListItem): Added.
  • DOMCoreClasses.h:
  • Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
  • Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
  • Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
  • WebView.cpp: (WebView::elementFromJS): Added.
  • WebView.h:

2010-07-19 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
​https://bugs.webkit.org/show_bug.cgi?id=37930

Remove skipped layout tests now that we have DRT support.

  • platform/win/Skipped:

2010-07-19 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
​https://bugs.webkit.org/show_bug.cgi?id=37930

Implements DRT support for markerTextForListItem in the Windows port.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::markerTextForListItem): Implemented.
8:00 PM Changeset in webkit [63709] by sfalken@apple.com
  • 7 edits in trunk/WebCore

Windows Build fixes for new ColorSync API.
We support both new and old APIs, since the newer headers aren't in the tree yet.

  • WebCorePrefix.h: Removed include of CoreServices.h. Included via ColorSyncPriv.h instead, since header may not be present.
  • platform/graphics/cg/ColorCG.cpp:

(WebCore::createCGColor): Conditionally use new ColorSync API.

  • platform/graphics/opentype/OpenTypeUtilities.cpp: Define Fixed if CoreServices.h doesn't.
  • platform/graphics/win/GraphicsLayerCACF.cpp:

(WebCore::GraphicsLayerCACF::updateLayerDrawsContent): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Include AssertMacros.h.
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::operator CFErrorRef): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

7:40 PM Changeset in webkit [63708] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
​https://bugs.webkit.org/show_bug.cgi?id=42356

Reviewed by Sam Weinig.

Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed ​https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
Call setMachPortQueueLength.

  • Platform/mac/MachUtilities.cpp: Added.

(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.

  • Platform/mac/MachUtilities.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add MachUtilities.cpp and MachUtilities.h

7:37 PM Changeset in webkit [63707] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Only set unloadEventEnd when the unload event is actually fired
​https://bugs.webkit.org/show_bug.cgi?id=42607

r63689 introduced this ASSERT and it began failing on Qt and Mac debug.
For some reason, it did not fail on Windows (which is where I was
testing). The ASSERT was disabled in r63699.

Test: page-cache related layout tests don't crash in debug mode on Mac.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
7:03 PM Changeset in webkit [63706] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
​https://bugs.webkit.org/show_bug.cgi?id=42513

Avoid making unnecessary deep-copies of QPainterPaths that will
be discarded after use.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
6:44 PM Changeset in webkit [63705] by kbr@google.com
  • 4 edits in trunk

2010-07-19 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
​https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):

2010-07-19 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
​https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch. No new tests;
covered by existing tests.

  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
6:19 PM Changeset in webkit [63704] by andersca@apple.com
  • 10 edits in trunk

Handle NP_ASFILE and NP_ASFILEONLY transfer modes
​https://bugs.webkit.org/show_bug.cgi?id=42587

Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export functions from FileSystem.h

  • platform/mac/FileSystemMac.mm:

(WebCore::openTemporaryFile):
Try to create a temporary file using mkstemp.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_StreamAsFile):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add NPP_ wrapper.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_fileHandle.

(WebKit::isSupportedTransferMode):
NP_ASFILE and NP_ASFILEONLY is now supported.

(WebKit::NetscapePluginStream::deliverData):
Call deliverDataToFile if necessary.

(WebKit::NetscapePluginStream::deliverDataToFile):
Create a temporary file and write the data into it.

(WebKit::NetscapePluginStream::stop):
If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to
call NPP_StreamAsFile and close the file and delete it.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelStreamLoad):
Keep a reference to the Stream since cancelling it will remove it from the map.

6:01 PM Changeset in webkit [63703] by jberlin@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Jessie Berlin <​jberlin@apple.com>

Windows build fix. Unreviewed.

  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeTestPluginPath):
5:25 PM Changeset in webkit [63702] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.
Update one more expected result missed in r63684.

  • platform/mac-leopard/accessibility/media-element-expected.txt:
5:07 PM Changeset in webkit [63701] by andersca@apple.com
  • 9 edits in trunk

Implement NPN_PostURLNotify
​https://bugs.webkit.org/show_bug.cgi?id=42602

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Read the buffer from a file if necessary and parse it.

(WebKit::NPN_GetURLNotify):
Add extra arguments.

(WebKit::NPN_PostURLNotify):
Parse the post buffer, then call NetscapePlugin::loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):
Pass the method, the header fields and form data along.

(WebKit::NetscapePlugin::allowPopups):
Just return false for now.

(WebKit::NetscapePlugin::initialize):
Pass extra arguments to loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:

Add method, header fields and form data.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):
Set the method, add the header fields and set the body.

4:55 PM Changeset in webkit [63700] by weinig@apple.com
  • 6 edits in trunk/WebKitTools

Remove dependency on getopt from WebKitTestRunner.

Reviewed by Jon Honeycutt.

  • Simplify options parsing and eliminate unused options.
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::testPluginPath):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

4:54 PM Changeset in webkit [63699] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed build fix.

Remove overzealous ASSERT from r63689
​https://bugs.webkit.org/show_bug.cgi?id=42606

No new tests because no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
4:36 PM Changeset in webkit [63698] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-19 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] MiniBrowser: Progress indication at address bar
​https://bugs.webkit.org/show_bug.cgi?id=42565

Reviewed by Antonio Gomes.

Make possible to see load progress at address bar based on
QtTestBrowser solution

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadProgress):
  • MiniBrowser/qt/BrowserWindow.h:
4:35 PM Changeset in webkit [63697] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-19 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
​https://bugs.webkit.org/show_bug.cgi?id=42564

Reviewed by Antonio Gomes.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserView::load): (BrowserWindow::BrowserWindow): (BrowserWindow::titleChanged): (BrowserWindow::urlChanged):
  • MiniBrowser/qt/BrowserWindow.h:
4:19 PM Changeset in webkit [63696] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Mark Rowe.

Web Inspector: Do Not Copy *.re2js Inspector Resources in XCode Build Phase
​https://bugs.webkit.org/show_bug.cgi?id=42601

Remove *.re2js files after copying them over in the Build Phase. We do
the same to remove the WebKit.qrc file.

  • WebCore.xcodeproj/project.pbxproj:
3:38 PM Changeset in webkit [63695] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/WebCore

Revert r63029 to address <rdar://problem/8202667>.

3:38 PM Changeset in webkit [63694] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Revert r63030 to address <rdar://problem/8202667>.

3:23 PM Changeset in webkit [63693] by weinig@apple.com
  • 8 edits
    10 adds in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
  • WebKitTestRunner/win/build-generated-files.sh: Added.
3:21 PM Changeset in webkit [63692] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <​ojan@chromium.org>

Unreviewed.
[chromium] Update test expectations after r63681.
Add new expected results for the clearly correct cases after r63684.

  • platform/chromium-mac/media/video-load-networkState-expected.txt:
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-load-networkState-expected.txt:
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [63691] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Update more tests/results missed in r63684.

  • accessibility/media-element.html:
  • media/unsupported-rtsp-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
2:58 PM Changeset in webkit [63690] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Clean up the buildbot configuration a little.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:55 PM Changeset in webkit [63689] by tonyg@chromium.org
  • 16 edits
    3 adds in trunk

2010-07-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
​https://bugs.webkit.org/show_bug.cgi?id=42512

  • fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document. (checkTimingNotChanged): (): (loadHandler):
  • fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
  • fast/dom/webtiming-navigate-within-document-expected.txt: Added.
  • fast/dom/webtiming-navigate-within-document.html: Added.
  • platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.

2010-07-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
​https://bugs.webkit.org/show_bug.cgi?id=42512

Test: fast/dom/webtiming-navigate-within-document.html

  • loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader. (WebCore::DocumentLoader::documentLoadTiming):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up. (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document. (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
  • loader/FrameLoader.h: Get rid of FrameLoadTimeline.
  • loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable. (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
  • page/Navigation.cpp: (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
  • page/Timing.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks. (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::redirectStart): (WebCore::Timing::redirectEnd): (WebCore::Timing::fetchStart): (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart): (WebCore::Timing::responseEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd): (WebCore::Timing::documentLoader): (WebCore::Timing::documentLoadTiming): (WebCore::Timing::resourceLoadTiming): (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
  • page/Timing.h:
2:18 PM Changeset in webkit [63688] by cmarrin@apple.com
  • 8 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.

LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.

2:05 PM Changeset in webkit [63687] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-07-19 Simon Fraser <Simon Fraser>

Reviewed by Brady Eidson.

Fix MiniBrowser to update URL as you browse
​https://bugs.webkit.org/show_bug.cgi?id=42591

Hook up various loading notifications to update the URL bar in MiniBrowser.

  • MiniBrowser/mac/BrowserWindowController.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): (-[BrowserWindowController didStartProvisionalLoadForFrame:]): (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): (-[BrowserWindowController didFailLoadWithErrorForFrame:]): (-[BrowserWindowController didCommitLoadForFrame:]):
1:53 PM Changeset in webkit [63686] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Update tests/results missed in r63684.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
1:38 PM Changeset in webkit [63685] by ap@apple.com
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

Updating test results.

  • platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: There are custom results for Tiger, adding new printout to it, as well.
  • platform/gtk/http/tests/misc: Added.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest: Added.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
  • platform/qt/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt. These platforms don't seem to have auth delegate calls, so we can't log auth dialogs.
1:11 PM Changeset in webkit [63684] by eric.carlson@apple.com
  • 19 edits in trunk

2010-07-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
​https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_completelyLoaded. (WebCore::HTMLMediaElement::parseMappedAttribute): Don't deal with 'load' event. (WebCore::HTMLMediaElement::prepareForLoad): Set m_completelyLoaded to false. (WebCore::HTMLMediaElement::setNetworkState): Don't post 'load' event. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if m_networkState != NETWORK_LOADING. (WebCore::HTMLMediaElement::userCancelledLoad): No more NETWORK_LOADED state.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
  • html/HTMLMediaElement.idl: Remove NETWORK_LOADING.

2010-07-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
​https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • media/audio-delete-while-slider-thumb-clicked.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/audio-delete-while-step-button-clicked.html: Ditto.
  • media/event-attributes-expected.txt:
  • media/event-attributes.html: Correct logic to check that 'progress' event(s) are fired while loading file, but not when src set to invalid file. 'abort' event is fired when the src is changed.
  • media/invalid-media-url-crash-expected.txt:
  • media/media-constants-expected.txt: No more NETWORK_LOADED state.
  • media/media-constants.html: No more NETWORK_LOADED state. Clean up test.
  • media/remove-from-document-expected.txt:
  • media/remove-from-document.html: Ditto.
  • media/video-controls-visible-audio-only.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/video-source-none-supported-expected.txt: No more NETWORK_LOADED state.
  • media/video-src-change-expected.txt: Ditto.
  • media/video-src-none-expected.txt:
  • media/video-src-none.html: No more NETWORK_LOADED state. Fix bogus test that generated "FAIL" in results.
1:08 PM Changeset in webkit [63683] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <​ojan@chromium.org>

Unreviewed.

[chromium] Update test_expectations with passing/flaky tests.
Add new chromium expected result from r63680.

  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [63682] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add local storage support for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42584

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::swap):

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLocalStorageEnabled):
(WKPreferencesGetLocalStorageEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setLocalStorageEnabled):
(WebKit::WebPreferences::localStorageEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):

1:03 PM Changeset in webkit [63681] by ap@apple.com
  • 6 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" case.
11:46 AM Changeset in webkit [63680] by ap@apple.com
  • 9 edits
    5 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=40996
Progress event should not be fired during synchronous XMLHttpRequest

​https://bugs.webkit.org/show_bug.cgi?id=17502
Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange

Tests: http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html

http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): We now only dispatch readystatechange event for synchronous requests in states UNSENT, OPENED and DONE. I'm not sure what exactly the spec draft says about readystatechange for sync requests, but this seems to be the most logical and backwards compatible behavior. (WebCore::XMLHttpRequest::didReceiveData): Don't dispatch progress events for sync requests. Note that we already don't dispatch upload progress events for those.
11:09 AM Changeset in webkit [63679] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
​https://bugs.webkit.org/show_bug.cgi?id=42578

  • platform/qt/Skipped: Add tests again until fix which were unskipped by r63657.
10:45 AM Changeset in webkit [63678] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <​ojan@chromium.org>

Unreviewed. Update expectations from ​http://trac.webkit.org/changeset/63672
and cleanup some unexpected passes.

  • platform/chromium-linux/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-linux/fast/forms/hidden-listbox-expected.png:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.png:
  • platform/chromium/test_expectations.txt:
10:34 AM Changeset in webkit [63677] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-07-19 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Uae an OwnPtr for the drawing area in WebPage (fixes a leak!).

  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::drawingArea):
10:26 AM Changeset in webkit [63676] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-19 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor npapi plugin copy step
​https://bugs.webkit.org/show_bug.cgi?id=42493

This is to avoid duplicate copy rules in the Linux make build.

  • WebKit.gyp:
  • DEPS: 52483:52869
10:19 AM Changeset in webkit [63675] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2010-07-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use OwnPtr for CodeBlock objects
​https://bugs.webkit.org/show_bug.cgi?id=42490

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): Moved this here and made it non-inline. Eliminated the code that used to initialize the raw pointer since it's now an OwnPtr. (JSC::EvalExecutable::~EvalExecutable): Removed the explicit delete here. (JSC::ProgramExecutable::ProgramExecutable): Ditto. (JSC::ProgramExecutable::~ProgramExecutable): Ditto. (JSC::FunctionExecutable::FunctionExecutable): Ditto. (JSC::FunctionExecutable::~FunctionExecutable): Ditto. (JSC::EvalExecutable::compileInternal): Added use of adoptPtr and get. (JSC::ProgramExecutable::compileInternal): Ditto. (JSC::FunctionExecutable::compileForCallInternal): Ditto. (JSC::FunctionExecutable::compileForConstructInternal): Ditto. (JSC::FunctionExecutable::recompile): Use clear instead of delete followed by assignment of 0.
  • runtime/Executable.h: Moved constructors to the cpp file and changed raw pointers to OwnPtr.
10:18 AM Changeset in webkit [63674] by weinig@apple.com
  • 7 edits
    3 deletes in trunk/WebKitTools

2010-07-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63671.
​http://trac.webkit.org/changeset/63671
​https://bugs.webkit.org/show_bug.cgi?id=42575

broke windows (Requested by weinig on #webkit).

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Removed.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::setStatusbarText):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setWaitToDump): (WTR::displayCallback): (WTR::dumpAsTextCallback): (WTR::dumpStatusCallbacksCallback): (WTR::waitUntilDoneCallback): (WTR::notifyDoneCallback): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::repaintSweepHorizontallyCallback): (WTR::testRepaintCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): (WTR::LayoutTestController::dumpStatusCallbacks): (WTR::LayoutTestController::setDumpStatusCallbacks): (WTR::LayoutTestController::setTestRepaint): (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:13 AM Changeset in webkit [63673] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix eol-style propety for the following file, otherwise svn-apply will fail.
​https://bugs.webkit.org/show_bug.cgi?id=42573

  • canvas/philip/tests.js: Added property svn:eol-style.
9:48 AM Changeset in webkit [63672] by mitz@apple.com
  • 4 edits
    8 adds in trunk

<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
​https://bugs.webkit.org/show_bug.cgi?id=34913

Reviewed by Simon Fraser.

WebCore:

Tests: fast/repaint/view-background-from-body-1.html

fast/repaint/view-background-from-body-2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.

LayoutTests:

  • fast/repaint/view-background-from-body-1.html: Added.
  • fast/repaint/view-background-from-body-2.html: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
9:43 AM Changeset in webkit [63671] by weinig@apple.com
  • 7 edits
    8 adds in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9:39 AM Changeset in webkit [63670] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

fix chromium linux compile on ubuntu maverick
​https://bugs.webkit.org/show_bug.cgi?id=42528

  • Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
9:23 AM Changeset in webkit [63669] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-19 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Live edit is not working in chromium.
​https://bugs.webkit.org/show_bug.cgi?id=42572

  • src/js/DebuggerScript.js:
9:21 AM Changeset in webkit [63668] by Adam Roben
  • 4 edits in trunk/WebKitTools

When dumping a response's MIME type, print its URL's last path component rather than its suitable-for-test-result form

This matches the Mac behavior.

Fixes <​http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.

9:21 AM Changeset in webkit [63667] by Adam Roben
  • 2 edits in trunk/WebCore

Fix an assertion when a plugin returns -1 from NPP_Write

We were forgetting to call setDefersLoading(false) before destroying
the PluginStream. In the process of destroying the stream, someone
would call setDefersLoading(true), and we would assert because we were
already deferring loads.

Fixes <​http://webkit.org/b/42563> Assertion failure in
ResourceHandle::setDefersLoading when running
plugins/return-negative-one-from-write.html on Windows

Reviewed by Anders Carlsson.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::deliverData): Call setDefersLoading(false)
before destroying the stream, to match the setDefersLoading(true) call
earlier in this function. (We already call setDefersLoading(false) in
the non-error case later on.)

9:06 AM Changeset in webkit [63666] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix some EFL theme issues
​https://bugs.webkit.org/show_bug.cgi?id=42569

Keep a pointer to theme filename and check for it correctly.
Reduce the scope of some variables.
Don't test for platformWidget() since we are not using it.

No new tests, no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyCursor): (WebCore::Widget::setCursor):
8:52 AM Changeset in webkit [63665] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add ifdef to compile code just on presence of Ecore_X
​https://bugs.webkit.org/show_bug.cgi?id=42567

No new tests since there's no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setEvasObject): Add #ifdef HAVE_ECORE_X to it.
8:29 AM Changeset in webkit [63664] by andersca@apple.com
  • 19 edits
    2 copies in trunk

WebKit2 does not have application cache
​https://bugs.webkit.org/show_bug.cgi?id=42552

Reviewed by Adam Roben.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add SetApplicationCacheDirectory.

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
add offlineWebApplicationCacheEnabled.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetOfflineWebApplicationCacheEnabled):
(WKPreferencesGetOfflineWebApplicationCacheEnabled):

  • UIProcess/API/C/WKPreferences.h:

Add getters/setters for whether the application cache is enabled.

  • UIProcess/WebContext.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setOfflineWebApplicationCacheEnabled):
Update the store and call update().

  • UIProcess/WebPreferences.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
Ask the web process to set the application cache directory.

  • UIProcess/mac/WebContextMac.mm: Added.

(WebKit::WebContext::applicationCacheDirectory):
Return the application cache directory.

  • UIProcess/win/WebContextWin.cpp: Added.

(WebKit::WebContext::applicationCacheDirectory):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj:

Add WebContextMac.mm

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::preferencesDidChange):

(WebKit::WebPage::didReceiveMessage):
Handle PreferencesDidChange. Get rid of the default: case statement so we'll
get warnings if we have unhandled message kinds.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setApplicationCacheDirectory):
Set the application cache directory.

(WebKit::WebProcess::didReceiveMessage):
Handle SetApplicationCacheDirectory.

win/WebKit2.vcproj:
Add WebContextWin.cpp

WebKitTools:

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.

(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.

  • WebKitTestRunner/TestInvocation.h:

LayoutTests:

  • platform/mac-wk2/Skipped:

Remove http/tests/appcache from skipped list.

8:23 AM Changeset in webkit [63663] by yurys@chromium.org
  • 5 edits in trunk

2010-07-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[chromium] inspector/console-trace.html failing on windows after r63548
​https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/console-trace.html: call dumpConsoleMessages sycnhronously right after console.trace
  • platform/chromium/test_expectations.txt:

2010-07-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add/removeStyleClass shouldn't increase number of spaces between class names.
​https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/front-end/utilities.js: (Element.prototype.removeStyleClass):
8:19 AM Changeset in webkit [63662] by yurys@chromium.org
  • 15 edits in trunk/WebCore

2010-07-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show stack trace for uncaught exceptions when Web Inspector is open.
​https://bugs.webkit.org/show_bug.cgi?id=42560

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype.toString):
  • inspector/front-end/inspector.css: (.console-message.repeated-message > ol.stack-trace): (.section .properties ol, .event-properties ol, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.section .properties ol.expanded, .event-properties ol.expanded, .stack-trace ol, ol.stack-trace):
  • page/Console.cpp: (WebCore::Console::addMessage):
  • page/Console.h: (WebCore::):
8:12 AM Changeset in webkit [63661] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Roben.

Fix NewRunWebKitTests to work on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=41180

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Specifying python explicitly.
8:05 AM Changeset in webkit [63660] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Robin Burchell <​robin.burchell@collabora.co.uk>

Reviewed by Antonio Gomes

[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.

Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: ​https://bugs.webkit.org/show_bug.cgi?id=42392

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
7:52 AM Changeset in webkit [63659] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-07-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check
​https://bugs.webkit.org/show_bug.cgi?id=42284

New name is isEquivalentColor(CanvasStyle).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
  • html/canvas/CanvasStyle.h:
7:50 AM Changeset in webkit [63658] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Remove non-existent files from Skipped list.

  • platform/qt/Skipped:
    • Unskip fast/dynamic/flash-replacement-test.html, because it was removed by r61289
    • Rename fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2.html after r63284
    • Unskip inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r63314
    • Unskip media/video-src-empty.html, because it was removed by r63119
7:27 AM Changeset in webkit [63657] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
​https://bugs.webkit.org/show_bug.cgi?id=42510

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
​https://bugs.webkit.org/show_bug.cgi?id=42510

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.alpha.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.2.html
  • canvas/philip/tests/2d.shadow.image.alpha.html
  • canvas/philip/tests/2d.shadow.image.transparent.1.html
  • canvas/philip/tests/2d.shadow.image.transparent.2.html
  • platform/qt/Skipped:
7:24 AM Changeset in webkit [63656] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
​https://bugs.webkit.org/show_bug.cgi?id=42508

  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
​https://bugs.webkit.org/show_bug.cgi?id=42508

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.basic.html

Reskip (bug now exposed):

  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • platform/qt/Skipped:
7:12 AM Changeset in webkit [63655] by Csaba Osztrogonác
  • 1 edit
    45 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing SVG tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/qt/svg/custom/convolution-crash-expected.checksum: Added.
  • platform/qt/svg/custom/convolution-crash-expected.png: Added.
  • platform/qt/svg/custom/convolution-crash-expected.txt: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.png: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt.
  • platform/qt/svg/custom/recursive-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.png: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.txt: Added.
  • platform/qt/svg/custom/recursive-mask-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-mask-expected.png: Added.
  • platform/qt/svg/custom/recursive-mask-expected.txt: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.png: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.png: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.checksum.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt.
  • platform/qt/svg/filters/filter-empty-g-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.checksum.
  • platform/qt/svg/filters/filter-empty-g-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
  • platform/qt/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/qt/svg/filters/filter-width-update-expected.png: Added.
  • platform/qt/svg/filters/filter-width-update-expected.txt: Added.
7:08 AM Changeset in webkit [63654] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
​https://bugs.webkit.org/show_bug.cgi?id=36973

Remove erroneous optimization that ignored painting calls when
the stroke/fill color had an alpha value of zero.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
​https://bugs.webkit.org/show_bug.cgi?id=36973

Unskip fast/canvas/canvas-composite-alpha.html

  • platform/qt/Skipped:
7:06 AM Changeset in webkit [63653] by andreas.kling@nokia.com
  • 3 edits
    1 add in trunk/WebCore

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

CSS3 background: Number of layers should be determined by background-image element count
​https://bugs.webkit.org/show_bug.cgi?id=41201

Manual test: css3-background-layer-count.html

Spec link:
​http://www.w3.org/TR/css3-background/#layering

  • manual-tests/css3-background-layer-count.html: Added.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): Don't repeat image properties, they determine the total number of layers. (WebCore::FillLayer::cullEmptyLayers): Change culling logic to discard all layers after the first one without an image set.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): Call fillUnsetProperties() before cullEmptyLayers() (WebCore::InheritedFlags::adjustMaskLayers): Ditto.
5:45 AM Changeset in webkit [63652] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid QImage::pixel() in getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=42463

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Use QImage::scanLine() instead of fetching data pixel-by-pixel.
5:43 AM Changeset in webkit [63651] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-19 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix build on 64-bit systems. According to
JavaScriptCore/wtf/Platform.h, x86_64 uses fixed allocator, which
needs jit/ExecutableAllocatorFixedVMPool.cpp to be included in build
system.
​https://bugs.webkit.org/show_bug.cgi?id=42559

  • CMakeListsEfl.txt: add missing file for x86_64.
5:28 AM Changeset in webkit [63650] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-19 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Fix test expectations
​https://bugs.webkit.org/show_bug.cgi?id=42556

text-rotated-gradient.svg is flaky on linux, and clip-path-child-changes.svg
isn't actually flaky.

  • platform/chromium/test_expectations.txt:
5:17 AM Changeset in webkit [63649] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: hide "toggle debugger" button when debugger is always enabled
​https://bugs.webkit.org/show_bug.cgi?id=42558

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
4:52 AM Changeset in webkit [63648] by ager@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-07-19 Mads Ager <​ager@chromium.org>

Reviewed by Pavel Feldman.

Remove chromium rebaselines for document.all layout test.
​https://bugs.webkit.org/show_bug.cgi?id=42557

V8 changed behavior to match JSC completely on document.all. Remove
chromium rebaseline.

  • platform/chromium-mac/fast/dom/undetectable-document-all-expected.txt: Removed.
  • platform/chromium-win/fast/dom/undetectable-document-all-expected.txt: Removed.
3:54 AM Changeset in webkit [63647] by kent.hansen@nokia.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Kent Hansen <​kent.hansen@nokia.com>

Unreviewed, fix failure introduced in r63645.
Ignore jscprint property since it only appears in
debug builds (as per window-property-descriptors test).

  • fast/dom/Window/window-properties.html:
2:40 AM Changeset in webkit [63646] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-19 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
​https://bugs.webkit.org/show_bug.cgi?id=42466

(Original problem at ​https://bugs.webkit.org/show_bug.cgi?id=42447)

No new functionality so no new tests.

  • dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Move here to avoid needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h.
  • dom/DeviceOrientationEvent.h:
1:23 AM Changeset in webkit [63645] by kent.hansen@nokia.com
  • 5 edits in trunk/LayoutTests

2010-07-19 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Sam Weinig.

Improve coverage of fast/dom/Window/window-properties test
​https://bugs.webkit.org/show_bug.cgi?id=42258

Use Object.getOwnPropertyNames to cover ECMA properties
and other native properties.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
Note: See TracTimeline for information about the timeline view.