Timeline
Jul 21, 2010:
- 11:52 PM Changeset in webkit [63877] by
-
- 13 edits in trunk
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
- platform/mac-wk2/Skipped: Moved some tests into the correct section now that dumpChildFrameScrollPositions is no longer the reason they fail. Removed now-passing test. Resorted some of the tests.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file. (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name. Changed to a file-internal function instead of a member function. (WTR::dumpDescendantFrameScrollPositions): Added. (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added. (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when appropriate. Also streamlined all the WKStringToUTF8 call sites. (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8. (WTR::InjectedBundlePage::willSetStatusbarText): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpAllFrameScrollPositions. (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from shouldDumpFrameScrollPositions.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions, and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
Added WKBundleFrameCopyName.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyName): Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name): Added.
- WebProcess/WebPage/WebFrame.h: Ditto.
- 8:08 PM Changeset in webkit [63876] by
-
- 3 edits3 adds in trunk
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
- fast/forms/input-value-sanitization-expected.txt: Added.
- fast/forms/input-value-sanitization.html: Added.
- fast/forms/script-tests/input-value-sanitization.js: Added.
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
Test: fast/forms/input-value-sanitization.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the value by HTMLInputElement::sanitizeValue() in a case that storesValueSeparateFromAttribute() state is not changed.
- 7:12 PM Changeset in webkit [63875] by
-
- 1 edit1 add in trunk/LayoutTests
2010-07-21 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Added platform test to account for qt's xml parser
- platform/qt/svg/custom/use-invalid-html-expected.txt: Added.
- 6:54 PM Changeset in webkit [63874] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Copy the test plugin into DumpRenderTree.app/
https://bugs.webkit.org/show_bug.cgi?id=42733
This was dropped in plugin copy refactoring.
- WebKit.gyp:
- 6:27 PM Changeset in webkit [63873] by
-
- 4 edits2 adds18 deletes in trunk/LayoutTests
dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html
https://bugs.webkit.org/show_bug.cgi?id=42608
Reviewed by Ojan Vafai.
Converted the tests and removed the platform specific expected results.
- editing/execCommand/create-list-from-range-selection-expected.txt: Added.
- editing/execCommand/create-list-from-range-selection.html: Use dumpAsMarkup
- editing/execCommand/insert-list-empty-div-expected.txt: Added.
- editing/execCommand/insert-list-empty-div.html: Use dumpAsMarkup
- platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.png: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.png: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/qt/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/qt/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- resources/dump-as-markup.js: Added setNodeToDump.
(Markup.setNodeToDump):
- 6:10 PM Changeset in webkit [63872] by
-
- 4 edits1 add in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Add a test showing that our parsing of unquoted attributes in
self-closing tags complies with the spec.
- html5lib/resources/webkit02.dat: Added.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 6:08 PM Changeset in webkit [63871] by
-
- 4 edits in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Let's pass the doctype01.dat tests again, please
https://bugs.webkit.org/show_bug.cgi?id=42794
The upstream results check the publicId and the systemId, so we need to
make dom2string smarter and print them.
- html5lib/resources/dom2string.js: (dom2string):
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 6:04 PM Changeset in webkit [63870] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
- html5lib/runner-expected-html5.txt:
- 6:03 PM Changeset in webkit [63869] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791
We need to atomize these strings at some point.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791
Testing makes perfect.
- html5lib/runner-expected-html5.txt:
- 6:00 PM Changeset in webkit [63868] by
-
- 7 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233
The spec has some typos in this area, but this is my best guess for
what Ian means. I've filed bugs against the spec for each typo.
- html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLElementStack::inButtonScope):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processEndTagForInBody):
- html/HTMLTreeBuilder.h:
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233
Test progression. There's one regression mixed in here. I'll
investigate in the next patch.
- html5lib/runner-expected-html5.txt:
- 5:58 PM Changeset in webkit [63867] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Removed comment element for test added with:
http://trac.webkit.org/changeset/63865
- svg/custom/use-invalid-html-expected.txt:
- svg/custom/use-invalid-html.xhtml:
- 5:46 PM Changeset in webkit [63866] by
-
- 17 edits in trunk
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
- platform/mac-wk2/Skipped: Removed now-passing tests from skipped list and moved one miscategorized test.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
- MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef. (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate. (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition. (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added. (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches the logic in DumpRenderTree.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
- WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
Added WKBundleFrameGetJavaScriptContext function.
- WebKit2.xcodeproj: Added property svn:ignore.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld): Use JSGlobalContextRef instead of JSContextRef and context instead of ct.
- 5:36 PM Changeset in webkit [63865] by
-
- 3 edits2 adds in trunk
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
Test: svg/custom/use-invalid-html.xhtml
- dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
- svg/custom/use-invalid-html-expected.txt: Added.
- svg/custom/use-invalid-html.xhtml: Added.
- 4:53 PM Changeset in webkit [63864] by
-
- 84 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins
Reviewed by Dan Bernstein.
GraphicsContext::clipConvexPolygon() now takes a boolean parameter
indicating whether or not the clip should be antialiased.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
Compute 4 booleans determining if each edge is a "matching" edge of
not. Send the two appropriate values to clipBorderSidePolygon() so
we can decide there whether or not to antialias the clip based on
matchy-ness.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
If both edges are matching, don't antialias. If neither edge
matches, never antialias. If one edge matches and one does not,
apply two clips to get the appropriate antialiasing in each corner.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
- rendering/RenderBoxModelObject.h:
LayoutTests: Some of these layout tests are updated results from the fix for
https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins.
The others have been in need of an update since
https://bugs.webkit.org/show_bug.cgi?id=9197 , but since the
differences were only detectable visually and with a pixel-text
tolerance of 0 (not the default), they slipped under the rug until
now.
Reviewed by Dan Bernstein.
New test:
- fast/borders/different-color-borders.html: Added.
- platform/mac/fast/borders/border-radius-circle-expected.checksum:
- platform/mac/fast/borders/border-radius-circle-expected.png:
- platform/mac/fast/borders/border-radius-constraints-expected.checksum:
- platform/mac/fast/borders/border-radius-constraints-expected.png:
- platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-01-expected.png:
- platform/mac/fast/borders/border-radius-groove-02-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-02-expected.png:
- platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-03-expected.png:
- platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
- platform/mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/mac/fast/borders/borderRadiusArcs01-expected.checksum:
- platform/mac/fast/borders/borderRadiusArcs01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed02-expected.png:
- platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed03-expected.png:
- platform/mac/fast/borders/borderRadiusDashed04-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/mac/fast/borders/borderRadiusDotted04-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/mac/fast/borders/borderRadiusDouble02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/mac/fast/borders/borderRadiusDouble03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble03-expected.png:
- platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble05-expected.png:
- platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble08-expected.png:
- platform/mac/fast/borders/borderRadiusGroove01-expected.checksum:
- platform/mac/fast/borders/borderRadiusGroove01-expected.png:
- platform/mac/fast/borders/borderRadiusGroove02-expected.checksum:
- platform/mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/mac/fast/borders/borderRadiusInset01-expected.checksum:
- platform/mac/fast/borders/borderRadiusInset01-expected.png:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/mac/fast/borders/borderRadiusOutset01-expected.checksum:
- platform/mac/fast/borders/borderRadiusOutset01-expected.png:
- platform/mac/fast/borders/borderRadiusRidge01-expected.checksum:
- platform/mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid01-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid02-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid02-expected.png:
- platform/mac/fast/borders/borderRadiusSolid03-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid03-expected.png:
- platform/mac/fast/borders/borderRadiusSolid04-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid04-expected.png:
- platform/mac/fast/borders/different-color-borders-expected.checksum: Added.
- platform/mac/fast/borders/different-color-borders-expected.png: Added.
- platform/mac/fast/borders/different-color-borders-expected.txt: Added.
- platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.png:
- 4:19 PM Changeset in webkit [63863] by
-
- 19 edits2 adds in trunk
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal): (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess): (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
- Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::addLocalScheme): (QWebSecurityOrigin::removeLocalScheme): (QWebSecurityOrigin::localSchemes):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- WebView.cpp: (WebView::registerURLSchemeAsLocal): (WebView::registerURLSchemeAsSecure):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- WebView/WebView.mm: (+[WebView _registerURLSchemeAsSecure:]): (+[WebView registerURLSchemeAsLocal:]):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
No new tests. (No change in behavior)
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::loadFrameRequest):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canLoad): (WebCore::SecurityOrigin::isLocal):
- page/SecurityOrigin.h:
- platform/SchemeRegistry.cpp: Added. (WebCore::localSchemes): (WebCore::secureSchemes): (WebCore::schemesWithUniqueOrigins): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localURLSchemes): (WebCore::SchemeRegistry::shouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::registerURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure):
- platform/SchemeRegistry.h: Added.
- 4:16 PM Changeset in webkit [63862] by
-
- 3 edits in trunk/WebCore
2010-07-21 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Assertion failure in AnimationBase::updateStateMachine() coming out of paused state
https://bugs.webkit.org/show_bug.cgi?id=37993
Added logic to properly handle pausing and resuming when in the
AnimationStateStartWaitStyleAvailable state. This was causing an
assert when going out of the pause state because the paused flag
was not set.
The fix is a straightforward implementation, going into a new
AnimationStatePausedWaitStyleAvailable state and setting the paused
flag (actually setting the m_pauseTime variable to something other
than -1). Also added handling of the new state, both when the
"style available" callback comes in while in this state and when
unpausing while in this state.
For now a LayoutTest is not possible since there's no way to go in
and out of the pause state. I've opened https://bugs.webkit.org/show_bug.cgi?id=42790
to track this.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h: (WebCore::AnimationBase::):
- 3:59 PM Changeset in webkit [63861] by
-
- 7 edits in trunk/LayoutTests
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Darin Adler.
Updated six more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42788
- css3/khtml-background-size-0x0-bmp.html:
- editing/deleting/delete-3959464-fix.html:
- editing/deleting/delete-and-undo.html:
- editing/deleting/delete-at-paragraph-boundaries-001.html:
- editing/deleting/delete-at-paragraph-boundaries-002.html:
- editing/deleting/delete-at-paragraph-boundaries-003.html:
- 3:46 PM Changeset in webkit [63860] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Skip html5lib/runner.html on these platforms because the
<keygen> element creates a different DOM. I need to
investigate why they're getting a different DOM, but I don't
have time to do that right now.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:12 PM Changeset in webkit [63859] by
-
- 6 edits2 adds in trunk
2010-07-21 Bo Liu <boliu@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295
- platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::):
2010-07-21 Bo Liu <boliu@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295
- WebKit.gyp:
- public/WebMediaElement.h: Added.
- src/WebMediaElement.cpp: Added. (WebKit::WebMediaElement::player): (WebKit::WebMediaElement::WebMediaElement): (WebKit::WebMediaElement::operator=): (WebKit::WebMediaElement::operator PassRefPtr<HTMLMediaElement>):
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::fromMediaElement): (WebKit::WebMediaPlayerClientImpl::mediaPlayer): (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::platformMedia):
- src/WebMediaPlayerClientImpl.h:
- 2:41 PM Changeset in webkit [63858] by
-
- 11 edits7 adds in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pull HTML5lib test suite from upstream
https://bugs.webkit.org/show_bug.cgi?id=42776
Grab a bunch of new tests from html5lib upstream. Also, upstream
tweaked some of our tests, so I've updated our tests to match the
upstream tweaks.
- html5lib/resources/adoption01.dat:
- html5lib/resources/doctype01.dat:
- html5lib/resources/scripted/adoption01.dat: Added.
- html5lib/resources/scripted/webkit01.dat: Added.
- html5lib/resources/tests1.dat:
- html5lib/resources/tests17.dat: Added.
- html5lib/resources/tests18.dat: Added.
- html5lib/resources/tests19.dat: Added.
- html5lib/resources/tests2.dat:
- html5lib/resources/tests20.dat: Added.
- html5lib/resources/tricky01.dat:
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- html5lib/webkit-resumer-expected.txt:
- 2:16 PM Changeset in webkit [63857] by
-
- 15 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
convert more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42786
This is a follow up to r63854.
- fast/backgrounds/size/backgroundSize02.html:
- fast/backgrounds/size/backgroundSize03.html:
- fast/backgrounds/size/backgroundSize04.html:
- fast/backgrounds/size/backgroundSize05.html:
- fast/backgrounds/size/backgroundSize06.html:
- fast/backgrounds/size/backgroundSize07.html:
- fast/backgrounds/size/backgroundSize08.html:
- fast/backgrounds/size/backgroundSize09.html:
- fast/backgrounds/size/backgroundSize10.html:
- fast/backgrounds/size/backgroundSize11.html:
- fast/backgrounds/size/backgroundSize12.html:
- fast/backgrounds/size/backgroundSize13.html:
- fast/backgrounds/size/backgroundSize14.html:
- fast/backgrounds/size/backgroundSize15.html:
- 2:07 PM Changeset in webkit [63856] by
-
- 6 edits in trunk
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771
Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
- WebCore.exp.in:
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
- page/FrameView.h:
- 1:54 PM Changeset in webkit [63855] by
-
- 2 edits in trunk/WebKit2
Handle broken pipes in more places in CoreIPC
Fixes <http://webkit.org/b/42784> Assertion failure in
Connection::readEventHandler when WebKitTestRunner exits
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Check for a broken pipe
whenever we call ::PeekNamedPipe.
- 1:39 PM Changeset in webkit [63854] by
-
- 38 edits2 adds in trunk
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Eric Carlson.
Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).
Listed properties in these updated have been changed to -webkit.
- fast/block/positioning/height-change.html: -apple-box
- fast/block/positioning/resources/window-height-change-frame-flex.html: -apple-box
- fast/borders/border-image-omit-right-slice.html: -khtml-border-image
- fast/css/apple-prefix.html: -khtml-box-orient
- fast/css/legacy-opacity-styles-expected.txt: -*-opacity
- fast/css/legacy-opacity-styles.html: -*-opacity
- fast/css/limited-vendor-prefix-behavior-expected.txt: Added.
- fast/css/limited-vendor-prefix-behavior.html: Added.
- fast/flexbox/001.html: -khtml-box-flex
- fast/flexbox/002.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/flexbox/003.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/flexbox/004.html: -khtml-box
- fast/flexbox/005.html: -khtml-box
- fast/flexbox/006.html: -khtml-box
- fast/flexbox/007.html: -khtml-box
- fast/flexbox/008.html: -khtml-box
- fast/flexbox/009.html: -khtml-box
- fast/flexbox/010.html: -khtml-box
- fast/flexbox/011.html: -khtml-box, -khtml-box-flex
- fast/flexbox/012.html: -khtml-box, -khtml-box-orient, -khtml-box-align
- fast/flexbox/013.html: -khtml-box, -khtml-box-flex
- fast/flexbox/014.html: -khtml-box, -khtml-box-orient, -khtml-box-flex
- fast/flexbox/015.html: -khtml-box, -khtml-box-flex, -khtml-box-flex
- fast/flexbox/016.html: -khtml-box-flex, -khtml-box, -khtml-box-orient
- fast/flexbox/017.html: -khtml-box, -khtml-box-orient, -webkit-box-pack, -khtml-box-direction
- fast/flexbox/018.html: -khtml-box, -khtml-box-orient, -khtml-box-pack
- fast/flexbox/019.html: -khtml-box, -khtml-box-pack, -khtml-box-orient
- fast/flexbox/020.html: -khtml-box, -khtml-box-flex-group, -khtml-box-flex
- fast/flexbox/021.html: -khtml-box, -khtml-box-flex
- fast/flexbox/022.html: -khtml-box, -khtml-box-flex
- fast/flexbox/023.html: -khtml-box
- fast/flexbox/024.html: -khtml-box, -khtml-box-orient
- fast/flexbox/025.html: -khtml-box, -khtml-box-flex
- fast/flexbox/026.html: -khtml-box, -khtml-box-flex
- fast/flexbox/child-flexing.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/repaint/flexible-box-overflow-horizontal.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/repaint/flexible-box-overflow.html: -khtml-box, -khtml-box-align, -khtml-box-orient
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Eric Carlson.
Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).
Test: fast/css/limited-vendor-prefix-behavior.html
- css/CSSParser.cpp: (WebCore::cssPropertyID):
- 1:30 PM Changeset in webkit [63853] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
- 1:25 PM Changeset in webkit [63852] by
-
- 2 edits in trunk/WebKit2
Teach CoreIPC how to handle messages that are larger than the pipe's buffer
::GetOverlappedResult and ::ReadFile can fail with ERROR_MORE_DATA
when there is more data available on the pipe than was requested in
the read operation. In those cases, the appropriate response is to
perform another read operation to read the extra data. We now do this.
Also, MSDN says that, because we are doing asynchronous read
operations, we should not pass a pointer to ::ReadFile to find out how
many bytes were read. Instead we should always call
::GetOverlappedResult to find this out. I've changed
Connection::readEventHandler to have a single loop that calls
::GetOverlappedResult and ::ReadFile in alternation, rather than
sometimes calling ::ReadFile multiple times in a row, to satisfy this
requirement.
In order to simplify the logic in this function, I've made us request
only a single byte from the pipe when there are no messages already in
the pipe. (Previously we were requesting 4096 bytes in this case.)
This allows us not to have to consider the case where the received
message is smaller than our read buffer. If we decide that this has a
negative impact on performance, we can of course change it. I've
mitigated this somewhat by using ::PeekNamedMessage to find out the
size of the next message in the pipe (if any), so that we can read it
all in one read operation.
Fixes <http://webkit.org/b/42710> <rdar://problem/8197571> Assertion
in Connection::readEventHandler when launching WebKitTestRunner
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Put the call to
::GetOverlappedResult in the same loop as ::ReadFile so that we will
call them alternately. If ::GetOverlappedResult fails with
ERROR_MORE_DATA, use ::PeekNamedPipe to determine the size of the rest
of the message, then read it from the pipe. After dispatching the
message, use ::PeekNamedPipe to find out the size of the next message
in the pipe so we can read it all in one operation. If there's no
message in the pipe, we'll request just a single byte of the next
message that becomes available, and Windows will tell us when the rest
of the message is ready. If ::ReadFile fails with ERROR_MORE_DATA it
means there is data available now even though we didn't think there
was any. We go back to the top of the loop in this case and call
::GetOverlappedResult again to retrieve the available data.
- 1:23 PM Changeset in webkit [63851] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix the last tree HTML5 tree builder crashes
https://bugs.webkit.org/show_bug.cgi?id=42773
This patch changes the internal representation of a bookmark to handle
the case where one of the adjecent entries in the list of active
formatting elements is actually a marker.
After this patch, the bookmarking mechanism isn't as general, but it
works for the cases we need in the adoption agency.
Also, after this patch, there aren't any more known crashers in the
HTML5 tree builder. :)
- html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::bookmarkFor): (WebCore::HTMLFormattingElementList::swapTo):
- html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::Bookmark::Bookmark): (WebCore::HTMLFormattingElementList::Bookmark::moveToAfter): (WebCore::HTMLFormattingElementList::Bookmark::hasBeenMoved): (WebCore::HTMLFormattingElementList::Bookmark::mark): (WebCore::HTMLFormattingElementList::first):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 1:10 PM Changeset in webkit [63850] by
-
- 10 edits in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
Reviewed by Anders Carlsson.
WebKit2:
- Convert injected bundle UIClient functions to will-style, at least until we establish more concrete use cases for them past the TestRunner.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::setStatusbarText):
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_willAddMessageToConsole):
(WTR::InjectedBundlePage::_willSetStatusbarText):
(WTR::InjectedBundlePage::_willRunJavaScriptAlert):
(WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
LayoutTests:
- platform/mac-wk2/Skipped:
- 12:38 PM Changeset in webkit [63849] by
-
- 2 edits in trunk/WebCore
2010-07-21 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Disable overzealous ASSERT
https://bugs.webkit.org/show_bug.cgi?id=42775
No new tests because no changed functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 12:27 PM Changeset in webkit [63848] by
-
- 3 edits in trunk/WebKit2
2010-07-21 Simon Fraser <Simon Fraser>
Windows build fix.
Need to supply implementations of PageClient::pageDidEnterAcceleratedCompositing()
and pageDidLeaveAcceleratedCompositing() for WebView on Windows.
- UIProcess/win/WebView.cpp: (WebKit::WebView::pageDidEnterAcceleratedCompositing): (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
- UIProcess/win/WebView.h:
- 11:38 AM Changeset in webkit [63847] by
-
- 5 edits in trunk/WebCore
2010-07-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=42534
Call NotificationsCenter::disconnectFrame() when the frame is disconnected from the page.
Calling it from the destructor of Frame is too late and sometimes causes access violation.
I was not able to reproduce this crash, so did not add new tests.
This patch is based on the error reported in
http://code.google.com/p/chromium/issues/detail?id=49323.
- page/DOMWindow.cpp: (WebCore::DOMWindow::pageDestroyed):
- page/DOMWindow.h:
- page/Frame.cpp: (WebCore::Frame::pageDestroyed):
- 11:16 AM Changeset in webkit [63846] by
-
- 5 edits in trunk
Don't assert when clicking on a plug-in in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42762
Reviewed by Sam Weinig.
WebCore:
Remove a now invalid assert and return false instead.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
WebKit2:
Add stub for PluginView::handleEvent.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
- WebProcess/Plugins/PluginView.h:
- 11:14 AM Changeset in webkit [63845] by
-
- 7 edits in trunk/WebCore
2010-07-21 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Revert r60670 as it introduced a regression: in some cases named children couldn't be retrieved.
https://bugs.webkit.org/show_bug.cgi?id=42766
See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- 10:53 AM Changeset in webkit [63844] by
-
- 16 edits in trunk
2010-07-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Only call m_player->setControls when the 'controls' attribute changes. (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): If we have a proxy widget, call the WebFrameLoaderClient's 'hide' and 'show' methods for the media proxy plug-in to make sure we remove and re-add the plug-in's view to the global list of plugin views. (WebCore::HTMLMediaElement::createMediaPlayerProxy): Bail if m_proxyWidget is non-NULL
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::hideMediaPlayerProxyPlugin): Empty stub method. (WebCore::EmptyFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.
- loader/FrameLoader.cpp:
- loader/FrameLoaderClient.h:
- loader/SubframeLoader.cpp: (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): Always set m_containsPlugIns in loadMediaPlayerProxyPlugin(), even when we don't have a renderer. (WebCore::FrameLoader::hideMediaPlayerProxyPlugin): New, call hideMediaPlayerProxyPlugin. (WebCore::FrameLoader::showMediaPlayerProxyPlugin): New, call showMediaPlayerProxyPlugin.
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setControls): (WebCore::MediaPlayer::setControls): New, pass through to media engine. (WebCore::MediaPlayer::enterFullscreen): Ditto. (WebCore::MediaPlayer::exitFullscreen): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setControls): (WebCore::MediaPlayerPrivateInterface::enterFullscreen): (WebCore::MediaPlayerPrivateInterface::exitFullscreen):
2010-07-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>
- Plugins/WebPluginController.h:
- Plugins/WebPluginController.mm: (-[WebPluginController dealloc]): Release _viewsNotInDocument. (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document. (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument. (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews. (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media player proxy plug-in should never be allocated by this method. (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
- WebView/WebView.mm: (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't consider the arePlugInsEnabled preference.
- WebView/WebViewInternal.h:
- 10:51 AM Changeset in webkit [63843] by
-
- 25 edits in trunk/WebKit2
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084
Hook up dynamic DrawingArea switching, so that when the WebProcess hits a page
that requires accelerated compositing, we switch to the LayerBackedDrawingArea.
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: (DrawingAreaProxyMessage::):
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing): (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
- UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]): (-[WKView _pageDidEnterAcceleratedCompositing]): (-[WKView _pageDidLeaveAcceleratedCompositing]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage):
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::): (WebKit::DrawingAreaProxy::type):
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize): (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage): (WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):
- UIProcess/LayerBackedDrawingAreaProxy.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDrawingArea): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::didEnterAcceleratedCompositing): (WebKit::WebPageProxy::didLeaveAcceleratedCompositing):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h: (WebKit::ChunkedUpdateDrawingArea::attachCompositingContext): (WebKit::ChunkedUpdateDrawingArea::setRootCompositingLayer):
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::): (WebKit::DrawingArea::type):
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::didUpdate): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
- WebProcess/WebPage/LayerBackedDrawingArea.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::exitAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
- 10:46 AM Changeset in webkit [63842] by
-
- 2 edits in trunk/WebCore
2010-07-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Make more members of CSSStyleSelector private.
https://bugs.webkit.org/show_bug.cgi?id=42757
No change in behavior, so no new tests.
- css/CSSStyleSelector.h: Made a publicly-unused methods private.
- 10:44 AM Changeset in webkit [63841] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
Avoid crashing during find-in-page when |view| is NULL.
https://bugs.webkit.org/show_bug.cgi?id=42760
There are no layout tests because we don't have a repro case
to work with, so this is a speculative fix based on crash dump
diagnosis. See bug for details.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches):
- 10:36 AM Changeset in webkit [63840] by
-
- 2 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Not reviewed, updating chromium test expectations.
Remove expectations for tests that were moved to platform/mac in r63616.
- platform/chromium/test_expectations.txt:
- 10:32 AM Changeset in webkit [63839] by
-
- 2 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Not reviewed, updating chromiumg test expectations.
- platform/chromium/test_expectations.txt: Marking remember-bad-password.html and
401-logout.php as failing.
- 10:30 AM Changeset in webkit [63838] by
-
- 2 edits4 adds in trunk/WebKitSite
2010-07-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Add a diagram explaining how a DOM element is attached to the site.
https://bugs.webkit.org/show_bug.cgi?id=42763
- coding/dom-element-attach.html: Added.
- coding/images/dom-element-attach-large.png: Added.
- coding/images/dom-element-attach-small.png: Added.
- coding/images/dom-element-attach.graffle: Added.
- coding/technical-articles.html: Added a link to the page with the diragram.
- 10:26 AM Changeset in webkit [63837] by
-
- 2 edits in trunk/WebCore
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: consider jQuery object to be of array nature.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 10:20 AM Changeset in webkit [63836] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests
WebCore:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a copy/paste, oops!
LayoutTests:
- platform/gtk/Skipped:
- platform/qt/Skipped: Skip the new tests, they don't pass.
- 9:55 AM Changeset in webkit [63835] by
-
- 6 edits in trunk/WebCore
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
https://bugs.webkit.org/show_bug.cgi?id=42662
If the contentsOrientation() on a GraphicsLayer is CompositingCoordinatesBottomUp, then we
need to flip the rects passed to setNeedsDisplayInRect:.
Avoid writing this code twice by making a bare function to share code
between WebLayer and WebTiledLayer. Convert the existing +drawContents:ofLayer:intoContext:
class method into a bare function, because the Obj-C calling overhead doesn't buy us anything.
Take out an assertion in GraphicsLayerCA::updateContentsTransform() that is not
correct.
No new tests because no layers use bottom-up contents at present.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplayInRect:]): (-[WebLayer drawInContext:]):
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): (-[WebTiledLayer drawInContext:]):
- 9:42 AM Changeset in webkit [63834] by
-
- 6 edits7 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests
Tests: http/tests/security/401-logout/401-logout.php
http/tests/xmlhttprequest/remember-bad-password.html
- platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::remove):
- platform/network/CredentialStorage.h: Added a way to remove stored credentials for a given protection space.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Remove stored credentials if they didn't work the first time.
- 9:39 AM Changeset in webkit [63833] by
-
- 13 edits in trunk
JavaScriptCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211743> JavaScriptCore needs to link against unversioned ICU
Reviewed by Adam Roben.
Dynamically create a new header, ICUVersion.h, as part of build-generated-files.sh.
Header contains a preprocessor define (U_DISABLE_RENAMING) indicating to ICU whether the ICU API
should be namespaced with the current ICU version number. Proper value is determined
by checking for the presence of libicuuc.lib, the unversioned copy of ICU.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Generate ICUVersion.h
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
WebCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
- WebCore.vcproj/WebCore.vcproj:
Add forced include of ICUVersion.h.
- WebCore.vcproj/WebCoreCommon.vsprops: Add forced include of ICUVersion.h.
WebKit/win: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
- WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
WebKit2: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.
- win/WebKit2Common.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- 9:31 AM Changeset in webkit [63832] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- Shared/win/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty): Added to match the Mac definition.
- 9:04 AM Changeset in webkit [63831] by
-
- 1 edit1 add in trunk/WebKit2
Land file I forgot to add.
- WebProcess/com.apple.WebProcess.sb: Added.
- 9:01 AM Changeset in webkit [63830] by
-
- 2 edits1 add in trunk/WebKit2
Move WebKit2WebProcess's settings to a vsprops file
Fixes <http://webkit.org/b/42751> WebKit2WebProcess should use vsprops
files
Reviewed by Darin Adler.
- win/WebKit2WebProcess.vcproj: Moved settings from here...
- win/WebKit2WebProcessCommon.vsprops: ...to here.
- 9:01 AM Changeset in webkit [63829] by
-
- 5 edits in trunk
Give InjectedBundle our standard set of configurations (minus the *_Cairo variants)
InjectedBundle's Debug_All configuration was the same as is Debug
configuration, and it was missing a Debug_Internal configuration.
Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy
Reviewed by Darin Adler.
WebKit/win:
Update WebKit.sln for InjectedBundle's Debug_Internal configuration
- WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
InjectedBundle when we're using the Debug_Internal solution
configuration.
WebKitTools:
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
debug_internal.vsprops and debug_all.vsprops to the Debug_All
configuration. Added a Debug_Internal configuration.
- WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
variant of InjectedBundle when we're using the Debug_Internal solution
configuration.
- 9:01 AM Changeset in webkit [63828] by
-
- 2 edits1 add in trunk/WebKitTools
Move InjectedBundle's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
files
Reviewed by Darin Adler.
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
Moved settings here...
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
here.
- 9:00 AM Changeset in webkit [63827] by
-
- 2 edits in trunk/WebKit/win
Add MiniBrowser to WebKit.sln
It is the last project to build.
Fixes <http://webkit.org/b/42747> build-webkit should build
MiniBrowser
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
WebKitTestRunner.
- 8:53 AM Changeset in webkit [63826] by
-
- 2 edits in trunk/WebKitTools
Give MiniBrowser our standard set of configurations (minus the *_Cairo variants)
MiniBrowser already had a configuration called "Release", but it was
using mostly the same settings as Debug. And its Debug configuration
was using the settings that Debug_Internal should be using.
Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
are screwy
Reviewed by Darin Adler.
- MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
the Debug configuration. Remove debug.vsprops and
debug_internal.vsprops from the Release configuration and replace them
with release.vsprops. Added Debug_Internal and Debug_All
configurations.
- 8:53 AM Changeset in webkit [63825] by
-
- 9 edits in trunk/WebKit2
Reviewed and tweaked by Anders Carlsson and Sam Weinig.
Patch by Ivan Krstić <ike@apple.com> on 2010-07-20
Put WebProcess in a sandbox. All of the following changes are
Mac-only.
<rdar://problem/7865269>
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
Send Sandbox extension for injected bundle to WebProcess.
- WebKit2.xcodeproj/project.pbxproj:
Add Sandbox profile to Resources for WebProcess.
- WebProcess/InjectedBundle/InjectedBundle.h:
New function InjectedBundle::setSandboxToken.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
Consume Sandbox token for the bundle if present.
(WebKit::InjectedBundle::setSandboxToken):
Set Sandbox token for the bundle.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::loadInjectedBundle):
Extra function parameter for Sandbox token.
(WebKit::WebProcess::didReceiveMessage):
Pass Sandbox token to loadInjectedBundle().
- WebProcess/WebProcess.h:
Extra function parameter for Sandbox token in loadInjectedBundle().
- WebProcess/com.apple.WebProcess.sb: Added.
Sandbox profile for WebProcess.
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
Initialize Sandbox, exit on failure.
- 8:53 AM Changeset in webkit [63824] by
-
- 2 edits1 add in trunk/WebKitTools
Move MiniBrowser's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
MiniBrowser should use vsprops files
https://bugs.webkit.org/show_bug.cgi?id=42745
Reviewed by Darin Adler.
- MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
settings here...
- MiniBrowser/MiniBrowser.vcproj: ...from here.
- 8:53 AM Changeset in webkit [63823] by
-
- 3 edits in trunk/WebKitTools
Fix compiler warnings when building MiniBrowser
Also cleaned up the .vcproj a bit.
Fixes <http://webkit.org/b/42743>.
Reviewed by Darin Adler.
- MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
already defined in .vsprops files. This also fixes a warning about
/EDITANDCONTINUE being incompatible with /SAFESEH.
- MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
being redefined. (I think this will also get us closer to building
with VC++ Express.)
- 8:51 AM Changeset in webkit [63822] by
-
- 2 edits in trunk/WebCore
2010-07-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Serialization to JSON in InspectorValue works incorrect
if comma is assigned as decimal separator. Windows with Russian locale.
https://bugs.webkit.org/show_bug.cgi?id=42755
- inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
- 8:43 AM Changeset in webkit [63821] by
-
- 7 edits in trunk/WebKit2
Handle WKView visibility changes
<rdar://problem/7891077>
Reviewed by Dan Bernstein.
- Shared/mac/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty):
Add convenience getter.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
Reorder the calls to _updateActiveState and _updateVisibility based on whether the view is moved to
a window or away from a window.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
Initialize m_forceRepaintWhenResumingPainting to false.
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
Pass the m_forceRepaintWhenResumingPainting along to the DrawingAreaMessage::ResumePainting message.
(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Don't try to paint empty update chunks.
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
Don't paint the update chunk if we're not visible. Instead, make sure that the entire page is being redrawn
when its shown again.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::suspendPainting):
Rename m_shouldPaint to m_isPaintingSuspended and invert its logic.
(WebKit::ChunkedUpdateDrawingArea::scheduleDisplay):
Don't schedule a display timer if the dirty rect is empty.
(WebKit::ChunkedUpdateDrawingArea::setSize):
If painting is suspended, just send back an empty update chunk in the DidSetSize message.
(WebKit::ChunkedUpdateDrawingArea::resumePainting):
If forceRepaint is true, repaint the entire drawing area.
- 8:14 AM Changeset in webkit [63820] by
-
- 3 edits4 adds in trunk
2010-07-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
CSS rotation transform can cause elements with certain styles to vanish during rotation.
https://bugs.webkit.org/show_bug.cgi?id=42579
Remove some untested, broken code that, as far as I can tell, could never get hit.
Use the correct rect for the PaintInfo so that zero-sized elements with overflow:hidden
but a border paint correctly.
Test: compositing/overflow/zero-size-overflow.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 8:12 AM Changeset in webkit [63819] by
-
- 2 edits in trunk/WebCore
2010-07-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Laszlo Gombos.
[QT] Leak and few more fixes to qt port of geolocation
https://bugs.webkit.org/show_bug.cgi?id=42753
Fixes memory leak and default values set to attributes.
Memory leak fix no new test case added.
- platform/qt/GeolocationServiceQt.cpp: Added. (WebCore::GeolocationServiceQt::~GeolocationServiceQt): (WebCore::GeolocationServiceQt::positionUpdated):
- 8:10 AM Changeset in webkit [63818] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
- platform/qt/Skipped: Unskip tests.
- 6:56 AM Changeset in webkit [63817] by
-
- 2 edits in trunk/WebCore
2010-07-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Added automatic sqlite extraction for Symbian to QtWebKit.
Also added sqlite detection in case sqlite is not present in the SDK.
This is possible if WebKit is compiled standalone.
The inclusion part is a consequence of commit c578c6c1d6d in the Qt
repository. It will not work on Qt versions < 4.7.1, but that is ok,
since the only build system it will affect is marked as experimental
in the whole 4.7 series.
- WebCore.pro:
- 6:48 AM Changeset in webkit [63816] by
-
- 1 add in trunk/WebKit/efl/ChangeLog
2010-07-21 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Creating ChangeLog for the EFL port.
- efl/ChangeLog: Added.
- 5:53 AM Changeset in webkit [63815] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Associate elements with the active form
https://bugs.webkit.org/show_bug.cgi?id=42728
This patch fixes fast/forms/formmove3.html. The test still doesn't
pass due to some render tree differences, but it works as intended now.
To fix this test, I needed to deviate from the spec slight. Minefield
seems to have the same deviation:
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::takeForm): (WebCore::HTMLConstructionSite::setForm): (WebCore::HTMLConstructionSite::createHTMLElement):
- html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::form):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 5:38 AM Changeset in webkit [63814] by
-
- 3 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The adoption agency doesn't properly attach()
https://bugs.webkit.org/show_bug.cgi?id=42727
The adoption agency is transliterated rather directly from the spec,
but it misses some of the WebKit-specific machinations, such as
attaching to the render tree.
The algorithm, as written, is a minor layer violation. I've added to
the problem by calling attach() from HTMLTreeBuilder (even though
that's the job of the HTMLConstructionSite). We'll need to clean up
the layering a bit at some point.
This patch half fixes fast/forms/formmove3.html. Hopefully I'll finish
fixing it in the next patch.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 5:22 AM Changeset in webkit [63813] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725
Test progression.
- html5lib/runner-expected-html5.txt:
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725
Fix spec transcription error.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
- 5:05 AM Changeset in webkit [63812] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix fast/css/last-child-style-sharing.html
https://bugs.webkit.org/show_bug.cgi?id=42731
Prior to this patch, we weren't calling finishParsingChildren on the
body element. We need a more systematic way of catching these bugs.
- html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popAll):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 4:18 AM Changeset in webkit [63811] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector/debugger-pause-in-eval-script.html fails on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=42735
- inspector/debugger-pause-in-eval-script.html:
- platform/chromium/test_expectations.txt:
- 3:42 AM Changeset in webkit [63810] by
-
- 10 edits in trunk
2010-07-21 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- WebCore.vcproj/WebCoreCommon.vsprops: Add bindings/generic to include path.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
- page/DOMWindow.idl:
- page/Page.cpp: (WebCore::Page::Page):
2010-07-21 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
- 2:57 AM Changeset in webkit [63809] by
-
- 4 edits80 adds in trunk
WebCore: Reviewed Nikolas Zimmermann.
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
The implementation was done by Nikolas Zimmermann before, but
there was no tests for it. The patch also implements the simple
setFilterRes method.
Tests: svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html
svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-height-attr.html
svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-width-attr.html
svg/dynamic-updates/SVGFilterElement-dom-x-attr.html
svg/dynamic-updates/SVGFilterElement-dom-y-attr.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGFilterElement.h:
LayoutTests: SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
Reviewed by Nikolas Zimmermann.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-height-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-width-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterRes-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterUnits-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-height-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-primitiveUnits-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-width-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-x-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-y-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-call.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterUnits-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-primitiveUnits-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js: Added.
(executeTest):
- 2:38 AM Changeset in webkit [63808] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
Forgot to update the role of HitTestRequest.h in
the xcode project after landing patch from
https://bugs.webkit.org/show_bug.cgi?id=39493
- WebCore.xcodeproj/project.pbxproj: Make HitTestRequest.h
private so it can be included in WebKit by EventHandler.h
which is already private..
- 2:19 AM Changeset in webkit [63807] by
-
- 6 edits2 adds in trunk
Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493
Reviewed by Steve Block.
WebCore:
Test: fast/events/touch/touch-active-state.html
- WebCore.exp.in: Update exports for new signature of
hitTestResultAtPoint.
- WebCore.order: ditto.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::hitTestResultAtPoint): Pass the type
of the hit test to perform as a parameter with a default
value rather than harcoding it in the function body.
(WebCore::EventHandler::handleMouseMoveEvent): Do not modiify
the active element during a mouse move if the user is
touching the screen.
(WebCore::EventHandler::handleTouchEvent): Set the correct
type of hit test to perform depending on the type of the
touch event we are handling.
- page/EventHandler.h: Update the signature of hitTestResultAtPoint.
LayoutTests:
- fast/events/touch/touch-active-state-expected.txt: Added.
- fast/events/touch/touch-active-state.html: Added.
- 2:02 AM Changeset in webkit [63806] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: should be possible to debug inspector
https://bugs.webkit.org/show_bug.cgi?id=42730
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
Jul 20, 2010:
- 11:53 PM Changeset in webkit [63805] by
-
- 11 edits2 adds in trunk
2010-07-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
console.assert should include stack trace with line numbers.
https://bugs.webkit.org/show_bug.cgi?id=22556
Test: inspector/console-assert.html
- bindings/v8/ScriptCallStack.cpp: (WebCore::getTopFrameLocation): (WebCore::toScriptCallFramesVector): (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement):
- page/Console.cpp: (WebCore::Console::lastWMLErrorMessage):
- page/Console.idl:
2010-07-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
console.assert should include stack trace with line numbers.
https://bugs.webkit.org/show_bug.cgi?id=22556
- inspector/console-assert-expected.txt: Added.
- inspector/console-assert.html: Added.
- 11:29 PM Changeset in webkit [63804] by
-
- 2 edits in trunk/WebCore
2010-07-20 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kent Tamura.
[EFL] Use log functions instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=42576
Use LOG and LOG_ERROR instead of fprintf.
No new tests, no new functionality.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
- 11:04 PM Changeset in webkit [63803] by
-
- 10 edits in trunk/WebCore
2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
https://bugs.webkit.org/show_bug.cgi?id=42523
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/rule_binding.py:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/generate-bindings.pl:
- inspector/CodeGeneratorInspector.pm:
- 9:28 PM Changeset in webkit [63802] by
-
- 2 edits in trunk/WebCore
Re-save vsprops file after no-op edit in Visual Studio
to fix manual edit issues.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 9:26 PM Changeset in webkit [63801] by
-
- 4 edits in trunk/JavaScriptCore
Re-save vsprops files after no-op edits in Visual Studio
to fix manual edit issues.
- 9:12 PM Changeset in webkit [63800] by
-
- 2 edits in trunk/WebCore
Re-save vcproj file after no-op edit in Visual Studio
to fix manual edit issues.
- WebCore.vcproj/WebCore.vcproj:
- 7:41 PM Changeset in webkit [63799] by
-
- 4 edits in trunk/LayoutTests
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update expected results for a "tricky" test
https://bugs.webkit.org/show_bug.cgi?id=42604
Originally, I created these expectations using Minefield. However, it
appears that Minefield parses this case incorrectly according to the
spec. I've filed <https://bugzilla.mozilla.org/show_bug.cgi?id=580091>.
This patch updates our expected results to what I believe is correct.
- html5lib/resources/tricky01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 7:30 PM Changeset in webkit [63798] by
-
- 6 edits1 add in trunk
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Include attributes when reconstructing elements in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42594
- html5lib/runner-expected-html5.txt:
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Include attributes when reconstructing elements in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42594
Remove FIXME now that we have a test.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromElementRecord):
- 6:43 PM Changeset in webkit [63797] by
-
- 2 edits in trunk/WebKitTools
Fix obvious typo.
Reviewed by Jon Honeycutt.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
- 6:29 PM Changeset in webkit [63796] by
-
- 2 edits in trunk/WebKitTools
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] by default, dumpAsText should disable pixel results
https://bugs.webkit.org/show_bug.cgi?id=42715
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
- 6:20 PM Changeset in webkit [63795] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-07-20 Tony Chang <tony@chromium.org>
Not reviewed, chromium test expectation.
[chromium] put back baseline for http/tests/inspector/resource-parameters.html
https://bugs.webkit.org/show_bug.cgi?id=42720
r63791 put in a failing baseline for webkit win, but chromium-win
falls back to webkit win before the result next to the test file.
Just put another copy in chromium-win of the original expected
results.
- platform/chromium/http/tests/inspector/resource-parameters-expected.txt: Copied from LayoutTests/http/tests/inspector/resource-parameters-expected.txt.
- 6:03 PM Changeset in webkit [63794] by
-
- 4 edits in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=42719
Make Acid2 pass in WebKit2
Reviewed by Brady Eidson.
WebCore:
- WebCore.exp.in: Update exported functions.
WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType): Check for supported image mimetypes
before falling back to plugins.
- 6:02 PM Changeset in webkit [63793] by
-
- 4 edits1 add in trunk/LayoutTests
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Import HTML5 parsing tests from html5test.com
https://bugs.webkit.org/show_bug.cgi?id=42713
- html5lib/resources/html5test-com.dat: Added.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 5:26 PM Changeset in webkit [63792] by
-
- 10 edits4 adds in trunk
2010-07-20 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
prefetch categorization is exactly wrong
https://bugs.webkit.org/show_bug.cgi?id=42651
The miscategorization caused onloads to issue early, so you see x,
y as 0, 0 in the buggy version.
- fast/dom/HTMLLinkElement/onload-completion-test-expected.txt: Added.
- fast/dom/HTMLLinkElement/onload-completion-test.html: Added.
- fast/dom/HTMLLinkElement/resources: Added.
- fast/dom/HTMLLinkElement/resources/nick.jpg: Added.
2010-07-20 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
prefetch categorization is exactly wrong
https://bugs.webkit.org/show_bug.cgi?id=42651
While I was in the area, I saw that CachedResource::schedule() was dead, so I have removed it.
Test: fast/dom/HTMLLinkElement/onload-completion-test.html
- loader/CachedCSSStyleSheet.h:
- loader/CachedFont.h:
- loader/CachedImage.h:
- loader/CachedResource.cpp:
- loader/CachedResource.h: (WebCore::CachedResource::isPrefetch):
- loader/CachedScript.h:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.h:
- 5:05 PM Changeset in webkit [63791] by
-
- 1 edit2 adds in trunk/LayoutTests
Land failing results for http/tests/inspector/resource-parameters.html. It has been
failing for a while. Fixing these results is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=42718>.
Rubber-stamped by Adam Roben.
- platform/win/http/tests/inspector: Added.
- platform/win/http/tests/inspector/resource-parameters-expected.txt: Added.
- 5:00 PM Changeset in webkit [63790] by
-
- 2 edits in trunk/WebKitTools
Windows build fix
- MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
WebKit.lib instead of the old, dusty WebKit2.lib.
- 4:44 PM Changeset in webkit [63789] by
-
- 2 edits in trunk/WebKit/win
Add WebKitTestRunner and friends to WebKit.sln
We added these projects to WebKit2.sln in r63585, but removed them
again in r63600 because WebKitTestRunner required getopt, which
doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
(which has replaced WebKit2.sln).
Fixes <http://webkit.org/b/42711> WebKit.sln should build
WebKitTestRunner
Reviewed by Steve Falkenburg.
- WebKit.vcproj/WebKit.sln: Added the following projects to the end of
the build order (in first-built to last-built order):
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
removed an unnecessary dependency from testapi on WebKit2WebProcess.
- 4:40 PM Changeset in webkit [63788] by
-
- 2 edits in trunk/WebKitTools
Stop linking WebKitTestRunner against getopt
Use of getopt was removed in r63700.
Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
getopt, but doesn't need to
Reviewed by Sam Weinig.
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
from all configurations.
- 4:33 PM Changeset in webkit [63787] by
-
- 2 edits in trunk/LayoutTests
Add a few more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42712
Reviewed by Maciej Stachowiak.
- platform/mac-wk2/Skipped:
- 4:23 PM Changeset in webkit [63786] by
-
- 6 edits in trunk
2010-07-16 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebFormElement::wasUserSubmitted(). This is used to
verify that the user submitted the form instead of JS when saving form
data in AutoFill.
https://bugs.webkit.org/show_bug.cgi?id=42479
- public/WebFormElement.h:
- src/WebFormElement.cpp: (WebKit::WebFormElement::wasUserSubmitted):
2010-07-16 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
Expose the form submission trigger on the HTMLFormElement object. This
is used to verify that the user submitted the form instead of JS when
saving form data in Chrome AutoFill.
https://bugs.webkit.org/show_bug.cgi?id=42479
No new tests as this is only used by the Chromium WebKit API.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::submissionTrigger):
- html/HTMLFormElement.h:
- 4:06 PM Changeset in webkit [63785] by
-
- 2 edits1 add in trunk/WebKitTools
Make run-webkit-tests --webkit-test-runner "work" on Windows
WebKitTestRunner crashes on launch, but at least the scripts build and
launch it!
Fixes <http://webkit.org/b/42709> run-webkit-tests
--webkit-test-runner bails with an error on Windows
Reviewed by Anders Carlsson.
- Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
Windows.
- WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
projects (from first-built to last-built): FindSafari, ImageDiff,
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
- 4:05 PM Changeset in webkit [63784] by
-
- 3 edits1 delete in trunk
Remove WebKit2.sln
WebKit.sln builds all the same projects.
Rubber-stamped in advance by Steve Falkenburg.
WebKit2:
- WebKit2.sln: Removed.
WebKitTools:
Change build-webkit back to building WebKit.sln on Windows
WebKit.sln builds all the same projects as WebKit2.sln, and the latter
is being removed.
- Scripts/build-webkit:
- 4:04 PM Changeset in webkit [63783] by
-
- 8 edits in branches/audio/WebCore
Fixes to Chrome build and run-time due to recent API changes
- 4:02 PM Changeset in webkit [63782] by
-
- 3 edits in trunk/WebCore
2010-07-20 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix fast/dom/title-content-write-set.html for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42668
Address some late-breaking review comments.
- dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::replaceData):
- dom/CharacterData.h:
- 3:39 PM Changeset in webkit [63781] by
-
- 4 edits in trunk/LayoutTests
2010-07-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
make dump-as-markup work better on subframes and allow dumping a subtree
https://bugs.webkit.org/show_bug.cgi?id=42673
- editing/selection/dump-as-markup-expected.txt:
- editing/selection/dump-as-markup.html:
- resources/dump-as-markup.js: (Markup.description): (Markup._getSelectionFromNode): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
- 3:23 PM Changeset in webkit [63780] by
-
- 9 edits in trunk
2010-07-20 Daniel Erat <derat@chromium.org>
Reviewed by Ojan Vafai.
Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220
Layout test addition to check that Chromium Linux honors fontconfig
settings enabling or disabling subpixel rendering per-strike.
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
- platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt:
- platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:
2010-07-20 Daniel Erat <derat@chromium.org>
Reviewed by Ojan Vafai.
Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220
Explicitly initialize global Chromium Linux isSkiaSubpixelGlyphs
flag to false for clarity.
- platform/graphics/chromium/FontPlatformDataLinux.cpp:
2010-07-20 Daniel Erat <derat@chromium.org>
Reviewed by Ojan Vafai.
Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220
Honor Fontconfig subpixel rendering setting on Chromium Linux.
- src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
- 3:12 PM Changeset in webkit [63779] by
-
- 3 edits in trunk/WebCore
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix fast/dom/title-content-write-set.html for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42668
When I split parserAppendData from appendData, it was tempting to cut
the function at dispatchModifiedEvent, but that's not quite right. We
still need to notify the parent that it's children have changed.
- dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
- dom/CharacterData.h:
- 2:56 PM Changeset in webkit [63778] by
-
- 2 edits in trunk/WebKitTools
Windows build fix
- MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
- 2:55 PM Changeset in webkit [63777] by
-
- 2 edits in trunk/WebKit2
Make the web process break into the debugger when Ctrl-Alt-Shift is held during launch
Fixes <http://webkit.org/b/42670> Would like a way to break into the
debugger when the web process launches
Reviewed by Anders Carlsson.
- WebProcess/WebKitMain.cpp:
(WebKitMain): If the Control, Alt, and Shift keys are held down in a
Debug build, call DebugBreak() so that we will break into the
debugger.
- 2:55 PM Changeset in webkit [63776] by
-
- 2 edits in trunk/WebKit2
Teach Connection how to handle a slow receiver
Fixes <http://webkit.org/b/42667> Assertion in
Connection::sendOutgoingMessage when browser or web process is paused
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage): If WriteFile returns FALSE
and the last error is ERROR_IO_PENDING, Windows will write the data as
soon as the current write operation is completed. We don't need to do
anything special in this case, so there's no need to assert about it.
- 2:45 PM Changeset in webkit [63775] by
-
- 3 edits in trunk/WebKit
2010-07-20 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Fix zoom in/out on EFL after r62666. The patch for adding viewport
missed the initialization of zoom_range.user_scalable. In case browser
doesn't care about the viewport and does not listen to the signal,
user_scalable will be always false, thus inhibiting zoom in/out.
https://bugs.webkit.org/show_bug.cgi?id=42656
- efl/EWebLauncher/main.c: (on_viewport_changed): when listening to signal about viewport meta tag, it's not sufficient to receive the parameters. One needs also to enforce these parameters in WebKit.
- efl/ewk/ewk_view.cpp: (_ewk_view_priv_new): initialize user_scalable parameter to allow browser zooming in and out.
- 2:34 PM Changeset in webkit [63774] by
-
- 3 edits2 adds in trunk
CrashTracer: [USER] 300 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 573
https://bugs.webkit.org/show_bug.cgi?id=42652
Reviewed by Beth Dakin.
WebCore:
When a table cell accesses its parent table, we should not use getOrCreate, because creating an AXTable inspects its render tree state
which may be out of date, leading to a crash.
By using only get(), it implies that the AXTable must be created before AXTableCells. This should
always be the case when AT clients access a table.
Test: accessibility/updating-attribute-in-table-causes-crash.html
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable):
LayoutTests:
- accessibility/updating-attribute-in-table-causes-crash-expected.txt: Added.
- accessibility/updating-attribute-in-table-causes-crash.html: Added.
- 2:11 PM Changeset in webkit [63773] by
-
- 5 edits2 adds in trunk
2010-07-20 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Check the node is a text node before doing the static cast
for editing commands.
https://bugs.webkit.org/show_bug.cgi?id=42655
Test: editing/execCommand/editing-nontext-node-crash.xhtml
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
2010-07-20 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Tests that applying an editing command on a non text node does not
result in crash.
https://bugs.webkit.org/show_bug.cgi?id=42655
- editing/execCommand/editing-nontext-node-crash-expected.txt: Added.
- editing/execCommand/editing-nontext-node-crash.xhtml: Added.
- 1:37 PM Changeset in webkit [63772] by
-
- 4 edits2 adds in trunk
2010-07-20 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by David Hyatt.
Don't merge Anonymous block whose first child is inline run-in.
Make run-in recalculate its style after its renderer is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=41375.
Test: fast/runin/crash-when-reparent-sibling.html
- rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren):
2010-07-20 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by David Hyatt.
Test case to verify https://bugs.webkit.org/show_bug.cgi?id=41375.
Test passes if expected result occurs without crash.
https://bugs.webkit.org/show_bug.cgi?id=41375.
- fast/runin/crash-when-reparent-sibling-expected.txt: Added.
- fast/runin/crash-when-reparent-sibling.html: Added.
- 1:27 PM Changeset in webkit [63771] by
-
- 2 edits in trunk/WebCore
Unreviewed Qt test fix.
Qt should not use PREEMPT_GEOLOCATION_PERMISSION until Bug 42027 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=42068
No new tests, test fix only.
- WebCore.pro:
- 1:23 PM Changeset in webkit [63770] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-20 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- src/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge): Add implementation of this method that always returns false.
- 12:56 PM Changeset in webkit [63769] by
-
- 8 edits in trunk/WebKit/chromium
2010-07-20 Darin Fisher <darin@chromium.org>
Reviewed by Jian Li.
[Chromium] Add interface for downloading to a file. This can be used
in the future to support XMLHttpRequest.responseBlob, but it also
serves a use case in Chromium.
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::willSendRequest): (WebKit::WebURLLoaderClient::didSendData): (WebKit::WebURLLoaderClient::didReceiveResponse): (WebKit::WebURLLoaderClient::didDownloadData): (WebKit::WebURLLoaderClient::didReceiveData): (WebKit::WebURLLoaderClient::didFinishLoading): (WebKit::WebURLLoaderClient::didFail):
- public/WebURLRequest.h:
- public/WebURLResponse.h:
- src/WebURLRequest.cpp: (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
- src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
- src/WebURLResponsePrivate.h:
- 12:55 PM Changeset in webkit [63768] by
-
- 3 edits in trunk
2010-07-20 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Enable Ecore-X on compile time
https://bugs.webkit.org/show_bug.cgi?id=42600
Check for a flag received from cmake configure and disable it
if necessary. Also disable it if Ecore-X wasn't found.
EFL port does not support automated tests yet.
- cmake/FindEFL.cmake:
- cmake/OptionsEfl.cmake:
- 12:53 PM Changeset in webkit [63767] by
-
- 10 edits in trunk/WebCore
2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63764.
http://trac.webkit.org/changeset/63764
https://bugs.webkit.org/show_bug.cgi?id=42658
have broken Chromium linux build (Requested by loislo on
#webkit).
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/rule_binding.py:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/generate-bindings.pl:
- inspector/CodeGeneratorInspector.pm:
- 12:48 PM Changeset in webkit [63766] by
-
- 8 edits2 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=41531
Asynchronous cross origin XMLHttpRequest doesn't expose 401 response when withCredentials is false
This doesn't match Firefox, but it matches our sync case, XHR2 spec and common sense.
Test: http/tests/xmlhttprequest/cross-origin-no-authorization.html (updated results).
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Instead of canceling the request, continue without credentials - if the platform has a necessary method on ResourceHandle.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Don't ask resource loader client for credentials if subresource loader client already took care of those.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge):
- platform/network/ResourceHandle.h: Added an accessor to check whether ResourceHandle is currently waiting for credentials.
- 12:29 PM Changeset in webkit [63765] by
-
- 2 edits in trunk/WebCore
2010-07-20 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
Build SVGPathBuilder, SVGPathParser and SVGPathSegListBuilder.
Add websockets include directory.
The EFL port doesn't yet support automated tests.
- CMakeLists.txt:
- 12:27 PM Changeset in webkit [63764] by
-
- 10 edits in trunk/WebCore
2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
https://bugs.webkit.org/show_bug.cgi?id=42523
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/rule_binding.py:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/generate-bindings.pl:
- inspector/CodeGeneratorInspector.pm:
- 12:23 PM Changeset in webkit [63763] by
-
- 6 edits5 adds in trunk
2010-07-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Geoffrey Garen.
WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613
- platform/mac/fast/objc/script-tests/TEMPLATE.html: Added.
- platform/mac/fast/objc/script-tests/webScriptObject-hasWebScriptKey.js: Added.
- platform/mac/fast/objc/webScriptObject-hasWebScriptKey-expected.txt: Added.
- platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html: Added.
2010-07-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Geoffrey Garen.
WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613
Test: platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html
Add private API "hasWebScriptKey" to check for key existence in
a WebScriptObject. Like JavaScript'sinsyntax. This is intended
to be made public eventually.
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject hasWebScriptKey:]):
- bindings/objc/WebScriptObjectPrivate.h:
2010-07-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Geoffrey Garen.
WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613
Normal ObjCController workflow for a WebScriptObject test.
- DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testHasWebScriptKey:]):
- 12:18 PM Changeset in webkit [63762] by
-
- 4 edits in trunk/WebCore
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 tree builder needs to call dispatchDocumentElementAvailable
https://bugs.webkit.org/show_bug.cgi?id=42654
This patch fixes the follout LayoutTests with --html5-treebuilder:
- userscripts/script-not-run-for-fragments.html
- userscripts/script-run-at-start.html
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement):
- html/HTMLConstructionSite.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- 11:59 AM Changeset in webkit [63761] by
-
- 6 edits in trunk
2010-07-20 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Steve Block.
Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068
If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default
- wtf/Platform.h:
2010-07-20 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Steve Block.
Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068
Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service
This change does not introduce any change in behavior for any platform. So there are no new tests
added.
- WebCore.pro:
- page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
- page/Geolocation.h:
- 11:28 AM Changeset in webkit [63760] by
-
- 2 edits in trunk/WebCore
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 tree builder should restore form state
https://bugs.webkit.org/show_bug.cgi?id=42644
We need to tell self-closing tags that we're done parsing their
children. This patch fixes the following LayoutTests when run with
--html5-treebuilder:
fast/forms/button-state-restore.html
fast/forms/state-restore-to-non-autocomplete-form.html
fast/forms/state-restore-to-non-edited-controls.html
fast/history/saves-state-after-fragment-nav.html
http/tests/navigation/restore-form-state-https.html
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
- 11:12 AM Changeset in webkit [63759] by
-
- 9 edits in trunk
2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63750.
http://trac.webkit.org/changeset/63750
https://bugs.webkit.org/show_bug.cgi?id=42648
This revision breaks the windows builds (Requested by
hwennborg on #webkit).
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
- page/DOMWindow.idl:
- page/Page.cpp: (WebCore::Page::Page):
2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63750.
http://trac.webkit.org/changeset/63750
https://bugs.webkit.org/show_bug.cgi?id=42648
This revision breaks the windows builds (Requested by
hwennborg on #webkit).
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp:
- 10:54 AM Changeset in webkit [63758] by
-
- 56 edits4 adds2 deletes in trunk/LayoutTests
2010-07-20 Stephen White <senorblanco@chromium.org>
Unreviewed; pixel test results fix.
Updated pixel test results after r63721.
- platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
- platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum:
- platform/chromium-linux/svg/custom/path-getTotalLength-expected.txt: Removed.
- platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.checksum:
- platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
- platform/chromium-linux/svg/dom: Added.
- platform/chromium-linux/svg/dom/path-parser-expected.txt: Added.
- platform/chromium-linux/svg/hixie/perf/001-expected.txt:
- platform/chromium-linux/svg/hixie/perf/002-expected.txt:
- platform/chromium-linux/svg/hixie/perf/007-expected.checksum:
- platform/chromium-linux/svg/hixie/perf/007-expected.png:
- platform/chromium-linux/svg/hixie/perf/007-expected.txt:
- platform/chromium-mac/fast/backgrounds/svg-as-background-5-expected.checksum: Removed.
- platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.checksum:
- platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png:
- platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.checksum:
- platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png:
- platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/chromium-win/svg/hixie/perf/001-expected.txt:
- platform/chromium-win/svg/hixie/perf/002-expected.txt:
- platform/chromium-win/svg/hixie/perf/007-expected.checksum:
- platform/chromium-win/svg/hixie/perf/007-expected.png:
- platform/chromium-win/svg/hixie/perf/007-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
- platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
- platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
- 10:53 AM Changeset in webkit [63757] by
-
- 4 edits in trunk/WebCore
2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: It is possible to show full call stack instead of top frame for Caller
and Call Site properties in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=42620
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- inspector/front-end/inspector.css: (.timeline-details): (.timeline-function-name): (.timeline-stacktrace-title):
- 10:50 AM Changeset in webkit [63756] by
-
- 3 edits in trunk/WebKit2
Implement NPN_GetURL and NPN_PostURL
https://bugs.webkit.org/show_bug.cgi?id=42650
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
Add a FIXME about deleting the file.
(WebKit::makeURLString):
Move this static method before NPN_GetURL.
(WebKit::NPN_GetURL):
Call NetscapePLugin::LoadURL.
(WebKit::NPN_PostURL):
Ditto.
(WebKit::NPN_PostURLNotify):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
Remove unreached code.
(WebKit::NetscapePluginStream::deliverDataToPlugin):
Stop the stream if the plug-in returns -1 from NPP_Write.
- 10:42 AM Changeset in webkit [63755] by
-
- 5 edits in trunk/WebKit/chromium
2010-07-19 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add webkit api reset to WebIDBDatabaseError and WebIDBKey
and refactor their destructors for chromium multi dll build.
- public/WebIDBDatabaseError.h: (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
- public/WebIDBKey.h: (WebKit::WebIDBKey::~WebIDBKey):
- src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::reset):
- src/WebIDBKey.cpp: (WebKit::WebIDBKey::reset):
- 10:38 AM Changeset in webkit [63754] by
-
- 2 edits in trunk/WebKitTools
2010-07-20 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=42118
Disable compositing/webgl tests if WebGL is not enabled
- Scripts/old-run-webkit-tests:
- 10:35 AM Changeset in webkit [63753] by
-
- 5 edits in trunk/WebCore
2010-07-20 Leon Clarke <leonclarke@google.com>
Reviewed by Pavel Feldman.
Make things compile again when the inspector is disabled, following
recent inspector improvements.
https://bugs.webkit.org/show_bug.cgi?id=42632
No new tests. Fixing a build break.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
- inspector/InspectorController.h: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
- inspector/InspectorDOMAgent.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- 10:31 AM Changeset in webkit [63752] by
-
- 5 edits20 moves7 adds in trunk/LayoutTests
2010-07-20 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
Move the canvas security tests to http tests to simulate remote host
access and then pass the tests. Remove them from Mac and Qt's skipped files.
https://bugs.webkit.org/show_bug.cgi?id=41279
- 10:20 AM Changeset in webkit [63751] by
-
- 4 edits in trunk/WebCore
2010-07-20 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Allow handles to be disposed and WebKit objects to be dereferenced even if their map is already destroyed.
https://bugs.webkit.org/show_bug.cgi?id=42634
Currently DOMDataStore could be destroyed even if it has some mappings (it gets destroyed
when its isolated context gets GCed). However in this case, handles allocated for
such objects would never be disposed as we require presence of mapping from wrapped
WebKit object to handle being collected in the map and now map is gone. That leads to
zombie objects in both WebKit (wrapped WebKit object doesn't get dereferenced) and V8
(both handle and V8 wrapper object could not be destroyed).
See http://code.google.com/p/chromium/issues/detail?id=47125 for further discussion.
- bindings/v8/DOMData.h: (WebCore::DOMData::handleWeakObject):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback):
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::~WeakReferenceMap):
- 10:08 AM Changeset in webkit [63750] by
-
- 9 edits in trunk
2010-07-20 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
- page/DOMWindow.idl:
- page/Page.cpp: (WebCore::Page::Page):
2010-07-20 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
- 9:44 AM Changeset in webkit [63749] by
-
- 2 edits in trunk/WebKitTools
2010-07-20 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Print additional information about exception if failed to connect to apache (in verbose mode).
https://bugs.webkit.org/show_bug.cgi?id=42627
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- 9:30 AM Changeset in webkit [63748] by
-
- 3 edits in trunk/WebKitTools
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] only pass --force to gclient sync if explicitly stated
https://bugs.webkit.org/show_bug.cgi?id=42581
- BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
always pass --force since it's hard to do manual cleanups
- Scripts/update-webkit-chromium: only pass --force if --force is
passed in
- 9:16 AM Changeset in webkit [63747] by
-
- 4 edits2 adds in trunk
2010-07-20 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Fixed a crash when deeply nested CSS selector is used.
https://bugs.webkit.org/show_bug.cgi?id=41129
This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.
- fast/css/css-selector-deeply-nested-expected.txt: Added.
- fast/css/css-selector-deeply-nested.html: Added.
2010-07-20 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Fixed a crash when deeply nested CSS selector is used.
https://bugs.webkit.org/show_bug.cgi?id=41129
This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.
Test: fast/css/css-selector-deeply-nested.html
- css/CSSSelector.cpp: (WebCore::CSSSelectorBag::~CSSSelectorBag): (WebCore::CSSSelectorBag::isEmpty): (WebCore::CSSSelectorBag::append): (WebCore::CSSSelectorBag::takeAny): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::specificity):
- css/CSSSelector.h:
- 8:17 AM Changeset in webkit [63746] by
-
- 2 edits in trunk/WebCore
2010-07-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error
https://bugs.webkit.org/show_bug.cgi?id=42642
- bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
- 8:09 AM Changeset in webkit [63745] by
-
- 6 edits in trunk
2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63742.
http://trac.webkit.org/changeset/63742
https://bugs.webkit.org/show_bug.cgi?id=42641
Broke Leopard Intel build. (Requested by bbandix on #webkit).
- wtf/Platform.h:
2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63742.
http://trac.webkit.org/changeset/63742
https://bugs.webkit.org/show_bug.cgi?id=42641
Broke Leopard Intel build. (Requested by bbandix on #webkit).
- WebCore.pro:
- page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
- page/Geolocation.h:
- 7:51 AM Changeset in webkit [63744] by
-
- 2 edits in trunk/LayoutTests
2010-07-20 Stephen White <senorblanco@chromium.org>
Unreviewed; expectations fix.
- platform/chromium/test_expectations.txt:
- 7:51 AM Changeset in webkit [63743] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Fixed case of "Name" attribute.
- 7:24 AM Changeset in webkit [63742] by
-
- 6 edits in trunk
Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068
Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-07-20
Reviewed by Steve Block.
If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default
- wtf/Platform.h:
WebCore:
Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service
This change does not introduce any change in behavior for any platform. So there are no new tests
added.
- WebCore.pro:
- page/Geolocation.cpp:
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::startUpdating):
- page/Geolocation.h:
- 5:21 AM Changeset in webkit [63741] by
-
- 4 edits in trunk/WebCore
2010-07-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Inspector: Resources Search Should Search Only Filtered Resources
https://bugs.webkit.org/show_bug.cgi?id=28290
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews):
- inspector/front-end/inspector.js: (WebInspector.performSearch): (WebInspector.doPerformSearch):
- 5:11 AM Changeset in webkit [63740] by
-
- 5 edits in trunk/WebKit/qt
2010-07-20 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
[Qt] Add API to define device-width and height for use with the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=42597
Reviewed by Antonio Gomes.
Add a new API for setting the deviceSize for use in conjunction with
out viewport meta tag API.
- Api/qgraphicswebview.cpp: (QGraphicsWebView::setDeviceSize): (QGraphicsWebView::deviceSize):
- Api/qgraphicswebview.h:
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::windowRect):
- WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
- 5:01 AM Changeset in webkit [63739] by
-
- 2 edits in trunk/WebCore
2010-07-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Incorrect absolute URLs in tooltips of links in the ElementsTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=42626
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeHTML):
- 4:46 AM Changeset in webkit [63738] by
-
- 2 edits in trunk/WebKit/qt
2010-07-20 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
Don't set an automatic timeout for notifications when running in DRT.
This fixes an issue with cancel() notifications in unrelated tests.
- WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::displayNotification):
- 3:17 AM Changeset in webkit [63737] by
-
- 2 edits in trunk/LayoutTests
2010-07-20 Alejandro G. Castro <alex@igalia.com>
Unreviewed.
Skipping the svg/dom/path-parser.html test for gtk, bug submitted:
https://bugs.webkit.org/show_bug.cgi?id=42624
- platform/gtk/Skipped:
- 2:24 AM Changeset in webkit [63736] by
-
- 2 edits in trunk/WebCore
2010-07-20 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed comment fix. The comment in IDL should be , not # .
Code generator: ensure generated constants match their corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42250
- dom/OverflowEvent.idl:
- 2:14 AM Changeset in webkit [63735] by
-
- 11 edits in trunk
2010-07-20 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
https://bugs.webkit.org/show_bug.cgi?id=42380
RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.
No new functionality so no new tests.
- Android.mk:
2010-07-20 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
https://bugs.webkit.org/show_bug.cgi?id=42380
RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.
No new functionality so no new tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocket.cpp: Remove #if USE(V8), as RuntimeEnabledFeatures.cpp is no longer V8-only.
- websockets/WebSocket.h: Ditto.
- 1:43 AM Changeset in webkit [63734] by
-
- 6 edits in trunk/WebCore
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
clean up style in ClipboardWin and PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=42609
No new tests since this is just a style cleanup.
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCFHTML): (WebCore::getURL): (WebCore::getPlainText): (WebCore::getTextHTML): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCFHTML): (WebCore::fragmentFromHTML):
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/ClipboardWin.cpp: (WebCore::pathRemoveBadFSCharacters): (WebCore::createGlobalHDropContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::writeURL): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeRange):
- platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create): (WebCore::ClipboardWin::dataObject):
- platform/win/PasteboardWin.cpp: (WebCore::PasteboardOwnerWndProc): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
- 1:31 AM Changeset in webkit [63733] by
-
- 2 edits in trunk/LayoutTests
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
https://bugs.webkit.org/show_bug.cgi?id=42348
This doesn't work in the HTML5 parser. We cover this behavior in
parsing tests. Sadly, the test still fails under the HTML5 parser, but
for a different reason.
- fast/events/focusingUnloadedFrame.html:
- 1:30 AM Changeset in webkit [63732] by
-
- 3 edits in trunk/WebCore
2010-07-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: jump to source is broken for call frames logged by console.trace
https://bugs.webkit.org/show_bug.cgi?id=42619
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
- inspector/front-end/treeoutline.js: allow passing HTML element as a title. (TreeElement.prototype.set title): (TreeElement.prototype.set shouldRefreshChildren): (TreeElement.prototype._setListItemNodeContent): (TreeElement.prototype._attach):
- 1:17 AM Changeset in webkit [63731] by
-
- 6 edits3 adds2 deletes in trunk
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
[chromium] crash in Position::getInlineBoxAndOffset
https://bugs.webkit.org/show_bug.cgi?id=42202
- editing/selection/firstRect-crash-expected.txt: Added.
- editing/selection/firstRect-crash.html: Added.
- platform/mac/editing/input/caret-primary-bidi-expected.txt: Fix some negative ranges.
- platform/mac/editing/input/range-for-empty-document-expected.txt:
- platform/mac/editing/selection/move-left-right-expected.txt: Removed since we now match the shared expected results.
- platform/win/editing/selection/move-left-right-expected.txt: Removed since it's the same as the shared expected results.
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
[chromium] crash in Position::getInlineBoxAndOffset
https://bugs.webkit.org/show_bug.cgi?id=42202
Test: editing/selection/firstRect-crash.html
Manual test: win/contextmenu-key2.html
- page/EventHandler.cpp: Code no longer needed
- page/Frame.cpp: (WebCore::Frame::firstRectForRange): Normalize Positions to VisiblePositions because
Positions may be pointing to nodes that have no renderer. If there's no renderer,
getInlineBoxAndOffset will crash.
- 12:47 AM Changeset in webkit [63730] by
-
- 87 edits in trunk/LayoutTests
2010-07-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Maciej Stachowiak.
svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
https://bugs.webkit.org/show_bug.cgi?id=42376
Finally generate pixel teset results again for svg/dynamic-updates. We have some regressions, tracked by master bug 42618.
- fast/js/resources/js-test-pre.js: Pass 'window.enablePixelTesting' as argument to setDumpAsText() - the svg/dynamic-updates tests set this value to true before importing js-test-pre.js
- platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
- svg/dynamic-updates/resources/SVGTestCase.js: Set 'window.enablePixelTesting' to true, forcing setDumpAsText() to generate pixel test results.
- svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-gradientUnits-attr.js: Tweak this test, to make it work as expected.
- svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-gradientUnits-prop.js: Ditto.
- svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-gradientUnits-attr.js: Update expected result description.
- svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-gradientUnits-prop.js: Ditto.
- 12:33 AM Changeset in webkit [63729] by
-
- 5 edits in trunk
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Foster parenting depends on the current element at insertion time
https://bugs.webkit.org/show_bug.cgi?id=42599
- html5lib/runner-expected-html5.txt:
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Foster parenting depends on the current element at insertion time
https://bugs.webkit.org/show_bug.cgi?id=42599
We need to consider the current element at insertion-time when deciding
whether to redirect insertion to the foster parent. Previously, we
were considering the current element *both* at insertion-time and at
the time we created the guard.
- html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::RedirectToFosterParentGuard):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::defaultForInTableText):
- 12:20 AM Changeset in webkit [63728] by
-
- 4 edits1 add in trunk/LayoutTests
2010-07-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Import a number of fast/invalid tests into html5lib for easy of fixing
https://bugs.webkit.org/show_bug.cgi?id=42590
Working with these DOM dumps is much easier than staring at render
trees. Also, this infrastructure lets us cross-test with other
browsers.
- html5lib/resources/tricky01.dat: Added.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 12:07 AM Changeset in webkit [63727] by
-
- 5 edits in trunk
2010-07-20 Matthew Delaney <mdelaney@apple.com>
Reviewed by Kenneth Rohde Christiansen.
Failing 2d.path.stroke.prune.curve philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42190
- platform/mac/Skipped: Unskipped now passing tests.
2010-07-20 Matthew Delaney <mdelaney@apple.com>
Reviewed by Kenneth Rohde Christiansen.
Failing 2d.path.stroke.prune.curve philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42190
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath): Added check to make sure there's a non-trivial path to close. Since there is currently no way to check if the current point is the start point, or similarly if there is only 1 point in the current subpath (since these are both sufficient conditions for a trivial subpath), then checking that the bounding rectangle has both zero width and height proves also to be a sufficient condition for a trivial path. (WebCore::CanvasRenderingContext2D::quadraticCurveTo): Added in simple bounds as per the spec. (WebCore::CanvasRenderingContext2D::bezierCurveTo): Added in simple bounds as per the spec.
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::closeSubpath): Moved the check for an empty path up on level to make it platform independent and remove redundancy.
- 12:03 AM Changeset in webkit [63726] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Add a few more items to the WK2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42595
- platform/mac-wk2/Skipped:
