Timeline

Jul 28, 2010:

11:27 PM WinCE edited by paroga@paroga.com

(diff)

10:52 PM Changeset in webkit [64265] by commit-queue@webkit.org

• 5 edits in trunk

2010-07-28 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable UI for chromium's appcache inspection.
​https://bugs.webkit.org/show_bug.cgi?id=43098

• inspector/front-end/Settings.js: Removed appCacheEnabled.
• inspector/front-end/StoragePanel.js: Removed appCacheEnabled condition. (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache):

2010-07-28 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable UI for chromium's appcache inspection.
​https://bugs.webkit.org/show_bug.cgi?id=43098

• src/js/DevTools.js: (WebInspector.loaded):

9:02 PM Changeset in webkit [64264] by victorw@chromium.org

• 1 edit
  2 adds
  32 deletes in trunk/LayoutTests

2010-07-28 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for svg test.
After Alex Nicolaou's patch ​http://trac.webkit.org/changeset/64254,
Chromium should have same results with platform/mac or platform/mac-leopard.
Also rebaselin leopard result for the new test added by r64254.

• platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Removed.
• platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
• platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.png: Removed.
• platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum: Removed.
• platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
• platform/chromium-mac/svg/custom/recursive-filter-expected.checksum: Removed.
• platform/chromium-mac/svg/custom/recursive-filter-expected.png: Removed.
• platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Removed.
• platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Removed.
• platform/chromium-mac/svg/filters/filter-on-tspan-expected.checksum: Removed.
• platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Removed.
• platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Removed.
• platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Removed.
• platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.checksum: Removed.
• platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Removed.
• platform/mac-leopard/svg/custom/mask-colorspace-expected.checksum: Added.
• platform/mac-leopard/svg/custom/mask-colorspace-expected.png: Added.

8:36 PM Changeset in webkit [64263] by commit-queue@webkit.org

• 3 edits in trunk/WebKitTools

2010-07-28 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

Fixed <​https://bugs.webkit.org/show_bug.cgi?id=33814>
check-webkit-style gives false positives in single-line functions.

• Scripts/webkitpy/style/checkers/cpp.py:
• Scripts/webkitpy/style/checkers/cpp_unittest.py:

8:24 PM Changeset in webkit [64262] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-07-28 Bryan Gislason <​bgislason@rim.com>

Reviewed by Nate Chapin.

Minor compile errors in loadMediaPlayerProxyPlugin
​https://bugs.webkit.org/show_bug.cgi?id=43141

• WebCore/loader/SubframeLoader.cpp:

8:22 PM Changeset in webkit [64261] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

Bug 43162 - Add support for MADV_FREE to PageAllocation.

Reviewed by Darin Adler.

• wtf/PageAllocation.cpp:

(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):

8:12 PM Changeset in webkit [64260] by commit-queue@webkit.org

• 5 edits in trunk

2010-07-28 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add a missing dependency.
​https://bugs.webkit.org/show_bug.cgi?id=43044

• css/CSSPrimitiveValueMappings.h:

2010-07-28 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add access to the computed style display to WebAccessibilityObject.
​https://bugs.webkit.org/show_bug.cgi?id=43044

• public/WebAccessibilityObject.h:
• src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::hasComputedStyle): (WebKit::WebAccessibilityObject::computedStyleDisplay):

8:08 PM Changeset in webkit [64259] by dbates@webkit.org

• 6 edits in trunk/LayoutTests

2010-07-28 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Output more descriptive PASS messages for list layout tests
​https://bugs.webkit.org/show_bug.cgi?id=42938

Output a more descriptive PASS message so that it is clear
what we are testing in the test cases: fast/lists/w3-css3-list-styles-alphabetic.html
and fast/lists/w3-css3-list-styles-numeric.html.

Currently, we only output "PASS" if the list marker equals
its list item text for every <li> in the list. Instead, we
should output a PASS message for each <li> so that we can
ensure that we are comparing the list marker and list
item text.

• fast/lists/resources/dump-list.js: Removed printPassedIfEmptyString() instead merged pass message into testListItemMarkerEqualsListItemText(). (filterListsWithReplacement): Removed support for a post filter function as this is not needed anymore. (testListItemMarkerEquals): Added. (testListItemMarkerEqualsListItemText): Added.
• fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Rebased result.
• fast/lists/w3-css3-list-styles-alphabetic.html: Updated to call testListItemMarkerEqualsListItemText().
• fast/lists/w3-css3-list-styles-numeric-expected.txt: Rebased result.
• fast/lists/w3-css3-list-styles-numeric.html: Modified JavaScript to call testListItemMarkerEquals() so that we can remove the redundant code.

8:01 PM Changeset in webkit [64258] by weinig@apple.com

• 3 edits in trunk/WebKit2

Another Windows build fix.

• UIProcess/API/C/WKBase.h:
• win/WebKit2Generated.make:

7:52 PM Changeset in webkit [64257] by crogers@google.com

• 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

fix audio branch build

7:18 PM Changeset in webkit [64256] by commit-queue@webkit.org

• 2 edits in trunk/WebKit/chromium

2010-07-28 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Set ENABLE_DEVICE_ORIENTATION=1 in features.gypi for chromium
​https://bugs.webkit.org/show_bug.cgi?id=43122

Enable the compile-time switch for device orientation.
The switch was already enabled in features_override.gypi in the Chromium
repository (in revision 53317), and should be set here as well.

The feature is being implemented behind a run-time flag which
defaults to off in Chromium.

• features.gypi: Set ENABLE_DEVICE_ORIENTATION=1.

7:03 PM Changeset in webkit [64255] by weinig@apple.com

• 3 edits in trunk/WebKit2

Fix builds.

• UIProcess/API/C/WKAPICast.h:

(WebKit::ProxyingRefPtr::operator APIType):
(toURLRef):
(toCopiedRef):
(toCopiedURLRef):

• UIProcess/win/WebView.h:

(WebKit::WebView::type):

6:52 PM Changeset in webkit [64254] by victorw@chromium.org

• 5 edits in trunk

2010-07-28 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Ojan Vafai.

Set incorrect but close expectations for mask-colorspace.svg on mac
​https://bugs.webkit.org/show_bug.cgi?id=43102

Blocks:

[chromium] r63450 caused some svg mask tests to fail pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42403

ImageBufferCG.cpp uses CoreGraphics to do the transform of SVG masks
into LinearRGB, but only for MAC which means not for CHROMIUM, so I
have changed the #if to account for both platforms. I am assuming this
isn't in for windows because it's missing in CG itself, but I didn't
verify that.

• platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

2010-07-28 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Ojan Vafai.

Set incorrect but close expectations for mask-colorspace.svg on mac
​https://bugs.webkit.org/show_bug.cgi?id=43102

Blocks:

[chromium] r63450 caused some svg mask tests to fail pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42403

On my Mac, after my best efforts, the mask colorspace doesn't
seem to come out right. Though the pixel values in the test
rectangle should be 111, they come out to 104, and ultimately
it is because the pixel values coming out of ImageBufferCG are
not linearized properly. Checking in this expected result because
visually the colours are close enough and I want to catch other
regressions, but if this starts to fail because the first image
has color 111,111,111 in the rectange and 76,76,76 or 78,78,78 in
the circle, the actual problem will have been corrected. (111 and
78 are the correct values).

Also removed fail expectations for those tests that are now
passing on my Mac.

• platform/chromium/test_expectations.txt:
• platform/mac/svg/custom/mask-colorspace-expected.checksum:
• platform/mac/svg/custom/mask-colorspace-expected.png:

6:41 PM Changeset in webkit [64253] by weinig@apple.com

• 52 edits
  3 adds in trunk/WebKit2

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43163
Add a CF-style base type (WKTypeRef) as a base for polymorphic functions.

Reviewed by Darin Adler.

• Add first polymorphic function, WKGetTypeID.
• Add functions to each WK type to get their respective TypeIDs.
• Adds WebURL to complement WebString.

• Shared/APIObject.h:

(WebKit::APIObject::):
(WebKit::APIObject::~APIObject):

• Shared/ImmutableArray.h:

(WebKit::ImmutableArray::type):

• Shared/WebString.h:

(WebKit::WebString::type):

• Shared/WebURL.h: Added.

(WebKit::WebURL::create):
(WebKit::WebURL::type):
(WebKit::WebURL::isNull):
(WebKit::WebURL::isEmpty):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):

• UIProcess/API/C/WKAPICast.h:

(WebKit::ProxyingRefPtr::ProxyingRefPtr):
(WebKit::ProxyingRefPtr::operator APIType):
(toRef):
(toURLRef):
(toCopiedURLRef):

• UIProcess/API/C/WKArray.cpp:

(WKArrayGetTypeID):

• UIProcess/API/C/WKArray.h:
• UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListGetTypeID):

• UIProcess/API/C/WKBackForwardList.h:
• UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemGetTypeID):

• UIProcess/API/C/WKBackForwardListItem.h:
• UIProcess/API/C/WKBase.h:
• UIProcess/API/C/WKContext.cpp:

(WKContextGetTypeID):

• UIProcess/API/C/WKContext.h:
• UIProcess/API/C/WKFrame.cpp:

(WKFrameGetTypeID):

• UIProcess/API/C/WKFrame.h:
• UIProcess/API/C/WKFramePolicyListener.cpp:

(WKFramePolicyListenerGetTypeID):

• UIProcess/API/C/WKFramePolicyListener.h:
• UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataGetTypeID):

• UIProcess/API/C/WKNavigationData.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageGetTypeID):

• UIProcess/API/C/WKPage.h:
• UIProcess/API/C/WKPageNamespace.cpp:

(WKPageNamespaceGetTypeID):

• UIProcess/API/C/WKPageNamespace.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetTypeID):

• UIProcess/API/C/WKPreferences.h:
• UIProcess/API/C/WKString.cpp:

(WKStringGetTypeID):

• UIProcess/API/C/WKString.h:
• UIProcess/API/C/WKType.cpp: Added.

(WKGetTypeID):

• UIProcess/API/C/WKType.h: Added.
• UIProcess/API/C/WKURL.cpp:

(WKURLGetTypeID):

• UIProcess/API/C/WKURL.h:
• UIProcess/API/win/WKView.cpp:

(WKViewGetTypeID):

• UIProcess/API/win/WKView.h:
• UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::type):

• UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::type):

• UIProcess/WebContext.h:

(WebKit::WebContext::type):

• UIProcess/WebFramePolicyListenerProxy.h:

(WebKit::WebFramePolicyListenerProxy::type):

• UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::type):

• UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::type):

• UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::type):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::type):

• UIProcess/WebPreferences.h:

(WebKit::WebPreferences::type):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGetTypeID):

• WebProcess/InjectedBundle/API/c/WKBundle.h:
• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetTypeID):

• WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetTypeID):
(WKBundlePageSetEditorClient):
(WKBundlePageSetLoaderClient):
(WKBundlePageSetUIClient):

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::type):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::type):

• win/WebKit2.vcproj:

6:31 PM Changeset in webkit [64252] by tkent@chromium.org

• 2 edits
  5 adds in trunk/LayoutTests

2010-07-28 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

• Rebaseline input-appearance-spinbutton-disabled-readonly.html for Chromium-mac and Chromium-linux.
• Remove input-number-events.html. It passes on Chromium now.

• platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
• platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
• platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
• platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
• platform/chromium-mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
• platform/chromium/test_expectations.txt:

6:27 PM Changeset in webkit [64251] by Darin Adler

• 11 edits in trunk

WebKitTestRunner needs to support layoutTestController.execCommand
<​https://bugs.webkit.org/show_bug.cgi?id=42538>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.isCommandEnabled
<​https://bugs.webkit.org/show_bug.cgi?id=42671>

WebKit2:

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageExecuteEditingCommand): Added.
(WKBundlePageIsEditingCommandEnabled): Added.

• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::executeEditingCommand): Added.
(WebKit::WebPage::isEditingCommandEnabled): Added.

• WebProcess/WebPage/WebPage.h: Ditto.

WebKitTools:

• WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Added execCommand and isCommandEnabled.

• WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::execCommand): Added.
(WTR::LayoutTestController::isCommandEnabled): Added.

• WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.

LayoutTests:

• platform/mac-wk2/Skipped: Don't skip the now-functioning tests.

5:56 PM Changeset in webkit [64250] by tkent@chromium.org

• 2 edits in trunk/WebCore

[Chromium] Improve read-only arrow button appearance
​https://bugs.webkit.org/show_bug.cgi?id=43108

Reviewed by Darin Fisher.

No new tests. This is a fix for fast/forms/
input-appearance-spinbutton-disabled-readonly.html

• platform/chromium/PlatformThemeChromiumGtk.cpp:

(WebCore::PlatformThemeChromiumGtk::paintArrowButton):
If the button has ReadOnlyState, paint the button as same as it is disabled.

5:54 PM Changeset in webkit [64249] by tkent@chromium.org

• 3 edits
  1 add in trunk

2010-07-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Introduce drt_expectations.txt for NRWT
​https://bugs.webkit.org/show_bug.cgi?id=43123

• platform/chromium/drt_expectations.txt: Added.

2010-07-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Introduce drt_expectations.txt for NRWT
​https://bugs.webkit.org/show_bug.cgi?id=43123

Introduce LayoutTests/platform/chromium/drt_expectations.txt,
which overrides test expectations only for DumpRenderTree, in
order to manage what problems are investigated.
This change will be reverted when we switch to DRT completely.

• Scripts/webkitpy/layout_tests/port/chromium.py: Add drt_expectations.txt content to the result of test_expectations_overrides() if --use-drt is specified.

5:51 PM Changeset in webkit [64248] by andersca@apple.com

• 2 edits in trunk/WebKit2

Fix 64-bit build.

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

5:41 PM Changeset in webkit [64247] by beidson@apple.com

• 21 edits in trunk

2010-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

First pass at visited link support for WK2
​https://bugs.webkit.org/show_bug.cgi?id=43157

• MiniBrowser/mac/AppDelegate.m: (didNavigateWithNavigationData): (didPerformClientRedirect): (didPerformServerRedirect): (didUpdateHistoryTitle): (populateVisitedLinks): Added for the new version of the HistoryClient. (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)

• MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):

2010-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

First pass at visited link support for WK2
​https://bugs.webkit.org/show_bug.cgi?id=43157

• Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
• Shared/CoreIPCSupport/WebProcessMessageKinds.h: (WebProcessMessage::):
• Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: (WebProcessProxyMessage::):

Move HistoryClient support from the page...:

• UIProcess/API/C/WKPage.cpp:
• UIProcess/API/C/WKPage.h:

...to the Context

• UIProcess/API/C/WKContext.cpp: (WKContextSetHistoryClient):
• UIProcess/API/C/WKContext.h:

• UIProcess/WebContext.cpp: (WebKit::WebContext::initializeHistoryClient): (WebKit::WebContext::ensureWebProcess): When a new WebProcess is created, set its "should track visited links" mode. (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): (WebKit::WebContext::populateVisitedLinks):
• UIProcess/WebContext.h: (WebKit::WebContext::hasValidProcess):

• UIProcess/WebHistoryClient.cpp: (WebKit::WebHistoryClient::initialize): (WebKit::WebHistoryClient::didNavigateWithNavigationData): (WebKit::WebHistoryClient::didPerformClientRedirect): (WebKit::WebHistoryClient::didPerformServerRedirect): (WebKit::WebHistoryClient::didUpdateHistoryTitle): (WebKit::WebHistoryClient::populateVisitedLinks):
• UIProcess/WebHistoryClient.h: (WebKit::WebHistoryClient::shouldTrackVisitedLinks):

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage):
• UIProcess/WebPageProxy.h:

• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage): (WebKit::WebProcessProxy::didReceiveSyncMessage):

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::populateVisitedLinks):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::updateGlobalHistory): (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): (WebKit::WebFrameLoaderClient::setTitle):

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage):

5:26 PM WebKitGtkLayoutTests edited by Martin Robinson

(diff)

5:25 PM WebKitGtkLayoutTests edited by Martin Robinson

Fix depth argument to Xvfb (16 -> 24) (diff)

5:14 PM Changeset in webkit [64246] by andersca@apple.com

• 6 edits in trunk

Implement NPN_InvokeDefault and NPN_Construct
​https://bugs.webkit.org/show_bug.cgi?id=43160

Reviewed by Sam Weinig.

WebKit2:

• WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):
Just call invoke directly.

(WebKit::NPJSObject::invokeDefault):
Call invoke.

(WebKit::NPJSObject::construct):
Implement this.

(WebKit::NPJSObject::invoke):
Add new invoke overload that takes the function as a JSValue.

(WebKit::NPJSObject::npClass):
Add NP_Construct.

(WebKit::NPJSObject::NP_InvokeDefault):
Call NPJSObject::invokeDefault.

(WebKit::NPJSObject::NP_Construct):
Call NPJSObject::construct.

• WebProcess/Plugins/NPJSObject.h:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle the Core Animation drawing model and the Carbon event model.

(WebKit::NPN_InvokeDefault):
Call the NPClass::invokeDefault function.

(WebKit::NPN_Construct):
Call the NPClass::construct function.

LayoutTests:

• platform/mac-wk2/Skipped:

Remove plugins/npruntime/invoke-default.html

4:45 PM Changeset in webkit [64245] by kim.1.gronholm@nokia.com

• 5 edits in trunk/WebKit/qt

2010-07-28 Kim Grönholm <​kim.1.gronholm@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Decouple QTouchEvent's accepted flag from JS prevent default
​https://bugs.webkit.org/show_bug.cgi?id=42892

Added comments to the touch event handling code.

• Api/qgraphicswebview.cpp: (QGraphicsWebView::sceneEvent):
• Api/qwebpage.cpp: (QWebPagePrivate::touchEvent): (QWebPage::event):
• Api/qwebpage_p.h:
• Api/qwebview.cpp: (QWebView::event):

4:38 PM Changeset in webkit [64244] by andersca@apple.com

• 6 edits in trunk

Implement NPN_Invoke
​https://bugs.webkit.org/show_bug.cgi?id=43158

Reviewed by Sam Weinig.

WebKit2:

• WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::hasMethod):
Use the free getCallData function.

(WebKit::NPJSObject::invoke):
Get the JavaScript function and call it.

(WebKit::NPJSObject::NP_Invoke):
Call NPJSObject::invoke.

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_Invoke):
Call the NPClass::invoke function.

LayoutTests:

• platform/mac-wk2/Skipped:

Remove plugins/npruntime/invoke.html.

4:32 PM Changeset in webkit [64243] by darin@chromium.org

• 4 edits in trunk/WebKit/chromium

2010-07-28 Gene Gutnik <​gene@google.com>

Reviewed by Darin Fisher.

Fix mouse coordinate conversion. WindowX,Y is an absolute
mouse coordinates within browser window, x,y - are coordinates
relative to the plugin.
​https://bugs.webkit.org/show_bug.cgi?id=42987

• src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
• src/WebInputEventConversion.h:
• src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent):

4:21 PM Changeset in webkit [64242] by tony@chromium.org

• 6 edits in trunk

2010-07-28 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

implement getData('text/html') for webkit win
​https://bugs.webkit.org/show_bug.cgi?id=37981

• platform/win/Skipped: 2 tests now pass

2010-07-28 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

implement getData('text/html') for webkit win
​https://bugs.webkit.org/show_bug.cgi?id=37981

• platform/win/ClipboardUtilitiesWin.cpp: (WebCore::extractMarkupFromCFHTML): (WebCore::getCFHTML): (WebCore::fragmentFromCFHTML): (WebCore::fragmentFromHTML):
• platform/win/ClipboardUtilitiesWin.h:
• platform/win/ClipboardWin.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardWin::getData):

4:18 PM Changeset in webkit [64241] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

2010-07-28 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Darin Adler.

mask-colorspace.svg result for chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=43100

blocking:

[chromium] r63450 caused some svg mask tests to fail pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42403

New expectations and baseline for mask-colorspace on Linux that
reflect my idea of what should be the passing output as of when
I wrote the original patch. In fact the inner circle should be
78,78,78 instead of 76,76,76 but while I sort out the broken
baselines I'm going to consider this an improvement; at least
the two images match each other as intended in the original test.

• platform/chromium-linux/svg/custom/mask-colorspace-expected.checksum: Added.
• platform/chromium-linux/svg/custom/mask-colorspace-expected.png: Added.
• platform/chromium/test_expectations.txt:

4:03 PM Changeset in webkit [64240] by andersca@apple.com

• 6 edits in trunk

Implement NPN_HasMethod
​https://bugs.webkit.org/show_bug.cgi?id=43155

Reviewed by Sam Weinig.

WebKit2:

• WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::hasMethod):
Check if the JSObject has a property with the given name. If it does, check that the value is a function.

(WebKit::NPJSObject::hasProperty):
Add a JSLock.

(WebKit::NPJSObject::npClass):
Add some stubbed out functions.

(WebKit::NPJSObject::NP_HasMethod):
Call NPJSObject::hasMethod.

(WebKit::NPJSObject::NP_Invoke):
(WebKit::NPJSObject::NP_InvokeDefault):
(WebKit::NPJSObject::NP_SetProperty):
Stub out functions.

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_HasMethod):
Call the NPClass::hasMethod function.

LayoutTests:

• platform/mac-wk2/Skipped:

Remove plugins/npruntime/invoke-browserfuncs.html.

3:50 PM Changeset in webkit [64239] by kevino@webkit.org

• 2 edits in trunk/WebKit/wx

[wx] wxPython build fix that was missed in last commit.

3:39 PM Changeset in webkit [64238] by beidson@apple.com

• 2 edits in trunk/WebKit2

Make sure new pages are always added to the same PageGroup (for now).

Rubberstamped by Sam Weinig.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

3:31 PM Changeset in webkit [64237] by abarth@webkit.org

• 6 edits in trunk

2010-07-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update numbered header element closing to match recent spec change
​https://bugs.webkit.org/show_bug.cgi?id=43072

• html5lib/runner-expected-html5.txt:

2010-07-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update numbered header element closing to match recent spec change
​https://bugs.webkit.org/show_bug.cgi?id=43072

Pretty straightforward transcription of the spec change.

• html/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped): (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
• html/HTMLElementStack.h:
• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processEndTagForInBody):

3:15 PM Changeset in webkit [64236] by kevino@webkit.org

• 2 edits
  1 add in trunk/WebKit/wx

[wx] Build fix after recent changes.

3:09 PM Changeset in webkit [64235] by andersca@apple.com

• 5 edits in trunk

Implement JSNPObject::put
​https://bugs.webkit.org/show_bug.cgi?id=43149

Reviewed by Sam Weinig.

WebKit2:

• WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlot):
Fix a typo.

(WebKit::JSNPObject::getOwnPropertyDescriptor):
Implement this in the same way as it's implemented in RuntimeObject.

(WebKit::JSNPObject::put):
Implement this, call NPClass::setProperty.

• WebProcess/Plugins/JSNPObject.h:

LayoutTests:

• platform/mac-wk2/Skipped:

Remove now passing tests.

2:55 PM Changeset in webkit [64234] by eric@webkit.org

• 2 edits in trunk/LayoutTests

2010-07-28 Eric Seidel <​eric@webkit.org>

No review. Skipping test to restore peace and justice.

REGRESSION(63862): animations/play-state.html fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=42821

• platform/mac/Skipped:
  • Attempt to staunch the bleeding by skipping this flake-zor.

2:51 PM UsingGitWithWebKit edited by dimich@chromium.org

(diff)

2:47 PM Changeset in webkit [64233] by victorw@chromium.org

• 1 edit
  8 adds in trunk/LayoutTests

2010-07-28 Victor Wang <​victorw@chromium.org>

Unreviewed. Add chromium baselines for test:
fast/table/early-table-layout

• platform/chromium-linux/fast/table/early-table-layout-expected.checksum: Added.
• platform/chromium-linux/fast/table/early-table-layout-expected.png: Added.
• platform/chromium-mac/fast/table/early-table-layout-expected.checksum: Added.
• platform/chromium-mac/fast/table/early-table-layout-expected.png: Added.
• platform/chromium-mac/fast/table/early-table-layout-expected.txt: Added.
• platform/chromium-win/fast/table/early-table-layout-expected.checksum: Added.
• platform/chromium-win/fast/table/early-table-layout-expected.png: Added.
• platform/chromium-win/fast/table/early-table-layout-expected.txt: Added.

2:42 PM Changeset in webkit [64232] by weinig@apple.com

• 29 edits
  2 adds in trunk/WebKit2

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43097
Make all objects in the WebKit2 API inherit from a single base class

Reviewed by Anders Carlsson.

• Adds an APIObject base class for all objects which can get vender through the C API to inherit from.
• Adds a WebString class which wraps WebCore::String for now. I am not too fond of this solution, so we continue should iterate on it.
• This is a first step toward make a CF-style base type (eg. CFTypeRef) for the C-API.

• Shared/APIObject.h: Added.

(WebKit::APIObject::APIObject):
Base class for API objects.

• Shared/ImmutableArray.h:

Make inherit from APIObject.

• Shared/WebString.h: Added.

(WebKit::WebString::create):
(WebKit::WebString::isNull):
(WebKit::WebString::isEmpty):
(WebKit::WebString::string):
(WebKit::WebString::WebString):
Wraps a WebCore::String so that it can be passed out to the API
and still inherit from APIObject.

• UIProcess/API/C/WKAPICast.h:

(WebKit::WebStringAdaptor::WebStringAdaptor):
(WebKit::WebStringAdaptor::operator WKStringRef):
(WebKit::WebStringAdaptor::operator WKURLRef):
Update conversion methods to deal in terms of WebStrings. Added WebStringAdaptor
to ease passing strings to client functions.

• UIProcess/API/C/WKContext.cpp:

(WKContextCreateWithInjectedBundlePath):
(WKContextPostMessageToInjectedBundle):
(_WKContextSetAdditionalPluginPath):
(_WKContextRegisterURLSchemeAsEmptyDocument):
Get the WebCore::String from the WebString.

• UIProcess/API/C/WKPage.cpp:

(WKPageLoadURL):
Ditto.

• UIProcess/API/C/WKString.cpp:

(WKStringIsEmpty):
Implement in terms of WebString.

• UIProcess/API/C/WKURL.cpp:
• UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCreateWithCFString):
(WKStringCopyCFString):
Ditto.

• UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):
Ditto.

• UIProcess/WebBackForwardList.h:

Make inherit from APIObject.

• UIProcess/WebBackForwardListItem.h:

Ditto.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveMessageFromInjectedBundle):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::registerURLSchemeAsEmptyDocument):
Use String instead of StringImpl to be consistent.

• UIProcess/WebContext.h:

Make inherit from APIObject.

• UIProcess/WebFramePolicyListenerProxy.h:

Ditto.

• UIProcess/WebFrameProxy.h:

Ditto.

• UIProcess/WebNavigationData.h:

Ditto.

• UIProcess/WebPageNamespace.h:

Ditto.

• UIProcess/WebPageProxy.h:

Ditto.

• UIProcess/WebPreferences.h:

Ditto.

• UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptPrompt):
Implement in terms of WebString.

• UIProcess/win/WebView.h:

Make inherit from APIObject.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):
Get the WebCore::String from the WebString.

• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFramePauseAnimationOnElementWithId):
Ditto.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):

• WebProcess/InjectedBundle/InjectedBundle.h:

Use String instead of StringImpl to be consistent.

• WebProcess/WebPage/WebFrame.h:

Make inherit from APIObject.

• WebProcess/WebPage/WebPage.h:

Make inherit from APIObject.

• win/WebKit2.vcproj:

Add new files.

2:30 PM Changeset in webkit [64231] by andersca@apple.com

• 15 edits
  1 copy
  1 add in trunk

Add support for calling NPObject methods
​https://bugs.webkit.org/show_bug.cgi?id=43145

Reviewed by Sam Weinig.

WebCore:

• WebCore.exp.in:

Export JSHTMLElement::s_info and pluginScriptObject.

• WebCore.xcodeproj/project.pbxproj:

Make JSHTMLElement.h and JSPluginElementFunctions.h private headers.

• bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject):

• bindings/js/JSPluginElementFunctions.h:

Make pluginScriptObject a public function.

WebKit2:

• WebKit2.xcodeproj/project.pbxproj:

Add JSNPMethod.cpp and JSNPMethod.h

• WebProcess/Plugins/JSNPMethod.cpp: Added.
• WebProcess/Plugins/JSNPMethod.h: Added.
• WebProcess/Plugins/JSNPObject.cpp:

(WebKit::):
Add a ClassInfo static variable for JSNPObject.

(WebKit::JSNPObject::callMethod):
Convert the passed in arguments, call the method and convert the result back.

(WebKit::JSNPObject::getOwnPropertySlot):
Check if the NPObject has a method.

(WebKit::JSNPObject::methodGetter):
Return a new JSNPMethod.

• WebProcess/Plugins/JSNPObject.h:

(WebKit::JSNPObject::classInfo):
Return the s_info.

• WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::getProperty):
Get the property from the JSObject.

• WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
Convert the given JSValue to an NPVariant.

• win/WebKit2.vcproj:

Add JSNPMethod.cpp and JSNPMethod.h

LayoutTests:

• platform/mac-wk2/Skipped:

Remove plugins/npruntime/get-int-identifier-special-values.html since it passes now.

2:18 PM Changeset in webkit [64230] by jamesr@google.com

• 7 edits in trunk

2010-07-28 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add a bool to Settings to control accelerated 2d canvas
​https://bugs.webkit.org/show_bug.cgi?id=43094

• public/WebSettings.h:
• src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAccelerated2dCanvasEnabled):
• src/WebSettingsImpl.h:

2010-07-28 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add a bool to Settings to control accelerated 2d canvas
​https://bugs.webkit.org/show_bug.cgi?id=43094

Currently this doesn't control anything, but it will soon.

• page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAccelerated2dCanvasEnabled):
• page/Settings.h: (WebCore::Settings::accelerated2dCanvasEnabled):

1:51 PM Changeset in webkit [64229] by kevino@webkit.org

• 23 edits
  2 adds in trunk

Reviewed by Kevin Ollivier.

Add DOM bindings support for wx port.

1:47 PM WebKitGtkLayoutTests edited by Martin Robinson

(diff)

1:46 PM WebKitGtkLayoutTests edited by Martin Robinson

(diff)

1:45 PM WebKitGtkLayoutTests edited by Martin Robinson

Added some further information about running layout tests (diff)

1:41 PM WebKitGtkLayoutTests created by Martin Robinson

1:41 PM Changeset in webkit [64228] by victorw@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-28 Victor Wang <​victorw@chromium.org>

Unreviewed. Fix chromium test expectations:
Remove duplicate expectation for test:
tables/mozilla/other/slashlogo.html

• platform/chromium/test_expectations.txt:

1:24 PM WebKitGTK edited by Martin Robinson

(diff)

1:23 PM WebKitGTK edited by Martin Robinson

(diff)

1:21 PM Changeset in webkit [64227] by senorblanco@chromium.org

• 4 edits in trunk/WebCore

2010-07-28 Stephen White <​senorblanco@chromium.org>

Reviewed by Darin Fisher.

Hook the GLES2 rendering path up to GraphicsContextSkia.
​https://bugs.webkit.org/show_bug.cgi?id=43119

This connects the state-setting and drawing calls implemented in
so far in GLES2Canvas, and calls PlatformContextSkia's
prepareForSoftwareDraw() for all the non-accelerated paths.

• platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect): These calls are software-only; call preSoftwareDraw() for these. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): These ones set state on both Skia and GLES2Canvas. (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::fillRect): These ones have a GLES2 implementation; call through to it if PlatformContextSkia's useGPU() flag is set and the state permits.
• platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::prepareForSoftwareDraw): (PlatformContextSkia::prepareForHardwareDraw): Rename preXXXDraw() -> prepareForXXXDraw().
• platform/graphics/skia/PlatformContextSkia.h: (PlatformContextSkia::prepareForSoftwareDraw): (PlatformContextSkia::prepareForHardwareDraw): Rename preXXXDraw() -> prepareForXXXDraw().

1:12 PM Changeset in webkit [64226] by crogers@google.com

• 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

another audio branch build fix

1:07 PM Changeset in webkit [64225] by jamesr@google.com

• 7 edits
  4 adds in trunk

2010-07-28 ​fsamuel@chromium.org <​fsamuel@chromium.org>

Reviewed by David Hyatt.

REGRESSION (r63994): Bank of America's home page is horribly mis-rendered
​https://bugs.webkit.org/show_bug.cgi?id=42993

Fixed bug introduced by patch for bug 40775.

The new table rendering code did not take into account table layouts starting
during a partial construction of the table render tree. As such,
multiple layouts on the same table resulted in more columns being generated.
This patch solves this issue.

• rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
• rendering/RenderTable.cpp: (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::appendColumn): (WebCore::RenderTableSection::splitColumn):
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::CellStruct::CellStruct):

2010-07-28 ​fsamuel@chromium.org <​fsamuel@chromium.org>

Reviewed by David Hyatt.

REGRESSION (r63994): Bank of America's home page is horribly mis-rendered
​https://bugs.webkit.org/show_bug.cgi?id=42993

Restored the expectation for the slashdot logo table test.

Added a new layout test to check for the correctness of early table layout.

• fast/table/early-table-layout.html: Added.
• platform/chromium/test_expectations.txt:
• platform/gtk/fast/table/early-table-layout-expected.checksum: Added.
• platform/gtk/fast/table/early-table-layout-expected.png: Added.
• platform/gtk/fast/table/early-table-layout-expected.txt: Added.

12:54 PM Changeset in webkit [64224] by Adam Roben

• 2 edits in trunk/WebKit2

Teach CoreIPC how to handle with a pipe closing during a write

Fixes <​http://webkit.org/b/43131> Assertion failure in
Connection::sendOutgoingMessage if the other process exits at just the
wrong time

Reviewed by Darin Adler.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage): If ::WriteFile fails with
ERROR_NO_DATA, the pipe (and thus the connection) has closed.

12:54 PM Changeset in webkit [64223] by Adam Roben

• 7 edits in trunk/WebKit2

Teach CoreIPC the right way to send large messages on Windows

r63776 added support for ::WriteFile failing with ERROR_IO_PENDING,
but it had a major flaw: we didn't ensure that the data being sent
(which is owned by the ArgumentEncoder) stayed around until the write
finished. We'd destroy the data immediately, leading to ::WriteFile
accessing that freed memory later. This seemed to always manifest
itself as a crash in ::WaitForMultipleObjects.

The correct solution (as hinted above) is to make sure that the data
being written is not destroyed until the write completes. When
::WriteFile fails with ERROR_IO_PENDING, we store the data being sent
in Connection::m_pendingWriteArguments, and don't send any more
messages until that write completes. We use an event in the OVERLAPPED
structure passed to ::WriteFile to detect when the write has completed
(similar to what we do for reads).

Fixes <​http://webkit.org/b/42785> <rdar://problem/8218522> Crash in
WebKit2WebProcess in WaitForMultipleObjects beneath
WorkQueue::workQueueThreadBody when running tests that produce a lot
of output

Reviewed by Anders Carlsson.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::canSendOutgoingMessages): Added. This calls out
to a platform-specific function to allow each platform to have its own
policy for when messages can and can't be sent.
(CoreIPC::Connection::sendOutgoingMessages): Use the new
canSendOutgoingMessages to determine whether we can send any messages
right now. We now remove one message at a time from m_outgoingMessages
and send it. We stop sending messages when sendOutgoingMessage returns
false.

• Platform/CoreIPC/Connection.h: Added m_pendingWriteArguments and

m_writeState on Windows.
(CoreIPC::Connection::Message::Message): Added this default
constructor.

• Platform/CoreIPC/MessageID.h:

(CoreIPC::MessageID::MessageID): Made the default constructor public
for Message's benefit.

• Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformCanSendOutgoingMessages): Added. Always
returns true.
(CoreIPC::Connection::sendOutgoingMessage): Changed to return a
boolean indicating whether more messages can be sent at this time.

• Platform/CoreIPC/qt/ConnectionQt.cpp:

(CoreIPC::Connection::platformCanSendOutgoingMessages): Added. Returns
true if we have a socket.
(CoreIPC::Connection::sendOutgoingMessage): Changed a null-check of
m_socket to an assertion since it should be checked for null in
platformCanSendOutgoingMessages. Changed to return a boolean
indicating whether more messages can be sent at this time.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInitialize): Added initialization of
m_writeState.
(CoreIPC::Connection::platformInvalidate): Close m_writeState's event
handle.
(CoreIPC::Connection::writeEventHandler): Added. Checks if the pending
write has completed, cleans up our pending write state, and sends any
remaining messages.
(CoreIPC::Connection::open): Register our write event with the
WorkQueue so that writeEventHandler will be called when the event is
signaled.
(CoreIPC::Connection::platformCanSendOutgoingMessages): Added. We can
only send messages if there isn't a write pending.
(CoreIPC::Connection::sendOutgoingMessage): Changed to return a
boolean indicating whether more messages can be sent at this time. We
now pass m_writeState to ::WriteFile instead of an empty OVERLAPPED
struct so that our write event will be signaled when the write
completes. We also no longer pass a pointer to receive how many bytes
were written, as recommended by MSDN. If ::WriteFile fails with
ERROR_IO_PENDING, we save the ArgumentEncoder for this message and
return false to indicate that no more messages can be sent at this
time.

12:53 PM Changeset in webkit [64222] by crogers@google.com

• 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

Fix audio branch build

12:53 PM Changeset in webkit [64221] by Adam Roben

• 2 edits in trunk/WebKit2

Stop leaking Connection::m_readState.hEvent on Windows

Fixes <​http://webkit.org/b/43129> CoreIPC::Connection leaks its read
event on Windows

Reviewed by Darin Adler.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInvalidate): Close the event handle.

12:44 PM Changeset in webkit [64220] by brettw@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-07-28 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Fix forward declares to be struct instead of class.
​https://bugs.webkit.org/show_bug.cgi?id=43127

• public/WebFont.h:

12:23 PM Changeset in webkit [64219] by tony@chromium.org

• 3 edits in trunk/WebKitTools

2010-07-28 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup temp files left by Linux DRT
​https://bugs.webkit.org/show_bug.cgi?id=43062

• BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
• BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left

by crashed DRTs

12:20 PM Changeset in webkit [64218] by victorw@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-28 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for tesst that
may crash on mac or linux:
fast/dom/prototype-inheritance-2.html

• platform/chromium/test_expectations.txt:

12:16 PM Changeset in webkit [64217] by tonikitoo@webkit.org

• 2 edits in trunk/WebKitTools

2010-07-28 Antonio Gomes <​tonikitoo@webkit.org>

Rubber-stamped by Kenneth Christiansen.

More Developer menu items reordering.

Grouping related menu items together, visually and logically (in the code).

No behavior change.

• QtTestBrowser/main.cpp:

12:04 PM Changeset in webkit [64216] by crogers@google.com

• 18 edits in branches/audio/WebCore

Add DelayNode variable audio delay effect

• currently limited to no more than one second delay, but not difficult to increase limit

12:04 PM Changeset in webkit [64215] by crogers@google.com

• 11 edits
  2 copies
  4 adds in branches/audio/WebCore

Add AudioChannelSplitter and AudioChannelMerger classes

• works with the limited testing so far
• currently hard-coded to limit of no more than six channels (sufficient for up to 5.1) but can easily be increased

11:31 AM Changeset in webkit [64214] by victorw@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-28 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for test:
storage/indexeddb/objectstore-basics.html

• storage/indexeddb/objectstore-basics-expected.txt:

11:18 AM WebKit Team edited by noam.rosenthal@nokia.com

(diff)

11:17 AM WebKit Team edited by noam.rosenthal@nokia.com

(diff)

11:04 AM WebKitGTK edited by Martin Robinson

Small cleanups (diff)

11:01 AM WebKitGTK edited by Martin Robinson

Added information about filing bugs against WebKitGTK (diff)

10:54 AM Changeset in webkit [64213] by tonyg@chromium.org

• 2 edits in trunk/WebCore

2010-07-28 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Pavel Feldman.

Exclude DNS and SSL time from connect time
​https://bugs.webkit.org/show_bug.cgi?id=43083

The ResourceLoadTiming API's definition of the connect phase includes
DNS and SSL time. However, the Web Timing spec wants just the TCP time.
So this patch subtracts those phases out.

No new tests because ResourceLoadTiming fields are not populated by
TestShell yet.

• page/Timing.cpp: (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd):

10:40 AM Changeset in webkit [64212] by andreip@google.com

• 2 edits in trunk/LayoutTests

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The text expectations for storage/objectore-basics.html are out of date
​https://bugs.webkit.org/show_bug.cgi?id=43126

Following ​http://trac.webkit.org/changeset/64209
the objectstore-basics-expected.txt file should be updated to reflect
the new tests.

• storage/indexeddb/objectstore-basics-expected.txt:

10:17 AM Changeset in webkit [64211] by pfeldman@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-07-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium DevTools: [REGRESSION] sourceURL is not respected.

​https://bugs.webkit.org/show_bug.cgi?id=43124

• src/js/DebuggerScript.js:

9:34 AM Changeset in webkit [64210] by andreip@google.com

• 3 edits in trunk/LayoutTests

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

Skip IDBKeyRange from the prototype-inheritance layout test.
IDBKeyRange is a DOM object and, with V8, it seems that such objects
do not respect the prototype inheritance.

Once IndexedDatabase is done, we should remove indexedDB and IDBKeyRange
from the list of skipped window properties and we should update the
Chromium and Android test expectations.

fast/dom/prototype-inheritance.html fails from r64141
​https://bugs.webkit.org/show_bug.cgi?id=43067

• fast/dom/script-tests/prototype-inheritance.js:
• platform/chromium/test_expectations.txt:

9:27 AM Changeset in webkit [64209] by andreip@google.com

• 5 edits in trunk

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
​https://bugs.webkit.org/show_bug.cgi?id=43120

• storage/indexeddb/script-tests/objectstore-basics.js: (openSuccess): (createSuccess):

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] WebDOMStringList default ctor does not initialize its m_private member
variable so any attempt to append strings to a WebDOMStringList instance results in a crash.
​https://bugs.webkit.org/show_bug.cgi?id=43120

Makes the default WebKit::WebDOMStringList ctor actually create its wrapped
WebCore::DOMStringList instance.

• public/WebDOMStringList.h:
• src/WebDOMStringList.cpp: (WebKit::WebDOMStringList::WebDOMStringList):

9:13 AM Changeset in webkit [64208] by steveblock@google.com

• 21 edits in trunk

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• webkit/webkitwebview.cpp: (webkit_web_view_init):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• WebView.cpp: (WebView::initWithFrame):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• WebView.cpp: (wxWebView::Create):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• ewk/ewk_view.cpp: (_ewk_view_priv_new):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

No new tests, refactoring only.

• WebCore.exp.in:
• page/Page.cpp: (WebCore::Page::Page):
• page/Page.h: (WebCore::Page::PageClients::PageClients):
• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Page clients should be passed to Page constructor via structure of pointers
​https://bugs.webkit.org/show_bug.cgi?id=42834

• WebKit2/WebProcess/WebPage/WebPage.cpp: (WebPage::WebPage):

9:00 AM Changeset in webkit [64207] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

2010-07-28 Xianzhu Wang <​phnixwxz@gmail.com>

Reviewed by Dan Bernstein.

Line not wrapped at certain punctuations
​https://bugs.webkit.org/show_bug.cgi?id=37698

• fast/text/line-breaks-after-closing-punctuations-expected.txt: Added.
• fast/text/line-breaks-after-closing-punctuations.html: Added.

2010-07-28 Xianzhu Wang <​phnixwxz@gmail.com>

Reviewed by Dan Bernstein.

Line not wrapped at certain punctuations
​https://bugs.webkit.org/show_bug.cgi?id=37698
Added a line breaking table for all printable ASCII chars to replace
the original line breaking table for only '?'.

Test: fast/text/line-breaks-after-closing-punctuations.html

• rendering/break_lines.cpp: (WebCore::isBreakableSpace): (WebCore::): (WebCore::shouldBreakAfter): (WebCore::needsLineBreakIterator):

8:26 AM Changeset in webkit [64206] by leandro@webkit.org

• 2 edits in trunk/WebCore

2010-07-28 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix.

Fix EFL build with SHARED_CORE=ON after r64124.

• CMakeLists.txt:

8:19 AM Changeset in webkit [64205] by jcivelli@chromium.org

• 2 edits in trunk/WebCore

2010-07-28 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Kent Tamura.

[Chromium] The popup now layouts properly its rows by
taking into account the label width.
​https://bugs.webkit.org/show_bug.cgi?id=42910

• platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

7:59 AM Changeset in webkit [64204] by pfeldman@chromium.org

• 4 edits in trunk

2010-07-28 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium tests fix.
Chromium Dev Tools: [REGRESSION] Pause is not working.

​https://bugs.webkit.org/show_bug.cgi?id=43118

• src/js/DevTools.js: (InspectorBackend.pause):

7:32 AM Changeset in webkit [64203] by loislo@chromium.org

• 3 edits in trunk/WebCore

2010-07-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Navigating to anchor prior to opening WebInspector
makes resource have 'other' type.
​https://bugs.webkit.org/show_bug.cgi?id=43110

• inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
• inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):

5:55 AM Changeset in webkit [64202] by andreas.kling@nokia.com

• 2 edits in trunk/WebCore

2010-07-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] putImageData(): Combine premultiplication and BGR->RGB
​https://bugs.webkit.org/show_bug.cgi?id=43114

Further optimized putImageData() by doing BGR->RGB inside the
premultiplication routine.

• platform/graphics/qt/ImageBufferQt.cpp: (WebCore::premultiplyABGRtoARGB): Renamed from premultiply. (WebCore::putImageData):

5:37 AM Changeset in webkit [64201] by andreip@google.com

• 3 edits in trunk/WebCore

2010-07-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IDBKeyRange should be a runtime-enabled feature.
​https://bugs.webkit.org/show_bug.cgi?id=43116

IDBKeyRange should be enabled at runtime only when IndexedDB is also
enabled.

No new tests needed, functionality not changed.

• bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::iDBKeyRangeEnabled):
• page/DOMWindow.idl:

4:53 AM WinCE edited by cortexian@gmail.com

(diff)

4:20 AM Changeset in webkit [64200] by Nikolas Zimmermann

• 2 edits in trunk/WebCore

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to land GNUmakefile.am changes, broke build in r64196.

• GNUmakefile.am: Add SVGResources.* / SVGResourcesCache.* / SVGResourcesCycleSolver.* to build.

4:16 AM Changeset in webkit [64199] by Nikolas Zimmermann

• 1 edit
  1 delete in trunk/LayoutTests

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix two layout test failure on the windows slave. Remove win-xp specific results after the r64186 change.

• platform/win-xp/fast/lists: Removed.
• platform/win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
• platform/win-xp/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.

4:14 AM Changeset in webkit [64198] by Nikolas Zimmermann

• 1 edit
  1 delete in trunk/LayoutTests

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix layout test failure on Leopard Intel Debug slave. Remove leopard specific result after the r64186 change.

• platform/mac-leopard/fast/lists: Removed.
• platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.

4:09 AM Changeset in webkit [64197] by Nikolas Zimmermann

• 5 edits in trunk/WebCore

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGMaskElement/SVGForeignObjectElement should not inherit from SVGURIReference
​https://bugs.webkit.org/show_bug.cgi?id=43113

Remove wrong SVGURIReference inheritance for SVGMaskElement/SVGForeignObjectElement. Old copy/paste bug.

• svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::synchronizeProperty):
• svg/SVGForeignObjectElement.h:
• svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::synchronizeProperty):
• svg/SVGMaskElement.h:

3:55 AM Changeset in webkit [64196] by Nikolas Zimmermann

• 13 edits
  7 adds in trunk/WebCore

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

WebKit shouldn't ignore resource cycles, but break them as Opera does
​https://bugs.webkit.org/show_bug.cgi?id=43031

Don't ignore resources containing cyclic references, but break them, as discussed on SVG WG mailing lists - to be compatible with Opera which already does that.

We used to lookup RenderSVGResourceContainers objects, by extracting the URI reference from the SVGRenderStyle, then utilizing getElementById() to lookup the
node, and access its renderer. Opera ignores such references, if they point to resources that contain cyclic references. Ignoring them would mean we have
to mutate the render style to empty the resource strings. That obviously doesn't work, as it would break expectations (getComputedStyle, etc.).

Introduce a SVGResources class that stores pointers to all resources, that can be applied to a RenderObject (clipper/filter/markers/masker).
Add a SVGResourcesCache class, which is basically a HashMap<RenderObject*, SVGResources*>. Whenever a RenderObject receives style, we extract the URI references
from the SVGRenderStyle, look up the RenderSVGResourceContainer* objects, and store them in a SVGResources* class. Then we execute a cycle detection logic,
which detects cyclic references and breaks them. Breaking them means just nulling the pointer to the resource in the SVGResources object. Those SVGResources
objects are cached, and used throughout the render tree to access resources. This way it's guaranteed that all cyclic references are resolved until layout/paint
phase begins.

This is the first chunk, which just adds the new SVGResources/SVGResourcesCache/SVGResourcesCycleSolver files, and does minor cleanups.
It's not yet glued in and doesn't affect any tests.

• Android.mk: Add SVGResources.* / SVGResourcesCache.* / SVGResourcesCycleSolver.* to build.
• CMakeLists.txt: Ditto.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• rendering/RenderInline.h: Make styleDidChange protected, RenderSVGInline wants to override it.
• rendering/RenderSVGAllInOne.cpp: Add SVGResources.* / SVGResourcesCache.* / SVGResourcesCycleSolver.* to build.
• rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer): Make isSVGHiddenContainer() private and renderName() public.
• rendering/RenderSVGResourceContainer.cpp: Added. Moved most methods from the header in the implementation file. (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke): (WebCore::RenderSVGResourceContainer::containsCyclicReference):
• rendering/RenderSVGResourceContainer.h: Add stubs, that SVGResourcesCache uses - a follow-up patch will add the logic. (WebCore::RenderSVGResourceContainer::addClient): (WebCore::RenderSVGResourceContainer::removeClient):
• rendering/SVGResources.cpp: Added. Holds a list of resources applyable to a RenderObject (fill/stroke, mask/markers/clipper/filter) (WebCore::paintingResourceFromSVGPaint): Helper function looking up a RenderSVGResource for a SVGPaint object. (WebCore::registerPendingResource): Helper function that register a RenderSVGResource as pending in the SVGDocumentExtensions. (WebCore::SVGResources::buildCachedResources): Build a list of resources for a RenderObject/RenderStyle pair, handles pending resources, if needed. (WebCore::SVGResources::invalidateClient): Helper function that calls invalidateClient() on all resources. (WebCore::SVGResources::resourceDestroyed): Helper function that calls invalidateClients() on a certain resource, and nulls it. (WebCore::SVGResources::buildSetOfResources): Helper function that stashes all resources present in the SVGResources members in a HashSet, used in SVGResourcesCycleSolver. (WebCore::SVGResources::resetClipper): Helper methods nulling a resource. (WebCore::SVGResources::resetFilter): Ditto. (WebCore::SVGResources::resetMarkerStart): Ditto. (WebCore::SVGResources::resetMarkerMid): Ditto. (WebCore::SVGResources::resetMarkerEnd): Ditto. (WebCore::SVGResources::resetMasker): Ditto. (WebCore::SVGResources::resetFill): Ditto. (WebCore::SVGResources::resetStroke): Ditto. (WebCore::SVGResources::dump):
• rendering/SVGResources.h: Added. (WebCore::SVGResources::clipper): Accesor of the cached m_foo variable. (WebCore::SVGResources::filter): Ditto. (WebCore::SVGResources::markerStart): Ditto. (WebCore::SVGResources::markerMid): Ditto. (WebCore::SVGResources::markerEnd): Ditto. (WebCore::SVGResources::masker): Ditto. (WebCore::SVGResources::fill): Ditto. (WebCore::SVGResources::stroke): Ditto.
• rendering/SVGResourcesCache.cpp: Added. Holds a HashMap<RenderObject*, SVGResources*> and utility functions that update/invalidate the cache. (WebCore::SVGResourcesCache::SVGResourcesCache): (WebCore::SVGResourcesCache::~SVGResourcesCache): (WebCore::SVGResourcesCache::addResourcesFromRenderObject): Build a SVGResources object for a RenderObject and adds it to the cache, then detects & breaks cycles using SVGResourcesCycleSolver. (WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Remove a SVGResources object from the cache. (WebCore::resourcesCacheFromRenderObject): Helper function, retrieving a SVGResourcesCache method from a RenderObject. (WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Returns a SVGResources object from the cache. (WebCore::SVGResourcesCache::clientLayoutChanged): (static) Calls invalidateClient() on all resources that are used by the passed RenderObject. (WebCore::SVGResourcesCache::clientStyleChanged): (static) Updates the cache (calling removeResourceFromRenderObject/addResourcesFrom...) and invalidates resources in the ancestor chain. (WebCore::SVGResourcesCache::clientUpdatedFromElement): (static) Does the same, without invalidating the ancestor chain. (WebCore::SVGResourcesCache::clientDestroyed): (static) Calls removeResourcesFromRenderObject() on the SVGResourcesCache, for the given renderer. (WebCore::SVGResourcesCache::resourceDestroyed): (static) Updates all SVGResources objects in the cache, that refer to the given resource.
• rendering/SVGResourcesCache.h: Added.
• rendering/SVGResourcesCycleSolver.cpp: Added. Detects and breaks cyclic references, just the way Opera handles it. Break cycles as they are detected. (WebCore::SVGResourcesCycleSolver::SVGResourcesCycleSolver): (WebCore::SVGResourcesCycleSolver::~SVGResourcesCycleSolver): (WebCore::SVGResourcesCycleSolver::resourceContainsCycles): Operates only on the render tree (WebCore::targetReferenceFromResource): Helper method for chainableResourceContainsCycles(). (WebCore::setFollowLinkForChainableResource): Ditto. (WebCore::SVGResourcesCycleSolver::chainableResourceContainsCycles): Handles cycles for resources that are chainable through xlink:href (filter/gradient/pattern). (WebCore::SVGResourcesCycleSolver::resolveCycles): Main method executing the cycle breaking logic, utilizing (chainableResource)resourceContainsCycles. (WebCore::SVGResourcesCycleSolver::breakCycle): Nulls a resource in the given SVGResources* object, to avoid using an invalid resource while rendering/layouting.
• rendering/SVGResourcesCycleSolver.h: Added.
• svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): Create SVGResourcesCache object once per SVGDocumentExtensions.
• svg/SVGDocumentExtensions.h: (WebCore::SVGDocumentExtensions::resourcesCache): Expose accesor method for the SVGResourcesCache.

3:12 AM Changeset in webkit [64195] by jorlow@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-28 Jeremy Orlow <​jorlow@chromium.org>

Updating Chromium test expectations to expect 8 tests to fail since
our "test shell" doesn't implement a method required by Daniel Bates'
​http://trac.webkit.org/changeset/64186/ change.

Not reviewed.

• platform/chromium/test_expectations.txt:

3:01 AM Changeset in webkit [64194] by Nikolas Zimmermann

• 3 edits in trunk/LayoutTests

2010-07-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline mac-leopard specific pixel test result after the path cleanup patch.

• platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
• platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:

2:50 AM Changeset in webkit [64193] by abecsi@webkit.org

• 2 edits in trunk/WebKit2

2010-07-28 Andras Becsi <​abecsi@webkit.org>

Unreviewed trivial build fix.

[Qt] Follow the API changes after r64172.

• UIProcess/API/qt/qwkpage.cpp: (QWKPage::url): (QWKPage::title):

1:56 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

1:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

1:33 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

1:08 AM Changeset in webkit [64192] by zherczeg@webkit.org

• 4 edits
  30 adds in trunk

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
​https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

WebCore:

Implementing svgAttributeChanged for SVGFEOffsetElement object.

Tests: svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr.html

svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr.html
svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr.html
svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop.html
svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop.html
svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop.html

• svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

• svg/SVGFEOffsetElement.h:

LayoutTests:

• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr.html: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr.html: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr.html: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop.html: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop.html: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop.html: Added.
• svg/dynamic-updates/script-tests/SVGFEOffsetElement-dom-dx-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEOffsetElement-dom-dy-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEOffsetElement-dom-in-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEOffsetElement-svgdom-dx-prop.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEOffsetElement-svgdom-dy-prop.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEOffsetElement-svgdom-in-prop.js: Added.

(executeTest):

1:03 AM Changeset in webkit [64191] by zherczeg@webkit.org

• 4 edits
  40 adds in trunk

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
​https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

WebCore:

Implementing svgAttributeChanged for SVGFEDiffuseLightingElement object.

Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr.html

svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop.html

• svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

• svg/SVGFEDiffuseLightingElement.h:

LayoutTests:

• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
• platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop.html: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Added.
• svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop.html: Added.
• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-dom-in-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-dom-lighting-color-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-dom-surfaceScale-attr.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-lighting-color-css-prop.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-svgdom-in-prop.js: Added.

(executeTest):

• svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop.js: Added.

(executeTest):

Jul 27, 2010:

10:59 PM Changeset in webkit [64190] by Martin Robinson

• 2 edits in trunk

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed build fix.

Add missing webkitdomdefines.h header to the sources list.

• GNUmakefile.am: Add missing header to the sources list.

10:16 PM Changeset in webkit [64189] by kinuko@chromium.org

• 17 edits in trunk

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• Configurations/FeatureDefines.xcconfig:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• features.gypi:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• Configurations/FeatureDefines.xcconfig:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• win/tools/vsprops/FeatureDefines.vsprops:
• win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• Configurations/FeatureDefines.xcconfig:
• GNUmakefile.am:
• WebCore.pri:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• configure.ac:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

• Scripts/build-webkit:

9:09 PM Changeset in webkit [64188] by dbates@webkit.org

• 1 edit
  7 deletes in trunk/LayoutTests

2010-07-27 Daniel Bates <​dbates@rim.com>

Unreviewed; remove platform-specific expected results.
​https://bugs.webkit.org/show_bug.cgi?id=42803

We no longer need the Qt an GTK platform-specific render tree dumps
as we now dump text.

• platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Removed.
• platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
• platform/qt/fast/lists/alpha-boundary-values-expected.checksum: Removed.
• platform/qt/fast/lists/alpha-boundary-values-expected.png: Removed.
• platform/qt/fast/lists/alpha-boundary-values-expected.txt: Removed.
• platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
• platform/qt/fast/lists/w3-list-styles-expected.txt: Removed.

8:48 PM Changeset in webkit [64187] by yuzo@google.com

• 5 edits in trunk

2010-07-26 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

@page rules in media queries should be tested.
Added tests for such rules.
​https://bugs.webkit.org/show_bug.cgi?id=42971

• printing/page-rule-selection-expected.txt:
• printing/page-rule-selection.html:

2010-07-26 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

@page rules in media queries should be tested.
​https://bugs.webkit.org/show_bug.cgi?id=42971

• page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): Fixed to properly begin printing. Added support for size property.

8:44 PM Changeset in webkit [64186] by dbates@webkit.org

• 10 edits
  8 adds
  25 deletes in trunk/LayoutTests

2010-07-27 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Convert DRT list tests from pixel-tests/render tree dumps to text
​https://bugs.webkit.org/show_bug.cgi?id=42803

With the passing of Bug #37929 and Bug #37930, convert a subset of the
DRT tests for lists from pixel-tests to text-based tests now that we
can retrieve the list item marker text in both the Mac and Windows ports.

• fast/lists/alpha-boundary-values-expected.txt: Added.
• fast/lists/alpha-boundary-values.html: Modified to dump as text.
• fast/lists/alpha-list-wrap-expected.txt: Added.
• fast/lists/alpha-list-wrap.html: Modified to dump as text.
• fast/lists/decimal-leading-zero-expected.txt: Added.
• fast/lists/decimal-leading-zero.html: Modified to dump as text.
• fast/lists/li-values-expected.txt: Added.
• fast/lists/li-values.html: Modified to dump as text.
• fast/lists/list-style-type-dynamic-change-expected.txt: Added.
• fast/lists/list-style-type-dynamic-change.html: Modified to dump as text.
• fast/lists/resources/dump-list.js: (dumpList): Modified to call processList. (filterListsWithReplacement): Added. (processList): Added. (dumpListItemAsHTML): Added. (printPassedIfEmptyString): Added. (printFailedIfListItemMarkerNotEqualListItemText): Added.
• fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
• fast/lists/w3-css3-list-styles-alphabetic.html: Modified to dump as text.
• fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
• fast/lists/w3-css3-list-styles-numeric.html: Modified to dump as text. Also, fix typos in the binary list-style-type results.
• fast/lists/w3-list-styles-expected.txt: Added.
• fast/lists/w3-list-styles.html: Modified to dump as text.
• platform/mac/fast/lists/alpha-boundary-values-expected.checksum: Removed.
• platform/mac/fast/lists/alpha-boundary-values-expected.png: Removed.
• platform/mac/fast/lists/alpha-boundary-values-expected.txt: Removed.
• platform/mac/fast/lists/alpha-list-wrap-expected.checksum: Removed.
• platform/mac/fast/lists/alpha-list-wrap-expected.png: Removed.
• platform/mac/fast/lists/alpha-list-wrap-expected.txt: Removed.
• platform/mac/fast/lists/decimal-leading-zero-expected.checksum: Removed.
• platform/mac/fast/lists/decimal-leading-zero-expected.png: Removed.
• platform/mac/fast/lists/decimal-leading-zero-expected.txt: Removed.
• platform/mac/fast/lists/li-values-expected.checksum: Removed.
• platform/mac/fast/lists/li-values-expected.png: Removed.
• platform/mac/fast/lists/li-values-expected.txt: Removed.
• platform/mac/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
• platform/mac/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
• platform/mac/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
• platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
• platform/mac/fast/lists/w3-list-styles-expected.checksum: Removed.
• platform/mac/fast/lists/w3-list-styles-expected.png: Removed.
• platform/mac/fast/lists/w3-list-styles-expected.txt: Removed.
• platform/win/fast/lists: Removed.
• platform/win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
• platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.

6:50 PM Changeset in webkit [64185] by Martin Robinson

• 3 edits in trunk/WebKitTools

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by David Levin.

Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
​https://bugs.webkit.org/show_bug.cgi?id=43090

• Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
• Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.

5:36 PM Changeset in webkit [64184] by barraclough@apple.com

• 6 edits in trunk/JavaScriptCore

Temporarily rolling out ​http://trac.webkit.org/changeset/64177,
this seems to give QT ARM/Win a headache (specifically, looks
like structure layour differs, objects get too large -
"..\..\..\JavaScriptCore\runtime\ArrayPrototype.cpp:41:"
"error: size of array 'dummyclass_fits_in_cell' is negative").

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

• runtime/JSArray.cpp:

(JSC::increasedVectorLength):
(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):

• runtime/JSArray.h:

(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::markChildrenDirect):

5:30 PM Changeset in webkit [64183] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

Speculative build fix for Chromium/Win

• wtf/Platform.h:

5:04 PM Changeset in webkit [64182] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

Oh! that makes more sense! Maybe C++-style comments are bringing teh bad mojo.

• wtf/Platform.h:

5:00 PM Changeset in webkit [64181] by andersca@apple.com

• 2 edits in trunk/WebKit2

Fix Windows build.

• WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::propertyGetter):
Remove unreachable code.

4:57 PM Changeset in webkit [64180] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

Speculative build fix for GTK/64 ... seems to be barfing on a comment o_O

• wtf/Platform.h:

4:41 PM Changeset in webkit [64179] by scherkus@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-27 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed.

Marking media/controls-drag-timebar.html as flaky due to new seek behaviour.

• platform/chromium/test_expectations.txt:

4:38 PM Changeset in webkit [64178] by jhawkins@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Unreviewed Build Fix.

Add a missing itemIcon() method to TestPopupMenuClient.

• tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::itemIcon):

4:26 PM Changeset in webkit [64177] by barraclough@apple.com

• 6 edits in trunk/JavaScriptCore

Changed the handling for removing and adding elements at the front
of an array. The code now keeps a bias that indicates the amount of
JSValue sized holes are prior to the ArrayStorage block. This means
that shift operations are now memmove's of the header part of
the ArrayStorage and unshift operations are similar, but may require a
realloc first to create the space. Similar operations are performed
for special cases of splice and slice.
Also optimized the new Array(size) case so that we don't allocate and
initialize array elements until the JS code starts using elements.
The array growth code is slightly more aggressive for initial growth
based on size growth of any previous array.

Patch by Michael Saboff <​msaboff@apple.com> on 2010-07-27
Reviewed by Gavin Barraclough.

• Configurations/JavaScriptCore.xcconfig:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

• runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::getNewVectorLength):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):

• runtime/JSArray.h:

(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::arrayStorage):
(JSC::JSArray::setArrayStorage):
(JSC::JSArray::markChildrenDirect):

4:19 PM Changeset in webkit [64176] by barraclough@apple.com

• 8 edits in trunk/JavaScriptCore

Bug 43089 - Cleanup JIT related switched in Platform.h

Reviewed by Oliver Hunt.

The code the enable to JIT checks every permutation of platform & OS individually, but
now the JIT is enabled on the majority much all x86/x86-64/ARM/MIPS systems. It should
be cleaner to just enable by default on these platforms, and explicitly disable on configs
that don't aren't supported.

Also, rename ENABLE_JIT_OPTIMIZE_MOD to ENABLE_JIT_USE_SOFT_MODULO. I always find this
confusing since enabling this "optimization" would be possible, but would be a regression
on x86/x86-64 systems! I think it's clearer to reserve "JIT_OPTIMIZE" for compiler
technologies applicable to all platforms, and make a more optional behaviour like this a
"USE".

• jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

• jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

• wtf/Platform.h:

4:16 PM Changeset in webkit [64175] by tkent@chromium.org

• 2 edits in trunk/WebKitTools

2010-07-27 Kent Tamura <​tkent@chromium.org>

Unreviewed, trivial typo fix.

• Scripts/webkitpy/layout_tests/port/chromium.py: Fix a wrong method name committed by r64109.

4:15 PM Changeset in webkit [64174] by andersca@apple.com

• 6 edits in trunk

Implement JSNPObject::propertyGetter
​https://bugs.webkit.org/show_bug.cgi?id=43091

Reviewed by Sam Weinig.

WebKit2:

• WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::propertyGetter):
Ask the NPObject for its property.

• WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::jsNPObjectDestroyed):
Add a stub.

(WebKit::NPRuntimeObjectMap::convertNPVariantToValue):
Implement this for everything except objects.

LayoutTests:

• platform/mac-wk2/Skipped:

Add a test I forgot to add, and remove plugins/npruntime/embed-property.html because it passes now.

4:02 PM Changeset in webkit [64173] by jhawkins@chromium.org

• 13 edits in trunk

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
​https://bugs.webkit.org/show_bug.cgi?id=43076

• public/WebView.h:
• src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getIcon): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::itemIcon): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::setSuggestions):
• src/AutoFillPopupMenuClient.h:
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
• src/WebViewImpl.h:

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

Add itemIcon() method to the PopupMenuClient, used by Chrome AutoFill
to display right-aligned credit card icons in the suggestions popup.
​https://bugs.webkit.org/show_bug.cgi?id=43076

No new tests as this is only used by the Chromium WebKit API.

• platform/PopupMenuClient.h:
• platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow):
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemIcon):
• rendering/RenderMenuList.h:
• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIcon):
• rendering/RenderTextControlSingleLine.h:

3:47 PM Changeset in webkit [64172] by weinig@apple.com

• 17 edits in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43087
Clean up handling of strings at the WebKit2 API layer.

Reviewed by Anders Carlsson.

WebKit2:

• Always use the "copy" rule for functions that return WKStringRefs or WKURLRefs.
• Never return a null WKStringRef or WKURLRef.

• UIProcess/API/C/WKAPICast.h:

(toRef):
(toURLRef):
(toCopiedRef):
(toCopiedURLRef):

• UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemCopyOriginalURL):
(WKBackForwardListItemCopyURL):
(WKBackForwardListItemCopyTitle):

• UIProcess/API/C/WKBackForwardListItem.h:
• UIProcess/API/C/WKFrame.cpp:

(WKFrameIsMainFrame):
(WKFrameCopyProvisionalURL):
(WKFrameCopyURL):
(WKFrameGetPage):
(WKFrameRetain):
(WKFrameRelease):

• UIProcess/API/C/WKFrame.h:
• UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataCopyTitle):
(WKNavigationDataCopyURL):

• UIProcess/API/C/WKNavigationData.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageCopyTitle):

• UIProcess/API/C/WKPage.h:
• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyURL):
(WKBundleFrameCopyName):
(WKBundleFrameCopyCounterValue):
(WKBundleFrameCopyMarkerText):

• WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
• WebProcess/InjectedBundle/API/c/WKBundleNode.cpp:

(WKBundleNodeCopyNodeName):

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentation):

WebKitTools:

• MiniBrowser/mac/BrowserWindowController.m:

(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(didNavigateWithNavigationData):
(-[BrowserWindowController updateProvisionalURLForFrame:]):

• MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindowForFrame):

3:46 PM Changeset in webkit [64171] by Martin Robinson

• 2 edits
  1 add in trunk/LayoutTests

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Unskip a test that is passing and add expected results to another.

• platform/gtk/Skipped: Unskip passing test.
• platform/gtk/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/canvas/set-colors-expected.txt.

3:41 PM Changeset in webkit [64170] by jamesr@google.com

• 2 edits in trunk/JavaScriptCore

2010-07-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make PLATFORM(CHROMIUM) and not OS(MAC) turn USE(GLES2_RENDERING) on
​https://bugs.webkit.org/show_bug.cgi?id=43084

This turns USE(GLES2_RENDERING) on for chromium on windows/linux. This causes no
change in behavior, that's all controlled by ENABLE() macros that are currently off.

• wtf/Platform.h:

3:36 PM Changeset in webkit [64169] by andersca@apple.com

• 2 edits in trunk/LayoutTests

Explicitly list all skipped tests in plugins/ so we can start removing passing tests.

Reviewed by Sam Weinig.

• platform/mac-wk2/Skipped:

3:23 PM Changeset in webkit [64168] by Joseph Pecoraro

• 1 edit
  1 add in trunk/BugsSite

2010-07-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Provide a Helpful Link for Web Inspector Bugs in Bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=43065

• template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.

3:20 PM Changeset in webkit [64167] by andersca@apple.com

• 7 edits
  2 copies in trunk/WebKit2

Add JSNPObject, a JSObject that wraps an NPObject
​https://bugs.webkit.org/show_bug.cgi?id=43079

Reviewed by Sam Weinig.

• WebKit2.xcodeproj/project.pbxproj:

Add JSNPObject.cpp and JSNPObject.h

• WebProcess/Plugins/JSNPObject.cpp: Added.

(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::~JSNPObject):
(WebKit::JSNPObject::getOwnPropertySlot):
Check if the NPObject has the given property.

(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::throwInvalidAccessError):

• WebProcess/Plugins/JSNPObject.h: Added.

(WebKit::JSNPObject::createStructure):

• WebProcess/Plugins/NPJSObject.h:

• win/WebKit2.vcproj:

Add JSNPObject.cpp and JSNPObject.h

3:16 PM Changeset in webkit [64166] by victorw@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for failed test:
fast/canvas/canvas-ImageData-behaviour.html

• platform/chromium/test_expectations.txt:

3:16 PM Changeset in webkit [64165] by commit-queue@webkit.org

• 7 edits in trunk/JavaScriptCore/qt

2010-07-27 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Update the QScriptValue autotests suite.

QScriptValue generated files were updated, changes are:

• More tested values (for example QSE::newObject() and QSE::newArray())
• Tested values are recreated before each test and are not reused. The change implies better code coverage and some expected result changes.
• A new test to check copy and assign functions.
• Tests are using standard QTestLib interface, without any custom macros.

[Qt] Improve test coverage for the QScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=42366

• tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::assignAndCopyConstruct_data): (tst_QScriptValue::assignAndCopyConstruct):
• tests/qscriptvalue/tst_qscriptvalue.h:
• tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_data): (tst_QScriptValue::equals): (tst_QScriptValue::strictlyEquals_data): (tst_QScriptValue::strictlyEquals): (tst_QScriptValue::instanceOf_data): (tst_QScriptValue::instanceOf):
• tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: (tst_QScriptValue::initScriptValues):
• tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: (tst_QScriptValue::isValid_data): (tst_QScriptValue::isValid): (tst_QScriptValue::isBool_data): (tst_QScriptValue::isBool): (tst_QScriptValue::isBoolean_data): (tst_QScriptValue::isBoolean): (tst_QScriptValue::isNumber_data): (tst_QScriptValue::isNumber): (tst_QScriptValue::isFunction_data): (tst_QScriptValue::isFunction): (tst_QScriptValue::isNull_data): (tst_QScriptValue::isNull): (tst_QScriptValue::isString_data): (tst_QScriptValue::isString): (tst_QScriptValue::isUndefined_data): (tst_QScriptValue::isUndefined): (tst_QScriptValue::isObject_data): (tst_QScriptValue::isObject): (tst_QScriptValue::isArray_data): (tst_QScriptValue::isArray): (tst_QScriptValue::isError_data): (tst_QScriptValue::isError):
• tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::toNumber_data): (tst_QScriptValue::toNumber): (tst_QScriptValue::toBool_data): (tst_QScriptValue::toBool): (tst_QScriptValue::toBoolean_data): (tst_QScriptValue::toBoolean): (tst_QScriptValue::toInteger_data): (tst_QScriptValue::toInteger): (tst_QScriptValue::toInt32_data): (tst_QScriptValue::toInt32): (tst_QScriptValue::toUInt32_data): (tst_QScriptValue::toUInt32): (tst_QScriptValue::toUInt16_data): (tst_QScriptValue::toUInt16):

3:07 PM Changeset in webkit [64164] by andreas.kling@nokia.com

• 2 edits in trunk/WebCore

2010-07-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] putImageData(): Fast premultiply() if alpha == 255

• platform/graphics/qt/ImageBufferQt.cpp: (WebCore::premultiply): Do nothing for opaque pixels.

2:52 PM Changeset in webkit [64163] by rniwa@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

REGRESSION: editing/style/remove-underline-from-stylesheet.html fails on Qt platform after r64083
​https://bugs.webkit.org/show_bug.cgi?id=43061

Reviewed by Justin Garcia.

Added a qt-specific test result because the final range and the generated DOM is same.

• platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.

2:42 PM Changeset in webkit [64162] by jianli@chromium.org

• 2 edits in trunk/WebCore

Enhance FileThreadTask to support return type.
​https://bugs.webkit.org/show_bug.cgi?id=43078

Reviewed by David Levin.

This is needed to support synchronous calls of FileStream methods in
addition to asynchronous calls via FileThreadTask.

• html/FileThreadTask.h:

(WebCore::createFileThreadTask):

2:37 PM Changeset in webkit [64161] by jamesr@google.com

• 5 edits in trunk/WebCore

2010-07-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Let PlatformContextSkia draw to a GLES2Canvas in addition to an SkCanvas
​https://bugs.webkit.org/show_bug.cgi?id=43070

This adds a GLES2Canvas as drawing surface to PlatformContextSkia and lets callers
issue draw commands to either. The PlatformContextSkia keeps track of where
rendering results are being accumulated and can blend the hardware and software
backing stores into each other when necessary.

Still just plumbing, no functionality change.

• platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas):
• platform/graphics/chromium/GLES2Canvas.h:
• platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::setGLES2Context): (PlatformContextSkia::preSoftwareDraw): (PlatformContextSkia::preHardwareDraw): (PlatformContextSkia::forceToSoftware): (PlatformContextSkia::uploadSoftwareToHardware): (PlatformContextSkia::readbackHardwareToSoftware):
• platform/graphics/skia/PlatformContextSkia.h: (PlatformContextSkia::useGPU): (PlatformContextSkia::gpuCanvas): (PlatformContextSkia::preSoftwareDraw): (PlatformContextSkia::preHardwareDraw): (PlatformContextSkia::forceToSoftware): (PlatformContextSkia::):

2:30 PM Changeset in webkit [64160] by brettw@chromium.org

• 3 edits
  9 adds in trunk/WebKit/chromium

2010-07-27 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Add the ability to select fonts and do basic text drawing to the
Chromium WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=42999

• WebKit.gyp:
• public/WebFloatPoint.h: Added. (WebKit::WebFloatPoint::WebFloatPoint): (WebKit::WebFloatPoint::operator=): (WebKit::WebFloatPoint::operator WebCore::FloatPoint): (WebKit::operator==): (WebKit::operator!=):
• public/WebFloatRect.h: Added. (WebKit::WebFloatRect::isEmpty): (WebKit::WebFloatRect::WebFloatRect): (WebKit::WebFloatRect::operator=): (WebKit::WebFloatRect::operator WebCore::FloatRect): (WebKit::operator==): (WebKit::operator!=):
• public/WebFont.h: Added.
• public/WebFontDescription.h: Added. (WebKit::WebFontDescription::): (WebKit::WebFontDescription::WebFontDescription):
• public/WebTextRun.h: Added. (WebKit::WebTextRun::WebTextRun):
• src/AssertMatchingEnums.cpp:
• src/WebFontDescription.cpp: Added. (WebKit::WebFontDescription::WebFontDescription): (WebKit::WebFontDescription::operator WebCore::FontDescription):
• src/WebFontImpl.cpp: Added. (WebKit::WebFont::Create): (WebKit::WebFontImpl::WebFontImpl): (WebKit::WebFontImpl::fontDescription): (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight): (WebKit::WebFontImpl::drawText): (WebKit::WebFontImpl::computeWidth): (WebKit::WebFontImpl::offsetForPosition): (WebKit::WebFontImpl::selectionRectForText):
• src/WebFontImpl.h: Added.
• src/WebTextRun.cpp: Added. (WebKit::WebTextRun::operator WebCore::TextRun):

2:23 PM Changeset in webkit [64159] by victorw@chromium.org

• 2 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for failed test on mac:
fast/dom/prototype-inheritance.html

• platform/chromium/test_expectations.txt:

2:18 PM Changeset in webkit [64158] by Simon Fraser

• 2 edits in trunk/WebCore

2010-07-27 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Incomplete repaint of some Safari extension content which falls into a composited iframe
<rdar://problem/8235044>

syncCompositingStateRecursive() bails if it thinks that a layout is pending, because
the layout may update layers and make this sync obsolete. However, it only checked for an
active layout timer. This ignores other sources of pending style changes and layouts, like
the document's style recalc timer. So use needsLayout(), which does check this.

Unable to create a test because it depends on Safari extension behavior.

• page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive):

2:17 PM Changeset in webkit [64157] by andreas.kling@nokia.com

• 2 edits in trunk/WebCore

2010-07-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] putImageData() optimizations
​https://bugs.webkit.org/show_bug.cgi?id=43059

• Single-pass premultiplication and BGR->RGB conversion
• Use ARGB32PM for the temporary image so Qt calls the fast Source composition function

• platform/graphics/qt/ImageBufferQt.cpp: (WebCore::premultiply): Added (static inline) (WebCore::putImageData):

2:11 PM Changeset in webkit [64156] by andreas.kling@nokia.com

• 10 edits in trunk

2010-07-23 Helder Correia <​heldercorreia@codeaurora.org>

Reviewed by Darin Adler.

Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
failing. For canvas image data manipulation, the values passed should
be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
to expect wrapping rather than clamping, and add some new checkings.
​https://bugs.webkit.org/show_bug.cgi?id=40272

• runtime/JSByteArray.h: (JSC::JSByteArray::setIndex): (JSC::JSByteArray::JSByteArray):

2010-07-23 Helder Correia <​heldercorreia@codeaurora.org>

Reviewed by Darin Adler.

Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
failing. For canvas image data manipulation, the values passed should
be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
to expect wrapping rather than clamping, and add some new checkings.
​https://bugs.webkit.org/show_bug.cgi?id=40272

• canvas/philip/tests/2d.imageData.object.round-expected.txt:
• canvas/philip/tests/2d.imageData.object.round.html:
• canvas/philip/tests/2d.imageData.object.wrap-expected.txt:
• fast/canvas/canvas-ImageData-behaviour-expected.txt:
• fast/canvas/canvas-ImageData-behaviour.js:
• platform/mac/Skipped:
• platform/qt/Skipped:

2:06 PM Changeset in webkit [64155] by Adam Roben

• 4 edits in trunk/WebKit2

Fix PageClient ownership in WebPageProxy

WKView now owns the PageClient, similar to how things work on Windows
(where the WebView is the PageClient).

Fixes <​http://webkit.org/b/40185> WebPageProxy should keep a weak
reference to the PageClient

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]): Store the PageClientImpl
on our WKViewData object and pass it to the WebPageProxy.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setPageClient):

• UIProcess/WebPageProxy.h:

Removed Mac-specific code that put the PageClient in an OwnPtr. We now
store it in a bare pointer just like on Windows.

1:55 PM Changeset in webkit [64154] by andersca@apple.com

• 10 edits in trunk

Expose interface for returning the plug-in script JSObject
​https://bugs.webkit.org/show_bug.cgi?id=43074

Reviewed by Sam Weinig.

WebCore:

PluginViewBase::scriptObject should be a virtual function.

• plugins/PluginViewBase.h:

(WebCore::PluginViewBase::scriptObject):

WebKit2:

• WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
Add empty stub.

• WebProcess/Plugins/NPRuntimeObjectMap.h:
• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::pluginScriptableNPObject):
Ask the plug-in for it's scriptable NPObject.

• WebProcess/Plugins/Netscape/NetscapePlugin.h:
• WebProcess/Plugins/Plugin.h:

Add pluginScritableNPObject.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Call PluginViewBase constructor.

(WebKit::PluginView::scriptObject):
Ask the plug-in for its scriptable object and wrap it.

• WebProcess/Plugins/PluginView.h:

PluginView now inherits from PluginViewBase.

1:23 PM Changeset in webkit [64153] by ojan@chromium.org

• 3 edits in trunk/WebKitTools

2010-07-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
​https://bugs.webkit.org/show_bug.cgi?id=42984

squash and no_squash have been intentionally erroring for a couple weeks now.
But post-commits was just broken. Just remove squash/no_squash.

• Scripts/webkitpy/tool/steps/abstractstep.py:
• Scripts/webkitpy/tool/steps/options.py:

1:18 PM Changeset in webkit [64152] by jianli@chromium.org

• 53 edits in trunk/WebCore

Add ScriptExecutionContext argument to File/Blob constructors.
​https://bugs.webkit.org/show_bug.cgi?id=40587

Reviewed by David Levin.

Remove DragData::createClipboard and add Clipboard::create for it to be
called directly in DragController. This is because we need to pass
Frame pointer to Clipboard class and use it to get ScriptExecutionContext
in order to construct File objects in Clipboard::files().

• bindings/js/SerializedScriptValue.cpp:

(WebCore::DeserializingTreeWalker::convertIfTerminal):

• bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):

• dom/Clipboard.h:
• editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent):

• editing/Editor.h:
• editing/android/EditorAndroid.cpp:

(WebCore::Editor::newGeneralClipboard):

• editing/brew/EditorBrew.cpp:

(WebCore::Editor::newGeneralClipboard):

• editing/chromium/EditorChromium.cpp:

(WebCore::Editor::newGeneralClipboard):

• editing/haiku/EditorHaiku.cpp:

(WebCore::Editor::newGeneralClipboard):

• editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):

• editing/qt/EditorQt.cpp:

(WebCore::Editor::newGeneralClipboard):

• editing/wx/EditorWx.cpp:

(WebCore::Editor::newGeneralClipboard):

• html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::slice):

• html/Blob.h:

(WebCore::Blob::create):

• html/Blob.idl:
• html/BlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob):

• html/BlobBuilder.h:
• html/BlobBuilder.idl:
• html/File.cpp:

(WebCore::File::File):

• html/File.h:

(WebCore::File::create):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::appendFormData):
(WebCore::HTMLInputElement::setFileListFromRenderer):

• page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):

• page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::createDraggingClipboard):

• page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::createDraggingClipboard):

• page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingClipboard):

• platform/DragData.h:
• platform/android/ClipboardAndroid.cpp:

(WebCore::Clipboard::create):

• platform/android/DragDataAndroid.cpp:
• platform/brew/ClipboardBrew.cpp:

(WebCore::Clipboard::create):

• platform/brew/DragDataBrew.cpp:
• platform/chromium/ClipboardChromium.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::create):
(WebCore::ClipboardChromium::files):

• platform/chromium/ClipboardChromium.h:
• platform/chromium/DragDataChromium.cpp:
• platform/efl/ClipboardEfl.cpp:

(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):

• platform/efl/DragDataEfl.cpp:
• platform/gtk/ClipboardGtk.cpp:

(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):
(WebCore::ClipboardGtk::ClipboardGtk):
(WebCore::ClipboardGtk::files):

• platform/gtk/ClipboardGtk.h:

(WebCore::ClipboardGtk::create):

• platform/gtk/DragDataGtk.cpp:
• platform/haiku/ClipboardHaiku.cpp:

(WebCore::Clipboard::create):

• platform/haiku/DragDataHaiku.cpp:
• platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create):
(WebCore::ClipboardMac::files):

• platform/mac/DragDataMac.mm:
• platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::create):

• platform/qt/DragDataQt.cpp:
• platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::files):

• platform/win/ClipboardWin.h:

(WebCore::ClipboardWin::create):

• platform/win/DragDataWin.cpp:
• platform/win/EditorWin.cpp:

(WebCore::Editor::newGeneralClipboard):

• platform/wince/DragDataWince.cpp:
• platform/wince/EditorWince.cpp:

(WebCore::Editor::newGeneralClipboard):

• platform/wx/ClipboardWx.cpp:

(WebCore::Clipboard::create):

• platform/wx/DragDataWx.cpp:

1:07 PM Changeset in webkit [64151] by dumi@chromium.org

• 14 edits in trunk

Move all WebSQLDatabases-specific code behind #if ENABLE(DATABASE).
​https://bugs.webkit.org/show_bug.cgi?id=43035

Reviewed by David Levin.

WebCore:

Make Chromium compile with ENABLE_DATABASE=0. The #ifdefs in
DatabaseAuthorizer and ChromiumBridge are removed, because they're
used by non-HTML5 DBs too (the classes in WebCore/platform/sql/),
which are used by other features too. So they need to be compiled
in even if HTML5 DBs are disabled.

• bindings/v8/custom/V8DOMWindowCustom.cpp:
• page/DOMWindow.idl:
• platform/chromium/ChromiumBridge.h:
• storage/DatabaseAuthorizer.cpp:
• storage/chromium/DatabaseObserver.h:
• storage/chromium/DatabaseTrackerChromium.cpp:
• storage/chromium/QuotaTracker.cpp:
• storage/chromium/QuotaTracker.h:
• storage/chromium/SQLTransactionClientChromium.cpp:

WebKit/chromium:

Make Chromium compile with ENABLE_DATABASE=0.

• src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseGetFileSize):

• src/DatabaseObserver.cpp:
• src/WebDatabase.cpp:

(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::closeDatabaseImmediately):

12:48 PM Changeset in webkit [64150] by kevino@webkit.org

• 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.

12:38 PM Changeset in webkit [64149] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: Misspellings not shown in AXAttributedStringForTextMarkerRange when selection is on word
​https://bugs.webkit.org/show_bug.cgi?id=41817

Reviewed by David Kilzer.

WebCore:

Change how misspelled words are identified for accessibility. No longer rely on the
cached markers in Document. Calculate on the fly, which is more accurate in a variety of
circumstances (like when selection has not moved across words, of if the cursor is in the middle
of a misspelled word).

Test: platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html

• accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling):
(AXAttributedStringAppendText):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):

LayoutTests:

• platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Added.
• platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html: Added.

12:34 PM Changeset in webkit [64148] by victorw@chromium.org

• 3 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations.

• platform/chromium/test_expectations.txt:
• storage/indexeddb/keyrange-expected.txt:

12:29 PM Changeset in webkit [64147] by andersca@apple.com

• 5 edits
  2 copies in trunk/WebKit2

Move NPJSObject out into separate files
​https://bugs.webkit.org/show_bug.cgi?id=43068

Reviewed by Adam Roben.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Plugins/NPJSObject.cpp: Added.

(WebKit::NPJSObject::create):
(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):

• WebProcess/Plugins/NPJSObject.h: Added.

(WebKit::NPJSObject::jsObject):
(WebKit::NPJSObject::toNPJSObject):

• WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::npJSObjectDestroyed):
(WebKit::NPRuntimeObjectMap::globalExec):

• WebProcess/Plugins/NPRuntimeObjectMap.h:
• win/WebKit2.vcproj:

12:14 PM Changeset in webkit [64146] by barraclough@apple.com

• 8 edits
  3 adds in trunk

Bug 42621 - Add a bump allocator for the YARR interpreter

Reviewed by Oliver Hunt.

The regex engine requires lifo allocation, however currently uses the general purpose
malloc/free memory allocation. A simple bump pointer allocator should provide a lower
overhead allocation solution.

JavaScriptCore:

When using YARR interpreter, 15% progression on v8-regex.

• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/JSGlobalData.h:
• runtime/RegExp.cpp:

(JSC::RegExp::compile):

• wtf/BumpPointerAllocator.h: Added.

(WTF::BumpPointerPool::ensureCapacity):
(WTF::BumpPointerPool::alloc):
(WTF::BumpPointerPool::dealloc):
(WTF::BumpPointerPool::operator new):
(WTF::BumpPointerPool::BumpPointerPool):
(WTF::BumpPointerPool::create):
(WTF::BumpPointerPool::shrink):
(WTF::BumpPointerPool::destroy):
(WTF::BumpPointerPool::ensureCapacityCrossPool):
(WTF::BumpPointerPool::deallocCrossPool):
(WTF::BumpPointerAllocator::BumpPointerAllocator):
(WTF::BumpPointerAllocator::~BumpPointerAllocator):
(WTF::BumpPointerAllocator::startAllocator):
(WTF::BumpPointerAllocator::stopAllocator):

• yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::byteCompileRegex):

• yarr/RegexInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

JavaScriptGlue:

• ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.

WebCore:

• ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.

12:04 PM Changeset in webkit [64145] by andersca@apple.com

• 5 edits
  2 moves in trunk/WebKit2

Rename NPJSObjectMap to NPRuntimeObjectMap
​https://bugs.webkit.org/show_bug.cgi?id=43066

Reviewed by Adam Roben.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Plugins/NPJSObjectMap.cpp: Removed.
• WebProcess/Plugins/NPJSObjectMap.h: Removed.
• WebProcess/Plugins/NPRuntimeObjectMap.cpp: Added.

(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::toNPJSObject):
(WebKit::NPJSObject::create):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::invalidate):

• WebProcess/Plugins/NPRuntimeObjectMap.h: Added.
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):

• WebProcess/Plugins/PluginView.h:
• win/WebKit2.vcproj:

11:32 AM Changeset in webkit [64144] by pfeldman@chromium.org

• 5 edits in trunk/WebCore

2010-07-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: render network timing as gant chart in popover.

​https://bugs.webkit.org/show_bug.cgi?id=43051

• inspector/InspectorResource.cpp: (WebCore::InspectorResource::buildObjectForTiming):
• inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
• inspector/front-end/inspector.css: (.resource-timing-row): (.resource-timing-bar): (.resource-timing-bar-title):
• inspector/front-end/utilities.js:

11:16 AM Changeset in webkit [64143] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Add inspector/debugger-breakpoints-not-activated-on-reload.html (introduced in r64133) to the Skipped list.

• platform/qt/Skipped: inspector/debugger-breakpoints-not-activated-on-reload.html skipped.

11:14 AM Changeset in webkit [64142] by victorw@chromium.org

• 11 edits in trunk/WebCore

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed, rolling out r64104.
​http://trac.webkit.org/changeset/64104
​https://bugs.webkit.org/show_bug.cgi?id=40768

The patch causes chromium webkit socket laytest crashes on
windows randomly

• inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): (WebCore::InspectorController::removeResource):
• inspector/InspectorController.h:
• inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
• inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::create):
• inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
• inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
• inspector/front-end/inspector.css: (.resources-category-scripts, .resources-category-xhr, .resources-category-fonts, .resources-category-other):
• inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
• websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer):
• websockets/WebSocketChannel.h:

11:04 AM Changeset in webkit [64141] by andreip@google.com

• 12 edits in trunk

2010-07-27 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] Key range methods belong to the IDBKeyRange interface
​https://bugs.webkit.org/show_bug.cgi?id=43052

• storage/indexeddb/script-tests/keyrange.js: (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-07-27 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] Key range methods belong to the IDBKeyRange interface
​https://bugs.webkit.org/show_bug.cgi?id=43052

Move the key range methods from the IndexedDatabaseRequest interface
to the IDBKeyRange interface. Also add a global IDBKeyRange object
that can be used to access the IDBKeyRange constants and factory methods.

• page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::iDBKeyRange):
• page/DOMWindow.h:
• page/DOMWindow.idl:
• storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::only): (WebCore::IDBKeyRange::leftBound): (WebCore::IDBKeyRange::rightBound): (WebCore::IDBKeyRange::bound):
• storage/IDBKeyRange.h:
• storage/IDBKeyRange.idl:
• storage/IndexedDatabaseRequest.cpp:
• storage/IndexedDatabaseRequest.h:
• storage/IndexedDatabaseRequest.idl:

10:45 AM QtScript edited by kent.hansen@nokia.com

(diff)

10:42 AM QtScript edited by kent.hansen@nokia.com

(diff)

10:39 AM BugAdvice created by ojan@chromium.org

10:17 AM Changeset in webkit [64140] by Adam Roben

• 2 edits in trunk/WebKit2

Make preferences APIs robust against web process crashes

Fixes <​http://webkit.org/b/43049> Crash in
WebPageNamespace::preferencesDidChange if preferences are changed
after the web process crashes

Reviewed by Anders Carlsson.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::preferencesDidChange): Bail out if we don't have
a web process. The new preference values will get propogated to the
web process if and when it launches.

10:14 AM Changeset in webkit [64139] by Chris Fleizach

• 3 edits in trunk/WebCore

AX: consolidate parentObjectIfExists() and parentObject() code
​https://bugs.webkit.org/show_bug.cgi?id=42981

Reviewed by Darin Adler.

Consolidate duplicate code in parentObject and parentObjectIfExists

No tests. No functionality changed.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):

• accessibility/AccessibilityRenderObject.h:

9:56 AM WikiStart edited by ojan@chromium.org

(diff)

9:44 AM Changeset in webkit [64138] by leandro@webkit.org

• 2 edits in trunk

2010-07-26 ryuan choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL]REGRESSION(r63952): build break because of InspectorBackendDispatcher.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43021

Modify cmake script to fix build break as adding InspectorBackendDispatcher.

• cmake/WebKitGenerators.cmake:

9:33 AM Changeset in webkit [64137] by Chris Fleizach

• 2 edits in trunk/WebCore

AX: replace m_renderer->document->axObjectCache() with just axObjectCache()
​https://bugs.webkit.org/show_bug.cgi?id=42979

Reviewed by Adam Barth.

No new tests. Code cleanup only.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::AccessibilityRenderObject::lastChild):
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::axObjectCache):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::addChildren):

9:30 AM Changeset in webkit [64136] by commit-queue@webkit.org

• 2 edits in trunk

2010-07-27 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Changing library names (appending suffix "_efl")
​https://bugs.webkit.org/show_bug.cgi?id=42902

Instead of having libwebcore.so, we will have libwebcore_efl.so.
Same for javascriptcore and wtf when compiled as shared, and for jsc.

• cmake/OptionsEfl.cmake:

9:19 AM Changeset in webkit [64135] by Martin Robinson

• 2 edits in trunk/LayoutTests

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Remove some mistakenly skipped tests from the skipped list as well as
a couple tests that no longer exist.

• platform/gtk/Skipped: Fix some errors in the skipped list.

9:18 AM Changeset in webkit [64134] by Adam Roben

• 2 edits in trunk/WebKitTools

Mac build fix

• MiniBrowser/mac/BrowserWindowController.m:

(processDidExit):
(-[BrowserWindowController awakeFromNib]):
Added processDidExit support.

9:12 AM Changeset in webkit [64133] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not activate all breakpoints on page reload
​https://bugs.webkit.org/show_bug.cgi?id=41461

• http/tests/inspector/debugger-test.js: (frontend_scriptsAreParsed): (frontend_waitUntilScriptsAreParsed.waitForAllScripts): (frontend_waitUntilScriptsAreParsed): (frontend_ensureSourceFrameLoaded): (frontend_showScriptSource):
• inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Added.
• inspector/debugger-breakpoints-not-activated-on-reload.html: Added.
• platform/gtk/Skipped: skip the test on GTK due to JSC debugger issue

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not activate all breakpoints on page reload
​https://bugs.webkit.org/show_bug.cgi?id=41461

Test: inspector/debugger-breakpoints-not-activated-on-reload.html

• inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
• inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: if breakpoints were deactivated, add new breakpoints as disabled.
​https://bugs.webkit.org/show_bug.cgi?id=41461

• src/js/DebuggerScript.js: ():

9:06 AM Changeset in webkit [64132] by Adam Roben

• 5 edits in trunk/WebKit2

Add a ProcessDidExit callback to the WKPageLoaderClient

Fixes <​http://webkit.org/b/43048> UI process needs a way to find out
when the web process crashes

Reviewed by Anders Carlsson.

• UIProcess/API/C/WKPage.h: Added WKPageProcessDidExitCallback, and a

processDidExit member of that type to WKPageLoaderClient.

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidExit): Added. Calls through to the
WKPageLoaderClient.

• UIProcess/WebLoaderClient.h: Added processDidExit.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit): Tell the loader client the
process exited.

8:54 AM Changeset in webkit [64131] by tonikitoo@webkit.org

• 2 edits in trunk/WebKitTools

2010-07-26 Antonio Gomes <​tonikitoo@webkit.org>

Rubber-stamped by Simon Hausmann.

[Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.

Move some less useful menu items on Developers menu from the top to the bottom, so
QGraphicsView menu goes to the top, and becomes more quickly accessible.

• QtTestBrowser/main.cpp: (LauncherWindow::createChrome):

8:37 AM Changeset in webkit [64130] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk/JavaScriptCore/qt

2010-07-27 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement QScriptEngine::newFunction() parts that doesn't depend on QScriptContext
​https://bugs.webkit.org/show_bug.cgi?id=42174

Since our function can be called in Javascript both as a function
and as a constructor, we couldn't use the existing
JSObjectMakeFunctionWithCallback() and JSObjectMakeConstructor().

Instead, a JSClassRef was created, implementing the needed
callbacks (the callAsConstructor is not there yet because its
behaviour depends on QScriptContext).

For the moment, QScriptContext is defined as a void type, since we
still don't use it.

The variant of newFunction() that also takes an external argument
was also implemented. The details of implementation were added to
the qscriptfunction{.c,_p.h} files.

This commit also adds tests, some of them from Qt's upstream.

• api/QtScript.pro:
• api/qscriptengine.cpp: (QScriptEngine::newFunction):
• api/qscriptengine.h:
• api/qscriptengine_p.cpp: (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::newFunction):
• api/qscriptengine_p.h:
• api/qscriptfunction.cpp: Added. (qt_NativeFunction_finalize): (qt_NativeFunction_callAsFunction): (qt_NativeFunctionWithArg_finalize): (qt_NativeFunctionWithArg_callAsFunction):
• api/qscriptfunction_p.h: Added. (QNativeFunctionData::QNativeFunctionData): (QNativeFunctionWithArgData::QNativeFunctionWithArgData):
• api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): (QScriptOriginalGlobalObject::functionPrototype):
• tests/qscriptengine/tst_qscriptengine.cpp: (myFunction): (myFunctionWithArg): (myFunctionThatReturns): (myFunctionThatReturnsWithoutEngine): (myFunctionThatReturnsWrongEngine): (tst_QScriptEngine::newFunction):

8:29 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

8:25 AM QtScript created by kent.hansen@nokia.com

8:25 AM Changeset in webkit [64129] by Adam Roben

• 2 edits in trunk/WebKitTools

Fix the path to InjectedBundle.dll in Debug_Internal builds

Fixes <​http://webkit.org/b/42994> WebKitTestRunner fails to load
InjectedBundle.dll in the Debug_Internal configuration

Reviewed by Anders Carlsson.

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeInjectedBundlePath): Add the _debug
suffix only in Debug_All builds.

8:06 AM Changeset in webkit [64128] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-07-27 Pranav Kedia <​pranavk@chromium.org>

Reviewed by Adam Barth.

Chrome browser Bug: Pause button stays when <audio> hits end
​https://bugs.webkit.org/show_bug.cgi?id=42677

The change is just in chromium media. Tested using media part of
WebKit layout tests. The following test that was failing is passing.
media/video-duration-known-after-eos.html -> unexpected pass

• rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Using mediaElement->canPlay() instead of mediaElement->paused() to paint the play/pause button.

8:01 AM Changeset in webkit [64127] by abecsi@webkit.org

• 2 edits in trunk/WebKit2

2010-07-27 Andras Becsi <​abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebEventFactory::createWebMouseEvent should follow WebKit2 API changes
​https://bugs.webkit.org/show_bug.cgi?id=43042

• Shared/qt/WebEventFactoryQt.cpp: (WebKit::WebEventFactory::createWebMouseEvent): Set deltaX, deltaY and deltaZ arguments.

7:12 AM Changeset in webkit [64126] by steveblock@google.com

• 9 edits in trunk

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

This change passes the enableHighAccuracy request option to the GeolocationController.
The GeolocationController tracks whether this should be used by the client.

No new tests possible as the mock provider doesn't support this feature.

• page/Geolocation.cpp: (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
• page/GeolocationController.cpp: (WebCore::GeolocationController::addObserver): (WebCore::GeolocationController::removeObserver):
• page/GeolocationController.h:
• page/GeolocationControllerClient.h:

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

Stub out setEnableHighAccuracy method for the Mac port.

• WebCoreSupport/WebGeolocationControllerClient.h: (WebGeolocationControllerClient::setEnableHighAccuracy):

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

Stub out setEnableHighAccuracy method for the Win port.

• WebCoreSupport/WebGeolocationControllerClient.h: (WebGeolocationControllerClient::setEnableHighAccuracy):

6:55 AM Changeset in webkit [64125] by steveblock@google.com

• 3 edits
  1 copy
  4 adds in trunk/LayoutTests

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
​https://bugs.webkit.org/show_bug.cgi?id=43025

This change modifies window-property.html and its expected result to work with JSC.
A V8-specific expected result is added for Android.

• fast/dom/DeviceOrientation/script-tests/window-property.js:
• fast/dom/DeviceOrientation/window-property-expected.txt:
• platform/android-v8: Added.
• platform/android-v8/fast: Added.
• platform/android-v8/fast/dom: Added.
• platform/android-v8/fast/dom/DeviceOrientation: Added.
• platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.

6:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

6:41 AM Changeset in webkit [64124] by loislo@chromium.org

• 30 edits
  2 deletes in trunk

2010-07-27 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Current implementation of message based inspector
transport generated by CodeGeneratorInspector should be upstreamed
from WebKit/chromium to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=42983

• Android.derived.v8bindings.mk:
• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• GNUmakefile.am:
• WebCore.exp.in:
• WebCore.gypi:
• WebCore.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/ScriptObject.cpp:
• bindings/js/ScriptObject.h:
• bindings/v8/ScriptObject.cpp:
• bindings/v8/ScriptObject.h:
• inspector/CodeGeneratorInspector.pm:
• inspector/InspectorBackend.idl: Removed.
• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
• inspector/InspectorFrontendClientLocal.h:
• inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):
• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:
• inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype._registerDelegate): (.WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):

2010-07-27 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Current implementation of message based inspector
transport generated by CodeGeneratorInspector should be upstreamed
from WebKit/chromium to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=42983

• WebKit.gypi:
• src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
• src/InspectorFrontendClientImpl.h:
• src/ToolsAgent.h:
• src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost):
• src/WebDevToolsAgentImpl.h:
• src/js/InspectorControllerImpl.js: Removed.

6:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

6:01 AM Changeset in webkit [64123] by andreas.kling@nokia.com

• 2 edits in trunk/WebKitTools

2010-07-25 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=42947
Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
error. Without which dumpRenderTree crashes.

• Scripts/old-run-webkit-tests:

5:56 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

5:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

5:43 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

5:27 AM Changeset in webkit [64122] by commit-queue@webkit.org

• 3 edits in trunk/WebKit2

2010-07-27 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit::PageClient implementation needs a dedicated class

​https://bugs.webkit.org/show_bug.cgi?id=42974

• UIProcess/API/qt/qwkpage.cpp: (PageClientImpl::PageClientImpl): Added. (PageClientImpl::pageDidEnterAcceleratedCompositing): Moved from QWKPagePrivate. (PageClientImpl::pageDidLeaveAcceleratedCompositing): Ditto. (PageClientImpl::processDidExit): Ditto. (PageClientImpl::processDidRevive): Ditto. (PageClientImpl::setCursor): Ditto. (PageClientImpl::takeFocus): Ditto. (PageClientImpl::toolTipChanged): Ditto. (QWKPagePrivate::QWKPagePrivate): Set a new instance of the PageClientImpl as PageClient rather than 'this'.
• UIProcess/API/qt/qwkpage_p.h: Removed PageClient implementation methods from QWKPagePrivate.

5:08 AM Changeset in webkit [64121] by antonm@chromium.org

• 3 edits in trunk/LayoutTests

2010-07-27 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Extend a test checking access to nested elements on the document to cover recent regression in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=42980

See ​http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

• fast/dom/HTMLDocument/document-special-properties-expected.txt:
• fast/dom/HTMLDocument/document-special-properties.html:

4:56 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

4:56 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

3:55 AM Changeset in webkit [64120] by Simon Hausmann

• 3 edits in trunk/WebKit/qt

[Qt] Incorrect input method hints
​https://bugs.webkit.org/show_bug.cgi?id=43037

Reviewed by Tor Arne Vestbø.

Properly set or reset all input method hints when
activating input fields.

• WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

• tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes): Extended unit test to verify that we
reset hints.

3:05 AM Changeset in webkit [64119] by vestbo@webkit.org

• 3 edits in trunk/LayoutTests/platform/qt

[Qt] Fix failing layout-tests after r64114

3:04 AM Companies and Organizations that have contributed to WebKit edited by zherczeg@webkit.org

(diff)

2:51 AM Changeset in webkit [64118] by kim.1.gronholm@nokia.com

• 5 edits in trunk/WebKit/qt

2010-07-27 Kim Grönholm <​kim.1.gronholm@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Decouple QTouchEvent's accepted flag from JS prevent default
​https://bugs.webkit.org/show_bug.cgi?id=42892

We need to always accept the QTouchEvents in order to get TouchUpdate and
TouchEnd events. QWebPage::event() return value is used to indicate
whether the default action was prevented for the touch events.

• Api/qgraphicswebview.cpp: (QGraphicsWebView::sceneEvent):
• Api/qwebpage.cpp: (QWebPagePrivate::touchEvent): (QWebPage::event):
• Api/qwebpage_p.h:
• Api/qwebview.cpp: (QWebView::event):

2:36 AM Changeset in webkit [64117] by tkent@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Trivial test fix.

• fast/forms/script-tests/input-number-events.js: Adjust pixel values in order to work on Windows.

2:29 AM Changeset in webkit [64116] by vestbo@webkit.org

• 2 edits in trunk/LayoutTests

Update expected result as well to match r64115.

Reviewed by NOBODY.

• fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:

2:12 AM Changeset in webkit [64115] by vestbo@webkit.org

• 3 edits in trunk/LayoutTests

Fix GTK layout-test break after r64114

Reviewed by NOBODY.

Skipping the test for Qt until we can find a non-fragile way to write
the test.

• fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
• platform/qt/Skipped:

1:38 AM Changeset in webkit [64114] by vestbo@webkit.org

• 780 edits in trunk

[Qt] Change default font from sans-serif to serif

Reviewed by Simon Hausmann.

This matches what other ports and browser engines do.

We now also use QFont's defaultFontFamily() to resolve the
correct fonts for each platform. For Qt >= 4.7 we can take
advantage of the new enums for generic font families.

The spatial-navigation test had to be changed due to the
fragile nature of the down-action. By changing the font we
hit the case where the two down actions were not enough to
scroll the link into view.

1:33 AM Changeset in webkit [64113] by commit-queue@webkit.org

• 3 edits in trunk/WebKit/chromium

2010-07-27 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add accessors for node and document to WebAccessibilityObject,
needed to support some Windows screenreader functionality.

​https://bugs.webkit.org/show_bug.cgi?id=43001

• public/WebAccessibilityObject.h:
• src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::node): (WebKit::WebAccessibilityObject::document):

1:07 AM Changeset in webkit [64112] by commit-queue@webkit.org

• 4 edits
  4 copies in trunk/WebKit/chromium

2010-07-27 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

For Windows accessibility, have WebElement provide access
to its attributes.

​https://bugs.webkit.org/show_bug.cgi?id=43004

• WebKit.gyp:
• public/WebAttribute.h: Added. (WebKit::WebAttribute::~WebAttribute): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::operator=):
• public/WebElement.h:
• public/WebNamedNodeMap.h: Added. (WebKit::WebNamedNodeMap::~WebNamedNodeMap): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::operator=):
• src/WebAttribute.cpp: Added. (WebKit::WebAttribute::reset): (WebKit::WebAttribute::assign): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::localName): (WebKit::WebAttribute::value):
• src/WebElement.cpp: (WebKit::WebElement::attributes):
• src/WebNamedNodeMap.cpp: Added. (WebKit::WebNamedNodeMap::reset): (WebKit::WebNamedNodeMap::assign): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::length): (WebKit::WebNamedNodeMap::attributeItem):

12:50 AM Changeset in webkit [64111] by commit-queue@webkit.org

• 17 edits
  1 delete in trunk

2010-07-27 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Simplify speech input plumbing in webcore and webkit
​https://bugs.webkit.org/show_bug.cgi?id=43008

No new tests as functionality is not changed.

• GNUmakefile.am: Removed a header file.
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• page/Page.cpp: (WebCore::Page::speechInput): Creates and returns SpeechInput when needed.
• page/Page.h:
• page/SpeechInput.cpp: Added methods to proxy and callbacks between input elements and WebKit (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording):
• page/SpeechInput.h:
• page/SpeechInputClient.h:
• page/SpeechInputClientListener.h: Removed.
• page/SpeechInputListener.h:
• rendering/TextControlInnerElements.cpp: Added one more callback. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
• rendering/TextControlInnerElements.h:

2010-07-27 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Simplify speech input plumbing in webcore and webkit
​https://bugs.webkit.org/show_bug.cgi?id=43008

• src/SpeechInputClientImpl.cpp: Move functionality to WebCore::SpeechInput and make this a dummy proxy. (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult):
• src/SpeechInputClientImpl.h:

12:31 AM Changeset in webkit [64110] by tkent@chromium.org

• 10 edits
  4 deletes in trunk

Add a runtime setting for interactive form validation.
​https://bugs.webkit.org/show_bug.cgi?id=40520

Reviewed by Ojan Vafai.

WebCore:

The interactive validation feature was disabled for non-strict
modes by r61059 to avoid a compatibility issue. This removes the
mode checking and introduce a runtime setting to enable/disable
the feature instead.
The default value is 'disable' and we'll remove the setting when
the compatibility issue is resolved and interactive validation
implementation is completed.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

• page/Settings.cpp:

(WebCore::Settings::Settings):

• page/Settings.h:

(WebCore::Settings::setInteractiveFormValidationEnabled):
(WebCore::Settings::interactiveFormValidationEnabled):

LayoutTests:

Remove the mode-specific tests and skip tests which don't work
without the interactive validation feature.

• fast/forms/interactive-validation-compat-mode-expected.txt: Removed.
• fast/forms/interactive-validation-compat-mode.html: Removed.
• fast/forms/interactive-validation-html4-expected.txt: Removed.
• fast/forms/interactive-validation-html4.html: Removed.
• platform/chromium/test_expectations.txt:
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

12:05 AM Changeset in webkit [64109] by tkent@chromium.org

• 2 edits in trunk/WebKitTools

2010-07-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=42956
[DRT/Chromium] Fix "out of sync" assertion error

Fix an assertion error on Windows like the following:
100721 20:16:46 chromium.py:386 CRITICAL Test got out of sync:
|​file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
|​file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|

• Scripts/webkitpy/layout_tests/port/chromium.py: If the url matches with "​file:///[a-z]:", does case-ignore comparison. GURL capitalize the driver letter of a file: URL.