Timeline
Jul 31, 2010:
- 11:12 PM Changeset in webkit [64439] by
-
- 2 edits in trunk/WebCore
Try to fix the Windows build when zlib is not available.
- platform/graphics/WOFFFileFormat.cpp:
- 11:05 PM Changeset in webkit [64438] by
-
- 2 edits in trunk/WebCore
Try to fix the Windows build when zlib is not available.
- platform/graphics/WOFFFileFormat.cpp:
- 11:03 PM Changeset in webkit [64437] by
-
- 2 edits in trunk/WebCore
Try to fix the Windows build when zlib is not available.
- platform/graphics/WOFFFileFormat.cpp:
- 10:53 PM Changeset in webkit [64436] by
-
- 2 edits in trunk/WebCore
Fix typo in attempted build fix.
- platform/graphics/WOFFFileFormat.cpp:
- 10:47 PM Changeset in webkit [64435] by
-
- 2 edits in trunk/WebCore
Try to fix the Windows build when zlib is not available.
- platform/graphics/WOFFFileFormat.cpp:
- 10:04 PM Changeset in webkit [64434] by
-
- 24 edits5 adds in trunk
<rdar://problem/8234766> Add WOFF support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=31302
Reviewed by Darin Adler.
WebCore:
- WebCore.vcproj/WebCore.vcproj: Added WOFFFileFormat.{cpp,h}.
- WebCore.vcproj/WebCoreCommon.vsprops: Added $(WebKitLibraries)\include\zlib to the header search path.
- WebCore.xcodeproj/project.pbxproj: Added WOFFFileFormat.{cpp,h} and linking against libz.
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat): Replaced hard-coded list of supported formats with
call to FontCustomPlatformData::supportsFormat().
- platform/graphics/WOFFFileFormat.cpp: Added.
(WebCore::isWOFF): Checks if the buffer has the WOFF signature.
(WebCore::convertWOFFToSfnt): Extracts the sfnt payload of a WOFF package.
- platform/graphics/WOFFFileFormat.h: Added.
- platform/graphics/cairo/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/chromium/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype,
and also for woff if the OpenType sanitizer is enabled.
- platform/graphics/chromium/FontCustomPlatformData.h:
- platform/graphics/gtk/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns false.
- platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/graphics/haiku/FontCustomPlatformData.h:
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::freeSfntData):
(WebCore::createFontCustomPlatformData): If the OpenType font sanitizer is not enabled, use convertWOFFToSfnt().
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype, opentype and woff.
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData): If the OpenType font sanitizer is not enabled, use convertWOFFToSfnt().
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype, opentype and woff.
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Added. Returns true for truetype and opentype.
- platform/graphics/win/FontCustomPlatformDataCairo.h:
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/graphics/wince/FontCustomPlatformData.h:
LayoutTests:
- platform/mac/Skipped: Enabled fast/css/font-face-woff.html.
- platform/mac/fast/css/font-face-woff-expected.checksum: Added.
- platform/mac/fast/css/font-face-woff-expected.png: Added.
- platform/mac/fast/css/font-face-woff-expected.txt: Added.
- 9:19 PM Changeset in webkit [64433] by
-
- 2 edits in trunk/LayoutTests
Update skipped list to get us to ~100 failures for Mac WebKit2.
Rubber-stamped by Dan Bernstein.
- platform/mac-wk2/Skipped:
- 6:10 PM Changeset in webkit [64432] by
-
- 10 edits in trunk
2010-07-31 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156
Modified SplitElementCommand to delete the id attribute from the second element when splitting an element.
Since this causes WebKit not to merge split elements, added shouldSplitElement to ApplyStyleCommand which
determines the necessity of splitting the element.
To share code between shouldSplitElement and removeInlineStyleFromElement (extracted from applyInlineStyle)
dontRemove was added as the 3rd argument to removeHTMLFontStyle, removeHTMLBidiEmbeddingStyle, and removeCSSStyle.
Test: editing/style/split-element-id-duplication.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Added 3rd argument for removeCSSStyle. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitElement. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Extracted from removeInlineStyle. (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Inline helper for removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeHTMLFontStyle): Added dontRemove. (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added dontRemove. (WebCore::ApplyStyleCommand::removeCSSStyle): Added dontRemove. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::splitTextElementAtStart): Removed the call to splitTextAtStart. Branching is now done in applyInlineStyle. (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto for splitTextAtEnd. (WebCore::ApplyStyleCommand::shouldSplitElement): Added.
- editing/ApplyStyleCommand.h:
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply): Deletes the id attribute from the second element. (WebCore::SplitElementCommand::doUnapply): Recovers the id attribute of the second element.
2010-07-31 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156
Added a test to ensure splitting element doesn't produce multiple nodes with the same id.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Removed the duplication of nodes with the same id.
- editing/execCommand/indent-pre-expected.txt: Ditto.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Ditto.
- editing/execCommand/outdent-regular-blockquote-expected.txt:
- editing/style/split-element-id-duplication-expected.txt: Added.
- editing/style/split-element-id-duplication.html: Added.
- editing/undo/redo-style-expected.txt: Editing delegates changed.
- 5:59 PM Changeset in webkit [64431] by
-
- 2 edits in trunk/LayoutTests
Unreviewed text expectations change for Chromium.
Patch by Satish Sampath <satish@chromium.org> on 2010-07-31
Disable speech input layout tests while they get updated.
https://bugs.webkit.org/show_bug.cgi?id=43310
- platform/chromium/test_expectations.txt: Disabled speech input tests.
- 5:42 PM Changeset in webkit [64430] by
-
- 4 edits in trunk/WebKit2
Crash due to calling StringImpl::createCFString() from non-main thread in plug-in code
https://bugs.webkit.org/show_bug.cgi?id=43306
<rdar://problem/8259687>
Reviewed by Darin Adler.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::getMIMETypeForExtension):
(WebKit::PluginInfoStore::findPlugin):
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::safeCreateCFString):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
Bypass MIMETypeRegistry in the UIProcess until we can safely convert Strings
to CFStringRefs.
- 4:43 PM Changeset in webkit [64429] by
-
- 4 edits in trunk
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Build fix: Windows.
- platform/win/PopupMenuWin.h:
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Build fix: Windows.
- WebView.cpp: (WebView::mouseWheel):
- 4:41 PM Changeset in webkit [64428] by
-
- 2 edits in trunk/WebKit
<http://webkit.org/b/43307> Make sure all private headers are copied to PrivateHeaders directory
Reviewed by Dan Bernstein.
This also fixes compilation of DumpRenderTree after changes for
Bug 40627.
- WebKit.xcodeproj/project.pbxproj: Set the PRIVATE attribute on
the following headers:
- WebFormDelegatePrivate.h
- WebKitStatisticsPrivate.h
- WebSecurityOriginPrivate.h
- 4:12 PM Changeset in webkit [64427] by
-
- 2 edits in trunk/WebCore
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Windows build fix.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::PopupMenuWndProc):
- 3:37 PM Changeset in webkit [64426] by
-
- 7 edits in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
Add back WKBundleFrameCopyInnerText to fix ~50 test failures
due to SVGElements not having the innerText function.
Reviewed by Dan Bernstein.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyInnerText):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::innerText):
- WebProcess/WebPage/WebFrame.h:
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText):
- 3:25 PM Changeset in webkit [64425] by
-
- 67 edits20 copies1 add in trunk
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes PopupMenu and SearchPopupMenu have been made pure virtual.
- platform/PopupMenu.h: (WebCore::PopupMenu::~PopupMenu):
- platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::~SearchPopupMenu):
Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
the new pure virtual PopupMenu and SearchPopupMenu.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): (WebCore::RenderMenuList::showPopup):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::valueChanged):
- rendering/RenderTextControlSingleLine.h:
Chrome and ChromeClient were made responsible for providing instances of classes
PopupMenu and SearchPopupMenu to its users.
- loader/EmptyClients.h: (WebCore::EmptyPopupMenu::show): (WebCore::EmptyPopupMenu::hide): (WebCore::EmptyPopupMenu::updateFromElement): (WebCore::EmptyPopupMenu::disconnectClient): (WebCore::EmptySearchPopupMenu::popupMenu): (WebCore::EmptySearchPopupMenu::saveRecentSearches): (WebCore::EmptySearchPopupMenu::loadRecentSearches): (WebCore::EmptySearchPopupMenu::enabled): (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural): (WebCore::EmptyChromeClient::createPopupMenu): (WebCore::EmptyChromeClient::createSearchPopupMenu):
- page/Chrome.cpp: (WebCore::Chrome::selectItemWritingDirectionIsNatural): (WebCore::Chrome::createPopupMenu): (WebCore::Chrome::createSearchPopupMenu):
- page/Chrome.h:
- page/ChromeClient.h:
Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
Each of new the files contain the concrete classes that inherit form PopupMenu or
SearchPopupMenu and are specific for the corresponding platform.
brew:
- platform/brew/PopupMenuBrew.cpp: (WebCore::PopupMenuBrew::PopupMenuBrew): (WebCore::PopupMenuBrew::~PopupMenuBrew): (WebCore::PopupMenuBrew::disconnectClient): (WebCore::PopupMenuBrew::show): (WebCore::PopupMenuBrew::hide): (WebCore::PopupMenuBrew::updateFromElement):
- platform/brew/PopupMenuBrew.h: Added. (WebCore::PopupMenuBrew::client):
- platform/brew/SearchPopupMenuBrew.cpp: (WebCore::SearchPopupMenuBrew::saveRecentSearches): (WebCore::SearchPopupMenuBrew::loadRecentSearches): (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew): (WebCore::SearchPopupMenuBrew::enabled): (WebCore::SearchPopupMenuBrew::popupMenu):
- platform/brew/SearchPopupMenuBrew.h: Added.
chromium:
- WebCore.gypi:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenuChromium::PopupMenuChromium): (WebCore::PopupMenuChromium::~PopupMenuChromium): (WebCore::PopupMenuChromium::show): (WebCore::PopupMenuChromium::hide): (WebCore::PopupMenuChromium::updateFromElement): (WebCore::PopupMenuChromium::disconnectClient):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupMenuChromium::client):
- platform/chromium/SearchPopupMenuChromium.cpp: (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium): (WebCore::SearchPopupMenuChromium::popupMenu): (WebCore::SearchPopupMenuChromium::enabled): (WebCore::SearchPopupMenuChromium::saveRecentSearches): (WebCore::SearchPopupMenuChromium::loadRecentSearches):
- platform/chromium/SearchPopupMenuChromium.h: Added.
efl:
- platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenuEfl::PopupMenuEfl): (WebCore::PopupMenuEfl::~PopupMenuEfl): (WebCore::PopupMenuEfl::show): (WebCore::PopupMenuEfl::hide): (WebCore::PopupMenuEfl::updateFromElement): (WebCore::PopupMenuEfl::disconnectClient):
- platform/efl/PopupMenuEfl.h: Added. (WebCore::PopupMenuEfl::client):
- platform/efl/SearchPopupMenuEfl.cpp: (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl): (WebCore::SearchPopupMenuEfl::popupMenu): (WebCore::SearchPopupMenuEfl::saveRecentSearches): (WebCore::SearchPopupMenuEfl::loadRecentSearches): (WebCore::SearchPopupMenuEfl::enabled):
- platform/efl/SearchPopupMenuEfl.h: Added.
gtk:
- GNUmakefile.am:
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): (WebCore::PopupMenuGtk::~PopupMenuGtk): (WebCore::PopupMenuGtk::show): (WebCore::PopupMenuGtk::hide): (WebCore::PopupMenuGtk::updateFromElement): (WebCore::PopupMenuGtk::disconnectClient): (WebCore::PopupMenuGtk::menuItemActivated): (WebCore::PopupMenuGtk::menuUnmapped): (WebCore::PopupMenuGtk::menuPositionFunction): (WebCore::PopupMenuGtk::menuRemoveItem):
- platform/gtk/PopupMenuGtk.h: Added. (WebCore::PopupMenuGtk::client):
- platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk): (WebCore::SearchPopupMenuGtk::popupMenu): (WebCore::SearchPopupMenuGtk::saveRecentSearches): (WebCore::SearchPopupMenuGtk::loadRecentSearches): (WebCore::SearchPopupMenuGtk::enabled):
- platform/gtk/SearchPopupMenuGtk.h: Added.
haiku:
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::HaikuPopup::HaikuPopup): (WebCore::HaikuPopup::~HaikuPopup): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::updateFromElement):
- platform/haiku/PopupMenuHaiku.h: Added. (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::client):
- platform/haiku/SearchPopupMenuHaiku.cpp: (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku): (WebCore::SearchPopupMenuHaiku::saveRecentSearches): (WebCore::SearchPopupMenuHaiku::loadRecentSearches): (WebCore::SearchPopupMenuHaiku::enabled): (WebCore::SearchPopupMenuHaiku::popupMenu):
- platform/haiku/SearchPopupMenuHaiku.h: Added.
mac:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/PopupMenuMac.h: Added. (WebCore::PopupMenuMac::disconnectClient): (WebCore::PopupMenuMac::client):
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenuMac::PopupMenuMac): (WebCore::PopupMenuMac::~PopupMenuMac): (WebCore::PopupMenuMac::clear): (WebCore::PopupMenuMac::populate): (WebCore::PopupMenuMac::show): (WebCore::PopupMenuMac::hide): (WebCore::PopupMenuMac::updateFromElement): (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
- platform/mac/SearchPopupMenuMac.h: Added.
- platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenuMac::SearchPopupMenuMac): (WebCore::SearchPopupMenuMac::popupMenu): (WebCore::SearchPopupMenuMac::enabled): (WebCore::SearchPopupMenuMac::saveRecentSearches): (WebCore::SearchPopupMenuMac::loadRecentSearches):
qt:
- WebCore.pro:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::disconnectClient): (WebCore::PopupMenuQt::show): (WebCore::PopupMenuQt::hide): (WebCore::PopupMenuQt::updateFromElement):
- platform/qt/PopupMenuQt.h: Added.
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/SearchPopupMenuQt.cpp: (WebCore::SearchPopupMenuQt::SearchPopupMenuQt): (WebCore::SearchPopupMenuQt::popupMenu): (WebCore::SearchPopupMenuQt::saveRecentSearches): (WebCore::SearchPopupMenuQt::loadRecentSearches): (WebCore::SearchPopupMenuQt::enabled):
- platform/qt/SearchPopupMenuQt.h: Added.
win:
- WebCore.vcproj/WebCore.vcproj:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::PopupMenuWin): (WebCore::PopupMenuWin::~PopupMenuWin): (WebCore::PopupMenuWin::disconnectClient): (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show): (WebCore::PopupMenuWin::hide): (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::setFocusedIndex): (WebCore::PopupMenuWin::visibleItems): (WebCore::PopupMenuWin::listIndexAtPoint): (WebCore::PopupMenuWin::focusedIndex): (WebCore::PopupMenuWin::focusFirst): (WebCore::PopupMenuWin::focusLast): (WebCore::PopupMenuWin::down): (WebCore::PopupMenuWin::up): (WebCore::PopupMenuWin::invalidateItem): (WebCore::PopupMenuWin::clientRect): (WebCore::PopupMenuWin::incrementWheelDelta): (WebCore::PopupMenuWin::reduceWheelDelta): (WebCore::PopupMenuWin::scrollToRevealSelection): (WebCore::PopupMenuWin::updateFromElement): (WebCore::PopupMenuWin::paint): (WebCore::PopupMenuWin::valueChanged): (WebCore::PopupMenuWin::invalidateScrollbarRect): (WebCore::PopupMenuWin::registerClass): (WebCore::PopupMenuWin::PopupMenuWndProc): (WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h: Added. (WebCore::PopupMenuWin::client): (WebCore::PopupMenuWin::scrollbar): (WebCore::PopupMenuWin::itemHeight): (WebCore::PopupMenuWin::windowRect): (WebCore::PopupMenuWin::popupHandle): (WebCore::PopupMenuWin::setWasClicked): (WebCore::PopupMenuWin::wasClicked): (WebCore::PopupMenuWin::setScrollOffset): (WebCore::PopupMenuWin::scrollOffset): (WebCore::PopupMenuWin::wheelDelta): (WebCore::PopupMenuWin::scrollbarCapturingMouse): (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
- platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::SearchPopupMenuWin): (WebCore::SearchPopupMenuWin::popupMenu): (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
- platform/win/SearchPopupMenuWin.h: Added.
wx:
- platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenuWx::PopupMenuWx): (WebCore::PopupMenuWx::~PopupMenuWx): (WebCore::PopupMenuWx::disconnectClient): (WebCore::PopupMenuWx::show): (WebCore::PopupMenuWx::OnMenuItemSelected): (WebCore::PopupMenuWx::hide): (WebCore::PopupMenuWx::updateFromElement):
- platform/wx/PopupMenuWx.h: Added. (WebCore::PopupMenuWx::client):
- platform/wx/SearchPopupMenuWx.cpp: (WebCore::SearchPopupMenuWx::SearchPopupMenuWx): (WebCore::SearchPopupMenuWx::saveRecentSearches): (WebCore::SearchPopupMenuWx::loadRecentSearches): (WebCore::SearchPopupMenuWx::enabled): (WebCore::SearchPopupMenuWx::popupMenu):
- platform/wx/SearchPopupMenuWx.h: Added.
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural): (WebKit::ChromeClientImpl::createPopupMenu): (WebKit::ChromeClientImpl::createSearchPopupMenu):
- src/ChromeClientImpl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientEfl::createPopupMenu): (WebCore::ChromeClientEfl::createSearchPopupMenu):
- WebCoreSupport/ChromeClientEfl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): (WebKit::ChromeClient::createPopupMenu): (WebKit::ChromeClient::createSearchPopupMenu):
- WebCoreSupport/ChromeClientGtk.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientHaiku::createPopupMenu): (WebCore::ChromeClientHaiku::createSearchPopupMenu):
- WebCoreSupport/ChromeClientHaiku.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientQt::createPopupMenu): (WebCore::ChromeClientQt::createSearchPopupMenu):
- WebCoreSupport/ChromeClientQt.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):
- WebCoreSupport/WebChromeClient.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientWx::createPopupMenu): (WebCore::ChromeClientWx::createSearchPopupMenu):
- WebKitSupport/ChromeClientWx.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
SearchPopupMenu respectively. At this point they are just empty implementations.
- WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added. (WebKit::WebPopupMenu::WebPopupMenu): (WebKit::WebPopupMenu::~WebPopupMenu): (WebKit::WebPopupMenu::disconnectClient): (WebKit::WebPopupMenu::show): (WebKit::WebPopupMenu::hide): (WebKit::WebPopupMenu::updateFromElement):
- WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added. (WebKit::WebSearchPopupMenu::WebSearchPopupMenu): (WebKit::WebSearchPopupMenu::popupMenu): (WebKit::WebSearchPopupMenu::saveRecentSearches): (WebKit::WebSearchPopupMenu::loadRecentSearches): (WebKit::WebSearchPopupMenu::enabled):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): (WebKit::WebChromeClient::createPopupMenu): (WebKit::WebChromeClient::createSearchPopupMenu):
- WebProcess/WebCoreSupport/WebChromeClient.h:
build issues:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 2:55 PM Changeset in webkit [64424] by
-
- 7 edits6 adds in trunk/LayoutTests
Unreviewed un-rollback of r64375 so Satish can land his fixes.
- fast/speech/input-appearance-numberandspeech-expected.txt: Added.
- fast/speech/input-appearance-numberandspeech.html: Added.
- fast/speech/input-appearance-searchandspeech-expected.txt: Added.
- fast/speech/input-appearance-searchandspeech.html: Added.
- fast/speech/input-appearance-speechbutton-expected.txt: Added.
- fast/speech/input-appearance-speechbutton.html: Added.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:04 PM Changeset in webkit [64423] by
-
- 66 edits21 deletes in trunk
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h:
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
- platform/PopupMenu.h: (WebCore::PopupMenu::create): (WebCore::PopupMenu::disconnectClient): (WebCore::PopupMenu::client): (WebCore::PopupMenu::scrollbar): (WebCore::PopupMenu::itemHeight): (WebCore::PopupMenu::windowRect): (WebCore::PopupMenu::popupHandle): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setScrollOffset): (WebCore::PopupMenu::scrollOffset): (WebCore::PopupMenu::wheelDelta): (WebCore::PopupMenu::scrollbarCapturingMouse): (WebCore::PopupMenu::setScrollbarCapturingMouse): (WebCore::PopupMenu::isActive): (WebCore::PopupMenu::scrollbarCornerPresent):
- platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::create):
- platform/brew/PopupMenuBrew.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/brew/PopupMenuBrew.h: Removed.
- platform/brew/SearchPopupMenuBrew.cpp: (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled):
- platform/brew/SearchPopupMenuBrew.h: Removed.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/chromium/PopupMenuChromium.h:
- platform/chromium/SearchPopupMenuChromium.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
- platform/chromium/SearchPopupMenuChromium.h: Removed.
- platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/efl/PopupMenuEfl.h: Removed.
- platform/efl/SearchPopupMenuEfl.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/efl/SearchPopupMenuEfl.h: Removed.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::menuItemActivated): (WebCore::PopupMenu::menuUnmapped): (WebCore::PopupMenu::menuPositionFunction): (WebCore::PopupMenu::menuRemoveItem):
- platform/gtk/PopupMenuGtk.h: Removed.
- platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/gtk/SearchPopupMenuGtk.h: Removed.
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/haiku/PopupMenuHaiku.h: Removed.
- platform/haiku/SearchPopupMenuHaiku.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/haiku/SearchPopupMenuHaiku.h: Removed.
- platform/mac/PopupMenuMac.h: Removed.
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/mac/SearchPopupMenuMac.h: Removed.
- platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/qt/PopupMenuQt.h: Removed.
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/SearchPopupMenuQt.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/qt/SearchPopupMenuQt.h: Removed.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::popupClassName): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::visibleItems): (WebCore::PopupMenu::listIndexAtPoint): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::invalidateItem): (WebCore::PopupMenu::clientRect): (WebCore::PopupMenu::incrementWheelDelta): (WebCore::PopupMenu::reduceWheelDelta): (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::paint): (WebCore::PopupMenu::valueChanged): (WebCore::PopupMenu::invalidateScrollbarRect): (WebCore::PopupMenu::registerClass): (WebCore::PopupMenu::PopupMenuWndProc): (WebCore::PopupMenu::wndProc):
- platform/win/PopupMenuWin.h: Removed.
- platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
- platform/win/SearchPopupMenuWin.h: Removed.
- platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::OnMenuItemSelected): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/wx/PopupMenuWx.h: Removed.
- platform/wx/SearchPopupMenuWx.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/wx/SearchPopupMenuWx.h: Removed.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): (WebCore::RenderMenuList::showPopup):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::valueChanged):
- rendering/RenderTextControlSingleLine.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/ChromeClientEfl.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
- WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
- win/WebKit2.vcproj:
- 1:17 PM Changeset in webkit [64422] by
-
- 66 edits19 copies2 adds in trunk
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes PopupMenu and SearchPopupMenu have been made pure virtual.
- platform/PopupMenu.h: (WebCore::PopupMenu::~PopupMenu):
- platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::~SearchPopupMenu):
Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
the new pure virtual PopupMenu and SearchPopupMenu.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): (WebCore::RenderMenuList::showPopup):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::valueChanged):
- rendering/RenderTextControlSingleLine.h:
Chrome and ChromeClient were made responsible for providing instances of classes
PopupMenu and SearchPopupMenu to its users.
- loader/EmptyClients.h: (WebCore::EmptyPopupMenu::show): (WebCore::EmptyPopupMenu::hide): (WebCore::EmptyPopupMenu::updateFromElement): (WebCore::EmptyPopupMenu::disconnectClient): (WebCore::EmptySearchPopupMenu::popupMenu): (WebCore::EmptySearchPopupMenu::saveRecentSearches): (WebCore::EmptySearchPopupMenu::loadRecentSearches): (WebCore::EmptySearchPopupMenu::enabled): (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural): (WebCore::EmptyChromeClient::createPopupMenu): (WebCore::EmptyChromeClient::createSearchPopupMenu):
- page/Chrome.cpp: (WebCore::Chrome::selectItemWritingDirectionIsNatural): (WebCore::Chrome::createPopupMenu): (WebCore::Chrome::createSearchPopupMenu):
- page/Chrome.h:
- page/ChromeClient.h:
Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
Each of new the files contain the concrete classes that inherit form PopupMenu or
SearchPopupMenu and are specific for the corresponding platform.
brew:
- platform/brew/PopupMenuBrew.cpp: (WebCore::PopupMenuBrew::PopupMenuBrew): (WebCore::PopupMenuBrew::~PopupMenuBrew): (WebCore::PopupMenuBrew::disconnectClient): (WebCore::PopupMenuBrew::show): (WebCore::PopupMenuBrew::hide): (WebCore::PopupMenuBrew::updateFromElement):
- platform/brew/PopupMenuBrew.h: Added. (WebCore::PopupMenuBrew::client):
- platform/brew/SearchPopupMenuBrew.cpp: (WebCore::SearchPopupMenuBrew::saveRecentSearches): (WebCore::SearchPopupMenuBrew::loadRecentSearches): (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew): (WebCore::SearchPopupMenuBrew::enabled): (WebCore::SearchPopupMenuBrew::popupMenu):
- platform/brew/SearchPopupMenuBrew.h: Added.
chromium:
- WebCore.gypi:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenuChromium::PopupMenuChromium): (WebCore::PopupMenuChromium::~PopupMenuChromium): (WebCore::PopupMenuChromium::show): (WebCore::PopupMenuChromium::hide): (WebCore::PopupMenuChromium::updateFromElement): (WebCore::PopupMenuChromium::disconnectClient):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupMenuChromium::client):
- platform/chromium/SearchPopupMenuChromium.cpp: (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium): (WebCore::SearchPopupMenuChromium::popupMenu): (WebCore::SearchPopupMenuChromium::enabled): (WebCore::SearchPopupMenuChromium::saveRecentSearches): (WebCore::SearchPopupMenuChromium::loadRecentSearches):
- platform/chromium/SearchPopupMenuChromium.h: Added.
efl:
- platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenuEfl::PopupMenuEfl): (WebCore::PopupMenuEfl::~PopupMenuEfl): (WebCore::PopupMenuEfl::show): (WebCore::PopupMenuEfl::hide): (WebCore::PopupMenuEfl::updateFromElement): (WebCore::PopupMenuEfl::disconnectClient):
- platform/efl/PopupMenuEfl.h: Added. (WebCore::PopupMenuEfl::client):
- platform/efl/SearchPopupMenuEfl.cpp: (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl): (WebCore::SearchPopupMenuEfl::popupMenu): (WebCore::SearchPopupMenuEfl::saveRecentSearches): (WebCore::SearchPopupMenuEfl::loadRecentSearches): (WebCore::SearchPopupMenuEfl::enabled):
- platform/efl/SearchPopupMenuEfl.h: Added.
gtk:
- GNUmakefile.am:
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): (WebCore::PopupMenuGtk::~PopupMenuGtk): (WebCore::PopupMenuGtk::show): (WebCore::PopupMenuGtk::hide): (WebCore::PopupMenuGtk::updateFromElement): (WebCore::PopupMenuGtk::disconnectClient): (WebCore::PopupMenuGtk::menuItemActivated): (WebCore::PopupMenuGtk::menuUnmapped): (WebCore::PopupMenuGtk::menuPositionFunction): (WebCore::PopupMenuGtk::menuRemoveItem):
- platform/gtk/PopupMenuGtk.h: Added. (WebCore::PopupMenuGtk::client):
- platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk): (WebCore::SearchPopupMenuGtk::popupMenu): (WebCore::SearchPopupMenuGtk::saveRecentSearches): (WebCore::SearchPopupMenuGtk::loadRecentSearches): (WebCore::SearchPopupMenuGtk::enabled):
- platform/gtk/SearchPopupMenuGtk.h: Added.
haiku:
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::HaikuPopup::HaikuPopup): (WebCore::HaikuPopup::~HaikuPopup): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::updateFromElement):
- platform/haiku/PopupMenuHaiku.h: Added. (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::client):
- platform/haiku/SearchPopupMenuHaiku.cpp: (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku): (WebCore::SearchPopupMenuHaiku::saveRecentSearches): (WebCore::SearchPopupMenuHaiku::loadRecentSearches): (WebCore::SearchPopupMenuHaiku::enabled): (WebCore::SearchPopupMenuHaiku::popupMenu):
- platform/haiku/SearchPopupMenuHaiku.h: Added.
mac:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/PopupMenuMac.h: Added. (WebCore::PopupMenuMac::disconnectClient): (WebCore::PopupMenuMac::client):
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenuMac::PopupMenuMac): (WebCore::PopupMenuMac::~PopupMenuMac): (WebCore::PopupMenuMac::clear): (WebCore::PopupMenuMac::populate): (WebCore::PopupMenuMac::show): (WebCore::PopupMenuMac::hide): (WebCore::PopupMenuMac::updateFromElement): (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
- platform/mac/SearchPopupMenuMac.h: Added.
- platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenuMac::SearchPopupMenuMac): (WebCore::SearchPopupMenuMac::popupMenu): (WebCore::SearchPopupMenuMac::enabled): (WebCore::SearchPopupMenuMac::saveRecentSearches): (WebCore::SearchPopupMenuMac::loadRecentSearches):
qt:
- WebCore.pro:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::disconnectClient): (WebCore::PopupMenuQt::show): (WebCore::PopupMenuQt::hide): (WebCore::PopupMenuQt::updateFromElement):
- platform/qt/PopupMenuQt.h: Added.
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/SearchPopupMenuQt.cpp: (WebCore::SearchPopupMenuQt::SearchPopupMenuQt): (WebCore::SearchPopupMenuQt::popupMenu): (WebCore::SearchPopupMenuQt::saveRecentSearches): (WebCore::SearchPopupMenuQt::loadRecentSearches): (WebCore::SearchPopupMenuQt::enabled):
- platform/qt/SearchPopupMenuQt.h: Added.
win:
- WebCore.vcproj/WebCore.vcproj:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::PopupMenuWin): (WebCore::PopupMenuWin::~PopupMenuWin): (WebCore::PopupMenuWin::disconnectClient): (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show): (WebCore::PopupMenuWin::hide): (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::setFocusedIndex): (WebCore::PopupMenuWin::visibleItems): (WebCore::PopupMenuWin::listIndexAtPoint): (WebCore::PopupMenuWin::focusedIndex): (WebCore::PopupMenuWin::focusFirst): (WebCore::PopupMenuWin::focusLast): (WebCore::PopupMenuWin::down): (WebCore::PopupMenuWin::up): (WebCore::PopupMenuWin::invalidateItem): (WebCore::PopupMenuWin::clientRect): (WebCore::PopupMenuWin::incrementWheelDelta): (WebCore::PopupMenuWin::reduceWheelDelta): (WebCore::PopupMenuWin::scrollToRevealSelection): (WebCore::PopupMenuWin::updateFromElement): (WebCore::PopupMenuWin::paint): (WebCore::PopupMenuWin::valueChanged): (WebCore::PopupMenuWin::invalidateScrollbarRect): (WebCore::PopupMenuWin::registerClass): (WebCore::PopupMenuWin::PopupMenuWndProc): (WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h: Added. (WebCore::PopupMenuWin::client): (WebCore::PopupMenuWin::scrollbar): (WebCore::PopupMenuWin::itemHeight): (WebCore::PopupMenuWin::windowRect): (WebCore::PopupMenuWin::popupHandle): (WebCore::PopupMenuWin::setWasClicked): (WebCore::PopupMenuWin::wasClicked): (WebCore::PopupMenuWin::setScrollOffset): (WebCore::PopupMenuWin::scrollOffset): (WebCore::PopupMenuWin::wheelDelta): (WebCore::PopupMenuWin::scrollbarCapturingMouse): (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
- platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::SearchPopupMenuWin): (WebCore::SearchPopupMenuWin::popupMenu): (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
- platform/win/SearchPopupMenuWin.h: Added.
wx:
- platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenuWx::PopupMenuWx): (WebCore::PopupMenuWx::~PopupMenuWx): (WebCore::PopupMenuWx::disconnectClient): (WebCore::PopupMenuWx::show): (WebCore::PopupMenuWx::OnMenuItemSelected): (WebCore::PopupMenuWx::hide): (WebCore::PopupMenuWx::updateFromElement):
- platform/wx/PopupMenuWx.h: Added. (WebCore::PopupMenuWx::client):
- platform/wx/SearchPopupMenuWx.cpp: (WebCore::SearchPopupMenuWx::SearchPopupMenuWx): (WebCore::SearchPopupMenuWx::saveRecentSearches): (WebCore::SearchPopupMenuWx::loadRecentSearches): (WebCore::SearchPopupMenuWx::enabled): (WebCore::SearchPopupMenuWx::popupMenu):
- platform/wx/SearchPopupMenuWx.h: Added.
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural): (WebKit::ChromeClientImpl::createPopupMenu): (WebKit::ChromeClientImpl::createSearchPopupMenu):
- src/ChromeClientImpl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientEfl::createPopupMenu): (WebCore::ChromeClientEfl::createSearchPopupMenu):
- WebCoreSupport/ChromeClientEfl.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): (WebKit::ChromeClient::createPopupMenu): (WebKit::ChromeClient::createSearchPopupMenu):
- WebCoreSupport/ChromeClientGtk.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientHaiku::createPopupMenu): (WebCore::ChromeClientHaiku::createSearchPopupMenu):
- WebCoreSupport/ChromeClientHaiku.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientQt::createPopupMenu): (WebCore::ChromeClientQt::createSearchPopupMenu):
- WebCoreSupport/ChromeClientQt.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):
- WebCoreSupport/WebChromeClient.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientWx::createPopupMenu): (WebCore::ChromeClientWx::createSearchPopupMenu):
- WebKitSupport/ChromeClientWx.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
SearchPopupMenu respectively. At this point they are just empty implementations.
- WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added. (WebKit::WebPopupMenu::WebPopupMenu): (WebKit::WebPopupMenu::~WebPopupMenu): (WebKit::WebPopupMenu::disconnectClient): (WebKit::WebPopupMenu::show): (WebKit::WebPopupMenu::hide): (WebKit::WebPopupMenu::updateFromElement):
- WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added. (WebKit::WebSearchPopupMenu::WebSearchPopupMenu): (WebKit::WebSearchPopupMenu::popupMenu): (WebKit::WebSearchPopupMenu::saveRecentSearches): (WebKit::WebSearchPopupMenu::loadRecentSearches): (WebKit::WebSearchPopupMenu::enabled):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): (WebKit::WebChromeClient::createPopupMenu): (WebKit::WebChromeClient::createSearchPopupMenu):
- WebProcess/WebCoreSupport/WebChromeClient.h:
build issues:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 11:36 AM Changeset in webkit [64421] by
-
- 4 edits in trunk
<http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
Reviewed by Darin Adler.
WebCore:
- Configurations/WebCore.xcconfig: Extracted
PRODUCTION_FRAMEWORKS_DIR variable.
WebKit/mac:
- Configurations/WebKit.xcconfig: Extracted
PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables.
- 10:30 AM Changeset in webkit [64420] by
-
- 7 edits in trunk/WebCore
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
HTMLStyleElement/SVGStyleElement need to share more code
https://bugs.webkit.org/show_bug.cgi?id=43293
Simplify HTMLStyleElement/SVGStyleElement. They look identically now, as all code is shared in StyleElement.
Doesn't affect any tests.
- dom/StyleElement.cpp: (WebCore::StyleElement::StyleElement): Take createdByParser & Document arguments, to share the line number extraction logic. Store it in m_lineNumber. (WebCore::StyleElement::insertedIntoDocument): Moved addStyleSheetCandidateNode here, to share code between HTML/SVGStyleElement. (WebCore::StyleElement::removedFromDocument): Same for removeStyleSheetCandidateNode. (WebCore::StyleElement::childrenChanged): Introduced new helper function. (WebCore::StyleElement::finishParsingChildren): Ditto. (WebCore::StyleElement::process): Use stored m_lineNumber, avoids a parameter. (WebCore::StyleElement::createSheet): No need to call the virtual setLoading() function, just store m_loading in StyleElement, and set it from here. (WebCore::StyleElement::isLoading): Introduced new helper function. (WebCore::StyleElement::sheetLoaded): Ditto.
- dom/StyleElement.h:
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): Pass Document & createdByParser arguments to StyleElement. (WebCore::HTMLStyleElement::finishParsingChildren): Delegate work to StyleElement. (WebCore::HTMLStyleElement::insertedIntoDocument): Ditto. (WebCore::HTMLStyleElement::removedFromDocument): Ditto. (WebCore::HTMLStyleElement::childrenChanged): Ditto.
- html/HTMLStyleElement.h: (WebCore::HTMLStyleElement::isLoading): Ditto. (WebCore::HTMLStyleElement::sheetLoaded): Ditto.
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): Pass Document & createdByParser arguments to StyleElement. (WebCore::SVGStyleElement::finishParsingChildren): Delegate work to StyleElement. (WebCore::SVGStyleElement::insertedIntoDocument): Ditto. (WebCore::SVGStyleElement::removedFromDocument): Ditto. (WebCore::SVGStyleElement::childrenChanged): Ditto.
- svg/SVGStyleElement.h: (WebCore::SVGStyleElement::isLoading): Ditto. (WebCore::SVGStyleElement::sheetLoaded): Ditto.
- 9:07 AM Changeset in webkit [64419] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed expectations change for Chromium.
- platform/chromium-linux/svg/custom/massive-coordinates-expected.txt: Added.
- 3:55 AM Changeset in webkit [64418] by
-
- 2 edits1 add in trunk/LayoutTests
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Some more housekeeping to turn Leopard but green again.
- platform/mac-leopard/Skipped: Skip fast/text/hyphens* on Leopard, as they fail since days on the bots. Filed bug 43296.
- platform/mac/fast/table/early-table-layout-expected.txt: Added, missing in bug r64225.
- 3:44 AM Changeset in webkit [64417] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-07-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing pixel baseline for new svg/custom/massive-coordinates.svg test.
- platform/mac/svg/custom/massive-coordinates-expected.checksum: Added.
- platform/mac/svg/custom/massive-coordinates-expected.png: Added.
- 3:15 AM Changeset in webkit [64416] by
-
- 2 edits in trunk/WebCore
2010-07-31 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed. Attempt to fix release build failure.
Having 'fail:' label without goto statement generates a compiler
warning that causes a build failure in release build.
- bindings/scripts/CodeGeneratorV8.pm:
- 2:44 AM Changeset in webkit [64415] by
-
- 10 edits in trunk/WebCore
2010-07-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix 'bool' in bindings/scripts/test/TestObj.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::CREATE): (WebDOMTestObj::setCREATE):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_create): (webkit_dom_test_obj_set_create): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjCreate): (WebCore::setJSTestObjCreate):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj CREATE]): (-[DOMTestObj setCREATE:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::CREATEAttrGetter): (WebCore::TestObjInternal::CREATEAttrSetter):
- 1:44 AM Changeset in webkit [64414] by
-
- 15 edits18 adds in trunk/WebCore
2010-07-30 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add idl and mock implementation for HTML5 FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=43134
Add idl for: FileSystem (as DOMFileSystem), Entry, Flags, Metadata,
FileSystemCallback, EntryCallback and ErrorCallback.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
They are added only for Mac and chromium.
Tests will be added when we expose the entry point and add implementation.
- DerivedSources.make:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- storage/DOMFileSystem.cpp: Added.
- storage/DOMFileSystem.h: Added.
- storage/DOMFileSystem.idl: Added.
- storage/Entry.cpp: Added.
- storage/Entry.h: Added.
- storage/Entry.idl: Added.
- storage/EntryCallback.h: Added.
- storage/EntryCallback.idl: Added.
- storage/ErrorCallback.h: Added.
- storage/ErrorCallback.idl: Added.
- storage/FileSystemCallback.h: Added.
- storage/FileSystemCallback.idl: Added.
- storage/Flags.h: Added.
- storage/Flags.idl: Added.
- storage/Metadata.h: Added.
- storage/Metadata.idl: Added.
- storage/MetadataCallback.h: Added.
- storage/MetadataCallback.idl: Added.
- bindings/scripts/CodeGenerator.pm: Added special case handlings for generating setter/getter names for CREATE/EXCLUSIVE attributes in Flags.idl.
- bindings/scripts/test/TestObj.idl: Updated.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Updated.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated.
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Updated.
- bindings/scripts/test/JS/JSTestObj.cpp: Updated.
- bindings/scripts/test/JS/JSTestObj.h: Updated.
- bindings/scripts/test/ObjC/DOMTestObj.h: Updated.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Updated.
- 12:35 AM Changeset in webkit [64413] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations to mark stretch-to-view-height.html failing on
Chromium.
- platform/chromium/test_expectations.txt:
- 12:07 AM Changeset in webkit [64412] by
-
- 2 edits in trunk/WebKit/win
2010-07-31 Daniel Bates <dbates@rim.com>
Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
- WebFrame.cpp: (WebFrame::setPrinting):
Jul 30, 2010:
- 11:58 PM Changeset in webkit [64411] by
-
- 26 edits3 deletes in trunk
2010-07-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64408.
http://trac.webkit.org/changeset/64408
https://bugs.webkit.org/show_bug.cgi?id=43292
Causing failed tests on Chromium canaries due to wrong history
item counts (Requested by atwilson on #webkit).
- fast/css/target-fragment-match.html:
- fast/dom/Window/timer-resume-on-navigation-back.html:
- fast/dom/location-hash.html:
- fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
- fast/frames/resources/cached-page-1.html:
- fast/frames/resources/cached-page-2.html:
- fast/harness/resources/cached-page-1.html:
- fast/harness/resources/cached-page-with-data-urls.html:
- fast/history/gesture-before-onload-expected.txt: Removed.
- fast/history/gesture-before-onload.html: Removed.
- fast/history/history-length.html:
- fast/history/resources/gesture-before-onload-target.html: Removed.
- fast/history/saves-state-after-fragment-nav.html:
- fast/loader/input-element-page-cache-crash.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- fast/loader/stateobjects/pushstate-clears-forward-history.html:
- fast/loader/subframe-navigate-during-main-frame-load.html:
- http/tests/history/redirect-js-document-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-assign-before-load-expected.txt:
- http/tests/history/redirect-js-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-href-before-load-expected.txt:
- http/tests/navigation/resources/document-location.js: (start):
- security/autocomplete-cleared-on-back.html:
- storage/hash-change-with-xhr.js: (runTest):
2010-07-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64408.
http://trac.webkit.org/changeset/64408
https://bugs.webkit.org/show_bug.cgi?id=43292
Causing failed tests on Chromium canaries due to wrong history
item counts (Requested by atwilson on #webkit).
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
- loader/RedirectScheduler.h:
- 11:27 PM Changeset in webkit [64410] by
-
- 1 edit1 add in trunk
2010-07-30 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[CMake] Add FindGperf.cmake
https://bugs.webkit.org/show_bug.cgi?id=39163
Add a clean gperf dedection since we need it for building.
- CMakeLists.txt:
- cmake/FindGperf.cmake: Added.
- 10:59 PM Changeset in webkit [64409] by
-
- 18 edits3 adds in trunk
<rdar://problem/8257783> Short documents may print a second blank page
https://bugs.webkit.org/show_bug.cgi?id=43271
Reviewed by Darin Adler.
WebCore:
Test: printing/stretch-to-view-height.html
- WebCore.exp.in: Export Frame::forceLayoutForPagination(), replacing forceLayoutWithPageWidthRange().
- page/Frame.cpp:
(WebCore::Frame::setPrinting): Now takes a page width and height and a maximum shrink factor and passes
them down to forceLayoutForPagination().
- page/Frame.h:
(WebCore::Frame::):
- page/FrameView.cpp:
(WebCore::FrameView::reset): Initialize m_pageHeight.
(WebCore::FrameView::forceLayoutForPagination): Renamed forceLayoutWithPageWidthRange() to this and
changed it to take a page width and height and a maximum shrink factor. Sets m_pageHeight, which is
queried by RenderBox::calcHeight() during layout. If the given pageHeight is 0, m_pageHeight is set
to the visible height, retaining the behavior before this change.
- page/FrameView.h:
(WebCore::FrameView::pageHeight): Added this accessor.
- page/PrintContext.cpp:
(WebCore::PrintContext::begin): Added a height parameter, used when calling setPrinting().
(WebCore::PrintContext::end): Updated for setPrinting() changes.
(WebCore::PrintContext::pageNumberForElement): Account for shrink-to-fit.
(WebCore::PrintContext::pageProperty): Pass 0 for the height, retaining current behavior.
(WebCore::PrintContext::numberOfPages): Account for shrink-to-fit.
(WebCore::PrintContext::spoolAllPagesWithBoundaries): Pass the page width to begin().
- page/PrintContext.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight): When printing, use FrameView::pageHeight() as the basis for
viewport-relative heights.
WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter
to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
(-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter,
which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
(-[WebHTMLView _endPrintMode]): Updated for additional height parameter to
_setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added
height parameter, which is passed on to FrameView::forceLayoutForPagination().
(-[WebHTMLView layout]): Updated for additional height parameter.
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height
parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height
parameter.
(-[WebHTMLView setPageWidthForPrinting:]): Ditto.
(-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to
_setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize.
- WebView/WebHTMLViewPrivate.h:
WebKit/win:
- WebFrame.cpp:
(WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
page height, which maintains existing behavior.
LayoutTests:
- platform/mac/printing/media-queries-print-expected.txt:
- printing/page-break-margin-collapsed-expected.txt:
- printing/resources/paged-media-test-utils.js:
(ratioToPageHeightToPixels): Changed to reflect the default shrink factor of 1.25.
- printing/script-tests/stretch-to-view-height.js: Added.
(test):
- printing/stretch-to-view-height-expected.txt: Added.
- printing/stretch-to-view-height.html: Added.
- 10:39 PM Changeset in webkit [64408] by
-
- 26 edits3 adds in trunk
2010-07-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861
Lock the back/forward list for location changes that happen before the
onload event fires that are not the result of user gestures.
http/tests/history tests now pass, their expectatiosn were updated
accordingly. Other tests needed a setTimeout wrapper around location
changes during onload, otherwise they would not generate history
entries as expected anymore.
- fast/css/target-fragment-match.html:
- fast/dom/Window/timer-resume-on-navigation-back.html:
- fast/dom/location-hash.html:
- fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
- fast/frames/resources/cached-page-1.html:
- fast/frames/resources/cached-page-2.html:
- fast/harness/resources/cached-page-1.html:
- fast/harness/resources/cached-page-with-data-urls.html:
- fast/history/gesture-before-onload-expected.txt: Added.
- fast/history/gesture-before-onload.html: Added.
- fast/history/history-length.html:
- fast/history/resources/gesture-before-onload-target.html: Added.
- fast/history/saves-state-after-fragment-nav.html:
- fast/loader/input-element-page-cache-crash.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- fast/loader/stateobjects/pushstate-clears-forward-history.html:
- fast/loader/subframe-navigate-during-main-frame-load.html:
- http/tests/history/redirect-js-document-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-assign-before-load-expected.txt:
- http/tests/history/redirect-js-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-href-before-load-expected.txt:
- http/tests/navigation/resources/document-location.js: (start):
- security/autocomplete-cleared-on-back.html:
- storage/hash-change-with-xhr.js: (updateDatabase): (invokeBack): (runTest): (runTestsInner):
2010-07-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861
Lock the back/forward list for location changes that happen before the
onload event fires that are not the result of user gestures.
Test: fast/history/gesture-before-onload.html and updated expectations
for http/tests/history tests that used to fail.
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
- loader/RedirectScheduler.h:
- 10:08 PM Changeset in webkit [64407] by
-
- 5 edits6 adds in trunk
2010-07-30 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
ctx.clearRect improperly clears shadow
https://bugs.webkit.org/show_bug.cgi?id=43213
- canvas/philip/tests/2d.clearRect+fillRect.alpha0-expected.txt: Added.
- canvas/philip/tests/2d.clearRect+fillRect.alpha0.5-expected.txt: Added.
- canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html: Added. Same as above but with alpha of one half.
- canvas/philip/tests/2d.clearRect+fillRect.alpha0.html: Added. Tests that clearing rect with alpha or 0 has no unwanted side-effects
- canvas/philip/tests/2d.clearRect+fillRect.basic-expected.txt: Added.
- canvas/philip/tests/2d.clearRect+fillRect.basic.html: Added. Tests clearing a rect and then filling back over doesn't show any side effects (such as caused by not ignoring/restoring appropriate context attributes).
- platform/mac/Skipped: unskipping now passing test
2010-07-30 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
ctx.clearRect improperly clears shadow
https://bugs.webkit.org/show_bug.cgi?id=43213
Tests: canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Added a new method to wipe out all context attributes to their defaults. (WebCore::CanvasRenderingContext2D::clearRect): Updated clearRect to ignore shadow, alpha, and global composite attributes when clearing the input rect to match the canvas spec.
- html/canvas/CanvasRenderingContext2D.h:
- 10:04 PM Changeset in webkit [64406] by
-
- 4 edits in trunk/WebCore
2010-07-30 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Decouple FileThread from FileStream to support generic file-related async tasks
https://bugs.webkit.org/show_bug.cgi?id=43135
No new tests as this doesn't change any functionality.
- html/FileThread.cpp: (WebCore::FileThread::stop): (WebCore::SameInstancePredicate::SameFilePredicate): (WebCore::SameInstancePredicate::operator()): (WebCore::FileThread::unscheduleTasksInternal):
- html/FileThread.h: (WebCore::FileThread::create): (WebCore::FileThread::Task::instance): (WebCore::FileThread::Task::Task):
- html/FileThreadTask.h: Changed all templates to take any type as a callee instance. (WebCore::createFileThreadTask):
- 9:39 PM Changeset in webkit [64405] by
-
- 2 edits in trunk/LayoutTests
2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org>
Fix chromium test expectations.
Test fast/media/media-feature-wgt-view-mode.html rename to
fast/media/view-mode-media-feature.html.
- platform/chromium/test_expectations.txt:
- 9:01 PM Changeset in webkit [64404] by
-
- 2 edits in trunk/LayoutTests
2010-07-30 Darin Fisher <darin@chromium.org>
Fix layout test oops.
- fast/loader/stateobjects/resources/pushstate-in-iframe-child.html:
- 8:38 PM Changeset in webkit [64403] by
-
- 5 edits in trunk/WebKit/mac
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Fix for tests that broke after r64400. Tracking a more
ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627
Switch the interface back to (unsigned long long), and move
the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin.
The subclasses' implementations were not getting called.
- Storage/WebDatabaseSecurityOrigin.mm:
- WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: (-[WebApplicationCacheSecurityOrigin quota]): (-[WebApplicationCacheSecurityOrigin setQuota:]):
- WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]):
- WebCoreSupport/WebSecurityOriginPrivate.h:
- 8:19 PM Changeset in webkit [64402] by
-
- 10 edits1 move in trunk
2010-07-30 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Eliminate BackForwardList::pushStateItem
https://bugs.webkit.org/show_bug.cgi?id=43282
The layout test was previously disabled because of the assertion being
hit in BackForwardList::pushStateItem. That assertion revealed the need
for this patch.
Test: fast/loader/stateobjects/pushstate-in-iframe.html
- history/BackForwardList.h:
- history/BackForwardListChromium.cpp:
- history/BackForwardListImpl.cpp:
- history/BackForwardListImpl.h:
- loader/HistoryController.cpp: Move the logic, of adding a null state object to the HistoryItem that was previously the current HistoryItem, to HistoryController::pushState from BackForwardList::pushStateItem. The BackForwardList was the wrong place for that logic since it lacked convenient access to the target HistoryItem. It is just given the top-most HistoryItem corresponding to the new navigation.
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
- 7:46 PM Changeset in webkit [64401] by
-
- 17 edits2 moves in trunk
2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Fraser.
Enabling view modes to all platforms
https://bugs.webkit.org/show_bug.cgi?id=37505
Removing ENABLE_WIDGETS_10_SUPPORT flag.
As view mode media feature is not part of widget 1.0 specification
any more the ENABLE_WIDGETS_10_SUPPORT flag may be removed. The only use
of this flag was related to view mode media feature implementation in Qt.
- wtf/Platform.h:
2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Fraser.
Enabling view modes to all platforms
https://bugs.webkit.org/show_bug.cgi?id=37505
Removing 'widget' reference from the layout tests because the view mode media feature
is not part of widget 1.0 specification any more.
The layout tests are stil skipped for all platforms except Qt because of the lack
of support of LayoutTestController in those platforms.
- fast/media/view-mode-media-feature-expected.txt: Renamed from LayoutTests/fast/media/media-feature-wgt-view-mode-expected.txt.
- fast/media/view-mode-media-feature.html: Renamed from LayoutTests/fast/media/media-feature-wgt-view-mode.html.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Fraser.
Enabling view modes to all platforms
https://bugs.webkit.org/show_bug.cgi?id=37505
View mode media feature implementation as specified in http://www.w3.org/TR/view-mode.
The view mode media feature layout tests are stil skipped for all platforms except Qt
because of the lack of support of LayoutTestController in those platforms.
Test: fast/media/view-mode-media-feature.html
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
- page/ChromeClient.h:
- page/Page.cpp: (WebCore::Page::Page): (WebCore::createViewModesSet): (WebCore::Page::setViewMode):
- page/Page.h: (WebCore::Page::viewMode):
2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Fraser.
Enabling view modes to all platforms
https://bugs.webkit.org/show_bug.cgi?id=37505
As view mode media feature is now supported by WebCore there is no need
to keep its implementation here. QtWebKit now uses WebCore's view mode media feature
implementation.
- Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
- Api/qwebpage_p.h:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
- 7:22 PM Changeset in webkit [64400] by
-
- 39 edits3 moves4 adds in trunk
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
WebCore:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Part 4 - Client Notification when the Quota is Reached
Notify the WebKit client when the per-origin quota is reached
via a delegate method reachedApplicationCacheOriginQuota.
Call the delegate method when the quota is reached.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didReachOriginQuota): (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::scheduleReachedOriginQuotaCallback):
- loader/appcache/ApplicationCacheGroup.h:
Some minor refactoring to access more quota information
without repeating code. Such as origin usage, and creating
an origin record.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::usageForOrigin): (WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin): (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::ensureOriginRecord):
- loader/appcache/ApplicationCacheStorage.h:
Boilerplate. Exports and definition of the delegate method.
- WebCore.OfflineWebApplications.exp:
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
- page/ChromeClient.h:
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
WebKit:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebKit.xcodeproj/project.pbxproj:
- efl/WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
- efl/WebCoreSupport/ChromeClientEfl.h:
WebKit/chromium:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::reachedApplicationCacheOriginQuota):
- src/ChromeClientImpl.h:
WebKit/gtk:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientGtk.h:
WebKit/haiku:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientHaiku.h:
WebKit/mac:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Part 4 - Client Notification when the Quota is Reached
Notify the WebKit client when the per-origin quota is reached
via a delegate method reachedApplicationCacheOriginQuota.
Refactor the WebSecurityOrigin class to be generic enough to
allow quota management of both Databases or Application Caches
via subclasses.
- Storage/WebDatabaseSecurityOrigin.h: Added.
- Storage/WebDatabaseSecurityOrigin.mm: Added. (-[WebDatabaseSecurityOrigin quota]): (-[WebDatabaseSecurityOrigin setQuota:]):
- WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
- WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added. (-[WebApplicationCacheSecurityOrigin quota]): (-[WebApplicationCacheSecurityOrigin setQuota:]):
- Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
- Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
- WebCoreSupport/WebSecurityOrigin.mm: Added. (-[WebSecurityOrigin usage]): to be implemented by subclasses. (-[WebSecurityOrigin quota]): to be implemented by subclasses. (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
- WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
- WebCoreSupport/WebSecurityOriginPrivate.h: Added.
Turn the notification into a WebUI Delegate to call. Following
the example of Databases.
- DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass. (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
- WebView/WebUIDelegatePrivate.h:
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
WebKit/qt:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientQt.h:
WebKit/win:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedApplicationCacheOriginQuota):
- WebCoreSupport/WebChromeClient.h:
WebKit/wx:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
- WebKitSupport/ChromeClientWx.h:
WebKit2:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 7:22 PM Changeset in webkit [64399] by
-
- 5 edits in trunk/WebCore
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 3 - Refactor storeNewestCache to allow Failure Reason Output
Storing can result in an error in a number of reasons. Previously
the reasons were global and binary and could be determined by
checking ApplicationCacheStorage state. Now, with per-origin quotas
a per-origin quota can cause a failure that is not in global state.
Current failure reasons are:
OriginQuotaReached = per-origin quota reached, no storage is allowed.
TotalQuotaReached = database quota reached, no storage is allowed.
DiskOrOperationFailure = SQL error such as failed prepare or query. Not expected to happen.
This part provides an implementation of storeNewestCache for those
that care about the failure reason, and not just if it succeeded
or not. This moves the final origin quota check into the transaction.
- loader/appcache/ApplicationCache.h: style fix for forwarding headers.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): move origin quota check into storeNewestCache's SQL transaction.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeNewestCache): old implementation calls the new implementation ignoring failure reason. (WebCore::ApplicationCacheStorage::storeNewestCache): new implementation provides a failure reason in case of failure.
- loader/appcache/ApplicationCacheStorage.h: (WebCore::ApplicationCacheStorage::): added FailureReason enum and storeNewestCache allowing it.
- 7:22 PM Changeset in webkit [64398] by
-
- 5 edits in trunk/WebCore
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 2 - Update Schema and enforce Per-Origin Quotas
Added an "Origins" table to the application cache databases.
This, like the Database's Origins table, is a list of origin
and quota pairs. Origins records are added as soon as they are
needed, and deleted only when the ApplicationCacheStorage is
emptied. This means Origins records persist even after all
caches for that origin may be deleted. The "CacheGroups" table
now has a foreign key column "origin" which relates to the
"Origins" table.
To enforce the quotas, remaining quota space is checked at
the start of update as an estimate and at the end before
inserting. Currently, reaching the quota limit will simply
cause an update error. A later part will provide a
notification to the client to allow an action, and refactor
the final quota limit check into a transaction.
Respect the quota during the update process. And cause
the update process to fail when the quota is reached.
- loader/appcache/ApplicationCacheGroup.cpp: added loading counter, counts bytes as they load (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didReceiveData): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheGroup.h: added security origin, based on the manifest URL (WebCore::ApplicationCacheGroup::origin): accessor
Updates the schema of the database tables as described
above. Handle other SQL operations such as checking the
remaining space and inserting and deleting Origins records.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::quotaForOrigin): query for the quota of an origin, may return the default origin quota if it didn't exist. (WebCore::ApplicationCacheStorage::remainingSizeForOriginExcludingCache): calculate the remaining size in a quota for an origin, possibly excluding a cache. (WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin): persistent update. (WebCore::ApplicationCacheStorage::openDatabase): updated schema for CachesGroups, added new table Origins. (WebCore::ApplicationCacheStorage::empty): wipe Origins table as well. (WebCore::ApplicationCacheStorage::unknownQuota): constant to mean unknown quota
- 7:22 PM Changeset in webkit [64397] by
-
- 13 edits in trunk
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 1 - Add Total and Per-Origin Quota Preferences.
Allow the application cache total size to be a preference, and
add a new preference for the default per-origin quota.
WebCore:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Allow the application cache total size to be a preference, and
add a new preference for the default per-origin quota.
Handle the per-origin quota in the global cacheStorage() object.
The per-origin quota will be used in a later part, this just
handles interaction with it from a client.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::setDefaultOriginQuota): setter (WebCore::ApplicationCacheStorage::ApplicationCacheStorage): default to "noQuota" on construction
- loader/appcache/ApplicationCacheStorage.h: (WebCore::ApplicationCacheStorage::noQuota): constant to mean unlimited storage (WebCore::ApplicationCacheStorage::defaultOriginQuota): accessor
Move around some exports around for Offline Web Applications.
- WebCore.exp.in: Added OFFLINE_WEB_APPLICATIONS exports.
WebKit/mac:
2010-07-30 Joseph Pecoraro <Joseph Pecoraro>
Storage quotas were int64_t (long long). Boilerplate for
these types added for consistency.
- Misc/WebNSDictionaryExtras.h:
- Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setLongLong:forKey:]):
- WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage.
- WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache maximumSize:]): (+[WebApplicationCache setMaximumSize:]): (+[WebApplicationCache defaultOriginQuota]): (+[WebApplicationCache setDefaultOriginQuota:]):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): defaults to noQuota for both preferences. (-[WebPreferences _longLongValueForKey:]): (-[WebPreferences _setLongLongValue:forKey:]): (-[WebPreferences applicationCacheTotalQuota]): (-[WebPreferences setApplicationCacheTotalQuota:]): (-[WebPreferences applicationCacheDefaultOriginQuota]): (-[WebPreferences setApplicationCacheDefaultOriginQuota:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): respect updates to the preferences.
- 6:58 PM Changeset in webkit [64396] by
-
- 24 edits1 add in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
Add structured message passing from the injected bundle to UIProcess
Reviewed by Maciej Stachowiak.
WebKit2:
- Platform/CoreIPC/MessageID.h:
- Shared/CoreIPCSupport/WebContextMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
(WebProcessProxyMessage::):
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContext.cpp:
(WebKit::):
(WebKit::PostMessageEncoder::PostMessageDecoder::PostMessageDecoder):
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
(WebKit::WebContext::didReceiveMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
- UIProcess/WebContext.h:
- UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostMessage):
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::):
(WebKit::InjectedBundle::InjectedBundle):
(WebKit::InjectedBundle::~InjectedBundle):
(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::setShouldTrackVisitedLinks):
(WebKit::InjectedBundle::removeAllVisitedLinks):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::willDestroyPage):
(WebKit::InjectedBundle::didReceiveMessage):
- WebProcess/InjectedBundle/InjectedBundle.h:
WebKitTools:
- MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowForFrame):
(didRecieveMessage):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::didReceiveMessage):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 6:58 PM Changeset in webkit [64395] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed expectations change for chromium.
- platform/chromium-mac/fast/forms/search-transformed-expected.checksum: Added.
- platform/chromium-mac/fast/forms/search-transformed-expected.png: Added.
- 6:50 PM Changeset in webkit [64394] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix to expectations.
- platform/chromium/test_expectations.txt:
- 6:48 PM Changeset in webkit [64393] by
-
- 2 edits7 adds in trunk/LayoutTests
Unreviewed expectations changes.
- platform/chromium-mac/svg/custom/massive-coordinates-expected.checksum: Added.
- platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Added.
- platform/chromium-win/svg/custom/massive-coordinates-expected.checksum: Added
- platform/chromium-win/svg/custom/massive-coordinates-expected.png: Added
- platform/chromium-win/svg/custom/massive-coordinates-expected.txt: Added.
- platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.checksum: Added
- platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png: Added
- platform/chromium/test_expectations.txt:
- 6:34 PM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 5:50 PM Changeset in webkit [64392] by
-
- 1 edit in trunk/WebCore/ChangeLog
I duplicated several ChangeLog entries when resolving a conflict.
- 5:39 PM Changeset in webkit [64391] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-30 James Robinson <jamesr@chromium.org>
Compile fix. Put GLES2 functions behind USE(GLES2_RENDERING) instead of
USE(ACCELERATED_COMPOSITING) to match WebCore. Fixes the compile when
USE(GLES2_RENDERING) is true and USE(ACCELERATED_COMPOSITING) is false.
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
- 5:28 PM Changeset in webkit [64390] by
-
- 18 edits in trunk
JavaScriptCore: Add Xcode support for compiling WebKit against iOS SDKs.
https://bugs.webkit.org/show_bug.cgi?id=42796
Reviewed by David Kilzer.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
WebCore: Add Xcode support for compiling WebKit against iOS SDKs.
https://bugs.webkit.org/show_bug.cgi?id=42796
Reviewed by David Kilzer.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
WebKit/mac: Add Xcode support for compiling WebKit against iOS SDKs.
https://bugs.webkit.org/show_bug.cgi?id=42796
Reviewed by David Kilzer.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
WebKit2: Add support to Xcode for compiling WebKit against iOS SDKs.
https://bugs.webkit.org/show_bug.cgi?id=42796
Reviewed by David Kilzer.
- Configurations/FeatureDefines.xcconfig:
- 5:18 PM Changeset in webkit [64389] by
-
- 3 edits in trunk/WebCore
2010-07-30 James Robinson <jamesr@chromium.org>
Compile fix: fix a typo in forward declaration, add EmptyClients impl.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::getOnscreenGLES2Context): (WebCore::EmptyChromeClient::getOffscreenGLES2Context):
- page/ChromeClient.h:
- 4:46 PM Changeset in webkit [64388] by
-
- 7 edits6 deletes in trunk/LayoutTests
Unreviewed rollback for r64375 because it broke chromium tests
downstream due to expectation files that were not moved.
https://bugs.webkit.org/show_bug.cgi?id=43261
- fast/forms/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/fast/speech/input-appearance-numberandspeech-expected.txt.
- fast/forms/input-appearance-numberandspeech.html: Renamed from LayoutTests/fast/speech/input-appearance-numberandspeech.html.
- fast/forms/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/fast/speech/input-appearance-searchandspeech-expected.txt.
- fast/forms/input-appearance-searchandspeech.html: Renamed from LayoutTests/fast/speech/input-appearance-searchandspeech.html.
- fast/forms/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/fast/speech/input-appearance-speechbutton-expected.txt.
- fast/forms/input-appearance-speechbutton.html: Renamed from LayoutTests/fast/speech/input-appearance-speechbutton.html.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 4:45 PM Changeset in webkit [64387] by
-
- 2 edits in trunk/WebKit2
Cast the return value for the templated ImmutableArray::at().
Reviewed by Sam Weinig.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::at):
- 4:38 PM Changeset in webkit [64386] by
-
- 31 edits in trunk/WebKit2
Patch for https://bugs.webkit.org/show_bug.cgi?id=43283
Add APIObject template introspection support.
Reviewed by Anders Carlsson.
Add a way to get the type the APIObject::Type from the APIObject subclass typenames
for template fun. Use this to make a type checking version of ImmutableArray::at.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::type):
- Shared/WebString.h:
(WebKit::WebString::type):
- Shared/WebURL.h:
(WebKit::WebURL::type):
- UIProcess/API/C/WKArray.cpp:
(WKArrayGetTypeID):
- UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListGetTypeID):
- UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemGetTypeID):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetTypeID):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetTypeID):
- UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerGetTypeID):
- UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataGetTypeID):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetTypeID):
- UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetTypeID):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetTypeID):
- UIProcess/API/C/WKString.cpp:
(WKStringGetTypeID):
- UIProcess/API/C/WKURL.cpp:
(WKURLGetTypeID):
- UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::type):
- UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::type):
- UIProcess/WebContext.h:
(WebKit::WebContext::type):
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::type):
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::type):
- UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::type):
- UIProcess/WebPageNamespace.h:
(WebKit::WebPageNamespace::type):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::type):
- UIProcess/WebPreferences.h:
(WebKit::WebPreferences::type):
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGetTypeID):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetTypeID):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetTypeID):
- WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::type):
- WebProcess/WebPage/WebFrame.h:
(WebKit::WebFrame::type):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::type):
- 4:34 PM Changeset in webkit [64385] by
-
- 3 edits in trunk/WebCore
2010-07-30 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Move GLES2 context manipulation to ChromeClient.h and put it behind the right #if guard
https://bugs.webkit.org/show_bug.cgi?id=43281
These calls were initially put in ChromeClientChromium, but they aren't chromium specific.
In theory any port that could create the proper OpenGL ES 2 contexts could implement
these functions. Also moves the calls to be behind the correct #if guard.
- page/ChromeClient.h:
- page/chromium/ChromeClientChromium.h:
- 4:19 PM Changeset in webkit [64384] by
-
- 26 edits in trunk
JavaScriptCore: Added a yield() function.
https://bugs.webkit.org/show_bug.cgi?id=42843
Reviewed by Davin Levin.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::yield):
- wtf/ThreadingWin.cpp:
(WTF::yield):
- wtf/gtk/ThreadingGtk.cpp:
(WTF::yield):
- wtf/qt/ThreadingQt.cpp:
(WTF::yield):
WebCore: Interrupt all DB operations when the worker is terminating.
https://bugs.webkit.org/show_bug.cgi?id=42843
Reviewed by David Levin.
Tests: fast/workers/storage/interrupt-database-sync.html
fast/workers/storage/interrupt-database.html
- bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback): If the
destructor is called on the context thread, delete m_data directly
instead of posting a task to do that. We need to do that to make
sure that all JS objects are destroyed before
WorkerThreadShutdownFinishTask (in WorkerThread.cpp) calls
WorkerContext::clearScript().
- bindings/scripts/CodeGeneratorJS.pm: Same change as above, for
all auto-generated callbacks.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback): Updated the
expectations for run-bindings-tests.
- platform/sql/SQLiteDatabase.cpp: Added the ability to interrupt
all DB operations in progress, unless the database was closed or
is being closed. Unlike sqlite3_interrupt(),
SQLiteDatabase::interrupt() is sticky: once it's called, trying to
run any statement on that database will fail with a
SQLITE_INTERRUPT error code.
(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::interrupt):
(WebCore::SQLiteDatabase::isInterrupted):
- platform/sql/SQLiteDatabase.h: Added a mutex that can used by
SQLiteStatement to check if the database was interrupted.
(WebCore::SQLiteDatabase::databaseMutex):
- platform/sql/SQLiteStatement.cpp: Changed prepare() and step()
to check if the database was interrupted, before trying to prepare
or run the statement. The other methods don't need to hold on to
the DB lock while running, because they're fast, so we don't need
to interrupt them.
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):
- storage/AbstractDatabase.cpp: Made SQLiteDatabase::interrupt()
and isInterrupted() visible to WebSQLDatabases classes.
(WebCore::AbstractDatabase::interrupt):
(WebCore::AbstractDatabase::isInterrupted):
- storage/AbstractDatabase.h:
- storage/DatabaseTracker.cpp: Added a method to interrupt all
databases in a given context.
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
- storage/DatabaseTracker.h:
- storage/SQLStatement.cpp: Changed the exception/error reported
when a statement is interrupted.
(WebCore::SQLStatement::execute):
- storage/SQLStatementSync.cpp:
(WebCore::SQLStatementSync::execute):
- storage/SQLTransaction.cpp: Changed the code to release the
callback objects as soon as they're not needed.
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
Changed this method to not schedule the next transaction step when
the database is interrupted.
(WebCore::SQLTransaction::performNextStep):
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- storage/SQLTransaction.h:
- storage/chromium/DatabaseTrackerChromium.cpp: Added a method to
interrupt all databases in a given context.
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop): Added a call to
DatabaseTracker::interruptAllDatabasesForContext().
LayoutTests: Test that terminating a worker interrupts all DB operations in that worker.
https://bugs.webkit.org/show_bug.cgi?id=42843
Reviewed by Davin Levin.
- fast/workers/storage/interrupt-database-expected.txt: Added.
- fast/workers/storage/interrupt-database-sync-expected.txt: Added.
- fast/workers/storage/interrupt-database-sync.html: Added.
- fast/workers/storage/interrupt-database.html: Added.
- fast/workers/storage/resources/interrupt-database-sync.js: Added.
- fast/workers/storage/resources/interrupt-database.js: Added.
(runTransaction):
- 4:02 PM Changeset in webkit [64383] by
-
- 7 edits2 adds in trunk/WebCore
2010-07-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
connect-compositing-iframe2.html test sometimes shows blank iframe content
https://bugs.webkit.org/show_bug.cgi?id=42046
Hooking up compositing iframes requires setNeedsStyleRecalc(SyntheticStyleChange) to
always result in a call to RenderLayer::styleChanged(). However, the semantics of
setNeedsStyleRecalc() was that each call would overwrite the existing styleChangeType,
allowing a "lesser" style change to override a "greater" one. In the test content,
SyntheticStyleChange was being replaced by FullStyleChange when the classname changed.
This resulted in RenderLayer::styleChanged() not being called.
Fix by changing the behavior of setNeedsStyleRecalc() to only touch the style change
type if a "lesser" change is being replaced with a "greater" one. This required adding
a new clearNeedsStyleRecalc() method to reset the style change type to NoStyleChange.
In addition, in Node::setNeedsStyleRecalc(), only propagate the childNeedsStyleRecalc
up the parent change if the node was not already needing recalc. In order to fix issues
with attaching, this required new call to clearNeedsStyleRecalc() at the end of attach().
- manual-tests/compositing/missing-iframe-contents.html: Added.
- manual-tests/compositing/resources/composited-subframe.html: Copied from LayoutTests/compositing/iframes/resources/composited-subframe.html.
- dom/Document.cpp: (WebCore::Document::recalcStyle): Call clearNeedsStyleRecalc().
- dom/Element.cpp: (WebCore::Element::recalcStyle): Call clearNeedsStyleRecalc().
- dom/Node.h: (WebCore::Node::clearNeedsStyleRecalc): New method.
- dom/Node.cpp: (WebCore::Node::setNeedsStyleRecalc): Only call setStyleChange() if the change type is greater than the current change type. (WebCore::Node::attach): After attaching, we can call clearNeedsStyleRecalc().
- dom/Text.cpp: (WebCore::Text::recalcStyle): Call clearNeedsStyleRecalc().
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Call clearNeedsStyleRecalc().
- 3:49 PM Changeset in webkit [64382] by
-
- 5 edits in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
Make WKArrayRef more usable.
Reviewed by Anders Carlsson.
WebKit2:
- Add Create functions.
- Make WKArrayGetItemAtIndex return a WKTypeRef.
- UIProcess/API/C/WKArray.cpp:
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
(WKArrayGetItemAtIndex):
- UIProcess/API/C/WKArray.h:
WebKitTools:
Remove now unnecessary const_casts.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpDescendantFrameScrollPositions):
(WTR::dumpDescendantFramesText):
- 3:38 PM Changeset in webkit [64381] by
-
- 2 edits in trunk/WebKit2
Reviewed by John Sullivan.
Fix issue with populating the back list when limit is a huge number.
https://bugs.webkit.org/show_bug.cgi?id=43270
- UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
- 3:27 PM Changeset in webkit [64380] by
-
- 29 edits1 add in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
Add first pass of structured message passing.
Reviewed by Anders Carlsson.
WebKit2:
- Only supports passing messages from the UIProcess -> InjectedBundle
- Only supports passing Strings, Arrays, and WebPage references (NOTE: There currently isn't a way to make an array).
- Changed ImmutableArray to operate on APIObjects instead of void*'s and removed the retain/release abstraction.
- Platform/CoreIPC/MessageID.h:
(CoreIPC::):
- Shared/CoreIPCSupport/InjectedBundleMessageKinds.h: Added.
(InjectedBundleMessage::):
(CoreIPC::):
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
- Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::create):
(WebKit::ImmutableArray::adopt):
(WebKit::ImmutableArray::at):
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextPostMessageToInjectedBundle):
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKType.cpp:
(WKGetTypeID):
- UIProcess/API/C/WebKit2.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveMessageFromInjectedBundle):
- UIProcess/WebContext.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::didReceiveMessage):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
- win/WebKit2.vcproj:
WebKitTools:
Update Minibrowser and WebKitTestRunner to work with the new post message
function.
- MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
- MiniBrowser/mac/MiniBrowser_Prefix.pch:
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didClearWindowForFrame):
(didCreatePage):
(willDestroyPage):
(didRecieveMessage):
(WKBundleInitialize):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::_didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessage):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 3:24 PM Changeset in webkit [64379] by
-
- 6 edits1 copy1 move3 adds3 deletes in trunk
2010-07-30 W. James MacLean <wjmaclean@google.com>
Reviewed by Nikolas Zimmermann.
SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645
Two of the expected test outputs were incorrect now that parsing of large values
is handled correctly.
- Revised FloatRect to remove bad float-to-int conversions in enclosingIntRect()
- Revised _parseNumber to do right-to-left float-based parsing of input value
- platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/massive-coordinates-expected.txt: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
- platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Removed.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Removed.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- svg/custom/mask-excessive-malloc-expected.txt: Added.
- svg/custom/massive-coordinates-expected.txt: Added.
- svg/custom/massive-coordinates.svg: Added.
- svg/custom/pattern-excessive-malloc-expected.txt: Added.
2010-07-30 W. James MacLean <wjmaclean@google.com>
Reviewed by Nikolas Zimmermann.
SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645
Two of the expected test outputs were incorrect now that parsing of large values
is handled correctly.
- Revised FloatRect to remove bad float-to-int conversions in enclosingIntRect()
- Revised _parseNumber to do right-to-left float-based parsing of input value
Test: svg/custom/massive-coordinates.svg
- platform/graphics/FloatRect.cpp: (WebCore::safeFloatToInt): (WebCore::enclosingIntRect):
- svg/SVGParserUtilities.cpp: (WebCore::_parseNumber):
- 2:49 PM Changeset in webkit [64378] by
-
- 5 edits in trunk
Versioning.
- 2:43 PM Changeset in webkit [64377] by
-
- 11 edits2 adds in trunk
Implement NPN_Evaluate
https://bugs.webkit.org/show_bug.cgi?id=43268
Reviewed by Sam Weinig.
WebKit2:
- WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
Evaluate the passed in string.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_Evaluate):
Call NetscapePlugin::evaluate.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::evaluate):
Call PluginController::evaluate.
- WebProcess/Plugins/PluginController.h:
Add evaluate pure virtual member function.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::evaluate):
Update the popup window state and call NPRuntimeObjectMap::evaluate.
LayoutTests:
Add test.
- plugins/npruntime/evaluate-expected.txt: Added.
- plugins/npruntime/evaluate.html: Added.
- 2:36 PM Changeset in webkit [64376] by
-
- 1 copy in tags/Safari-534.4
New tag.
- 2:29 PM Changeset in webkit [64375] by
-
- 7 edits6 moves1 add in trunk/LayoutTests
2010-07-30 Satish Sampath <satish@chromium.org>
Reviewed by David Levin.
Move speech input layout tests to their own directory.
https://bugs.webkit.org/show_bug.cgi?id=43261
- fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/fast/forms/input-appearance-numberandspeech-expected.txt.
- fast/speech/input-appearance-numberandspeech.html: Renamed from LayoutTests/fast/forms/input-appearance-numberandspeech.html.
- fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/fast/forms/input-appearance-searchandspeech-expected.txt.
- fast/speech/input-appearance-searchandspeech.html: Renamed from LayoutTests/fast/forms/input-appearance-searchandspeech.html.
- fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/fast/forms/input-appearance-speechbutton-expected.txt.
- fast/speech/input-appearance-speechbutton.html: Renamed from LayoutTests/fast/forms/input-appearance-speechbutton.html.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:20 PM Changeset in webkit [64374] by
-
- 5 edits in trunk/WebCore
2010-07-30 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make the GLES2 texture map generic and teach ImageSkia and ImageBufferSkia about GLES2
https://bugs.webkit.org/show_bug.cgi?id=43218
This makes the GLES2Canvas' TextureHashMap key on void* instead of NativeImagePtr
to make it easier to use with other backends. It also teaches ImageSkia how
to draw to a GLES2Canvas instead of a skia buffer.
No change in functionality (yet), no new tests.
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture):
- platform/graphics/chromium/GLES2Canvas.h:
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2): (WebCore::BitmapImage::draw): (WebCore::BitmapImageSingleFrameSkia::draw):
- 2:15 PM Changeset in webkit [64373] by
-
- 3 edits in trunk/WebCore
2010-07-30 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Implement SVGScriptElement::shouldExecuteAsJavaScript() otherwise
SVGScriptElement cannot run when XHTMLMP is enabled.
https://bugs.webkit.org/show_bug.cgi?id=43267
No test needed, because it fails all SVG <script> tests when XHTMLMP is on.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
- svg/SVGScriptElement.h:
- 2:14 PM Changeset in webkit [64372] by
-
- 1 edit1 move in trunk/LayoutTests
2010-07-30 Darin Fisher <darin@chromium.org>
Temporarily disable this test. For some reason, the test is reporting
'PASS' but notifyDone() is not running.
- fast/loader/stateobjects/pushstate-in-iframe.html: Removed.
- fast/loader/stateobjects/pushstate-in-iframe.html-disabled: Copied from fast/loader/stateobjects/pushstate-in-iframe.html.
- 2:13 PM Changeset in webkit [64371] by
-
- 2 edits in trunk/WebCore
Style errors in Navigator.h
https://bugs.webkit.org/show_bug.cgi?id=43262
Reviewed by Darin Adler.
Fixing style changes. No new tests.
- page/Navigator.h:
(WebCore::Navigator::create):
(WebCore::Navigator::frame):
(WebCore::Navigator::optionalGeolocation):
- 2:09 PM Changeset in webkit [64370] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations fix.
- platform/chromium/test_expectations.txt:
- 2:06 PM UsingGitWithWebKit edited by
- (diff)
- 1:39 PM Changeset in webkit [64369] by
-
- 5 edits3 adds in trunk
2010-07-27 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
History.pushState() + navigation operates on top frame when called from
nested context
https://bugs.webkit.org/show_bug.cgi?id=43080
Test: fast/loader/stateobjects/pushstate-in-iframe.html
- loader/HistoryController.cpp: (WebCore::HistoryController::pushState): createTreeItem should be called on the top-most HistoryController so that we properly clone the HistoryItem tree starting at the root node.
- 12:35 PM Changeset in webkit [64368] by
-
- 2 edits in trunk/LayoutTests
2010-07-30 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
[Gtk] Needs a signal for didFinishDocumentLoadForFrame - fails fast/history/saves-state-after-fragment-nav.html
https://bugs.webkit.org/show_bug.cgi?id=27637
This feature was added in a different bug, so we can unskip this test.
- platform/gtk/Skipped:
- 12:06 PM Changeset in webkit [64367] by
-
- 3 edits in trunk/WebCore
2010-07-30 fsamuel@chromium.org <fsamuel@chromium.org>
Reviewed by Dimitri Glazkov.
Expand SVG Attribute Macros
https://bugs.webkit.org/show_bug.cgi?id=43254
Expanded SVG Attribute Macros to reduce debugging headache.
No change in behavior, so no new tests.
- rendering/style/SVGRenderStyle.h: Expanded and removed references to SVG_RS_DEFINE_ATTRIBUTE* macros.
- rendering/style/SVGRenderStyleDefs.h: Removed definitons for expanded macros.
- 12:04 PM Changeset in webkit [64366] by
-
- 7 edits in trunk/WebCore
2010-07-30 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add callback arguments support to binding code generator scripts
https://bugs.webkit.org/show_bug.cgi?id=43130
Tests: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::methodWithCallbackArgCallback): (WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): (WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback): (WebCore::ConfigureV8TestObjTemplate):
- 11:47 AM Changeset in webkit [64365] by
-
- 10 edits in trunk
Implement NPN_InvokeDefault
https://bugs.webkit.org/show_bug.cgi?id=43266
Reviewed by Sam Weinig.
WebCore:
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::isPluginElement):
Add convenience function.
(WebCore::pluginInstance):
Call isPluginElement.
(WebCore::pluginScriptObjectFromPluginViewBase):
Given an JSHTMLElement, ask the PluginViewBase for the scriptable object.
(WebCore::pluginScriptObject):
Call isPluginElement. Call pluginScriptObjectFromPluginViewBase.
(WebCore::callPlugin):
Get the script object, assemble the arguments and call "call" directly.
(WebCore::runtimeObjectGetCallData):
Try to get the script object from the PluginViewBase first.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scriptObject):
Remove ExecState parameter.
WebKit2:
- WebProcess/Plugins/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
Remove ExecState parameter.
(WebKit::JSNPObject::callObject):
Call the NPClass::invokeDefault function.
(WebKit::callNPJSObject):
Call JSNPObject::callObject.
(WebKit::JSNPObject::getCallData):
Check if the NPClass has an invokeDefault function.
- WebProcess/Plugins/JSNPObject.h:
- WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
Remove ExecState parameter.
(WebKit::NPRuntimeObjectMap::convertNPVariantToJSValue):
Remove ExecState parameter.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scriptObject):
Remove ExecState parameter.
- 11:18 AM Changeset in webkit [64364] by
-
- 13 edits in trunk
We can't make these changes until QuartzCore.lib is included in
WebKitSupportLibrary.
- 11:01 AM Changeset in webkit [64363] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- win/WebKit2Apple.vsprops: Always link against QuartzCore, since
WebKitSystemInterface requires it.
- 10:39 AM Changeset in webkit [64362] by
-
- 2 edits in trunk/WebKitTools
Try to fix the layout test failures.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_get_value):
- 10:37 AM Changeset in webkit [64361] by
-
- 11 edits in trunk
Remove uses of CACFContextRef and CARender* from WebCore
These types are now wrapped in a WKCACFContext type exported by
WebKitSystemInterface.
Fixes <http://webkit.org/b/43244>.
Reviewed by Sam Weinig.
WebCore:
- platform/graphics/win/WKCACFContextFlusher.cpp:
(WebCore::WKCACFContextFlusher::addContext):
(WebCore::WKCACFContextFlusher::removeContext):
(WebCore::WKCACFContextFlusher::flushAllContexts):
- platform/graphics/win/WKCACFContextFlusher.h:
Changed to use WKCACFContext. We don't retain/release the context when
putting it into/taking it out of the set. WKCACFContext is not a
ref-counted type, so we can't retain/release it, but the
retain/release was also unnecessary as WKCACFLayerRenderer calls
removeContext before the context is destroyed.
- platform/graphics/win/WKCACFLayer.cpp:
(WebCore::WKCACFLayer::becomeRootLayerForContext):
- platform/graphics/win/WKCACFLayer.h:
Changed to use WKCACFContext.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::didFlushContext):
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
(WebCore::WKCACFLayerRenderer::createRenderer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::render): Also replaced uses of
CGSRegion with WebKitSystemInterface functions/types.
(WebCore::WKCACFLayerRenderer::resetDevice):
- platform/graphics/win/WKCACFLayerRenderer.h:
Replaced our CACFContextRef, CARenderContext, and CARenderOGLContext
with a single WKCACFContext, which wraps all three. We hold a bare
pointer to it and destroy it in our destructor.
WebKitLibraries:
Add WKCACFContext and related functions
Also added some functions used by WKCAImageQueue.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 10:37 AM Changeset in webkit [64360] by
-
- 4 edits in trunk/WebCore
Remove knowledge of WKCACFContextFlusher from WKCACFLayer
Fixes <http://webkit.org/b/43248> WKCACFLayer shouldn't know about
WKCACFContextFlusher
Reviewed by Sam Weinig.
- platform/graphics/win/WKCACFLayer.cpp:
(WebCore::WKCACFLayer::setNeedsCommit): Don't bother calling to
WKCACFContextFlusher. Our root layer will do this for us.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFRootLayer::setNeedsRender): Changed to call the new
layerTreeDidChange function.
(WebCore::WKCACFLayerRenderer::layerTreeDidChange): Added. Tells
WKCACFContextFlusher that the context has changed, and schedules a
render.
- platform/graphics/win/WKCACFLayerRenderer.h: Added
layerTreeDidChange.
- 10:30 AM Changeset in webkit [64359] by
-
- 12 edits3 adds2 deletes in trunk
Replace plugins/npruntime/bindings-test.html with a more sophisticated test
https://bugs.webkit.org/show_bug.cgi?id=43232
Reviewed by Adam Roben.
WebKitTools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add PluginScriptableNPObjectInvokeDefault.cpp.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
Remove invokeDefault callback function.
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::create):
Move this to the top of the file.
(PluginTest::NPP_GetValue):
Add default implementation.
(PluginTest::NPN_CreateObject):
Add NPN_ wrapper.
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest::identifier):
Add identifier getter.
- DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
(DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
Add "using namespace std".
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_GetValue):
Give PluginTest a chance to return a value.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
Add PluginScriptableNPObjectInvokeDefault.cpp.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_get_value):
Give PluginTest a chance to return a value.
LayoutTests:
- plugins/npruntime/bindings-test-expected.txt: Removed.
- plugins/npruntime/bindings-test.html: Removed.
- plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt: Added.
- plugins/npruntime/plugin-scriptable-object-invoke-default.html: Added.
- 8:29 AM Changeset in webkit [64358] by
-
- 37 edits1 copy6 moves1 delete in trunk
2010-07-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Rename all the IDBIndex classses to match the latest conventions
https://bugs.webkit.org/show_bug.cgi?id=43190
No functionality has changed.
IDBIndexRequest -> IDBIndex in the spec. So that's the first change.
IDBIndex was the name of our interface class though, so we need to rename
it to get it out of the way. While we're at it, we might as well clean
up the naming in general to make things more clear. In the future, we're
going to need another layer (yes, yuck) which will be shared by the async
and sync classes which will do caching and other optimizations. That will
then connect to the backend. We also added "Interface" to make it more
clear that's what the file/class is.
Existing layout tests are enough since nothing should change as far as JavaScript can see.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- storage/IDBAny.cpp: (WebCore::IDBAny::idbIndex): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBCallbacks.h:
- storage/IDBIndex.cpp: Added. (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::~IDBIndex):
- storage/IDBIndex.h: (WebCore::IDBIndex::create): (WebCore::IDBIndex::name): (WebCore::IDBIndex::keyPath): (WebCore::IDBIndex::unique):
- storage/IDBIndex.idl: Added.
- storage/IDBIndexBackendImpl.cpp: Added. (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::~IDBIndexBackendImpl):
- storage/IDBIndexBackendImpl.h: Added. (WebCore::IDBIndexBackendImpl::create): (WebCore::IDBIndexBackendImpl::name): (WebCore::IDBIndexBackendImpl::keyPath): (WebCore::IDBIndexBackendImpl::unique):
- storage/IDBIndexBackendInterface.h: Added. (WebCore::IDBIndexBackendInterface::~IDBIndexBackendInterface):
- storage/IDBIndexImpl.cpp: Removed.
- storage/IDBIndexImpl.h: Removed.
- storage/IDBIndexRequest.cpp: Removed.
- storage/IDBIndexRequest.h: Removed.
- storage/IDBIndexRequest.idl: Removed.
- storage/IDBObjectStore.h:
- storage/IDBObjectStoreImpl.cpp: (WebCore::IDBObjectStoreImpl::createIndex): (WebCore::IDBObjectStoreImpl::index):
- storage/IDBObjectStoreImpl.h:
- storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::index):
- storage/IDBObjectStoreRequest.h:
- storage/IDBObjectStoreRequest.idl:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
2010-07-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Rename all the IDBIndex classses to match the latest conventions
https://bugs.webkit.org/show_bug.cgi?id=43190
Fix up stuff in WebKit layer to handle the renamings in WebCore.
- WebKit.gyp:
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBIndexBackendProxy.cpp: Added. (WebCore::IDBIndexBackendProxy::create): (WebCore::IDBIndexBackendProxy::IDBIndexBackendProxy): (WebCore::IDBIndexBackendProxy::~IDBIndexBackendProxy): (WebCore::IDBIndexBackendProxy::name): (WebCore::IDBIndexBackendProxy::keyPath): (WebCore::IDBIndexBackendProxy::unique):
- src/IDBIndexBackendProxy.h: Added.
- src/IDBIndexProxy.cpp: Removed.
- src/IDBIndexProxy.h: Removed.
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::index):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::WebIDBIndexImpl): (WebKit::WebIDBIndexImpl::name): (WebKit::WebIDBIndexImpl::keyPath): (WebKit::WebIDBIndexImpl::unique):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::index):
- 7:31 AM Changeset in webkit [64357] by
-
- 10 edits in trunk
2010-07-30 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add library version and soname to EFL generated libraries and binary.
https://bugs.webkit.org/show_bug.cgi?id=43212
Make WebKit-EFL follow libtool soname versioning scheme.
- cmake/OptionsEfl.cmake: Added PROJECT_VERSION_PATCH to PROJECT_VERSION.
2010-07-30 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add library version and soname to EFL generated libraries and binary.
https://bugs.webkit.org/show_bug.cgi?id=43212
Add version and soname to libjavascriptcore.so and libwtf.so in case of
linking as shared libraries, and version to jsc executable.
- CMakeLists.txt:
- jsc/CMakeLists.txt:
- wtf/CMakeLists.txt:
2010-07-30 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add library version and soname to EFL generated libraries and binary.
https://bugs.webkit.org/show_bug.cgi?id=43212
Add version and soname to libwebcore.so in case of linking as shared
library.
No new feature, so no new tests.
- CMakeLists.txt:
2010-07-30 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add library version and soname to EFL generated libraries and binary.
https://bugs.webkit.org/show_bug.cgi?id=43212
Add version and soname to libewebkit.so.
- CMakeLists.txt:
- 7:16 AM Changeset in webkit [64356] by
-
- 26 edits2 copies3 adds in trunk
2010-07-30 Steve Block <steveblock@google.com>
Reviewed by Steve Block.
Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589
- fast/dom/DeviceOrientation/basic-operation-expected.txt: Added.
- fast/dom/DeviceOrientation/basic-operation.html: Added.
- fast/dom/DeviceOrientation/script-tests/basic-operation.js: Added.
- platform/gtk/Skipped:
2010-07-30 Steve Block <steveblock@google.com>
Reviewed by Steve Block.
Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589
This patch does not hook up the new LayoutTestController method to WebKit
for any platform. This will be done in later patches.
https://bugs.webkit.org/show_bug.cgi?id=43181 tracks this for Mac.
Test: fast/dom/DeviceOrientation/basic-operation.html
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DeviceOrientationClient.h: (WebCore::DeviceOrientationClient::~DeviceOrientationClient):
- dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::DeviceOrientationController):
- dom/DeviceOrientationEvent.cpp:
- platform/mock/DeviceOrientationClientMock.cpp: Added. (WebCore::DeviceOrientationClientMock::DeviceOrientationClientMock): (WebCore::DeviceOrientationClientMock::setController): (WebCore::DeviceOrientationClientMock::startUpdating): (WebCore::DeviceOrientationClientMock::stopUpdating): (WebCore::DeviceOrientationClientMock::setOrientation): (WebCore::DeviceOrientationClientMock::timerFired):
- platform/mock/DeviceOrientationClientMock.h: Added. (WebCore::DeviceOrientationClientMock::lastOrientation):
2010-07-30 Steve Block <steveblock@google.com>
Reviewed by Steve Block.
Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589
- DumpRenderTree/LayoutTestController.cpp: (setMockDeviceOrientationCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockDeviceOrientation):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockDeviceOrientation):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockDeviceOrientation):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockDeviceOrientation):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockDeviceOrientation):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockDeviceOrientation):
- Scripts/build-webkit:
- 6:47 AM Changeset in webkit [64355] by
-
- 4 edits in trunk/WebKit2
2010-07-30 Balazs Kelemen <kb@inf.u-szeged.hu>
Unreviewed build fix.
[Qt] Build fix for recent API changes in WebKit2.
- UIProcess/API/cpp/qt/WKStringQt.cpp: (WKStringCopyQString):
- UIProcess/API/cpp/qt/WKURLQt.cpp: (WKURLCopyQUrl):
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- 6:31 AM Changeset in webkit [64354] by
-
- 3 edits in trunk/WebKitTools
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
https://bugs.webkit.org/show_bug.cgi?id=43209
When -resizes-to-content was being passed as a command line parameter it was simply
not being set (although the corresponding menu item was marked as ON).
User had to toggle the menu OFF and then ON again for it to take place.
Reason: LauncherWindow::applyPrefs method sets many user options passed in from
the command line, but not resizesToContents. Patch addresses that.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::applyPrefs): (LauncherWindow::toggleResizesToContents):
- QtTestBrowser/webview.h: (WebViewGraphicsBased::resizesToContents):
- 6:31 AM Changeset in webkit [64353] by
-
- 3 edits in trunk/WebKitTools
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Simon Fraser.
[Qt] QtTestBrowser: more method grouping and clean ups.
Moving blocks of code around. Basically grouping related methods close to each.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::changeViewportUpdateMode): (LauncherWindow::showFPS): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow):
- QtTestBrowser/launcherwindow.h:
- 6:19 AM Changeset in webkit [64352] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-30 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add a check for WebViewClient being null.
https://bugs.webkit.org/show_bug.cgi?id=43240
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::SpeechInputClientImpl):
- 5:21 AM Changeset in webkit [64351] by
-
- 7 edits2 adds in trunk/WebCore
2010-07-30 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add a mock in WebCore for testing speech input
https://bugs.webkit.org/show_bug.cgi?id=42603
Layout tests will be added in a subsequent patch using this mock.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/mock/SpeechInputClientMock.cpp: Added. (WebCore::SpeechInputClientMock::SpeechInputClientMock): (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::stopRecording): (WebCore::SpeechInputClientMock::cancelRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h: Added.
- 4:43 AM Changeset in webkit [64350] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-30 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Disable runtime switch for device orientation in chromium
https://bugs.webkit.org/show_bug.cgi?id=43237
Explicitly set the runtime switch for device orientation
in WebView::create until we implement the feature.
If the flag is accidentally on while no DeviceOrientationClient
is provided, the program will crash.
- src/WebViewImpl.cpp: (WebKit::WebView::create):
- 4:32 AM Changeset in webkit [64349] by
-
- 2 edits in trunk/WebKitTools
2010-07-30 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Tor Arne Vestbø.
[QT][Symbian] QtTestBrowser missing location capabilities
https://bugs.webkit.org/show_bug.cgi?id=43235
QtTestBrowser missing capabilities to use QtMobility::QLocation.
- QtTestBrowser/QtTestBrowser.pro:
- 4:18 AM Changeset in webkit [64348] by
-
- 2 edits in trunk/WebKitSite
2010-07-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Update SVG implementation status.
- projects/svg/status.xml:
- 4:10 AM Changeset in webkit [64347] by
-
- 17 edits in trunk/LayoutTests
2010-07-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
svg/dynamic-updates: cursor attribute changes not respected
https://bugs.webkit.org/show_bug.cgi?id=42615
Turns out the tests were wrong, specifying a hot spot which is too large.
Switched to a larger cursor image to make the changes easier to detect, when using the browser.
All svg/dynamic-updates tests work again, without regressions.
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
- svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
- svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
- svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt:
- svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt:
- svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js:
- svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js:
- svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js:
- svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js:
- 4:10 AM Changeset in webkit [64346] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-30 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Simon Hausmann.
[QT] build fix for symbian
https://bugs.webkit.org/show_bug.cgi?id=43234
- wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
- 4:02 AM Changeset in webkit [64345] by
-
- 3 edits in trunk/WebCore
2010-07-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Optimize SVGResources memory usage
https://bugs.webkit.org/show_bug.cgi?id=43236
Instead of storing pointers to all possible resources that could be applied to an element, group them in three categories:
clipper/filter/masker, marker-start/marker-mid/marker-end, and fill/stroke.
Only build the cached resources data for elements where the properties can be applied to. Maintain a static list of tagnames
for each of the three categories, to avoid doing unncessary work.
Doesn't affect any tests.
- rendering/SVGResources.cpp: (WebCore::SVGResources::SVGResources): (WebCore::clipperFilterMaskerTags): (WebCore::markerTags): (WebCore::fillAndStrokeTags): (WebCore::SVGResources::buildCachedResources): (WebCore::SVGResources::invalidateClient): (WebCore::SVGResources::resourceDestroyed): (WebCore::SVGResources::buildSetOfResources): (WebCore::SVGResources::setClipper): (WebCore::SVGResources::resetClipper): (WebCore::SVGResources::setFilter): (WebCore::SVGResources::resetFilter): (WebCore::SVGResources::setMarkerStart): (WebCore::SVGResources::resetMarkerStart): (WebCore::SVGResources::setMarkerMid): (WebCore::SVGResources::resetMarkerMid): (WebCore::SVGResources::setMarkerEnd): (WebCore::SVGResources::resetMarkerEnd): (WebCore::SVGResources::setMasker): (WebCore::SVGResources::resetMasker): (WebCore::SVGResources::setFill): (WebCore::SVGResources::resetFill): (WebCore::SVGResources::setStroke): (WebCore::SVGResources::resetStroke): (WebCore::SVGResources::dump):
- rendering/SVGResources.h: (WebCore::SVGResources::clipper): (WebCore::SVGResources::filter): (WebCore::SVGResources::markerStart): (WebCore::SVGResources::markerMid): (WebCore::SVGResources::markerEnd): (WebCore::SVGResources::masker): (WebCore::SVGResources::fill): (WebCore::SVGResources::stroke): (WebCore::SVGResources::ClipperFilterMaskerData::ClipperFilterMaskerData): (WebCore::SVGResources::ClipperFilterMaskerData::create): (WebCore::SVGResources::MarkerData::MarkerData): (WebCore::SVGResources::MarkerData::create): (WebCore::SVGResources::FillStrokeData::FillStrokeData): (WebCore::SVGResources::FillStrokeData::create):
- 3:48 AM Changeset in webkit [64344] by
-
- 30 edits13 moves in trunk
2010-07-26 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IndexedDatabase should be called IDBFactory.
https://bugs.webkit.org/show_bug.cgi?id=42967
Rename IndexedDatabase to IDBFactory to match the specification.
Also implement the following new naming convention:
IDBFoo IDL interfaces are implemented using IDBFoo C++ classes.
IDBFoo objects have pointers to IDBFooBackendInterface objects.
IDBFooBackendInterface is implemented by IDBFooBackendImpl and
IDBFooBackendProxy (for Chromium).
No new tests needed, just renaming.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::indexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/PageGroup.cpp: (WebCore::PageGroup::idbFactory):
- page/PageGroup.h:
- platform/chromium/ChromiumBridge.h:
- storage/IDBAny.cpp: (WebCore::IDBAny::idbFactory): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBDatabaseRequest.cpp:
- storage/IDBFactory.cpp: Added. (WebCore::IDBFactory::IDBFactory): (WebCore::IDBFactory::~IDBFactory): (WebCore::IDBFactory::open):
- storage/IDBFactory.h: Added. (WebCore::IDBFactory::create):
- storage/IDBFactory.idl: Added.
- storage/IDBFactoryBackendInterface.cpp: Added. (WebCore::IDBFactoryBackendInterface::create):
- storage/IDBFactoryBackendInterface.h: Added. (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
- storage/IDBFactoryBackendImpl.cpp: Added. (WebCore::IDBFactoryBackendImpl::create): (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::~IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBFactoryBackendImpl.h: Added.
- storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::only): (WebCore::IDBKeyRange::leftBound): (WebCore::IDBKeyRange::rightBound): (WebCore::IDBKeyRange::bound):
- storage/IDBKeyRange.h:
- storage/IDBKeyRange.idl:
- storage/IndexedDatabase.cpp: Removed.
- storage/IndexedDatabase.h: Removed.
- storage/IndexedDatabaseImpl.cpp: Removed.
- storage/IndexedDatabaseImpl.h: Removed.
- storage/IndexedDatabaseRequest.cpp: Removed.
- storage/IndexedDatabaseRequest.h: Removed.
- storage/IndexedDatabaseRequest.idl: Removed.
- storage/chromium/IDBFactoryBackendInterface.cpp: Added. (WebCore::IDBFactoryBackendInterface::create):
- storage/chromium/IndexedDatabase.cpp: Removed.
2010-07-26 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IndexedDatabase should be called IDBFactory.
https://bugs.webkit.org/show_bug.cgi?id=42967
- WebKit.gyp:
- public/WebIDBFactory.h: Added. (WebKit::WebIDBFactory::~WebIDBFactory): (WebKit::WebIDBFactory::databases): (WebKit::WebIDBFactory::open):
- public/WebIndexedDatabase.h: Removed.
- public/WebKitClient.h: (WebKit::WebKitClient::idbFactory):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::idbFactory):
- src/IDBFactoryBackendProxy.cpp: Added. (WebCore::IDBFactoryBackendProxy::create): (WebCore::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebCore::IDBFactoryBackendProxy::~IDBFactoryBackendProxy): (WebCore::IDBFactoryBackendProxy::open):
- src/IDBFactoryBackendProxy.h: Added.
- src/IndexedDatabaseProxy.cpp: Removed.
- src/IndexedDatabaseProxy.h: Removed.
- src/WebIDBFactoryImpl.cpp: Added. (WebKit::WebIDBFactory::create): (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::~WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open):
- src/WebIDBFactoryImpl.h: Added.
- src/WebIndexedDatabaseImpl.cpp: Removed.
- src/WebIndexedDatabaseImpl.h: Removed.
- 3:12 AM Changeset in webkit [64343] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt:
- 2:48 AM Changeset in webkit [64342] by
-
- 5 edits in trunk/LayoutTests
2010-07-30 Jeremy Orlow <jorlow@chromium.org>
Another svg baseline that was wrong and now visually matches mac (minus
font issues, of course). Unreviewed.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- 1:44 AM Changeset in webkit [64341] by
-
- 3 edits in trunk/WebCore
2010-07-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Crash on refresh with a comment selected in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=43183
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeForPath):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
- 1:22 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 1:17 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 1:15 AM QtWebKit edited by
- (diff)
- 1:14 AM QtWebKit edited by
- (diff)
- 1:13 AM QtWebKit edited by
- (diff)
- 12:49 AM Changeset in webkit [64340] by
-
- 7 edits in trunk
2010-07-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Update expectation for turbulence filter:
svg/W3C-SVG-1.1/filters-turb-01-f.svg
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
2010-07-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
feTurbulence is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=5864
This code is based on the previous implementation of
Dirk Schulze, extended with some modification and optimization.
LayoutTests: Updating expected values for turbulence filter.
svg/W3C-SVG-1.1/filters-turb-01-f.svg
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::FETurbulence): (WebCore::FETurbulence::create): (WebCore::FETurbulence::PaintingData::PaintingData): (WebCore::FETurbulence::PaintingData::random): (WebCore::smoothCurve): (WebCore::linearInterpolation): (WebCore::FETurbulence::initPaint): (WebCore::checkNoise): (WebCore::FETurbulence::noise2D): (WebCore::Noise::if): (WebCore::FETurbulence::calculateTurbulenceValueForPoint): (WebCore::FETurbulence::apply):
- svg/graphics/filters/SVGFETurbulence.h: (WebCore::):
