⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 3, 2010:

11:52 PM Changeset in webkit [64631] by ap@apple.com
  • 7 edits in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=42939
WebEditorClient::didBeginEditing is never called in WebKit2

  • page/FocusController.cpp: (WebCore::FocusController::setFocused): Focusing a page without a focused frame makes little sense, so WebKit used to focus a frame first when its view became first responder. For viewless frames, WebKit cannot know what to focus. The assumption here is that in all cases with null m_focusedFrame, it's the main frame that needs to be focused.
10:57 PM Changeset in webkit [64630] by eric@webkit.org
  • 1 edit in trunk/ChangeLog

2010-08-03 Eric Seidel <​eric@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

10:09 PM Changeset in webkit [64629] by dbates@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-03 Daniel Bates <​dbates@rim.com>

Fix misspelled word 'teh' in the description of the XSS Auditor setting.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
10:07 PM Changeset in webkit [64628] by eric@webkit.org
  • 3 edits in trunk/WebKit2

2010-08-03 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Close the WebProcess

​https://bugs.webkit.org/show_bug.cgi?id=41690

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::open): Registered connectionDidClose to be called when the client disconnected.
  • Platform/qt/RunLoopQt.cpp: (RunLoop::stop): Implemented by calling QCoreApplication::exit.
9:37 PM Changeset in webkit [64627] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative windows build fix.

  • wtf/Bitmap.h:
9:25 PM Changeset in webkit [64626] by barraclough@apple.com
  • 5 edits
    2 adds in trunk

Build fix following r64624.

JavaScriptCore:

JavaScriptGlue:

  • ForwardingHeaders/wtf/BitMap.h: Added.

WebCore:

  • ForwardingHeaders/wtf/BitMap.h: Added.
8:58 PM Changeset in webkit [64625] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations fixup for origin-quota.html.

  • platform/chromium/test_expectations.txt:
8:27 PM Changeset in webkit [64624] by barraclough@apple.com
  • 10 edits
    2 adds
    1 delete in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=43269

Patch by Nathan Lawrence <​nlawrence@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.

Added new allocateAligned methods to PageAllocation. In order to
prevent a regress in performance, the function needs to be inlined.

Additionally, I ported the symbian block allocator to use
PageAllocation and added a new WTF::Bitmap class to support this.

(JSC::AlignedMemory::deallocate):
(JSC::AlignedMemory::base):
(JSC::AlignedMemory::AlignedMemory):
(JSC::AlignedMemoryAllocator::destroy):
(JSC::AlignedMemoryAllocator::allocate):
(JSC::AlignedMemoryAllocator::AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::~AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::free):

  • runtime/Collector.cpp:

(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::allocate):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):

  • runtime/Collector.h:

(JSC::CollectorHeap::collectorBlock):

  • runtime/CollectorHeapIterator.h:

(JSC::CollectorHeapIterator::operator*):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):

  • wtf/Bitmap.h: Added.

(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::advanceToNextFreeBit):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):

  • wtf/PageAllocation.h:

(WTF::PageAllocation::operator UnspecifiedBoolType):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::reserveAligned):

  • wtf/Platform.h:
  • wtf/symbian: Removed.
  • wtf/symbian/BlockAllocatorSymbian.cpp: Removed.
  • wtf/symbian/BlockAllocatorSymbian.h: Removed.
8:16 PM Changeset in webkit [64623] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations fixup to fix canary bot redness.

  • platform/chromium/test_expectations.txt:
8:07 PM Changeset in webkit [64622] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-03 Kent Tamura <​tkent@chromium.org>

Rubber-stamped by Eric Seidel.

Add an explanation comment to drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
8:06 PM Changeset in webkit [64621] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-08-03 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Edits to bridge documentation
​https://bugs.webkit.org/show_bug.cgi?id=43012

  • docs/qtwebkit-bridge.qdoc:
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
8:05 PM Changeset in webkit [64620] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=43314. The prior code
was using the wrong "length" value to move array contents when adding
space to the beginning of an array for an unshift() or similar
operation. Instead of using m_vectorLength, the length of the
allocated JSValue array, the code was using m_length, the declared
length of the array. These two values do not need to match.

Patch by Michael Saboff <​msaboff@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.

(JSC::JSArray::increaseVectorPrefixLength):

7:54 PM Changeset in webkit [64619] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix following ​https://bugs.webkit.org/show_bug.cgi?id=43089
(accidentally inverted a compiler version check).

Patch by Chao-ying Fu <​fu@mips.com> on 2010-08-03
Reviewed by Gavin Barraclough.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

7:32 PM Changeset in webkit [64618] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-03 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Gavin Barraclough.

Implement DEFINE_STUB_FUNCTION for WinCE.
​https://bugs.webkit.org/show_bug.cgi?id=34953

  • jit/JITStubs.cpp: (JSC::): (JSC::DEFINE_STUB_FUNCTION):
7:29 PM Changeset in webkit [64617] by Joseph Pecoraro
  • 5 edits in trunk/LayoutTests

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Skipping tests for a new feature not implemented on some platforms.
Follow-up bugs have been filed and are listed below.

7:07 PM Changeset in webkit [64616] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

<input type=number> UI: Support wheel events
​https://bugs.webkit.org/show_bug.cgi?id=42441

Reviewed by Ojan Vafai.

WebCore:

Test: fast/forms/input-number-wheel.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

Call stepUpFromRenderer() for wheelDeltaY.

LayoutTests:

  • fast/forms/input-number-wheel-expected.txt: Added.
  • fast/forms/input-number-wheel.html: Added.
  • fast/forms/script-tests/input-number-wheel.js: Added.
6:53 PM Changeset in webkit [64615] by tkent@chromium.org
  • 6 edits in trunk/WebKitTools

2010-08-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Implement --testshell-startup-dialog
​https://bugs.webkit.org/show_bug.cgi?id=40616

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Check --testshell-startup-dialog, and call openStartUpDialog() if it is specfied.
  • DumpRenderTree/chromium/TestShell.h: Declare openStartUpDialog().
  • DumpRenderTree/chromium/TestShellGtk.cpp: (openStartupDialog):
  • DumpRenderTree/chromium/TestShellMac.mm: (openStartupDialog):
  • DumpRenderTree/chromium/TestShellWin.cpp: (openStartupDialog):
6:51 PM Changeset in webkit [64614] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency of base/md5.h
​https://bugs.webkit.org/show_bug.cgi?id=43403

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): Use wtf/MD5.h
6:50 PM Changeset in webkit [64613] by Joseph Pecoraro
  • 19 edits
    8 adds in trunk

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

LayoutTests:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

Part 6 - LayoutTest and Cleanup

  • http/tests/appcache/origin-quota-expected.txt: Added.
  • http/tests/appcache/origin-quota.html: Added.
  • http/tests/appcache/resources/quota-origin-iframe-1.html: Added.
  • http/tests/appcache/resources/quota-origin-iframe-1.manifest: Added.
  • http/tests/appcache/resources/quota-origin-iframe-2.html: Added.
  • http/tests/appcache/resources/quota-origin-iframe-2.manifest: Added.
  • http/tests/appcache/resources/quota-origin-iframe-3.html: Added.
  • http/tests/appcache/resources/quota-origin-iframe-3.manifest: Added.

WebCore:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

Part 6 - LayoutTest and Cleanup

Test: http/tests/appcache/origin-quota.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::scheduleReachedOriginQuotaCallback): made synchronous, as asynchronously the cache group was deleted too soon.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin): all storing operations should force the database to be created if needed.

WebKit/mac:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Part 6 - LayoutTest and Cleanup

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches. (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

WebKitTools:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Part 6 - LayoutTest and Cleanup

Allow tests to delete application caches and set application cache
origin quotas, so they can be tested.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller. (clearAllApplicationCachesCallback): should delete all application caches. (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output. (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.

Mac implementation.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllApplicationCaches): delete application caches. (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix. (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.

Stub implementations for other platforms.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

6:50 PM Changeset in webkit [64612] by Joseph Pecoraro
  • 9 edits
    4 moves
    1 add in trunk

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

WebKit:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers

  • WebKit.xcodeproj/project.pbxproj: Add new Quota Managers, remove old SecurityOrigin subclasses.

WebKit/mac:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers

Per-Origin quotas exist for Databases and Application Caches. Clients
given a WebSecurityOrigin have the ability to set the quota for any
per-origin quota type. This puts quota management into an interface
and WebSecurityOrigin allows access to quota managers for the
different types of quotas.

This also deprecates the old methods on WebSecurityOrigin. They are
left in for now to prevent breaking older clients.

The WebQuotaManager interface allows querying and modifying a
per-origin quota. This is implemented for both Databases and
Application Caches.

  • Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
  • Storage/WebDatabaseQuotaManager.h: Added.
  • Storage/WebDatabaseQuotaManager.mm: Added. (-[WebDatabaseQuotaManager origin]): (-[WebDatabaseQuotaManager usage]): (-[WebDatabaseQuotaManager quota]): (-[WebDatabaseQuotaManager setQuota:]):
  • Storage/WebDatabaseSecurityOrigin.h: Removed.
  • Storage/WebDatabaseSecurityOrigin.mm: Removed.
  • WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
  • WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added. (-[WebApplicationCacheQuotaManager origin]): (-[WebApplicationCacheQuotaManager usage]): (-[WebApplicationCacheQuotaManager quota]): (-[WebApplicationCacheQuotaManager setQuota:]):
  • WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.

Remove the WebSecurityOrigin sub-classes. Managers are better.

  • WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
  • WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.

Create the managers lazily. Change old style calls to make use
of the managers.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): (WebChromeClient::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin applicationCacheQuotaManager]): (-[WebSecurityOrigin databaseQuotaManager]): (-[WebSecurityOrigin dealloc]): release the managers if they exist.

WebKitTools:

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
​https://bugs.webkit.org/show_bug.cgi?id=40627

Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers

Change old style calls to make use of the managers.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setDatabaseQuota):
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
6:29 PM Changeset in webkit [64611] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-03 Eric Seidel <​eric@webkit.org>

Unreviewed. Skipping test which fails on some Leopard installs.

http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
​https://bugs.webkit.org/show_bug.cgi?id=35271

Skip this failing test as the most expedient solution.

  • platform/mac-leopard/Skipped:
6:19 PM Changeset in webkit [64610] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-08-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

extractAndNegateTextDecorationStyle and maxRangeOffset in ApplyStyleCommand.cpp should be deleted
​https://bugs.webkit.org/show_bug.cgi?id=43437

Removed extractAndNegateTextDecorationStyle because we never push down text decorations added by CSS rules
as discussed on the bug 27809. Also removed pushDownTextDecorationStyleAtBoundaries because it only existed
to encapsulate the complexity of calling pushDownTextDecorationStyleAroundNode first with forceNegate = false
(calling pushDownTextDecorationStyleAroundNode) and again with forceNegate = true (calling extractAndNegateTextDecorationStyle)
after updating layout but neither the layout update nor the second call to pushDownTextDecorationStyleAroundNode
is needed after the removal of extractAndNegateTextDecorationStyle.

Also replaced maxRangeOffset by lastOffsetForEditing as FIXME (added by r48235) indicated.

No new tests added since this is a clean up.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): No longer takes forceNegate as an argument. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode directly.
  • editing/ApplyStyleCommand.h:
6:09 PM Changeset in webkit [64609] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Extract a function that serializes nodes from the range version of createMarkup
​https://bugs.webkit.org/show_bug.cgi?id=43405

Extracted serializeNodes that serializes nodes from createMarkup.
No new tests added since this is a clean up.

  • editing/markup.cpp: (WebCore::serializeNodes): Added. (WebCore::createMarkup): Calls serializeNodes.
5:15 PM Changeset in webkit [64608] by barraclough@apple.com
  • 24 edits in trunk/JavaScriptCore

Bug 43390 - Do not CRASH if we run out of room for jit code.

Reviewed by Oliver Hunt.

Change the ExecutableAllocator implementations not to crash, and to return 0 if memory cannot be allocated.
The assemblers should pass this through without trying to use it in executableCopy.
Change the LinkBuffer to handle this, and to provide an allocationSuccessful() method to test for this.

Change the JIT to throw an exception if allocation fails.
Make JIT optimizations fail gracefully if memory cannot be allocated (use non-optimized path).
Change YARR JIT to fallback to PCRE

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::executableCopy):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::allocationSuccessful):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::executableCopy):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::executableCopy):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::allocInternal):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compilePatchGetArrayLength):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::setupPolymorphicProtoList):

  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • runtime/ExceptionHelpers.cpp:

(JSC::createOutOfMemoryError):

  • runtime/ExceptionHelpers.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::compile):

4:44 PM Changeset in webkit [64607] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fix the build by adding the needed MathML source files to WebCore's vcproj.
Also, Visual Studio did some drive-by resorting of the vcproj, the added
MathML files are the only important change.

  • WebCore.vcproj/WebCore.vcproj:
4:36 PM Changeset in webkit [64606] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add a new Leopard build slave to run the release tests.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:26 PM Changeset in webkit [64605] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-08-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Nate Chapin.

Web Inspector: Missing ApplicationCache InspectorBackend Stub
​https://bugs.webkit.org/show_bug.cgi?id=43265

Registered "getApplicationCaches".

  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
4:09 PM Changeset in webkit [64604] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Fix the Windows build by adding WebCore/mathml to the list of paths to look for header
files.

  • WebCore.vcproj/WebCoreCommon.vsprops:
3:56 PM Changeset in webkit [64603] by jhoneycutt@apple.com
  • 9 edits in trunk

WebKitTestRunner needs to activate the Mac font ascent hack
​https://bugs.webkit.org/show_bug.cgi?id=43404

Reviewed by Darin Adler.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleActivateMacFontAscentHack):
Get the InjectedBundle, and calls its activateMacFontAscentHack().

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Declare WKBundleActivateMacFontAscentHack().

  • WebProcess/InjectedBundle/InjectedBundle.h:

Declare activateMacFontAscentHack().

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack):
Activate the ascent hack.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
Call WKBundleActivateMacFontAscentHack().

3:55 PM Changeset in webkit [64602] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Fixed a crash seen on the GTK 64bit buildbot.

Reviewed by Oliver Hunt.

When JSArray is allocated for the vptr stealing hack, it's not allocated
in the heap, so the JSArray constructor can't safely call Heap::heap().

Since this was subtle enough to confuse smart people, I've changed JSArray
to have an explicit vptr stealing constructor.

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:

(JSC::JSArray::):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

3:55 PM Changeset in webkit [64601] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

WebKitTestRunner needs to support loading custom fonts (via the
WEBKIT_TESTFONTS environment variable)
​https://bugs.webkit.org/show_bug.cgi?id=42782

Reviewed by Adam Roben.

  • WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:

(WTR::fontsPath):
Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
as this directory doesn't appear to be created anymore.
(WTR::activateFonts):
Loop through the fonts, and call AddFontResourceExW() for each.

3:54 PM Changeset in webkit [64600] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the i386 build with a static_cast hammer.

  • mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::layout):

3:50 PM Changeset in webkit [64599] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-08-03 Simon Fraser <Simon Fraser>

Fix typo in typo fix.

  • Shared/DrawingAreaBase.h: (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase):
3:49 PM Changeset in webkit [64598] by mrowe@apple.com
  • 1 edit
    5 deletes in trunk/ANGLE

Remove some unnecessary files from the ANGLE tree.

Rubber-stamped by Adele Peterson.

  • src/compiler/tools/COPYING.bison: Removed.
  • src/compiler/tools/COPYING.flex: Removed.
  • src/compiler/tools/README: Removed.
  • src/compiler/tools/bison.hairy: Removed.
  • src/compiler/tools/bison.simple: Removed.
3:49 PM Changeset in webkit [64597] by mrowe@apple.com
  • 2 edits
    4 adds in trunk/ANGLE

Clean up the ANGLE Xcode project.

Rubber-stamped by Adele Peterson.

Main changes include:

  • Adding a Production configuration.
  • Modifying the library name from libangle.a to libANGLE.a.
  • Installing the headers in a subdirectory of /usr/local/include to avoid polluting the top-level directory.
  • Generating derived sources in to the built products directory so they're saved along with the symroot.
  • Switching to using .xcconfig files for maximum cleanliness.
  • ANGLE.xcodeproj/project.pbxproj:
  • Configurations/ANGLE.xcconfig: Added.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
3:42 PM Changeset in webkit [64596] by Beth Dakin
  • 5 edits in trunk/WebCore

Speculative build fix for Leopard.

  • mathml/RenderMathMLOperator.cpp:
  • mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):

  • mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):

  • mathml/RenderMathMLSubSup.cpp:
3:33 PM Changeset in webkit [64595] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-08-03 Simon Fraser <Simon Fraser>

Fix typo in previous commit.

  • Shared/DrawingAreaBase.h: (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase):
3:30 PM Changeset in webkit [64594] by Simon Fraser
  • 21 edits
    2 copies in trunk

2010-08-03 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Compositing iframe layout test crashes in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42860

Fix assertion caused by a DrawingArea handling a message that was targetted at an older DrawingArea
that it has replaced.

This was done by assigning a unique ID to each DrawingAreaProxy that gets created, and passing
this ID, along with the type, to the WebProcess via an encoded DrawingAreaInfo. Each message
also includes this ID. Messages with an ID that doesn't match that of the current DrawingArea are ignored.

Refactored some common code and data into a DrawingAreaBase class which is shared, and adding
encode/decode of DrawingAreaInfo.

  • Shared/DrawingAreaBase.cpp: Added. (WebKit::DrawingAreaBase::encode): (WebKit::DrawingAreaBase::decode):
  • Shared/DrawingAreaBase.h: Added. (WebKit::DrawingAreaBase::): (WebKit::DrawingAreaBase::~DrawingAreaBase): (WebKit::DrawingAreaBase::type): (WebKit::DrawingAreaBase::id): (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase): (CoreIPC::):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setSize): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update):
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy): (WebKit::DrawingAreaProxy::nextDrawingAreaID):
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::create): (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h:
  • win/WebKit2.vcproj:
3:29 PM Changeset in webkit [64593] by Beth Dakin
  • 2 edits in trunk/WebKitLibraries

Enable MathML on Windows.

Reviewed by Alice Liu.

  • win/tools/vsprops/FeatureDefines.vsprops:
3:11 PM Changeset in webkit [64592] by Beth Dakin
  • 2 edits in trunk/WebCore

Speculative build fix.

  • css/mathml.css:

(mi):
(math[mathsize="small"], mstyle[mathsize="small"], mo[mathsize="small"], mn[mathsize="small"], mi[mathsize="small"], mtext[mathsize="small"], mspace[mathsize="small"], ms[mathsize="small"]):
(math[mathsize="normal"], mstyle[mathsize="normal"], mo[mathsize="normal"], mn[mathsize="normal"], mi[mathsize="normal"], mtext[mathsize="normal"], mspace[mathsize="normal"], ms[mathsize="normal"]):
(math[mathsize="big"], mstyle[mathsize="big"], mo[mathsize="big"], mn[mathsize="big"], mi[mathsize="big"], mtext[mathsize="big"], mspace[mathsize="big"], ms[mathsize="big"]):

3:04 PM Changeset in webkit [64591] by ggaren@apple.com
  • 4 edits in trunk

2010-08-03 Alex Milowski <​alex@milowski.com>

Reviewed by Beth Dakin.

Changed the ENABLE_MATHML value to enable MathML by default.

  • Configurations/FeatureDefines.xcconfig:

2010-08-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=43444
PLATFORM(CF) is false on Windows in JavaScriptCore

Moved some PLATFORM(WIN) #defines down into JavaScriptCore.

  • config.h: Moved WTF_PLATFORM_CF 1 and WTF_USE_PTHREADS 0 to wtf/Platform.h. Removed #undef WTF_USE_WININET because wtf/Platform.h no longer #defines it.
2:57 PM Changeset in webkit [64590] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-03 Dimitri Glazkov <Dimitri Glazkov>

Removed duplicate expectations from the DRT overrides.

  • platform/chromium/drt_expectations.txt: Removed special-key-events-in-input-text.html.
2:40 PM Writing DumpAsMarkup Tests edited by rniwa@webkit.org
Updated "Dump Multiple Times" to match the recent changes (diff)
2:35 PM Changeset in webkit [64589] by Beth Dakin
  • 11 edits in trunk

JavaScriptCore: Changed the ENABLE_MATHML value to enable MathML by default.

Patch by Alex Milowski <​alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.

  • Configurations/FeatureDefines.xcconfig:

WebCore: Changed the ENABLE_MATHML value to enable MathML by default.

Patch by Alex Milowski <​alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac: Changed the ENABLE_MATHML value to enable MathML by default.

Patch by Alex Milowski <​alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.

  • Configurations/FeatureDefines.xcconfig:

WebKit2: Changed the ENABLE_MATHML value to enable MathML by default.

Patch by Alex Milowski <​alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.

  • Configurations/FeatureDefines.xcconfig:

WebKitTools: Changed the default for MathML support so that is is enabled by default.

Patch by Alex Milowski <​alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.

  • Scripts/build-webkit:
2:34 PM Writing DumpAsMarkup Tests edited by rniwa@webkit.org
Updated "Output Subtree" to match the recent changes (diff)
2:29 PM Writing DumpAsMarkup Tests edited by rniwa@webkit.org
Updated "How to Use" to match the recent changes (diff)
2:29 PM Changeset in webkit [64588] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Change to keep returned pointer from malloc family functions to
quiet memory leak detect. The pointer is saved in the new m_allocBase
member of the ArrayStorage structure. This fixes the issue found in
​https://bugs.webkit.org/show_bug.cgi?id=43229.

Patch by Michael Saboff <​msaboff@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.

As part of this change, we use m_allocBase when reallocating and
freeing the memory associated with ArrayStorage.

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):

  • runtime/JSArray.h:
2:01 PM Changeset in webkit [64587] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Try to fix Windows build: Don't use GCActivityCallbackCF on Windows, since
PLATFORM(CF) is not defined on Windows.

We'll need to enable the GC activity callback some other way, but this
change should get the build back to normal.

  • runtime/GCActivityCallbackCF.cpp: Make it easier to detect this error

in the future with an explicit error message.

1:42 PM Changeset in webkit [64586] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build: update .def file.

1:34 PM Changeset in webkit [64585] by ggaren@apple.com
  • 12 edits
    3 adds in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=41318
GC should reclaim garbage even when new objects are not being allocated rapidly

Patch by Nathan Lawrence <​nlawrence@apple.com> on 2010-08-03
Reviewed by Oliver Hunt.

Added a callback in JavaScriptCore that gets triggered after an
allocation causes the heap to reset. This is useful for adding a
timer that will trigger garbage collection after the "last" allocation.

Also needed was to add lock and unlock methods to JSLock that needed
only a JSGlobalData object versus an ExecState object.

(JSC::JIT::emit_op_put_by_val):

  • runtime/Collector.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reset):
(JSC::Heap::setActivityCallback):

  • runtime/Collector.h:
  • runtime/GCActivityCallback.cpp: Added.

(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()):

  • runtime/GCActivityCallback.h: Added.

(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::operator()):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC::DefaultGCActivityCallback::create):

  • runtime/GCActivityCallbackCF.cpp: Added.

(JSC::DefaultGCActivityCallbackPlatformData::trigger):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()):

  • runtime/JSLock.cpp:

(JSC::JSLock::JSLock):

  • runtime/JSLock.h:
1:23 PM Changeset in webkit [64584] by senorblanco@chromium.org
  • 10 edits in trunk/WebCore

2010-07-30 Stephen White <​senorblanco@chromium.org>

Reviewed by Ojan Vafai.

Move PlatformContextSkia and NativeImageSkia into the WebCore namespace.
​https://bugs.webkit.org/show_bug.cgi?id=43272

One wrinkle is that PlatformContext and NativeImagePtr are
typedef'ed outside outside the WebCore namespace block, so the
PlatformContextSkia and NativeImageSkia have to be forward-declared
explicitly within that namespace. Another solution might be to move
those declarations into the WebCore namespace block below, but that
would affect platforms other than Skia, so I leave it to the reviewer
to decide.

Test: if it compiles, you're happy.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::hasResizedBitmap): (WebCore::NativeImageSkia::shouldCacheResampling):
  • platform/graphics/skia/NativeImageSkia.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::beginLayerClippedToImage): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setupPaintForStroking): (WebCore::PlatformContextSkia::getStrokeStyle): (WebCore::PlatformContextSkia::setStrokeStyle): (WebCore::PlatformContextSkia::setTextDrawingMode): (WebCore::PlatformContextSkia::interpolationQuality): (WebCore::PlatformContextSkia::setInterpolationQuality): (WebCore::PlatformContextSkia::getImageResamplingHint): (WebCore::PlatformContextSkia::setImageResamplingHint): (WebCore::PlatformContextSkia::clearImageResamplingHint): (WebCore::PlatformContextSkia::applyClipFromImage): (WebCore::PlatformContextSkia::setGLES2Context): (WebCore::PlatformContextSkia::prepareForSoftwareDraw): (WebCore::PlatformContextSkia::prepareForHardwareDraw): (WebCore::PlatformContextSkia::syncSoftwareCanvas): (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::paintSkiaText):
  • platform/graphics/skia/SkiaFontWin.h:
1:04 PM Changeset in webkit [64583] by Adam Roben
  • 2 edits
    1 move in trunk/WebCore

Rename LocalizedStringsMac.mm to LocalizedStrings.cpp

LocalizedStringsMac.mm should be usable by other ports
​https://bugs.webkit.org/show_bug.cgi?id=43441

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj: Updated the file's name and path.
  • platform/LocalizedStrings.cpp: Renamed from

WebCore/platform/mac/LocalizedStringsMac.mm. Changed #imports to

12:47 PM Changeset in webkit [64582] by jamesr@google.com
  • 10 edits in trunk

2010-08-03 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
​https://bugs.webkit.org/show_bug.cgi?id=43221

Implements functions in term of Platform3DObjects instead of WebGL types.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::shaderSource):

2010-08-03 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
​https://bugs.webkit.org/show_bug.cgi?id=43221

Changes the GraphicsContext3D API to use Platform3DObjects instead of WebGLFoo* types like WebGLTexture.
WebGLRenderingContext still uses WebGLFoo types and converts to Platform3DObjects internally. Other
consumers of the GraphicsContext3D can use the Platform3DObject APIs directly without any ties to WebGL.

The majority of this change is purely mechanical. The less obvious changes are:

  • move all null checking on WebGLFoo types to WebGLRenderingContext, instead of mixing them between WebGLRenderingContext and the various port-specific implementations of GraphicsContext3D
  • add a GraphicsContext3D getter to CanvasRenderingContext. This is needed for the readback path on Chromium/mac. It may be possible to remove this, but I would prefer to do that in a follow-up patch to minimize churn.
  • move some texture cube map logic that existed only in the Chromium port of GC3D to WebGLRenderingContext behind #if PLATFORM(CHROMIUM). I think this logic should either exist for all ports or exist for none, but again I would rather change the behavior in a different patch from this one.
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::graphicsContext3D):
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::handleNPOTTextures): (WebCore::WebGLRenderingContext::createFallbackBlackTextures1x1): (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0): (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::graphicsContext3D):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation):
12:45 PM Changeset in webkit [64581] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • platform/mac-snowleopard/Skipped: Added bug number.
12:41 PM Changeset in webkit [64580] by xan@webkit.org
  • 10 edits
    1 add in trunk

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Fix DOM event dispatch
​https://bugs.webkit.org/show_bug.cgi?id=40847

Add new files to the build.

  • GNUmakefile.am:

WebCore:

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Fix DOM event dispatch
​https://bugs.webkit.org/show_bug.cgi?id=40847

Bind UI and Mouse events and add ad-hoc kit method for WebCore
Events.

  • GNUmakefile.am:
  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::kit):
  • bindings/gobject/WebKitDOMBinding.h:
  • bindings/gobject/WebKitDOMEventTarget.cpp: (WebKit::core):
  • bindings/gobject/WebKitDOMEventTargetPrivate.h: Added.
  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Fix DOM event dispatch
​https://bugs.webkit.org/show_bug.cgi?id=40847

Test DOM event dispatch.

  • tests/testdomdomwindow.c: (load_event_callback): (test_dom_domview_signals): (clicked_cb): (load_status_callback): (test_dom_domview_dispatch_event): (main):
12:39 PM Changeset in webkit [64579] by Nikolas Zimmermann
  • 480 edits in trunk/WebCore

2010-08-03 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Cleanup all of svg/ code
​https://bugs.webkit.org/show_bug.cgi?id=43311

Unify the license header in all files in svg/, to use the same template as most WebCore files use.
Unified email adress style, etc. all generated with a perl script attached to bug 43311.

  • svg/...: Updated header template in all files, in the svg/ subdirectory.
12:31 PM Changeset in webkit [64578] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-08-03 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Roll chromium to 54723 to unbreak the builds.

  • DEPS:
12:20 PM Changeset in webkit [64577] by andreip@google.com
  • 37 edits
    1 copy
    4 moves
    1 delete in trunk

2010-08-03 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IDBObjectStoreRequest should be called IDBObjectStore
​https://bugs.webkit.org/show_bug.cgi?id=43420

Renaming IDBObjectStoreRequest to IDBObjectStore.

No new tests needed, just refactoring.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbObjectStore): (WebCore::IDBAny::set):
  • storage/IDBAny.h: (WebCore::IDBAny::):
  • storage/IDBCallbacks.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::objectStore):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBObjectStore.cpp: Added. (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::name): (WebCore::IDBObjectStore::keyPath): (WebCore::IDBObjectStore::indexNames): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create): (WebCore::IDBObjectStore::~IDBObjectStore):
  • storage/IDBObjectStore.idl: Added.
  • storage/IDBObjectStoreBackendImpl.cpp: Added. (WebCore::IDBObjectStoreBackendImpl::~IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::indexNames): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex):
  • storage/IDBObjectStoreBackendImpl.h: Added. (WebCore::IDBObjectStoreBackendImpl::create): (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath):
  • storage/IDBObjectStoreBackendInterface.h: Added. (WebCore::IDBObjectStoreBackendInterface::~IDBObjectStoreBackendInterface):
  • storage/IDBObjectStoreImpl.cpp: Removed.
  • storage/IDBObjectStoreImpl.h: Removed.
  • storage/IDBObjectStoreRequest.cpp: Removed.
  • storage/IDBObjectStoreRequest.h: Removed.
  • storage/IDBObjectStoreRequest.idl: Removed.
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
  • storage/IDBRequest.h:

2010-08-03 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IDBObjectStoreRequest should be called IDBObjectStore
​https://bugs.webkit.org/show_bug.cgi?id=43420

  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::objectStore):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::create):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl):
  • src/WebIDBObjectStoreImpl.h:
12:18 PM Changeset in webkit [64576] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKitTools

Roll r64566 back in this time with all the overloads in place..

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::shouldInsertNode):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/StringFunctions.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
12:17 PM Changeset in webkit [64575] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • platform/mac-snowleopard/Skipped: Skip remove-property test that Anders added while

working on WebKit2. Unknown why it's failing on SnowLeopard at this time. We could have
added SnowLeopard-specific results instead, but for now we decided skipping was easier.

Reviewed by Anders Carlsson.

12:11 PM Changeset in webkit [64574] by weinig@apple.com
  • 5 edits
    1 delete in trunk/WebKitTools

Rollout r64566. It broke all the WebKit2 tests.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::operator<<):
(WTR::InjectedBundlePage::shouldInsertNode):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/StringFunctions.h: Removed.
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::createWKURL):
(WTR::WKStringToUTF8):
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
11:56 AM Changeset in webkit [64573] by Martin Robinson
  • 4 edits in trunk

2010-08-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Ojan Vafai.

[GTK] Incorrect keyIdentifier for print screen key events
​https://bugs.webkit.org/show_bug.cgi?id=43422

Unskip a test which is now passing.

  • platform/gtk/Skipped:

2010-08-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Ojan Vafai.

[GTK] Incorrect keyIdentifier for print screen key events
​https://bugs.webkit.org/show_bug.cgi?id=43422

Produce the correct keyIdentifier for GDK_Print (print screen).

  • platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
11:44 AM Changeset in webkit [64572] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-08-03 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

[v8] Get current memory usage and make it available on stack before crashing due to out of memory
​https://bugs.webkit.org/show_bug.cgi?id=43426

That should allow us to diagnose the cases when the process just ran out of memory
and hence V8 failed to allocate more OS pages.

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
11:28 AM Changeset in webkit [64571] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-08-03 Jorge González <​aloriel@gmail.com>

Reviewed by Gustavo Noronha.

Spanish translation update.

  • es.po: Updated.
11:18 AM Changeset in webkit [64570] by leandro@webkit.org
  • 5 edits
    7 adds in trunk

2010-08-03 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Implement HTML5 slider theme (using the scrollbar theme as base).
​https://bugs.webkit.org/show_bug.cgi?id=43430

  • DefaultTheme/default.edc: Include slider.edc.
  • DefaultTheme/widget/slider/slider.edc: Added.
  • DefaultTheme/widget/slider/slider_h.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png.
  • DefaultTheme/widget/slider/slider_hilight.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_hilight.png.
  • DefaultTheme/widget/slider/slider_knob_h.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png.
  • DefaultTheme/widget/slider/slider_knob_v.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png.
  • DefaultTheme/widget/slider/slider_v.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png.

2010-08-03 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement HTML5 slider theme (using the scrollbar theme as base).
​https://bugs.webkit.org/show_bug.cgi?id=43430

EFL port does not yet support automated tests.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::edjeGroupFromFormType): Add Edje groups for both vertical and horizontal sliders. (WebCore::supportsFocus): Add sliders as focusable elements. (WebCore::RenderThemeEfl::paintSliderTrack): Implement. (WebCore::RenderThemeEfl::adjustSliderTrackStyle): Implement. (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Use adjustSliderTrackStyle() implementation. (WebCore::RenderThemeEfl::paintSliderThumb): Use paintSliderTrack() implementation().
  • platform/efl/RenderThemeEfl.h: Add SliderVertical and
  • SliderHorizontal. (WebCore::): Added prototypes for adjustSlider*/paintSlider*.
11:12 AM Changeset in webkit [64569] by Simon Fraser
  • 5 edits in trunk/WebKit2

2010-08-03 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Compositing iframe layout test crashes in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42860

Part one of the fix: make DrawingArea ref-counted, so that the object
can survide a swap in drawing areas inside the run loop observer callback.

  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformClear): (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverCallback): (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverFired):
11:10 AM Changeset in webkit [64568] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix crash during HitTest call.
​https://bugs.webkit.org/show_bug.cgi?id=43372

11:08 AM Changeset in webkit [64567] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-08-03 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Does not paint the node highlight used by the inspector
​https://bugs.webkit.org/show_bug.cgi?id=43429

Implement highlighting the nodes when using the inspector.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event):
11:02 AM Changeset in webkit [64566] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKitTools

WTR: Move all the utility functions for working with strings to a shared header.
​https://bugs.webkit.org/show_bug.cgi?id=43386

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::shouldInsertNode):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/StringFunctions.h: Added.
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:54 AM Changeset in webkit [64565] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-08-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: incorrect absolute protocol-less URLs in tooltips of links in the ElementsTreeOutline
​https://bugs.webkit.org/show_bug.cgi?id=43246

  • inspector/front-end/inspector.js: (WebInspector.completeURL):
10:39 AM Changeset in webkit [64564] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Frequent ASSERT_NOT_REACHED in Connection::processIncomingMessage when running regression tests
​https://bugs.webkit.org/show_bug.cgi?id=42926
<rdar://problem/8237329>

Reviewed by Adam Roben.

Remove this assert, it's bogus. It would fire when a reply came in on the connection queue before
waitForReply was called on the client thread, but that case is already covered.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

10:17 AM Changeset in webkit [64563] by Adam Roben
  • 6 edits in trunk

Compile out two Mac-only localized strings on non-Mac platforms

Fixes <​http://webkit.org/b/43433> copyImageUnknownFileLabel and
AXARIAContentGroupText should only be compiled on Mac

Reviewed by Anders Carlsson.

WebCore:

  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.h:

Wrapped copyImageUnknownFileLabel and AXARIAContentGroupText in
PLATFORM(MAC).

WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Wrapped copyImageUnknownFileLabel and AXARIAContentGroupText in
PLATFORM(MAC).

10:13 AM Changeset in webkit [64562] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, don't build some DOM bindings we don't use.

10:02 AM Changeset in webkit [64561] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-08-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove a memory leak from CusorGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43424

  • platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): (WebCore::createCustomCursor): (WebCore::Cursor::ensurePlatformCursor):
  • platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
9:26 AM Changeset in webkit [64560] by cmarrin@apple.com
  • 149 adds in trunk/ANGLE

2010-08-02 Paul Sawaya <​psawaya@apple.com>

Reviewed by Adele Peterson.

Add ANGLE library to WebKit. From the repository (​http://angleproject.googlecode.com) as of July 22.
​https://bugs.webkit.org/show_bug.cgi?id=42789


9:01 AM AGC created by noam.rosenthal@nokia.com
8:47 AM Changeset in webkit [64559] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-08-03 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Darin Adler.

[EFL] REGRESSION(64425) need to fix build break
​https://bugs.webkit.org/show_bug.cgi?id=43322

just add include path missed after r64425

  • CMakeListsEfl.txt:
8:33 AM Changeset in webkit [64558] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-08-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: speculative chromium tests fix.

  • inspector/front-end/ExtensionServer.js:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
8:26 AM Changeset in webkit [64557] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

[Qt] Platform plugin interface for Haptics
​https://bugs.webkit.org/show_bug.cgi?id=43143

Patch by Kim Grönholm <​kim.1.gronholm@nokia.com> on 2010-08-03
Reviewed by Simon Hausmann.

Platform plugin interface for playing haptic feedback

  • Api/qwebkitplatformplugin.h:

(QWebHapticFeedbackPlayer::):
(QWebKitPlatformPlugin::):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin::createHapticFeedbackPlayer):

  • examples/platformplugin/qwebkitplatformplugin.h:

(QWebHapticFeedbackPlayer::):
(QWebKitPlatformPlugin::):

8:14 AM Changeset in webkit [64556] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

2010-08-02 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

[Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
​https://bugs.webkit.org/show_bug.cgi?id=43168

QGraphicsWebView resizesToContents property has to work together with QWebPage's
setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::applyPrefs):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setCustomLayoutSize): Setter helper. (WebViewGraphicsBased::customLayoutSize): Getter helper.
  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes

needed when toggle resizesToContents on/off.

8:07 AM Changeset in webkit [64555] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-08-03 Martin Robinson <​mrobinson@igalia.com>

[GTK] Incorrect keyIdentifier for print screen key events
​https://bugs.webkit.org/show_bug.cgi?id=43422

Skip this test on GTK+ until this bug can be fixed. Correct the
baseline, so that the Mac bots pass the test.

  • fast/events/special-key-events-in-input-text-expected.txt:
  • platform/gtk/Skipped:
7:53 AM Changeset in webkit [64554] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-03 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium interactive UI tests.

  • src/js/Tests.js: (.TestSuite.prototype.testResourceHeaders):
6:44 AM Changeset in webkit [64553] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-03 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

Fix warning in WebCore/rendering/RenderBoxModelObject.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43412

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::clipBorderSidePolygon): Remove useless assignment.
6:38 AM Changeset in webkit [64552] by xan@webkit.org
  • 5 edits in trunk

WebCore:

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Make string parameters be 'const char*' instead of just 'char*'.

  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update unit tests now that string parameters are 'const char*'.

  • tests/testdomdocument.c: (test_dom_document_title): (test_dom_document_get_elements_by_tag_name): (test_dom_document_get_elements_by_class_name): (test_dom_document_get_element_by_id):
  • tests/testdomnode.c: (test_dom_node_insertion):
6:37 AM Changeset in webkit [64551] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Get rid of extra spaces in the type strings.

  • bindings/scripts/CodeGeneratorGObject.pm:
6:33 AM Changeset in webkit [64550] by xan@webkit.org
  • 2 edits in trunk

2010-08-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Silence JSCore gir "creation".

  • GNUmakefile.am:
6:24 AM Changeset in webkit [64549] by jochen@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-03 Jochen Eisinger <​jochen@chromium.org>

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
6:22 AM Changeset in webkit [64548] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-03 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Roben.

Fix warning in WebCore/plugins/win/PluginMessageThrottlerWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43413

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Modify initialization order.
6:07 AM Changeset in webkit [64547] by yurys@chromium.org
  • 8 edits in trunk/WebCore

2010-08-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use InspectorValue to push resource data to the frontend
​https://bugs.webkit.org/show_bug.cgi?id=43414

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): destroy remote frontend object along with the old inspector frontend (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/InspectorResource.cpp: (WebCore::buildHeadersObject): (WebCore::buildObjectForTiming): (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorResource.h:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
5:50 AM Changeset in webkit [64546] by Nikolas Zimmermann
  • 480 edits in trunk/WebCore

2010-08-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64539.
​http://trac.webkit.org/changeset/64539
​https://bugs.webkit.org/show_bug.cgi?id=43409

Accidently changed licenses in some files (Requested by
WildFox on #webkit).

  • svg/ColorDistance.cpp:
  • svg/ColorDistance.h:
  • svg/ElementTimeControl.h:
  • svg/ElementTimeControl.idl:
  • svg/GradientAttributes.h:
  • svg/LinearGradientAttributes.h:
  • svg/PatternAttributes.h:
  • svg/RadialGradientAttributes.h:
  • svg/SVGAElement.cpp:
  • svg/SVGAElement.h:
  • svg/SVGAElement.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAltGlyphElement.cpp:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphElement.idl:
  • svg/SVGAngle.cpp:
  • svg/SVGAngle.h:
  • svg/SVGAngle.idl:
  • svg/SVGAnimateColorElement.cpp:
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateColorElement.idl:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateElement.idl:
  • svg/SVGAnimateMotionElement.cpp:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimateTransformElement.idl:
  • svg/SVGAnimatedAngle.idl:
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.idl:
  • svg/SVGAnimatedLength.idl:
  • svg/SVGAnimatedLengthList.idl:
  • svg/SVGAnimatedNumber.idl:
  • svg/SVGAnimatedNumberList.idl:
  • svg/SVGAnimatedPathData.cpp:
  • svg/SVGAnimatedPathData.h:
  • svg/SVGAnimatedPathData.idl:
  • svg/SVGAnimatedPoints.cpp:
  • svg/SVGAnimatedPoints.h:
  • svg/SVGAnimatedPoints.idl:
  • svg/SVGAnimatedPreserveAspectRatio.idl:
  • svg/SVGAnimatedProperty.h:
  • svg/SVGAnimatedPropertySynchronizer.h:
  • svg/SVGAnimatedPropertyTraits.h:
  • svg/SVGAnimatedRect.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGAnimatedTemplate.h:
  • svg/SVGAnimatedTransformList.idl:
  • svg/SVGAnimationElement.cpp:
  • svg/SVGAnimationElement.h:
  • svg/SVGAnimationElement.idl:
  • svg/SVGCircleElement.cpp:
  • svg/SVGCircleElement.h:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.cpp:
  • svg/SVGClipPathElement.h:
  • svg/SVGClipPathElement.idl:
  • svg/SVGColor.cpp:
  • svg/SVGColor.h:
  • svg/SVGColor.idl:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGCursorElement.cpp:
  • svg/SVGCursorElement.h:
  • svg/SVGCursorElement.idl:
  • svg/SVGDefsElement.cpp:
  • svg/SVGDefsElement.h:
  • svg/SVGDefsElement.idl:
  • svg/SVGDescElement.cpp:
  • svg/SVGDescElement.h:
  • svg/SVGDescElement.idl:
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h:
  • svg/SVGDocument.idl:
  • svg/SVGDocumentExtensions.cpp:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGElement.idl:
  • svg/SVGElementInstance.cpp:
  • svg/SVGElementInstance.h:
  • svg/SVGElementInstance.idl:
  • svg/SVGElementInstanceList.cpp:
  • svg/SVGElementInstanceList.h:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGElementRareData.h:
  • svg/SVGEllipseElement.cpp:
  • svg/SVGEllipseElement.h:
  • svg/SVGEllipseElement.idl:
  • svg/SVGException.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGFont.cpp:
  • svg/SVGFontData.cpp:
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp:
  • svg/SVGFontElement.h:
  • svg/SVGFontElement.idl:
  • svg/SVGFontFaceElement.cpp:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceElement.idl:
  • svg/SVGFontFaceFormatElement.cpp:
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceFormatElement.idl:
  • svg/SVGFontFaceNameElement.cpp:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceNameElement.idl:
  • svg/SVGFontFaceSrcElement.cpp:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceSrcElement.idl:
  • svg/SVGFontFaceUriElement.cpp:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGFontFaceUriElement.idl:
  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.cpp:
  • svg/SVGGElement.h:
  • svg/SVGGElement.idl:
  • svg/SVGGlyphElement.cpp:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphElement.idl:
  • svg/SVGGlyphMap.h:
  • svg/SVGGradientElement.cpp:
  • svg/SVGGradientElement.h:
  • svg/SVGGradientElement.idl:
  • svg/SVGHKernElement.cpp:
  • svg/SVGHKernElement.h:
  • svg/SVGHKernElement.idl:
  • svg/SVGImageElement.cpp:
  • svg/SVGImageElement.h:
  • svg/SVGImageElement.idl:
  • svg/SVGImageLoader.cpp:
  • svg/SVGImageLoader.h:
  • svg/SVGLangSpace.cpp:
  • svg/SVGLangSpace.h:
  • svg/SVGLangSpace.idl:
  • svg/SVGLength.cpp:
  • svg/SVGLength.h:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.cpp:
  • svg/SVGLengthList.h:
  • svg/SVGLengthList.idl:
  • svg/SVGLineElement.cpp:
  • svg/SVGLineElement.h:
  • svg/SVGLineElement.idl:
  • svg/SVGLinearGradientElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGLinearGradientElement.idl:
  • svg/SVGList.h:
  • svg/SVGListTraits.h:
  • svg/SVGLocatable.cpp:
  • svg/SVGLocatable.h:
  • svg/SVGLocatable.idl:
  • svg/SVGMPathElement.cpp:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp:
  • svg/SVGMarkerElement.h:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h:
  • svg/SVGMaskElement.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGMetadataElement.cpp:
  • svg/SVGMetadataElement.h:
  • svg/SVGMetadataElement.idl:
  • svg/SVGMissingGlyphElement.cpp:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGMissingGlyphElement.idl:
  • svg/SVGNumber.idl:
  • svg/SVGNumberList.cpp:
  • svg/SVGNumberList.h:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.cpp:
  • svg/SVGPaint.h:
  • svg/SVGPaint.idl:
  • svg/SVGParserUtilities.cpp:
  • svg/SVGParserUtilities.h:
  • svg/SVGPathBuilder.cpp:
  • svg/SVGPathBuilder.h:
  • svg/SVGPathConsumer.h:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:
  • svg/SVGPathElement.idl:
  • svg/SVGPathParser.cpp:
  • svg/SVGPathParser.h:
  • svg/SVGPathSeg.h:
  • svg/SVGPathSeg.idl:
  • svg/SVGPathSegArc.cpp:
  • svg/SVGPathSegArc.h:
  • svg/SVGPathSegArcAbs.idl:
  • svg/SVGPathSegArcRel.idl:
  • svg/SVGPathSegClosePath.cpp:
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegClosePath.idl:
  • svg/SVGPathSegCurvetoCubic.cpp:
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicAbs.idl:
  • svg/SVGPathSegCurvetoCubicRel.idl:
  • svg/SVGPathSegCurvetoCubicSmooth.cpp:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl:
  • svg/SVGPathSegCurvetoQuadratic.cpp:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegCurvetoQuadraticAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticRel.idl:
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
  • svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
  • svg/SVGPathSegLineto.cpp:
  • svg/SVGPathSegLineto.h:
  • svg/SVGPathSegLinetoAbs.idl:
  • svg/SVGPathSegLinetoHorizontal.cpp:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoHorizontalAbs.idl:
  • svg/SVGPathSegLinetoHorizontalRel.idl:
  • svg/SVGPathSegLinetoRel.idl:
  • svg/SVGPathSegLinetoVertical.cpp:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegLinetoVerticalAbs.idl:
  • svg/SVGPathSegLinetoVerticalRel.idl:
  • svg/SVGPathSegList.cpp:
  • svg/SVGPathSegList.h:
  • svg/SVGPathSegList.idl:
  • svg/SVGPathSegListBuilder.cpp:
  • svg/SVGPathSegListBuilder.h:
  • svg/SVGPathSegMoveto.cpp:
  • svg/SVGPathSegMoveto.h:
  • svg/SVGPathSegMovetoAbs.idl:
  • svg/SVGPathSegMovetoRel.idl:
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h:
  • svg/SVGPatternElement.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.cpp:
  • svg/SVGPointList.h:
  • svg/SVGPointList.idl:
  • svg/SVGPolyElement.cpp:
  • svg/SVGPolyElement.h:
  • svg/SVGPolygonElement.cpp:
  • svg/SVGPolygonElement.h:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.cpp:
  • svg/SVGPolylineElement.h:
  • svg/SVGPolylineElement.idl:
  • svg/SVGPreserveAspectRatio.cpp:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGPreserveAspectRatio.idl:
  • svg/SVGRadialGradientElement.cpp:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRadialGradientElement.idl:
  • svg/SVGRect.idl:
  • svg/SVGRectElement.cpp:
  • svg/SVGRectElement.h:
  • svg/SVGRectElement.idl:
  • svg/SVGRenderingIntent.h:
  • svg/SVGRenderingIntent.idl:
  • svg/SVGSVGElement.cpp:
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:
  • svg/SVGScriptElement.idl:
  • svg/SVGSetElement.cpp:
  • svg/SVGSetElement.h:
  • svg/SVGSetElement.idl:
  • svg/SVGStopElement.cpp:
  • svg/SVGStopElement.h:
  • svg/SVGStopElement.idl:
  • svg/SVGStringList.cpp:
  • svg/SVGStringList.h:
  • svg/SVGStringList.idl:
  • svg/SVGStylable.cpp:
  • svg/SVGStylable.h:
  • svg/SVGStylable.idl:
  • svg/SVGStyleElement.cpp:
  • svg/SVGStyleElement.h:
  • svg/SVGStyleElement.idl:
  • svg/SVGStyledElement.cpp:
  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp:
  • svg/SVGStyledLocatableElement.h:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp:
  • svg/SVGSwitchElement.h:
  • svg/SVGSwitchElement.idl:
  • svg/SVGSymbolElement.cpp:
  • svg/SVGSymbolElement.h:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTRefElement.cpp:
  • svg/SVGTRefElement.h:
  • svg/SVGTRefElement.idl:
  • svg/SVGTSpanElement.cpp:
  • svg/SVGTSpanElement.h:
  • svg/SVGTSpanElement.idl:
  • svg/SVGTests.cpp:
  • svg/SVGTests.h:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTextElement.cpp:
  • svg/SVGTextElement.h:
  • svg/SVGTextElement.idl:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPathElement.idl:
  • svg/SVGTextPositioningElement.cpp:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTextPositioningElement.idl:
  • svg/SVGTitleElement.cpp:
  • svg/SVGTitleElement.h:
  • svg/SVGTitleElement.idl:
  • svg/SVGTransform.cpp:
  • svg/SVGTransform.h:
  • svg/SVGTransform.idl:
  • svg/SVGTransformDistance.cpp:
  • svg/SVGTransformDistance.h:
  • svg/SVGTransformList.cpp:
  • svg/SVGTransformList.h:
  • svg/SVGTransformList.idl:
  • svg/SVGTransformable.cpp:
  • svg/SVGTransformable.h:
  • svg/SVGTransformable.idl:
  • svg/SVGURIReference.cpp:
  • svg/SVGURIReference.h:
  • svg/SVGURIReference.idl:
  • svg/SVGUnitTypes.h:
  • svg/SVGUnitTypes.idl:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/SVGUseElement.idl:
  • svg/SVGVKernElement.cpp:
  • svg/SVGVKernElement.h:
  • svg/SVGVKernElement.idl:
  • svg/SVGViewElement.cpp:
  • svg/SVGViewElement.h:
  • svg/SVGViewElement.idl:
  • svg/SVGViewSpec.cpp:
  • svg/SVGViewSpec.h:
  • svg/SVGViewSpec.idl:
  • svg/SVGZoomAndPan.cpp:
  • svg/SVGZoomAndPan.h:
  • svg/SVGZoomAndPan.idl:
  • svg/SVGZoomEvent.cpp:
  • svg/SVGZoomEvent.h:
  • svg/SVGZoomEvent.idl:
  • svg/animation/SMILTime.cpp:
  • svg/animation/SMILTime.h:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp:
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/filters/SVGDistantLightSource.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp:
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp:
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFELighting.cpp:
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp:
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp:
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp:
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp:
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp:
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilter.cpp:
  • svg/graphics/filters/SVGFilter.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:
  • svg/graphics/filters/SVGFilterBuilder.h:
  • svg/graphics/filters/SVGLightSource.cpp:
  • svg/graphics/filters/SVGLightSource.h:
  • svg/graphics/filters/SVGPointLightSource.h:
  • svg/graphics/filters/SVGSpotLightSource.h:
5:36 AM Changeset in webkit [64545] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-08-03 Balazs Kelemen <​kb@inf.u-szeged.hu>

[Qt] Unreviewed typo fix in the WebKit2/DerivedSources.pro project file.

Use QMAKE_MKDIR as the command for directory creation.

  • DerivedSources.pro:
4:59 AM WebKit Team edited by jochen@chromium.org
(diff)
4:08 AM Changeset in webkit [64544] by andreip@google.com
  • 2 edits in trunk/WebCore

2010-08-03 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[IndexedDB] Chromium build is broken due to typo in WebCore.gypi:3501
​https://bugs.webkit.org/show_bug.cgi?id=43408

Add missing ' in WebCore.gypi:3501.

  • WebCore.gypi:
3:43 AM Changeset in webkit [64543] by andreip@google.com
  • 30 edits
    1 copy
    4 moves
    1 delete in trunk

2010-07-30 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

Rename IDBDatabaseRequest to IDBDatabase
​https://bugs.webkit.org/show_bug.cgi?id=43250

No new tests, just refactoring.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCore.vcproj~: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.xcodeproj/project.pbxproj~: Added.
  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbDatabase): (WebCore::IDBAny::set):
  • storage/IDBAny.h: (WebCore::IDBAny::):
  • storage/IDBCallbacks.h:
  • storage/IDBDatabase.cpp: Added. (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::objectStore): (WebCore::IDBDatabase::removeObjectStore):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::name): (WebCore::IDBDatabase::description): (WebCore::IDBDatabase::version): (WebCore::IDBDatabase::objectStores):
  • storage/IDBDatabase.idl: Added.
  • storage/IDBDatabaseBackendImpl.cpp: Added. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::objectStores): (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
  • storage/IDBDatabaseBackendImpl.h: Added. (WebCore::IDBDatabaseBackendImpl::create): (WebCore::IDBDatabaseBackendImpl::name): (WebCore::IDBDatabaseBackendImpl::description): (WebCore::IDBDatabaseBackendImpl::version):
  • storage/IDBDatabaseBackendInterface.h: Added. (WebCore::IDBDatabaseBackendInterface::~IDBDatabaseBackendInterface):
  • storage/IDBDatabaseImpl.cpp: Removed.
  • storage/IDBDatabaseImpl.h: Removed.
  • storage/IDBDatabaseRequest.cpp: Removed.
  • storage/IDBDatabaseRequest.h: Removed.
  • storage/IDBDatabaseRequest.idl: Removed.
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
  • storage/IDBRequest.h:

2010-07-30 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

Rename IDBDatabaseRequest to IDBDatabase
​https://bugs.webkit.org/show_bug.cgi?id=43250

  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::create):
  • src/IDBDatabaseProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::name): (WebKit::WebIDBDatabaseImpl::description): (WebKit::WebIDBDatabaseImpl::version): (WebKit::WebIDBDatabaseImpl::objectStores): (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::objectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore):
  • src/WebIDBDatabaseImpl.h:
3:12 AM Changeset in webkit [64542] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-03 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Initiate speech input requests on click event
​https://bugs.webkit.org/show_bug.cgi?id=43352

  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
2:54 AM Changeset in webkit [64541] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
2:33 AM Changeset in webkit [64540] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-08-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: debugger code should serialize call frames to InspectorObjects instead of SerializedScriptValues.
​https://bugs.webkit.org/show_bug.cgi?id=43339

No new tests. Refactoring.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFrames):
  • inspector/InjectedScript.h:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::editScriptSource): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::currentCallFrames): (WebCore::InspectorController::didPause):
  • inspector/InspectorController.h:
  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
2:21 AM Changeset in webkit [64539] by Nikolas Zimmermann
  • 480 edits in trunk/WebCore

2010-08-03 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup all of svg/ code
​https://bugs.webkit.org/show_bug.cgi?id=43311

Unify the license header in all files in svg/, to use the same template as most WebCore files use.
Unified email adress style, etc. all generated with a perl script attached to bug 43311.i

  • svg/...: Updated header template in all files, in the svg/ subdirectory.
2:11 AM Changeset in webkit [64538] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Upstreaming test_expectations.

  • platform/chromium/test_expectations.txt:
2:04 AM Changeset in webkit [64537] by dumi@chromium.org
  • 40 edits
    11 adds in trunk

WebCore: Turn all callbacks into ActiveDOMObjects and create callbacks in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=40112

Reviewed by Adam Barth.

Test: http/tests/storage/callbacks-are-called-in-correct-context.html

  • CMakeLists.txt: Added new files.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/ActiveDOMCallback.cpp: Added. The base class

for all callbacks, that behaves like an ActiveDOMObject.
(WebCore::DestroyOnContextThreadTask::create):
(WebCore::DestroyOnContextThreadTask::performTask):
(WebCore::DestroyOnContextThreadTask::DestroyOnContextThreadTask):
(WebCore::ActiveDOMObjectCallbackImpl::ActiveDOMObjectCallbackImpl):
(WebCore::ActiveDOMObjectCallbackImpl::contextDestroyed):
(WebCore::ActiveDOMObjectCallbackImpl::canSuspend):
(WebCore::ActiveDOMObjectCallbackImpl::suspend):
(WebCore::ActiveDOMObjectCallbackImpl::resume):
(WebCore::ActiveDOMObjectCallbackImpl::stop):
(WebCore::ActiveDOMObjectCallbackImpl::canInvokeCallback):
(WebCore::ActiveDOMObjectCallbackImpl::scriptExecutionContext):
(WebCore::ActiveDOMObjectCallbackImpl::mutex):
(WebCore::destroyOnContextThread):
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
(WebCore::ActiveDOMCallback::~ActiveDOMCallback):
(WebCore::ActiveDOMCallback::canInvokeCallback):
(WebCore::ActiveDOMCallback::scriptExecutionContext):

  • bindings/generic/ActiveDOMCallback.h: Added.
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: Pass the

right ScriptExecutionContext to the JSC callbacks.
(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/scripts/CodeGeneratorJS.pm: Make all callbacks inherit

from ActiveDOMCallback, and make them use the right
ScriptExecutionContext.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: Update the

expectations for the code generated by CodeGenerator{JS|V8}.pm.
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):

  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/scripts/test/V8/V8TestCallback.h:

(WebCore::V8TestCallback::create):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Pass

the right ScriptExecutionContext to the V8 callbacks.
(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:

(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::openDatabaseCallback):
(WebCore::V8WorkerContext::openDatabaseSyncCallback):

  • dom/ActiveDOMObject.cpp: Simplify the code.

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • storage/Database.cpp: CallbackClass::handleEvent() doesn't take

a ScriptExecutionContext anymore.
(WebCore::DatabaseCreationCallbackTask::performTask):

  • storage/DatabaseCallback.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):

  • storage/EntryCallback.h:
  • storage/ErrorCallback.h:
  • storage/FileSystemCallback.h:
  • storage/MetadataCallback.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::execute):

  • storage/SQLTransactionSyncCallback.h:

LayoutTests: Make sure all DB callbacks run in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=40112

Reviewed by Adam Barth.

  • http/tests/storage: Added.
  • http/tests/storage/callbacks-are-called-in-correct-context-expected.txt: Added.
  • http/tests/storage/callbacks-are-called-in-correct-context.html: Added.
  • http/tests/storage/resources: Added.
  • http/tests/storage/resources/callbacks-are-called-in-correct-context-first-frame.html: Added.
  • http/tests/storage/resources/callbacks-are-called-in-correct-context-output-frame.html: Added.
  • http/tests/storage/resources/callbacks-are-called-in-correct-context-second-frame.html: Added.
  • http/tests/storage/resources/callbacks-are-called-in-correct-context-third-frame.html: Added.
  • http/tests/storage/resources/callbacks-are-called-in-correct-context.cgi: Added.
1:57 AM Changeset in webkit [64536] by loislo@chromium.org
  • 6 edits in trunk/WebCore

2010-08-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Trivial InspectorBackend functions were removed.
And now it is bit simpler to change Inspector API because we have
less number of abstraction layers.
​https://bugs.webkit.org/show_bug.cgi?id=43402

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::releaseWrapperObjectGroup): (WebCore::InspectorBackend::inspectorFrontend): (WebCore::InspectorBackend::remoteFrontend):
  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::inspectorDOMAgent): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
  • inspector/InspectorController.h:
1:32 AM Changeset in webkit [64535] by ap@apple.com
  • 2 edits in trunk/WebCore

Unreviewed (emergency test fix).

REGRESSION (r64518): Most regression tests fail on ASSERT(shouldTrackVisitedLinks)
on Snow Leopard.

Platforms that use strategies now use a different code path than others, and that code path
lacks necessary checks. We don't have a Snow Leopard debug buildbot.

  • page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLinkHash): The private version of addVisitedLink() must not be called when we're not tracking visited links.
12:36 AM Changeset in webkit [64534] by pfeldman@chromium.org
  • 35 edits
    10 deletes in trunk

2010-08-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: Get rid of DevTools RPC.

​https://bugs.webkit.org/show_bug.cgi?id=43335

  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::getProfilerLogLines):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::getProfilerLogLines):
  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot): (WebCore::InspectorBackend::getProfilerLogLines):
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::disableProfiler):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):

2010-08-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: Get rid of DevTools RPC.

​https://bugs.webkit.org/show_bug.cgi?id=43335

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToInspectorFrontend): (WebKit::WebDevToolsAgentClient::sendDebuggerOutput): (WebKit::WebDevToolsAgentClient::sendDispatchToAPU):
  • public/WebDevToolsFrontend.h:
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToBackend):
  • public/WebDevToolsMessageData.h: Removed.
  • public/WebDevToolsMessageTransport.h: Removed.
  • src/APUAgentDelegate.h: Removed.
  • src/DebuggerAgent.h: Removed.
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::debuggerOutput):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8):
  • src/DevToolsRPC.h: Removed.
  • src/DevToolsRPCJS.h: Removed.
  • src/InspectorClientImpl.cpp:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
  • src/ProfilerAgent.h: Removed.
  • src/ProfilerAgentImpl.cpp: Removed.
  • src/ProfilerAgentImpl.h: Removed.
  • src/ToolsAgent.h: Removed.
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): (WebKit::WebDevToolsFrontendImpl::frontendLoaded): (WebKit::WebDevToolsFrontendImpl::executeScript):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DevTools.js: (devtools.dispatch): (devtools.ToolsAgent):
  • src/js/DevToolsHostStub.js:
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent):

2010-08-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: Get rid of DevTools RPC.

​https://bugs.webkit.org/show_bug.cgi?id=43335

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::sendMessageToInspectorFrontend): (DRTDevToolsAgent::call):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h: (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendMessageToBackend): (DRTDevToolsClient::call):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
12:14 AM Changeset in webkit [64533] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-03 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update for DRT/Chromium.

  • platform/chromium/drt_expectations.txt:

Aug 2, 2010:

11:19 PM Changeset in webkit [64532] by mitz@apple.com
  • 2 edits in trunk/WebCore

Removed temporary build rule introduced in r62594.

Rubber-stamped by Sam Weinig.

  • DerivedSources.make:
11:00 PM Changeset in webkit [64531] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt:
10:51 PM Changeset in webkit [64530] by tkent@chromium.org
  • 8 edits in trunk

[DRT/Chromium] Remove dependencies to some Chromium headers
​https://bugs.webkit.org/show_bug.cgi?id=43396

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update Chromium revision to 54649 in order to have a

webkit_support change (r54646)

WebKitTools:

  • DumpRenderTree/chromium/CppVariant.h: Remove base/basictypes.h because webkit_support.h contains it.
  • DumpRenderTree/chromium/EventSender.cpp:

(getCurrentEventTimeSec): Use new wrapper function.

  • DumpRenderTree/chromium/TestNavigationController.h: Remove base/basictypes.h because webkit_support.h contains it.
  • DumpRenderTree/chromium/TestShell.cpp:

(dumpHistoryItem): Use new wrapper function.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::cancelledError): Use new wrapper function.
(WebViewHost::didFailResourceLoad): Use new wrapper function.

9:57 PM Changeset in webkit [64529] by pfeldman@chromium.org
  • 5 edits in trunk

2010-08-02 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r64525 for breaking chromium tests.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve):
8:22 PM Changeset in webkit [64528] by kevino@webkit.org
  • 5 edits
    2 adds in trunk

[wx] Build fixes after recent changes.

8:00 PM Changeset in webkit [64527] by beidson@apple.com
  • 1 edit
    1 add in trunk/WebCore
  • platform/VisitedLinkStrategy.h: Added.

(WebCore::VisitedLinkStrategy::~VisitedLinkStrategy):

Reviewed by NOBODY (Build fix, forgot to svn add this file)

7:44 PM Changeset in webkit [64526] by Martin Robinson
  • 4 edits in trunk/WebCore

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebKit2 requires lazy cursor support
​https://bugs.webkit.org/show_bug.cgi?id=43053

Add lazy cursor support for GTK+. Lazy cursor support is used on some
WebKit2 ports to support changing the cursor.

No new tests, as this should not change functionality.

  • platform/Cursor.h: Changed the m_platformCursor member to be a GRefPtr. This simplifies the logic a great deal.
  • platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): Added, adapted from existing code. (WebCore::createCustomCursor): Added, adapted from existing code. (WebCore::Cursor::ensurePlatformCursor): Added. (WebCore::Cursor::Cursor): Added. (WebCore::Cursor::operator=): Added. (WebCore::Cursor::~Cursor): Added.
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor): Call platformCusor now to get the actual GdkCursor.
7:25 PM Changeset in webkit [64525] by dpranke@chromium.org
  • 5 edits in trunk

2010-08-02 Rajiv Makhijani <​rajivmakhijani@chromium.org>

Reviewed by Adam Barth.

Committed by Dirk Pranke.

Added missing "if (window.layoutTestController)" check.
Removed expectation for test case that should now pass with this bugfix.

​https://bugs.webkit.org/show_bug.cgi?id=38705

  • http/tests/security/sandbox-inherit-to-initial-document-2.html:
  • platform/chromium/test_expectations.txt:

2010-08-02 Rajiv Makhijani <​rajivmakhijani@chromium.org>

Reviewed by Adam Barth.

Committed by Dirk Pranke.

Bug 38705 - [v8] chromium fails http/tests/sandbox-inherit-to-initial-document-2
​https://bugs.webkit.org/show_bug.cgi?id=38705

WebCore::V8Proxy::retrieve(Frame* frame) calls WebCore::ScriptController::canExecuteScripts
and returns 0 if canExecuteScripts is false. It should return the proxy regardless
of whether the frame can execute scripts.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Removed canExecuteScripts check.
7:20 PM Changeset in webkit [64524] by Martin Robinson
  • 8 edits
    4 adds in trunk

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT implement execCommand()
​https://bugs.webkit.org/show_bug.cgi?id=35351

Enable tests which are now passing and re-organize some others that
will pass once we have editing callbacks enabled.

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/5300379-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt: Added.
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt: Added.
  • platform/gtk/editing/selection/selection-actions-expected.txt: Added.

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT implement execCommand()
​https://bugs.webkit.org/show_bug.cgi?id=35351

  • webkit/webkitprivate.h: Add some private methods for the DRT which enable LayoutTestController.execCommand and LayoutTestController.isCommandEnabled: webkit_web_view_execute_core_command_by_name and webkit_web_view_is_command_enabled.
  • webkit/webkitwebview.cpp: (webkit_web_view_execute_core_command_by_name): added. (webkit_web_view_is_command_enabled): Added.

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT implement execCommand()
​https://bugs.webkit.org/show_bug.cgi?id=35351

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name. (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled. (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
7:04 PM Changeset in webkit [64523] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium change to mark keydown-numpad-keys.html as failing on all platforms (not just linux)

  • platform/chromium/test_expectations.txt: Mark keydown-numpad-keys.html as failing on all platforms
7:00 PM Changeset in webkit [64522] by atwilson@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed rollback of Chromium expectations files to match rollback of r64471.

  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-win/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
6:48 PM Changeset in webkit [64521] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

[GTK] Use GdkPixbuf for ImageBuffer::toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=43088

Rebaseline some tests after r64506.

  • platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt:
  • platform/gtk/fast/canvas/toDataURL-supportedTypes-expected.txt: Copied from LayoutTests/platform/qt/fast/canvas/toDataURL-supportedTypes-expected.txt.
6:35 PM Changeset in webkit [64520] by atwilson@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed text expectations changes for Chromium.

  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Added.
  • platform/chromium-mac/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
  • platform/chromium-win/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Added.
  • platform/chromium-win/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Mark keydown-numpad-keys.html as failing on all platforms (not just linux).
6:13 PM Changeset in webkit [64519] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:
6:08 PM Changeset in webkit [64518] by beidson@apple.com
  • 12 edits in trunk

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Add VisitedLinkStrategy for each platform to implement
​https://bugs.webkit.org/show_bug.cgi?id=43393

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createVisitedLinkStrategy): (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links. (WebPlatformStrategies::addVisitedLink): Ditto.

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Add VisitedLinkStrategy for each platform to implement
​https://bugs.webkit.org/show_bug.cgi?id=43393

No new tests. (No change in behavior)

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:


  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Use VisitedLinkStrategy if it's enabled.


  • loader/HistoryController.cpp: (WebCore::addVisitedLink): Choose VisitedLinkStrategy if it's enabled, else fallback to PageGroup. (WebCore::HistoryController::updateForStandardLoad): Use addVisitedLink helper. (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto. (WebCore::HistoryController::updateForClientRedirect): Ditto. (WebCore::HistoryController::updateForSameDocumentNavigation): Ditto.


  • platform/PlatformStrategies.h: (WebCore::PlatformStrategies::visitedLinkStrategy): (WebCore::PlatformStrategies::PlatformStrategies):

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Add VisitedLinkStrategy for each platform to implement
​https://bugs.webkit.org/show_bug.cgi?id=43393

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createVisitedLinkStrategy): (WebKit::WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links, for now. (WebKit::WebPlatformStrategies::addVisitedLink): Ditto.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
6:05 PM Changeset in webkit [64517] by Chris Fleizach
  • 21 edits
    8 deletes in trunk

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64471.
​http://trac.webkit.org/changeset/64471
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::):
  • accessibility/Accessibility.cpp: Removed.
  • accessibility/Accessibility.h: Removed.
  • accessibility/Accessibility.idl: Removed.
  • accessibility/AccessibilityObject.h:
  • accessibility/ScreenReader.cpp: Removed.
  • accessibility/ScreenReader.h: Removed.
  • accessibility/ScreenReader.idl: Removed.
  • accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postPlatformNotification):
  • accessibility/mac/AccessibilityObjectMac.mm:
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::mimeTypes):
  • page/Navigator.h:
  • page/Navigator.idl:

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64471.
​http://trac.webkit.org/changeset/64471
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • GNUmakefile.am:

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64471.
​http://trac.webkit.org/changeset/64471
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • platform/mac/accessibility/js-accessibility-expected.txt: Removed.
  • platform/mac/accessibility/js-accessibility.html: Removed.
5:59 PM Changeset in webkit [64516] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-02 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Range::create should not be calling deprecatedEditingOffset and node on start and end
​https://bugs.webkit.org/show_bug.cgi?id=43385

Replaced node() and deprecatedEditingOffset() by containerNode() and computeOffsetInContainerNode().

No new tests added since this does not change the behavior.

  • dom/Range.cpp: (WebCore::Range::create):
5:57 PM Changeset in webkit [64515] by Chris Fleizach
  • 2 edits in trunk/WebCore

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64472.
​http://trac.webkit.org/changeset/64472
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • WebCore.vcproj/WebCore.vcproj:
5:50 PM Changeset in webkit [64514] by Chris Fleizach
  • 2 edits in trunk/WebCore

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64476.
​http://trac.webkit.org/changeset/64476

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • WebCore.vcproj/WebCore.vcproj:
5:39 PM Changeset in webkit [64513] by luiz@webkit.org
  • 68 edits
    20 copies
    1 add in trunk

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

Classes PopupMenu and SearchPopupMenu have been made pure virtual.

  • platform/PopupMenu.h: (WebCore::PopupMenu::~PopupMenu):
  • platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::~SearchPopupMenu):

Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
the new pure virtual PopupMenu and SearchPopupMenu.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): (WebCore::RenderMenuList::showPopup):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::valueChanged):
  • rendering/RenderTextControlSingleLine.h:

Chrome and ChromeClient were made responsible for providing instances of classes
PopupMenu and SearchPopupMenu to its users.

  • loader/EmptyClients.h: (WebCore::EmptyPopupMenu::show): (WebCore::EmptyPopupMenu::hide): (WebCore::EmptyPopupMenu::updateFromElement): (WebCore::EmptyPopupMenu::disconnectClient): (WebCore::EmptySearchPopupMenu::popupMenu): (WebCore::EmptySearchPopupMenu::saveRecentSearches): (WebCore::EmptySearchPopupMenu::loadRecentSearches): (WebCore::EmptySearchPopupMenu::enabled): (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural): (WebCore::EmptyChromeClient::createPopupMenu): (WebCore::EmptyChromeClient::createSearchPopupMenu):
  • page/Chrome.cpp: (WebCore::Chrome::selectItemWritingDirectionIsNatural): (WebCore::Chrome::createPopupMenu): (WebCore::Chrome::createSearchPopupMenu):
  • page/Chrome.h:
  • page/ChromeClient.h:

Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
Each of new the files contain the concrete classes that inherit form PopupMenu or
SearchPopupMenu and are specific for the corresponding platform.

brew:

  • platform/brew/PopupMenuBrew.cpp: (WebCore::PopupMenuBrew::PopupMenuBrew): (WebCore::PopupMenuBrew::~PopupMenuBrew): (WebCore::PopupMenuBrew::disconnectClient): (WebCore::PopupMenuBrew::show): (WebCore::PopupMenuBrew::hide): (WebCore::PopupMenuBrew::updateFromElement):
  • platform/brew/PopupMenuBrew.h: Added. (WebCore::PopupMenuBrew::client):
  • platform/brew/SearchPopupMenuBrew.cpp: (WebCore::SearchPopupMenuBrew::saveRecentSearches): (WebCore::SearchPopupMenuBrew::loadRecentSearches): (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew): (WebCore::SearchPopupMenuBrew::enabled): (WebCore::SearchPopupMenuBrew::popupMenu):
  • platform/brew/SearchPopupMenuBrew.h: Added.

chromium:

  • WebCore.gypi:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenuChromium::PopupMenuChromium): (WebCore::PopupMenuChromium::~PopupMenuChromium): (WebCore::PopupMenuChromium::show): (WebCore::PopupMenuChromium::hide): (WebCore::PopupMenuChromium::updateFromElement): (WebCore::PopupMenuChromium::disconnectClient):
  • platform/chromium/PopupMenuChromium.h: (WebCore::PopupMenuChromium::client):
  • platform/chromium/SearchPopupMenuChromium.cpp: (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium): (WebCore::SearchPopupMenuChromium::popupMenu): (WebCore::SearchPopupMenuChromium::enabled): (WebCore::SearchPopupMenuChromium::saveRecentSearches): (WebCore::SearchPopupMenuChromium::loadRecentSearches):
  • platform/chromium/SearchPopupMenuChromium.h: Added.

efl:

  • platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenuEfl::PopupMenuEfl): (WebCore::PopupMenuEfl::~PopupMenuEfl): (WebCore::PopupMenuEfl::show): (WebCore::PopupMenuEfl::hide): (WebCore::PopupMenuEfl::updateFromElement): (WebCore::PopupMenuEfl::disconnectClient):
  • platform/efl/PopupMenuEfl.h: Added. (WebCore::PopupMenuEfl::client):
  • platform/efl/SearchPopupMenuEfl.cpp: (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl): (WebCore::SearchPopupMenuEfl::popupMenu): (WebCore::SearchPopupMenuEfl::saveRecentSearches): (WebCore::SearchPopupMenuEfl::loadRecentSearches): (WebCore::SearchPopupMenuEfl::enabled):
  • platform/efl/SearchPopupMenuEfl.h: Added.

gtk:

  • GNUmakefile.am:
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): (WebCore::PopupMenuGtk::~PopupMenuGtk): (WebCore::PopupMenuGtk::show): (WebCore::PopupMenuGtk::hide): (WebCore::PopupMenuGtk::updateFromElement): (WebCore::PopupMenuGtk::disconnectClient): (WebCore::PopupMenuGtk::menuItemActivated): (WebCore::PopupMenuGtk::menuUnmapped): (WebCore::PopupMenuGtk::menuPositionFunction): (WebCore::PopupMenuGtk::menuRemoveItem):
  • platform/gtk/PopupMenuGtk.h: Added. (WebCore::PopupMenuGtk::client):
  • platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk): (WebCore::SearchPopupMenuGtk::popupMenu): (WebCore::SearchPopupMenuGtk::saveRecentSearches): (WebCore::SearchPopupMenuGtk::loadRecentSearches): (WebCore::SearchPopupMenuGtk::enabled):
  • platform/gtk/SearchPopupMenuGtk.h: Added.

haiku:

  • platform/haiku/PopupMenuHaiku.cpp: (WebCore::HaikuPopup::HaikuPopup): (WebCore::HaikuPopup::~HaikuPopup): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::updateFromElement):
  • platform/haiku/PopupMenuHaiku.h: Added. (WebCore::PopupMenuHaiku::disconnectClient): (WebCore::PopupMenuHaiku::client):
  • platform/haiku/SearchPopupMenuHaiku.cpp: (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku): (WebCore::SearchPopupMenuHaiku::saveRecentSearches): (WebCore::SearchPopupMenuHaiku::loadRecentSearches): (WebCore::SearchPopupMenuHaiku::enabled): (WebCore::SearchPopupMenuHaiku::popupMenu):
  • platform/haiku/SearchPopupMenuHaiku.h: Added.

mac:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/PopupMenuMac.h: Added. (WebCore::PopupMenuMac::disconnectClient): (WebCore::PopupMenuMac::client):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenuMac::PopupMenuMac): (WebCore::PopupMenuMac::~PopupMenuMac): (WebCore::PopupMenuMac::clear): (WebCore::PopupMenuMac::populate): (WebCore::PopupMenuMac::show): (WebCore::PopupMenuMac::hide): (WebCore::PopupMenuMac::updateFromElement): (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
  • platform/mac/SearchPopupMenuMac.h: Added.
  • platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenuMac::SearchPopupMenuMac): (WebCore::SearchPopupMenuMac::popupMenu): (WebCore::SearchPopupMenuMac::enabled): (WebCore::SearchPopupMenuMac::saveRecentSearches): (WebCore::SearchPopupMenuMac::loadRecentSearches):

qt:

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::disconnectClient): (WebCore::PopupMenuQt::show): (WebCore::PopupMenuQt::hide): (WebCore::PopupMenuQt::updateFromElement):
  • platform/qt/PopupMenuQt.h: Added.
  • platform/qt/QtAbstractWebPopup.h:
  • platform/qt/SearchPopupMenuQt.cpp: (WebCore::SearchPopupMenuQt::SearchPopupMenuQt): (WebCore::SearchPopupMenuQt::popupMenu): (WebCore::SearchPopupMenuQt::saveRecentSearches): (WebCore::SearchPopupMenuQt::loadRecentSearches): (WebCore::SearchPopupMenuQt::enabled):
  • platform/qt/SearchPopupMenuQt.h: Added.

win:

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::PopupMenuWin): (WebCore::PopupMenuWin::~PopupMenuWin): (WebCore::PopupMenuWin::disconnectClient): (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show): (WebCore::PopupMenuWin::hide): (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::setFocusedIndex): (WebCore::PopupMenuWin::visibleItems): (WebCore::PopupMenuWin::listIndexAtPoint): (WebCore::PopupMenuWin::focusedIndex): (WebCore::PopupMenuWin::focusFirst): (WebCore::PopupMenuWin::focusLast): (WebCore::PopupMenuWin::down): (WebCore::PopupMenuWin::up): (WebCore::PopupMenuWin::invalidateItem): (WebCore::PopupMenuWin::clientRect): (WebCore::PopupMenuWin::incrementWheelDelta): (WebCore::PopupMenuWin::reduceWheelDelta): (WebCore::PopupMenuWin::scrollToRevealSelection): (WebCore::PopupMenuWin::updateFromElement): (WebCore::PopupMenuWin::paint): (WebCore::PopupMenuWin::valueChanged): (WebCore::PopupMenuWin::invalidateScrollbarRect): (WebCore::PopupMenuWin::registerClass): (WebCore::PopupMenuWin::PopupMenuWndProc): (WebCore::PopupMenuWin::wndProc):
  • platform/win/PopupMenuWin.h: Added. (WebCore::PopupMenuWin::client): (WebCore::PopupMenuWin::scrollbar): (WebCore::PopupMenuWin::itemHeight): (WebCore::PopupMenuWin::windowRect): (WebCore::PopupMenuWin::popupHandle): (WebCore::PopupMenuWin::setWasClicked): (WebCore::PopupMenuWin::wasClicked): (WebCore::PopupMenuWin::setScrollOffset): (WebCore::PopupMenuWin::scrollOffset): (WebCore::PopupMenuWin::wheelDelta): (WebCore::PopupMenuWin::scrollbarCapturingMouse): (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::SearchPopupMenuWin): (WebCore::SearchPopupMenuWin::popupMenu): (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
  • platform/win/SearchPopupMenuWin.h: Added.

wx:

  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenuWx::PopupMenuWx): (WebCore::PopupMenuWx::~PopupMenuWx): (WebCore::PopupMenuWx::disconnectClient): (WebCore::PopupMenuWx::show): (WebCore::PopupMenuWx::OnMenuItemSelected): (WebCore::PopupMenuWx::hide): (WebCore::PopupMenuWx::updateFromElement):
  • platform/wx/PopupMenuWx.h: Added. (WebCore::PopupMenuWx::client):
  • platform/wx/SearchPopupMenuWx.cpp: (WebCore::SearchPopupMenuWx::SearchPopupMenuWx): (WebCore::SearchPopupMenuWx::saveRecentSearches): (WebCore::SearchPopupMenuWx::loadRecentSearches): (WebCore::SearchPopupMenuWx::enabled): (WebCore::SearchPopupMenuWx::popupMenu):
  • platform/wx/SearchPopupMenuWx.h: Added.

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural): (WebKit::ChromeClientImpl::createPopupMenu): (WebKit::ChromeClientImpl::createSearchPopupMenu):
  • src/ChromeClientImpl.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientEfl::createPopupMenu): (WebCore::ChromeClientEfl::createSearchPopupMenu):
  • WebCoreSupport/ChromeClientEfl.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): (WebKit::ChromeClient::createPopupMenu): (WebKit::ChromeClient::createSearchPopupMenu):
  • WebCoreSupport/ChromeClientGtk.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientHaiku::createPopupMenu): (WebCore::ChromeClientHaiku::createSearchPopupMenu):
  • WebCoreSupport/ChromeClientHaiku.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientQt::createPopupMenu): (WebCore::ChromeClientQt::createSearchPopupMenu):
  • WebCoreSupport/ChromeClientQt.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::createPopupMenu): (WebChromeClient::createSearchPopupMenu):
  • WebCoreSupport/WebChromeClient.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural): (WebCore::ChromeClientWx::createPopupMenu): (WebCore::ChromeClientWx::createSearchPopupMenu):
  • WebKitSupport/ChromeClientWx.h:

2010-07-27 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Fisher.

PopupMenu refactoring in preparation to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42592

Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
SearchPopupMenu respectively. At this point they are just empty implementations.

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added. (WebKit::WebPopupMenu::WebPopupMenu): (WebKit::WebPopupMenu::~WebPopupMenu): (WebKit::WebPopupMenu::disconnectClient): (WebKit::WebPopupMenu::show): (WebKit::WebPopupMenu::hide): (WebKit::WebPopupMenu::updateFromElement):
  • WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added. (WebKit::WebSearchPopupMenu::WebSearchPopupMenu): (WebKit::WebSearchPopupMenu::popupMenu): (WebKit::WebSearchPopupMenu::saveRecentSearches): (WebKit::WebSearchPopupMenu::loadRecentSearches): (WebKit::WebSearchPopupMenu::enabled):
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.

As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): (WebKit::WebChromeClient::createPopupMenu): (WebKit::WebChromeClient::createSearchPopupMenu):
  • WebProcess/WebCoreSupport/WebChromeClient.h:

build issues:

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
5:38 PM Changeset in webkit [64512] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64478.
​http://trac.webkit.org/changeset/64478
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
5:30 PM Changeset in webkit [64511] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

2010-08-02 Chris Fleizach <Chris Fleizach>

Unreviewed, rolling out r64486.
​http://trac.webkit.org/changeset/64486
​https://bugs.webkit.org/show_bug.cgi?id=43005

Rolling out ​https://bugs.webkit.org/show_bug.cgi?id=43005
until further discussion

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
5:26 PM Changeset in webkit [64510] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix duplicated entries.
5:15 PM Changeset in webkit [64509] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update

  • platform/chromium/drt_expectations.txt: Add Linux results.
5:12 PM Changeset in webkit [64508] by jhoneycutt@apple.com
  • 1 edit
    1 add
    1 delete in trunk/WebKitTools

Restore the WebKitTestRunner.sln that was removed, and remove the
correct one.

Rubber-stamped by Sam Weinig.

  • WebKitTestRunner/WebKitTestRunner.sln: Added.
  • WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
5:00 PM Changeset in webkit [64507] by rniwa@webkit.org
  • 10 edits in trunk/LayoutTests

2010-07-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Remove setNodeToDump from dump-as-markup.js
​https://bugs.webkit.org/show_bug.cgi?id=43286

Removed Removed Markup.setNodeToDump, replaced all calls to this method by calls to dump.
Because we want need to avoid printing "Dump of markup 1:" when dump is called only once,
Markup.dump no longer adds the text on the first call. Instead, it'll insert the text
on the second call when the first call didn't have the description.

  • editing/execCommand/create-list-from-range-selection.html: Replaced setNodeToDump by dump
  • editing/execCommand/hilitecolor.html: Replaced setNodeToDump by dump
  • editing/execCommand/insert-list-empty-div.html: Replaced setNodeToDump by dump
  • editing/execCommand/switch-list-type-with-inner-list.html: Replaced setNodeToDump by dump
  • editing/execCommand/switch-list-type-with-orphaned-li.html: Replaced setNodeToDump by dump
  • editing/selection/home-inside-noneditable-table.html: Replaced setNodeToDump by dump
  • editing/style/remove-underline-from-stylesheet.html: Replaced setNodeToDump by dump
  • resources/dump-as-markup.js: Removed Markup.setNodeToDump. (Markup.dump): (Markup.notifyDone):
4:51 PM Changeset in webkit [64506] by Martin Robinson
  • 7 edits
    3 adds in trunk

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GdkPixbuf for ImageBuffer::toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=43088

  • platform/gtk/Skipped: Generate results for a toDataURL test and unskip it.

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GdkPixbuf for ImageBuffer::toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=43088

Implement ImageBuffer::toDataURL with GdkPixbuf instead of Cairo. This
allows the method to support a larger variety of image types.

  • GNUmakefile.am: Add new files to the source list.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding): Add the list of image types supported by GTK.
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/gtk/CairoUtilities.cpp: Added. (getCairoSurfacePixel): Move this method from ImageGtk.cpp. (getGdkPixbufPixel): Move this method from ImageGtk.cpp. (cairoImageSurfaceToGdkPixbuf): Move this method from ImageGtk.cpp.
  • platform/graphics/gtk/CairoUtilities.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp: Added. (WebCore::ImageBuffer::toDataURL): Use GdkPixbuf to do the conversion to a data url.
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf): Use the new helper method in CairoUtilities.h.
4:43 PM Changeset in webkit [64505] by xan@webkit.org
  • 5 edits in trunk

2010-08-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for the Audio element in the DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=43313

Add new files to the build.

  • GNUmakefile.am:

WebCore:

2010-08-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for the Audio element in the DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=43313

The IDL definition of some HTMLMediaElement methods does not match
the C++ implementation API, take this fact into account when
generating the bindings.

  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createAudioWrapper): (WebKit::createHTMLElementWrapper):
  • bindings/scripts/CodeGeneratorGObject.pm:
4:39 PM Changeset in webkit [64504] by andersca@apple.com
  • 12 edits in trunk

Fix plug-in test failures and remove tests from the Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=43389

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export FrameLoader::cancelledError.

WebKit2:

  • WebProcess/Plugins/JSNPMethod.cpp:

JSNPMethod::s_info should specify InternalFunction::info as its parent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::cancelStreamLoad):
Special-case the manual stream and call PluginController::cancelManualStreamLoad.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::stop):
It's OK to call stop on a stream that hasn't been started. Remove assertion and return early.

  • WebProcess/Plugins/PluginController.h:

Add cancelManualStreamLoad.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelManualStreamLoad):
Tell the document loader to cancel the main resource load.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::innerText):
Check for a null document element.

LayoutTests:

  • platform/mac-wk2/Skipped:

Move plug-in tests that now fail due to lack of functionality out into appropriate sections.

4:33 PM Changeset in webkit [64503] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Skip Windows-only accessibility tests on WebKit2.

​https://bugs.webkit.org/show_bug.cgi?id=43387

Reviewed by Brady Eidson.

  • platform/win-wk2/Skipped:
4:30 PM Changeset in webkit [64502] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-02 Ojan Vafai <​ojan@chromium.org>

Fix chromium-mac test results that fail because the chromium-mac bots run Leopard.
I'd update platform/mac-leopard, but the mac-leopard bot doesn't run pixel-tests.
In either case, I think the difference falls within that bot's tolerance.

  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.png: Added.
3:47 PM JavaScript and DOM Benchmarks edited by ariya@webkit.org
add Dromaeo (diff)
3:42 PM Changeset in webkit [64501] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update skipped list to get us to ~75 failures for Mac WebKit2.

Rubber-stamped by John Honeycutt.

  • platform/mac-wk2/Skipped:
3:38 PM Changeset in webkit [64500] by jhoneycutt@apple.com
  • 5 edits
    1 move
    1 delete in trunk

Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.

WebKit/win:

Reviewed by Sam Weinig.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

Remove the unused WebKitTestRunner.sln.

Reviewed by Sam Weinig.

  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
  • WebKitTestRunner/WebKitTestRunner.sln: Removed.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added.
  • WebKitTestRunner/win/WebKitTestRunner.sln:
3:31 PM Changeset in webkit [64499] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-02 Ojan Vafai <​ojan@chromium.org>

Fix failing test on QT/GTK bots.

r64488 removed the SelectAll on focus behavior. Put in a SelectAll call to match the
old test behavior.

  • editing/pasteboard/crash-accessing-clipboardData-types.html:
3:22 PM Changeset in webkit [64498] by ojan@chromium.org
  • 14 edits in trunk/LayoutTests

2010-08-02 Ojan Vafai <​ojan@chromium.org>

platform specific expectations after r64488
​https://bugs.webkit.org/show_bug.cgi?id=43384

Followup updates after r64488 for tests that had platform-specific expecations.

  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-linux/fast/dom/focus-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-focus-ring-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-focus-ring-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-win/fast/dom/focus-contenteditable-expected.checksum:
  • platform/chromium-win/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-win/fast/dom/focus-contenteditable-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.checksum:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.png:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/select-element-1-expected.txt:
2:58 PM Changeset in webkit [64497] by atwilson@chromium.org
  • 7 edits
    2 deletes in trunk/LayoutTests

Unreviewed test expectations fixups for chromium.

  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-win/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
2:55 PM Changeset in webkit [64496] by Martin Robinson
  • 6 edits in trunk/WebKit/gtk

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Create a frame-created signal
​https://bugs.webkit.org/show_bug.cgi?id=43284

Add a frame-created signal, which will allow developers to track
the beginning of a frame lifecycle and attach signal handlers to
all new frames.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): Emit the frame-created signal.
  • tests/testwebframe.c: Add a test which verifies that the correct number of frame-created signals is fired when a page with iframes loads. (createFrameSignalTestFrameCreatedCallback): Added. (createFrameSignalTestTimeout): Added. (test_webkit_web_frame_created_signal): Added. (main): Add a reference to the new test.
  • webkit/webkitprivate.h: De-normalize webkit_web_frame_init_with_web_view into the one place that it is used, so that the frame-created signal may be fired there.
  • webkit/webkitwebframe.cpp: Remove webkit_web_frame_init_with_web_view.
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init): Add the frame-created signal declaration.
2:50 PM Changeset in webkit [64495] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

fix editing/selection/focus-contenteditable-iframe.html after r64489
​https://bugs.webkit.org/show_bug.cgi?id=43383

I had just messed up the expected results before committing r64489.
This new output is correct and matches the test description.

  • editing/selection/focus-contenteditable-iframe-expected.txt:
2:32 PM Changeset in webkit [64494] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Add support for loading manual streams
​https://bugs.webkit.org/show_bug.cgi?id=43380

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_loadManually to false.

(WebKit::NetscapePlugin::removePluginStream):
Special case the manual stream.

(WebKit::NetscapePlugin::initialize):
Don't request the stream if we're already loading.

(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
Create the manual stream and pass the response to it.

(WebKit::NetscapePlugin::manualStreamDidReceiveData):
Pass the data to the manual stream.

(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
Call the manual stream.

(WebKit::NetscapePlugin::manualStreamDidFail):
Ditto.

  • WebProcess/Plugins/Plugin.h:

Add pure virtual member functions for manual stream loading.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
Put code in a function so both PluginView::Stream::didReceiveResponse and
manualLoadDidReceiveResponse can call it.

(WebKit::PluginView::Stream::didReceiveResponse):
Call buildHTTPHeaders.

(WebKit::PluginView::Stream::didFinishLoading):
Protect the plug-in when calling destroyStream.

(WebKit::PluginView::manualLoadDidReceiveResponse):
Call Plugin::manualStreamDidReceiveResponse.

(WebKit::PluginView::manualLoadDidReceiveData):
Call Plugin::manualStreamDidReceiveData.

(WebKit::PluginView::manualLoadDidFinishLoading):
Call Plugin::manualStreamDidFinishLoading.

(WebKit::PluginView::manualLoadDidFail):
Call Plugin::manualStreamDidFail.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_hasSentResponseToPluginView to false.

(WebKit::WebFrameLoaderClient::setMainDocumentError):
Call PluginView::manualLoadDidFail.

(WebKit::WebFrameLoaderClient::committedLoad):
Call PluginView::manualLoadDidReceiveResponse.

(WebKit::WebFrameLoaderClient::finishedLoading):
Call PluginView::manualLoadDidFinishLoading.

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):
Keep track of the plug-in view.

2:27 PM Changeset in webkit [64493] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix the windows build.

  • WebKitTestRunner/win/main.cpp:
2:10 PM Changeset in webkit [64492] by beidson@apple.com
  • 12 edits in trunk

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Basic WK2 visited link coloring
​https://bugs.webkit.org/show_bug.cgi?id=43377

No new tests. (No change in behavior)

  • WebCore.exp.in:


  • page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLinkHash):
  • page/PageGroup.h:

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Basic WK2 visited link coloring
​https://bugs.webkit.org/show_bug.cgi?id=43377

Add simple API that allows the WK2 app to add 1 visited link at a time.
For now, this just pipes each individual LinkHash down to WebCore.


  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: (WebProcessMessage::):
  • UIProcess/API/C/WKContext.cpp: (WKContextAddVisitedLink):
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::addVisitedLink):
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::addVisitedLinkHash): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h:
2:03 PM Changeset in webkit [64491] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

Add a Skipped list on Windows, and have run-webkit-tests respect it.

Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
there are zero tests failing
​https://bugs.webkit.org/show_bug.cgi?id=43374

Reviewed by Adam Roben.

WebKitTools:

  • Scripts/old-run-webkit-tests:

If using WebKitTestRunner and Apple Windows WebKit, set the platform to
win-wk2. When building the result hierarchy, if the platform is win-wk2,
add it first to the list of platforms.

LayoutTests:

  • platform/win-wk2/Skipped: Copied from LayoutTests/platform/mac-wk2/Skipped.

All platform/mac tests removed.

2:01 PM Changeset in webkit [64490] by Martin Robinson
  • 4 edits in trunk/WebCore

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Style cleanup for CairoPath.h
​https://bugs.webkit.org/show_bug.cgi?id=43133

Turn CairoPath into a class, as it has a constructor and destructor.
Change raw member access to use the new accessor.

No new tests as functionality has not changed.

  • platform/graphics/cairo/CairoPath.h: Cleanup and indentation fix. (WebCore::CairoPath::CairoPath): (WebCore::CairoPath::~CairoPath): (WebCore::CairoPath::context):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::addPath): Convert raw member access to accessor access. (WebCore::GraphicsContext::clip): Ditto.
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): Ditto. (WebCore::Path::operator=): Ditto. (WebCore::Path::clear): Ditto. (WebCore::Path::isEmpty): Ditto. (WebCore::Path::currentPoint): Ditto. (WebCore::Path::translate): Ditto. (WebCore::Path::moveTo): Ditto. (WebCore::Path::addLineTo): Ditto. (WebCore::Path::addRect): Ditto. (WebCore::Path::addQuadCurveTo): Ditto. (WebCore::Path::addBezierCurveTo): Ditto. (WebCore::Path::addArc): Ditto. (WebCore::Path::addArcTo): Ditto. (WebCore::Path::addEllipse): Ditto. (WebCore::Path::closeSubpath): Ditto. (WebCore::Path::boundingRect): Ditto. (WebCore::Path::strokeBoundingRect): Ditto. (WebCore::Path::contains): Ditto. (WebCore::Path::strokeContains): Ditto. (WebCore::Path::apply): Ditto. (WebCore::Path::transform): Ditto. (WebCore::Path::debugString): Ditto.
1:50 PM Changeset in webkit [64489] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

focusing the body of a contentEditable iframe resets the selection
​https://bugs.webkit.org/show_bug.cgi?id=42645

  • editing/selection/focus-contenteditable-iframe-expected.txt: Added.
  • editing/selection/focus-contenteditable-iframe.html: Added.

2010-07-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

focusing the body of a contentEditable iframe resets the selection
​https://bugs.webkit.org/show_bug.cgi?id=42645

The selection shouldn't be reset to the beginning of the rootEditableElement
if it is already inside the rootEditableElement.

Test: editing/selection/focus-contenteditable-iframe.html

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
1:46 PM Changeset in webkit [64488] by ojan@chromium.org
  • 26 edits in trunk

2010-07-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

focusing an unfocused contentEditable element should place the cursor at the beginning
​https://bugs.webkit.org/show_bug.cgi?id=42646

r14666 made this change for the body and html elements, but not for all contentEditable
elements. Doing this for all contentEditable elements matches all other browsers.

  • editing/deleting/5546763-expected.txt:
  • editing/deleting/in-visibly-empty-root.html:
  • editing/execCommand/4786404-1.html:
  • editing/execCommand/4786404-2.html:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/pasteboard/5601583-1.html:
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2.html:
  • editing/selection/move-begin-end-expected.txt:
  • editing/selection/move-begin-end.html:
  • editing/style/5279521.html:
  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
  • platform/mac/editing/input/text-input-controller-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-2-expected.txt:
  • platform/mac/editing/pasteboard/select-element-1-expected.txt:
  • platform/mac/fast/dom/focus-contenteditable-expected.checksum:
  • platform/mac/fast/dom/focus-contenteditable-expected.png:
  • platform/mac/fast/dom/focus-contenteditable-expected.txt:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.checksum:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.txt:

2010-07-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

focusing an unfocused contentEditable element should place the cursor at the beginning
​https://bugs.webkit.org/show_bug.cgi?id=42646

r14666 made this change for the body and html elements, but not for all contentEditable
elements. Doing this for all contentEditable elements matches all other browsers.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
1:02 PM Changeset in webkit [64487] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Protect the plug-in from being destroyed while in plug-in code
​https://bugs.webkit.org/show_bug.cgi?id=43370

Reviewed by Sam Weinig.

Add a PluginProtector to NPRuntimeObjectMap and use it in JSNPObject.

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
Add PluginProtector declarations.

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::PluginProtector::PluginProtector):
Ref the plug-in view (unless it's being destroyed).

(WebKit::NPRuntimeObjectMap::PluginProtector::~PluginProtector):

  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_isBeingDestroyed.

(WebKit::PluginView::~PluginView):
Set m_isBeingDestroyed to true.

(WebKit::PluginView::scriptObject):
Don't crash if the plug-in failed to initialize.

(WebKit::PluginView::evaluate):
Remove comment.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::isBeingDestroyed):

12:50 PM Changeset in webkit [64486] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected result after r64471.

AX: Support methods for web apps to interact with the native accessibility APIs
​https://bugs.webkit.org/show_bug.cgi?id=43005

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
12:10 PM Changeset in webkit [64485] by Darin Adler
  • 25 edits in trunk

2010-08-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.setCanOpenWindows
​https://bugs.webkit.org/show_bug.cgi?id=42321

WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
​https://bugs.webkit.org/show_bug.cgi?id=42779

  • platform/mac-wk2/Skipped: Removed tests that are now passing. Moved other tests into the appropriate section.

2010-08-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.setCanOpenWindows
​https://bugs.webkit.org/show_bug.cgi?id=42321

WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
​https://bugs.webkit.org/show_bug.cgi?id=42779

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of waiting for the first call to didCreatePage. (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page is created. Put other pages into a map. (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction of the main page. (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than the main page.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and closeOtherPages functions.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than the main page affect dumping. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize the new m_shouldCloseExtraWindows member. (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now. (WTR::LayoutTestController::windowCount): Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete, windowCount, shouldCloseExtraWindowsAfterRunningTest, and m_shouldCloseExtraWindows.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::shared): Return a pointer to the shared copy, but don't allocate and leak it. This seemed cleaner than adding an explicit finalize call to go along with the explicit initialize call. (WTR::TestController::TestController): Added calls to the initialize and run function, which are now done automatically. (WTR::TestController::~TestController): Added, since it's called now. (WTR::closeOtherPage): Added. Used to close pages other than the main page. (WTR::createOtherPage): Added. Used to create pages other than the main page. (WTR::TestController::initialize): Added code to set up createOtherPage. (WTR::TestController::run): Removed unused return value.
  • WebKitTestRunner/TestController.h: Made constructor and destructor public, and initialize and run private. Changed m_mainWebView to be an OwnPtr.
  • WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed to avoid releasing the window twice. Another way to handle it would be to remove the release, but this approach is slightly more robust because it works even if some other code calls the close method an extra time.
  • WebKitTestRunner/mac/main.mm: (main): Use a stack-allocated TestController object instead of calling initalize and run on a globally allocated one.

2010-08-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.setCanOpenWindows
​https://bugs.webkit.org/show_bug.cgi?id=42321

WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
​https://bugs.webkit.org/show_bug.cgi?id=42779

Implemented window.close, added a function that does a similar operation on behalf
of injected bundle code named WKBundlePageClose, and fixed the reference counting of
the result of the createNewPage client function.

  • UIProcess/API/cpp/WKRetainPtr.h: Added clear. Tweaked formatting. Renamed releaseRef to leakRef.
  • UIProcess/API/mac/WKView.mm: (-[WKView _updateVisibility]): Handle the case where drawing area is 0. This came up in WebKitTestRunner and other functions handle drawing area of 0.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): Update now that createNewPage returns a PassRefPtr. (WebKit::WebPageProxy::createNewPage): Changed to return a PassRefPtr.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::createNewPage): Changed to return a PassRefPtr and adopt the WKPageRef passed from the client. This follows the "create rule".
  • UIProcess/WebUIClient.h: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageClose): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added WKBundlePageClose and re-sorted the other functions in this file.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::closeWindowSoon): Implemented this.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Called setJavaScriptCanOpenWindowsAutomatically(true). I suppose we will need to revisit this later when we implement pop-up blocking. (WebKit::WebPage::tryClose): Factored out the part of this that sends a message to the other process. (WebKit::WebPage::sendClose): This is where the part that sends a message went.
  • WebProcess/WebPage/WebPage.h: Added sendClose, used by both closeWindowSoon and WKBundlePageClose.
11:51 AM Changeset in webkit [64484] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-02 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

add myself to the reviewers list
​https://bugs.webkit.org/show_bug.cgi?id=43366

  • Scripts/webkitpy/common/config/committers.py:
11:48 AM Changeset in webkit [64483] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for typo in chromium test_expectations.txt.

  • platform/chromium/test_expectations.txt: Fixed typo in entry.
11:43 AM Changeset in webkit [64482] by Adam Roben
  • 2 edits in trunk/BugsSite

Tell the patch prettifier about some (not so) new directories

  • PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake

directories.

11:36 AM Changeset in webkit [64481] by noam.rosenthal@nokia.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Unreviewed: Added Noam Rosenthal to the commiters script

11:33 AM Changeset in webkit [64480] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=43369
WebBackForwardList::forwardListAsImmutableArrayWithLimit can return partly-uninitialized array

Reviewed by Ada Chan.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
Use a simpler and correct expression to determine "last".

11:28 AM Changeset in webkit [64479] by andersca@apple.com
  • 13 edits
    3 adds in trunk

Cache JSNPObjects and fix bugs in the object map
​https://bugs.webkit.org/show_bug.cgi?id=43368

Reviewed by Sam Weinig.

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
Assert that we're not trying to wrap an NPJSObject.

(WebKit::JSNPObject::~JSNPObject):
Tell the object map that we're gone.

(WebKit::JSNPObject::invalidate):
Release the NPObject and null out the pointer.

  • WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::create):
Assert that we're not trying to wrap a JSNPObject.

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
If we're passed a JSNPObject, just extract its NPObject.

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
If we're passed an NPJSObject, just extract its JSObject. Otherwise, check if we already have
a JSObject for this NPObject and return it.

(WebKit::NPRuntimeObjectMap::jsNPObjectDestroyed):
Remove the object from the map.

(WebKit::NPRuntimeObjectMap::convertNPVariantToJSValue):
getOrCreateJSObject now checks for wrapped objects.

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
getOrCreateNPObject now checks for wrapped objects.

(WebKit::NPRuntimeObjectMap::invalidate):
Invalidate JSNPObjects as well.

WebKitTools:

Test that we correctly throw exceptions when trying to do things to a JSObject that used to
wrap an NPObject that came from a plug-in that is now destroyed.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest::Object::getProperty):
(PluginTest::Object::NP_GetProperty):
(PluginTest::Object::npClass):

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.

(NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
(NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

  • plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
  • plugins/npruntime/object-from-destroyed-plugin.html: Added.
11:19 AM Changeset in webkit [64478] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

AX: Support methods for web apps to interact with the native accessibility APIs
​https://bugs.webkit.org/show_bug.cgi?id=43005

Updating expectations for layout tests.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
11:13 AM Changeset in webkit [64477] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-02 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Group functions used in createMarkup (range version) into a class so they are easier to understand
​https://bugs.webkit.org/show_bug.cgi?id=43227

Added MarkupAccumulatorWrapper to group getStartMarkup, getEndMarkup, joinMarkups, and addStyleMarkup.
MarkupAccumulatorWrapper is intended to be merged with MarkupAccumulator in the future.

No new tests added since this is a clean up.

  • editing/markup.cpp: (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Added. (WebCore::MarkupAccumulatorWrapper::insertString): Added. (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Added. (WebCore::MarkupAccumulatorWrapper::insertEndTag): Added. (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Added. (WebCore::MarkupAccumulatorWrapper::wrapWithStyleNode): Added. (WebCore::MarkupAccumulatorWrapper::takeResults): Added. (WebCore::createMarkup): Uses MarkupAccumulatorWrapper.
11:04 AM Changeset in webkit [64476] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Add a missing </File> tag to WebCore.vcproj.

  • WebCore.vcproj/WebCore.vcproj:
10:53 AM Changeset in webkit [64475] by commit-queue@webkit.org
  • 8 edits in trunk

2010-08-02 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement support for get_character_extents and get_range_extents
​https://bugs.webkit.org/show_bug.cgi?id=25677

Implement get_range_extents() and modify get_character_extents()
to properly work after "The Great Flattening" occurred in the ATK
objects hierarchy, some months ago.

In the case of the GTK port, not just the text controls should be
considered when it comes to these functions but also those
composite objects that would also allow to work with text ranges,
such as headings and links. To take care of this, a new function
AccessibilityObject::allowsTextRanges() was defined with a default
implementation in the header file and an specific one for GTK in
AccessibilityObjectAtk.cpp.

Based on a previous patch by Joanmarie Diggs.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::allowsTextRanges): New
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex): (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): New
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textExtents): (webkit_accessible_text_get_character_extents): (webkit_accessible_text_get_range_extents): (atk_text_interface_init):

2010-08-02 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement support for get_character_extents and get_range_extents
​https://bugs.webkit.org/show_bug.cgi?id=25677

Added new unit tests to check get_character_extents and
get_range_extents functions for the ATK_TEXT interface

Based on a previous patch by Joanmarie Diggs.

  • tests/testatk.c: (test_webkit_atk_get_extents): (main):
10:52 AM Changeset in webkit [64474] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations change to mark test as failing on Chromium Linux.

  • platform/chromium/test_expectations.txt: Mark fast/events/keydown-numpad-keys.html as failing on Linux.
10:52 AM WebKit Team edited by tony@chromium.org
(diff)
10:28 AM Changeset in webkit [64473] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

[Qt] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=43365

  • platform/qt/Skipped: Skip these two tests which are failing on Qt, until a fix can be made.
10:24 AM Changeset in webkit [64472] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX: Support methods for web apps to interact with the native accessibility APIs
​https://bugs.webkit.org/show_bug.cgi?id=43005

Fix for windows build. No review.

  • WebCore.vcproj/WebCore.vcproj:
10:14 AM Changeset in webkit [64471] by Chris Fleizach
  • 21 edits
    8 adds in trunk

AX: Support methods for web apps to interact with the native accessibility APIs
​https://bugs.webkit.org/show_bug.cgi?id=43005

Reviewed by David Kilzer.

.:

  • GNUmakefile.am:

WebCore:

Adds a new "accessibility" object that hangs off of "window.navigator".
This accessibility object will allow web apps to interact with native accessibility APIs
to provide a richer experience (for screen reader users primarily).

Test: platform/mac/accessibility/js-accessibility.html

  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/Accessibility.cpp: Added.

(WebCore::Accessibility::Accessibility):
(WebCore::Accessibility::~Accessibility):
(WebCore::Accessibility::disconnectFrame):
(WebCore::Accessibility::screenChanged):
(WebCore::Accessibility::elementsChanged):
(WebCore::Accessibility::screenReader):

  • accessibility/Accessibility.h: Added.

(WebCore::Accessibility::create):

  • accessibility/Accessibility.idl: Added.
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isScreenReaderRunning):
(WebCore::AccessibilityObject::screenReaderFocusedElement):
(WebCore::AccessibilityObject::screenReaderVersion):

  • accessibility/ScreenReader.cpp: Added.

(WebCore::ScreenReader::ScreenReader):
(WebCore::ScreenReader::~ScreenReader):
(WebCore::ScreenReader::disconnectFrame):
(WebCore::ScreenReader::active):
(WebCore::ScreenReader::activeElement):
(WebCore::ScreenReader::version):

  • accessibility/ScreenReader.h: Added.

(WebCore::ScreenReader::create):

  • accessibility/ScreenReader.idl: Added.
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::isScreenReaderRunning):
(WebCore::AccessibilityObject::screenReaderFocusedElement):
(WebCore::AccessibilityObject::screenReaderVersion):

  • page/Navigator.cpp:

(WebCore::Navigator::disconnectFrame):
(WebCore::Navigator::accessibility):

  • page/Navigator.h:
  • page/Navigator.idl:

LayoutTests:

  • platform/mac/accessibility/js-accessibility-expected.txt: Added.
  • platform/mac/accessibility/js-accessibility.html: Added.
10:07 AM Changeset in webkit [64470] by Martin Robinson
  • 13 edits in trunk

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=35170

Modify some existing tests to test the generate key code of
the keypad insert and delete keys as well as the print screen key.

  • fast/events/keydown-numpad-keys-expected.txt: Update expectations.
  • fast/events/script-tests/keydown-numpad-keys.js: Add test for keypad insert and delete.
  • fast/events/special-key-events-in-input-text-expected.txt: Update expectations.
  • fast/events/special-key-events-in-input-text.html: Add test for print screen.

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=35170

Emit the proper DOM keyCode for the print screen, keypad insert,
and keypad delete keys.

  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix mapping between GDK key codes and Windows key codes.

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=35170

Add support to all event senders for simulating keypad insert
and print screen keys.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Add support for generating keypad insert and print screen.
  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Ditto.
  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown): Ditto.
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
9:59 AM Changeset in webkit [64469] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

Build fix for building against development versions of GTK+. GTK 2.22
has not yet been released, so these function definitions must be conditionalized
on the development version.

  • DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
9:48 AM Changeset in webkit [64468] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-02 Martin Robinson <​mrobinson@igalia.com>

[GTK] r64379 broke two tests
​https://bugs.webkit.org/show_bug.cgi?id=43361

Re-baseline these tests after r64379.

  • platform/gtk/svg/custom/massive-coordinates-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
9:45 AM Changeset in webkit [64467] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-02 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
9:26 AM Changeset in webkit [64466] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-02 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] use ChromiumDriver on Linux when running webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=43273

  • Scripts/webkitpy/layout_tests/port/chromium.py:
9:17 AM Changeset in webkit [64465] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-02 Kristian Monsen <​kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android, adding guards around filter specific code.
​https://bugs.webkit.org/show_bug.cgi?id=43338
This CL introduced the code:
​http://trac.webkit.org/changeset/64196

Compile fix only, no new tests.

  • rendering/SVGResourcesCycleSolver.cpp: (WebCore::SVGResourcesCycleSolver::breakCycle):
9:05 AM Changeset in webkit [64464] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-02 Kristian Monsen <​kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android, guard inspector code with ENABLE(INSPECTOR).
​https://bugs.webkit.org/show_bug.cgi?id=43345
Code introduced in this CL:
​http://trac.webkit.org/changeset/63891

No new tests, just a compile fix.

  • bindings/v8/ScriptValue.cpp:
8:10 AM Changeset in webkit [64463] by tkent@chromium.org
  • 8 edits in trunk

2010-08-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Always initialize GTK
​https://bugs.webkit.org/show_bug.cgi?id=43327

  • WebKit.gyp: Add GTK dependency for DRT.

2010-08-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Always initialize GTK
​https://bugs.webkit.org/show_bug.cgi?id=43327

Call gtk_init() in order to fix plugin test crash.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Pass argc/argv to platformInit().
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/TestShellGtk.cpp: (platformInit): Update parameters, call gtk_init().
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit): Update parameters.
  • DumpRenderTree/chromium/TestShellWin.cpp: (platformInit): Update parameters.
7:53 AM Changeset in webkit [64462] by jorlow@chromium.org
  • 68 edits
    21 deletes in trunk

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::create): (WebCore::PopupMenu::disconnectClient): (WebCore::PopupMenu::client): (WebCore::PopupMenu::scrollbar): (WebCore::PopupMenu::itemHeight): (WebCore::PopupMenu::windowRect): (WebCore::PopupMenu::popupHandle): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setScrollOffset): (WebCore::PopupMenu::scrollOffset): (WebCore::PopupMenu::wheelDelta): (WebCore::PopupMenu::scrollbarCapturingMouse): (WebCore::PopupMenu::setScrollbarCapturingMouse): (WebCore::PopupMenu::isActive): (WebCore::PopupMenu::scrollbarCornerPresent):
  • platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::create):
  • platform/brew/PopupMenuBrew.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/brew/PopupMenuBrew.h: Removed.
  • platform/brew/SearchPopupMenuBrew.cpp: (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled):
  • platform/brew/SearchPopupMenuBrew.h: Removed.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/chromium/PopupMenuChromium.h:
  • platform/chromium/SearchPopupMenuChromium.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/chromium/SearchPopupMenuChromium.h: Removed.
  • platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/efl/PopupMenuEfl.h: Removed.
  • platform/efl/SearchPopupMenuEfl.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/efl/SearchPopupMenuEfl.h: Removed.
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::menuItemActivated): (WebCore::PopupMenu::menuUnmapped): (WebCore::PopupMenu::menuPositionFunction): (WebCore::PopupMenu::menuRemoveItem):
  • platform/gtk/PopupMenuGtk.h: Removed.
  • platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/gtk/SearchPopupMenuGtk.h: Removed.
  • platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/haiku/PopupMenuHaiku.h: Removed.
  • platform/haiku/SearchPopupMenuHaiku.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/haiku/SearchPopupMenuHaiku.h: Removed.
  • platform/mac/PopupMenuMac.h: Removed.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/mac/SearchPopupMenuMac.h: Removed.
  • platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/qt/PopupMenuQt.h: Removed.
  • platform/qt/QtAbstractWebPopup.h:
  • platform/qt/SearchPopupMenuQt.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/qt/SearchPopupMenuQt.h: Removed.
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::popupClassName): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::visibleItems): (WebCore::PopupMenu::listIndexAtPoint): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::invalidateItem): (WebCore::PopupMenu::clientRect): (WebCore::PopupMenu::incrementWheelDelta): (WebCore::PopupMenu::reduceWheelDelta): (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::paint): (WebCore::PopupMenu::valueChanged): (WebCore::PopupMenu::invalidateScrollbarRect): (WebCore::PopupMenu::registerClass): (WebCore::PopupMenu::PopupMenuWndProc): (WebCore::PopupMenu::wndProc):
  • platform/win/PopupMenuWin.h: Removed.
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/win/SearchPopupMenuWin.h: Removed.
  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::OnMenuItemSelected): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/wx/PopupMenuWx.h: Removed.
  • platform/wx/SearchPopupMenuWx.cpp: (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/wx/SearchPopupMenuWx.h: Removed.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): (WebCore::RenderMenuList::showPopup):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::valueChanged):
  • rendering/RenderTextControlSingleLine.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • tests/PopupMenuTest.cpp: (WebKit::SelectPopupMenuTest::SetUp):

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: (WebView::mouseWheel):

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Speculative revert of 64425 due to Chromium instability
​https://bugs.webkit.org/show_bug.cgi?id=43347

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
  • WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
  • win/WebKit2.vcproj:
7:48 AM Changeset in webkit [64461] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-02 Markus Goetz <​Markus.Goetz@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Do not link to SharedBufferCF.cpp
The Qt port does not need this file.
We plan to implement the platformData()
for SharedBuffer at some point soon.
​https://bugs.webkit.org/show_bug.cgi?id=43242

  • WebCore.pro:
  • platform/SharedBuffer.cpp:
7:35 AM QtWebKitTriageRoster edited by alexis.menard@nokia.com
(diff)
7:32 AM Changeset in webkit [64460] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

2010-08-02 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Generate forwarding headers for WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=43336

  • DerivedSources.pro: Added WebKit2/DerivedSources.pro to SUBDIRS if webkit2 is on.

2010-08-02 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Generate forwarding headers for WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=43336

  • WebCore.pri: Removed header copying logic.
  • WebCore.pro: Add include paths for WebKit2.

2010-08-02 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Generate forwarding headers for WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=43336

  • DerivedSources.pro: Added.

2010-08-02 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Generate forwarding headers for WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=43336

  • Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
6:44 AM Changeset in webkit [64459] by loislo@chromium.org
  • 4 edits in trunk/LayoutTests

2010-08-02 Ilya Tikhonovsky <​loislo@chromium.org>

Not reviewed. Build fix.

WebInspector: 2 Inspector extensions tests are failing at Qt/GTK/Chromium.
The tests were temporary disabled. Bug was created.
​https://bugs.webkit.org/show_bug.cgi?id=43344

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
5:55 AM Changeset in webkit [64458] by loislo@chromium.org
  • 17 edits
    1 copy
    12 adds in trunk

ndrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: adding experimental support for WebInspector extensions API.
​https://bugs.webkit.org/show_bug.cgi?id=40425

Tests: inspector/extensions-api.html

inspector/extensions.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
  • inspector/front-end/ExtensionAPI.js: Added. An API implementation that gets injected into the extension context. (injectedExtensionAPI): (injectedExtensionAPI.EventSinkImpl.prototype.addListener): (injectedExtensionAPI.EventSinkImpl.prototype.removeListener): (injectedExtensionAPI.EventSinkImpl.prototype._fire): (injectedExtensionAPI.EventSink): (injectedExtensionAPI.InspectorExtensionAPI): (injectedExtensionAPI.InspectorExtensionAPI.prototype.log): (injectedExtensionAPI.Resources.prototype.getAll): (injectedExtensionAPI.Resources.prototype.get return): (injectedExtensionAPI.Resources.prototype): (injectedExtensionAPI.Panels): (injectedExtensionAPI.Panels.prototype.create.callbackWrapper): (injectedExtensionAPI.Panels.prototype.create): (injectedExtensionAPI.PanelImpl): (injectedExtensionAPI.PanelImpl.prototype.createSidebarPane.callbackWrapper): (injectedExtensionAPI.PanelImpl.prototype.createSidebarPane): (injectedExtensionAPI.ExtensionPanel): (injectedExtensionAPI.ExtensionSidebarPaneImpl): (injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight): (injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpanded): (injectedExtensionAPI.InspectedWindow): (injectedExtensionAPI.InspectedWindow.prototype.reload): (injectedExtensionAPI.InspectedWindow.prototype.evaluate): (injectedExtensionAPI.ExtensionServerClient.prototype.sendRequest): (injectedExtensionAPI.ExtensionServerClient.prototype.registerHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.nextObjectId): (injectedExtensionAPI.ExtensionServerClient.prototype._registerCallback): (injectedExtensionAPI.ExtensionServerClient.prototype._onCallback): (injectedExtensionAPI.ExtensionServerClient.prototype._onMessage): (injectedExtensionAPI.expandURL): (injectedExtensionAPI.):
  • inspector/front-end/ExtensionPanel.js: Added. A class that provides WebInspector's Panel interface to the inspector, hosts extension panel within an IFrame and proxies Panel callbacks to the extension

.

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get defaultFocusedElement):
(WebInspector.ExtensionPanel.prototype.updateMainViewWidth):
(WebInspector.ExtensionPanel.prototype.searchCanceled):
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ExtensionPanel.prototype._addStyleRule):

  • inspector/front-end/ExtensionRegistryStub.js: Added. A stub for ExtensionRegistry class that is meant to provide a list of extensions. Actual implementations may be browser-specfic. (.WebInspector.InspectorExtensionRegistryStub): (.WebInspector.InspectorExtensionRegistryStub.prototype.getExtensionsAsync):
  • inspector/front-end/ExtensionServer.js: Added. Communicates with ExtensionAPI via DOM messaging and proxies requests to WebInspector classes. (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyPanelShown): (WebInspector.ExtensionServer.prototype.notifyObjectSelected): (WebInspector.ExtensionServer.prototype.notifyResourceFinished): (WebInspector.ExtensionServer.prototype.notifySearchAction): (WebInspector.ExtensionServer.prototype.notifyInspectedPageLoaded): (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged): (WebInspector.ExtensionServer.prototype.notifyInspectorReset): (WebInspector.ExtensionServer.prototype._convertResource): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._onSubscribe): (WebInspector.ExtensionServer.prototype._onUnsubscribe): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onCreateSidebar): (WebInspector.ExtensionServer.prototype._createClientIframe): (WebInspector.ExtensionServer.prototype._onSetSidebarHeight): (WebInspector.ExtensionServer.prototype._onSetSidebarExpansion): (WebInspector.ExtensionServer.prototype._onLog): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): (WebInspector.ExtensionServer.prototype._onRevealAndSelect): (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._dispatchCallback): (WebInspector.ExtensionServer.prototype._onGetResources): (WebInspector.ExtensionServer.prototype.initExtensions): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._onmessage): (WebInspector.ExtensionServer.prototype._registerHandler): (WebInspector.ExtensionStatus): (WebInspector.addExtensions):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.setExtensionAPI): (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource): (WebInspector.reset): (WebInspector.inspectedURLChanged): (WebInspector.didCommitLoad):

2010-08-02 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: adding tests for WebInspector extensions API.
​https://bugs.webkit.org/show_bug.cgi?id=40425

  • http/tests/inspector/inspector-test.js: (dumpObject):
  • inspector/extensions-api-expected.txt: Added.
  • inspector/extensions-api.html: Added.
  • inspector/extensions-expected.txt: Added.
  • inspector/extensions-test.js: Added. (log): (frontend_initializeExtension): (doit): (done.callback): (done): (extensionFunctions):
  • inspector/extensions.html: Added.
  • inspector/resources/extension-main.html: Added.
  • inspector/resources/extension-main.js: Added. (fetchTests.callback): (fetchTests): (runTests): (onTestsDone): (runTest): (callbackAndNextTest.callbackWrapper): (callbackAndNextTest): (output):
  • inspector/resources/extension-panel.html: Added.
  • inspector/resources/extension-sidebar.html: Added.
  • platform/chromium/test_expectations.txt:
5:29 AM Changeset in webkit [64457] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Inspector is not working when it is loaded as html page.
​https://bugs.webkit.org/show_bug.cgi?id=43334

  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow): (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
5:21 AM Changeset in webkit [64456] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-02 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Simon Hausmann.

[QT] build fix for symbian
​https://bugs.webkit.org/show_bug.cgi?id=43234

1) wrong order of passing param's
2) static_cast complains on symbian so using reinterpret_cast

No new tests added. Just a build fix for qt symbian

  • wtf/PageAllocation.cpp: (WTF::PageAllocation::commit): (WTF::PageAllocation::decommit): (WTF::PageAllocation::reserve):
5:08 AM Changeset in webkit [64455] by Csaba Osztrogonác
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected files after r64432.
​https://bugs.webkit.org/show_bug.cgi?id=43061

  • platform/qt/editing/undo/redo-style-expected.checksum: Added.
  • platform/qt/editing/undo/redo-style-expected.png: Added.
  • platform/qt/editing/undo/redo-style-expected.txt: Copied from LayoutTests/editing/undo/redo-style-expected.txt.
4:07 AM Changeset in webkit [64454] by Csaba Osztrogonác
  • 1 edit
    2 copies
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected files for tests introduced in r64379.

  • platform/qt/svg/custom/massive-coordinates-expected.checksum: Added.
  • platform/qt/svg/custom/massive-coordinates-expected.png: Added.
  • platform/qt/svg/custom/massive-coordinates-expected.txt: Copied from LayoutTests/svg/custom/massive-coordinates-expected.txt.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
3:13 AM Changeset in webkit [64453] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Kent Tamura.

WebSocket server should start with SO_REUSEADDR
​https://bugs.webkit.org/show_bug.cgi?id=43329

Pulls in pywebsocket-0.5.2.
pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
​http://code.google.com/p/pywebsocket/source/detail?r=273

  • Scripts/webkitpy/thirdparty/init.py: Bump pywebsocket version
3:01 AM Changeset in webkit [64452] by jorlow@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-08-02 Jeremy Orlow <​jorlow@chromium.org>

Another SVG rebaseline for Win/Linux because of different fonts.
Not reviewed.

  • platform/chromium-linux/svg/custom/js-update-stop-linked-gradient-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/js-update-stop-linked-gradient-expected.png: Added.
  • platform/chromium-win/svg/custom/js-update-stop-linked-gradient-expected.checksum: Added.
  • platform/chromium-win/svg/custom/js-update-stop-linked-gradient-expected.png: Added.
  • platform/chromium-win/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.