⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 8, 2010:

11:56 PM Changeset in webkit [64966] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Darin Adler.

REGRESSION(64898,64949) build break because of wrong filename
​https://bugs.webkit.org/show_bug.cgi?id=43701

add SVGPathStringSource.cpp and modify SVGPathSourceString.cpp to
SVGPathStringSource.cpp

simple fixing build break, so No new tests.

  • CMakeLists.txt:
10:47 PM Changeset in webkit [64965] by ariya@webkit.org
  • 15 edits in trunk

2010-08-08 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Antonio Gomes.

Inconsistent Qt version checks
​https://bugs.webkit.org/show_bug.cgi?id=43695

Use QT_VERSION_CHECK macro instead of encoded hex.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebViewPrivate::detachCurrentPage):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery): (QWebPage::view):
  • Api/qwebview.cpp: (QWebViewPrivate::detachCurrentPage):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/PageClientQt.h:
10:43 PM Changeset in webkit [64964] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43698

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): Add suggested parentheses.
10:26 PM Changeset in webkit [64963] by morrita@google.com
  • 10 edits
    3 adds in trunk

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • editing/pasteboard/paste-text-events-expected.txt: Added.
  • editing/pasteboard/paste-text-events.html: Added.
  • editing/pasteboard/script-tests/paste-text-events.js: Added.

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • Extended TextEvents to hold paste-specific parameters
  • Did fire TextEvents at where we originally did immediate pastes.
  • Factored out TextEvent handling from EventHandler::defaultTextInputEventHandler() to Editor::handleTextEvent() because it's solely done by the editor.
  • move actual pasting logic to Editor::handleTextEvent()

Test: editing/pasteboard/paste-text-events.html

  • WebCore.exp.in:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isPaste): (WebCore::TextEvent::shouldSmartReplace): (WebCore::TextEvent::shouldMatchStyle): (WebCore::TextEvent::pastingFragment):
  • editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::findEventTargetFromSelection):
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

On paste, invoke Editor instead of direct command invocation,
which allows dispatching events before actual paste.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
9:29 PM Changeset in webkit [64962] by morrita@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Should have test: textInput should not fired when preceding key events are cancelled.
​https://bugs.webkit.org/show_bug.cgi?id=43601

  • fast/events/inputText-never-fired-on-keydown-cancel-expected.txt: Added.
  • fast/events/inputText-never-fired-on-keydown-cancel.html: Added.
  • fast/events/script-tests/inputText-never-fired-on-keydown-cancel.js: Added. (handleTextInput): (mayCancel): (setup): (test):
9:05 PM Changeset in webkit [64961] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, trivial fix.

Fix "WindowsError: [Error 32] The process cannot access the file
because it is being used by another process" introduced by r64959.

  • BuildSlaveSupport/test-result-archive:
7:16 PM Changeset in webkit [64960] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
6:26 PM Changeset in webkit [64959] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium buildbot: Avoid "zip" command dependency
​https://bugs.webkit.org/show_bug.cgi?id=43470

Reviewed by Tony Chang.

  • BuildSlaveSupport/test-result-archive: For Chromium port, creates a zip archive with zipfile package of Python instead of external "zip" command. We'd like to avoid additional command installation.
6:12 PM Changeset in webkit [64958] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, add member needed to compile Mac-specific font code.

3:27 PM Changeset in webkit [64957] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

[Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h
​https://bugs.webkit.org/show_bug.cgi?id=43360

  • platform/WindowsKeyboardCodes.h: Undef macros which are also defined in MinGW/include/winuser.h to aviod gcc redefinition warning
1:30 PM Changeset in webkit [64956] by jamesr@google.com
  • 9 edits in trunk/LayoutTests

2010-08-08 James Robinson <​jamesr@chromium.org>

Unreviewed. Rebaseline chromium results for r64954.

  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/invalid/003-expected.txt:
  • platform/chromium-win/fast/invalid/019-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [64955] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Add more items to WebKit2 skipped list.

Rubber stamped by Sam Weinig.

  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [64954] by jamesr@google.com
  • 11 edits in trunk

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
builder's adoption agency flag. This is a speedup assuming that nodes subjected
to the adoption agency are likely to be frequently reparented, and thus it is better
to delay creating the render tree until later (when hopefully the DOM is finalized).

On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

New baselines for tests where the render tree depends on 0x0 render objects being
created/destroyed during adoption agency fixups.

  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/invalid/003-expected.txt:
  • platform/mac/fast/invalid/019-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug647-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
10:56 AM Changeset in webkit [64953] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

fast/events/onunload-back-to-page-cache.html does not pass with GTK DRT
​https://bugs.webkit.org/show_bug.cgi?id=43692

Update onunload-back-to-page-cache.html to set the frame name later,
so that the onunload handler console message doesn't have it. Also
include a message about what exactly we're testing.

  • fast/events/onunload-back-to-page-cache-expected.txt:
  • fast/events/script-tests/onunload-back-to-page-cache.js: (onpageshow):
10:45 AM Changeset in webkit [64952] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: speed-up Element.prototype.removeChildren
​https://bugs.webkit.org/show_bug.cgi?id=43687

  • inspector/front-end/utilities.js: (Element.prototype.removeChildren):
9:47 AM Changeset in webkit [64951] by loislo@chromium.org
  • 11 edits in trunk/WebCore

2010-08-08 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: remove hand written InspectorFrontend from almost all places.
​https://bugs.webkit.org/show_bug.cgi?id=43630

  • inspector/ConsoleMessage.cpp:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/TimelineRecordFactory.cpp:
9:41 AM Changeset in webkit [64950] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Chromium Mac build after r64915.

  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm:

(WebCore::FontPlatformData::ctFont): Copied from mac/FontPlatformDataMac.mm.

9:10 AM Changeset in webkit [64949] by krit@webkit.org
  • 18 edits
    2 adds in trunk/WebCore

2010-08-08 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add missing String builder for SVGPathParser
​https://bugs.webkit.org/show_bug.cgi?id=43682

Introduces SVGPathStringBuilder. SVGPathParser clients, like normalized and unaltered
SVGPathSegLists or SVGPathByteStreams, can be parsed and transformed to a string.
StringBuilder can create a string of individual strings, seperated by spaces now.
Share more code in SVGPathParserFactory and use a common general concept to manage SVG path
data parsing.

Doesn't affect any tests.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString): Added possibility to use a space between individual strings.
  • platform/text/StringBuilder.h: Cleanup according to WebKit style. (WebCore::): (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::setNonNull): (WebCore::StringBuilder::isNull):
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::cleanup): Clear all references.
  • svg/SVGPathByteStreamBuilder.h: (WebCore::SVGPathByteStreamBuilder::cleanup): dito.
  • svg/SVGPathConsumer.h:
  • svg/SVGPathParser.cpp: (WebCore::SVGPathParser::cleanup): dito.
  • svg/SVGPathParser.h:
  • svg/SVGPathParserFactory.cpp: Cleanup of factory. More code get shared. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathByteStreamBuilder): (WebCore::globalSVGPathStringBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathStringBuilder.cpp: Added. Build string from parsed SVG data. (WebCore::SVGPathStringBuilder::SVGPathStringBuilder): (WebCore::SVGPathStringBuilder::moveTo): (WebCore::SVGPathStringBuilder::lineTo): (WebCore::SVGPathStringBuilder::lineToHorizontal): (WebCore::SVGPathStringBuilder::lineToVertical): (WebCore::SVGPathStringBuilder::curveToCubic): (WebCore::SVGPathStringBuilder::curveToCubicSmooth): (WebCore::SVGPathStringBuilder::curveToQuadratic): (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth): (WebCore::SVGPathStringBuilder::arcTo): (WebCore::SVGPathStringBuilder::closePath):
  • svg/SVGPathStringBuilder.h: Added. (WebCore::SVGPathStringBuilder::cleanup): (WebCore::SVGPathStringBuilder::result):
1:32 AM Changeset in webkit [64948] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKitTools

WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
​https://bugs.webkit.org/show_bug.cgi?id=43686

Reviewed by Dan Bernstein.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().

  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Link to shlwapi.lib for SHGetValue.

1:07 AM Changeset in webkit [64947] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069)
​https://bugs.webkit.org/show_bug.cgi?id=43040

The pointer from Document to Frame can be null. See ​http://webkit.org/coding/major-objects.html.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:55 AM Changeset in webkit [64946] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

frame()->selection() can't be null
​https://bugs.webkit.org/show_bug.cgi?id=43681

SelectionController is a component of Frame. If frame is non-null, it
can't possibly be null.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive):
12:45 AM Changeset in webkit [64945] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

Send invalid input to trigger old ASSERTs.

  • svg/dom/svg-length-units-expected.txt: Added.
  • svg/dom/svg-length-units.html: Added.

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

ASSERTs aren't in release builds, so we can't use them to validate user
input! We've seen a bunch of examples of this in SVG code. It might
be worth auditing all the code to remove this misguided pattern.

Test: svg/dom/svg-length-units.html

  • svg/SVGLength.cpp: (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits):
12:33 AM Changeset in webkit [64944] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Chromium: isindex tests timeout after r64712
​https://bugs.webkit.org/show_bug.cgi?id=43543

Update isindex tests/expectactions after r64712 so that even though they
stil fail, they fail immediately instead of timing out.

  • http/tests/misc/isindex-formdata-expected.txt:
  • http/tests/misc/isindex-formdata.html:
  • http/tests/misc/isindex-with-no-form-base-href-expected.txt:
  • http/tests/misc/resources/isindex-with-no-form-base-href.html:
12:22 AM Changeset in webkit [64943] by eric@webkit.org
  • 21 edits
    1 delete in trunk/JavaScriptCore

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64938.
​http://trac.webkit.org/changeset/64938
​https://bugs.webkit.org/show_bug.cgi?id=43685

Did not compile on several ports (Requested by abarth on
#webkit).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
  • jit/JIT.h:
  • jit/JITMarkObjects.cpp: Removed.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
  • wtf/Platform.h:

Aug 7, 2010:

11:58 PM Changeset in webkit [64942] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Empty strings can have more than one ref
​https://bugs.webkit.org/show_bug.cgi?id=43666

These asserts are trying to say that we have a thread-safe copy of the
string, but they're not accurate for empty strings because we use a
special static empty string that magically has infinite refs.

  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::addDatabase): (WebCore::OriginUsageRecord::markDatabase):
11:45 PM Changeset in webkit [64941] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Add KURL parameter to WMLDocument::create()
​https://bugs.webkit.org/show_bug.cgi?id=43173

To fix build break in WML, url parameter is added. Because,
Document class has url parameter.

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
  • wml/WMLDocument.h: (WebCore::WMLDocument::create): Add an url parameter to create() method
11:32 PM Changeset in webkit [64940] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Change getIDAttribute() with getIdAttribute()
​https://bugs.webkit.org/show_bug.cgi?id=43175

Change getIDAttribute() with getIdAttribute() because function
name was changed.

  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::findNamedCardInDocument): Change getIDAttribute() with getIdAttribute().
11:19 PM Changeset in webkit [64939] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-08-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

WebTiming does not take page cache into account
​https://bugs.webkit.org/show_bug.cgi?id=42772

Adds tests that simulates flow from a page that's in the page cache to
one that's not, and then back to the page cached page (where the
DocumentLoader is reused, but we should have a new DocumentLoadTiming
struct).

  • fast/events/onunload-back-to-page-cache-expected.txt: Added.
  • fast/events/onunload-back-to-page-cache.html: Added.

2010-08-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

WebTiming does not take page cache into account
​https://bugs.webkit.org/show_bug.cgi?id=42772

When restoring a page from the page cache, reset its DocumentLoadTiming
struct and record navigationStart.

Test: fast/events/onunload-back-to-page-cache.html

  • loader/DocumentLoadTiming.h: removed Noncopyable, since it's just a simple struct.
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::resetTiming): Added method.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Uncommented assert. (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): Added resetTiming() call.
11:04 PM Changeset in webkit [64938] by eric@webkit.org
  • 21 edits
    1 add in trunk/JavaScriptCore

2010-08-07 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

The JIT code contains a number of direct references to GC'd objects.
When we have movable objects, these references will need to be
updated.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::int32AtLocation): (JSC::AbstractMacroAssembler::pointerAtLocation): (JSC::AbstractMacroAssembler::jumpTarget):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithPatch):

Normally, loadPtr will optimize when the register is eax. Since
the slightly smaller instruction changes the offsets, it messes up
our ability to repatch the code. We added this new instruction
that garuntees a constant size.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32WithPatch):

Changed load32 in the same way described above.

(JSC::MacroAssemblerX86::load32):

Moved the logic to optimize laod32 from movl_mr to load32

(JSC::MacroAssemblerX86::store32):

Moved the logic to optimize store32 from movl_rm to store32

  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::int32AtLocation): (JSC::X86Assembler::pointerAtLocation): (JSC::X86Assembler::jumpTarget):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h:

As described in StructureStubInfo.h, we needed to add additional
fields to both StructureStubInfo and
PolymorphicAccessStructureList so that we can determine the
structure of the JITed code at patch time.

(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::markAggregate):

Added this function to mark the JITed code that correosponds to
this structure stub info.

  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
  • jit/JIT.h:
  • jit/JITMarkObjects.cpp: Added. (JSC::JIT::patchPrototypeStructureAddress): (JSC::JIT::patchGetDirectOffset): (JSC::JIT::markGetByIdProto): (JSC::JIT::markGetByIdChain): (JSC::JIT::markGetByIdProtoList): (JSC::JIT::markPutByIdTransition): (JSC::JIT::markGlobalObjectReference):
  • jit/JITPropertyAccess.cpp:

Added asserts for the patch offsets.

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
  • wtf/Platform.h:

Added ENABLE_MOVABLE_GC_OBJECTS flag

10:29 PM Changeset in webkit [64937] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-08-07 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Revert JSArray to point to the beginning of the contained ArrayStorage
struct. This is described in
​https://bugs.webkit.org/show_bug.cgi?id=43526.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::~JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::getOwnPropertyNames): (JSC::JSArray::getNewVectorLength): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::increaseVectorPrefixLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::shiftCount): (JSC::JSArray::unshiftCount): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting): (JSC::JSArray::subclassData): (JSC::JSArray::setSubclassData): (JSC::JSArray::checkConsistency):
  • runtime/JSArray.h: (JSC::JSArray::length): (JSC::JSArray::canGetIndex): (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
10:01 PM Changeset in webkit [64936] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for EventHandlingState struct
​https://bugs.webkit.org/show_bug.cgi?id=43548

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

struct name - instantiated at: WebCore/
EventHandlingState - html/HTMLInputElement.cpp:2051

  • html/HTMLInputElement.cpp:
9:47 PM Changeset in webkit [64935] by eric@webkit.org
  • 5 edits in trunk

2010-08-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Remove unecessary focus code.
​https://bugs.webkit.org/show_bug.cgi?id=43542

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):

2010-08-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Eric Seidel.

Removed unecessary focus code.
​https://bugs.webkit.org/show_bug.cgi?id=43542

  • src/ChromiumBridge.cpp:
8:55 PM Changeset in webkit [64934] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-07 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Add ENABLE(YARR) guard around JSGlobalData::m_regexAllocator
​https://bugs.webkit.org/show_bug.cgi?id=43399

m_regexAllocator is used only by RegExp::compile which is guarded with ENABLE(YARR).

  • runtime/JSGlobalData.h:
8:25 PM Changeset in webkit [64933] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-07 Patrick Roland Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

[Qt] Enable JIT on WinCE
​https://bugs.webkit.org/show_bug.cgi?id=43303

Add ExtraCompiler for generating GeneratedJITStubs_MSVC.asm.

  • DerivedSources.pro:
8:13 PM Changeset in webkit [64932] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Include FormDataBuilder.h in WMLGoElement.h
​https://bugs.webkit.org/show_bug.cgi?id=43177

To fix build breaks in WMLGoElement.cpp, FormDataBuilder.h needs to be included.

  • wml/WMLGoElement.cpp: Include FormDataBuilder.h
8:00 PM Changeset in webkit [64931] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=43176

  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::defaultEventHandler): Sets NULL parameter to SelectElement::defaultEventHandler.
7:38 PM Changeset in webkit [64930] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Change DocumentParser with ScriptableDocumentParser in WMLDocument
​https://bugs.webkit.org/show_bug.cgi?id=43174

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing): Change DocumentParser with ScriptableDocumentParser.
7:22 PM Changeset in webkit [64929] by weinig@apple.com
  • 7 edits in trunk

WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
​https://bugs.webkit.org/show_bug.cgi?id=42683

Reviewed by Maciej Stachowiak.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):

LayoutTests:

  • platform/mac-wk2/Skipped:
6:59 PM Changeset in webkit [64928] by weinig@apple.com
  • 9 edits in trunk

WebKitTestRunner needs to print onunload handler information
<rdar://problem/8213831>
​https://bugs.webkit.org/show_bug.cgi?id=42703

Reviewed by Anders Carlsson.

WebKit2:

Add SPI to get the number of pending unload events.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetPendingUnloadCount):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::pendingUnloadCount):

  • WebProcess/WebPage/WebFrame.h:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::operator<<):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

LayoutTests:

  • platform/mac-wk2/Skipped:
4:26 PM Changeset in webkit [64927] by weinig@apple.com
  • 9 edits in trunk

Add additional loader client functions need to complete WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=43684

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):

WebKitTools:

Remove unnecessary and jarring underscores as well.

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didClearWindowObjectForFrame):
(didCreatePage):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3:47 PM Changeset in webkit [64926] by mitz@apple.com
  • 2 edits in trunk/WebCore

Use ctFont() to get the CTFont.

Reviewed by Sam Weinig.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

3:40 PM Changeset in webkit [64925] by abarth@webkit.org
  • 2 edits
    2 adds in trunk

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

document->documentElement can always be null
​https://bugs.webkit.org/show_bug.cgi?id=43677

This ASSERT is bogus.

  • css/StyleMedia.cpp: (WebCore::StyleMedia::matchMedium):
3:32 PM Changeset in webkit [64924] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another fix for the windows build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):

3:26 PM Changeset in webkit [64923] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references

to JSGCController.{cpp,h} relative to the build root.

3:25 PM Changeset in webkit [64922] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix windows build.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::platformLayer):

  • WebProcess/Plugins/PluginView.h:
2:42 PM Changeset in webkit [64921] by weinig@apple.com
  • 17 edits
    3 adds in trunk

WebKitTestRunner needs GCController
<rdar://problem/8213834>
​https://bugs.webkit.org/show_bug.cgi?id=42701

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGarbageCollectJavaScriptObjects):
(WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WKBundleGetJavaScriptObjectsCount):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::garbageCollectJavaScriptObjects):
(WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WebKit::InjectedBundle::javaScriptObjectsCount):

  • WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:

(WTR::setProperty):

  • WebKitTestRunner/InjectedBundle/GCController.cpp: Added.

(WTR::GCController::create):
(WTR::GCController::GCController):
(WTR::GCController::~GCController):
(WTR::GCController::wrapperClass):
(WTR::GCController::collect):
(WTR::GCController::collectOnAlternateThread):
(WTR::GCController::getJSObjectCount):
(WTR::GCController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/GCController.h: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::bundle):
(WTR::InjectedBundle::gcController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::keepWebHistory):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

  • platform/mac-wk2/Skipped: Remove now passing tests and add some failing tests.
2:41 PM Changeset in webkit [64920] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/8285090> First word on a line doesn’t hyphenate properly
​https://bugs.webkit.org/show_bug.cgi?id=43679

Reviewed by Anders Carlsson.

WebCore:

Test: fast/text/hyphenate-first-word.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): The character at lastSpace is not necessarily a whitespace character
before the current word. It can also be part of the word, such as when the word is the first
one on the line. Include the charcater at lastSpace in the string passed to lastHyphenLocation().

LayoutTests:

  • fast/text/hyphenate-first-word.html: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/mac/fast/text/hyphenate-locale-expected.checksum:
  • platform/mac/fast/text/hyphenate-locale-expected.png:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
1:54 PM Changeset in webkit [64919] by andersca@apple.com
  • 9 edits in trunk/WebKit2

CA drawing model support for Mac Plugins
​https://bugs.webkit.org/show_bug.cgi?id=43678
<rdar://problem/7929701>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle WKNVSupportsCompositingCoreAnimationPluginsBool and
NPNVsupportsCoreAnimationBool and return true if accelerated compositing is enabled.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
Call PluginController::isAcceleratedCompositingEnabled.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
If the plug-in uses the Core Animation drawing model, ask it for its layer.

(WebKit::NetscapePlugin::platformPaint):
Don't send draw events if the Core Animation drawing model is used.

(WebKit::NetscapePlugin::pluginLayer):
Return the plug-in layer.

  • WebProcess/Plugins/Plugin.h:

Add a pluginLayer pure virtual member function.

  • WebProcess/Plugins/PluginController.h:

Add an isAcceleratedCompositingEnabled pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
If the plug-in has a layer, enter compositing mode.

(WebKit::PluginView::platformLayer):
Ask the plug-in for its layer.

(WebKit::PluginView::isAcceleratedCompositingEnabled):
Call Settings::acceleratedCompositingEnabled.

  • WebProcess/Plugins/PluginView.h:
1:45 PM Changeset in webkit [64918] by weinig@apple.com
  • 10 edits in trunk/WebKit2

Delete key doesn't go Back in WebKit2
<rdar://problem/8272978>
​https://bugs.webkit.org/show_bug.cgi?id=43665

Reviewed by Anders Carlsson.

  • Adds support for delete key going back (mac only for now)
  • Adds support for command-left/command right going back/forward
  • Flesh out scrolling due to arrow keys on the mac to match old webkit.
  • Made performDefaultBehaviorForKeyEvent platform specific and added a boolean return value which will be used later to inform the UI process about what events have been processed.
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _wantsKeyDownForEvent:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::forwardItem):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

1:07 PM Changeset in webkit [64917] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKitTools/QtTestBrowser/launcherwindow.cpp

2010-08-07 Antonio Gomes <​tonikitoo@webkit.org>

Another unreviewed missing bit of r64673

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
12:18 PM Changeset in webkit [64916] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • platform/graphics/SimpleFontData.h:
11:59 AM Changeset in webkit [64915] by mitz@apple.com
  • 12 edits in trunk

Created a separate SimpleFontData constructor exclusively for SVG fonts and moved the CTFontRef
from SimpleFontData to FontPlatformData.
​https://bugs.webkit.org/show_bug.cgi?id=43674

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/Platform.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI here from WebCore/config.h.

WebCore:

  • config.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI from here to wtf/Platform.h.
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Use new SimpleFontData constructor for SVG fonts.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Separated into two constructors, one for
PlatformFontData-based fonts and one for SVG fonts.

  • platform/graphics/SimpleFontData.h: Moved the m_CTFont member variable and the getCTFont()

accessor from here…

  • platform/graphics/mac/FontPlatformData.h: …to here, renaming the latter ctFont().
  • platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Copy m_CTFont.
(WebCore::FontPlatformData::operator=): Copy m_CTFont.
(WebCore::FontPlatformData::setFont): Clear m_CTFont.
(WebCore::FontPlatformData::ctFont): Moved here from SimpleFontDataCoreText.cpp and renamed.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes): Updated to use FontPlatformData::ctFont().

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::SVGFontData): Added an assertion.

11:00 AM Changeset in webkit [64914] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos in the change log

10:52 AM Changeset in webkit [64913] by abarth@webkit.org
  • 6 edits in trunk

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Regression: Memory corruption in tree builder
​https://bugs.webkit.org/show_bug.cgi?id=43672

Turns out this ASSERT was wrong and we need the branch. Yay for
test-driven development.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Regression: Memory corruption in tree builder
​https://bugs.webkit.org/show_bug.cgi?id=43672

  • html5lib/resources/adoption02.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
10:34 AM Changeset in webkit [64912] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Bitmap.h has no default constructor
​https://bugs.webkit.org/show_bug.cgi?id=43619

Reviewed by Eric Seidel.

Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.

Csaba Osztrogonác helped to find this bug.

  • wtf/Bitmap.h:

(WTF::::Bitmap):

8:57 AM Changeset in webkit [64911] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Unreviewed build-fix.

Come up with a more efficient way to represent Path segments
​https://bugs.webkit.org/show_bug.cgi?id=41159

Landed wrong version of the patch.

  • svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData):
  • svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::createSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
8:33 AM Changeset in webkit [64910] by Dimitri Glazkov
  • 1 edit
    7 adds in trunk/LayoutTests

2010-08-07 Dimitri Glazkov <Dimitri Glazkov>

[Chromium]: Added port-specific expectations after ​http://trac.webkit.org/changeset/64901.
​https://bugs.webkit.org/show_bug.cgi?id=41596

  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
8:17 AM Changeset in webkit [64909] by krit@webkit.org
  • 11 edits
    5 adds in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Come up with a more efficient way to represent Path segments
​https://bugs.webkit.org/show_bug.cgi?id=41159

Introduce SVGPathByteStream as a fast and efficient way to organize the synchronization
of Path, SVG path data string and SVGPathSegList in normalized and unaltered modes.
Extended SVGPathParserFactory to accept SVGPathByteStreams as input source and to create
a SVGPathByteStream from a SVG path data string.

Doesn't affect any tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathByteStream.h: Added. (WebCore::): (WebCore::SVGPathByteStream::create): (WebCore::SVGPathByteStream::data): (WebCore::SVGPathByteStream::begin): (WebCore::SVGPathByteStream::end): (WebCore::SVGPathByteStream::append): (WebCore::SVGPathByteStream::clear): (WebCore::SVGPathByteStream::isEmpty): (WebCore::SVGPathByteStream::SVGPathByteStream):
  • svg/SVGPathByteStreamBuilder.cpp: Added. (WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder): (WebCore::SVGPathByteStreamBuilder::moveTo): (WebCore::SVGPathByteStreamBuilder::lineTo): (WebCore::SVGPathByteStreamBuilder::lineToHorizontal): (WebCore::SVGPathByteStreamBuilder::lineToVertical): (WebCore::SVGPathByteStreamBuilder::curveToCubic): (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth): (WebCore::SVGPathByteStreamBuilder::curveToQuadratic): (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth): (WebCore::SVGPathByteStreamBuilder::arcTo): (WebCore::SVGPathByteStreamBuilder::closePath):
  • svg/SVGPathByteStreamBuilder.h: Added. (WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): (WebCore::SVGPathByteStreamBuilder::writeType): (WebCore::SVGPathByteStreamBuilder::writeFlag): (WebCore::SVGPathByteStreamBuilder::writeFloat): (WebCore::SVGPathByteStreamBuilder::writeFloatPoint): (WebCore::SVGPathByteStreamBuilder::writeSegmentType):
  • svg/SVGPathByteStreamSource.cpp: Added. (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::~SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData): (WebCore::SVGPathByteStreamSource::parseFloat): (WebCore::SVGPathByteStreamSource::parseFlag): (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand):
  • svg/SVGPathByteStreamSource.h: Added. (WebCore::SVGPathByteStreamSource::create): (WebCore::SVGPathByteStreamSource::readType): (WebCore::SVGPathByteStreamSource::readFlag): (WebCore::SVGPathByteStreamSource::readFloat): (WebCore::SVGPathByteStreamSource::readSVGSegmentType): (WebCore::SVGPathByteStreamSource::readFloatPoint):
  • svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathByteStreamBuilder): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
6:03 AM Changeset in webkit [64908] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
5:42 AM Changeset in webkit [64907] by victorw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-06 Victor Wang <​victorw@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add dllimport/dllexport to WebSpeechInputControllerMock::create
so it works for windows dll build.

​https://bugs.webkit.org/show_bug.cgi?id=43627

  • public/WebSpeechInputControllerMock.h:
5:22 AM Changeset in webkit [64906] by abecsi@webkit.org
  • 7 edits
    3 deletes in trunk

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebCore.pri:
  • WebCore.pro:
  • features.pri: Removed.

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebKit.pro:

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebKit2.pri: Removed.
  • WebKit2.pro:
  • WebProcess.pro: Removed.
4:47 AM Changeset in webkit [64905] by abecsi@webkit.org
  • 5 edits in trunk/WebKit2

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

NPAPI headers should be included through npruntime_internal.h

​https://bugs.webkit.org/show_bug.cgi?id=43620

  • DerivedSources.pro:
  • WebProcess/Plugins/NPJSObject.h:
  • WebProcess/Plugins/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
4:44 AM Changeset in webkit [64904] by abecsi@webkit.org
  • 7 edits
    3 adds in trunk

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

Just build changes so no new tests.

  • WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
  • WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
  • features.pri: Added.

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
  • WebKit2.pro: Build specification for the WebKit2 framework.
  • WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.
2:32 AM Changeset in webkit [64903] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update DRT expectation.
2:28 AM Changeset in webkit [64902] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Remove workarounds in two dynamic-updates scripts, that now work without it.

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js:
  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js:
2:25 AM Changeset in webkit [64901] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)

Test: http/tests/misc/slow-loading-image-in-pattern.html

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Added test verifying that resources are properly updated, if an image child element has changed.

  • http/tests/misc/slow-loading-image-in-pattern.html: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
2:17 AM Changeset in webkit [64900] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-07 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt: Rebaseline for r64890.
12:13 AM Changeset in webkit [64899] by Nikolas Zimmermann
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-08-07 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove obsolete baselines for win-xp and win-vista, all windows platforms are the same for this test
​https://bugs.webkit.org/show_bug.cgi?id=43669

  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
Note: See TracTimeline for information about the timeline view.