⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 9, 2010:

11:59 PM Changeset in webkit [65053] by yurys@chromium.org
  • 13 edits
    2 deletes in trunk

2010-08-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
​https://bugs.webkit.org/show_bug.cgi?id=43726

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: Removed.
  • inspector/InspectorFrontend.h: Removed.

2010-08-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
​https://bugs.webkit.org/show_bug.cgi?id=43726

  • http/tests/inspector/inspector-test.js: (notifyDone):
10:50 PM Changeset in webkit [65052] by loislo@chromium.org
  • 15 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove obsolete JS wrappers for did* methods.
​https://bugs.webkit.org/show_bug.cgi?id=43738

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/Callback.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptView.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
10:13 PM Changeset in webkit [65051] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix Qt/ARM again, this time including the other changed file.

9:00 PM Changeset in webkit [65050] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

eviewed by Ariya Hidayat.

[Qt] QtTestBrowser: proper set scene rect

When resizesToContents is ON scene's rect is set to the boundary of
the mainFrame. However, navigating to other web page should keep resizing
scene's rect according to the new document loaded. Patch addresses this issue.

Now resizesToContents and scrolling properly work on QtTestBrowser.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::contentsSizeChanged): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent):
  • QtTestBrowser/webview.h:
8:59 PM Changeset in webkit [65049] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: Clean up LauncherWindow code.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init(). (LauncherWindow::init): Fixed comments. (LauncherWindow::applyPrefs): Move the method around. (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
8:58 PM Changeset in webkit [65048] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.

It gets control+0 the same visual effect as control++ or control-.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::toggleZoomTextOnly):
8:57 PM Changeset in webkit [65047] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser
make m_zoomLevels a static member.

Not all instances of LauncherWindow need its own m_zoomLevel.

  • QtTestBrowser/launcherwindow.cpp:
  • QtTestBrowser/launcherwindow.h:
8:43 PM Changeset in webkit [65046] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VIII.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:34 PM Changeset in webkit [65045] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VII.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:29 PM Changeset in webkit [65044] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Qt/ARM

C++ overload resolution I stab at thee

  • jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

8:27 PM Changeset in webkit [65043] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VI.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:19 PM Changeset in webkit [65042] by oliver@apple.com
  • 19 edits
    1 add in trunk/JavaScriptCore

2010-08-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow an assembler/macroassembler to compact branches to more concise forms when linking
​https://bugs.webkit.org/show_bug.cgi?id=43745

This patch makes it possible for an assembler to convert jumps into a different
(presumably more efficient) form at link time. Currently implemented in the
ARMv7 JIT as that already had logic to delay linking of jumps until the end of
compilation already. The ARMv7 JIT chooses between either a 4 byte short jump
or a full 32-bit offset (and rewrites ITTT instructions as appropriate), so does
not yet produce the most compact form possible. The general design of the linker
should make it relatively simple to introduce new branch types with little effort,
as the linker has no knowledge of the exact form of any of the branches.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.cpp: Added. (JSC::): Record jump sizes
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::LinkRecord::LinkRecord): (JSC::ARMv7Assembler::LinkRecord::from): (JSC::ARMv7Assembler::LinkRecord::setFrom): (JSC::ARMv7Assembler::LinkRecord::to): (JSC::ARMv7Assembler::LinkRecord::type): (JSC::ARMv7Assembler::LinkRecord::linkType): (JSC::ARMv7Assembler::LinkRecord::setLinkType): Encapsulate LinkRecord fields so we can compress the values somewhat

(JSC::ARMv7Assembler::JmpSrc::JmpSrc):

Need to record the jump type now

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):

Need to pass the jump types

(JSC::ARMv7Assembler::executableOffsetFor):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::linkRecordSourceComparator):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::convertJumpTo):
(JSC::ARMv7Assembler::recordLinkOffsets):
(JSC::ARMv7Assembler::jumpsToLink):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::unlinkedCode):

Helper functions for the linker

(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::canBeShortJump):
(JSC::ARMv7Assembler::linkLongJump):
(JSC::ARMv7Assembler::linkShortJump):
(JSC::ARMv7Assembler::linkJumpAbsolute):

Moving code around for the various jump linking functions

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::beginUninterruptedSequence): (JSC::AbstractMacroAssembler::endUninterruptedSequence): We have to track uninterrupted sequences in any assembler that compacts branches as that's not something we're allowed to do in such sequences. AbstractMacroAssembler has a nop version of these functions as it makes the code elsewhere nicer.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::trampolineAt): Updated these functions to adjust for any changed offsets in the linked code

(JSC::LinkBuffer::applyOffset):

A helper function to deal with the now potentially moved labels

(JSC::LinkBuffer::linkCode):

The new and mighty linker function

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::beginUninterruptedSequence): (JSC::MacroAssemblerARMv7::endUninterruptedSequence): (JSC::MacroAssemblerARMv7::jumpsToLink): (JSC::MacroAssemblerARMv7::unlinkedCode): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::convertJumpTo): (JSC::MacroAssemblerARMv7::recordLinkOffsets): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::link): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::breakpoint): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::executableOffsetFor): (JSC::MacroAssemblerARMv7::inUninterruptedSequence): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):

All branches need to pass on their type now

  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::returnLastBytes):

We can't know ahead of time how much space will be necessary to
hold the linked code if we're compacting branches, this new
function allows us to return the unused bytes at the end of linking

  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
  • jit/JIT.h: (JSC::JIT::compile):

The JIT class now needs to take a linker offset so that recompilation
can generate the same jumps when using branch compaction.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emitSlow_op_mod):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): Update for new trampolineAt changes
  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::):
  • wtf/Platform.h:
8:18 PM Changeset in webkit [65041] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Qt build fix attempt V.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:10 PM Changeset in webkit [65040] by barraclough@apple.com
  • 4 edits in trunk/WebCore

Qt build fix attempt IV.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

7:58 PM Changeset in webkit [65039] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative chromium build fix.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::charactersAreAllASCII):

7:41 PM Changeset in webkit [65038] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

7:40 PM Changeset in webkit [65037] by mrowe@apple.com
  • 1 copy in tags/Safari-533.18.1

New tag.

7:35 PM Changeset in webkit [65036] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

7:24 PM Changeset in webkit [65035] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.18-branch

Merge r63772.

7:13 PM Changeset in webkit [65034] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix V.

  • tests/KURLTest.cpp:

(ComponentCase::TEST):

7:06 PM Changeset in webkit [65033] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix IV.

  • src/WebPageSerializerImpl.h:
6:59 PM Changeset in webkit [65032] by barraclough@apple.com
  • 4 edits in trunk

Qt build fix III.

JavaScriptCore:

  • wtf/text/WTFString.h:

WebCore:

  • css/CSSSelector.cpp:
6:47 PM Changeset in webkit [65031] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove error-prone external SegementedSubstring contructor
​https://bugs.webkit.org/show_bug.cgi?id=43752

There's a lot of code that assumes that SegmentedString takes ownership
of its substrings. For example, when the HTML parser pauses and
resumes asynchronously, it could explode if SegmentedString didn't own
its substrings.

Prior to this patch, there was a constructor that let
SegmentedSubstring use an external string buffer. It turns out it was
only used in a handful of places, but I'd rather pay the memcpy of
these small strings than risk having them used after free.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::parseComment):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString):
6:43 PM Changeset in webkit [65030] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative Qt build fix.

  • css/CSSSelector.cpp:
6:43 PM Changeset in webkit [65029] by weinig@apple.com
  • 13 edits in trunk

Add zoom support for injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=43759

Reviewed by Geoffrey Garen.

WebKit2:

Add SPI to change the zoom factor for a page.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(toZoomMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetZoomFactor):
(WKBundlePageSetZoomFactor):
(WKBundlePageSetZoomMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::zoomFactor):
(WebKit::WebPage::setZoomFactor):
(WebKit::WebPage::setZoomMode):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Use zoom factor SPI to implement zoom related eventSender functions.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.

LayoutTests:

  • platform/mac-wk2/Skipped: Remove now passing tests.
6:42 PM Changeset in webkit [65028] by barraclough@apple.com
  • 4 edits in trunk/WebKitTools

Speculative chromium build fix III.

  • DumpRenderTree/chromium/MockSpellCheck.h:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost::addClearHeader):
(WebViewHost::clearHeaders):

6:37 PM Changeset in webkit [65027] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix II.

  • src/AssertMatchingEnums.cpp:
6:32 PM Changeset in webkit [65026] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

increase the number of test results that we save
​https://bugs.webkit.org/show_bug.cgi?id=43763

Now that we do incremental uploads, we can increase the number of
results that we save for ​http://test-results.appspot.com/dashboards/flakiness_dashboard.html.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
6:28 PM Changeset in webkit [65025] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative gtk build fix.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handlePostReadFile):

6:24 PM Changeset in webkit [65024] by mrowe@apple.com
  • 1 edit in branches/safari-533.18-branch/WebCore/rendering/RenderLayerBacking.cpp

Build fix. Remove a static function that is no longer called.

6:22 PM Changeset in webkit [65023] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix.

  • public/WebCString.h:
5:55 PM Changeset in webkit [65022] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Qt build fix.

  • wtf/qt/StringQt.cpp:
5:38 PM Changeset in webkit [65021] by barraclough@apple.com
  • 504 edits in trunk

Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

Rubber stamped by Sam Weinig

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.h:
  • bindings/cpp/WebDOMCString.h:
  • bindings/cpp/WebDOMString.h:
  • bindings/gobject/ConvertToUTF8String.h:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JavaScriptCallFrame.h:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptSourceProvider.h:
  • bindings/js/ScriptString.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/v8/ScheduledAction.h:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bridge/c/c_utility.h:
  • css/CSSFontSelector.h:
  • css/CSSHelper.h:
  • css/CSSOMUtils.h:
  • css/CSSPrimitiveValue.h:
  • css/MediaList.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • css/WebKitCSSKeyframesRule.h:
  • dom/CheckedRadioButtons.h:
  • dom/DOMImplementation.h:
  • dom/DocumentMarker.h:
  • dom/DynamicNodeList.h:
  • dom/EventTarget.h:
  • dom/MessagePort.h:
  • dom/MessagePortChannel.h:
  • dom/NameNodeList.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/OptionGroupElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/SelectElement.h:
  • dom/ViewportArguments.h:
  • dom/make_names.pl:
  • editing/HTMLInterchange.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CollectionCache.h:
  • html/DOMFormData.h:
  • html/DataGridColumnList.h:
  • html/DateComponents.h:
  • html/FileStream.h:
  • html/FileStreamProxy.h:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):

  • html/HTMLCollection.h:
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.h:
  • html/HTMLParserQuirks.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptRunnerHost.h:
  • html/StepRange.h:
  • html/canvas/CanvasGradient.h:
  • html/canvas/CanvasNumberArray.h:
  • html/canvas/CanvasPattern.h:
  • inspector/InjectedScript.h:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorValues.h:
  • inspector/ScriptDebugListener.h:
  • loader/CachedResourceClient.h:
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/RedirectScheduler.h:
  • loader/SubframeLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveFactory.h:
  • loader/icon/IconDatabaseClient.h:
  • notifications/NotificationPresenter.h:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Console.h:
  • page/ContextMenuClient.h:
  • page/DOMSelection.h:
  • page/EditorClient.h:
  • page/EventHandler.h:
  • page/FrameView.h:
  • page/GeolocationPositionCache.h:
  • page/History.h:
  • page/Location.h:
  • page/Navigator.h:
  • page/NavigatorBase.h:
  • page/PluginHalterClient.h:
  • page/PrintContext.h:
  • page/SpeechInput.h:
  • page/SpeechInputListener.h:
  • page/animation/AnimationController.h:
  • platform/CookieJar.h:
  • platform/CrossThreadCopier.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/Language.h:
  • platform/Length.h:
  • platform/LinkHash.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.h:
  • platform/Logging.h:
  • platform/Pasteboard.h:
  • platform/PopupMenuClient.h:
  • platform/SearchPopupMenu.h:
  • platform/Widget.h:
  • platform/cf/BinaryPropertyList.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/cocoa/KeyEventCocoa.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontData.h:
  • platform/graphics/FontSelector.h:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Icon.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/Path.h:
  • platform/graphics/StringTruncator.h:
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cairo/FontPlatformData.h:
  • platform/graphics/cg/FontPlatformData.h:
  • platform/graphics/cg/ImageSourceCG.h:
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wince/MediaPlayerPrivateWince.h:
  • platform/graphics/wince/MediaPlayerProxy.h:
  • platform/graphics/wx/FontCustomPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/mac/PasteboardHelper.h:
  • platform/network/DNS.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.h:
  • platform/text/Hyphenation.h:
  • platform/text/LineEnding.h:
  • platform/text/TextCodec.h:
  • platform/text/TextEncoding.h:
  • platform/text/TextStream.h:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/WCDataObject.h:
  • platform/win/WebCoreTextRenderer.h:
  • plugins/DOMMimeType.h:
  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.h:
  • plugins/DOMPluginArray.h:
  • rendering/CounterNode.h:
  • rendering/HitTestResult.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.h:
  • rendering/TextControlInnerElements.h:
  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • storage/Storage.h:
  • storage/chromium/DatabaseObserver.h:
  • svg/SVGAnimatedTemplate.h:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGStylable.h:
  • svg/SVGTests.h:
  • svg/SVGTransformList.h:
  • svg/SVGTransformable.h:
  • svg/SVGVKernElement.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketHandshakeResponse.h:
  • wml/WMLErrorHandling.h:
  • wml/WMLPageState.h:
  • wml/WMLVariables.h:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:
  • workers/Worker.h:
  • workers/WorkerContextProxy.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerLocation.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerThread.h:
  • xml/DOMParser.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:
  • xml/XPathUtil.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/chromium:

  • public/WebCString.h:
  • public/WebString.h:
  • src/DOMUtilitiesPrivate.h:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.h:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebPageSerializerImpl.h:

WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.h:

WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.h:
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/WebBaseNetscapePluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebView/WebViewInternal.h:

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

  • COMVariantSetter.h:
  • MarshallingHelpers.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebHistory.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.h:
  • WebKitSupport/InspectorClientWx.h:

WebKit2:

  • UIProcess/PageClient.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:
5:25 PM Changeset in webkit [65020] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Nat Duca <​nduca@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Blue line visible at the right hand side of the window with accelerated compositor
​https://bugs.webkit.org/show_bug.cgi?id=43748

Correct the ortho projection matrix for the root layer, which was
too large by 0.5px in both width and height. For even view sizes,
this would cause the viewport to appear 1 pixel too small.

Fixing this requires removal of several 0.5 correction factors
that were previously added to compensate for the too-large viewport.

Finally, compute the translation for the root layer quad using
floating point rather than integer arithmetic. This avoids us losing
a key half-pixel of translation when the width of the window is odd.

To test, size window to even/odd dimensions. No blue line should be visible.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
5:24 PM Changeset in webkit [65019] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43465

Removed fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle
because StyleChange's applyFontColor, applyFontFace, and applyFontSize all return false
if there was no difference between the new font color, font size, font face and that of the computed style.

Also added a work-around for the bug 28282 in getPropertiesNotInComputedStyle with a test so that
the above change will not add a redundant font or span element.

Test: editing/style/fore-color-by-name.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getRGBAFontColor): Added. (WebCore::StyleChange::extractTextStyles): Calls getRGBAFontColor. (WebCore::getPropertiesNotInComputedStyle): Removes color property manually by checking the RGBA values. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): See above.

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43465

Added a test for applying execCommand('foreColor') by color name. Because of the bug 28282, we have to manually
process color property in getPropertiesNotInComputedStyle to avoid adding a redundant font or span element.

  • editing/style/fore-color-by-name-expected.txt: Added.
  • editing/style/fore-color-by-name.html: Added.
5:06 PM Changeset in webkit [65018] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-09 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Fix compilation of VideoLayerChromium on Mac OS X with compositor
​https://bugs.webkit.org/show_bug.cgi?id=43757

No new tests; build fix only (associated functionality not implemented yet).

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
  • platform/graphics/chromium/VideoLayerChromium.h:
5:00 PM Changeset in webkit [65017] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need to implement GraphicsContextQt::clipConvexPolygon()
​https://bugs.webkit.org/show_bug.cgi?id=41310

Based on the prototype code by Simon Hausmann.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
  • rendering/RenderObject.h:
4:45 PM Changeset in webkit [65016] by Chris Fleizach
  • 8 edits in trunk

AX: Placeholder value for text fields not exposed like it should be
​https://bugs.webkit.org/show_bug.cgi?id=43598

Reviewed by David Kilzer.

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::placeholderValue):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:
4:29 PM Changeset in webkit [65015] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] DRT error print statement incorrectly tries to print a FILE*
​https://bugs.webkit.org/show_bug.cgi?id=43747

  • DumpRenderTree/chromium/ImageDiff.cpp: (writeFile): pass the correct pointer.
4:25 PM Changeset in webkit [65014] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
​https://bugs.webkit.org/show_bug.cgi?id=43639

The bug was caused when RemoveCSSPropertyCommand is called with CSSMutableStyleDeclaration of some styled element,
and the style attribute of the element is removed subsequently. When the attribute removal is undone, new instance of
CSSMutableStyleDeclaration is created and RemoveCSSPropertyCommand's m_style became detached from the element.

Modified RemoveCSSPropertyCommand to store the styled element directly instead of its CSSMutableStyleDeclaration.

Test: editing/undo/remove-css-property-and-remove-style.html

  • WebCore.order:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): Calls removeCSSProperty. (WebCore::ApplyStyleCommand::extractTextDecorationStyle): Calls removeCSSProperty.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeCSSProperty): Takes StyledElement instead of CSSMutableStyleDeclaration.
  • editing/CompositeEditCommand.h:
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Takes StyledElement instead of CSSMutableStyleDeclaration. (WebCore::RemoveCSSPropertyCommand::doApply): See above. (WebCore::RemoveCSSPropertyCommand::doUnapply): See above.
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create): See above.

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
​https://bugs.webkit.org/show_bug.cgi?id=43639

Added a test to remove style attribute after removing a CSS property from the style.
Undo should restore both style attribute and the removed CSS property.

  • editing/undo/remove-css-property-and-remove-style-expected.txt: Added.
  • editing/undo/remove-css-property-and-remove-style.html: Added.
4:18 PM Changeset in webkit [65013] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Use getIdentifierValue to obtain direction and unicode-bidi properties in ApplyStyleCommand
​https://bugs.webkit.org/show_bug.cgi?id=43699

Deployed getIdentifierValue in various parts of ApplyStyleCommand where
direction and unicode-bidi properties were obtained manually.

No new tests since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: (WebCore::getIdentifierValue): Takes CSSStyleDeclaration instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls getIdentifierValue.
  • editing/ApplyStyleCommand.h:
4:06 PM Changeset in webkit [65012] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove trailing whitespace in HTMLViewSourceDocument.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43741

No behavior change. The whitespace was distracting me while porting
this class to the new parser.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
3:11 PM Changeset in webkit [65011] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

Upload incremental test results json to server by default.

​https://bugs.webkit.org/show_bug.cgi?id=43743

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:06 PM Changeset in webkit [65010] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-533.18-branch

Merge r64706.

2:59 PM Changeset in webkit [65009] by mrowe@apple.com
  • 7 edits in branches/safari-533.18-branch

Merge r64110.

2:59 PM Changeset in webkit [65008] by mrowe@apple.com
  • 4 edits in branches/safari-533.18-branch/WebKit/mac

Merge r62872.

2:59 PM Changeset in webkit [65007] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.18-branch

Merge r64095.

2:52 PM Changeset in webkit [65006] by eric@webkit.org
  • 18 edits in trunk

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
​https://bugs.webkit.org/show_bug.cgi?id=43586

  • html5lib/runner-expected.txt:
    • We pass 2 more tests now that the tokenizer is set to the right state before fragment parsing.
  • html5lib/runner-expected-html5.txt:
    • We pass 4 more tests now that HTML5 fragment parsing is (partially) implemented behind the --html5-treebuilder flag.

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
​https://bugs.webkit.org/show_bug.cgi?id=43586

The bulk of this change is just a transcription of the HTML5 spec:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#fragment-case

DocumentParser() now sets the right tokenizer state before handling
fragments. Since default code path uses the HTML5 tokenizer with the
legacy tree builder, this fixes 2 tokenizer-state tests for the html5lib.
This fixes 2 more tree-builder tests when the html5 treebuilder is enabled too.

  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
    • HTML5 implementation of fragment parsing requires the context element (parent) pointer. The legacy implementation handles all parsing branches which require the context element outside of the parser itself, which likely produces "wrong" results. We'll remove those branches when we turn on the HMTL5 fragment parser.

(WebCore::DocumentFragment::parseXML):

  • Rename "parent" to "contextElement" to match the HTML path (and the HTML5 spec).
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
    • Pass the contextElement (this).
  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::setForm):
    • Needed by for the fragment case.

(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

  • I'm not sure this method should exist, it only has one caller. but for now, I've moved the fragment case FIXME out to the one caller and implemented it.
  • html/HTMLConstructionSite.h:
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLNames::tokenizerStateForContextElement):
    • Part of the fragment case handling for the HTML5 parser.

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • Set the Tokenizer state based on the contextElement.

(WebCore::HTMLDocumentParser::parseDocumentFragment):

  • Take a contextElement argument.
  • html/HTMLDocumentParser.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML):
    • Added a FIXME before the branches the old parser used to avoid ever needing to pass a context element when parsing HTML fragments.

(WebCore::HTMLElement::insertAdjacentHTML):

  • Pass the context element.
  • html/HTMLTokenizer.h:
  • html/HTMLTreeBuilder.cpp:
    • I added a new helper class FragmentParsingContext to simplify the two HTMLTreeBuilder constructors and hide the existence of m_dummyDocumentForFragmentParse.
    • I also removed m_isParsingFragment and replaced it with an isParsingFragment() function.

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::~FragmentParsingContext):
(WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):

  • I had to implement two notImplemented() states in order to get most of the layout tests to pass when using the HTML5 parser fragment case.

(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):

  • The HTML5 parsing algorithm fragment case uses a dummy document to handle all the parsing and then moves all the children from the dummy document over into a DocumentFragment when the parse is done. We could avoid this adopt step by making the TreeBuilder a bit more complicated, but I'm not sure that's necessary (yet).
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::isParsingFragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): (WebCore::HTMLTreeBuilder::FragmentParsingContext::scriptingPermission):
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
2:36 PM Changeset in webkit [65005] by dumi@chromium.org
  • 34 edits
    4 deletes in trunk

WebCore: Auto-generate most HTML5 DB bindings.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp

and the custom implementations of openDatabase{Sync}().

  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDatabaseCustom.cpp: Removed.
  • bindings/js/JSDatabaseSyncCustom.cpp: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/scripts/CodeGeneratorGObject.pm: Change the code generators

to check that each value can be converted to the respective
argument type.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/custom/V8BindingMacros.h:
  • bindings/v8/V8Binding.h: Minor changes required to support the

auto-generated bindings.
(WebCore::V8Parameter::V8Parameter):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):

  • storage/Database.h:
  • storage/Database.idl:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl:
  • workers/WorkerContext.idl:

LayoutTests: Changing the expected error message for a test.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • fast/workers/storage/open-database-inputs-sync-expected.txt:
2:32 PM Changeset in webkit [65004] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild
​https://bugs.webkit.org/show_bug.cgi?id=43740

This removes the DTD checks, which aren't needed for view source
documents.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
2:29 PM Changeset in webkit [65003] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fixed an uninitialized member variable in the Color(CGColorRef) constructor.

Reviewed by Simon Fraser.

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::Color): Initialize m_valid to true if the color is not 0.

2:12 PM Changeset in webkit [65002] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Chromium compile fix, unreviewed.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
1:54 PM Changeset in webkit [65001] by jamesr@google.com
  • 4 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
​https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
1:44 PM Changeset in webkit [65000] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

1:41 PM Changeset in webkit [64999] by mrowe@apple.com
  • 1 copy in branches/safari-533.18-branch

New branch.

1:36 PM Changeset in webkit [64998] by zmo@google.com
  • 8 edits in trunk

2010-08-09 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43693

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): Don't generate GL errors. Generate them in the callers instead. (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate GL error if sizeInBytes fails.
  • html/canvas/WebGLRenderingContext.h: Make sizeInBytes private helper.
  • html/canvas/WebGLRenderingContext.idl: Remove sizeInBytes.

2010-08-09 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43693

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Define sizeInBytes and don't use the WebGL one (it's been removed).
  • fast/canvas/webgl/gl-object-get-calls.html: Ditto.
  • fast/canvas/webgl/index-validation.html: Ditto.
1:29 PM Changeset in webkit [64997] by eric.carlson@apple.com
  • 10 edits in trunk

2010-08-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): RenderVideo::videoSizeChanged is gone, just use updateFromElement instead. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Clear the image loader and cached image when the 'poster' attribute is changed and we aren't displaying a poster.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::intrinsicSizeChanged): videoSizeChanged -> updateIntrinsicSize. (WebCore::RenderVideo::updateIntrinsicSize): Renamed from videoSizeChanged, calculate initial intrinsic size with calculateIntrinsicSize (WebCore::RenderVideo::calculateIntrinsicSize): New, calculate size according to current spec. (WebCore::RenderVideo::imageChanged): Reset intrinsic size to default when poster fails to load. (WebCore::RenderVideo::updatePlayer): Call updateIntrinsicSize.
  • rendering/RenderVideo.h: Renamed videoSizeChanged to updateIntrinsicSize and make private.

2010-08-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

  • media/video-poster-expected.txt:
  • media/video-poster.html:
  • media/video-size-expected.txt:
  • media/video-size.html:
11:44 AM Changeset in webkit [64996] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Fixes custom JS bindings for IDBCursor after r64828.
​https://bugs.webkit.org/show_bug.cgi?id=43729

Build fix, no tests.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • storage/IDBObjectStore.h:
11:33 AM Changeset in webkit [64995] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

EWS bots wait 2 minutes between patches
​https://bugs.webkit.org/show_bug.cgi?id=43731

  • Scripts/webkitpy/tool/bot/queueengine.py:
    • Don't sleep after failures. This was a hold-over from an earlier design.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
    • EWS bots were not properly reporting true/false from process_work_item. They were always returning None, thus false, thus always logging as a failure and sleeping 2 minutes after each patch.
11:22 AM Changeset in webkit [64994] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64993.
​http://trac.webkit.org/changeset/64993
​https://bugs.webkit.org/show_bug.cgi?id=43734

broke chromium compile (Requested by jamesr on #webkit).

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
11:05 AM Changeset in webkit [64993] by jamesr@google.com
  • 4 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
​https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
11:01 AM Changeset in webkit [64992] by eric@webkit.org
  • 3 edits in trunk/WebKit2

2010-08-09 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] No need for PageClientImpl

​https://bugs.webkit.org/show_bug.cgi?id=43728

Remove PageClientImpl, take the implementation of WebKit::PageClient into QWKPagePrivate.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::toolTipChanged):
  • UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::pageDidEnterAcceleratedCompositing): (QWKPagePrivate::pageDidLeaveAcceleratedCompositing): (QWKPagePrivate::processDidExit): (QWKPagePrivate::processDidRevive): (QWKPagePrivate::setCursor): (QWKPagePrivate::takeFocus):
10:50 AM Changeset in webkit [64991] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-08-09 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Moves window.open logic into the generic bindings.

This patch moves window.open logic from V8 into the generic
bindings so it could be shared with JSC. JSC sharing is not in
this patch. This patch is of the same flavor/intent as 33201.

​https://bugs.webkit.org/show_bug.cgi?id=41392

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open): (WebCore::::completeURL):
  • bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp): (WebCore::::shouldAllowNavigation):
  • bindings/v8/V8Binding.h: (WebCore::V8Binding::emptyScriptValue):
  • bindings/v8/V8Utilities.cpp: (WebCore::transferHiddenDependency): (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture):
  • bindings/v8/specialization/V8BindingState.h: (WebCore::):
10:39 AM Changeset in webkit [64990] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Skip the slow software rendering path of GraphicsContext3D if accelerated
compositing is active. This fixes an issue with WebGL and the compositor
in which the software rendering of WebGL would cause the current GL context
to change while the compositor was processing layers. Tested by running
several WebGL samples both with the compositor enabled and disabled.
​https://bugs.webkit.org/show_bug.cgi?id=43644

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::beginPaint):
10:36 AM Changeset in webkit [64989] by jianli@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Update chromium test results.

  • platform/chromium-mac/editing/selection/5076323-1-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/5076323-1-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:05 AM Changeset in webkit [64988] by jhawkins@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-06 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
9:39 AM Changeset in webkit [64987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Fixes xcode project issues after r64828:
​https://bugs.webkit.org/show_bug.cgi?id=43638

Build fix, no tests (sort-Xcode-project-file should not throw any warnings).

  • WebCore.xcodeproj/project.pbxproj: fixed IDBCursor and related IndexedDB files, and re-ran sort-Xcode-project-file.
9:11 AM Changeset in webkit [64986] by loislo@chromium.org
  • 12 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove callId argument from all backend agents' methods.
​https://bugs.webkit.org/show_bug.cgi?id=43723

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::getDatabaseTableNames):
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource):
  • inspector/InspectorDebuggerAgent.h:
8:55 AM Changeset in webkit [64985] by weinig@apple.com
  • 11 edits
    3 adds in trunk

Stub out EventSender for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=43703

WebKitTools:

Reviewed by Anders Carlsson.

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Add ability to pass javascript arguments to the wrapped object.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.

(WTR::EventSendingController::create):
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::~EventSendingController):
(WTR::EventSendingController::wrapperClass):
(WTR::setExceptionForString):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::contextClick):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
(WTR::EventSendingController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::eventSendingController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):
Add stubbed out EventSenderController.

  • WebKitTestRunner/InjectedBundle/GCController.h:

Remove incorrect comment.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

Add new files.

LayoutTests:

Reviewed by Anders Carlsson

  • platform/mac-wk2/Skipped: Update.
8:52 AM Changeset in webkit [64984] by eric@webkit.org
  • 7 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for mroot color handling.
​https://bugs.webkit.org/show_bug.cgi?id=43628

  • mathml/presentation/roots.xhtml:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Take into account style color to draw MathML mroot radical.
​https://bugs.webkit.org/show_bug.cgi?id=43628

Test: mathml/presentation/roots.xhtml

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
8:50 AM Changeset in webkit [64983] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-08-09 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus
​https://bugs.webkit.org/show_bug.cgi?id=43602

Only call gtk_im_context_focus_in() when we focus a frame which is currently in
an editable node.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in().
8:40 AM Changeset in webkit [64982] by eric@webkit.org
  • 8 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add test for some deprecated MathML style attributes
​https://bugs.webkit.org/show_bug.cgi?id=43503

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement MathML deprecated style attributes
​https://bugs.webkit.org/show_bug.cgi?id=43503

Test: mathml/presentation/attributes.xhtml

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
  • mathml/mathattrs.in:
7:59 AM Changeset in webkit [64981] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove unnecessary did* methods from RemoteInspectorFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=43721

  • inspector/CodeGeneratorInspector.pm:
6:56 AM Changeset in webkit [64980] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-08-09 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

Canvas: Fast-path for setting the already set color with setStrokeColor() and setFillColor()
​https://bugs.webkit.org/show_bug.cgi?id=43718

Avoid creating CanvasStyle objects when setting the same fill or stroke color using
the WebKit-specific setters of CanvasRenderingContext2D.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
  • html/canvas/CanvasStyle.h: Added CanvasStyle::isEquivalentColor() overloads for RGBA and CMYKA channel values.
6:34 AM Changeset in webkit [64979] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:00 AM Changeset in webkit [64978] by pfeldman@chromium.org
  • 4 edits in trunk

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore original last panel restore logic.

​https://bugs.webkit.org/show_bug.cgi?id=43719

  • inspector/front-end/inspector.js: (WebInspector.showPanel):
5:23 AM Changeset in webkit [64977] by pfeldman@chromium.org
  • 5 edits in trunk

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

  • src/js/Tests.js: (.TestSuite.prototype.testShowStoragePanel.this): (.TestSuite.prototype.testShowStoragePanel):

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

  • http/tests/inspector/inspector-test.js: (frontend_setupTestEnvironment):
  • inspector/elements-panel-limited-children.html:
4:57 AM Changeset in webkit [64976] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Unreviewed, fixing the builds after r64967.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
4:48 AM Changeset in webkit [64975] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium tests fix.

Disable runtime switch for device motion in chromium.
​https://bugs.webkit.org/show_bug.cgi?id=43717

  • src/WebViewImpl.cpp: (WebKit::WebView::create):
4:40 AM Changeset in webkit [64974] by morrita@google.com
  • 7 edits
    3 adds in trunk

2010-05-20 MORITA Hajime <​morrita@google.com>

Reviewed by Ojan Vafai.

<​http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.
<​http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.

  • editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt: Added.
  • editing/selection/doubleclick-inline-first-last-contenteditable.html: Added.
  • editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js: Added.

2010-05-27 MORITA Hajime <​morrita@google.com>

Reviewed by Ojan Vafai.

<​http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.
<​http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.

nextBoundary() and previousBoundary() assumed that editable
boundaries are on block-level elements, But it can appear on
inline-level elements. So we start boundary look-up from the given
node, instead of the containingBlock of the given node.
Also, added TextIteratorEndsAtEditingBoundary to
BackwardsCharacterIterator, otherwise, the VisiblePosition
returned by BackwardsCharacterIterator might cross an editing
boundary.

Test: editing/selection/doubleclick-inline-first-last-contenteditable.html

  • dom/Position.cpp: (WebCore::Position::parentEditingBoundary): Added.
  • dom/Position.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::crossesEditingBoundary): Added. (WebCore::SimplifiedBackwardsTextIterator::setCurrentNode): Added. (WebCore::SimplifiedBackwardsTextIterator::clearCurrentNode): Added. (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
  • editing/TextIterator.h: (WebCore::):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):
4:26 AM Changeset in webkit [64973] by loislo@chromium.org
  • 19 edits in trunk

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
​https://bugs.webkit.org/show_bug.cgi?id=43711

  • WebCore.exp.in:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.toggleSearchingForNode): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.showProfileForURL):

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
​https://bugs.webkit.org/show_bug.cgi?id=43711

  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-proto-property.html:
  • inspector/elements-panel-limited-children.html:
3:50 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:24 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:17 AM MathML 3 testsuite results edited by François Sausset
(diff)
2:48 AM Changeset in webkit [64972] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: Remove temporary device motion fix.

​https://bugs.webkit.org/show_bug.cgi?id=43713

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
2:36 AM Changeset in webkit [64971] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::clipOut(IntRect) ignores the transformation matrix.
​https://bugs.webkit.org/show_bug.cgi?id=43705

Just like clipOut(Path), which is taken care in r60796 already,
clipOut(IntRect) must transform the window bounding box properly.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut):
2:18 AM Changeset in webkit [64970] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Drop SLOW as SLOW and TIMEOUT isn't allowed.
2:14 AM Changeset in webkit [64969] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Mark http/tests/misc/bad-charset-alias as a slow test.
1:49 AM Changeset in webkit [64968] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Mark fast/parser/residual-style-hang as a slow test.
1:33 AM QtWebKitMediaElementSupport edited by Henry Haverinen
(diff)
12:53 AM Changeset in webkit [64967] by eric@webkit.org
  • 20 edits
    6 adds in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for the mfenced MathML element and update tests with stretched parenthesis/brackets/operators
​https://bugs.webkit.org/show_bug.cgi?id=42472

  • mathml/presentation/fenced.xhtml: Added.
  • mathml/presentation/row.xhtml:
  • platform/mac/mathml/presentation/fenced-expected.checksum: Added.
  • platform/mac/mathml/presentation/fenced-expected.png: Added.
  • platform/mac/mathml/presentation/fenced-expected.txt: Added.
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement mfenced MathML element
Update stretchy operator code to take into account new brackets and to tune layout parameters
​https://bugs.webkit.org/show_bug.cgi?id=42472

Test: mathml/presentation/fenced.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement): (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLFenced.cpp: Added. (WebCore::RenderMathMLFenced::RenderMathMLFenced): (WebCore::RenderMathMLFenced::updateFromElement): (WebCore::RenderMathMLFenced::makeOperatorStyle): (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::addChild): (WebCore::RenderMathMLFenced::layout):
  • mathml/RenderMathMLFenced.h: Added.
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::RenderMathMLOperator): (WebCore::RenderMathMLOperator::stretchToHeight): (WebCore::): (WebCore::RenderMathMLOperator::updateFromElement): (WebCore::RenderMathMLOperator::createStackableStyle): (WebCore::RenderMathMLOperator::createGlyph):

Aug 8, 2010:

11:56 PM Changeset in webkit [64966] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Darin Adler.

REGRESSION(64898,64949) build break because of wrong filename
​https://bugs.webkit.org/show_bug.cgi?id=43701

add SVGPathStringSource.cpp and modify SVGPathSourceString.cpp to
SVGPathStringSource.cpp

simple fixing build break, so No new tests.

  • CMakeLists.txt:
10:47 PM Changeset in webkit [64965] by ariya@webkit.org
  • 15 edits in trunk

2010-08-08 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Antonio Gomes.

Inconsistent Qt version checks
​https://bugs.webkit.org/show_bug.cgi?id=43695

Use QT_VERSION_CHECK macro instead of encoded hex.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebViewPrivate::detachCurrentPage):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery): (QWebPage::view):
  • Api/qwebview.cpp: (QWebViewPrivate::detachCurrentPage):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/PageClientQt.h:
10:43 PM Changeset in webkit [64964] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43698

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): Add suggested parentheses.
10:26 PM Changeset in webkit [64963] by morrita@google.com
  • 10 edits
    3 adds in trunk

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • editing/pasteboard/paste-text-events-expected.txt: Added.
  • editing/pasteboard/paste-text-events.html: Added.
  • editing/pasteboard/script-tests/paste-text-events.js: Added.

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • Extended TextEvents to hold paste-specific parameters
  • Did fire TextEvents at where we originally did immediate pastes.
  • Factored out TextEvent handling from EventHandler::defaultTextInputEventHandler() to Editor::handleTextEvent() because it's solely done by the editor.
  • move actual pasting logic to Editor::handleTextEvent()

Test: editing/pasteboard/paste-text-events.html

  • WebCore.exp.in:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isPaste): (WebCore::TextEvent::shouldSmartReplace): (WebCore::TextEvent::shouldMatchStyle): (WebCore::TextEvent::pastingFragment):
  • editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::findEventTargetFromSelection):
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

On paste, invoke Editor instead of direct command invocation,
which allows dispatching events before actual paste.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
9:29 PM Changeset in webkit [64962] by morrita@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Should have test: textInput should not fired when preceding key events are cancelled.
​https://bugs.webkit.org/show_bug.cgi?id=43601

  • fast/events/inputText-never-fired-on-keydown-cancel-expected.txt: Added.
  • fast/events/inputText-never-fired-on-keydown-cancel.html: Added.
  • fast/events/script-tests/inputText-never-fired-on-keydown-cancel.js: Added. (handleTextInput): (mayCancel): (setup): (test):
9:05 PM Changeset in webkit [64961] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, trivial fix.

Fix "WindowsError: [Error 32] The process cannot access the file
because it is being used by another process" introduced by r64959.

  • BuildSlaveSupport/test-result-archive:
7:16 PM Changeset in webkit [64960] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
6:26 PM Changeset in webkit [64959] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium buildbot: Avoid "zip" command dependency
​https://bugs.webkit.org/show_bug.cgi?id=43470

Reviewed by Tony Chang.

  • BuildSlaveSupport/test-result-archive: For Chromium port, creates a zip archive with zipfile package of Python instead of external "zip" command. We'd like to avoid additional command installation.
6:12 PM Changeset in webkit [64958] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, add member needed to compile Mac-specific font code.

3:27 PM Changeset in webkit [64957] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

[Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h
​https://bugs.webkit.org/show_bug.cgi?id=43360

  • platform/WindowsKeyboardCodes.h: Undef macros which are also defined in MinGW/include/winuser.h to aviod gcc redefinition warning
1:30 PM Changeset in webkit [64956] by jamesr@google.com
  • 9 edits in trunk/LayoutTests

2010-08-08 James Robinson <​jamesr@chromium.org>

Unreviewed. Rebaseline chromium results for r64954.

  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/invalid/003-expected.txt:
  • platform/chromium-win/fast/invalid/019-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [64955] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Add more items to WebKit2 skipped list.

Rubber stamped by Sam Weinig.

  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [64954] by jamesr@google.com
  • 11 edits in trunk

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
builder's adoption agency flag. This is a speedup assuming that nodes subjected
to the adoption agency are likely to be frequently reparented, and thus it is better
to delay creating the render tree until later (when hopefully the DOM is finalized).

On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

New baselines for tests where the render tree depends on 0x0 render objects being
created/destroyed during adoption agency fixups.

  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/invalid/003-expected.txt:
  • platform/mac/fast/invalid/019-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug647-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
10:56 AM Changeset in webkit [64953] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

fast/events/onunload-back-to-page-cache.html does not pass with GTK DRT
​https://bugs.webkit.org/show_bug.cgi?id=43692

Update onunload-back-to-page-cache.html to set the frame name later,
so that the onunload handler console message doesn't have it. Also
include a message about what exactly we're testing.

  • fast/events/onunload-back-to-page-cache-expected.txt:
  • fast/events/script-tests/onunload-back-to-page-cache.js: (onpageshow):
10:45 AM Changeset in webkit [64952] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: speed-up Element.prototype.removeChildren
​https://bugs.webkit.org/show_bug.cgi?id=43687

  • inspector/front-end/utilities.js: (Element.prototype.removeChildren):
9:47 AM Changeset in webkit [64951] by loislo@chromium.org
  • 11 edits in trunk/WebCore

2010-08-08 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: remove hand written InspectorFrontend from almost all places.
​https://bugs.webkit.org/show_bug.cgi?id=43630

  • inspector/ConsoleMessage.cpp:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/TimelineRecordFactory.cpp:
9:41 AM Changeset in webkit [64950] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Chromium Mac build after r64915.

  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm:

(WebCore::FontPlatformData::ctFont): Copied from mac/FontPlatformDataMac.mm.

9:10 AM Changeset in webkit [64949] by krit@webkit.org
  • 18 edits
    2 adds in trunk/WebCore

2010-08-08 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add missing String builder for SVGPathParser
​https://bugs.webkit.org/show_bug.cgi?id=43682

Introduces SVGPathStringBuilder. SVGPathParser clients, like normalized and unaltered
SVGPathSegLists or SVGPathByteStreams, can be parsed and transformed to a string.
StringBuilder can create a string of individual strings, seperated by spaces now.
Share more code in SVGPathParserFactory and use a common general concept to manage SVG path
data parsing.

Doesn't affect any tests.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString): Added possibility to use a space between individual strings.
  • platform/text/StringBuilder.h: Cleanup according to WebKit style. (WebCore::): (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::setNonNull): (WebCore::StringBuilder::isNull):
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::cleanup): Clear all references.
  • svg/SVGPathByteStreamBuilder.h: (WebCore::SVGPathByteStreamBuilder::cleanup): dito.
  • svg/SVGPathConsumer.h:
  • svg/SVGPathParser.cpp: (WebCore::SVGPathParser::cleanup): dito.
  • svg/SVGPathParser.h:
  • svg/SVGPathParserFactory.cpp: Cleanup of factory. More code get shared. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathByteStreamBuilder): (WebCore::globalSVGPathStringBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathStringBuilder.cpp: Added. Build string from parsed SVG data. (WebCore::SVGPathStringBuilder::SVGPathStringBuilder): (WebCore::SVGPathStringBuilder::moveTo): (WebCore::SVGPathStringBuilder::lineTo): (WebCore::SVGPathStringBuilder::lineToHorizontal): (WebCore::SVGPathStringBuilder::lineToVertical): (WebCore::SVGPathStringBuilder::curveToCubic): (WebCore::SVGPathStringBuilder::curveToCubicSmooth): (WebCore::SVGPathStringBuilder::curveToQuadratic): (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth): (WebCore::SVGPathStringBuilder::arcTo): (WebCore::SVGPathStringBuilder::closePath):
  • svg/SVGPathStringBuilder.h: Added. (WebCore::SVGPathStringBuilder::cleanup): (WebCore::SVGPathStringBuilder::result):
1:32 AM Changeset in webkit [64948] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKitTools

WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
​https://bugs.webkit.org/show_bug.cgi?id=43686

Reviewed by Dan Bernstein.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().

  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Link to shlwapi.lib for SHGetValue.

1:07 AM Changeset in webkit [64947] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069)
​https://bugs.webkit.org/show_bug.cgi?id=43040

The pointer from Document to Frame can be null. See ​http://webkit.org/coding/major-objects.html.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:55 AM Changeset in webkit [64946] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

frame()->selection() can't be null
​https://bugs.webkit.org/show_bug.cgi?id=43681

SelectionController is a component of Frame. If frame is non-null, it
can't possibly be null.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive):
12:45 AM Changeset in webkit [64945] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

Send invalid input to trigger old ASSERTs.

  • svg/dom/svg-length-units-expected.txt: Added.
  • svg/dom/svg-length-units.html: Added.

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

ASSERTs aren't in release builds, so we can't use them to validate user
input! We've seen a bunch of examples of this in SVG code. It might
be worth auditing all the code to remove this misguided pattern.

Test: svg/dom/svg-length-units.html

  • svg/SVGLength.cpp: (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits):
12:33 AM Changeset in webkit [64944] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Chromium: isindex tests timeout after r64712
​https://bugs.webkit.org/show_bug.cgi?id=43543

Update isindex tests/expectactions after r64712 so that even though they
stil fail, they fail immediately instead of timing out.

  • http/tests/misc/isindex-formdata-expected.txt:
  • http/tests/misc/isindex-formdata.html:
  • http/tests/misc/isindex-with-no-form-base-href-expected.txt:
  • http/tests/misc/resources/isindex-with-no-form-base-href.html:
12:22 AM Changeset in webkit [64943] by eric@webkit.org
  • 21 edits
    1 delete in trunk/JavaScriptCore

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64938.
​http://trac.webkit.org/changeset/64938
​https://bugs.webkit.org/show_bug.cgi?id=43685

Did not compile on several ports (Requested by abarth on
#webkit).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
  • jit/JIT.h:
  • jit/JITMarkObjects.cpp: Removed.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.