Context Navigation

← Previous Period
Next Period →

Timeline

Aug 10, 2010:

11:53 PM WebKit Team edited by abarth@webkit.org

(diff)

11:31 PM Changeset in webkit [65129] by hamaji@chromium.org

2 edits in trunk/LayoutTests

2010-08-10 Shinichiro Hamaji <hamaji@chromium.org>

Add a suppression of animations/suspend-resume-animation.html for chromium.

platform/chromium/test_expectations.txt:

11:24 PM Changeset in webkit [65128] by ariya@webkit.org

2 edits in trunk/WebCore

2010-08-10 Ariya Hidayat <ariya@sencha.com>

[Qt] Fix build warning: remove reference to html/BlobRegistryImp.h

WebCore.pro:

11:20 PM Changeset in webkit [65127] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=43803
<rdar://problem/6988023> Only the last Korean character can be shown if font style is enabled while typing (43803)

Test: platform/mac/editing/input/bold-node.html

editing/Editor.cpp: (WebCore::Editor::setComposition): It is not clear to me what the "baseNode == extentNode" check is about in this function , but let's try to make it more likely that it passes.

11:19 PM Changeset in webkit [65126] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-08-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

webkit-patch should refuse to run under Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=40962

Given that there are lots of places in webkit-patch's code that
assume unix-style filenames (forward slashes), webkit-patch fails
with weird file-not-found errors when run under a native windows
Python. It would be nice if we just trapped this and errored out
at the beginning, rather than producing unpredictable errors.

Scripts/webkit-patch:

11:00 PM Changeset in webkit [65125] by dumi@chromium.org

2 edits in trunk/JavaScriptCore

Unreviewed, reverting an unintentional change to a file submitted in r65108.

bytecode/CodeBlock.h:

(JSC::binaryChop):

10:39 PM Changeset in webkit [65124] by commit-queue@webkit.org

3 edits in trunk/WebKit/qt

2010-08-10 Anders Bakken <agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
https://bugs.webkit.org/show_bug.cgi?id=40580

_q_updateMicroFocus() is a noop unless this ifdef evaluates to true:

#if !defined(QT_NO_IM) && (defined(Q_WS_X11)

defined(Q_WS_QWS) defined(Q_OS_SYMBIAN))

In such cases there's no need to carry the overhead of the extra
signal/slot connection.

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):

10:20 PM Changeset in webkit [65123] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-08-10 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Make CSSSelector::specificity() non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43784

This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806

No functional change, thus no tests.

css/CSSSelector.cpp: (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::specificityForPage):
css/CSSSelector.h:

10:02 PM Changeset in webkit [65122] by commit-queue@webkit.org

3 edits in trunk/WebKit/efl

2010-08-10 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL]REGRESSION(65021) need to fix build break
https://bugs.webkit.org/show_bug.cgi?id=43767

Remove AtomicStringWTF and change namespace TextCaseInsensitive.

ewk/ewk_frame.cpp: (ewk_frame_plugin_create):
ewk/ewk_view.cpp: (ewk_view_text_search): (ewk_view_text_matches_mark): (ewk_view_setting_font_cursive_set):

9:47 PM Changeset in webkit [65121] by tkent@chromium.org

4 edits in trunk

2010-08-10 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Chromium build fix for r65107.

src/WebAnimationControllerImpl.cpp: (WebKit::WebAnimationControllerImpl::suspendAnimations): (WebKit::WebAnimationControllerImpl::resumeAnimations):

2010-08-10 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Chromium build fix for r65107.

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):

8:40 PM Changeset in webkit [65120] by cmarrin@apple.com

3 edits in trunk/WebKit/chromium

another try at fixing Chromium build broken by http://trac.webkit.org/changeset/65107

8:30 PM Changeset in webkit [65119] by cmarrin@apple.com

1 edit in trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp

Another try at fixing Chromium build

8:10 PM Changeset in webkit [65118] by commit-queue@webkit.org

4 edits in trunk

2010-08-10 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

2d.path.clip.empty.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=43161

platform/mac/Skipped: Unskipping now passing path.clip.empty

2010-08-10 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

2d.path.clip.empty.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=43161

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clip): Catching the empty path case from being sent directly to CGContextClip - which would ignore it. Instead, using CGContextClip with a CGRectZero to achieve the desired behavior of reducing the clipping region to nothing.

7:53 PM Changeset in webkit [65117] by commit-queue@webkit.org

4 edits in trunk/WebCore

2010-08-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add video files to enable video in WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=43790

Add files regarding html5 video to CMakeList.txt for WebKit Efl.
But, this patch is not run html5 video on WebKit EFL yet.

CMakeLists.txt: Add files related to html5video.
platform/efl/LocalizedStringsEfl.cpp: Add functions for html5 video. (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Disable MediaPlayerPrivate::r

egisterMediaEngine for WebKit EFL.

7:34 PM Changeset in webkit [65116] by commit-queue@webkit.org

6 edits in trunk/WebCore

2010-08-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

Add a toRenderSVGImage function
https://bugs.webkit.org/show_bug.cgi?id=43789

Add a function for casting to RenderSVGImage and use it.

rendering/RenderSVGImage.h: (WebCore::toRenderSVGImage):
rendering/RenderTreeAsText.cpp: (WebCore::write):
rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGImage):
rendering/SVGRenderTreeAsText.h:
svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):

7:33 PM Changeset in webkit [65115] by cmarrin@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touching WebKit.idl to get IWebFramePrivate.idl to get rebuilt

7:21 PM Changeset in webkit [65114] by cmarrin@apple.com

2 edits in trunk/WebKitTools/DumpRenderTree

Fix for Chromium and gtk builds, broken by http://trac.webkit.org/changeset/65107

7:15 PM Changeset in webkit [65113] by commit-queue@webkit.org

4 edits in trunk

2010-08-10 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240

platform/gtk/Skipped: unskipped test

2010-08-10 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies): create the SoupCookieJar if it does not exist. Otherwise the accept policy won't be set.

7:14 PM Changeset in webkit [65112] by cmarrin@apple.com

1 edit in trunk/WebKit/win/WebFrame.cpp

Fix for Windows build, broken by http://trac.webkit.org/changeset/65107

7:13 PM Changeset in webkit [65111] by barraclough@apple.com

7 edits in trunk/WebKit

Build fix (update more includes)

WebKit/mac:

Plugins/Hosted/NetscapePluginHostManager.h:

WebKit/win:

WebKitDLL.h:
WebLocalizableStrings.cpp:
WebNotificationCenter.cpp:
WebPreferences.cpp:

6:55 PM Changeset in webkit [65110] by abarth@webkit.org

3 edits in trunk/WebCore

2010-08-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Clients of HTMLTokenizer should be able to see where characters went in the token
https://bugs.webkit.org/show_bug.cgi?id=43766

When viewing the source of a document, we want to colorize different
parts of the input depending on how they were tokenized. In this
patch, we expose the internal segmentation of a token by recording the
start and end offsets for each attribute name and each attribute value.

html/HTMLToken.h: (WebCore::HTMLToken::addNewAttribute): (WebCore::HTMLToken::beginAttributeName): (WebCore::HTMLToken::endAttributeName): (WebCore::HTMLToken::beginAttributeValue): (WebCore::HTMLToken::endAttributeValue): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::AtomicHTMLToken::AtomicHTMLToken):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):

6:28 PM Changeset in webkit [65109] by jamesr@google.com

2 edits in trunk/LayoutTests

2010-08-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.

fast/dom/Window/window-properties.html is pretty slow
https://bugs.webkit.org/show_bug.cgi?id=43755

window-properties.html would take 5.9 seconds to run on my Mac Pro.

Changing the order of checks in logValue to have more early returns before we get value and valueType brings this down to 3.66 seconds
Changing logBuffer to be a string that we append to instead of an array that we push() to brings this to 0.7 seconds (string appends are faster than array push()-es followed by a join() in all browsers except IE per http://closure-library.googlecode.com/svn/docs/closure_goog_string_stringbuffer.js.source.html

fast/dom/Window/window-properties.html:

6:19 PM Changeset in webkit [65108] by dumi@chromium.org

9 edits in trunk

Do not post a sync task to the DB thread if it's terminating.
https://bugs.webkit.org/show_bug.cgi?id=43676

Reviewed by David Levin.

bindings/generic/ActiveDOMCallback.cpp: The context can

sometimes be NULL. Check if it's NULL instead of asserting that
it's not.
(WebCore::ActiveDOMCallback::ActiveDOMCallback):

dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):

storage/Database.cpp: Do not post a sync task to the DB thread

if the DB thread is terminating. Also, when a task is destroyed,
ASSERT that it was completed, or that it had no synchronizer.
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):

storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTask::~DatabaseTask):
(WebCore::DatabaseTask::performTask):

storage/DatabaseTask.h:

(WebCore::DatabaseTaskSynchronizer::hasCheckedForTermination):
(WebCore::DatabaseTaskSynchronizer::setHasCheckedForTermination):
(WebCore::DatabaseTask::hasSynchronizer):
(WebCore::DatabaseTask::hasCheckedForTermination):

storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::terminationRequested):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):

storage/DatabaseThread.h:

6:03 PM Changeset in webkit [65107] by cmarrin@apple.com

26 edits
2 adds in trunk

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

Qt specific API. Missing symbian symbol defines in:

WebKit/qt/symbian/bwins/QtWebKitu.def
WebKit/qt/symbian/eabi/QtWebKitu.def

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendAnimations): (DumpRenderTreeSupportQt::resumeAnimations):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

Gtk specific API.

webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_suspend_animations): (webkit_web_frame_resume_animations):

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

Win specific API

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp: (WebFrame::suspendAnimations): (WebFrame::resumeAnimations):
WebFrame.h:

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.

WebView/WebFrame.mm: (-[WebFrame _suspendAnimations]): (-[WebFrame _resumeAnimations]):
WebView/WebFramePrivate.h:

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

This tests suspend and resume of animations. Transitions are currently broken
due to https://bugs.webkit.org/show_bug.cgi?id=43792. I will add transition
tests and tests of transition and animation interaction with that fix.

animations/animation-test-helpers.js: (matrixStringToArray):
animations/suspend-resume-animation-expected.txt: Added.
animations/suspend-resume-animation.html: Added.

2010-08-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733

Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
Calls functions with the same names on AnimationController for the
mainFrame.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/LayoutTestController.cpp: (suspendAnimationsCallback): (resumeAnimationsCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):

5:54 PM Changeset in webkit [65106] by barraclough@apple.com

2 edits in trunk/WebCore

Qt build fix.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

5:29 PM Changeset in webkit [65105] by jianli@chromium.org

5 edits in trunk/WebCore

Fix more build break.

bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::revokeBlobURL):

dom/ScriptExecutionContext.h:
html/Blob.cpp:

(WebCore::Blob::slice):

5:16 PM Changeset in webkit [65104] by barraclough@apple.com

58 edits in trunk

Bug 43817 - Remove UString::Rep
UString::Rep has for a long time been replaced by UStringImpl (Rep
remaining as a typedef). UStringImpl has since been removed too
(unified with StringImpl). Remove Rep, rename rep() to impl() and
m_rep to m_impl. Also add impl() method to Identifier, and rename
its UString member from _ustring to m_string.

Rubber stamped by Sam Weinig

JavaScriptCore:

API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty):

API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getOwnPropertyNames):
(JSC::::staticValueGetter):
(JSC::::staticFunctionGetter):

API/JSClassRef.cpp:

(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

API/JSClassRef.h:
API/OpaqueJSString.cpp:

(OpaqueJSString::ustring):

bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::findScopedProperty):
(JSC::keyForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

parser/JSParser.cpp:

(JSC::JSParser::parseStrictObjectLiteral):

pcre/pcre_exec.cpp:

(Histogram::add):

profiler/CallIdentifier.h:

(JSC::CallIdentifier::Hash::hash):

profiler/Profile.cpp:
profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintDataSampleStyle):

profiler/ProfileNode.h:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::ustring):
(JSC::Identifier::impl):
(JSC::Identifier::data):
(JSC::Identifier::size):
(JSC::Identifier::ascii):
(JSC::Identifier::isNull):
(JSC::Identifier::isEmpty):
(JSC::Identifier::toUInt32):
(JSC::Identifier::toStrictUInt32):
(JSC::Identifier::toArrayIndex):
(JSC::Identifier::toDouble):
(JSC::Identifier::equal):
(JSC::Identifier::add):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/InternalFunction.cpp:

(JSC::InternalFunction::displayName):

runtime/JSFunction.cpp:

(JSC::JSFunction::displayName):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::addStaticGlobals):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSString.h:

(JSC::):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):

runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):

runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::HashTable::deleteTable):

runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::setKey):
(JSC::HashEntry::key):
(JSC::HashTable::entry):

runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::addKnownUnique):

runtime/RegExp.cpp:

(JSC::RegExp::match):

runtime/RegExpCache.cpp:

(JSC::RegExpCache::create):

runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):

runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::rep):
(JSC::SmallStrings::singleCharacterStringRep):

runtime/SmallStrings.h:
runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

runtime/Structure.cpp:

(JSC::Structure::~Structure):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::hasTransition):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):

runtime/Structure.h:

(JSC::Structure::get):
(JSC::Structure::hasTransition):

runtime/StructureTransitionTable.h:
runtime/SymbolTable.h:
runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::toStrictUInt32):
(JSC::UString::substr):

runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::codePointCompare):
(JSC::IdentifierRepHash::hash):
(WTF::):

WebCore:

bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):

bindings/js/JSDOMBinding.h:

(WebCore::ustringToString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):

bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValueData::SerializedScriptValueData):

bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::~JavaStringImpl):
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
(JSC::Bindings::JavaStringImpl::uString):

bridge/jsc/BridgeJSC.h:

WebKit/mac:

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

5:14 PM Changeset in webkit [65103] by jianli@chromium.org

6 edits in trunk/WebCore

Fix qt build break.

html/BlobRegistryImpl.cpp:
html/BlobRegistryImpl.h:
html/BlobURL.cpp:
html/BlobURL.h:
platform/BlobRegistry.h:

5:03 PM Changeset in webkit [65102] by jianli@chromium.org

16 edits
4 copies
4 adds in trunk/WebCore

Add the support to register the blob data.
https://bugs.webkit.org/show_bug.cgi?id=43600

Reviewed by David Levin.

This is the first step towards adding Blob URL support. The blob has
an internal URL (used by FileReader) and public URLs (used by Blob.url).
The URL and its associated data are managed by BlobRegistry interface.

This patch does not remove the usage of BlobItem. It will be removed
when all the blob data support is hooked up and the new tests will be
added then.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedBlob::create):
(WebCore::SerializedBlob::url):
(WebCore::SerializedBlob::type):
(WebCore::SerializedBlob::size):
(WebCore::SerializedBlob::SerializedBlob):
(WebCore::SerializedFile::create):
(WebCore::SerializedFile::path):
(WebCore::SerializedFile::url):
(WebCore::SerializedFile::type):
(WebCore::SerializedFile::SerializedFile):
(WebCore::SerializedFileList::item):
(WebCore::SerializedFileList::SerializedFileList):
(WebCore::SerializedScriptValueData::SerializedScriptValueData):
(WebCore::SharedSerializedData::asBlob):
(WebCore::SharedSerializedData::asFile):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::convertIfTerminal):
(WebCore::TeardownTreeWalker::convertIfTerminal):

bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValueData::):
(WebCore::SerializedScriptValueData::asString):
(WebCore::SerializedScriptValueData::asBlob):
(WebCore::SerializedScriptValueData::asFile):

bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Writer::writeBlob):
(WebCore::ZigZag::Writer::writeFile):
(WebCore::ZigZag::Writer::writeFileList):
(WebCore::ZigZag::Writer::doWriteUintHelper):
(WebCore::ZigZag::Writer::doWriteUint32):
(WebCore::ZigZag::Writer::doWriteUint64):
(WebCore::ZigZag::Serializer::writeBlob):
(WebCore::ZigZag::Serializer::writeFile):
(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):
(WebCore::ZigZag::Reader::doReadUintHelper):
(WebCore::ZigZag::Reader::doReadUint32):
(WebCore::ZigZag::Reader::doReadUint64):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::trackBlobURL):
(WebCore::ScriptExecutionContext::revokeBlobURL):

dom/ScriptExecutionContext.h:
html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::createPublicURL):

html/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::url):

html/BlobRegistryImpl.cpp: Added.
html/BlobRegistryImpl.h: Added.
html/BlobStorageData.h: Added.
html/BlobURL.cpp: Added.
html/BlobURL.h: Added.
html/File.cpp:

(WebCore::File::File):

html/File.h:

(WebCore::File::create):

platform/BlobData.cpp: Added.
platform/BlobData.h: Added.
platform/BlobRegistry.h: Added.

4:52 PM Changeset in webkit [65101] by senorblanco@chromium.org

6 edits in trunk/LayoutTests

2010-08-10 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

Rebaselines a test for win & linux, removes it from test_expectations.

platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.checksum:
platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-win/fast/canvas/image-object-in-canvas-expected.checksum:
platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium/test_expectations.txt:

4:46 PM Changeset in webkit [65100] by abarth@webkit.org

3 edits in trunk/WebCore

2010-08-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SegmentedString should keep track of how many characters it consumes
https://bugs.webkit.org/show_bug.cgi?id=43765

The easiest way to keep track of how many characters we've consumed
would be to increment a counter every time we advance, but that's too
slow. Instead, we keep track lazily and update our summary durning the
slow case of advance (which is sufficiently rare).

There's some subtly to how this works w.r.t. "unconsuming" characters
by pushing them back on the front of the segmented string. This isn't
really a "right answer" here because the notion of unconsuming input
isn't present in the API. This patch makes some assumptions about how
clients of this class use its API. In a future patch, we might want to
rename some of the method names to make this more explicit.

platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring):
platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::numberOfCharactersConsumed): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::numberOfCharactersConsumed):

3:32 PM Changeset in webkit [65099] by barraclough@apple.com

16 edits
1 delete in trunk

Bug 43816 - Remove UStringImpl
The class was actually removed a long time ago, replaced by StringImpl.
UStringImpl is just a typedef onto StringImpl. Remove this.

JavaScriptCore:

API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):

JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::replaceCharacter):

runtime/JSString.h:

(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):

runtime/JSStringBuilder.h:

(JSC::jsMakeNontrivialString):

runtime/RopeImpl.cpp:

(JSC::RopeImpl::derefFibersNonRecursive):

runtime/RopeImpl.h:

(JSC::RopeImpl::deref):

runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

runtime/UString.cpp:

(JSC::initializeUString):

runtime/UString.h:

(JSC::UString::adopt):
(JSC::tryMakeString):
(JSC::makeString):

runtime/UStringImpl.h: Removed.

WebCore:

Rubber stamped by Sam Weinig.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):

3:24 PM Changeset in webkit [65098] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2010-08-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

[Chromium/DRT] Enable saving layout test results.
https://bugs.webkit.org/show_bug.cgi?id=43796

BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more

parameters to the new-run-webkit-tests, including the name
of the test results server.

3:02 PM Changeset in webkit [65097] by senorblanco@chromium.org

5 edits in trunk

2010-08-09 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Prefer the medium-quality (bilinear) image resampling for 2D canvas on
Chromium.
https://bugs.webkit.org/show_bug.cgi?id=43646

This is what the accelerated path is going to do,
so do it in the software path as well.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
platform/graphics/GraphicsContext.h:

2010-08-09 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Temporarily mark html/canvas/image-object-in-canvas.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=43646

platform/chromium/test_expectations.txt:

2:50 PM Changeset in webkit [65096] by kbr@google.com

2 edits in trunk/WebKit/chromium

2010-08-10 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Roll forward Chromium DEPS to r55584
https://bugs.webkit.org/show_bug.cgi?id=43811

DEPS:

2:35 PM Changeset in webkit [65095] by Chris Fleizach

3 edits
2 adds in trunk

Removing an element from an anonymous block causes crash
https://bugs.webkit.org/show_bug.cgi?id=42309

Reviewed by Dave Hyatt.

WebCore:

There was a case where a continuation was added as a child, but if you asked
that child who is your parent, it would return the wrong answer.

The specific scenario was when a sibling of an element who was the start of a
continuation was present. Retrieving the parent object had then follow the sibling
chain and then follow the originating continuation chain.

Test: accessibility/removed-anonymous-block-child-causes-crash.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::nextSibling):

Fix erroneous comment

(WebCore::nextContinuation):
(WebCore::AccessibilityRenderObject::renderParentObject):

Handle unhandled continuation case.

(WebCore::AccessibilityRenderObject::addChildren):

ASSERT that the parentObject() is the same when adding a new child.

LayoutTests:

accessibility/removed-anonymous-block-child-causes-crash-expected.txt: Added.
accessibility/removed-anonymous-block-child-causes-crash.html: Added.

2:35 PM Changeset in webkit [65094] by commit-queue@webkit.org

2 edits in trunk/WebKit/chromium

2010-08-10 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Support appcache status change for Chrome
https://bugs.webkit.org/show_bug.cgi?id=43531

src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache):

2:27 PM Changeset in webkit [65093] by kbr@google.com

5 edits in trunk/WebKit/chromium

2010-08-10 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Use Chromium OpenGL bindings rather than GLEW in WebGraphicsContextDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=43754

Deleted per-platform OpenGL context management code, now
abstracted via GLContext. Built and tested in Chromium with
--in-process-webgl flag.

WebKit.gyp:
src/GraphicsContext3D.cpp:
src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
src/WebGraphicsContext3DDefaultImpl.h:

1:56 PM Changeset in webkit [65092] by jianli@chromium.org

3 edits in trunk/WebKitTools

More chromium build fix.

DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::grantPermission):
(NotificationPresenter::show):
(NotificationPresenter::checkPermission):

1:47 PM Changeset in webkit [65091] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-08-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Make FastMalloc more portable.
https://bugs.webkit.org/show_bug.cgi?id=41790

wtf/FastMalloc.cpp: (WTF::TCMalloc_Central_FreeList::Populate): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

1:46 PM Changeset in webkit [65090] by inferno@chromium.org

3 edits
2 adds in trunk

2010-08-10 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Take checks for ruby base existence out of the ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=43795

Test: fast/ruby/ruby-remove-no-base.html

rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::addChild): (WebCore::RenderRubyRun::removeChild):

2010-08-10 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that removing a ruby child which causes merging of ruby base withe
a non existant base of the right sibling run does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=43795

fast/ruby/ruby-remove-no-base-expected.txt: Added.
fast/ruby/ruby-remove-no-base.html: Added.

1:44 PM Changeset in webkit [65089] by zmo@google.com

8 edits in trunk

2010-08-06 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

texture functions should gen INVALID_OPERATION if no texture is bound
https://bugs.webkit.org/show_bug.cgi?id=42907

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Check if a texture is bound to target. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::generateMipmap): Ditto. (WebCore::WebGLRenderingContext::getTexParameter): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texParameter): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTextureBinding): Check if target is valid and if a texture is bound to it.
html/canvas/WebGLRenderingContext.h: Declare validateTextureBinding().

2010-08-06 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

texture functions should gen INVALID_OPERATION if no texture is bound
https://bugs.webkit.org/show_bug.cgi?id=42907

fast/canvas/webgl/gl-enum-tests-expected.txt: Need to bind a texture before testing tex-functions.
fast/canvas/webgl/gl-enum-tests.html: Ditto.
fast/canvas/webgl/null-object-behaviour-expected.txt: Test tex-functions when no texture is bound.
fast/canvas/webgl/null-object-behaviour.html: Ditto.

1:38 PM Changeset in webkit [65088] by jianli@chromium.org

3 edits in trunk/WebKitTools

Chromium build fix.

DumpRenderTree/chromium/MockSpellCheck.cpp:
DumpRenderTree/chromium/NotificationPresenter.cpp:

1:29 PM Changeset in webkit [65087] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by Sam Weinig.

[WINCE] Implement Path::currentPoint()
https://bugs.webkit.org/show_bug.cgi?id=42927

platform/graphics/wince/PathWince.cpp: (WebCore::Path::currentPoint):

1:13 PM Changeset in webkit [65086] by ariya@webkit.org

2 edits in trunk/WebCore

2010-08-10 Ariya Hidayat <ariya@sencha.com>

[Qt] Warning fix, remove reference to platform/text/StringImpl.h

WebCore.pro:

12:59 PM Changeset in webkit [65085] by jianli@chromium.org

2 edits in trunk/WebKit/chromium

Another chromium build fix.

src/AssertMatchingEnums.cpp:

12:52 PM Changeset in webkit [65084] by alice.liu@apple.com

2 edits in trunk/WebCore

Chromium build fix attempt. not reviewed

platform/text/TextBoundaries.cpp: use correct stringimplh include

12:06 PM Changeset in webkit [65083] by jianli@chromium.org

3 edits in trunk/WebCore

Chromium build fix.

platform/graphics/chromium/FontPlatformDataChromiumWin.h:
platform/graphics/chromium/FontPlatformDataLinux.cpp:

11:57 AM Changeset in webkit [65082] by abarth@webkit.org

16 edits
2 adds in trunk

2010-08-10 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
https://bugs.webkit.org/show_bug.cgi?id=42827.

Test: fast/events/popup-blocked-from-iframe-script.html

WebCore.order:
bindings/js/JSDOMBinding.cpp: (WebCore::processingUserGesture):
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::domWindowAllowPopUp): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
bindings/js/ScriptController.h:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::anyPageIsProcessingUserGesture):
bindings/v8/ScriptController.h:
bindings/v8/specialization/V8BindingState.cpp: (WebCore::::processingUserGesture):
loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture):

2010-08-10 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
https://bugs.webkit.org/show_bug.cgi?id=42827

fast/events/popup-blocked-from-iframe-script-expected.txt: Added.
fast/events/popup-blocked-from-iframe-script.html: Added.

11:50 AM Changeset in webkit [65081] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-08-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by David Levin.

[WINCE] Buildfix for CE 6.0
https://bugs.webkit.org/show_bug.cgi?id=43027

CE 6.0 doesn't define localtime in the system include files.

wtf/Platform.h: Include ce_time.h on all OS(WINCE).

11:39 AM Changeset in webkit [65080] by victorw@chromium.org

3 edits in trunk/WebKitTools

2010-08-10 Victor Wang <victorw@chromium.org>

Reviewed by Ojan Vafai.

Update test results server merge logic so the aggregated
results and times are updated for tests that are
in aggragated json but not in incremental json.

Also update unittest to test this case.

https://bugs.webkit.org/show_bug.cgi?id=43769

TestResultServer/model/jsonresults.py:
TestResultServer/model/jsonresults_unittest.py:

11:22 AM Changeset in webkit [65079] by barraclough@apple.com

2 edits in trunk/WebCore

Chromium build fix

platform/graphics/chromium/FontPlatformDataLinux.h:

11:22 AM Changeset in webkit [65078] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Unreviewed.

Skipping editing/selection/selection-modify-crash.html (added by r65061) on gtk
because it has been crashing on gtk since r65061 and it doesn't crash on other platforms.

platform/gtk/Skipped:

10:45 AM Changeset in webkit [65077] by barraclough@apple.com

228 edits
1 move
1 add
4 deletes in trunk

Bug 43786 - Move AtomicStringHash from WebCore to WTF
Also remove deprecated string headers from WebCore/platform/text.

Rubber stamped by Sam Weinig.

JavaScriptCore:

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/text/AtomicString.h:
wtf/text/AtomicStringHash.h: Copied from WebCore/platform/text/AtomicStringHash.h.

WebCore:

ForwardingHeaders/wtf/text/AtomicStringHash.h: Added.
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
bindings/cpp/WebDOMHTMLCollectionCustom.cpp:
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSDOMApplicationCacheCustom.cpp:
bindings/js/JSDOMMimeTypeArrayCustom.cpp:
bindings/js/JSDOMPluginArrayCustom.cpp:
bindings/js/JSDOMPluginCustom.cpp:
bindings/js/JSDOMStringMapCustom.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDataGridColumnListCustom.cpp:
bindings/js/JSHTMLAllCollectionCustom.cpp:
bindings/js/JSHTMLCollectionCustom.cpp:
bindings/js/JSMessagePortCustom.cpp:
bindings/js/JSNodeListCustom.cpp:
bindings/scripts/CodeGeneratorCPP.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
bindings/scripts/test/CPP/WebDOMTestObj.cpp:
bindings/scripts/test/V8/V8TestInterface.h:
bindings/scripts/test/V8/V8TestObj.h:
bindings/v8/ScriptDebugServer.h:
bindings/v8/V8Binding.cpp:
bindings/v8/V8Binding.h:
bridge/jni/v8/JavaClassV8.h:
css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:
css/CSSFontSelector.h:
css/CSSNamespace.h:
css/CSSParser.cpp:
css/CSSParser.h:
css/CSSParserValues.h:
css/CSSStyleSelector.h:
css/CSSVariablesDeclaration.h:
css/MediaFeatureNames.h:
css/MediaQueryExp.h:
css/WebKitCSSKeyframesRule.h:
dom/CustomEvent.h:
dom/Document.cpp:
dom/Event.cpp:
dom/Event.h:
dom/EventNames.h:
dom/EventTarget.h:
dom/InputElement.h:
dom/MessagePort.cpp:
dom/MessagePort.h:
dom/NameNodeList.h:
dom/NodeRareData.h:
dom/QualifiedName.h:
dom/ScriptElement.cpp:
dom/SpaceSplitString.h:
dom/TagNodeList.h:
dom/XMLDocumentParser.h:
editing/EditorCommand.cpp:
history/mac/HistoryItemMac.mm:
html/BlobBuilder.cpp:
html/DataGridColumn.h:
html/DataGridColumnList.cpp:
html/HTMLDocument.h:
html/HTMLInputElement.cpp:
html/HTMLTokenizer.cpp:
html/HTMLTokenizer.h:
html/LegacyPreloadScanner.cpp:
html/LegacyPreloadScanner.h:
inspector/InspectorCSSStore.h:
inspector/InspectorController.h:
inspector/InspectorDOMAgent.cpp:
inspector/InspectorDOMAgent.h:
inspector/InspectorDebuggerAgent.h:
inspector/InspectorValues.h:
loader/Cache.h:
loader/CrossOriginAccessControl.cpp:
loader/CrossOriginPreflightResultCache.h:
loader/DocLoader.h:
loader/ImageLoader.h:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheStorage.h:
loader/appcache/DOMApplicationCache.h:
loader/icon/IconDatabase.h:
loader/icon/IconRecord.h:
loader/loader.h:
notifications/Notification.h:
page/FrameTree.h:
page/Page.cpp:
page/PageGroup.h:
page/SecurityOrigin.h:
page/Settings.h:
page/WindowFeatures.cpp:
page/animation/AnimationBase.h:
page/animation/AnimationControllerPrivate.h:
page/animation/CompositeAnimation.h:
platform/Cookie.h:
platform/KURL.cpp:
platform/KURLGoogle.cpp:
platform/KURLHash.h:
platform/Length.cpp:
platform/LinkHash.cpp:
platform/LinkHash.h:
platform/MIMETypeRegistry.cpp:
platform/MIMETypeRegistry.h:
platform/SchemeRegistry.h:
platform/ThreadGlobalData.cpp:
platform/ThreadGlobalData.h:
platform/cf/BinaryPropertyList.cpp:
platform/chromium/SearchPopupMenuChromium.cpp:
platform/efl/ClipboardEfl.cpp:
platform/efl/CookieJarEfl.cpp:
platform/efl/PlatformKeyboardEventEfl.cpp:
platform/graphics/FontCache.cpp:
platform/graphics/FontFamily.h:
platform/graphics/MediaPlayer.h:
platform/graphics/cg/ImageSourceCGWin.cpp:
platform/graphics/chromium/FontCacheChromiumWin.cpp:
platform/graphics/chromium/FontCacheLinux.cpp:
platform/graphics/chromium/FontUtilsChromiumWin.cpp:
platform/graphics/chromium/LayerChromium.h:
platform/graphics/filters/Filter.h:
platform/graphics/mac/FontPlatformData.h:
platform/graphics/mac/GraphicsLayerCA.h:
platform/graphics/qt/FontCacheQt.cpp:
platform/graphics/win/FontCacheWin.cpp:
platform/graphics/win/FontPlatformDataCGWin.cpp:
platform/graphics/win/FontPlatformDataCairoWin.cpp:
platform/graphics/win/FontPlatformDataWin.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
platform/graphics/win/WKCACFLayer.h:
platform/graphics/wince/FontPlatformData.cpp:
platform/graphics/wx/FontPlatformData.h:
platform/gtk/ClipboardGtk.cpp:
platform/gtk/DataObjectGtk.h:
platform/haiku/ClipboardHaiku.cpp:
platform/haiku/CookieJarHaiku.cpp:
platform/haiku/SearchPopupMenuHaiku.cpp:
platform/mac/SearchPopupMenuMac.mm:
platform/mac/ThreadCheck.mm:
platform/network/CredentialStorage.cpp:
platform/network/HTTPHeaderMap.h:
platform/network/cf/DNSCFNet.cpp:
platform/network/curl/CookieJarCurl.cpp:
platform/qt/ClipboardQt.cpp:
platform/text/AtomicString.h: Removed.
platform/text/AtomicStringHash.h: Removed.
platform/text/AtomicStringImpl.h: Removed.
platform/text/AtomicStringKeyedMRUCache.h:
platform/text/StringBuilder.cpp:
platform/text/StringHash.h: Removed.
platform/text/StringImpl.h: Removed.
platform/text/TextCodecLatin1.cpp:
platform/text/TextCodecUTF16.cpp:
platform/text/TextCodecUserDefined.cpp:
platform/text/cf/HyphenationCF.cpp:
platform/text/cf/StringImplCF.cpp:
platform/text/mac/HyphenationMac.mm:
platform/text/mac/StringImplMac.mm:
platform/text/transcoder/FontTranscoder.h:
platform/text/wince/TextCodecWinCE.cpp:
platform/win/BString.cpp:
platform/win/ClipboardWin.cpp:
platform/win/SearchPopupMenuWin.cpp:
platform/wince/SearchPopupMenuWince.cpp:
platform/wx/ClipboardWx.cpp:
plugins/DOMMimeTypeArray.cpp:
plugins/DOMPlugin.cpp:
plugins/DOMPluginArray.cpp:
plugins/PluginDatabase.h:
plugins/PluginPackage.h:
plugins/PluginStream.h:
rendering/RenderApplet.h:
rendering/RenderText.cpp:
rendering/style/BindingURI.h:
rendering/style/ContentData.cpp:
rendering/style/CounterContent.h:
rendering/style/CounterDirectives.h:
rendering/style/KeyframeList.h:
rendering/style/StyleRareInheritedData.h:
storage/AbstractDatabase.cpp:
storage/DatabaseAuthorizer.h:
storage/DatabaseTracker.h:
storage/IDBDatabaseBackendImpl.h:
storage/IDBFactoryBackendImpl.h:
storage/IDBObjectStoreBackendImpl.h:
storage/OriginQuotaManager.h:
storage/OriginUsageRecord.h:
storage/SQLTransactionCoordinator.h:
storage/StorageAreaSync.h:
storage/StorageMap.h:
storage/StorageNamespaceImpl.cpp:
storage/chromium/QuotaTracker.h:
svg/SVGAltGlyphElement.h:
svg/SVGDocumentExtensions.cpp:
svg/SVGDocumentExtensions.h:
svg/SVGFitToViewBox.cpp:
svg/SVGLangSpace.h:
svg/animation/SMILTimeContainer.h:
svg/graphics/filters/SVGFilterBuilder.h:
websockets/WebSocket.h:
websockets/WebSocketChannel.cpp:
websockets/WebSocketHandshake.cpp:
websockets/WebSocketHandshakeResponse.cpp:
wml/WMLPageState.h:
workers/AbstractWorker.h:
workers/DefaultSharedWorkerRepository.h:
workers/Worker.h:
workers/WorkerContext.h:
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp:
xml/XMLHttpRequestUpload.h:
xml/XPathExpressionNode.h:
xml/XPathNamespace.h:
xml/XPathParser.cpp:
xml/XSLTProcessor.h:

WebKit/chromium:

src/WebKit.cpp:
src/WebPageSerializerImpl.h:
src/WebString.cpp:

WebKit/gtk:

gdom/ConvertToGCharPrivate.h:

WebKit/wx:

WebEdit.cpp:

10:34 AM Changeset in webkit [65076] by jamesr@google.com

2 edits in trunk/WebKit/chromium

2010-08-10 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Feature defines are out of sync between features.gypi and downstream feature_overrides.gypi
https://bugs.webkit.org/show_bug.cgi?id=43756

This synchronizes the feature defines to what's currently downstream (at r55468).
The difference between the build.webkit.org bots and the chromium bots has
caused strange compilation failures lately.

features.gypi:

9:50 AM Changeset in webkit [65075] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-08-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Adding changes that escaped from r65072.

Web Inspector: move database processing to native layer.
https://bugs.webkit.org/show_bug.cgi?id=43788

inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):

9:43 AM Changeset in webkit [65074] by kov@webkit.org

2 edits in trunk/WebCore

2010-08-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Inputs of type 'search' have weird looking checkboxes instead of search/clear icons
https://bugs.webkit.org/show_bug.cgi?id=43760

Draw appropriate GTK+ stock images for search/clear icons in search entries.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):

9:31 AM Changeset in webkit [65073] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-08-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Qt build fix, follow up for r65072.

inspector/InspectorController.cpp: (WebCore::InspectorController::releaseFrontendLifetimeAgents):

9:06 AM Changeset in webkit [65072] by pfeldman@chromium.org

26 edits
1 copy
1 add in trunk/WebCore

2010-08-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move database processing to native layer.

https://bugs.webkit.org/show_bug.cgi?id=43788

English.lproj/localizedStrings.js:
WebCore.gypi:
bindings/js/JSInjectedScriptHostCustom.cpp:
bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
inspector/CodeGeneratorInspector.pm:
inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch):
inspector/InjectedScript.h:
inspector/InjectedScriptHost.cpp:
inspector/InjectedScriptHost.h:
inspector/InjectedScriptHost.idl:
inspector/Inspector.idl:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::executeSQL):
inspector/InspectorBackend.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
inspector/InspectorController.h:
inspector/InspectorDebuggerAgent.h:
inspector/InspectorStorageAgent.cpp: Added. (WebCore::): (WebCore::InspectorStorageAgent::InspectorStorageAgent): (WebCore::InspectorStorageAgent::~InspectorStorageAgent): (WebCore::InspectorStorageAgent::executeSQL): (WebCore::InspectorStorageAgent::clearFrontend):
inspector/InspectorStorageAgent.h: Added. (WebCore::InspectorStorageAgent::create): (WebCore::InspectorStorageAgent::frontend):
inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.sqlTransactionSucceeded): (WebInspector.sqlTransactionFailed):
inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished): (WebInspector.DatabaseQueryView.prototype._queryError):
inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
inspector/front-end/InjectedScript.js:
inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):

7:14 AM Changeset in webkit [65071] by steveblock@google.com

2 edits in trunk/WebCore

2010-08-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

[V8] DeviceMotionEvent can not be used from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=43785

This is tested by the existing tests fast/dom/DeviceMotion/create-event.html
and fast/dom/DeviceMotion/optional-event-properties.html.

bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):

6:52 AM Changeset in webkit [65070] by abecsi@webkit.org

7 edits
3 adds in trunk

2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

https://bugs.webkit.org/show_bug.cgi?id=43621

Just build changes so no new tests.

WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
features.pri: Added.

2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

https://bugs.webkit.org/show_bug.cgi?id=43621

WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.

2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

https://bugs.webkit.org/show_bug.cgi?id=43621

WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
WebKit2.pro: Build specification for the WebKit2 framework.
WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.

6:23 AM Changeset in webkit [65069] by yurys@chromium.org

6 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of utility context
https://bugs.webkit.org/show_bug.cgi?id=43787

public/WebDevToolsAgentClient.h:
src/DebuggerAgentImpl.cpp:
src/DebuggerAgentImpl.h:
src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
src/WebDevToolsAgentImpl.h:

5:42 AM Changeset in webkit [65068] by yurys@chromium.org

8 edits in trunk

2010-08-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
https://bugs.webkit.org/show_bug.cgi?id=43780

inspector/CodeGeneratorInspector.pm:
inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
inspector/InspectorController.h: (WebCore::InspectorController::hasFrontend):
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue):
inspector/InspectorDebuggerAgent.h:

2010-08-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
https://bugs.webkit.org/show_bug.cgi?id=43780

src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):

4:34 AM Changeset in webkit [65067] by vestbo@webkit.org

2 edits in trunk/WebCore

Make sure NPAPI plugins get an initial setNPWindow on Mac

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=43782

plugins/mac/PluginViewMac.mm:

4:20 AM Changeset in webkit [65066] by steveblock@google.com

3 edits
2 adds in trunk/LayoutTests

2010-08-09 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Accelerometer tests need V8 results
https://bugs.webkit.org/show_bug.cgi?id=43443

This patch adds V8-specific results for Android for the existing window-property.html test.

fast/dom/DeviceMotion/script-tests/window-property.js:
fast/dom/DeviceMotion/window-property-expected.txt:
platform/android-v8/fast/dom/DeviceMotion: Added.
platform/android-v8/fast/dom/DeviceMotion/window-property-expected.txt: Added.

4:12 AM Changeset in webkit [65065] by krit@webkit.org

17 edits in trunk/WebCore

2010-08-10 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Use SVGPathParser to create SVG paths and to perform path animations
https://bugs.webkit.org/show_bug.cgi?id=43696

Removed toString() functions in all SVGPathSeg* objects as well as toPath() in SVGPathSegList.
These hacks were used to create a SVG path data string or a platform path from a SVGPathSegList.
Use the new SVGPathParser instead.

Doesn't affect any tests.

svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
svg/SVGPathElement.cpp: (WebCore::SVGPathElement::toPathData):
svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildPathFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
svg/SVGPathParserFactory.h:
svg/SVGPathSeg.cpp:
svg/SVGPathSeg.h:
svg/SVGPathSegArc.cpp:
svg/SVGPathSegArc.h:
svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter):
svg/SVGPathSegCurvetoCubic.h:
svg/SVGPathSegCurvetoCubicSmooth.h:
svg/SVGPathSegCurvetoQuadratic.h:
svg/SVGPathSegLinetoHorizontal.h:
svg/SVGPathSegLinetoVertical.h:
svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
svg/SVGPathSegList.h:

3:49 AM Changeset in webkit [65064] by Csaba Osztrogonác

5 edits
2 deletes in trunk

2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65056.
http://trac.webkit.org/changeset/65056
https://bugs.webkit.org/show_bug.cgi?id=43773

"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).

html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):

2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65056.
http://trac.webkit.org/changeset/65056
https://bugs.webkit.org/show_bug.cgi?id=43773

"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).

fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Removed.
fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Removed.

3:13 AM Changeset in webkit [65063] by jorlow@chromium.org

5 edits
9 adds in trunk/WebKit/chromium

2010-08-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Implement chromium WebDeviceOrientationClient wrapper and have WebViewImpl get it from WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=43258

Provide a DeviceOrientationClient to Page by means of a
DeviceOrientationClientProxy that proxies calls to
a WebDeviceOrientationClient, an interface that can be implemented
in the WebKit or Chromium layer. An implementation to be used for
layout tests, wrapping DeviceOrientationClientMock, is provided.

WebKit.gyp:
public/WebDeviceOrientation.h: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation):
public/WebDeviceOrientationClient.h: Added. (WebKit::WebDeviceOrientationClient::~WebDeviceOrientationClient):
public/WebDeviceOrientationClientMock.h: Added. (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock): (WebKit::WebDeviceOrientationClientMock::~WebDeviceOrientationClientMock):
public/WebDeviceOrientationController.h: Added. (WebKit::WebDeviceOrientationController::WebDeviceOrientationController):
public/WebViewClient.h: (WebKit::WebViewClient::deviceOrientationClient):
src/DeviceOrientationClientProxy.cpp: Added. (WebKit::DeviceOrientationClientProxy::setController): (WebKit::DeviceOrientationClientProxy::startUpdating): (WebKit::DeviceOrientationClientProxy::stopUpdating): (WebKit::DeviceOrientationClientProxy::lastOrientation):
src/DeviceOrientationClientProxy.h: Added. (WebKit::DeviceOrientationClientProxy::DeviceOrientationClientProxy):
src/WebDeviceOrientation.cpp: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation): (WebKit::WebDeviceOrientation::operator=): (WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):
src/WebDeviceOrientationClientMock.cpp: Added. (WebKit::WebDeviceOrientationClientMock::setController): (WebKit::WebDeviceOrientationClientMock::startUpdating): (WebKit::WebDeviceOrientationClientMock::stopUpdating): (WebKit::WebDeviceOrientationClientMock::lastOrientation): (WebKit::WebDeviceOrientationClientMock::setOrientation): (WebKit::WebDeviceOrientationClientMock::initialize): (WebKit::WebDeviceOrientationClientMock::reset):
src/WebDeviceOrientationController.cpp: Added. (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): (WebKit::WebDeviceOrientationController::controller):
src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
src/WebViewImpl.h:

3:08 AM Changeset in webkit [65062] by tkent@chromium.org

5 edits
2 adds in trunk

2010-08-10 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Kent Tamura.

Iterate over :first-letter so that it will be included in innerText.
https://bugs.webkit.org/show_bug.cgi?id=39863

Test: fast/dom/inner-text-first-letter.html

editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::emitText):
editing/TextIterator.h:

2010-08-10 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Kent Tamura.

Iterate over :first-letter so that it will be included in innerText.
https://bugs.webkit.org/show_bug.cgi?id=39863

fast/dom/inner-text-first-letter-expected.txt: Added.
fast/dom/inner-text-first-letter.html: Added.

2:26 AM Changeset in webkit [65061] by tkent@chromium.org

3 edits
2 adds in trunk

Fix crashes by SelectionController::modify().
https://bugs.webkit.org/show_bug.cgi?id=43032

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/selection-modify-crash.html

editing/visible_units.cpp:

(WebCore::endOfDocument): Add NULL-check for document()->documentElement().

LayoutTests:

editing/selection/selection-modify-crash-expected.txt: Added.
editing/selection/selection-modify-crash.html: Added.

2:05 AM Changeset in webkit [65060] by hamaji@chromium.org

3 edits in trunk/WebKit/chromium

2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r64988.
http://trac.webkit.org/changeset/64988
https://bugs.webkit.org/show_bug.cgi?id=43775

"It seems to break chromium's ui_tests" (Requested by hamaji
on #webkit).

public/WebFrameClient.h:
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):

1:47 AM Changeset in webkit [65059] by krit@webkit.org

15 edits
2 adds in trunk/WebCore

2010-08-10 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add missing SVGPathSegList source for SVGPathParser
https://bugs.webkit.org/show_bug.cgi?id=43691

Added SVGPathSegListSource to parse normalized or unaltered SVGPathSegLists and transform
them to either a SVG path string, or a SVGPathByteStream. This will be needed to synchronize
all SVGPathSegLists and the SVG path string of the 'd' attribute.
Refactored SVGPathSource code, to read concrete path segments instead of type/flag/coordinates
from the data sources. This is a further abstraction and seperates the reading of content from
the parsing and interpreting.

Doesn't affect any tests.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
svg/SVGAllInOne.cpp:
svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand): (WebCore::SVGPathByteStreamSource::parseMoveToSegment): (WebCore::SVGPathByteStreamSource::parseLineToSegment): (WebCore::SVGPathByteStreamSource::parseLineToHorizontalSegment): (WebCore::SVGPathByteStreamSource::parseLineToVerticalSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathByteStreamSource::parseArcToSegment):
svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
svg/SVGPathParser.cpp: (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment):
svg/SVGPathSegListSource.cpp: Added. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::~SVGPathSegListSource): (WebCore::SVGPathSegListSource::hasMoreData): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseLineToHorizontalSegment): (WebCore::SVGPathSegListSource::parseLineToVerticalSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathSegListSource::parseArcToSegment):
svg/SVGPathSegListSource.h: Added. (WebCore::SVGPathSegListSource::create): (WebCore::SVGPathSegListSource::moveToNextToken):
svg/SVGPathSource.h:
svg/SVGPathStringSource.cpp: (WebCore::SVGPathStringSource::parseMoveToSegment): (WebCore::SVGPathStringSource::parseLineToSegment): (WebCore::SVGPathStringSource::parseLineToHorizontalSegment): (WebCore::SVGPathStringSource::parseLineToVerticalSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathStringSource::parseArcToSegment):
svg/SVGPathStringSource.h:

1:41 AM Changeset in webkit [65058] by loislo@chromium.org

2 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: small refactoring for CodeGeneratorInspector.
A number of push calls were replaced by embedded text.
Just for improve code readability.
https://bugs.webkit.org/show_bug.cgi?id=43770

inspector/CodeGeneratorInspector.pm:

12:49 AM Changeset in webkit [65057] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove references to deleted header InspectorFrontend.h

src/WebDevToolsAgentImpl.cpp:

12:29 AM Changeset in webkit [65056] by eric@webkit.org

5 edits
2 adds in trunk

2010-08-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762

In order to fix the insertAdjacentHTML I had to change behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.

fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.

2010-08-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762

In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.

Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html

html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
- This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
html/HTMLElement.cpp: (WebCore::contextElementForInsertion):
- This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.

(WebCore::HTMLElement::insertAdjacentHTML):

Use the right contextElement now that we know how to compute it.

html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
- This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.

12:25 AM Changeset in webkit [65055] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation.

src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::frontendLoaded):

12:12 AM Changeset in webkit [65054] by morrita@google.com

3 edits in trunk/LayoutTests

2010-08-10 MORITA Hajime <morrita@google.com>

Unreviewed test fix.

https://bugs.webkit.org/show_bug.cgi?id=43771
[Chromium] Test: editing/selection/doubleclick-inline-first-last-contenteditable fails on win

Set platform selectTrailingWhitespaceEnabled false, which is true only on windows.

editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
platform/chromium/test_expectations.txt:

Aug 9, 2010:

11:59 PM Changeset in webkit [65053] by yurys@chromium.org

13 edits
2 deletes in trunk

2010-08-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
https://bugs.webkit.org/show_bug.cgi?id=43726

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: Removed.
inspector/InspectorFrontend.h: Removed.

2010-08-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
https://bugs.webkit.org/show_bug.cgi?id=43726

http/tests/inspector/inspector-test.js: (notifyDone):

10:50 PM Changeset in webkit [65052] by loislo@chromium.org

15 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove obsolete JS wrappers for did* methods.
https://bugs.webkit.org/show_bug.cgi?id=43738

inspector/CodeGeneratorInspector.pm:
inspector/Inspector.idl:
inspector/front-end/BreakpointManager.js:
inspector/front-end/Callback.js:
inspector/front-end/ConsoleView.js:
inspector/front-end/DOMAgent.js:
inspector/front-end/DOMStorage.js:
inspector/front-end/Database.js:
inspector/front-end/InjectedScriptAccess.js:
inspector/front-end/ProfilesPanel.js:
inspector/front-end/ResourcesPanel.js:
inspector/front-end/ScriptView.js:
inspector/front-end/ScriptsPanel.js:
inspector/front-end/inspector.js: (WebInspector.reportProtocolError):

10:13 PM Changeset in webkit [65051] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Fix Qt/ARM again, this time including the other changed file.

9:00 PM Changeset in webkit [65050] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <tonikitoo@webkit.org>

eviewed by Ariya Hidayat.

[Qt] QtTestBrowser: proper set scene rect

When resizesToContents is ON scene's rect is set to the boundary of
the mainFrame. However, navigating to other web page should keep resizing
scene's rect according to the new document loaded. Patch addresses this issue.

Now resizesToContents and scrolling properly work on QtTestBrowser.

QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::contentsSizeChanged): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent):
QtTestBrowser/webview.h:

8:59 PM Changeset in webkit [65049] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: Clean up LauncherWindow code.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init(). (LauncherWindow::init): Fixed comments. (LauncherWindow::applyPrefs): Move the method around. (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.

8:58 PM Changeset in webkit [65048] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.

It gets control+0 the same visual effect as control++ or control-.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::toggleZoomTextOnly):

8:57 PM Changeset in webkit [65047] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: make m_zoomLevels a static member.

Not all instances of LauncherWindow need its own m_zoomLevel.

QtTestBrowser/launcherwindow.cpp:
QtTestBrowser/launcherwindow.h:

8:43 PM Changeset in webkit [65046] by barraclough@apple.com

2 edits in trunk/WebCore

Qt build fix attempt VIII.

dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:34 PM Changeset in webkit [65045] by barraclough@apple.com

2 edits in trunk/WebCore

Qt build fix attempt VII.

dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:29 PM Changeset in webkit [65044] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Fix Qt/ARM

C++ overload resolution I stab at thee

jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

8:27 PM Changeset in webkit [65043] by barraclough@apple.com

2 edits in trunk/WebCore

Qt build fix attempt VI.

dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:19 PM Changeset in webkit [65042] by oliver@apple.com

19 edits
1 add in trunk/JavaScriptCore

2010-08-09 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow an assembler/macroassembler to compact branches to more concise forms when linking
https://bugs.webkit.org/show_bug.cgi?id=43745

This patch makes it possible for an assembler to convert jumps into a different
(presumably more efficient) form at link time. Currently implemented in the
ARMv7 JIT as that already had logic to delay linking of jumps until the end of
compilation already. The ARMv7 JIT chooses between either a 4 byte short jump
or a full 32-bit offset (and rewrites ITTT instructions as appropriate), so does
not yet produce the most compact form possible. The general design of the linker
should make it relatively simple to introduce new branch types with little effort,
as the linker has no knowledge of the exact form of any of the branches.

JavaScriptCore.xcodeproj/project.pbxproj:
assembler/ARMv7Assembler.cpp: Added. (JSC::): Record jump sizes

assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::LinkRecord::LinkRecord): (JSC::ARMv7Assembler::LinkRecord::from): (JSC::ARMv7Assembler::LinkRecord::setFrom): (JSC::ARMv7Assembler::LinkRecord::to): (JSC::ARMv7Assembler::LinkRecord::type): (JSC::ARMv7Assembler::LinkRecord::linkType): (JSC::ARMv7Assembler::LinkRecord::setLinkType): Encapsulate LinkRecord fields so we can compress the values somewhat

(JSC::ARMv7Assembler::JmpSrc::JmpSrc):

Need to record the jump type now

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):

Need to pass the jump types

(JSC::ARMv7Assembler::executableOffsetFor):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::linkRecordSourceComparator):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::convertJumpTo):
(JSC::ARMv7Assembler::recordLinkOffsets):
(JSC::ARMv7Assembler::jumpsToLink):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::unlinkedCode):

Helper functions for the linker

(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::canBeShortJump):
(JSC::ARMv7Assembler::linkLongJump):
(JSC::ARMv7Assembler::linkShortJump):
(JSC::ARMv7Assembler::linkJumpAbsolute):

Moving code around for the various jump linking functions

assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::beginUninterruptedSequence): (JSC::AbstractMacroAssembler::endUninterruptedSequence): We have to track uninterrupted sequences in any assembler that compacts branches as that's not something we're allowed to do in such sequences. AbstractMacroAssembler has a nop version of these functions as it makes the code elsewhere nicer.

assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::trampolineAt): Updated these functions to adjust for any changed offsets in the linked code

(JSC::LinkBuffer::applyOffset):

A helper function to deal with the now potentially moved labels

(JSC::LinkBuffer::linkCode):

The new and mighty linker function

assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::beginUninterruptedSequence): (JSC::MacroAssemblerARMv7::endUninterruptedSequence): (JSC::MacroAssemblerARMv7::jumpsToLink): (JSC::MacroAssemblerARMv7::unlinkedCode): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::convertJumpTo): (JSC::MacroAssemblerARMv7::recordLinkOffsets): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::link): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::breakpoint): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::executableOffsetFor): (JSC::MacroAssemblerARMv7::inUninterruptedSequence): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):

All branches need to pass on their type now

jit/ExecutableAllocator.h: (JSC::ExecutablePool::returnLastBytes):

We can't know ahead of time how much space will be necessary to
hold the linked code if we're compacting branches, this new
function allows us to return the unused bytes at the end of linking

jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
jit/JIT.h: (JSC::JIT::compile):

The JIT class now needs to take a linker offset so that recompilation
can generate the same jumps when using branch compaction.

jit/JITArithmetic32_64.cpp: (JSC::JIT::emitSlow_op_mod):
jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): Update for new trampolineAt changes

wtf/FastMalloc.cpp: (WTF::TCMallocStats::):
wtf/Platform.h:

8:18 PM Changeset in webkit [65041] by barraclough@apple.com

3 edits in trunk/WebCore

Qt build fix attempt V.

dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:10 PM Changeset in webkit [65040] by barraclough@apple.com

4 edits in trunk/WebCore

Qt build fix attempt IV.

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

7:58 PM Changeset in webkit [65039] by barraclough@apple.com

2 edits in trunk/WebCore

Speculative chromium build fix.

platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::charactersAreAllASCII):

7:41 PM Changeset in webkit [65038] by mrowe@apple.com

5 edits in branches/safari-533.18-branch

Versioning.

7:40 PM Changeset in webkit [65037] by mrowe@apple.com

1 copy in tags/Safari-533.18.1

New tag.

7:35 PM Changeset in webkit [65036] by mrowe@apple.com

5 edits in branches/safari-533.18-branch

Versioning.

7:24 PM Changeset in webkit [65035] by mrowe@apple.com

4 edits
2 adds in branches/safari-533.18-branch

Merge r63772.

7:13 PM Changeset in webkit [65034] by barraclough@apple.com

2 edits in trunk/WebKit/chromium

Speculative chromium build fix V.

tests/KURLTest.cpp:

(ComponentCase::TEST):

7:06 PM Changeset in webkit [65033] by barraclough@apple.com

2 edits in trunk/WebKit/chromium

Speculative chromium build fix IV.

src/WebPageSerializerImpl.h:

6:59 PM Changeset in webkit [65032] by barraclough@apple.com

4 edits in trunk

Qt build fix III.

JavaScriptCore:

wtf/text/WTFString.h:

WebCore:

css/CSSSelector.cpp:

6:47 PM Changeset in webkit [65031] by eric@webkit.org

4 edits in trunk/WebCore

2010-08-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove error-prone external SegementedSubstring contructor
https://bugs.webkit.org/show_bug.cgi?id=43752

There's a lot of code that assumes that SegmentedString takes ownership
of its substrings. For example, when the HTML parser pauses and
resumes asynchronously, it could explode if SegmentedString didn't own
its substrings.

Prior to this patch, there was a constructor that let
SegmentedSubstring use an external string buffer. It turns out it was
only used in a handful of places, but I'd rather pay the memcpy of
these small strings than risk having them used after free.

bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::parseComment):
platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString):

6:43 PM Changeset in webkit [65030] by barraclough@apple.com

2 edits in trunk/WebCore

Speculative Qt build fix.

css/CSSSelector.cpp:

6:43 PM Changeset in webkit [65029] by weinig@apple.com

13 edits in trunk

Add zoom support for injected bundle
https://bugs.webkit.org/show_bug.cgi?id=43759

Reviewed by Geoffrey Garen.

WebKit2:

Add SPI to change the zoom factor for a page.

WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(toZoomMode):

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetZoomFactor):
(WKBundlePageSetZoomFactor):
(WKBundlePageSetZoomMode):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::zoomFactor):
(WebKit::WebPage::setZoomFactor):
(WebKit::WebPage::setZoomMode):

WebProcess/WebPage/WebPage.h:

WebKitTools:

Use zoom factor SPI to implement zoom related eventSender functions.

WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.

LayoutTests:

platform/mac-wk2/Skipped: Remove now passing tests.

6:42 PM Changeset in webkit [65028] by barraclough@apple.com

4 edits in trunk/WebKitTools

Speculative chromium build fix III.

DumpRenderTree/chromium/MockSpellCheck.h:
DumpRenderTree/chromium/NotificationPresenter.h:
DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost::addClearHeader):
(WebViewHost::clearHeaders):

6:37 PM Changeset in webkit [65027] by barraclough@apple.com

2 edits in trunk/WebKit/chromium

Speculative chromium build fix II.

src/AssertMatchingEnums.cpp:

6:32 PM Changeset in webkit [65026] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-08-09 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

increase the number of test results that we save
https://bugs.webkit.org/show_bug.cgi?id=43763

Now that we do incremental uploads, we can increase the number of
results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

6:28 PM Changeset in webkit [65025] by barraclough@apple.com

2 edits in trunk/WebCore

Speculative gtk build fix.

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handlePostReadFile):

6:24 PM Changeset in webkit [65024] by mrowe@apple.com

1 edit in branches/safari-533.18-branch/WebCore/rendering/RenderLayerBacking.cpp

Build fix. Remove a static function that is no longer called.

6:22 PM Changeset in webkit [65023] by barraclough@apple.com

2 edits in trunk/WebKit/chromium

Speculative chromium build fix.

public/WebCString.h:

5:55 PM Changeset in webkit [65022] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Qt build fix.

wtf/qt/StringQt.cpp:

5:38 PM Changeset in webkit [65021] by barraclough@apple.com

504 edits in trunk

Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

Rubber stamped by Sam Weinig

JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:
wtf/Forward.h:

WebCore:

WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.h:
accessibility/AccessibilityARIAGrid.h:
accessibility/AccessibilityListBoxOption.h:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilityTable.h:
bindings/cpp/WebDOMCString.h:
bindings/cpp/WebDOMString.h:
bindings/gobject/ConvertToUTF8String.h:
bindings/js/DOMWrapperWorld.h:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.h:
bindings/js/JSMessagePortCustom.h:
bindings/js/JavaScriptCallFrame.h:
bindings/js/ScriptController.h:
bindings/js/ScriptProfile.h:
bindings/js/ScriptSourceProvider.h:
bindings/js/ScriptString.h:
bindings/js/WorkerScriptController.h:
bindings/objc/DOMImplementationFront.h:
bindings/v8/ScheduledAction.h:
bindings/v8/ScriptController.h:
bindings/v8/V8DOMWindowShell.h:
bindings/v8/V8Proxy.h:
bindings/v8/V8Utilities.h:
bindings/v8/custom/V8CustomXPathNSResolver.h:
bridge/c/c_utility.h:
css/CSSFontSelector.h:
css/CSSHelper.h:
css/CSSOMUtils.h:
css/CSSPrimitiveValue.h:
css/MediaList.h:
css/StyleBase.h:
css/StyleSheetList.h:
css/WebKitCSSKeyframesRule.h:
dom/CheckedRadioButtons.h:
dom/DOMImplementation.h:
dom/DocumentMarker.h:
dom/DynamicNodeList.h:
dom/EventTarget.h:
dom/MessagePort.h:
dom/MessagePortChannel.h:
dom/NameNodeList.h:
dom/Node.h:
dom/NodeList.h:
dom/OptionGroupElement.h:
dom/ScriptExecutionContext.h:
dom/SelectElement.h:
dom/ViewportArguments.h:
dom/make_names.pl:
editing/HTMLInterchange.h:
editing/htmlediting.h:
editing/markup.h:
html/CollectionCache.h:
html/DOMFormData.h:
html/DataGridColumnList.h:
html/DateComponents.h:
html/FileStream.h:
html/FileStreamProxy.h:
html/FormDataList.h:

(WebCore::FormDataList::appendData):

html/HTMLCollection.h:
html/HTMLElementStack.h:
html/HTMLFormattingElementList.h:
html/HTMLParserQuirks.h:
html/HTMLQuoteElement.h:
html/HTMLScriptRunnerHost.h:
html/StepRange.h:
html/canvas/CanvasGradient.h:
html/canvas/CanvasNumberArray.h:
html/canvas/CanvasPattern.h:
inspector/InjectedScript.h:
inspector/InspectorCSSStore.h:
inspector/InspectorClient.h:
inspector/InspectorFrontendClient.h:
inspector/InspectorValues.h:
inspector/ScriptDebugListener.h:
loader/CachedResourceClient.h:
loader/CrossOriginAccessControl.h:
loader/DocumentThreadableLoader.h:
loader/FrameLoaderClient.h:
loader/RedirectScheduler.h:
loader/SubframeLoader.h:
loader/appcache/DOMApplicationCache.h:
loader/archive/ArchiveFactory.h:
loader/icon/IconDatabaseClient.h:
notifications/NotificationPresenter.h:
page/Chrome.h:
page/ChromeClient.h:
page/Console.h:
page/ContextMenuClient.h:
page/DOMSelection.h:
page/EditorClient.h:
page/EventHandler.h:
page/FrameView.h:
page/GeolocationPositionCache.h:
page/History.h:
page/Location.h:
page/Navigator.h:
page/NavigatorBase.h:
page/PluginHalterClient.h:
page/PrintContext.h:
page/SpeechInput.h:
page/SpeechInputListener.h:
page/animation/AnimationController.h:
platform/CookieJar.h:
platform/CrossThreadCopier.h:
platform/DragImage.h:
platform/FileSystem.h:
platform/Language.h:
platform/Length.h:
platform/LinkHash.h:
platform/LocalizationStrategy.h:
platform/LocalizedStrings.h:
platform/Logging.h:
platform/Pasteboard.h:
platform/PopupMenuClient.h:
platform/SearchPopupMenu.h:
platform/Widget.h:
platform/cf/BinaryPropertyList.h:
platform/chromium/ChromiumBridge.h:
platform/chromium/ClipboardUtilitiesChromium.h:
platform/cocoa/KeyEventCocoa.h:
platform/graphics/Color.h:
platform/graphics/FontCache.h:
platform/graphics/FontData.h:
platform/graphics/FontSelector.h:
platform/graphics/GraphicsTypes.h:
platform/graphics/Icon.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageSource.h:
platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:
platform/graphics/Path.h:
platform/graphics/StringTruncator.h:
platform/graphics/cairo/FontCustomPlatformData.h:
platform/graphics/cairo/FontPlatformData.h:
platform/graphics/cg/FontPlatformData.h:
platform/graphics/cg/ImageSourceCG.h:
platform/graphics/chromium/FontCustomPlatformData.h:
platform/graphics/chromium/FontPlatformDataChromiumWin.h:
platform/graphics/chromium/FontPlatformDataLinux.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/haiku/FontCustomPlatformData.h:
platform/graphics/mac/FontCustomPlatformData.h:
platform/graphics/mac/FontPlatformData.h:
platform/graphics/qt/FontCustomPlatformData.h:
platform/graphics/qt/FontPlatformData.h:
platform/graphics/win/FontCustomPlatformData.h:
platform/graphics/win/FontCustomPlatformDataCairo.h:
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/wince/FontPlatformData.h:
platform/graphics/wince/MediaPlayerPrivateWince.h:
platform/graphics/wince/MediaPlayerProxy.h:
platform/graphics/wx/FontCustomPlatformData.h:
platform/graphics/wx/FontPlatformData.h:
platform/mac/PasteboardHelper.h:
platform/network/DNS.h:
platform/network/FormData.h:
platform/network/FormDataBuilder.h:
platform/network/HTTPParsers.h:
platform/text/Hyphenation.h:
platform/text/LineEnding.h:
platform/text/TextCodec.h:
platform/text/TextEncoding.h:
platform/text/TextStream.h:
platform/win/BString.h:
platform/win/ClipboardUtilitiesWin.h:
platform/win/WCDataObject.h:
platform/win/WebCoreTextRenderer.h:
plugins/DOMMimeType.h:
plugins/DOMMimeTypeArray.h:
plugins/DOMPlugin.h:
plugins/DOMPluginArray.h:
rendering/CounterNode.h:
rendering/HitTestResult.h:
rendering/RenderObjectChildList.h:
rendering/RenderText.h:
rendering/RenderTreeAsText.h:
rendering/TextControlInnerElements.h:
rendering/style/ContentData.h:
rendering/style/RenderStyle.h:
storage/DatabaseAuthorizer.h:
storage/DatabaseTrackerClient.h:
storage/SQLTransaction.h:
storage/SQLTransactionSync.h:
storage/Storage.h:
storage/chromium/DatabaseObserver.h:
svg/SVGAnimatedTemplate.h:
svg/SVGDocumentExtensions.h:
svg/SVGGlyphElement.h:
svg/SVGHKernElement.h:
svg/SVGNumberList.h:
svg/SVGPointList.h:
svg/SVGPreserveAspectRatio.h:
svg/SVGStylable.h:
svg/SVGTests.h:
svg/SVGTransformList.h:
svg/SVGTransformable.h:
svg/SVGVKernElement.h:
websockets/ThreadableWebSocketChannel.h:
websockets/ThreadableWebSocketChannelClientWrapper.h:
websockets/WebSocket.h:
websockets/WebSocketChannel.h:
websockets/WebSocketHandshakeResponse.h:
wml/WMLErrorHandling.h:
wml/WMLPageState.h:
wml/WMLVariables.h:
workers/DefaultSharedWorkerRepository.h:
workers/SharedWorkerRepository.h:
workers/Worker.h:
workers/WorkerContextProxy.h:
workers/WorkerLoaderProxy.h:
workers/WorkerLocation.h:
workers/WorkerMessagingProxy.h:
workers/WorkerReportingProxy.h:
workers/WorkerThread.h:
xml/DOMParser.h:
xml/XMLHttpRequestUpload.h:
xml/XPathEvaluator.h:
xml/XPathExpression.h:
xml/XPathNSResolver.h:
xml/XPathResult.h:
xml/XPathUtil.h:

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/chromium:

public/WebCString.h:
public/WebString.h:
src/DOMUtilitiesPrivate.h:
src/DebuggerAgentImpl.h:
src/DebuggerAgentManager.h:
src/WebDevToolsAgentImpl.h:
src/WebDevToolsFrontendImpl.h:
src/WebPageSerializerImpl.h:

WebKit/efl:

WebCoreSupport/InspectorClientEfl.h:

WebKit/gtk:

WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku:

WebCoreSupport/FrameLoaderClientHaiku.h:
WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/WebBaseNetscapePluginView.h:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebIconDatabaseClient.h:
WebCoreSupport/WebPluginHalterClient.h:
WebView/WebViewInternal.h:

WebKit/qt:

WebCoreSupport/FrameLoaderClientQt.h:
WebCoreSupport/InspectorClientQt.h:

WebKit/win:

COMVariantSetter.h:
MarshallingHelpers.h:
WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebPluginHalterClient.h:
WebHistory.h:

WebKit/wx:

WebKitSupport/FrameLoaderClientWx.h:
WebKitSupport/InspectorClientWx.h:

WebKit2:

UIProcess/PageClient.h:
UIProcess/VisitedLinkProvider.h:
UIProcess/WebContextInjectedBundleClient.h:
UIProcess/WebFrameProxy.h:
UIProcess/WebHistoryClient.h:
UIProcess/WebLoaderClient.h:
UIProcess/WebPolicyClient.h:
UIProcess/WebProcessProxy.h:
UIProcess/WebUIClient.h:
UIProcess/win/WebView.h:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/Plugins/NPRuntimeObjectMap.h:
WebProcess/Plugins/Netscape/NetscapePluginStream.h:
WebProcess/Plugins/PluginController.h:
WebProcess/WebPage/WebFrame.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebProcess.h:

5:25 PM Changeset in webkit [65020] by eric@webkit.org

2 edits in trunk/WebCore

2010-08-09 Nat Duca <nduca@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Blue line visible at the right hand side of the window with accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=43748

Correct the ortho projection matrix for the root layer, which was
too large by 0.5px in both width and height. For even view sizes,
this would cause the viewport to appear 1 pixel too small.

Fixing this requires removal of several 0.5 correction factors
that were previously added to compensate for the too-large viewport.

Finally, compute the translation for the root layer quad using
floating point rather than integer arithmetic. This avoids us losing
a key half-pixel of translation when the width of the window is odd.

To test, size window to even/odd dimensions. No blue line should be visible.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):

5:24 PM Changeset in webkit [65019] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-08-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
https://bugs.webkit.org/show_bug.cgi?id=43465

Removed fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle
because StyleChange's applyFontColor, applyFontFace, and applyFontSize all return false
if there was no difference between the new font color, font size, font face and that of the computed style.

Also added a work-around for the bug 28282 in getPropertiesNotInComputedStyle with a test so that
the above change will not add a redundant font or span element.

Test: editing/style/fore-color-by-name.html

editing/ApplyStyleCommand.cpp: (WebCore::getRGBAFontColor): Added. (WebCore::StyleChange::extractTextStyles): Calls getRGBAFontColor. (WebCore::getPropertiesNotInComputedStyle): Removes color property manually by checking the RGBA values. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): See above.

2010-08-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
https://bugs.webkit.org/show_bug.cgi?id=43465

Added a test for applying execCommand('foreColor') by color name. Because of the bug 28282, we have to manually
process color property in getPropertiesNotInComputedStyle to avoid adding a redundant font or span element.

editing/style/fore-color-by-name-expected.txt: Added.
editing/style/fore-color-by-name.html: Added.

5:06 PM Changeset in webkit [65018] by kbr@google.com

3 edits in trunk/WebCore

2010-08-09 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Fix compilation of VideoLayerChromium on Mac OS X with compositor
https://bugs.webkit.org/show_bug.cgi?id=43757

No new tests; build fix only (associated functionality not implemented yet).

platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
platform/graphics/chromium/VideoLayerChromium.h:

5:00 PM Changeset in webkit [65017] by ariya@webkit.org

3 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need to implement GraphicsContextQt::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41310

Based on the prototype code by Simon Hausmann.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
rendering/RenderObject.h:

4:45 PM Changeset in webkit [65016] by Chris Fleizach

8 edits in trunk

AX: Placeholder value for text fields not exposed like it should be
https://bugs.webkit.org/show_bug.cgi?id=43598

Reviewed by David Kilzer.

WebCore:

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::placeholderValue):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

accessibility/placeholder-expected.txt:
accessibility/placeholder.html:

4:29 PM Changeset in webkit [65015] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-08-09 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] DRT error print statement incorrectly tries to print a FILE*
https://bugs.webkit.org/show_bug.cgi?id=43747

DumpRenderTree/chromium/ImageDiff.cpp: (writeFile): pass the correct pointer.

4:25 PM Changeset in webkit [65014] by rniwa@webkit.org

8 edits
2 adds in trunk

2010-08-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=43639

The bug was caused when RemoveCSSPropertyCommand is called with CSSMutableStyleDeclaration of some styled element,
and the style attribute of the element is removed subsequently. When the attribute removal is undone, new instance of
CSSMutableStyleDeclaration is created and RemoveCSSPropertyCommand's m_style became detached from the element.

Modified RemoveCSSPropertyCommand to store the styled element directly instead of its CSSMutableStyleDeclaration.

Test: editing/undo/remove-css-property-and-remove-style.html

WebCore.order:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): Calls removeCSSProperty. (WebCore::ApplyStyleCommand::extractTextDecorationStyle): Calls removeCSSProperty.
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeCSSProperty): Takes StyledElement instead of CSSMutableStyleDeclaration.
editing/CompositeEditCommand.h:
editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Takes StyledElement instead of CSSMutableStyleDeclaration. (WebCore::RemoveCSSPropertyCommand::doApply): See above. (WebCore::RemoveCSSPropertyCommand::doUnapply): See above.
editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create): See above.

2010-08-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=43639

Added a test to remove style attribute after removing a CSS property from the style.
Undo should restore both style attribute and the removed CSS property.

editing/undo/remove-css-property-and-remove-style-expected.txt: Added.
editing/undo/remove-css-property-and-remove-style.html: Added.

4:18 PM Changeset in webkit [65013] by rniwa@webkit.org

3 edits in trunk/WebCore

2010-08-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Use getIdentifierValue to obtain direction and unicode-bidi properties in ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=43699

Deployed getIdentifierValue in various parts of ApplyStyleCommand where
direction and unicode-bidi properties were obtained manually.

No new tests since this is a cleanup.

editing/ApplyStyleCommand.cpp: (WebCore::getIdentifierValue): Takes CSSStyleDeclaration instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls getIdentifierValue.
editing/ApplyStyleCommand.h:

4:06 PM Changeset in webkit [65012] by eric@webkit.org

2 edits in trunk/WebCore

2010-08-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove trailing whitespace in HTMLViewSourceDocument.cpp
https://bugs.webkit.org/show_bug.cgi?id=43741

No behavior change. The whitespace was distracting me while porting
this class to the new parser.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):

3:11 PM Changeset in webkit [65011] by victorw@chromium.org

2 edits in trunk/WebKitTools

2010-08-09 Victor Wang <victorw@chromium.org>

Reviewed by Ojan Vafai.

Upload incremental test results json to server by default.

https://bugs.webkit.org/show_bug.cgi?id=43743

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:06 PM Changeset in webkit [65010] by mrowe@apple.com

4 edits
3 adds in branches/safari-533.18-branch

Merge r64706.

2:59 PM Changeset in webkit [65009] by mrowe@apple.com

7 edits in branches/safari-533.18-branch

Merge r64110.

2:59 PM Changeset in webkit [65008] by mrowe@apple.com

4 edits in branches/safari-533.18-branch/WebKit/mac

Merge r62872.

2:59 PM Changeset in webkit [65007] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.18-branch

Merge r64095.

2:52 PM Changeset in webkit [65006] by eric@webkit.org

18 edits in trunk

2010-08-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
https://bugs.webkit.org/show_bug.cgi?id=43586

html5lib/runner-expected.txt:
- We pass 2 more tests now that the tokenizer is set to the right state before fragment parsing.
html5lib/runner-expected-html5.txt:
- We pass 4 more tests now that HTML5 fragment parsing is (partially) implemented behind the --html5-treebuilder flag.

2010-08-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
https://bugs.webkit.org/show_bug.cgi?id=43586

The bulk of this change is just a transcription of the HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#fragment-case

DocumentParser() now sets the right tokenizer state before handling
fragments. Since default code path uses the HTML5 tokenizer with the
legacy tree builder, this fixes 2 tokenizer-state tests for the html5lib.
This fixes 2 more tree-builder tests when the html5 treebuilder is enabled too.

dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
- HTML5 implementation of fragment parsing requires the context element (parent) pointer. The legacy implementation handles all parsing branches which require the context element outside of the parser itself, which likely produces "wrong" results. We'll remove those branches when we turn on the HMTL5 fragment parser.

(WebCore::DocumentFragment::parseXML):

Rename "parent" to "contextElement" to match the HTML path (and the HTML5 spec).

dom/DocumentFragment.h:
dom/Element.cpp: (WebCore::Element::createContextualFragment):
- Pass the contextElement (this).
html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::setForm):
- Needed by for the fragment case.

(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

I'm not sure this method should exist, it only has one caller. but for now, I've moved the fragment case FIXME out to the one caller and implemented it.

html/HTMLConstructionSite.h:
html/HTMLDocumentParser.cpp: (WebCore::HTMLNames::tokenizerStateForContextElement):
- Part of the fragment case handling for the HTML5 parser.

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

Set the Tokenizer state based on the contextElement.

(WebCore::HTMLDocumentParser::parseDocumentFragment):

Take a contextElement argument.

html/HTMLDocumentParser.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML):
- Added a FIXME before the branches the old parser used to avoid ever needing to pass a context element when parsing HTML fragments.

(WebCore::HTMLElement::insertAdjacentHTML):

Pass the context element.

html/HTMLTokenizer.h:
html/HTMLTreeBuilder.cpp:
- I added a new helper class FragmentParsingContext to simplify the two HTMLTreeBuilder constructors and hide the existence of m_dummyDocumentForFragmentParse.
- I also removed m_isParsingFragment and replaced it with an isParsingFragment() function.

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::~FragmentParsingContext):
(WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):

I had to implement two notImplemented() states in order to get most of the layout tests to pass when using the HTML5 parser fragment case.

(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):

The HTML5 parsing algorithm fragment case uses a dummy document to handle all the parsing and then moves all the children from the dummy document over into a DocumentFragment when the parse is done. We could avoid this adopt step by making the TreeBuilder a bit more complicated, but I'm not sure that's necessary (yet).

html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::isParsingFragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): (WebCore::HTMLTreeBuilder::FragmentParsingContext::scriptingPermission):
xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):

2:36 PM Changeset in webkit [65005] by dumi@chromium.org

34 edits
4 deletes in trunk

WebCore: Auto-generate most HTML5 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp

and the custom implementations of openDatabase{Sync}().

Android.v8bindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDatabaseCustom.cpp: Removed.
bindings/js/JSDatabaseSyncCustom.cpp: Removed.
bindings/js/JSWorkerContextCustom.cpp:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
bindings/v8/custom/V8WorkerContextCustom.cpp:

bindings/scripts/CodeGeneratorGObject.pm: Change the code generators

to check that each value can be converted to the respective
argument type.

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):

bindings/v8/custom/V8BindingMacros.h:

bindings/v8/V8Binding.h: Minor changes required to support the

auto-generated bindings.
(WebCore::V8Parameter::V8Parameter):

bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

page/DOMWindow.idl:
storage/Database.cpp:

(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):

storage/Database.h:
storage/Database.idl:
storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):

storage/DatabaseSync.h:
storage/DatabaseSync.idl:
workers/WorkerContext.idl:

LayoutTests: Changing the expected error message for a test.
https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

fast/workers/storage/open-database-inputs-sync-expected.txt:

2:32 PM Changeset in webkit [65004] by eric@webkit.org

2 edits in trunk/WebCore

2010-08-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=43740

This removes the DTD checks, which aren't needed for view source
documents.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):

2:29 PM Changeset in webkit [65003] by mitz@apple.com

2 edits in trunk/WebCore

Fixed an uninitialized member variable in the Color(CGColorRef) constructor.

Reviewed by Simon Fraser.

platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::Color): Initialize m_valid to true if the color is not 0.

2:12 PM Changeset in webkit [65002] by jamesr@google.com

2 edits in trunk/WebCore

2010-08-09 James Robinson <jamesr@chromium.org>

Chromium compile fix, unreviewed.

platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):

1:54 PM Changeset in webkit [65001] by jamesr@google.com

4 edits in trunk/WebCore

2010-08-09 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):

1:44 PM Changeset in webkit [65000] by mrowe@apple.com

5 edits in branches/safari-533.18-branch

Versioning.

1:41 PM Changeset in webkit [64999] by mrowe@apple.com

1 copy in branches/safari-533.18-branch

New branch.

1:36 PM Changeset in webkit [64998] by zmo@google.com

8 edits in trunk

2010-08-09 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
https://bugs.webkit.org/show_bug.cgi?id=43693

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): Don't generate GL errors. Generate them in the callers instead. (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate GL error if sizeInBytes fails.
html/canvas/WebGLRenderingContext.h: Make sizeInBytes private helper.
html/canvas/WebGLRenderingContext.idl: Remove sizeInBytes.

2010-08-09 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
https://bugs.webkit.org/show_bug.cgi?id=43693

fast/canvas/webgl/gl-object-get-calls-expected.txt: Define sizeInBytes and don't use the WebGL one (it's been removed).
fast/canvas/webgl/gl-object-get-calls.html: Ditto.
fast/canvas/webgl/index-validation.html: Ditto.

1:29 PM Changeset in webkit [64997] by eric.carlson@apple.com

10 edits in trunk

2010-08-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): RenderVideo::videoSizeChanged is gone, just use updateFromElement instead. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Clear the image loader and cached image when the 'poster' attribute is changed and we aren't displaying a poster.

rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::intrinsicSizeChanged): videoSizeChanged -> updateIntrinsicSize. (WebCore::RenderVideo::updateIntrinsicSize): Renamed from videoSizeChanged, calculate initial intrinsic size with calculateIntrinsicSize (WebCore::RenderVideo::calculateIntrinsicSize): New, calculate size according to current spec. (WebCore::RenderVideo::imageChanged): Reset intrinsic size to default when poster fails to load. (WebCore::RenderVideo::updatePlayer): Call updateIntrinsicSize.
rendering/RenderVideo.h: Renamed videoSizeChanged to updateIntrinsicSize and make private.

2010-08-09 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

media/video-poster-expected.txt:
media/video-poster.html:
media/video-size-expected.txt:
media/video-size.html:

11:44 AM Changeset in webkit [64996] by eric@webkit.org

4 edits in trunk/WebCore

2010-08-09 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Fixes custom JS bindings for IDBCursor after r64828.
https://bugs.webkit.org/show_bug.cgi?id=43729

Build fix, no tests.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
storage/IDBObjectStore.h:

11:33 AM Changeset in webkit [64995] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-08-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS bots wait 2 minutes between patches
https://bugs.webkit.org/show_bug.cgi?id=43731

Scripts/webkitpy/tool/bot/queueengine.py:
- Don't sleep after failures. This was a hold-over from an earlier design.
Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- EWS bots were not properly reporting true/false from process_work_item. They were always returning None, thus false, thus always logging as a failure and sleeping 2 minutes after each patch.

11:22 AM Changeset in webkit [64994] by eric@webkit.org

4 edits in trunk/WebCore

2010-08-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r64993.
http://trac.webkit.org/changeset/64993
https://bugs.webkit.org/show_bug.cgi?id=43734

broke chromium compile (Requested by jamesr on #webkit).

platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
platform/graphics/chromium/CanvasLayerChromium.h:
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):

11:05 AM Changeset in webkit [64993] by jamesr@google.com

4 edits in trunk/WebCore

2010-08-09 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):

11:01 AM Changeset in webkit [64992] by eric@webkit.org

3 edits in trunk/WebKit2

2010-08-09 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] No need for PageClientImpl

https://bugs.webkit.org/show_bug.cgi?id=43728

Remove PageClientImpl, take the implementation of WebKit::PageClient into QWKPagePrivate.

UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::toolTipChanged):
UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::pageDidEnterAcceleratedCompositing): (QWKPagePrivate::pageDidLeaveAcceleratedCompositing): (QWKPagePrivate::processDidExit): (QWKPagePrivate::processDidRevive): (QWKPagePrivate::setCursor): (QWKPagePrivate::takeFocus):

10:50 AM Changeset in webkit [64991] by eric@webkit.org

9 edits in trunk/WebCore

2010-08-09 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Moves window.open logic into the generic bindings.

This patch moves window.open logic from V8 into the generic
bindings so it could be shared with JSC. JSC sharing is not in
this patch. This patch is of the same flavor/intent as 33201.

https://bugs.webkit.org/show_bug.cgi?id=41392

bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open): (WebCore::::completeURL):
bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp): (WebCore::::shouldAllowNavigation):
bindings/v8/V8Binding.h: (WebCore::V8Binding::emptyScriptValue):
bindings/v8/V8Utilities.cpp: (WebCore::transferHiddenDependency): (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL):
bindings/v8/custom/V8ArrayBufferCustom.cpp:
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
bindings/v8/specialization/V8BindingState.cpp: (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture):
bindings/v8/specialization/V8BindingState.h: (WebCore::):

10:39 AM Changeset in webkit [64990] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-08-09 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Skip the slow software rendering path of GraphicsContext3D if accelerated
compositing is active. This fixes an issue with WebGL and the compositor
in which the software rendering of WebGL would cause the current GL context
to change while the compositor was processing layers. Tested by running
several WebGL samples both with the compositor enabled and disabled.
https://bugs.webkit.org/show_bug.cgi?id=43644

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::beginPaint):

10:36 AM Changeset in webkit [64989] by jianli@chromium.org

2 edits
2 adds in trunk/LayoutTests

Update chromium test results.

platform/chromium-mac/editing/selection/5076323-1-expected.checksum: Added.
platform/chromium-mac/editing/selection/5076323-1-expected.png: Added.
platform/chromium/test_expectations.txt:

10:05 AM Changeset in webkit [64988] by jhawkins@chromium.org

3 edits in trunk/WebKit/chromium

2010-08-06 James Hawkins <jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=43648

public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):

9:39 AM Changeset in webkit [64987] by eric@webkit.org

2 edits in trunk/WebCore

2010-08-09 Marcus Bulach <bulach@chromium.org>

Reviewed by Darin Adler.

Fixes xcode project issues after r64828:
https://bugs.webkit.org/show_bug.cgi?id=43638

Build fix, no tests (sort-Xcode-project-file should not throw any warnings).

WebCore.xcodeproj/project.pbxproj: fixed IDBCursor and related IndexedDB files, and re-ran sort-Xcode-project-file.

9:11 AM Changeset in webkit [64986] by loislo@chromium.org

12 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove callId argument from all backend agents' methods.
https://bugs.webkit.org/show_bug.cgi?id=43723

inspector/CodeGeneratorInspector.pm:
inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::getDatabaseTableNames):
inspector/InspectorBackend.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::getResourceContent):
inspector/InspectorController.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
inspector/InspectorDOMAgent.h:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource):
inspector/InspectorDebuggerAgent.h:

8:55 AM Changeset in webkit [64985] by weinig@apple.com

11 edits
3 adds in trunk

Stub out EventSender for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43703

WebKitTools:

Reviewed by Anders Carlsson.

WebKitTestRunner/DerivedSources.make:
WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Add ability to pass javascript arguments to the wrapped object.

WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.

(WTR::EventSendingController::create):
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::~EventSendingController):
(WTR::EventSendingController::wrapperClass):
(WTR::setExceptionForString):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::contextClick):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
(WTR::EventSendingController::makeWindowObject):

WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::reset):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::eventSendingController):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):
Add stubbed out EventSenderController.

WebKitTestRunner/InjectedBundle/GCController.h:

Remove incorrect comment.

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/win/InjectedBundle.vcproj:

Add new files.

LayoutTests:

Reviewed by Anders Carlsson

platform/mac-wk2/Skipped: Update.

8:52 AM Changeset in webkit [64984] by eric@webkit.org

7 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for mroot color handling.
https://bugs.webkit.org/show_bug.cgi?id=43628

mathml/presentation/roots.xhtml:
platform/mac/mathml/presentation/roots-expected.checksum:
platform/mac/mathml/presentation/roots-expected.png:
platform/mac/mathml/presentation/roots-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Take into account style color to draw MathML mroot radical.
https://bugs.webkit.org/show_bug.cgi?id=43628

Test: mathml/presentation/roots.xhtml

mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):

8:50 AM Changeset in webkit [64983] by Martin Robinson

2 edits in trunk/WebKit/gtk

2010-08-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus
https://bugs.webkit.org/show_bug.cgi?id=43602

Only call gtk_im_context_focus_in() when we focus a frame which is currently in
an editable node.

webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in().

8:40 AM Changeset in webkit [64982] by eric@webkit.org

8 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add test for some deprecated MathML style attributes
https://bugs.webkit.org/show_bug.cgi?id=43503

mathml/presentation/attributes.xhtml:
platform/mac/mathml/presentation/attributes-expected.checksum:
platform/mac/mathml/presentation/attributes-expected.png:
platform/mac/mathml/presentation/attributes-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement MathML deprecated style attributes
https://bugs.webkit.org/show_bug.cgi?id=43503

Test: mathml/presentation/attributes.xhtml

mathml/MathMLElement.cpp: (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
mathml/mathattrs.in:

7:59 AM Changeset in webkit [64981] by loislo@chromium.org

2 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove unnecessary did* methods from RemoteInspectorFrontend.
https://bugs.webkit.org/show_bug.cgi?id=43721

inspector/CodeGeneratorInspector.pm:

6:56 AM Changeset in webkit [64980] by andreas.kling@nokia.com

4 edits in trunk/WebCore

2010-08-09 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

Canvas: Fast-path for setting the already set color with setStrokeColor() and setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=43718

Avoid creating CanvasStyle objects when setting the same fill or stroke color using
the WebKit-specific setters of CanvasRenderingContext2D.

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor):
html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
html/canvas/CanvasStyle.h: Added CanvasStyle::isEquivalentColor() overloads for RGBA and CMYKA channel values.

6:34 AM Changeset in webkit [64979] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

platform/chromium/test_expectations.txt:

6:00 AM Changeset in webkit [64978] by pfeldman@chromium.org

4 edits in trunk

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore original last panel restore logic.

https://bugs.webkit.org/show_bug.cgi?id=43719

inspector/front-end/inspector.js: (WebInspector.showPanel):

5:23 AM Changeset in webkit [64977] by pfeldman@chromium.org

5 edits in trunk

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

src/js/Tests.js: (.TestSuite.prototype.testShowStoragePanel.this): (.TestSuite.prototype.testShowStoragePanel):

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

http/tests/inspector/inspector-test.js: (frontend_setupTestEnvironment):
inspector/elements-panel-limited-children.html:

4:57 AM Changeset in webkit [64976] by dumi@chromium.org

5 edits in trunk/WebCore

Unreviewed, fixing the builds after r64967.

CMakeLists.txt:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:

4:48 AM Changeset in webkit [64975] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium tests fix.

Disable runtime switch for device motion in chromium.
https://bugs.webkit.org/show_bug.cgi?id=43717

src/WebViewImpl.cpp: (WebKit::WebView::create):

4:40 AM Changeset in webkit [64974] by morrita@google.com

7 edits
3 adds in trunk

2010-05-20 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

<http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.
<http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.

editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt: Added.
editing/selection/doubleclick-inline-first-last-contenteditable.html: Added.
editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js: Added.

2010-05-27 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

<http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.
<http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.

nextBoundary() and previousBoundary() assumed that editable
boundaries are on block-level elements, But it can appear on
inline-level elements. So we start boundary look-up from the given
node, instead of the containingBlock of the given node.
Also, added TextIteratorEndsAtEditingBoundary to
BackwardsCharacterIterator, otherwise, the VisiblePosition
returned by BackwardsCharacterIterator might cross an editing
boundary.

Test: editing/selection/doubleclick-inline-first-last-contenteditable.html

dom/Position.cpp: (WebCore::Position::parentEditingBoundary): Added.
dom/Position.h:
editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::crossesEditingBoundary): Added. (WebCore::SimplifiedBackwardsTextIterator::setCurrentNode): Added. (WebCore::SimplifiedBackwardsTextIterator::clearCurrentNode): Added. (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
editing/TextIterator.h: (WebCore::):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):

4:26 AM Changeset in webkit [64973] by loislo@chromium.org

19 edits in trunk

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
https://bugs.webkit.org/show_bug.cgi?id=43711

WebCore.exp.in:
inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp:
inspector/InspectorFrontend.h:
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.toggleSearchingForNode): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.showProfileForURL):

2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
https://bugs.webkit.org/show_bug.cgi?id=43711

inspector/debugger-breakpoints-not-activated-on-reload.html:
inspector/debugger-cyclic-ref.html:
inspector/debugger-eval-while-paused.html:
inspector/debugger-no-nested-pause.html:
inspector/debugger-pause-in-eval-script.html:
inspector/debugger-pause-on-debugger-statement.html:
inspector/debugger-proto-property.html:
inspector/elements-panel-limited-children.html:

3:50 AM MathML 3 testsuite results edited by François Sausset

(diff)

3:24 AM MathML 3 testsuite results edited by François Sausset

(diff)

3:17 AM MathML 3 testsuite results edited by François Sausset

(diff)

2:48 AM Changeset in webkit [64972] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: Remove temporary device motion fix.

https://bugs.webkit.org/show_bug.cgi?id=43713

src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation):

2:36 AM Changeset in webkit [64971] by ariya@webkit.org

2 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::clipOut(IntRect) ignores the transformation matrix.
https://bugs.webkit.org/show_bug.cgi?id=43705

Just like clipOut(Path), which is taken care in r60796 already,
clipOut(IntRect) must transform the window bounding box properly.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut):

2:18 AM Changeset in webkit [64970] by hamaji@chromium.org

2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>

Update chromium's expectation.

platform/chromium/test_expectations.txt: Drop SLOW as SLOW and TIMEOUT isn't allowed.

2:14 AM Changeset in webkit [64969] by hamaji@chromium.org

2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>

Update chromium's expectation.

platform/chromium/test_expectations.txt: Mark http/tests/misc/bad-charset-alias as a slow test.

1:49 AM Changeset in webkit [64968] by hamaji@chromium.org

2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>

Update chromium's expectation.

platform/chromium/test_expectations.txt: Mark fast/parser/residual-style-hang as a slow test.

1:33 AM QtWebKitMediaElementSupport edited by Henry Haverinen

(diff)

12:53 AM Changeset in webkit [64967] by eric@webkit.org

20 edits
6 adds in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for the mfenced MathML element and update tests with stretched parenthesis/brackets/operators
https://bugs.webkit.org/show_bug.cgi?id=42472

mathml/presentation/fenced.xhtml: Added.
mathml/presentation/row.xhtml:
platform/mac/mathml/presentation/fenced-expected.checksum: Added.
platform/mac/mathml/presentation/fenced-expected.png: Added.
platform/mac/mathml/presentation/fenced-expected.txt: Added.
platform/mac/mathml/presentation/mo-expected.checksum:
platform/mac/mathml/presentation/mo-expected.png:
platform/mac/mathml/presentation/mo-expected.txt:
platform/mac/mathml/presentation/over-expected.checksum:
platform/mac/mathml/presentation/over-expected.png:
platform/mac/mathml/presentation/over-expected.txt:
platform/mac/mathml/presentation/row-alignment-expected.checksum:
platform/mac/mathml/presentation/row-alignment-expected.png:
platform/mac/mathml/presentation/row-alignment-expected.txt:
platform/mac/mathml/presentation/row-expected.checksum:
platform/mac/mathml/presentation/row-expected.png:
platform/mac/mathml/presentation/row-expected.txt:
platform/mac/mathml/presentation/tables-expected.checksum:
platform/mac/mathml/presentation/tables-expected.png:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement mfenced MathML element
Update stretchy operator code to take into account new brackets and to tune layout parameters
https://bugs.webkit.org/show_bug.cgi?id=42472

Test: mathml/presentation/fenced.xhtml

WebCore.xcodeproj/project.pbxproj:
mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement): (WebCore::MathMLInlineContainerElement::createRenderer):
mathml/RenderMathMLFenced.cpp: Added. (WebCore::RenderMathMLFenced::RenderMathMLFenced): (WebCore::RenderMathMLFenced::updateFromElement): (WebCore::RenderMathMLFenced::makeOperatorStyle): (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::addChild): (WebCore::RenderMathMLFenced::layout):
mathml/RenderMathMLFenced.h: Added.
mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::RenderMathMLOperator): (WebCore::RenderMathMLOperator::stretchToHeight): (WebCore::): (WebCore::RenderMathMLOperator::updateFromElement): (WebCore::RenderMathMLOperator::createStackableStyle): (WebCore::RenderMathMLOperator::createGlyph):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed