⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 11, 2010:

11:42 PM Changeset in webkit [65220] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-08-11 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Handle clicks and recognition events for the speech input button
​https://bugs.webkit.org/show_bug.cgi?id=43857

  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton): Selects the image based on current state.
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::set_state): Switch to a new state and update the UI. (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
  • rendering/TextControlInnerElements.h: (WebCore::InputFieldSpeechButtonElement::): (WebCore::InputFieldSpeechButtonElement::state):
11:31 PM Changeset in webkit [65219] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION(65135): format specifier warnings
​https://bugs.webkit.org/show_bug.cgi?id=43876

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu. (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.
11:02 PM Changeset in webkit [65218] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in bindings/cpp.

10:50 PM Changeset in webkit [65217] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Make PendingScript copyable so that it can be stored in containers
​https://bugs.webkit.org/show_bug.cgi?id=43875

This will be useful for storing PendingScripts in a Vector or Deque for
async and defer scripts.

No new tests because no functional changes.

  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
9:35 PM Changeset in webkit [65216] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Disable accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=43894

Disable accelerated compositing because DRT is not ready for
it. This change fixes hundreds of test crashes on Windows and
Linux.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
8:56 PM Changeset in webkit [65215] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-11 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Fixing a regression in the UI for Mac default audio/video controls.
​https://bugs.webkit.org/show_bug.cgi?id=43750

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
8:53 PM Changeset in webkit [65214] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add more files to the WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
8:13 PM Changeset in webkit [65213] by abarth@webkit.org
  • 5 edits in trunk

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

  • html5lib/runner-expected-html5.txt:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
HTMLElement::createContextualFragment that interferes with the new
HTMLTreeBuilder. Doing that exposes the above ASSERT, which I've fixed
in this patch too. Fixing that ASSERT involved a small refactoring in
ExternalCharacterTokenBuffer.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::createContextualFragment):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): (WebCore::HTMLTreeBuilder::processCharacterBuffer):
7:55 PM Changeset in webkit [65212] by abarth@webkit.org
  • 4 edits in trunk

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Conditionalize wrong fragment parsing code to pass more HTML5lib tests
​https://bugs.webkit.org/show_bug.cgi?id=43877

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Conditionalize wrong fragment parsing code to pass more HTML5lib tests
​https://bugs.webkit.org/show_bug.cgi?id=43877

This code exists to support the LegacyHTMLTreeBuilder. Unfortunately,
it causes problems for the new HTMLTreeBuilder (which is more
self-contained).

  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
7:37 PM Changeset in webkit [65211] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
​https://bugs.webkit.org/show_bug.cgi?id=40725

Qt and Tiger seem to have encoding problems that swallow the --
characters that terminate the comment. We can avoid those problems by
inserting a space before the -->. We're losing coverage of these
issues, but I'm not sure we should be in the business of debugging
these encoders unless there's a security problem.

Thanks to ap for investigating and finding this workaround.

  • fast/encoding/japanese-encoding-mix.html:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
7:36 PM Changeset in webkit [65210] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Add SPI to stop loading from the InjectedBundle.

Reviewed by Gavin Barraclough.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStopLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.h:
7:09 PM Changeset in webkit [65209] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-08-11 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Last Hangul letter is typed again when a composition is finished with mouse press
​https://bugs.webkit.org/show_bug.cgi?id=40518

When a mouse press fires during a IME composition, the current composition character
can be entered twice at the previous editing position and a new editing position.
Because the IME commit signal is emitted after the mouse press event.
This patch allows to prevent the commit signal during a composition when a mouse press fires.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit. (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires. (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Call handleInputMethodMousePress()
7:05 PM Changeset in webkit [65208] by rniwa@webkit.org
  • 8 edits
    3 adds in trunk

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Can't unbold text in div in font-weight span
​https://bugs.webkit.org/show_bug.cgi?id=26871

The bug was caused by removeInlineStyle not being able to include styled inline nodes around the start.
Solved this problem by pushing down all inline styles instead of just text-decorations.
This approach allows removeInlineStyle to remove styled ancestors properly and generates compact markups.

Test: editing/style/push-down-inline-styles.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): No longer removes attributes or node when mode == RemoveNone. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement to determine the highest ancestor whose style needs to be pushed down. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Renamed from extractTextDecorationStyle. Extracts all inline CSS properties specified instead of just text decorations. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Renamed from applyTextDecorationStyle. Applies inline styles using addInlineStyleIfNeeded or adds inline CSS values. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Renamed from pushDownTextDecorationStyleAroundNode. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode.
  • editing/ApplyStyleCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Prevents moveParagraph from preserving the style of an empty paragraph when merged with the previous paragraph because we don't use that style anyways.

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Can't unbold text in div in font-weight span
​https://bugs.webkit.org/show_bug.cgi?id=26871

Added a test to push down inline styles to the leaves of DOM tree.

  • editing/deleting/delete-br-011-expected.txt: Removed redundant style spans.
  • editing/execCommand/empty-span-removal-expected.txt: Removed a span without any attributes.
  • editing/style/push-down-inline-styles-expected.txt: Added.
  • editing/style/push-down-inline-styles.html: Added.
  • editing/style/script-tests/push-down-inline-styles.js: Added. (testSingleToggle):
6:56 PM Changeset in webkit [65207] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

6:50 PM Changeset in webkit [65206] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt: http/tests/storage/callbacks-are-called-in-correct-context.html is SLOW, not PASS TIMEOUT
6:27 PM Changeset in webkit [65205] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Ariya Hidayat.

Remove dead code in CSSStyleSelector.
​https://bugs.webkit.org/show_bug.cgi?id=43805

  • css/CSSStyleSelector.cpp: Remove some debugging code that was compiled out.
6:24 PM Changeset in webkit [65204] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: isNativeCheckbox does not work as advertised
​https://bugs.webkit.org/show_bug.cgi?id=43872

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isInputImage):

Only say it's an input image if its role has not been overriden

(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):

  • dom/InputElement.h:

Add methods to query if it's a checkbox or radio button type element.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
5:45 PM Changeset in webkit [65203] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt: Mark http/tests/storage/callbacks-are-called-in-correct-context.html as flaky.
5:39 PM Changeset in webkit [65202] by weinig@apple.com
  • 2 edits in trunk/WebKit2

WKPageStopLoading always asserts

Reviewed by Gavin Barraclough.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage): Switch break to return, break made us
hit the ASSERT_NOT_REACHED at the end of the function.

5:31 PM Changeset in webkit [65201] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
which means isNaN(new Date("")) should return true.
​https://bugs.webkit.org/show_bug.cgi?id=43793
Tests: fast/js/date-constructor.html

  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::resetDateCache):

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
​https://bugs.webkit.org/show_bug.cgi?id=43793

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
5:12 PM Changeset in webkit [65200] by kbr@google.com
  • 38 edits in trunk

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Remove obsolete WebGLArray type names
​https://bugs.webkit.org/show_bug.cgi?id=43885

Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.

  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.idl:

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Remove obsolete WebGLArray type names
​https://bugs.webkit.org/show_bug.cgi?id=43885

Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.

  • compositing/webgl/webgl-reflection.html:
  • fast/canvas/webgl/array-get-and-set-method-removal.html:
  • fast/canvas/webgl/array-get-out-of-bounds.html:
  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
  • fast/canvas/webgl/array-set-out-of-bounds.html:
  • fast/canvas/webgl/array-setters-expected.txt:
  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
  • fast/canvas/webgl/null-uniform-location.html:
  • fast/canvas/webgl/point-size.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils): (WebGLTestUtils.):
  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
  • fast/canvas/webgl/tex-image-with-format-and-type.html:
  • fast/canvas/webgl/tex-input-validation.html:
  • fast/canvas/webgl/tex-sub-image-2d-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d.html:
  • fast/canvas/webgl/texImage2DImageDataTest.html:
  • fast/canvas/webgl/viewport-unchanged-upon-resize.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
4:46 PM Changeset in webkit [65199] by steveblock@google.com
  • 4 edits in trunk/WebCore

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

[chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
​https://bugs.webkit.org/show_bug.cgi?id=43753

This change guards the entire contents of the V8 custom bindings files
with ENABLE(GEOLOCATION) to match JSC.

No new tests, build fix only.

  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
4:35 PM Changeset in webkit [65198] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Adding my Collabora personality to the list.

  • Scripts/webkitpy/common/config/committers.py:
4:30 PM Changeset in webkit [65197] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Levin.

Include <wtf/UnusedParam.h> in GraphicsContextSkia.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43843

wtf/UnusedParam.h must be included because UNUSED_PARAM macro is used.

  • platform/graphics/skia/GraphicsContextSkia.cpp:
4:25 PM Changeset in webkit [65196] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Small improvement to the documentation of the geolocation-policy-decision-requested
signal, stating more clearly what is expected from the handler.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
4:25 PM Changeset in webkit [65195] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Geolocation policy decision object leaking
​https://bugs.webkit.org/show_bug.cgi?id=43884

Use GRefPtr on the policy decision object to fix the leak.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
4:14 PM Changeset in webkit [65194] by thakis@chromium.org
  • 4 edits in trunk/WebCore

2010-08-11 Nico Weber <​thakis@chromium.org>

Reviewed by David Levin.

[chromium/mac]: Fix colors in compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=43823

The textures are drawn by opengl, which doesn't do any color space
correction -- it assumes everything is in the device color space
already. Hence, when drawing into the memory that will be uploaded
as opengl texture, use the device color space.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureContents):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
3:54 PM Changeset in webkit [65193] by aa@chromium.org
  • 9 edits in trunk

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Remove obsolete texImage2D and texSubImage2D entry points
​https://bugs.webkit.org/show_bug.cgi?id=40320

No new tests; covered by existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
3:44 PM Changeset in webkit [65192] by kbr@google.com
  • 4 edits in trunk/WebCore

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Remove obsolete texImage2D and texSubImage2D entry points
​https://bugs.webkit.org/show_bug.cgi?id=40320

No new tests; covered by existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
3:28 PM Changeset in webkit [65191] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-08-11 Martin Robinson <​mrobinson@igalia.com>

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:16 PM Changeset in webkit [65190] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/win/BString.cpp:

(WebCore::BString::BString):

3:02 PM Changeset in webkit [65189] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix II.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

2:52 PM Changeset in webkit [65188] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Windows & !JIT build fix.

(JSC::RegExp::match):

2:48 PM Changeset in webkit [65187] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Qt build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

2:45 PM Changeset in webkit [65186] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber stamp by sam weinig

Touch a file to stop the bot rolling a bit change out!

  • runtime/UString.cpp:

(JSC::UString::ascii):

2:35 PM Changeset in webkit [65185] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage
​https://bugs.webkit.org/show_bug.cgi?id=43848

Tested by existing DeviceOrientation tests.

  • loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::setController): (WebCore::EmptyDeviceMotionClient::startUpdating): (WebCore::EmptyDeviceMotionClient::stopUpdating): (WebCore::EmptyDeviceMotionClient::currentDeviceMotion): (WebCore::EmptyDeviceOrientationClient::setController): (WebCore::EmptyDeviceOrientationClient::startUpdating): (WebCore::EmptyDeviceOrientationClient::stopUpdating): (WebCore::EmptyDeviceOrientationClient::lastOrientation):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
2:23 PM Changeset in webkit [65184] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Mark websocket/tests/frame-length-overflow.html as flaky.

  • platform/chromium/test_expectations.txt:
1:38 PM Changeset in webkit [65183] by aa@chromium.org
  • 9 edits in trunk

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Handle the case where user styles might have author level. Minor refactor.
  • dom/Document.cpp: (WebCore::Document::pageGroupUserSheets): Set isUserStyle on created stylesheet objects appropriately.
  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): Add new optional "level" argument.
  • page/PageGroup.h: Ditto.
  • page/UserStyleSheet.h: Add level property. (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::setLevel): (WebCore::UserStyleSheet::level):

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet): Send "author" for the css level of user styles.
1:24 PM Changeset in webkit [65182] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=42042
An empty value for xml:lang isn't considered

Revert last line change of my patch ; it happens to
behave correctly and same as before, but makes the
use case of empty values unneededly slower.

No new tests. (No change in behavior)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1:10 PM Changeset in webkit [65181] by jhawkins@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
1:09 PM Changeset in webkit [65180] by kevino@webkit.org
  • 13 edits
    2 adds in trunk

[wx, WebDOM] Build fix. Fix handling of callbacks and WebCore::String -> WTF::String fixes.

12:55 PM Changeset in webkit [65179] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Perl warnings when running commit-log-editor
​https://bugs.webkit.org/show_bug.cgi?id=43856

Fixes Perl warnings introduced by the patch for Bug #40548.

Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.

  • Scripts/commit-log-editor:
12:53 PM Changeset in webkit [65178] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[Chromium] Remove consistently passing tests
from test_expectations.txt.

​https://bugs.webkit.org/show_bug.cgi?id=43868

  • platform/chromium/test_expectations.txt:
12:52 PM Changeset in webkit [65177] by barraclough@apple.com
  • 58 edits
    1 copy in trunk

Rubber stamps by Darin Adler & Sam Weinig.

Bug 43867 - Some UString cleanup

Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClass::className):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::processClauseList):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegex):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeNumericIdentifier):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::length):

  • profiler/Profiler.cpp:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

  • runtime/ExceptionHelpers.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/Identifier.h:

(JSC::Identifier::characters):
(JSC::Identifier::length):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseInt):
(JSC::parseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSNumberCell.cpp:

(JSC::JSNumberCell::toString):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::indent):
(JSC::Stringifier::unindent):
(JSC::Walker::walk):

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter):
(JSC::JSString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::fiberCount):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::JSString::getIndex):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::Lexer::Lexer):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/NumericStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getRightContext):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::append):

  • runtime/StringConcatenate.h: Copied from JavaScriptCore/runtime/UString.h.

(JSC::):
(JSC::sumWithOverflow):
(JSC::tryMakeString):
(JSC::makeString):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::localeCompare):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
(JSC::trimString):

  • runtime/UString.cpp:

(JSC::UString::number):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toDouble):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator==):
(JSC::operator<):
(JSC::operator>):
(JSC::UString::UTF8String):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::length):
(JSC::UString::characters):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::operator!=):
(JSC::codePointCompare):
(JSC::UString::toArrayIndex):
(JSC::IdentifierRepHash::hash):
(WTF::):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::Parser):

JavaScriptGlue:

  • JSUtils.cpp:

(UStringToCFString):
(KJSValueToCFTypeInternal):

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::hasCSSPropertyNamePrefix):
(WebCore::cssPropertyName):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setPort):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::size):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

  • bridge/jni/jsc/JNIUtilityPrivate.cpp:

(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(toNSString):

12:49 PM Changeset in webkit [65176] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Trying waiting for httpd lock in the EWS
​https://bugs.webkit.org/show_bug.cgi?id=43833

If this works, we can probably run the tests on the mac-ews, which
would be very exciting. :)

  • Scripts/webkitpy/tool/steps/runtests.py:
12:48 PM Changeset in webkit [65175] by hyatt@apple.com
  • 10 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.

Reviewed by Dan Bernstein.

WebCore:

Add a new boolean to Document to indicate that content should be paginated. This is checked when doing page breaks
and in a couple of other cases.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::paginatedForScreen):
(WebCore::Document::setPaginatedForScreen):
(WebCore::Document::paginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::calcColumnWidth):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):

WebKit/mac:

Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
content.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _isInScreenPaginationMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):

  • WebView/WebHTMLViewPrivate.h:
12:39 PM Changeset in webkit [65174] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Add AudioNode memory leak instrumentation

12:38 PM Changeset in webkit [65173] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Make AudioContext be an ActiveDOMObject

12:33 PM Changeset in webkit [65172] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-08-11 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Nikolas Zimmermann.

RenderSVGRoot::nodeAtPoint truncates translated mouse coordinates
​https://bugs.webkit.org/show_bug.cgi?id=41968

New layout test checks for proper hit region.

  • platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt:
  • platform/chromium/test_expectations.txt:
  • svg/hittest/svg-rect-hit.html: Added.
11:59 AM Changeset in webkit [65171] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Windows build fix. Turns out we need to unconditionally include
HTMLEntityNames.cpp now that LegacyHTMLDocumentParser doesn't exist.

  • html/HTMLEntityParser.cpp:
11:56 AM Changeset in webkit [65170] by eric.carlson@apple.com
  • 10 edits
    2 adds in trunk

2010-08-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
​https://bugs.webkit.org/show_bug.cgi?id=42897

A <source> element inserted as a child of a media element with a networkState of NETWORK_EMPTY
should cause the networkState to immediately change to NETWORK_NO_SOURCE.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::prepareForLoad): Set m_networkState to NETWORK_NO_SOURCE. (WebCore::HTMLMediaElement::loadInternal): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::selectMediaResource): No need to change m_networkState, it was done in prepareForLoad.
  • html/HTMLMediaElement.h:
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::insertedIntoTree): Renamed from insertedIntoDocument because we want to do this setup whether or not the parent media element is in the document.
  • html/HTMLSourceElement.h:

2010-08-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
​https://bugs.webkit.org/show_bug.cgi?id=42897

  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-empty-events.html:
  • media/video-source-inserted-expected.txt: Added.
  • media/video-source-inserted.html: Added.
11:49 AM Changeset in webkit [65169] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-11 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add setting for enabling spatial navigation.
​https://bugs.webkit.org/show_bug.cgi?id=43569

Adding api for enabling/disabling spatial navigation.

  • ewk/ewk_view.cpp: Both functions below added. (ewk_view_setting_spatial_navigation_get): (ewk_view_setting_spatial_navigation_set):
  • ewk/ewk_view.h: same as ewk_view.cpp.
11:48 AM Changeset in webkit [65168] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Dimitri Glazkov <Dimitri Glazkov>

Build fix, turn off yet-unbaked DEVICE_ORIENTATION stuff.

  • features.gypi: Turned it off.
11:31 AM Changeset in webkit [65167] by abarth@webkit.org
  • 27 edits
    4 deletes in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Delete LegacyHTMLDocumentParser and LegacyPreloadScanner
​https://bugs.webkit.org/show_bug.cgi?id=43836

These classes are bit-rotting disturbingly quickly. We removed the
last dependencies on these classes and so we can remove them.

We might need to preserve some of their particular quirks to handle
some legacy applications, but our current thinking is to do that with
individual settings that affect the new parser.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • dom/DocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTMLConstructionSite.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
  • html/HTMLEntityParser.h:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLTreeBuilder.cpp:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
  • html/LegacyHTMLDocumentParser.cpp: Removed.
  • html/LegacyHTMLDocumentParser.h: Removed.
  • html/LegacyHTMLTreeBuilder.cpp:
  • html/LegacyPreloadScanner.cpp: Removed.
  • html/LegacyPreloadScanner.h: Removed.
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::processFilesizeString): (WebCore::wasLastDayOfMonth): (WebCore::processFileDateString): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::append): (WebCore::FTPDirectoryDocumentParser::finish):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
  • page/XSSAuditor.h:
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::prepend):
11:31 AM Changeset in webkit [65166] by bulach@chromium.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-08-11 Marcus Bulach <​bulach@chromium.org>

Reviewed by Eric Seidel.

Check in a script to list redundant test outputs.
​https://bugs.webkit.org/show_bug.cgi?id=37630

If e.g. platform/mac-leopard is missing an expected test output, we
fall back on platform/mac. This means it's possible to grow redundant
test outputs, where we have the same expected data in both a platform
directory and another platform it falls back on.
(original patch by Evan Marting <​evan@chromium.org> ​https://bugs.webkit.org/attachment.cgi?id=53398)

  • Scripts/deduplicate-tests: Added.
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
11:01 AM Changeset in webkit [65165] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
​https://bugs.webkit.org/show_bug.cgi?id=43853

LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
to slots at all.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::animatedFlip): (LauncherWindow::animatedYFlip):
  • QtTestBrowser/launcherwindow.h:
10:40 AM Changeset in webkit [65164] by Chris Jerdonek
  • 5 edits in trunk/WebCore

2010-08-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Refactored FrameLoader::createWindow() out of the FrameLoader class
since FrameLoader should not be responsible for creating windows.

​https://bugs.webkit.org/show_bug.cgi?id=39156

No new functionality, so no new tests.

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
    • Updated the call to FrameLoader's createWindow().
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
    • Updated the call to FrameLoader's createWindow().
  • loader/FrameLoader.cpp: (WebCore::createWindowFromFrameLoader):
    • Made FrameLoader::createWindow() non-member, non-friend and changed it to accept Frame* parameters instead of FrameLoader*.
  • loader/FrameLoader.h:
    • Updated the header file to reflect the above change to FrameLoader.cpp.
10:14 AM Changeset in webkit [65163] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-08-11 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

Implementation dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=43544

Add ewk_view_navigation_policy_decision to decide whether url which
user clicked will be loaded or not.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_navigation_policy_decision):
  • ewk/ewk_view.h:
9:55 AM Changeset in webkit [65162] by Nate Chapin
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium rebaseline.

Tweak win pixel results for svg/batik/text/textFeatures.svg.

  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
9:31 AM Changeset in webkit [65161] by alex
  • 4 edits in trunk/LayoutTests

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Unreviewed.

New baselines for the mathml tests.

  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.txt:
8:57 AM Changeset in webkit [65160] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
​https://bugs.webkit.org/show_bug.cgi?id=43851

All window options data (including the bool holding if the view is either QWebView or
QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
getting broken.

Patch addresses this issue.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleWebView): (LauncherWindow::toggleAcceleratedCompositing):
8:56 AM Changeset in webkit [65159] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-10 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
​https://bugs.webkit.org/show_bug.cgi?id=43831

Only instantiate QStateMachine and friends associated to the YRotation action on demand.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedYFlip):
8:33 AM Changeset in webkit [65158] by abecsi@webkit.org
  • 4 edits
    1 add in trunk/WebKit2

2010-08-11 Balazs Kelemen <​kb@inf.u-szeged.hu>

Unreviewed build fix.

[Qt] Update WebKit2 build environment, add stub implementation of SharedMemory.

  • DerivedSources.pro:
  • Platform/qt/SharedMemoryQt.cpp: Added. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
  • WebKit2.pro:
  • WebKit2Prefix.h:
8:08 AM Changeset in webkit [65157] by Nate Chapin
  • 44 edits
    2 adds
    3 deletes in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium rebaseline.

New results and expectations tweak for ​http://trac.webkit.org/changeset/65138.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.png:
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png: Added.
  • platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium/test_expectations.txt:
7:56 AM Changeset in webkit [65156] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: small refactoring for CodeGeneratorInspector.
all "notify" methods are generating in InspectorFrontend
the other methods are generating in InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=43849

  • inspector/CodeGeneratorInspector.pm:
7:43 AM Changeset in webkit [65155] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Misc improvements to the scrolling code
​https://bugs.webkit.org/show_bug.cgi?id=41926

Refactor code that uses deprecated ways of dealing with the
adjustments to use the GtkVersioning infrastructure.

  • GNUmakefile.am:
  • platform/gtk/GtkVersioning.cpp: Added.
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
7:37 AM Changeset in webkit [65154] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Update the Symbian def files

Re-freeze with various QGraphicsWebView and DRT updates.
The uppper part of the diff is just whitespace, so
diff -w will show the real diff.

  • symbian/eabi/QtWebKitu.def:
6:51 AM Changeset in webkit [65153] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-08-11 Nate Chapin <Nate Chapin>

Chromium mac build fix (variables weren't being initialized).

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Initalize dxLeft, dxRight, dyLeft, dyRight.
6:45 AM Changeset in webkit [65152] by estade@chromium.org
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-08-11 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

[chromium] linux chromium sends double clicks too often
​https://bugs.webkit.org/show_bug.cgi?id=43096

  • WebKit.gyp: add the test
  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent): check the x/y coordinates of the potential double click event
  • tests/WebInputEventFactoryTestGtk.cpp: Added.
6:27 AM Changeset in webkit [65151] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Rebaseline Chromium test.

  • platform/chromium-win/http/tests/loading/bad-scheme-subframe-expected.txt:
6:27 AM Changeset in webkit [65150] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-08-11 Gabor Loki <​loki@webkit.org>

Qt build fix (ARMv7).

Fix invalid conversion from int to Condition.
Add ARMv7Assembler.cpp to JavaScriptCore.pro.

6:12 AM Changeset in webkit [65149] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-08-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: apply correct fix to storage panel status bar buttons.

​https://bugs.webkit.org/show_bug.cgi?id=43846

  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype.get statusBarItems):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):
5:54 AM Changeset in webkit [65148] by Darin Adler
  • 3 edits in trunk/WebKitTools

2010-08-11 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Improved editor options for prepare-ChangeLog and commit-log-editor
​https://bugs.webkit.org/show_bug.cgi?id=40548

  • Scripts/commit-log-editor: Split editor strings on spaces so EDITOR values like "xed --launch --wait" work properly.
  • Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can use a command line tool with the $openChangeLogs feature.
5:30 AM Changeset in webkit [65147] by commit-queue@webkit.org
  • 10 edits in trunk/WebCore

2010-08-11 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Barth.

Override operator= for C++ DOM binding classes with private structs
and update C++ DOM bindings test results.
​https://bugs.webkit.org/show_bug.cgi?id=43735

  • bindings/cpp/WebDOMEventTarget.cpp: (WebDOMEventTarget::operator=):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::operator=):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: (WebDOMTestInterface::operator=):
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::operator=):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
5:14 AM Changeset in webkit [65146] by commit-queue@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-08-11 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

At collection time, we frequently want to mark a cell, while checking
whether it was originally checked. Previously, this was a get
operation follwed by a set operation. Fusing the two saves
computation and gives a 0.5% sunspider speedup.

  • runtime/Collector.h: (JSC::CollectorBitmap::getset): (JSC::Heap::checkMarkCell):
  • runtime/JSArray.h: (JSC::MarkStack::drain):
  • runtime/JSCell.h: (JSC::MarkStack::append):
4:09 AM Changeset in webkit [65145] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Inform a plugin about the zoom level when it's created
​https://bugs.webkit.org/show_bug.cgi?id=42268

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
3:30 AM Changeset in webkit [65144] by jparent@chromium.org
  • 5 edits
    2 adds in trunk

2010-08-11 Julie Parent <​jparent@chromium.org>

Reviewed by Justin Garcia.

Crash in replaceSelectionCommand with RTL text.
​https://bugs.webkit.org/show_bug.cgi?id=41485

Adds tests for 4 cases: latin text plus space in RTL region and LTR region,
and hebrew text plus space in RTL region and LTR region. Currently, the
latin text in RTL region case crashes. Added all combinations of test since
earlier patch crashed with hebrew text in LTR region.

  • editing/execCommand/insert-image-on-top-of-directional-text-expected.txt: Added.
  • editing/execCommand/insert-image-on-top-of-directional-text.html: Added.

2010-08-11 Julie Parent <​jparent@chromium.org>

Reviewed by Justin Garcia.

Crash in replaceSelectionCommand with RTL text.
​https://bugs.webkit.org/show_bug.cgi?id=41485

For text with mixed directionality, sort the text boxes before
computing gaps, since that code assumes the boxes are in order.

Test: editing/execCommand/insert-image-on-top-of-directional-text.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Sort boxes like we do in TextIterator before computing gaps.
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): Use new compareByStart rather than compareBoxStart. No functional change.
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::compareByStart): Moved compareBoxStart from TextIterator here so it can be used in multiple places.
2:41 AM Changeset in webkit [65143] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-08-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Improve vsprops copying for Windows build
​https://bugs.webkit.org/show_bug.cgi?id=41982

When we detect a new SDK, always copy a new set of vsprops files.
Previously, if someone updated their SDK after updating their sources,
they could end up with out-of-date vsprops files.

2:20 AM Changeset in webkit [65142] by mrowe@apple.com
  • 5 edits in trunk/WebKit2

Build fix. Update references to StringHash.h.

  • Shared/CommandLine.h:
  • UIProcess/WebContext.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/win/WebProcessMainWin.cpp:
2:15 AM Changeset in webkit [65141] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium compilation.

  • DEPS:
1:46 AM Changeset in webkit [65140] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed build fix of Leopard Intel Debug (Build)

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processBuffer): use %lu, instead of %ul
1:43 AM Changeset in webkit [65139] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix.

  • DEPS: bump up Chromium revision.
1:43 AM Changeset in webkit [65138] by alex
  • 50 edits in trunk

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Dirk Schulze.

Fixes to the gaussian blur algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41605

Added the recomendations of SVG regarding the kernel size
calculation for the approximation of the gaussian
blur. ​http://www.w3.org/TR/SVG/filters.html#feGaussianBlurElement.
Modified also some variable names to clarify algorithm, reviewed
the situation where both standard deviations are 0.

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::stdDeviationX): (WebCore::FEGaussianBlur::setStdDeviationX): (WebCore::FEGaussianBlur::stdDeviationY): (WebCore::FEGaussianBlur::setStdDeviationY): (WebCore::boxBlur): (WebCore::FEGaussianBlur::kernelPosition): Added the SVG kernel position recomendation. (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h:

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Dirk Schulze.

Fixes to the gaussian blur algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41605

Unskipped test and generated results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.

Updated pixel tests.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-leopard/svg/batik/text/textProperties-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textProperties-expected.png:
  • platform/mac-leopard/svg/custom/mask-colorspace-expected.png:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/custom/non-opaque-filters-expected.checksum:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.checksum:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/text-filter-expected.checksum:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
1:35 AM Changeset in webkit [65137] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Kristian Monsen <​kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android, added include for <wtf/text/Cstring.h, this
did not get included in Android.
​https://bugs.webkit.org/show_bug.cgi?id=41517

Build fix only, no new tests.

  • page/PrintContext.cpp:
1:32 AM Changeset in webkit [65136] by yurys@chromium.org
  • 5 edits
    1 delete in trunk

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InjectDispatch.js
​https://bugs.webkit.org/show_bug.cgi?id=43835

  • WebKit.grd:
  • src/js/InjectDispatch.js: Removed.

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InjectDispatch.js
​https://bugs.webkit.org/show_bug.cgi?id=43835

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
1:23 AM Changeset in webkit [65135] by ukai@chromium.org
  • 4 edits
    3 adds in trunk

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix length calculation to be more robust.
​https://bugs.webkit.org/show_bug.cgi?id=43777

  • websocket/tests/frame-length-overflow-expected.txt: Added.
  • websocket/tests/frame-length-overflow.html: Added.
  • websocket/tests/frame-length-overflow_wsh.py: Added.

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix length calculation to be more robust.
​https://bugs.webkit.org/show_bug.cgi?id=43777

Test: websocket/tests/frame-length-overflow.html

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): len is size_t.
    • add sanity check for integer wraps.

(WebCore::WebSocketChannel::skipBuffer): len is size_t.
(WebCore::WebSocketChannel::processBuffer): length is size_t.

  • add sanity check for integer wraps.
  • websockets/WebSocketChannel.h: change m_bufferSize and len to size_t.
12:51 AM Changeset in webkit [65134] by abarth@webkit.org
  • 6 edits
    5 adds in trunk

2010-08-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.

Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
    • This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
  • html/HTMLElement.cpp: (WebCore::contextElementForInsertion):
    • This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.

(WebCore::HTMLElement::insertAdjacentHTML):

  • Use the right contextElement now that we know how to compute it.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
    • This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.

2010-08-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In order to fix the insertAdjacentHTML I had to some behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.

  • fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
  • fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.
12:40 AM Changeset in webkit [65133] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Attempt to fix Windows build.

  • platform/win/COMPtr.h: (WTF::):
12:30 AM Changeset in webkit [65132] by abarth@webkit.org
  • 12 edits
    2 adds in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Port view-source to new parser
​https://bugs.webkit.org/show_bug.cgi?id=43746

This patch switches the view-source mode for frames over to using the
new HTML parsing infrastructure. This patch is an architectural change
to how we parser view source documents.

Previously, the LegacyHTMLDocumentParser would output a "guide string"
that consided of the inter-attribute whitespace and various "control"
characters. The HTMLViewSourceDocument would then interpret this guide
string to approximately reconstruct the source of the original document
and colorize various syntatic constructs.

Unfortunately, that approach is inherently low-fidelity. It's not
really feasible to reconstruct the input document from the token
stream. The old view source mode also had a number of hacks in the old
parser (e.g., to turn of decoding of HTML entities).

Instead of trying to reconstruct the original document from the token
stream, we use the segmentation information given by the tokens to
colorize the input document itself. Each token now caries information
about where in the input stream it came from and where various
subcomponents (e.g., attribute names and values) are located. This
approach is higher fidelity because we use this segmentation
information to colorize the original input instead of attempting to
reconstruct the original input.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLDocumentParser.cpp:
  • html/HTMLToken.h: (WebCore::HTMLToken::clear): (WebCore::HTMLToken::startIndex): (WebCore::HTMLToken::length): (WebCore::HTMLToken::end):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addSource): (WebCore::HTMLViewSourceDocument::processDoctypeToken): (WebCore::HTMLViewSourceDocument::processTagToken): (WebCore::HTMLViewSourceDocument::processCommentToken): (WebCore::HTMLViewSourceDocument::processCharacterToken): (WebCore::HTMLViewSourceDocument::addRange):
  • html/HTMLViewSourceDocument.h:
  • html/HTMLViewSourceParser.cpp: Added. (WebCore::HTMLViewSourceParser::~HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::insert): (WebCore::HTMLViewSourceParser::pumpTokenizer): (WebCore::HTMLViewSourceParser::append): (WebCore::HTMLViewSourceParser::sourceForToken): (WebCore::HTMLViewSourceParser::updateTokenizerState): (WebCore::HTMLViewSourceParser::finish): (WebCore::HTMLViewSourceParser::finishWasCalled):
  • html/HTMLViewSourceParser.h: Added. (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::document):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken):
12:13 AM WebKit Team edited by ariya@webkit.org
my new employer (diff)
12:13 AM Changeset in webkit [65131] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-08-11 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
​https://bugs.webkit.org/show_bug.cgi?id=17918

  • fast/flexbox/vertical-box-form-controls-expected.txt: Added.
  • fast/flexbox/vertical-box-form-controls.html: Added.

2010-08-11 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
​https://bugs.webkit.org/show_bug.cgi?id=17918

Test: fast/flexbox/vertical-box-form-controls.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicWidth):
12:08 AM Changeset in webkit [65130] by abarth@webkit.org
  • 9 edits in trunk

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • API/JSRetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". We should probably put this in the style guide and do it consitently. Fixed other minor style issues. Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers oat once. Added a clear function.
  • wtf/PassRefPtr.h: Changed all uses of releaseRef to leakRef.
  • wtf/RefPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Tidied up declarations and comments a bit. Changed all uses of releaseRef to leakRef.
  • wtf/RetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • platform/win/COMPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function. Changed the hash table code so it doesn't need to call releaseRef, and so it uses the hash table deleted value hooks already present within the class.

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • UIProcess/API/cpp/WKRetainPtr.h: Changed all uses of "template <...>" to "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.

Aug 10, 2010:

11:53 PM WebKit Team edited by abarth@webkit.org
(diff)
11:31 PM Changeset in webkit [65129] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-10 Shinichiro Hamaji <​hamaji@chromium.org>

Add a suppression of animations/suspend-resume-animation.html for chromium.

  • platform/chromium/test_expectations.txt:
11:24 PM Changeset in webkit [65128] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-08-10 Ariya Hidayat <​ariya@sencha.com>

[Qt] Fix build warning: remove reference to html/BlobRegistryImp.h

  • WebCore.pro:
11:20 PM Changeset in webkit [65127] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43803
<rdar://problem/6988023> Only the last Korean character can be shown if font style is enabled while typing (43803)

Test: platform/mac/editing/input/bold-node.html

  • editing/Editor.cpp: (WebCore::Editor::setComposition): It is not clear to me what the "baseNode == extentNode" check is about in this function , but let's try to make it more likely that it passes.
11:19 PM Changeset in webkit [65126] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

webkit-patch should refuse to run under Win32 Python
​https://bugs.webkit.org/show_bug.cgi?id=40962

Given that there are lots of places in webkit-patch's code that
assume unix-style filenames (forward slashes), webkit-patch fails
with weird file-not-found errors when run under a native windows
Python. It would be nice if we just trapped this and errored out
at the beginning, rather than producing unpredictable errors.

  • Scripts/webkit-patch:
11:00 PM Changeset in webkit [65125] by dumi@chromium.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed, reverting an unintentional change to a file submitted in r65108.

  • bytecode/CodeBlock.h:

(JSC::binaryChop):

10:39 PM Changeset in webkit [65124] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-08-10 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
​https://bugs.webkit.org/show_bug.cgi?id=40580

_q_updateMicroFocus() is a noop unless this ifdef evaluates to true:

#if !defined(QT_NO_IM) && (defined(Q_WS_X11)
defined(Q_WS_QWS) defined(Q_OS_SYMBIAN))

In such cases there's no need to carry the overhead of the extra
signal/slot connection.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
10:20 PM Changeset in webkit [65123] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-10 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Make CSSSelector::specificity() non-recursive.
​https://bugs.webkit.org/show_bug.cgi?id=43784

This change is one of the required changes to fix the following master bug:
​https://bugs.webkit.org/show_bug.cgi?id=42806

No functional change, thus no tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::specificityForPage):
  • css/CSSSelector.h:
10:02 PM Changeset in webkit [65122] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-10 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL]REGRESSION(65021) need to fix build break
​https://bugs.webkit.org/show_bug.cgi?id=43767

Remove AtomicStringWTF and change namespace TextCaseInsensitive.

  • ewk/ewk_frame.cpp: (ewk_frame_plugin_create):
  • ewk/ewk_view.cpp: (ewk_view_text_search): (ewk_view_text_matches_mark): (ewk_view_setting_font_cursive_set):
9:47 PM Changeset in webkit [65121] by tkent@chromium.org
  • 4 edits in trunk

2010-08-10 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

Chromium build fix for r65107.

  • src/WebAnimationControllerImpl.cpp: (WebKit::WebAnimationControllerImpl::suspendAnimations): (WebKit::WebAnimationControllerImpl::resumeAnimations):

2010-08-10 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

Chromium build fix for r65107.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
8:40 PM Changeset in webkit [65120] by cmarrin@apple.com
  • 3 edits in trunk/WebKit/chromium

another try at fixing Chromium build broken by ​http://trac.webkit.org/changeset/65107

8:30 PM Changeset in webkit [65119] by cmarrin@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp

Another try at fixing Chromium build

8:10 PM Changeset in webkit [65118] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-10 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Darin Adler.

2d.path.clip.empty.html test is failing
​https://bugs.webkit.org/show_bug.cgi?id=43161

  • platform/mac/Skipped: Unskipping now passing path.clip.empty

2010-08-10 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Darin Adler.

2d.path.clip.empty.html test is failing
​https://bugs.webkit.org/show_bug.cgi?id=43161

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clip): Catching the empty path case from being sent directly to CGContextClip - which would ignore it. Instead, using CGContextClip with a CGRectZero to achieve the desired behavior of reducing the clipping region to nothing.
7:53 PM Changeset in webkit [65117] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-08-10 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add video files to enable video in WebKit EFL
​https://bugs.webkit.org/show_bug.cgi?id=43790

Add files regarding html5 video to CMakeList.txt for WebKit Efl.
But, this patch is not run html5 video on WebKit EFL yet.

  • CMakeLists.txt: Add files related to html5video.
  • platform/efl/LocalizedStringsEfl.cpp: Add functions for html5 video. (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Disable MediaPlayerPrivate::r

egisterMediaEngine for WebKit EFL.

7:34 PM Changeset in webkit [65116] by commit-queue@webkit.org
  • 6 edits in trunk/WebCore

2010-08-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

Add a toRenderSVGImage function
​https://bugs.webkit.org/show_bug.cgi?id=43789

Add a function for casting to RenderSVGImage and use it.

  • rendering/RenderSVGImage.h: (WebCore::toRenderSVGImage):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGImage):
  • rendering/SVGRenderTreeAsText.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
7:33 PM Changeset in webkit [65115] by cmarrin@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touching WebKit.idl to get IWebFramePrivate.idl to get rebuilt

7:21 PM Changeset in webkit [65114] by cmarrin@apple.com
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Fix for Chromium and gtk builds, broken by ​http://trac.webkit.org/changeset/65107

7:15 PM Changeset in webkit [65113] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-10 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/media/video-cookie.html fails
​https://bugs.webkit.org/show_bug.cgi?id=42240

  • platform/gtk/Skipped: unskipped test

2010-08-10 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/media/video-cookie.html fails
​https://bugs.webkit.org/show_bug.cgi?id=42240

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies): create the SoupCookieJar if it does not exist. Otherwise the accept policy won't be set.
7:14 PM Changeset in webkit [65112] by cmarrin@apple.com
  • 1 edit in trunk/WebKit/win/WebFrame.cpp

Fix for Windows build, broken by ​http://trac.webkit.org/changeset/65107

7:13 PM Changeset in webkit [65111] by barraclough@apple.com
  • 7 edits in trunk/WebKit

Build fix (update more includes)

WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostManager.h:

WebKit/win:

  • WebKitDLL.h:
  • WebLocalizableStrings.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
6:55 PM Changeset in webkit [65110] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-08-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Clients of HTMLTokenizer should be able to see where characters went in the token
​https://bugs.webkit.org/show_bug.cgi?id=43766

When viewing the source of a document, we want to colorize different
parts of the input depending on how they were tokenized. In this
patch, we expose the internal segmentation of a token by recording the
start and end offsets for each attribute name and each attribute value.

  • html/HTMLToken.h: (WebCore::HTMLToken::addNewAttribute): (WebCore::HTMLToken::beginAttributeName): (WebCore::HTMLToken::endAttributeName): (WebCore::HTMLToken::beginAttributeValue): (WebCore::HTMLToken::endAttributeValue): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::AtomicHTMLToken::AtomicHTMLToken):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
6:28 PM Changeset in webkit [65109] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-08-10 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

fast/dom/Window/window-properties.html is pretty slow
​https://bugs.webkit.org/show_bug.cgi?id=43755


window-properties.html would take 5.9 seconds to run on my Mac Pro.

  • fast/dom/Window/window-properties.html:
6:19 PM Changeset in webkit [65108] by dumi@chromium.org
  • 9 edits in trunk

Do not post a sync task to the DB thread if it's terminating.
​https://bugs.webkit.org/show_bug.cgi?id=43676

Reviewed by David Levin.

  • bindings/generic/ActiveDOMCallback.cpp: The context can

sometimes be NULL. Check if it's NULL instead of asserting that
it's not.
(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):

  • storage/Database.cpp: Do not post a sync task to the DB thread

if the DB thread is terminating. Also, when a task is destroyed,
ASSERT that it was completed, or that it had no synchronizer.
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):

  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTask::~DatabaseTask):
(WebCore::DatabaseTask::performTask):

  • storage/DatabaseTask.h:

(WebCore::DatabaseTaskSynchronizer::hasCheckedForTermination):
(WebCore::DatabaseTaskSynchronizer::setHasCheckedForTermination):
(WebCore::DatabaseTask::hasSynchronizer):
(WebCore::DatabaseTask::hasCheckedForTermination):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::terminationRequested):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):

  • storage/DatabaseThread.h:
6:03 PM Changeset in webkit [65107] by cmarrin@apple.com
  • 26 edits
    2 adds in trunk

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733


Qt specific API. Missing symbian symbol defines in:


WebKit/qt/symbian/bwins/QtWebKitu.def
WebKit/qt/symbian/eabi/QtWebKitu.def

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendAnimations): (DumpRenderTreeSupportQt::resumeAnimations):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733


Gtk specific API.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_suspend_animations): (webkit_web_frame_resume_animations):

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733

Win specific API

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::suspendAnimations): (WebFrame::resumeAnimations):
  • WebFrame.h:

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733


Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.

  • WebView/WebFrame.mm: (-[WebFrame _suspendAnimations]): (-[WebFrame _resumeAnimations]):
  • WebView/WebFramePrivate.h:

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733


This tests suspend and resume of animations. Transitions are currently broken
due to ​https://bugs.webkit.org/show_bug.cgi?id=43792. I will add transition
tests and tests of transition and animation interaction with that fix.

  • animations/animation-test-helpers.js: (matrixStringToArray):
  • animations/suspend-resume-animation-expected.txt: Added.
  • animations/suspend-resume-animation.html: Added.

2010-08-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Oliver Hunt.

Add suspendAnimations/resumeAnimation API to DRT
​https://bugs.webkit.org/show_bug.cgi?id=43733


Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
Calls functions with the same names on AnimationController for the
mainFrame.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp: (suspendAnimationsCallback): (resumeAnimationsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
5:54 PM Changeset in webkit [65106] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

5:29 PM Changeset in webkit [65105] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Fix more build break.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::revokeBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:

(WebCore::Blob::slice):

5:16 PM Changeset in webkit [65104] by barraclough@apple.com
  • 58 edits in trunk

Bug 43817 - Remove UString::Rep
UString::Rep has for a long time been replaced by UStringImpl (Rep
remaining as a typedef). UStringImpl has since been removed too
(unified with StringImpl). Remove Rep, rename rep() to impl() and
m_rep to m_impl. Also add impl() method to Identifier, and rename
its UString member from _ustring to m_string.

Rubber stamped by Sam Weinig

JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getOwnPropertyNames):
(JSC::::staticValueGetter):
(JSC::::staticFunctionGetter):

  • API/JSClassRef.cpp:

(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • API/JSClassRef.h:
  • API/OpaqueJSString.cpp:

(OpaqueJSString::ustring):

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::findScopedProperty):
(JSC::keyForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • parser/JSParser.cpp:

(JSC::JSParser::parseStrictObjectLiteral):

  • pcre/pcre_exec.cpp:

(Histogram::add):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::Hash::hash):

  • profiler/Profile.cpp:
  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintDataSampleStyle):

  • profiler/ProfileNode.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::ustring):
(JSC::Identifier::impl):
(JSC::Identifier::data):
(JSC::Identifier::size):
(JSC::Identifier::ascii):
(JSC::Identifier::isNull):
(JSC::Identifier::isEmpty):
(JSC::Identifier::toUInt32):
(JSC::Identifier::toStrictUInt32):
(JSC::Identifier::toArrayIndex):
(JSC::Identifier::toDouble):
(JSC::Identifier::equal):
(JSC::Identifier::add):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::displayName):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::displayName):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::addStaticGlobals):

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::JSStaticScopeObject):

  • runtime/JSString.h:

(JSC::):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):

  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::HashTable::deleteTable):

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::setKey):
(JSC::HashEntry::key):
(JSC::HashTable::entry):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::addKnownUnique):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::create):

  • runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::rep):
(JSC::SmallStrings::singleCharacterStringRep):

  • runtime/SmallStrings.h:
  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

  • runtime/Structure.cpp:

(JSC::Structure::~Structure):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::hasTransition):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):

  • runtime/Structure.h:

(JSC::Structure::get):
(JSC::Structure::hasTransition):

  • runtime/StructureTransitionTable.h:
  • runtime/SymbolTable.h:
  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::toStrictUInt32):
(JSC::UString::substr):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::codePointCompare):
(JSC::IdentifierRepHash::hash):
(WTF::):

WebCore:

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):

  • bindings/js/JSDOMBinding.h:

(WebCore::ustringToString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):

  • bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValueData::SerializedScriptValueData):

  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::~JavaStringImpl):
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
(JSC::Bindings::JavaStringImpl::uString):

  • bridge/jsc/BridgeJSC.h:

WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

5:14 PM Changeset in webkit [65103] by jianli@chromium.org
  • 6 edits in trunk/WebCore

Fix qt build break.

  • html/BlobRegistryImpl.cpp:
  • html/BlobRegistryImpl.h:
  • html/BlobURL.cpp:
  • html/BlobURL.h:
  • platform/BlobRegistry.h:
5:03 PM Changeset in webkit [65102] by jianli@chromium.org
  • 16 edits
    4 copies
    4 adds in trunk/WebCore

Add the support to register the blob data.
​https://bugs.webkit.org/show_bug.cgi?id=43600

Reviewed by David Levin.

This is the first step towards adding Blob URL support. The blob has
an internal URL (used by FileReader) and public URLs (used by Blob.url).
The URL and its associated data are managed by BlobRegistry interface.

This patch does not remove the usage of BlobItem. It will be removed
when all the blob data support is hooked up and the new tests will be
added then.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedBlob::create):
(WebCore::SerializedBlob::url):
(WebCore::SerializedBlob::type):
(WebCore::SerializedBlob::size):
(WebCore::SerializedBlob::SerializedBlob):
(WebCore::SerializedFile::create):
(WebCore::SerializedFile::path):
(WebCore::SerializedFile::url):
(WebCore::SerializedFile::type):
(WebCore::SerializedFile::SerializedFile):
(WebCore::SerializedFileList::item):
(WebCore::SerializedFileList::SerializedFileList):
(WebCore::SerializedScriptValueData::SerializedScriptValueData):
(WebCore::SharedSerializedData::asBlob):
(WebCore::SharedSerializedData::asFile):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::convertIfTerminal):
(WebCore::TeardownTreeWalker::convertIfTerminal):

  • bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValueData::):
(WebCore::SerializedScriptValueData::asString):
(WebCore::SerializedScriptValueData::asBlob):
(WebCore::SerializedScriptValueData::asFile):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Writer::writeBlob):
(WebCore::ZigZag::Writer::writeFile):
(WebCore::ZigZag::Writer::writeFileList):
(WebCore::ZigZag::Writer::doWriteUintHelper):
(WebCore::ZigZag::Writer::doWriteUint32):
(WebCore::ZigZag::Writer::doWriteUint64):
(WebCore::ZigZag::Serializer::writeBlob):
(WebCore::ZigZag::Serializer::writeFile):
(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):
(WebCore::ZigZag::Reader::doReadUintHelper):
(WebCore::ZigZag::Reader::doReadUint32):
(WebCore::ZigZag::Reader::doReadUint64):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::trackBlobURL):
(WebCore::ScriptExecutionContext::revokeBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::createPublicURL):

  • html/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::url):

  • html/BlobRegistryImpl.cpp: Added.
  • html/BlobRegistryImpl.h: Added.
  • html/BlobStorageData.h: Added.
  • html/BlobURL.cpp: Added.
  • html/BlobURL.h: Added.
  • html/File.cpp:

(WebCore::File::File):

  • html/File.h:

(WebCore::File::create):

  • platform/BlobData.cpp: Added.
  • platform/BlobData.h: Added.
  • platform/BlobRegistry.h: Added.
4:52 PM Changeset in webkit [65101] by senorblanco@chromium.org
  • 6 edits in trunk/LayoutTests

2010-08-10 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.


Rebaselines a test for win & linux, removes it from test_expectations.

  • platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-win/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium/test_expectations.txt:
4:46 PM Changeset in webkit [65100] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-08-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SegmentedString should keep track of how many characters it consumes
​https://bugs.webkit.org/show_bug.cgi?id=43765

The easiest way to keep track of how many characters we've consumed
would be to increment a counter every time we advance, but that's too
slow. Instead, we keep track lazily and update our summary durning the
slow case of advance (which is sufficiently rare).

There's some subtly to how this works w.r.t. "unconsuming" characters
by pushing them back on the front of the segmented string. This isn't
really a "right answer" here because the notion of unconsuming input
isn't present in the API. This patch makes some assumptions about how
clients of this class use its API. In a future patch, we might want to
rename some of the method names to make this more explicit.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring):
  • platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::numberOfCharactersConsumed): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::numberOfCharactersConsumed):
3:32 PM Changeset in webkit [65099] by barraclough@apple.com
  • 16 edits
    1 delete in trunk

Bug 43816 - Remove UStringImpl
The class was actually removed a long time ago, replaced by StringImpl.
UStringImpl is just a typedef onto StringImpl. Remove this.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):

(JSC::JSString::resolveRope):
(JSC::JSString::replaceCharacter):

  • runtime/JSString.h:

(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):

  • runtime/JSStringBuilder.h:

(JSC::jsMakeNontrivialString):

  • runtime/RopeImpl.cpp:

(JSC::RopeImpl::derefFibersNonRecursive):

  • runtime/RopeImpl.h:

(JSC::RopeImpl::deref):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

  • runtime/UString.cpp:

(JSC::initializeUString):

  • runtime/UString.h:

(JSC::UString::adopt):
(JSC::tryMakeString):
(JSC::makeString):

  • runtime/UStringImpl.h: Removed.

WebCore:

Rubber stamped by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):

3:24 PM Changeset in webkit [65098] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-08-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

[Chromium/DRT] Enable saving layout test results.
​https://bugs.webkit.org/show_bug.cgi?id=43796

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more

parameters to the new-run-webkit-tests, including the name
of the test results server.

3:02 PM Changeset in webkit [65097] by senorblanco@chromium.org
  • 5 edits in trunk

2010-08-09 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Prefer the medium-quality (bilinear) image resampling for 2D canvas on
Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=43646


This is what the accelerated path is going to do,
so do it in the software path as well.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • platform/graphics/GraphicsContext.h:

2010-08-09 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Temporarily mark html/canvas/image-object-in-canvas.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=43646

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [65096] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-08-10 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Roll forward Chromium DEPS to r55584
​https://bugs.webkit.org/show_bug.cgi?id=43811

  • DEPS:
2:35 PM Changeset in webkit [65095] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Removing an element from an anonymous block causes crash
​https://bugs.webkit.org/show_bug.cgi?id=42309

Reviewed by Dave Hyatt.

WebCore:

There was a case where a continuation was added as a child, but if you asked
that child who is your parent, it would return the wrong answer.

The specific scenario was when a sibling of an element who was the start of a
continuation was present. Retrieving the parent object had then follow the sibling
chain and then follow the originating continuation chain.

Test: accessibility/removed-anonymous-block-child-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::nextSibling):

Fix erroneous comment

(WebCore::nextContinuation):
(WebCore::AccessibilityRenderObject::renderParentObject):

Handle unhandled continuation case.

(WebCore::AccessibilityRenderObject::addChildren):

ASSERT that the parentObject() is the same when adding a new child.

LayoutTests:

  • accessibility/removed-anonymous-block-child-causes-crash-expected.txt: Added.
  • accessibility/removed-anonymous-block-child-causes-crash.html: Added.
2:35 PM Changeset in webkit [65094] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-10 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Support appcache status change for Chrome
​https://bugs.webkit.org/show_bug.cgi?id=43531

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
2:27 PM Changeset in webkit [65093] by kbr@google.com
  • 5 edits in trunk/WebKit/chromium

2010-08-10 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Use Chromium OpenGL bindings rather than GLEW in WebGraphicsContextDefaultImpl
​https://bugs.webkit.org/show_bug.cgi?id=43754

Deleted per-platform OpenGL context management code, now
abstracted via GLContext. Built and tested in Chromium with
--in-process-webgl flag.

  • WebKit.gyp:
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
  • src/WebGraphicsContext3DDefaultImpl.h:
1:56 PM Changeset in webkit [65092] by jianli@chromium.org
  • 3 edits in trunk/WebKitTools

More chromium build fix.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::grantPermission):
(NotificationPresenter::show):
(NotificationPresenter::checkPermission):

1:47 PM Changeset in webkit [65091] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Make FastMalloc more portable.
​https://bugs.webkit.org/show_bug.cgi?id=41790

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_Central_FreeList::Populate): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
1:46 PM Changeset in webkit [65090] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Take checks for ruby base existence out of the ASSERTs.
​https://bugs.webkit.org/show_bug.cgi?id=43795

Test: fast/ruby/ruby-remove-no-base.html

  • rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::addChild): (WebCore::RenderRubyRun::removeChild):

2010-08-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Tests that removing a ruby child which causes merging of ruby base withe
a non existant base of the right sibling run does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=43795

  • fast/ruby/ruby-remove-no-base-expected.txt: Added.
  • fast/ruby/ruby-remove-no-base.html: Added.
1:44 PM Changeset in webkit [65089] by zmo@google.com
  • 8 edits in trunk

2010-08-06 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

texture functions should gen INVALID_OPERATION if no texture is bound
​https://bugs.webkit.org/show_bug.cgi?id=42907

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Check if a texture is bound to target. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::generateMipmap): Ditto. (WebCore::WebGLRenderingContext::getTexParameter): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texParameter): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTextureBinding): Check if target is valid and if a texture is bound to it.
  • html/canvas/WebGLRenderingContext.h: Declare validateTextureBinding().

2010-08-06 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

texture functions should gen INVALID_OPERATION if no texture is bound
​https://bugs.webkit.org/show_bug.cgi?id=42907

  • fast/canvas/webgl/gl-enum-tests-expected.txt: Need to bind a texture before testing tex-functions.
  • fast/canvas/webgl/gl-enum-tests.html: Ditto.
  • fast/canvas/webgl/null-object-behaviour-expected.txt: Test tex-functions when no texture is bound.
  • fast/canvas/webgl/null-object-behaviour.html: Ditto.
1:38 PM Changeset in webkit [65088] by jianli@chromium.org
  • 3 edits in trunk/WebKitTools

Chromium build fix.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.cpp:
1:29 PM Changeset in webkit [65087] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Sam Weinig.

[WINCE] Implement Path::currentPoint()
​https://bugs.webkit.org/show_bug.cgi?id=42927

  • platform/graphics/wince/PathWince.cpp: (WebCore::Path::currentPoint):
1:13 PM Changeset in webkit [65086] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-08-10 Ariya Hidayat <​ariya@sencha.com>

[Qt] Warning fix, remove reference to platform/text/StringImpl.h

  • WebCore.pro:
12:59 PM Changeset in webkit [65085] by jianli@chromium.org
  • 2 edits in trunk/WebKit/chromium

Another chromium build fix.

  • src/AssertMatchingEnums.cpp:
12:52 PM Changeset in webkit [65084] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix attempt. not reviewed

  • platform/text/TextBoundaries.cpp: use correct stringimplh include
12:06 PM Changeset in webkit [65083] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Chromium build fix.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontPlatformDataLinux.cpp:
11:57 AM Changeset in webkit [65082] by abarth@webkit.org
  • 16 edits
    2 adds in trunk

2010-08-10 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
​https://bugs.webkit.org/show_bug.cgi?id=42827.

Test: fast/events/popup-blocked-from-iframe-script.html

  • WebCore.order:
  • bindings/js/JSDOMBinding.cpp: (WebCore::processingUserGesture):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::domWindowAllowPopUp): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::anyPageIsProcessingUserGesture):
  • bindings/v8/ScriptController.h:
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture):

2010-08-10 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
​https://bugs.webkit.org/show_bug.cgi?id=42827

  • fast/events/popup-blocked-from-iframe-script-expected.txt: Added.
  • fast/events/popup-blocked-from-iframe-script.html: Added.
11:50 AM Changeset in webkit [65081] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by David Levin.

[WINCE] Buildfix for CE 6.0
​https://bugs.webkit.org/show_bug.cgi?id=43027

CE 6.0 doesn't define localtime in the system include files.

  • wtf/Platform.h: Include ce_time.h on all OS(WINCE).
11:39 AM Changeset in webkit [65080] by victorw@chromium.org
  • 3 edits in trunk/WebKitTools

2010-08-10 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

Update test results server merge logic so the aggregated
results and times are updated for tests that are
in aggragated json but not in incremental json.

Also update unittest to test this case.

​https://bugs.webkit.org/show_bug.cgi?id=43769

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
11:22 AM Changeset in webkit [65079] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix

  • platform/graphics/chromium/FontPlatformDataLinux.h:
11:22 AM Changeset in webkit [65078] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skipping editing/selection/selection-modify-crash.html (added by r65061) on gtk
because it has been crashing on gtk since r65061 and it doesn't crash on other platforms.

  • platform/gtk/Skipped:
10:45 AM Changeset in webkit [65077] by barraclough@apple.com
  • 228 edits
    1 move
    1 add
    4 deletes in trunk

Bug 43786 - Move AtomicStringHash from WebCore to WTF
Also remove deprecated string headers from WebCore/platform/text.

Rubber stamped by Sam Weinig.

JavaScriptCore:

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/AtomicString.h:
  • wtf/text/AtomicStringHash.h: Copied from WebCore/platform/text/AtomicStringHash.h.

WebCore:

  • ForwardingHeaders/wtf/text/AtomicStringHash.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  • bindings/cpp/WebDOMHTMLCollectionCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDOMMimeTypeArrayCustom.cpp:
  • bindings/js/JSDOMPluginArrayCustom.cpp:
  • bindings/js/JSDOMPluginCustom.cpp:
  • bindings/js/JSDOMStringMapCustom.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataGridColumnListCustom.cpp:
  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSNodeListCustom.cpp:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.h:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:
  • bridge/jni/v8/JavaClassV8.h:
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/CSSFontSelector.h:
  • css/CSSNamespace.h:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSParserValues.h:
  • css/CSSStyleSelector.h:
  • css/CSSVariablesDeclaration.h:
  • css/MediaFeatureNames.h:
  • css/MediaQueryExp.h:
  • css/WebKitCSSKeyframesRule.h:
  • dom/CustomEvent.h:
  • dom/Document.cpp:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/InputElement.h:
  • dom/MessagePort.cpp:
  • dom/MessagePort.h:
  • dom/NameNodeList.h:
  • dom/NodeRareData.h:
  • dom/QualifiedName.h:
  • dom/ScriptElement.cpp:
  • dom/SpaceSplitString.h:
  • dom/TagNodeList.h:
  • dom/XMLDocumentParser.h:
  • editing/EditorCommand.cpp:
  • history/mac/HistoryItemMac.mm:
  • html/BlobBuilder.cpp:
  • html/DataGridColumn.h:
  • html/DataGridColumnList.cpp:
  • html/HTMLDocument.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • html/LegacyPreloadScanner.cpp:
  • html/LegacyPreloadScanner.h:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorValues.h:
  • loader/Cache.h:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocLoader.h:
  • loader/ImageLoader.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconRecord.h:
  • loader/loader.h:
  • notifications/Notification.h:
  • page/FrameTree.h:
  • page/Page.cpp:
  • page/PageGroup.h:
  • page/SecurityOrigin.h:
  • page/Settings.h:
  • page/WindowFeatures.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CompositeAnimation.h:
  • platform/Cookie.h:
  • platform/KURL.cpp:
  • platform/KURLGoogle.cpp:
  • platform/KURLHash.h:
  • platform/Length.cpp:
  • platform/LinkHash.cpp:
  • platform/LinkHash.h:
  • platform/MIMETypeRegistry.cpp:
  • platform/MIMETypeRegistry.h:
  • platform/SchemeRegistry.h:
  • platform/ThreadGlobalData.cpp:
  • platform/ThreadGlobalData.h:
  • platform/cf/BinaryPropertyList.cpp:
  • platform/chromium/SearchPopupMenuChromium.cpp:
  • platform/efl/ClipboardEfl.cpp:
  • platform/efl/CookieJarEfl.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/FontFamily.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/cg/ImageSourceCGWin.cpp:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:
  • platform/graphics/chromium/FontCacheLinux.cpp:
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/filters/Filter.h:
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/win/FontCacheWin.cpp:
  • platform/graphics/win/FontPlatformDataCGWin.cpp:
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/graphics/win/WKCACFLayer.h:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/gtk/ClipboardGtk.cpp:
  • platform/gtk/DataObjectGtk.h:
  • platform/haiku/ClipboardHaiku.cpp:
  • platform/haiku/CookieJarHaiku.cpp:
  • platform/haiku/SearchPopupMenuHaiku.cpp:
  • platform/mac/SearchPopupMenuMac.mm:
  • platform/mac/ThreadCheck.mm:
  • platform/network/CredentialStorage.cpp:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/text/AtomicString.h: Removed.
  • platform/text/AtomicStringHash.h: Removed.
  • platform/text/AtomicStringImpl.h: Removed.
  • platform/text/AtomicStringKeyedMRUCache.h:
  • platform/text/StringBuilder.cpp:
  • platform/text/StringHash.h: Removed.
  • platform/text/StringImpl.h: Removed.
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/cf/StringImplCF.cpp:
  • platform/text/mac/HyphenationMac.mm:
  • platform/text/mac/StringImplMac.mm:
  • platform/text/transcoder/FontTranscoder.h:
  • platform/text/wince/TextCodecWinCE.cpp:
  • platform/win/BString.cpp:
  • platform/win/ClipboardWin.cpp:
  • platform/win/SearchPopupMenuWin.cpp:
  • platform/wince/SearchPopupMenuWince.cpp:
  • platform/wx/ClipboardWx.cpp:
  • plugins/DOMMimeTypeArray.cpp:
  • plugins/DOMPlugin.cpp:
  • plugins/DOMPluginArray.cpp:
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • rendering/RenderApplet.h:
  • rendering/RenderText.cpp:
  • rendering/style/BindingURI.h:
  • rendering/style/ContentData.cpp:
  • rendering/style/CounterContent.h:
  • rendering/style/CounterDirectives.h:
  • rendering/style/KeyframeList.h:
  • rendering/style/StyleRareInheritedData.h:
  • storage/AbstractDatabase.cpp:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseTracker.h:
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/OriginQuotaManager.h:
  • storage/OriginUsageRecord.h:
  • storage/SQLTransactionCoordinator.h:
  • storage/StorageAreaSync.h:
  • storage/StorageMap.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/chromium/QuotaTracker.h:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGDocumentExtensions.cpp:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGFitToViewBox.cpp:
  • svg/SVGLangSpace.h:
  • svg/animation/SMILTimeContainer.h:
  • svg/graphics/filters/SVGFilterBuilder.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:
  • websockets/WebSocketHandshake.cpp:
  • websockets/WebSocketHandshakeResponse.cpp:
  • wml/WMLPageState.h:
  • workers/AbstractWorker.h:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/Worker.h:
  • workers/WorkerContext.h:
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathExpressionNode.h:
  • xml/XPathNamespace.h:
  • xml/XPathParser.cpp:
  • xml/XSLTProcessor.h:

WebKit/chromium:

  • src/WebKit.cpp:
  • src/WebPageSerializerImpl.h:
  • src/WebString.cpp:

WebKit/gtk:

  • gdom/ConvertToGCharPrivate.h:

WebKit/wx:

  • WebEdit.cpp:
10:34 AM Changeset in webkit [65076] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-08-10 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Feature defines are out of sync between features.gypi and downstream feature_overrides.gypi
​https://bugs.webkit.org/show_bug.cgi?id=43756

This synchronizes the feature defines to what's currently downstream (at r55468).
The difference between the build.webkit.org bots and the chromium bots has
caused strange compilation failures lately.

  • features.gypi:
9:50 AM Changeset in webkit [65075] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-08-10 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Adding changes that escaped from r65072.

Web Inspector: move database processing to native layer.
​https://bugs.webkit.org/show_bug.cgi?id=43788

  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):
9:43 AM Changeset in webkit [65074] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-08-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Inputs of type 'search' have weird looking checkboxes instead of search/clear icons
​https://bugs.webkit.org/show_bug.cgi?id=43760

Draw appropriate GTK+ stock images for search/clear icons in search entries.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
9:31 AM Changeset in webkit [65073] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-10 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Qt build fix, follow up for r65072.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::releaseFrontendLifetimeAgents):
9:06 AM Changeset in webkit [65072] by pfeldman@chromium.org
  • 26 edits
    1 copy
    1 add in trunk/WebCore

2010-08-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move database processing to native layer.

​https://bugs.webkit.org/show_bug.cgi?id=43788

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::executeSQL):
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorStorageAgent.cpp: Added. (WebCore::): (WebCore::InspectorStorageAgent::InspectorStorageAgent): (WebCore::InspectorStorageAgent::~InspectorStorageAgent): (WebCore::InspectorStorageAgent::executeSQL): (WebCore::InspectorStorageAgent::clearFrontend):
  • inspector/InspectorStorageAgent.h: Added. (WebCore::InspectorStorageAgent::create): (WebCore::InspectorStorageAgent::frontend):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.sqlTransactionSucceeded): (WebInspector.sqlTransactionFailed):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished): (WebInspector.DatabaseQueryView.prototype._queryError):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
7:14 AM Changeset in webkit [65071] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-08-10 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

[V8] DeviceMotionEvent can not be used from JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=43785

This is tested by the existing tests fast/dom/DeviceMotion/create-event.html
and fast/dom/DeviceMotion/optional-event-properties.html.

  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
6:52 AM Changeset in webkit [65070] by abecsi@webkit.org
  • 7 edits
    3 adds in trunk

2010-08-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

Just build changes so no new tests.

  • WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
  • WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
  • features.pri: Added.

2010-08-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.

2010-08-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
  • WebKit2.pro: Build specification for the WebKit2 framework.
  • WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.
6:23 AM Changeset in webkit [65069] by yurys@chromium.org
  • 6 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of utility context
​https://bugs.webkit.org/show_bug.cgi?id=43787

  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
  • src/WebDevToolsAgentImpl.h:
5:42 AM Changeset in webkit [65068] by yurys@chromium.org
  • 8 edits in trunk

2010-08-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
​https://bugs.webkit.org/show_bug.cgi?id=43780

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
  • inspector/InspectorController.h: (WebCore::InspectorController::hasFrontend):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue):
  • inspector/InspectorDebuggerAgent.h:

2010-08-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
​https://bugs.webkit.org/show_bug.cgi?id=43780

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
4:34 AM Changeset in webkit [65067] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

Make sure NPAPI plugins get an initial setNPWindow on Mac

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=43782

  • plugins/mac/PluginViewMac.mm:
4:20 AM Changeset in webkit [65066] by steveblock@google.com
  • 3 edits
    2 adds in trunk/LayoutTests

2010-08-09 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Accelerometer tests need V8 results
​https://bugs.webkit.org/show_bug.cgi?id=43443

This patch adds V8-specific results for Android for the existing window-property.html test.

  • fast/dom/DeviceMotion/script-tests/window-property.js:
  • fast/dom/DeviceMotion/window-property-expected.txt:
  • platform/android-v8/fast/dom/DeviceMotion: Added.
  • platform/android-v8/fast/dom/DeviceMotion/window-property-expected.txt: Added.
4:12 AM Changeset in webkit [65065] by krit@webkit.org
  • 17 edits in trunk/WebCore

2010-08-10 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Use SVGPathParser to create SVG paths and to perform path animations
​https://bugs.webkit.org/show_bug.cgi?id=43696

Removed toString() functions in all SVGPathSeg* objects as well as toPath() in SVGPathSegList.
These hacks were used to create a SVG path data string or a platform path from a SVGPathSegList.
Use the new SVGPathParser instead.

Doesn't affect any tests.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::toPathData):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildPathFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSeg.cpp:
  • svg/SVGPathSeg.h:
  • svg/SVGPathSegArc.cpp:
  • svg/SVGPathSegArc.h:
  • svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter):
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • svg/SVGPathSegList.h:
3:49 AM Changeset in webkit [65064] by Csaba Osztrogonác
  • 5 edits
    2 deletes in trunk

2010-08-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65056.
​http://trac.webkit.org/changeset/65056
​https://bugs.webkit.org/show_bug.cgi?id=43773

"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):

2010-08-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65056.
​http://trac.webkit.org/changeset/65056
​https://bugs.webkit.org/show_bug.cgi?id=43773

"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).

  • fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Removed.
  • fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Removed.
3:13 AM Changeset in webkit [65063] by jorlow@chromium.org
  • 5 edits
    9 adds in trunk/WebKit/chromium

2010-08-10 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Implement chromium WebDeviceOrientationClient wrapper and have WebViewImpl get it from WebViewClient.
​https://bugs.webkit.org/show_bug.cgi?id=43258

Provide a DeviceOrientationClient to Page by means of a
DeviceOrientationClientProxy that proxies calls to
a WebDeviceOrientationClient, an interface that can be implemented
in the WebKit or Chromium layer. An implementation to be used for
layout tests, wrapping DeviceOrientationClientMock, is provided.

  • WebKit.gyp:
  • public/WebDeviceOrientation.h: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation):
  • public/WebDeviceOrientationClient.h: Added. (WebKit::WebDeviceOrientationClient::~WebDeviceOrientationClient):
  • public/WebDeviceOrientationClientMock.h: Added. (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock): (WebKit::WebDeviceOrientationClientMock::~WebDeviceOrientationClientMock):
  • public/WebDeviceOrientationController.h: Added. (WebKit::WebDeviceOrientationController::WebDeviceOrientationController):
  • public/WebViewClient.h: (WebKit::WebViewClient::deviceOrientationClient):
  • src/DeviceOrientationClientProxy.cpp: Added. (WebKit::DeviceOrientationClientProxy::setController): (WebKit::DeviceOrientationClientProxy::startUpdating): (WebKit::DeviceOrientationClientProxy::stopUpdating): (WebKit::DeviceOrientationClientProxy::lastOrientation):
  • src/DeviceOrientationClientProxy.h: Added. (WebKit::DeviceOrientationClientProxy::DeviceOrientationClientProxy):
  • src/WebDeviceOrientation.cpp: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation): (WebKit::WebDeviceOrientation::operator=): (WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):
  • src/WebDeviceOrientationClientMock.cpp: Added. (WebKit::WebDeviceOrientationClientMock::setController): (WebKit::WebDeviceOrientationClientMock::startUpdating): (WebKit::WebDeviceOrientationClientMock::stopUpdating): (WebKit::WebDeviceOrientationClientMock::lastOrientation): (WebKit::WebDeviceOrientationClientMock::setOrientation): (WebKit::WebDeviceOrientationClientMock::initialize): (WebKit::WebDeviceOrientationClientMock::reset):
  • src/WebDeviceOrientationController.cpp: Added. (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): (WebKit::WebDeviceOrientationController::controller):
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
3:08 AM Changeset in webkit [65062] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

2010-08-10 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Kent Tamura.

Iterate over :first-letter so that it will be included in innerText.
​https://bugs.webkit.org/show_bug.cgi?id=39863

Test: fast/dom/inner-text-first-letter.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::emitText):
  • editing/TextIterator.h:

2010-08-10 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Kent Tamura.

Iterate over :first-letter so that it will be included in innerText.
​https://bugs.webkit.org/show_bug.cgi?id=39863

  • fast/dom/inner-text-first-letter-expected.txt: Added.
  • fast/dom/inner-text-first-letter.html: Added.
2:26 AM Changeset in webkit [65061] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix crashes by SelectionController::modify().
​https://bugs.webkit.org/show_bug.cgi?id=43032

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/selection-modify-crash.html

  • editing/visible_units.cpp:

(WebCore::endOfDocument): Add NULL-check for document()->documentElement().

LayoutTests:

  • editing/selection/selection-modify-crash-expected.txt: Added.
  • editing/selection/selection-modify-crash.html: Added.
2:05 AM Changeset in webkit [65060] by hamaji@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64988.
​http://trac.webkit.org/changeset/64988
​https://bugs.webkit.org/show_bug.cgi?id=43775

"It seems to break chromium's ui_tests" (Requested by hamaji
on #webkit).

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
1:47 AM Changeset in webkit [65059] by krit@webkit.org
  • 15 edits
    2 adds in trunk/WebCore

2010-08-10 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add missing SVGPathSegList source for SVGPathParser
​https://bugs.webkit.org/show_bug.cgi?id=43691

Added SVGPathSegListSource to parse normalized or unaltered SVGPathSegLists and transform
them to either a SVG path string, or a SVGPathByteStream. This will be needed to synchronize
all SVGPathSegLists and the SVG path string of the 'd' attribute.
Refactored SVGPathSource code, to read concrete path segments instead of type/flag/coordinates
from the data sources. This is a further abstraction and seperates the reading of content from
the parsing and interpreting.

Doesn't affect any tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand): (WebCore::SVGPathByteStreamSource::parseMoveToSegment): (WebCore::SVGPathByteStreamSource::parseLineToSegment): (WebCore::SVGPathByteStreamSource::parseLineToHorizontalSegment): (WebCore::SVGPathByteStreamSource::parseLineToVerticalSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathByteStreamSource::parseArcToSegment):
  • svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
  • svg/SVGPathParser.cpp: (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment):
  • svg/SVGPathSegListSource.cpp: Added. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::~SVGPathSegListSource): (WebCore::SVGPathSegListSource::hasMoreData): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseLineToHorizontalSegment): (WebCore::SVGPathSegListSource::parseLineToVerticalSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathSegListSource::parseArcToSegment):
  • svg/SVGPathSegListSource.h: Added. (WebCore::SVGPathSegListSource::create): (WebCore::SVGPathSegListSource::moveToNextToken):
  • svg/SVGPathSource.h:
  • svg/SVGPathStringSource.cpp: (WebCore::SVGPathStringSource::parseMoveToSegment): (WebCore::SVGPathStringSource::parseLineToSegment): (WebCore::SVGPathStringSource::parseLineToHorizontalSegment): (WebCore::SVGPathStringSource::parseLineToVerticalSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathStringSource::parseArcToSegment):
  • svg/SVGPathStringSource.h:
1:41 AM Changeset in webkit [65058] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: small refactoring for CodeGeneratorInspector.
A number of push calls were replaced by embedded text.
Just for improve code readability.
​https://bugs.webkit.org/show_bug.cgi?id=43770

  • inspector/CodeGeneratorInspector.pm:
12:49 AM Changeset in webkit [65057] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Remove references to deleted header InspectorFrontend.h

  • src/WebDevToolsAgentImpl.cpp:
12:29 AM Changeset in webkit [65056] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In order to fix the insertAdjacentHTML I had to change behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.

  • fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
  • fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.

Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
    • This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
  • html/HTMLElement.cpp: (WebCore::contextElementForInsertion):
    • This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.

(WebCore::HTMLElement::insertAdjacentHTML):

  • Use the right contextElement now that we know how to compute it.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
    • This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.
12:25 AM Changeset in webkit [65055] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-10 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium compilation.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::frontendLoaded):
12:12 AM Changeset in webkit [65054] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-08-10 MORITA Hajime <​morrita@google.com>

Unreviewed test fix.

​https://bugs.webkit.org/show_bug.cgi?id=43771
[Chromium] Test: editing/selection/doubleclick-inline-first-last-contenteditable fails on win

Set platform selectTrailingWhitespaceEnabled false, which is true only on windows.

  • editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.