⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 12, 2010:

11:58 PM Changeset in webkit [65304] by yurys@chromium.org
  • 10 edits in trunk

2010-08-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow interrupting long running JS to execute inspector command
​https://bugs.webkit.org/show_bug.cgi?id=43900

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::): (WebCore::ScriptDebugServer::pause): (WebCore::ScriptDebugServer::interruptAndRun): (WebCore::ScriptDebugServer::runPendingTasks): (WebCore::ScriptDebugServer::handleV8DebugEvent):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Task::~Task):

2010-08-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow interrupting long running JS to execute inspector command
​https://bugs.webkit.org/show_bug.cgi?id=43900

  • public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::MessageDescriptor::~MessageDescriptor):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::shouldInterruptForMessage): (WebKit::WebDevToolsAgent::processPendingMessages):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DevTools.js:
11:49 PM Changeset in webkit [65303] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Refactoring the fpu code generator for the ARM port
​https://bugs.webkit.org/show_bug.cgi?id=43842

Reviewed by Gavin Barraclough.

Support up to 32 double precision registers, and the
recent VFP instruction formats. This patch is mainly
a style change which keeps the current functionality.

  • assembler/ARMAssembler.h:

(JSC::ARMRegisters::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::emitDoublePrecisionInst):
(JSC::ARMAssembler::emitSinglePrecisionInst):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vmov_vfp_r):
(JSC::ARMAssembler::vmov_arm_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

11:42 PM Changeset in webkit [65302] by Csaba Osztrogonác
  • 41 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpName): (JSC::printGlobalResolveInfo): (JSC::printStructureStubInfo): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures):
  • jsc.cpp: (functionPrint): (functionDebug): (runInteractive): (fillBufferWithContentsOfFile):
  • pcre/pcre_exec.cpp: (Histogram::~Histogram):
  • profiler/CallIdentifier.h: (JSC::CallIdentifier::c_str):
  • profiler/Profile.cpp: (JSC::Profile::debugPrintDataSampleStyle):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
  • profiler/ProfileNode.cpp: (JSC::ProfileNode::debugPrintData): (JSC::ProfileNode::debugPrintDataSampleStyle):
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • runtime/DateConversion.cpp: (JSC::parseDate):
  • runtime/Identifier.h: (JSC::Identifier::Identifier): (JSC::Identifier::toArrayIndex):
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::deleteProperty):
  • runtime/JSArray.h:
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::parseInt): (JSC::globalFuncJSCPrint):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/UString.cpp: (JSC::UString::toDouble): (JSC::UString::UTF8String):
  • runtime/UString.h: (JSC::UString::isNull): (JSC::UString::isEmpty): (JSC::UString::impl): (JSC::UString::cost): (JSC::UString::~UString): (JSC::UString::toArrayIndex):
  • wtf/text/WTFString.cpp: (WTF::String::utf8):
  • wtf/text/WTFString.h: (WTF::String::String): (WTF::String::isHashTableDeletedValue): (WTF::String::length): (WTF::String::operator[]): (WTF::String::isNull): (WTF::String::isEmpty): (WTF::String::impl):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebFrame.cpp: (wxWebFrame::RunScript):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
  • bridge/NP_jsobject.cpp: (_NPN_Enumerate):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
  • bridge/jni/JNIBridge.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::methodID):
  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::UTF8String): (JSC::Bindings::JavaParameter::type): (JSC::Bindings::JavaMethod::returnType):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::convertJObjectToValue):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JNIBridgeJSC.h: (JSC::Bindings::JavaField::type):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::UTF8String):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot): (JSC::RuntimeArray::getOwnPropertyDescriptor): (JSC::RuntimeArray::put):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebProcess/Plugins/JSNPObject.cpp: (WebKit::npIdentifierFromIdentifier):
  • WebProcess/Plugins/NPJSObject.cpp: (WebKit::NPJSObject::enumerate):
  • WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
11:35 PM Changeset in webkit [65301] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Fixed typo in inspector js.
Follow up to r65300.

  • inspector/front-end/inspector.js: (WebInspector.log.isLogAvailable):
11:31 PM Changeset in webkit [65300] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Make getPrototypes return objects, not names.
​https://bugs.webkit.org/show_bug.cgi?id=43934

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/inspector.js: (WebInspector.log):
10:43 PM Changeset in webkit [65299] by jamesr@google.com
  • 8 edits in trunk/WebCore

2010-08-12 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r65284 and r65288. Broke chromium compile.
​https://bugs.webkit.org/show_bug.cgi?id=43725
​http://trac.webkit.org/changeset/65284
​http://trac.webkit.org/changeset/65288

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
9:33 PM Changeset in webkit [65298] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add more files to the WebKit2 skipped list.

Reviewed by Gavin Barraclough.

  • platform/mac-wk2/Skipped:
9:27 PM Changeset in webkit [65297] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-08-12 James Robinson <​jamesr@chromium.org>

Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.

  • platform/chromium/test_expectations.txt:
9:09 PM Changeset in webkit [65296] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

8:58 PM Changeset in webkit [65295] by barraclough@apple.com
  • 41 edits in trunk

Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.

Reviewed by Sam Weinig

JavaScriptCore:

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • pcre/pcre_exec.cpp:

(Histogram::~Histogram):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/Identifier.h:

(JSC::Identifier::toStrictUInt32):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSC::toArrayIndex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/JNIBridge.cpp:

(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):

  • bridge/jni/JNIBridge.h:

(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JNIBridgeJSC.h:

(JSC::Bindings::JavaField::type):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::utf8):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

WebKit/wx:

  • WebFrame.cpp:

(wxWebFrame::RunScript):

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):

  • WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

8:47 PM Changeset in webkit [65294] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKitTools

WebKitTestRunner does not correctly resize WebView for W3C SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=43945

Reviewed by Sam Weinig.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.

8:46 PM Changeset in webkit [65293] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit2

WebKit2 needs to initialize SafariTheme
​https://bugs.webkit.org/show_bug.cgi?id=43901

Reviewed by Sam Weinig.

  • WebProcess/win/WebProcessMainWin.cpp:

(WebKit::initializeSafariTheme):
Copied from old WebKit.
(WebKit::WebProcessMain):
If we're using SafariTheme, initialize it.

8:21 PM Changeset in webkit [65292] by mjs@apple.com
  • 4 edits in trunk/WebKit2

2010-08-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

WebKit2 crashes when WebFrame outlives WebPage
​https://bugs.webkit.org/show_bug.cgi?id=43939

  • WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::page): Add this method, to allow WebFrame to retrieve its WebPage following WebCore pointers.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone). (WebKit::WebFrame::page): Don't use the data member, get it from WebCore. (WebKit::WebFrame::invalidate): Use method to get page() and null check. (WebKit::WebFrame::isMainFrame): ditto
  • WebProcess/WebPage/WebFrame.h:
8:11 PM Changeset in webkit [65291] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed, fixing the previous commit.

Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.

  • platform/chromium/test_expectations.txt:
8:05 PM Changeset in webkit [65290] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
editing/pasteboard/smart-paste-004.html reported by japhet.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [65289] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Eeerk! - revert accidentally committed changes in UString!

(JSC::UString::UString):

  • runtime/UString.h:
7:29 PM Changeset in webkit [65288] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative build fix for chromium bindings (someone added the old include style!).

  • bindings/v8/V8DOMWindowShell.h:
6:44 PM Changeset in webkit [65287] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-08-12 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] TextEvent class has to many flags
​https://bugs.webkit.org/show_bug.cgi?id=43893

Turned TextEvent::m_isLineBreak, TextEvent::m_isBacktab, TextEvent::m_isPaste
into single TextEvent::m_inputType enumeration.

No functional change. No new tests.

  • dom/TextEvent.cpp: (WebCore::TextEvent::selectInputType): (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::): (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
6:05 PM Changeset in webkit [65286] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

Change UString constructors to match those in WTF::String.
This changes behaviour of UString((char*)0) to create null
strings, akin to UString() rather than UString::empty().
(This matches String). Remove unused constructors from
UString, and add null-terminated UTF-16 constructor, to
match String. Move String's constructor into the .cpp to
match UString.

Reviewed by Sam Weinig

(JSC::DebuggerCallFrame::calculatedFunctionName):

  • runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createSingleCharacterString):

  • runtime/UString.cpp:

(JSC::UString::UString):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::swap):
(JSC::UString::adopt):
(JSC::UString::operator[]):

  • wtf/text/WTFString.h:

(WTF::String::String):
(WTF::String::adopt):
(WTF::String::operator[]):

5:12 PM Changeset in webkit [65285] by kbr@google.com
  • 5 edits
    4 deletes in trunk/WebCore

2010-08-12 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Delete obsolete CanvasNumberArray
​https://bugs.webkit.org/show_bug.cgi?id=38619

Deleted unreferenced code. Built WebKit and Chromium to test.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.mk:
  • bindings/js/JSCanvasNumberArrayCustom.cpp: Removed.
  • html/canvas/CanvasNumberArray.cpp: Removed.
  • html/canvas/CanvasNumberArray.h: Removed.
  • html/canvas/CanvasNumberArray.idl: Removed.
4:57 PM Changeset in webkit [65284] by antonm@chromium.org
  • 8 edits in trunk/WebCore

2010-08-12 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Create callbacks for named access of elements from document object on fly.
​https://bugs.webkit.org/show_bug.cgi?id=43725

That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.

This reapplies ​http://trac.webkit.org/changeset/60670 reverted with
​http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
4:30 PM Changeset in webkit [65283] by tony@chromium.org
  • 1 edit
    27 adds in trunk/LayoutTests

2010-08-12 Tony Chang <​tony@chromium.org>

Unreviewed, landing google-chrome linux 64 test results.

  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/google-chrome-linux64/svg/hixie/perf/001-expected.txt: Added.
  • platform/google-chrome-linux64/svg/hixie/perf/002-expected.txt: Added.
  • platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
4:26 PM Changeset in webkit [65282] by Dimitri Glazkov
  • 2 edits in trunk

2010-08-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Add more Chromium-related dependency directories to .gitignore.
​https://bugs.webkit.org/show_bug.cgi?id=43940

  • .gitignore: Added all existing that are created by update-webkit --chromium.
4:23 PM Changeset in webkit [65281] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2010-08-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
​https://bugs.webkit.org/show_bug.cgi?id=43813

This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
to lazy-attach.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): Added parent check.
  • html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
  • html/HTMLLinkElement.h: Ditto.
4:18 PM Changeset in webkit [65280] by jschuh@chromium.org
  • 4 edits in trunk

2010-08-12 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dumitru Daniliuc.

Clear PluginData's page pointer on page refresh
​https://bugs.webkit.org/show_bug.cgi?id=43888

Test: plugins/access-after-page-destroyed.html

  • page/Page.cpp: (WebCore::Page::refreshPlugins):

2010-08-12 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dumitru Daniliuc.

Clear PluginData's page pointer on page refresh
​https://bugs.webkit.org/show_bug.cgi?id=43888

  • plugins/access-after-page-destroyed.html:
4:14 PM Changeset in webkit [65279] by zmo@google.com
  • 5 edits in trunk

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
​https://bugs.webkit.org/show_bug.cgi?id=31842

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUnsignedLongParameter): Casting from int to unsigned long correctly.

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
​https://bugs.webkit.org/show_bug.cgi?id=31842

  • fast/canvas/webgl/gl-get-calls-expected.txt: Bring back the commented out STENCIL tests.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
4:11 PM MathML 3 testsuite results edited by François Sausset
(diff)
4:06 PM Changeset in webkit [65278] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: mimic FireBug's array detection.
​https://bugs.webkit.org/show_bug.cgi?id=30974

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
3:59 PM Changeset in webkit [65277] by zmo@google.com
  • 5 edits in trunk

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

regression in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=43873

  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::generateMipmapLevelInfo): should set m_needToUseBlackTexture to false if generateMipmapLevelInfo runs through successfully.

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

regression in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=43873

  • fast/canvas/webgl/texture-npot-expected.txt: Add more test cases on NPOT/POT texture behaviors.
  • fast/canvas/webgl/texture-npot.html: Ditto.
3:57 PM Changeset in webkit [65276] by ariya@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-08-12 Ariya Hidayat <​ariya@sencha.com>

Reviewed by David Hyatt.

[Qt] Split TransparencyLayer into its own header file.
​https://bugs.webkit.org/show_bug.cgi?id=43935

  • WebCore.pro: Include TransparencyLayer.h.
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/TransparencyLayer.h: Added. (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::TransparencyLayer::operator=):
3:53 PM Changeset in webkit [65275] by commit-queue@webkit.org
  • 24 edits in trunk

2010-08-12 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Update the tests to take into account padding changes for the mrow element.
​https://bugs.webkit.org/show_bug.cgi?id=43908

  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-08-12 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Horizontal padding should be 0 on mrow elements.
​https://bugs.webkit.org/show_bug.cgi?id=43908

Updated tests in /mathml

  • css/mathml.css: (mrow, mfenced): (mfenced):
3:42 PM Changeset in webkit [65274] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

Build break fix.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.

3:40 PM Changeset in webkit [65273] by aa@chromium.org
  • 9 edits in trunk

2010-08-12 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
  • dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
  • page/PageGroup.h:
  • page/UserStyleSheet.h: (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):

2010-08-12 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):
3:32 PM Changeset in webkit [65272] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix qt build break.

  • html/ThreadableBlobRegistry.cpp:

(WebCore::postTaskToMainThread):

3:16 PM Changeset in webkit [65271] by jianli@chromium.org
  • 13 edits
    2 adds in trunk/WebCore

Add ThreadableBlobRegistry to support calling BlobRegistry methods in
main thread.
​https://bugs.webkit.org/show_bug.cgi?id=43874

Reviewed by David Levin.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::addBlob):
(WebCore::ScriptExecutionContext::removeBlob):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::contextDestroyed):

  • html/Blob.h:
  • html/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::unregisterBlobURL):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):

  • html/ThreadableBlobRegistry.cpp: Added.
  • html/ThreadableBlobRegistry.h: Added.
3:03 PM Changeset in webkit [65270] by jhoneycutt@apple.com
  • 14 edits
    2 copies
    1 add in trunk

WebKitTestRunner needs to run tests without using native controls
​https://bugs.webkit.org/show_bug.cgi?id=43772

Reviewed by Sam Weinig.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add a new message.

  • UIProcess/API/C/win/WKContextPrivateWin.h: Added.

Declare WKContextSetShouldPaintNativeControls().

  • UIProcess/API/C/win/WKContextWin.cpp: Added.

(WKContextSetShouldPaintNativeControls):
Call the WebContext's setShouldPaintNativeControls().

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
Initialize m_shouldPaintNativeControls.
(WebKit::WebContext::ensureWebProcess):
If we created a web process, call platformSetUpWebProcess().

  • UIProcess/WebContext.h:

Declare new functions and a member to store whether we should paint
native controls.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformSetUpWebProcess):
Stubbed.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::setShouldPaintNativeControls):
Set m_shouldPaintNativeControls. If we have a valid web process, send a
SetShouldPaintNativeControls message.
(WebKit::WebContext::platformSetUpWebProcess):
Send a SetShouldPaintNativeControls message.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
If this is a SetShouldPaintNativeControls message, decode the argument,
and call Settings::setShouldPaintNativeControls().

  • win/WebKit2.vcproj:

Add WKContextPrivateWin.h and WKContextWin.cpp to project.

  • win/WebKit2Generated.make:

Copy WKContextPrivateWin.h.

WebKitTools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
Call platformInitializeContext().

  • WebKitTestRunner/TestController.h:

Declare platformInitializeContext().

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitializeContext):
Stubbed.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.

2:55 PM Changeset in webkit [65269] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

generate-bindings.pl should generate warning free code
​https://bugs.webkit.org/show_bug.cgi?id=43353

bindings/scripts/CodeGeneratorJS.pm: Suggested parentheses added around && within
2:49 PM Changeset in webkit [65268] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore
  • runtime/UString.h: Removed unneccessary #include.

Reviewed by NOBODY (build fix).

2:28 PM Changeset in webkit [65267] by weinig@apple.com
  • 14 edits
    2 deletes in trunk/WebKitTools

WebKitTestRunner should be more aggressive about ensuring consistent state between tests
​https://bugs.webkit.org/show_bug.cgi?id=43653

Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/StringFunctions.h:

(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

  • WebKitTestRunner/TestInvocation.h:

Move resetting code to TestController.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::runUntil):

  • WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::runUntil):

  • WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Move runUntil to TestController.

2:20 PM Changeset in webkit [65266] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.

Reviewed by Sam Weinig

  • runtime/UString.cpp:

(JSC::UString::ascii):

  • runtime/UString.h:

(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):

2:06 PM Changeset in webkit [65265] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

merge MarkupAccumulator and MarkupAccumulatorWrapper
​https://bugs.webkit.org/show_bug.cgi?id=43834

Removed MarkupAccumulator and added serializeNodesWithNamespaces to use MarkupAccumulatorWrapper
in both versions of createMarkup. Accumulation of nodes done manually in serializeNodes is
now done by MarkupAccumulatorWrapper as done in the original MarkupAccumulator.

No new tests added since this is a cleanup.

  • editing/markup.cpp: (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Takes vector of nodes and set it to m_nodes. (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Adds node to m_nodes. (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Adds node to m_nodes. (WebCore::serializeNodes): Adding node to nodes is moved into MarkupAccumulatorWrapper. (WebCore::createMarkup): Instantiates MarkupAccumulatorWrapper. (WebCore::serializeNodesWithNamespaces): Renamed from MarkupAccumulator::appendMarkup.
1:28 PM Changeset in webkit [65264] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

[Qt] Fix warnings: unknown conversion type character 'l' in format
​https://bugs.webkit.org/show_bug.cgi?id=43359

Qt port doesn't call any printf in String::format(...), consequently
using attribute((format(printf,m,n))) is incorrect and causes
false positive warnings on Windows if you build with MinGW.

Qt port calls QString::vsprintf(...) , which is platform
independent, and handles %lli, %llu and %llx on all platforms.
(​http://trac.webkit.org/changeset/35712)

  • wtf/text/WTFString.h:
1:05 PM Changeset in webkit [65263] by hclam@chromium.org
  • 17 edits in trunk/LayoutTests

Rebaselining the test results for media controls on Mac to fix
a regression.

Submitted for Victoria Kirst (​vrk@google.com).

Reviewed by David Levin.

  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
12:43 PM BuildingQtOnLinux edited by Ademar Reis
install dependencies on fedora (diff)
12:16 PM Changeset in webkit [65262] by demarchi@webkit.org
  • 53 edits
    4 adds
    2 deletes in trunk/WebKit/efl

2010-08-11 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Adding new theme for widgets.
​https://bugs.webkit.org/show_bug.cgi?id=43860

Original theme was there for a long time. This is a new
fresh one.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/button/button.edc:
  • DefaultTheme/widget/button/img_button_focus.png:
  • DefaultTheme/widget/button/img_button_hover.png:
  • DefaultTheme/widget/button/img_button_normal.png:
  • DefaultTheme/widget/button/img_button_press.png:
  • DefaultTheme/widget/check/check.edc:
  • DefaultTheme/widget/check/img_check_off.png:
  • DefaultTheme/widget/check/img_check_off_focus.png:
  • DefaultTheme/widget/check/img_check_off_hover.png:
  • DefaultTheme/widget/check/img_check_on.png:
  • DefaultTheme/widget/check/img_check_on_focus.png:
  • DefaultTheme/widget/check/img_check_on_hover.png:
  • DefaultTheme/widget/combo/combo.edc:
  • DefaultTheme/widget/combo/combo_focus.png:
  • DefaultTheme/widget/combo/combo_focus_button.png:
  • DefaultTheme/widget/combo/combo_hover.png:
  • DefaultTheme/widget/combo/combo_hover_button.png:
  • DefaultTheme/widget/combo/combo_normal.png:
  • DefaultTheme/widget/combo/combo_normal_button.png:
  • DefaultTheme/widget/combo/combo_press.png:
  • DefaultTheme/widget/combo/combo_press_button.png:
  • DefaultTheme/widget/combo/icon.png:
  • DefaultTheme/widget/entry/img_focused.png:
  • DefaultTheme/widget/entry/img_hovered.png:
  • DefaultTheme/widget/entry/img_normal.png:
  • DefaultTheme/widget/file/file_focus.png:
  • DefaultTheme/widget/file/file_hover.png:
  • DefaultTheme/widget/file/file_normal.png:
  • DefaultTheme/widget/file/file_press.png:
  • DefaultTheme/widget/radio/img_radio_off.png:
  • DefaultTheme/widget/radio/img_radio_off_focus.png:
  • DefaultTheme/widget/radio/img_radio_off_hover.png:
  • DefaultTheme/widget/radio/img_radio_on.png:
  • DefaultTheme/widget/radio/img_radio_on_focus.png:
  • DefaultTheme/widget/radio/img_radio_on_hover.png:
  • DefaultTheme/widget/radio/radio.edc:
  • DefaultTheme/widget/scrollbar/scrollbar.edc:
  • DefaultTheme/widget/scrollbar/scrollbar_h.png:
  • DefaultTheme/widget/scrollbar/scrollbar_hilight.png: Removed.
  • DefaultTheme/widget/scrollbar/scrollbar_knob_h.png:
  • DefaultTheme/widget/scrollbar/scrollbar_knob_v.png:
  • DefaultTheme/widget/scrollbar/scrollbar_v.png:
  • DefaultTheme/widget/search/cancel/cancel_normal_button2.png:
  • DefaultTheme/widget/search/decoration/decoration_normal_button.png:
  • DefaultTheme/widget/search/field/field_focused.png:
  • DefaultTheme/widget/search/field/field_hovered.png:
  • DefaultTheme/widget/search/field/field_normal.png:
  • DefaultTheme/widget/slider/slider.edc:
  • DefaultTheme/widget/slider/slider_fill_h.png: Added.
  • DefaultTheme/widget/slider/slider_fill_v.png: Added.
  • DefaultTheme/widget/slider/slider_h.png:
  • DefaultTheme/widget/slider/slider_hilight.png: Removed.
  • DefaultTheme/widget/slider/slider_knob_h.png:
  • DefaultTheme/widget/slider/slider_knob_press_h.png: Added.
  • DefaultTheme/widget/slider/slider_knob_press_v.png: Added.
  • DefaultTheme/widget/slider/slider_knob_v.png:
  • DefaultTheme/widget/slider/slider_v.png:
12:13 PM Changeset in webkit [65261] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-12 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
11:22 AM Changeset in webkit [65260] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-12 Gabor Loki <​loki@webkit.org>

Reviewed by Geoffrey Garen.

Fix the array subscript is above array bounds warning in ByteArray on ARM.
​https://bugs.webkit.org/show_bug.cgi?id=43358

The warning is very similar to this one: ​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861

  • wtf/ByteArray.cpp: (WTF::ByteArray::create):
11:04 AM Changeset in webkit [65259] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Remove a duplicate linux debug expectation.

  • platform/chromium/test_expectations.txt:
10:51 AM Changeset in webkit [65258] by benm@google.com
  • 2 edits in trunk/WebCore

2010-08-12 Ben Murdoch <​benm@google.com>

Reviewed by Pavel Feldman.

InspectorController.h missing InspectorObject forward declaration
​https://bugs.webkit.org/show_bug.cgi?id=43913

Build fix so no new tests.

  • inspector/InspectorController.h: Adds the necessary forward declaration.
10:47 AM Changeset in webkit [65257] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk

Add file I forgot to add in r65255.

10:39 AM Changeset in webkit [65256] by demarchi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [65255] by kov@webkit.org
  • 10 edits in trunk

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

  • GNUmakefile.am: GSettings rules.
  • configure.ac: GSettings infrastructure, and check if we should use it by looking for an appropriate version of GIO.

JavaScriptCore

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

  • wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our GSettings support. (WTF::refGPtr): (WTF::derefGPtr):
  • wtf/gobject/GRefPtr.h:

WebKit/gtk

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

Use GSettings to save/restore settings used by the Web Inspector.
A few helper functions were added to have settings that use
boolean values be actual booleans, and also to conform with the
GSettings naming requirements for keys.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::toGSettingName): (WebKit::truthStringFromVariant): (WebKit::variantFromTruthString): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
  • org.webkit.gtk.gschema.xml: Added.
  • webkit/webkitprivate.cpp: (inspectorGSettings): (webkit_init):
  • webkit/webkitprivate.h:
10:32 AM Changeset in webkit [65254] by commit-queue@webkit.org
  • 2 edits
    1 copy
    1 delete in trunk/WebKitTools

2010-08-12 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

Merge pretty printers for gdb.
​https://bugs.webkit.org/show_bug.cgi?id=43850

We need to update webcore.py because basic string classes have moved to WTF from WebCore.
It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
webcore.py is left for backward compatibility.

  • gdb/webcore.py:
  • gdb/webkit.py: Added.
  • gdb/wtf.py: Removed.
10:16 AM Changeset in webkit [65253] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Removing unused macro GENERATE_EDJ.

  • cmake/WebKitEfl.cmake:

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Adding theme source files and images as dependencies of the theme.

  • CMakeListsEfl.txt:
10:11 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
(diff)
10:10 AM MathML Goals edited by alex@milowski.com
(diff)
10:10 AM MathML Goals edited by alex@milowski.com
(diff)
10:03 AM Changeset in webkit [65252] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Comment out svg/hittest/svg-rect-hit.html, as the test
was not landed with the relevant patch.

  • platform/chromium/test_expectations.txt:
10:02 AM MathML edited by alex@milowski.com
(diff)
10:00 AM MathML Status edited by alex@milowski.com
(diff)
9:59 AM Changeset in webkit [65251] by johnnyg@google.com
  • 3 edits in trunk/WebKit/chromium

2010-08-12 John Gregg <​johnnyg@google.com>

Reviewed by Kent Tamura.

[chromium] Add Notification::detachPresenter to the WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=43659

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::detachPresenter):
9:38 AM MathML edited by alex@milowski.com
(diff)
9:35 AM MathML edited by alex@milowski.com
(diff)
9:33 AM Changeset in webkit [65250] by tony@chromium.org
  • 4 edits
    2 adds in trunk/WebKitTools

2010-08-11 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] add google-chrome layout test result directories
​https://bugs.webkit.org/show_bug.cgi?id=43889

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
9:32 AM MathML Status created by alex@milowski.com
9:20 AM MathML edited by alex@milowski.com
(diff)
9:19 AM MathML edited by alex@milowski.com
(diff)
8:58 AM Changeset in webkit [65249] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-12 Hui Huang <​hui.2.huang@nokia.com>

Reviewed by Eric Seidel.

m_windowRect is not updated because parent of PluginView is not
set when updatePluginWidget is called. plugin gets wrong window
size on setwindow.
​https://bugs.webkit.org/show_bug.cgi?id=43635

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setParent):
8:37 AM Changeset in webkit [65248] by pfeldman@chromium.org
  • 27 edits
    1 add
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, re-apply r65241 and 65243.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

8:26 AM Changeset in webkit [65247] by senorblanco@chromium.org
  • 8 edits in trunk

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
8:11 AM Changeset in webkit [65246] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65225.
​http://trac.webkit.org/changeset/65225
​https://bugs.webkit.org/show_bug.cgi?id=43918

Broke EFL port build (Requested by acidx on #webkit).

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
8:04 AM Changeset in webkit [65245] by pfeldman@chromium.org
  • 26 edits
    1 add
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.

7:38 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:20 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:11 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:01 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:40 AM Changeset in webkit [65244] by Nate Chapin
  • 2 edits
    3 adds in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Update chromium's test_expectations.txt and provide new baselines for
​http://trac.webkit.org/changeset/65229.

(Text-only baseline for win/linux because there are real regressions in the
image results. See ​https://bugs.webkit.org/show_bug.cgi?id=43912)

  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:38 AM Changeset in webkit [65243] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Adding the file missing in r65241.

6:37 AM Changeset in webkit [65242] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

The scratch register should be saved in YARR with ARM JIT
​https://bugs.webkit.org/show_bug.cgi?id=43910

Reviewed by Simon Hausmann.

Reported by Jocelyn Turcotte.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):

6:31 AM Changeset in webkit [65241] by pfeldman@chromium.org
  • 26 edits
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format): (WebInspector.ConsoleCommandResult):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/ObjectProxy.js: Removed.
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromErrorMessage): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder): (WebInspector.RemoteObjectProperty):
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
  • inspector/front-end/utilities.js:

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

  • inspector/console-dir-expected.txt:
  • inspector/console-dir-global.html:
  • inspector/console-dir.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
6:30 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:27 AM Changeset in webkit [65240] by benm@google.com
  • 2 edits in trunk/WebCore

2010-08-12 Ben Murdoch <​benm@google.com>

Reviewed by Steve Block.

V8 code generator does not add V8BindingMacros.h include in all places it is needed
​https://bugs.webkit.org/show_bug.cgi?id=43907

Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
macro.

Build fix so no new tests.

  • bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
6:23 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:09 AM Changeset in webkit [65239] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-08-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed.

Media test baseline forgotten in r65224.

  • platform/gtk/media/audio-no-installed-engines-expected.txt: Added.
6:04 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:47 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:37 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:36 AM Changeset in webkit [65238] by hamaji@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65181.
​http://trac.webkit.org/changeset/65181
​https://bugs.webkit.org/show_bug.cgi?id=43909

It broke 35 layout tests fail on chromium-win (Requested by
hamaji on #webkit).

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
5:31 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:04 AM Changeset in webkit [65237] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

  • platform/chromium/test_expectations.txt: Two failing video related tests.
5:00 AM Changeset in webkit [65236] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] animations/suspend-resume-animation.html fails
​https://bugs.webkit.org/show_bug.cgi?id=43905

  • platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.
4:52 AM Changeset in webkit [65235] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

  • platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac
4:44 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:37 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:10 AM Changeset in webkit [65234] by jorlow@chromium.org
  • 19 edits
    2 deletes in trunk

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/GroupSettings.cpp: Removed.
  • page/GroupSettings.h: Removed.
  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
  • page/PageGroup.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota): (WebCore::Settings::setLocalStorageDatabasePath):
  • page/Settings.h: (WebCore::Settings::localStorageQuota): (WebCore::Settings::localStorageDatabasePath):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView.cpp: (WebView::initWithFrame):
3:37 AM Changeset in webkit [65233] by Nikolas Zimmermann
  • 1 edit
    1 delete in trunk/LayoutTests

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Delete a test that slipped in by accident.

  • svg/zoom/page/zoom-mask.svg: Removed.
3:30 AM Changeset in webkit [65232] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.

  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
  • rendering/SVGImageBufferTools.h:
3:27 AM Changeset in webkit [65231] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix.

  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
3:21 AM Changeset in webkit [65230] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/win

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix. Matches solutions in qt and mac ports for
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView.cpp: (WebView::initWithFrame):
3:11 AM Changeset in webkit [65229] by Nikolas Zimmermann
  • 18 edits
    7 adds in trunk

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
Clippers, Patterns and Filters remain to be converted.

Test: svg/zoom/page/zoom-mask-with-percentages.svg

  • Android.mk: Add SVGImageBufferTools.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderSVGAllInOne.cpp: Ditto.
  • rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class. (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more. (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/SVGImageBufferTools.cpp: Added. (WebCore::SVGImageBufferTools::absoluteTransformFromContext): (WebCore::SVGImageBufferTools::createImageBuffer): (WebCore::SVGImageBufferTools::clipToImageBuffer):
  • rendering/SVGImageBufferTools.h: Added. (WebCore::SVGImageBufferTools::SVGImageBufferTools): (WebCore::SVGImageBufferTools::~SVGImageBufferTools):

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
Add new test covering zooming into masks, to show that it doesn't pixelate anymore.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • svg/zoom/page/zoom-mask-with-percentages.svg: Added.
3:03 AM Changeset in webkit [65228] by jorlow@chromium.org
  • 17 edits
    2 adds in trunk

2010-08-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move the 2 group-wide local storage settings there, and
add a new setting for IndexedDB's path (which is prompting this change).

No behavior has changed, so no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
  • page/PageGroup.h: (WebCore::PageGroup::groupSettings):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
  • page/Settings.h:

2010-08-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Change WebView to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but we can't really change the API at this point.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):

2010-08-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Change WebSettings to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but I don't see how we can change the API at this point.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2:43 AM Changeset in webkit [65227] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Decode images directly to QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=40797

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.

Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.

This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

2:41 AM Changeset in webkit [65226] by bulach@chromium.org
  • 12 edits in trunk

2010-07-14 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
​https://bugs.webkit.org/show_bug.cgi?id=42278

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js: (createEventHelper): splits event creation so that we can test without init. (testInitEvent): adds test for OverflowEvent creation.

2010-07-14 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
​https://bugs.webkit.org/show_bug.cgi?id=42278

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

Tests: idls should generate valid code.

  • dom/Node.h: (WebCore::Node::):
  • dom/Node.idl:
  • dom/OverflowEvent.h: (WebCore::OverflowEvent::):
  • dom/OverflowEvent.idl:
  • html/FileReader.cpp: (WebCore::FileReader::readyState):
  • html/FileReader.h: (WebCore::FileReader::):
  • html/FileReader.idl:
1:50 AM Changeset in webkit [65225] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-12 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Cleanup generator code.
​https://bugs.webkit.org/show_bug.cgi?id=39164

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
1:24 AM Changeset in webkit [65224] by Philippe Normand
  • 2 edits
    8 adds in trunk/LayoutTests

2010-08-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] new media tests baselines needed
​https://bugs.webkit.org/show_bug.cgi?id=42444

Visually check those tests, they seemed fine to me so I added
their baselines.

  • platform/gtk/Skipped:
  • platform/gtk/media/audio-controls-rendering-expected.txt: Added.
  • platform/gtk/media/video-display-toggle-expected.txt: Added.
  • platform/gtk/media/video-empty-source-expected.txt: Added.
  • platform/gtk/media/video-layer-crash-expected.txt: Added.
  • platform/gtk/media/video-no-audio-expected.txt: Added.
  • platform/gtk/media/video-transformed-expected.txt: Added.
  • platform/gtk/media/video-zoom-controls-expected.txt: Added.
  • platform/gtk/media/video-zoom-expected.txt: Added.
1:06 AM Changeset in webkit [65223] by alex
  • 2 edits in trunk/WebCore

2010-08-12 Alejandro G. Castro <​alex@igalia.com>

Reviewed by David Levin.

The #if clause enabling a feature should avoid the all includes of
the feature
​https://bugs.webkit.org/show_bug.cgi?id=43866

Modified the position of the guard to avoid including all the
headers if the feature controlling the guard is not enabled.

  • dom/make_names.pl:
12:18 AM Changeset in webkit [65222] by commit-queue@webkit.org
  • 8 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65221.
​http://trac.webkit.org/changeset/65221
​https://bugs.webkit.org/show_bug.cgi?id=43896

Broke snow leopard build. (Requested by dave_levin on
#webkit).

  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65221.
​http://trac.webkit.org/changeset/65221
​https://bugs.webkit.org/show_bug.cgi?id=43896

Broke snow leopard build. (Requested by dave_levin on
#webkit).

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:
12:00 AM Changeset in webkit [65221] by senorblanco@chromium.org
  • 8 edits in trunk

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
  • src/WebGraphicsContext3DDefaultImpl.h:

Aug 11, 2010:

11:42 PM Changeset in webkit [65220] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-08-11 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Handle clicks and recognition events for the speech input button
​https://bugs.webkit.org/show_bug.cgi?id=43857

  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton): Selects the image based on current state.
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::set_state): Switch to a new state and update the UI. (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
  • rendering/TextControlInnerElements.h: (WebCore::InputFieldSpeechButtonElement::): (WebCore::InputFieldSpeechButtonElement::state):
11:31 PM Changeset in webkit [65219] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION(65135): format specifier warnings
​https://bugs.webkit.org/show_bug.cgi?id=43876

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu. (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.
11:02 PM Changeset in webkit [65218] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in bindings/cpp.

10:50 PM Changeset in webkit [65217] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Make PendingScript copyable so that it can be stored in containers
​https://bugs.webkit.org/show_bug.cgi?id=43875

This will be useful for storing PendingScripts in a Vector or Deque for
async and defer scripts.

No new tests because no functional changes.

  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
9:35 PM Changeset in webkit [65216] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Disable accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=43894

Disable accelerated compositing because DRT is not ready for
it. This change fixes hundreds of test crashes on Windows and
Linux.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
8:56 PM Changeset in webkit [65215] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-11 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Fixing a regression in the UI for Mac default audio/video controls.
​https://bugs.webkit.org/show_bug.cgi?id=43750

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
8:53 PM Changeset in webkit [65214] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add more files to the WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
8:13 PM Changeset in webkit [65213] by abarth@webkit.org
  • 5 edits in trunk

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

  • html5lib/runner-expected-html5.txt:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
HTMLElement::createContextualFragment that interferes with the new
HTMLTreeBuilder. Doing that exposes the above ASSERT, which I've fixed
in this patch too. Fixing that ASSERT involved a small refactoring in
ExternalCharacterTokenBuffer.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::createContextualFragment):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): (WebCore::HTMLTreeBuilder::processCharacterBuffer):
7:55 PM Changeset in webkit [65212] by abarth@webkit.org
  • 4 edits in trunk

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Conditionalize wrong fragment parsing code to pass more HTML5lib tests
​https://bugs.webkit.org/show_bug.cgi?id=43877

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Conditionalize wrong fragment parsing code to pass more HTML5lib tests
​https://bugs.webkit.org/show_bug.cgi?id=43877

This code exists to support the LegacyHTMLTreeBuilder. Unfortunately,
it causes problems for the new HTMLTreeBuilder (which is more
self-contained).

  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
7:37 PM Changeset in webkit [65211] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
​https://bugs.webkit.org/show_bug.cgi?id=40725

Qt and Tiger seem to have encoding problems that swallow the --
characters that terminate the comment. We can avoid those problems by
inserting a space before the -->. We're losing coverage of these
issues, but I'm not sure we should be in the business of debugging
these encoders unless there's a security problem.

Thanks to ap for investigating and finding this workaround.

  • fast/encoding/japanese-encoding-mix.html:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
7:36 PM Changeset in webkit [65210] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Add SPI to stop loading from the InjectedBundle.

Reviewed by Gavin Barraclough.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStopLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.h:
7:09 PM Changeset in webkit [65209] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-08-11 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Last Hangul letter is typed again when a composition is finished with mouse press
​https://bugs.webkit.org/show_bug.cgi?id=40518

When a mouse press fires during a IME composition, the current composition character
can be entered twice at the previous editing position and a new editing position.
Because the IME commit signal is emitted after the mouse press event.
This patch allows to prevent the commit signal during a composition when a mouse press fires.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit. (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires. (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Call handleInputMethodMousePress()
7:05 PM Changeset in webkit [65208] by rniwa@webkit.org
  • 8 edits
    3 adds in trunk

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Can't unbold text in div in font-weight span
​https://bugs.webkit.org/show_bug.cgi?id=26871

The bug was caused by removeInlineStyle not being able to include styled inline nodes around the start.
Solved this problem by pushing down all inline styles instead of just text-decorations.
This approach allows removeInlineStyle to remove styled ancestors properly and generates compact markups.

Test: editing/style/push-down-inline-styles.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): No longer removes attributes or node when mode == RemoveNone. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement to determine the highest ancestor whose style needs to be pushed down. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Renamed from extractTextDecorationStyle. Extracts all inline CSS properties specified instead of just text decorations. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Renamed from applyTextDecorationStyle. Applies inline styles using addInlineStyleIfNeeded or adds inline CSS values. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Renamed from pushDownTextDecorationStyleAroundNode. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode.
  • editing/ApplyStyleCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Prevents moveParagraph from preserving the style of an empty paragraph when merged with the previous paragraph because we don't use that style anyways.

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Can't unbold text in div in font-weight span
​https://bugs.webkit.org/show_bug.cgi?id=26871

Added a test to push down inline styles to the leaves of DOM tree.

  • editing/deleting/delete-br-011-expected.txt: Removed redundant style spans.
  • editing/execCommand/empty-span-removal-expected.txt: Removed a span without any attributes.
  • editing/style/push-down-inline-styles-expected.txt: Added.
  • editing/style/push-down-inline-styles.html: Added.
  • editing/style/script-tests/push-down-inline-styles.js: Added. (testSingleToggle):
6:56 PM Changeset in webkit [65207] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

6:50 PM Changeset in webkit [65206] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt: http/tests/storage/callbacks-are-called-in-correct-context.html is SLOW, not PASS TIMEOUT
6:27 PM Changeset in webkit [65205] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Ariya Hidayat.

Remove dead code in CSSStyleSelector.
​https://bugs.webkit.org/show_bug.cgi?id=43805

  • css/CSSStyleSelector.cpp: Remove some debugging code that was compiled out.
6:24 PM Changeset in webkit [65204] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: isNativeCheckbox does not work as advertised
​https://bugs.webkit.org/show_bug.cgi?id=43872

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isInputImage):

Only say it's an input image if its role has not been overriden

(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):

  • dom/InputElement.h:

Add methods to query if it's a checkbox or radio button type element.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
5:45 PM Changeset in webkit [65203] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt: Mark http/tests/storage/callbacks-are-called-in-correct-context.html as flaky.
5:39 PM Changeset in webkit [65202] by weinig@apple.com
  • 2 edits in trunk/WebKit2

WKPageStopLoading always asserts

Reviewed by Gavin Barraclough.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage): Switch break to return, break made us
hit the ASSERT_NOT_REACHED at the end of the function.

5:31 PM Changeset in webkit [65201] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
which means isNaN(new Date("")) should return true.
​https://bugs.webkit.org/show_bug.cgi?id=43793
Tests: fast/js/date-constructor.html

  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::resetDateCache):

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
​https://bugs.webkit.org/show_bug.cgi?id=43793

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
5:12 PM Changeset in webkit [65200] by kbr@google.com
  • 38 edits in trunk

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Remove obsolete WebGLArray type names
​https://bugs.webkit.org/show_bug.cgi?id=43885

Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.

  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.idl:

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Remove obsolete WebGLArray type names
​https://bugs.webkit.org/show_bug.cgi?id=43885

Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.

  • compositing/webgl/webgl-reflection.html:
  • fast/canvas/webgl/array-get-and-set-method-removal.html:
  • fast/canvas/webgl/array-get-out-of-bounds.html:
  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
  • fast/canvas/webgl/array-set-out-of-bounds.html:
  • fast/canvas/webgl/array-setters-expected.txt:
  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
  • fast/canvas/webgl/null-uniform-location.html:
  • fast/canvas/webgl/point-size.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils): (WebGLTestUtils.):
  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
  • fast/canvas/webgl/tex-image-with-format-and-type.html:
  • fast/canvas/webgl/tex-input-validation.html:
  • fast/canvas/webgl/tex-sub-image-2d-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d.html:
  • fast/canvas/webgl/texImage2DImageDataTest.html:
  • fast/canvas/webgl/viewport-unchanged-upon-resize.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
4:46 PM Changeset in webkit [65199] by steveblock@google.com
  • 4 edits in trunk/WebCore

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

[chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
​https://bugs.webkit.org/show_bug.cgi?id=43753

This change guards the entire contents of the V8 custom bindings files
with ENABLE(GEOLOCATION) to match JSC.

No new tests, build fix only.

  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
4:35 PM Changeset in webkit [65198] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Adding my Collabora personality to the list.

  • Scripts/webkitpy/common/config/committers.py:
4:30 PM Changeset in webkit [65197] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Levin.

Include <wtf/UnusedParam.h> in GraphicsContextSkia.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43843

wtf/UnusedParam.h must be included because UNUSED_PARAM macro is used.

  • platform/graphics/skia/GraphicsContextSkia.cpp:
4:25 PM Changeset in webkit [65196] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Small improvement to the documentation of the geolocation-policy-decision-requested
signal, stating more clearly what is expected from the handler.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
4:25 PM Changeset in webkit [65195] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Geolocation policy decision object leaking
​https://bugs.webkit.org/show_bug.cgi?id=43884

Use GRefPtr on the policy decision object to fix the leak.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
4:14 PM Changeset in webkit [65194] by thakis@chromium.org
  • 4 edits in trunk/WebCore

2010-08-11 Nico Weber <​thakis@chromium.org>

Reviewed by David Levin.

[chromium/mac]: Fix colors in compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=43823

The textures are drawn by opengl, which doesn't do any color space
correction -- it assumes everything is in the device color space
already. Hence, when drawing into the memory that will be uploaded
as opengl texture, use the device color space.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureContents):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
3:54 PM Changeset in webkit [65193] by aa@chromium.org
  • 9 edits in trunk

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Remove obsolete texImage2D and texSubImage2D entry points
​https://bugs.webkit.org/show_bug.cgi?id=40320

No new tests; covered by existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
3:44 PM Changeset in webkit [65192] by kbr@google.com
  • 4 edits in trunk/WebCore

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Remove obsolete texImage2D and texSubImage2D entry points
​https://bugs.webkit.org/show_bug.cgi?id=40320

No new tests; covered by existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
3:28 PM Changeset in webkit [65191] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-08-11 Martin Robinson <​mrobinson@igalia.com>

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:16 PM Changeset in webkit [65190] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/win/BString.cpp:

(WebCore::BString::BString):

3:02 PM Changeset in webkit [65189] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix II.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

2:52 PM Changeset in webkit [65188] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Windows & !JIT build fix.

(JSC::RegExp::match):

2:48 PM Changeset in webkit [65187] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Qt build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

2:45 PM Changeset in webkit [65186] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber stamp by sam weinig

Touch a file to stop the bot rolling a bit change out!

  • runtime/UString.cpp:

(JSC::UString::ascii):

2:35 PM Changeset in webkit [65185] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage
​https://bugs.webkit.org/show_bug.cgi?id=43848

Tested by existing DeviceOrientation tests.

  • loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::setController): (WebCore::EmptyDeviceMotionClient::startUpdating): (WebCore::EmptyDeviceMotionClient::stopUpdating): (WebCore::EmptyDeviceMotionClient::currentDeviceMotion): (WebCore::EmptyDeviceOrientationClient::setController): (WebCore::EmptyDeviceOrientationClient::startUpdating): (WebCore::EmptyDeviceOrientationClient::stopUpdating): (WebCore::EmptyDeviceOrientationClient::lastOrientation):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
2:23 PM Changeset in webkit [65184] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Mark websocket/tests/frame-length-overflow.html as flaky.

  • platform/chromium/test_expectations.txt:
1:38 PM Changeset in webkit [65183] by aa@chromium.org
  • 9 edits in trunk

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Handle the case where user styles might have author level. Minor refactor.
  • dom/Document.cpp: (WebCore::Document::pageGroupUserSheets): Set isUserStyle on created stylesheet objects appropriately.
  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): Add new optional "level" argument.
  • page/PageGroup.h: Ditto.
  • page/UserStyleSheet.h: Add level property. (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::setLevel): (WebCore::UserStyleSheet::level):

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet): Send "author" for the css level of user styles.
1:24 PM Changeset in webkit [65182] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=42042
An empty value for xml:lang isn't considered

Revert last line change of my patch ; it happens to
behave correctly and same as before, but makes the
use case of empty values unneededly slower.

No new tests. (No change in behavior)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1:10 PM Changeset in webkit [65181] by jhawkins@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
1:09 PM Changeset in webkit [65180] by kevino@webkit.org
  • 13 edits
    2 adds in trunk

[wx, WebDOM] Build fix. Fix handling of callbacks and WebCore::String -> WTF::String fixes.

12:55 PM Changeset in webkit [65179] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-11 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Perl warnings when running commit-log-editor
​https://bugs.webkit.org/show_bug.cgi?id=43856

Fixes Perl warnings introduced by the patch for Bug #40548.

Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.

  • Scripts/commit-log-editor:
12:53 PM Changeset in webkit [65178] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[Chromium] Remove consistently passing tests
from test_expectations.txt.

​https://bugs.webkit.org/show_bug.cgi?id=43868

  • platform/chromium/test_expectations.txt:
12:52 PM Changeset in webkit [65177] by barraclough@apple.com
  • 58 edits
    1 copy in trunk

Rubber stamps by Darin Adler & Sam Weinig.

Bug 43867 - Some UString cleanup

Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClass::className):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::processClauseList):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegex):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeNumericIdentifier):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::length):

  • profiler/Profiler.cpp:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

  • runtime/ExceptionHelpers.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/Identifier.h:

(JSC::Identifier::characters):
(JSC::Identifier::length):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseInt):
(JSC::parseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSNumberCell.cpp:

(JSC::JSNumberCell::toString):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::indent):
(JSC::Stringifier::unindent):
(JSC::Walker::walk):

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter):
(JSC::JSString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::fiberCount):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::JSString::getIndex):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::Lexer::Lexer):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/NumericStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getRightContext):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::append):

  • runtime/StringConcatenate.h: Copied from JavaScriptCore/runtime/UString.h.

(JSC::):
(JSC::sumWithOverflow):
(JSC::tryMakeString):
(JSC::makeString):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::localeCompare):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
(JSC::trimString):

  • runtime/UString.cpp:

(JSC::UString::number):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toDouble):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator==):
(JSC::operator<):
(JSC::operator>):
(JSC::UString::UTF8String):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::length):
(JSC::UString::characters):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::operator!=):
(JSC::codePointCompare):
(JSC::UString::toArrayIndex):
(JSC::IdentifierRepHash::hash):
(WTF::):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::Parser):

JavaScriptGlue:

  • JSUtils.cpp:

(UStringToCFString):
(KJSValueToCFTypeInternal):

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::hasCSSPropertyNamePrefix):
(WebCore::cssPropertyName):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setPort):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::size):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

  • bridge/jni/jsc/JNIUtilityPrivate.cpp:

(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(toNSString):

12:49 PM Changeset in webkit [65176] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Trying waiting for httpd lock in the EWS
​https://bugs.webkit.org/show_bug.cgi?id=43833

If this works, we can probably run the tests on the mac-ews, which
would be very exciting. :)

  • Scripts/webkitpy/tool/steps/runtests.py:
12:48 PM Changeset in webkit [65175] by hyatt@apple.com
  • 10 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.

Reviewed by Dan Bernstein.

WebCore:

Add a new boolean to Document to indicate that content should be paginated. This is checked when doing page breaks
and in a couple of other cases.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::paginatedForScreen):
(WebCore::Document::setPaginatedForScreen):
(WebCore::Document::paginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::calcColumnWidth):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):

WebKit/mac:

Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
content.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _isInScreenPaginationMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):

  • WebView/WebHTMLViewPrivate.h:
12:39 PM Changeset in webkit [65174] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Add AudioNode memory leak instrumentation

12:38 PM Changeset in webkit [65173] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Make AudioContext be an ActiveDOMObject

12:33 PM Changeset in webkit [65172] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-08-11 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Nikolas Zimmermann.

RenderSVGRoot::nodeAtPoint truncates translated mouse coordinates
​https://bugs.webkit.org/show_bug.cgi?id=41968

New layout test checks for proper hit region.

  • platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt:
  • platform/chromium/test_expectations.txt:
  • svg/hittest/svg-rect-hit.html: Added.
11:59 AM Changeset in webkit [65171] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Windows build fix. Turns out we need to unconditionally include
HTMLEntityNames.cpp now that LegacyHTMLDocumentParser doesn't exist.

  • html/HTMLEntityParser.cpp:
11:56 AM Changeset in webkit [65170] by eric.carlson@apple.com
  • 10 edits
    2 adds in trunk

2010-08-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
​https://bugs.webkit.org/show_bug.cgi?id=42897

A <source> element inserted as a child of a media element with a networkState of NETWORK_EMPTY
should cause the networkState to immediately change to NETWORK_NO_SOURCE.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::prepareForLoad): Set m_networkState to NETWORK_NO_SOURCE. (WebCore::HTMLMediaElement::loadInternal): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::selectMediaResource): No need to change m_networkState, it was done in prepareForLoad.
  • html/HTMLMediaElement.h:
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::insertedIntoTree): Renamed from insertedIntoDocument because we want to do this setup whether or not the parent media element is in the document.
  • html/HTMLSourceElement.h:

2010-08-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
​https://bugs.webkit.org/show_bug.cgi?id=42897

  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-empty-events.html:
  • media/video-source-inserted-expected.txt: Added.
  • media/video-source-inserted.html: Added.
11:49 AM Changeset in webkit [65169] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-11 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add setting for enabling spatial navigation.
​https://bugs.webkit.org/show_bug.cgi?id=43569

Adding api for enabling/disabling spatial navigation.

  • ewk/ewk_view.cpp: Both functions below added. (ewk_view_setting_spatial_navigation_get): (ewk_view_setting_spatial_navigation_set):
  • ewk/ewk_view.h: same as ewk_view.cpp.
11:48 AM Changeset in webkit [65168] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Dimitri Glazkov <Dimitri Glazkov>

Build fix, turn off yet-unbaked DEVICE_ORIENTATION stuff.

  • features.gypi: Turned it off.
11:31 AM Changeset in webkit [65167] by abarth@webkit.org
  • 27 edits
    4 deletes in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Delete LegacyHTMLDocumentParser and LegacyPreloadScanner
​https://bugs.webkit.org/show_bug.cgi?id=43836

These classes are bit-rotting disturbingly quickly. We removed the
last dependencies on these classes and so we can remove them.

We might need to preserve some of their particular quirks to handle
some legacy applications, but our current thinking is to do that with
individual settings that affect the new parser.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • dom/DocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTMLConstructionSite.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
  • html/HTMLEntityParser.h:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLTreeBuilder.cpp:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
  • html/LegacyHTMLDocumentParser.cpp: Removed.
  • html/LegacyHTMLDocumentParser.h: Removed.
  • html/LegacyHTMLTreeBuilder.cpp:
  • html/LegacyPreloadScanner.cpp: Removed.
  • html/LegacyPreloadScanner.h: Removed.
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::processFilesizeString): (WebCore::wasLastDayOfMonth): (WebCore::processFileDateString): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::append): (WebCore::FTPDirectoryDocumentParser::finish):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
  • page/XSSAuditor.h:
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::prepend):
11:31 AM Changeset in webkit [65166] by bulach@chromium.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-08-11 Marcus Bulach <​bulach@chromium.org>

Reviewed by Eric Seidel.

Check in a script to list redundant test outputs.
​https://bugs.webkit.org/show_bug.cgi?id=37630

If e.g. platform/mac-leopard is missing an expected test output, we
fall back on platform/mac. This means it's possible to grow redundant
test outputs, where we have the same expected data in both a platform
directory and another platform it falls back on.
(original patch by Evan Marting <​evan@chromium.org> ​https://bugs.webkit.org/attachment.cgi?id=53398)

  • Scripts/deduplicate-tests: Added.
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
11:01 AM Changeset in webkit [65165] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
​https://bugs.webkit.org/show_bug.cgi?id=43853

LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
to slots at all.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::animatedFlip): (LauncherWindow::animatedYFlip):
  • QtTestBrowser/launcherwindow.h:
10:40 AM Changeset in webkit [65164] by Chris Jerdonek
  • 5 edits in trunk/WebCore

2010-08-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Refactored FrameLoader::createWindow() out of the FrameLoader class
since FrameLoader should not be responsible for creating windows.

​https://bugs.webkit.org/show_bug.cgi?id=39156

No new functionality, so no new tests.

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
    • Updated the call to FrameLoader's createWindow().
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
    • Updated the call to FrameLoader's createWindow().
  • loader/FrameLoader.cpp: (WebCore::createWindowFromFrameLoader):
    • Made FrameLoader::createWindow() non-member, non-friend and changed it to accept Frame* parameters instead of FrameLoader*.
  • loader/FrameLoader.h:
    • Updated the header file to reflect the above change to FrameLoader.cpp.
10:14 AM Changeset in webkit [65163] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-08-11 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

Implementation dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=43544

Add ewk_view_navigation_policy_decision to decide whether url which
user clicked will be loaded or not.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_navigation_policy_decision):
  • ewk/ewk_view.h:
9:55 AM Changeset in webkit [65162] by Nate Chapin
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium rebaseline.

Tweak win pixel results for svg/batik/text/textFeatures.svg.

  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
9:31 AM Changeset in webkit [65161] by alex
  • 4 edits in trunk/LayoutTests

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Unreviewed.

New baselines for the mathml tests.

  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.txt:
8:57 AM Changeset in webkit [65160] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-11 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
​https://bugs.webkit.org/show_bug.cgi?id=43851

All window options data (including the bool holding if the view is either QWebView or
QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
getting broken.

Patch addresses this issue.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleWebView): (LauncherWindow::toggleAcceleratedCompositing):
8:56 AM Changeset in webkit [65159] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-10 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
​https://bugs.webkit.org/show_bug.cgi?id=43831

Only instantiate QStateMachine and friends associated to the YRotation action on demand.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedYFlip):
8:33 AM Changeset in webkit [65158] by abecsi@webkit.org
  • 4 edits
    1 add in trunk/WebKit2

2010-08-11 Balazs Kelemen <​kb@inf.u-szeged.hu>

Unreviewed build fix.

[Qt] Update WebKit2 build environment, add stub implementation of SharedMemory.

  • DerivedSources.pro:
  • Platform/qt/SharedMemoryQt.cpp: Added. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
  • WebKit2.pro:
  • WebKit2Prefix.h:
8:08 AM Changeset in webkit [65157] by Nate Chapin
  • 44 edits
    2 adds
    3 deletes in trunk/LayoutTests

2010-08-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium rebaseline.

New results and expectations tweak for ​http://trac.webkit.org/changeset/65138.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.png:
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png: Added.
  • platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium/test_expectations.txt:
7:56 AM Changeset in webkit [65156] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: small refactoring for CodeGeneratorInspector.
all "notify" methods are generating in InspectorFrontend
the other methods are generating in InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=43849

  • inspector/CodeGeneratorInspector.pm:
7:43 AM Changeset in webkit [65155] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Misc improvements to the scrolling code
​https://bugs.webkit.org/show_bug.cgi?id=41926

Refactor code that uses deprecated ways of dealing with the
adjustments to use the GtkVersioning infrastructure.

  • GNUmakefile.am:
  • platform/gtk/GtkVersioning.cpp: Added.
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
7:37 AM Changeset in webkit [65154] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Update the Symbian def files

Re-freeze with various QGraphicsWebView and DRT updates.
The uppper part of the diff is just whitespace, so
diff -w will show the real diff.

  • symbian/eabi/QtWebKitu.def:
6:51 AM Changeset in webkit [65153] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-08-11 Nate Chapin <Nate Chapin>

Chromium mac build fix (variables weren't being initialized).

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Initalize dxLeft, dxRight, dyLeft, dyRight.
6:45 AM Changeset in webkit [65152] by estade@chromium.org
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-08-11 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

[chromium] linux chromium sends double clicks too often
​https://bugs.webkit.org/show_bug.cgi?id=43096

  • WebKit.gyp: add the test
  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent): check the x/y coordinates of the potential double click event
  • tests/WebInputEventFactoryTestGtk.cpp: Added.
6:27 AM Changeset in webkit [65151] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Rebaseline Chromium test.

  • platform/chromium-win/http/tests/loading/bad-scheme-subframe-expected.txt:
6:27 AM Changeset in webkit [65150] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-08-11 Gabor Loki <​loki@webkit.org>

Qt build fix (ARMv7).

Fix invalid conversion from int to Condition.
Add ARMv7Assembler.cpp to JavaScriptCore.pro.

6:12 AM Changeset in webkit [65149] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-08-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: apply correct fix to storage panel status bar buttons.

​https://bugs.webkit.org/show_bug.cgi?id=43846

  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype.get statusBarItems):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):
5:54 AM Changeset in webkit [65148] by Darin Adler
  • 3 edits in trunk/WebKitTools

2010-08-11 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Improved editor options for prepare-ChangeLog and commit-log-editor
​https://bugs.webkit.org/show_bug.cgi?id=40548

  • Scripts/commit-log-editor: Split editor strings on spaces so EDITOR values like "xed --launch --wait" work properly.
  • Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can use a command line tool with the $openChangeLogs feature.
5:30 AM Changeset in webkit [65147] by commit-queue@webkit.org
  • 10 edits in trunk/WebCore

2010-08-11 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Barth.

Override operator= for C++ DOM binding classes with private structs
and update C++ DOM bindings test results.
​https://bugs.webkit.org/show_bug.cgi?id=43735

  • bindings/cpp/WebDOMEventTarget.cpp: (WebDOMEventTarget::operator=):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::operator=):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: (WebDOMTestInterface::operator=):
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::operator=):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
5:14 AM Changeset in webkit [65146] by commit-queue@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-08-11 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

At collection time, we frequently want to mark a cell, while checking
whether it was originally checked. Previously, this was a get
operation follwed by a set operation. Fusing the two saves
computation and gives a 0.5% sunspider speedup.

  • runtime/Collector.h: (JSC::CollectorBitmap::getset): (JSC::Heap::checkMarkCell):
  • runtime/JSArray.h: (JSC::MarkStack::drain):
  • runtime/JSCell.h: (JSC::MarkStack::append):
4:09 AM Changeset in webkit [65145] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Inform a plugin about the zoom level when it's created
​https://bugs.webkit.org/show_bug.cgi?id=42268

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
3:30 AM Changeset in webkit [65144] by jparent@chromium.org
  • 5 edits
    2 adds in trunk

2010-08-11 Julie Parent <​jparent@chromium.org>

Reviewed by Justin Garcia.

Crash in replaceSelectionCommand with RTL text.
​https://bugs.webkit.org/show_bug.cgi?id=41485

Adds tests for 4 cases: latin text plus space in RTL region and LTR region,
and hebrew text plus space in RTL region and LTR region. Currently, the
latin text in RTL region case crashes. Added all combinations of test since
earlier patch crashed with hebrew text in LTR region.

  • editing/execCommand/insert-image-on-top-of-directional-text-expected.txt: Added.
  • editing/execCommand/insert-image-on-top-of-directional-text.html: Added.

2010-08-11 Julie Parent <​jparent@chromium.org>

Reviewed by Justin Garcia.

Crash in replaceSelectionCommand with RTL text.
​https://bugs.webkit.org/show_bug.cgi?id=41485

For text with mixed directionality, sort the text boxes before
computing gaps, since that code assumes the boxes are in order.

Test: editing/execCommand/insert-image-on-top-of-directional-text.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Sort boxes like we do in TextIterator before computing gaps.
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): Use new compareByStart rather than compareBoxStart. No functional change.
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::compareByStart): Moved compareBoxStart from TextIterator here so it can be used in multiple places.
2:41 AM Changeset in webkit [65143] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-08-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Improve vsprops copying for Windows build
​https://bugs.webkit.org/show_bug.cgi?id=41982

When we detect a new SDK, always copy a new set of vsprops files.
Previously, if someone updated their SDK after updating their sources,
they could end up with out-of-date vsprops files.

2:20 AM Changeset in webkit [65142] by mrowe@apple.com
  • 5 edits in trunk/WebKit2

Build fix. Update references to StringHash.h.

  • Shared/CommandLine.h:
  • UIProcess/WebContext.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/win/WebProcessMainWin.cpp:
2:15 AM Changeset in webkit [65141] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium compilation.

  • DEPS:
1:46 AM Changeset in webkit [65140] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed build fix of Leopard Intel Debug (Build)

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processBuffer): use %lu, instead of %ul
1:43 AM Changeset in webkit [65139] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix.

  • DEPS: bump up Chromium revision.
1:43 AM Changeset in webkit [65138] by alex
  • 50 edits in trunk

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Dirk Schulze.

Fixes to the gaussian blur algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41605

Added the recomendations of SVG regarding the kernel size
calculation for the approximation of the gaussian
blur. ​http://www.w3.org/TR/SVG/filters.html#feGaussianBlurElement.
Modified also some variable names to clarify algorithm, reviewed
the situation where both standard deviations are 0.

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::stdDeviationX): (WebCore::FEGaussianBlur::setStdDeviationX): (WebCore::FEGaussianBlur::stdDeviationY): (WebCore::FEGaussianBlur::setStdDeviationY): (WebCore::boxBlur): (WebCore::FEGaussianBlur::kernelPosition): Added the SVG kernel position recomendation. (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h:

2010-08-11 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Dirk Schulze.

Fixes to the gaussian blur algorithm
​https://bugs.webkit.org/show_bug.cgi?id=41605

Unskipped test and generated results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.

Updated pixel tests.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-leopard/svg/batik/text/textProperties-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textProperties-expected.png:
  • platform/mac-leopard/svg/custom/mask-colorspace-expected.png:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/custom/non-opaque-filters-expected.checksum:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.checksum:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/text-filter-expected.checksum:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
1:35 AM Changeset in webkit [65137] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Kristian Monsen <​kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android, added include for <wtf/text/Cstring.h, this
did not get included in Android.
​https://bugs.webkit.org/show_bug.cgi?id=41517

Build fix only, no new tests.

  • page/PrintContext.cpp:
1:32 AM Changeset in webkit [65136] by yurys@chromium.org
  • 5 edits
    1 delete in trunk

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InjectDispatch.js
​https://bugs.webkit.org/show_bug.cgi?id=43835

  • WebKit.grd:
  • src/js/InjectDispatch.js: Removed.

2010-08-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InjectDispatch.js
​https://bugs.webkit.org/show_bug.cgi?id=43835

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
1:23 AM Changeset in webkit [65135] by ukai@chromium.org
  • 4 edits
    3 adds in trunk

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix length calculation to be more robust.
​https://bugs.webkit.org/show_bug.cgi?id=43777

  • websocket/tests/frame-length-overflow-expected.txt: Added.
  • websocket/tests/frame-length-overflow.html: Added.
  • websocket/tests/frame-length-overflow_wsh.py: Added.

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix length calculation to be more robust.
​https://bugs.webkit.org/show_bug.cgi?id=43777

Test: websocket/tests/frame-length-overflow.html

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): len is size_t.
    • add sanity check for integer wraps.

(WebCore::WebSocketChannel::skipBuffer): len is size_t.
(WebCore::WebSocketChannel::processBuffer): length is size_t.

  • add sanity check for integer wraps.
  • websockets/WebSocketChannel.h: change m_bufferSize and len to size_t.
12:51 AM Changeset in webkit [65134] by abarth@webkit.org
  • 6 edits
    5 adds in trunk

2010-08-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.

Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
    • This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
  • html/HTMLElement.cpp: (WebCore::contextElementForInsertion):
    • This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.

(WebCore::HTMLElement::insertAdjacentHTML):

  • Use the right contextElement now that we know how to compute it.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
    • This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.

2010-08-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
​https://bugs.webkit.org/show_bug.cgi?id=43762

In order to fix the insertAdjacentHTML I had to some behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.

  • fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
  • fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.
12:40 AM Changeset in webkit [65133] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Attempt to fix Windows build.

  • platform/win/COMPtr.h: (WTF::):
12:30 AM Changeset in webkit [65132] by abarth@webkit.org
  • 12 edits
    2 adds in trunk/WebCore

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Port view-source to new parser
​https://bugs.webkit.org/show_bug.cgi?id=43746

This patch switches the view-source mode for frames over to using the
new HTML parsing infrastructure. This patch is an architectural change
to how we parser view source documents.

Previously, the LegacyHTMLDocumentParser would output a "guide string"
that consided of the inter-attribute whitespace and various "control"
characters. The HTMLViewSourceDocument would then interpret this guide
string to approximately reconstruct the source of the original document
and colorize various syntatic constructs.

Unfortunately, that approach is inherently low-fidelity. It's not
really feasible to reconstruct the input document from the token
stream. The old view source mode also had a number of hacks in the old
parser (e.g., to turn of decoding of HTML entities).

Instead of trying to reconstruct the original document from the token
stream, we use the segmentation information given by the tokens to
colorize the input document itself. Each token now caries information
about where in the input stream it came from and where various
subcomponents (e.g., attribute names and values) are located. This
approach is higher fidelity because we use this segmentation
information to colorize the original input instead of attempting to
reconstruct the original input.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLDocumentParser.cpp:
  • html/HTMLToken.h: (WebCore::HTMLToken::clear): (WebCore::HTMLToken::startIndex): (WebCore::HTMLToken::length): (WebCore::HTMLToken::end):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addSource): (WebCore::HTMLViewSourceDocument::processDoctypeToken): (WebCore::HTMLViewSourceDocument::processTagToken): (WebCore::HTMLViewSourceDocument::processCommentToken): (WebCore::HTMLViewSourceDocument::processCharacterToken): (WebCore::HTMLViewSourceDocument::addRange):
  • html/HTMLViewSourceDocument.h:
  • html/HTMLViewSourceParser.cpp: Added. (WebCore::HTMLViewSourceParser::~HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::insert): (WebCore::HTMLViewSourceParser::pumpTokenizer): (WebCore::HTMLViewSourceParser::append): (WebCore::HTMLViewSourceParser::sourceForToken): (WebCore::HTMLViewSourceParser::updateTokenizerState): (WebCore::HTMLViewSourceParser::finish): (WebCore::HTMLViewSourceParser::finishWasCalled):
  • html/HTMLViewSourceParser.h: Added. (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::document):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken):
12:13 AM WebKit Team edited by ariya@webkit.org
my new employer (diff)
12:13 AM Changeset in webkit [65131] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-08-11 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
​https://bugs.webkit.org/show_bug.cgi?id=17918

  • fast/flexbox/vertical-box-form-controls-expected.txt: Added.
  • fast/flexbox/vertical-box-form-controls.html: Added.

2010-08-11 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
​https://bugs.webkit.org/show_bug.cgi?id=17918

Test: fast/flexbox/vertical-box-form-controls.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicWidth):
12:08 AM Changeset in webkit [65130] by abarth@webkit.org
  • 9 edits in trunk

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • API/JSRetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". We should probably put this in the style guide and do it consitently. Fixed other minor style issues. Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers oat once. Added a clear function.
  • wtf/PassRefPtr.h: Changed all uses of releaseRef to leakRef.
  • wtf/RefPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Tidied up declarations and comments a bit. Changed all uses of releaseRef to leakRef.
  • wtf/RetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • platform/win/COMPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function. Changed the hash table code so it doesn't need to call releaseRef, and so it uses the hash table deleted value hooks already present within the class.

2010-08-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Add leakRef and clear to all RefPtr variants
​https://bugs.webkit.org/show_bug.cgi?id=42389

  • UIProcess/API/cpp/WKRetainPtr.h: Changed all uses of "template <...>" to "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.
Note: See TracTimeline for information about the timeline view.