⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 21, 2010:

8:01 PM Changeset in webkit [65781] by weinig@apple.com
  • 6 edits in trunk/WebKitTools

Check in missing files.

6:58 PM Changeset in webkit [65780] by weinig@apple.com
  • 44 edits in trunk

Remove specialized retain/release functions in favor of a single one for WKTypeRefs
​https://bugs.webkit.org/show_bug.cgi?id=44386

Reviewed by Dan Bernstein.

WebKit2:

  • UIProcess/API/C/WKArray.cpp:

(WKArrayGetSize):

  • UIProcess/API/C/WKArray.h:
  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListCopyForwardListWithLimit):

  • UIProcess/API/C/WKBackForwardList.h:
  • UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemCopyTitle):

  • UIProcess/API/C/WKBackForwardListItem.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKData.cpp:

(WKDataGetSize):

  • UIProcess/API/C/WKData.h:
  • UIProcess/API/C/WKDictionary.cpp:

(WKDictionaryCopyKeys):

  • UIProcess/API/C/WKDictionary.h:
  • UIProcess/API/C/WKError.h:
  • UIProcess/API/C/WKFormSubmissionListener.cpp:

(WKFormSubmissionListenerContinue):

  • UIProcess/API/C/WKFormSubmissionListener.h:
  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetPage):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKFramePolicyListener.cpp:

(WKFramePolicyListenerIgnore):

  • UIProcess/API/C/WKFramePolicyListener.h:
  • UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataCopyURL):

  • UIProcess/API/C/WKNavigationData.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageNamespace.cpp:

(WKPageNamespaceGetContext):

  • UIProcess/API/C/WKPageNamespace.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):
(WKPreferencesGetLocalStorageEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKString.cpp:
  • UIProcess/API/C/WKString.h:
  • UIProcess/API/C/WKType.cpp:

(WKRetain):
(WKRelease):

  • UIProcess/API/C/WKType.h:
  • UIProcess/API/C/WKURL.cpp:

(WKURLGetTypeID):

  • UIProcess/API/C/WKURL.h:
  • UIProcess/API/cpp/WKRetainPtr.h:
  • UIProcess/API/win/WKView.cpp:
  • UIProcess/API/win/WKView.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::shared):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldNormalWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:

WebKitTools:

  • MiniBrowser/mac/AppDelegate.m:

(didRecieveMessageFromInjectedBundle):
(didNavigateWithNavigationData):
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationWillTerminate:]):

  • MiniBrowser/mac/BrowserStatisticsWindowController.m:

(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController fetch:]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(-[BrowserWindowController updateProvisionalURLForFrame:]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didClearWindowObjectForFrame):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::goToURL):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::~PlatformWebView):

11:40 AM Changeset in webkit [65779] by eric.carlson@apple.com
  • 6 edits in trunk

2010-08-21 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media engine should not be asked to open all urls
​https://bugs.webkit.org/show_bug.cgi?id=44370

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Do nothing with urls with a type attribute that would be rejected by canPlayType().

2010-08-21 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media engine should not be asked to open all urls
​https://bugs.webkit.org/show_bug.cgi?id=44370

  • media/video-source-none-supported-expected.txt:
  • media/video-source-none-supported.html:
  • media/video-source-type.html:
3:11 AM Changeset in webkit [65778] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-21 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Ariya Hidayat.

[Qt] http/tests/incremental should be enabled
​https://bugs.webkit.org/show_bug.cgi?id=44284

  • platform/qt/Skipped: Enable http/tests/incremental, disabling only one failing test (#44282)
2:23 AM Changeset in webkit [65777] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-21 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Ariya Hidayat.

[Qt] All sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/ tests can be re-enabled
​https://bugs.webkit.org/show_bug.cgi?id=44192

Tested on several scenarios, including qt-4.7 and qt-4.6

  • platform/qt/Skipped:
1:33 AM Changeset in webkit [65776] by ariya@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Faster bounding rect for the shadow clip region
​https://bugs.webkit.org/show_bug.cgi?id=44369

Patch by Ariya Hidayat <​ariya@sencha.com> on 2010-08-21
Reviewed by Kenneth Rohde Christiansen.

Like in r65650, we should use the faster QPainter::clipBoundingRect
when it is available.

  • platform/graphics/qt/ContextShadow.cpp:

(WebCore::ContextShadow::drawShadowRect):

Aug 20, 2010:

10:14 PM Changeset in webkit [65775] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

[Qt] When using the raster graphics system on Maemo5, allow
Flash to render directly into the raster window surface.
wmode=transparent is now supported as a result of this change.

Reviewed by Ariya Hidayat.

​https://bugs.webkit.org/show_bug.cgi?id=44043

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingImageSurfaceExtension):

10:06 PM Changeset in webkit [65774] by ap@apple.com
  • 3 edits
    3 adds in trunk

2010-08-20 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources

  • http/tests/misc/resources/script-500.php: Added.
  • http/tests/misc/script-500-expected.txt: Added.
  • http/tests/misc/script-500.html: Added.

2010-08-20 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources

Test: http/tests/misc/script-500.html

  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveData): Treat all HTTP codes >= 400 as error ones, since they are.
8:39 PM Changeset in webkit [65773] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-08-20 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit does not build with Python 2.3
​https://bugs.webkit.org/show_bug.cgi?id=44373

Replaced the function sorted() by a call to sort()
on the entry list.
The function sorted() has been added to Python 2.4.
The function method sort() of List works with older
versions of Python.

  • Scripts/create-html-entity-table:
6:18 PM Changeset in webkit [65772] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-20 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Ariya Hidayat.

[Qt] Enable some http/ tests which are passing for some time
​https://bugs.webkit.org/show_bug.cgi?id=44366

These are reported as "passing, require confirmation on bot". Some of them
fail on my machines, so I'm enabling only the ones which pass.

  • platform/qt/Skipped: enable several http tests
6:01 PM Changeset in webkit [65771] by commit-queue@webkit.org
  • 7 edits in trunk/WebKit/qt

2010-08-20 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Ariya Hidayat.

[Qt] constify core() and kit() parameters
​https://bugs.webkit.org/show_bug.cgi?id=44347

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core):
  • Api/qwebhistory_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::core):
  • Api/qwebpage_p.h:
5:35 PM Changeset in webkit [65770] by kinuko@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-20 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed; build fix for chromium (and remove duplicated ChangeLog entry).

5:25 PM Changeset in webkit [65769] by tonyg@chromium.org
  • 10 edits
    4 adds in trunk

2010-08-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::Node::createRendererIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=44129

  • html5lib/resources/adoption02.dat: A crazy DOM from ​https://bugs.webkig.org/show_bug.cgi?id=44170 which previously crashed. The expectation doesn't appear to be correct, but it behaves the same in Firefox 4, so I'm going to file a spec bug.
  • fast/parser/remove-misnested-iframe-in-beforeload-expected.txt:
  • fast/parser/remove-misnested-iframe-in-beforeload.html: Misnest a node in a table and remove it during its beforeload handler. The node should not be in the tree.
  • fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt:
  • fast/parser/remove-misnested-iframe-parent-in-beforeload.html: Misnest a node in a table and remove its parent during its beforeload handler. The adoption agency should have already changed its parent to the one before the table and it and its parent should be removed.

2010-08-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::Node::createRendererIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=44129

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): Factor out core bit to insertBetween. (WebCore::ContainerNode::insertBetween): Factored out of insertBefore. (WebCore::ContainerNode::parserInsertBefore): Similar to insertBefore, but doesn't handle reparenting or dispatch DOM mutation events. (WebCore::ContainerNode::removeChild): Factor out core bit to removeBetween. (WebCore::ContainerNode::removeBetween): Facotred out of removeChild. (WebCore::ContainerNode::parserRemoveChild): Similar to removeChild, but doesn't handle reparenting or dispatch DOM mutation events. (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::legacyParserAddChild):
  • dom/ContainerNode.h:
  • dom/Node.cpp: (WebCore::Node::parserRemoveChild): (WebCore::Node::parserInsertBefore):
  • dom/Node.h:
  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite): Use new parserInsertBefore.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::reparentChildren): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Was missing a key bit from the spec about removing the old parent if it exists.
5:18 PM Changeset in webkit [65768] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-08-20 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed; build fix. Had included wrong version of build file.

5:13 PM Changeset in webkit [65767] by Martin Robinson
  • 4 edits in trunk

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Joseph Pecoraro.

[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
​https://bugs.webkit.org/show_bug.cgi?id=44342

  • platform/gtk/Skipped: Unskip tests which are now passing.

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Joseph Pecoraro.

[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
​https://bugs.webkit.org/show_bug.cgi?id=44342

  • GNUmakefile.am: Fix dependency tracking for copied web inspector files.
5:04 PM Changeset in webkit [65766] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-08-20 James Robinson <​jamesr@chromium.org>

Synchronize default of use_accelerated_compositing gyp variable with downstream. Unreviewed.

  • features.gypi:
5:02 PM Changeset in webkit [65765] by kinuko@chromium.org
  • 2 edits
    2 adds in trunk/WebKit/chromium

2010-08-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add chromium-side callback implementation for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=44350

Add WebFileSystemCallbacks that calls back the WebCore's implementation.

  • WebKit.gyp:
  • src/WebFileSystemCallbacksImpl.cpp: Added.
  • src/WebFileSystemCallbacksImpl.h: Added.
4:59 PM Changeset in webkit [65764] by crogers@google.com
  • 4 edits
    6 adds in branches/audio/WebCore

Split out HRTFPanner file into: HRTFKernel, HRTFElevation, HRTFDatabase, HRTFPanner files

4:49 PM Changeset in webkit [65763] by kinuko@chromium.org
  • 9 edits
    2 adds in trunk/WebCore

2010-08-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Darin Fisher.

Add Callback implementation for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=44349

No new tests; tests will be added later.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/FileSystemCallbacks.cpp: Added.
  • storage/FileSystemCallbacks.h: Added.
  • storage/EntryCallback.h: Nits fix
  • storage/FileSystemCallback.h: Nits fix
4:48 PM Changeset in webkit [65762] by rniwa@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2010-08-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65757.
​http://trac.webkit.org/changeset/65757
​https://bugs.webkit.org/show_bug.cgi?id=44371

"fails on chromium windows and there is also a bug in the test
script." (Requested by rniwa on #webkit).

  • editing/style/make-text-writing-direction-inline-expected.txt: Removed.
  • editing/style/make-text-writing-direction-inline.html: Removed.
  • editing/style/script-tests/make-text-writing-direction-inline.js: Removed.
4:23 PM Changeset in webkit [65761] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-08-20 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] WebKit does not compile with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=44335

  • PlatformGLObject => Platform3DObject
  • Implemented getAttachedShaders()
  • Implemented bufferData() and bufferSubData() for ArrayBuffer*
  • Removed reference to nonexistent variable in getImageData()
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsLayerQt.h:
4:03 PM Changeset in webkit [65760] by mitz@apple.com
  • 2 edits in trunk/WebCore

#ifdef-out some Leopard-and-earlier code.

Reviewed by Dave Kilzer.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):

3:43 PM Changeset in webkit [65759] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-20 Kenneth Russell <​kbr@google.com>

Unreviewed, speculative Chromium build fix. Forward declare
IntSize in WebGLRenderingContext.h and include IntSize.h in .cpp.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
3:19 PM Changeset in webkit [65758] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2010-08-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element canPlayType("application/octet-stream") not handled correctly
​https://bugs.webkit.org/show_bug.cgi?id=44343

Test: media/media-can-play-octet-stream.html

  • platform/graphics/MediaPlayer.cpp: (WebCore::applicationOctetStream): New, accessor for static string used more than once. (WebCore::textPlain): Ditto. (WebCore::codecs): Ditto. (WebCore::chooseBestEngineForTypeAndCodecs): Special case "application/octet-stream". (WebCore::MediaPlayer::load): Use static static string methods. (WebCore::MediaPlayer::supportsType): Special case "application/octet-stream".

2010-08-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element canPlayType("application/octet-stream") not handled correctly
​https://bugs.webkit.org/show_bug.cgi?id=44343

  • media/media-can-play-octet-stream-expected.txt: Added.
  • media/media-can-play-octet-stream.html: Added.
3:14 PM Changeset in webkit [65757] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-20 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle
​https://bugs.webkit.org/show_bug.cgi?id=43989

Added a test for MakeTextWritingDirectionNatural, MakeTextWritingDirectionLeftToRight,
and MakeTextWritingDirectionRightToLeft commands.

  • editing/style/make-text-writing-direction-inline.html: Added.
  • editing/style/script-tests/make-text-writing-direction-inline.js: Added. (modifyWritingDirection): (selectFirstWord): (selectSecondAndThirdWords):
3:12 PM Changeset in webkit [65756] by kbr@google.com
  • 4 edits
    4 adds in trunk

2010-08-20 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Implement HTMLVideoElement support for texImage2D and texSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=33852

Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): (WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer): (WebCore::WebGLRenderingContext::LRUImageBufferCache::bubbleToFront):
  • html/canvas/WebGLRenderingContext.h:

2010-08-20 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Implement HTMLVideoElement support for texImage2D and texSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=33852

  • fast/canvas/webgl/resources/quadrants.mp4: Added.
  • fast/canvas/webgl/resources/quadrants.ogv: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: Added.
2:54 PM Changeset in webkit [65755] by dumi@chromium.org
  • 3 edits
    2 adds in trunk

WebCore: Removing an incorrect ASSERT.
​https://bugs.webkit.org/show_bug.cgi?id=44151

Reviewed by Adam Barth.

A failure in the preflight step of a transaction wrapper does not
guarantee that the transaction is rolled back (and it shouldn't).

Test: storage/change-version-no-crash-on-preflight-failure.html

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):

LayoutTests: Check that a failure in the preflight step of a transaction wrapper does not trigger any assertion.
​https://bugs.webkit.org/show_bug.cgi?id=44151

Reviewed by Adam Barth.

  • storage/change-version-no-crash-on-preflight-failure-expected.txt: Added.
  • storage/change-version-no-crash-on-preflight-failure.html: Added.
2:44 PM Changeset in webkit [65754] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-20 David Leong <​david.leong@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Update Symbian capabilities to remove AllFiles and DRM

Add CONFIG(production) variation for set of DLL capabilities.
DRM and AllFiles capabilities need to be audited for the sis
package to be signed.

No new tests.

  • WebCore.pro: Updated Symbian Capabilities.
2:14 PM Changeset in webkit [65753] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-08-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Do Not Copy Subversion Related Files in Inspector Build Phase
​https://bugs.webkit.org/show_bug.cgi?id=44353

  • WebCore.xcodeproj/project.pbxproj: remove .svn directories in the "Copy Inspector Resources" build phase.
2:03 PM Changeset in webkit [65752] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-08-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/8245719> backface-visibility and reflections don't play nicely together.

On elements with a reflection and backface-visibility: hidden, set the doubleSided property on the
reflection flattening layer so that backface-visibility works in all configurations.

Test: compositing/reflections/backface-hidden-reflection.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateBackfaceVisibility): Call setDoubleSided: on the structural layer for reflections. (WebCore::GraphicsLayerCA::ensureStructuralLayer): Fix a comment typo, and call updateBackfaceVisibility() when we gain a structural layer.
1:37 PM Changeset in webkit [65751] by commit-queue@webkit.org
  • 6 edits in trunk/WebKit2

2010-08-20 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Implement cursor change in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=44263

Implemented PageClient::setCursor.

  • UIProcess/API/qt/qgraphicswkview.cpp: Added updateCursor slot to be connected to the QWKPage::setCursor signal. (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::updateCursor): Sets the cursor of the widget.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::setCursor): Added implementation for PageClient::setCursor. Emitting singal through the QWKPage.
  • UIProcess/API/qt/qwkpage.h: Added setCursor signal.
  • UIProcess/API/qt/qwkpage_p.h:
1:19 PM Changeset in webkit [65750] by johnnyg@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-20 John Gregg <​johnnyg@google.com>

Unreviewed, chromium rebaseline.

New test was added in r65746, it requires a new chromium-linux baseline.

  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Added.
12:44 PM Changeset in webkit [65749] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

style correction in markup.cpp
​https://bugs.webkit.org/show_bug.cgi?id=44318

Make markup.cpp pass check-webkit-style.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::MarkupAccumulator::appendAttributeValue): (WebCore::appendEscapedContent): (WebCore::MarkupAccumulator::appendStartMarkup): (WebCore::completeURLs): (WebCore::isElementPresentational): (WebCore::isSpecialAncestorBlock): (WebCore::shouldIncludeWrapperForFullySelectedRoot): (WebCore::createMarkup): (WebCore::fillContainerFromString): (WebCore::createFragmentFromText): (WebCore::createFragmentFromNodes):
12:23 PM Changeset in webkit [65748] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-20 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

crash when trying to access a stale Node pointer in FocusController::setFocusedNode
​https://bugs.webkit.org/show_bug.cgi?id=44226

  • fast/events/focus-change-crash2-expected.txt: Added.
  • fast/events/focus-change-crash2.html: Added.

2010-08-20 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

crash when trying to access a stale Node pointer in FocusController::setFocusedNode
​https://bugs.webkit.org/show_bug.cgi?id=44226

Test: fast/events/focus-change-crash2.html

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): add a ref to prevent the focused node from being deleted
12:02 PM Changeset in webkit [65747] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-20 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix a null pointer crash when dispatching JS keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=44313

  • fast/events/initkeyboardevent-crash-expected.txt: Added.
  • fast/events/initkeyboardevent-crash.html: Added.

2010-08-20 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix a null pointer crash when dispatching JS keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=44313

  • src/WebInputEventConversion.cpp: (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
12:02 PM BuildingQtOnOSX edited by ariya@webkit.org
mention QtXmlPatterns (diff)
11:49 AM Changeset in webkit [65746] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-08-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Slider labels do not update as you move the sliders on this page
​https://bugs.webkit.org/show_bug.cgi?id=41020

When repainting after layout in a multicol element, we need to adjust the
repaint rect for the columns.

Test: fast/repaint/multicol-repaint.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
11:33 AM Changeset in webkit [65745] by jianli@chromium.org
  • 8 edits
    1 copy
    1 move in trunk/WebCore

Move FileStreamClient to platform and add AsyncFileStream interface.
​https://bugs.webkit.org/show_bug.cgi?id=44224

Reviewed by David Levin.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStreamProxy.cpp: Account for the change.

(WebCore::FileStreamProxy::FileStreamProxy):
(WebCore::FileStreamProxy::stop):

  • html/FileStreamProxy.h: Make it derive from AsyncFileStream.h.
  • platform/AsyncFileStream.h: Added.
  • platform/FileStreamClient.h: Renamed from WebCore/html/FileStreamClient.h.
11:25 AM BuildingQtOnOSX edited by ariya@webkit.org
Fix for potential include problem (diff)
11:24 AM Changeset in webkit [65744] by leandro@webkit.org
  • 4 edits
    1 add in trunk

2010-08-20 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.

  • CMakeListsEfl.txt: Depend on Fontconfig, PNG, JPEG and dl libraries.

2010-08-20 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.

  • cmake/FindFontconfig.cmake: Added.
  • cmake/OptionsEfl.cmake: Find Fontconfig, JPEG, and PNG libraries.
11:12 AM Changeset in webkit [65743] by jcivelli@chromium.org
  • 6 edits
    7 deletes in trunk/WebKit/chromium

2010-08-20 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Removing the deprecated class WebEvent and friends.
​https://bugs.webkit.org/show_bug.cgi?id=44296

  • WebKit.gyp:
  • public/WebEvent.h: Removed.
  • public/WebEventListener.h: Removed.
  • public/WebMutationEvent.h: Removed.
  • public/WebNode.h:
  • src/EventListenerWrapper.cpp: (WebKit::EventListenerWrapper::webDOMEventListenerDeleted):
  • src/EventListenerWrapper.h:
  • src/WebEvent.cpp: Removed.
  • src/WebEventListener.cpp: Removed.
  • src/WebEventListenerPrivate.cpp: Removed.
  • src/WebEventListenerPrivate.h: Removed.
  • src/WebNode.cpp: (WebKit::WebNode::removeEventListener):
11:00 AM Changeset in webkit [65742] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-08-20 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Fisher.

Prevent use of stale notification presenter pointer in notifications by instead using
a notification center pointer and deriving the presenter from it. Notification presenter
gets properly destroyed using disconnectFrame function inside notification center. Add
null checks for notification presenter.
​https://bugs.webkit.org/show_bug.cgi?id=43645

Test: fast/notifications/notifications-window-close-crash.html

  • notifications/Notification.cpp: (WebCore::Notification::Notification): (WebCore::Notification::create): (WebCore::Notification::show): (WebCore::Notification::cancel): (WebCore::Notification::contextDestroyed): (WebCore::Notification::finishLoading):
  • notifications/Notification.h: (WebCore::Notification::detachPresenter):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):

2010-08-20 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Fisher.

Manual test to check that canceling the notification on a closed window does
not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=43645

  • fast/notifications/notifications-window-close-crash-expected.txt: Added.
  • fast/notifications/notifications-window-close-crash.html: Added.
10:50 AM Changeset in webkit [65741] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

r64526 broke the GTK+-3 build
​https://bugs.webkit.org/show_bug.cgi?id=44254

No new tests, as this is covered by manual-tests/cursor.html.

  • platform/gtk/CursorGtk.cpp: (WebCore::createPixmapFromBits): Added this method which turns the inline data structures into GdkPixmaps using Cairo and GDK-Cairo. (WebCore::createNamedCursor): Modified this method to use the new helper.
  • platform/gtk/CursorGtk.h: Changed all inline data structures to be unsigned char arrays (which Cairo requires). The progress cursor is known in X11 icon themes as "left_ptr_watch." This change to the name preserves the old behavior of taking this icon from the theme when available. It seems that this worked in the past due to a fluke or failure of the previous code.
10:24 AM Changeset in webkit [65740] by zmo@google.com
  • 14 edits in trunk

2010-08-19 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Fix failing WebGL tests in Chromium in-process-webgl port
​https://bugs.webkit.org/show_bug.cgi?id=44305

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): Add implementation.

2010-08-19 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Fix failing WebGL tests in Chromium in-process-webgl port
​https://bugs.webkit.org/show_bug.cgi?id=44305

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Add "#ifdef GLES" around precision keywords.
  • fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Re-enable the failing tests.
  • fast/canvas/webgl/gl-bind-attrib-location-test.html: Add "#ifdef GLES" around precision keywords.
  • fast/canvas/webgl/read-pixels-pack-alignment-expected.txt: Ditto.
  • fast/canvas/webgl/read-pixels-pack-alignment.html: Ditto.
  • fast/canvas/webgl/resources/fragmentShader.frag: Ditto.
  • fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
  • fast/canvas/webgl/texture-active-bind.html: Ditto.
  • fast/canvas/webgl/texture-complete.html: Ditto.
  • fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
  • platform/chromium/test_expectations.txt: Ditto.
10:13 AM Changeset in webkit [65739] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
​https://bugs.webkit.org/show_bug.cgi?id=44342

  • platform/gtk/Skipped: Skip failing tests.
10:07 AM Changeset in webkit [65738] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-08-20 John Gregg <​johnnyg@google.com>

Unreviewed, test expectations.

Add fail expectations for some SVG tests after r65729. See bug 44341.

  • platform/chromium/test_expectations.txt:
9:32 AM Changeset in webkit [65737] by Martin Robinson
  • 7 edits in trunk

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Pavel Feldman.

Web Inspector: Inspector tests were disabled for GTK.
​https://bugs.webkit.org/show_bug.cgi?id=43977

  • platform/gtk/Skipped: Unskip tests which should now be passing.

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Pavel Feldman.

Web Inspector: Inspector tests were disabled for GTK.
​https://bugs.webkit.org/show_bug.cgi?id=43977

Allow setting the inspector resources path via an environment variables
and add a method, inspectorFilesPath, to the WebKit InspectorClient that
encapsulates this logic.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to get the path to the resource. (WebKit::InspectorClient::inspectorFilesPath): Added. (WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method.
  • WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result.

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Pavel Feldman.

Web Inspector: Inspector tests were disabled for GTK.
​https://bugs.webkit.org/show_bug.cgi?id=43977

  • Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate path before running tests.
9:01 AM Changeset in webkit [65736] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-08-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Eliminate full-surface copy from canvas.drawImage(...)
​https://bugs.webkit.org/show_bug.cgi?id=44190

Covered by canvas layout tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::drawsUsingCopy): Return false now. (WebCore::ImageBuffer::clip): Add a link to the bug which tracks this feature. (WebCore::ImageBuffer::draw): Construct the bitmap image without the full-surface copy. (WebCore::ImageBuffer::drawPattern): Ditto.
8:13 AM Changeset in webkit [65735] by alex
  • 2 edits in trunk/WebCore

2010-08-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[REGRESSION] r65608 broke gtk distcheck
​https://bugs.webkit.org/show_bug.cgi?id=44333

Define the inspector.html as a noinst_DATA intead of using the dir
suffix, which is used for installation.

  • GNUmakefile.am:
8:07 AM Changeset in webkit [65734] by dbates@webkit.org
  • 4 edits in trunk/WebKitTools

2010-08-20 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

svn-apply doesn't detect empty line with Windows line endings
after property value
​https://bugs.webkit.org/show_bug.cgi?id=43981

Part 2 of 2

Add unit tests that were not landed in the first commit.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added the following test cases: "SVN: binary file (isBinary true) using Windows line endings" "SVN: property diff, followed by file change diff using Windows line endings" "SVN: two consecutive property diffs using Windows line endings" "SVN: binary file with executable bit change usng Windows line endings" "SVN: binary file followed by property change on different file using Windows line endings" "SVN: binary file followed by file change on different file using Windows line endings" "SVN: file change diff with property change, followed by property change diff using Windows line endings" "SVN: file change diff with property change, followed by file change diff using Windows line endings"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following test cases: "add svn:executable, followed by empty line and start of next diff using Windows line endings" "add svn:executable, followed by empty line and start of next property diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" "add svn:executable, followed by empty line and start of binary patch using Windows line endings" "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" "single-line '+' with trailing new line using Windows line endings" "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following test cases: "single-line '-' change followed by empty line with Windows line endings" "multi-line '+' change and start of binary patch with Windows line endings"
7:48 AM Changeset in webkit [65733] by demarchi@webkit.org
  • 2 edits in trunk/WebKit

2010-08-20 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix.

As opposed to WebCore, JavascriptCore and wtf, webkit is always a
shared library. After r65366, libewebkit.so was not being installed
anymore when building with SHARED_CORE=0 (which is the default). This
partially reverts that revision in order to fix this issue.

  • CMakeLists.txt: always install webkit library.
7:45 AM Changeset in webkit [65732] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-20 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

svn-apply doesn't detect empty line with Windows line endings
after property value
​https://bugs.webkit.org/show_bug.cgi?id=43981

Fixes an issue where an empty line following the property value
in an SVN property change diff would not be detected if it had
Windows line endings (i.e. ended in CRLF). Hence it was consumed
as if it was part of a multi-line property value.

  • Scripts/VCSUtils.pm:
    • Modified parseSvnPropertyValue() to detect empty line with Windows line endings.
    • Added toWindowsLineEndings().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added the following test cases: "SVN: binary file (isBinary true) using Windows line endings" "SVN: property diff, followed by file change diff using Windows line endings" "SVN: two consecutive property diffs using Windows line endings" "SVN: binary file with executable bit change usng Windows line endings" "SVN: binary file followed by property change on different file using Windows line endings" "SVN: binary file followed by file change on different file using Windows line endings" "SVN: file change diff with property change, followed by property change diff using Windows line endings" "SVN: file change diff with property change, followed by file change diff using Windows line endings"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following test cases: "add svn:executable, followed by empty line and start of next diff using Windows line endings" "add svn:executable, followed by empty line and start of next property diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" "add svn:executable, followed by empty line and start of binary patch using Windows line endings" "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" "single-line '+' with trailing new line using Windows line endings" "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following test cases: "single-line '-' change followed by empty line with Windows line endings" "multi-line '+' change and start of binary patch with Windows line endings"
6:38 AM Changeset in webkit [65731] by yurys@chromium.org
  • 12 edits in trunk

2010-08-19 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement breaking on DOM node subtree mutations.
​https://bugs.webkit.org/show_bug.cgi?id=42886

Add two entries to Web Inspector DOM element context menu:

  1. "Stop on subtree modifications": will break on adding/removing of any element which is a child of the DOM element
  2. "Remove breakpoints": will remove all breakpoints associated with the DOM element
  • English.lproj/localizedStrings.js:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::pauseOnBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/Settings.js:

2010-08-19 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: enable DOM breakpoints for chromium
​https://bugs.webkit.org/show_bug.cgi?id=42886

4:34 AM Changeset in webkit [65730] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2010-08-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: discard InjectedScript reference on ScriptState when clearing injected scripts
​https://bugs.webkit.org/show_bug.cgi?id=44328

Otherwise if the reference is not cleared we may remove InjectedScript from the
map on InjectedScriptHost but keep it on ScriptState and try to reuse it later.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::discardInjectedScript):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::discardInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.h: (WebCore::InjectedScript::scriptState):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::discardInjectedScripts):
  • inspector/InjectedScriptHost.h:
2:13 AM Changeset in webkit [65729] by Nikolas Zimmermann
  • 4 edits
    4 adds in trunk

2010-08-20 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Clippers are rasterized, when applied to scaled target object
​https://bugs.webkit.org/show_bug.cgi?id=44325

Use SVGImageBufferTools logic for RenderSVGResourceClipper, just like RenderSVGResourceMasker/Gradient,
to avoid pixelation, when the clipper is applied to a scaled target object, or when the document is scaled.

Test: svg/clip-path/clip-path-pixelation.svg

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext): (WebCore::RenderSVGResourceClipper::createClipData):
  • rendering/RenderSVGResourceClipper.h:

2010-08-20 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Clippers are rasterized, when applied to scaled target object
​https://bugs.webkit.org/show_bug.cgi?id=44325

  • platform/mac/svg/clip-path/clip-path-pixelation-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • svg/clip-path/clip-path-pixelation.svg: Added.
1:12 AM Changeset in webkit [65728] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-08-20 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Initialize GDK before loading plugins
​https://bugs.webkit.org/show_bug.cgi?id=44324

Attempt to call gdk_init_check() before loading any plugins.
This prevents various crashes and freezes in Adobe's Flash plugin.

  • plugins/qt/PluginPackageQt.cpp: (WebCore::initializeGdkIfPossible): (WebCore::PluginPackage::load):
12:58 AM Changeset in webkit [65727] by mitz@apple.com
  • 2 edits in trunk/WebCore

Follow-up to r41020.

Reviewed by Mark Rowe.

No change in behavior, thus no new tests.

  • platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Asserted that the NSFont parameter is not nil,
and removed nil check.
(WebCore::FontPlatformData::setFont): Asserted that the NSFont parameter is not nil and that
this is not the deleted value, and removed code to handle those cases.

Note: See TracTimeline for information about the timeline view.