Timeline
Aug 23, 2010:
- 11:54 PM Changeset in webkit [65866] by
-
- 2 edits in trunk/JavaScriptCore
[WINCE] Buildfix for GeneratedJITStubs after r64818
https://bugs.webkit.org/show_bug.cgi?id=44469
Patch by Patrick Gansterer <paroga@paroga.com> on 2010-08-23
Rubber-stamped by Gabor Loki.
Use " THUNK_RETURN_ADDRESS_OFFSET" instead of "#offset#".
- jit/JITStubs.cpp:
- 10:14 PM Changeset in webkit [65865] by
-
- 2 edits2 deletes in trunk/LayoutTests
2010-08-23 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
Removes the rebaselined results for special-key-events-in-input-text.html
because my test_shell change fixes it and produces the expected output.
https://bugs.webkit.org/show_bug.cgi?id=44156
- platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Removed.
- platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 9:20 PM Changeset in webkit [65864] by
-
- 3 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLScriptRunner::create
https://bugs.webkit.org/show_bug.cgi?id=44474
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/HTMLScriptRunner.h: (WebCore::HTMLScriptRunner::create):
- 9:01 PM Changeset in webkit [65863] by
-
- 3 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder should use adoptPtr
https://bugs.webkit.org/show_bug.cgi?id=44473
We should really use this pattern everywhere.
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
- 8:51 PM Changeset in webkit [65862] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Skip another test which shows one pixel differences between the 32-bit and 64-bit bot.
- platform/gtk/Skipped: Skip newly failing test.
- platform/gtk/svg/custom/recursive-filter-expected.txt: Removed.
- 8:49 PM Changeset in webkit [65861] by
-
- 3 edits in trunk/LayoutTests
Add tests to the Skipped list.
Rubber-stamped by Brady Eidson.
- platform/mac-wk2/Skipped:
- platform/win/Skipped:
- 8:43 PM Changeset in webkit [65860] by
-
- 4 edits1 add in trunk/WebKit/chromium
2010-08-23 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Made WebFrame not report the text from hidden frames.
(some pages contain hidden frames with garbage text that
should not be indexed or used to detect the page's language).
https://bugs.webkit.org/show_bug.cgi?id=39456
- WebKit.gyp:
- public/WebCString.h: (WebKit::operator<):
- public/WebURL.h: (WebKit::operator<):
- src/WebCString.cpp: (WebKit::WebCString::compare):
- src/WebFrameImpl.cpp: (WebKit::frameContentAsPlainText):
- tests/RunAllTests.cpp: (main):
- tests/WebFrameTest.cpp: Added.
- 8:25 PM Changeset in webkit [65859] by
-
- 2 edits in trunk/WebCore
2010-08-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Set the ResourceResponse HTTP headers in RessourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=44444
- platform/network/win/ResourceHandleWin.cpp: (WebCore::queryHTTPHeader): (WebCore::ResourceHandle::onRequestComplete):
- 8:24 PM Changeset in webkit [65858] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, removing a Chromium-specific expectation.
- platform/chromium-win/editing/execCommand/insert-list-xml-expected.txt: Removed.
- 8:04 PM Changeset in webkit [65857] by
-
- 4 edits in trunk/WebCore
2010-08-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Support all available biBitCount values in BitmapInfo
https://bugs.webkit.org/show_bug.cgi?id=43724
Add an enum with all possible values for biBitCount.
Also remove explicit initialization of bmiHeader members,
because that is already done in the constructor.
- platform/win/BitmapInfo.cpp: Added property svn:eol-style. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
- platform/win/BitmapInfo.h: Added property svn:eol-style. (WebCore::BitmapInfo::): (WebCore::BitmapInfo::bytesPerLine): (WebCore::BitmapInfo::paddedBytesPerLine): (WebCore::BitmapInfo::paddedWidth):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::paint):
- 7:30 PM Changeset in webkit [65856] by
-
- 6 edits in trunk
2010-08-23 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix for r65852.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create):
- rendering/TextControlInnerElements.h:
2010-08-23 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix for r65852.
- src/WebNode.cpp: (WebKit::WebNode::parentNode):
- 7:26 PM Changeset in webkit [65855] by
-
- 2 edits36 adds in trunk/LayoutTests
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Rebaseline new tests and skip tests which produce incorrect output.
- platform/gtk/Skipped:
- platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
- platform/gtk/fast/repaint/multicol-repaint-expected.txt: Added.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.txt.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.txt.
- platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
- platform/gtk/mathml/presentation/attributes-expected.txt: Added.
- platform/gtk/mathml/presentation/fenced-expected.txt: Added.
- platform/gtk/mathml/presentation/fractions-expected.txt: Added.
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/gtk/mathml/presentation/mo-expected.txt: Added.
- platform/gtk/mathml/presentation/over-expected.txt: Added.
- platform/gtk/mathml/presentation/roots-expected.txt: Added.
- platform/gtk/mathml/presentation/row-alignment-expected.txt: Added.
- platform/gtk/mathml/presentation/row-expected.txt: Added.
- platform/gtk/mathml/presentation/style-expected.txt: Added.
- platform/gtk/mathml/presentation/subsup-expected.txt: Added.
- platform/gtk/mathml/presentation/tokenElements-expected.txt: Added.
- platform/gtk/mathml/presentation/under-expected.txt: Added.
- platform/gtk/mathml/presentation/underover-expected.txt: Added.
- platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/gtk/svg/custom/convolution-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/convolution-crash-expected.txt.
- platform/gtk/svg/custom/marker-empty-path-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.txt.
- platform/gtk/svg/custom/path-zero-strokewidth-expected.txt: Added.
- platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
- platform/gtk/svg/custom/pattern-no-pixelation-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-no-pixelation-expected.txt.
- platform/gtk/svg/custom/recursive-filter-expected.txt: Added.
- platform/gtk/svg/custom/recursive-gradient-expected.txt: Added.
- platform/gtk/svg/custom/recursive-mask-expected.txt: Added.
- platform/gtk/svg/custom/recursive-pattern-expected.txt: Added.
- platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
- platform/gtk/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
- platform/gtk/svg/in-html/circle-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- 7:14 PM Changeset in webkit [65854] by
-
- 2 edits in trunk/WebCore
2010-08-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
MarkupAccumulator::appendStartMarkup should be broken down into pieces
https://bugs.webkit.org/show_bug.cgi?id=44288
Extracted appendText, appendComment, appendProcessingInstruction, appendElement and appendCDATASection.
Also simplified the conditionals in appendText.
No new tests are added since this is a cleanup.
- editing/markup.cpp: (WebCore::MarkupAccumulator::appendText): (WebCore::MarkupAccumulator::appendComment): (WebCore::MarkupAccumulator::appendProcessingInstruction): (WebCore::MarkupAccumulator::appendElement): (WebCore::MarkupAccumulator::appendCDATASection): (WebCore::MarkupAccumulator::appendStartMarkup):
- 6:49 PM Changeset in webkit [65853] by
-
- 5 edits in trunk
2010-08-23 Simon Fraser <Simon Fraser>
Reviewed by Alexey Proskuryakov.
TreeWalker is not calling acceptNode function in filter object
https://bugs.webkit.org/show_bug.cgi?id=35296
Fix incorrect shadowing of the 'function' variable, which could result
in badness when asking for arguments.callee.
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode):
- 6:39 PM Changeset in webkit [65852] by
-
- 23 edits in trunk
WebCore: Changed type of Node::parentNode to ContainerNode so we don't have to cast,
since parent are all containers.
Reviewed by Geoff Garen.
- css/CSSStyleSelector.h: Changed m_parentNode to ContainerNode*.
- dom/Document.h: Fixed the type of TreeShared in the Node constructor.
Yes, it's here.
- dom/Node.cpp:
(WebCore::Node::eventParentNode): Removed now-unneeded typecast dance.
(WebCore::eventTargetAsSVGElementInstance):Changed type to ContainerNode*.
- dom/Node.h: Made Node inherit from TreeShared<ContainerNode> instead of
from TreeShared<Node>. Removed bogus comment. Changed return type of parentNode
and shadowParentNode functions to ContainerNode*. Fixed using to use
TreeShared<ContainerNode>.
- dom/Position.h: Include ContainerNode.h instead of Node.h.
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::findFosterSite): Removed now-unneeded typecast.
- rendering/MediaControlElements.h:
- rendering/SVGShadowTreeElements.h:
- rendering/TextControlInnerElements.h:
Changed return type of shadowParentNode functions to ContainerNode.
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updatePartsState): Cast the node to HTMLElement* before
passing it to the function that creates the shadow element. We know the node is
a HTMLMeterElement, but the node function doesn't know that.
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updatePartsState): Ditto.
- rendering/RenderSlider.cpp:
(WebCore::SliderThumbElement::SliderThumbElement): More of the same.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::RenderSlider::updateFromElement): Ditto.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createSubtreeIfNeeded): Ditto.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Ditto.
- rendering/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Ditto.
(WebCore::SVGShadowTreeRootElement::shadowParentNode): Ditto.
- rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::create): Ditto.
(WebCore::ShadowBlockElement::ShadowBlockElement): Ditto.
(WebCore::ShadowBlockElement::createForPart): Ditto.
(WebCore::ShadowInputElement::create): Ditto.
(WebCore::ShadowInputElement::ShadowInputElement): Ditto.
- rendering/ShadowElement.h:
(WebCore::ShadowElement::ShadowElement): Ditto.
(WebCore::ShadowElement::shadowParent): Ditto.
(WebCore::ShadowElement::shadowParentNode): Ditto.
- rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement): Ditto.
(WebCore::TextControlInnerElement::create): Ditto.
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement): Ditto.
(WebCore::TextControlInnerTextElement::create): Ditto.
(WebCore::SpinButtonElement::SpinButtonElement): Ditto.
(WebCore::SpinButtonElement::create): Ditto.
- svg/SVGElement.cpp:
(WebCore::SVGElement::eventParentNode): Removed now-unneeded typecast.
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Changed type to ContainerNode*.
WebKit2: * WebProcess/InjectedBundle/API/c/WKBundleNode.cpp:
(WKBundleNodeGetParent): Update since parent now returns a
ContainerNode*. The toRef function is a bit too picky to convert
it without a bit of help.
Reviewed by Geoff Garen.
- 6:25 PM Changeset in webkit [65851] by
-
- 3 edits in trunk/WebCore
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The Mozilla theme drawing code incorrectly renders scrollbar backgrounds
https://bugs.webkit.org/show_bug.cgi?id=44388
No new tests as this functionality is currently unused. When the
the new scrollbar theme code lands for GTK+, this will be tested
by scrollbar pixel tests.
- platform/gtk/gtk2drawing.c: Expose a method to paint scrolled window backgrounds and disable incorrect rendering of scrollbar trough backgrounds. (moz_gtk_scrolled_window_paint): Added. (moz_gtk_scrollbar_trough_paint): Disable incorrect background render.
- platform/gtk/gtkdrawing.h: Add scrolled window widget type in the enum.
- 6:23 PM Changeset in webkit [65850] by
-
- 3 edits in trunk/WebCore
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The Mozilla theme drawing API should expose extra information about scrollbar geometry
https://bugs.webkit.org/show_bug.cgi?id=44385
Expose the trough_under_steppers property in MozGtkScrollbarMetrics.
No new tests as this does not change functionality.
- platform/gtk/gtk2drawing.c: Set the trough_under_steppers member when accessing theme data.
- platform/gtk/gtkdrawing.h: Add the trough_under_steppers member.
- 5:44 PM Changeset in webkit [65849] by
-
- 6 edits in trunk/WebCore
Parser DOM tree manipulation functions do not need to be virtual.
Reviewed by Geoff Garen.
- dom/ContainerNode.h: Made parserAddChild, parserRemoveChild, and
parserInsertBefore non-virtual.
- dom/Node.cpp: Removed the parserAddChild, parserRemoveChild, and
parserInsertBefore functions, which should never have been in the Node class.
- dom/Node.h: Ditto.
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach): Changed argument type to ContainerNode*
because we never need to attach a child to a non-container node.
(WebCore::HTMLConstructionSite::findFosterSite): Cast the result of the parent
function to ContainerNode*. A parent is always guaranteed to be a container, but
the parent function returns a Node* so that callers can use it without including
ContainerNode's header. That seems like something we can easily fix later.
- html/HTMLConstructionSite.h: Changed AttachmentSite::parent and the
attach function to ContainerNode* instead of Node*.
- 5:29 PM Changeset in webkit [65848] by
-
- 2 edits in trunk/LayoutTests
2010-08-23 Adam Barth <abarth@webkit.org>
Update the expected results for this test. I think the new expected
results are better than the old ones, but we'll check with some editing
folks to be sure.
- editing/execCommand/insert-list-xml-expected.txt:
- 5:04 PM Changeset in webkit [65847] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-23 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
[REGRESSION] Interpreter incorrectly excludes prototype chain when validating put_by_id_transition
https://bugs.webkit.org/show_bug.cgi?id=44240
<rdar://problem/8328995>
Fix an error I introduced when cleaning up the interpreter side of the logic
to prevent setters being called in object initialisers.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- 4:55 PM Changeset in webkit [65846] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium/test_expectations.txt:
- 4:52 PM Changeset in webkit [65845] by
-
- 2 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/bad-placeholder.html fails with --html5-treebuilder
https://bugs.webkit.org/show_bug.cgi?id=44463
The problem here is that using the documentElement as the context puts
the tree builder into the BeforeHead insertion mode, which strips
leading spaces. This code is confused about what it wants, but it
certainly doesn't want to be in that insertion mode. Looking through
the callers, they'd much rather be in the InBody insertion mode. We
can get them there by creating a fake body element as the context
element.
In the long term, all this code needs to be changed to move away from
deprecatedCreateContextualFragment, which does a bunch of nasty stuff
like removing certain kinds of elements. However, that's a battle for
another day.
- editing/markup.cpp: (WebCore::createFragmentFromMarkup):
- 4:49 PM Changeset in webkit [65844] by
-
- 2 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
fast/xsl/default-html.html fails with HTML5 fragment parsing
https://bugs.webkit.org/show_bug.cgi?id=44450
This patch is a step down a trail of tears. As far as I can tell,
there's no spec for XSLTProcessor.transformToFragment. This patch
attempts to infer the proper behavior from test cases and the Mozilla
wiki.
- xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
- 4:48 PM Changeset in webkit [65843] by
-
- 3 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
editing/pasteboard/paste-visible-script.html is broken with --html5-treebuilder
https://bugs.webkit.org/show_bug.cgi?id=44457
Turns out there are two more checks we need for fragment scripting
permission. Not the most beautiful design, but it seems work.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertScriptElement):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
- 4:44 PM Changeset in webkit [65842] by
-
- 5 edits in trunk/WebCore
2010-08-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
fast/dom/script-innerHTML-x.xhtml fails when run with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=44447
This special handling for script/style used to exist in
setInnerHTML. HTML5 moves this logic into the HTML and XML
parsers instead of in setInnerHTML.
In order to share this logic between WebKit's two XML parsers
I had to clean up a bit of the libxml2 parser and add a
new appendFragmentSource method.
Covered by fast/dom/script-innerHTML-x.xhtml.
- dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end):
- Now that libxml2 is calling finish() for fragments (Qt already was) I went through and removed this unneeded style update after fragment parsing.
(WebCore::XMLDocumentParser::parseDocumentFragment):
- Yay for shared code!
- This is where I added the style/script hack moved from setInnerHTML.
- dom/XMLDocumentParser.h:
- Fix indent.
- dom/XMLDocumentParserLibxml2.cpp:
- Removed parseDocumentFragment and moved necessary libxml-specific logic into appendFragmentSource.
(WebCore::XMLDocumentParser::appendFragmentSource):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::appendFragmentSource):
- 4:32 PM Changeset in webkit [65841] by
-
- 2 edits in trunk/WebKitTools
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
https://bugs.webkit.org/show_bug.cgi?id=44465
Initialize the axes field of mouse button and motion events to null.
This is the value that should be used for events originating from the
mouse device.
- DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Initalize button event axes field to null. (mouseMoveToCallback): Initialize motion event axes field to null.
- 4:12 PM Changeset in webkit [65840] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-23 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Fixed case where a single character search string in a string.replace()
did not properly handle back reference replacement. The fix is to
check for a '$' as part of the check to see if we can execute the
single character replace optimization.
https://bugs.webkit.org/show_bug.cgi?id=44067
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace):
- 4:07 PM Changeset in webkit [65839] by
-
- 11 edits in trunk
2010-08-23 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44455
Updated Safari, Qt and Chromium WebGL ports to avoid referencing
ArrayBuffer and ArrayBufferView types from GraphicsContext3D.
Ran all WebGL layout tests; no new regressions. Built and tested
WebKit on Mac OS X; built Chromium on Mac OS X and Linux.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):
2010-08-23 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44455
Updated Safari, Qt and Chromium WebGL ports to avoid referencing
ArrayBuffer and ArrayBufferView types from GraphicsContext3D.
Ran all WebGL layout tests; no new regressions. Built and tested
WebKit on Mac OS X; built Chromium on Mac OS X and Linux.
- html/canvas/WebGLBuffer.cpp:
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractTextureData):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::getQuadVertices):
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
- 3:59 PM Changeset in webkit [65838] by
-
- 4 edits in trunk
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65703.
http://trac.webkit.org/changeset/65703
https://bugs.webkit.org/show_bug.cgi?id=44460
"Causing lots of crashes on Snow Leopard when running the
layout tests" (Requested by eseidel2 on #webkit).
- WebProcess/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad):
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65703.
http://trac.webkit.org/changeset/65703
https://bugs.webkit.org/show_bug.cgi?id=44460
"Causing lots of crashes on Snow Leopard when running the
layout tests" (Requested by eseidel2 on #webkit).
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Initialize): (NP_GetEntryPoints):
- 3:30 PM Changeset in webkit [65837] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating some Chromium expectations.
- platform/chromium/test_expectations.txt:
- 3:23 PM Changeset in webkit [65836] by
-
- 4 edits in trunk/WebCore
2010-08-20 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
[CHROMIUM] Fix some failing layout tests w/ACCELERATED_2D_CANVAS
https://bugs.webkit.org/show_bug.cgi?id=44346
LayoutTests/fast/canvas/canvas-incremental-repaint.html (top middle
pane).
Failing because we were not applying the CTM in clearRect(). Now using
the fast path when the CTM is identity, and a fillRect() for the rest.
LayoutTests/fast/canvas/canvas-strokeRect.html
LayoutTests/fast/canvas/shadow-offset-[1-7].html
Failing because we weren't switching to the software path when a
shadow is present.
Also refactor the two versions of fillRect(), and use TRIANGLE_STRIP
strip instead of TRIANGLES, which lets us get rid of the element array
and use drawArrays() instead of drawElements().
Covered by the above layout tests.
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): Remove m_quadIndices (now unused). (WebCore::GLES2Canvas::clearRect): Use a glClear() fast path for the identity-CTM clear, and fillRect() for the rest. (WebCore::GLES2Canvas::fillRect): Refactor the two versions of fillRect(). (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): Get rid of the ELEMENT_ARRAY_BUFFER bind. Use drawArrays() instead of drawElements(). (WebCore::GLES2Canvas::getQuadVertices): Re-order the vertices so they form a triangle strip.
- platform/graphics/chromium/GLES2Canvas.h: Remove m_quadIndices (now unused).
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect): Check for a draw looper (shadow), and drop to the software path.
- 3:12 PM Changeset in webkit [65835] by
-
- 3 edits in trunk/WebCore
2010-08-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Move filehandling into fileLoadTimer callback
https://bugs.webkit.org/show_bug.cgi?id=43714
Also add mimetype detection for local files.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer):
- 2:59 PM Changeset in webkit [65834] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-23 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSON.stringify is much slower than Firefox on particular pathological input
https://bugs.webkit.org/show_bug.cgi?id=44456
Make StringBuilder::reserveCapacity reserve additional space so we don't end up
repeatedly copying the entire result string.
- runtime/StringBuilder.h: (JSC::StringBuilder::append): (JSC::StringBuilder::reserveCapacity):
- 2:52 PM Changeset in webkit [65833] by
-
- 6 edits in trunk/WebCore
2010-08-23 Iain Merrick <husky@google.com>
Reviewed by Steve Block.
Update JNI bridge for V8 after renaming of JavaString::utf8().
https://bugs.webkit.org/show_bug.cgi?id=44419
This fixes the build on Android. No new functionality, so no new tests.
- bridge/jni/v8/JNIBridgeV8.cpp: (JavaField::JavaField):
- bridge/jni/v8/JNIBridgeV8.h: (JSC::Bindings::JavaField::type):
- bridge/jni/v8/JavaClassV8.cpp: (JavaClass::JavaClass):
- bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectGetProperty):
- bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::utf8):
- 2:31 PM Changeset in webkit [65832] by
-
- 4 edits3 adds in trunk
2010-08-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Hyatt.
Assertion failure in FrameView::layout when modifying the DOM during
pagehide with PageCache enabled
https://bugs.webkit.org/show_bug.cgi?id=43152
Always unschedule any pending relayouts when changing the view, not just
when we're not using the page cache. Otherwise touching the DOM during
the pagehide handler can lead to layouts that will be done by the time
the view has changed, which triggers an assert.
- fast/loader/resources/unschedule-relayout-after-unload-target.html: Added.
- fast/loader/unschedule-relayout-after-unload-expected.txt: Added.
- fast/loader/unschedule-relayout-after-unload.html: Added.
2010-08-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Hyatt.
Assertion failure in FrameView::layout when modifying the DOM during
pagehide with PageCache enabled
https://bugs.webkit.org/show_bug.cgi?id=43152
Always unschedule any pending relayouts when changing the view, not just
when we're not using the page cache. Otherwise touching the DOM during
the pagehide handler can lead to layouts that will be done by the time
the view has changed, which triggers an assert.
Test: fast/loader/unschedule-relayout-after-unload.html
- page/Frame.cpp: (WebCore::Frame::setView): move unscheduleRelayout outside page cache check.
- page/FrameView.cpp: (WebCore::FrameView::layout): remove early return now that assert should be correct (and the referenced rdar:// got fixed).
- 2:29 PM Changeset in webkit [65831] by
-
- 4 edits in trunk
Layout tests do not run when using WebKitTestRunner in a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=44409
Reviewed by Dan Bernstein.
WebKit2:
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use WebKit2WebProcess_debug.exe when building Debug.
WebKitTools:
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath):
Use InjectedBundle_debug.dll when building Debug.
- 2:27 PM Changeset in webkit [65830] by
-
- 3 edits in trunk/LayoutTests
Add more tests to the WebKit2 skipped lists.
Rubber-stamped by Mark Rowe.
- platform/mac-wk2/Skipped:
- platform/win-wk2/Skipped:
- 1:43 PM Changeset in webkit [65829] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65812.
http://trac.webkit.org/changeset/65812
https://bugs.webkit.org/show_bug.cgi?id=44451
Broke fast/events/special-key-events-in-input-text.html for
chromium (Requested by jamesr on #webkit).
- platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Added.
- platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Added.
- 1:20 PM Changeset in webkit [65828] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=43989
Added a test for MakeTextWritingDirectionNatural, MakeTextWritingDirectionLeftToRight,
and MakeTextWritingDirectionRightToLeft commands.
- editing/style/make-text-writing-direction-inline.html: Added.
- editing/style/script-tests/make-text-writing-direction-inline.js: Added. (modifyWritingDirection): (selectFirstWord): (selectSecondAndThirdWords):
- 1:09 PM Changeset in webkit [65827] by
-
- 19 edits2 adds in trunk
Handle blob resource.
https://bugs.webkit.org/show_bug.cgi?id=43941
Reviewed by Darin Fisher.
- JavaScriptCore.exp: Add an export that is neede by BlobResourceHandle.
WebCore:
To provide lower level blob reosurce handling for all possible ports,
BlobResourceHandle derived from ResourceHandle is implemented. It provides
both synchronous and asynchronous resource loading for blob URL.
BlobResourceHandle needs to create a FileStreamProxy instance in order to
asynchronous file stream operation. To achive this, a hook createAsyncFileStream
is added to ResourceHandleClient interface. When ResourceLoader implements
ths hook, it creates and returns FileStreamProxy.
BlobResourceHandle.* is not added to chromium port since it will implement
its own blob resource handling.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::createAsyncFileStream): Create and return FileStreamProxy.
- loader/ResourceLoader.h:
- page/SecurityOrigin.cpp: Add the support to get and validate the origin of blob URL.
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::canLoad):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems): Fix a bug that the length is not subtracted.
- platform/network/BlobResourceHandle.cpp: Added.
- platform/network/BlobResourceHandle.h: Added.
- platform/network/HTTPParsers.cpp:
(WebCore::parseRange):
- platform/network/HTTPParsers.h:
- platform/network/ResourceHandle.cpp: Hook up with asynchronous blob resource handling.
(WebCore::ResourceHandle::create):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::createAsyncFileStream): Add a hook.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadResourceSynchronously): Hook up with synchronous blob resource handling.
- 1:03 PM Changeset in webkit [65826] by
-
- 3 edits2 adds in trunk
2010-08-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Fix security origin calculation in createPattern. Need to use
cachedImage->response().url() instead of cachedImage->url().
https://bugs.webkit.org/show_bug.cgi?id=44399.
Test: http/tests/security/canvas-remote-read-remote-image-redirect.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
2010-08-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that calling getImageData(), toDataURL() on a canvas tainted by
a createPattern of a different origin image using redirects from same origin
is not allowed.
https://bugs.webkit.org/show_bug.cgi?id=44399
- http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt: Added.
- http/tests/security/canvas-remote-read-remote-image-redirect.html: Added.
- 12:27 PM Changeset in webkit [65825] by
-
- 1 edit1 add in trunk/LayoutTests
2010-08-23 Simon Fraser <Simon Fraser>
Add missing test result.
- platform/mac/fast/table/simple_paint-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.txt.
- 12:22 PM Changeset in webkit [65824] by
-
- 3 edits3 adds in trunk
2010-08-23 Simon Fraser <Simon Fraser>
Reviewed by Alexey Proskuryakov.
TreeWalker is not calling acceptNode function in filter object
https://bugs.webkit.org/show_bug.cgi?id=35296
We only accepted raw functions as the NodeFilter on TreeWalker. Fix this to
look for an 'acceptNode' function on the filter object, and use that if present.
Also throw an exception if the filter object does not have an acceptNode function.
Test: fast/dom/TreeWalker/acceptNode-filter.html
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode):
- 12:18 PM Changeset in webkit [65823] by
-
- 3 edits3 deletes in trunk
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65814.
http://trac.webkit.org/changeset/65814
https://bugs.webkit.org/show_bug.cgi?id=44443
broke svg/custom/missing-xlink.svg (Requested by kling on
#webkit).
- fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
- fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
- fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed.
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65814.
http://trac.webkit.org/changeset/65814
https://bugs.webkit.org/show_bug.cgi?id=44443
broke svg/custom/missing-xlink.svg (Requested by kling on
#webkit).
- dom/Element.cpp: (WebCore::Element::setAttributeNS):
- 12:10 PM Changeset in webkit [65822] by
-
- 2 edits in trunk/WebKitSite
Clean up some HTML typos in crashlogs.html
Rubber-stamped by Maciej Stachowiak.
- quality/crashlogs.html: Fixed "</code>>" typos added in
r56300. Changed "<tt>" tag with style attribute to "<code>"
that was missed in r56300.
- 11:59 AM Changeset in webkit [65821] by
-
- 4 edits in trunk
Remove unneeded BlobRegistryImpl.* and WebBlobRegistryImpl.* from
chromium project files.
https://bugs.webkit.org/show_bug.cgi?id=44442
Reviewed by David Levin.
WebCore:
- WebCore.gypi:
WebKit/chromium:
- WebKit.gyp:
- 11:28 AM Changeset in webkit [65820] by
-
- 2 edits in trunk/WebKit/mac
WebPDFView should remove itself as the delegate of its PDFView before being dealloced
https://bugs.webkit.org/show_bug.cgi?id=44441
Reviewed by Dan Bernstein.
- WebView/WebPDFView.mm:
(-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
- 11:12 AM Changeset in webkit [65819] by
-
- 2 edits in trunk/WebCore
2010-08-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Many LayoutTests crash when run with --html5-treebuilder
https://bugs.webkit.org/show_bug.cgi?id=44440
Our list of special tags is out of sync with the HTML5 spec. This
patch adds HTML to the list, which fixs a ton of crashers when parsing
fragments. We neet to sync up the list at some point, but we want to
make sure we have test coverage for all those changes, so I've left
that for a future patch.
- html/HTMLTreeBuilder.cpp:
- 10:58 AM Changeset in webkit [65818] by
-
- 2 edits in trunk/WebKit/efl
2010-08-23 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix for platforms that do not require linking with "dl".
CMake includes the variable CMAKE_DL_LIBS that evaluates to the
platform-specific libraries.
- CMakeListsEfl.txt: Use ${CMAKE_DL_LIBS} instead of dl.
- 9:56 AM Changeset in webkit [65817] by
-
- 2 edits in trunk/WebKit2
2010-08-23 Daniel Bates <dbates@rim.com>
Rubber-stamped by Adam Roben.
Substitute "sizeof("javascript:") - 1" for the hardcoded constant 11 when
extracting the JavaScript code portion of a JavaScript URL so as to make
it clearer that the 11 represents the length of the scheme portion of
a JavaScript URL.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest):
- 9:54 AM Changeset in webkit [65816] by
-
- 2 edits in trunk/WebCore
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Context menu in Scripts panel was broken.
https://bugs.webkit.org/show_bug.cgi?id=44431
- inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared):
- 9:37 AM Changeset in webkit [65815] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-23 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=44421
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
- public/WebSpeechInputListener.h:
- 9:34 AM Changeset in webkit [65814] by
-
- 3 edits3 adds in trunk
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
https://bugs.webkit.org/show_bug.cgi?id=44432
Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html
- dom/Element.cpp: (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null and the qualifiedName has a prefix.
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
https://bugs.webkit.org/show_bug.cgi?id=44432
- fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
- fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
- fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.
- 9:18 AM Changeset in webkit [65813] by
-
- 3 edits in trunk/WebCore
2010-08-23 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] rendering was broken when missing plugin.
https://bugs.webkit.org/show_bug.cgi?id=43395
Implement RenderThemeEfl::systemFont to render "Missing plugin" when we
don't have proper plugin.
In this case, RenderEmbeddedObject::paintReplaced call systemFont and
pass returned font to GraphicsContext.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::setDefaultFontSize): (WebCore::RenderThemeEfl::systemFont):
- platform/efl/RenderThemeEfl.h:
- 8:30 AM Changeset in webkit [65812] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-08-23 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
Removes the rebaselined results for special-key-events-in-input-text.html
because my test_shell change fixes it and produces the expected output.
https://bugs.webkit.org/show_bug.cgi?id=44156
- platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Removed.
- platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Removed.
- 8:20 AM Changeset in webkit [65811] by
-
- 2 edits in trunk/WebKitTools
2010-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
https://bugs.webkit.org/show_bug.cgi?id=42026
If a GTK+ 3.x build is present return that as the library to use,
otherwise fallback to the GTK+ 2.x build.
- Scripts/webkitdirs.pm:
- 7:40 AM Changeset in webkit [65810] by
-
- 5 edits in trunk/WebCore
2010-08-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=44327
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpoint): (WebInspector.BreakpointManager.prototype._removeBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.Breakpoint):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.JSBreakpointItem): (WebInspector.JSBreakpointItem.prototype.compareTo): (WebInspector.JSBreakpointItem.prototype.element): (WebInspector.JSBreakpointItem.prototype._breakpointClicked): (WebInspector.JSBreakpointItem.prototype._checkboxClicked): (WebInspector.JSBreakpointItem.prototype._enableChanged): (WebInspector.JSBreakpointItem.prototype._textChanged): (WebInspector.JSBreakpointItem.prototype._removed):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype._addBreakpointToSource):
- 7:07 AM Changeset in webkit [65809] by
-
- 9 edits in trunk/WebCore
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: inspector protocol should be switched from array based
message format to object based message format.
Almost all the protocol related things is generated by CodeGeneratorInspector.pm
It was changed a bit. As result InspectorBackendStub.js wraps the
calls into Request objects. InspectorBackendDispatcher.cpp unwraps
these objects and calls corresponding agents. These two files and
RemoteInspectorFrontend are generated by CodeGeneratorInspector.pm
Dispatching part of WebInspector also was adjusted for handling Event
objects produced by RemoteInspectorFrontend.cpp and Response objects
produced by InspectorBackendDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=44338
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setAttachedWindow):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
- inspector/InspectorValues.h: (WebCore::InspectorObject::find):
- inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processResponse):
- inspector/front-end/inspector.js: (WebInspector.dispatch): (WebInspector_syncDispatch): (WebInspector.dispatchMessageFromBackend): (WebInspector.reportProtocolError):
- 6:58 AM Changeset in webkit [65808] by
-
- 5 edits1 add in trunk
2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Find needed forwarding headers for WebKit2 automatically
https://bugs.webkit.org/show_bug.cgi?id=44336
- MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here. The new script does not satisfy the needs of this file however using normal includes is generally better here.
- MiniBrowser/qt/MiniBrowser.pro: Added include paths.
- Scripts/enumerate-included-framework-headers: Enumerates headers included from the given frameworks by files in the current directory (and subdirectories). In the future this needs to be rewritten in perl for being able to use on Windows.
2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Find needed forwarding headers for WebKit2 automatically
https://bugs.webkit.org/show_bug.cgi?id=44336
- DerivedSources.pro: Use the new enumerate-included-framework-headers script for generating the list of forwarding headers we want to create.
- 6:23 AM Changeset in webkit [65807] by
-
- 8 edits3 deletes in trunk
2010-08-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Remove IDBDatabase.description per spec changes
https://bugs.webkit.org/show_bug.cgi?id=44264
Update layout tests to match changes. One layout test is now
obsolete.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-description-expected.txt: Removed.
- storage/indexeddb/database-description.html: Removed.
- storage/indexeddb/script-tests/database-basics.js: (openSuccess):
- storage/indexeddb/script-tests/database-description.js: Removed.
2010-08-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Remove IDBDatabase.description per spec changes
https://bugs.webkit.org/show_bug.cgi?id=44264
There's now no longer any way to access the description from JS.
The main premise of the manual test is now obsolete. Over time we'll
be able to add to it again. While I'm at it, I cleaned up the format
of the manual test to be easier to follow (code and usage wise).
- manual-tests/indexed-database.html:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase):
- storage/IDBDatabase.h:
- storage/IDBDatabase.idl:
- 6:06 AM WinCE edited by
- (diff)
- 5:49 AM Changeset in webkit [65806] by
-
- 3 edits in trunk/WebCore
2010-08-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: element's css: pseudo-class locations
https://bugs.webkit.org/show_bug.cgi?id=44344
Also contains a drive-by fix for 44301 (gray out read-only).
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylePropertiesSection):
- 5:34 AM Changeset in webkit [65805] by
-
- 3 edits2 adds in trunk/WebKit2
[Qt] Build fix.
- DerivedSources.pro:
- WebKit2.pro:
- WebProcess/Plugins/Netscape/qt: Added.
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Added.
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::toNP):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- 5:28 AM Changeset in webkit [65804] by
-
- 9 edits in trunk/WebCore
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65803.
http://trac.webkit.org/changeset/65803
https://bugs.webkit.org/show_bug.cgi?id=44416
windows build failed (Requested by loislo on #webkit).
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
- inspector/InspectorValues.h:
- inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processResponse):
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch): (WebInspector_syncDispatch): (WebInspector.dispatchMessageFromBackend): (WebInspector.reportProtocolError):
- 5:14 AM Changeset in webkit [65803] by
-
- 9 edits in trunk/WebCore
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: inspector protocol should be switched from array based
message format to object based message format.
Almost all the protocol related things is generated by CodeGeneratorInspector.pm
It was changed a bit. As result InspectorBackendStub.js wraps the
calls into Request objects. InspectorBackendDispatcher.cpp unwraps
these objects and calls corresponding agents. These two files and
RemoteInspectorFrontend are generated by CodeGeneratorInspector.pm
Dispatching part of WebInspector also was adjusted for handling Event
objects produced by RemoteInspectorFrontend.cpp and Response objects
produced by InspectorBackendDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=44338
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setAttachedWindow):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
- inspector/InspectorValues.h: (WebCore::InspectorObject::find):
- inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processResponse):
- inspector/front-end/inspector.js: (WebInspector.dispatch): (WebInspector_syncDispatch): (WebInspector.dispatchMessageFromBackend): (WebInspector.reportProtocolError):
- 5:09 AM Changeset in webkit [65802] by
-
- 2 edits in trunk/WebCore
2010-08-23 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Make the copy of the inspector files silent.
- GNUmakefile.am:
- 4:44 AM Changeset in webkit [65801] by
-
- 3 edits in trunk/WebCore
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] -webkit-text-stroke is broken due to Qt::TextBypassShaping
https://bugs.webkit.org/show_bug.cgi?id=44403
Don't bypass the Harfbuzz shaping if we're drawing text with a stroke.
For canvas, always use complex text shaping since stroke and fill are decoupled.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::measureText): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
- 4:35 AM Changeset in webkit [65800] by
-
- 2 edits in trunk/LayoutTests
2010-08-23 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed change to drt_expectations.txt.
Add new entry to platform/chromium/drt_expectations.txt
- platform/chromium/drt_expectations.txt:
- 2:49 AM Changeset in webkit [65799] by
-
- 7 edits3 adds in trunk/LayoutTests
2010-08-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add DOM breakpoints test
https://bugs.webkit.org/show_bug.cgi?id=44251
- http/tests/inspector/debugger-test2.js: Added. (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._scriptsAreParsed): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest):
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest): (initialize_InspectorTest.): (runTest.runTestInFrontend): (runTest):
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/dom-breakpoints-expected.txt: Added.
- inspector/dom-breakpoints.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:38 AM Changeset in webkit [65798] by
-
- 2 edits in trunk/LayoutTests
2010-08-23 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping more media tests
[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235
- platform/gtk/Skipped: Skip media/video-zoom-controls.html and media/adopt-node-crash.html
- 2:35 AM Changeset in webkit [65797] by
-
- 16 edits2 adds in trunk/WebCore
2010-08-23 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Extract profiler-related code and data from InspectorController into
InspectorProfilerAgent.
- 1:10 AM Changeset in webkit [65796] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Allow wmode=transparent in QWebView on Maemo5 after r65775.
https://bugs.webkit.org/show_bug.cgi?id=44043
Reviewed by Ariya Hidayat.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
- 12:59 AM Changeset in webkit [65795] by
-
- 2 edits in trunk/WebCore
[Qt] Crash when purging the scratch buffer for the shadow
https://bugs.webkit.org/show_bug.cgi?id=44384
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-23
Reviewed by Kenneth Rohde Christiansen.
WebCore::Timer can't be used in a static object bcause it relies on
thread global data, which is invalid once the application instance is
destroyed. To overcome the problem, use QObject's timer support for
the ShadowBuffer class.
- platform/graphics/qt/ContextShadow.cpp:
(WebCore::):
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::schedulePurge):
(WebCore::ShadowBuffer::timerEvent):
Aug 22, 2010:
- 11:27 PM Changeset in webkit [65794] by
-
- 2 edits in trunk/LayoutTests
2010-08-22 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt:
- 11:11 PM Changeset in webkit [65793] by
-
- 4 edits in trunk/WebCore
2010-08-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] don't expose the private player in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=44332
Only a pointer to our playbin2 element instance is required
instead of the whole MediaPlayerPrivateGStreamer instance.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::createGWorld): (WebCore::GStreamerGWorld::GStreamerGWorld): (WebCore::GStreamerGWorld::~GStreamerGWorld): (WebCore::GStreamerGWorld::enterFullscreen): (WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/GStreamerGWorld.h: (WebCore::GStreamerGWorld::pipeline):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- 8:50 PM Changeset in webkit [65792] by
-
- 3 edits in trunk/WebKitTools
2010-08-22 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
https://bugs.webkit.org/show_bug.cgi?id=43010
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::applyPrefs):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 5:52 PM Changeset in webkit [65791] by
-
- 2 edits in trunk/WebCore
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext: Simplify getting the clip bounding rect
https://bugs.webkit.org/show_bug.cgi?id=44396
Move the Qt 4.8 version check for QPainter::clipBoundingRect()
into a GraphicsContextPlatformPrivate method.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
- 5:30 PM Changeset in webkit [65790] by
-
- 2 edits in trunk/WebKit/efl
2010-08-22 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Remove duplicated include entry from default theme.
https://bugs.webkit.org/show_bug.cgi?id=44345
This used to create the group webkit/widget/entry twice in
the theme. It's leading to a bug with the newer versions of
EFL.
- DefaultTheme/default.edc:
- 5:14 PM Changeset in webkit [65789] by
-
- 2 edits in trunk/WebKit/qt
2010-08-22 Marc Mutz <marc.mutz@kdab.com>
Reviewed by Antonio Gomes.
[Qt] Actually emit the QWebView::selectionChanged() signal
- Api/qwebview.cpp: (QWebView::setPage): Connect QWebPage::selectionChanged() to QWebView::selectionChanged()
- 3:42 PM Changeset in webkit [65788] by
-
- 18 edits in trunk
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
- DerivedSources.pro:
- Shared/CoreIPCSupport/WebPageMessageKinds.h: (WebPageMessage::):
- Shared/WebEvent.h: (WebKit::WebEvent::): (WebKit::WebTouchPoint::): (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::id): (WebKit::WebTouchPoint::state): (WebKit::WebTouchPoint::screenPosX): (WebKit::WebTouchPoint::screenPosY): (WebKit::WebTouchPoint::posX): (WebKit::WebTouchPoint::posY): (WebKit::WebTouchPoint::setState): (WebKit::WebTouchPoint::encode): (WebKit::WebTouchPoint::decode): (WebKit::WebTouchEvent::WebTouchEvent): (WebKit::WebTouchEvent::type): (WebKit::WebTouchEvent::touchPoints): (WebKit::WebTouchEvent::encode): (WebKit::WebTouchEvent::decode): (WebKit::WebTouchEvent::isTouchEventType):
- Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint): (WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): (WebKit::platform):
- Shared/WebEventConversion.h:
- Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent):
- Shared/qt/WebEventFactoryQt.h:
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::event): (QGraphicsWKView::touchEvent):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::touchEvent):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::touchEvent):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::touchEvent): (WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- 2:41 PM Changeset in webkit [65787] by
-
- 29 edits2 adds in trunk
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Chromium port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::addMarker): (WebKit::WebFrameImpl::setMarkerActive):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Windows port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- WebFrame.cpp: (WebFrame::unmarkAllMisspellings): (WebFrame::unmarkAllBadGrammar):
- WebView.cpp: (WebView::rectsForTextMatches):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Mac port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): (-[WebFrame _unmarkAllMisspellings]):
- WebView/WebHTMLView.mm: (-[WebHTMLView unmarkAllTextMatches]): (-[WebHTMLView rectsForTextMatches]):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the EFL port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- ewk/ewk_frame.cpp: (ewk_frame_text_matches_unmark_all):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Moves the document marker management code in Document.cpp into its own
class called DocumentMarkerController.
No functionality was changed, so no new tests.
- Android.mk: Added DocumentMarkerController.cpp
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
- WebCore.exp.in: Substituted symbols ZN7WebCore24DocumentMarkerController13removeMarkersENS_14DocumentMarker10MarkerTypeE and ZN7WebCore24DocumentMarkerController23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE for ZN7WebCore8Document13removeMarkersENS_14DocumentMarker10MarkerTypeE and ZN7WebCore8Document23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE, respectively.
- WebCore.gypi: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: (WebCore::Document::removedLastRef): Modified to call DocumentMarkerController::detach(). (WebCore::Document::~Document): Removed "deleteAllValues(m_markers)" as DocumentMarkerController is stored in OwnPtr; so it will be destroyed automatically on Document destruction. (WebCore::Document::textInserted): Modified to use marker controller. (WebCore::Document::textRemoved): Ditto.
- dom/Document.h: (WebCore::Document::markers): Added.
- dom/DocumentMarkerController.cpp: Added. (WebCore::placeholderRectForMarker): (WebCore::DocumentMarkerController::detach): (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersForNode): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::setRenderedRectForMarker): (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive):
- dom/DocumentMarkerController.h: Added. (WebCore::DocumentMarkerController::~DocumentMarkerController):
- editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Modified to use marker controller. (WebCore::findFirstMisspellingInRange): Ditto. (WebCore::findFirstGrammarDetailInRange): Ditto. (WebCore::Editor::advanceToNextMisspelling): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::changeBackToReplacedString): Ditto.
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Ditto. (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
- page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Ditto. (WebCore::Frame::setMarkedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::respondToChangedSelection): Ditto.
- page/FrameView.cpp: (WebCore::FrameView::getTickmarks): Ditto. (WebCore::FrameView::paintContents): Ditto.
- page/Page.cpp: (WebCore::Page::unmarkAllTextMatches): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Ditto. (WebCore::HitTestResult::replacedString): Ditto.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto. (WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::computeTextMatchMarkerRect): Ditto.
- 2:32 PM Changeset in webkit [65786] by
-
- 6 edits in trunk
Add the blob URL member to FormData.
https://bugs.webkit.org/show_bug.cgi?id=44387
Reviewed by Darin Fisher.
WebCore:
This is in preparation to switch blob implementation to using BlobData
model. When a blob is added to a FormData, it is represented as a blob
URL in the list.
- platform/network/FormData.cpp:
(WebCore::FormData::appendBlob):
- platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(WebCore::FormDataElement::):
(WebCore::operator==):
WebKit/chromium:
As the result of adding the blob URL member to the FormData, we need
to update the corresponding WebKit API for chromium.
- public/WebHTTPBody.h:
(WebKit::WebHTTPBody::Element::):
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendBlob):
- 11:38 AM Changeset in webkit [65785] by
-
- 4 edits in trunk
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
- html5lib/resources/adoption01.dat:
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
The HTML5 spec has changed since Adam and I original wrote
the HTMLTreeBuilder. Most important for this change was resolution of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9580
I also removed our "phrasing" tag support since that was also removed
from the spec as part of other bug fixes.
This is tested by tonyg's <a><svg><tr><input></a> test in adoption01.dat.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement): (WebCore::HTMLTreeBuilder::processEndTag):
- 5:12 AM Changeset in webkit [65784] by
-
- 2 edits in trunk/WebCore
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] TransparencyLayer: Always use anti-aliasing and smooth pixmap transform
https://bugs.webkit.org/show_bug.cgi?id=44394
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer): Set the Antialiasing and SmoothPixmapTransforms render hints for all TransparencyLayers.
- 1:38 AM Changeset in webkit [65783] by
-
- 4 edits in trunk
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient): Reverse the (radial) gradient if r0 > r1.
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
Unskip two tests that now pass:
- canvas/philip/tests/2d.gradient.radial.outside2.html
- canvas/philip/tests/2d.gradient.radial.outside3.html
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [65782] by
-
- 5 edits in trunk/WebCore
[Qt] Layer approach to support generic shadow handling
https://bugs.webkit.org/show_bug.cgi?id=44380
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-22
Reviewed by Dirk Schulze.
The pair beginShadowLayer and endShadowLayer creates a temporary image
where the caller can draw onto, using the returned QPainter. When
endShadowLayer is called, the temporary image will be filtered, using
the specified shadow color and blur radius, and drawn to the graphics
context.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/ContextShadow.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::contextShadow):
