Timeline

Aug 25, 2010:

11:29 PM Changeset in webkit [66081] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/WebKit/efl

2010-08-25 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy FullScreenVideoControllerEfl to WebKit EFL
​https://bugs.webkit.org/show_bug.cgi?id=44590

Add FullScreenVideoControllerEfl to WebCoreSupport. However,
this is not implemented yet.

• CMakeListsEfl.txt:
• WebCoreSupport/FullscreenVideoControllerEfl.cpp: Added. (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::~FullscreenVideoController): (FullscreenVideoController::setMediaElement): (FullscreenVideoController::showHud): (FullscreenVideoController::hideHud): (FullscreenVideoController::enterFullscreen): (FullscreenVideoController::updateHudPosition): (FullscreenVideoController::exitOnUserRequest): (FullscreenVideoController::exitFullscreen): (FullscreenVideoController::canPlay): (FullscreenVideoController::play): (FullscreenVideoController::pause): (FullscreenVideoController::playStateChanged): (FullscreenVideoController::togglePlay): (FullscreenVideoController::volume): (FullscreenVideoController::muted): (FullscreenVideoController::setVolume): (FullscreenVideoController::volumeChanged): (FullscreenVideoController::muteChanged): (FullscreenVideoController::currentTime): (FullscreenVideoController::setCurrentTime): (FullscreenVideoController::duration): (FullscreenVideoController::percentLoaded): (FullscreenVideoController::beginSeek): (FullscreenVideoController::doSeek): (FullscreenVideoController::endSeek): (timeToString): (FullscreenVideoController::updateHudProgressBar): (FullscreenVideoController::createHud):
• WebCoreSupport/FullscreenVideoControllerEfl.h: Added. (FullscreenVideoController::mediaElement):

11:13 PM Changeset in webkit [66080] by commit-queue@webkit.org

• 3 edits in trunk/WebKit/efl

2010-08-25 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API for enabling local storage.
​https://bugs.webkit.org/show_bug.cgi?id=44319

Add API for enabling/disabling local storage.

• ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_local_storage_get): Added (ewk_view_setting_local_storage_set): Added
• ewk/ewk_view.h:

9:02 PM Changeset in webkit [66079] by commit-queue@webkit.org

• 12 edits in trunk

2010-08-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66074.
​http://trac.webkit.org/changeset/66074
​https://bugs.webkit.org/show_bug.cgi?id=44660

Chromium canary turned red (Requested by yuzo on #webkit).

• bindings/generic/RuntimeEnabledFeatures.cpp:
• bindings/generic/RuntimeEnabledFeatures.h:
• bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText):
• bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didFinishLoading):
• xml/XMLHttpRequest.h:
• xml/XMLHttpRequest.idl:

2010-08-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66074.
​http://trac.webkit.org/changeset/66074
​https://bugs.webkit.org/show_bug.cgi?id=44660

Chromium canary turned red (Requested by yuzo on #webkit).

• features.gypi:
• public/WebRuntimeFeatures.h:
• src/WebRuntimeFeatures.cpp:

8:40 PM Changeset in webkit [66078] by commit-queue@webkit.org

• 2 edits in trunk/JavaScriptCore

2010-08-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=44645

Make waf script portable so that we can add more ports.

• wscript:

8:35 PM Changeset in webkit [66077] by mrowe@apple.com

• 3 edits in trunk/WebCore

<rdar://problem/8205479> WebCore's icon database often prevents Safari from being killable via sudden termination

Reviewed by Dan Bernstein.

We need to ensure that each call to disableSuddenTermination is balanced by a corresponding call to enableSuddenTermination.
It's possbile for several calls to IconDatabase::wakeSyncThread to correspond to only a single iteration of the loop within
IconDatabase::syncThreadMainLoop. This results in the sudden termination disable count growing without bound rather than
being balanced when the work completes. We can prevent this by ensuring that we only disable sudden termination once for each
corresponding iteration of the sync thread's main loop.

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Only disable sudden termination if it has not yet been disabled for this iteration of
the sync thread's main loop.
(WebCore::IconDatabase::syncThreadMainLoop): Clear the flag indicating that sudden termination has been disabled after reenabling it
so that future calls to wakeSyncThread disable sudden termination once more.

• loader/icon/IconDatabase.h:

8:25 PM Changeset in webkit [66076] by commit-queue@webkit.org

• 2 edits in trunk

2010-08-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=44645

Make waf script portable so that we can add more ports.

• wscript:

8:09 PM Changeset in webkit [66075] by commit-queue@webkit.org

• 1 edit
  3 adds in trunk/LayoutTests

2010-08-25 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

Added new test to check for regression as reported in
​https://bugs.webkit.org/show_bug.cgi?id=44600.

• fast/js/script-tests/string-split-double-empty.js: Added.
• fast/js/string-split-double-empty-expected.txt: Added.
• fast/js/string-split-double-empty.html: Added.

7:54 PM Changeset in webkit [66074] by commit-queue@webkit.org

• 12 edits in trunk

2010-08-25 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=44133
IDL bindings for XmlHttpRequest.responseBlob support, doesn't do anything yet.
Adds two new attributes, asBlob and responseBlob.
Runtime disabled by default, also behind a new ENABLE_XHR_RESPONSE_BLOB compile time guard.

No new tests, just adding some stubs.

• bindings/generic/RuntimeEnabledFeatures.cpp:
• bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setResponseBlobEnabled): (WebCore::RuntimeEnabledFeatures::responseBlobEnabled): (WebCore::RuntimeEnabledFeatures::asBlobEnabled):
• bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText): Changed to allow an exceptional return path.
• bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): Changed to allow an exceptional return path.
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseXML): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseBlob): Added stub method, returns 0 for now. (WebCore::XMLHttpRequest::setAsBlob): Sets the asBlob attribute, raises exception if called at an inappropriate time. (WebCore::XMLHttpRequest::open): Resets asBlob to false, the default value. (WebCore::XMLHttpRequest::abort): Clears m_responseBlob. (WebCore::XMLHttpRequest::clearResponse): Clears m_responseBlob. (WebCore::XMLHttpRequest::didFinishLoading): Added a FIXME to populate m_responseBlob.
• xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob):
• xml/XMLHttpRequest.idl:

2010-08-25 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=44133
WebKitAPI to allow runtime enablement of XmlHttpRequest.responseBlob.

• features.gypi: Define ENABLE_XHR_RESPONSE_BLOB.
• public/WebRuntimeFeatures.h:
• src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):

6:59 PM Changeset in webkit [66073] by Martin Robinson

• 2 edits in trunk/LayoutTests

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Skip a test that requires editing delegate dumps.

• platform/gtk/Skipped:

6:52 PM Changeset in webkit [66072] by crogers@google.com

• 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

audio branch: tweak to WebCore.xcodeproj

6:45 PM Changeset in webkit [66071] by hclam@chromium.org

• 9 edits
  4 copies
  1 add in trunk

WebCore: Adding a means of communication between WebKit/WebCore and
chromium in order to share video frames. This adds the necessary
WebKit-side classes and methods, but does not actually use them
yet - that will be committed in a separate patch after the
corresponding Chromium side is committed.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (​vrk@google.com).

​https://bugs.webkit.org/show_bug.cgi?id=44539

No new tests, as these new classes/APIs are not yet used.

• platform/graphics/chromium/VideoFrameChromium.h: Added.

(WebCore::VideoFrameChromium::):

• platform/graphics/chromium/VideoFrameProvider.h: Added.
• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):

• platform/graphics/chromium/VideoLayerChromium.h:

WebKit/chromium: Adding a way to communicate video frames between Chromium and WebKit.
The WebKit side acts as a middleman between Chromium and WebCore.
The VideoFrameChromiumImpl is not being used by WebCore yet, as there
still needs to be an implementation of WebVideoFrame in Chromium
-- coming soon in a subsequent patch.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (​vrk@google.com).

API changes for Video Frame sharing between WebKit and Chromium
​https://bugs.webkit.org/show_bug.cgi?id=44539

• WebKit.gyp:
• public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::getCurrentFrame):
(WebKit::WebMediaPlayer::putCurrentFrame):

• public/WebVideoFrame.h: Added.
• src/VideoFrameChromiumImpl.cpp: Added.

(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::type):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):

• src/VideoFrameChromiumImpl.h: Added.
• src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):

• src/WebMediaPlayerClientImpl.h:

6:39 PM Changeset in webkit [66070] by Martin Robinson

• 2 edits in trunk/WebKit/gtk

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

confirm dialog should show OK/Cancel instead of Yes/No for consistency
​https://bugs.webkit.org/show_bug.cgi?id=32877

Change the button labels for the fallback confirmation dialog to be
OK and Cancel.

• webkit/webkitwebview.cpp: (webkit_web_view_script_dialog):

6:37 PM Changeset in webkit [66069] by Martin Robinson

• 2 edits in trunk/WebKitTools

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Updating webkitpy test expectations.

• Scripts/webkitpy/tool/steps/steps_unittest.py:

6:32 PM Changeset in webkit [66068] by crogers@google.com

• 1 edit in branches/audio/WebCore/DerivedSources.make

audio branch: DerivedSources.make WebCore/audio -> WebCore/webaudio

6:02 PM Changeset in webkit [66067] by crogers@google.com

• 1 edit
  323 moves
  3 adds in branches/audio/WebCore

audio branch: move WebCore/audio to WebCore/webaudio

6:00 PM Changeset in webkit [66066] by kbr@google.com

• 4 edits in trunk/WebCore

2010-08-25 Kenneth Russell <​kbr@google.com>

Reviewed by Simon Fraser.

Source data passed to TypedArray creators should be const
​https://bugs.webkit.org/show_bug.cgi?id=44649

Compiled and ran existing WebGL tests to verify.

• html/canvas/Float32Array.cpp: (WebCore::Float32Array::create):
• html/canvas/Float32Array.h:
• html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::create):

5:53 PM Changeset in webkit [66065] by crogers@google.com

• 2432 deletes in branches/audio/WebCore/audio/AudioSpatialization

audio branch: remove all but composite spatialization HRIR files

5:40 PM Changeset in webkit [66064] by ojan@chromium.org

• 3 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

fix the always squash git config
​https://bugs.webkit.org/show_bug.cgi?id=44651

Fix help text and apparently underscores are not allowed
in git config keys.

• Scripts/webkitpy/common/checkout/scm.py:
• Scripts/webkitpy/tool/steps/commit.py:

5:40 PM Changeset in webkit [66063] by cmarrin@apple.com

• 2 edits in trunk/LayoutTests

2010-08-25 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Skipping a couple of compositing tests because layerTreeAsText() is not implemented on Wk2 yet.

• platform/mac-wk2/Skipped:

5:33 PM Changeset in webkit [66062] by eric@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Eric Seidel <​eric@webkit.org>

Unreviewed, just removing a dead enum.

Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
​https://bugs.webkit.org/show_bug.cgi?id=44626

Remove HTMLTagStatus since it's not used anymore.

• html/HTMLElement.h:

5:31 PM Changeset in webkit [66061] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: CSS first letter text transform causes crash
​https://bugs.webkit.org/show_bug.cgi?id=44352

Reviewed by David Kilzer.

WebCore:

Test: accessibility/first-letter-text-transform-causes-crash.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::nextContinuation):

LayoutTests:

• accessibility/first-letter-text-transform-causes-crash-expected.txt: Added.
• accessibility/first-letter-text-transform-causes-crash.html: Added.

5:23 PM Changeset in webkit [66060] by eric@webkit.org

• 2 edits in trunk/WebKit/chromium

2010-08-25 Eric Seidel <​eric@webkit.org>

Unreviewed. Build fix.

Make Chromiums Broken WebPageSerializerImpl compile again
​https://bugs.webkit.org/show_bug.cgi?id=44652

Make it compile again. This code is still horribly wrong.

• src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::endTagToString):

5:10 PM Changeset in webkit [66059] by Darin Adler

• 2 edits in trunk/WebKitTools

• Scripts/commit-log-editor: Fix perl warning for people who have no

value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.

Reviewed by John Sullivan.

5:07 PM Changeset in webkit [66058] by ojan@chromium.org

• 4 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

stop blocking commits when the bots are red
​https://bugs.webkit.org/show_bug.cgi?id=44644

This check currently is just annoying. It doesn't actually
help keep the tree green. We can always add it back later
if we decide the tree is generally more green.

• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/mocktool.py:
• Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:

5:02 PM Changeset in webkit [66057] by eric@webkit.org

• 58 edits in trunk

2010-08-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
​https://bugs.webkit.org/show_bug.cgi?id=44626

Serialization is covered by a bunch of tests. innerHTML behavior is sadly not.
In either case, this is just moving code and should have no functional change.

• editing/markup.cpp: (WebCore::elementCannotHaveEndTag): (WebCore::MarkupAccumulator::shouldSelfClose): (WebCore::MarkupAccumulator::appendEndMarkup): (WebCore::serializeNodesWithNamespaces):
• html/HTMLAnchorElement.h:
• html/HTMLAreaElement.h:
• html/HTMLBRElement.h:
• html/HTMLBaseElement.h:
• html/HTMLBaseFontElement.h:
• html/HTMLBlockquoteElement.h:
• html/HTMLBodyElement.h:
• html/HTMLCanvasElement.cpp:
• html/HTMLCanvasElement.h:
• html/HTMLDListElement.h:
• html/HTMLDataGridCellElement.h:
• html/HTMLDataGridColElement.h:
• html/HTMLDirectoryElement.h:
• html/HTMLDivElement.h:
• html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::ieForbidsInsertHTML): (WebCore::HTMLElement::deprecatedCreateContextualFragment): (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::setOuterText):
• html/HTMLElement.h:
• html/HTMLEmbedElement.h:
• html/HTMLFontElement.h:
• html/HTMLFormControlElement.h:
• html/HTMLFormElement.h:
• html/HTMLFrameElement.h:
• html/HTMLFrameSetElement.h:
• html/HTMLHRElement.h:
• html/HTMLHeadElement.h:
• html/HTMLHeadingElement.h:
• html/HTMLHtmlElement.h:
• html/HTMLIFrameElement.h:
• html/HTMLImageElement.h:
• html/HTMLInputElement.h:
• html/HTMLIsIndexElement.h:
• html/HTMLLIElement.h:
• html/HTMLLinkElement.h:
• html/HTMLMapElement.h:
• html/HTMLMarqueeElement.h:
• html/HTMLMenuElement.h:
• html/HTMLMetaElement.h:
• html/HTMLModElement.h:
• html/HTMLOListElement.h:
• html/HTMLOptionElement.h:
• html/HTMLParagraphElement.h:
• html/HTMLParamElement.h:
• html/HTMLPlugInElement.h:
• html/HTMLPreElement.h:
• html/HTMLQuoteElement.h:
• html/HTMLScriptElement.h:
• html/HTMLSourceElement.h:
• html/HTMLStyleElement.h:
• html/HTMLTableCaptionElement.h:
• html/HTMLTableCellElement.h:
• html/HTMLTableColElement.cpp:
• html/HTMLTableColElement.h:
• html/HTMLTableElement.h:
• html/HTMLTableRowElement.h:
• html/HTMLTableSectionElement.h:
• html/HTMLUListElement.h:

4:55 PM Changeset in webkit [66056] by rniwa@webkit.org

• 3 edits
  1 add
  9 deletes in trunk/LayoutTests

2010-08-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

test conversion: editing/style/typing-style-003.html should use runDumpAsTextEditingTest instead of runEditingTest
​https://bugs.webkit.org/show_bug.cgi?id=44646

• editing/style/typing-style-003-expected.txt: Added.
• editing/style/typing-style-003.html: Calls runDumpAsTextEditingTest instead of runEditingTest.
• platform/chromium-linux/editing/style/typing-style-003-expected.checksum: Removed.
• platform/chromium-win/editing/style/typing-style-003-expected.checksum: Removed.
• platform/chromium-win/editing/style/typing-style-003-expected.png: Removed.
• platform/chromium-win/editing/style/typing-style-003-expected.txt: Removed.
• platform/gtk/editing/style/typing-style-003-expected.txt: Removed.
• platform/mac/editing/style/typing-style-003-expected.checksum: Removed.
• platform/mac/editing/style/typing-style-003-expected.png: Removed.
• platform/mac/editing/style/typing-style-003-expected.txt: Removed.
• platform/qt/Skipped: Run typing-style-003.html on qt again.
• platform/qt/editing/style/typing-style-003-expected.txt: Removed.

4:40 PM Changeset in webkit [66055] by zmo@google.com

• 14 edits in trunk

2010-08-20 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

WebGL must enforce restrictions even if running on OpenGL ES 2.0
​https://bugs.webkit.org/show_bug.cgi?id=42908

• public/WebGraphicsContext3D.h: Add two new flags.
• src/GraphicsContext3D.cpp: Ditto. (WebCore::GraphicsContext3DInternal::isGLES2NPOTStrict): (WebCore::GraphicsContext3DInternal::isErrorGeneratedOnOutOfBoundsAccesses): (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
• src/WebGraphicsContext3DDefaultImpl.cpp: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2NPOTStrict): (WebKit::WebGraphicsContext3DDefaultImpl::isErrorGeneratedOnOutOfBoundsAccesses):
• src/WebGraphicsContext3DDefaultImpl.h: Ditto.

2010-08-20 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

WebGL must enforce restrictions even if running on OpenGL ES 2.0
​https://bugs.webkit.org/show_bug.cgi?id=42908

• html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::getColorBufferFormat): Get format at given level instead of 0.
• html/canvas/WebGLRenderingContext.cpp: Add two new flags and use them to replace the original isGLES2Compliant(). (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
• html/canvas/WebGLRenderingContext.h: Declare two new flags.
• html/canvas/WebGLTexture.cpp: Get format at given level instead of 0. (WebCore::WebGLTexture::getInternalFormat):
• html/canvas/WebGLTexture.h: Ditto.
• platform/graphics/GraphicsContext3D.h: Add three new flags.
• platform/graphics/mac/GraphicsContext3DMac.mm: Ditto. (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
• platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):

4:38 PM Changeset in webkit [66054] by bfulgham@webkit.org

• 4 edits in trunk

WebCore: Build correction, no review.

• WebCore.vcproj/WebCore.vcproj: Add missing implementation for PlatformRefPtrCairo.

WebKit2: Build fix, no review.

Add conditional guards around Safari-specific
include files.

• WebProcess/WebPage/win/WebPageWin.cpp:

4:37 PM Changeset in webkit [66053] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2010-08-25 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
​https://bugs.webkit.org/show_bug.cgi?id=38912

I know of nothing else to do but skip all media tests for the cq.

• Scripts/webkitpy/tool/steps/runtests.py:

4:10 PM Changeset in webkit [66052] by inferno@chromium.org

• 3 edits
  2 adds in trunk

2010-08-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Adler.

Added abort condition for RenderCounters when traversing a detached render tree.
​https://bugs.webkit.org/show_bug.cgi?id=43812

Test: fast/css/counters/counter-traverse-object-crash.html

• rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):

2010-08-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Adler.

Assertion failure in RenderCounter when traversing a detached render trees.
​https://bugs.webkit.org/show_bug.cgi?id=43812

• fast/css/counters/counter-traverse-object-crash-expected.txt: Added.
• fast/css/counters/counter-traverse-object-crash.html: Added.

3:55 PM Changeset in webkit [66051] by crogers@google.com

• 1 edit
  79 moves
  2 adds in branches/audio/WebCore

audio branch: move relevant files to WebCore/platform/audio

3:49 PM Changeset in webkit [66050] by cmarrin@apple.com

• 6 edits
  2 adds in trunk

2010-08-25 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=44629
Add layer consistency checking and fix found crashing bug

The crash was being caused by some of the calls which mutated
the sublayer list leaving the list in an inconsistent state.
This eventually lead to a crash. It would also lead to visual
artifacts if the crash didn't occur. Added consistency checking
to catch this and any other inconsistencies in the sublayer list.

The particular bug in this case was caused by clamping an index
for insertion to the current size of the sublayer list. CACF uses
an index equal to the current length to indicate an append operation.
With tiled layers the apparent size of the list is one less than its
actual size (to accomodate the layer which holds the list of tiles)
so this clamping was causing the new layer to get inserted before the
tile parent. The tile parent was then mistaken for a WKCACFLayer and
it eventually tried to deref that layer, causing the crash.

I also added some protection when destroying a WKCACFLayer. The user data
for the corresponding CACFLayer is now changed to 0xDeadBeef rather than
null. This allows dangling layers to be more easily identified. This
value is checked and ASSERTed if seen. I also remove the sublayers
on destruction to make the consistency checks work properly while
a layer is being destroyed.

Test: compositing/tiling/crash-reparent-tiled-layer.html

3:17 PM Changeset in webkit [66049] by dpranke@chromium.org

• 3 edits in trunk/WebKitTools

2010-08-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests for test_expectations
This adds unit tests to cover (almost?) all of the non-rebaselining
functionality.

​https://bugs.webkit.org/show_bug.cgi?id=44579

• Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
• Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:

3:15 PM Changeset in webkit [66048] by rniwa@webkit.org

• 4 edits
  2 adds in trunk

2010-08-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
​https://bugs.webkit.org/show_bug.cgi?id=33668

The bug was caused by enclosingListChild returning a list child whose enclosing list is
a sibling of the current list child. Fixed enclosingListChild to traverse upwards
in the DOM to find the list child which is a sibling of the current list child.
Also fixed adjacentEnclosingList to only returns the list that belongs to the same outer list.

In doApplyForSingleParagraph, if the start or the end of currentSelection existed inside a list content
moved by moveParagraphWithClones, either end could point to a wrong position after the move.
Fixed this problem by checking this condition upfront and restoring later.

In doApply, if moveParagraph or moveParagraphWithClones, endOfSelection or startOfLastParagraph
could be null or orphaned, fixed this problem by indexForVisiblePosition.

Test: editing/execCommand/insert-list-orphaned-item-with-nested-lists.html

• editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): (WebCore::enclosingListChild): (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::adjacentEnclosingList): (WebCore::InsertListCommand::listifyParagraph):

2010-08-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
​https://bugs.webkit.org/show_bug.cgi?id=33668

Added a test to convert nested lists with an orphaned list child to an ordered nested list.
Selection in switch-list-type-with-inner-list.html is restored correctly after inserting list.

• editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt: Added.
• editing/execCommand/insert-list-orphaned-item-with-nested-lists.html: Added.
• editing/execCommand/switch-list-type-with-inner-list-expected.txt: Selection is restored correctly.

2:58 PM Changeset in webkit [66047] by bfulgham@webkit.org

• 5 edits in trunk/WebCore

Build corrections, no review.

• platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Add include for new (missing) "CairoPath.h" class.
• platform/graphics/cairo/PlatformRefPtrCairo.h: Correct include and compilation guards to match coding conventions.
• platform/graphics/win/FontCustomPlatformDataCairo.cpp: Change implementation to match CG version, using the FontCustomPlatformData name, rather than the original FontCustomPlatformDataCairo.
• platform/graphics/win/FontCustomPlatformDataCairo.h: Same as for the .cpp file.

2:52 PM Changeset in webkit [66046] by crogers@google.com

• 1 add in branches/audio/WebCore/platform/audio

audio branch: add WebCore/platform/audio directory

2:45 PM Changeset in webkit [66045] by dpranke@chromium.org

• 5 edits
  10 adds in trunk/WebKitTools

2010-08-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests

This change adds more unit tests for the image_diff, test_failures,
and test_files modules, bringing them to 100% coverage (and adds a
couple tests to run_webkit_tests while we're at it).

This test also turns on the "dryrun" port for testing when run on
the mac, increasing coverage in a few other places.

​https://bugs.webkit.org/show_bug.cgi?id=44578

• Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
• Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
• Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
• Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
• Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
• Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
• Scripts/webkitpy/layout_tests/port/test.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2:42 PM Changeset in webkit [66044] by crogers@google.com

• 91 edits in branches/audio

audio branch: add feature defines

2:41 PM Changeset in webkit [66043] by dpranke@chromium.org

• 4 edits in trunk/WebKitTools

2010-08-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests for layout_package/printing.py

This change adds more unit tests to get the test coverage to 100%
for the printing module. This code is actually pretty crufty and
has some layering violations that need to be cleaned up but I'll
save that for another CL after we get all the unit tests written and
we fix the multithreading issues. At least now we'll be able to tell
if we break things.

​https://bugs.webkit.org/show_bug.cgi?id=44576

• Scripts/webkitpy/layout_tests/layout_package/printing.py:
• Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

2:27 PM Changeset in webkit [66042] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Krzysztof Czech <​k.czech@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Crash while calling PopupMenuEfl destructor
​https://bugs.webkit.org/show_bug.cgi?id=44497

Condition checks if m_view is defined
before popup is hide

• platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenuEfl::~PopupMenuEfl):

2:16 PM Changeset in webkit [66041] by ojan@chromium.org

• 3 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests should respect set-webkit-configuration
​https://bugs.webkit.org/show_bug.cgi?id=44633

Moves the getting of the configuration into the base Port so that
chromium ports use it as well. In the downstream chromium port,
this should still just return Release.

• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:

2:15 PM Changeset in webkit [66040] by rniwa@webkit.org

• 12 edits
  3 adds in trunk

2010-08-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Creating a link when selecting multiple nodes creates multiple links
​https://bugs.webkit.org/show_bug.cgi?id=30836

The bug was caused by applyInlineStyleToRange calling addInlineStyleIfNeeded
on each inline element. Modified applyInlineStyleToRange to call addInlineStyleIfNeeded
once for all inline elements with the same style difference.

Because this implies that anchor element may wrap other inline elements when added,
modified pushDownInlineStyleAroundNode to push down styled elements.

Removed pushPartiallySelectedAnchorElementsDown from CompositeEditCommand since
ApplyStyleCommand now correctly pushes down anchors at the start and the end of the selection.

Test: editing/execCommand/toggle-link.html

• editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::operator==): Added. (WebCore::StyleChange::operator!=): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Wraps inline elements with the same style difference by one element instead of wrapping each element separately. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Extracts styled element. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Avoids adding styled element. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Pushes down styled element. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): No longer checks inline-ness. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Adds style even when m_removeOnly. Callers should set addStyledElement = DoNotAddStyledElement to avoid adding styled element.
• editing/ApplyStyleCommand.h:
• editing/CompositeEditCommand.cpp: Removed pushPartiallySelectedAnchorElementsDown.
• editing/CompositeEditCommand.h: Removed pushPartiallySelectedAnchorElementsDown.
• editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): used to call pushPartiallySelectedAnchorElementsDown.
• editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Used to call pushPartiallySelectedAnchorElementsDown.

2010-08-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Creating a link when selecting multiple nodes creates multiple links
​https://bugs.webkit.org/show_bug.cgi?id=30836

Added a test to ensure WebKit creates single anchor element on execCommand('createLink') if possible.
Also rebaselined several tests to match new behavior.

• editing/execCommand/createLink-expected.txt: Merged some anchor elements.
• editing/execCommand/script-tests/toggle-link.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastWord):
• editing/execCommand/script-tests/toggle-style-3.js: i elements are merged.
• editing/execCommand/toggle-style-3-expected.txt: Ditto.
• editing/execCommand/toggle-link-expected.txt: Added.
• editing/execCommand/toggle-link.html: Added.
• editing/execCommand/unlink-expected.txt: Merged some anchor elements.

1:28 PM Changeset in webkit [66039] by zmo@google.com

• 27 edits
  13 adds in trunk

2010-08-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
​https://bugs.webkit.org/show_bug.cgi?id=38282

• src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Add premultiplyAlpha flag.

2010-08-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
​https://bugs.webkit.org/show_bug.cgi?id=38282

Test: fast/canvas/webgl/gl-teximage.html

• platform/graphics/GraphicsContext3D.cpp: Fix a bug where alpha channel is ignored.
• platform/graphics/ImageSource.cpp: Add premultiplyAlpha flag. (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::setData):
• platform/graphics/ImageSource.h: Ditto.
• platform/graphics/cg/ImageSourceCG.cpp: Ditto. (WebCore::ImageSource::ImageSource):
• platform/graphics/qt/ImageDecoderQt.cpp: Ditto. (WebCore::ImageDecoder::create): (WebCore::ImageDecoderQt::ImageDecoderQt): (WebCore::ImageDecoderQt::frameCount): (WebCore::ImageDecoderQt::forceLoadEverything):
• platform/graphics/qt/ImageDecoderQt.h: Ditto.
• platform/graphics/skia/GraphicsContext3DSkia.cpp: Fix the premultiplyAlpha data loss issue in skia. (WebCore::GraphicsContext3D::getImageData):
• platform/image-decoders/ImageDecoder.cpp: Add premultiplyAlpha flag. (WebCore::ImageDecoder::create): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=):
• platform/image-decoders/ImageDecoder.h: Ditto. (WebCore::RGBA32Buffer::premultiplyAlpha): (WebCore::RGBA32Buffer::setPremultiplyAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::ImageDecoder):
• platform/image-decoders/bmp/BMPImageDecoder.cpp: Ditto. (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::frameBufferAtIndex):
• platform/image-decoders/bmp/BMPImageDecoder.h: Ditto.
• platform/image-decoders/gif/GIFImageDecoder.cpp: Ditto. (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::frameCount):
• platform/image-decoders/gif/GIFImageDecoder.h: Ditto.
• platform/image-decoders/ico/ICOImageDecoder.cpp: Ditto. (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::frameCount): (WebCore::ICOImageDecoder::decodeAtIndex):
• platform/image-decoders/ico/ICOImageDecoder.h: Ditto.
• platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto. (WebCore::JPEGImageDecoder::JPEGImageDecoder): (WebCore::JPEGImageDecoder::frameBufferAtIndex):
• platform/image-decoders/jpeg/JPEGImageDecoder.h: Ditto.
• platform/image-decoders/png/PNGImageDecoder.cpp: Ditto. (WebCore::PNGImageDecoder::PNGImageDecoder): (WebCore::PNGImageDecoder::frameBufferAtIndex):
• platform/image-decoders/png/PNGImageDecoder.h: Ditto.
• platform/image-decoders/skia/ImageDecoderSkia.cpp: Ditto. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=):

2010-08-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
​https://bugs.webkit.org/show_bug.cgi?id=38282

• fast/canvas/webgl/gl-teximage-expected.txt: Added.
• fast/canvas/webgl/gl-teximage.html: Added.
• fast/canvas/webgl/resources/3x3.png: Added.
• fast/canvas/webgl/resources/gray-ramp-256-with-128-alpha.png: Added.
• fast/canvas/webgl/resources/gray-ramp-256.png: Added.
• fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Added.
• fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Added.
• fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Added.
• fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Added.
• fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Added.
• fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Added.
• fast/canvas/webgl/resources/gray-ramp.png: Added.
• fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos. (WebGLTestUtils):
• fast/canvas/webgl/resources/zero-alpha.png: Added.
• platform/chromium/test_expectations.txt: Don't run gl-teximage.html for mac.
• platform/mac/Skipped: Don't run gl-teximage.html for mac.

1:27 PM Changeset in webkit [66038] by demarchi@webkit.org

• 2 edits in trunk/WebKit/efl

2010-08-25 Jaehun Lim <​ljaehun.lim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] enable libsoup's content decode feature
​https://bugs.webkit.org/show_bug.cgi?id=44147

libsoup's content decode feature is enabled during initializaton.

• ewk/ewk_main.cpp: (ewk_init):

1:23 PM Changeset in webkit [66037] by abarth@webkit.org

• 25 edits
  4 deletes in trunk/WebCore

2010-08-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove XBL
​https://bugs.webkit.org/show_bug.cgi?id=44621

This patch removes support for XBL. XBL seems cool, but this code is
old and pretty bitrotten. If we decide to support XBL in the future,
we can recover this code from this revision. As it stands, it doesn't
seem worth half-maintaining this code.

• Android.mk:
• CMakeLists.txt:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
• css/CSSPropertyNames.in:
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
• dom/Document.h:
• loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
• loader/Cache.h:
• loader/CachedResource.h: (WebCore::CachedResource::):
• loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setXSLStyleSheet): (WebCore::CachedResourceClient::fontLoaded):
• loader/CachedXBLDocument.cpp: Removed.
• loader/CachedXBLDocument.h: Removed.
• loader/DocLoader.cpp: (WebCore::DocLoader::canRequest):
• loader/DocLoader.h:
• loader/loader.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::Loader::determinePriority):
• rendering/style/BindingURI.cpp: Removed.
• rendering/style/BindingURI.h: Removed.
• rendering/style/RenderStyle.cpp:
• rendering/style/RenderStyle.h:
• rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
• rendering/style/StyleRareNonInheritedData.h:

1:08 PM Changeset in webkit [66036] by andreas.kling@nokia.com

• 4 edits in trunk

2010-08-25 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

We weren't setting it explicitly which caused us to use Qt::MiterJoin when
we actually want Qt::SvgMiterJoin.

Fixes display glitches on the "Monster" chrome experiment among other things.

• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext):

2010-08-25 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

Skip canvas/philip/tests/2d.path.rect.zero.1.html
It was working because we didn't properly initialize the GC's LineJoin mode.

• platform/qt/Skipped:

1:06 PM Changeset in webkit [66035] by Adam Roben

• 2 edits in trunk/WebKit2

Clean up Connection::open on Windows

Fixes <​http://webkit.org/b/44185>.

Reviewed by Steve Falkenburg.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInitialize): Set m_isConnected to true
since the pipe got connected before it was even given to us.
(CoreIPC::Connection::readEventHandler): Removed code that will never
run now that m_isConnected is always true when this function is
called. Since no outgoing messages will have been queued before
m_isConnected is set to true, there's no need to send them explicitly
here; they'll get sent as they're queued.
(CoreIPC::Connection::open): Removed the call to ::ConnectNamedPipe,
since the pipe is already connected by this point. Changed to schedule
a read in the server and client the same way (rather than using
::SetEvent in the server).

12:54 PM Changeset in webkit [66034] by Dimitri Glazkov

• 2 edits
  3 moves in trunk/LayoutTests

2010-08-25 Fady Samuel <​fsamuel@chromium.org>

Reviewed by Dimitri Glazkov.

Table Rendering Layout Test Expectations Updated
​https://bugs.webkit.org/show_bug.cgi?id=44429

Simple Paint test appears to render the same on Mac, Windows, and Linux.

Updated test expectations to match this and moved the expectations into the test directory.

• fast/table/simple_paint-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.checksum.
• fast/table/simple_paint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.png.
• fast/table/simple_paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.txt.
• platform/chromium/test_expectations.txt:

12:25 PM Changeset in webkit [66033] by demarchi@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 66024
​https://bugs.webkit.org/show_bug.cgi?id=44631

No new features added, so no new tests.

• CMakeListsEfl.txt: change GRefPtrCairo.cpp by PlatformRefPtrCairo.cpp.

12:19 PM Changeset in webkit [66032] by rniwa@webkit.org

• 18 edits
  8 adds in trunk

2010-08-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Various designmode=&quot;on&quot;/&quot;off&quot; &amp; execCommand(&quot;Undo&quot;) NULL pointer crashes
​https://bugs.webkit.org/show_bug.cgi?id=32823

The bug was caused by changeSelectionAfterCommand which updates the selection
without checking the whether new selection is valid or not.

Fixed changeSelectionAfterCommand so that it won't update the selection
when either end of the new selection is orphaned. Also fixed various editing commands
to exit early if either end of the selection is orphaned.

Tests: editing/undo/orphaned-selection-crash-bug32823-1.html

editing/undo/orphaned-selection-crash-bug32823-2.html
editing/undo/orphaned-selection-crash-bug32823-3.html
editing/undo/orphaned-selection-crash-bug32823-4.html

• editing/Editor.cpp: (WebCore::Editor::changeSelectionAfterCommand): No longer sets orphaned selection.
• editing/VisibleSelection.h: (WebCore::VisibleSelection::isNonOrphanedRange): Added. (WebCore::VisibleSelection::isNonOrphanedCaretOrRange): Added.
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Added an early exist. See above.
• editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Ditto.
• editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::doApply): Ditto.
• editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
• editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Ditto.
• editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
• editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto.
• editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Ditto.
• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::doApply): Ditto.
• editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Ditto.

2010-08-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Various designmode="on"/"off" & execCommand("Undo") NULL pointer crashes
​https://bugs.webkit.org/show_bug.cgi?id=32823

These tests ensure WebKit doesn't crash when undoing some editing commands failed
and either end of endingSelection() became orphaned.
All tests are copied from the bug to prevent regression.

• editing/undo/orphaned-selection-crash-bug32823-1-expected.txt: Added.
• editing/undo/orphaned-selection-crash-bug32823-1.html: Added.
• editing/undo/orphaned-selection-crash-bug32823-2-expected.txt: Added.
• editing/undo/orphaned-selection-crash-bug32823-2.html: Added.
• editing/undo/orphaned-selection-crash-bug32823-3-expected.txt: Added.
• editing/undo/orphaned-selection-crash-bug32823-3.html: Added.
• editing/undo/orphaned-selection-crash-bug32823-4-expected.txt: Added.
• editing/undo/orphaned-selection-crash-bug32823-4.html: Added.
• editing/undo/redo-split-text-with-removal-expected.txt: Caret is restored.

11:55 AM Changeset in webkit [66031] by commit-queue@webkit.org

• 3 edits in trunk/JavaScriptCore

2010-08-25 Michael Saboff <​msaboff@apple.com>

Reviewed by Sam Weinig.

Remove the single entry regular expression cache introduced as part of
the fix for ​https://bugs.webkit.org/show_bug.cgi?id=41238.
The performance problem in Dromaeo that initiated that bug is no
longer present. Dromaeo has been modified so that the regular
expression tests are somewhat random and don't benefit from a
single entry cache.

• runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
• runtime/RegExp.h:

11:30 AM Changeset in webkit [66030] by commit-queue@webkit.org

• 2 edits in trunk/WebKit/qt

2010-08-25 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Simon Hausmann.

In FrameLoaderClientQt::createFrame we should call loadURLIntoChildFrame
with parent frame's loader instead of child frame's loader.
​https://bugs.webkit.org/show_bug.cgi?id=43930

• WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

11:26 AM Changeset in webkit [66029] by ojan@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

make perf tests work with V8
​https://bugs.webkit.org/show_bug.cgi?id=44623

V8 doesn't support getJSObjectCount.

• resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):

11:24 AM Changeset in webkit [66028] by Simon Fraser

• 6 edits
  2 adds in trunk

2010-08-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Flash content draws in front of site's drop down menu at ​http://www.monster.com/
​https://bugs.webkit.org/show_bug.cgi?id=41330

If an iframe with composited content became overlapped, we failed to
consider that iframe for compositing if it had no RenderLayer, so the layering
would be incorrect.

Overlap is detected at painting time, but it's bad for FrameView::setIsOverlapped()
to call setNeedsStyleRecalc(), because this would cause subsequent calls to
FrameView::paintContents() in the same painting batch to bail with needsLayout().

Instead, we do the setNeedsStyleRecalc() from RenderLayerCompositor::notifyIFramesOfCompositingChange(),
so that the parent document has a chance to update style, and give the iframe a RenderLayer.
Then setIsOverlapped() simply needs to schedule a layer update, which we do on a timer.

When dumping layers via Frame::layerTreeAsText(), if a layer update is pending, then
update the layers.

Test: compositing/iframes/become-overlapped-iframe.html

• page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
• page/FrameView.cpp: (WebCore::FrameView::setIsOverlapped):
• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::scheduleCompositingLayerUpdate): (WebCore::RenderLayerCompositor::compositingLayerUpdatePending): (WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired): (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
• rendering/RenderLayerCompositor.h:

11:22 AM Changeset in webkit [66027] by tony@chromium.org

• 2 edits in trunk/WebKitTools

2010-08-25 Tony Chang <​tony@chromium.org>

Not reviewed, changing svn props for a script.

• Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.

11:17 AM Changeset in webkit [66026] by abarth@webkit.org

• 3 edits in trunk/WebKitTools

2010-08-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WebKit2 from core builders
​https://bugs.webkit.org/show_bug.cgi?id=44625

This builder was added to the core builders by accident. It doesn't
appear to be green enough to be a core builder yet.

• Scripts/webkitpy/common/net/buildbot.py:
• Scripts/webkitpy/common/net/buildbot_unittest.py:

11:12 AM Changeset in webkit [66025] by Adam Roben

• 4 edits in trunk

Call NP_GetEntryPoints before NP_Initialize on Windows

Doing otherwise will cause Flash and QuickTime to crash inside
NP_Initialize.

Fixes <​http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows

Reviewed by John Sullivan.

WebKit2:

• WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad): On Windows, first call
NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
prevent Silverlight (e.g.) from crashing (see r38858).

WebKitTools:

Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order

The order differs between Mac and Windows (see r38858).

• DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and

a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior.
(NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
yet. This matches Silverlight's behavior.

11:00 AM Changeset in webkit [66024] by Martin Robinson

• 31 edits
  2 moves
  1 add in trunk

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
​https://bugs.webkit.org/show_bug.cgi?id=44354

Replace GRefPtr with PlatformRefPtr. Keep GLib specific bits in
GRefPtr.h.

• GNUmakefile.am: Add PlatformRefPtr.h to the source list.
• wtf/PlatformRefPtr.h: Migrated from GRefPtr.h. (WTF::PlatformRefPtr::PlatformRefPtr): Ditto. (WTF::PlatformRefPtr::~PlatformRefPtr): Ditto. (WTF::PlatformRefPtr::clear): Ditto. (WTF::PlatformRefPtr::get): Ditto. (WTF::PlatformRefPtr::operator*): Ditto. (WTF::PlatformRefPtr::operator->): Ditto. (WTF::PlatformRefPtr::operator!): Ditto. (WTF::PlatformRefPtr::operator UnspecifiedBoolType): Ditto. (WTF::PlatformRefPtr::hashTableDeletedValue): Ditto. (WTF::::operator): Ditto. (WTF::::swap): Ditto. (WTF::swap): Ditto. (WTF::operator==): Ditto. (WTF::operator!=): Ditto. (WTF::static_pointer_cast): Ditto. (WTF::const_pointer_cast): Ditto. (WTF::getPtr): Ditto. (WTF::adoptPlatformRef): Ditto.
• wtf/gobject/GRefPtr.cpp: Changes to reflect new names. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
• wtf/gobject/GRefPtr.h: Ditto. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
​https://bugs.webkit.org/show_bug.cgi?id=44354

No new tests as functionality has not changed.

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef. Rename GRefPtrCairo to PlatformRefPtrCairo.

• GNUmakefile.am:
• platform/Cursor.h:
• platform/graphics/cairo/GRefPtrCairo.cpp: Removed.
• platform/graphics/cairo/GRefPtrCairo.h: Removed.
• platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
• platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
• platform/graphics/cairo/PlatformRefPtrCairo.h: Added.
• platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
• platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::declareAndWriteDragImage):
• platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): (WebCore::createCustomCursor): (WebCore::Cursor::ensurePlatformCursor):
• platform/gtk/DataObjectGtk.h:
• platform/gtk/GRefPtrGtk.cpp: (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
• platform/gtk/GRefPtrGtk.h:
• platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
• platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::dropAtomsForContext):
• platform/gtk/PopupMenuGtk.h:
• platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::paintMozillaGtkWidget):
• platform/gtk/RenderThemeGtk.h:

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
​https://bugs.webkit.org/show_bug.cgi?id=44354

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef.

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
• WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
• WebCoreSupport/EditorClientGtk.h:
• WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::createPlugin):
• WebCoreSupport/FullscreenVideoController.h:
• WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
• webkit/webkitdownload.cpp: (webkit_download_error):
• webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request):
• webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response):

2010-08-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
​https://bugs.webkit.org/show_bug.cgi?id=44354

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef.

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isSelected):

10:51 AM Changeset in webkit [66023] by eric.carlson@apple.com

• 9 edits in trunk

2010-08-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

HTMLMediaElement.canPlayType must be case insensitive for MIME type.
​https://bugs.webkit.org/show_bug.cgi?id=44577

• platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): (WebCore::MediaPlayer::supportsType):

2010-08-24 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

HTMLMediaElement.canPlayType must be case insensitive for MIME type.
​https://bugs.webkit.org/show_bug.cgi?id=44577

• media/media-can-play-octet-stream-expected.txt:
• media/media-can-play-octet-stream.html:
• media/media-can-play-ogg-expected.txt:
• media/media-can-play-ogg.html:
• media/video-can-play-type-expected.txt:
• media/video-can-play-type.html:

10:35 AM Changeset in webkit [66022] by ojan@chromium.org

• 2 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <​ojan@chromium.org>

Fix order of Timothy's email address. The script, and
other tools all assume that the first email is the bugzilla address.

• Scripts/webkitpy/common/config/committers.py:

10:33 AM Changeset in webkit [66021] by xan@webkit.org

• 4 edits in trunk

2010-08-25 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
​https://bugs.webkit.org/show_bug.cgi?id=44608

Move FEATURE_DEFINES declaration here, since it's used by the
bindings code generator. Also, fix typo in the variable holding
the defines.

• GNUmakefile.am:

WebCore:

2010-08-25 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
​https://bugs.webkit.org/show_bug.cgi?id=44608

Move FEATURE_DEFINES declaration to the toplevel GNUmakefile.am,
since it's used there now too.

• GNUmakefile.am:

10:10 AM Changeset in webkit [66020] by tony@chromium.org

• 1 edit
  2 deletes in trunk/LayoutTests

2010-08-25 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] remove chromium.Interval layout test
​https://bugs.webkit.org/show_bug.cgi?id=44614

chromium.Interval is moving into the benchmarking namespace
and not being exposed by default.

• platform/chromium/fast/dom/interval-expected.txt: Removed.
• platform/chromium/fast/dom/interval.html: Removed.

10:02 AM Changeset in webkit [66019] by xan@webkit.org

• 3 edits in trunk/JavaScriptCore

2010-08-25 Xan Lopez <​xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Remove dead code in JSGlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=44615

The recursion data member in the JSGlobalObject and its getter
plus inc/dec methods seems to be unused, remove them.

• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
• runtime/JSGlobalObject.h:

9:39 AM Changeset in webkit [66018] by demarchi@webkit.org

• 4 edits in trunk

2010-08-25 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 65332
​https://bugs.webkit.org/show_bug.cgi?id=44543

Generated variables are now returned from FindPkgConfig, so no need
to document the custom ones.

• cmake/FindGthread.cmake:

2010-08-25 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 65332
​https://bugs.webkit.org/show_bug.cgi?id=44543

Use Gthread_LIBRARIES instead of GTHREAD_LIBRARIES. This fix
the build when using ENABLE_GLIB_SUPPORT=ON and NETWORK_BACKEND=curl.

• CMakeListsEfl.txt:

9:33 AM Changeset in webkit [66017] by Girish Ramakrishnan

• 2 edits in trunk/WebCore

2010-08-25 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Ariya Hidayat.

Proper workaround for missing Gtk initialization in Adobe's flash plugins.
​https://bugs.webkit.org/show_bug.cgi?id=44405

• plugins/qt/PluginPackageQt.cpp: (WebCore::initializeGtk): (WebCore::PluginPackage::load):

9:18 AM Changeset in webkit [66016] by mnaganov@chromium.org

• 1 edit in trunk/WebCore/English.lproj/localizedStrings.js

Unreviewed -- no code change. Sort WebCore/English.lproj/localizedStrings.js.

8:48 AM Changeset in webkit [66015] by pfeldman@chromium.org

• 2 edits in trunk/WebCore

2010-08-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: support checked and disabled context menu items.
​https://bugs.webkit.org/show_bug.cgi?id=44612

• platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):

7:42 AM Changeset in webkit [66014] by loislo@chromium.org

• 2 edits in trunk/WebCore

2010-08-25 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: InspectorBackendStub.js is not updated when Inspector.idl changes.
​https://bugs.webkit.org/show_bug.cgi?id=44604

• WebCore.xcodeproj/project.pbxproj:

7:24 AM Changeset in webkit [66013] by yurys@chromium.org

• 4 edits in trunk/WebCore

2010-08-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't stop on DOM breakpoints when all breakpoints are deactivated
​https://bugs.webkit.org/show_bug.cgi?id=44509

• bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::breakProgram):
• bindings/v8/ScriptDebugServer.h:
• inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create):

7:14 AM Changeset in webkit [66012] by yurys@chromium.org

• 8 edits in trunk/WebCore

2010-08-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazily request frontend settings instead of pushing them on connect
​https://bugs.webkit.org/show_bug.cgi?id=44607

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
• inspector/Inspector.idl:
• inspector/InspectorController.cpp: (WebCore::InspectorController::getSettings): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::populateScriptObjects): this method is now called explicitely from the frontend, it should be gone eventually once all panels request initial data lazily.
• inspector/InspectorController.h:
• inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype._reset):
• inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.initialize.populateApplicationSettings): (WebInspector.Settings.initialize.populateSessionSettings): (WebInspector.Settings.initialize):
• inspector/front-end/inspector.js: (WebInspector.doLoadedDone):

6:54 AM Changeset in webkit [66011] by mnaganov@chromium.org

• 1 edit
  1 delete in trunk/LayoutTests/platform

[Chromium] Unreviewed test expectations update for the 307-after-303-after-post test.

6:50 AM Changeset in webkit [66010] by pfeldman@chromium.org

• 6 edits in trunk/WebCore

2010-08-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: support disabled and checked context menu items.
​https://bugs.webkit.org/show_bug.cgi?id=44601

• bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
• bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
• inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.appendItem):

6:08 AM Changeset in webkit [66009] by commit-queue@webkit.org

• 3 edits in trunk

2010-08-25 Zaheer Ahmad <​zaheer.mot@gmail.com>

Reviewed by Xan Lopez.

[GTK] GTK port doesnt compile with video turned off
​https://bugs.webkit.org/show_bug.cgi?id=44236

Generate the audio GObject DOM bindings only if video enabled

• WebCore/GNUMakefile.am
• WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Make the audio code invocation conditional

5:16 AM Changeset in webkit [66008] by pfeldman@chromium.org

• 10 edits in trunk

2010-08-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=44532

Test: inspector/dom-breakpoint.html

• inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
• inspector/front-end/DOMAgent.js:
• inspector/front-end/ElementsTreeOutline.js:

2010-08-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=44532

• http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.waitUntilPaused.pausedScript): (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
• http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.): (initialize_InspectorTest):
• inspector/dom-breakpoints-expected.txt:
• inspector/dom-breakpoints.html:

4:59 AM Changeset in webkit [66007] by jorlow@chromium.org

• 13 edits in trunk

2010-08-25 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Pass the element's bounds to embedder during speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=44427

The embedder would typically want to show a native UI with information, settings etc.
By passing the display bounds of the html element, the embedder can position the
native speech recognition UI appropriately.

• page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
• page/SpeechInput.h:
• page/SpeechInputClient.h:
• platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition):
• platform/mock/SpeechInputClientMock.h:
• rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-08-25 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Pass the element's bounds to embedder during speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=44427

• public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
• src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
• src/SpeechInputClientImpl.h:
• src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
• src/WebSpeechInputControllerMockImpl.h:

4:52 AM Changeset in webkit [66006] by commit-queue@webkit.org

• 2 edits in trunk/WebKit/chromium

2010-08-25 Pawel Hajdan <​phajdan.jr@chromium.org>

Reviewed by Darin Fisher.

Add an assertion to prevent re-initializing WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=44545

This will help prevent crashes like:

• ​http://code.google.com/p/chromium/issues/detail?id=52731
• ​http://code.google.com/p/chromium/issues/detail?id=52643

• src/WebKit.cpp: (WebKit::initialize):

4:36 AM Changeset in webkit [66005] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=44461
Assertion failure at WebCore/platform/network/CredentialStorage.cpp:85.

Remove the assertion at CredentialStorage.cpp:85 since it is legal to have
multiple forward slashes after the path component.

No test needed.

• platform/network/CredentialStorage.cpp: (WebCore::protectionSpaceMapKeyFromURL):

4:03 AM Changeset in webkit [66004] by commit-queue@webkit.org

• 2 edits in trunk/JavaScriptCore

2010-08-25 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Changed the initial and subsequent allocation of vector storage to
Array()s. The changes are to limit sparse arrays to 100000 entries
and fixed the sparse map to vector storage conversion to use the
minimum amount of memory needed to store the current number of entries.
These changes address ​https://bugs.webkit.org/show_bug.cgi?id=43707

• runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::getNewVectorLength):

3:41 AM Changeset in webkit [66003] by jcivelli@chromium.org

• 2 edits
  4 adds in trunk/WebKit/chromium

2010-08-25 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

Adding missing test files and reenabling the WebFrame unit-test.
​https://bugs.webkit.org/show_bug.cgi?id=44492

• tests/WebFrameTest.cpp: (WebKit::TEST_F):
• tests/data/iframes_test.html: Added.
• tests/data/invisible_iframe.html: Added.
• tests/data/visible_iframe.html: Added.
• tests/data/zero_sized_iframe.html: Added.

3:06 AM Changeset in webkit [66002] by pfeldman@chromium.org

• 4 edits in trunk/WebCore

2010-08-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: search in Scripts panel brings ui back to original search view.
​https://bugs.webkit.org/show_bug.cgi?id=44516

• inspector/front-end/Panel.js: (WebInspector.Panel.prototype.searchCanceled): (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
• inspector/front-end/ResourcesPanel.js:
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.searchCanceled): (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback): (WebInspector.ScriptsPanel.prototype.performSearch): (WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

2:45 AM Changeset in webkit [66001] by tkent@chromium.org

• 8 edits in trunk

<input type=number>: Support auto-repeat by mouse press
​https://bugs.webkit.org/show_bug.cgi?id=44476

Reviewed by Shinichiro Hamaji

WebCore:

Like arrow button of scrollbars, spinbuttons of <input
type=number> should continue to increase/decrease their values
while the mouse button is pressed.

No new tests because the new behavior strongly depends on a timer.

• rendering/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):

Initializes the timer.

(WebCore::SpinButtonElement::defaultEventHandler):

Starts the timer by a mousedown event.

(WebCore::SpinButtonElement::startRepeatingTimer):
(WebCore::SpinButtonElement::stopRepeatingTimer):
(WebCore::SpinButtonElement::repeatingTimerFired):

• rendering/TextControlInnerElements.h:

LayoutTests:

Update existing tests.

• fast/forms/script-tests/input-spinbutton-capturing.js:
• platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum:
• platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
• platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

2:37 AM Changeset in webkit [66000] by tkent@chromium.org

• 4 edits in trunk/LayoutTests

2010-08-25 Kent Tamura <​tkent@chromium.org>

Unreviewed, skip list update.

input-spinbutton-capturing.html should be skipped in platforms
without spinbutton implementation.

• platform/gtk/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

2:36 AM Changeset in webkit [65999] by loki@webkit.org

• 8 edits in trunk

Avoid increasing required alignment of target type warning
​https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix alignment warnings on Qt.

WebCore:

• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

• platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

• platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::getAddr):

• platform/text/qt/TextCodecQt.cpp:

(WebCore::TextCodecQt::decode):

WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

• Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

2:28 AM Changeset in webkit [65998] by commit-queue@webkit.org

• 3 edits in trunk/WebKit2

2010-08-25 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement WebKit::Module for qt
​https://bugs.webkit.org/show_bug.cgi?id=44527

• Platform/Module.h:
• Platform/qt/ModuleQt.cpp: (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):

1:38 AM Changeset in webkit [65997] by tkent@chromium.org

• 3 edits
  3 adds in trunk

Fix a bug that a spin-button doesn't release mouse capturing
​https://bugs.webkit.org/show_bug.cgi?id=44411

Reviewed by Shinichiro Hamaji

WebCore:

• LeftButton should be checked only for clickEvent. Note that this change doesn't change the behavior because button() value is initialized with LeftButton even for mousemoveEvent.
• Should pass a SpinButtonElement node to setCapturingMouseEventsNode().

Test: fast/forms/input-spinbutton-capturing.html

• rendering/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

LayoutTests:

• fast/forms/input-spinbutton-capturing-expected.txt: Added.
• fast/forms/input-spinbutton-capturing.html: Added.
• fast/forms/script-tests/input-spinbutton-capturing.js: Added.

1:25 AM Changeset in webkit [65996] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

2010-08-25 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Change expectations on a test that now passes.
​https://bugs.webkit.org/show_bug.cgi?id=44524

• platform/chromium/test_expectations.txt:

1:23 AM Changeset in webkit [65995] by loki@webkit.org

• 5 edits in trunk

Avoid increasing required alignment of target type warning
​https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix platform independent alignment warnings.

JavaScriptCore:

• wtf/ListHashSet.h:

(WTF::ListHashSetNodeAllocator::pool):

WebCore:

• loader/CachedMetadata.h:

(WebCore::CachedMetadata::readUnsigned):

• platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

1:06 AM Changeset in webkit [65994] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Add missing methods at ResourceHandleWin
​https://bugs.webkit.org/show_bug.cgi?id=44453

• platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::willLoadFromCache): (WebCore::prefetchDNS): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::platformSetDefersLoading):

12:52 AM Changeset in webkit [65993] by loki@webkit.org

• 3 edits in trunk/JavaScriptCore

Enable truncated floating point feature on ARM
​https://bugs.webkit.org/show_bug.cgi?id=44233

Reviewed by Gavin Barraclough.

Enable truncated floating point feature with the help of VCVTR.S32.F64
instruction. If VCVTR.S32.F64 can't fit the result into a 32-bit
integer/register, it saturates at INT_MAX or INT_MIN. Testing this
looks quicker than testing FPSCR for exception.

Inspired by Jacob Bramley's patch from JaegerMonkey

• assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::vcvtr_s32_f64_r):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

12:21 AM Changeset in webkit [65992] by abarth@webkit.org

• 2 edits in trunk/WebCore

2010-08-25 Adam Barth <​abarth@webkit.org>

Second attempt to fix Qt build

• dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseDtd):

12:19 AM Changeset in webkit [65991] by tkent@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-08-25 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

• DEPS: Roll Chromium revision to 57298 to fix upstream build.

Aug 24, 2010:

11:57 PM Changeset in webkit [65990] by eric@webkit.org

• 4 edits in trunk/WebCore

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove more DTD junk now that the LegacyHTMLDocumentParser is gone
​https://bugs.webkit.org/show_bug.cgi?id=44588

Just removing dead code, thus no tests.

• html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName):
• html/HTMLElement.h:

11:53 PM Changeset in webkit [65989] by abarth@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Qt build fix.

• dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):

11:52 PM Changeset in webkit [65988] by tkent@chromium.org

• 4 edits in trunk

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix 26 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44580

• platform/chromium/drt_expectations.txt:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix 26 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44580

• DRTDevToolsAgent has a reference to the main WebView. So we should not clear it in closeDevTools() and should clear it in ~TestShell().
• DRTDevToolsClient has a reference to a DevTools WebView and no way to update it. So we should delete DRTDevToolsClient instances in closeDevTools().

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): (TestShell::closeDevTools):

11:46 PM Changeset in webkit [65987] by abarth@webkit.org

• 4 edits in trunk/LayoutTests

2010-08-24 Adam Barth <​abarth@webkit.org>

Unskip XSSAuditor test and fix the source of flakiness. I'll make the
test pass again in the XSSAuditor redesign.

• http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
• http/tests/security/xssAuditor/dom-write-innerHTML.html:
• platform/mac/Skipped:

11:21 PM Changeset in webkit [65986] by abarth@webkit.org

• 61 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Delete HTMLElement::checkDTD
​https://bugs.webkit.org/show_bug.cgi?id=44563

This function existed to service the LegacyHTMLTreeBuilder. The new
HTMLTreeBuilder has this logic internalized. Pulling on this thread
caused me to remove a legacyParserAddChild and to discover some code
that shouldn't be calling these parser-specific APIs.

• dom/ContainerNode.cpp: (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::deprecatedParserAddChild):
• dom/ContainerNode.h:
• dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
• dom/Node.cpp: (WebCore::Node::deprecatedParserAddChild):
• dom/Node.h:
• dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::enterText):
• dom/XMLDocumentParser.h:
• dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset):
• dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
• html/HTMLDataGridElement.cpp:
• html/HTMLDataGridElement.h:
• html/HTMLDataGridRowElement.cpp:
• html/HTMLDataGridRowElement.h:
• html/HTMLDataListElement.cpp:
• html/HTMLDataListElement.h:
• html/HTMLDocument.cpp:
• html/HTMLDocument.h:
• html/HTMLElement.cpp:
• html/HTMLElement.h:
• html/HTMLFieldSetElement.cpp:
• html/HTMLFieldSetElement.h:
• html/HTMLFrameSetElement.cpp:
• html/HTMLFrameSetElement.h:
• html/HTMLHeadElement.cpp:
• html/HTMLHeadElement.h:
• html/HTMLHeadingElement.cpp:
• html/HTMLHeadingElement.h:
• html/HTMLHtmlElement.cpp:
• html/HTMLHtmlElement.h:
• html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
• html/HTMLMapElement.cpp:
• html/HTMLMapElement.h:
• html/HTMLMediaElement.cpp:
• html/HTMLMediaElement.h:
• html/HTMLNoScriptElement.cpp:
• html/HTMLNoScriptElement.h:
• html/HTMLOptGroupElement.cpp:
• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.cpp:
• html/HTMLOptionElement.h:
• html/HTMLParagraphElement.cpp:
• html/HTMLParagraphElement.h:
• html/HTMLPlugInElement.cpp:
• html/HTMLPlugInElement.h:
• html/HTMLScriptElement.h:
• html/HTMLSelectElement.cpp:
• html/HTMLSelectElement.h:
• html/HTMLStyleElement.h:
• html/HTMLTableColElement.cpp:
• html/HTMLTableColElement.h:
• html/HTMLTableElement.cpp:
• html/HTMLTableElement.h:
• html/HTMLTableRowElement.cpp:
• html/HTMLTableRowElement.h:
• html/HTMLTableSectionElement.cpp:
• html/HTMLTableSectionElement.h:
• html/HTMLTextAreaElement.h:
• html/HTMLTitleElement.h:
• rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::attachToParent): (WebCore::MediaControlInputElement::attachToParent):
• rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement):

11:02 PM Changeset in webkit [65985] by eric@webkit.org

• 3 edits in trunk/LayoutTests

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5 spec changed to coalesce text nodes even when they were not created by the parser
​https://bugs.webkit.org/show_bug.cgi?id=44586

See ​http://www.w3.org/Bugs/Public/show_bug.cgi?id=10221 for more info.

• html5lib/resources/adoption01.dat:

10:53 PM Changeset in webkit [65984] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
​https://bugs.webkit.org/show_bug.cgi?id=44584

• Scripts/webkitpy/tool/commands/queues_unittest.py:

10:41 PM Changeset in webkit [65983] by dumi@chromium.org

• 4 edits in trunk/WebKit/chromium

Build fix: Remove setHTML5ParserEnabled(), it's no longer used.

Reviewed by Adam Barth.

• public/WebSettings.h:
• src/WebSettingsImpl.cpp:
• src/WebSettingsImpl.h:

10:38 PM Changeset in webkit [65982] by abarth@webkit.org

• 65 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove tagPriority
​https://bugs.webkit.org/show_bug.cgi?id=44557

This code used to be used by the old parser. Now it's unused.

• html/HTMLAnchorElement.h:
• html/HTMLAppletElement.h:
• html/HTMLAreaElement.h:
• html/HTMLAudioElement.h:
• html/HTMLBRElement.h:
• html/HTMLBaseElement.h:
• html/HTMLBaseFontElement.h:
• html/HTMLBlockquoteElement.h:
• html/HTMLBodyElement.h:
• html/HTMLCanvasElement.cpp:
• html/HTMLCanvasElement.h:
• html/HTMLDListElement.h:
• html/HTMLDataGridCellElement.h:
• html/HTMLDataGridColElement.h:
• html/HTMLDataGridElement.h:
• html/HTMLDataGridRowElement.h:
• html/HTMLDirectoryElement.h:
• html/HTMLDivElement.h:
• html/HTMLElement.cpp:
• html/HTMLElement.h:
• html/HTMLEmbedElement.h:
• html/HTMLFieldSetElement.h:
• html/HTMLFontElement.h:
• html/HTMLFormControlElement.h:
• html/HTMLFormElement.h:
• html/HTMLFrameElement.h:
• html/HTMLFrameSetElement.h:
• html/HTMLHRElement.h:
• html/HTMLHeadElement.h:
• html/HTMLHeadingElement.h:
• html/HTMLHtmlElement.h:
• html/HTMLIFrameElement.h:
• html/HTMLImageElement.h:
• html/HTMLInputElement.h:
• html/HTMLIsIndexElement.h:
• html/HTMLKeygenElement.h:
• html/HTMLLIElement.h:
• html/HTMLLabelElement.h:
• html/HTMLLinkElement.h:
• html/HTMLMapElement.h:
• html/HTMLMarqueeElement.h:
• html/HTMLMenuElement.h:
• html/HTMLMetaElement.h:
• html/HTMLModElement.h:
• html/HTMLOListElement.h:
• html/HTMLObjectElement.h:
• html/HTMLOptionElement.h:
• html/HTMLParagraphElement.h:
• html/HTMLParamElement.h:
• html/HTMLPreElement.h:
• html/HTMLQuoteElement.h:
• html/HTMLScriptElement.h:
• html/HTMLSelectElement.h:
• html/HTMLSourceElement.h:
• html/HTMLStyleElement.h:
• html/HTMLTableCaptionElement.h:
• html/HTMLTableCellElement.h:
• html/HTMLTableColElement.cpp:
• html/HTMLTableColElement.h:
• html/HTMLTableElement.h:
• html/HTMLTableRowElement.h:
• html/HTMLTableSectionElement.h:
• html/HTMLUListElement.h:
• html/HTMLVideoElement.h:

10:35 PM Changeset in webkit [65981] by eric@webkit.org

• 4 edits in trunk

2010-08-24 Dumitru Daniliuc <​dumi@chromium.org>

Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.

• platform/chromium/test_expectations.txt:

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix one more html5lib test case for button scoping
​https://bugs.webkit.org/show_bug.cgi?id=44583

I <3 test driven development.

• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):

10:21 PM Changeset in webkit [65980] by dumi@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.

• platform/chromium/test_expectations.txt:

10:11 PM Changeset in webkit [65979] by eric@webkit.org

• 5 edits in trunk/WebKitTools

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue and EWS bots should report all failures
​https://bugs.webkit.org/show_bug.cgi?id=41820

Right now commit-queue/EWS only report failures when the
patch under testing fails. We should report all failures
to the status server so that we can diagnose when the bots
are wedged w/o needing to log into the machines.

I also reduced the amount of data we upload since we've seen
timeouts during status upload.

• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/queues.py:
• Scripts/webkitpy/tool/commands/queues_unittest.py:

10:01 PM Changeset in webkit [65978] by eric@webkit.org

• 14 edits
  3 deletes in trunk

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

• html5lib/runner-expected-html5.txt: Removed.
• html5lib/webkit-resumer-expected-html5.txt: Removed.

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

Just removing dead code, no tests.

• dom/DocumentFragment.cpp:
• dom/DocumentFragment.h:
• page/Settings.cpp: (WebCore::Settings::Settings):
• page/Settings.h:

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm: (+[WebPreferences initialize]):
• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

• DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
• Scripts/old-run-webkit-tests:
• Scripts/test-html5-parser: Removed.

9:47 PM Changeset in webkit [65977] by abarth@webkit.org

• 3 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unneeded include in HTMLPreloadScanner
​https://bugs.webkit.org/show_bug.cgi?id=44552

Slowly but steadily sweeping up the dust in the HTML parser.

• html/HTMLPreloadScanner.cpp:
• html/HTMLPreloadScanner.h:

9:33 PM Changeset in webkit [65976] by eric@webkit.org

• 2 edits
  1 add in trunk/LayoutTests

2010-08-24 Eric Seidel <​eric@webkit.org>

Unreviewed. Just adding test results.

XMLDocumentParser needs to implement DocumentParser::detach()
​https://bugs.webkit.org/show_bug.cgi?id=44533

I was lame before and forgot to add results or mark this test
as dumpAsText().

• fast/css/font-face-svg-decoding-error-expected.txt: Added.
• fast/css/font-face-svg-decoding-error.html:

9:31 PM Changeset in webkit [65975] by kinuko@chromium.org

• 7 edits
  2 adds in trunk/WebCore

2010-08-24 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Implement virtual path utilities for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=44132

No new tests; tests will be added later. (Each DOMFilePath's method is briefly tested locally.)

• CMakeLists.txt:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• storage/DOMFilePath.cpp: Added.
• storage/DOMFilePath.h: Added.

9:27 PM Changeset in webkit [65974] by dumi@chromium.org

• 9 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

• platform/chromium-mac/fast/js/kde/Number-expected.txt:
• platform/chromium-mac/fast/js/number-toExponential-expected.txt:
• platform/chromium-mac/fast/js/number-tofixed-expected.txt:
• platform/chromium-mac/fast/js/number-toprecision-expected.txt:
• platform/chromium-win/fast/js/kde/Number-expected.txt:
• platform/chromium-win/fast/js/number-toExponential-expected.txt:
• platform/chromium-win/fast/js/number-tofixed-expected.txt:
• platform/chromium-win/fast/js/number-toprecision-expected.txt:
• platform/chromium/test_expectations.txt:

9:20 PM Changeset in webkit [65973] by abarth@webkit.org

• 3 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLParserScheduler::create
​https://bugs.webkit.org/show_bug.cgi?id=44551

• html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
• html/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::create):

9:18 PM Changeset in webkit [65972] by jianli@chromium.org

• 2 edits
  2 deletes in trunk/WebKit/chromium

[chromium] WebBlobRegistry cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=44571

Reviewed by Darin Fisher.

Remove unneeded method from WebBlobRegistry interface.
Also remove unneeded WebBlobRegistryImpl.* files. They're already
excluded from gyp files.

• public/WebBlobRegistry.h:
• src/WebBlobRegistryImpl.cpp: Removed.
• src/WebBlobRegistryImpl.h: Removed.

8:55 PM Changeset in webkit [65971] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

2010-08-24 Adam Barth <​abarth@webkit.org>

Add http/tests/security/xssAuditor/dom-write-location-inline-event.html
to the Skipped list. It's flaky after enabling the HTML5 fragment
parser. I need to investigate. However, I'm planning to redesign the
XSSAuditor to make use of the new parser, so it seems to make sense to
wait a bit.

• platform/mac/Skipped:

8:16 PM Changeset in webkit [65970] by dbates@webkit.org

• 2 edits in trunk

2010-08-24 Daniel Bates <​dbates@rim.com>

Fix the change log date associated with changeset 65967
<​http://trac.webkit.org/changeset/65967> in both the
LayoutTests and WebCore change log.

8:12 PM Changeset in webkit [65969] by dbates@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Daniel Bates <​dbates@rim.com>

Fix code comment as per Darin Adler's suggestion in <​https://bugs.webkit.org/show_bug.cgi?id=44486#c2>.
I inadvertently did not update this comment when I landed changeset 65967 <​http://trac.webkit.org/changeset/65967>.

• rendering/RenderListMarker.cpp: (WebCore::listMarkerSuffix):

8:10 PM Changeset in webkit [65968] by weinig@apple.com

• 2 edits in trunk/WebKit2

WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode
<rdar://problem/8348100>
​https://bugs.webkit.org/show_bug.cgi?id=44537

Reviewed by Mark Rowe.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Use posix_spawnattr_setbinpref_np
to tell posix_spawn to launch the WebProcess in 32-bit mode when the UIProcess
is running in 32-bit mode.

8:05 PM Changeset in webkit [65967] by dbates@webkit.org

• 6 edits
  3 adds in trunk

2010-08-23 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Suffix for CSS alphabetic list style types should fallback to
decimal for ordinals outside of their representable range
​https://bugs.webkit.org/show_bug.cgi?id=44486

Test: fast/lists/w3-css3-list-styles-fallback-style.html

Fixes an issue where the decimal suffix is not used for
ordinals that cannot be represented by the alphabetic list
style type.

Currently, for ordinals that cannot be represented in the
alphabetic list style we use the suffix associated with the
list style. Instead, we should use the suffix for the decimal
list style ('.'). For instance, when the list style type is
Afar and the starting ordinal is 0, then we fallback to the
decimal list style suffix '.' because 0 cannot be represented
in Afar.

• rendering/RenderListMarker.cpp: (WebCore::toRoman): Moved bounds check into WebCore::effectiveListMarkerType(). (WebCore::toAlphabetic): Ditto. (WebCore::toHebrew): Ditto. (WebCore::toArmenian): Ditto. (WebCore::toGeorgian): Ditto. (WebCore::toCJKIdeographic): Ditto. (WebCore::effectiveListMarkerType): Added. (WebCore::listMarkerSuffix): Added value parameter to prototype. Modified to call WebCore::effectiveListMarkerType. (WebCore::listMarkerText): Modified to call WebCore::effectiveListMarkerType(). (WebCore::RenderListMarker::paint): Modified to pass list item ordinal (i.e. m_listItem->value()) to WebCore::listMarkerSuffix(). (WebCore::RenderListMarker::calcPrefWidths): Ditto. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.

2010-08-23 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Suffix for CSS alphabetic list style types should fallback to
decimal for ordinals outside of their representable range
​https://bugs.webkit.org/show_bug.cgi?id=44486

Tests that CSS list styles fallback to the decimal list style
for ordinals that cannot be represented. We need to implement
DRT support to test the actual suffix (see bug #44489).

Also, adds test for ordinal 0 for each numeric list style type.

• fast/lists/resources/w3-css3-list-styles-alphabetic.css: Added.
• fast/lists/w3-css3-list-styles-alphabetic.html: Moved CSS list styles to file w3-css3-list-styles-alphabetic.css,
• fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Added.
• fast/lists/w3-css3-list-styles-fallback-style.html: Added.
• fast/lists/w3-css3-list-styles-numeric-expected.txt: Added test for ordinal 0 for each list style type.
• fast/lists/w3-css3-list-styles-numeric.html: Rebased result.

7:59 PM Changeset in webkit [65966] by tkent@chromium.org

• 4 edits in trunk

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix 28 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44574

• platform/chromium/drt_expectations.txt:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix 28 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44574

Reset DevToolsClient and DevToolsAgent before closing a DevTools
WebView in order to avoid accessing to a deleted WebView instance.

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeDevTools):

6:51 PM Changeset in webkit [65965] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

Windows build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

6:49 PM Changeset in webkit [65964] by abarth@webkit.org

• 2 edits in trunk/WebKit/chromium

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Hulu popups are blocked
​https://bugs.webkit.org/show_bug.cgi?id=44572

We were blocking popups created by Flash Player because we were never
setting the UserGestureIndicator for events. Most WebKit ports handle
events through EventHandler, but Chromium is special (for some unknown
reason) and dispatches events directly. That means Chromium misses out
on some of the work done by EventHandler, including setting the
UserGestureIndicator.

I suspect this is covered by an existing LayoutTest, but I don't have
the ability to run the Chromium LayoutTests on this machine. :(

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

6:34 PM Changeset in webkit [65963] by barraclough@apple.com

• 1 edit
  1 add in trunk/WebCore

Windows build fix.

• ForwardingHeaders/wtf/DecimalNumber.h: Added.

6:21 PM Changeset in webkit [65962] by barraclough@apple.com

• 5 edits in trunk/JavaScriptCore

Windows build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• wtf/DecimalNumber.h:

(WTF::DecimalNumber::intPow10):

• wtf/dtoa.cpp:
• wtf/dtoa.h:

6:09 PM Changeset in webkit [65961] by ojan@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

GC before running an iteration in the perf tests
​https://bugs.webkit.org/show_bug.cgi?id=44570

This is a speculative attempt at reducing flakiness.
There definitely are a lot of collected for some tests,
so, having GC happen in the middle of a run may very well
be causing flakiness.

• resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):

6:06 PM Changeset in webkit [65960] by tony@chromium.org

• 10 edits
  3 adds in trunk/LayoutTests

2010-08-24 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] rebaseline chromium linux svg tests
​https://bugs.webkit.org/show_bug.cgi?id=44562

These are anti-aliasing (rounding) differences on Linux.

• platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: The number 600 has a few pixels of extra space between characters.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
• platform/chromium-linux/svg/custom/animate-path-morphing-expected.checksum:
• platform/chromium-linux/svg/custom/animate-path-morphing-expected.png:
• platform/chromium-linux/svg/custom/use-transform-expected.checksum:
• platform/chromium-linux/svg/custom/use-transform-expected.png:
• platform/chromium/test_expectations.txt:

6:04 PM Changeset in webkit [65959] by barraclough@apple.com

• 21 edits
  2 adds in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=44487

Reviewed by Oliver Hunt.

Number.toExponential/toFixed/toPrecision all contain a spaghetti of duplicated
code & unnecessary complexity. Add a new DecimalNumber class to encapsulate
double to string conversion, share the implementations of rounding &
decimal-fraction/exponential formatting.

• JavaScriptCore.exp:

Update exports.

• runtime/NumberPrototype.cpp:

(JSC::toThisNumber):
(JSC::getIntegerArgumentInRange):

Helper methods used in implementing toExponential/toFixed/toString.

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

Reimplemented using new DecimalNumber class.

• runtime/UString.cpp:

(JSC::UString::number):

Updated to call numberToString.

• wtf/DecimalNumber.h: Added.

(WTF::):
(WTF::DecimalNumber::DecimalNumber):
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):
(WTF::DecimalNumber::sign):
(WTF::DecimalNumber::exponent):
(WTF::DecimalNumber::significand):
(WTF::DecimalNumber::precision):
(WTF::DecimalNumber::init):
(WTF::DecimalNumber::isZero):
(WTF::DecimalNumber::roundToPrecision):

New class to perform double to string conversion.
Has three constructors, which allow conversion with no rounding,
rounding to significant-figures, or rounding to decimal-places,
and two methods for formatting strings, either using decimal
fraction or exponential encoding. Internal implementation uses
pre-rounding of the values before calling dtoa rather than
relying on dtoa to correctly round, which does not produce
fully accurate results. Hopefully we can address this in the
near future.

• wtf/dtoa.cpp:

(WTF::intPow10):

• wtf/dtoa.h:

intPow10 is used internally by DecimalNumber.

• wtf/text/WTFString.cpp:

(WTF::copyToString):
(WTF::nanOrInfToString):

Used internally in numberToString for NaN/Infinity handling.

(WTF::numberToString):

Added new method to convert doubles to strings.

• wtf/text/WTFString.h:

Added declaration for numberToString. This is here because
we should switch over to using this for all double to string
conversion in WebCore (see section 2.4.4.3 of the HTML5 spec).

JavaScriptGlue: ​https://bugs.webkit.org/show_bug.cgi?id=44487

Reviewed by Oliver Hunt.

• ForwardingHeaders/wtf/text/WTFString.h: Added.

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=44487

Reviewed by Oliver Hunt.

• html/LegacyHTMLTreeBuilder.cpp:

(WebCore::serializeForNumberType):

Update function call to numberToString.

LayoutTests: Bug 44487 - Clean up NumberPrototype.cpp

Reviewed by Oliver Hunt.

This patch changes some layout test results - in all these cases we were
not previously accurate to spec defined behaviour, and we are still not

• but overall this changes reduces the overall magnitude of error due to

rounding differences. The underlying problem is that we should be using
dtoa to generate results to a specified accuracy, rather than relying on
pre-rounding the input values. We should look at reenabling our dtoa
implementation to work in this fashion as a separate change.

• fast/js/kde/Number-expected.txt:
• fast/js/kde/script-tests/Number.js:
• fast/js/number-toExponential-expected.txt:
• fast/js/number-tofixed-expected.txt:
• fast/js/number-toprecision-expected.txt:
• fast/js/script-tests/number-toExponential.js:
• fast/js/script-tests/number-tofixed.js:
• fast/js/script-tests/number-toprecision.js:

5:40 PM Changeset in webkit [65958] by eric@webkit.org

• 11 edits
  3 adds in trunk

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser needs to implement DocumentParser::detach()
​https://bugs.webkit.org/show_bug.cgi?id=44533

Added a test which uses an image as an SVG font (decoding errors galore).

XML versions of one of the tests from
​http://trac.webkit.org/changeset/65692

• fast/css/font-face-svg-decoding-error.html: Added.
• fast/frames/resources/set-src-to-javascript-url.xhtml: Added.
• fast/frames/set-parent-src-synchronously.xhtml: Added.

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser needs to implement DocumentParser::detach()
​https://bugs.webkit.org/show_bug.cgi?id=44533

Test: fast/frames/set-parent-src-synchronously.xhtml

In the example from the page we were accessing document()
after DocumentParser::detach() was called. To prevent this
I added an ASSERT(m_document) to document(), causing many
test cases to cover the bug shown in bug 44533.

To fix the bug, I implemented XMLDocumentParser::detach()
and had it call clearCurrentNodeStack(), thus making
it impossible for XMLDocumentParser to still have the Document
on the node stack after detach (which was what was causing this bug).

While fixing this, I noticed that XMLDocumentParser may have the
same trouble crashing that the HTMLDocumentParser did when
synchronously deleted from JS (for example by an iframe navigation).
I added a test case to cover this and protected the parser after
the two places it executes scripts.

• dom/DocumentParser.h: (WebCore::DocumentParser::document): (WebCore::DocumentParser::isDetached):
• dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
• dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::detach): (WebCore::XMLDocumentParser::notifyFinished):
• dom/XMLDocumentParser.h:
• dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::resumeParsing):
• html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::willPumpLexer): (WebCore::HTMLDocumentParser::didPumpLexer): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::script):
• html/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
• html/HTMLViewSourceParser.h: (WebCore::HTMLViewSourceParser::document):
• loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::document):

5:39 PM Changeset in webkit [65957] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Add SynchronousLoader for ResourceHandleWin
​https://bugs.webkit.org/show_bug.cgi?id=44452

• platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):

5:31 PM Changeset in webkit [65956] by dumi@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

Unreviewed, updating a chromium-linux expectation.

• platform/chromium-linux/svg/css/shadow-changes-expected.checksum: Added.
• platform/chromium-linux/svg/css/shadow-changes-expected.png: Added.

5:24 PM Changeset in webkit [65955] by kbr@google.com

• 2 edits in trunk/LayoutTests

2010-08-24 Kenneth Russell <​kbr@google.com>

Unreviewed, test expectations update. Skip
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html while
root cause of failure is being investigated. See
​https://bugs.webkit.org/show_bug.cgi?id=44459 .

• platform/mac-snowleopard/Skipped:

5:22 PM Changeset in webkit [65954] by tkent@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

• platform/chromium/drt_expectations.txt: Add inspector test failures.

5:10 PM Changeset in webkit [65953] by dpranke@chromium.org

• 7 edits
  2 adds in trunk/WebKitTools

2010-08-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: clean up code for test_types, test_failures

Add a bunch of unit tests for webkitpy.layout_tests.test_types and
webkitpy.layout_tests.layout_package.test_failures, and remove
some dead code and otherwise clean up things.

​https://bugs.webkit.org/show_bug.cgi?id=44559

• Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
• Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
• Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
• Scripts/webkitpy/layout_tests/test_types/image_diff.py:
• Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
• Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
• Scripts/webkitpy/layout_tests/test_types/text_diff.py:

5:09 PM Changeset in webkit [65952] by adachan@apple.com

• 2 edits in trunk/WebKit/win

Reviewed by Steve Falkenburg.

<rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
​https://bugs.webkit.org/show_bug.cgi?id=44564

• WebView.cpp: (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL if plugins are disabled.

5:02 PM Changeset in webkit [65951] by dpranke@chromium.org

• 6 edits
  35 adds
  15 deletes in trunk/WebKitTools

2010-08-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: revise unit testing strategy for test failures

This change revamps the way we store test data for new-run-webkit-tests.
Previously we had a few copies of test files from the main test tree.
Now we have a bunch of completely fake test data and use the test
data to generate different kinds of test failures, getting
much better coverage.

​https://bugs.webkit.org/show_bug.cgi?id=44556

• Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
• Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
• Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
• Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
• Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
• Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
• Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
• Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
• Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
• Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
• Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
• Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
• Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
• Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
• Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
• Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
• Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
• Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
• Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
• Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
• Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
• Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
• Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
• Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
• Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
• Scripts/webkitpy/layout_tests/port/test.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

4:48 PM Changeset in webkit [65950] by rniwa@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Replaced soft tab indentation by hard tab indentation for LegacyWebArchive.h.

• WebCore.xcodeproj/project.pbxproj:

4:45 PM Changeset in webkit [65949] by dpranke@chromium.org

• 3 edits in trunk/WebKitTools

2010-08-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

speed up new-run-webkit-tests unit tests

Add a --no-record-results flag that turns off generating the JSON
results file on every test run. Generating the file requires us to
fetch the old results down from the bots, which can be slow. This
flag is off by default.

Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.

These changes together shorten the test cycle from ~4.5s to ~1.5s

• a 3x speedup.

​https://bugs.webkit.org/show_bug.cgi?id=44553

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

4:17 PM Changeset in webkit [65948] by dumi@chromium.org

• 2 edits
  5 adds in trunk/LayoutTests

Unreviewed, more Chromium-specific expectations.

• platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum: Added.
• platform/chromium-mac/fast/repaint/multicol-repaint-expected.png: Added.
• platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum: Added.
• platform/chromium-win/fast/repaint/multicol-repaint-expected.png: Added.
• platform/chromium-win/fast/repaint/multicol-repaint-expected.txt: Added.
• platform/chromium/test_expectations.txt:

3:55 PM Changeset in webkit [65947] by oliver@apple.com

• 6 edits
  1 add in trunk

2010-08-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

Don't seed the JS random number generator from time()
​https://bugs.webkit.org/show_bug.cgi?id=41868
<rdar://problem/8171025>

Switch to using the secure random number generator to
seed the fast random generator, and make the generator
be per global object.

• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
• runtime/JSGlobalData.h:
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::weakRandomNumber):
• runtime/MathObject.cpp: (JSC::mathProtoFuncRandom):

3:47 PM Changeset in webkit [65946] by jianli@chromium.org

• 4 edits in trunk/WebKit/chromium

[chromium] Update WebBlobData.
​https://bugs.webkit.org/show_bug.cgi?id=44481

Reviewed by Darin Fisher.

Some changes to WebBlobData to match with chromium implementation.
1) Change to use WebCString for data, instead of WebData.
2) Separate path from URL.

• public/WebBlobData.h:
• src/WebBlobData.cpp:

(WebKit::WebBlobData::itemAt):
(WebKit::WebBlobData::appendData):
(WebKit::WebBlobData::appendBlob):

• src/WebBlobStorageData.cpp:

(WebKit::WebBlobStorageData::itemAt):

3:41 PM Changeset in webkit [65945] by dumi@chromium.org

• 3 edits
  5 adds in trunk/LayoutTests

Unreviewed, updating Chromium-specific expectations.

• platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
• platform/chromium-win/svg/css/shadow-changes-expected.checksum: Added.
• platform/chromium-win/svg/css/shadow-changes-expected.png: Added.
• platform/chromium-win/svg/css/shadow-changes-expected.txt: Added.
• platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.checksum: Added.
• platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png: Added.

3:37 PM Changeset in webkit [65944] by tony@chromium.org

• 2 edits in trunk/WebKitTools

2010-08-24 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] fix the platform result fallback order on mac/win
​https://bugs.webkit.org/show_bug.cgi?id=44483

• Scripts/webkitpy/layout_tests/port/google_chrome.py:

3:33 PM Changeset in webkit [65943] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2010-08-24 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Mark Rowe.

Web Inspector: RemoteInspectorFrontend can be renamed to InspectorFrontend
​https://bugs.webkit.org/show_bug.cgi?id=44499

Follow-up. No longer generate the RemoteInspectorFrontend files, just
generate the required InspectorFrontend files.

• DerivedSources.make:

3:33 PM Changeset in webkit [65942] by Joseph Pecoraro

• 9 edits in trunk/WebCore

2010-08-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Backend Should Provide Full Supported CSS Properties List
​https://bugs.webkit.org/show_bug.cgi?id=40886

This allows the backend to send the front-end its complete list of
supported CSS Properties. This is used in CSS Autocompletion and
CSS Syntax Highlighting to show which styles are supported.

• css/makeprop.pl: moved CSS properties to the header file.
• inspector/Inspector.idl: expose getSupportedCSSProperties.
• inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
• inspector/InspectorDOMAgent.h:
• inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions._firstIndexOfPrefix): handle a possible error case before properties have loaded. (WebInspector.CSSCompletions._load): fill up the special array with the received properties.
• inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): use the list of support properties from the backend.
• inspector/front-end/SourceCSSTokenizer.re2js:
• inspector/front-end/inspector.js: request the list of supported CSS properties on load. (WebInspector.doLoadedDone):

3:27 PM Changeset in webkit [65941] by abarth@webkit.org

• 22 edits
  2 deletes in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Delete LegacyHTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=44554

There were some free functions in LegacyHTMLTreeBuilder that needed a
new home. I've put them in HTMLTreeBuilder, but they'll probably need
a better home eventually.

• Android.mk:
• CMakeLists.txt:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp: (WebCore::shouldCreateImplicitHead):
• dom/DocumentParser.h:
• dom/ScriptableDocumentParser.h:
• html/HTMLConstructionSite.cpp:
• html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
• html/HTMLInputElement.cpp:
• html/HTMLMeterElement.cpp:
• html/HTMLProgressElement.cpp:
• html/HTMLTreeBuilder.cpp: (WebCore::serializeForNumberType): (WebCore::parseToDoubleForNumberType):
• html/HTMLTreeBuilder.h:
• html/HTMLViewSourceParser.h:
• html/LegacyHTMLTreeBuilder.cpp: Removed.
• html/LegacyHTMLTreeBuilder.h: Removed.
• html/StepRange.cpp:
• html/ValidityState.cpp:
• rendering/RenderSlider.cpp:

3:22 PM Changeset in webkit [65940] by ojan@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

perf tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=44199

Speculative fix for perf test flakiness. Use chromium.Interval
to get a microsecond granularity timer. If this does end up
reducing flakiness, then we can expose something similar for
JSC and/or layoutTestController.

• resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):

3:16 PM Changeset in webkit [65939] by commit-queue@webkit.org

• 13 edits in trunk

2010-08-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: show DOM breakpoints in sidebar pane
​https://bugs.webkit.org/show_bug.cgi?id=44424

• inspector/dom-breakpoints.html:

2010-08-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: show DOM breakpoints in sidebar pane
​https://bugs.webkit.org/show_bug.cgi?id=44424

• inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._setBreakpoint): (WebInspector.BreakpointManager.prototype._breakpointRemoved): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.set condition): (WebInspector.Breakpoint.prototype.remove):
• inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype.element): (WebInspector.BreakpointItem.prototype.remove): (WebInspector.BreakpointItem.prototype._checkboxClicked): (WebInspector.BreakpointItem.prototype._enableChanged): (WebInspector.BreakpointItem.prototype._removed): (WebInspector.JSBreakpointItem): (WebInspector.JSBreakpointItem.prototype._textChanged): (WebInspector.DOMBreakpointItem): (WebInspector.DOMBreakpointItem.prototype.compareTo):
• inspector/front-end/DOMAgent.js: (WebInspector.DOMBreakpointManager): (WebInspector.DOMBreakpointManager.prototype.setBreakpoint): (WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode): (WebInspector.DOMBreakpointManager.prototype._breakpointRemoved): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype.get enabled): (WebInspector.DOMBreakpoint.prototype.set enabled): (WebInspector.DOMBreakpoint.prototype.remove):
• inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset):
• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
• inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype.reset):
• inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype._breakpointRemoved): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown):
• inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.updateLocalContent):
• inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane.breakpointAdded): (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded): (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.doLoadedDone):

2:51 PM Changeset in webkit [65938] by senorblanco@chromium.org

• 2 edits in trunk/WebCore

2010-08-24 Stephen White <​senorblanco@chromium.org>

Reviewed by Dumitru Daniliuc.

Speculative fix for layout test failures on Chrome/Linux.
​https://bugs.webkit.org/show_bug.cgi?id=44550

Tests fast/canvas/arc-crash.html, fast/canvas/canvas-state-intact-after-putImageData.html, and fast/canvas/toDataURL-supportedTypes.html are failing on Chrome/Linux. Can't repro the failure locally, but this fix can't hurt.

• html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):

2:42 PM Changeset in webkit [65937] by dumi@chromium.org

• 5 edits in trunk

WebCore: Fix the NodeFilter wrapper and the binding for acceptNode.
​https://bugs.webkit.org/show_bug.cgi?id=44542

Reviewed by Dimitri Glazkov.

• bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::wrapNativeNodeFilter): This function
should always create a filter. V8NodeFilterCondition::acceptNode()
will check if the given object can be used as a filter, and throw
an exception if it can't.

• bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode): Update this binding
to do the same thing that the JS binding does.

LayoutTests: acceptNode-filter.html should pass after this patch.
​https://bugs.webkit.org/show_bug.cgi?id=44542

Reviewed by Dimitri Glazkov.

• platform/chromium/test_expectations.txt:

2:24 PM Changeset in webkit [65936] by tony@chromium.org

• 27 edits
  14 adds in trunk/LayoutTests

2010-08-24 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] linux layout test results for svg tests
​https://bugs.webkit.org/show_bug.cgi?id=44303

• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
• platform/chromium-linux/svg/carto.net/slider-expected.checksum:
• platform/chromium-linux/svg/carto.net/slider-expected.png:
• platform/chromium-linux/svg/carto.net/textbox-expected.checksum:
• platform/chromium-linux/svg/carto.net/textbox-expected.png:
• platform/chromium-linux/svg/carto.net/window-expected.txt: Added.
• platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.checksum:
• platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.png: Added.
• platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
• platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
• platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
• platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
• platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
• platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
• platform/chromium-linux/svg/hixie/text/003b-expected.txt: Added.
• platform/chromium/test_expectations.txt:

2:14 PM Changeset in webkit [65935] by tony@chromium.org

• 5 edits
  2 adds in trunk/LayoutTests

2010-08-24 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] linux baselines for a few svg tests
​https://bugs.webkit.org/show_bug.cgi?id=44286

These are all font differences from the windows and mac results. On
Linux, we have stronger anti-aliasing of fonts than windows although
we match the windows font metrics (which is why these are only pixel
results).

• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
• platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
• platform/chromium/drt_expectations.txt:
• platform/chromium/test_expectations.txt:

2:01 PM Changeset in webkit [65934] by Simon Fraser

• 2 edits in trunk/WebCore

2010-08-24 Simon Fraser <Simon Fraser>

Reviewed by Tony Chang.

After r65681, caret no longer displays promptly while editing form fields
​https://bugs.webkit.org/show_bug.cgi?id=44294

The caret no longer eagerly updates its rect on every paint, so we have
to manually update it after scrolling the selection into view when
the selection changes.

Tested by the pixel results of fast/forms/input-text-scroll-left-on-blur.html

• page/Frame.cpp: (WebCore::Frame::revealSelection):

1:55 PM Changeset in webkit [65933] by abarth@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove redundant call to OwnPtr::clear
​https://bugs.webkit.org/show_bug.cgi?id=44548

As pointed out by Darin, this call to clear is not needed.

• editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):

1:49 PM Changeset in webkit [65932] by abarth@webkit.org

• 7 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTokenizer::create
​https://bugs.webkit.org/show_bug.cgi?id=44477

• html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
• html/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): (WebCore::HTMLPreloadScanner::scan): (WebCore::HTMLPreloadScanner::processToken):
• html/HTMLPreloadScanner.h:
• html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::create):
• html/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::pumpTokenizer): (WebCore::HTMLViewSourceParser::updateTokenizerState):
• html/HTMLViewSourceParser.h:

1:43 PM Changeset in webkit [65931] by abarth@webkit.org

• 5 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove references to LegacyHTMLTreebuilder from HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=44544

• html/HTMLDocumentParser.cpp:
• html/HTMLDocumentParser.h:
• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::finished):
• html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):

1:38 PM Changeset in webkit [65930] by mrowe@apple.com

• 2 edits in trunk/WebKit2

Set the install path of WebKit2.framework to the build directory for debug and release builds
to match our other frameworks.

Rubber-stamped by Sam Weinig.

• WebKit2.xcodeproj/project.pbxproj:

1:26 PM Changeset in webkit [65929] by xan@webkit.org

• 2 edits in trunk

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Build fix, strike 2.

The unit tests are C files, so put the flag in global_cflags.

• GNUmakefile.am:

1:22 PM Changeset in webkit [65928] by Simon Fraser

• 1 edit
  3 adds in trunk/LayoutTests

2010-08-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Add test for a NodeFilter throwing
​https://bugs.webkit.org/show_bug.cgi?id=44480

The TreeWalker DOM spec says that an exception thrown inside the NodeFilter should
propagate out to the caller. This tests that.

• fast/dom/TreeWalker/filter-throw-expected.txt: Added.
• fast/dom/TreeWalker/filter-throw.html: Added.
• fast/dom/TreeWalker/script-tests/filter-throw.js: Added. (walker.document.createTreeWalker):

1:20 PM Changeset in webkit [65927] by xan@webkit.org

• 4 edits in trunk

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

Move GTK_API_VERSION_2 define to here, since we want to use it
outside of WebCore/WebKit.

• GNUmakefile.am:

WebCore:

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

Move GTK_API_VERSION_2 define out.

• GNUmakefile.am:

1:08 PM Changeset in webkit [65926] by Simon Fraser

• 3 edits
  3 adds in trunk

2010-08-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

TreeWalker traversal order is wrong when skipping and rejecting
​https://bugs.webkit.org/show_bug.cgi?id=44377

TreeWalker's nextSibling() and previousSibling() behaved incorrectly
when traversing down a subtree where all nodes are skipped; it backed all
the way up to the root of the subtree, then jump to the subtree's parentNode.
This would skip later siblings.

Fix by resetting 'node' when traversing to children so that node = node->parentNode()
gets the correct node later.

Test: fast/dom/TreeWalker/traversal-skip-most.html

• dom/TreeWalker.cpp: (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling):

12:55 PM Changeset in webkit [65925] by xan@webkit.org

• 4 edits in trunk

WebKit/gtk:

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Set a device to the event struct when building with GTK+ 3.x, it's
mandatory.

• tests/testcopyandpaste.c: (runPasteTestCallback):

WebKitTools:

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Set a device to the event struct when building with GTK+ 3.x, it's
mandatory.

• DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):

12:52 PM Changeset in webkit [65924] by commit-queue@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

Remove null-checks from DeviceOrientationController
​https://bugs.webkit.org/show_bug.cgi?id=44504

Remove checks for m_client being NULL from DeviceOrientationController.
It will never be NULL, and this is checked by an ASSERT on construction.

Will be covered by layout tests for device orientation.

• dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::addListener): (WebCore::DeviceOrientationController::removeListener): (WebCore::DeviceOrientationController::removeAllListeners):

12:39 PM Changeset in webkit [65923] by Martin Robinson

• 2 edits in trunk/WebKit/gtk

2010-08-24 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

• tests/testkeyevents.c: (key_press_event_cb): (key_release_event_cb):

12:31 PM QtWebKitGitInstructions edited by Ademar Reis

(diff)

12:26 PM Changeset in webkit [65922] by Martin Robinson

• 4 edits in trunk

2010-08-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
​https://bugs.webkit.org/show_bug.cgi?id=44534

Fix an issue where a GdkEvent* is treated like a GdkEvent.

• tests/testkeyevents.c: (key_press_event_cb): (key_release_event_cb):

2010-08-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
​https://bugs.webkit.org/show_bug.cgi?id=44534

Fix two double-frees introduced in my previous commit.

• DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): Copy the event before using it again. (keyDownCallback): Ditto.

12:17 PM Changeset in webkit [65921] by senorblanco@chromium.org

• 7 edits in trunk/WebCore

2010-08-24 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Fix accelerated 2d canvas with accelerated compositing off.
​https://bugs.webkit.org/show_bug.cgi?id=44525

Tested by running with --enable-accelerated-2d-canvas with
--enable-accelerated-compositing off.
ImageBuffer::copyImage changes covered by
LayoutTests/fast/canvas/canvas-pattern-*.html.

• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Extend the accelerated compositing check and the readback for non-accelerated compositing to accelerated 2D canvas also.
• html/canvas/CanvasRenderingContext.cpp:
• html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer): Move this logic from WebGL to common canvas context code.
• html/canvas/WebGLRenderingContext.h: Remove implementation of paintsIntoCanvasBuffer.
• platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::copyImage): When copying the image for patterns, sync the software canvas.
• platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw): Use SkDevice::eraseColor() to clear the canvas for mixed mode rendering.

12:00 PM Changeset in webkit [65920] by oliver@apple.com

• 2 edits in trunk/JavaScriptCore

2010-08-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Beth Dakin.

Make overflow guards in UString::utf8 explicit
​https://bugs.webkit.org/show_bug.cgi?id=44540

Add an explicit overflow check prior to allocating our buffer,
rather than implicitly relying on the guard in convertUTF16ToUTF8.

• runtime/UString.cpp: (JSC::UString::utf8):

11:37 AM Changeset in webkit [65919] by abarth@webkit.org

• 3 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Deploy adoptPtr in WebCore/editing
​https://bugs.webkit.org/show_bug.cgi?id=44501

• editing/Editor.cpp: (WebCore::Editor::Editor):
• editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):

11:35 AM Changeset in webkit [65918] by abarth@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Deploy adoptPtr in WebCore/history
​https://bugs.webkit.org/show_bug.cgi?id=44502

• history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::addRedirectURL):

11:33 AM Changeset in webkit [65917] by abarth@webkit.org

• 8 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Partial deployment of adoptPtr to WebCore/html
​https://bugs.webkit.org/show_bug.cgi?id=44507

Deploy adoptPtr to some more places in WebCore/html. The big chunk
that I haven't done yet is createRenderer, but that's going to be a big
patch unto itself.

• html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo):
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::addElementAlias):
• html/HTMLInputElement.cpp: (WebCore::createTypeMap): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::preDispatchEventHandler):
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach):
• html/HTMLToken.h: (WebCore::HTMLToken::beginDOCTYPE):
• html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::parseMappedAttribute):
• html/ValidityState.h: (WebCore::ValidityState::create):

11:31 AM Changeset in webkit [65916] by abarth@webkit.org

• 6 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Partial deployment of adoptPtr to WebCore/html
​https://bugs.webkit.org/show_bug.cgi?id=44507

There's a lot of places that need adoptPtr in WebCore/html. This patch
does some of them. More will follow.

• html/FileThreadTask.h: (WebCore::FileThreadTask0::create): (WebCore::FileThreadTask1::create): (WebCore::FileThreadTask2::create): (WebCore::FileThreadTask3::create):
• html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
• html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::pushCommon):
• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::attach):

11:08 AM Changeset in webkit [65915] by Martin Robinson

• 5 edits in trunk

2010-08-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
​https://bugs.webkit.org/show_bug.cgi?id=44534

• tests/testcopyandpaste.c: (runPasteTestCallback): Switch to using gdk_event_new and also reference the GdkWindow. when setting it on the event. It is dereferenced by gdk_event_free(...).
• tests/testhittestresult.c: (load_status_cb): Switch to using gdk_event_new.

2010-08-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
​https://bugs.webkit.org/show_bug.cgi?id=44534

• DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow when setting it on the event. It is dereferenced by gdk_event_free(...). (contextClickCallback): Ditto. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent. (dispatchEvent): Ditto. Also free the event when we are done with it. (keyDownCallback): Use gdk_event_new and reference the GdkWindow.

11:05 AM Changeset in webkit [65914] by Simon Fraser

• 1 edit
  6 adds in trunk/LayoutTests

2010-08-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

TreeWalker traversal order is wrong when skipping and rejecting
​https://bugs.webkit.org/show_bug.cgi?id=44377

Add some tests for TreeWalker with node filters that skip and reject.

• fast/dom/TreeWalker/script-tests/traversal-reject.js: Added. (rejectB1Filter.acceptNode): (rejectB2Filter.acceptNode):
• fast/dom/TreeWalker/script-tests/traversal-skip.js: Added. (skipB1Filter.acceptNode): (skipB2Filter.acceptNode):
• fast/dom/TreeWalker/traversal-reject-expected.txt: Added.
• fast/dom/TreeWalker/traversal-reject.html: Added.
• fast/dom/TreeWalker/traversal-skip-expected.txt: Added.
• fast/dom/TreeWalker/traversal-skip.html: Added.

11:03 AM Changeset in webkit [65913] by weinig@apple.com

• 2 edits in trunk/WebCore

Improve comment for Simon.

Reviewed by Simon Fraser.

• editing/Editor.h:

10:59 AM Changeset in webkit [65912] by weinig@apple.com

• 7 edits
  2 adds in trunk

Paste event fires twice for mac WebKit
<rdar://problem/8094611>
​https://bugs.webkit.org/show_bug.cgi?id=44535

Reviewed by Oliver Hunt.

WebCore:

The mac implementation of paste in WebKit was accidentally calling
Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
Use the new pasteAsPlainTextBypassingDHTML function to bypass the
second call.

Test: editing/pasteboard/paste-event-only-once.html

• WebCore.exp.in:
• editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainTextBypassingDHTML):

• editing/Editor.h:

Expose a function which just pastes using from the general pasteboard,
bypassing all the checking and DHTML pasting.

WebKit/mac:

The mac implementation of paste in WebKit was accidentally calling
Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
Use the new pasteAsPlainTextBypassingDHTML function to bypass the
second call.

• WebView/WebHTMLView.mm:

(-[WebHTMLView paste:]):

LayoutTests:

• editing/pasteboard/paste-event-only-once-expected.txt: Added.
• editing/pasteboard/paste-event-only-once.html: Added.

10:53 AM Changeset in webkit [65911] by Nate Chapin

• 2 edits in trunk/WebCore

2010-08-24 Nate Chapin <Nate Chapin>

Unreviewed.

Chromium build fix (add a #include missing in PingLoader.cpp)

• loader/PingLoader.cpp:

10:26 AM Changeset in webkit [65910] by Nate Chapin

• 11 edits
  7 adds in trunk

2010-08-24 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Allow image loads triggered from unload handlers to run entirely
independently of any other loads or navigations.

​https://bugs.webkit.org/show_bug.cgi?id=30457

Test: http/tests/navigation/image-load-in-unload-handler.html

• Android.mk:
• CMakeLists.txt:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• loader/DocLoader.cpp: (WebCore::DocLoader::requestImage): Use PingLoader for image

loads in unload handlers.

• loader/FrameLoader.h: (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
• loader/PingLoader.cpp: Added. (WebCore::PingLoader::loadImage): Set the appropriate

headers for an image load in unload handler (since we're
not using SubresourceLoader, we need to do this manually here).

(WebCore::PingLoader::PingLoader):

• loader/PingLoader.h: Added. (WebCore::PingLoader::~PingLoader): (WebCore::PingLoader::didReceiveResponse): (WebCore::PingLoader::didReceiveData): (WebCore::PingLoader::didFinishLoading): (WebCore::PingLoader::didFail):

10:10 AM Changeset in webkit [65909] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fix new inspector test expectation.

• inspector/styles-computed-trace-expected.txt:

9:50 AM Changeset in webkit [65908] by weinig@apple.com

• 2 edits in trunk/WebKit2

Update profile.

Reviewed by John Sullivan.

• WebProcess/com.apple.WebProcess.sb:

9:48 AM Changeset in webkit [65907] by demarchi@webkit.org

• 3 edits in trunk/WebKit/efl

2010-08-24 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Extended EFL WebView API to allow enable/disable Frame Flattening
​https://bugs.webkit.org/show_bug.cgi?id=44253

• ewk/ewk_view.cpp: (ewk_view_setting_enable_frame_flattening_get): (ewk_view_setting_enable_frame_flattening_set):
• ewk/ewk_view.h:

9:40 AM Changeset in webkit [65906] by demarchi@webkit.org

• 2 edits in trunk

2010-08-24 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

[EFL] Unreviewed build fix after r65891.

r65891 renamed RemoteInspectorFrontend to InspectorFrontend. Rename
accordingly in CMake build system.

• cmake/WebKitGenerators.cmake:

9:15 AM Changeset in webkit [65905] by pfeldman@chromium.org

• 14 edits
  2 adds in trunk

2010-08-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Trace to the style that contributes to
the computed styles panel.
​https://bugs.webkit.org/show_bug.cgi?id=44448

Test: inspector/styles-computed-trace.html

• English.lproj/localizedStrings.js:
• inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsTextForTest):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._refreshUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylePropertiesSection.linkifyUncopyable): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.isPropertyDisabled): (WebInspector.StylePropertiesSection.prototype.update): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.ComputedStylePropertiesSection): (WebInspector.ComputedStylePropertiesSection.prototype.collapse): (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited): (WebInspector.ComputedStylePropertiesSection.prototype.update): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): (WebInspector.BlankStylePropertiesSection):
• inspector/front-end/inspector.css: (.styles-section a::before):
• inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.linkifyResourceAsNode):

2010-08-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Trace to the style that contributes to
the computed styles panel.
​https://bugs.webkit.org/show_bug.cgi?id=44448

• inspector/elements-panel-styles-expected.txt:
• inspector/elements-tests.js: (frontend_getSelectedElementStyles): (frontend_dumpStyleTreeItem):
• inspector/styles-computed-trace-expected.txt: Added.
• inspector/styles-computed-trace.html: Added.
• inspector/styles-disable-inherited-expected.txt:
• inspector/styles-disable-inherited.html:
• inspector/styles-disable-then-delete-expected.txt:
• inspector/styles-source-lines-inline-expected.txt:

9:06 AM Changeset in webkit [65904] by commit-queue@webkit.org

• 19 edits in trunk

2010-08-24 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Eric Seidel.

[chromium] Generate drag images for HTML elements and selections.
​https://bugs.webkit.org/show_bug.cgi?id=43449

We weren't properly generating drag images if an HTML element was set
as the drag feedback image. I also implemented dragImageForSelection
while I was working on this part of the code.

No new tests.

• WebCore.exp.in:
• bindings/objc/DOM.mm: (-[DOMNode renderedImage]):
• page/Frame.h:
• page/brew/FrameBrew.cpp: (WebCore::Frame::nodeImage):
• page/chromium/FrameChromium.cpp: (WebCore::): (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
• page/efl/FrameEfl.cpp: (WebCore::Frame::nodeImage):
• page/gtk/FrameGtk.cpp: (WebCore::Frame::nodeImage):
• page/haiku/FrameHaiku.cpp: (WebCore::Frame::nodeImage):
• page/mac/FrameMac.mm: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
• page/qt/FrameQt.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
• page/win/FrameCGWin.cpp: (WebCore::Frame::nodeImage):
• page/win/FrameCairoWin.cpp: (WebCore::Frame::nodeImage):
• page/wince/FrameWince.cpp: (WebCore::Frame::nodeImage):
• page/wx/FrameWx.cpp: (WebCore::Frame::nodeImage):
• platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::createDragImage):
• rendering/RenderObject.cpp: (WebCore::RenderObject::selectionForegroundColor):

2010-08-24 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Eric Seidel.

[chromium] Generate drag images for HTML elements and selections.
​https://bugs.webkit.org/show_bug.cgi?id=43449

Fix up calls to Frame::nodeImage, which has a new signature.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):

8:53 AM Changeset in webkit [65903] by Csaba Osztrogonác

• 1 edit
  1 delete in trunk/LayoutTests

Unreviewed trivial fix.

After r65845 we don't need Qt specific expected result.

• platform/qt/editing/execCommand/insert-list-xml-expected.txt: Removed.

8:44 AM Changeset in webkit [65902] by jorlow@chromium.org

• 8 edits
  2 adds in trunk

2010-08-24 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB needs to manually delete all objectStore data and indexes
​https://bugs.webkit.org/show_bug.cgi?id=44522

• storage/indexeddb/objectstore-removeobjectstore-expected.txt: Added.
• storage/indexeddb/objectstore-removeobjectstore.html: Added.
• storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback):

2010-08-24 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB needs to manually delete all objectStore data and indexes
​https://bugs.webkit.org/show_bug.cgi?id=44522

Apparently it's only newer versions of SQLite that handle cascade
delete. The rest silently fail. So do it manually.

Test: storage/indexeddb/objectstore-removeobjectstore.html

• storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::doDelete): (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
• storage/IDBDatabaseBackendImpl.h:
• storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
• storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::removeIndex):
• storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create): (WebCore::IDBObjectStoreBackendImpl::id):

8:03 AM Changeset in webkit [65901] by weinig@apple.com

• 2 edits in trunk/LayoutTests

Update skipped list for WebKit2.

• platform/mac-wk2/Skipped:

7:59 AM Changeset in webkit [65900] by weinig@apple.com

• 4 edits
  4 adds in trunk

Fix for <rdar://problem/8153271> and <rdar://problem/8153288>
Change behavior of javascript: urls in <embed> and <object> back to
how they behaved before r50698.

Reviewed by Adam Barth.

WebCore:

Tests: fast/loader/javascript-url-in-embed.html

fast/loader/javascript-url-in-object.html

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::loadOrRedirectSubframe):

• loader/SubframeLoader.h:

LayoutTests:

• fast/loader/javascript-url-in-embed-expected.txt: Added.
• fast/loader/javascript-url-in-embed.html: Added.
• fast/loader/javascript-url-in-object-expected.txt: Added.
• fast/loader/javascript-url-in-object.html: Added.

7:58 AM Changeset in webkit [65899] by kov@webkit.org

• 2 edits in trunk/WebKit/gtk

2010-08-24 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Do not initialize the GSettings object in webkit_init - the other
call sites are always called in the main thread so this is
unnecessary.

• webkit/webkitprivate.cpp: (webkit_init):

7:14 AM Changeset in webkit [65898] by tkent@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

• platform/chromium/drt_expectations.txt: Remove a duplicated entry.

7:13 AM Changeset in webkit [65897] by xan@webkit.org

• 3 edits in trunk/WebCore

2010-08-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update code to compile with latest GTK+ 3.x.

• platform/gtk/gtk2drawing.c: (TSOffsetStyleGCs): (moz_gtk_entry_paint):
• plugins/gtk/gtk2xtbin.c: (gtk_xtbin_new):

7:04 AM Changeset in webkit [65896] by Nikolas Zimmermann

• 2 edits in trunk/LayoutTests

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Landed wrong results in my last commit.

• platform/mac/svg/css/shadow-changes-expected.txt:

7:00 AM Changeset in webkit [65895] by Nikolas Zimmermann

• 3 edits
  4 adds in trunk

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

-webkit-svg-shadow doesn't repaint on changes
​https://bugs.webkit.org/show_bug.cgi?id=44521

Trivial fix, to make -webkit-svg-shadow react on changes.

Test: svg/css/shadow-changes.svg

• rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): If 'svgShadow' is not equal, cause a repaint.

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

-webkit-svg-shadow doesn't repaint on changes
​https://bugs.webkit.org/show_bug.cgi?id=44521

• platform/mac/svg/css/shadow-changes-expected.checksum: Added.
• platform/mac/svg/css/shadow-changes-expected.png: Added.
• platform/mac/svg/css/shadow-changes-expected.txt: Added.
• svg/css/shadow-changes.svg: Added.

6:40 AM Changeset in webkit [65894] by krit@webkit.org

• 2 edits in trunk/WebCore

2010-08-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cg logs "<Error>: CGPathCloseSubpath: no current point. " in lots of tests
​https://bugs.webkit.org/show_bug.cgi?id=43026

Check if the path is empty before closing it.

• svg/SVGPathBuilder.cpp: (WebCore::SVGPathBuilder::moveTo):

6:25 AM Changeset in webkit [65893] by bulach@chromium.org

• 9 edits
  3 adds in trunk

2010-08-24 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Hooks IDBKeyPath with IDBObjectStorage::put.
​https://bugs.webkit.org/show_bug.cgi?id=44275

Adds a mechanism to extract an IDBKey from SerializedScriptValue using IDBKeyPath
during IDBObjectStorage::put.

• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• platform/chromium/ChromiumBridge.h:
• storage/IDBKeyPathBackendImpl.cpp: Added. (IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
• storage/IDBKeyPathBackendImpl.h: Added.
• storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put):
• storage/chromium/IDBKeyPathBackendImpl.cpp: Added. (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2010-08-24 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Hooks IDBKeyPath with IDBObjectStorage::put.
​https://bugs.webkit.org/show_bug.cgi?id=44275

Adds a mechanism to extract an IDBKey from SerializedScriptValue using IDBKeyPath
during IDBObjectStorage::put.

• public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
• public/WebKitClient.h: (WebKit::WebKitClient::createIDBKeysFromSerializedValuesAndKeyPath):
• src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath):

6:04 AM Changeset in webkit [65892] by abecsi@webkit.org

• 2 edits in trunk/WebKit/qt

2010-08-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix predeclared variables for Symbian to be able to build QtWebKit for Symbian on Linux.

• Api/DerivedSources.pro:

5:26 AM Changeset in webkit [65891] by loislo@chromium.org

• 35 edits in trunk/WebCore

2010-08-24 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: RemoteInspectorFrontend can be renamed to InspectorFrontend.
The old version of InspectorFrontend was removed some time ago and now
it is possible to rename the new version of inspector frontend class to its
original name.
​https://bugs.webkit.org/show_bug.cgi?id=44499

• GNUmakefile.am:
• WebCore.gyp/WebCore.gyp:
• WebCore.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• inspector/CodeGeneratorInspector.pm:
• inspector/ConsoleMessage.cpp:
• inspector/ConsoleMessage.h:
• inspector/InjectedScriptHost.cpp:
• inspector/InjectedScriptHost.h:
• inspector/InspectorApplicationCacheAgent.cpp:
• inspector/InspectorApplicationCacheAgent.h:
• inspector/InspectorBackend.cpp:
• inspector/InspectorBackend.h:
• inspector/InspectorCSSStore.cpp:
• inspector/InspectorCSSStore.h:
• inspector/InspectorController.cpp:
• inspector/InspectorController.h:
• inspector/InspectorDOMAgent.cpp:
• inspector/InspectorDOMAgent.h:
• inspector/InspectorDOMStorageResource.cpp:
• inspector/InspectorDOMStorageResource.h:
• inspector/InspectorDatabaseResource.cpp:
• inspector/InspectorDatabaseResource.h:
• inspector/InspectorDebuggerAgent.cpp:
• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorProfilerAgent.cpp:
• inspector/InspectorProfilerAgent.h:
• inspector/InspectorResource.cpp:
• inspector/InspectorResource.h:
• inspector/InspectorStorageAgent.cpp:
• inspector/InspectorStorageAgent.h:
• inspector/InspectorTimelineAgent.cpp:
• inspector/InspectorTimelineAgent.h:

5:11 AM Changeset in webkit [65890] by Csaba Osztrogonác

• 1 edit
  1 delete in trunk/LayoutTests

Unreviewed trivial fix.

Remove wrong code from Qt that's dumping extra markup into the clipboard
​https://bugs.webkit.org/show_bug.cgi?id=44506

After r65888 we don't need Qt specific expected result.

• platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Removed.

4:22 AM Changeset in webkit [65889] by Nikolas Zimmermann

• 4 edits
  4 adds in trunk

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Markers don't render, when applied to a target using vector-effect="non-scaling-stroke"
​https://bugs.webkit.org/show_bug.cgi?id=44511

Make fillAndStrokePath a member function of RenderPath, to avoid having to pass the const Path& and this paramters.
Don't leave the GraphicsContext mutated after applying non-scaling-stroke transformation, otherwhise markers will be renderer
in the wrong coordinate space, and thus don't show up anymore.

Test: svg/custom/non-scaling-stroke-markers.svg

• rendering/RenderPath.cpp: (WebCore::RenderPath::fillAndStrokePath): (WebCore::RenderPath::paint):
• rendering/RenderPath.h:

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Markers don't render, when applied to a target using vector-effect="non-scaling-stroke"
​https://bugs.webkit.org/show_bug.cgi?id=44511

Add new test verifying that markers can be appplied to objects using vector-effect="non-scaling-stroke".

• platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum: Added.
• platform/mac/svg/custom/non-scaling-stroke-markers-expected.png: Added.
• platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
• svg/custom/non-scaling-stroke-markers.svg: Added.

4:16 AM Changeset in webkit [65888] by Csaba Osztrogonác

• 2 edits in trunk/WebCore

Remove wrong code from Qt that's dumping extra markup into the clipboard
​https://bugs.webkit.org/show_bug.cgi?id=44506

Patch by Adam Barth <​abarth@webkit.org> on 2010-08-24
Reviewed by Kenneth Rohde Christiansen.

I have no way of testing this patch, but hopefully it should fix a
bunch of newly failing tests. This code seems very confused.

• platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection):

4:00 AM Changeset in webkit [65887] by Csaba Osztrogonác

• 2 edits in trunk/WebCore

Web Inspector: fix gcc warnings introduced in 65731
​https://bugs.webkit.org/show_bug.cgi?id=44468

Patch by Pavel Podivilov <​podivilov@chromium.org> on 2010-08-24
Reviewed by Yury Semikhatsky.

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::pauseOnBreakpoint):

3:38 AM Changeset in webkit [65886] by Simon Hausmann

• 2 edits in trunk/JavaScriptCore

[Symbian] Fix commit/decommit of system memory using RChunk

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2010-08-24
Reviewed by Simon Hausmann.

Swap accidentially reversed start and m_base values for determining the
offset within the RChunk.

• wtf/PageReservation.h:

(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):

3:11 AM Changeset in webkit [65885] by andreas.kling@nokia.com

• 3 edits in trunk/LayoutTests

2010-08-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

r65878 broke fast/dom/document-attribute-js-null.html

• fast/dom/document-attribute-js-null-expected.txt:
• fast/dom/document-attribute-js-null.html:

3:05 AM Changeset in webkit [65884] by rolandsteiner@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: trim duplicated entry from Chromium test_expectations.txt

• platform/chromium/test_expectations.txt:

3:03 AM Changeset in webkit [65883] by abecsi@webkit.org

• 2 edits in trunk/WebKitTools

2010-08-24 Andras Becsi <​abecsi@webkit.org>

[Qt] WebKit2 build fix.

• Scripts/enumerate-included-framework-headers: Remove stray global option form sed.

2:58 AM Changeset in webkit [65882] by ariya@webkit.org

• 2 edits in trunk/WebCore

[Qt] Blur shadow for rectangle fill
​https://bugs.webkit.org/show_bug.cgi?id=44488

Patch by Ariya Hidayat <​ariya@sencha.com> on 2010-08-24
Reviewed by Simon Hausmann.

Refactor fillRect() function to support blur radius in the shadow.

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

2:27 AM Changeset in webkit [65881] by tkent@chromium.org

• 6 edits in trunk

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[DRT/Chromium] Support for IndexedDB tests
​https://bugs.webkit.org/show_bug.cgi?id=44490

• platform/chromium/drt_expectations.txt:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[DRT/Chromium] Support for IndexedDB tests
​https://bugs.webkit.org/show_bug.cgi?id=44490

• DEPS: Roll Chromium to r57145 to have a webkit_support change.

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[DRT/Chromium] Support for IndexedDB tests
​https://bugs.webkit.org/show_bug.cgi?id=44490

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Enable IndexedDB.

2:25 AM Changeset in webkit [65880] by Nikolas Zimmermann

• 30 edits
  36 adds in trunk

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze

clip-path does not work inside mask element
​https://bugs.webkit.org/show_bug.cgi?id=41428

Add new tests covering nesting of clippers and maskers, with different unitTypes for the content coordinate system.
Scale all ImageBuffer content to take into account that ImageBuffers use integer based sizes, where the content
is floating-point sized. This compensates rounded errors, when scaling the document.

Tests: svg/clip-path/clip-in-mask-objectBoundingBox.svg

svg/clip-path/clip-in-mask-userSpaceOnUse.svg
svg/clip-path/clip-in-mask.svg
svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg
svg/clip-path/deep-nested-clip-in-mask-panning.svg
svg/clip-path/deep-nested-clip-in-mask.svg
svg/clip-path/nested-clip-in-mask-image-based-clipping.svg
svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg
svg/clip-path/nested-clip-in-mask-path-based-clipping.svg

• rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource): Return the value of applyClippingToContext, instead of always true. (WebCore::RenderSVGResourceClipper::applyClippingToContext): Moved some code from createClipData, to avoid having to pass 5 arguments to createClipData. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Renamed from createClipData.
• rendering/RenderSVGResourceClipper.h:
• rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Pass absoluteTargetRect to createImageBuffer. (WebCore::clipToTextMask): Ditto.
• rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource): Ditto. (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): Pass content transformation to renderSubtreeToImageBuffer, to support nesting objectBoundingBox resources.
• rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): Adapt to calculateTransformationToOutermostSVGCoordinateSystem changes. AffineTransform is now passed as reference. (WebCore::RenderSVGResourcePattern::createTileImage): ImageBuffer content scaling is now handled by createImageBuffer.
• rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem): Renamed. Don't return an AffineTransform copy, but instead pass it as reference. (WebCore::SVGImageBufferTools::createImageBuffer): Always scale the ImageBuffer content, to compensate rounding effects (code was only present in patterns so far).

Now also needs the 'absoluteTargetRect' parameter, not only 'clampedAbsoluteTargetRect'.

(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer): Moved from SVGRenderSupport.
(WebCore::SVGImageBufferTools::clipToImageBuffer): Pass ImageBuffer as OwnPtr reference, to allow to clear it under certain circumstances (see comment).
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer): Remove AffineTransform parameter, absoluteTargetRect is calculated before passing into this function.

• rendering/SVGImageBufferTools.h:
• rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent): Important change, respect the RenderSVGResourceClipper::applyResource() return value!
• rendering/SVGRenderSupport.h:
• svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build): renderSubtreeToImage now lives in SVGImageBufferTools, adapt code.

2010-08-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

clip-path does not work inside mask element
​https://bugs.webkit.org/show_bug.cgi?id=41428

Update results of all tests containing <mask> / <pattern> and/or gradient on text (using CG).
The ImageBuffer content is now scaled to account for rounding differences, when zooming.

• platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
• platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
• platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
• platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
• platform/mac/svg/clip-path/clip-in-mask-expected.checksum: Added.
• platform/mac/svg/clip-path/clip-in-mask-expected.png: Added.
• platform/mac/svg/clip-path/clip-in-mask-expected.txt: Added.
• platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
• platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
• platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
• platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
• platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
• platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.checksum: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
• platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
• platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
• platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
• platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
• platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
• platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
• platform/mac/svg/custom/text-rotated-gradient-expected.png:
• platform/mac/svg/text/selection-background-color-expected.checksum:
• platform/mac/svg/text/selection-background-color-expected.png:
• platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
• platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
• platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
• platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
• svg/clip-path/clip-in-mask-objectBoundingBox.svg: Added.
• svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Added.
• svg/clip-path/clip-in-mask.svg: Added.
• svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Added.
• svg/clip-path/deep-nested-clip-in-mask.svg: Added.
• svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Added.
• svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Added.
• svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Added.

2:05 AM Changeset in webkit [65879] by andreip@google.com

• 9 edits in trunk

2010-08-24 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

Implement IDBTransaction::objectStore

[IndexedDB] IDBTransaction is missing the implementation for objectStore method
​https://bugs.webkit.org/show_bug.cgi?id=44446

• storage/indexeddb/script-tests/transaction-basics.js: (test): (openSuccess): (createSuccess): (abortCallback):
• storage/indexeddb/transaction-basics-expected.txt:

2010-08-24 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IDBTransaction is missing the implementation for objectStore method
​https://bugs.webkit.org/show_bug.cgi?id=44446

• storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction):
• storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore):
• storage/IDBTransactionBackendImpl.h:
• storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::createTransaction):
• storage/IDBTransactionCoordinator.h:

1:55 AM Changeset in webkit [65878] by andreas.kling@nokia.com

• 16 edits in trunk

2010-08-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Disallow setting Document.xmlVersion to unsupported versions
​https://bugs.webkit.org/show_bug.cgi?id=44494

Added XMLDocumentParser::supportsXMLVersion() - only returns true for "1.0"
in both implementations.

• dom/Document.cpp: (WebCore::Document::setXMLVersion): Throw NOT_SUPPORTED_ERR if XMLDocumentParser::supportsXMLVersion() returns false for the version.
• dom/XMLDocumentParser.h:
• dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::supportsXMLVersion):
• dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::supportsXMLVersion):

2010-08-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Disallow setting Document.xmlVersion to unsupported versions
​https://bugs.webkit.org/show_bug.cgi?id=44494

Rebaselined tests (to expect success in 9/10 cases)
documentsetxmlversion03.xhtml fails now (but legitimately.)

• dom/xhtml/level3/core/canonicalform06-expected.txt:
• dom/xhtml/level3/core/documentsetxmlversion01-expected.txt:
• dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
• dom/xhtml/level3/core/documentsetxmlversion05-expected.txt:
• dom/xhtml/level3/core/infoset06-expected.txt:
• dom/xhtml/level3/core/infoset07-expected.txt:
• dom/xhtml/level3/core/wellformed01-expected.txt:
• dom/xhtml/level3/core/wellformed02-expected.txt:
• dom/xhtml/level3/core/wellformed03-expected.txt:
• dom/xhtml/level3/core/wellformed04-expected.txt:

1:51 AM Changeset in webkit [65877] by Simon Hausmann

• 2 edits in trunk/WebCore

[Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=31273

Patch by Laszlo Gombos <Laszlo Gombos> on 2010-08-24
Reviewed by Simon Hausmann.

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that
WebKit headers are included before platform headers. On all other
platforms continue to use INCLUDEPATH (as before).

This patch also removed the workarounds that are put in place
now that we have a better solution.

No new tests as there is no new functionality.

• WebCore.pro:

1:38 AM Changeset in webkit [65876] by ariya@webkit.org

• 3 edits in trunk/WebCore

[Qt] Support text-shadow blur
​https://bugs.webkit.org/show_bug.cgi?id=19728

Patch by Ariya Hidayat <​ariya@sencha.com> on 2010-08-24
Reviewed by Kenneth Rohde Christiansen.

Implement blur for text shadow using the shadow layer in r65782.

• platform/graphics/qt/ContextShadow.cpp:

(WebCore::ContextShadow::beginShadowLayer):

• platform/graphics/qt/FontQt.cpp:

(WebCore::drawTextCommon):

1:16 AM Changeset in webkit [65875] by abarth@webkit.org

• 4 edits in trunk/LayoutTests

2010-08-24 Adam Barth <​abarth@webkit.org>

Update baselines for Tiger bot. I'm not sure why these didn't turn up
when running the tests locally. The limits are slightly different in
the new parser, so we'll need to adjust these tests.

• fast/parser/block-nesting-cap-expected.txt:
• fast/parser/block-nesting-cap-table-expected.txt:
• fast/parser/element-nesting-cap-expected.txt:

1:15 AM Changeset in webkit [65874] by andreas.kling@nokia.com

• 7 edits
  3 adds in trunk

2010-08-23 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
​https://bugs.webkit.org/show_bug.cgi?id=44432

Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html

• dom/Element.cpp: (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null and the qualifiedName has a prefix.

2010-08-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø and Nikolas Zimmermann.

setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
​https://bugs.webkit.org/show_bug.cgi?id=44432

• Added a test for the new behavior.
• Rebaselined svg/custom/missing-xlink.svg

• fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
• fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
• fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.
• platform/chromium-mac/svg/custom/missing-xlink-expected.txt:
• platform/chromium-win/svg/custom/missing-xlink-expected.txt:
• platform/mac-leopard/svg/custom/missing-xlink-expected.txt:
• platform/mac/svg/custom/missing-xlink-expected.txt:
• platform/win/svg/custom/missing-xlink-expected.txt:

12:58 AM Changeset in webkit [65873] by abarth@webkit.org

• 3 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Build fix. leakPtr doesn't exist, contrary to my dreams.

• storage/IDBKeyTree.h: (WebCore::::put):
• storage/IDBPendingTransactionMonitor.cpp: (WebCore::IDBPendingTransactionMonitor::addPendingTransaction):

12:46 AM Changeset in webkit [65872] by rolandsteiner@chromium.org

• 2 edits in trunk/LayoutTests

2010-08-24 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: upstreaming chromium test suppressions.

Moving entries to LayoutTests/platform/chromium/test_expectations.txt

• platform/chromium/test_expectations.txt:

12:34 AM Changeset in webkit [65871] by abarth@webkit.org

• 13 edits in trunk/WebCore

2010-08-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Deploy adoptPtr in WebCore/storage
​https://bugs.webkit.org/show_bug.cgi?id=44491

There are still some naked news for a future patch. The next step is
to make create methods.

• storage/Database.cpp: (WebCore::DatabaseCreationCallbackTask::create): (WebCore::DerefContextTask::create): (WebCore::DeliverPendingCallbackTask::create):
• storage/DatabaseSync.cpp: (WebCore::CloseSyncDatabaseOnContextThreadTask::create):
• storage/DatabaseTask.h: (WebCore::Database::DatabaseOpenTask::create): (WebCore::Database::DatabaseCloseTask::create): (WebCore::Database::DatabaseTransactionTask::create): (WebCore::Database::DatabaseTableNamesTask::create):
• storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
• storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::addOpenDatabase):
• storage/IDBKeyTree.h: (WebCore::::put):
• storage/IDBPendingTransactionMonitor.cpp: (WebCore::IDBPendingTransactionMonitor::addPendingTransaction):
• storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createDeleteEmptyDatabase): (WebCore::LocalStorageTask::createTerminate):
• storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create):
• storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight):
• storage/SQLTransactionSync.cpp: (WebCore::SQLTransactionSync::SQLTransactionSync): (WebCore::SQLTransactionSync::begin):
• storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::copy):

12:32 AM Changeset in webkit [65870] by loislo@chromium.org

• 5 edits in trunk/WebCore

2010-08-24 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: setAttachedWindow was modified at r65809 but it should be implemented another way.
​https://bugs.webkit.org/show_bug.cgi?id=44493

• inspector/Inspector.idl:
• inspector/InspectorController.cpp:
• inspector/InspectorController.h:
• inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::setAttachedWindow):

12:19 AM Changeset in webkit [65869] by rolandsteiner@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-08-24 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed build fix.

put the "DISABLED_" in front of the right identifier.

• tests/WebFrameTest.cpp: (WebKit::TEST_F):

12:12 AM Changeset in webkit [65868] by abarth@webkit.org

• 18 edits in trunk

2010-08-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use new HTML5 TreeBuilder for fragment parsing
​https://bugs.webkit.org/show_bug.cgi?id=44475

The HTML5 TreeBuilder is ready to be used for all parsing
including fragments! This is the last change to move trunk
off of the LegacyHTMLTreeBuilder. We'll go through and
delete the thousands of lines of code supporting the old
parser in a separate patch.

This is covered by many layout tests.

• html/HTMLTreeBuilder.cpp:

2010-08-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use new HTML5 TreeBuilder for fragment parsing
​https://bugs.webkit.org/show_bug.cgi?id=44475

The HTML5 TreeBuilder is ready to be used for all parsing
including fragments! This is the last change to move trunk
off of the LegacyHTMLTreeBuilder. We'll go through and
delete the thousands of lines of code supporting the old
parser in a separate patch.

As far as we can tell, all of these are test progressions, see below.

• editing/pasteboard/paste-noscript-svg-expected.txt: progression.
• fast/forms/state-restore-to-non-edited-controls-expected.txt: matches minefield.
• fast/innerHTML/innerHTML-changing-document-properties-expected.txt: new HTML5 exception code, progression.
• fast/parser/fragment-parser-expected.txt: matches minefield.
• fast/parser/p-in-scope-expected.txt: matches minefield.
• fast/parser/p-in-scope-strict-expected.txt: matches minefield.
• fast/parser/residual-style-close-across-n-blocks-expected.txt: matches minefield.
• fast/table/incomplete-table-in-fragment-2-expected.txt: matches minefield.
• fast/table/incomplete-table-in-fragment-hang-expected.txt: matches minefield.
• html5lib/runner-expected.txt: progression!
• http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: Adam will fix this separately.

12:06 AM Changeset in webkit [65867] by rolandsteiner@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-08-23 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Tamura Kent.

Disable failing test
​https://bugs.webkit.org/show_bug.cgi?id=44492

• tests/WebFrameTest.cpp: (WebKit::TEST_F):