Timeline
Aug 28, 2010:
- 11:45 PM Changeset in webkit [66329] by
-
- 3 edits2 moves1 add in trunk/WebCore
2010-08-28 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa
Just moving files around so no new tests.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/cocoa: Added.
- platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
- platform/graphics/mac/FontPlatformData.h: Removed.
- platform/graphics/mac/FontPlatformDataMac.mm: Removed.
- 10:52 PM Changeset in webkit [66328] by
-
- 1 edit in trunk/LayoutTests/dom/xhtml/level2/html/button03.js
Checked in a file missed when I landed just now.
- 10:48 PM Changeset in webkit [66327] by
-
- 46 edits1 copy5 adds in trunk
Some IDL attributes don't reflect URL content attributes properly
https://bugs.webkit.org/show_bug.cgi?id=43650
Reviewed by Sam Weinig.
WebCore:
- dom/Document.cpp:
(WebCore::Document::processBaseElement): Added. Implements the rules for base elements
from the HTML5 specification. Handles multiple base elements in the same document.
- dom/Document.h: Removed setBaseElementURL and setBaseElementTarget, replacing them
with processBaseElement.
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::parseMappedAttribute): Call the new processBaseElement
function.
(WebCore::HTMLBaseElement::insertedIntoDocument): Ditto.
(WebCore::HTMLBaseElement::removedFromDocument): Ditto.
(WebCore::HTMLBaseElement::isURLAttribute): Added.
(WebCore::HTMLBaseElement::target): Moved here from the .h file and changed to not
realy on an m_target local variable.
- html/HTMLBaseElement.h: Added an override of the isURLAttribute function. Removed
unneeded process function. Removed declaration of nonexistent setHref and setTarget
functions. Removed unneeded m_hrefAttrValue, m_href, and m_target. Moved
implementation of target function into the .cpp file.
- html/HTMLBaseElement.idl: Marked the href attribute as URL.
- html/HTMLBlockquoteElement.cpp:
(WebCore::HTMLBlockquoteElement::isURLAttribute): Added.
- html/HTMLBlockquoteElement.h: Added isURLAttribute.
- html/HTMLBlockquoteElement.idl: Marked the cite attribute as URL.
- html/HTMLEmbedElement.idl: Marked the src attribute as URL.
- html/HTMLFormElement.cpp: Added a comment about the action function, which should
be removed.
- html/HTMLFormElement.idl: Marked the action attribute as URL.
- html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::isURLAttribute): Added.
(WebCore::HTMLHtmlElement::insertedIntoDocument): Tweaked a bit.
- html/HTMLHtmlElement.h: Added isURLAttribute.
- html/HTMLHtmlElement.idl: Marked the manifest attribute as URL.
- html/HTMLIFrameElement.idl: Marked the src attribute a URL.
- html/HTMLModElement.cpp:
(WebCore::HTMLModElement::isURLAttribute): Added.
- html/HTMLModElement.h: Added isURLAttribute.
- html/HTMLModElement.idl: Marked the cite attribute as URL.
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::isURLAttribute): Added.
- html/HTMLQuoteElement.h: Added isURLAttribute.
- html/HTMLQuoteElement.idl: Marked the cite attribute as URL.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::processTagToken): Changed code to create a base
element instead of calling setBaseElementURL directly.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use AtomicString instead of String.
(WebCore::HTMLViewSourceDocument::addLine): Ditto.
(WebCore::HTMLViewSourceDocument::addText): Ditto.
(WebCore::HTMLViewSourceDocument::addBase): Added. Creates a base element and inserts it.
(WebCore::HTMLViewSourceDocument::addLink): Use AtomicString instead of String.
- html/HTMLViewSourceDocument.h: Updated function declarations as above.
- bindings/scripts/test/CPP/WebDOMTestCallback.h:
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
Updated results, which changed due to the fixes for at
least these bugs, and perhaps a few more:
https://bugs.webkit.org/show_bug.cgi?id=42115
https://bugs.webkit.org/show_bug.cgi?id=44597
https://bugs.webkit.org/show_bug.cgi?id=44738
- bindings/scripts/test/TestObj.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFormElement.cpp:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSourceElement.idl:
- html/HTMLVideoElement.idl:
Tweaked formatting.
LayoutTests:
- dom/html/level2/html/button03.js: Added a "WebKit modification" section so this
correctly expects the action attribute to return a completed URL.
- dom/xhtml/level2/html/button03.js: Ditto.
- fast/dom/URL-attribute-reflection-expected.txt: Updaed expected results to expecte
more successes.
- fast/dom/script-tests/URL-attribute-reflection.js:
(testURLReflection): Fixed wrong variable name in the test script.
- http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Removed a call
to encodeURI that was needed to work around our incorrect implementation of
HTMLIFrameElement's src attribute.
- fast/dom/HTMLBaseElement: Added.
- fast/dom/HTMLBaseElement/multiple-base-elements-expected.txt: Added.
- fast/dom/HTMLBaseElement/multiple-base-elements.html: Added.
- fast/dom/HTMLBaseElement/script-tests: Added.
- fast/dom/HTMLBaseElement/script-tests/TEMPLATE.html:
Copied from fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html.
- fast/dom/HTMLBaseElement/script-tests/multiple-base-elements.js: Added.
- 10:11 PM Changeset in webkit [66326] by
-
- 2 edits in trunk/WebCore
2010-08-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
The logic to escape entities in appendEscapedContent and appendAttributeValue should be merged
https://bugs.webkit.org/show_bug.cgi?id=44831
Added appendCharactersReplacingEntities to escape &, <, >, ", and nbsp based on the mask.
Removed escapeContentText because it was only used in appendText, which now directly calls
appendCharactersReplacingEntities. Replaced appendEscapedContent, ucharRange, and appendUCharRange
by appendNodeValue.
No new tests are added since this is a cleanup.
- editing/markup.cpp: (WebCore::): (WebCore::appendCharactersReplacingEntities): Added. (WebCore::MarkupAccumulator::appendAttributeValue): Calls appendCharactersReplacingEntities. (WebCore::MarkupAccumulator::appendNodeValue): Added. (WebCore::MarkupAccumulator::appendText): Calls appendNodeValue and appendCharactersReplacingEntities. (WebCore::urlToMarkup): Calls escapeEntities.
- 9:50 PM Changeset in webkit [66325] by
-
- 2 edits in trunk/LayoutTests
Update WebKit2 skipped list.
- platform/mac-wk2/Skipped:
- 9:38 PM Changeset in webkit [66324] by
-
- 5 edits3 adds in trunk
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560
The bug was caused by WebKit not pushing down implicitly added styles to descendent nodes.
Fixed the bug by pushing down all elements that implicitly add style.
extractInlineStyleToPushDown now calls removeImplicitlyStyledElement, which was modified to extract
the style implicitly added by the element to extractStyle.
This revealed a bug in applyInlineStyleToPushDown where applyInlineStyleIfNeeded could add
an implicitly styled element inside an element with a conflicting style, thereby overriding the style of the element.
Fixed this by extending the logic to honor the existing inline style declaration used in
the case of rewriting inline style declaration to all cases including the one calling addInlineStyleIfNeeded.
Also fixed a bug in removeInlineStyle where pushDownInlineStyleAroundNode was called on a text node
outside of selection if start was at the end of the text node.
Test: editing/style/push-down-implicit-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added extractedStyle, which receives the style implicitly added by the element being removed. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Calls removeImplicitlyStyledElement to remove the implicitly styled element and extract the inline style added by the element. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Fixed a bug that addInlineStyleIfNeeded could override the inline style declaration style of the node. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Uses extractInlineStyleToPushDown (WebCore::ApplyStyleCommand::removeInlineStyle): See above.
- editing/ApplyStyleCommand.h: Prototype changes.
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560
Added a test to ensure WebKit removes text-decorations added by u or s
and pushes down implicit styles properly into descendent nodes.
- editing/style/push-down-implicit-styles-expected.txt: Added.
- editing/style/push-down-implicit-styles.html: Added.
- editing/style/script-tests/push-down-implicit-styles.js: Added. (testSingleToggle): (selectAll): (selectTest): (selectSecondWord): (selectLastTwoWords):
- editing/style/typing-style-003-expected.txt: Negation of inline styles are now done by pushing down implicitly styled elements rather than canceling them by inline style declarations.
- 8:45 PM Changeset in webkit [66323] by
-
- 4 edits in trunk/WebKit/mac
Make an internal method used by Apple Mail into SPI
https://bugs.webkit.org/show_bug.cgi?id=44832
rdar://problem/5748951
Reviewed by Sam Weinig.
- WebView/WebFrame.mm:
(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
from the internal section to the private section.
- WebView/WebFrameInternal.h: Moved the method declaration out of here.
- WebView/WebFramePrivate.h: Moved the method declaration in here.
- 8:31 PM Changeset in webkit [66322] by
-
- 3 edits in trunk/WebKit/chromium
[chromium] Add webkit_support.gyp:blob to WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=44829
Reviewed by Darin Fisher.
Also bump up chromium revision in DEPS in order to pick up
the revision that contains blob change.
- DEPS:
- WebKit.gyp:
- 8:15 PM Changeset in webkit [66321] by
-
- 5 edits in tags/Safari-534.6.2
Versioning.
- 8:15 PM Changeset in webkit [66320] by
-
- 8 edits1 move1 add1 delete in tags/Safari-534.6.2
Merge r66319.
- 7:34 PM Changeset in webkit [66319] by
-
- 9 edits1 move1 add1 delete in trunk
<http://webkit.org/b/44802> REGRESSION (r65351): WebCore build fails due to attempting to directly access WebKitTools/Scripts
Reviewed by Adam Barth.
Move create-html-entity-table in to WebCore so that the build is again self-contained.
The script is also updated to take input as a CSV file rather than JSON as the former
can be parsed without requiring a third-party Python module be installed.
.:
- cmake/WebKitMacros.cmake:
WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.pri:
- WebCore.xcodeproj/project.pbxproj: Stop copying the input file in to the WebCore framework wrapper.
- html/parser/HTMLEntityNames.in: Added.
- html/parser/HTMLEntityNames.json: Removed.
- html/parser/create-html-entity-table: Renamed from WebKitTools/Scripts/create-html-entity-table.
- 6:57 PM Changeset in webkit [66318] by
-
- 17 edits in trunk
Bug 44830 - In Array's prototype functyions we're incorrectly handing large index values
Reviewed by Oliver Hunt.
We are in places casting doubles to unsigneds, and unsigneds to ints, without always check
that the result is within bounds. This is problematic in the case of double-to-unsigned
conversion because we should be saturating to array length.
Also, the error return value from Array.splice should be [], not undefined.
I don't see any security concerns here. These methods are spec'ed in such a way that they
can be applied to non Array objects, so in all cases the (potentially bogus) indices are
being passed to functions that will safely check accesses are within bounds.
- runtime/ArrayPrototype.cpp:
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/JSValue.h:
(JSC::JSValue::toUInt32):
LayoutTests:
- fast/js/array-splice-expected.txt:
- fast/js/script-tests/array-splice.js:
- fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.10_Array_prototype_slice/S15.4.4.10_A3_T3-expected.txt:
- fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.2_T3-expected.txt:
- fast/js/sputnik/Implementation_Diagnostics/S15.4.4.12_D1.5_T1-expected.txt:
- ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
- ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
- ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
- platform/mac-snowleopard/Skipped:
- 5:30 PM Changeset in webkit [66317] by
-
- 2 edits in trunk/WebCore
2010-08-28 Daniel Bates <dbates@rim.com>
Attempt to fix Chromium Mac Release bot after changeset 66305 <http://trac.webkit.org/changeset/66305>.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): Added case statements for missing enum values. These case statements simply fall through to a "break" statement.
- 4:06 PM Changeset in webkit [66316] by
-
- 2 edits in trunk/WebCore
Reviewed by Nikolas Zimmermann.
Add explicit destructor for C++ DOM bindings to avoid memory leaks when using SWIG.
https://bugs.webkit.org/attachment.cgi?bugid=44738
- 4:01 PM Changeset in webkit [66315] by
-
- 2 edits in trunk
Reviewed by Kevin Ollivier.
[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645
- 3:11 PM Changeset in webkit [66314] by
-
- 7 edits in trunk
[wx] Build fix after parseMode -> compatibilityMode rename.
- 1:10 PM Changeset in webkit [66313] by
-
- 2 edits in trunk/WebCore
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Add WebM MIME types to type registry
https://bugs.webkit.org/show_bug.cgi?id=44826
- platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add "video/webm" and "audio/webm" types.
- 12:34 PM Changeset in webkit [66312] by
-
- 4 edits in trunk/LayoutTests
2010-08-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
fast/frames/frame-crash-with-page-cache.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44813
Update test to not rely on intervals resuming when going back to a page
in the page cache. Based on the original bug for which this test was
added (34773), intervals were not part of the triggering condition.
- fast/frames/resources/cached-page-1.html:
- fast/frames/resources/cached-page-2.html:
- platform/chromium/test_expectations.txt:
- 11:48 AM Changeset in webkit [66311] by
-
- 5 edits in trunk
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::asyncEventTimerFired): If m_isWaitingToDecrementLoadEventDelayCount is true, call setShouldDelayLoadEvent(false) and set the timer to fire the pending events on the next idle. (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): Don't clear the delay from within a media engine callback because document 'load' event handlers that cause the page to become inactive will delete the media engine.
- html/HTMLMediaElement.h: Add m_isWaitingToDecrementLoadEventDelayCount.
2010-08-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743
- platform/mac/Skipped: Remove tabindex-focus-blur-all.html from the skip list.
- 10:38 AM Changeset in webkit [66310] by
-
- 5 edits in trunk/WebCore
2010-08-28 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794
Some preliminary cleanup; for vectors, prefer indexed access rather than using iterators.
No behavior changes.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): (WebCore::KeyframeAnimation::validateTransformFunctionList):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
- rendering/style/KeyframeList.h: (WebCore::KeyframeList::at): (WebCore::KeyframeList::keyframes):
- 10:02 AM Changeset in webkit [66309] by
-
- 2 edits in trunk/WebCore
Speculative fix for <rdar://problem/7275077> Crash in InlineBox::root() under RenderTextControl::textWithHardLineBreaks()
https://bugs.webkit.org/show_bug.cgi?id=44816
Reviewed by Simon Fraser.
No test because I could not reproduce the crash.
In a common variant of the crash, InlineBox::root() is called with this == 12. This suggests that
a RenderInline* was cast into a RenderBox*, so RenderBox::inlineBoxWrapper() interpreted the
m_lineHeight and m_verticalPosition members of a RenderInline as a pointer to an InlineBox.
The cast into RenderBox* in textWithHardLineBreaks() was introduced in r40881 with no exaplanation.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textWithHardLineBreaks): Fetch the first line directly from the inner
text block instead of relying on the first child being a text node.
- 9:56 AM Changeset in webkit [66308] by
-
- 2 edits in trunk/WebCore
2010-08-28 Moritz Lipp <mlq@pwmt.org>
Reviewed by Xan Lopez.
[GTK] Improper webkit_dom_document_evaluate implementation.
https://bugs.webkit.org/show_bug.cgi?id=42115
The generated webkit_dom_document_evaluate() function does not meet the
evaluate interface described in the W3 Documentation
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathEvaluator-evaluate
"If this is specified as nullor the implementation does not reuse the
specified result,...". The current implementation did not accept the
result parameter to be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
- 9:14 AM Changeset in webkit [66307] by
-
- 2 edits in trunk/WebKit/qt
2010-08-28 Daniel Bates <dbates@rim.com>
Attempt to fix the Qt Windows and Qt Linux Release minimal builds
after changeset 66297 <http://trac.webkit.org/changeset/66297>.
- Api/qwebplugindatabase.cpp: (QWebPluginDatabase::plugins): Wrap the call to PluginPackage::ensurePluginLoaded in #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE).
- 2:43 AM Changeset in webkit [66306] by
-
- 22 edits in trunk
2010-08-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781
This patch teaches the HTMLTreeBuilder about demoted form elements.
Demoting a form element magically stops the form element from
rendering. Demoted form elements are a concept from the
LegacyHTMLTreeBuilder, but they are somewhat of a hack because
rendering should be DOM-based. We'll likely look for a better solution
in a future patch.
- html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLFormElement):
- html/parser/HTMLConstructionSite.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
2010-08-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781
Update test expectations to account for demoted form elements. I spot
checked a bunch of these and this change is the reverse of the change
to these expectations in http://trac.webkit.org/changeset/64712. At
the time, we thought these rendering changes were correct because the
DOM was correct. However, demoted form elements have magical
non-DOM-based rendering.
- platform/mac/fast/forms/form-added-to-table-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
- platform/mac/fast/table/inline-form-assert-expected.txt:
- platform/mac/fast/table/insert-cell-before-form-expected.txt:
- platform/mac/fast/table/insert-row-before-form-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
- platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- 2:30 AM Changeset in webkit [66305] by
-
- 17 edits3 adds in trunk
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT
- platform/chromium/accessibility: Added.
- platform/chromium/accessibility/children-changed-notification-expected.txt: Added.
- platform/chromium/accessibility/children-changed-notification.html: Added.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::childrenChanged):
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
- public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectChildren):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren):
- src/ChromeClientImpl.h:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
- DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController): (AccessibilityController::reset): (AccessibilityController::getRootElement): (AccessibilityController::dumpAccessibilityNotifications):
- DumpRenderTree/chromium/AccessibilityController.h: (AccessibilityController::shouldDumpAccessibilityNotifications):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didChangeAccessibilityObjectChildren):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:09 AM Changeset in webkit [66304] by
-
- 4 edits in trunk/WebKitTools
2010-08-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update commit-queue failure message
https://bugs.webkit.org/show_bug.cgi?id=44798
The commit-queue auto-restarts itself and has for a very long time.
No need for people to email me to request a restart anymore.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 1:49 AM Changeset in webkit [66303] by
-
- 8 edits2 copies in trunk/WebCore
2010-08-28 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Implement the DOM FileWriter class
https://bugs.webkit.org/show_bug.cgi?id=44362
No new tests until the delegate class has an implementation; bug logged.
Build file additions.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
The AsyncFileWriter is an abstract interface to which FileWriter delegates all the hard work.
- html/AsyncFileWriter.h: Added.
The FileWriterClient is the interface for communications back from the AsyncFileWriter [success/failure, progress events].
- html/FileWriterClient.h: Added. (WebCore::FileWriterClient::~FileWriterClient):
Added all delegation, state tracking, and progress event processing.
- html/FileWriter.cpp: (WebCore::FileWriter::FileWriter): (WebCore::FileWriter::initialize): (WebCore::FileWriter::~FileWriter): ActiveDomObject stuff (WebCore::FileWriter::hasPendingActivity): (WebCore::FileWriter::stop): (WebCore::FileWriter::write): FileWriter public interface (WebCore::FileWriter::seek): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): FileWriterClient interface (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didTruncate): (WebCore::FileWriter::didFail): Progress events (WebCore::FileWriter::fireEvent):
- html/FileWriter.h:
- 1:31 AM Changeset in webkit [66302] by
-
- 2 edits in trunk/WebCore
2010-08-28 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Preparatory patch to split libwebcore in multiple libraries.
Start with a webcore_prerequisites pseudo-target what will be the common
target for all the other ones.
- WebCore.gyp/WebCore.gyp:
- 12:58 AM Changeset in webkit [66301] by
-
- 5 edits in trunk
2010-08-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777
- wtf/Platform.h:
2010-08-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777
- platform/PurgeableBuffer.h:
- platform/mac/PurgeableBufferMac.cpp:
- 12:26 AM Changeset in webkit [66300] by
-
- 2 edits in trunk/WebCore
2010-08-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix error message when theme loading fails
https://bugs.webkit.org/show_bug.cgi?id=44775
Parameters for logging were in the wrong order.
No new functionality so no new tests.
- platform/efl/ScrollbarEfl.cpp: (ScrollbarEfl::setParent): exchange argument order in log function call
Aug 27, 2010:
- 11:56 PM Changeset in webkit [66299] by
-
- 3 edits in trunk/WebCore
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: some tests no longer painting
https://bugs.webkit.org/show_bug.cgi?id=44773
Fix regression from the RenderImageResource introduction, fast/canvas/canvas-as-image.html
and fast/canvas/canvas-as-image-incremental-repaint.html pixel tests did not work anymore.
- rendering/RenderImageResource.h: (WebCore::RenderImageResource::hasImage): Make hasImage virtual.
- rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::hasImage): Always return true, just like RenderImageGeneratedContent did.
- 10:18 PM Changeset in webkit [66298] by
-
- 2 edits in trunk/WebKit/qt
2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44761
Make the test more robust to changes in the execution environment. The click
are now correctly simulated, and the position are determined from the content.
The test also create the view and page on the stack to avoid the leak when the
test is failing.
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
- 9:32 PM Changeset in webkit [66297] by
-
- 13 edits in trunk
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] NPAPI Plugin metadata should be cached, and loading a plugin should not require loading every plugin
https://bugs.webkit.org/show_bug.cgi?id=43179
Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE flag to enable persistent
NPAPI Plugin Cache. The flag is enabled by default.
- wtf/Platform.h: Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cache plugin info to a persistent database
Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)
Currently only enabled for Qt UNIX flavors.
- WebCore.pro: Enable NETSCAPE_PLUGIN_METADATA_CACHE for UNIX builds
- platform/qt/FileSystemQt.cpp: (WebCore::openFile): Added. (WebCore::readFromFile): Added.
- plugins/PluginDatabase.cpp: (WebCore::persistentPluginMetadataCachePath): Static accessor for the path (WebCore::PluginDatabase::PluginDatabase): Add instance variable. (WebCore::PluginDatabase::refresh): (WebCore::PluginDatabase::pluginForMIMEType): Ensure returned plugin is loaded. (WebCore::PluginDatabase::MIMETypeForExtension): Ensure returned plugin is loaded. (WebCore::PluginDatabase::clear): (WebCore::fillBufferWithContentsOfFile): Static helper function. (WebCore::readUTF8String): Static helper function. (WebCore::readTime): Static helper function. (WebCore::PluginDatabase::loadPersistentMetadataCache): (WebCore::writeUTF8String): Static helper function. (WebCore::writeTime): Static helper function. (WebCore::PluginDatabase::updatePersistentMetadataCache): Added. (WebCore::PluginDatabase::isPersistentMetadataCacheEnabled): Added. (WebCore::PluginDatabase::setPersistentMetadataCacheEnabled):Added. (WebCore::PluginDatabase::persistentMetadataCachePath): Added. (WebCore::PluginDatabase::setPersistentMetadataCachePath): Added.
- plugins/PluginDatabase.h:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::PluginPackage): Add instance variable. (WebCore::PluginPackage::createPackageFromCache): Added. (WebCore::PluginPackage::ensurePluginLoaded): Added.
- plugins/PluginPackage.h: (WebCore::PluginPackage::fullMIMEDescription): Added.
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo): Split mime parsing. (WebCore::PluginPackage::setMIMEDescription): Added. Mime parsing.
2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cache plugin info to a persistent database
Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)
Currently only enabled for Qt UNIX flavors.
- Api/qwebplugindatabase.cpp: (QWebPluginDatabase::plugins): Match previous behavior: ensure all returned plugins are loaded.
- Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage): Set plugin cache path.
- 8:06 PM Changeset in webkit [66296] by
-
- 7 edits2 adds in trunk
2010-08-27 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734
Implements all of the symbolic CSS3 list-style-types as per
section 4.5 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#symbolic>.
Test: fast/lists/w3-css3-list-styles-symbolic.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added list style types Asterisks and Footnotes.
- css/CSSValueKeywords.in: Ditto.
- inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
- rendering/RenderListMarker.cpp: (WebCore::toAlphabeticOrNumeric): Changed type of parameter sequenceSize from int to unsigned. (WebCore::toSymbolic): Added. (WebCore::toAlphabetic): Changed type of parameter alphabetSize from int to unsigned. (WebCore::toNumeric): Changed type of parameter numeralsSize from int to unsigned. (WebCore::effectiveListMarkerType): Added. (WebCore::listMarkerSuffix): Added list style types Asterisks and Footnotes. (WebCore::listMarkerText): Ditto. (WebCore::RenderListMarker::paint): Ditto. (WebCore::RenderListMarker::calcPrefWidths): Ditto. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
- rendering/style/RenderStyleConstants.h: Ditto. (WebCore::):
2010-08-27 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734
Tests that all of the symbolic CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-symbolic-expected.txt: Added.
- fast/lists/w3-css3-list-styles-symbolic.html: Added.
- 8:01 PM Changeset in webkit [66295] by
-
- 6 edits in trunk/WebCore
2010-08-27 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
CanvasRenderingContext2D::willDraw changed to didDraw
Solves issue with canvas to canvas draw calls, and simplifies
mixed software and GPU acceleration of GraphicsContext implementations
which must track dirty rects for backing stores.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect): (WebCore::CanvasRenderingContext2D::didDraw): (WebCore::CanvasRenderingContext2D::putImageData): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged):
- 7:41 PM Changeset in webkit [66294] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-08-27 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas test 2d.composite.operation.clear failing
https://bugs.webkit.org/show_bug.cgi?id=43226
- canvas/philip/tests/2d.composite.operation.foobar.html: Added. Tests if bogus composite ops are ignored.
- platform/mac/Skipped: Added comment about why original clear test should remain on the skip list.
- 7:25 PM Changeset in webkit [66293] by
-
- 5 edits in trunk
2010-08-27 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121
No new tests.
- platform/chromium/ChromiumBridge.h:
2010-08-27 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121
- public/WebClipboard.h: (WebKit::WebClipboard::writeData): (WebKit::WebClipboard::readFilenames):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::clipboardWriteData):
- 7:16 PM Changeset in webkit [66292] by
-
- 8 edits in trunk/WebKit2
Add UserContent API to WebKit2 InjectedBundle
<rdar://problem/8367587>
https://bugs.webkit.org/show_bug.cgi?id=44810
Reviewed by Dan Bernstein.
The new API differs from the version in WebKit1 in that the function do not take
a group name since we currently do not expose a way to make multiple PageGroups in
the API.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(toUserScriptInjectionTime):
(toUserContentInjectedFrames):
Add conversion functions for enums.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::toStringVector):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
- WebProcess/InjectedBundle/InjectedBundle.h:
Forward API to PageGroup.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::sharedPageGroup):
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
- WebProcess/WebProcess.h: Ad accessor for global PageGroup.
- 6:58 PM Changeset in webkit [66291] by
-
- 2 edits in trunk/WebCore
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Remove unnecessary AlphaBlend in PasteboardWin.
https://bugs.webkit.org/show_bug.cgi?id=44720
Replacing AlphaBlend with BitBlt is safe because testing showed that alpha
never survives copy-and-paste on Windows in any browser, and StretchBlt
was a overkill since the source and destination size are always equal.
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
- 6:46 PM Changeset in webkit [66290] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Not reviewed, adding two more files to chromium's test_expectations.
- platform/chromium/test_expectations.txt:
- 6:21 PM Changeset in webkit [66289] by
-
- 2 edits in trunk/LayoutTests
Add tests to the WebKit2 skipped list.
Rubber-stamped by Brady Eidson.
- platform/mac-wk2/Skipped:
- 6:05 PM Changeset in webkit [66288] by
-
- 5 edits in trunk
2010-08-26 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282
- platform/graphics/skia/GraphicsContext3DSkia.cpp: Dealing with the case of texImage2D with HTMLCanvasElement input. (WebCore::GraphicsContext3D::getImageData):
2010-08-26 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282
- fast/canvas/webgl/gl-teximage-expected.txt: Adding back the tests using canvas as texImage2D input.
- fast/canvas/webgl/gl-teximage.html: Ditto.
- 5:57 PM Changeset in webkit [66287] by
-
- 2 edits in trunk/WebCore
2010-08-26 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Working around compile issue in LayerRendererChromium.cpp
when DEBUG_GL_CALLS=1
https://bugs.webkit.org/show_bug.cgi?id=44739
No new functionality, no new tests.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer):
- 5:54 PM Changeset in webkit [66286] by
-
- 2 edits in trunk/WebCore
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Port SoftLinking to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44693
WinCE provides GetProcAddressW and GetProcAddressA for softlinking.
Unfortunately WinNT provides only GetProcAddress (without A or W).
Add a platform dependent macro for GetProcAddress.
- platform/win/SoftLinking.h:
- 5:44 PM Changeset in webkit [66285] by
-
- 2 edits in trunk/WebCore
2010-08-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] ScrollbarThemeGtk should account for the trough_under_steppers property
https://bugs.webkit.org/show_bug.cgi?id=44742
No new tests until this code is activated, at which point pixel tests will
test the scrollbar rendering.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paintTrackBackground): Only inflate the track background if the style specifies trough_under_steppers. (WebCore::ScrollbarThemeGtk::paint): If the theme specifies trough_under_steppers, a dirty stepper also triggers a repaint of the trough region.
- 5:23 PM Changeset in webkit [66284] by
-
- 4 edits4 adds in trunk
2010-08-27 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Alexey Proskuryakov.
LayoutTests:
2010-08-27 Joseph Pecoraro <Joseph Pecoraro>
Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731
- fast/events/input-focus-no-duplicate-events-expected.txt: Added.
- fast/events/input-focus-no-duplicate-events.html: Added.
- fast/events/input-tab-focus-no-duplicate-events-expected.txt: Added.
- fast/events/input-tab-focus-no-duplicate-events.html: Added.
WebCore:
2010-08-27 Joseph Pecoraro <Joseph Pecoraro>
Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731
Tests: fast/events/input-focus-no-duplicate-events.html
fast/events/input-tab-focus-no-duplicate-events.html
- dom/Element.cpp: (WebCore::Element::focus): do not continue and update the appearance of the element if it was not focused.
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): respect the return value of Document::setFocusedNode.
- 5:16 PM Changeset in webkit [66283] by
-
- 3 edits2 copies in trunk/LayoutTests
2010-08-27 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Copy video files back into http/tests/media/resources/ since some tests apparently
can't load from test/resources/. Sigh.
- http/tests/media/resources/test.mp4: Copied from LayoutTests/http/tests/resources/test.mp4.
- http/tests/media/resources/test.ogv: Copied from LayoutTests/http/tests/resources/test.ogv.
- http/tests/media/video-cookie.html:
- http/tests/media/video-referer.html:
- 5:08 PM Changeset in webkit [66282] by
-
- 7 edits in trunk
2010-08-26 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
LayoutTests:
2010-08-26 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: attribute nodes don't get rendered in the console
https://bugs.webkit.org/show_bug.cgi?id=44736
Add formatting tests for attribute nodes.
- inspector/console-format-expected.txt:
- inspector/console-format.html:
WebCore:
2010-08-26 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: attribute nodes don't get rendered in the console
https://bugs.webkit.org/show_bug.cgi?id=44736
Extended Test: inspector/console-format.html
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): add "name" and "value" properties for Attribute nodes.
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): add "name" and "value" properties for Attribute nodes.
- inspector/front-end/ElementsTreeOutline.js: display html for Attribute nodes.
- 5:05 PM Changeset in webkit [66281] by
-
- 1 edit18 adds in trunk/SunSpider
Added version 5 and version 6 of V8 tests with modifications similar
to the version 4 tests so they'll work with the SunSpider test harness.
Note that these files are external source and therefore don't conform
to WebKit coding standards.
https://bugs.webkit.org/show_bug.cgi?id=44638
Patch by Michael Saboff <msaboff@apple.com> on 2010-08-27
Reviewed by Stephanie Lewis.
- tests/v8-v5: Added.
- tests/v8-v5/LIST: Added.
- tests/v8-v5/v8-crypto.js: Added.
- tests/v8-v5/v8-deltablue.js: Added.
- tests/v8-v5/v8-earley-boyer.js: Added.
- tests/v8-v5/v8-raytrace.js: Added.
- tests/v8-v5/v8-regexp.js: Added.
- tests/v8-v5/v8-richards.js: Added.
- tests/v8-v5/v8-splay.js: Added.
- tests/v8-v6: Added.
- tests/v8-v6/LIST: Added.
- tests/v8-v6/v8-crypto.js: Added.
- tests/v8-v6/v8-deltablue.js: Added.
- tests/v8-v6/v8-earley-boyer.js: Added.
- tests/v8-v6/v8-raytrace.js: Added.
- tests/v8-v6/v8-regexp.js: Added.
- tests/v8-v6/v8-richards.js: Added.
- tests/v8-v6/v8-splay.js: Added.
- 4:59 PM Changeset in webkit [66280] by
-
- 5 edits3 adds in trunk/WebKit/chromium
2010-08-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
[chromium] Add chromium-side of AsyncFileSystem implementation
https://bugs.webkit.org/show_bug.cgi?id=44434
- WebKit.gyp:
- src/AssertMatchingEnums.cpp: Added assertions.
- src/AsyncFileSystemChromium.cpp: Added.
- src/AsyncFileSystemChromium.h: Added.
- src/LocalFileSystemChromium.cpp: Added.
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
- src/WebFileSystemCallbacksImpl.h:
- 4:56 PM Changeset in webkit [66279] by
-
- 2 edits in trunk/WebKit2
Move WKBundle didCreatePage callback to outside the WebPage
constructor to avoid adoptRef errors.
Reviewed by Gavin Barraclough.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
- 4:55 PM Changeset in webkit [66278] by
-
- 5 edits in trunk/LayoutTests
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; chromium rebaseline for r66247.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- 4:46 PM Changeset in webkit [66277] by
-
- 12 edits25 moves in trunk/WebCore
2010-08-27 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Finshing moving the HTML parser into WebCore/html/parser.
- Android.derived.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/CSSPreloadScanner.cpp: Removed.
- html/CSSPreloadScanner.h: Removed.
- html/HTMLConstructionSite.cpp: Removed.
- html/HTMLConstructionSite.h: Removed.
- html/HTMLDocumentParser.cpp: Removed.
- html/HTMLDocumentParser.h: Removed.
- html/HTMLEntityNames.json: Removed.
- html/HTMLEntityParser.cpp: Removed.
- html/HTMLEntityParser.h: Removed.
- html/HTMLEntitySearch.cpp: Removed.
- html/HTMLEntitySearch.h: Removed.
- html/HTMLEntityTable.h: Removed.
- html/HTMLFormattingElementList.cpp: Removed.
- html/HTMLFormattingElementList.h: Removed.
- html/HTMLParserScheduler.cpp: Removed.
- html/HTMLParserScheduler.h: Removed.
- html/HTMLPreloadScanner.cpp: Removed.
- html/HTMLPreloadScanner.h: Removed.
- html/HTMLScriptRunner.cpp: Removed.
- html/HTMLScriptRunner.h: Removed.
- html/HTMLScriptRunnerHost.h: Removed.
- html/HTMLTokenizer.cpp: Removed.
- html/HTMLTokenizer.h: Removed.
- html/HTMLViewSourceParser.cpp: Removed.
- html/HTMLViewSourceParser.h: Removed.
- html/parser/CSSPreloadScanner.cpp: Copied from WebCore/html/CSSPreloadScanner.cpp.
- html/parser/CSSPreloadScanner.h: Copied from WebCore/html/CSSPreloadScanner.h.
- html/parser/HTMLConstructionSite.cpp: Copied from WebCore/html/HTMLConstructionSite.cpp.
- html/parser/HTMLConstructionSite.h: Copied from WebCore/html/HTMLConstructionSite.h.
- html/parser/HTMLDocumentParser.cpp: Copied from WebCore/html/HTMLDocumentParser.cpp.
- html/parser/HTMLDocumentParser.h: Copied from WebCore/html/HTMLDocumentParser.h.
- html/parser/HTMLEntityNames.json: Copied from WebCore/html/HTMLEntityNames.json.
- html/parser/HTMLEntityParser.cpp: Copied from WebCore/html/HTMLEntityParser.cpp.
- html/parser/HTMLEntityParser.h: Copied from WebCore/html/HTMLEntityParser.h.
- html/parser/HTMLEntitySearch.cpp: Copied from WebCore/html/HTMLEntitySearch.cpp.
- html/parser/HTMLEntitySearch.h: Copied from WebCore/html/HTMLEntitySearch.h.
- html/parser/HTMLEntityTable.h: Copied from WebCore/html/HTMLEntityTable.h.
- html/parser/HTMLFormattingElementList.cpp: Copied from WebCore/html/HTMLFormattingElementList.cpp.
- html/parser/HTMLFormattingElementList.h: Copied from WebCore/html/HTMLFormattingElementList.h.
- html/parser/HTMLParserScheduler.cpp: Copied from WebCore/html/HTMLParserScheduler.cpp.
- html/parser/HTMLParserScheduler.h: Copied from WebCore/html/HTMLParserScheduler.h.
- html/parser/HTMLPreloadScanner.cpp: Copied from WebCore/html/HTMLPreloadScanner.cpp.
- html/parser/HTMLPreloadScanner.h: Copied from WebCore/html/HTMLPreloadScanner.h.
- html/parser/HTMLScriptRunner.cpp: Copied from WebCore/html/HTMLScriptRunner.cpp.
- html/parser/HTMLScriptRunner.h: Copied from WebCore/html/HTMLScriptRunner.h.
- html/parser/HTMLScriptRunnerHost.h: Copied from WebCore/html/HTMLScriptRunnerHost.h.
- html/parser/HTMLTokenizer.cpp: Copied from WebCore/html/HTMLTokenizer.cpp.
- html/parser/HTMLTokenizer.h: Copied from WebCore/html/HTMLTokenizer.h.
- html/parser/HTMLViewSourceParser.cpp: Copied from WebCore/html/HTMLViewSourceParser.cpp.
- html/parser/HTMLViewSourceParser.h: Copied from WebCore/html/HTMLViewSourceParser.h.
- 4:42 PM Changeset in webkit [66276] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test expectations.
Aaron said it's ok to add userscripts/mixed-case-stylesheet.html to
the expected failure list because we test these in chromium anyway.
- platform/chromium/test_expectations.txt:
- 4:36 PM Changeset in webkit [66275] by
-
- 2 adds in trunk/WebKitSite/blog-files/webgl/resources
Forgot to add new WebGL demo support files
- 4:33 PM Changeset in webkit [66274] by
-
- 5 edits in trunk/LayoutTests
2010-08-27 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; rebaseline for r66247.
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- 4:31 PM Changeset in webkit [66273] by
-
- 7 edits2 deletes in trunk/WebKitSite/blog-files/webgl
Updated WebGL blog files for latest WebKit implementation
- 4:17 PM Changeset in webkit [66272] by
-
- 1 copy in tags/Safari-534.6.2
New tag.
- 4:14 PM Changeset in webkit [66271] by
-
- 10 edits2 moves1 delete in trunk/LayoutTests
2010-08-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Allow ports to use different test movies.
https://bugs.webkit.org/show_bug.cgi?id=44799
Move test movies from http/tests/media/resources to http/tests/resources. Change
local-video-source-from-remote to load a movie supported by the platform and to
not log movie name.
- http/tests/media/resources/test.mp4: Removed.
- http/tests/media/resources/test.ogv: Removed.
- http/tests/media/video-cancel-load.html:
- http/tests/media/video-cookie.html:
- http/tests/media/video-error-abort.html:
- http/tests/media/video-load-twice.html:
- http/tests/media/video-play-suspend.html:
- http/tests/media/video-referer.html:
- http/tests/resources/silence.mpg: Removed.
- http/tests/resources/test.mp4: Copied from LayoutTests/http/tests/media/resources/test.mp4.
- http/tests/resources/test.ogv: Copied from LayoutTests/http/tests/media/resources/test.ogv.
- http/tests/security/local-video-source-from-remote-expected.txt:
- http/tests/security/local-video-source-from-remote.html:
- media/video-source-error.html:
- 3:50 PM Changeset in webkit [66270] by
-
- 3 edits in trunk/LayoutTests
2010-08-27 Eric Carlson <eric.carlson@apple.com>
Rubber-stamped Simon Fraser.
Set svn mime-type on two test movies.
- http/tests/media/resources/test.mp4: Added property svn:mime-type.
- http/tests/media/resources/test.ogv: Added property svn:mime-type.
- 3:50 PM Changeset in webkit [66269] by
-
- 2 edits in trunk/WebCore
2010-08-27 Simon Fraser <Simon Fraser>
Reviewed by Tony Chang.
Insertion point does not show when dragging text into an editable area
https://bugs.webkit.org/show_bug.cgi?id=44295
r65681 caused the caret to use the last-computed caret rect when
painting, rather than forcing a style update. Because of this,
we now need to eagerly update the caret rect when changing
the drag selection.
Not testable in DRT because the drag selection is always cleared
before EventSender returns, so the drag caret can never show in
the pixel results.
Tested by running editing/selection/drag-in-iframe.html manually.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
- 3:42 PM Changeset in webkit [66268] by
-
- 2 edits in trunk/WebCore
2010-08-27 Adam Barth <abarth@webkit.org>
Attempt to fix the Windows build.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 3:38 PM Changeset in webkit [66267] by
-
- 2 edits in trunk/LayoutTests
Build fix only, not reviewed.
In review for https://bugs.webkit.org/show_bug.cgi?id=43099, a few
necessary testing functions were removed.
- fullscreen/full-screen-test.js:
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
- 3:32 PM Changeset in webkit [66266] by
-
- 2 edits in trunk/WebCore
2010-08-27 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt build.
- WebCore.pro:
- 3:25 PM Changeset in webkit [66265] by
-
- 8 edits4 moves in trunk/WebCore
2010-08-27 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move HTMLTreeBuilder and HTMLElementStack to WebCore/html/parser.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElementStack.cpp: Removed.
- html/HTMLElementStack.h: Removed.
- html/HTMLTreeBuilder.cpp: Removed.
- html/HTMLTreeBuilder.h: Removed.
- html/parser/HTMLElementStack.cpp: Copied from WebCore/html/HTMLElementStack.cpp.
- html/parser/HTMLElementStack.h: Copied from WebCore/html/HTMLElementStack.h.
- html/parser/HTMLTreeBuilder.cpp: Copied from WebCore/html/HTMLTreeBuilder.cpp.
- html/parser/HTMLTreeBuilder.h: Copied from WebCore/html/HTMLTreeBuilder.h.
- 2:58 PM Changeset in webkit [66264] by
-
- 9 edits1 move1 add in trunk/WebCore
2010-08-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Create WebCore/html/parser
https://bugs.webkit.org/show_bug.cgi?id=44792
This patch begins the process of moving the HTML parser code to the
WebCore/html/parser directory. This patch moves a single header file.
More files will follow in future patches.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLToken.h: Renamed from WebCore/html/HTMLToken.h.
- 2:54 PM Changeset in webkit [66263] by
-
- 193 edits4 deletes in tags/Safari-534.6.1
Roll out r66156.
- 2:53 PM Changeset in webkit [66262] by
-
- 5 edits in tags/Safari-534.6.1
Versioning.
- 2:51 PM Changeset in webkit [66261] by
-
- 3 edits1 delete in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Not reviewed, updating chromium test expectations after r66251.
- platform/chromium/Skipped: Removed.
- platform/chromium/fast/dom/domListEnumeration-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:45 PM Changeset in webkit [66260] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8147879> - Null URL passed to WebKit2 HistoryDelegate
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): WK2 now loads initial about:blank document's synchronously,
without consulting the policy delegate.
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
- 2:36 PM Changeset in webkit [66259] by
-
- 1 copy in tags/Safari-534.6.1
New tag.
- 2:35 PM Changeset in webkit [66258] by
-
- 4 edits9 adds in trunk
2010-08-27 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=42862
WebGL in CSS Canvas crashes
This fixes the crash, which was a simple null pointer deref. But this
revealed that -webkit-canvas no longer works for WebGL. I believe this
is due to the recent ImageBuffer optimizations done by Dave Hyatt
(https://bugs.webkit.org/show_bug.cgi?id=43507). This changed ImageBuffer
from always keeping a copy of the pixels to doing a copy to get them
when needed. Since We need to get pixels out of the WebGL drawing buffer
to use them as a CSS background, I had to change when I return those
pixels to the ImageBuffer.
Tests: fast/canvas/webgl/css-webkit-canvas-repaint.html
fast/canvas/webgl/css-webkit-canvas.html
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage): Add logic to get image from WebGL so it works with new ImageBuffer logic (see above)
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Fixed null pointer deref
- 2:22 PM Changeset in webkit [66257] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Not reviewed, cleaning up chromium test results.
After r66245, JSC and V8 produce the same results for fast/js/kde/Number.html.
- platform/chromium-mac/fast/js/kde/Number-expected.txt: Removed.
- platform/chromium-win/fast/js/kde/Number-expected.txt: Removed.
- 2:18 PM Changeset in webkit [66256] by
-
- 3 edits2 copies1 move3 adds1 delete in trunk/WebCore
2010-08-27 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Move Shader class from platform/graphics/chromium to platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=44793
The Shader class and its subclasses are not chromium-specific. This moves
them to a common location so they can be re-used on all platforms. Also
moves the Shader subclasses into their own .h/.cpp files.
Refactor, no new tests.
- WebCore.gypi:
- platform/graphics/chromium/GLES2Canvas.cpp:
- platform/graphics/chromium/Shader.cpp: Removed.
- platform/graphics/chromium/Shader.h: Removed.
- platform/graphics/gpu/Shader.cpp: Added. (WebCore::Shader::affineTo3x3): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::Shader): (WebCore::Shader::~Shader):
- platform/graphics/gpu/Shader.h: Added.
- platform/graphics/gpu/SolidFillShader.cpp: Added. (WebCore::SolidFillShader::SolidFillShader): (WebCore::SolidFillShader::create): (WebCore::SolidFillShader::use):
- platform/graphics/gpu/SolidFillShader.h: Added.
- platform/graphics/gpu/TexShader.cpp: Added. (WebCore::TexShader::TexShader): (WebCore::TexShader::create): (WebCore::TexShader::use):
- platform/graphics/gpu/TexShader.h: Added.
- 2:15 PM Changeset in webkit [66255] by
-
- 13 edits5 adds in trunk
2010-08-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add AsyncFileSystem interface for platform-dependent FileSystem API implementation
https://bugs.webkit.org/show_bug.cgi?id=44433
No new tests; tests will be added later.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/AsyncFileSystem.cpp: Added.
- platform/AsyncFileSystem.h: Added.
- platform/AsyncFileSystemCallbacks.h: Added.
- storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem): (WebCore::DOMFileSystem::~DOMFileSystem): (WebCore::DOMFileSystem::stop): (WebCore::DOMFileSystem::hasPendingActivity): (WebCore::DOMFileSystem::contextDestroyed):
- storage/DOMFileSystem.h: (WebCore::DOMFileSystem::create):
- storage/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didFail): (WebCore::FileSystemCallbacks::FileSystemCallbacks): (WebCore::FileSystemCallbacks::didOpenFileSystem):
- storage/FileSystemCallbacks.h:
- storage/LocalFileSystem.cpp: Added.
- storage/LocalFileSystem.h: Added.
- storage/Flags.h: Nits fix.
- 2:11 PM Changeset in webkit [66254] by
-
- 14 edits in trunk/LayoutTests
Try to make some xssAuditor tests less flakey.
https://bugs.webkit.org/show_bug.cgi?id=44749
Reviewed by Simon Fraser.
Use postMessage() to communicate to the top window each time a
beforeload event fires in the iframe. When the top window has seen a
beforeload event from each widget in the iframe, it calls notifyDone().
This prevents the test from exiting before all the widgets have had a
chance to load, therefore ensuring that all relevant XSS Auditor
messages have been emitted.
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char.html:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char.html:
- http/tests/security/xssAuditor/object-embed-tag.html:
- http/tests/security/xssAuditor/object-src-inject.html:
- http/tests/security/xssAuditor/object-tag-javascript-url.html:
- http/tests/security/xssAuditor/object-tag.html:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/resources/echo-object-src.pl:
- http/tests/security/xssAuditor/resources/utilities.js:
(notifyDoneAfterReceivingBeforeloadFromIds):
- platform/mac/Skipped:
- 2:06 PM Changeset in webkit [66253] by
-
- 5 edits in trunk
Versioning.
- 2:06 PM Changeset in webkit [66252] by
-
- 1 copy in tags/Safari-534.6
New tag.
- 1:49 PM Changeset in webkit [66251] by
-
- 47 edits18 adds in trunk
2010-07-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099
- wtf/Platform.h: Enable FULLSCREEN_API mode for the Mac (except iOS).
2010-07-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
Added chrome client overrides which support entering and exiting full screen. A new preference has
been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
(defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
when the chrome has started/finished its full screen animation.
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullscreenForElement): (WebChromeClient::enterFullscreenForElement): (WebChromeClient::exitFullscreenForElement): (-[WebKitFullScreenListener initWithElement:]): (-[WebKitFullScreenListener webkitWillEnterFullScreen]): (-[WebKitFullScreenListener webkitDidEnterFullScreen]): (-[WebKitFullScreenListener webkitWillExitFullScreen]): (-[WebKitFullScreenListener webkitDidExitFullScreen]):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setFullScreenEnabled:]): (-[WebPreferences fullScreenEnabled]):
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-07-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099
Mozilla has proposed a new set of JavaScript APIs which allow any element in
a document to go full-screen. The current revision of their proposal can be
found here:
<https://wiki.mozilla.org/index.php?title=Gecko:FullScreenAPI&oldid=243429>
The proposed specification includes the following:
Document:
- Three new methods on Document:
+ void requestFullScreen()
+ void requestFullScreenWithKeys()
+ void cancelFullScreen()
- Three new attributes of Document:
+ readonly attribute boolean fullScreen
+ readonly attribute boolean fullScreenWithKeys
+ (optional) readonly attribute Element currentFullScreenElement
Element:
- Two new methods on Element:
+ void requestFullScreen()
+ void requestFullScreenWithKeys()
Events:
- One new event:
+ fullScreenChange
CSS Pseudo-classes:
- Three new Pseudo-classes:
+ :full-screen
+ :full-screen-doc
+ :full-screen-root-with-target
For WebKit's initial implementation, all the above new APIs will be prefixed with
"webkit" or "-webkit" where appropriate.
New tests:
LayoutTests/fullscreen/full-screen-api.html
LayoutTests/fullscreen/full-screen-css.html
LayoutTests/fullscreen/full-screen-request.html
Project file changes:
- Configurations/FeatureDefines.xcconfig: Added an ENABLE_FULLSCREEN_API entry.
- DerivedSources.make: Added rules for fullscreen.css and WebCore.FullScreen.exp.
- WebCore.FullScreen.exp: Added export symbols for Document and Element functions.
- WebCore.xcodeproj/project.pbxproj: New source files added to the project.
IDL changes:
- dom/Document.idl: Added the new full-screen API to the Document's javascript interface.
- dom/Element.idl: Added the new full-screen API to the Element's javascript interface.
Source changes:
- bindings/objc/PublicDOMInterfaces.h: Exposed Document and Element fullscreen functions in the DOM classes.
- css/CSSSelector.cpp: Added new FullScreen pseudo-classes.
- css/CSSSelector.h: Added new full-screen pseudo classes to the PseudoType enum.
- css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle): Pull the fullscreen.css sheet into the defaultStyle and the defaultQuirksStyle sheets. (WebCore::loadSimpleDefaultStyle): Pull the fullscreen.css sheet into the defaultStyle sheet. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Check for the new FullScreen pseudo classes.
- dom/Document.cpp: (WebCore::Document::createEvent): Support creating a "WebKitFullScreenChange" event. (WebCore::Document::addListenerTypeIfNeeded): Support listening for a "webKitFullScreenChangeEvent" (WebCore::Document::webkitRequestFullScreenForElement): Passes request to the chrome client to enter full screen mode. (WebCore::Document::webkitCancelFullScreen): Passes request to the chrome client to exit full screen mode. (WebCore::Document::webkitWillEnterFullScreenForElement): Sets the FullScreen pseudo-classes on the full-screen element and its document. (WebCore::Document::webkitDidEnterFullScreenForElement): Currently a no-op. (WebCore::Document::webkitWillExitFullScreenForElement): Currently a no-op. (WebCore::Document::webkitDidExitFullScreenForElement): Clears the FullScreen pseudo-classes on the full-screen element and its document.
- dom/Document.h: Added const accessors for new full-screen instance variables. (WebCore::Document::): (WebCore::Document::webkitIsFullScreen): Accessor for m_isFullScreen. (WebCore::Document::webkitIsFullScreenWithKeysEnabled): Accessor for m_isFullScren and m_areKeysEnabled. (WebCore::Document::webkitCurrentFullScreenElement): Accessor for m_fullScreenElement.
- dom/Element.cpp: (WebCore::Element::webkitRequestFullScreen): Calls Document::webkitRequestFullScreenForElement.
- dom/Element.h:
- dom/EventNames.h: Add a webkitfullscreenchange event name.
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Parse the new "onwebkitfullscreenchange" attribute and register a listener.
- page/ChromeClient.h: (WebCore::ChromeClient::supportsFullscreenForElement): Pass through to the current UI delegate. (WebCore::ChromeClient::enterFullscreenForElement): Create a WebKitFullScreenListener and pass through to the current UI delegate. (WebCore::ChromeClient::exitFullscreenForElement): Create a WebKitFullScreenListener and pass through to the current UI delegate.
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: Add a new setting to control runtime support for full screen mode (defaults to off)
- rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): The full screen button now toggles full screen mode (previously, it only entered).
- rendering/style/RenderStyleConstants.h: Added new style constants.
2010-08-09 Jer Noble <jer.noble@apple.com>
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099
New tests for the new full screen API:
full-screen-api.html: tests for the presence of the new full screen
apis.
full-screen-request.html: tests that clients can request the browser
enter full screen mode successfully.
full-screen-css.html: tests that the new full screen pseudo classes are
applied once full screen mode is entered.
full-screen-remove.html: tests that the document's current full screen
element is changed when that element is removed from the DOM tree.
full-screen-remove-ancestor.html: tests that the document's current full
screen element is changed an ancestor of that element is removed
from the DOM tree.
full-screen-twice.html: tests that entering full screen mode on two
different elements in a row does not fail.
Tests that were changed:
domListEnumeration.html: This test returns a specific count of
properties on HTML elements; after consultation with Sam Weinig (the
original test author), it was decided that this part of the test
would be very difficult to make platform specific, and that nothing
significant would be lost if the property count sections were
removed.
platform/*/Skipped: Added the fullscreen/ directory to the Skipped list
for every platform save mac.
- fast/dom/Window/window-properties-expected.txt: Added the new
properties exposed on Document and Element.
- fast/dom/domListEnumeration-expected.txt: Removed the iteration count
part of this test.
- fast/dom/script-tests/domListEnumeration.js: ""
- fullscreen: Added.
- platform/mac/fullscreen: Added.
- platform/mac/fullscreen/full-screen-api-expected.txt: Added.
- platform/mac/fullscreen/full-screen-api.html: Added.
- platform/mac/fullscreen/full-screen-css-expected.txt: Added.
- platform/mac/fullscreen/full-screen-css.html: Added.
- platform/mac/fullscreen/full-screen-remove-ancestor-expected.txt: Added.
- platform/mac/fullscreen/full-screen-remove-ancestor.html: Added.
- platform/mac/fullscreen/full-screen-remove-expected.txt: Added.
- platform/mac/fullscreen/full-screen-remove.html: Added.
- platform/mac/fullscreen/full-screen-request-expected.txt: Added.
- platform/mac/fullscreen/full-screen-request.html: Added.
- platform/mac/fullscreen/full-screen-twice-expected.txt: Added.
- platform/mac/fullscreen/full-screen-twice.html: Added.
2010-07-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
Added basic full screen support to DumpRenderTree: when a webView requests
that DumpRenderTree go "full screen", just call the provided callback listener object's
will/did Enter/Exit full screen methods. Also, register a new user default which
enables full screen support.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:supportsFullscreenForElement:]): (-[UIDelegate webView:enterFullscreenForElement:listener:]): (-[UIDelegate webView:exitFullscreenForElement:listener:]):
- 1:44 PM Changeset in webkit [66250] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784
Skip fast/history/history-subframe-with-name.html for GTK while we figure out
why it fails there.
- platform/gtk/Skipped:
- 1:42 PM Changeset in webkit [66249] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:37 PM Changeset in webkit [66248] by
-
- 8 edits4 moves1 add in trunk/WebCore
2010-08-27 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Move Texture class from p/g/chromium to p/g/gpu
https://bugs.webkit.org/show_bug.cgi?id=44783
This class and its support were developed in platform/graphics/chromium but are not chromium-specific
in any way. This patch moves them to a common location so they can be shared by all platforms.
Pure refactor, so no new tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture):
- platform/graphics/chromium/GLES2Canvas.h:
- platform/graphics/chromium/GLES2Texture.cpp: Removed.
- platform/graphics/chromium/GLES2Texture.h: Removed.
- platform/graphics/gpu/Texture.cpp: Added. (WebCore::Texture::Texture): (WebCore::Texture::~Texture): (WebCore::convertFormat): (WebCore::Texture::create): (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::bindTile):
- platform/graphics/gpu/Texture.h: Added. (WebCore::Texture::): (WebCore::Texture::format): (WebCore::Texture::tiles):
- platform/graphics/gpu/TilingData.cpp: Renamed from WebCore/platform/graphics/chromium/TilingData.cpp. (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord): (WebCore::TilingData::tileBounds): (WebCore::TilingData::tileBoundsWithBorder): (WebCore::TilingData::tileBoundsNormalized): (WebCore::TilingData::tilePositionX): (WebCore::TilingData::tilePositionY): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::overlappedTileIndices): (WebCore::TilingData::intersectDrawQuad):
- platform/graphics/gpu/TilingData.h: Renamed from WebCore/platform/graphics/chromium/TilingData.h. (WebCore::TilingData::maxTextureSize): (WebCore::TilingData::totalSizeX): (WebCore::TilingData::totalSizeY): (WebCore::TilingData::numTiles): (WebCore::TilingData::numTilesX): (WebCore::TilingData::numTilesY): (WebCore::TilingData::tileIndex): (WebCore::TilingData::tileXIndex): (WebCore::TilingData::tileYIndex): (WebCore::TilingData::TilingData): (WebCore::TilingData::assertTile):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
- platform/graphics/skia/PlatformContextSkia.h:
- 1:29 PM Changeset in webkit [66247] by
-
- 52 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
Reviewed by Simon Fraser.
WebCore:
Rename the various modes to match the HTML5 specification:
ParseMode -> CompatibilityMode
CompatMode -> QuirksMode
AlmostStrictMode -> LimitedQuirksMode
StrictMode -> NoQuirksMode
Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
Clean up user stylesheets to minimize style recalculation when the mode is switched.
Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
a doctype token.
determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
precisely.
- WebCore.exp.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
- dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList):
- dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::appendBytes):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::setDocType):
(WebCore::Document::unscheduleStyleRecalc):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::createStyleSelector):
(WebCore::Document::implicitOpen):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::updatePageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::updatePageGroupUserSheets):
(WebCore::Document::findAnchor):
- dom/Document.h:
(WebCore::Document::):
(WebCore::Document::setCompatibilityModeFromDoctype):
(WebCore::Document::lockCompatibilityMode):
(WebCore::Document::compatibilityMode):
(WebCore::Document::inQuirksMode):
(WebCore::Document::inLimitedQuirksMode):
(WebCore::Document::inNoQuirksMode):
- dom/Element.cpp:
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
(WebCore::Element::webkitMatchesSelector):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setClass):
- dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
- dom/OptionElement.cpp:
(WebCore::OptionElement::collectOptionLabelOrText):
- dom/SelectorNodeList.cpp:
(WebCore::createSelectorNodeList):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::parseMappedAttribute):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::createLinkDecl):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertDoctype):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
(WebCore::HTMLDocument::compatMode):
(WebCore::HTMLDocument::setCompatibilityModeFromDoctype):
- html/HTMLDocument.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::defaultForInitial):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::reportDataReceived):
- loader/DocumentWriter.h:
- loader/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
- loader/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
- loader/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
- loader/SinkDocument.cpp:
(WebCore::SinkDocument::SinkDocument):
- loader/TextDocument.cpp:
(WebCore::TextDocument::TextDocument):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- page/PageGroup.cpp:
(WebCore::PageGroup::resetUserStyleCacheInAllFrames):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setEnforceCSSMIMETypeInNoQuirksMode):
- page/Settings.h:
(WebCore::Settings::enforceCSSMIMETypeInNoQuirksMode):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcPrefWidths):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::calcInlinePrefWidths):
(WebCore::RenderBlock::calcBlockPrefWidths):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createInlineBoxForRenderer):
(WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewHeight):
- rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowHeight):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticallyAlignBoxes):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::setBitDefaults):
WebKit/mac:
Rename the various modes to match the HTML5 specification:
ParseMode -> CompatibilityMode
CompatMode -> QuirksMode
AlmostStrictMode -> LimitedQuirksMode
StrictMode -> NoQuirksMode
Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
Clean up user stylesheets to minimize style recalculation when the mode is switched.
Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
a doctype token.
determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
precisely.
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
- 1:28 PM Changeset in webkit [66246] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:12 PM Changeset in webkit [66245] by
-
- 15 edits in trunk
Bug 44745 - Number.toFixed/toExponential/toPrecision are inaccurate.
Reviewed by Oliver Hunt.
These methods should be using a version of dtoa that can generate results accurate
to the requested precision, whereas our version of dtoa is only currently able to
support producing results sufficiently accurate to distinguish the value from any
other IEEE-754 double precision number.
This change has no impact on benchmarks we track.
On microbenchmarks for these functions, this is a slight regression where a high
precision is requested (dtoa now need to iterate further to generate a a greater
number of digits), but with smaller precision values (hopefully more common) this
improves performance, since it reduced the accurate of result dtoa is required,
to produce, and removes the need to pre-round values before calling dtoa.
- JavaScriptCore.exp:
doubleToStringInJavaScriptFormat renamed to numberToString
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
doubleToStringInJavaScriptFormat renamed to numberToString
- runtime/UString.cpp:
(JSC::UString::number):
doubleToStringInJavaScriptFormat renamed to numberToString
- wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):
Remove all pre-rounding of values, instead call dtoa correctly.
- wtf/dtoa.cpp:
(WTF::dtoa):
- wtf/dtoa.h:
Reenable support for rounding to specific-figures/decimal-places in dtoa.
Modify to remove unbiased rounding, provide ECMA required away-from-zero.
Rewrite doubleToStringInJavaScriptFormat to use DecimalNumber, rename to
numberToString.
WebCore:
- html/HTMLTreeBuilder.cpp:
(WebCore::serializeForNumberType):
doubleToStringInJavaScriptFormat renamed to numberToString.
LayoutTests:
Updating expected results, corrected errors in fast/js/kde/script-tests/Number.js
(corrected results confirmed with FireFox).
- fast/js/kde/Number-expected.txt:
- fast/js/kde/script-tests/Number.js:
- fast/js/number-toExponential-expected.txt:
- fast/js/number-tofixed-expected.txt:
- fast/js/number-toprecision-expected.txt:
- 1:04 PM Changeset in webkit [66244] by
-
- 2 edits in trunk
2010-08-27 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed. Fix compiling dependencies on EFL port due to r65891.
No new functionality so no new tests.
- cmake/WebKitGenerators.cmake:
- 12:42 PM Changeset in webkit [66243] by
-
- 12 edits in trunk
2010-08-27 Michael Nordman <Michael Nordman>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=44133
IDL bindings for XmlHttpRequest.responseBlob support, doesn't do anything yet.
Adds two new attributes, asBlob and responseBlob.
Runtime disabled by default, also behind a new ENABLE_XHR_RESPONSE_BLOB compile time guard.
No new tests, just adding some stubs.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setResponseBlobEnabled): (WebCore::RuntimeEnabledFeatures::responseBlobEnabled): (WebCore::RuntimeEnabledFeatures::asBlobEnabled):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText): Changed to allow an exceptional return path.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): Changed to allow an exceptional return path.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseXML): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseBlob): Added stub method, returns 0 for now. (WebCore::XMLHttpRequest::setAsBlob): Sets the asBlob attribute, raises exception if called at an inappropriate time. (WebCore::XMLHttpRequest::open): Resets asBlob to false, the default value. (WebCore::XMLHttpRequest::abort): Clears m_responseBlob. (WebCore::XMLHttpRequest::clearResponse): Clears m_responseBlob. (WebCore::XMLHttpRequest::didFinishLoading): Added a FIXME to populate m_responseBlob.
- xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob):
- xml/XMLHttpRequest.idl:
2010-08-27 Michael Nordman <Michael Nordman>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=44133
WebKitAPI to allow runtime enablement of XmlHttpRequest.responseBlob.
- features.gypi: Define ENABLE_XHR_RESPONSE_BLOB.
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):
- 12:26 PM Changeset in webkit [66242] by
-
- 1 edit363 adds in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed. Add google-chrome linux ia32 results. These are slightly
different from the chromium-linux results because of rounding
differences due to different compiler flags. These results are
expected to pass on ubuntu hardy 32.
- platform/google-chrome-linux32/css1/box_properties/acid_test-expected.checksum: Added.
- platform/google-chrome-linux32/css1/box_properties/acid_test-expected.png: Added.
- platform/google-chrome-linux32/css1/box_properties/acid_test-expected.txt: Added.
- platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.checksum: Added.
- platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.png: Added.
- platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.txt: Added.
- platform/google-chrome-linux32/editing/execCommand/5138441-expected.checksum: Added.
- platform/google-chrome-linux32/editing/execCommand/5138441-expected.png: Added.
- platform/google-chrome-linux32/editing/inserting/editing-empty-divs-expected.checksum: Added.
- platform/google-chrome-linux32/editing/inserting/editing-empty-divs-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize04-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize04-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize18-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/svg-as-background-4-expected.png: Added.
- platform/google-chrome-linux32/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
- platform/google-chrome-linux32/fast/backgrounds/svg-as-background-5-expected.png: Added.
- platform/google-chrome-linux32/fast/block/basic/011-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/basic/011-expected.png: Added.
- platform/google-chrome-linux32/fast/block/basic/011-expected.txt: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-2-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-2-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-3-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-3-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-2-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-2-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-3-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-3-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-ltr-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-rtl-expected.checksum: Added.
- platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.
- platform/google-chrome-linux32/fast/borders/border-image-omit-right-slice-expected.checksum: Copied from LayoutTests/platform/chromium-win/fast/borders/border-image-omit-right-slice-expected.checksum.
- platform/google-chrome-linux32/fast/borders/border-image-omit-right-slice-expected.png: Copied from LayoutTests/platform/chromium-win/fast/borders/border-image-omit-right-slice-expected.png.
- platform/google-chrome-linux32/fast/borders/border-image-rotate-transform-expected.checksum: Added.
- platform/google-chrome-linux32/fast/borders/border-image-rotate-transform-expected.png: Added.
- platform/google-chrome-linux32/fast/borders/borderRadiusSolid03-expected.checksum: Added.
- platform/google-chrome-linux32/fast/borders/borderRadiusSolid03-expected.png: Added.
- platform/google-chrome-linux32/fast/css-generated-content/012-expected.checksum: Added.
- platform/google-chrome-linux32/fast/css-generated-content/012-expected.png: Added.
- platform/google-chrome-linux32/fast/css/border-height-expected.checksum: Added.
- platform/google-chrome-linux32/fast/css/border-height-expected.png: Added.
- platform/google-chrome-linux32/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
- platform/google-chrome-linux32/fast/css/margin-top-bottom-dynamic-expected.png: Added.
- platform/google-chrome-linux32/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
- platform/google-chrome-linux32/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
- platform/google-chrome-linux32/fast/forms/menulist-style-color-expected.checksum: Added.
- platform/google-chrome-linux32/fast/forms/menulist-style-color-expected.png: Added.
- platform/google-chrome-linux32/fast/forms/negativeLineHeight-expected.checksum: Added.
- platform/google-chrome-linux32/fast/forms/negativeLineHeight-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/negativeLineHeight-expected.png.
- platform/google-chrome-linux32/fast/forms/search-vertical-alignment-expected.checksum: Added.
- platform/google-chrome-linux32/fast/forms/search-vertical-alignment-expected.png: Added.
- platform/google-chrome-linux32/fast/forms/textAreaLineHeight-expected.checksum: Added.
- platform/google-chrome-linux32/fast/forms/textAreaLineHeight-expected.png: Added.
- platform/google-chrome-linux32/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum: Added.
- platform/google-chrome-linux32/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/google-chrome-linux32/fast/gradients/radial-centered-expected.checksum: Added.
- platform/google-chrome-linux32/fast/gradients/radial-centered-expected.png: Added.
- platform/google-chrome-linux32/fast/images/animated-svg-as-image-expected.checksum: Added.
- platform/google-chrome-linux32/fast/images/animated-svg-as-image-expected.png: Added.
- platform/google-chrome-linux32/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
- platform/google-chrome-linux32/fast/inline-block/inline-block-vertical-align-expected.png: Added.
- platform/google-chrome-linux32/fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
- platform/google-chrome-linux32/fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
- platform/google-chrome-linux32/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
- platform/google-chrome-linux32/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Added.
- platform/google-chrome-linux32/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
- platform/google-chrome-linux32/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/google-chrome-linux32/fast/replaced/absolute-image-sizing-expected.checksum: Added.
- platform/google-chrome-linux32/fast/replaced/absolute-image-sizing-expected.png: Added.
- platform/google-chrome-linux32/fast/table/empty-table-percent-height-expected.checksum: Added.
- platform/google-chrome-linux32/fast/table/empty-table-percent-height-expected.png: Added.
- platform/google-chrome-linux32/plugins/embed-attributes-style-expected.checksum: Added.
- platform/google-chrome-linux32/plugins/embed-attributes-style-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-09-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-03-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-group-03-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/google-chrome-linux32/svg/batik/text/textEffect-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/textEffect-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath2-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath2-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath3-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPath3-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPathSpaces-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/textOnPathSpaces-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/verticalText-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/verticalText-expected.png: Added.
- platform/google-chrome-linux32/svg/batik/text/verticalTextOnPath-expected.checksum: Added.
- platform/google-chrome-linux32/svg/batik/text/verticalTextOnPath-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/circular-marker-reference-2-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/circular-marker-reference-2-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/control-points-for-S-and-T-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum.
- platform/google-chrome-linux32/svg/custom/control-points-for-S-and-T-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png.
- platform/google-chrome-linux32/svg/custom/empty-merge-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/empty-merge-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/empty-merge-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/feComponentTransfer-Table-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/feDisplacementMap-01-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/focus-ring-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/focus-ring-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum.
- platform/google-chrome-linux32/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png.
- platform/google-chrome-linux32/svg/custom/image-small-width-height-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/image-small-width-height-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/image-with-transform-clip-filter-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/image-with-transform-clip-filter-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/inline-svg-in-xhtml-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-all-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-all-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-transform-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-transform-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/non-circular-marker-reference-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/non-circular-marker-reference-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/path-getTotalLength-expected.txt: Copied from LayoutTests/svg/custom/path-getTotalLength-expected.txt.
- platform/google-chrome-linux32/svg/custom/pattern-with-transformation-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/recursive-filter-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/recursive-filter-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/recursive-filter-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/relative-sized-use-on-symbol-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.checksum.
- platform/google-chrome-linux32/svg/custom/relative-sized-use-on-symbol-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.png.
- platform/google-chrome-linux32/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.txt: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
- platform/google-chrome-linux32/svg/custom/use-css-events-expected.checksum: Added.
- platform/google-chrome-linux32/svg/custom/use-css-events-expected.png: Added.
- platform/google-chrome-linux32/svg/custom/width-full-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/width-full-percentage-expected.txt.
- platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/google-chrome-linux32/svg/filters/filteredImage-expected.checksum: Added.
- platform/google-chrome-linux32/svg/filters/filteredImage-expected.png: Added.
- platform/google-chrome-linux32/svg/filters/filteredImage-expected.txt: Copied from LayoutTests/platform/qt/svg/filters/filteredImage-expected.txt.
- platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
- platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.png: Added.
- platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.txt: Added.
- platform/google-chrome-linux32/svg/filters/subRegion-one-effect-expected.checksum: Added.
- platform/google-chrome-linux32/svg/filters/subRegion-one-effect-expected.png: Added.
- platform/google-chrome-linux32/svg/filters/subRegion-two-effects-expected.checksum: Added.
- platform/google-chrome-linux32/svg/filters/subRegion-two-effects-expected.png: Added.
- platform/google-chrome-linux32/svg/hixie/perf/001-expected.checksum: Added.
- platform/google-chrome-linux32/svg/hixie/perf/001-expected.png: Added.
- platform/google-chrome-linux32/svg/hixie/perf/001-expected.txt: Added.
- platform/google-chrome-linux32/svg/hixie/perf/002-expected.checksum: Added.
- platform/google-chrome-linux32/svg/hixie/perf/002-expected.png: Added.
- platform/google-chrome-linux32/svg/hixie/perf/002-expected.txt: Added.
- platform/google-chrome-linux32/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
- platform/google-chrome-linux32/svg/text/text-path-01-b-expected.checksum: Added.
- platform/google-chrome-linux32/svg/text/text-path-01-b-expected.png: Added.
- platform/google-chrome-linux32/svg/text/text-text-06-t-expected.checksum: Added.
- platform/google-chrome-linux32/svg/text/text-text-06-t-expected.png: Added.
- platform/google-chrome-linux32/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/google-chrome-linux32/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/google-chrome-linux32/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/google-chrome-linux32/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug1296-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug1296-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug1430-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug1430-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug15544-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug15544-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug23235-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug23235-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2886-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2886-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2947-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2947-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2981-2-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug2981-2-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug4284-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug4284-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug4427-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug4427-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug625-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/core/bloomberg-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/core/bloomberg-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_position-table-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla/other/cell_widths-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla/other/cell_widths-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Added.
- platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
- platform/google-chrome-linux32/transforms/svg-vs-css-expected.checksum: Added.
- platform/google-chrome-linux32/transforms/svg-vs-css-expected.png: Added.
- 11:40 AM Changeset in webkit [66241] by
-
- 2 edits in trunk/WebKit/qt
2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] tst_QWebFrame::inputFieldFocus() fails on MeeGo Handset with QtWebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44703
Make the test more robust to changes in the execution environment.
The position where the mouse events are sent is now computed from the element geometry,
this make the test less dependent on the fonts.
The test now also make sure the window manager mapped the window on screen
before attempting to send the events.
- tests/qwebframe/tst_qwebframe.cpp:
- 11:30 AM Changeset in webkit [66240] by
-
- 4 edits2 adds in trunk
2010-08-27 Simon Fraser <Simon Fraser>
Reviewed by Tony Chang.
Crash in CSSStyleSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=44780
Need to null-check the images when replacing pending images, because a later
rule may have replaced an image with 'none'.
Test: fast/css/pending-images-crash.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
- page/FrameView.cpp: (WebCore::FrameView::paintContents): Fix unrelated log message.
- 11:24 AM Changeset in webkit [66239] by
-
- 16 edits1 add9 deletes in trunk
2010-08-27 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Revert r66218 & r66220 due to GTK test failures.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.categorySortFunction): (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/AuditResultView.js: (WebInspector.AuditCategoryResultPane.prototype._appendResult):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditCategory.prototype.runRules):
- inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI): (injectedExtensionAPI.EventSinkImpl.prototype.addListener): (injectedExtensionAPI.EventSinkImpl.prototype._fire): (injectedExtensionAPI.EventSink): (injectedExtensionAPI.InspectorExtensionAPI): (injectedExtensionAPI.Panels.prototype.create):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionStatus):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js: ():
2010-08-27 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Revert r66218 & r66220 due to GTK test failures.
- inspector/audits-panel-functional.html:
- inspector/audits-tests.js: Removed.
- inspector/extensions-api-expected.txt:
- inspector/extensions-audits-api-expected.txt: Removed.
- inspector/extensions-audits-api.html: Removed.
- inspector/extensions-audits-expected.txt: Removed.
- inspector/extensions-audits-tests.js: Removed.
- inspector/extensions-audits.html: Removed.
- inspector/extensions-expected.txt:
- inspector/resources/audits-script3.js: Added. (foo3):
- platform/chromium/test_expectations.txt:
- 11:20 AM Changeset in webkit [66238] by
-
- 7 edits5 adds in trunk
2010-08-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Crash in HistoryController::recursiveGoToItem when navigating in a frame
while another frame has a custom window name
https://bugs.webkit.org/show_bug.cgi?id=44183
Add a test to check that we can handle navigation from a top-level frame
when one of the child frames sets window.name after load.
- fast/history/history-subframe-with-name-expected.txt: Added.
- fast/history/history-subframe-with-name.html: Added.
- fast/history/resources/history-subframe-with-name-2.html: Added.
- fast/history/resources/history-subframe-with-name-3.html: Added.
- fast/history/resources/history-subframe-with-name-container.html: Added.
2010-08-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Crash in HistoryController::recursiveGoToItem when navigating in a frame
while another frame has a custom window name
https://bugs.webkit.org/show_bug.cgi?id=44183
Fix up HistoryController::recursiveGoToItem to better check whether the
current document frames, the curent history item frames, and the
destination history frames match up.
Test: fast/history/history-subframe-with-name.html
- history/HistoryItem.cpp: (WebCore::HistoryItem::childItemWithDocumentSequenceNumber): Add linear lookup of child by document sequence number (WebCore::HistoryItem::hasSameDocuments): Remove assumption that the other item has the children in the same order (it doesn't seem to be true) (WebCore::HistoryItem::hasSameFrames): Add recursive comparison of child frames.
- history/HistoryItem.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Compare full set of documents in history items, not just the topmost ones. Otherwise when going between framesets where only one of the subframes changed we wouldn't trigger a load.
- loader/HistoryController.cpp: (WebCore::HistoryController::recursiveGoToItem): Also check that the two history items have the same frames (WebCore::HistoryController::currentFramesMatchItem): Refactor childFramesMatchItem to also check the top-most frame, to make recursiveGoToItem easier to read.
- loader/HistoryController.h:
- 10:53 AM Changeset in webkit [66237] by
-
- 3 edits in trunk/WebCore
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[WINCE] Buildfix for graphics code after r65449
https://bugs.webkit.org/show_bug.cgi?id=44510
- platform/graphics/wince/GraphicsContextWince.cpp:
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::ImageBuffer::drawsUsingCopy): (WebCore::ImageBuffer::copyImage): (WebCore::ImageBuffer::clip): (WebCore::ImageBuffer::draw): (WebCore::ImageBuffer::drawPattern):
- 10:50 AM Changeset in webkit [66236] by
-
- 5 edits31 deletes in trunk/WebKitSite/specs
Remove obsolete CSS proposals, adding links to the most recent ones. Add nodes to the HTML media proposals indicating that they are stagnant or have been superseded.
- 10:45 AM Changeset in webkit [66235] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed, remove duplicate test expectation.
- platform/chromium/test_expectations.txt:
- 10:35 AM Changeset in webkit [66234] by
-
- 2 edits in trunk/WebCore
2010-08-27 Dawit Alemayehu <adawit@kde.org>
Reviewed by Simon Hausmann.
[Qt] Search the Windows registry for the location of the Java plugin DLL.
https://bugs.webkit.org/show_bug.cgi?id=38911
This change, in addition to the ones 34539 and 38911, is needed to
make Java applet work in QtWebKit on the Windows platform.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::addJavaPluginDirectory): (WebCore::PluginDatabase::defaultPluginDirectories):
- 10:34 AM Changeset in webkit [66233] by
-
- 2 edits in trunk/WebKitSite
- coding/RefPtr.html: Minor revision, improve clarity and mention some
recent developments.
- 10:23 AM Changeset in webkit [66232] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Andrey Kosyakov <caseq@chromium.org>
Unreviewed.
Attempt to fix flakiness of inspector extension audit tests.
- inspector/extensions-audits-tests.js:
- 10:15 AM Changeset in webkit [66231] by
-
- 2 edits in trunk/WebKit2
Handle ERROR_IO_INCOMPLETE more correctly in Connection
We still don't know exactly why we're getting this error, but at least
we can do something sensible when we do.
Fixes <http://webkit.org/b/44776> Occasional crash in
Connection::readEventHandler or assertion failure in
Connection::writeEventHandler due to ERROR_IO_INCOMPLETE
Reviewed by Sam Weinig.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Bail out of this function
entirely when we get ERROR_IO_INCOMPLETE. We'll get called back later
when the read completes. Continuing in the function at this point
would cause us to treat an incomplete read as a complete one, leading
to a crash. Added an assertion to make the crash more understandable
in the future.
(CoreIPC::Connection::writeEventHandler): Bail out when we get
ERROR_IO_INCOMPLETE. We'll get called back later when the write
completes.
- 10:14 AM Changeset in webkit [66230] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed. Add chromium-mac results for svg/custom/getscreenctm-in-scrollable-div-area.xhtml.
The image results are the same except for the scrollbars. I'm not
sure why this wasn't landed with the win/linux results in r66193.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
- 10:14 AM Changeset in webkit [66229] by
-
- 2 edits in trunk/WebKit2
Make the web process pause on launch when the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable is set
This is a bit easier to use than holding Ctrl-Alt-Shift during launch,
since the process can sometimes take a long time to launch under the
debugger. Ctrl-Alt-Shift still works, however.
Fixes <http://webkit.org/b/44774> Would like an easier way to pause
the web process on launch
Reviewed by Sam Weinig.
- WebProcess/WebKitMain.cpp:
(WebKitMain):
- 10:03 AM Changeset in webkit [66228] by
-
- 3 edits3 deletes in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed. Reverting r66177, which were chromium expectations for
fast/forms/select-style. It seems like this was a regression fixed in r66195.
- platform/chromium-mac/fast/forms/select-style-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/select-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/select-style-expected.txt: Removed.
- platform/chromium-win/fast/forms/select-style-expected.checksum:
- platform/chromium-win/fast/forms/select-style-expected.png:
- 9:58 AM Changeset in webkit [66227] by
-
- 2 edits in trunk/WebKit2
- WebKit2.xcodeproj/project.pbxproj: Make WKBundleScriptWorld.h public.
Rubber-stamped by Adam Roben.
- 9:52 AM Changeset in webkit [66226] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test expectations.
- platform/chromium/test_expectations.txt:
- 9:06 AM Changeset in webkit [66225] by
-
- 2 edits in trunk/WebCore
2010-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: color-code property values in object notation.
https://bugs.webkit.org/show_bug.cgi?id=44766
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
- 8:58 AM Changeset in webkit [66224] by
-
- 2 edits in trunk/WebCore
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[WINCE] Buildfix for FontPlatformData after r65021
https://bugs.webkit.org/show_bug.cgi?id=44467
- platform/graphics/wince/FontPlatformData.h:
- 7:46 AM Changeset in webkit [66223] by
-
- 24 edits4 adds2 deletes in trunk/WebCore
2010-08-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779
At the moment RenderSVGImage inherits from RenderImage, which makes non-SVG compatible
assumptions about repainting, and thus has to be fixed to inherit from RenderSVGModelObject.
This patch moves the CachedImage from RenderImage into a separate class.
The new class contains the common behavior of RenderImage and RenderSVGImage.
An additional patch will remove the inheritance of RenderImage at RenderSVGImage.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): (WebCore::HTMLEmbedElement::attach):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer): (WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::attach):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer):
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::parseMappedAttribute):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::renderImageResource): (WebCore::ImageLoader::updateRenderer):
- loader/ImageLoader.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setImageResource): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::notifyFinished): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::paintIntoRect): (WebCore::RenderImage::minimumReplacedHeight): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
- rendering/RenderImage.h: (WebCore::RenderImage::imageResource): (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::intrinsicSizeChanged): (WebCore::toRenderImage):
- rendering/RenderImageGeneratedContent.cpp: Removed.
- rendering/RenderImageGeneratedContent.h: Removed.
- rendering/RenderImageResource.cpp: Added. (WebCore::RenderImageResource::RenderImageResource): (WebCore::RenderImageResource::~RenderImageResource): (WebCore::RenderImageResource::initialize): (WebCore::RenderImageResource::shutdown): (WebCore::RenderImageResource::setCachedImage): (WebCore::RenderImageResource::resetAnimation): (WebCore::RenderImageResource::setImageContainerSize): (WebCore::RenderImageResource::nullImage):
- rendering/RenderImageResource.h: Added. (WebCore::RenderImageResource::create): (WebCore::RenderImageResource::cachedImage): (WebCore::RenderImageResource::hasImage): (WebCore::RenderImageResource::image): (WebCore::RenderImageResource::errorOccurred): (WebCore::RenderImageResource::usesImageContainerSize): (WebCore::RenderImageResource::imageHasRelativeWidth): (WebCore::RenderImageResource::imageHasRelativeHeight): (WebCore::RenderImageResource::imageSize): (WebCore::RenderImageResource::imagePtr):
- rendering/RenderImageResourceStyleImage.cpp: Added. (WebCore::RenderImageResourceStyleImage::RenderImageResourceStyleImage): (WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): (WebCore::RenderImageResourceStyleImage::initialize): (WebCore::RenderImageResourceStyleImage::shutdown):
- rendering/RenderImageResourceStyleImage.h: Added. (WebCore::RenderImageResourceStyleImage::create): (WebCore::RenderImageResourceStyleImage::image): (WebCore::RenderImageResourceStyleImage::errorOccurred): (WebCore::RenderImageResourceStyleImage::setImageContainerSize): (WebCore::RenderImageResourceStyleImage::usesImageContainerSize): (WebCore::RenderImageResourceStyleImage::imageHasRelativeWidth): (WebCore::RenderImageResourceStyleImage::imageHasRelativeHeight): (WebCore::RenderImageResourceStyleImage::imageSize): (WebCore::RenderImageResourceStyleImage::imagePtr):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::paint):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::calculateIntrinsicSize):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
- wml/WMLImageElement.cpp: (WebCore::WMLImageElement::createRenderer):
- 7:21 AM Changeset in webkit [66222] by
-
- 3 edits in trunk/WebCore
2010-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements panel breaks after calling "Edit as HTML" on <body>
https://bugs.webkit.org/show_bug.cgi?id=44765
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setOuterHTML):
- 7:15 AM Changeset in webkit [66221] by
-
- 2 edits in trunk/WebKit/qt/Api
2010-08-27 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed complementary fix to r66217.
- Api/qwebpage.cpp:
- Api/qwebview.cpp:
- 7:11 AM Changeset in webkit [66220] by
-
- 1 edit3 adds in trunk/WebCore
2010-08-27 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix.
Web Inspector: add audits support to extension API
Byuild fix: added missing files.
https://bugs.webkit.org/show_bug.cgi?id=44518
- inspector/front-end/AuditFormatters.js: Added. (WebInspector.applyFormatters): (WebInspector.AuditFormatters.text): (WebInspector.AuditFormatters.snippet): (WebInspector.AuditFormatters.concat): (WebInspector.AuditFormatters.url):
- inspector/front-end/ExtensionAuditCategory.js: Added. (WebInspector.ExtensionAuditCategory): (WebInspector.ExtensionAuditCategory.prototype.get id): (WebInspector.ExtensionAuditCategory.prototype.get displayName): (WebInspector.ExtensionAuditCategory.prototype.get ruleCount): (WebInspector.ExtensionAuditCategory.prototype.run): (WebInspector.ExtensionAuditCategoryResults): (WebInspector.ExtensionAuditCategoryResults.prototype.get complete): (WebInspector.ExtensionAuditCategoryResults.prototype.cancel): (WebInspector.ExtensionAuditCategoryResults.prototype.addResult): (WebInspector.ExtensionAuditCategoryResults.prototype._addNode): (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
- inspector/front-end/ExtensionCommon.js: Added. (WebInspector.commonExtensionSymbols):
- 7:03 AM Changeset in webkit [66219] by
-
- 2 edits in trunk/WebKit/qt
2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] tst_QWebFrame::hitTestContent() fails on Meego Handset
https://bugs.webkit.org/show_bug.cgi?id=44701
Make the test more robust. The position of the text is not relying
on the size of the fonts anymore.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:57 AM Changeset in webkit [66218] by
-
- 16 edits6 adds1 delete in trunk
2010-08-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add audits support to extension API
Exposed (late) adding of categories from AuditPanel.
Removed indexOfObjectInListSortedByFunction in favor of
insertionIndexForObjectInListSortedByFunction (the former had
weird interface always returning negative numbers and was only used in
the latter).
https://bugs.webkit.org/show_bug.cgi?id=44518
Tests: inspector/extensions-audits-api.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditFormatters.js: Added. (WebInspector.applyFormatters): (WebInspector.AuditFormatters.text): (WebInspector.AuditFormatters.snippet): (WebInspector.AuditFormatters.concat): (WebInspector.AuditFormatters.url):
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype.addCategory.compareCategories): (WebInspector.AuditLauncherView.prototype.addCategory): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/AuditResultView.js: (WebInspector.AuditCategoryResultPane.prototype._appendResult):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype.addCategory): (WebInspector.AuditsPanel.prototype.getCategory): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditCategory.prototype.run):
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._fire): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._dispatch): (WebInspector.injectedExtensionAPI.EventSink): (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.Audits): (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory): (WebInspector.injectedExtensionAPI.AuditCategory.customDispatch): (WebInspector.injectedExtensionAPI.AuditCategory): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.AuditResult): (WebInspector.injectedExtensionAPI.AuditResult.prototype.get Severity): (WebInspector.injectedExtensionAPI.AuditResultImpl): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.addResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.createResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.done): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype._nodeFactory): (WebInspector.injectedExtensionAPI.AuditResultNode): (WebInspector.injectedExtensionAPI.AuditResultNode.prototype.addChild):
- inspector/front-end/ExtensionAuditCategory.js: Added. (WebInspector.ExtensionAuditCategory): (WebInspector.ExtensionAuditCategory.prototype.get id): (WebInspector.ExtensionAuditCategory.prototype.get displayName): (WebInspector.ExtensionAuditCategory.prototype.get ruleCount): (WebInspector.ExtensionAuditCategory.prototype.run): (WebInspector.ExtensionAuditCategoryResults): (WebInspector.ExtensionAuditCategoryResults.prototype.get complete): (WebInspector.ExtensionAuditCategoryResults.prototype.cancel): (WebInspector.ExtensionAuditCategoryResults.prototype.addResult): (WebInspector.ExtensionAuditCategoryResults.prototype._addNode): (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
- inspector/front-end/ExtensionCommon.js: Added. (WebInspector.commonExtensionSymbols):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.startAuditRun): (WebInspector.ExtensionServer.prototype.stopAuditRun): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript): (WebInspector.ExtensionStatus):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js: ():
2010-08-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add audits support to extension API
https://bugs.webkit.org/show_bug.cgi?id=44518
- inspector/audits-panel-functional.html:
- inspector/audits-tests.js: Added. (frontend_collectAuditResults): (frontend_collectTextContent):
- inspector/extensions-api-expected.txt:
- inspector/extensions-audits-api-expected.txt: Added.
- inspector/extensions-audits-api.html: Added.
- inspector/extensions-audits-expected.txt: Added.
- inspector/extensions-audits-tests.js: Added. (extension_runAudits.onMessage): (extension_runAudits): (frontend_runExtensionAudits.onAuditsDone):
- inspector/extensions-audits.html: Added.
- inspector/extensions-expected.txt:
- inspector/resources/audits-script3.js: Removed.
- platform/chromium/test_expectations.txt:
- 6:45 AM Changeset in webkit [66217] by
-
- 3 edits in trunk/WebKit/qt
2010-08-26 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add support for automatically creating new windows in QWebView
https://bugs.webkit.org/show_bug.cgi?id=29847
Improved the documentation of createWindow methods of both QWebView and
QWebPage by mentioning that for any of them be called, QWebSettings'
JavaScriptCanOpenWindows must be set to true.
- Api/qwebpage.cpp:
- Api/qwebview.cpp:
- 6:32 AM Changeset in webkit [66216] by
-
- 17 edits in trunk
2010-08-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/script-tests/database-basics.js: (openSuccess): (setVersionAgain): (checkVersion):
- storage/indexeddb/script-tests/open-cursor.js: (openEmptyCursor): (openCursor):
2010-08-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
- storage/IDBDatabase.h:
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
2010-08-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion):
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::setVersion):
- src/IDBDatabaseProxy.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion):
- src/WebIDBDatabaseImpl.h:
- 6:13 AM Changeset in webkit [66215] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-08-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Remove test expectations for tests that pass
https://bugs.webkit.org/show_bug.cgi?id=44762
- platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt: Copied from LayoutTests/http/tests/inspector/resource-parameters-expected.txt.
- platform/chromium/test_expectations.txt:
- 6:08 AM Changeset in webkit [66214] by
-
- 1 edit1 add in trunk/LayoutTests
2010-08-27 Dirk Schulze <krit@webkit.org>
Unreviewed rebaseline of Qt.
getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197
QtPainterPath does some internal optimizations and this influences the result.
- platform/qt/svg/dom/path-pointAtLength-expected.txt: Added.
- 6:06 AM Changeset in webkit [66213] by
-
- 6 edits in trunk/WebCore
2010-08-26 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use context menu items with checkbox for setting and removing DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44687
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.DOMBreakpointItem):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMBreakpointManager.prototype.findBreakpoint): (WebInspector.DOMBreakpoint.labelForType): (WebInspector.DOMBreakpoint.contextMenuLabelForType):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/inspector.js: (WebInspector.pausedScript):
- 5:34 AM Changeset in webkit [66212] by
-
- 4 edits in trunk/LayoutTests
Not reviewed
Fix GTK, Qt and Win expected results after modifying js-test-pre.js and js-test-post.js
https://bugs.webkit.org/show_bug.cgi?id=44642
These platform-specific expected results were missed in the original patch.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- 5:24 AM Changeset in webkit [66211] by
-
- 2 edits in trunk/WebCore
2010-08-27 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Calls to IndexedDB methods from V8Proxy::didLeaveScriptContext() are missing enable guards
https://bugs.webkit.org/show_bug.cgi?id=44760
No new tests, build fix only.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::didLeaveScriptContext):
- 5:15 AM Changeset in webkit [66210] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip two flakey xssAuditor tests that are being worked on. Hopefully we finally have somewhat green tree again.
- platform/mac/Skipped:
- 5:11 AM Changeset in webkit [66209] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip another test that is problematic, on leopard & sl bots.
- platform/mac/Skipped:
- 5:09 AM Changeset in webkit [66208] by
-
- 3 edits3 adds in trunk
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197
The closepath segment was traversed by the wrong direction. Swap starting point and
end point for closeSubpath.
Test: svg/dom/path-pointAtLength.html
- platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197
Test that path gives back the correct point on a given length for the closepath segment.
- svg/dom/path-pointAtLength-expected.txt: Added.
- svg/dom/path-pointAtLength.html: Added.
- svg/dom/script-tests/path-pointAtLength.js: Added. (pointAtLengthOfPath):
- 5:08 AM Changeset in webkit [66207] by
-
- 2 edits in trunk/WebKitTools
Unreviewed. Add myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 5:07 AM Changeset in webkit [66206] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Turn leopard bot green again (skip more media tests :/)
- platform/mac-leopard/Skipped:
- 5:00 AM Changeset in webkit [66205] by
-
- 3 edits in trunk/JavaScriptCore
2010-08-27 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
Byte alignment issue on MIPS
https://bugs.webkit.org/show_bug.cgi?id=29415
MIPS accesses one byte at a time for now to avoid the help from the
kernel to fix unaligned accesses.
- wtf/text/AtomicString.cpp: (WebCore::equal):
- wtf/text/StringHash.h: (WebCore::StringHash::equal):
- 4:40 AM Changeset in webkit [66204] by
-
- 3 edits6 adds in trunk
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Filter with wrong results on repaint for non-CG platforms
https://bugs.webkit.org/show_bug.cgi?id=44706
The result of SVG Filter is transformed to linearRGB on every repaint.
Transform the result just once, right after creating it.
Test: svg/repaint/filter-repaint.svg
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Filter with wrong results on repaint for non-CG platforms
https://bugs.webkit.org/show_bug.cgi?id=44706
Test that repainting a Filter does not change the result.
- platform/mac/svg/repaint: Added.
- platform/mac/svg/repaint/filter-repaint-expected.checksum: Added.
- platform/mac/svg/repaint/filter-repaint-expected.png: Added.
- platform/mac/svg/repaint/filter-repaint-expected.txt: Added.
- svg/repaint: Added.
- svg/repaint/filter-repaint.svg: Added.
- 4:24 AM Changeset in webkit [66203] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66196.
http://trac.webkit.org/changeset/66196
https://bugs.webkit.org/show_bug.cgi?id=44758
Corresponding test has been rolled back (Requested by yuzo on
#webkit).
- platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Removed.
- platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Removed.
- 4:22 AM Changeset in webkit [66202] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Tor Arne Vestbø.
Fix a couple of typos in comment.
- bytecode/CodeBlock.h:
- 4:15 AM Changeset in webkit [66201] by
-
- 4 edits in trunk/LayoutTests
2010-08-27 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
js-test-post.js is not robust for asynchronous tests
https://bugs.webkit.org/show_bug.cgi?id=44642
This patch moves finishJSTest() to js-test-pre.js to make it available for when an
asynchronous test completes before js-test-post.js has been parsed, and updates
js-test-post.js to handle this case.
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/js/resources/js-test-post.js:
- fast/js/resources/js-test-pre.js: (finishJSTest):
- 4:02 AM Changeset in webkit [66200] by
-
- 3 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Remove trailing whitespace after test name, no need to duplicate the same test in mac/Skipped and mac-leopard/Skipped, oops.
- platform/mac-leopard/Skipped:
- platform/mac/Skipped:
- 3:53 AM Changeset in webkit [66199] by
-
- 3 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Also skip media/video-source-error.html on Leopard, and media/video-zoom-controls.html on SnowLeopard.
It's a pity that numerous of the media tests are skipped since a longer time on these platforms.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- 3:04 AM Changeset in webkit [66198] by
-
- 24 edits in trunk
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController that frontend closes if InspectorController triggered the action.
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
- inspector/front-end/inspector.js: (WebInspector.disconnectFromBackend):
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::disconnectFromBackend):
- src/InspectorFrontendClientImpl.h:
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::closeWindow): (WebKit::InspectorFrontendClient::disconnectFromBackend):
- WebCoreSupport/InspectorClientGtk.h:
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView:]):
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorFrontendClientQt::closeWindow): (WebCore::InspectorFrontendClientQt::disconnectFromBackend): (WebCore::InspectorFrontendClientQt::destroyInspectorView): (WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
- WebCoreSupport/InspectorClientQt.h:
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView):
- WebCoreSupport/WebInspectorClient.h:
- 2:44 AM Changeset in webkit [66197] by
-
- 3 edits3 deletes in trunk
2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66188.
http://trac.webkit.org/changeset/66188
https://bugs.webkit.org/show_bug.cgi?id=44756
"Graphic libraries handle segement length differently. Fixing
one platform might break another one. Rolling out this patch
and think about another solution to get getPointAtLength"
(Requested by krit on #webkit).
- svg/dom/path-pointAtLength-expected.txt: Removed.
- svg/dom/path-pointAtLength.html: Removed.
- svg/dom/script-tests/path-pointAtLength.js: Removed.
2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66188.
http://trac.webkit.org/changeset/66188
https://bugs.webkit.org/show_bug.cgi?id=44756
"Graphic libraries handle segement length differently. Fixing
one platform might break another one. Rolling out this patch
and think about another solution to get getPointAtLength"
(Requested by krit on #webkit).
- platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):
- 2:34 AM Changeset in webkit [66196] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-27 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
- platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Added.
- platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Added.
- 2:26 AM Changeset in webkit [66195] by
-
- 3 edits in trunk/WebCore
2010-08-27 Simon Fraser <Simon Fraser>
Reviewed by Nikolas Zimmermann.
r66141 caused fast/forms/select-style.html to fail on mac:
https://bugs.webkit.org/show_bug.cgi?id=44737
Handle the fact that a CSSImageValue may have a value of CSSValueNone,
in which case we should not return a pending image.
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedOrPendingImage):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::cachedOrPendingFromValue):
- 2:25 AM Changeset in webkit [66194] by
-
- 7 edits in trunk
2010-08-27 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748
- platform/chromium/drt_expectations.txt: Update expectations for the DRT change.
2010-08-27 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748
- DEPS: Update Chromium revision to 57605 to have a webkit_support change.
2010-08-27 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::createClientMessageLoop): Returns a valid WebKitClientMessageLoop instance
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- 2:24 AM Changeset in webkit [66193] by
-
- 1 edit18 adds in trunk/LayoutTests
2010-08-27 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
- 2:21 AM Changeset in webkit [66192] by
-
- 2 edits in trunk/WebCore
2010-08-27 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dan Bernstein.
drawGDIGlyphs checks if the offset is empty incorrectly causing
problems with the shadow
https://bugs.webkit.org/show_bug.cgi?id=44619
Removed the offset empty condition, now we just check if we have
offset or blur.
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- 2:17 AM Changeset in webkit [66191] by
-
- 9 edits in trunk/LayoutTests
2010-08-27 Alejandro G. Castro <alex@igalia.com>
Unreviewed.
Updated test resuls for gtk.
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/fast/css/nested-rounded-corners-expected.txt:
- platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
- platform/gtk/fast/forms/placeholder-stripped-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
- platform/gtk/mathml/presentation/style-expected.txt:
- 2:10 AM Changeset in webkit [66190] by
-
- 2 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip a media test that fails on all mac test bots. Already notified Eric.
- platform/mac/Skipped:
- 1:44 AM Changeset in webkit [66189] by
-
- 4 edits in trunk/LayoutTests
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Landed wrong results, as I still had another local patch in my tree. Fixing.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- 1:20 AM Changeset in webkit [66188] by
-
- 3 edits3 adds in trunk
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197
The closepath segment was traversed by the wrong direction. Swap starting point and
end point for closeSubpath.
Test: svg/dom/path-pointAtLength.html
- platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):
2010-08-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197
Test that path gives back the correct point on a given length for the closepath segment.
- svg/dom/path-pointAtLength-expected.txt: Added.
- svg/dom/path-pointAtLength.html: Added.
- svg/dom/script-tests/path-pointAtLength.js: Added. (pointAtLengthOfPath):
- 1:08 AM Changeset in webkit [66187] by
-
- 3 edits12 adds in trunk
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGLocatable.getScreenCTM ignores scrolling
https://bugs.webkit.org/show_bug.cgi?id=44083
getScreenCTM needs to include the FrameViews scrollOffset in the e/f parameters of the AffineTransform.
Adding three new tests, which cover scrolling & getScreenCTM in large svgs with scrollbars, and with (nested) divs in overflow="scroll" mode.
Tests: svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml
svg/custom/getscreenctm-in-scrollable-div-area.xhtml
svg/custom/getscreenctm-in-scrollable-svg-area.xhtml
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGLocatable.getScreenCTM ignores scrolling
https://bugs.webkit.org/show_bug.cgi?id=44083
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
- svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml: Added.
- svg/custom/getscreenctm-in-scrollable-div-area.xhtml: Added.
- svg/custom/getscreenctm-in-scrollable-svg-area.xhtml: Added.
- 12:36 AM Changeset in webkit [66186] by
-
- 3 edits in trunk/WebCore
2010-08-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
implicitlyStyledElementShouldBeRemovedWhenApplyingStyle, removeHTMLFontStyle, and removeHTMLBidiEmbeddingStyle should be merged
https://bugs.webkit.org/show_bug.cgi?id=44622
Merged shouldRemoveTextDecorationTag, implicitlyStyledElementShouldBeRemovedWhenApplyingStyle, removeHTMLFontStyle,
and removeHTMLBidiEmbeddingStyle into removeImplicitlyStyledElement. New function uses CSSPropertyElementMapping to
support all different cases dealt separately in each function.
No new tests are added since this is a cleanup.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls removeImplicitlyStyledElement. (WebCore::): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added.
- editing/ApplyStyleCommand.h: