Context Navigation

← Previous Period
Next Period →

Timeline

Aug 29, 2010:

11:56 PM Changeset in webkit [66364] by tkent@chromium.org

2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Kent Tamura.

Move more common settings to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44812

WebCore.gyp/WebCore.gyp:

11:54 PM Changeset in webkit [66363] by Darin Adler

4 edits in trunk/JavaScriptCore

Fix Qt build.

wtf/unicode/glib/UnicodeMacrosFromICU.h: Added U_IS_BMP.
wtf/unicode/qt4/UnicodeQt4.h: Ditto.
wtf/unicode/wince/UnicodeWince.h: Ditto.

11:51 PM Changeset in webkit [66362] by Darin Adler

212 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Create SVG and WML elements with create functions instead of direct invocations of new
https://bugs.webkit.org/show_bug.cgi?id=44851

Added the create functions, made some existing constructors protected and private,
made some other member functions protected and and private, added some missing virtual
keywords for clarity to functions that already were overriding virtual functions,
fixed some inconsistent indentation, and removed some unneeded empty destructors.

In the future, it will be good to have the constructors all be private so we don't
use them by accident. Then we'll change the reference count rule globally and add
all the necessary calls to adoptRef.

The SVG changes are compiled and tested. The WML changes are speculative and untested.

dom/make_names.pl: Removed supportfor the createWithNew keyword.
svg/svgtags.in: Removed all the createWithNew keywords.
wml/WMLTagNames.in: Ditto.

svg/SVGAElement.cpp: (WebCore::SVGAElement::create): Added.
svg/SVGAElement.h:
svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::create): Added.
svg/SVGAltGlyphElement.h:
svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::create): Added.
svg/SVGAnimateColorElement.h:
svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::create): Added.
svg/SVGAnimateElement.h:
svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::create): Added.
svg/SVGAnimateMotionElement.h:
svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::create): Added.
svg/SVGAnimateTransformElement.h:
svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::create): Added.
svg/SVGCircleElement.h:
svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::create): Added.
svg/SVGClipPathElement.h:
svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::create): Added.
svg/SVGCursorElement.h:
svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::create): Added.
svg/SVGDefsElement.h:
svg/SVGDescElement.cpp: (WebCore::SVGDescElement::create): Added.
svg/SVGDescElement.h:
svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::create): Added.
svg/SVGEllipseElement.h:
svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::create): Added.
svg/SVGFEBlendElement.h:
svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::create): Added.
svg/SVGFEColorMatrixElement.h:
svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::create): Added.
svg/SVGFEComponentTransferElement.h:
svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::create): Added.
svg/SVGFECompositeElement.h:
svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::create): Added.
svg/SVGFEConvolveMatrixElement.h:
svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::create): Added.
svg/SVGFEDiffuseLightingElement.h:
svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::create): Added.
svg/SVGFEDisplacementMapElement.h:
svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::create): Added.
svg/SVGFEDistantLightElement.h:
svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::create): Added.
svg/SVGFEFloodElement.h:
svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::create): Added.
svg/SVGFEFuncAElement.h:
svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::create): Added.
svg/SVGFEFuncBElement.h:
svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::create): Added.
svg/SVGFEFuncGElement.h:
svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::create): Added.
svg/SVGFEFuncRElement.h:
svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::create): Added.
svg/SVGFEGaussianBlurElement.h:
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::create): Added.
svg/SVGFEImageElement.h:
svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::create): Added.
svg/SVGFEMergeElement.h:
svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::create): Added.
svg/SVGFEMergeNodeElement.h:
svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::create): Added.
svg/SVGFEMorphologyElement.h:
svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::create): Added.
svg/SVGFEOffsetElement.h:
svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::create): Added.
svg/SVGFEPointLightElement.h:
svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::create): Added.
svg/SVGFESpecularLightingElement.h:
svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::create): Added.
svg/SVGFESpotLightElement.h:
svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::create): Added.
svg/SVGFETileElement.h:
svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::create): Added.
svg/SVGFETurbulenceElement.h:
svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::create): Added.
svg/SVGFilterElement.h:
svg/SVGFontElement.cpp: (WebCore::SVGFontElement::create): Added.
svg/SVGFontElement.h:
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::create): Added.
svg/SVGFontFaceElement.h:
svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::create): Added.
svg/SVGFontFaceFormatElement.h:
svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::create): Added.
svg/SVGFontFaceNameElement.h:
svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::create): Added.
svg/SVGFontFaceSrcElement.h:
svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::create): Added.
svg/SVGFontFaceUriElement.h:
svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::create): Added.
svg/SVGForeignObjectElement.h:
svg/SVGGElement.cpp: (WebCore::SVGGElement::create): Added.
svg/SVGGElement.h:
svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::create): Added.
svg/SVGGlyphElement.h:
svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::create): Added.
svg/SVGHKernElement.h:
svg/SVGImageElement.cpp: (WebCore::SVGImageElement::create): Added.
svg/SVGImageElement.h:
svg/SVGLineElement.cpp: (WebCore::SVGLineElement::create): Added.
svg/SVGLineElement.h:
svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::create): Added.
svg/SVGLinearGradientElement.h:
svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::create): Added.
svg/SVGMPathElement.h:
svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::create): Added.
svg/SVGMarkerElement.h:
svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::create): Added.
svg/SVGMaskElement.h:
svg/SVGMetadataElement.cpp: (SVGMetadataElement::create): Added.
svg/SVGMetadataElement.h:
svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::create): Added.
svg/SVGMissingGlyphElement.h:
svg/SVGPathElement.cpp: (WebCore::SVGPathElement::create): Added.
svg/SVGPathElement.h:
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::create): Added.
svg/SVGPatternElement.h:
svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::create): Added.
svg/SVGPolygonElement.h:
svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::create): Added.
svg/SVGPolylineElement.h:
svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::create): Added.
svg/SVGRadialGradientElement.h:
svg/SVGRectElement.cpp: (WebCore::SVGRectElement::create): Added.
svg/SVGRectElement.h:
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::create): Added.
svg/SVGSVGElement.h:
svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::create): Added.
svg/SVGScriptElement.h:
svg/SVGSetElement.cpp: (WebCore::SVGSetElement::create): Added.
svg/SVGSetElement.h:
svg/SVGStopElement.cpp: (WebCore::SVGStopElement::create): Added.
svg/SVGStopElement.h: (WebCore::SVGStyleElement::create): Added.
svg/SVGStyleElement.h:
svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::create): Added.
svg/SVGSwitchElement.h:
svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::create): Added.
svg/SVGSymbolElement.h:
svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::create): Added.
svg/SVGTRefElement.h:
svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::create): Added.
svg/SVGTSpanElement.h:
svg/SVGTextContentElement.h:
svg/SVGTextElement.cpp: (WebCore::SVGTextElement::create): Added.
svg/SVGTextElement.h:
svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::create): Added.
svg/SVGTextPathElement.h:
svg/SVGTextPositioningElement.h:
svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::create): Added.
svg/SVGTitleElement.h:
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::create): Added.
svg/SVGUseElement.h:
svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::create): Added.
svg/SVGVKernElement.h:
svg/SVGViewElement.cpp: (WebCore::SVGViewElement::create): Added.
svg/SVGViewElement.h:
wml/WMLAElement.cpp: (WebCore::WMLAElement::create): Added.
wml/WMLAElement.h:
wml/WMLAccessElement.cpp: (WebCore::WMLAccessElement::create): Added.
wml/WMLAccessElement.h:
wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::create): Added.
wml/WMLAnchorElement.h:
wml/WMLBRElement.cpp: (WebCore::WMLBRElement::create): Added.
wml/WMLBRElement.h:
wml/WMLCardElement.cpp: (WebCore::WMLCardElement::create): Added.
wml/WMLCardElement.h:
wml/WMLDoElement.cpp: (WebCore::WMLDoElement::create): Added.
wml/WMLDoElement.h:
wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::create): Added.
wml/WMLFieldSetElement.h:
wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::create): Added.
wml/WMLGoElement.cpp: (WebCore::WMLGoElement::create): Added.
wml/WMLGoElement.h:
wml/WMLImageElement.cpp: (WebCore::WMLImageElement::create): Added.
wml/WMLImageElement.h:
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::create): Added.
wml/WMLInputElement.h:
wml/WMLInsertedLegendElement.cpp: (WebCore::WMLInsertedLegendElement::create): Added.
wml/WMLInsertedLegendElement.h:
wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::create): Added.
wml/WMLMetaElement.cpp: (WebCore::WMLMetaElement::create): Added.
wml/WMLMetaElement.h:
wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::create): Added.
wml/WMLNoopElement.h:
wml/WMLOnEventElement.cpp: (WebCore::WMLOnEventElement::create): Added.
wml/WMLOnEventElement.h:
wml/WMLOptGroupElement.cpp: (WebCore::WMLOptGroupElement::create): Added.
wml/WMLOptGroupElement.h:
wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::create): Added.
wml/WMLOptionElement.h:
wml/WMLPElement.cpp: (WebCore::WMLPElement::create): Added.
wml/WMLPElement.h:
wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::create): Added.
wml/WMLPostfieldElement.h:
wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::create): Added.
wml/WMLPrevElement.h:
wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::create): Added.
wml/WMLRefreshElement.h:
wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::create): Added.
wml/WMLSelectElement.h:
wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::create): Added.
wml/WMLSetvarElement.h:
wml/WMLTableElement.cpp: (WebCore::WMLTableElement::create): Added.
wml/WMLTableElement.h:
wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::create): Added.
wml/WMLTaskElement.h:
wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::create): Added.
wml/WMLTemplateElement.h:
wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::create): Added.
wml/WMLTimerElement.h:

11:37 PM Changeset in webkit [66361] by tkent@chromium.org

1 edit in trunk/WebCore/ChangeLog

Unreviewed, add missing bug URL for the last my commit.

11:31 PM Changeset in webkit [66360] by tkent@chromium.org

2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Kent Tamura.

Rename webcore to 'webcore_remaining'.
Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore

Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.

WebCore.gyp/WebCore.gyp:

11:31 PM Changeset in webkit [66359] by abarth@webkit.org

8 edits in trunk

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move UTF16 LEAD/TRAIL logic into the HTMLEntityParser
https://bugs.webkit.org/show_bug.cgi?id=44790

We now block this attack.

http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:

11:12 PM Changeset in webkit [66358] by jeremy@chromium.org

5 edits
2 moves in trunk/WebCore

2010-08-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa

https://bugs.webkit.org/show_bug.cgi?id=41398

Just moving files around so no new tests.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
platform/graphics/mac/FontPlatformData.h: Removed.
platform/graphics/mac/FontPlatformDataMac.mm: Removed.

10:11 PM Changeset in webkit [66357] by tkent@chromium.org

11 edits in trunk

Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=43537

Reviewed by Darin Adler.

WebCore:

isValidValue() is useful for browser implementations to propose
form field values without breaking form validity.
No new tests because these functions are not exposed to JavaScript.

html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::):

Remove virtual valueMissing(), patternMismatch(), and tooLong().

html/HTMLInputElement.cpp:

(WebCore::isValidColorString): Moved from ValidityState.
(WebCore::isValidEmailAddress): ditto.
(WebCore::HTMLInputElement::isValidValue): Added.
(WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
(WebCore::HTMLInputElement::valueMissing): Add a String parameter.
(WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
(WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
(WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
(WebCore::HTMLInputElement::stepMismatch): Add a String parameter.

html/HTMLInputElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLTextAreaElement::isValidValue): Added.

html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing):

html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
(WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
(WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().

html/ValidityState.h:

WebKit/chromium:

public/WebInputElement.h:
src/WebInputElement.cpp:

(WebKit::WebInputElement::isValidValue):

9:55 PM Changeset in webkit [66356] by yuzo@google.com

1 edit
1 add in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66282.

platform/chromium-win/inspector/console-format-expected.txt: Added.

9:47 PM Changeset in webkit [66355] by tkent@chromium.org

36 edits in trunk

Change lower and higher limits of date/datetime/datetime-local/month/week types
https://bugs.webkit.org/show_bug.cgi?id=39737

Reviewed by Darin Adler.

WebCore:

According to the latest draft of HTML5, ISO-8601 dates in HTML5
should support A.D.0001 in Gregorian calendar though Gregorian
calendar started in 1582. So, we change the lower limits of
date&time types to 0001-01-01T00:00.

We also introduce the common higher limit, 275760-09-13T00:00. It
is the higher limit of Date type of ECMAScript.

html/DateComponents.cpp:

(WebCore::DateComponents::parseYear):

Rejects years less than A.D.1 and years greater than 275760.

(WebCore::withinHTMLDateLimits):

Helper functions to check lower and higher limits.

(WebCore::DateComponents::addDay):

Remove an overflow check. 'year' can't be so large number because parseYear() rejects such numbers.
Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::addMinute):

Add an assertion for the base date.
Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::parseMonth):

Add withinHTMLDateLimits() call.

(WebCore::DateComponents::parseDate): ditto.
(WebCore::DateComponents::parseWeek): ditto.
(WebCore::DateComponents::parseDateTimeLocal): ditto.
(WebCore::DateComponents::parseDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDate): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth): ditto.
(WebCore::DateComponents::setMonthsSinceEpoch):

Add year range check and withinHTMLDateLimits() call.

(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

Add year range check and week range check.

html/DateComponents.h: Update minimum/maximum constant values.

(WebCore::DateComponents::minimumDate):
(WebCore::DateComponents::minimumDateTime):
(WebCore::DateComponents::minimumMonth):
(WebCore::DateComponents::minimumWeek):
(WebCore::DateComponents::maximumDate):
(WebCore::DateComponents::maximumDateTime):
(WebCore::DateComponents::maximumMonth):
(WebCore::DateComponents::maximumWeek):

LayoutTests:

Update tests and test results for the new DateComponents behavior.

fast/forms/ValidityState-rangeOverflow-expected.txt:
fast/forms/ValidityState-stepMismatch-expected.txt:
fast/forms/ValidityState-typeMismatch-date-expected.txt:
fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
fast/forms/ValidityState-typeMismatch-month-expected.txt:
fast/forms/ValidityState-typeMismatch-week-expected.txt:
fast/forms/input-valueasdate-date-expected.txt:
fast/forms/input-valueasdate-datetime-expected.txt:
fast/forms/input-valueasdate-month-expected.txt:
fast/forms/input-valueasdate-week-expected.txt:
fast/forms/input-valueasnumber-date-expected.txt:
fast/forms/input-valueasnumber-datetime-expected.txt:
fast/forms/input-valueasnumber-datetimelocal-expected.txt:
fast/forms/input-valueasnumber-month-expected.txt:
fast/forms/input-valueasnumber-week-expected.txt:
fast/forms/script-tests/ValidityState-rangeOverflow.js:
fast/forms/script-tests/ValidityState-stepMismatch.js:
fast/forms/script-tests/ValidityState-typeMismatch-date.js:
fast/forms/script-tests/ValidityState-typeMismatch-datetime.js:
fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js:
fast/forms/script-tests/ValidityState-typeMismatch-month.js:
fast/forms/script-tests/ValidityState-typeMismatch-week.js:
fast/forms/script-tests/input-valueasdate-date.js:
fast/forms/script-tests/input-valueasdate-datetime.js:
fast/forms/script-tests/input-valueasdate-month.js:
fast/forms/script-tests/input-valueasdate-week.js:
fast/forms/script-tests/input-valueasnumber-date.js:
fast/forms/script-tests/input-valueasnumber-datetime.js:
fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
fast/forms/script-tests/input-valueasnumber-month.js:
fast/forms/script-tests/input-valueasnumber-week.js:

9:38 PM Changeset in webkit [66354] by yuzo@google.com

2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66296.

platform/chromium/test_expectations.txt:

9:25 PM Changeset in webkit [66353] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-08-29 James Robinson <jamesr@chromium.org>

Reviewed by David Levin.

Make failing the download step fail the build
https://bugs.webkit.org/show_bug.cgi?id=44298

If the download step fails on a test bot, this ensures that
the build goes red instead of only the download step going red
and the overall build staying green.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

9:16 PM Changeset in webkit [66352] by yuzo@google.com

2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

platform/chromium/test_expectations.txt:

9:07 PM Changeset in webkit [66351] by tkent@chromium.org

4 edits in trunk

2010-08-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847

DEPS: Roll Chromium revision to 57823 to have a webkit_support change.

2010-08-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847

DumpRenderTree/chromium/EventSender.cpp: Use webkit_support::VKEY_* instead of base::VKEY_*.

8:26 PM Changeset in webkit [66350] by Darin Adler

2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=40589

Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty

function names.

7:41 PM Changeset in webkit [66349] by yuzo@google.com

62 edits
11 copies
6 adds
19 deletes in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66306.

platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Added.
platform/chromium-linux/fast/forms/formmove3-expected.checksum:
platform/chromium-linux/fast/forms/formmove3-expected.png:
platform/chromium-linux/fast/forms/formmove3-expected.txt:
platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Added.
platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Added.
platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Added.
platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Added.
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/chromium-mac/fast/forms/formmove3-expected.checksum: Removed.
platform/chromium-mac/fast/forms/formmove3-expected.png: Removed.
platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Added.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
platform/chromium-win/fast/forms/form-added-to-table-expected.txt:
platform/chromium-win/fast/forms/formmove3-expected.checksum:
platform/chromium-win/fast/forms/formmove3-expected.png:
platform/chromium-win/fast/forms/formmove3-expected.txt:
platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt:
platform/chromium-win/fast/table/inline-form-assert-expected.txt:
platform/chromium-win/fast/table/insert-cell-before-form-expected.txt:
platform/chromium-win/fast/table/insert-row-before-form-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum:
platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/chromium/test_expectations.txt:

7:06 PM Changeset in webkit [66348] by commit-queue@webkit.org

1 edit
1 add in trunk/WebCore

2010-08-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=34412

Implement SharedBuffer::createWithContentsOfFile with IFile.

platform/brew/SharedBufferBrew.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):

6:54 PM Changeset in webkit [66347] by zecke@webkit.org

4 edits in trunk/WebKitTools

[iExploder] Add new CSS Properties and HTML Attributes

https://bugs.webkit.org/show_bug.cgi?id=44746

Updated the files with the update-iexploder-cssproperties script
and manually readded the -webkit-binding CSS Property to the list.

iExploder/htdocs/cssproperties.in:
iExploder/htdocs/htmlattrs.in:
iExploder/htdocs/htmltags.in:

6:53 PM Changeset in webkit [66346] by zecke@webkit.org

3 edits in trunk/WebKitTools

Fix Coverage build after the addition of ANGLE

https://bugs.webkit.org/show_bug.cgi?id=44744

ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.

This is achieved by applying the XCode options for each project
separately and exclude ANGLE.

Scripts/build-webkit: Remove -framework AppKit due link errors.
Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.

6:46 PM Changeset in webkit [66345] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-08-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port vprintf_stderr_common
https://bugs.webkit.org/show_bug.cgi?id=33568

Use BREW's DBGPRINTF to output debug messages.

wtf/Assertions.cpp:

6:31 PM Changeset in webkit [66344] by enrica@apple.com

5 edits in trunk

WebCore: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

This fixes the crash but also fixes the generated markup when
performing a replacement at the border with an inline, to avoid the
new content being merged into the inline.
The crash is happening when doApply detects the need of merging
the start and the end of the new paragraph and the destination position
is moved inside an inline.

I've added new test cases to an existing layout test.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): When the situation described above is detected,
we insert a placeholder to avoid merging into the inline.

LayoutTests: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

Added new test cases to an exisisting file and updated the result to reflect
the correct behavior.

editing/selection/replace-selection-crash-expected.txt:
editing/selection/replace-selection-crash.html:

6:16 PM Changeset in webkit [66343] by abarth@webkit.org

4 edits in trunk

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000

Update expectations for this pasteboard test to include our new friend
fakepath.

editing/pasteboard/file-input-files-access-expected.txt:

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000

The HTML 5 spec says to prepend C:\fakepath\ to the value of an
<input type="file"> control, so that's what we do now.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value):

5:36 PM Changeset in webkit [66342] by commit-queue@webkit.org

3 edits
2 moves in trunk/WebCore

2010-08-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66329.
http://trac.webkit.org/changeset/66329
https://bugs.webkit.org/show_bug.cgi?id=44845

broke chromium mac (Requested by jamesr on #webkit).

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/mac/FontPlatformData.h: Renamed from WebCore/platform/graphics/cocoa/FontPlatformData.h. (WebCore::toCTFontRef): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::isColorBitmapFont): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::hashTableDeletedFontValue):
platform/graphics/mac/FontPlatformDataMac.mm: Renamed from WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm. (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::ctFont): (WebCore::FontPlatformData::description):

5:10 PM Changeset in webkit [66341] by abarth@webkit.org

2 edits in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Attempt to make Sam's life easier by not opening a comment text field
if there's a selection. This should make it easier to copy/paste text
out of the diff without accidentally opening comment boxes.

code-review.js:

4:56 PM Changeset in webkit [66340] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-08-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

fast/loader/input-element-page-cache-crash.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44811

Make test not rely on page cache behavior (window.finishTest being
persisted), instead use sessionStorage.

fast/loader/input-element-page-cache-crash.html:
platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [66339] by Simon Fraser

12 edits
6 adds in trunk

2010-08-29 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794

When a property does not appear in all keyframes of a keyframe animation, we currently use the
value of that property from the unanimated style. That forces the author to use additional
keyframes for properties that need to "skip a keyframe", which is laborious.

With this change, properties are interpolated between the keyframes in which they appear.
This is equivalent to splitting each property out into its own set of keyframes.

Tests: animations/missing-keyframe-properties-repeating.html

animations/missing-keyframe-properties-timing-function.html
animations/missing-keyframe-properties.html

css/CSSStyleSelector.h:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForKeyframe): Pass a KeyframeValue in so that we can collect which properties are represented per keyframe. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Keyframes are inserted into a KeyframeList by object now, rather than by key and style.

page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): Use AnimationDirectionAlternate for readability.

page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Renamed from getKeyframeAnimationInterval. Use fractionalTime etc to match AnimationBase::progress(), and do lookups per-property. Simplify the code that finds the relevant keyframe to do less work. (WebCore::KeyframeAnimation::animate): Call fetchIntervalEndpointsForProperty() for each property, rather than just once for the entire keyframe. (WebCore::KeyframeAnimation::getAnimatedStyle): Ditto. (WebCore::KeyframeAnimation::hasAnimationForProperty): FIXME comment.

page/animation/KeyframeAnimation.h: Rename getKeyframeAnimationInterval() to fetchIntervalEndpointsForProperty().

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): For hardware animations, only insert values for keyframes which contain the property.

(WebCore::KeyframeList::KeyframeList): insert() takes a KeyframeValue now.

rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::operator==): (WebCore::KeyframeList::insert): Fix insert/replace logic, and ensure we maintain the m_properties hash.

rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): Make members private, with accessors. Add a m_properties HashSet for the properties animated in this keyframe.

3:09 PM Changeset in webkit [66338] by Csaba Osztrogonác

2 edits in trunk/WebCore

2010-08-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=44843

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within

2:28 PM Changeset in webkit [66337] by Darin Adler

2 edits in trunk/WebCore

Try to fix Mac build.

WebCore.xcodeproj/project.pbxproj: Mark CounterContent.h Private instead of Project.

1:46 PM Changeset in webkit [66336] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-29 Pawel Hajdan <phajdan.jr@chromium.org>

Reviewed by Darin Adler.

Fix libxml workarounds to work with recent versions of libxml.
I was testing locally with libxml2-2.7.6.
https://bugs.webkit.org/show_bug.cgi?id=30508

Based on patch by Philippe Normand <pnormand@igalia.com>.

This also fixes a Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=29333

dom/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::startDocumentHandler):

1:41 PM Changeset in webkit [66335] by Darin Adler

5 edits in trunk/WebCore

Try to fix Windows build.

rendering/style/ContentData.h: Added include of CounterContent.h.

css/CSSStyleSelector.cpp: Removed include of CounterContent.h.
rendering/style/ContentData.cpp: Ditto.
rendering/style/RenderStyle.cpp: Ditto.

12:56 PM Changeset in webkit [66334] by Darin Adler

23 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Deploy OwnPtr, PassOwnPtr, and adoptPtr in some CSS-related files
https://bugs.webkit.org/show_bug.cgi?id=44834

css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::CSSFunctionValue): Updated since CSSParserFunction::args is an OwnPtr. (WebCore::CSSFunctionValue::parserValue): Ditto.

css/CSSGrammar.y: Added leakPtr calls for putting MediaQueryExp* into the media query expression list, which is a vector of raw pointers that are deleted explicitly.

css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Updated to use document instead of doc. (WebCore::CSSImportRule::insertedIntoParent): Ditto.
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Ditto.

css/CSSNamespace.h: Took the "m_" off the names of the data members of this structure. Used OwnPtr for the parent data member. Rewrote the namespaceForPrefix function so it's iterative instead of recursive.

css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Update since m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList are now all OwnPtr and thus don't need to be initialized. (WebCore::CSSParser::~CSSParser): Update to not delete the above OwnPtr. (WebCore::CSSParser::parseMediaQuery): Replaced the code that sets m_mediaQuery to 0 with an assertion. Also use release when passing the media query to appendMediaQuery. (WebCore::CSSParser::document): Updated to use document instead of doc and to use early return instead of a nested if. (WebCore::CSSParser::parseContent): Added a get() call needed since CSSParserFunction::args is an OwnPtr. (WebCore::CSSParser::parseAnimationTimingFunction): Ditto. (WebCore::CSSParser::parseDashboardRegions): Ditto. (WebCore::CSSParser::parseShape): Ditto. (WebCore::isValidFormatFunction): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseColorParameters): Ditto. (WebCore::CSSParser::parseHSLParameters): Ditto. (WebCore::parseGradientColorStop): Ditto. (WebCore::CSSParser::parseGradient): Ditto. (WebCore::CSSParser::parseCanvas): Ditto. (WebCore::CSSParser::parseTransform): Ditto. (WebCore::CSSParser::createFloatingMediaQueryExp): Updated to use adoptPtr and remove the explicit deletion. (WebCore::CSSParser::sinkFloatingMediaQueryExp): Updated to use release. (WebCore::CSSParser::createFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::sinkFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::createFloatingMediaQuery): Ditto. (WebCore::CSSParser::sinkFloatingMediaQuery): Ditto. (WebCore::CSSParser::checkForVariables): Use get for CSSParserFunction::args.

css/CSSParser.h: Made return values for sinkFloatingMediaQueryExp, sinkFloatingMediaQueryExpList, and sinkFloatingMediaQuery be PassOwnPtr. Made createFloatingMediaQuery take a PassOwnPtr. Made m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList be OwnPtr.

css/CSSParserValues.h: Made args be an OwnPtr.

css/CSSStyleSelector.cpp: Made CSSRuleSet m_universalRules and m_pageRules be OwnPtr. (WebCore::CSSStyleSelector::CSSStyleSelector): Use document instead of doc. Got rid of the init function, only called here, because it did nothing that wasn't already done. Eliminated unneeded code to set m_userStyle to 0, since it's now an OwnPtr and will be 0 automatically. Use adoptPtr when initializing m_medium, m_authorStyle, and m_useStyle. (WebCore::CSSStyleSelector::~CSSStyleSelector): Got rid of unneeded delete of m_medium, m_authorStyle, and m_userStyle, and unneded clear of m_keyframesRuleMap. (WebCore::CSSStyleSelector::styleForElement): Use get with m_userStyle and m_authorStyle. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleForPage): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto. (WebCore::CSSRuleSet::CSSRuleSet): Got rid of unneeded initialization of m_universalRules and m_pageRules. (WebCore::CSSRuleSet::~CSSRuleSet): Got rid of unneeed deletion of same. (WebCore::CSSRuleSet::addRule): Use adoptPtr to initialize m_universalRules. (WebCore::CSSRuleSet::addPageRule): Use adoptPtr to initialize m_pageRules. (WebCore::CSSStyleSelector::applyProperty): Use adopPtr to create counter context object.

css/CSSStyleSelector.h: Made m_authorStyle, m_userStyle, and m_medium use OwnPtr. Got rid of init function.

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): Updatd for name change from m_doc and doc to m_document and document. Eliminated unneeded initialization of m_namespaces now that it is an OwnPtr. (WebCore::CSSStyleSheet::~CSSStyleSheet): Got rid of unneeded deletion of same. (WebCore::CSSStyleSheet::cssRules): Updated doc to document. (WebCore::CSSStyleSheet::addNamespace): Added adopPtr when setting m_namespaces. (WebCore::CSSStyleSheet::determineNamespace): Updated for changes to the CSSNamespace class, using uri data member instead of function. (WebCore::CSSStyleSheet::styleSheetChanged): Use document instead of doc.

css/CSSStyleSheet.h: Renamed doc and m_doc to document and m_document. Made m_namespaces an OwnPtr.

css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): Clean up logic a bit. (WebCore::CSSValueList::createParserValueList): Clean up logic a bit and return a PassOwnPtr.

css/CSSValueList.h: Changed createParserValueList to return a PassOwnPtr.

css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): Updated to use document instead of doc.

css/MediaList.cpp: (WebCore::MediaList::deleteMedium): Use OwnPtr instead of a boolean to make sure the newly-created query here is deleted. (WebCore::MediaList::appendMediaQuery): Updated to take PassOwnPtr.

css/MediaList.h: Changed appendMediaQuery to take a PassOwnPtr.

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSheet): Use document instead of doc. (WebCore::InspectorDOMAgent::getRuleRanges): Ditto. (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): Ditto.

rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Update since data members are OwnPtr. Also, fixed iterative deletion algorithm to be much simpler. (WebCore::ContentData::dataEquivalent): Added FIXMEs and tweaked formatting. (WebCore::ContentData::deleteContent): Tweaked formatting.

rendering/style/ContentData.h: Changed m_next to an OwnPtr. Added assertions to getters to check that we get the correct type. Use leakRef instead of releaseRef. Changed setCounter and setNext functions to take PassOwnPtr arguments.

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::prepareToSetContent): Refactored common part of the into a shared function so the three setContent functions don't have to repeat the logic. Used an OwnPtr to avoid confusing logic and leakPtr. (WebCore::RenderStyle::setContent): Changed argument to PassOwnPtr.

rendering/style/RenderStyle.h: Changed setContent argument to a PassOwnPtr. Added declaration of prepareToSetContent helper function.

11:04 AM Changeset in webkit [66333] by abarth@webkit.org

2 edits in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Turns out we're supposed to use find instead of children here.

code-review.js:

10:59 AM Changeset in webkit [66332] by abarth@webkit.org

2 edits
1 add
1 delete in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Awesomify pretty-diff based review tool
https://bugs.webkit.org/show_bug.cgi?id=44835

This patch replaces the existing inline comment feature with a new
implementation. Hopefully the new implementation is more awesome.
It's not 100% done yet, but I'd like to get this version out there to
see how it works.

Unlike the previous version this version works with the "Formatted
Diff" link instead of the "Review Patch" link. Hopefully that will
avoid interfering with folks who like the old style review.

PrettyPatch/PrettyPatch.rb:
code-review.js: Added.
prototype.js: Removed.

7:12 AM Changeset in webkit [66331] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port ScrollbarThemeWin to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44818

Add a #ifdef around usage of unsupported DFCS_FLAT.

platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintButton):

6:55 AM Changeset in webkit [66330] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port SystemInfo to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44817

platform/win/SystemInfo.cpp: (WebCore::isRunningOnVistaOrLater):

Aug 28, 2010:

11:45 PM Changeset in webkit [66329] by jeremy@chromium.org

3 edits
2 moves
1 add in trunk/WebCore

2010-08-28 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa

https://bugs.webkit.org/show_bug.cgi?id=41398

Just moving files around so no new tests.

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/cocoa: Added.
platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
platform/graphics/mac/FontPlatformData.h: Removed.
platform/graphics/mac/FontPlatformDataMac.mm: Removed.

10:52 PM Changeset in webkit [66328] by Darin Adler

1 edit in trunk/LayoutTests/dom/xhtml/level2/html/button03.js

Checked in a file missed when I landed just now.

10:48 PM Changeset in webkit [66327] by Darin Adler

46 edits
1 copy
5 adds in trunk

Some IDL attributes don't reflect URL content attributes properly
https://bugs.webkit.org/show_bug.cgi?id=43650

Reviewed by Sam Weinig.

WebCore:

dom/Document.cpp:

(WebCore::Document::processBaseElement): Added. Implements the rules for base elements
from the HTML5 specification. Handles multiple base elements in the same document.

dom/Document.h: Removed setBaseElementURL and setBaseElementTarget, replacing them

with processBaseElement.

html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::parseMappedAttribute): Call the new processBaseElement
function.
(WebCore::HTMLBaseElement::insertedIntoDocument): Ditto.
(WebCore::HTMLBaseElement::removedFromDocument): Ditto.
(WebCore::HTMLBaseElement::isURLAttribute): Added.
(WebCore::HTMLBaseElement::target): Moved here from the .h file and changed to not
realy on an m_target local variable.

html/HTMLBaseElement.h: Added an override of the isURLAttribute function. Removed

unneeded process function. Removed declaration of nonexistent setHref and setTarget
functions. Removed unneeded m_hrefAttrValue, m_href, and m_target. Moved
implementation of target function into the .cpp file.

html/HTMLBaseElement.idl: Marked the href attribute as URL.

html/HTMLBlockquoteElement.cpp:

(WebCore::HTMLBlockquoteElement::isURLAttribute): Added.

html/HTMLBlockquoteElement.h: Added isURLAttribute.
html/HTMLBlockquoteElement.idl: Marked the cite attribute as URL.

html/HTMLEmbedElement.idl: Marked the src attribute as URL.

html/HTMLFormElement.cpp: Added a comment about the action function, which should

be removed.

html/HTMLFormElement.idl: Marked the action attribute as URL.

html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute): Added.
(WebCore::HTMLHtmlElement::insertedIntoDocument): Tweaked a bit.

html/HTMLHtmlElement.h: Added isURLAttribute.
html/HTMLHtmlElement.idl: Marked the manifest attribute as URL.

html/HTMLIFrameElement.idl: Marked the src attribute a URL.

html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute): Added.

html/HTMLModElement.h: Added isURLAttribute.
html/HTMLModElement.idl: Marked the cite attribute as URL.

html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute): Added.

html/HTMLQuoteElement.h: Added isURLAttribute.
html/HTMLQuoteElement.idl: Marked the cite attribute as URL.

html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken): Changed code to create a base
element instead of calling setBaseElementURL directly.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use AtomicString instead of String.
(WebCore::HTMLViewSourceDocument::addLine): Ditto.
(WebCore::HTMLViewSourceDocument::addText): Ditto.
(WebCore::HTMLViewSourceDocument::addBase): Added. Creates a base element and inserts it.
(WebCore::HTMLViewSourceDocument::addLink): Use AtomicString instead of String.

html/HTMLViewSourceDocument.h: Updated function declarations as above.

bindings/scripts/test/CPP/WebDOMTestCallback.h:
bindings/scripts/test/CPP/WebDOMTestInterface.h:
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated results, which changed due to the fixes for at
least these bugs, and perhaps a few more:
https://bugs.webkit.org/show_bug.cgi?id=42115
https://bugs.webkit.org/show_bug.cgi?id=44597
https://bugs.webkit.org/show_bug.cgi?id=44738

bindings/scripts/test/TestObj.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFormElement.cpp:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMediaElement.idl:
html/HTMLObjectElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSourceElement.idl:
html/HTMLVideoElement.idl:

Tweaked formatting.

LayoutTests:

dom/html/level2/html/button03.js: Added a "WebKit modification" section so this

correctly expects the action attribute to return a completed URL.

dom/xhtml/level2/html/button03.js: Ditto.

fast/dom/URL-attribute-reflection-expected.txt: Updaed expected results to expecte

more successes.

fast/dom/script-tests/URL-attribute-reflection.js:

(testURLReflection): Fixed wrong variable name in the test script.

http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Removed a call

to encodeURI that was needed to work around our incorrect implementation of
HTMLIFrameElement's src attribute.

fast/dom/HTMLBaseElement: Added.
fast/dom/HTMLBaseElement/multiple-base-elements-expected.txt: Added.
fast/dom/HTMLBaseElement/multiple-base-elements.html: Added.
fast/dom/HTMLBaseElement/script-tests: Added.
fast/dom/HTMLBaseElement/script-tests/TEMPLATE.html:

Copied from fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html.

fast/dom/HTMLBaseElement/script-tests/multiple-base-elements.js: Added.

10:11 PM Changeset in webkit [66326] by rniwa@webkit.org

2 edits in trunk/WebCore

2010-08-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

The logic to escape entities in appendEscapedContent and appendAttributeValue should be merged
https://bugs.webkit.org/show_bug.cgi?id=44831

Added appendCharactersReplacingEntities to escape &, <, >, ", and nbsp based on the mask.
Removed escapeContentText because it was only used in appendText, which now directly calls
appendCharactersReplacingEntities. Replaced appendEscapedContent, ucharRange, and appendUCharRange
by appendNodeValue.

No new tests are added since this is a cleanup.

editing/markup.cpp: (WebCore::): (WebCore::appendCharactersReplacingEntities): Added. (WebCore::MarkupAccumulator::appendAttributeValue): Calls appendCharactersReplacingEntities. (WebCore::MarkupAccumulator::appendNodeValue): Added. (WebCore::MarkupAccumulator::appendText): Calls appendNodeValue and appendCharactersReplacingEntities. (WebCore::urlToMarkup): Calls escapeEntities.

9:50 PM Changeset in webkit [66325] by weinig@apple.com

2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

platform/mac-wk2/Skipped:

9:38 PM Changeset in webkit [66324] by rniwa@webkit.org

5 edits
3 adds in trunk

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560

The bug was caused by WebKit not pushing down implicitly added styles to descendent nodes.
Fixed the bug by pushing down all elements that implicitly add style.

extractInlineStyleToPushDown now calls removeImplicitlyStyledElement, which was modified to extract
the style implicitly added by the element to extractStyle.

This revealed a bug in applyInlineStyleToPushDown where applyInlineStyleIfNeeded could add
an implicitly styled element inside an element with a conflicting style, thereby overriding the style of the element.
Fixed this by extending the logic to honor the existing inline style declaration used in
the case of rewriting inline style declaration to all cases including the one calling addInlineStyleIfNeeded.

Also fixed a bug in removeInlineStyle where pushDownInlineStyleAroundNode was called on a text node
outside of selection if start was at the end of the text node.

Test: editing/style/push-down-implicit-styles.html

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added extractedStyle, which receives the style implicitly added by the element being removed. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Calls removeImplicitlyStyledElement to remove the implicitly styled element and extract the inline style added by the element. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Fixed a bug that addInlineStyleIfNeeded could override the inline style declaration style of the node. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Uses extractInlineStyleToPushDown (WebCore::ApplyStyleCommand::removeInlineStyle): See above.
editing/ApplyStyleCommand.h: Prototype changes.

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560

Added a test to ensure WebKit removes text-decorations added by u or s
and pushes down implicit styles properly into descendent nodes.

editing/style/push-down-implicit-styles-expected.txt: Added.
editing/style/push-down-implicit-styles.html: Added.
editing/style/script-tests/push-down-implicit-styles.js: Added. (testSingleToggle): (selectAll): (selectTest): (selectSecondWord): (selectLastTwoWords):
editing/style/typing-style-003-expected.txt: Negation of inline styles are now done by pushing down implicitly styled elements rather than canceling them by inline style declarations.

8:45 PM Changeset in webkit [66323] by Darin Adler

4 edits in trunk/WebKit/mac

Make an internal method used by Apple Mail into SPI
https://bugs.webkit.org/show_bug.cgi?id=44832
rdar://problem/5748951

Reviewed by Sam Weinig.

WebView/WebFrame.mm:

(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
from the internal section to the private section.

WebView/WebFrameInternal.h: Moved the method declaration out of here.
WebView/WebFramePrivate.h: Moved the method declaration in here.

8:31 PM Changeset in webkit [66322] by jianli@chromium.org

3 edits in trunk/WebKit/chromium

[chromium] Add webkit_support.gyp:blob to WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=44829

Reviewed by Darin Fisher.

Also bump up chromium revision in DEPS in order to pick up
the revision that contains blob change.

DEPS:
WebKit.gyp:

8:15 PM Changeset in webkit [66321] by mrowe@apple.com

5 edits in tags/Safari-534.6.2

Versioning.

8:15 PM Changeset in webkit [66320] by mrowe@apple.com

8 edits
1 move
1 add
1 delete in tags/Safari-534.6.2

Merge r66319.

7:34 PM Changeset in webkit [66319] by mrowe@apple.com

9 edits
1 move
1 add
1 delete in trunk

<http://webkit.org/b/44802> REGRESSION (r65351): WebCore build fails due to attempting to directly access WebKitTools/Scripts

Reviewed by Adam Barth.

Move create-html-entity-table in to WebCore so that the build is again self-contained.
The script is also updated to take input as a CSV file rather than JSON as the former
can be parsed without requiring a third-party Python module be installed.

cmake/WebKitMacros.cmake:

WebCore:

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
WebCore.gyp/WebCore.gyp:
WebCore.pri:
WebCore.xcodeproj/project.pbxproj: Stop copying the input file in to the WebCore framework wrapper.
html/parser/HTMLEntityNames.in: Added.
html/parser/HTMLEntityNames.json: Removed.
html/parser/create-html-entity-table: Renamed from WebKitTools/Scripts/create-html-entity-table.

6:57 PM Changeset in webkit [66318] by barraclough@apple.com

17 edits in trunk

Bug 44830 - In Array's prototype functyions we're incorrectly handing large index values

Reviewed by Oliver Hunt.

We are in places casting doubles to unsigneds, and unsigneds to ints, without always check
that the result is within bounds. This is problematic in the case of double-to-unsigned
conversion because we should be saturating to array length.

Also, the error return value from Array.splice should be [], not undefined.

I don't see any security concerns here. These methods are spec'ed in such a way that they
can be applied to non Array objects, so in all cases the (potentially bogus) indices are
being passed to functions that will safely check accesses are within bounds.

JavaScriptCore:

runtime/ArrayPrototype.cpp:

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

runtime/JSValue.h:

(JSC::JSValue::toUInt32):

LayoutTests:

fast/js/array-splice-expected.txt:
fast/js/script-tests/array-splice.js:
fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.10_Array_prototype_slice/S15.4.4.10_A3_T3-expected.txt:
fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.2_T3-expected.txt:
fast/js/sputnik/Implementation_Diagnostics/S15.4.4.12_D1.5_T1-expected.txt:
ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
platform/mac-snowleopard/Skipped:

5:30 PM Changeset in webkit [66317] by dbates@webkit.org

2 edits in trunk/WebCore

2010-08-28 Daniel Bates <dbates@rim.com>

Attempt to fix Chromium Mac Release bot after changeset 66305 <http://trac.webkit.org/changeset/66305>.

accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): Added case statements for missing enum values. These case statements simply fall through to a "break" statement.

4:06 PM Changeset in webkit [66316] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

Add explicit destructor for C++ DOM bindings to avoid memory leaks when using SWIG.
https://bugs.webkit.org/attachment.cgi?bugid=44738

4:01 PM Changeset in webkit [66315] by kevino@webkit.org

2 edits in trunk

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645

3:11 PM Changeset in webkit [66314] by kevino@webkit.org

7 edits in trunk

[wx] Build fix after parseMode -> compatibilityMode rename.

1:10 PM Changeset in webkit [66313] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Add WebM MIME types to type registry
https://bugs.webkit.org/show_bug.cgi?id=44826

platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add "video/webm" and "audio/webm" types.

12:34 PM Changeset in webkit [66312] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-08-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

fast/frames/frame-crash-with-page-cache.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44813

Update test to not rely on intervals resuming when going back to a page
in the page cache. Based on the original bug for which this test was
added (34773), intervals were not part of the triggering condition.

fast/frames/resources/cached-page-1.html:
fast/frames/resources/cached-page-2.html:
platform/chromium/test_expectations.txt:

11:48 AM Changeset in webkit [66311] by eric.carlson@apple.com

5 edits in trunk

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::asyncEventTimerFired): If m_isWaitingToDecrementLoadEventDelayCount is true, call setShouldDelayLoadEvent(false) and set the timer to fire the pending events on the next idle. (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): Don't clear the delay from within a media engine callback because document 'load' event handlers that cause the page to become inactive will delete the media engine.
html/HTMLMediaElement.h: Add m_isWaitingToDecrementLoadEventDelayCount.

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743

platform/mac/Skipped: Remove tabindex-focus-blur-all.html from the skip list.

10:38 AM Changeset in webkit [66310] by Simon Fraser

5 edits in trunk/WebCore

2010-08-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794

Some preliminary cleanup; for vectors, prefer indexed access rather than using iterators.

No behavior changes.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): (WebCore::KeyframeAnimation::validateTransformFunctionList):
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
rendering/style/KeyframeList.h: (WebCore::KeyframeList::at): (WebCore::KeyframeList::keyframes):

10:02 AM Changeset in webkit [66309] by mitz@apple.com

2 edits in trunk/WebCore

Speculative fix for <rdar://problem/7275077> Crash in InlineBox::root() under RenderTextControl::textWithHardLineBreaks()
https://bugs.webkit.org/show_bug.cgi?id=44816

Reviewed by Simon Fraser.

No test because I could not reproduce the crash.

In a common variant of the crash, InlineBox::root() is called with this == 12. This suggests that
a RenderInline* was cast into a RenderBox*, so RenderBox::inlineBoxWrapper() interpreted the
m_lineHeight and m_verticalPosition members of a RenderInline as a pointer to an InlineBox.

The cast into RenderBox* in textWithHardLineBreaks() was introduced in r40881 with no exaplanation.

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textWithHardLineBreaks): Fetch the first line directly from the inner
text block instead of relying on the first child being a text node.

9:56 AM Changeset in webkit [66308] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-28 Moritz Lipp <mlq@pwmt.org>

Reviewed by Xan Lopez.

[GTK] Improper webkit_dom_document_evaluate implementation.
https://bugs.webkit.org/show_bug.cgi?id=42115

The generated webkit_dom_document_evaluate() function does not meet the
evaluate interface described in the W3 Documentation
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathEvaluator-evaluate
"If this is specified as nullor the implementation does not reuse the
specified result,...". The current implementation did not accept the
result parameter to be NULL.

bindings/scripts/CodeGeneratorGObject.pm:

9:14 AM Changeset in webkit [66307] by dbates@webkit.org

2 edits in trunk/WebKit/qt

2010-08-28 Daniel Bates <dbates@rim.com>

Attempt to fix the Qt Windows and Qt Linux Release minimal builds
after changeset 66297 <http://trac.webkit.org/changeset/66297>.

Api/qwebplugindatabase.cpp: (QWebPluginDatabase::plugins): Wrap the call to PluginPackage::ensurePluginLoaded in #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE).

2:43 AM Changeset in webkit [66306] by abarth@webkit.org

22 edits in trunk

2010-08-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781

This patch teaches the HTMLTreeBuilder about demoted form elements.
Demoting a form element magically stops the form element from
rendering. Demoted form elements are a concept from the
LegacyHTMLTreeBuilder, but they are somewhat of a hack because
rendering should be DOM-based. We'll likely look for a better solution
in a future patch.

html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLFormElement):
html/parser/HTMLConstructionSite.h:
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):

2010-08-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781

Update test expectations to account for demoted form elements. I spot
checked a bunch of these and this change is the reverse of the change
to these expectations in http://trac.webkit.org/changeset/64712. At
the time, we thought these rendering changes were correct because the
DOM was correct. However, demoted form elements have magical
non-DOM-based rendering.

platform/mac/fast/forms/form-added-to-table-expected.txt:
platform/mac/fast/forms/formmove3-expected.txt:
platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
platform/mac/fast/table/inline-form-assert-expected.txt:
platform/mac/fast/table/insert-cell-before-form-expected.txt:
platform/mac/fast/table/insert-row-before-form-expected.txt:
platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:

2:30 AM Changeset in webkit [66305] by commit-queue@webkit.org

17 edits
3 adds in trunk

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT

platform/chromium/accessibility: Added.
platform/chromium/accessibility/children-changed-notification-expected.txt: Added.
platform/chromium/accessibility/children-changed-notification.html: Added.
platform/chromium/drt_expectations.txt:
platform/chromium/test_expectations.txt:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT

accessibility/AXObjectCache.h: (WebCore::AXObjectCache::):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::childrenChanged):
accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
page/chromium/ChromeClientChromium.h:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectChildren):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren):
src/ChromeClientImpl.h:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController): (AccessibilityController::reset): (AccessibilityController::getRootElement): (AccessibilityController::dumpAccessibilityNotifications):
DumpRenderTree/chromium/AccessibilityController.h: (AccessibilityController::shouldDumpAccessibilityNotifications):
DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didChangeAccessibilityObjectChildren):
DumpRenderTree/chromium/WebViewHost.h:

2:09 AM Changeset in webkit [66304] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-08-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update commit-queue failure message
https://bugs.webkit.org/show_bug.cgi?id=44798

The commit-queue auto-restarts itself and has for a very long time.
No need for people to email me to request a restart anymore.

Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

1:49 AM Changeset in webkit [66303] by commit-queue@webkit.org

8 edits
2 copies in trunk/WebCore

2010-08-28 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Implement the DOM FileWriter class
https://bugs.webkit.org/show_bug.cgi?id=44362

No new tests until the delegate class has an implementation; bug logged.

Build file additions.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

The AsyncFileWriter is an abstract interface to which FileWriter delegates all the hard work.

html/AsyncFileWriter.h: Added.

The FileWriterClient is the interface for communications back from the AsyncFileWriter [success/failure, progress events].

html/FileWriterClient.h: Added. (WebCore::FileWriterClient::~FileWriterClient):

Added all delegation, state tracking, and progress event processing.

html/FileWriter.cpp: (WebCore::FileWriter::FileWriter): (WebCore::FileWriter::initialize): (WebCore::FileWriter::~FileWriter): ActiveDomObject stuff (WebCore::FileWriter::hasPendingActivity): (WebCore::FileWriter::stop): (WebCore::FileWriter::write): FileWriter public interface (WebCore::FileWriter::seek): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): FileWriterClient interface (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didTruncate): (WebCore::FileWriter::didFail): Progress events (WebCore::FileWriter::fireEvent):
html/FileWriter.h:

1:31 AM Changeset in webkit [66302] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-28 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Preparatory patch to split libwebcore in multiple libraries.

Start with a webcore_prerequisites pseudo-target what will be the common
target for all the other ones.

WebCore.gyp/WebCore.gyp:

12:58 AM Changeset in webkit [66301] by commit-queue@webkit.org

5 edits in trunk

2010-08-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777

wtf/Platform.h:

2010-08-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777

platform/PurgeableBuffer.h:
platform/mac/PurgeableBufferMac.cpp:

12:26 AM Changeset in webkit [66300] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-08-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix error message when theme loading fails
https://bugs.webkit.org/show_bug.cgi?id=44775

Parameters for logging were in the wrong order.

No new functionality so no new tests.

platform/efl/ScrollbarEfl.cpp: (ScrollbarEfl::setParent): exchange argument order in log function call

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed