⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 30, 2010:

11:44 PM Changeset in webkit [66460] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-08-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Buffered ranges drawing support
​https://bugs.webkit.org/show_bug.cgi?id=44869

Refactored the media slider track painting code to support
multiple buffered ranges painting. This change introduces no
functional regression.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack):
10:51 PM Changeset in webkit [66459] by jianli@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Update WebCore/ChangeLog to add missing entries.

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation):

10:39 PM Changeset in webkit [66458] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2010-08-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
​https://bugs.webkit.org/show_bug.cgi?id=44315

Remove ENABLE_HISTORY_ALWAYS_ASYNC #define.

  • wtf/Platform.h:

2010-08-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
​https://bugs.webkit.org/show_bug.cgi?id=44315

Add test that checks history.back() asynchronous behavior. Modifies
location-hash.html to not assume synchronous traversal and removes it
from the Chromium test expectations, since it passes there now too.

  • fast/dom/location-hash-expected.txt:
  • fast/dom/location-hash.html:
  • fast/history/history-traversal-is-asynchronous-expected.txt: Added.
  • fast/history/history-traversal-is-asynchronous.html: Added.
  • platform/chromium/test_expectations.txt:

2010-08-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
​https://bugs.webkit.org/show_bug.cgi?id=44315

Remove check in RedirectScheduler::scheduleHistoryNavigation that would
dispatch some navigations synchronously.

Test: fast/history/history-traversal-is-asynchronous.html

  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
10:37 PM Changeset in webkit [66457] by jianli@chromium.org
  • 1 edit in trunk/WebCore/fileapi/ThreadableBlobRegistry.cpp

2010-08-30 Jian Li <​jianli@chromium.org>

Try to fix break again.

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerBlobURL): (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
10:26 PM Changeset in webkit [66456] by jianli@chromium.org
  • 2 edits in trunk/WebCore/fileapi

2010-08-30 Jian Li <​jianli@chromium.org>

Fix another build break. Also fix directory upload test break.

  • fileapi/File.cpp: (WebCore::File::File):
  • fileapi/ThreadableBlobRegistry.cpp:
10:17 PM Changeset in webkit [66455] by jianli@chromium.org
  • 1 edit in trunk/WebCore/xml/XMLHttpRequest.cpp

2010-08-30 Jian Li <​jianli@chromium.org>

Fix build break.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
10:05 PM Changeset in webkit [66454] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-30 Kamil Blank <​k.blank@samsung.com>

Reviewed by Adam Barth.

[EFL] Added API which returns position of n-th text matches mark
​https://bugs.webkit.org/show_bug.cgi?id=44258

  • ewk/ewk_frame.cpp: (_ewk_frame_rect_cmp_less_than): Private. (_ewk_frame_rect_is_negative_value): Private. (ewk_frame_text_matches_nth_pos_get): Added. Function returns position of n-th text match in frame.
  • ewk/ewk_frame.h:
9:56 PM Changeset in webkit [66453] by jianli@chromium.org
  • 1 edit in trunk/WebCore/platform/network/BlobRegistryImpl.cpp

2010-08-30 Jian Li <​jianli@chromium.org>

Fix qt/gtk build break.

  • platform/network/BlobRegistryImpl.cpp:
9:45 PM Changeset in webkit [66452] by jianli@chromium.org
  • 33 edits
    1 copy
    1 move
    8 adds
    3 deletes in trunk

Switch the Blob implementation to using the blob data registration model
​https://bugs.webkit.org/show_bug.cgi?id=44389

Reviewed by Darin Fisher.

WebCore:

Tests: fast/files/read-blob-async.html

fast/files/read-file-async.html

With this switch, File/Blob/BlobBuilder are changed to register the blob
data. FileReader is changed to route through loading the blob resource.
FormData is also updated to take BlobData. The WebKit mac implementation
is updated to resolve the blob references in the BlobData.

  • CMakeLists.txt: Update the project file to remove BlobItem.*.
  • GNUmakefile.am: Update the project file to remove BlobItem.*.
  • WebCore.gypi: Update the project file to remove BlobItem.*.
  • WebCore.pro: Update the project file to remove BlobItem.*.
  • WebCore.vcproj/WebCore.vcproj: Update the project file to remove BlobItem.*.
  • WebCore.xcodeproj/project.pbxproj: Update the project file to remove BlobItem.*.
  • fileapi/Blob.cpp: Switch to using BlobData.

(WebCore::Blob::Blob):
(WebCore::Blob::slice):

  • fileapi/Blob.h: Switch to using BlobData.

(WebCore::Blob::create):
(WebCore::Blob::size):
(WebCore::Blob::isFile):

  • fileapi/BlobBuilder.cpp: Switch to using BlobData.

(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::getBlob):

  • fileapi/BlobBuilder.h: Switch to using BlobData.
  • fileapi/BlobURL.cpp: Add a new helper method used in FormData.

(WebCore::BlobURL::getIdentifier):

  • fileapi/BlobURL.h:
  • fileapi/File.cpp: Switch to using BlobData.

(WebCore::createBlobDataForFile):
(WebCore::File::File):
(WebCore::File::size):
(WebCore::File::captureSnapshot):

  • fileapi/File.h: Switch to using BlobData.

(WebCore::File::create):
(WebCore::File::path):
(WebCore::File::name):
(WebCore::File::webkitRelativePath):

  • fileapi/FileReader.cpp: Change the reading to route through blob resource loading.

(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::delayedStart):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didReceiveResponse):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::failed):
(WebCore::FileReader::httpStatusCodeToExceptionCode):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToDataURL):

  • fileapi/FileReader.h:
  • html/FormDataList.cpp: Account to BlobData change.

(WebCore::FormDataList::appendString):
(WebCore::FormDataList::appendBlob):

  • html/FormDataList.h: Account to BlobData change.

(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):
(WebCore::FormDataList::Item::blob):
(WebCore::FormDataList::items):

  • loader/FormSubmission.cpp: Account to BlobData change.

(WebCore::FormSubmission::create):

  • platform/BlobItem.cpp: Removed.
  • platform/BlobItem.h: Removed.
  • platform/network/BlobRegistryImpl.cpp: Add the implementations for resource loading.

(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::loadResourceSynchronously):

  • platform/network/BlobResourceHandle.cpp: Fix a bug that the ref is not added.

(WebCore::BlobResourceHandle::BlobResourceHandle):

  • platform/network/FormData.cpp: Account to BlobData change.

(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h: Account to BlobData change.
  • platform/network/mac/FormDataStreamMac.mm: Resolve blob references in the form data.

(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):

  • xml/XMLHttpRequest.cpp: Account to BlobData change.

(WebCore::XMLHttpRequest::send):

WebKit/chromium:

  • src/WebSearchableFormData.cpp:

(WebCore::HasSuitableTextElement):

LayoutTests:

Add a new test and change an existing test. Both tests are written in
better organized utility files and modules.

  • fast/files/file-reader-expected.txt: Removed.
  • fast/files/file-reader.html: Removed.
  • fast/files/read-blob-async-expected.txt: Added.
  • fast/files/read-blob-async.html: Added.
  • fast/files/read-file-async-expected.txt: Added.
  • fast/files/read-file-async.html: Added.
  • fast/files/resources/UTF8-2.txt: Added.
  • fast/files/resources/UTF8-3.txt: Added.
  • fast/files/resources/read-blob-test-cases.js: Added.
  • fast/files/resources/read-common.js: Added.
  • fast/files/resources/read-file-test-cases.js: Added.
  • fast/files/resources/setup-for-read-common.js: Added.
  • platform/gtk/Skipped: Account to the test changes for gtk.
  • platform/mac-wk2/Skipped: Account to the test changes for mac-wk2.
  • platform/qt/Skipped: Account to the test changes for qt.
  • platform/win/Skipped: Account to the test changes for win.
9:41 PM Changeset in webkit [66451] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-08-30 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[EFL]Url of HistoryItem was broken for special character like korean
​https://bugs.webkit.org/show_bug.cgi?id=44495

Remove unnecessary code. This makes a bug with complicated URL.

  • ewk/ewk_frame.cpp: (ewk_frame_view_state_save):
9:24 PM Changeset in webkit [66450] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-30 Nat Duca <​nduca@chromium.org>

Reviewed by Adam Barth.

[chromium] Accelerated Compositing: Artifacts/blink when enabling compositor.
​https://bugs.webkit.org/show_bug.cgi?id=44196

If accelerated compositing enables after a page loads, the dirtied
portion of the screen will be only a subset of the full screen,
leading to artefacts. Avoid these artefacts by invalidating the
visible content rect on compositor initialization.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
8:44 PM Changeset in webkit [66449] by eric@webkit.org
  • 36 edits in trunk

2010-08-30 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r66418.
​http://trac.webkit.org/changeset/66418
​https://bugs.webkit.org/show_bug.cgi?id=44896

Adam tried to roll this out with:
​https://bugs.webkit.org/show_bug.cgi?id=44924
but we hit a commit-queue edgecase and it failed, trying again.

Causing test failures on multiple bots

  • platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:

2010-08-30 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r66418.
​http://trac.webkit.org/changeset/66418
​https://bugs.webkit.org/show_bug.cgi?id=44896

Adam tried to roll this out with:
​https://bugs.webkit.org/show_bug.cgi?id=44924
but we hit a commit-queue edgecase and it failed, trying again.

Causing test failures on multiple bots

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsBoundariesUpdate):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::styleWillChange):
  • rendering/RenderPath.h: (WebCore::RenderPath::setNeedsBoundariesUpdate):
  • rendering/RenderSVGBlock.cpp:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calculateLocalTransform):
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint): (WebCore::RenderSVGHiddenContainer::objectBoundingBox): (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.cpp:
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::strokeBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox):
  • rendering/SVGRenderSupport.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
8:34 PM Changeset in webkit [66448] by alice.liu@apple.com
  • 15 edits in trunk

Add missing parts of didFinishDocumentLoadForFrame
​https://bugs.webkit.org/show_bug.cgi?id=44913

Reviewed by Darin Adler.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added new kind
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage): Updated struct

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame): Added

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Added case for WebPageProxyMessage::DidFinishDocumentLoadForFrame
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame): Added

  • UIProcess/WebPageProxy.h:

Just rearranging existing code in these:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didFinishDocumentLoadForFrame): Added
(-[BrowserWindowController awakeFromNib]): Updated struct

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Updated struct

7:14 PM Changeset in webkit [66447] by abarth@webkit.org
  • 6 edits in trunk

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CDATASection state for the HTMLTokenizer
​https://bugs.webkit.org/show_bug.cgi?id=44923

In the spec, this state refers back to the HTMLTreeBuilder from the
HTMLTokenizer. Rather that introduce that (backwards) dependencies, we
have the tree builder set a bit on the tokenizer.

  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::nextToken):
  • html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::shouldAllowCDATA): (WebCore::HTMLTokenizer::setShouldAllowCDATA):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken):

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement CDATASection state for the HTMLTokenizer
​https://bugs.webkit.org/show_bug.cgi?id=44923

Large test progression.

  • html5lib/runner-expected.txt:
7:04 PM Changeset in webkit [66446] by crogers@google.com
  • 3 edits in trunk/JavaScriptCore

2010-08-30 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fix namespace for wtf/Complex.h and wtf/Vector3.h
​https://bugs.webkit.org/show_bug.cgi?id=44892

  • wtf/Complex.h:
  • wtf/Vector3.h:
6:40 PM Changeset in webkit [66445] by mrowe@apple.com
  • 4 edits in tags/Safari-534.6.3/WebKit/mac

Merge r66441.

6:40 PM Changeset in webkit [66444] by mrowe@apple.com
  • 5 edits in tags/Safari-534.6.3

Versioning.

6:32 PM Changeset in webkit [66443] by abarth@webkit.org
  • 5 edits in trunk

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5lib's test_innerHTML01.dat
​https://bugs.webkit.org/show_bug.cgi?id=44919

These tests provoked two branches that we hadn't implemented yet.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag):

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5lib's test_innerHTML01.dat
​https://bugs.webkit.org/show_bug.cgi?id=44919

Enable these tests now that they don't ASSERT. Yay! They pass. :)

  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
6:32 PM Changeset in webkit [66442] by mrowe@apple.com
  • 1 copy in tags/Safari-534.6.3

New tag.

6:07 PM Changeset in webkit [66441] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/8369736> WebKit build fails.

Reviewed by Darin Adler.

Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.

  • Carbon/HIViewAdapter.m:
  • Carbon/HIWebView.mm:
  • Plugins/WebNetscapePluginView.mm:
6:06 PM Changeset in webkit [66440] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Stop using a QuickDraw function that was only used for debugging purposes.

Reviewed by Darin Adler.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::pathFromFont):

6:04 PM Changeset in webkit [66439] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Try and fix the WebKit2 buildbot.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add missing initialization of QTMovieDisableComponent.

6:04 PM Changeset in webkit [66438] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix crash on launch on Windows due to changing IWebFramePrivate's vtable

This regressed in r65107.

Fixes <​http://webkit.org/b/44755>.

Rubber-stamped by Jon Honeycutt.

  • Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and

resumeAnimations to the end of the interface so that the vtable will
match what Safari expects.

6:01 PM Changeset in webkit [66437] by aestes@apple.com
  • 4 edits in trunk/WebKit

WebKit: Add 'application/x-snkp' to StringsNotToBeLocalized.txt.

Reviewed by Darin Adler.

  • StringsNotToBeLocalized.txt:

WebKit/mac: REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
​https://bugs.webkit.org/show_bug.cgi?id=44865

Reviewed by Darin Adler.

After ​http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
for authentication fail to log in. This is due to a bug in AppleConnect that r66156
exposed, but since this will have a significant impact on users of WebKit nightly
builds, a plugin-specific hack should be added while the underlying issue is being
addressed.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
if the plugin is of type 'application/x-snkp'.

5:51 PM Changeset in webkit [66436] by weinig@apple.com
  • 17 edits
    15 adds in trunk/WebKit2

Add URLRequest API for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=44910

Reviewed by Anders Carlsson.

Add WebURLRequest class and WKURLRequestRef C API to go with it. Right now,
instance of WKURLRequestRef are manipulated via platform types, a la the
WKStringRef and WKURLRef types.

  • Pipes WKPageLoadURLRequest through to the WebProcess.
  • Shared/APIObject.h:
  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebURLRequest.cpp: Added.

(WebKit::WebURLRequest::WebURLRequest):

  • Shared/WebURLRequest.h: Added.

(WebKit::WebURLRequest::create):
(WebKit::WebURLRequest::resourceRequest):
(WebKit::WebURLRequest::type):

  • Shared/mac/WebCoreArgumentCodersMac.mm: Added.

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):

  • Shared/mac/WebURLRequestMac.mm: Added.

(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):

  • Shared/qt/WebCoreArgumentCodersQt.cpp: Added.

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):

  • Shared/qt/WebURLRequestQt.cpp: Added.

(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):

  • Shared/win/WebCoreArgumentCodersWin.cpp: Added.

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):

  • Shared/win/WebURLRequestWin.cpp: Added.

(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadURLRequest):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKURLRequest.cpp: Added.

(WKURLRequestGetTypeID):

  • UIProcess/API/C/WKURLRequest.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/C/cf/WKURLRequestCF.cpp: Added.

(WKURLRequestCreateWithCFURLRequest):
(WKURLRequestCopyCFURLRequest):

  • UIProcess/API/C/cf/WKURLRequestCF.h: Added.
  • UIProcess/API/C/mac: Added.
  • UIProcess/API/C/mac/WKURLRequestNS.h: Added.
  • UIProcess/API/C/mac/WKURLRequestNS.mm: Added.

(WKURLRequestCreateWithNSURLRequest):
(WKURLRequestCopyNSURLRequest):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):

  • UIProcess/WebPageProxy.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
5:44 PM Changeset in webkit [66435] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Import new tests from HTML5lib
​https://bugs.webkit.org/show_bug.cgi?id=44912

  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests21.dat: Added.
  • html5lib/resources/tests_innerHTML_1.dat: Added.
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
5:39 PM Changeset in webkit [66434] by morrita@google.com
  • 6 edits
    5 adds
    4 deletes in trunk/LayoutTests

2010-08-30 Yuta Kitamura <​yutak@chromium.org>

Unreviewed test expectation update.

Update Chromium test expectations
​https://bugs.webkit.org/show_bug.cgi?id=44859

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed. Test expectation was wrong.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Ditto.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [66433] by vangelis@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-30 Vangelis Kokkevis <​vangelis@chromium.org>

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
5:29 PM Changeset in webkit [66432] by dumi@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
  • platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
5:26 PM Changeset in webkit [66431] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

2010-08-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
​https://bugs.webkit.org/show_bug.cgi?id=21680

The bug was caused by WebKit's using the computed style to obtain the background color,
which is rgba(0,0,0,0) for nodes with transparent background color. While this is correct
in the accordance to CSS2 because background-color is not inherited by default,
it is not desirable for editing purposes where the background color in effect is expected.

Modified valueStyle in EditorCommand.cpp to call Editor::selectionStartCSSPropertyValue,
instead of Frame::selectionStartStylePropertyValue, which traverses common ancestors of
the selected range or caret to retrieve the effective background color of the selected region
instead of the background color at the start of the selection.
This takes effect when the original background color is transparent or the selection is range
(to avoid picking up the background color only present at the start of paragraph).

Removed selectionStartStylePropertyValue and migrated it to Editor::selectionStartCSSPropertyValue.

Test: editing/execCommand/query-command-value-background-color.html

  • editing/Editor.cpp: (WebCore::hasTransparentBackgroundColor): Checks whether the specified style's background color is transparent or not. (WebCore::Editor::selectionStartCSSPropertyValue): Migrated the contents of selectionStartStylePropertyValue and added the special case for background color.
  • editing/Editor.h: Added the prototype for selectionStartCSSPropertyValue.
  • editing/EditorCommand.cpp: (WebCore::valueStyle): Calls Editor::selectionStartCSSPropertyValue.
  • page/Frame.cpp: Removed selectionStartStylePropertyValue.
  • page/Frame.h: Ditto.

2010-08-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
​https://bugs.webkit.org/show_bug.cgi?id=21680

Tests queryCommandValue("BackColor") on various cases, especially the cases where
the background color of the selected node is transparent but that of its ancestor has a color.

  • editing/execCommand/query-command-value-background-color-expected.txt: Added.
  • editing/execCommand/query-command-value-background-color.html: Added.
5:19 PM Changeset in webkit [66430] by tkent@chromium.org
  • 4 edits in trunk

2010-08-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Fix fast/notifications/notifications-display-close-events.html failure
​https://bugs.webkit.org/show_bug.cgi?id=44585

  • platform/chromium/drt_expectations.txt:

2010-08-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Fix fast/notifications/notifications-display-close-events.html failure
​https://bugs.webkit.org/show_bug.cgi?id=44585

Apply ​http://crrev.com/48893. We should dispatch display events
asynchronously.

  • DumpRenderTree/chromium/NotificationPresenter.cpp: (deferredDisplayDispatch): (NotificationPresenter::show):
5:11 PM Changeset in webkit [66429] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-08-30 Tony Chang <​tony@chromium.org>

Unreviewed, rebaseline plugins/mouse-event.html on chromium win/linux
after ​http://trac.webkit.org/changeset/66408.

  • platform/chromium-linux/plugins/mouse-events-expected.txt:
  • platform/chromium-win/plugins/mouse-events-expected.txt:
5:02 PM Changeset in webkit [66428] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-08-30 Lei Zhang <​thestig@chromium.org>

Reviewed by Shinichiro Hamaji.

Defer printing until the FrameLoader finishes loading.
​https://bugs.webkit.org/show_bug.cgi?id=43658

  • manual-tests/print-before-load.html: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoading):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print):
  • page/DOMWindow.h: (WebCore::DOMWindow::printDeferred):
5:01 PM Changeset in webkit [66427] by crogers@google.com
  • 22 edits
    1 add in branches/audio

audio branch: lots of random cleanup for moving to trunk

5:00 PM Changeset in webkit [66426] by demarchi@webkit.org
  • 2 edits in trunk

2010-08-30 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Adam Barth.

[EFL] Remove compiler optimization for gcc 4.5.1
​https://bugs.webkit.org/show_bug.cgi?id=44520

GCC 4.5.1 generates wrong code because of -ftree-sra which is enabled
by default at any optimization level.

Newer and older versions are not affected, so check for compiler
version before disabling this.

  • cmake/WebKitHelpers.cmake: add flag depending on compiler version.
4:37 PM Changeset in webkit [66425] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adele Peterson.

REGRESSION(r51939): platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html fails
​https://bugs.webkit.org/show_bug.cgi?id=44897

Fixed the path to fast/js/resources/

  • platform/chromium/test_expectations.txt: No longer fails.
  • platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Fixed.
4:29 PM Changeset in webkit [66424] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-30 Tony Chang <​tony@chromium.org>

Unreviewed, fixing chromium test_expectations after r66299.

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [66423] by evan@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

2010-08-30 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] incorrect baselines on all platforms for fast/css/font-weight-1
​https://bugs.webkit.org/show_bug.cgi?id=44904

This test uses a custom font. From the change that checked them in, it
required build changes to make this custom font available for the tests.
The Chromium baselines were obviously wrong.

  • platform/chromium-linux/fast/css/font-weight-1-expected.checksum: Removed.
  • platform/chromium-linux/fast/css/font-weight-1-expected.png: Removed.
  • platform/chromium-linux/fast/css/font-weight-1-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-weight-1-expected.checksum: Removed.
  • platform/chromium-win/fast/css/font-weight-1-expected.png: Removed.
  • platform/chromium-win/fast/css/font-weight-1-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: mark as failing on all platforms.
3:57 PM Changeset in webkit [66422] by abarth@webkit.org
  • 1 edit in trunk/BugsSite/PrettyPatch/PrettyPatch.rb

Typo fix.

3:53 PM Changeset in webkit [66421] by dumi@chromium.org
  • 2 edits
    33 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/fast/lists/li-values-expected.checksum: Removed.
  • platform/chromium-linux/fast/lists/li-values-expected.png: Removed.
  • platform/chromium-linux/fast/lists/li-values-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/w3-list-styles-expected.checksum: Removed.
  • platform/chromium-linux/fast/lists/w3-list-styles-expected.png: Removed.
  • platform/chromium-linux/fast/lists/w3-list-styles-expected.txt: Removed.
  • platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
  • platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.png: Removed.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.txt: Removed.
  • platform/chromium-win/fast/lists/alpha-list-wrap-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/alpha-list-wrap-expected.png: Removed.
  • platform/chromium-win/fast/lists/alpha-list-wrap-expected.txt: Removed.
  • platform/chromium-win/fast/lists/decimal-leading-zero-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/decimal-leading-zero-expected.png: Removed.
  • platform/chromium-win/fast/lists/decimal-leading-zero-expected.txt: Removed.
  • platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
  • platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
  • platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
  • platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/chromium-win/fast/lists/w3-list-styles-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/w3-list-styles-expected.png: Removed.
  • platform/chromium-win/fast/lists/w3-list-styles-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [66420] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[review tool] Let reviewer select how much context to show in snippet
​https://bugs.webkit.org/show_bug.cgi?id=44905

We now highlight the context for a comment in yellow on the left (where
the line numbers are). Clicking a line number expands or contracts the
amount of context, as appropriate. Informal user testing indicates
that we might want to support drag as well.

This patch also changes the "open a comment box here" action to
double-click to avoid issues with mis-clicks.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
3:43 PM Changeset in webkit [66419] by crogers@google.com
  • 1 edit
    8 adds in trunk/WebCore

2010-08-30 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add ReverbConvolver class
​https://bugs.webkit.org/show_bug.cgi?id=34912

No new tests since audio API is not yet implemented.

  • platform/audio: Added.
  • platform/audio/ReverbAccumulationBuffer.cpp: Added. (WebCore::ReverbAccumulationBuffer::ReverbAccumulationBuffer): (WebCore::ReverbAccumulationBuffer::readAndClear): (WebCore::ReverbAccumulationBuffer::updateReadIndex): (WebCore::ReverbAccumulationBuffer::accumulate): (WebCore::ReverbAccumulationBuffer::reset):
  • platform/audio/ReverbAccumulationBuffer.h: Added. (WebCore::ReverbAccumulationBuffer::readIndex): (WebCore::ReverbAccumulationBuffer::readTimeFrame):
  • platform/audio/ReverbConvolver.cpp: Added. (WebCore::backgroundThreadEntry): (WebCore::ReverbConvolver::ReverbConvolver): (WebCore::ReverbConvolver::~ReverbConvolver): (WebCore::ReverbConvolver::backgroundThreadEntry): (WebCore::ReverbConvolver::process): (WebCore::ReverbConvolver::reset):
  • platform/audio/ReverbConvolver.h: Added. (WebCore::ReverbConvolver::impulseResponseLength): (WebCore::ReverbConvolver::inputBuffer): (WebCore::ReverbConvolver::useBackgroundThreads):
  • platform/audio/ReverbConvolverStage.cpp: Added. (WebCore::ReverbConvolverStage::ReverbConvolverStage): (WebCore::ReverbConvolverStage::processInBackground): (WebCore::ReverbConvolverStage::process): (WebCore::ReverbConvolverStage::reset):
  • platform/audio/ReverbConvolverStage.h: Added. (WebCore::ReverbConvolverStage::inputReadIndex):
  • platform/audio/ReverbInputBuffer.cpp: Added. (WebCore::ReverbInputBuffer::ReverbInputBuffer): (WebCore::ReverbInputBuffer::write): (WebCore::ReverbInputBuffer::directReadFrom): (WebCore::ReverbInputBuffer::reset):
  • platform/audio/ReverbInputBuffer.h: Added. (WebCore::ReverbInputBuffer::writeIndex):
3:37 PM Changeset in webkit [66418] by Nikolas Zimmermann
  • 36 edits in trunk

2010-08-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add culling to RenderSVGContainer
​https://bugs.webkit.org/show_bug.cgi?id=44896

Cache object/strokeBoundingBox and repaintRectInLocalCoordinates() in RenderSVGContainer & RenderSVGRoot, just like it's done in RenderPath.
Propagate boundary changes up the render tree, in layout phase, in order to notify parents that they should update their cached boundaries.

This is a huge speed benefit when interacting with an already layouted document, as there's no need anymore to traverse all children
of any container or <svg> element, just to retrieve the repaint rect.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setNeedsBoundariesUpdate):
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint):
  • rendering/RenderPath.h: (WebCore::RenderPath::path): (WebCore::RenderPath::setNeedsBoundariesUpdate):
  • rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::styleWillChange):
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::updateCachedBoundaries):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): (WebCore::RenderSVGContainer::calculateLocalTransform):
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::strokeBoundingBox):
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::styleWillChange):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::styleWillChange):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleWillChange):
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::styleWillChange): (WebCore::RenderSVGRoot::updateCachedBoundaries):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::setNeedsBoundariesUpdate): (WebCore::RenderSVGRoot::setNeedsTransformUpdate): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::strokeBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): (WebCore::SVGRenderSupport::paintInfoIntersectsRepaintRect):
  • rendering/SVGRenderSupport.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):

2010-08-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add culling to RenderSVGContainer
​https://bugs.webkit.org/show_bug.cgi?id=44896

Update some pixel test results, that show marginal changes.

  • platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
3:31 PM Changeset in webkit [66417] by leandro@webkit.org
  • 3 edits in trunk/WebCore

2010-08-30 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix when ENABLE_WEB_SOCKETS=ON.

EFL port does not yet support automated tests.

  • CMakeLists.txt: Add missing files.
  • CMakeListsEfl.txt: Ditto.
3:28 PM Changeset in webkit [66416] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-30 Kenneth Russell <​kbr@google.com>

Reviewed by Chris Marrin.

Expose Vector3 and associated operations
​https://bugs.webkit.org/show_bug.cgi?id=44666

Rolling out earlier patch exposing Vector3 class in
TransformationMatrix.h. A different approach will be taken under
another bug.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::v3Length): (WebCore::v3Scale): (WebCore::v3Dot): (WebCore::v3Combine): (WebCore::v3Cross): (WebCore::decompose):
  • platform/graphics/transforms/TransformationMatrix.ha:
3:25 PM Changeset in webkit [66415] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

Build fix; Unreviewed.

Added a export symbol to the WebCore.exp.in list.

  • WebCore.exp.in:
3:20 PM Changeset in webkit [66414] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-08-30 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add audio cone effect files. The cone effect operates as defined in the OpenAL specification.
​https://bugs.webkit.org/show_bug.cgi?id=44712

No new tests since audio API not implemented yet.

  • platform/audio: Added.
  • platform/audio/Cone.cpp: Added. (WebCore::ConeEffect::ConeEffect): (WebCore::ConeEffect::gain):
  • platform/audio/Cone.h: Added. (WebCore::ConeEffect::setInnerAngle): (WebCore::ConeEffect::innerAngle): (WebCore::ConeEffect::setOuterAngle): (WebCore::ConeEffect::outerAngle): (WebCore::ConeEffect::setOuterGain): (WebCore::ConeEffect::outerGain):
3:16 PM Changeset in webkit [66413] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-08-30 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

audio engine: add Reverb class
​https://bugs.webkit.org/show_bug.cgi?id=36466

No new tests since audio API is not yet implemented.

  • platform/audio: Added.
  • platform/audio/Reverb.cpp: Added. (WebCore::calculateNormalizationScale): (WebCore::Reverb::Reverb): (WebCore::Reverb::initialize): (WebCore::Reverb::process): (WebCore::Reverb::reset):
  • platform/audio/Reverb.h: Added. (WebCore::Reverb::): (WebCore::Reverb::impulseResponseLength):
3:10 PM Changeset in webkit [66412] by crogers@google.com
  • 1 edit
    1 add in trunk/WebCore

2010-08-30 Chris Rogers <​crogers@google.com>

Unreviewed

Add WebCore/platform/audio directory
in preparation for landing: ​https://bugs.webkit.org/show_bug.cgi?id=36466

  • platform/audio: Added.
2:47 PM Changeset in webkit [66411] by jer.noble@apple.com
  • 10 edits
    5 adds in trunk

2010-08-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

text/plain non-video files cause <video> to hang (while reading them?)
​https://bugs.webkit.org/show_bug.cgi?id=44212


Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
the initialization routine.

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.

2010-08-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

text/plain non-video files cause <video> to hang (while reading them?)
​https://bugs.webkit.org/show_bug.cgi?id=44212


Disable all the QuickTime components which ingest .txt files.

New tests:

  • http/tests/media/video-served-as-text.html: Added.
  • http/tests/media/text-served-as-text.html: Added.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Disable all four text

'eat' components.

  • platform/mac/WebCoreSystemInterface.h: Add wkQTMovieDisableComponent.
  • platform/mac/WebCoreSystemInterface.mm: Add wkQTMovieDisableComponent.

2010-08-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

text/plain non-video files cause <video> to hang (while reading them?)
​https://bugs.webkit.org/show_bug.cgi?id=44212


Added two new tests: video-served-as-text.html and
text-served-as-text.html. The second checks that a text file does not
generates an error when loaded by a <video> element. The first checks
that media served as text/plain still loads without errors.

  • http/tests/media/resources/test.txt: Added.
  • http/tests/media/text-served-as-text-expected.txt: Added.
  • http/tests/media/text-served-as-text.html: Added.
  • http/tests/media/video-served-as-text-expected.txt: Added.
  • http/tests/media/video-served-as-text.html: Added.
2:39 PM Changeset in webkit [66410] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-30 Evan Martin <​evan@chromium.org>

Unreviewed, updating Chromium expectations.

Revert part of my update in r66406 that was wrong.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [66409] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Update LayoutTest for file inputs to show "pass" for fakepath
​https://bugs.webkit.org/show_bug.cgi?id=44882

As requested by Alexey.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (draggingPathsShouldResultInFiles):
2:16 PM Changeset in webkit [66408] by robert@webkit.org
  • 10 edits in trunk

2010-08-30 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

allow ports with windowed plugins to support windowless plugin tests

​https://bugs.webkit.org/show_bug.cgi?id=40730

Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.

Unskip the following tests on Qt:

plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html

  • platform/qt/Skipped:
  • plugins/keyboard-events.html:
  • plugins/mouse-events-fixedpos.html:
  • plugins/mouse-events.html:

2010-08-30 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

allow ports with windowed plugins to support windowless plugin tests

​https://bugs.webkit.org/show_bug.cgi?id=40730

Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.

Unskip the following tests on Qt:

plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus): (WebCore::setXKeyEventSpecificFields):

2010-08-30 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

allow ports with windowed plugins to support windowless plugin tests

​https://bugs.webkit.org/show_bug.cgi?id=40730

Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.

Unskip the following tests on Qt:

plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginSetProperty):
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_handle_event):
1:50 PM Changeset in webkit [66407] by kinuko@chromium.org
  • 15 edits in trunk

2010-08-30 Kinuko Yasuda <​kinuko@chromium.osrc>

Reviewed by Darin Fisher.

Add DOMFileSystem implementation to support Entry manipulation operations
​https://bugs.webkit.org/show_bug.cgi?id=44732

Fixed virtual-path / platform-path conversion timing. (The conversion needs to be done before calling AsyncFileSystem methods to support cross-filesystem operations.)

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::move): (WebCore::AsyncFileSystemChromium::copy): (WebCore::AsyncFileSystemChromium::remove): (WebCore::AsyncFileSystemChromium::readMetadata): (WebCore::AsyncFileSystemChromium::createFile): (WebCore::AsyncFileSystemChromium::createDirectory): (WebCore::AsyncFileSystemChromium::fileExists): (WebCore::AsyncFileSystemChromium::directoryExists): (WebCore::AsyncFileSystemChromium::readDirectory):

2010-08-30 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Darin Fisher.

Add DOMFileSystem implementation to support Entry manipulation operations
​https://bugs.webkit.org/show_bug.cgi?id=44732

No new tests; tests will be added later.

  • storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::root): (WebCore::checkValidityForForCopyOrMove): Added. (WebCore::DOMFileSystem::getMetadata): Added. (WebCore::DOMFileSystem::move): Added. (WebCore::DOMFileSystem::copy): Added. (WebCore::DOMFileSystem::remove): Added. (WebCore::DOMFileSystem::getParent): Added. (WebCore::DOMFileSystem::getFile): Added. (WebCore::DOMFileSystem::getDirectory): Added. (WebCore::DOMFileSystem::readDirectory): Added.
  • storage/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): Added implementation. (WebCore::DirectoryEntry::getDirectory): Added implementation.
  • storage/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added implementation. (WebCore::DirectoryReader::readEntries): Added implementation.
  • storage/DirectoryReader.h:
  • storage/Entry.cpp: (WebCore::Entry::getMetadata): Added implementation. (WebCore::Entry::moveTo): Added implementation. (WebCore::Entry::copyTo): Added implementation. (WebCore::Entry::remove): Added implementation. (WebCore::Entry::getParent): Added implementation.
  • storage/Entry.h:
  • storage/FileEntry.h:

Added a helper template to schedule callbacks.

  • storage/DOMFileSystem.h: (WebCore::DOMFileSystem::DispatchCallbackTask): Added to schedule callbacks. (WebCore::DOMFileSystem::scheduleCallback): Added to schedule callbacks.

Changed to fire callbacks asynchronously.

  • storage/LocalFileSystem.cpp: (WebCore::LocalFileSystem::requestFileSystem):
1:39 PM Changeset in webkit [66406] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-30 Evan Martin <​evan@chromium.org>

Unreviewed, updating Chromium expectations.

Simplify some obsolete test expectations based on looking at their
current behavior on the dashboard.

  • platform/chromium/test_expectations.txt:
1:20 PM Changeset in webkit [66405] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after addition of fileapi directory in WebCore.

1:16 PM Changeset in webkit [66404] by alex
  • 5 edits in trunk

2010-08-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Fixed compilation error, now that we have included the
GtkVersioning.h we have to remove some version dependent code from
EventSender.

  • platform/gtk/GtkVersioning.c: (gdk_window_get_root_coords):
  • platform/gtk/GtkVersioning.h:

2010-08-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Fixed compilation error, now that we have included the
GtkVersioning.h we have to remove some version dependent code from
EventSender.

  • DumpRenderTree/gtk/EventSender.cpp:
1:03 PM Changeset in webkit [66403] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and corresponding-
<rdar://problem/8342055>

Reviewed by Sam Weinig.

All of the calls to firstChild() and lastChild() in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint() need to be
null checked.

  • mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and-
​https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()

Reviewed by Sam Weinig.

  • mathml/empty-mroot-crash-expected.txt: Added.
  • mathml/empty-mroot-crash.xhtml: Added.
  • mathml/msubsup-no-grandchild-expected.txt: Added.
  • mathml/msubsup-no-grandchild.xhtml: Added.
12:56 PM Changeset in webkit [66402] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()
-and corresponding-
<rdar://problem/8325203>

Reviewed by Darin Adler.

Null-check m_scripts. It is null-checked everywhere else in the
class and can legitimately be null.

  • mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout):

12:27 PM Changeset in webkit [66401] by aestes@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-08-30 Andy Estes <​aestes@apple.com>

Reviewed by Eric Carlson.

Strings returned by asciiDebug() should be NULL-terminated.
​https://bugs.webkit.org/show_bug.cgi?id=44866

  • wtf/text/WTFString.cpp: (asciiDebug):
12:21 PM Changeset in webkit [66400] by Martin Robinson
  • 2 edits
    12 adds in trunk/LayoutTests

2010-08-30 Martin Robinson <​mrobinson@igalia.com>

Unskip passing philip canvas tests and unskip and add results for some more shadow tests.

  • platform/gtk/Skipped:
  • platform/gtk/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/gtk/svg/css/composite-shadow-example-expected.png: Added.
  • platform/gtk/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/gtk/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/gtk/svg/css/composite-shadow-text-expected.png: Added.
  • platform/gtk/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.checksum: Added.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-large-radius-expected.txt.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum: Added.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-negative-offset-expected.txt.
12:06 PM Changeset in webkit [66399] by cmarrin@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Moved my name from committer to reviewer

12:06 PM Changeset in webkit [66398] by alex
  • 10 edits
    1 move in trunk

2010-08-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
​https://bugs.webkit.org/show_bug.cgi?id=44787

We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.

  • GNUmakefile.am:
  • platform/gtk/GtkVersioning.c: Added. (gtk_adjustment_set_value): (gtk_adjustment_configure): (getDefaultGDKPointerDevice):
  • platform/gtk/GtkVersioning.cpp: Removed.
  • platform/gtk/GtkVersioning.h:

2010-08-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
​https://bugs.webkit.org/show_bug.cgi?id=44787

We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.

  • GNUmakefile.am:

2010-08-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
​https://bugs.webkit.org/show_bug.cgi?id=44787

We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): (mouseMoveToCallback): (keyDownCallback):
  • GNUmakefile.am:
11:44 AM Changeset in webkit [66397] by Darin Adler
  • 257 edits in trunk/WebCore

2010-08-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Make SVG constructors private to make sure callers all use create
​https://bugs.webkit.org/show_bug.cgi?id=44872

Made as many members private and protected as possible, and got rid of many
unneeded empty constructor and destructor definitions, in some cases changing
a class to be non-polymorphic. Made some functions inline. Used the word document
instead of the abbreviation doc. Removed unneeded explicit base class
initialization in cases where it is no different from the default behavior.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement): (WebCore::SVGAElement::childShouldCreateRenderer):
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAngle.cpp:
  • svg/SVGAngle.h:
  • svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedPathData.cpp:
  • svg/SVGAnimatedPathData.h:
  • svg/SVGAnimatedPoints.cpp:
  • svg/SVGAnimatedPoints.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement):
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement):
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement):
  • svg/SVGClipPathElement.h:
  • svg/SVGColor.cpp:
  • svg/SVGColor.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement):
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement):
  • svg/SVGDefsElement.h:
  • svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement):
  • svg/SVGDescElement.h:
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h:
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.h:
  • svg/SVGElementInstanceList.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement):
  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::SVGFEPointLightElement): (WebCore::SVGFEPointLightElement::lightSource):
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:
  • svg/SVGFontData.cpp:
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement):
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement):
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement):
  • svg/SVGGlyphElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement):
  • svg/SVGGradientElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::SVGHKernElement):
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
  • svg/SVGImageElement.h:
  • svg/SVGImageLoader.cpp:
  • svg/SVGImageLoader.h:
  • svg/SVGLangSpace.cpp:
  • svg/SVGLangSpace.h:
  • svg/SVGLengthList.cpp:
  • svg/SVGLengthList.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGLocatable.cpp:
  • svg/SVGLocatable.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement):
  • svg/SVGMaskElement.h:
  • svg/SVGMetadataElement.cpp: (WebCore::SVGMetadataElement::SVGMetadataElement):
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGNumberList.cpp:
  • svg/SVGNumberList.h:
  • svg/SVGPaint.cpp:
  • svg/SVGPaint.h:
  • svg/SVGParserUtilities.cpp: (WebCore::genericParseNumber): (WebCore::parseNumber):
  • svg/SVGPathBlender.cpp:
  • svg/SVGPathBlender.h:
  • svg/SVGPathBuilder.h:
  • svg/SVGPathByteStreamBuilder.h:
  • svg/SVGPathByteStreamSource.cpp:
  • svg/SVGPathByteStreamSource.h:
  • svg/SVGPathConsumer.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement):
  • svg/SVGPathElement.h:
  • svg/SVGPathParser.cpp:
  • svg/SVGPathParser.h:
  • svg/SVGPathSeg.cpp:
  • svg/SVGPathSeg.h:
  • svg/SVGPathSegArc.h:
  • svg/SVGPathSegClosePath.cpp:
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • svg/SVGPathSegLineto.h:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegList.cpp:
  • svg/SVGPathSegList.h:
  • svg/SVGPathSegListBuilder.h:
  • svg/SVGPathSegListSource.cpp:
  • svg/SVGPathSegListSource.h:
  • svg/SVGPathSegMoveto.h:
  • svg/SVGPathSource.h:
  • svg/SVGPathStringBuilder.cpp:
  • svg/SVGPathStringBuilder.h:
  • svg/SVGPathStringSource.cpp:
  • svg/SVGPathStringSource.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
  • svg/SVGPatternElement.h:
  • svg/SVGPointList.cpp:
  • svg/SVGPointList.h:
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement):
  • svg/SVGPolyElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::SVGPolygonElement):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::SVGPolylineElement):
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
  • svg/SVGScriptElement.h:
  • svg/SVGSetElement.cpp: (WebCore::SVGSetElement::SVGSetElement):
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement):
  • svg/SVGStopElement.h:
  • svg/SVGStringList.cpp:
  • svg/SVGStringList.h:
  • svg/SVGStylable.cpp:
  • svg/SVGStylable.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
  • svg/SVGStyledLocatableElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::childShouldCreateRenderer):
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement):
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::SVGTSpanElement):
  • svg/SVGTests.cpp:
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::SVGTitleElement):
  • svg/SVGTransform.cpp:
  • svg/SVGTransform.h:
  • svg/SVGTransformable.cpp:
  • svg/SVGTransformable.h:
  • svg/SVGURIReference.cpp:
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement):
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h:
  • svg/SVGZoomAndPan.cpp:
  • svg/SVGZoomAndPan.h:
  • svg/SVGZoomEvent.cpp:
  • svg/SVGZoomEvent.h:
10:35 AM Changeset in webkit [66396] by andersca@apple.com
  • 2 edits in trunk/WebKit2

WorkQueue leaks its dispatch queue
<rdar://problem/8358509>
​https://bugs.webkit.org/show_bug.cgi?id=44689

Reviewed by Sam Weinig.

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::platformInvalidate):

10:18 AM Changeset in webkit [66395] by eric.carlson@apple.com
  • 7 edits
    3 adds in trunk

2010-08-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Disable automatic looping
​https://bugs.webkit.org/show_bug.cgi?id=44844

Test: media/video-does-not-loop.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Disable QuickTime automatic looping.
  • platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::createMovieController): Ditto.

2010-08-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Disable automatic looping
​https://bugs.webkit.org/show_bug.cgi?id=44844

  • media/content/silence-loop.mov: Added.
  • media/video-does-not-loop-expected.txt: Added.
  • media/video-does-not-loop.html: Added.
  • platform/chromium/test_expectations.txt: Skip new test.
  • platform/gtk/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
10:12 AM Changeset in webkit [66394] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

ApplyStyleCommand::applyInlineStyle needs cleanup
​https://bugs.webkit.org/show_bug.cgi?id=44458

Cleanup:

  1. Isolated code to find the highest ancestor with embedding style, and deployed it in ApplyStyleCommand::applyInlineStyle.
  2. Combined the code to remove embedding style up to enclosing block and the code to remove unicode-bidi and direction properties between start and end nodes.
  3. Simplified the conditionals to apply embedding styles.

No new tests are added since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: (WebCore::highestEmbeddingAncestor): Added. (WebCore::ApplyStyleCommand::applyInlineStyle): See above.
9:45 AM Changeset in webkit [66393] by Martin Robinson
  • 2 edits
    65 adds in trunk/LayoutTests

2010-08-30 Martin Robinson <​mrobinson@igalia.com>

Adding layout and pixel results in preparation for landing GTK+ shadow performance improvements.

  • platform/gtk/Skipped: Unskip tests that now have results, skip tests that are definitely failing.
  • platform/gtk/fast/box-shadow/basic-shadows-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt: Added.
  • platform/gtk/fast/box-shadow/border-radius-big-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/gtk/fast/box-shadow/border-radius-big-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/inset-expected.png: Added.
  • platform/gtk/fast/box-shadow/inset-expected.txt: Added.
  • platform/gtk/fast/box-shadow/spread-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/spread-expected.png: Added.
  • platform/gtk/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
  • platform/gtk/fast/box-shadow/transform-fringing-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/transform-fringing-expected.png: Added.
  • platform/gtk/fast/box-shadow/transform-fringing-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/gtk/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/gtk/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt: Added.
  • platform/gtk/fast/css/shadow-multiple-expected.checksum: Added.
  • platform/gtk/fast/css/shadow-multiple-expected.png: Added.
  • platform/gtk/fast/css/shadow-multiple-expected.txt: Added.
  • platform/gtk/fast/forms/box-shadow-override-expected.checksum: Added.
  • platform/gtk/fast/forms/box-shadow-override-expected.png: Added.
  • platform/gtk/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/gtk/fast/text/shadow-no-blur-expected.checksum: Added.
  • platform/gtk/fast/text/shadow-no-blur-expected.png: Added.
  • platform/gtk/fast/text/shadow-no-blur-expected.txt: Added.
  • platform/gtk/fast/transforms/shadows-expected.checksum: Added.
  • platform/gtk/fast/transforms/shadows-expected.png: Added.
  • platform/gtk/fast/transforms/shadows-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/shadows-expected.txt.
  • platform/gtk/svg/css/arrow-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/arrow-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/arrow-with-shadow-expected.txt.
  • platform/gtk/svg/css/group-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/group-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/group-with-shadow-expected.txt: Added.
  • platform/gtk/svg/css/mask-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/mask-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/gtk/svg/css/path-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/path-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/path-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/path-with-shadow-expected.txt.
  • platform/gtk/svg/css/stars-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/stars-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.
9:18 AM Changeset in webkit [66392] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-08-30 Simon Fraser <Simon Fraser>

Disable http/tests/css/css-image-loading.html on Windows.

  • platform/win/Skipped:
8:58 AM Changeset in webkit [66391] by Simon Fraser
  • 9 edits in trunk/WebCore

2010-08-29 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Fix RenderStyle::addCursor to use a StyleImage, not a CachedImage
​https://bugs.webkit.org/show_bug.cgi?id=44719

Modernize the CSS cursor code to use a StyleImage, rather
than a CachedImage in the CursorData, and handle the loading
of pending images for the cursor property.

Covered by manual tests in WebCore/manual-tests

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::loadPendingImages):
  • html/canvas/WebGLRenderingContext.cpp:
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
  • rendering/style/CursorData.h: (WebCore::CursorData::CursorData): (WebCore::CursorData::image): (WebCore::CursorData::setImage):
  • rendering/style/CursorList.h: (WebCore::CursorList::operator[]):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::addCursor):
  • rendering/style/RenderStyle.h:
8:48 AM Changeset in webkit [66390] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-08-30 Martin Robinson <​mrobinson@igalia.com>

Build fix. Add the new fileapi directory to the IDL vpath.

  • GNUmakefile.am:
8:16 AM Changeset in webkit [66389] by Martin Robinson
  • 3 edits
    1 add in trunk

2010-08-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit DOM bindings build should not depend on output GNUMakefile
​https://bugs.webkit.org/show_bug.cgi?id=44805

Move the DOM bindings source lists and generator rules to
WebCore/bindings/gobject/GNUmakefile.am. This will prevent a full WebKit API
rebuild whenever the automake files change, decreasing build times.

  • GNUmakefile.am:

2010-08-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit DOM bindings build should not depend on output GNUMakefile
​https://bugs.webkit.org/show_bug.cgi?id=44805

Move WebKit DOM bindings build rules to bindings/gobject/GNUmakefile.am to
prevent full WebKit API rebuilds when the automake files change.

No new tests as this is just a build change.

  • bindings/gobject/GNUmakefile.am: Added.
7:27 AM Changeset in webkit [66388] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: event listener properties are rendered as [object Object].
​https://bugs.webkit.org/show_bug.cgi?id=44779

  • inspector/front-end/EventListenersSidebarPane.js:
7:15 AM Changeset in webkit [66387] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.2.0

Late tagging of 1.2.0.

7:10 AM Changeset in webkit [66386] by zoltan@webkit.org
  • 4 edits in trunk/WebKitTools

[Qt] Add new window menu to MiniBrowser

Reviewed by Kenneth Rohde Christiansen.

Implement newWindow function and add a menu item for opening new window in MiniBrowser.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/main.cpp:

(main):

5:40 AM Changeset in webkit [66385] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix with Blob Support

[EFL] Build break with Blob support
​https://bugs.webkit.org/show_bug.cgi?id=44858

No new features added, so no new tests.

  • CMakeLists.txt:
4:57 AM Changeset in webkit [66384] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Andras Becsi <​abecsi@webkit.org>

Unreviewed trivial fix.

[Qt] Let qmake know about HTML parser headers.

No new tests needed.

  • WebCore.pro:
4:38 AM Changeset in webkit [66383] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Andras Becsi <​abecsi@webkit.org>

Unreviewed build fix.

[Qt] Fix fileapi header paths to fix warnings after r66365.

No new tests needed.

  • WebCore.pro:
3:34 AM Changeset in webkit [66382] by dumi@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-win/fast/lists/li-values-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/li-values-expected.png: Removed.
  • platform/chromium-win/fast/lists/li-values-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:06 AM Changeset in webkit [66381] by yuzo@google.com
  • 3 edits
    1 add in trunk/LayoutTests

2010-08-30 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/fast/lists/li-values-expected.txt: Added.
  • platform/chromium-win/fast/lists/li-values-expected.txt:
  • platform/chromium/test_expectations.txt:
2:53 AM Changeset in webkit [66380] by yuzo@google.com
  • 3 edits
    2 adds in trunk/LayoutTests

2010-08-30 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change for r66359.

  • platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
2:48 AM Changeset in webkit [66379] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-30 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Kent Tamura.

REGRESSION(r66355): Fix warnings in html/DateComponents.cpp
​https://bugs.webkit.org/show_bug.cgi?id=44855

  • html/DateComponents.cpp:
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek): Suggested parentheses added around && within
2:42 AM Changeset in webkit [66378] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
​https://bugs.webkit.org/show_bug.cgi?id=44843

Reviewed by Darin Adler.

  • editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within
2:13 AM Changeset in webkit [66377] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-08-30 Mikołaj Małecki <​m.malecki@samsung.com>

Reviewed by Kenneth Rohde Christiansen

[EFL] Added initial setting to turn on offline pages.
​https://bugs.webkit.org/show_bug.cgi?id=44239

  • ewk/ewk_main.cpp: Torn off non-EFL init to _ewk_init_body (ewk_init): Changed non-EFL init to call _ewk_init_body (_ewk_init_body): Moved internal init here and added cache directory path setting.
  • ewk/ewk_view.cpp: Added new config items: offline_app_cache and cache_directory (_ewk_view_priv_new): creating cache_directory string (_ewk_view_priv_del): deleting cache_directory string (ewk_view_setting_offline_app_cache_get): (ewk_view_setting_offline_app_cache_set): (ewk_view_setting_cache_directory_get): (ewk_view_setting_cache_directory_set):
  • ewk/ewk_view.h: added offline_app_cache and cache_directory props to ewk API
1:48 AM Changeset in webkit [66376] by commit-queue@webkit.org
  • 24 edits in trunk

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js: (WebInspector.inspectedPageDestroyed):

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::closeWindow):
  • WebCoreSupport/InspectorClientGtk.h:

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView]):

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorFrontendClientQt::closeWindow):
  • WebCoreSupport/InspectorClientQt.h:

2010-08-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66198.
​http://trac.webkit.org/changeset/66198
​https://bugs.webkit.org/show_bug.cgi?id=44856

It made tests crash on Qt bot (Requested by Ossy_ on #webkit).

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView):
  • WebCoreSupport/WebInspectorClient.h:
1:24 AM Changeset in webkit [66375] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Refactor number parsing in the lexer
​https://bugs.webkit.org/show_bug.cgi?id=44104

Reviewed by Darin Adler.

Number parsing was full of gotos, and needed a complete
redesign to remove them (Only one remained). Furthermore
integer arithmetic is empolyed for fast cases (= small
integer numbers).

  • parser/Lexer.cpp:

(JSC::Lexer::parseHex):
(JSC::Lexer::parseOctal):
(JSC::Lexer::parseDecimal):
(JSC::Lexer::parseNumberAfterDecimalPoint):
(JSC::Lexer::parseNumberAfterExponentIndicator):
(JSC::Lexer::lex):

  • parser/Lexer.h:
1:03 AM Changeset in webkit [66374] by Simon Hausmann
  • 2 edits in trunk/PlanetWebKit

Renamed Trolltech Labs to Qt Labs.

Reviewed by Tor Arne Vestbø.

  • config.ini:
12:45 AM Changeset in webkit [66373] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-30 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Kent Tamura.

Split webcore_svg off webcore_remaining. webcore_svg contains all svg
sources files.
​https://bugs.webkit.org/show_bug.cgi?id=44840

  • WebCore.gyp/WebCore.gyp:
12:44 AM Changeset in webkit [66372] by morrita@google.com
  • 7 edits
    1 add in trunk

2010-08-13 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.

  • platform/chromium/test_expectations.txt: Skips at this time and will rebaseline shortly.
  • platform/mac/Skipped: Mac doesn't suffer from the problem.
  • scrollbars/custom-scrollbar-with-incomplete-style.html: Added.

2010-08-13 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.

WebKit assumes outermost scrollbar always painted.
So force their style to have the background color if it isn't
given by the stylesheet.

Test: scrollbars/custom-scrollbar-with-incomplete-style.html

  • rendering/RenderObject.h: (WebCore::RenderObject::hasBackground): Extracted body to RenderStyle for sharing.
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): Added the workaround as mentioned above.
  • rendering/RenderScrollbar.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasBackground): Extracted from RenderObject.
12:35 AM Changeset in webkit [66371] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

WebCore::RenderBlock::addChild* NULL ptrs
​https://bugs.webkit.org/show_bug.cgi?id=43722

  • fast/ruby/before-doesnt-crash-expected.txt: Added.
  • fast/ruby/before-doesnt-crash.html: Added.

2010-08-30 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

WebCore::RenderBlock::addChild* NULL ptrs
​https://bugs.webkit.org/show_bug.cgi?id=43722

Also includes some cleanup of comments and ASSERTs.

Test: fast/ruby/before-doesnt-crash.html

  • rendering/RenderRuby.cpp: (WebCore::RenderRubyAsInline::addChild):
12:28 AM Changeset in webkit [66370] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-30 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Kent Tamura

Move most dependencies to webcore_prerequisites
​https://bugs.webkit.org/show_bug.cgi?id=44814

  • WebCore.gyp/WebCore.gyp:
12:15 AM Changeset in webkit [66369] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Adam Barth <​abarth@webkit.org>

Move AsyncImageResizer back to html to fix Chromium build.

  • WebCore.gypi:
12:13 AM Changeset in webkit [66368] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Adam Barth <​abarth@webkit.org>

Fix silly typo that breaks the build.

  • WebCore.pro:
12:07 AM Changeset in webkit [66367] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build.

  • WebCore.pri:
12:04 AM Changeset in webkit [66366] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-30 Adam Barth <​abarth@webkit.org>

Attempt to fix Chromium build.

  • WebCore.gyp/WebCore.gyp:
12:00 AM Changeset in webkit [66365] by abarth@webkit.org
  • 10 edits
    31 moves
    1 add in trunk/WebCore

2010-08-29 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Maciej Stachowiak.

Move File and Blob related files from WebCore/html to WebCore/fileapi.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi: Added.
  • fileapi/AsyncFileWriter.h: Copied from WebCore/html/AsyncFileWriter.h.
  • fileapi/Blob.cpp: Copied from WebCore/html/Blob.cpp.
  • fileapi/Blob.h: Copied from WebCore/html/Blob.h.
  • fileapi/Blob.idl: Copied from WebCore/html/Blob.idl.
  • fileapi/BlobBuilder.cpp: Copied from WebCore/html/BlobBuilder.cpp.
  • fileapi/BlobBuilder.h: Copied from WebCore/html/BlobBuilder.h.
  • fileapi/BlobBuilder.idl: Copied from WebCore/html/BlobBuilder.idl.
  • fileapi/BlobURL.cpp: Copied from WebCore/html/BlobURL.cpp.
  • fileapi/BlobURL.h: Copied from WebCore/html/BlobURL.h.
  • fileapi/File.cpp: Copied from WebCore/html/File.cpp.
  • fileapi/File.h: Copied from WebCore/html/File.h.
  • fileapi/File.idl: Copied from WebCore/html/File.idl.
  • fileapi/FileError.h: Copied from WebCore/html/FileError.h.
  • fileapi/FileError.idl: Copied from WebCore/html/FileError.idl.
  • fileapi/FileList.cpp: Copied from WebCore/html/FileList.cpp.
  • fileapi/FileList.h: Copied from WebCore/html/FileList.h.
  • fileapi/FileList.idl: Copied from WebCore/html/FileList.idl.
  • fileapi/FileReader.cpp: Copied from WebCore/html/FileReader.cpp.
  • fileapi/FileReader.h: Copied from WebCore/html/FileReader.h.
  • fileapi/FileReader.idl: Copied from WebCore/html/FileReader.idl.
  • fileapi/FileStreamProxy.cpp: Copied from WebCore/html/FileStreamProxy.cpp.
  • fileapi/FileStreamProxy.h: Copied from WebCore/html/FileStreamProxy.h.
  • fileapi/FileThread.cpp: Copied from WebCore/html/FileThread.cpp.
  • fileapi/FileThread.h: Copied from WebCore/html/FileThread.h.
  • fileapi/FileThreadTask.h: Copied from WebCore/html/FileThreadTask.h.
  • fileapi/FileWriter.cpp: Copied from WebCore/html/FileWriter.cpp.
  • fileapi/FileWriter.h: Copied from WebCore/html/FileWriter.h.
  • fileapi/FileWriter.idl: Copied from WebCore/html/FileWriter.idl.
  • fileapi/FileWriterClient.h: Copied from WebCore/html/FileWriterClient.h.
  • fileapi/ThreadableBlobRegistry.cpp: Copied from WebCore/html/ThreadableBlobRegistry.cpp.
  • fileapi/ThreadableBlobRegistry.h: Copied from WebCore/html/ThreadableBlobRegistry.h.
  • html/AsyncFileWriter.h: Removed.
  • html/Blob.cpp: Removed.
  • html/Blob.h: Removed.
  • html/Blob.idl: Removed.
  • html/BlobBuilder.cpp: Removed.
  • html/BlobBuilder.h: Removed.
  • html/BlobBuilder.idl: Removed.
  • html/BlobURL.cpp: Removed.
  • html/BlobURL.h: Removed.
  • html/File.cpp: Removed.
  • html/File.h: Removed.
  • html/File.idl: Removed.
  • html/FileError.h: Removed.
  • html/FileError.idl: Removed.
  • html/FileList.cpp: Removed.
  • html/FileList.h: Removed.
  • html/FileList.idl: Removed.
  • html/FileReader.cpp: Removed.
  • html/FileReader.h: Removed.
  • html/FileReader.idl: Removed.
  • html/FileStreamProxy.cpp: Removed.
  • html/FileStreamProxy.h: Removed.
  • html/FileThread.cpp: Removed.
  • html/FileThread.h: Removed.
  • html/FileThreadTask.h: Removed.
  • html/FileWriter.cpp: Removed.
  • html/FileWriter.h: Removed.
  • html/FileWriter.idl: Removed.
  • html/FileWriterClient.h: Removed.
  • html/ThreadableBlobRegistry.cpp: Removed.
  • html/ThreadableBlobRegistry.h: Removed.

Aug 29, 2010:

11:56 PM Changeset in webkit [66364] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Kent Tamura.

Move more common settings to webcore_prerequisites
​https://bugs.webkit.org/show_bug.cgi?id=44812

  • WebCore.gyp/WebCore.gyp:
11:54 PM Changeset in webkit [66363] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Fix Qt build.

  • wtf/unicode/glib/UnicodeMacrosFromICU.h: Added U_IS_BMP.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
  • wtf/unicode/wince/UnicodeWince.h: Ditto.
11:51 PM Changeset in webkit [66362] by Darin Adler
  • 212 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Create SVG and WML elements with create functions instead of direct invocations of new
​https://bugs.webkit.org/show_bug.cgi?id=44851

Added the create functions, made some existing constructors protected and private,
made some other member functions protected and and private, added some missing virtual
keywords for clarity to functions that already were overriding virtual functions,
fixed some inconsistent indentation, and removed some unneeded empty destructors.

In the future, it will be good to have the constructors all be private so we don't
use them by accident. Then we'll change the reference count rule globally and add
all the necessary calls to adoptRef.

The SVG changes are compiled and tested. The WML changes are speculative and untested.

  • dom/make_names.pl: Removed supportfor the createWithNew keyword.
  • svg/svgtags.in: Removed all the createWithNew keywords.
  • wml/WMLTagNames.in: Ditto.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::create): Added.
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::create): Added.
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::create): Added.
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::create): Added.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::create): Added.
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::create): Added.
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::create): Added.
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::create): Added.
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::create): Added.
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::create): Added.
  • svg/SVGDefsElement.h:
  • svg/SVGDescElement.cpp: (WebCore::SVGDescElement::create): Added.
  • svg/SVGDescElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::create): Added.
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::create): Added.
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::create): Added.
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::create): Added.
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::create): Added.
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::create): Added.
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::create): Added.
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::create): Added.
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::create): Added.
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::create): Added.
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::create): Added.
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::create): Added.
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::create): Added.
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::create): Added.
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::create): Added.
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::create): Added.
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::create): Added.
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::create): Added.
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::create): Added.
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::create): Added.
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::create): Added.
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::create): Added.
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::create): Added.
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::create): Added.
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::create): Added.
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::create): Added.
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::create): Added.
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::create): Added.
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::create): Added.
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::create): Added.
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::create): Added.
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::create): Added.
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::create): Added.
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::create): Added.
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::create): Added.
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::create): Added.
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::create): Added.
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::create): Added.
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::create): Added.
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::create): Added.
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::create): Added.
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::create): Added.
  • svg/SVGMaskElement.h:
  • svg/SVGMetadataElement.cpp: (SVGMetadataElement::create): Added.
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::create): Added.
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::create): Added.
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::create): Added.
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::create): Added.
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::create): Added.
  • svg/SVGPolylineElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::create): Added.
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::create): Added.
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::create): Added.
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::create): Added.
  • svg/SVGScriptElement.h:
  • svg/SVGSetElement.cpp: (WebCore::SVGSetElement::create): Added.
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::create): Added.
  • svg/SVGStopElement.h: (WebCore::SVGStyleElement::create): Added.
  • svg/SVGStyleElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::create): Added.
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::create): Added.
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::create): Added.
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::create): Added.
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::create): Added.
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::create): Added.
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::create): Added.
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::create): Added.
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::create): Added.
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::create): Added.
  • svg/SVGViewElement.h:
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::create): Added.
  • wml/WMLAElement.h:
  • wml/WMLAccessElement.cpp: (WebCore::WMLAccessElement::create): Added.
  • wml/WMLAccessElement.h:
  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::create): Added.
  • wml/WMLAnchorElement.h:
  • wml/WMLBRElement.cpp: (WebCore::WMLBRElement::create): Added.
  • wml/WMLBRElement.h:
  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::create): Added.
  • wml/WMLCardElement.h:
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::create): Added.
  • wml/WMLDoElement.h:
  • wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::create): Added.
  • wml/WMLFieldSetElement.h:
  • wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::create): Added.
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::create): Added.
  • wml/WMLGoElement.h:
  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::create): Added.
  • wml/WMLImageElement.h:
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::create): Added.
  • wml/WMLInputElement.h:
  • wml/WMLInsertedLegendElement.cpp: (WebCore::WMLInsertedLegendElement::create): Added.
  • wml/WMLInsertedLegendElement.h:
  • wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::create): Added.
  • wml/WMLMetaElement.cpp: (WebCore::WMLMetaElement::create): Added.
  • wml/WMLMetaElement.h:
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::create): Added.
  • wml/WMLNoopElement.h:
  • wml/WMLOnEventElement.cpp: (WebCore::WMLOnEventElement::create): Added.
  • wml/WMLOnEventElement.h:
  • wml/WMLOptGroupElement.cpp: (WebCore::WMLOptGroupElement::create): Added.
  • wml/WMLOptGroupElement.h:
  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::create): Added.
  • wml/WMLOptionElement.h:
  • wml/WMLPElement.cpp: (WebCore::WMLPElement::create): Added.
  • wml/WMLPElement.h:
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::create): Added.
  • wml/WMLPostfieldElement.h:
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::create): Added.
  • wml/WMLPrevElement.h:
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::create): Added.
  • wml/WMLRefreshElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::create): Added.
  • wml/WMLSelectElement.h:
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::create): Added.
  • wml/WMLSetvarElement.h:
  • wml/WMLTableElement.cpp: (WebCore::WMLTableElement::create): Added.
  • wml/WMLTableElement.h:
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::create): Added.
  • wml/WMLTaskElement.h:
  • wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::create): Added.
  • wml/WMLTemplateElement.h:
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::create): Added.
  • wml/WMLTimerElement.h:
11:37 PM Changeset in webkit [66361] by tkent@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed, add missing bug URL for the last my commit.

11:31 PM Changeset in webkit [66360] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Kent Tamura.

Rename webcore to 'webcore_remaining'.
Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore

Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.

  • WebCore.gyp/WebCore.gyp:
11:31 PM Changeset in webkit [66359] by abarth@webkit.org
  • 8 edits in trunk

2010-08-29 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Move UTF16 LEAD/TRAIL logic into the HTMLEntityParser
​https://bugs.webkit.org/show_bug.cgi?id=44790

We now block this attack.

  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
11:12 PM Changeset in webkit [66358] by jeremy@chromium.org
  • 5 edits
    2 moves in trunk/WebCore

2010-08-29 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa

​https://bugs.webkit.org/show_bug.cgi?id=41398

Just moving files around so no new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
  • platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
  • platform/graphics/mac/FontPlatformData.h: Removed.
  • platform/graphics/mac/FontPlatformDataMac.mm: Removed.
10:11 PM Changeset in webkit [66357] by tkent@chromium.org
  • 11 edits in trunk

Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement
​https://bugs.webkit.org/show_bug.cgi?id=43537

Reviewed by Darin Adler.

WebCore:

isValidValue() is useful for browser implementations to propose
form field values without breaking form validity.
No new tests because these functions are not exposed to JavaScript.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::):

Remove virtual valueMissing(), patternMismatch(), and tooLong().

  • html/HTMLInputElement.cpp:

(WebCore::isValidColorString): Moved from ValidityState.
(WebCore::isValidEmailAddress): ditto.
(WebCore::HTMLInputElement::isValidValue): Added.
(WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
(WebCore::HTMLInputElement::valueMissing): Add a String parameter.
(WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
(WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
(WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
(WebCore::HTMLInputElement::stepMismatch): Add a String parameter.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLTextAreaElement::isValidValue): Added.

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing):

  • html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
(WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
(WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().

  • html/ValidityState.h:

WebKit/chromium:

  • public/WebInputElement.h:
  • src/WebInputElement.cpp:

(WebKit::WebInputElement::isValidValue):

9:55 PM Changeset in webkit [66356] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change for r66282.

  • platform/chromium-win/inspector/console-format-expected.txt: Added.
9:47 PM Changeset in webkit [66355] by tkent@chromium.org
  • 36 edits in trunk

Change lower and higher limits of date/datetime/datetime-local/month/week types
​https://bugs.webkit.org/show_bug.cgi?id=39737

Reviewed by Darin Adler.

WebCore:

According to the latest draft of HTML5, ISO-8601 dates in HTML5
should support A.D.0001 in Gregorian calendar though Gregorian
calendar started in 1582. So, we change the lower limits of
date&time types to 0001-01-01T00:00.

We also introduce the common higher limit, 275760-09-13T00:00. It
is the higher limit of Date type of ECMAScript.

  • html/DateComponents.cpp:

(WebCore::DateComponents::parseYear):

Rejects years less than A.D.1 and years greater than 275760.

(WebCore::withinHTMLDateLimits):

Helper functions to check lower and higher limits.

(WebCore::DateComponents::addDay):

  • Remove an overflow check. 'year' can't be so large number because parseYear() rejects such numbers.
  • Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::addMinute):

  • Add an assertion for the base date.
  • Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::parseMonth):

Add withinHTMLDateLimits() call.

(WebCore::DateComponents::parseDate): ditto.
(WebCore::DateComponents::parseWeek): ditto.
(WebCore::DateComponents::parseDateTimeLocal): ditto.
(WebCore::DateComponents::parseDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDate): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth): ditto.
(WebCore::DateComponents::setMonthsSinceEpoch):

Add year range check and withinHTMLDateLimits() call.

(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

Add year range check and week range check.

  • html/DateComponents.h: Update minimum/maximum constant values.

(WebCore::DateComponents::minimumDate):
(WebCore::DateComponents::minimumDateTime):
(WebCore::DateComponents::minimumMonth):
(WebCore::DateComponents::minimumWeek):
(WebCore::DateComponents::maximumDate):
(WebCore::DateComponents::maximumDateTime):
(WebCore::DateComponents::maximumMonth):
(WebCore::DateComponents::maximumWeek):

LayoutTests:

Update tests and test results for the new DateComponents behavior.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-date-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
  • fast/forms/ValidityState-typeMismatch-month-expected.txt:
  • fast/forms/ValidityState-typeMismatch-week-expected.txt:
  • fast/forms/input-valueasdate-date-expected.txt:
  • fast/forms/input-valueasdate-datetime-expected.txt:
  • fast/forms/input-valueasdate-month-expected.txt:
  • fast/forms/input-valueasdate-week-expected.txt:
  • fast/forms/input-valueasnumber-date-expected.txt:
  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/input-valueasnumber-datetimelocal-expected.txt:
  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/input-valueasnumber-week-expected.txt:
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js:
  • fast/forms/script-tests/input-valueasdate-date.js:
  • fast/forms/script-tests/input-valueasdate-datetime.js:
  • fast/forms/script-tests/input-valueasdate-month.js:
  • fast/forms/script-tests/input-valueasdate-week.js:
  • fast/forms/script-tests/input-valueasnumber-date.js:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
  • fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
  • fast/forms/script-tests/input-valueasnumber-month.js:
  • fast/forms/script-tests/input-valueasnumber-week.js:
9:38 PM Changeset in webkit [66354] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change for r66296.

  • platform/chromium/test_expectations.txt:
9:25 PM Changeset in webkit [66353] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-29 James Robinson <​jamesr@chromium.org>

Reviewed by David Levin.

Make failing the download step fail the build
​https://bugs.webkit.org/show_bug.cgi?id=44298

If the download step fails on a test bot, this ensures that
the build goes red instead of only the download step going red
and the overall build staying green.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
9:16 PM Changeset in webkit [66352] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
9:07 PM Changeset in webkit [66351] by tkent@chromium.org
  • 4 edits in trunk

2010-08-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
​https://bugs.webkit.org/show_bug.cgi?id=44847

  • DEPS: Roll Chromium revision to 57823 to have a webkit_support change.

2010-08-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
​https://bugs.webkit.org/show_bug.cgi?id=44847

  • DumpRenderTree/chromium/EventSender.cpp: Use webkit_support::VKEY_* instead of base::VKEY_*.
8:26 PM Changeset in webkit [66350] by Darin Adler
  • 2 edits in trunk/WebKitTools

​https://bugs.webkit.org/show_bug.cgi?id=40589

  • Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty

function names.

7:41 PM Changeset in webkit [66349] by yuzo@google.com
  • 62 edits
    11 copies
    6 adds
    19 deletes in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change for r66306.

  • platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Added.
  • platform/chromium-linux/fast/forms/formmove3-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
  • platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Added.
  • platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Added.
  • platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/formmove3-expected.png: Removed.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
  • platform/chromium-win/fast/forms/form-added-to-table-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.checksum:
  • platform/chromium-win/fast/forms/formmove3-expected.png:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt:
  • platform/chromium-win/fast/table/insert-cell-before-form-expected.txt:
  • platform/chromium-win/fast/table/insert-row-before-form-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [66348] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-08-29 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SharedBuffer::createWithContentsOfFile
​https://bugs.webkit.org/show_bug.cgi?id=34412

Implement SharedBuffer::createWithContentsOfFile with IFile.

  • platform/brew/SharedBufferBrew.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
6:54 PM Changeset in webkit [66347] by zecke@webkit.org
  • 4 edits in trunk/WebKitTools

[iExploder] Add new CSS Properties and HTML Attributes

​https://bugs.webkit.org/show_bug.cgi?id=44746

Updated the files with the update-iexploder-cssproperties script
and manually readded the -webkit-binding CSS Property to the list.

  • iExploder/htdocs/cssproperties.in:
  • iExploder/htdocs/htmlattrs.in:
  • iExploder/htdocs/htmltags.in:
6:53 PM Changeset in webkit [66346] by zecke@webkit.org
  • 3 edits in trunk/WebKitTools

Fix Coverage build after the addition of ANGLE

​https://bugs.webkit.org/show_bug.cgi?id=44744

ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.

This is achieved by applying the XCode options for each project
separately and exclude ANGLE.

  • Scripts/build-webkit: Remove -framework AppKit due link errors.
  • Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
6:46 PM Changeset in webkit [66345] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-29 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port vprintf_stderr_common
​https://bugs.webkit.org/show_bug.cgi?id=33568

Use BREW's DBGPRINTF to output debug messages.

  • wtf/Assertions.cpp:
6:31 PM Changeset in webkit [66344] by enrica@apple.com
  • 5 edits in trunk

WebCore: Crash when dragging text in Google Docs
​https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

This fixes the crash but also fixes the generated markup when
performing a replacement at the border with an inline, to avoid the
new content being merged into the inline.
The crash is happening when doApply detects the need of merging
the start and the end of the new paragraph and the destination position
is moved inside an inline.

I've added new test cases to an existing layout test.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): When the situation described above is detected,
we insert a placeholder to avoid merging into the inline.

LayoutTests: Crash when dragging text in Google Docs
​https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

Added new test cases to an exisisting file and updated the result to reflect
the correct behavior.

  • editing/selection/replace-selection-crash-expected.txt:
  • editing/selection/replace-selection-crash.html:
6:16 PM Changeset in webkit [66343] by abarth@webkit.org
  • 4 edits in trunk

2010-08-29 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
​https://bugs.webkit.org/show_bug.cgi?id=29000

Update expectations for this pasteboard test to include our new friend
fakepath.

  • editing/pasteboard/file-input-files-access-expected.txt:

2010-08-29 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
​https://bugs.webkit.org/show_bug.cgi?id=29000

The HTML 5 spec says to prepend C:\fakepath\ to the value of an
<input type="file"> control, so that's what we do now.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value):
5:36 PM Changeset in webkit [66342] by commit-queue@webkit.org
  • 3 edits
    2 moves in trunk/WebCore

2010-08-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66329.
​http://trac.webkit.org/changeset/66329
​https://bugs.webkit.org/show_bug.cgi?id=44845

broke chromium mac (Requested by jamesr on #webkit).

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/FontPlatformData.h: Renamed from WebCore/platform/graphics/cocoa/FontPlatformData.h. (WebCore::toCTFontRef): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::isColorBitmapFont): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/mac/FontPlatformDataMac.mm: Renamed from WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm. (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::ctFont): (WebCore::FontPlatformData::description):
5:10 PM Changeset in webkit [66341] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-08-29 Adam Barth <​abarth@webkit.org>

Attempt to make Sam's life easier by not opening a comment text field
if there's a selection. This should make it easier to copy/paste text
out of the diff without accidentally opening comment boxes.

  • code-review.js:
4:56 PM Changeset in webkit [66340] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

fast/loader/input-element-page-cache-crash.html fails on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=44811

Make test not rely on page cache behavior (window.finishTest being
persisted), instead use sessionStorage.

  • fast/loader/input-element-page-cache-crash.html:
  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [66339] by Simon Fraser
  • 12 edits
    6 adds in trunk

2010-08-29 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

When properties are missing from animation keyframes, interpolate between those keyframes that specify them
​https://bugs.webkit.org/show_bug.cgi?id=40794

When a property does not appear in all keyframes of a keyframe animation, we currently use the
value of that property from the unanimated style. That forces the author to use additional
keyframes for properties that need to "skip a keyframe", which is laborious.

With this change, properties are interpolated between the keyframes in which they appear.
This is equivalent to splitting each property out into its own set of keyframes.

Tests: animations/missing-keyframe-properties-repeating.html

animations/missing-keyframe-properties-timing-function.html
animations/missing-keyframe-properties.html

  • css/CSSStyleSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForKeyframe): Pass a KeyframeValue in so that we can collect which properties are represented per keyframe. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Keyframes are inserted into a KeyframeList by object now, rather than by key and style.
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): Use AnimationDirectionAlternate for readability.
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Renamed from getKeyframeAnimationInterval. Use fractionalTime etc to match AnimationBase::progress(), and do lookups per-property. Simplify the code that finds the relevant keyframe to do less work. (WebCore::KeyframeAnimation::animate): Call fetchIntervalEndpointsForProperty() for each property, rather than just once for the entire keyframe. (WebCore::KeyframeAnimation::getAnimatedStyle): Ditto. (WebCore::KeyframeAnimation::hasAnimationForProperty): FIXME comment.
  • page/animation/KeyframeAnimation.h: Rename getKeyframeAnimationInterval() to fetchIntervalEndpointsForProperty().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): For hardware animations, only insert values for keyframes which contain the property.

(WebCore::KeyframeList::KeyframeList): insert() takes a KeyframeValue now.

  • rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::operator==): (WebCore::KeyframeList::insert): Fix insert/replace logic, and ensure we maintain the m_properties hash.
  • rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): Make members private, with accessors. Add a m_properties HashSet for the properties animated in this keyframe.
3:09 PM Changeset in webkit [66338] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
​https://bugs.webkit.org/show_bug.cgi?id=44843

  • editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within
2:28 PM Changeset in webkit [66337] by Darin Adler
  • 2 edits in trunk/WebCore

Try to fix Mac build.

  • WebCore.xcodeproj/project.pbxproj: Mark CounterContent.h Private instead of Project.
1:46 PM Changeset in webkit [66336] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Pawel Hajdan <​phajdan.jr@chromium.org>

Reviewed by Darin Adler.

Fix libxml workarounds to work with recent versions of libxml.
I was testing locally with libxml2-2.7.6.
​https://bugs.webkit.org/show_bug.cgi?id=30508

Based on patch by Philippe Normand <​pnormand@igalia.com>.

This also fixes a Chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=29333

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::startDocumentHandler):
1:41 PM Changeset in webkit [66335] by Darin Adler
  • 5 edits in trunk/WebCore

Try to fix Windows build.

  • rendering/style/ContentData.h: Added include of CounterContent.h.
  • css/CSSStyleSelector.cpp: Removed include of CounterContent.h.
  • rendering/style/ContentData.cpp: Ditto.
  • rendering/style/RenderStyle.cpp: Ditto.
12:56 PM Changeset in webkit [66334] by Darin Adler
  • 23 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Deploy OwnPtr, PassOwnPtr, and adoptPtr in some CSS-related files
​https://bugs.webkit.org/show_bug.cgi?id=44834

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::CSSFunctionValue): Updated since CSSParserFunction::args is an OwnPtr. (WebCore::CSSFunctionValue::parserValue): Ditto.
  • css/CSSGrammar.y: Added leakPtr calls for putting MediaQueryExp* into the media query expression list, which is a vector of raw pointers that are deleted explicitly.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Updated to use document instead of doc. (WebCore::CSSImportRule::insertedIntoParent): Ditto.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Ditto.
  • css/CSSNamespace.h: Took the "m_" off the names of the data members of this structure. Used OwnPtr for the parent data member. Rewrote the namespaceForPrefix function so it's iterative instead of recursive.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Update since m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList are now all OwnPtr and thus don't need to be initialized. (WebCore::CSSParser::~CSSParser): Update to not delete the above OwnPtr. (WebCore::CSSParser::parseMediaQuery): Replaced the code that sets m_mediaQuery to 0 with an assertion. Also use release when passing the media query to appendMediaQuery. (WebCore::CSSParser::document): Updated to use document instead of doc and to use early return instead of a nested if. (WebCore::CSSParser::parseContent): Added a get() call needed since CSSParserFunction::args is an OwnPtr. (WebCore::CSSParser::parseAnimationTimingFunction): Ditto. (WebCore::CSSParser::parseDashboardRegions): Ditto. (WebCore::CSSParser::parseShape): Ditto. (WebCore::isValidFormatFunction): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseColorParameters): Ditto. (WebCore::CSSParser::parseHSLParameters): Ditto. (WebCore::parseGradientColorStop): Ditto. (WebCore::CSSParser::parseGradient): Ditto. (WebCore::CSSParser::parseCanvas): Ditto. (WebCore::CSSParser::parseTransform): Ditto. (WebCore::CSSParser::createFloatingMediaQueryExp): Updated to use adoptPtr and remove the explicit deletion. (WebCore::CSSParser::sinkFloatingMediaQueryExp): Updated to use release. (WebCore::CSSParser::createFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::sinkFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::createFloatingMediaQuery): Ditto. (WebCore::CSSParser::sinkFloatingMediaQuery): Ditto. (WebCore::CSSParser::checkForVariables): Use get for CSSParserFunction::args.
  • css/CSSParser.h: Made return values for sinkFloatingMediaQueryExp, sinkFloatingMediaQueryExpList, and sinkFloatingMediaQuery be PassOwnPtr. Made createFloatingMediaQuery take a PassOwnPtr. Made m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList be OwnPtr.
  • css/CSSParserValues.h: Made args be an OwnPtr.
  • css/CSSStyleSelector.cpp: Made CSSRuleSet m_universalRules and m_pageRules be OwnPtr. (WebCore::CSSStyleSelector::CSSStyleSelector): Use document instead of doc. Got rid of the init function, only called here, because it did nothing that wasn't already done. Eliminated unneeded code to set m_userStyle to 0, since it's now an OwnPtr and will be 0 automatically. Use adoptPtr when initializing m_medium, m_authorStyle, and m_useStyle. (WebCore::CSSStyleSelector::~CSSStyleSelector): Got rid of unneeded delete of m_medium, m_authorStyle, and m_userStyle, and unneded clear of m_keyframesRuleMap. (WebCore::CSSStyleSelector::styleForElement): Use get with m_userStyle and m_authorStyle. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleForPage): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto. (WebCore::CSSRuleSet::CSSRuleSet): Got rid of unneeded initialization of m_universalRules and m_pageRules. (WebCore::CSSRuleSet::~CSSRuleSet): Got rid of unneeed deletion of same. (WebCore::CSSRuleSet::addRule): Use adoptPtr to initialize m_universalRules. (WebCore::CSSRuleSet::addPageRule): Use adoptPtr to initialize m_pageRules. (WebCore::CSSStyleSelector::applyProperty): Use adopPtr to create counter context object.
  • css/CSSStyleSelector.h: Made m_authorStyle, m_userStyle, and m_medium use OwnPtr. Got rid of init function.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): Updatd for name change from m_doc and doc to m_document and document. Eliminated unneeded initialization of m_namespaces now that it is an OwnPtr. (WebCore::CSSStyleSheet::~CSSStyleSheet): Got rid of unneeded deletion of same. (WebCore::CSSStyleSheet::cssRules): Updated doc to document. (WebCore::CSSStyleSheet::addNamespace): Added adopPtr when setting m_namespaces. (WebCore::CSSStyleSheet::determineNamespace): Updated for changes to the CSSNamespace class, using uri data member instead of function. (WebCore::CSSStyleSheet::styleSheetChanged): Use document instead of doc.
  • css/CSSStyleSheet.h: Renamed doc and m_doc to document and m_document. Made m_namespaces an OwnPtr.
  • css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): Clean up logic a bit. (WebCore::CSSValueList::createParserValueList): Clean up logic a bit and return a PassOwnPtr.
  • css/CSSValueList.h: Changed createParserValueList to return a PassOwnPtr.
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): Updated to use document instead of doc.
  • css/MediaList.cpp: (WebCore::MediaList::deleteMedium): Use OwnPtr instead of a boolean to make sure the newly-created query here is deleted. (WebCore::MediaList::appendMediaQuery): Updated to take PassOwnPtr.
  • css/MediaList.h: Changed appendMediaQuery to take a PassOwnPtr.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSheet): Use document instead of doc. (WebCore::InspectorDOMAgent::getRuleRanges): Ditto. (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Update since data members are OwnPtr. Also, fixed iterative deletion algorithm to be much simpler. (WebCore::ContentData::dataEquivalent): Added FIXMEs and tweaked formatting. (WebCore::ContentData::deleteContent): Tweaked formatting.
  • rendering/style/ContentData.h: Changed m_next to an OwnPtr. Added assertions to getters to check that we get the correct type. Use leakRef instead of releaseRef. Changed setCounter and setNext functions to take PassOwnPtr arguments.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::prepareToSetContent): Refactored common part of the into a shared function so the three setContent functions don't have to repeat the logic. Used an OwnPtr to avoid confusing logic and leakPtr. (WebCore::RenderStyle::setContent): Changed argument to PassOwnPtr.
  • rendering/style/RenderStyle.h: Changed setContent argument to a PassOwnPtr. Added declaration of prepareToSetContent helper function.
11:04 AM Changeset in webkit [66333] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-08-29 Adam Barth <​abarth@webkit.org>

Turns out we're supposed to use find instead of children here.

  • code-review.js:
10:59 AM Changeset in webkit [66332] by abarth@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/BugsSite

2010-08-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Awesomify pretty-diff based review tool
​https://bugs.webkit.org/show_bug.cgi?id=44835

This patch replaces the existing inline comment feature with a new
implementation. Hopefully the new implementation is more awesome.
It's not 100% done yet, but I'd like to get this version out there to
see how it works.

Unlike the previous version this version works with the "Formatted
Diff" link instead of the "Review Patch" link. Hopefully that will
avoid interfering with folks who like the old style review.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js: Added.
  • prototype.js: Removed.
7:12 AM Changeset in webkit [66331] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port ScrollbarThemeWin to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=44818

Add a #ifdef around usage of unsupported DFCS_FLAT.

  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintButton):
6:55 AM Changeset in webkit [66330] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port SystemInfo to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=44817

  • platform/win/SystemInfo.cpp: (WebCore::isRunningOnVistaOrLater):
Note: See TracTimeline for information about the timeline view.