Timeline
Aug 31, 2010:
- 11:44 PM Changeset in webkit [66583] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Remove a duplicated expectation.
- 11:16 PM Changeset in webkit [66582] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Add recent failures.
- 11:14 PM Changeset in webkit [66581] by
-
- 3 edits2 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=44915
Need to handle CSSValueAuto in CSSPrimitiveValue::operator ETextAlign()
Reviewed by Dan Bernstein.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map TAAUTO to -webkit-auto. "auto" is
not a valid text-align value. We use TAAUTO internally for the nameless value that acts
as left if direction:ltr and right for direction:rtl.
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=44915
Need to handle CSSValueAuto in CSSPrimitiveValue::operator ETextAlign()
Reviewed by Dan Bernstein.
- fast/css/text-align-webkit-auto-expected.txt: Added.
- fast/css/text-align-webkit-auto.html: Added.
- 11:11 PM Changeset in webkit [66580] by
-
- 1 edit in trunk/WebKit/win/WebFrame.cpp
Fix Win build bustage.
- 11:08 PM Changeset in webkit [66579] by
-
- 1 edit in trunk/WebCore/page/Frame.cpp
Fix Qt build bustage. Why are these tiled backing store functions defined on Frame and not FrameView anyway? Fail.
- 11:04 PM Changeset in webkit [66578] by
-
- 3 edits1 add in trunk/WebCore
2010-08-31 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Martin Robinson.
[EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44508
Add PlatformVideoWindowEfl.cpp in order to use gstreamer by
WebKit EFL.
- platform/graphics/gstreamer/PlatformVideoWindow.h: (WebCore::PlatformVideoWindow::window): (WebCore::PlatformVideoWindow::videoWindowId):
- platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Added. (PlatformVideoWindow::PlatformVideoWindow): (PlatformVideoWindow::~PlatformVideoWindow):
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Include <gtk/gtk.h> directly.
- 10:59 PM Changeset in webkit [66577] by
-
- 33 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- WebCore.exp.in:
- page/FocusController.cpp:
(WebCore::FocusController::setActive):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::layout):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/FrameView.h:
- page/Page.cpp:
(WebCore::Page::scheduleForcedStyleRecalcForAllPages):
- page/Page.h:
- page/Settings.cpp:
(WebCore::setNeedsRecalcStyleInAllFrames):
(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setZoomMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::platformColorsDidChange):
WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::layout):
WebKit/efl: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- ewk/ewk_view.cpp:
(ewk_view_layout_if_needed_recursive):
WebKit/gtk: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- webkit/webkitwebview.cpp:
(webkit_web_view_expose_event):
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
Eliminate Mac-specific code for style re-application and recursive layout/style updating in
favor of the cross-platform code that all the other ports use.
- Carbon/HIWebView.mm:
(Draw):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::forceLayout):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
(-[WebHTMLView viewWillDraw]):
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
(-[WebHTMLView setNeedsToApplyStyles:]):
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView _layoutIfNeeded]):
(-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebView.mm:
(-[WebView _viewWillDrawInternal]):
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- Api/qwebelement.cpp:
(QWebElement::render):
- Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- WebFrame.cpp:
(WebFrame::paintDocumentRectToContext):
- WebView.cpp:
(WebView::updateBackingStore):
WebKit/wx: https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
Reviewed by Sam Weinig.
- WebView.cpp:
(wxWebView::OnPaint):
WebKit2: https://bugs.webkit.org/show_bug.cgi?id=44863
Reviewed by Sam Weinig.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::layoutIfNeeded):
- 10:46 PM Changeset in webkit [66576] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-31 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add WebKitClient::callOnMainThreadWithDelay()
https://bugs.webkit.org/show_bug.cgi?id=45016
It is required to remove base/task.h and base/timer.h dependency
from DRT/Chromium.
- public/WebKitClient.h: (WebKit::WebKitClient::callOnMainThreadWithDelay): Added.
- 10:21 PM Changeset in webkit [66575] by
-
- 4 adds in trunk/LayoutTests
Add test case I forgot to add from previous multicol checkin.
- 9:49 PM Changeset in webkit [66574] by
-
- 4 edits2 adds1 delete in trunk/WebCore
2010-08-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
Unfork Chromium's FontPlatformDataChromiumMac.mm.
Modified FontPlatformDataCocoa to provide hooks needed by Chromium.
Moved Chromium's mechanics for OOP font loading to CrossProcessFontLoading.mm.
Added ::create() function to MemoryActivatedFont to match new guidelines for
RefCounted<> classes.
Not possible to test due to sandbox interaction.
- WebCore.gypi: Update files for chromium build.
- platform/graphics/chromium/CrossProcessFontLoading.h: Added. (WebCore::MemoryActivatedFont::cgFont): (WebCore::MemoryActivatedFont::atsFontRef):
- platform/graphics/chromium/CrossProcessFontLoading.mm: Added. (WebCore::MemoryActivatedFont::create): (WebCore::MemoryActivatedFont::MemoryActivatedFont): (WebCore::MemoryActivatedFont::~MemoryActivatedFont): (WebCore::FontPlatformData::loadFont):
- platform/graphics/chromium/FontPlatformDataChromiumMac.mm: Removed.
- platform/graphics/cocoa/FontPlatformData.h:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::loadFont): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont):
- 9:27 PM Changeset in webkit [66573] by
-
- 2 edits in trunk/WebCore
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] warning: unused variable "queryResult"
https://bugs.webkit.org/show_bug.cgi?id=44998
No new tests as functionality has not changed.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen): Move queryResult within the gstreamer version guards, where it is used.
- 8:32 PM Changeset in webkit [66572] by
-
- 2 edits in trunk/WebCore
Refinement to previous checkin for pagination of block-level replaced elements. Don't bother to
paginate floating block-level replaced elements for now.
Reviewed by Adam Roben.
Added fast/multicol/float-pagination-failure.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
- 8:30 PM Changeset in webkit [66571] by
-
- 2 edits in trunk/WebKitTools
2010-08-31 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Adam Barth.
Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
https://bugs.webkit.org/show_bug.cgi?id=44789
- Scripts/webkitpy/common/net/bugzilla.py:
- 8:27 PM Changeset in webkit [66570] by
-
- 12 edits in trunk
2010-08-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Add LocalFileSystem.requestFileSystem interface to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=44734
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableFileSystem): (WebKit::WebRuntimeFeatures::isFileSystemEnabled):
2010-08-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Add LocalFileSystem.requestFileSystem interface to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=44734
No new tests; tests will be added later.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::fileSystemEnabled): (WebCore::RuntimeEnabledFeatures::setFileSystemEnabled): (WebCore::RuntimeEnabledFeatures::requestFileSystemEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
- page/DOMWindow.h: (WebCore::DOMWindow::):
- page/DOMWindow.idl:
- page/Settings.cpp: (WebCore::Settings::setFileSystemRootPath):
- page/Settings.h: (WebCore::Settings::fileSystemRootPath):
- 8:12 PM Changeset in webkit [66569] by
-
- 2 edits in trunk/WebCore
2010-08-31 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Add PLATFORM(BREWMP) guard to PluginViewNone
https://bugs.webkit.org/show_bug.cgi?id=44768
Build fix. Add PLATFORM(BREWMP) guard to add dummy PluginView::privateBrowsingStateChanged
and PluginView::setJavaScriptPaused.
- plugins/PluginViewNone.cpp:
- 7:47 PM Changeset in webkit [66568] by
-
- 5 edits2 adds in trunk
2010-08-31 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=40947
<rdar://problem/8124723> REGRESSION (r57544): XMLHttpRequest POSTed multipart/form-data
wrongfully gets a charset appended
- http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt:
- http/tests/xmlhttprequest/request-encoding2.html: Updated tests that has wrong expectations.
- http/tests/xmlhttprequest/post-with-boundary-expected.txt: Added.
- http/tests/xmlhttprequest/post-with-boundary.html: Added. Added a new test, sending a valid multipart form with boundary.
2010-08-31 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=40947
<rdar://problem/8124723> REGRESSION (r57544): XMLHttpRequest POSTed multipart/form-data
wrongfully gets a charset appended
Test: http/tests/xmlhttprequest/post-with-boundary.html
- xml/XMLHttpRequest.cpp: (WebCore::replaceCharsetInMediaType): Changed to only set charset if it was already present, and never append. (WebCore::XMLHttpRequest::send): Updated for replaceCharsetInMediaType renaming.
- 7:11 PM Changeset in webkit [66567] by
-
- 3 edits1 move5 adds in trunk/WebCore
2010-08-31 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Implement Readable/Writable versions of ChromiumDataObjectNew
https://bugs.webkit.org/show_bug.cgi?id=44917
This is the second of several patches to update Chromium to support
arbitrary data types in event.dataTransfer.
ReadableDataObject simply calls through to several Chromium IPCs to
retrieve the appropriate data.
WritableDataObject ostensibly buffers arbitrary data internally until
a call is made to flush the data to the platform-specific abstraction;
unfortunately, a special exception is currently made for pasteboard
handling due to how it is handled in WebCore.
No new tests.
- WebCore.gypi:
- platform/chromium/ChromiumDataObjectNew.h: Removed.
- platform/chromium/ClipboardChromium.cpp:
- platform/chromium/ClipboardMimeTypes.cpp: Added.
- platform/chromium/ClipboardMimeTypes.h: Added.
- platform/chromium/ReadableDataObject.cpp: Added. (WebCore::clipboardBuffer): (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::hasData): (WebCore::ReadableDataObject::types): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::getURL): (WebCore::ReadableDataObject::getHTML): (WebCore::ReadableDataObject::hasFilenames): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
- platform/chromium/ReadableDataObject.h: Added.
- platform/chromium/WritableDataObject.cpp: Added. (WebCore::WritableDataObject::create): (WebCore::WritableDataObject::WritableDataObject): (WebCore::WritableDataObject::clearData): (WebCore::WritableDataObject::clearAllExceptFiles): (WebCore::WritableDataObject::clearAll): (WebCore::WritableDataObject::setData): (WebCore::WritableDataObject::setURL): (WebCore::WritableDataObject::setHTML): (WebCore::WritableDataObject::dataMap): (WebCore::WritableDataObject::urlTitle): (WebCore::WritableDataObject::htmlBaseURL): (WebCore::WritableDataObject::fileExtension): (WebCore::WritableDataObject::fileContentFilename): (WebCore::WritableDataObject::fileContent): (WebCore::WritableDataObject::setFileExtension): (WebCore::WritableDataObject::setFileContentFilename): (WebCore::WritableDataObject::setFileContent):
- platform/chromium/WritableDataObject.h: Added.
- 7:00 PM Changeset in webkit [66566] by
-
- 2 edits in trunk/LayoutTests
Fix gtk bot.
- platform/gtk/Skipped: Skip the webarchive/loading/missing-data.html for the same reason
the nearly identical webarchive/loading/mainresource-null-mimetype-crash.html is skipped.
- 6:55 PM Changeset in webkit [66565] by
-
- 2 edits in trunk/WebKit/qt
2010-08-31 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] tst_QWebPage::originatingObjectInNetworkRequests() fails on trunk
https://bugs.webkit.org/show_bug.cgi?id=45001
Fix the test, we should not use data encoded URL since we are not
setting an URL but setting the substituteData directly.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::originatingObjectInNetworkRequests):
- 6:16 PM Changeset in webkit [66564] by
-
- 5 edits in trunk/WebKitTools
2010-08-31 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Barth.
ews: Add support for EFL-EWS
https://bugs.webkit.org/show_bug.cgi?id=44982
- QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
- Scripts/webkitpy/common/config/ports.py: Define a EflPort class and add it to the ports dict.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a EflEWS class.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add a test case for the EFL EWS.
- 6:07 PM Changeset in webkit [66563] by
-
- 8 edits in trunk/LayoutTests
2010-08-31 Tony Chang <tony@chromium.org>
Unreviewed, update pngs where the checksum is correct, but the png doesn't match.
- platform/chromium-linux/fast/dom/attr_dead_doc-expected.png:
- platform/chromium-linux/fast/frames/content-opacity-1-expected.png:
- platform/chromium-linux/fast/frames/content-opacity-2-expected.png:
- platform/chromium-linux/fast/frames/iframe-text-contents-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png:
- 6:02 PM Changeset in webkit [66562] by
-
- 3 edits2 copies1 add in trunk
Null-deref when decoding web archive with no data key in LegacyWebArchive::createResource
https://bugs.webkit.org/show_bug.cgi?id=45000
Reviewed by Sam Weinig.
WebCore:
Test: webarchive/loading/missing-data.html
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource): Use wrapCFData instead of CFDataGetBytePtr/GetLength,
which is both more efficient, and can handle null. Also fixed incorrect use of ParsedURLString,
since the string is coming from a file and so there are no guarantees about its format.
LayoutTests:
- webarchive/loading/missing-data-expected.txt: Added.
- webarchive/loading/missing-data.html: Added.
- webarchive/loading/resources/missing-data.webarchive: Added.
- 5:56 PM Changeset in webkit [66561] by
-
- 1 edit303 adds in trunk/LayoutTests
2010-08-31 Tony Chang <tony@chromium.org>
Unreviewed. Add pngs for chromium linux results that have checksums.
- platform/chromium-linux/css2.1/t0505-c16-descendant-01-e-expected.png: Added.
- platform/chromium-linux/css2.1/t0509-c15-ids-01-e-expected.png: Added.
- platform/chromium-linux/css2.1/t1205-c563-list-type-00-b-expected.png: Added.
- platform/chromium-linux/css2.1/t1205-c564-list-img-00-b-g-expected.png: Added.
- platform/chromium-linux/editing/deleting/4845371-expected.png: Added.
- platform/chromium-linux/editing/deleting/4922367-expected.png: Added.
- platform/chromium-linux/editing/deleting/5156801-2-expected.png: Added.
- platform/chromium-linux/editing/deleting/5300379-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-3608430-fix-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-3608462-fix-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-4083333-fix-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-004-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-005-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-006-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-br-007-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-character-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-hr-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-image-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-image-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-image-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-leading-ws-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-listitem-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-listitem-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-selection-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-tab-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-tab-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-tab-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-tab-004-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-trailing-ws-001-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-ws-fixup-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/delete-ws-fixup-004-expected.png: Added.
- platform/chromium-linux/editing/deleting/list-item-1-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-different-styles-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-into-empty-block-2-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-unrendered-space-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png: Added.
- platform/chromium-linux/editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
- platform/chromium-linux/editing/deleting/pruning-after-merge-2-expected.png: Added.
- platform/chromium-linux/editing/deleting/smart-delete-003-expected.png: Added.
- platform/chromium-linux/editing/deleting/table-cells-expected.png: Added.
- platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Added.
- platform/chromium-linux/editing/execCommand/4916402-expected.png: Added.
- platform/chromium-linux/editing/execCommand/5569741-expected.png: Added.
- platform/chromium-linux/editing/execCommand/format-block-with-braces-expected.png: Added.
- platform/chromium-linux/editing/execCommand/format-block-with-trailing-br-expected.png: Added.
- platform/chromium-linux/editing/execCommand/indent-empty-root-expected.png: Added.
- platform/chromium-linux/editing/execCommand/indent-list-item-expected.png: Added.
- platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png: Added.
- platform/chromium-linux/editing/execCommand/nsresponder-indent-expected.png: Added.
- platform/chromium-linux/editing/execCommand/nsresponder-outdent-expected.png: Added.
- platform/chromium-linux/editing/execCommand/remove-list-item-1-expected.png: Added.
- platform/chromium-linux/editing/inserting/4875189-1-expected.png: Added.
- platform/chromium-linux/editing/inserting/4959067-expected.png: Added.
- platform/chromium-linux/editing/inserting/4960120-2-expected.png: Added.
- platform/chromium-linux/editing/inserting/5002441-expected.png: Added.
- platform/chromium-linux/editing/inserting/5156401-2-expected.png: Added.
- platform/chromium-linux/editing/inserting/5549929-3-expected.png: Added.
- platform/chromium-linux/editing/inserting/break-blockquote-after-delete-expected.png: Added.
- platform/chromium-linux/editing/inserting/editable-inline-element-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-3778059-fix-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-after-delete-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-002-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-003-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-004-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-005-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-006-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-007-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-008-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-space-in-empty-doc-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-tab-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-tab-002-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-tab-003-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-tab-004-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
- platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png: Added.
- platform/chromium-linux/editing/inserting/line-break-expected.png: Added.
- platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png: Added.
- platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png: Added.
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/chromium-linux/editing/inserting/redo-expected.png: Added.
- platform/chromium-linux/editing/inserting/typing-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/typing-002-expected.png: Added.
- platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png: Added.
- platform/chromium-linux/editing/inserting/typing-around-image-001-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/4076267-2-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/4076267-3-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/4076267-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/4700297-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5006779-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5065605-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5071074-2-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5075944-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5134759-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5156401-1-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5483567-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/5601583-1-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/8145-1-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/displaced-placeholder-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/merge-end-3-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/merge-start-list-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-blockquote-1-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-003-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Added.
- platform/chromium-linux/editing/selection/4866671-expected.png: Added.
- platform/chromium-linux/editing/selection/4932260-1-expected.png: Added.
- platform/chromium-linux/editing/selection/4932260-2-expected.png: Added.
- platform/chromium-linux/editing/selection/4932260-3-expected.png: Added.
- platform/chromium-linux/editing/selection/5076323-2-expected.png: Added.
- platform/chromium-linux/editing/selection/5076323-3-expected.png: Added.
- platform/chromium-linux/editing/selection/contenteditable-click-inside-expected.png: Added.
- platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Added.
- platform/chromium-linux/editing/selection/editable-non-editable-crash-expected.png: Added.
- platform/chromium-linux/editing/selection/extend-by-character-006-expected.png: Added.
- platform/chromium-linux/editing/selection/extend-by-word-001-expected.png: Added.
- platform/chromium-linux/editing/selection/fake-doubleclick-expected.png: Added.
- platform/chromium-linux/editing/selection/fake-drag-expected.png: Added.
- platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png: Added.
- platform/chromium-linux/editing/selection/move-between-blocks-no-001-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-character-001-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-character-002-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-character-004-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-character-6-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-line-002-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-sentence-001-expected.png: Added.
- platform/chromium-linux/editing/selection/move-by-word-001-expected.png: Added.
- platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Added.
- platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png: Added.
- platform/chromium-linux/editing/selection/table-caret-1-expected.png: Added.
- platform/chromium-linux/editing/selection/table-caret-2-expected.png: Added.
- platform/chromium-linux/editing/selection/table-caret-3-expected.png: Added.
- platform/chromium-linux/editing/selection/wrapped-line-caret-1-expected.png: Added.
- platform/chromium-linux/editing/selection/wrapped-line-caret-2-expected.png: Added.
- platform/chromium-linux/editing/spelling/spelling-expected.png: Added.
- platform/chromium-linux/editing/style/5065910-expected.png: Added.
- platform/chromium-linux/editing/style/fontsize-1-expected.png: Added.
- platform/chromium-linux/editing/style/highlight-expected.png: Added.
- platform/chromium-linux/editing/style/style-3681552-fix-001-expected.png: Added.
- platform/chromium-linux/editing/style/style-3681552-fix-002-expected.png: Added.
- platform/chromium-linux/editing/style/typing-style-001-expected.png: Added.
- platform/chromium-linux/editing/style/typing-style-002-expected.png: Added.
- platform/chromium-linux/editing/undo/4063751-expected.png: Added.
- platform/chromium-linux/editing/undo/redo-typing-001-expected.png: Added.
- platform/chromium-linux/editing/undo/undo-typing-001-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.
- platform/chromium-linux/fast/css/outline-auto-empty-rects-expected.png: Added.
- platform/chromium-linux/fast/css/outline-auto-location-expected.png: Added.
- platform/chromium-linux/fast/events/label-focus-expected.png: Added.
- platform/chromium-linux/fast/forms/textfield-outline-expected.png: Added.
- platform/chromium-linux/fast/forms/textfield-overflow-expected.png: Added.
- platform/chromium-linux/fast/lists/004-expected.png: Added.
- platform/chromium-linux/fast/repaint/4776765-expected.png: Added.
- platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png: Added.
- platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Added.
- platform/chromium-linux/fast/repaint/delete-into-nested-block-expected.png: Added.
- platform/chromium-linux/fast/repaint/float-overflow-expected.png: Added.
- platform/chromium-linux/fast/repaint/float-overflow-right-expected.png: Added.
- platform/chromium-linux/fast/repaint/focus-layers-expected.png: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/chromium-linux/fast/repaint/list-marker-2-expected.png: Added.
- platform/chromium-linux/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/chromium-linux/fast/table/empty-table-percent-height-expected.png: Added.
- platform/chromium-linux/fast/text/justified-selection-expected.png: Added.
- platform/chromium-linux/media/audio-controls-rendering-expected.png: Added.
- platform/chromium-linux/media/controls-after-reload-expected.png: Added.
- platform/chromium-linux/media/controls-strict-expected.png: Added.
- platform/chromium-linux/media/video-display-toggle-expected.png: Added.
- platform/chromium-linux/media/video-empty-source-expected.png: Added.
- platform/chromium-linux/media/video-no-audio-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
- platform/chromium-linux/svg/custom/focus-ring-expected.png: Added.
- platform/chromium-linux/svg/custom/foreignObject-crash-on-hover-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-path-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-path-removal-expected.png: Added.
- platform/chromium-linux/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png: Added.
- platform/chromium-linux/svg/custom/linking-a-03-b-viewTarget-expected.png: Added.
- platform/chromium-linux/svg/custom/linking-a-03-b-zoomAndPan-expected.png: Added.
- platform/chromium-linux/svg/custom/path-textPath-simulation-expected.png: Added.
- platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.png: Added.
- platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/chromium-linux/svg/custom/use-clipped-hit-expected.png: Added.
- platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.png: Added.
- platform/chromium-linux/svg/custom/use-elementInstance-methods-expected.png: Added.
- platform/chromium-linux/svg/custom/use-event-handler-on-referenced-element-expected.png: Added.
- platform/chromium-linux/svg/custom/use-event-handler-on-use-element-expected.png: Added.
- platform/chromium-linux/svg/custom/use-nested-transform-expected.png: Added.
- platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
- platform/chromium-linux/svg/custom/width-full-percentage-expected.png: Added.
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Added.
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Added.
- platform/chromium-linux/svg/hixie/error/003-expected.png: Added.
- platform/chromium-linux/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-linux/svg/hixie/perf/002-expected.png: Added.
- platform/chromium-linux/svg/hixie/shapes/path/001-expected.png: Added.
- platform/chromium-linux/svg/text/textPathBoundsBug-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug3191-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
- platform/chromium-linux/tables/mozilla/core/misc-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
- 5:38 PM Changeset in webkit [66560] by
-
- 5 edits in trunk/WebCore
2010-08-31 Kenneth Russell <kbr@google.com>
Reviewed by Chris Marrin.
Add length and related operations to FloatPoint and FloatSize
https://bugs.webkit.org/show_bug.cgi?id=44994
Added length and squared length operations to both FloatPoint and
FloatSize, and added set(x, y), dot and normalize operations to
FloatPoint. These changes have been tested with new code to be
added later.
- platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::normalize): (WebCore::FloatPoint::length):
- platform/graphics/FloatPoint.h: (WebCore::FloatPoint::set): (WebCore::FloatPoint::dot): (WebCore::FloatPoint::lengthSquared): (WebCore::operator*):
- platform/graphics/FloatSize.cpp: (WebCore::FloatSize::diagonalLength):
- platform/graphics/FloatSize.h: (WebCore::FloatSize::diagonalLengthSquared):
- 5:34 PM Changeset in webkit [66559] by
-
- 4 edits in trunk
2010-08-31 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
gl-teximage.html and tex-image-and-sub-image-2d-with-image.html failed on Chromium Mac bots (10.5)
https://bugs.webkit.org/show_bug.cgi?id=44993
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Take into consideration the source image pixel row alignment.
2010-08-31 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
gl-teximage.html and tex-image-and-sub-image-2d-with-image.html failed on Chromium Mac bots (10.5)
https://bugs.webkit.org/show_bug.cgi?id=44993
- platform/chromium/test_expectations.txt: Enabling the failing tests with the fix.
- 5:20 PM Changeset in webkit [66558] by
-
- 2 edits in trunk/WebKit2
Fix some copy/paste errors.
Reviewed by Steve Falkenburg.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
Null check the correct callback.
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
Ditto.
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
Ditto.
- 5:18 PM Changeset in webkit [66557] by
-
- 5 edits in trunk/WebKit2
Crash when closing a page with a form field when using WebKit2.
Reviewed by Anders Carlsson.
The crash came from accessing a BundlePageFormClient that had been
destroyed. The client was intended to be cleared by a call to
WKBundlePageSetFormClient, but a null check there caused it not to be
cleared.
I fixed this and all of the other WK "set client" functions.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetInjectedBundleClient):
Return early if the caller passed a client with a version not equal to
0.
(WKContextSetHistoryClient):
Ditto.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
Ditto.
(WKPageSetPagePolicyClient):
Ditto.
(WKPageSetPageFormClient):
Ditto.
(WKPageSetPageUIClient):
Ditto.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetClient):
Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetEditorClient):
Ditto.
(WKBundlePageSetFormClient):
Ditto.
(WKBundlePageSetLoaderClient):
Ditto.
(WKBundlePageSetUIClient):
Ditto.
- 5:17 PM Changeset in webkit [66556] by
-
- 2 edits in trunk/WebCore
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Unify GENERATE_DOM_NAMES code
https://bugs.webkit.org/show_bug.cgi?id=44842
- CMakeLists.txt: Added property svn:eol-style.
- 4:49 PM Changeset in webkit [66555] by
-
- 3 edits in trunk/WebCore
Variable name change. m_shouldFirePostLayoutTimer is now
m_hasPendingPostLayoutTasks
Rubber-stamped by Dan Bernstein..
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
- page/FrameView.h:
- 4:48 PM Changeset in webkit [66554] by
-
- 2 edits in trunk/WebKit2
Build fix.
- Shared/WebPreferencesStore.h: Actually remove encode(), which has been moved to WebPreferencesStore.cpp.
- 4:31 PM Changeset in webkit [66553] by
-
- 3 edits in trunk/BugsSite
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Make it easy to scroll through review comments
https://bugs.webkit.org/show_bug.cgi?id=45002
This patch lets you scroll through review comments using "n" (for next)
and "p" (for previous). It also attributes comments to their authors.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 4:21 PM Changeset in webkit [66552] by
-
- 4 edits2 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=44828 FrameView
should make more calls to postLayoutTasks() using the timer
-and corresponding-
<rdar://problem/8064938>
Reviewed by Dave Hyatt.
WebCore:
This change only allows synchronous calls to postLayoutTasks() if
we are not already in a synchronous call to postLayoutTasks().
Furthermore, it de-couples the notion of "the post layout timer
should fire" from m_postLayoutTasksTimer.isActive(), instead using
a boolean to track the need to use the timer.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::unscheduleRelayout):
(WebCore::FrameView::performPostLayoutTasks):
- page/FrameView.h:
LayoutTests:
- fast/events/change-overflow-on-overflow-change-expected.txt: Added.
- fast/events/change-overflow-on-overflow-change.html: Added.
- 4:13 PM Changeset in webkit [66551] by
-
- 20 edits in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42195
<rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
LayoutTests:
- platform/mac-wk2/Skipped: Unskip XSS Auditor tests.
WebKitTools:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method makes WebProcess use a different value for this preference than UIProcess thinks it uses.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess, which forgets its override.
WebKit2:
- Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore): Initialize xssAuditorEnabled. (WebKit::WebPreferencesStore::decode): Moved from header, added xssAuditorEnabled. (WebKit::WebPreferencesStore::encode): Ditto. (WebKit::WebPreferencesStore::overrideXSSAuditorEnabledForTestRunner): Set an override, so that decoding a WebPreferencesStore in the process will give the override result. WebProcess doesn't hold to WebPreferencesStore, so there are no existing ones to patch. (WebKit::WebPreferencesStore::removeTestRunnerOverrides): Remove the override.
- Shared/WebPreferencesStore.h: Added xssAuditorEnabled.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetXSSAuditorEnabled): (WKPreferencesGetXSSAuditorEnabled):
- UIProcess/API/C/WKPreferences.h: Added an API method to change xssAuditorEnabled preference.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Added a comment explaining how making this method smarter could affect WebKitTestRunner.
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setXSSAuditorEnabled): (WebKit::WebPreferences::xssAuditorEnabled):
- UIProcess/WebPreferences.h: Implemented xssAuditorEnabled preference accessors.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleOverrideXSSAuditorEnabledForTestRunner):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added a private methods to temporarily change xssAuditor setting from an injected bundle, not notifying UIProcess about the change.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
- WebProcess/InjectedBundle/InjectedBundle.h: Change the setting in existing pages, and override it for future ones.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Take xssAuditorEnabled from preferences store. (WebKit::WebPage::preferencesDidChange): If preferences change, forget our override. This only happens in WKRT when the next test begins.
- 4:12 PM Changeset in webkit [66550] by
-
- 2 edits in trunk/WebCore
Fix 32-bit WebKit2 build.
Reviewed by Sam Weinig.
- WebCore.exp.in:
- 3:53 PM Changeset in webkit [66549] by
-
- 2 edits in trunk/WebCore
2010-08-31 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Regression in r63528: Custom http headers for loads of type
FrameLoadTypeReloadFromOrigin are not being correctly
propagated to subresource loads.
No tests, since DRT doesn't seem to have a way to trigger a
FrameLoadTypeReloadFromOrigin load.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- 3:48 PM Changeset in webkit [66548] by
-
- 11 edits in trunk
WebKitTestRunner needs layoutTestController.addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=42680
Reviewed by Gavin Barraclough.
WebKitTestRunner needs layoutTestController.addUserScript
https://bugs.webkit.org/show_bug.cgi?id=42681
WebKit2:
Improve UserContent APIs to allow passing null in the same places
the WebKit1 API allowed. Add convenience function toWTFString to do
WKStringRef conversion with correct null string behavior.
- UIProcess/API/C/WKAPICast.h:
(toWTFString):
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::toStringVector):
WebKitTools:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
LayoutTests:
- platform/mac-wk2/Skipped: Update skipped list.
- 3:25 PM Changeset in webkit [66547] by
-
- 9 edits4 deletes in trunk/WebKitTools
2010-08-31 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r66542.
http://trac.webkit.org/changeset/66542
https://bugs.webkit.org/show_bug.cgi?id=44902
r66542 - the weird logging dependencies in Python stuck again ...
- Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
- Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
- Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
- Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
- Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:18 PM Changeset in webkit [66546] by
-
- 3 edits in trunk/WebKitTools
Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::markerTextForListItem):
- DumpRenderTree/chromium/LayoutTestController.h:
- 3:13 PM Changeset in webkit [66545] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Tony Chang <tony@chromium.org>
Unreviewed, updating test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 3:10 PM Changeset in webkit [66544] by
-
- 13 edits in trunk
Add ability to count text matches without marking
https://bugs.webkit.org/show_bug.cgi?id=43996
Reviewed by Darin Adler.
WebCore:
Safari needs to be able to count text matches without triggering lots of repainting.
Rename markAllMatchesForText() to countMatchesForText() and add a markMatches parameter.
- WebCore.exp.in:
- page/Frame.cpp:
(WebCore::Frame::countMatchesForText):
- page/Frame.h:
- page/Page.cpp:
(WebCore::Page::markAllMatchesForText):
WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_text_matches_mark): Switched to call
countMatchesForText() instead of markAllMatchesForText().
WebKit/mac:
Safari needs to be able to count text matches without triggering lots of repainting.
Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
parameter. For backwards compatibility markAllMatchesForText: calls
countMatchesForText: and passes YES for markMatches:.
- WebView/WebDocumentInternal.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
(-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
- WebView/WebPDFView.mm:
(-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
(-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
- WebView/WebView.mm:
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
- WebView/WebViewPrivate.h:
- 3:09 PM Changeset in webkit [66543] by
-
- 2 edits in trunk/WebKit2
Remove library directive from def file to fix Debug_All build.
Rubber stamped by Sam Weinig.
- win/WebKit2.def:
- 2:53 PM Changeset in webkit [66542] by
-
- 9 edits4 adds in trunk/WebKitTools
2010-08-31 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: add more unit tests
Add more unit tests for new-run-webkit-tests; we now cover all but
the most obscure code paths in the generic code. We still need to
add coverage for the http server and web socket paths, and add better
coverage of the platform-specific logic. Note that the rebaselining
tool is still not well tested.
Also clean up some of the configuration logic for the printing
module and the way it interacts with the Python logging module; that
is a crufty interface, to be certain.
- Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
- Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
- Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
- Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
- Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 2:51 PM Changeset in webkit [66541] by
-
- 5 edits in trunk
2010-08-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
canPlayType("application/octet-stream") must return ""
https://bugs.webkit.org/show_bug.cgi?id=44985
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsType): Always return IsNotSupported for application/octet-stream
2010-08-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
canPlayType("application/octet-stream") must return ""
https://bugs.webkit.org/show_bug.cgi?id=44985
- media/media-can-play-octet-stream-expected.txt:
- media/media-can-play-octet-stream.html:
- 2:47 PM Changeset in webkit [66540] by
-
- 5 edits in trunk/WebCore
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] ScrollbarThemeGtk should respond to theme changes
https://bugs.webkit.org/show_bug.cgi?id=44782
Scrollbar is currently written with the assumption that scrollbars never change
thickness. In GTK+ changing the current theme can alter scrollbar thickness. This
change manually resizes interior frame scrollbar widgets when the GTK+ theme changes.
Since we are now tracking style changes, we may also cache theme properties to avoid
having to call moz_gtk_get_scrollbar_metrics repeatedly during rendering.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::gtkScrollbar): Added accessor for the Mozilla theming code's scrollbar widget. We access it here, because RenderThemGtk takes care of initializing the Mozilla code.
- platform/gtk/RenderThemeGtk.h: Added accessor declaration.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Update the style property cache during construction. (WebCore::ScrollbarThemeGtk::registerScrollbar): Track all interior frame scrollbars. (WebCore::ScrollbarThemeGtk::unregisterScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Added this method which updates the style cache. (WebCore::gtkStyleSetCallback): Added this signal handler for when the style changes. (WebCore::ScrollbarThemeGtk::backButtonRect): Use the style cache instead of calling moz_gtk_get_scrollbar_metrics. (WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto. (WebCore::ScrollbarThemeGtk::trackRect): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::thumbRect): Ditto. (WebCore::ScrollbarThemeGtk::paint): Ditto. (WebCore::ScrollbarThemeGtk::scrollbarThickness): Ditto. (WebCore::ScrollbarThemeGtk::buttonSize): Ditto. (WebCore::ScrollbarThemeGtk::minimumThumbLength): Ditto.
- platform/gtk/ScrollbarThemeGtk.h: Added new method declarations.
- 2:39 PM Changeset in webkit [66539] by
-
- 5 edits in trunk
2010-08-31 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Web archives are created with a size of 0 due to PassRefPtr mistake
https://bugs.webkit.org/show_bug.cgi?id=44984
rdar://problem/8042283
- loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::ArchiveResource): Merge the three constructors into one. (WebCore::ArchiveResource::create): Merge the two create functions into one, and fix the logic so there is no use of a PassRefPtr after it has been passed.
- loader/archive/ArchiveResource.h: Use default arguments instead of overloading to cut down from three create functions to two. Remove two of the constructors.
2010-08-31 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Web archives are created with a size of 0 due to PassRefPtr mistake
https://bugs.webkit.org/show_bug.cgi?id=44984
rdar://problem/8042283
- webarchive/test-link-rel-icon-expected.webarchive: Expect a correct size, not 0.
- 2:34 PM Changeset in webkit [66538] by
-
- 3 edits in trunk/JavaScriptCore
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge): Replaced somewhat-quirky code that
mixed types with code that uses size_t.
Reviewed by Anders Carlsson.
- wtf/TCPageMap.h: Removed names of unused arguments to avoid warning.
- 2:33 PM Changeset in webkit [66537] by
-
- 6 edits3 adds in trunk
Expose WorkerContext.createBlobURL and WorkerContext.revokeBlobURL.
https://bugs.webkit.org/show_bug.cgi?id=44972
Reviewed by David Levin.
WebCore:
Test: fast/files/workers/worker-apply-blob-url-to-xhr.html
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canRequest):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::createBlobURL):
(WebCore::WorkerContext::revokeBlobURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
LayoutTests:
- fast/files/workers/resources/worker-apply-blob-url-to-xhr.js: Added.
- fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt: Added.
- fast/files/workers/worker-apply-blob-url-to-xhr.html: Added.
- 2:33 PM Changeset in webkit [66536] by
-
- 3 edits in trunk/WebCore
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox):
Added a cast so we can mix int and unsigned in a single ?: expression.
This warns with clang, but strangely not with gcc.
Reviewed by Anders Carlsson.
- html/parser/HTMLTreeBuilder.cpp: Removed unused functions.
The clang compiler notices and complains about these. If we need them
later we should use Subversion to bring them back.
- 2:31 PM Changeset in webkit [66535] by
-
- 2 edits in trunk/WebKit/mac
- WebInspector/WebInspectorFrontend.mm:
(-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
Reviewed by Anders Carlsson.
- 2:29 PM Changeset in webkit [66534] by
-
- 2 edits in trunk/WebKitTools
- Scripts/check-for-global-initializers: Add a file that ends up having global initializers
in a debug build when built with certain compilers.
Reviewed by Anders Carlsson.
- 2:27 PM Changeset in webkit [66533] by
-
- 3 edits in trunk/WebCore
2010-08-31 Kenneth Russell <kbr@google.com>
Reviewed by Simon Fraser.
Add cross product and arithmetic operations to FloatPoint3D
https://bugs.webkit.org/show_bug.cgi?id=44970
Added set, move, and scale operations similar to FloatPoint's,
addition and subtraction operators, length, lengthSquared and
cross product. These changes have been tested with new code to be
added later.
- platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::normalize): (WebCore::FloatPoint3D::length):
- platform/graphics/FloatPoint3D.h: (WebCore::FloatPoint3D::set): (WebCore::FloatPoint3D::move): (WebCore::FloatPoint3D::scale): (WebCore::FloatPoint3D::dot): (WebCore::FloatPoint3D::cross): (WebCore::FloatPoint3D::lengthSquared): (WebCore::operator +=): (WebCore::operator -=): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
- 2:25 PM Changeset in webkit [66532] by
-
- 3 edits in trunk/BugsSite
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Show previous comments inline in diff
https://bugs.webkit.org/show_bug.cgi?id=44977
This patch adds basic support for showing previous comments inline in
the diff. We crawl the bugs.webkit.org comments about this attachment
and extract comments related to specific lines. We then show the
comments inline in the diff.
This part of the tool needs a bunch of polish, but this at least is a
starting point for further work.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 2:23 PM Changeset in webkit [66531] by
-
- 22 edits1 add in trunk
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Isolate all GTK+ typedefs into one file
https://bugs.webkit.org/show_bug.cgi?id=44900
- GNUmakefile.am: Add GtkTypedefs.h to the source lists.
- wtf/Platform.h: #include GtkTypedefs.h for the GTK+ build.
- wtf/ThreadingPrimitives.h: Remove GTK+ typedefs.
- wtf/gobject/GOwnPtr.h: Ditto.
- wtf/gobject/GRefPtr.h: Ditto.
- wtf/gtk/GtkTypedefs.h: Added.
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Isolate all GTK+ typedefs into one file
https://bugs.webkit.org/show_bug.cgi?id=44900
- platform/graphics/gtk/CairoUtilities.h: Remove GTK+ typedefs.
- platform/gtk/ClipboardGtk.h: Ditto.
- platform/gtk/DataObjectGtk.h: Ditto.
- platform/gtk/GOwnPtrGtk.h: Ditto.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/gtk/PasteboardHelper.h: Ditto.
- platform/gtk/PopupMenuGtk.h: Ditto.
- platform/gtk/RenderThemeGtk.h: Ditto.
- platform/gtk/ScrollbarGtk.h: Ditto.
- platform/gtk/gtk2drawing.c: Remove unused Assertions.h.
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Isolate all GTK+ typedefs into one file
https://bugs.webkit.org/show_bug.cgi?id=44900
- WebCoreSupport/EditorClientGtk.h: Remove GTK+ typedefs.
- WebCoreSupport/FullscreenVideoController.h: Ditto.
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Isolate all GTK+ typedefs into one file
https://bugs.webkit.org/show_bug.cgi?id=44900
- DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
- 2:15 PM Changeset in webkit [66530] by
-
- 2 edits in trunk/WebCore
2010-08-31 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile.
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
- 2:02 PM Changeset in webkit [66529] by
-
- 1 edit2 adds in trunk/WebCore
2010-08-31 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add FFTConvolver class
https://bugs.webkit.org/show_bug.cgi?id=34907
No new tests since audio API is not yet implemented.
- platform/audio: Added.
- platform/audio/FFTConvolver.cpp: Added. (WebCore::FFTConvolver::FFTConvolver): (WebCore::FFTConvolver::process): (WebCore::FFTConvolver::reset):
- platform/audio/FFTConvolver.h: Added. (WebCore::FFTConvolver::fftSize):
- 1:57 PM Changeset in webkit [66528] by
-
- 2 edits in trunk/WebCore
Fix ThreadableBlobRegistry methods not to rely on WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=44971
Reviewed by Darin Fisher and David Levin.
We could hit an ASSERT when we're performing some blob related cleanup
in ScriptExecutionContext destructor when WorkerContext dies. The fix
is to use isMainThread and callOnMainThread.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::registerBlobURLFromTask):
(WebCore::unregisterBlobURLTask):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- 1:50 PM Changeset in webkit [66527] by
-
- 4 edits in trunk
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Fix 'make dist' in preparation of the 1.3.3 release
https://bugs.webkit.org/show_bug.cgi?id=44978
- GNUmakefile.am: Adding missing headers to the sources list.
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Fix 'make dist' in preparation of the 1.3.3 release
https://bugs.webkit.org/show_bug.cgi?id=44978
- GNUmakefile.am: Add missing and moved headers to the sources list.
- 1:32 PM Changeset in webkit [66526] by
-
- 4 edits in trunk/WebCore
2010-08-31 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] crashes while dragging any contents
https://bugs.webkit.org/show_bug.cgi?id=44940
Fix crashes caused by returning newly assigned value instead of adoptRef
value.
- page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::createDraggingClipboard):
- platform/efl/ClipboardEfl.cpp: (WebCore::Editor::newGeneralClipboard):
- platform/efl/ClipboardEfl.h: (WebCore::ClipboardEfl::create):
- 12:53 PM Changeset in webkit [66525] by
-
- 25 edits in trunk/WebKit/gtk/po
2010-08-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66519.
http://trac.webkit.org/changeset/66519
https://bugs.webkit.org/show_bug.cgi?id=44973
Broke GTK+. (Requested by kov on #webkit).
- cs.po:
- de.po:
- en_GB.po:
- es.po:
- et.po:
- gl.po:
- gu.po:
- he.po:
- it.po:
- lt.po:
- lv.po:
- nb.po:
- nl.po:
- pa.po:
- pt.po:
- pt_BR.po:
- ru.po:
- sl.po:
- sr.po:
- sr@latin.po:
- sv.po:
- uk.po:
- vi.po:
- zh_CN.po:
- 12:45 PM Changeset in webkit [66524] by
-
- 3 edits in trunk/JavaScriptCore
Support emit_op_mod() for MIPS
https://bugs.webkit.org/show_bug.cgi?id=42855
Patch by Chao-ying Fu <fu@mips.com> on 2010-08-31
Reviewed by Oliver Hunt.
This patch uses MIPS div instructions for op_mod to improve performance.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::div):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
- 12:40 PM Changeset in webkit [66523] by
-
- 4 edits2 adds in trunk
2010-08-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: The parser of Inspector protocol messages should be covered by a test.
The inspector protocol is based on messages in JSON format.
Each message should be a JSON object with a number of properties.
InspectorBackendDispatcher is parsing these messages and should be
able to detect wrong formatted messages.
It has these functionality but no tests for it.
- inspector/CodeGeneratorInspector.pm:
2010-08-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: The parser of Inspector protocol messages should be covered by a test.
The inspector protocol is based on messages in JSON format.
Each message should be a JSON object with a number of properties.
InspectorBackendDispatcher is parsing these messages and should be
able to detect wrong formatted messages.
It has these functionality but no tests for it.
- http/tests/inspector/inspector-test2.js: (dump): (dumpArray):
- inspector/report-protocol-errors-expected.txt: Added.
- inspector/report-protocol-errors.html: Added.
- 12:39 PM Changeset in webkit [66522] by
-
- 5 edits in trunk
2010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
Preparations for the 1.3.4 release. Bump webkit version to 543.7,
as well.
- configure.ac:
WebKit/gtk
2010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
Preparations for the 1.3.4 release.
- NEWS:
- docs/webkitgtk-docs.sgml:
- 12:35 PM Changeset in webkit [66521] by
-
- 7 edits in trunk/WebCore
2010-08-31 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] More correct and faster error handling when converting v8 objects to various WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=44678
Split v8 object conversion into two phase: 1st, which can throw an exception, and
2nd, which must always succeed. That allows to report correctly the case when exception
happens.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp: (WebCore::int32ToWebCoreString): (WebCore::v8NonStringValueToWebCoreString):
- bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::operator String): (WebCore::V8ParameterBase::operator AtomicString): (WebCore::V8ParameterBase::V8ParameterBase): (WebCore::V8ParameterBase::prepareBase): (WebCore::V8ParameterBase::object): (WebCore::V8ParameterBase::setString): (WebCore::V8ParameterBase::toString): (WebCore::): (WebCore::::prepare):
- bindings/v8/custom/V8BindingMacros.h:
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
- bindings/v8/cstom/V8DeviceOrientationEventCustom.cpp: (WebCore::V8DeviceMotionEvent::initDeviceOrientationEventCallback):
- 12:25 PM Changeset in webkit [66520] by
-
- 2 edits in trunk/WebKit/gtk
2010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Minor documentation typo fix.
- webkit/webkitwebview.cpp:
- 12:21 PM Changeset in webkit [66519] by
-
- 25 edits in trunk/WebKit/gtk/po
2010-08-31 Gustavo Noronha Silva <Gustavo Noronha Silva>
Refreshed all po files with the latest potfile.
- cs.po:
- de.po:
- en_GB.po:
- es.po:
- et.po:
- gl.po:
- gu.po:
- he.po:
- it.po:
- lt.po:
- lv.po:
- nb.po:
- nl.po:
- pa.po:
- pt.po:
- pt_BR.po:
- ru.po:
- sl.po:
- sr.po:
- sr@latin.po:
- sv.po:
- uk.po:
- vi.po:
- zh_CN.po:
- 12:09 PM Changeset in webkit [66518] by
-
- 4 edits in trunk/WebKitTools
2010-08-31 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Show more status on queue status pages
https://bugs.webkit.org/show_bug.cgi?id=44938
I upped the number of status lines from 6 to 15 --
this has been bugging me for a while...
I also disabled showing the chromium-win EWS queue
since it's been down for almost 5 months now.
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/model/queues.py:
- 12:03 PM Changeset in webkit [66517] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-08-31 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test_expectations.txt.
- platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt: Added.
- platform/chromium-win/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/chromium-win/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt: Added.
- platform/chromium/test_expectations.txt: Mark notifications-click-event.html as failing and rebase paginate-block-replaced on linux/win.
- 11:55 AM Changeset in webkit [66516] by
-
- 4 edits2 adds in trunk
2010-08-30 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Joseph Pecoraro.
WebInspector: it'd be better to introduce inspector API related tests.
As far as we have some kind of API for Inspector
it'd be better to have API related tests. This is the test
for API wrappers. These wrappers are tracking the types of arguments
of API functions.
Test: inspector/protocol-error.html
- inspector/CodeGeneratorInspector.pm:
- inspector/front-end/inspector.js: (WebInspector_syncDispatch): (WebInspector.reportProtocolError):
2010-08-30 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Joseph Pecoraro.
WebInspector: it'd be better to introduce inspector API related tests.
As far as we have some kind of API for Inspector
it'd be better to have API related tests. This is the test
for API wrappers. These wrappers are tracking the types of arguments
of API functions.
- inspector/protocol-error-expected.txt: Added.
- inspector/protocol-error.html: Added.
- 11:55 AM Changeset in webkit [66515] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-08-31 Jorge González <aloriel@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Spanish translation for trunk
https://bugs.webkit.org/show_bug.cgi?id=44395
- es.po: Updated.
- 11:47 AM Changeset in webkit [66514] by
-
- 3 edits in trunk/WebKit2
Handle WM_PRINTCLIENT in WebKit2 on Windows
Reviewed by Sam Weinig.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Call through to onPrintClientEvent when we
get a WM_PRINTCLIENT message.
(WebKit::WebView::onPrintClientEvent): Added. Paints the entire view
into the HDC provided by Windows.
- UIProcess/win/WebView.h: Added onPrintClientEvent.
- 11:46 AM Changeset in webkit [66513] by
-
- 2 edits in trunk/WebCore
2010-08-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66484.
http://trac.webkit.org/changeset/66484
https://bugs.webkit.org/show_bug.cgi?id=44966
Broke EFL build (Requested by acidx on #webkit).
- CMakeLists.txt:
- 11:39 AM Changeset in webkit [66512] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
Add EditorClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=44822
- WebCoreSupport/EditorClientWinCE.cpp: Added. (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::shouldDeleteRange): (WebKit::EditorClient::shouldShowDeleteInterface): (WebKit::EditorClient::isContinuousSpellCheckingEnabled): (WebKit::EditorClient::isGrammarCheckingEnabled): (WebKit::EditorClient::spellCheckerDocumentTag): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::EditorClient::shouldInsertText): (WebKit::EditorClient::shouldChangeSelectedRange): (WebKit::EditorClient::shouldApplyStyle): (WebKit::EditorClient::shouldMoveRangeAfterDelete): (WebKit::EditorClient::didBeginEditing): (WebKit::EditorClient::respondToChangedContents): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::didEndEditing): (WebKit::EditorClient::didWriteSelectionToPasteboard): (WebKit::EditorClient::didSetSelectionTypesForPasteboard): (WebKit::EditorClient::isEditable): (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::shouldInsertNode): (WebKit::EditorClient::pageDestroyed): (WebKit::EditorClient::smartInsertDeleteEnabled): (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): (WebKit::EditorClient::toggleContinuousSpellChecking): (WebKit::EditorClient::toggleGrammarChecking): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing): (WebKit::EditorClient::textDidChangeInTextField): (WebKit::EditorClient::doTextFieldCommandFromEvent): (WebKit::EditorClient::textWillBeDeletedInTextField): (WebKit::EditorClient::textDidChangeInTextArea): (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClient::checkGrammarOfString): (WebKit::EditorClient::updateSpellingUIWithGrammarString): (WebKit::EditorClient::updateSpellingUIWithMisspelledWord): (WebKit::EditorClient::showSpellingUI): (WebKit::EditorClient::spellingUIIsShowing): (WebKit::EditorClient::getGuessesForWord): (WebKit::EditorClient::willSetInputMethodState):
- WebCoreSupport/EditorClientWinCE.h: Added.
- 11:22 AM Changeset in webkit [66511] by
-
- 2 edits in trunk/WebCore
2010-08-31 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
deduplicate code from Node::checkReplaceChild and Node::checkAddChild
https://bugs.webkit.org/show_bug.cgi?id=44962
Remove duplicate code in preparation for fixing https://bugs.webkit.org/show_bug.cgi?id=19524
No new tests since there is no change in functionality.
- dom/Node.cpp: (WebCore::isChildTypeAllowed): (WebCore::Node::canReplaceChild): (WebCore::checkAcceptChild): (WebCore::transferOwnerDocument): (WebCore::Node::checkReplaceChild): (WebCore::Node::checkAddChild):
- 11:19 AM Changeset in webkit [66510] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
Add DragClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=44821
- WebCoreSupport/DragClientWinCE.cpp: Added. (WebKit::DragClient::willPerformDragDestinationAction): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::actionMaskForDrag): (WebKit::DragClient::dragSourceActionMaskForPoint): (WebKit::DragClient::startDrag): (WebKit::DragClient::createDragImageForLink): (WebKit::DragClient::dragControllerDestroyed):
- WebCoreSupport/DragClientWinCE.h: Added.
- 11:01 AM Changeset in webkit [66509] by
-
- 4 edits in trunk/WebCore
2010-08-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[Chromium] bindTexture(TEXTURE_CUBE_MAP) shouldn't generate errors with valid cubemap texture
https://bugs.webkit.org/show_bug.cgi?id=44922
- html/canvas/WebGLRenderingContext.cpp: Remove TEXTURE_WRAP_R code. (WebCore::WebGLRenderingContext::bindTexture):
- html/canvas/WebGLTexture.cpp: Remove the code for tracking TEXTURE_WRAP_R. (WebCore::WebGLTexture::WebGLTexture):
- html/canvas/WebGLTexture.h: Ditto.
- 10:54 AM Changeset in webkit [66508] by
-
- 2 edits in trunk/WebKit2
Don't send messages to the injected bundle if the web process has exited
Fixes <http://webkit.org/b/43046> <rdar://problem/8239455> Crash in
WKContextPostMessageToInjectedBundle if the web process has exited
Reviewed by Sam Weinig.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle): Only send messages
when we have a valid web process.
- 10:53 AM Changeset in webkit [66507] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-08-31 Kjartan Maraas <kmaraas@gnome.org>
Reviewed by Gustavo Noronha Silva.
WebKitGTK+ translation needed
https://bugzilla.gnome.org/show_bug.cgi?id=610099
Initial Norwegian (bokmal) translation.
- nb.po: Added.
- 10:53 AM Changeset in webkit [66506] by
-
- 3 edits in trunk/WebKit2
Use the Windows thread pool instead of a dedicated thread for WorkQueue on Windows
WorkQueue now uses ::RegisterWaitForSingleObject to find out when work
items need to be executed. This causes Windows to wait on the objects
on a thread pool wait thread, and then to spawn a thread pool worker
thread when an object is signaled. This is more efficient than using
our own dedicated thread to perform the wait and the work because
multiple WorkQueues (and even other parts of WebKit or other modules)
can all share the same wait thread and worker thread pool.
Each time WorkQueue::m_performWorkEvent or any handle in
WorkQueue::m_handles is signaled, a worker thread will be spawned.
To maintain WorkQueue's serial nature, only one worker thread is
allowed to perform work items at a time. (The worker thread that is
actually performing work items is called the queue's "work thread".)
To accomplish this, worker threads must register as the queue's work
thread before performing work items.
WorkQueue::m_isWorkThreadRegistered is used as an atomic guard to make
sure that only one worker thread is registered at a time.
Fixes <http://webkit.org/b/43150> <rdar://problem/8247280>.
Reviewed by Anders Carlsson.
- Platform/WorkQueue.h:
- Added the WorkItemWin class, which is used to wrap WorkItems for WorkQueue's Windows implementation
- Changed m_workItemQueue and m_handles to hold RefPtr<WorkItemWin>s
- Replaced "work queue thread"-related members with new members that handle our thread pool code
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::WorkItemWin::WorkItemWin):
(WorkQueue::WorkItemWin::create):
Added simple constructor/creator.
(WorkQueue::handleCallback): Added. This function is called whenever a
handle in WorkQueue::m_handles is signaled. We add the WorkItemWin
that corresponds to the handle (passed via the context parameter) to
the work item queue, then try to register as the work thread and
perform any queued work. If another thread is already registered as
the work thread, we just exit and let that thread handle the work we
queued.
(WorkQueue::registerHandle): Changed to wrap the WorkItem in a
WorkItemWin, and to use ::RegisterWaitForSingleObject to wait on the
handle.
(WorkQueue::eventCallback): Added. This function is called whenever
m_performWorkEvent is signaled. We try to register as the work thread
and perfom any queued work. If another thread is already registered as
the work thread, we just exit and let that thread handle the work.
(WorkQueue::performWorkOnRegisteredWorkThread): Added. Performs any
queued work in a loop until either the queue becomes invalid or no
work is left to perform. Unregisters as the work thread before exiting
so that other threads can perform work in the future.
(WorkQueue::platformInitialize): Added initialization of
m_isWorkThreadRegistered. Replaced code to spawn the old work queue
thread with a call to ::RegisterWaitForSingleObject so that a worker
thread from the thread pool will be spawned when m_performWorkEvent is
signaled.
(WorkQueue::tryRegisterAsWorkThread): Added. Attempts an atomic
compare-and-swap to change m_isWorkThreadRegistered from 0 to 1. If
sucessful, we return true to indicate that this thread is now
registered as the work thread.
(WorkQueue::unregisterAsWorkThread): Added. Uses an atomic
compare-and-swap to change m_isWorkThreadRegistered back from 1 to 0.
(WorkQueue::scheduleWork): Changed to wrap the WorkItem in a
WorkItemWin. Also added an optimization to avoid signaling
m_performWorkEvent when a work thread is already performing work, as
it will pick up the item we just queued without us having to do
anything.
- 10:52 AM Changeset in webkit [66505] by
-
- 2 edits in trunk/WebCore
Rename addTwoCStrings to concatenateTwoCStrings.
Rubber-stamped by David Levin.
- fileapi/BlobBuilder.cpp:
(WebCore::concatenateTwoCStrings):
(WebCore::BlobBuilder::append):
- 10:46 AM Changeset in webkit [66504] by
-
- 1 edit in trunk/WebCore/ChangeLog
Update WebCore/ChangeLog to fix the missing bug title.
- 10:37 AM Changeset in webkit [66503] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
Add ContextMenuClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=44820
- WebCoreSupport/ContextMenuClientWinCE.cpp: Added. (WebKit::ContextMenuClient::ContextMenuClient): (WebKit::ContextMenuClient::contextMenuDestroyed): (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): (WebKit::ContextMenuClient::contextMenuItemSelected): (WebKit::ContextMenuClient::downloadURL): (WebKit::ContextMenuClient::copyImageToClipboard): (WebKit::ContextMenuClient::searchWithGoogle): (WebKit::ContextMenuClient::lookUpInDictionary): (WebKit::ContextMenuClient::speak): (WebKit::ContextMenuClient::stopSpeaking): (WebKit::ContextMenuClient::isSpeaking):
- WebCoreSupport/ContextMenuClientWinCE.h: Added.
- 10:25 AM Changeset in webkit [66502] by
-
- 4 edits in trunk/LayoutTests
2010-08-31 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] rebaseline linux fast/backgrounds/001
https://bugs.webkit.org/show_bug.cgi?id=44899
Only difference is font antialiasing.
- platform/chromium-linux/fast/backgrounds/001-expected.checksum:
- platform/chromium-linux/fast/backgrounds/001-expected.png:
- platform/chromium/test_expectations.txt:
- 10:24 AM Changeset in webkit [66501] by
-
- 2 edits in trunk/WebKitTools
2010-08-31 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Read command line arguments and open them as URLs in new windows
https://bugs.webkit.org/show_bug.cgi?id=44944
Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
- MiniBrowser/qt/main.cpp: (main):
- 10:23 AM Changeset in webkit [66500] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-08-31 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] new linux baseline for fast/text/capitalize-boundaries
https://bugs.webkit.org/show_bug.cgi?id=44898
This differs from the Windows baseline in antialiasing and that the Windows
result has a missing-glyph box.
- platform/chromium-linux/fast/text/capitalize-boundaries-expected.checksum: Added.
- platform/chromium-linux/fast/text/capitalize-boundaries-expected.png: Added.
- platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:17 AM Changeset in webkit [66499] by
-
- 2 edits in trunk/WebCore
Improve BlobBuilder to combine adjacent strings.
https://bugs.webkit.org/post_bug.cgi
Reviewed by Darin Fisher.
- fileapi/BlobBuilder.cpp:
(WebCore::addTwoCStrings):
(WebCore::BlobBuilder::append):
- 10:08 AM Changeset in webkit [66498] by
-
- 119 edits in trunk/WebCore
2010-08-31 Darin Adler <Darin Adler>
Reviewed by Simon Fraser.
Make DOM classes start with a reference count of 1, like all other RefCounted
https://bugs.webkit.org/show_bug.cgi?id=28068
- dom/Document.cpp: (WebCore::Document::accessSVGExtensions): Use adoptPtr instead of set.
- dom/Document.h: Removed initialRefCount in Node constructor. It's always 1 now.
- dom/Node.h: Removed CreateWithZeroRefCountFlag, CreateStyledElementZeroRefCount, CreateSVGElementZeroRefCount, and initialRefCount.
- platform/TreeShared.h: Removed initialRefCount argument. It's always 1 now.
- rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement): Use create instead of new.
- rendering/SVGResources.h: Inherit from Noncopyable.
- rendering/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::~SVGResourcesCache): Removed unneeded special case code.
- rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::create): Added. (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Made argument type more specific. (WebCore::SVGShadowTreeRootElement::create): Added.
- rendering/SVGShadowTreeElements.h: Added create functions, and made the argument type more specific.
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): Use adoptPtr.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Use adoptPtr instead of set.
- svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Use CreateSVGElement instead of CreateSVGElementZeroRefCount. (WebCore::SVGElement::create): Use adoptRef.
- wml/WMLElement.cpp: (WebCore::WMLElement::WMLElement): Use CreateStyledElement instead of CreateStyledElementZeroRefCount. (WebCore::WMLElement::create): Use adoptRef.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::create):
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::create):
- svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::create):
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::create):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::create):
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::create):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::create):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::create):
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::create):
- svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::create):
- svg/SVGDescElement.cpp: (WebCore::SVGDescElement::create):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::create):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::create):
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::create):
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::create):
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::create):
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::create):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::create):
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::create):
- svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::create):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::create):
- svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::create):
- svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::create):
- svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::create):
- svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::create):
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::create):
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::create):
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::create):
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::create):
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::create):
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::create):
- svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::create):
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::create):
- svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::create):
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::create):
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::create):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::create):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::create):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::create):
- svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::create):
- svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::create):
- svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::create):
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::create):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::create):
- svg/SVGGElement.cpp: (WebCore::SVGGElement::create):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::create):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::create):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::create):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::create):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::create):
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::create):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::create):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::create):
- svg/SVGMetadataElement.cpp: (WebCore::SVGMetadataElement::create):
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::create):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::create):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::create):
- svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::create):
- svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::create):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::create):
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::create):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::create): (WebCore::SVGSVGElement::currentView):
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::create):
- svg/SVGSetElement.cpp: (WebCore::SVGSetElement::create):
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::create):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::create):
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::create):
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::create):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::create):
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::create):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::create):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::create):
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::create):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::create): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
- svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::create):
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::create):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::create):
- wml/WMLAccessElement.cpp: (WebCore::WMLAccessElement::create):
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::create):
- wml/WMLBRElement.cpp: (WebCore::WMLBRElement::create):
- wml/WMLCardElement.cpp: (WebCore::WMLCardElement::create):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::create):
- wml/WMLDocument.h: (WebCore::WMLDocument::create):
- wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::create):
- wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::create):
- wml/WMLGoElement.cpp: (WebCore::WMLGoElement::create):
- wml/WMLImageElement.cpp: (WebCore::WMLImageElement::create):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::create):
- wml/WMLInsertedLegendElement.cpp: (WebCore::WMLInsertedLegendElement::create):
- wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::create):
- wml/WMLMetaElement.cpp: (WebCore::WMLMetaElement::create):
- wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::create):
- wml/WMLOnEventElement.cpp: (WebCore::WMLOnEventElement::create):
- wml/WMLOptGroupElement.cpp: (WebCore::WMLOptGroupElement::create):
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::create):
- wml/WMLPElement.cpp: (WebCore::WMLPElement::create):
- wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::create):
- wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::create):
- wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::create):
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::create):
- wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::create):
- wml/WMLTableElement.cpp: (WebCore::WMLTableElement::create):
- wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::create):
- wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::create):
- wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::create): Use adoptRef.
- 10:05 AM Changeset in webkit [66497] by
-
- 2 edits2 deletes in trunk/LayoutTests
2010-08-31 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] incorrect baseline for fast/css/font-face-implicit-local-font
https://bugs.webkit.org/show_bug.cgi?id=44893
The test is verifying that the CSS unicode-range: property is correctly
modifying the font for a substring of text. The checked-in image shows
the wrong font.
Also, update the comment in test_expectations to reflect this
information.
- platform/chromium-linux/fast/css/font-face-implicit-local-font-expected.checksum: Removed.
- platform/chromium-linux/fast/css/font-face-implicit-local-font-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 10:04 AM Changeset in webkit [66496] by
-
- 3 edits2 adds in trunk
2010-08-31 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Local frame loads should check against origin (not referrer)
https://bugs.webkit.org/show_bug.cgi?id=44888
Test: fast/frames/iframe-no-src-local-origin-allow.html
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe):
2010-08-31 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Local frame loads should check against origin (not referrer)
https://bugs.webkit.org/show_bug.cgi?id=44888
- fast/frames/iframe-no-src-local-origin-allow-expected.txt: Added.
- fast/frames/iframe-no-src-local-origin-allow.html: Added.
- 10:01 AM Changeset in webkit [66495] by
-
- 4 edits in trunk/WebKit2
2010-08-31 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
[Qt] Fix warnings in WebKit2 directory
https://bugs.webkit.org/show_bug.cgi?id=44593
- Platform/CoreIPC/qt/ConnectionQt.cpp: Mark unused variables for compiler. (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
- Shared/qt/WebEventFactoryQt.cpp: (WebKit::WebEventFactory::createWebTouchEvent): Initialize state variable. Default case added.
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::toNP): Return initialized NPEvent.
- 9:57 AM Changeset in webkit [66494] by
-
- 5 edits in trunk
2010-08-25 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (cg)
https://bugs.webkit.org/show_bug.cgi?id=44566
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Fix the premultiplyAlpha issue for cg.
2010-08-25 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (cg)
https://bugs.webkit.org/show_bug.cgi?id=44566
- fast/canvas/webgl/gl-teximage-expected.txt: Fix a typo in the file.
- platform/chromium/test_expectations.txt: Re-enable gl-teximage.html test.
- platform/mac/Skipped: Ditto.
- 9:52 AM Changeset in webkit [66493] by
-
- 2 edits in trunk/WebKit2
2010-08-31 Andras Becsi <abecsi@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Determine application path of MiniBrowser at runtime and use that path
for QtWebProcess if the executable exists in that path.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncherHelper::launch):
- 9:30 AM Changeset in webkit [66492] by
-
- 3 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=44956, paginate block-level replaced elements.
<rdar://problem/8000991> Images with display:block get split between columns or pages
Reviewed by Adam Roben.
Added fast/multicol/paginate-block-replaced.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=44956, paginate block-level replaced elements.
Reviewed by Adam Roben.
- fast/multicol/paginate-block-replaced.html: Added.
- platform/mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/mac/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/mac/fast/multicol/paginate-block-replaced-expected.txt: Added.
- 9:24 AM Changeset in webkit [66491] by
-
- 1 edit18 adds in trunk/WebKitTools
2010-08-31 Adrian Perez <Adrian Perez de Castro>
Reviewed by Martin Robinson.
Support scripts to run Buildbot slaves under daemontools (gtk related)
https://bugs.webkit.org/show_bug.cgi?id=40053
- BuildSlaveSupport/gtk: Added.
- BuildSlaveSupport/gtk/README: Added.
- BuildSlaveSupport/gtk/buildbot: Added.
- BuildSlaveSupport/gtk/buildbot/log: Added.
- BuildSlaveSupport/gtk/buildbot/log/run: Added.
- BuildSlaveSupport/gtk/buildbot/run: Added.
- BuildSlaveSupport/gtk/crashmon: Added.
- BuildSlaveSupport/gtk/crashmon/crashmon: Added.
- BuildSlaveSupport/gtk/crashmon/log: Added.
- BuildSlaveSupport/gtk/crashmon/log/run: Added.
- BuildSlaveSupport/gtk/crashmon/run: Added.
- BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
- BuildSlaveSupport/gtk/pulseaudio: Added.
- BuildSlaveSupport/gtk/pulseaudio/run: Added.
- BuildSlaveSupport/gtk/xvfb: Added.
- BuildSlaveSupport/gtk/xvfb/log: Added.
- BuildSlaveSupport/gtk/xvfb/log/run: Added.
- BuildSlaveSupport/gtk/xvfb/run: Added.
- 9:23 AM Changeset in webkit [66490] by
-
- 5 adds in trunk/WebKit/wince
Add InspectorClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=44819
Patch by Patrick Gansterer <paroga@paroga.com> on 2010-08-28
Reviewed by Adam Roben.
- WebCoreSupport/InspectorClientWinCE.cpp: Added.
(WebKit::InspectorClient::InspectorClient):
(WebKit::InspectorClient::~InspectorClient):
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::openInspectorFrontend):
(WebKit::InspectorClient::releaseFrontendPage):
(WebKit::InspectorClient::highlight):
(WebKit::InspectorClient::hideHighlight):
(WebKit::InspectorClient::populateSetting):
(WebKit::InspectorClient::storeSetting):
(WebKit::InspectorClient::sendMessageToFrontend):
- WebCoreSupport/InspectorClientWinCE.h: Added.
- 9:23 AM Changeset in webkit [66489] by
-
- 3 edits in trunk/JavaScriptCore
Modify ASSERT_UNUSED and UNUSED_PARAM similar to Qt's Q_UNUSED.
https://bugs.webkit.org/show_bug.cgi?id=44870
Reviewed by Darin Adler.
- wtf/Assertions.h:
- wtf/UnusedParam.h:
- 8:58 AM Changeset in webkit [66488] by
-
- 2 edits in trunk/WebKit/efl
2010-08-31 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[EFL] Build break for r66456
https://bugs.webkit.org/post_bug.cgi
Replace firstRectsForMarkers with renderedRectsForMarkers.
- ewk/ewk_frame.cpp: (ewk_frame_text_matches_nth_pos_get):
- 8:55 AM Changeset in webkit [66487] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip fixed test for the GTK port.
media/video-loop.html fails intermittently on GTK and Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=33671
- platform/gtk/Skipped: Unskip media/video-loop.html
- 8:49 AM Changeset in webkit [66486] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36515
CSS style definitions are ignored if they just follow a "@charset" which appears in lines
other than the first line in stylesheet.
Test: fast/css/misplaced-charset.html
- css/CSSGrammar.y: Ignore a misplaced charset rule without consuming extra characters and thus breaking subsequent rules.
- 8:43 AM Changeset in webkit [66485] by
-
- 2 edits in trunk/WebCore
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Antonio Gomes.
[CMake] Add IF (ENABLE_MATHML) around MathML sources
https://bugs.webkit.org/show_bug.cgi?id=44927
- CMakeLists.txt:
- 7:59 AM Changeset in webkit [66484] by
-
- 2 edits in trunk/WebCore
2010-08-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[CMake] Unify GENERATE_DOM_NAMES code
https://bugs.webkit.org/show_bug.cgi?id=44842
- CMakeLists.txt: Added property svn:eol-style.
- 7:38 AM Changeset in webkit [66483] by
-
- 3 edits1 add in trunk/WebCore
2010-08-31 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Add an interface for platform copy/paste drag/drop data objects
https://bugs.webkit.org/show_bug.cgi?id=44914
Currently, Chromium only supports a few hardcoded data types in
event.dataTransfer. This is the first of several patches to add support
for arbitrary data types.
No new tests.
- WebCore.gypi:
- platform/chromium/ChromiumDataObjectNew.h: Added.
- platform/chromium/ClipboardChromium.cpp:
- 7:22 AM Changeset in webkit [66482] by
-
- 13 edits in trunk/LayoutTests
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update in-test expectations to account for HTML5 parsing changes
https://bugs.webkit.org/show_bug.cgi?id=44889
We've already updated the -expected.txt files for these tests to
account for the behavior changes with the HTML5 parser. This patch
updates the redundant "in-test" expectations so that the results say
"PASS" instead of "FAIL".
- fast/forms/datalist-nonoption-child.html:
- fast/forms/state-restore-to-non-edited-controls-expected.txt:
- fast/forms/state-restore-to-non-edited-controls.html:
- fast/parser/fragment-parser-expected.txt:
- fast/parser/residual-style-close-across-n-blocks-expected.txt:
- fast/parser/residual-style-close-across-n-blocks.html:
- fast/parser/script-tests/fragment-parser.js:
- http/tests/misc/isindex-formdata-expected.txt:
- http/tests/misc/isindex-formdata.html:
- http/tests/misc/isindex-with-no-form-base-href-expected.txt:
- http/tests/misc/resources/isindex-with-no-form-base-href.html:
- 7:06 AM Changeset in webkit [66481] by
-
- 3 edits in trunk/LayoutTests
2010-08-31 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Remove passing tests from Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=44906
Remove test expectations from Chromium's test_expectations.txt that are
incorrect (the tests now pass).
fast/events/special-key-events-in-input-text.html
fixed by http://crrev.com/57503
fast/events/tabindex-focus-chain.html
fast/forms/tabs-with-modifiers.html
editing/selection/drag-in-iframe.html
fixed by http://trac.webkit.org/changeset/66269/ (appeared twice in
the file)
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [66480] by
-
- 3 edits in trunk/LayoutTests
2010-08-31 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Attempt to fix flakiness of inspector extensions API audits tests on Qt.
Synchronize last output() with signalling test completion.
- inspector/resources/extension-main.html:
- inspector/resources/extension-main.js: (onTestsDone):
- 6:26 AM Changeset in webkit [66479] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
https://bugs.webkit.org/show_bug.cgi?id=33027
- platform/gtk/Skipped: Unskip now passing test.
- 5:57 AM Changeset in webkit [66478] by
-
- 2 edits in trunk/WebKit/qt
2010-08-31 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
JSC TimeoutChecker::didTimeOut overflows on ARM
https://bugs.webkit.org/show_bug.cgi?id=38538
Re-enabled the test that was skipped for Maemo 5.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS):
- 5:38 AM Changeset in webkit [66477] by
-
- 22 edits10 adds1 delete in trunk
2010-08-30 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add audits support to extension API
Exposed (late) adding of categories from AuditPanel.
Removed indexOfObjectInListSortedByFunction in favor of
insertionIndexForObjectInListSortedByFunction (the former had
weird interface always returning negative numbers and was only used in
the latter).
https://bugs.webkit.org/show_bug.cgi?id=44518
Tests: inspector/extensions-audits-api.html
inspector/extensions-audits.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditFormatters.js: Added. (WebInspector.applyFormatters): (WebInspector.AuditFormatters.text): (WebInspector.AuditFormatters.snippet): (WebInspector.AuditFormatters.concat): (WebInspector.AuditFormatters.url):
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype.addCategory.compareCategories): (WebInspector.AuditLauncherView.prototype.addCategory): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/AuditResultView.js: (WebInspector.AuditCategoryResultPane.prototype._appendResult):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype.addCategory): (WebInspector.AuditsPanel.prototype.getCategory): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditCategory.prototype.run):
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._fire): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._dispatch): (WebInspector.injectedExtensionAPI.EventSink): (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.Audits): (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory): (WebInspector.injectedExtensionAPI.AuditCategory.customDispatch): (WebInspector.injectedExtensionAPI.AuditCategory): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.AuditResult): (WebInspector.injectedExtensionAPI.AuditResult.prototype.get Severity): (WebInspector.injectedExtensionAPI.AuditResultImpl): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.addResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.createResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.done): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype._nodeFactory): (WebInspector.injectedExtensionAPI.AuditResultNode): (WebInspector.injectedExtensionAPI.AuditResultNode.prototype.addChild):
- inspector/front-end/ExtensionAuditCategory.js: Added. (WebInspector.ExtensionAuditCategory): (WebInspector.ExtensionAuditCategory.prototype.get id): (WebInspector.ExtensionAuditCategory.prototype.get displayName): (WebInspector.ExtensionAuditCategory.prototype.get ruleCount): (WebInspector.ExtensionAuditCategory.prototype.run): (WebInspector.ExtensionAuditCategoryResults): (WebInspector.ExtensionAuditCategoryResults.prototype.get complete): (WebInspector.ExtensionAuditCategoryResults.prototype.cancel): (WebInspector.ExtensionAuditCategoryResults.prototype.addResult): (WebInspector.ExtensionAuditCategoryResults.prototype._addNode): (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
- inspector/front-end/ExtensionCommon.js: Added. (WebInspector.commonExtensionSymbols):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.startAuditRun): (WebInspector.ExtensionServer.prototype.stopAuditRun): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript): (WebInspector.ExtensionStatus):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js: ():
2010-08-30 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add audits support to extension API
https://bugs.webkit.org/show_bug.cgi?id=44518
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest): (runTest.runTestInFrontend): (runTest):
- inspector/audits-panel-functional.html:
- inspector/audits-tests.js: Added. (frontend_collectAuditResults): (frontend_collectTextContent):
- inspector/audits-tests2.js: Added. (initialize_AuditTests.InspectorTest.collectAuditResults): (initialize_AuditTests.InspectorTest.collectTextContent): (initialize_AuditTests):
- inspector/extensions-api-expected.txt:
- inspector/extensions-api.html:
- inspector/extensions-audits-api-expected.txt: Added.
- inspector/extensions-audits-api.html: Added.
- inspector/extensions-audits-expected.txt: Added.
- inspector/extensions-audits-tests.js: Added. (extension_runAudits.onMessage): (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest): (test):
- inspector/extensions-audits.html: Added.
- inspector/extensions-expected.txt:
- inspector/extensions-test.js: (extensionFunctions): (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (test):
- inspector/extensions.html:
- inspector/resources/audits-script3.js: Removed.
- inspector/resources/extension-main.js: (onTestsDone):
- platform/chromium/test_expectations.txt:
- 5:26 AM Changeset in webkit [66476] by
-
- 2 edits in trunk/WebCore
2010-08-31 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Remove unused canReferToParentFrameEncoding() function from FrameLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=44895
No new tests; no behavior changed.
- loader/FrameLoader.cpp:
- 5:02 AM Changeset in webkit [66475] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-31 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
JSC TimeoutChecker::didTimeOut overflows on ARM
https://bugs.webkit.org/show_bug.cgi?id=38538
Make getCPUTime() return values relative to the first call.
The previous implementation relied on simply on currentTime(), which
return a time since epoch and not a time since the thread started. This
made the return value of getCPUTime() overflow on 32 bits.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 4:33 AM Changeset in webkit [66474] by
-
- 2 edits in trunk/WebCore
2010-08-31 Jeremy Orlow <jorlow@chromium.org>
Build fix.
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
- 3:46 AM Changeset in webkit [66473] by
-
- 18 edits2 adds in trunk
2010-08-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement the rest of IDBCursors + make them persistent
https://bugs.webkit.org/show_bug.cgi?id=44546
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/objectstore-cursor.html: Added.
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/script-tests/keyrange.js: (checkLeftBoundKeyRange): ():
- storage/indexeddb/script-tests/open-cursor.js: (emptyCursorSuccess):
2010-08-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement the rest of IDBCursors + make them persistent
https://bugs.webkit.org/show_bug.cgi?id=44546
Because the old (memory only) backend didn't support ranges, IDBCursors
were never really finished. This completes them on top of SQLite like
the rest of IndexedDB.
Test: storage/indexeddb/objectstore-cursor.html
- storage/IDBCursor.cpp: (WebCore::IDBCursor::value):
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::loadCurrentRow):
- storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
- storage/IDBCursorBackendInterface.h:
- storage/IDBKey.cpp: (WebCore::IDBKey::isEqual):
- storage/IDBKey.h:
- storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::leftBound): (WebCore::IDBKeyRange::rightBound): (WebCore::IDBKeyRange::bound):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::cursorWhereFragment): (WebCore::IDBObjectStoreBackendImpl::openCursor):
2010-08-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement the rest of IDBCursors + make them persistent
https://bugs.webkit.org/show_bug.cgi?id=44546
- src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::value):
- src/IDBCursorBackendProxy.h:
- src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::value):
- 2:56 AM Changeset in webkit [66472] by
-
- 6 edits in trunk/LayoutTests
2010-08-31 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
fast/dom/frame-loading-via-document-write.html fails on Chromium and is otherwise flaky
https://bugs.webkit.org/show_bug.cgi?id=44894
Detect all frames loading more reliably (add a counter to count down when each of
the three frames has loaded). Install onload handler on images instead of the document
to not tickle bug 29615.
- fast/dom/frame-loading-via-document-write.html:
- fast/dom/resources/frame-loading-via-document-write.js: (didImageLoad):
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- 2:40 AM Changeset in webkit [66471] by
-
- 3 edits in trunk/BugsSite
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
https://bugs.webkit.org/show_bug.cgi?id=44936
- PrettyPatch/PrettyPatch.rb:
- Add a version number to bust through bugs.webkit.org's aggressive cacheing.
- code-review.js:
- 1:58 AM Changeset in webkit [66470] by
-
- 13 edits2 adds in trunk
2010-08-27 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notifications should support a click event
https://bugs.webkit.org/show_bug.cgi?id=44800
- public/WebNotification.h:
- src/WebNotification.cpp: (WebKit::WebNotification::dispatchClickEvent):
2010-08-27 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notifications should support a click event
https://bugs.webkit.org/show_bug.cgi?id=44800
Test: fast/notifications/notifications-click-event.html
- notifications/Notification.h:
- notifications/Notification.idl:
2010-08-27 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notifications should support a click event
https://bugs.webkit.org/show_bug.cgi?id=44800
- fast/notifications/notifications-click-event-expected.txt: Added.
- fast/notifications/notifications-click-event.html: Added.
- platform/qt/Skipped:
2010-08-27 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notifications should support a click event.
Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
can be simulated during a layout test. Requires storing a list of active
notifications so that they can be referred to later for clicking.
https://bugs.webkit.org/show_bug.cgi?id=44800
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::simulateDesktopNotificationClick):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::simulateClick): (NotificationPresenter::show): (NotificationPresenter::cancel): (NotificationPresenter::objectDestroyed):
- DumpRenderTree/chromium/NotificationPresenter.h:
- 1:25 AM Changeset in webkit [66469] by
-
- 2 edits in trunk/LayoutTests
2010-08-31 Alejandro G. Castro <alex@igalia.com>
Unreviewed.
[GTK] canvas/philip/tests/2d.path.isPointInPath.edge-actual.txt
fails in the bots
https://bugs.webkit.org/show_bug.cgi?id=44932
Skip a test that is failing in the bots.
- platform/gtk/Skipped:
- 1:21 AM Changeset in webkit [66468] by
-
- 2 edits in trunk/LayoutTests
Skip fast/files/apply-blob-url-to-img.html for now until finding out
how to generate the right result.
- platform/mac/Skipped:
- 1:10 AM Changeset in webkit [66467] by
-
- 7 edits1 add in trunk
[V8] Custom binding for "dataset"
https://bugs.webkit.org/show_bug.cgi?id=44930
Reviewed by Adam Barth.
WebCore:
- WebCore.gyp/WebCore.gyp: Remove the exclusion of DOMStringMap.idl.
- WebCore.gypi: Add V8DOMStringMapCustom.cpp.
- bindings/v8/custom/V8DOMStringMapCustom.cpp: Added.
(WebCore::V8DOMStringMap::namedPropertyQuery):
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):
- dom/Element.idl: Remove V8 exclusion.
- page/DOMWindow.idl: ditto.
LayoutTests:
- platform/chromium/test_expectations.txt: Remove dataset.html and dataset-xhtml.xhtml.
- 1:06 AM Changeset in webkit [66466] by
-
- 3 edits in trunk/WebKit2
Build fix after r66448 on WebKit2.
[Qt] qt_wk_didFinishDocumentLoadForFrame needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=44934
- UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didFinishDocumentLoadForFrame):
- UIProcess/API/qt/ClientImpl.h:
- 12:56 AM Changeset in webkit [66465] by
-
- 2 edits in trunk/LayoutTests
Update chromium test result.
- platform/chromium/test_expectations.txt:
- 12:39 AM Changeset in webkit [66464] by
-
- 2 edits in trunk/WebCore
Fix chromium build break.
- page/DOMWindow.h:
- 12:35 AM Changeset in webkit [66463] by
-
- 4 edits2 adds in trunk
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Stale document crashes at multiple URLs (with new parser)
https://bugs.webkit.org/show_bug.cgi?id=44885
We're not supposed to load resources in detached documents. According
to several locations I examined, it's the job of the caller of
DocLoader to check this invariant. Like most code dealing with
detached documents, this check isn't overly consistent. At some point,
we'll need to rationalize all the different patterns here. However, at
this point, this patch appears correct because it matches what we do
for <link rel="stylesheet">.
Test: fast/dom/HTMLLinkElement/prefetch-detached.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/DocLoader.cpp: (WebCore::DocLoader::requestLinkPrefetch):
2010-08-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Stale document crashes at multiple URLs (with new parser)
https://bugs.webkit.org/show_bug.cgi?id=44885
Test what happens when you insert a link prefetch element into a
detached document.
- fast/dom/HTMLLinkElement/prefetch-detached-expected.txt: Added.
- fast/dom/HTMLLinkElement/prefetch-detached.html: Added.
- 12:25 AM Changeset in webkit [66462] by
-
- 14 edits9 adds in trunk
Expose window.createBlobURL and window.revokeBlobURL.
https://bugs.webkit.org/show_bug.cgi?id=44908
Reviewed by David Levin.
WebCore:
Tests: fast/files/apply-blob-url-to-img.html
fast/files/apply-blob-url-to-xhr.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createBlobURL):
(WebCore::DOMWindow::revokeBlobURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
LayoutTests:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/files/apply-blob-url-to-img.html: Added.
- fast/files/apply-blob-url-to-xhr-expected.txt: Added.
- fast/files/apply-blob-url-to-xhr.html: Added.
- fast/files/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/fast/files/apply-blob-url-to-img-expected.checksum: Added.
- platform/mac/fast/files/apply-blob-url-to-img-expected.png: Added.
- platform/mac/fast/files/apply-blob-url-to-img-expected.txt: Added.
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:06 AM Changeset in webkit [66461] by
-
- 24 edits3 copies16 adds in trunk
Support FileReaderSync in workers.
https://bugs.webkit.org/show_bug.cgi?id=44657
Reviewed by David Levin.
WebCore:
Also add FileException interface and make Blob/File/FileError useable in
workers.
Tests: fast/files/workers/worker-read-blob-async.html
fast/files/workers/worker-read-blob-sync.html
fast/files/workers/worker-read-file-async.html
fast/files/workers/worker-read-file-sync.html
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/Blob.idl: Added NoStaticTables attribute.
- fileapi/File.idl: Added NoStaticTables attribute.
- fileapi/FileError.idl: Added NoStaticTables attribute.
- fileapi/FileException.h: Added.
- fileapi/FileException.idl: Added.
- fileapi/FileReaderSync.cpp: Added.
- fileapi/FileReaderSync.h: Added.
- fileapi/FileReaderSync.idl: Added.
- workers/WorkerContext.idl: Expose FileReaderSync and BlodBuilder in workers.
LayoutTests:
Added 4 test files to test FileReaderSync in workers.
- fast/files/read-blob-async.html:
- fast/files/read-file-async.html:
- fast/files/resources/read-common.js:
(readBlobAsBinaryString):
(readBlobAsText):
(readBlobAsDataURL):
(_readBlobAsBinaryStringAsync):
(_readBlobAsTextAsync):
(_readBlobAsDataURLAsync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
(createReaderSync):
- fast/files/resources/read-blob-test-cases.js:
(runNextTest):
- fast/files/resources/read-file-test-cases.js:
(runNextTest):
(testMultipleReads):
- fast/files/resources/setup-for-read-common.js:
(log):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):
- fast/files/workers/resources/worker-read-blob-async.js: Added.
- fast/files/workers/resources/worker-read-blob-sync.js: Added.
- fast/files/workers/resources/worker-read-common.js: Added.
- fast/files/workers/resources/worker-read-file-async.js: Added.
- fast/files/workers/resources/worker-read-file-sync.js: Added.
- fast/files/workers/worker-read-blob-async-expected.txt: Added.
- fast/files/workers/worker-read-blob-async.html: Added.
- fast/files/workers/worker-read-blob-sync-expected.txt: Added.
- fast/files/workers/worker-read-blob-sync.html: Added.
- fast/files/workers/worker-read-file-async-expected.txt: Added.
- fast/files/workers/worker-read-file-async.html: Added.
- fast/files/workers/worker-read-file-sync-expected.txt: Added.
- fast/files/workers/worker-read-file-sync.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
Aug 30, 2010:
- 11:44 PM Changeset in webkit [66460] by
-
- 2 edits in trunk/WebCore
2010-08-30 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Buffered ranges drawing support
https://bugs.webkit.org/show_bug.cgi?id=44869
Refactored the media slider track painting code to support
multiple buffered ranges painting. This change introduces no
functional regression.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack):
- 10:51 PM Changeset in webkit [66459] by
-
- 1 edit in trunk/WebCore/ChangeLog
Update WebCore/ChangeLog to add missing entries.
- loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleHistoryNavigation):
- 10:39 PM Changeset in webkit [66458] by
-
- 8 edits2 adds in trunk
2010-08-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
https://bugs.webkit.org/show_bug.cgi?id=44315
Remove ENABLE_HISTORY_ALWAYS_ASYNC #define.
- wtf/Platform.h:
2010-08-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
https://bugs.webkit.org/show_bug.cgi?id=44315
Add test that checks history.back() asynchronous behavior. Modifies
location-hash.html to not assume synchronous traversal and removes it
from the Chromium test expectations, since it passes there now too.
- fast/dom/location-hash-expected.txt:
- fast/dom/location-hash.html:
- fast/history/history-traversal-is-asynchronous-expected.txt: Added.
- fast/history/history-traversal-is-asynchronous.html: Added.
- platform/chromium/test_expectations.txt:
2010-08-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
https://bugs.webkit.org/show_bug.cgi?id=44315
Remove check in RedirectScheduler::scheduleHistoryNavigation that would
dispatch some navigations synchronously.
Test: fast/history/history-traversal-is-asynchronous.html
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- 10:37 PM Changeset in webkit [66457] by
-
- 1 edit in trunk/WebCore/fileapi/ThreadableBlobRegistry.cpp
2010-08-30 Jian Li <jianli@chromium.org>
Try to fix break again.
- fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerBlobURL): (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- 10:26 PM Changeset in webkit [66456] by
-
- 2 edits in trunk/WebCore/fileapi
2010-08-30 Jian Li <jianli@chromium.org>
Fix another build break. Also fix directory upload test break.
- fileapi/File.cpp: (WebCore::File::File):
- fileapi/ThreadableBlobRegistry.cpp:
- 10:17 PM Changeset in webkit [66455] by
-
- 1 edit in trunk/WebCore/xml/XMLHttpRequest.cpp
2010-08-30 Jian Li <jianli@chromium.org>
Fix build break.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- 10:05 PM Changeset in webkit [66454] by
-
- 3 edits in trunk/WebKit/efl
2010-08-30 Kamil Blank <k.blank@samsung.com>
Reviewed by Adam Barth.
[EFL] Added API which returns position of n-th text matches mark
https://bugs.webkit.org/show_bug.cgi?id=44258
- ewk/ewk_frame.cpp: (_ewk_frame_rect_cmp_less_than): Private. (_ewk_frame_rect_is_negative_value): Private. (ewk_frame_text_matches_nth_pos_get): Added. Function returns position of n-th text match in frame.
- ewk/ewk_frame.h:
- 9:56 PM Changeset in webkit [66453] by
-
- 1 edit in trunk/WebCore/platform/network/BlobRegistryImpl.cpp
2010-08-30 Jian Li <jianli@chromium.org>
Fix qt/gtk build break.
- platform/network/BlobRegistryImpl.cpp:
- 9:45 PM Changeset in webkit [66452] by
-
- 33 edits1 copy1 move8 adds3 deletes in trunk
Switch the Blob implementation to using the blob data registration model
https://bugs.webkit.org/show_bug.cgi?id=44389
Reviewed by Darin Fisher.
WebCore:
Tests: fast/files/read-blob-async.html
fast/files/read-file-async.html
With this switch, File/Blob/BlobBuilder are changed to register the blob
data. FileReader is changed to route through loading the blob resource.
FormData is also updated to take BlobData. The WebKit mac implementation
is updated to resolve the blob references in the BlobData.
- CMakeLists.txt: Update the project file to remove BlobItem.*.
- GNUmakefile.am: Update the project file to remove BlobItem.*.
- WebCore.gypi: Update the project file to remove BlobItem.*.
- WebCore.pro: Update the project file to remove BlobItem.*.
- WebCore.vcproj/WebCore.vcproj: Update the project file to remove BlobItem.*.
- WebCore.xcodeproj/project.pbxproj: Update the project file to remove BlobItem.*.
- fileapi/Blob.cpp: Switch to using BlobData.
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
- fileapi/Blob.h: Switch to using BlobData.
(WebCore::Blob::create):
(WebCore::Blob::size):
(WebCore::Blob::isFile):
- fileapi/BlobBuilder.cpp: Switch to using BlobData.
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::getBlob):
- fileapi/BlobBuilder.h: Switch to using BlobData.
- fileapi/BlobURL.cpp: Add a new helper method used in FormData.
(WebCore::BlobURL::getIdentifier):
- fileapi/BlobURL.h:
- fileapi/File.cpp: Switch to using BlobData.
(WebCore::createBlobDataForFile):
(WebCore::File::File):
(WebCore::File::size):
(WebCore::File::captureSnapshot):
- fileapi/File.h: Switch to using BlobData.
(WebCore::File::create):
(WebCore::File::path):
(WebCore::File::name):
(WebCore::File::webkitRelativePath):
- fileapi/FileReader.cpp: Change the reading to route through blob resource loading.
(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::delayedStart):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didReceiveResponse):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::failed):
(WebCore::FileReader::httpStatusCodeToExceptionCode):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToDataURL):
- fileapi/FileReader.h:
- html/FormDataList.cpp: Account to BlobData change.
(WebCore::FormDataList::appendString):
(WebCore::FormDataList::appendBlob):
- html/FormDataList.h: Account to BlobData change.
(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):
(WebCore::FormDataList::Item::blob):
(WebCore::FormDataList::items):
- loader/FormSubmission.cpp: Account to BlobData change.
(WebCore::FormSubmission::create):
- platform/BlobItem.cpp: Removed.
- platform/BlobItem.h: Removed.
- platform/network/BlobRegistryImpl.cpp: Add the implementations for resource loading.
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::loadResourceSynchronously):
- platform/network/BlobResourceHandle.cpp: Fix a bug that the ref is not added.
(WebCore::BlobResourceHandle::BlobResourceHandle):
- platform/network/FormData.cpp: Account to BlobData change.
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendKeyValuePairItems):
- platform/network/FormData.h: Account to BlobData change.
- platform/network/mac/FormDataStreamMac.mm: Resolve blob references in the form data.
(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):
- xml/XMLHttpRequest.cpp: Account to BlobData change.
(WebCore::XMLHttpRequest::send):
WebKit/chromium:
- src/WebSearchableFormData.cpp:
(WebCore::HasSuitableTextElement):
LayoutTests:
Add a new test and change an existing test. Both tests are written in
better organized utility files and modules.
- fast/files/file-reader-expected.txt: Removed.
- fast/files/file-reader.html: Removed.
- fast/files/read-blob-async-expected.txt: Added.
- fast/files/read-blob-async.html: Added.
- fast/files/read-file-async-expected.txt: Added.
- fast/files/read-file-async.html: Added.
- fast/files/resources/UTF8-2.txt: Added.
- fast/files/resources/UTF8-3.txt: Added.
- fast/files/resources/read-blob-test-cases.js: Added.
- fast/files/resources/read-common.js: Added.
- fast/files/resources/read-file-test-cases.js: Added.
- fast/files/resources/setup-for-read-common.js: Added.
- platform/gtk/Skipped: Account to the test changes for gtk.
- platform/mac-wk2/Skipped: Account to the test changes for mac-wk2.
- platform/qt/Skipped: Account to the test changes for qt.
- platform/win/Skipped: Account to the test changes for win.
- 9:41 PM Changeset in webkit [66451] by
-
- 2 edits in trunk/WebKit/efl
2010-08-30 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Adam Barth.
[EFL]Url of HistoryItem was broken for special character like korean
https://bugs.webkit.org/show_bug.cgi?id=44495
Remove unnecessary code. This makes a bug with complicated URL.
- ewk/ewk_frame.cpp: (ewk_frame_view_state_save):
- 9:24 PM Changeset in webkit [66450] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-30 Nat Duca <nduca@chromium.org>
Reviewed by Adam Barth.
[chromium] Accelerated Compositing: Artifacts/blink when enabling compositor.
https://bugs.webkit.org/show_bug.cgi?id=44196
If accelerated compositing enables after a page loads, the dirtied
portion of the screen will be only a subset of the full screen,
leading to artefacts. Avoid these artefacts by invalidating the
visible content rect on compositor initialization.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 8:44 PM Changeset in webkit [66449] by
-
- 36 edits in trunk
2010-08-30 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r66418.
http://trac.webkit.org/changeset/66418
https://bugs.webkit.org/show_bug.cgi?id=44896
Adam tried to roll this out with:
https://bugs.webkit.org/show_bug.cgi?id=44924
but we hit a commit-queue edgecase and it failed, trying again.
Causing test failures on multiple bots
- platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
- platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
2010-08-30 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r66418.
http://trac.webkit.org/changeset/66418
https://bugs.webkit.org/show_bug.cgi?id=44896
Adam tried to roll this out with:
https://bugs.webkit.org/show_bug.cgi?id=44924
but we hit a commit-queue edgecase and it failed, trying again.
Causing test failures on multiple bots
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h: (WebCore::RenderObject::setNeedsBoundariesUpdate):
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::styleWillChange):
- rendering/RenderPath.h: (WebCore::RenderPath::setNeedsBoundariesUpdate):
- rendering/RenderSVGBlock.cpp:
- rendering/RenderSVGBlock.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calculateLocalTransform):
- rendering/RenderSVGGradientStop.h:
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint): (WebCore::RenderSVGHiddenContainer::objectBoundingBox): (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInline.cpp:
- rendering/RenderSVGInline.h:
- rendering/RenderSVGModelObject.cpp:
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::strokeBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox):
- rendering/SVGRenderSupport.h:
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
- 8:34 PM Changeset in webkit [66448] by
-
- 15 edits in trunk
Add missing parts of didFinishDocumentLoadForFrame
https://bugs.webkit.org/show_bug.cgi?id=44913
Reviewed by Darin Adler.
WebKit2:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added new kind
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage): Updated struct
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame): Added
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage): Added case for WebPageProxyMessage::DidFinishDocumentLoadForFrame
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame): Added
- UIProcess/WebPageProxy.h:
Just rearranging existing code in these:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(didFinishDocumentLoadForFrame): Added
(-[BrowserWindowController awakeFromNib]): Updated struct
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Updated struct
- 7:14 PM Changeset in webkit [66447] by
-
- 6 edits in trunk
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement CDATASection state for the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=44923
In the spec, this state refers back to the HTMLTreeBuilder from the
HTMLTokenizer. Rather that introduce that (backwards) dependencies, we
have the tree builder set a bit on the tokenizer.
- html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::nextToken):
- html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::shouldAllowCDATA): (WebCore::HTMLTokenizer::setShouldAllowCDATA):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken):
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement CDATASection state for the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=44923
Large test progression.
- html5lib/runner-expected.txt:
- 7:04 PM Changeset in webkit [66446] by
-
- 3 edits in trunk/JavaScriptCore
2010-08-30 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix namespace for wtf/Complex.h and wtf/Vector3.h
https://bugs.webkit.org/show_bug.cgi?id=44892
- wtf/Complex.h:
- wtf/Vector3.h:
- 6:40 PM Changeset in webkit [66445] by
-
- 4 edits in tags/Safari-534.6.3/WebKit/mac
Merge r66441.
- 6:40 PM Changeset in webkit [66444] by
-
- 5 edits in tags/Safari-534.6.3
Versioning.
- 6:32 PM Changeset in webkit [66443] by
-
- 5 edits in trunk
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Enable HTML5lib's test_innerHTML01.dat
https://bugs.webkit.org/show_bug.cgi?id=44919
These tests provoked two branches that we hadn't implemented yet.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag):
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Enable HTML5lib's test_innerHTML01.dat
https://bugs.webkit.org/show_bug.cgi?id=44919
Enable these tests now that they don't ASSERT. Yay! They pass. :)
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 6:32 PM Changeset in webkit [66442] by
-
- 1 copy in tags/Safari-534.6.3
New tag.
- 6:07 PM Changeset in webkit [66441] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/8369736> WebKit build fails.
Reviewed by Darin Adler.
Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
- Carbon/HIViewAdapter.m:
- Carbon/HIWebView.mm:
- Plugins/WebNetscapePluginView.mm:
- 6:06 PM Changeset in webkit [66440] by
-
- 2 edits in trunk/WebCore
Stop using a QuickDraw function that was only used for debugging purposes.
Reviewed by Darin Adler.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::pathFromFont):
- 6:04 PM Changeset in webkit [66439] by
-
- 2 edits in trunk/WebKit2
Try and fix the WebKit2 buildbot.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add missing initialization of QTMovieDisableComponent.
- 6:04 PM Changeset in webkit [66438] by
-
- 2 edits in trunk/WebKit/win
Fix crash on launch on Windows due to changing IWebFramePrivate's vtable
This regressed in r65107.
Fixes <http://webkit.org/b/44755>.
Rubber-stamped by Jon Honeycutt.
- Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
resumeAnimations to the end of the interface so that the vtable will
match what Safari expects.
- 6:01 PM Changeset in webkit [66437] by
-
- 4 edits in trunk/WebKit
WebKit: Add 'application/x-snkp' to StringsNotToBeLocalized.txt.
Reviewed by Darin Adler.
- StringsNotToBeLocalized.txt:
WebKit/mac: REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
https://bugs.webkit.org/show_bug.cgi?id=44865
Reviewed by Darin Adler.
After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
for authentication fail to log in. This is due to a bug in AppleConnect that r66156
exposed, but since this will have a significant impact on users of WebKit nightly
builds, a plugin-specific hack should be added while the underlying issue is being
addressed.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
if the plugin is of type 'application/x-snkp'.
- 5:51 PM Changeset in webkit [66436] by
-
- 17 edits15 adds in trunk/WebKit2
Add URLRequest API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44910
Reviewed by Anders Carlsson.
Add WebURLRequest class and WKURLRequestRef C API to go with it. Right now,
instance of WKURLRequestRef are manipulated via platform types, a la the
WKStringRef and WKURLRef types.
- Pipes WKPageLoadURLRequest through to the WebProcess.
- Shared/APIObject.h:
- Shared/CoreIPCSupport/WebPageMessageKinds.h:
- Shared/WebCoreArgumentCoders.h:
- Shared/WebURLRequest.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
- Shared/WebURLRequest.h: Added.
(WebKit::WebURLRequest::create):
(WebKit::WebURLRequest::resourceRequest):
(WebKit::WebURLRequest::type):
- Shared/mac/WebCoreArgumentCodersMac.mm: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
- Shared/mac/WebURLRequestMac.mm: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
- Shared/qt/WebCoreArgumentCodersQt.cpp: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
- Shared/qt/WebURLRequestQt.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
- Shared/win/WebCoreArgumentCodersWin.cpp: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
- Shared/win/WebURLRequestWin.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadURLRequest):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKURLRequest.cpp: Added.
(WKURLRequestGetTypeID):
- UIProcess/API/C/WKURLRequest.h: Added.
- UIProcess/API/C/WebKit2.h:
- UIProcess/API/C/cf/WKURLRequestCF.cpp: Added.
(WKURLRequestCreateWithCFURLRequest):
(WKURLRequestCopyCFURLRequest):
- UIProcess/API/C/cf/WKURLRequestCF.h: Added.
- UIProcess/API/C/mac: Added.
- UIProcess/API/C/mac/WKURLRequestNS.h: Added.
- UIProcess/API/C/mac/WKURLRequestNS.mm: Added.
(WKURLRequestCreateWithNSURLRequest):
(WKURLRequestCopyNSURLRequest):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
- UIProcess/WebPageProxy.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 5:44 PM Changeset in webkit [66435] by
-
- 5 edits2 adds in trunk/LayoutTests
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Import new tests from HTML5lib
https://bugs.webkit.org/show_bug.cgi?id=44912
- html5lib/resources/tests10.dat:
- html5lib/resources/tests20.dat:
- html5lib/resources/tests21.dat: Added.
- html5lib/resources/tests_innerHTML_1.dat: Added.
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 5:39 PM Changeset in webkit [66434] by
-
- 6 edits5 adds4 deletes in trunk/LayoutTests
2010-08-30 Yuta Kitamura <yutak@chromium.org>
Unreviewed test expectation update.
Update Chromium test expectations
https://bugs.webkit.org/show_bug.cgi?id=44859
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed. Test expectation was wrong.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Ditto.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:38 PM Changeset in webkit [66433] by
-
- 2 edits in trunk/WebKitTools
2010-08-30 Vangelis Kokkevis <vangelis@chromium.org>
Unreviewed: Add myself to the list of Committers.
- Scripts/webkitpy/common/config/committers.py:
- 5:29 PM Changeset in webkit [66432] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
- platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
- platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
- 5:26 PM Changeset in webkit [66431] by
-
- 7 edits2 adds in trunk
2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
https://bugs.webkit.org/show_bug.cgi?id=21680
The bug was caused by WebKit's using the computed style to obtain the background color,
which is rgba(0,0,0,0) for nodes with transparent background color. While this is correct
in the accordance to CSS2 because background-color is not inherited by default,
it is not desirable for editing purposes where the background color in effect is expected.
Modified valueStyle in EditorCommand.cpp to call Editor::selectionStartCSSPropertyValue,
instead of Frame::selectionStartStylePropertyValue, which traverses common ancestors of
the selected range or caret to retrieve the effective background color of the selected region
instead of the background color at the start of the selection.
This takes effect when the original background color is transparent or the selection is range
(to avoid picking up the background color only present at the start of paragraph).
Removed selectionStartStylePropertyValue and migrated it to Editor::selectionStartCSSPropertyValue.
Test: editing/execCommand/query-command-value-background-color.html
- editing/Editor.cpp: (WebCore::hasTransparentBackgroundColor): Checks whether the specified style's background color is transparent or not. (WebCore::Editor::selectionStartCSSPropertyValue): Migrated the contents of selectionStartStylePropertyValue and added the special case for background color.
- editing/Editor.h: Added the prototype for selectionStartCSSPropertyValue.
- editing/EditorCommand.cpp: (WebCore::valueStyle): Calls Editor::selectionStartCSSPropertyValue.
- page/Frame.cpp: Removed selectionStartStylePropertyValue.
- page/Frame.h: Ditto.
2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
https://bugs.webkit.org/show_bug.cgi?id=21680
Tests queryCommandValue("BackColor") on various cases, especially the cases where
the background color of the selected node is transparent but that of its ancestor has a color.
- editing/execCommand/query-command-value-background-color-expected.txt: Added.
- editing/execCommand/query-command-value-background-color.html: Added.
- 5:19 PM Changeset in webkit [66430] by
-
- 4 edits in trunk
2010-08-30 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Fix fast/notifications/notifications-display-close-events.html failure
https://bugs.webkit.org/show_bug.cgi?id=44585
- platform/chromium/drt_expectations.txt:
2010-08-30 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Fix fast/notifications/notifications-display-close-events.html failure
https://bugs.webkit.org/show_bug.cgi?id=44585
Apply http://crrev.com/48893. We should dispatch display events
asynchronously.
- DumpRenderTree/chromium/NotificationPresenter.cpp: (deferredDisplayDispatch): (NotificationPresenter::show):
- 5:11 PM Changeset in webkit [66429] by
-
- 3 edits in trunk/LayoutTests
2010-08-30 Tony Chang <tony@chromium.org>
Unreviewed, rebaseline plugins/mouse-event.html on chromium win/linux
after http://trac.webkit.org/changeset/66408.
- platform/chromium-linux/plugins/mouse-events-expected.txt:
- platform/chromium-win/plugins/mouse-events-expected.txt:
- 5:02 PM Changeset in webkit [66428] by
-
- 4 edits1 add in trunk/WebCore
2010-08-30 Lei Zhang <thestig@chromium.org>
Reviewed by Shinichiro Hamaji.
Defer printing until the FrameLoader finishes loading.
https://bugs.webkit.org/show_bug.cgi?id=43658
- manual-tests/print-before-load.html: Added.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoading):
- page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print):
- page/DOMWindow.h: (WebCore::DOMWindow::printDeferred):
- 5:01 PM Changeset in webkit [66427] by
-
- 22 edits1 add in branches/audio
audio branch: lots of random cleanup for moving to trunk
- 5:00 PM Changeset in webkit [66426] by
-
- 2 edits in trunk
2010-08-30 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Adam Barth.
[EFL] Remove compiler optimization for gcc 4.5.1
https://bugs.webkit.org/show_bug.cgi?id=44520
GCC 4.5.1 generates wrong code because of -ftree-sra which is enabled
by default at any optimization level.
Newer and older versions are not affected, so check for compiler
version before disabling this.
- cmake/WebKitHelpers.cmake: add flag depending on compiler version.
- 4:37 PM Changeset in webkit [66425] by
-
- 3 edits in trunk/LayoutTests
2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adele Peterson.
REGRESSION(r51939): platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html fails
https://bugs.webkit.org/show_bug.cgi?id=44897
Fixed the path to fast/js/resources/
- platform/chromium/test_expectations.txt: No longer fails.
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Fixed.
- 4:29 PM Changeset in webkit [66424] by
-
- 2 edits in trunk/LayoutTests
2010-08-30 Tony Chang <tony@chromium.org>
Unreviewed, fixing chromium test_expectations after r66299.
- platform/chromium/test_expectations.txt:
- 4:14 PM Changeset in webkit [66423] by
-
- 2 edits6 deletes in trunk/LayoutTests
2010-08-30 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] incorrect baselines on all platforms for fast/css/font-weight-1
https://bugs.webkit.org/show_bug.cgi?id=44904
This test uses a custom font. From the change that checked them in, it
required build changes to make this custom font available for the tests.
The Chromium baselines were obviously wrong.
- platform/chromium-linux/fast/css/font-weight-1-expected.checksum: Removed.
- platform/chromium-linux/fast/css/font-weight-1-expected.png: Removed.
- platform/chromium-linux/fast/css/font-weight-1-expected.txt: Removed.
- platform/chromium-win/fast/css/font-weight-1-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-weight-1-expected.png: Removed.
- platform/chromium-win/fast/css/font-weight-1-expected.txt: Removed.
- platform/chromium/test_expectations.txt: mark as failing on all platforms.
- 3:57 PM Changeset in webkit [66422] by
-
- 1 edit in trunk/BugsSite/PrettyPatch/PrettyPatch.rb
Typo fix.
- 3:53 PM Changeset in webkit [66421] by
-
- 2 edits33 deletes in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium-linux/fast/lists/li-values-expected.checksum: Removed.
- platform/chromium-linux/fast/lists/li-values-expected.png: Removed.
- platform/chromium-linux/fast/lists/li-values-expected.txt: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
- platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
- platform/chromium-linux/fast/lists/w3-list-styles-expected.checksum: Removed.
- platform/chromium-linux/fast/lists/w3-list-styles-expected.png: Removed.
- platform/chromium-linux/fast/lists/w3-list-styles-expected.txt: Removed.
- platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
- platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
- platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
- platform/chromium-win/fast/lists/alpha-boundary-values-expected.checksum: Removed.
- platform/chromium-win/fast/lists/alpha-boundary-values-expected.png: Removed.
- platform/chromium-win/fast/lists/alpha-boundary-values-expected.txt: Removed.
- platform/chromium-win/fast/lists/alpha-list-wrap-expected.checksum: Removed.
- platform/chromium-win/fast/lists/alpha-list-wrap-expected.png: Removed.
- platform/chromium-win/fast/lists/alpha-list-wrap-expected.txt: Removed.
- platform/chromium-win/fast/lists/decimal-leading-zero-expected.checksum: Removed.
- platform/chromium-win/fast/lists/decimal-leading-zero-expected.png: Removed.
- platform/chromium-win/fast/lists/decimal-leading-zero-expected.txt: Removed.
- platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
- platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
- platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
- platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
- platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
- platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
- platform/chromium-win/fast/lists/w3-list-styles-expected.checksum: Removed.
- platform/chromium-win/fast/lists/w3-list-styles-expected.png: Removed.
- platform/chromium-win/fast/lists/w3-list-styles-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 3:52 PM Changeset in webkit [66420] by
-
- 3 edits in trunk/BugsSite
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[review tool] Let reviewer select how much context to show in snippet
https://bugs.webkit.org/show_bug.cgi?id=44905
We now highlight the context for a comment in yellow on the left (where
the line numbers are). Clicking a line number expands or contracts the
amount of context, as appropriate. Informal user testing indicates
that we might want to support drag as well.
This patch also changes the "open a comment box here" action to
double-click to avoid issues with mis-clicks.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 3:43 PM Changeset in webkit [66419] by
-
- 1 edit8 adds in trunk/WebCore
2010-08-30 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add ReverbConvolver class
https://bugs.webkit.org/show_bug.cgi?id=34912
No new tests since audio API is not yet implemented.
- platform/audio: Added.
- platform/audio/ReverbAccumulationBuffer.cpp: Added. (WebCore::ReverbAccumulationBuffer::ReverbAccumulationBuffer): (WebCore::ReverbAccumulationBuffer::readAndClear): (WebCore::ReverbAccumulationBuffer::updateReadIndex): (WebCore::ReverbAccumulationBuffer::accumulate): (WebCore::ReverbAccumulationBuffer::reset):
- platform/audio/ReverbAccumulationBuffer.h: Added. (WebCore::ReverbAccumulationBuffer::readIndex): (WebCore::ReverbAccumulationBuffer::readTimeFrame):
- platform/audio/ReverbConvolver.cpp: Added. (WebCore::backgroundThreadEntry): (WebCore::ReverbConvolver::ReverbConvolver): (WebCore::ReverbConvolver::~ReverbConvolver): (WebCore::ReverbConvolver::backgroundThreadEntry): (WebCore::ReverbConvolver::process): (WebCore::ReverbConvolver::reset):
- platform/audio/ReverbConvolver.h: Added. (WebCore::ReverbConvolver::impulseResponseLength): (WebCore::ReverbConvolver::inputBuffer): (WebCore::ReverbConvolver::useBackgroundThreads):
- platform/audio/ReverbConvolverStage.cpp: Added. (WebCore::ReverbConvolverStage::ReverbConvolverStage): (WebCore::ReverbConvolverStage::processInBackground): (WebCore::ReverbConvolverStage::process): (WebCore::ReverbConvolverStage::reset):
- platform/audio/ReverbConvolverStage.h: Added. (WebCore::ReverbConvolverStage::inputReadIndex):
- platform/audio/ReverbInputBuffer.cpp: Added. (WebCore::ReverbInputBuffer::ReverbInputBuffer): (WebCore::ReverbInputBuffer::write): (WebCore::ReverbInputBuffer::directReadFrom): (WebCore::ReverbInputBuffer::reset):
- platform/audio/ReverbInputBuffer.h: Added. (WebCore::ReverbInputBuffer::writeIndex):
- 3:37 PM Changeset in webkit [66418] by
-
- 36 edits in trunk
2010-08-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add culling to RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=44896
Cache object/strokeBoundingBox and repaintRectInLocalCoordinates() in RenderSVGContainer & RenderSVGRoot, just like it's done in RenderPath.
Propagate boundary changes up the render tree, in layout phase, in order to notify parents that they should update their cached boundaries.
This is a huge speed benefit when interacting with an already layouted document, as there's no need anymore to traverse all children
of any container or <svg> element, just to retrieve the repaint rect.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setNeedsBoundariesUpdate):
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint):
- rendering/RenderPath.h: (WebCore::RenderPath::path): (WebCore::RenderPath::setNeedsBoundariesUpdate):
- rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::styleWillChange):
- rendering/RenderSVGBlock.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::updateCachedBoundaries):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): (WebCore::RenderSVGContainer::calculateLocalTransform):
- rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::strokeBoundingBox):
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::styleWillChange):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::styleWillChange):
- rendering/RenderSVGInline.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleWillChange):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::styleWillChange): (WebCore::RenderSVGRoot::updateCachedBoundaries):
- rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::setNeedsBoundariesUpdate): (WebCore::RenderSVGRoot::setNeedsTransformUpdate): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::strokeBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): (WebCore::SVGRenderSupport::paintInfoIntersectsRepaintRect):
- rendering/SVGRenderSupport.h:
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
2010-08-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add culling to RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=44896
Update some pixel test results, that show marginal changes.
- platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
- platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
- platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- 3:31 PM Changeset in webkit [66417] by
-
- 3 edits in trunk/WebCore
2010-08-30 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix when ENABLE_WEB_SOCKETS=ON.
EFL port does not yet support automated tests.
- CMakeLists.txt: Add missing files.
- CMakeListsEfl.txt: Ditto.
- 3:28 PM Changeset in webkit [66416] by
-
- 3 edits in trunk/WebCore
2010-08-30 Kenneth Russell <kbr@google.com>
Reviewed by Chris Marrin.
Expose Vector3 and associated operations
https://bugs.webkit.org/show_bug.cgi?id=44666
Rolling out earlier patch exposing Vector3 class in
TransformationMatrix.h. A different approach will be taken under
another bug.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::v3Length): (WebCore::v3Scale): (WebCore::v3Dot): (WebCore::v3Combine): (WebCore::v3Cross): (WebCore::decompose):
- platform/graphics/transforms/TransformationMatrix.ha:
- 3:25 PM Changeset in webkit [66415] by
-
- 2 edits in trunk/WebCore
Build fix; Unreviewed.
Added a export symbol to the WebCore.exp.in list.
- WebCore.exp.in:
- 3:20 PM Changeset in webkit [66414] by
-
- 1 edit2 adds in trunk/WebCore
2010-08-30 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add audio cone effect files. The cone effect operates as defined in the OpenAL specification.
https://bugs.webkit.org/show_bug.cgi?id=44712
No new tests since audio API not implemented yet.
- platform/audio: Added.
- platform/audio/Cone.cpp: Added. (WebCore::ConeEffect::ConeEffect): (WebCore::ConeEffect::gain):
- platform/audio/Cone.h: Added. (WebCore::ConeEffect::setInnerAngle): (WebCore::ConeEffect::innerAngle): (WebCore::ConeEffect::setOuterAngle): (WebCore::ConeEffect::outerAngle): (WebCore::ConeEffect::setOuterGain): (WebCore::ConeEffect::outerGain):
- 3:16 PM Changeset in webkit [66413] by
-
- 1 edit2 adds in trunk/WebCore
2010-08-30 Chris Rogers <crogers@google.com>
Reviewed by Chris Marrin.
audio engine: add Reverb class
https://bugs.webkit.org/show_bug.cgi?id=36466
No new tests since audio API is not yet implemented.
- platform/audio: Added.
- platform/audio/Reverb.cpp: Added. (WebCore::calculateNormalizationScale): (WebCore::Reverb::Reverb): (WebCore::Reverb::initialize): (WebCore::Reverb::process): (WebCore::Reverb::reset):
- platform/audio/Reverb.h: Added. (WebCore::Reverb::): (WebCore::Reverb::impulseResponseLength):
- 3:10 PM Changeset in webkit [66412] by
-
- 1 edit1 add in trunk/WebCore
2010-08-30 Chris Rogers <crogers@google.com>
Unreviewed
Add WebCore/platform/audio directory
in preparation for landing: https://bugs.webkit.org/show_bug.cgi?id=36466
- platform/audio: Added.
- 2:47 PM Changeset in webkit [66411] by
-
- 10 edits5 adds in trunk
2010-08-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
text/plain non-video files cause <video> to hang (while reading them?)
https://bugs.webkit.org/show_bug.cgi?id=44212
Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
the initialization routine.
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
2010-08-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
text/plain non-video files cause <video> to hang (while reading them?)
https://bugs.webkit.org/show_bug.cgi?id=44212
Disable all the QuickTime components which ingest .txt files.
New tests:
- http/tests/media/video-served-as-text.html: Added.
- http/tests/media/text-served-as-text.html: Added.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Disable all four text
'eat' components.
- platform/mac/WebCoreSystemInterface.h: Add wkQTMovieDisableComponent.
- platform/mac/WebCoreSystemInterface.mm: Add wkQTMovieDisableComponent.
2010-08-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
text/plain non-video files cause <video> to hang (while reading them?)
https://bugs.webkit.org/show_bug.cgi?id=44212
Added two new tests: video-served-as-text.html and
text-served-as-text.html. The second checks that a text file does not
generates an error when loaded by a <video> element. The first checks
that media served as text/plain still loads without errors.
- http/tests/media/resources/test.txt: Added.
- http/tests/media/text-served-as-text-expected.txt: Added.
- http/tests/media/text-served-as-text.html: Added.
- http/tests/media/video-served-as-text-expected.txt: Added.
- http/tests/media/video-served-as-text.html: Added.
- 2:39 PM Changeset in webkit [66410] by
-
- 2 edits in trunk/LayoutTests
2010-08-30 Evan Martin <evan@chromium.org>
Unreviewed, updating Chromium expectations.
Revert part of my update in r66406 that was wrong.
- platform/chromium/test_expectations.txt:
- 2:26 PM Changeset in webkit [66409] by
-
- 3 edits in trunk/LayoutTests
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Update LayoutTest for file inputs to show "pass" for fakepath
https://bugs.webkit.org/show_bug.cgi?id=44882
As requested by Alexey.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/script-tests/file-input-files-access.js: (draggingPathsShouldResultInFiles):
- 2:16 PM Changeset in webkit [66408] by
-
- 10 edits in trunk
2010-08-30 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
allow ports with windowed plugins to support windowless plugin tests
Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.
Unskip the following tests on Qt:
plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html
- platform/qt/Skipped:
- plugins/keyboard-events.html:
- plugins/mouse-events-fixedpos.html:
- plugins/mouse-events.html:
2010-08-30 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
allow ports with windowed plugins to support windowless plugin tests
Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.
Unskip the following tests on Qt:
plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus): (WebCore::setXKeyEventSpecificFields):
2010-08-30 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
allow ports with windowed plugins to support windowless plugin tests
Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.
Unskip the following tests on Qt:
plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginSetProperty):
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New):
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_handle_event):
- 1:50 PM Changeset in webkit [66407] by
-
- 15 edits in trunk
2010-08-30 Kinuko Yasuda <kinuko@chromium.osrc>
Reviewed by Darin Fisher.
Add DOMFileSystem implementation to support Entry manipulation operations
https://bugs.webkit.org/show_bug.cgi?id=44732
Fixed virtual-path / platform-path conversion timing. (The conversion needs to be done before calling AsyncFileSystem methods to support cross-filesystem operations.)
- src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::move): (WebCore::AsyncFileSystemChromium::copy): (WebCore::AsyncFileSystemChromium::remove): (WebCore::AsyncFileSystemChromium::readMetadata): (WebCore::AsyncFileSystemChromium::createFile): (WebCore::AsyncFileSystemChromium::createDirectory): (WebCore::AsyncFileSystemChromium::fileExists): (WebCore::AsyncFileSystemChromium::directoryExists): (WebCore::AsyncFileSystemChromium::readDirectory):
2010-08-30 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add DOMFileSystem implementation to support Entry manipulation operations
https://bugs.webkit.org/show_bug.cgi?id=44732
No new tests; tests will be added later.
- storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::root): (WebCore::checkValidityForForCopyOrMove): Added. (WebCore::DOMFileSystem::getMetadata): Added. (WebCore::DOMFileSystem::move): Added. (WebCore::DOMFileSystem::copy): Added. (WebCore::DOMFileSystem::remove): Added. (WebCore::DOMFileSystem::getParent): Added. (WebCore::DOMFileSystem::getFile): Added. (WebCore::DOMFileSystem::getDirectory): Added. (WebCore::DOMFileSystem::readDirectory): Added.
- storage/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): Added implementation. (WebCore::DirectoryEntry::getDirectory): Added implementation.
- storage/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added implementation. (WebCore::DirectoryReader::readEntries): Added implementation.
- storage/DirectoryReader.h:
- storage/Entry.cpp: (WebCore::Entry::getMetadata): Added implementation. (WebCore::Entry::moveTo): Added implementation. (WebCore::Entry::copyTo): Added implementation. (WebCore::Entry::remove): Added implementation. (WebCore::Entry::getParent): Added implementation.
- storage/Entry.h:
- storage/FileEntry.h:
Added a helper template to schedule callbacks.
- storage/DOMFileSystem.h: (WebCore::DOMFileSystem::DispatchCallbackTask): Added to schedule callbacks. (WebCore::DOMFileSystem::scheduleCallback): Added to schedule callbacks.
Changed to fire callbacks asynchronously.
- storage/LocalFileSystem.cpp: (WebCore::LocalFileSystem::requestFileSystem):
- 1:39 PM Changeset in webkit [66406] by
-
- 2 edits in trunk/LayoutTests
2010-08-30 Evan Martin <evan@chromium.org>
Unreviewed, updating Chromium expectations.
Simplify some obsolete test expectations based on looking at their
current behavior on the dashboard.
- platform/chromium/test_expectations.txt:
- 1:20 PM Changeset in webkit [66405] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after addition of fileapi directory in WebCore.
- 1:16 PM Changeset in webkit [66404] by
-
- 5 edits in trunk
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed compilation error, now that we have included the
GtkVersioning.h we have to remove some version dependent code from
EventSender.
- platform/gtk/GtkVersioning.c: (gdk_window_get_root_coords):
- platform/gtk/GtkVersioning.h:
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed compilation error, now that we have included the
GtkVersioning.h we have to remove some version dependent code from
EventSender.
- DumpRenderTree/gtk/EventSender.cpp:
- 1:03 PM Changeset in webkit [66403] by
-
- 3 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and corresponding-
<rdar://problem/8342055>
Reviewed by Sam Weinig.
All of the calls to firstChild() and lastChild() in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint() need to be
null checked.
- mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and-
https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()
Reviewed by Sam Weinig.
- mathml/empty-mroot-crash-expected.txt: Added.
- mathml/empty-mroot-crash.xhtml: Added.
- mathml/msubsup-no-grandchild-expected.txt: Added.
- mathml/msubsup-no-grandchild.xhtml: Added.
- 12:56 PM Changeset in webkit [66402] by
-
- 2 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()
-and corresponding-
<rdar://problem/8325203>
Reviewed by Darin Adler.
Null-check m_scripts. It is null-checked everywhere else in the
class and can legitimately be null.
- mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
- 12:27 PM Changeset in webkit [66401] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-30 Andy Estes <aestes@apple.com>
Reviewed by Eric Carlson.
Strings returned by asciiDebug() should be NULL-terminated.
https://bugs.webkit.org/show_bug.cgi?id=44866
- wtf/text/WTFString.cpp: (asciiDebug):
- 12:21 PM Changeset in webkit [66400] by
-
- 2 edits12 adds in trunk/LayoutTests
2010-08-30 Martin Robinson <mrobinson@igalia.com>
Unskip passing philip canvas tests and unskip and add results for some more shadow tests.
- platform/gtk/Skipped:
- platform/gtk/svg/css/composite-shadow-example-expected.checksum: Added.
- platform/gtk/svg/css/composite-shadow-example-expected.png: Added.
- platform/gtk/svg/css/composite-shadow-example-expected.txt: Added.
- platform/gtk/svg/css/composite-shadow-text-expected.checksum: Added.
- platform/gtk/svg/css/composite-shadow-text-expected.png: Added.
- platform/gtk/svg/css/composite-shadow-text-expected.txt: Added.
- platform/gtk/svg/css/shadow-with-large-radius-expected.checksum: Added.
- platform/gtk/svg/css/shadow-with-large-radius-expected.png: Added.
- platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-large-radius-expected.txt.
- platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum: Added.
- platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Added.
- platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-negative-offset-expected.txt.
- 12:06 PM Changeset in webkit [66399] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
Moved my name from committer to reviewer
- 12:06 PM Changeset in webkit [66398] by
-
- 10 edits1 move in trunk
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
https://bugs.webkit.org/show_bug.cgi?id=44787
We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.
- GNUmakefile.am:
- platform/gtk/GtkVersioning.c: Added. (gtk_adjustment_set_value): (gtk_adjustment_configure): (getDefaultGDKPointerDevice):
- platform/gtk/GtkVersioning.cpp: Removed.
- platform/gtk/GtkVersioning.h:
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
https://bugs.webkit.org/show_bug.cgi?id=44787
We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.
- GNUmakefile.am:
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
https://bugs.webkit.org/show_bug.cgi?id=44787
We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.
- DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): (mouseMoveToCallback): (keyDownCallback):
- GNUmakefile.am:
- 11:44 AM Changeset in webkit [66397] by
-
- 257 edits in trunk/WebCore
2010-08-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Make SVG constructors private to make sure callers all use create
https://bugs.webkit.org/show_bug.cgi?id=44872
Made as many members private and protected as possible, and got rid of many
unneeded empty constructor and destructor definitions, in some cases changing
a class to be non-polymorphic. Made some functions inline. Used the word document
instead of the abbreviation doc. Removed unneeded explicit base class
initialization in cases where it is no different from the default behavior.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement): (WebCore::SVGAElement::childShouldCreateRenderer):
- svg/SVGAElement.h:
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
- svg/SVGAltGlyphElement.h:
- svg/SVGAngle.cpp:
- svg/SVGAngle.h:
- svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement):
- svg/SVGAnimateElement.h:
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedPathData.cpp:
- svg/SVGAnimatedPathData.h:
- svg/SVGAnimatedPoints.cpp:
- svg/SVGAnimatedPoints.h:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement):
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement):
- svg/SVGClipPathElement.h:
- svg/SVGColor.cpp:
- svg/SVGColor.h:
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement):
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h:
- svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement):
- svg/SVGDescElement.h:
- svg/SVGDocument.cpp:
- svg/SVGDocument.h:
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.h:
- svg/SVGElementInstanceList.h:
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement):
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
- svg/SVGFEFuncRElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
- svg/SVGFEOffsetElement.h:
- svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::SVGFEPointLightElement): (WebCore::SVGFEPointLightElement::lightSource):
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
- svg/SVGFESpotLightElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFitToViewBox.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontData.cpp:
- svg/SVGFontData.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement):
- svg/SVGFontElement.h:
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement):
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
- svg/SVGFontFaceUriElement.h:
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement):
- svg/SVGGElement.h:
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement):
- svg/SVGGlyphElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement):
- svg/SVGGradientElement.h:
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::SVGHKernElement):
- svg/SVGHKernElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
- svg/SVGImageElement.h:
- svg/SVGImageLoader.cpp:
- svg/SVGImageLoader.h:
- svg/SVGLangSpace.cpp:
- svg/SVGLangSpace.h:
- svg/SVGLengthList.cpp:
- svg/SVGLengthList.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
- svg/SVGLinearGradientElement.h:
- svg/SVGLocatable.cpp:
- svg/SVGLocatable.h:
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement):
- svg/SVGMaskElement.h:
- svg/SVGMetadataElement.cpp: (WebCore::SVGMetadataElement::SVGMetadataElement):
- svg/SVGMetadataElement.h:
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
- svg/SVGMissingGlyphElement.h:
- svg/SVGNumberList.cpp:
- svg/SVGNumberList.h:
- svg/SVGPaint.cpp:
- svg/SVGPaint.h:
- svg/SVGParserUtilities.cpp: (WebCore::genericParseNumber): (WebCore::parseNumber):
- svg/SVGPathBlender.cpp:
- svg/SVGPathBlender.h:
- svg/SVGPathBuilder.h:
- svg/SVGPathByteStreamBuilder.h:
- svg/SVGPathByteStreamSource.cpp:
- svg/SVGPathByteStreamSource.h:
- svg/SVGPathConsumer.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement):
- svg/SVGPathElement.h:
- svg/SVGPathParser.cpp:
- svg/SVGPathParser.h:
- svg/SVGPathSeg.cpp:
- svg/SVGPathSeg.h:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegClosePath.cpp:
- svg/SVGPathSegClosePath.h:
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticSmooth.h:
- svg/SVGPathSegLineto.h:
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegList.cpp:
- svg/SVGPathSegList.h:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathSegListSource.cpp:
- svg/SVGPathSegListSource.h:
- svg/SVGPathSegMoveto.h:
- svg/SVGPathSource.h:
- svg/SVGPathStringBuilder.cpp:
- svg/SVGPathStringBuilder.h:
- svg/SVGPathStringSource.cpp:
- svg/SVGPathStringSource.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
- svg/SVGPatternElement.h:
- svg/SVGPointList.cpp:
- svg/SVGPointList.h:
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement):
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::SVGPolygonElement):
- svg/SVGPolygonElement.h:
- svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::SVGPolylineElement):
- svg/SVGPolylineElement.h:
- svg/SVGPreserveAspectRatio.cpp:
- svg/SVGPreserveAspectRatio.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
- svg/SVGScriptElement.h:
- svg/SVGSetElement.cpp: (WebCore::SVGSetElement::SVGSetElement):
- svg/SVGSetElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement):
- svg/SVGStopElement.h:
- svg/SVGStringList.cpp:
- svg/SVGStringList.h:
- svg/SVGStylable.cpp:
- svg/SVGStylable.h:
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement):
- svg/SVGStyleElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement):
- svg/SVGStyledElement.h:
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement):
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::SVGTSpanElement):
- svg/SVGTests.cpp:
- svg/SVGTests.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::SVGTitleElement):
- svg/SVGTransform.cpp:
- svg/SVGTransform.h:
- svg/SVGTransformable.cpp:
- svg/SVGTransformable.h:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement):
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h:
- svg/SVGZoomAndPan.cpp:
- svg/SVGZoomAndPan.h:
- svg/SVGZoomEvent.cpp:
- svg/SVGZoomEvent.h:
- 10:35 AM Changeset in webkit [66396] by
-
- 2 edits in trunk/WebKit2
WorkQueue leaks its dispatch queue
<rdar://problem/8358509>
https://bugs.webkit.org/show_bug.cgi?id=44689
Reviewed by Sam Weinig.
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::platformInvalidate):
- 10:18 AM Changeset in webkit [66395] by
-
- 7 edits3 adds in trunk
2010-08-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Disable automatic looping
https://bugs.webkit.org/show_bug.cgi?id=44844
Test: media/video-does-not-loop.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Disable QuickTime automatic looping.
- platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::createMovieController): Ditto.
2010-08-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Disable automatic looping
https://bugs.webkit.org/show_bug.cgi?id=44844
- media/content/silence-loop.mov: Added.
- media/video-does-not-loop-expected.txt: Added.
- media/video-does-not-loop.html: Added.
- platform/chromium/test_expectations.txt: Skip new test.
- platform/gtk/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- 10:12 AM Changeset in webkit [66394] by
-
- 2 edits in trunk/WebCore
2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
ApplyStyleCommand::applyInlineStyle needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=44458
Cleanup:
- Isolated code to find the highest ancestor with embedding style, and deployed it in ApplyStyleCommand::applyInlineStyle.
- Combined the code to remove embedding style up to enclosing block and the code to remove unicode-bidi and direction properties between start and end nodes.
- Simplified the conditionals to apply embedding styles.
No new tests are added since this is a cleanup.
- editing/ApplyStyleCommand.cpp: (WebCore::highestEmbeddingAncestor): Added. (WebCore::ApplyStyleCommand::applyInlineStyle): See above.
- 9:45 AM Changeset in webkit [66393] by
-
- 2 edits65 adds in trunk/LayoutTests
2010-08-30 Martin Robinson <mrobinson@igalia.com>
Adding layout and pixel results in preparation for landing GTK+ shadow performance improvements.
- platform/gtk/Skipped: Unskip tests that now have results, skip tests that are definitely failing.
- platform/gtk/fast/box-shadow/basic-shadows-expected.checksum: Added.
- platform/gtk/fast/box-shadow/basic-shadows-expected.png: Added.
- platform/gtk/fast/box-shadow/basic-shadows-expected.txt: Added.
- platform/gtk/fast/box-shadow/border-radius-big-expected.checksum: Added.
- platform/gtk/fast/box-shadow/border-radius-big-expected.png: Added.
- platform/gtk/fast/box-shadow/border-radius-big-expected.txt: Added.
- platform/gtk/fast/box-shadow/inset-expected.checksum: Added.
- platform/gtk/fast/box-shadow/inset-expected.png: Added.
- platform/gtk/fast/box-shadow/inset-expected.txt: Added.
- platform/gtk/fast/box-shadow/spread-expected.checksum: Added.
- platform/gtk/fast/box-shadow/spread-expected.png: Added.
- platform/gtk/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
- platform/gtk/fast/box-shadow/transform-fringing-expected.checksum: Added.
- platform/gtk/fast/box-shadow/transform-fringing-expected.png: Added.
- platform/gtk/fast/box-shadow/transform-fringing-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-1-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-1-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-1-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-2-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-2-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-2-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-3-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-3-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-3-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-4-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-4-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-4-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-5-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-5-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-5-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-6-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-6-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-6-expected.txt: Added.
- platform/gtk/fast/canvas/shadow-offset-7-expected.checksum: Added.
- platform/gtk/fast/canvas/shadow-offset-7-expected.png: Added.
- platform/gtk/fast/canvas/shadow-offset-7-expected.txt: Added.
- platform/gtk/fast/css/shadow-multiple-expected.checksum: Added.
- platform/gtk/fast/css/shadow-multiple-expected.png: Added.
- platform/gtk/fast/css/shadow-multiple-expected.txt: Added.
- platform/gtk/fast/forms/box-shadow-override-expected.checksum: Added.
- platform/gtk/fast/forms/box-shadow-override-expected.png: Added.
- platform/gtk/fast/forms/box-shadow-override-expected.txt: Added.
- platform/gtk/fast/text/shadow-no-blur-expected.checksum: Added.
- platform/gtk/fast/text/shadow-no-blur-expected.png: Added.
- platform/gtk/fast/text/shadow-no-blur-expected.txt: Added.
- platform/gtk/fast/transforms/shadows-expected.checksum: Added.
- platform/gtk/fast/transforms/shadows-expected.png: Added.
- platform/gtk/fast/transforms/shadows-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/shadows-expected.txt.
- platform/gtk/svg/css/arrow-with-shadow-expected.checksum: Added.
- platform/gtk/svg/css/arrow-with-shadow-expected.png: Added.
- platform/gtk/svg/css/arrow-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/arrow-with-shadow-expected.txt.
- platform/gtk/svg/css/group-with-shadow-expected.checksum: Added.
- platform/gtk/svg/css/group-with-shadow-expected.png: Added.
- platform/gtk/svg/css/group-with-shadow-expected.txt: Added.
- platform/gtk/svg/css/mask-with-shadow-expected.checksum: Added.
- platform/gtk/svg/css/mask-with-shadow-expected.png: Added.
- platform/gtk/svg/css/mask-with-shadow-expected.txt: Added.
- platform/gtk/svg/css/path-with-shadow-expected.checksum: Added.
- platform/gtk/svg/css/path-with-shadow-expected.png: Added.
- platform/gtk/svg/css/path-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/path-with-shadow-expected.txt.
- platform/gtk/svg/css/stars-with-shadow-expected.checksum: Added.
- platform/gtk/svg/css/stars-with-shadow-expected.png: Added.
- platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.
- 9:18 AM Changeset in webkit [66392] by
-
- 2 edits in trunk/LayoutTests
2010-08-30 Simon Fraser <Simon Fraser>
Disable http/tests/css/css-image-loading.html on Windows.
- platform/win/Skipped:
- 8:58 AM Changeset in webkit [66391] by
-
- 9 edits in trunk/WebCore
2010-08-29 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Fix RenderStyle::addCursor to use a StyleImage, not a CachedImage
https://bugs.webkit.org/show_bug.cgi?id=44719
Modernize the CSS cursor code to use a StyleImage, rather
than a CachedImage in the CursorData, and handle the loading
of pending images for the cursor property.
Covered by manual tests in WebCore/manual-tests
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::loadPendingImages):
- html/canvas/WebGLRenderingContext.cpp:
- page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
- rendering/style/CursorData.h: (WebCore::CursorData::CursorData): (WebCore::CursorData::image): (WebCore::CursorData::setImage):
- rendering/style/CursorList.h: (WebCore::CursorList::operator[]):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::addCursor):
- rendering/style/RenderStyle.h:
- 8:48 AM Changeset in webkit [66390] by
-
- 2 edits in trunk/WebCore
2010-08-30 Martin Robinson <mrobinson@igalia.com>
Build fix. Add the new fileapi directory to the IDL vpath.
- GNUmakefile.am:
- 8:16 AM Changeset in webkit [66389] by
-
- 3 edits1 add in trunk
2010-08-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKit DOM bindings build should not depend on output GNUMakefile
https://bugs.webkit.org/show_bug.cgi?id=44805
Move the DOM bindings source lists and generator rules to
WebCore/bindings/gobject/GNUmakefile.am. This will prevent a full WebKit API
rebuild whenever the automake files change, decreasing build times.
- GNUmakefile.am:
2010-08-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKit DOM bindings build should not depend on output GNUMakefile
https://bugs.webkit.org/show_bug.cgi?id=44805
Move WebKit DOM bindings build rules to bindings/gobject/GNUmakefile.am to
prevent full WebKit API rebuilds when the automake files change.
No new tests as this is just a build change.
- bindings/gobject/GNUmakefile.am: Added.
- 7:27 AM Changeset in webkit [66388] by
-
- 2 edits in trunk/WebCore
2010-08-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: event listener properties are rendered as [object Object].
https://bugs.webkit.org/show_bug.cgi?id=44779
- inspector/front-end/EventListenersSidebarPane.js:
- 7:15 AM Changeset in webkit [66387] by
-
- 1 copy in releases/WebKitGTK/webkit-1.2.0
Late tagging of 1.2.0.
- 7:10 AM Changeset in webkit [66386] by
-
- 4 edits in trunk/WebKitTools
[Qt] Add new window menu to MiniBrowser
Reviewed by Kenneth Rohde Christiansen.
Implement newWindow function and add a menu item for opening new window in MiniBrowser.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/main.cpp:
(main):
- 5:40 AM Changeset in webkit [66385] by
-
- 2 edits in trunk/WebCore
2010-08-30 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix with Blob Support
[EFL] Build break with Blob support
https://bugs.webkit.org/show_bug.cgi?id=44858
No new features added, so no new tests.
- CMakeLists.txt:
- 4:57 AM Changeset in webkit [66384] by
-
- 2 edits in trunk/WebCore
2010-08-30 Andras Becsi <abecsi@webkit.org>
Unreviewed trivial fix.
[Qt] Let qmake know about HTML parser headers.
No new tests needed.
- WebCore.pro:
- 4:38 AM Changeset in webkit [66383] by
-
- 2 edits in trunk/WebCore
2010-08-30 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix fileapi header paths to fix warnings after r66365.
No new tests needed.
- WebCore.pro:
- 3:34 AM Changeset in webkit [66382] by
-
- 2 edits3 deletes in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium-win/fast/lists/li-values-expected.checksum: Removed.
- platform/chromium-win/fast/lists/li-values-expected.png: Removed.
- platform/chromium-win/fast/lists/li-values-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 3:06 AM Changeset in webkit [66381] by
-
- 3 edits1 add in trunk/LayoutTests
2010-08-30 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
- platform/chromium-linux/fast/lists/li-values-expected.txt: Added.
- platform/chromium-win/fast/lists/li-values-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:53 AM Changeset in webkit [66380] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-08-30 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change for r66359.
- platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
- platform/chromium-mac/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- 2:48 AM Changeset in webkit [66379] by
-
- 2 edits in trunk/WebCore
2010-08-30 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Kent Tamura.
REGRESSION(r66355): Fix warnings in html/DateComponents.cpp
https://bugs.webkit.org/show_bug.cgi?id=44855
- html/DateComponents.cpp:
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek): Suggested parentheses added around && within - 2:42 AM Changeset in webkit [66378] by
-
- 2 edits in trunk/WebCore
REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=44843
Reviewed by Darin Adler.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within - 2:13 AM Changeset in webkit [66377] by
-
- 4 edits in trunk/WebKit/efl
2010-08-30 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Kenneth Rohde Christiansen
[EFL] Added initial setting to turn on offline pages.
https://bugs.webkit.org/show_bug.cgi?id=44239
- ewk/ewk_main.cpp: Torn off non-EFL init to _ewk_init_body (ewk_init): Changed non-EFL init to call _ewk_init_body (_ewk_init_body): Moved internal init here and added cache directory path setting.
- ewk/ewk_view.cpp: Added new config items: offline_app_cache and cache_directory (_ewk_view_priv_new): creating cache_directory string (_ewk_view_priv_del): deleting cache_directory string (ewk_view_setting_offline_app_cache_get): (ewk_view_setting_offline_app_cache_set): (ewk_view_setting_cache_directory_get): (ewk_view_setting_cache_directory_set):
- ewk/ewk_view.h: added offline_app_cache and cache_directory props to ewk API
- 1:48 AM Changeset in webkit [66376] by
-
- 24 edits in trunk
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/inspector.js: (WebInspector.inspectedPageDestroyed):
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- src/InspectorFrontendClientImpl.cpp:
- src/InspectorFrontendClientImpl.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::closeWindow):
- WebCoreSupport/InspectorClientGtk.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView]):
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorFrontendClientQt::closeWindow):
- WebCoreSupport/InspectorClientQt.h:
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView):
- WebCoreSupport/WebInspectorClient.h:
- 1:24 AM Changeset in webkit [66375] by
-
- 3 edits in trunk/JavaScriptCore
Refactor number parsing in the lexer
https://bugs.webkit.org/show_bug.cgi?id=44104
Reviewed by Darin Adler.
Number parsing was full of gotos, and needed a complete
redesign to remove them (Only one remained). Furthermore
integer arithmetic is empolyed for fast cases (= small
integer numbers).
- parser/Lexer.cpp:
(JSC::Lexer::parseHex):
(JSC::Lexer::parseOctal):
(JSC::Lexer::parseDecimal):
(JSC::Lexer::parseNumberAfterDecimalPoint):
(JSC::Lexer::parseNumberAfterExponentIndicator):
(JSC::Lexer::lex):
- parser/Lexer.h:
- 1:03 AM Changeset in webkit [66374] by
-
- 2 edits in trunk/PlanetWebKit
Renamed Trolltech Labs to Qt Labs.
Reviewed by Tor Arne Vestbø.
- config.ini:
- 12:45 AM Changeset in webkit [66373] by
-
- 2 edits in trunk/WebCore
2010-08-30 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura.
Split webcore_svg off webcore_remaining. webcore_svg contains all svg
sources files.
https://bugs.webkit.org/show_bug.cgi?id=44840
- WebCore.gyp/WebCore.gyp:
- 12:44 AM Changeset in webkit [66372] by
-
- 7 edits1 add in trunk
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.
- platform/chromium/test_expectations.txt: Skips at this time and will rebaseline shortly.
- platform/mac/Skipped: Mac doesn't suffer from the problem.
- scrollbars/custom-scrollbar-with-incomplete-style.html: Added.
2010-08-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=43960
[Chromium] styled scroll bar on the window is painted badly.
WebKit assumes outermost scrollbar always painted.
So force their style to have the background color if it isn't
given by the stylesheet.
Test: scrollbars/custom-scrollbar-with-incomplete-style.html
- rendering/RenderObject.h: (WebCore::RenderObject::hasBackground): Extracted body to RenderStyle for sharing.
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): Added the workaround as mentioned above.
- rendering/RenderScrollbar.h:
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasBackground): Extracted from RenderObject.
- 12:35 AM Changeset in webkit [66371] by
-
- 3 edits2 adds in trunk
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
WebCore::RenderBlock::addChild* NULL ptrs
https://bugs.webkit.org/show_bug.cgi?id=43722
- fast/ruby/before-doesnt-crash-expected.txt: Added.
- fast/ruby/before-doesnt-crash.html: Added.
2010-08-30 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
WebCore::RenderBlock::addChild* NULL ptrs
https://bugs.webkit.org/show_bug.cgi?id=43722
Also includes some cleanup of comments and ASSERTs.
Test: fast/ruby/before-doesnt-crash.html
- rendering/RenderRuby.cpp: (WebCore::RenderRubyAsInline::addChild):
- 12:28 AM Changeset in webkit [66370] by
-
- 2 edits in trunk/WebCore
2010-08-30 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Kent Tamura
Move most dependencies to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44814
- WebCore.gyp/WebCore.gyp:
- 12:15 AM Changeset in webkit [66369] by
-
- 2 edits in trunk/WebCore
2010-08-30 Adam Barth <abarth@webkit.org>
Move AsyncImageResizer back to html to fix Chromium build.
- WebCore.gypi:
- 12:13 AM Changeset in webkit [66368] by
-
- 2 edits in trunk/WebCore
2010-08-30 Adam Barth <abarth@webkit.org>
Fix silly typo that breaks the build.
- WebCore.pro:
- 12:07 AM Changeset in webkit [66367] by
-
- 2 edits in trunk/WebCore
2010-08-30 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt build.
- WebCore.pri:
- 12:04 AM Changeset in webkit [66366] by
-
- 2 edits in trunk/WebCore
2010-08-30 Adam Barth <abarth@webkit.org>
Attempt to fix Chromium build.
- WebCore.gyp/WebCore.gyp:
- 12:00 AM Changeset in webkit [66365] by
-
- 10 edits31 moves1 add in trunk/WebCore
2010-08-29 Adam Barth <abarth@webkit.org>
Rubber-stamped by Maciej Stachowiak.
Move File and Blob related files from WebCore/html to WebCore/fileapi.
- Android.mk:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.xcodeproj/project.pbxproj:
- fileapi: Added.
- fileapi/AsyncFileWriter.h: Copied from WebCore/html/AsyncFileWriter.h.
- fileapi/Blob.cpp: Copied from WebCore/html/Blob.cpp.
- fileapi/Blob.h: Copied from WebCore/html/Blob.h.
- fileapi/Blob.idl: Copied from WebCore/html/Blob.idl.
- fileapi/BlobBuilder.cpp: Copied from WebCore/html/BlobBuilder.cpp.
- fileapi/BlobBuilder.h: Copied from WebCore/html/BlobBuilder.h.
- fileapi/BlobBuilder.idl: Copied from WebCore/html/BlobBuilder.idl.
- fileapi/BlobURL.cpp: Copied from WebCore/html/BlobURL.cpp.
- fileapi/BlobURL.h: Copied from WebCore/html/BlobURL.h.
- fileapi/File.cpp: Copied from WebCore/html/File.cpp.
- fileapi/File.h: Copied from WebCore/html/File.h.
- fileapi/File.idl: Copied from WebCore/html/File.idl.
- fileapi/FileError.h: Copied from WebCore/html/FileError.h.
- fileapi/FileError.idl: Copied from WebCore/html/FileError.idl.
- fileapi/FileList.cpp: Copied from WebCore/html/FileList.cpp.
- fileapi/FileList.h: Copied from WebCore/html/FileList.h.
- fileapi/FileList.idl: Copied from WebCore/html/FileList.idl.
- fileapi/FileReader.cpp: Copied from WebCore/html/FileReader.cpp.
- fileapi/FileReader.h: Copied from WebCore/html/FileReader.h.
- fileapi/FileReader.idl: Copied from WebCore/html/FileReader.idl.
- fileapi/FileStreamProxy.cpp: Copied from WebCore/html/FileStreamProxy.cpp.
- fileapi/FileStreamProxy.h: Copied from WebCore/html/FileStreamProxy.h.
- fileapi/FileThread.cpp: Copied from WebCore/html/FileThread.cpp.
- fileapi/FileThread.h: Copied from WebCore/html/FileThread.h.
- fileapi/FileThreadTask.h: Copied from WebCore/html/FileThreadTask.h.
- fileapi/FileWriter.cpp: Copied from WebCore/html/FileWriter.cpp.
- fileapi/FileWriter.h: Copied from WebCore/html/FileWriter.h.
- fileapi/FileWriter.idl: Copied from WebCore/html/FileWriter.idl.
- fileapi/FileWriterClient.h: Copied from WebCore/html/FileWriterClient.h.
- fileapi/ThreadableBlobRegistry.cpp: Copied from WebCore/html/ThreadableBlobRegistry.cpp.
- fileapi/ThreadableBlobRegistry.h: Copied from WebCore/html/ThreadableBlobRegistry.h.
- html/AsyncFileWriter.h: Removed.
- html/Blob.cpp: Removed.
- html/Blob.h: Removed.
- html/Blob.idl: Removed.
- html/BlobBuilder.cpp: Removed.
- html/BlobBuilder.h: Removed.
- html/BlobBuilder.idl: Removed.
- html/BlobURL.cpp: Removed.
- html/BlobURL.h: Removed.
- html/File.cpp: Removed.
- html/File.h: Removed.
- html/File.idl: Removed.
- html/FileError.h: Removed.
- html/FileError.idl: Removed.
- html/FileList.cpp: Removed.
- html/FileList.h: Removed.
- html/FileList.idl: Removed.
- html/FileReader.cpp: Removed.
- html/FileReader.h: Removed.
- html/FileReader.idl: Removed.
- html/FileStreamProxy.cpp: Removed.
- html/FileStreamProxy.h: Removed.
- html/FileThread.cpp: Removed.
- html/FileThread.h: Removed.
- html/FileThreadTask.h: Removed.
- html/FileWriter.cpp: Removed.
- html/FileWriter.h: Removed.
- html/FileWriter.idl: Removed.
- html/FileWriterClient.h: Removed.
- html/ThreadableBlobRegistry.cpp: Removed.
- html/ThreadableBlobRegistry.h: Removed.
