Timeline
Sep 7, 2010:
- 10:56 PM Changeset in webkit [66954] by
-
- 5 edits3 adds in trunk
DatasetDOMStringMap does not have the right memory model
https://bugs.webkit.org/show_bug.cgi?id=45358
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dom/dataset-gc.html
- bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren):
Mark the dataset if it exists.
- dom/Element.cpp:
(WebCore::Element::optionalDataset):
- dom/Element.h:
Expose a way to get the dataset or null (depending on if anyone thing
has forced its creation yet).
LayoutTests:
Test that the dataset persists gc.
- fast/dom/dataset-gc-expected.txt: Added.
- fast/dom/dataset-gc.html: Added.
- fast/dom/script-tests/dataset-gc.js: Added.
- 10:54 PM Changeset in webkit [66953] by
-
- 3 edits in trunk/WebKitTools
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading.
- TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
- 10:30 PM Changeset in webkit [66952] by
-
- 5 edits in trunk
Versioning.
- 10:28 PM Changeset in webkit [66951] by
-
- 1 copy in tags/Safari-534.7
New tag.
- 9:58 PM Changeset in webkit [66950] by
-
- 2 edits in trunk/WebKit2
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, another Qt release build fix attempt.
- UIProcess/API/cpp/qt/WKURLQt.cpp:
- 9:52 PM Changeset in webkit [66949] by
-
- 2 edits in trunk/WebKit2
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, attempt to fix Qt release build.
- UIProcess/API/cpp/qt/WKStringQt.cpp:
- 9:02 PM Changeset in webkit [66948] by
-
- 5 edits3 adds1 delete in trunk
2010-09-07 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] Added test case for Path::length()
https://bugs.webkit.org/show_bug.cgi?id=45331
Also removed test case for Path::pointAtLength() that is now passing
- platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
- svg/dom/path-totalLength-expected.txt: Added.
- svg/dom/path-totalLength.html: Added.
- svg/dom/script-tests/path-totalLength.js: Added. (getTotalLength):
2010-09-07 Jan E Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
https://bugs.webkit.org/show_bug.cgi?id=45331
This is needed due to an adverse effect of the fix in 44061 that causes
certain paths not to be closed. This is not important for canvas paths
but it is for SVG paths, so splitting up the code in a generic (SVG)
case and one specialized for canvas.
Test: svg/dom/path-totalLength.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
- platform/graphics/Path.h: (WebCore::Path::closeCanvasSubpath):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): (WebCore::Path::closeCanvasSubpath):
- 8:01 PM Changeset in webkit [66947] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix
Missed one test in mac_unittest.py in previous change; for some
reason the method is listed twice. I will fix both for now, but will
figure this out in a later, not-time-sensitive patch.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 7:56 PM Changeset in webkit [66946] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
test-webkitpy: Fix load error of
webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
- Scripts/webkitpy/layout_tests/port/server_process.py: Avoid to import fcntl on win32. Win32 Python doesn't have fcntl and we don't use server_process.py on Win32 Python. However unittest.py tries to load everything in a module.
- 7:23 PM Changeset in webkit [66945] by
-
- 4 edits in trunk/WebKitTools
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.
Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- 6:26 PM Changeset in webkit [66944] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Kent Tamura.
Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=45123
- resources/dump-as-markup.js: (Markup.waitUntilDone):
- 6:15 PM Changeset in webkit [66943] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-07 James Robinson <jamesr@chromium.org>
Compile fix attempt for windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:10 PM Changeset in webkit [66942] by
-
- 2 edits1 add in trunk/WebCore
2010-09-07 Simon Fraser <Simon Fraser>
Reviewed by Chris Marrin.
Transform animations always run in software now
https://bugs.webkit.org/show_bug.cgi?id=45341
After r66339 we always fell into software animation, because we
failed to detect transform or opacity properties in the keyframes,
so would send an empty list of values to the GraphicsLayer.
Fixed by using CSSProperty values, rather than GraphicsLayer
values, when detecting the presence of properties in the keyframes.
Test: manual-tests/transition-accelerated.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
- 6:02 PM Changeset in webkit [66941] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-07 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add FFTFrame files
https://bugs.webkit.org/show_bug.cgi?id=34827
No new tests since audio API is not yet implemented.
- platform/audio/FFTFrame.cpp: Added. (WebCore::FFTFrame::doPaddedFFT): (WebCore::FFTFrame::createInterpolatedFrame): (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay): (WebCore::FFTFrame::print):
- platform/audio/FFTFrame.h: Added. (WebCore::FFTFrame::fftSize): (WebCore::FFTFrame::log2FFTSize): (WebCore::FFTFrame::dspSplitComplex):
- platform/audio/mac/FFTFrameMac.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::fftSetupForSize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
- 5:54 PM Changeset in webkit [66940] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Fix Windows build after r66936
https://bugs.webkit.org/show_bug.cgi?id=45348
Add symbol names that were missing from r66936.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:50 PM Changeset in webkit [66939] by
-
- 5 edits in trunk
WebCore: Build fix, no review.
Provide stubs to allow WebKit.dll to build
for the WinCairo port.
- platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
- platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):
WebKit2: Build correction, no review.
- win/WebKit2.vcproj: Disable two unused files for
the WinCairo target.
- 5:48 PM Changeset in webkit [66938] by
-
- 1 edit1 add in trunk/WebCore
2010-09-07 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=45204
No new tests since audio API is not yet implemented.
- platform/audio/AudioArray.h: Added. (WebCore::AudioArray::AudioArray): (WebCore::AudioArray::zero): (WebCore::AudioArray::zeroRange): (WebCore::AudioArray::copyToRange):
- 5:46 PM Changeset in webkit [66937] by
-
- 14 edits2 copies14 adds in trunk/WebKitTools
2010-09-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: still more unit tests
Clean up and remove unnecessary code. Biggest notable change is
moving the chromium-specific imagediff code from port/base to
port/chromium.
Add more unit tests for run_webkit_tests.py, port/base.py,
port/factory.py, port/dryrun.py, and
layout_package/dump_render_tree_thread.py
This covers almost all of the generic and test code paths except for
a few error paths involving invalid or port-specific command line
arguments, and the code path for uploading results files to the
buildbots.
- Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
- Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
- Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
- Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
- Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
- Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
- Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
- Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
- Scripts/webkitpy/layout_tests/port/server_process.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:33 PM Changeset in webkit [66936] by
-
- 9 edits2 adds in trunk
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Move internal representation of JSC::RegExp (which depends on wether
YARR and YARR_JIT is enabled) into RegExpRepresentation which can live
in the implementation only. This makes it feasible to use RegExp in
WebCore without bringing in all of YARR.
- JavaScriptCore.exp: Export RegExp and RegExpObject functions that are needed inside WebCore's JSC bindings.
- runtime/RegExp.cpp: (JSC::RegExpRepresentation::~RegExpRepresentation): (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::compile): (JSC::RegExp::match):
- runtime/RegExp.h:
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Make RegExp test of pushstate-object-types.html actually test a RegExp
value with flags.
Also adds ImageData since it can be serialized as of r54646.
- fast/loader/stateobjects/pushstate-object-types-expected.txt:
- fast/loader/stateobjects/pushstate-object-types.html:
2010-09-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Oliver Hunt.
pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718
Add RegExp support to the JSC implementation of SerializedScriptValue
(it stores the pattern and flags read from a RegExpObject, and creates
a new one on deserialization).
Tests: fast/loader/stateobjects/pushstate-object-types.html
- ForwardingHeaders/runtime/RegExp.h: Added.
- ForwardingHeaders/runtime/RegExpObject.h: Added.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
- 5:32 PM Changeset in webkit [66935] by
-
- 4 edits in trunk/WebKit/mac
Fix clang++ build.
Reviewed by Oliver Hunt.
- Misc/WebLocalizableStrings.h:
Fix a struct/tag mismatch.
- WebView/WebDeviceOrientationProviderMock.mm:
(-[WebDeviceOrientationProviderMock init]):
Remove stray semicolon.
- WebView/WebViewData.h:
Remove unused class forward declaration.
- 4:56 PM Changeset in webkit [66934] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Fix OpenGL error reporting in WebGL layout test utilities
https://bugs.webkit.org/show_bug.cgi?id=45336
- fast/canvas/webgl/resources/webgl-test.js: (getGLErrorAsString):
- 4:51 PM Changeset in webkit [66933] by
-
- 4 edits in trunk/WebKit2
Fix clang++ build.
Reviewed by Sam Weinig.
- UIProcess/API/C/WKAPICast.h:
Move all functions into the WebKit namespace.
- UIProcess/API/C/cf/WKStringCF.cpp:
Add using namespace WebKit.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
Move all functions into the WebKit namespace.
- 4:43 PM Changeset in webkit [66932] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium linux test expectations.
- platform/chromium/drt_expectations.txt: Adding back a test removed in r66924 that is still failing.
- 4:40 PM WebKit Team edited by
- (diff)
- 4:37 PM Changeset in webkit [66931] by
-
- 3 edits in trunk/WebCore
2010-09-07 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
Fix compile errors in DrawingBuffer if USE(ACCELERATED_COMPOSITING) is not set
https://bugs.webkit.org/show_bug.cgi?id=45324
Adds appropriate #if guards around code that has to deal directly with the compositor.
DrawingBuffer can still be used without the compositor as an off-screen rendering
region.
To test, compile without USE(ACCELERATED_COMPOSITING).
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h:
- 4:34 PM Changeset in webkit [66930] by
-
- 3 edits2 adds in trunk
2010-09-07 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Testing the DOMHTMLSelectElement interface for selecting an
index in a <select> and triggering a "change" event. This also
tests for allowing multiple selections.
- platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
- platform/mac/fast/objc/dom-html-select-activate.html: Added.
2010-09-07 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.
- DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
- 4:33 PM Changeset in webkit [66929] by
-
- 7 edits in trunk/WebCore
2010-09-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Test: LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html
This provides a way for a WebKit client using the Obj-C DOM bindings to
trigger the "change" on a listbox select (<select multiple> or <select>
with size > 1). This is because when a select is rendered as a listbox
"change" events are triggered by mouse down events.
This adds -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]
to allow for handling multiple selections if the select element is a
multi-select.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
- bindings/objc/DOMPrivate.h: unified the Category name. Was "FormsAutocomplete" now all are "FormAutocomplete".
- dom/SelectElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndexByUser): listboxs need to be treated specially to fire their "change" event.
- html/HTMLSelectElement.h:
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::setSelectedIndexByUser):
- 4:28 PM Changeset in webkit [66928] by
-
- 2 edits in trunk/WebCore
2010-09-07 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Minor WKCACFLayerRenderer cleanup
https://bugs.webkit.org/show_bug.cgi?id=45201
Call initD3DGeometry() from createRenderer, rather than duplicating the code.
No behavior changes.
- platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::createRenderer):
- 4:27 PM Changeset in webkit [66927] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 James Robinson <jamesr@chromium.org>
Rubber-stamped by Dimitri Glazkov.
Move myself from the committer to the reviewer list.
- Scripts/webkitpy/common/config/committers.py:
- 4:26 PM Changeset in webkit [66926] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] removing tests that pass after switch the bot back to hardy
https://bugs.webkit.org/show_bug.cgi?id=45327
- platform/chromium/drt_expectations.txt:
- 4:19 PM Changeset in webkit [66925] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
[Chromium/DRT] Remove now-passing tests.
- platform/chromium/drt_expectations.txt: A few more tests now pass, yay!
- 4:10 PM Changeset in webkit [66924] by
-
- 4 edits in trunk/LayoutTests
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
turn off php output buffering in multipart tests
https://bugs.webkit.org/show_bug.cgi?id=45232
This was causing hanging multipart resources to not output anything.
On Lucid, the output buffer is enabled by default, but it's not enabled on Hardy.
http://www.php.net/manual/en/function.ob-end-flush.php
- http/tests/multipart/resources/multipart-wait-before-boundary.php:
- http/tests/multipart/resources/multipart.php:
- platform/chromium/drt_expectations.txt:
- 4:05 PM Changeset in webkit [66923] by
-
- 2 edits in trunk/WebCore
2010-09-07 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Reset the owner of PlatformLayer's once the GraphicsLayer they are associated with
gets destroyed.
https://bugs.webkit.org/show_bug.cgi?id=45329
Test: Fixes UI test failures downstream for all the Media tests when run on the buildbots (machines without GPUs).
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
- 4:03 PM Changeset in webkit [66922] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Add fast/canvas/webgl/gl-teximage.html (failing on chromium mac bot) to chromium/test_expectations.
- platform/chromium/test_expectations.txt:
- 3:46 PM Changeset in webkit [66921] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial expectations update.
[Chromium/DRT] Remove expectation of crash for
fast/js/date-preserve-milliseconds.html. It's now passing.
- platform/chromium/drt_expectations.txt: Remove now-passing test.
- 3:43 PM Changeset in webkit [66920] by
-
- 21 edits in branches/audio/WebCore
audio branch: more code cleanup in preparation for landing in trunk
- 3:43 PM Changeset in webkit [66919] by
-
- 28 edits in branches/audio/WebCore
audio branch: massive munge to use adoptPtr() instead of naked operator new
- 3:42 PM Changeset in webkit [66918] by
-
- 3 edits in trunk/BugsSite
2010-09-07 Adam Barth <abarth@webkit.org>
Minor tweaks to the reviewtool UI.
Rename Cancel to Discard to make it more clear what the button does.
Also, move the style declaration for the focus ring later in the sheet
so it works.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 3:37 PM Changeset in webkit [66917] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial test move.
[Chromium/DRT] Correct a mistake made eons ago (probably by me)
and make the test expectations agnostic to the flavor of Windows.
- platform/chromium-win-xp/fast/multicol/client-rects-expected.checksum: Removed.
- platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Removed.
- platform/chromium-win/fast/multicol/client-rects-expected.checksum: Updated.
- platform/chromium-win/fast/multicol/client-rects-expected.png: Updated.
- 3:35 PM Changeset in webkit [66916] by
-
- 10 edits in trunk
<rdar://problem/8381749> -Wcast-align warning emitted when building with clang
Reviewed by Darin Adler.
Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
- Configurations/Base.xcconfig:
JavaScriptGlue:
Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
- Configurations/Base.xcconfig:
WebCore:
Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
- Configurations/Base.xcconfig:
WebKit/mac:
Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
- Configurations/Base.xcconfig:
WebKit2:
Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
- Configurations/Base.xcconfig:
- 3:21 PM Changeset in webkit [66915] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Remove passing tests from chromium/test_expectations.
- platform/chromium/test_expectations.txt:
- 3:21 PM Changeset in webkit [66914] by
-
- 5 edits in trunk
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133
This is so it's possible for me to fix
http://code.google.com/p/chromium/issues/detail?id=21386 .
- public/WebKit.h: Add areLayoutTestImagesOpaque()
- src/WebKit.cpp: (WebKit::areLayoutTestImagesOpaque):
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
- 3:08 PM Changeset in webkit [66913] by
-
- 1 copy in branches/chromium/517
Create branch for Chromium 517.
- 3:07 PM Changeset in webkit [66912] by
-
- 1 add in branches/chromium
Create a directory for Chromium branches
- 2:57 PM Changeset in webkit [66911] by
-
- 3 edits2 adds in trunk
2010-09-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Remove redundant bounds check in originalText(). Add bounds check
to previousCharacter(). No need of start() > 0 check since m_start
is unsigned and we already do start() null check inside function.
https://bugs.webkit.org/show_bug.cgi?id=45303
Test: fast/text/one-letter-transform-crash.html
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter):
2010-09-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that we dont hit assert i < m_length when trying to read
previousCharacter for text fragments.
https://bugs.webkit.org/show_bug.cgi?id=45303
- fast/text/one-letter-transform-crash-expected.txt: Added.
- fast/text/one-letter-transform-crash.html: Added.
- 2:53 PM Changeset in webkit [66910] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Remove passing tests from chromium/test_expectations.
- platform/chromium/test_expectations.txt:
- 2:50 PM Changeset in webkit [66909] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Remove flakiness expectation for tests, fixed by r66861.
https://bugs.webkit.org/show_bug.cgi?id=45311
- platform/chromium/drt_expectations.txt: Removed tests.
- 2:24 PM Changeset in webkit [66908] by
-
- 5 edits1 add in trunk
2010-09-07 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316
Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
2010-09-07 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316
Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.
- fast/canvas/webgl/gl-teximage-expected.txt:
- fast/canvas/webgl/gl-teximage.html:
- fast/canvas/webgl/resources/blue-1x1.jpg: Added.
- 2:07 PM Changeset in webkit [66907] by
-
- 2 edits in trunk/WebKit2
Another windows fix.
- UIProcess/win/WebView.cpp:
- 2:00 PM Changeset in webkit [66906] by
-
- 6 edits in trunk/WebKitTools
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Implement --check-layout-test-sys-deps
https://bugs.webkit.org/show_bug.cgi?id=45283
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
- DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
- DumpRenderTree/chromium/TestShellGtk.cpp: (checkLayoutTestSystemDependencies): Add an empty implementation.
- DumpRenderTree/chromium/TestShellMac.mm: (checkLayoutTestSystemDependencies): Add an empty implementation.
- DumpRenderTree/chromium/TestShellWin.cpp: (checkLayoutTestSystemDependencies): Port similar function of test_shell.
- 1:59 PM Changeset in webkit [66905] by
-
- 2 edits in trunk/WebKit2
Try and fix windows.
- UIProcess/WebEditCommandProxy.h:
- 1:18 PM Changeset in webkit [66904] by
-
- 2 edits in trunk/WebCore
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Add rendering/ColumnInfo.h to the sources list.
- GNUmakefile.am:
- 1:07 PM BuildBot edited by
- (diff)
- 12:59 PM Changeset in webkit [66903] by
-
- 5 edits1 add in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=45317, encapsulate multi-column rectangle information.
Reviewed by Beth Dakin.
- WebCore.xcodeproj/project.pbxproj:
- rendering/ColumnInfo.h: Added.
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::desiredColumnWidth):
(WebCore::ColumnInfo::setDesiredColumnWidth):
(WebCore::ColumnInfo::desiredColumnCount):
(WebCore::ColumnInfo::setDesiredColumnCount):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnRectAt):
(WebCore::ColumnInfo::clearColumns):
(WebCore::ColumnInfo::addColumnRect):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::desiredColumnCount):
(WebCore::RenderBlock::columnInfo):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderBlock.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
- 12:56 PM Changeset in webkit [66902] by
-
- 3 edits in trunk/WebKit/win
2010-09-07 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Clean up a potential resource leak.
https://bugs.webkit.org/show_bug.cgi?id=45198
Several bitmap device context were being created and used,
and destroyed without returning the context to its original
state. This showed up as bitmap leaks in BoundsChecker.
- FullscreenVideoController.cpp:
- WebView.cpp: (WebView::scrollBackingStore): (WebView::paint):
- 12:44 PM BuildBot edited by
- (diff)
- 12:41 PM Changeset in webkit [66901] by
-
- 2 edits in trunk/WebKit2
Fix incorrect parameter name.
Reviewed by Darin Adler.
- UIProcess/API/mac/PageClientImpl.mm:
- 12:40 PM Changeset in webkit [66900] by
-
- 4 edits2 adds in trunk
<rdar://problem/7794761> Floats inside of multicol fail to hit test
https://bugs.webkit.org/show_bug.cgi?id=44730
Reviewed by Dave Hyatt.
WebCore:
Test: fast/multicol/hit-test-float.html
Factored float hit-testing out of nodeAtPoint so that hitTestColumns could
call it with column-adjusted coordinates.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
- rendering/RenderBlock.h:
LayoutTests:
- fast/multicol/hit-test-float-expected.txt: Added.
- fast/multicol/hit-test-float.html: Added.
- 12:31 PM Changeset in webkit [66899] by
-
- 7 edits in trunk
2010-09-07 François Sausset <François Sausset>
Reviewed by Beth Dakin.
Update to test the display attribute on the math element.
https://bugs.webkit.org/show_bug.cgi?id=44206
- mathml/presentation/attributes.xhtml:
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
2010-09-07 François Sausset <François Sausset>
Reviewed by Beth Dakin.
<math> element should be centered when display attribute set to block.
https://bugs.webkit.org/show_bug.cgi?id=44206
Test: mathml/presentation/attributes.xhtml
- css/mathml.css: (math[display="block"]):
- 12:21 PM Changeset in webkit [66898] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 Jessie Berlin <jberlin@apple.com>
Unreviewed. Mac build fix.
- MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
- 12:18 PM Changeset in webkit [66897] by
-
- 18 edits4 adds in trunk/WebKit2
Add support for Undo/Redo
<rdar://problem/7660519>
https://bugs.webkit.org/show_bug.cgi?id=42781
Reviewed by Darin Adler.
Adds platform independent parts of Undo/Redo support and the mac
platform support.
To work around the common assumption made by platforms, that a redo
item will be added synchronously while an undo is in progress, we
ignore the calls from WebCore to add redo items, and instead add add
them after telling WebCore to unapply the EditCommand. We similarly
need to ignore undos, that take place during a redo, and force the
addition ourselves.
- Shared/CoreIPCSupport/WebPageMessageKinds.h:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
Add new messages.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(-[WebEditCommandObjC initWithWebEditCommandProxy:WebKit::]):
(-[WebEditCommandObjC WebKit::]):
(-[WebEditorUndoTargetObjC undoEditing:]):
(-[WebEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::nameForEditAction):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::registerEditCommand):
(QWKPagePrivate::clearAllEditCommands):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
- UIProcess/win/WebView.h:
Add platform specific hooks for undo/redo.
- UIProcess/WebEditCommandProxy.cpp: Added.
(WebKit::WebEditCommandProxy::WebEditCommandProxy):
(WebKit::WebEditCommandProxy::~WebEditCommandProxy):
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):
- UIProcess/WebEditCommandProxy.h: Added.
(WebKit::WebEditCommandProxy::create):
(WebKit::WebEditCommandProxy::commandID):
(WebKit::WebEditCommandProxy::editAction):
(WebKit::WebEditCommandProxy::invalidate):
A proxy for the WebEditCommands in the WebProcess. These are owned
by the platform back/forward list, with a weak reference back to the
WebPageProxy (which holds a weakset of live WebEditCommandProxys).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::registerEditCommandForUndo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::registerEditCommandForRedo):
(WebKit::WebPageProxy::addEditCommand):
(WebKit::WebPageProxy::removeEditCommand):
(WebKit::WebPageProxy::processDidExit):
- UIProcess/WebPageProxy.h:
Forward messages.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::registerCommandForRedo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
Send undo/redo registration and clearing to the UIProcess.
- WebProcess/WebPage/WebEditCommand.cpp: Added.
(WebKit::generateCommandID):
(WebKit::WebEditCommand::WebEditCommand):
- WebProcess/WebPage/WebEditCommand.h: Added.
(WebKit::WebEditCommand::create):
(WebKit::WebEditCommand::command):
(WebKit::WebEditCommand::commandID):
Wrapper for WebCore::EditCommand, with an added unique ID.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::webEditCommand):
(WebKit::WebPage::addWebEditCommand):
(WebKit::WebPage::removeWebEditCommand):
(WebKit::WebPage::unapplyEditCommand):
(WebKit::WebPage::reapplyEditCommand):
(WebKit::WebPage::didRemoveEditCommand):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isInRedo):
Forward messages.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 11:46 AM Changeset in webkit [66896] by
-
- 17 edits in trunk/LayoutTests
2010-09-07 Simon Fraser <Simon Fraser>
Reviewed by Chris Marrin.
Avoid use of CA plugin in compositing tests so that they work on Windows
https://bugs.webkit.org/show_bug.cgi?id=45312
Convert tests to use <video> rather than a plugin, so that they have similar
compositing behavior on Windows.
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned.html:
- compositing/geometry/limit-layer-bounds-overflow-repaint.html:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root.html:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition.html:
- compositing/geometry/limit-layer-bounds-positioned.html:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow.html:
- compositing/geometry/limit-layer-bounds-transformed.html:
- platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
- 11:29 AM Changeset in webkit [66895] by
-
- 3 edits in trunk/WebCore
2010-09-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Media elements should derive from ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=45306
<rdar://problem/7929062>
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize ActiveDOMObject (WebCore::HTMLMediaElement::stop): Call suspend, we want to do the same thing in both cases. (WebCore::HTMLMediaElement::suspend): Rename from documentWillBecomeInactive. (WebCore::HTMLMediaElement::resume): Rename from documentDidBecomeActive. (WebCore::HTMLMediaElement::hasPendingActivity): Return true if the event queue is not empty so the element can't be collected before they are sent.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::canSuspend):
- 11:14 AM ImprovingLifeOnWindows edited by
- Removed the item about copying to %TMP%, since we don't do that anymore. (diff)
- 11:09 AM Changeset in webkit [66894] by
-
- 8 edits in trunk
2010-09-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
https://bugs.webkit.org/show_bug.cgi?id=45217
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
WebKitTools:
Make WebKitTestRunner work with this change.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Make sure the ScriptWorld here is the normal world, since that is no longer being done in WebFrameLoaderClient.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 11:02 AM Changeset in webkit [66893] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Add fast/text/atsui-spacing-features.html to test_expectations (failing on LINUX).
- platform/chromium/test_expectations.txt:
- 10:38 AM Changeset in webkit [66892] by
-
- 7 edits in trunk
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112
Made
- platform/chromium/GeolocationServiceChromium.cpp:
- platform/chromium/GeolocationServiceChromium.h:
2010-09-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112
Made
- public/WebGeolocationService.h:
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient): (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
- src/WebGeolocationServiceMock.cpp:
- 10:22 AM Changeset in webkit [66891] by
-
- 1 edit24 adds in trunk/LayoutTests
2010-09-07 Zhenyao Mo <zmo@google.com>
Unreviewed.
Rebaseline WIN LINUX for a few svg/dynamic-updates tests.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
- 10:13 AM Changeset in webkit [66890] by
-
- 2 edits in trunk/WebCore
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Small build fix. Remove libWebCoreJS from CLEAN_FILES, as it
is no longer built.
- GNUmakefile.am: Remove reference to libWebCoreJS.
- 10:10 AM Changeset in webkit [66889] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298
No new tests as this fixes a test failure.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
- 9:44 AM Changeset in webkit [66888] by
-
- 2 edits in trunk/WebCore
2010-09-07 Kristian Monsen <kristianm@google.com>
Reviewed by Steve Block.
Compile fix for Android.
https://bugs.webkit.org/show_bug.cgi?id=45292
Explicitly add needed header for
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK as they do not get
included through other headers on Android.
No new tests, just a compile fix.
- bindings/scripts/CodeGeneratorV8.pm:
- 9:40 AM Changeset in webkit [66887] by
-
- 23 edits in trunk
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302
No new tests as this is just a build change.
- platform/graphics/gstreamer/DataSourceGStreamer.cpp: Guard with #if ENABLE(VIDEO)
- platform/graphics/gstreamer/DataSourceGStreamer.h: Ditto.
- platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Ditto.
- platform/graphics/gstreamer/GOwnPtrGStreamer.h: Ditto.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: Ditto.
- platform/graphics/gstreamer/GStreamerGWorld.h: Ditto.
- platform/graphics/gstreamer/ImageGStreamer.h: Ditto.
- platform/graphics/gstreamer/ImageGStreamerCG.mm: Ditto.
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
- platform/graphics/gstreamer/PlatformVideoWindow.h: Ditto.
- platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Ditto.
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Ditto.
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Ditto.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Ditto.
- platform/gtk/GeolocationServiceGtk.cpp: Guard with ENABLE(GEOLOCATION)
- platform/gtk/GeolocationServiceGtk.h: Ditto.
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302
- webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members.
- 9:02 AM Changeset in webkit [66886] by
-
- 7 edits in trunk
2010-09-07 Jonathan Dixon <joth@chromium.org>
Reviewed by Jeremy Orlow.
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112
Add missing virtual destructor to the abstract base class.
- platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
- platform/chromium/GeolocationServiceChromium.h:
2010-09-07 Jonathan Dixon <joth@chromium.org>
Reviewed by Jeremy Orlow.
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112
Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably
- public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
- 8:55 AM Changeset in webkit [66885] by
-
- 2 edits in trunk/WebCore
2010-09-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298
No new tests as this fixes a test failure.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
- 8:55 AM Changeset in webkit [66884] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Disable a timing out speech input test for generated clicks.
https://bugs.webkit.org/show_bug.cgi?id=45297
- platform/chromium/test_expectations.txt:
- 8:15 AM Changeset in webkit [66883] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
REGRESSION(66741): Undefined pthread macros
https://bugs.webkit.org/show_bug.cgi?id=45246
PTHREAD_MUTEX_NORMAL and PTHREAD_MUTEX_DEFAULT (introduced in r60487) are not defined on Linux,
but used in a statement. Add an additional check to test this.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger):
- 7:53 AM Changeset in webkit [66882] by
-
- 3 edits in trunk
2010-09-07 Adam Langley <agl@chromium.org>
Reviewed by Tony Chang.
[chromium] Fix complex text word spacing on Linux.
I broke complex text word spacing with r66689. I misnamed a
variable in the original code |glyphIndex| when it was
actually indexing code points. That meant that I compared it
against the wrong limit when working around Harfbuzz issues
and neatly disabled word spacing.
Test: fast/text/atsui-spacing-features.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setGlyphXPositions):
- 7:07 AM Changeset in webkit [66881] by
-
- 1 edit30 adds in trunk/LayoutTests
2010-09-07 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=42244
Adding layout tests for fePointLight dynamic changes.
feSpotLight svgAttributeChanged covered the pointLight case as well so we don't need new C++ code.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr.html: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-x-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-y-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-z-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-x-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-y-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-z-prop.js: Added. (executeTest):
- 6:44 AM Changeset in webkit [66880] by
-
- 3 edits in trunk/LayoutTests
2010-09-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: disable debugger tests on qt
https://bugs.webkit.org/show_bug.cgi?id=45290
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 6:27 AM Changeset in webkit [66879] by
-
- 4 edits1 delete in trunk
2010-09-07 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288
- fast/speech/input-text-speechbutton.html: Added RTL test case and merged JS code.
- fast/speech/script-tests/input-text-speechbutton.js: Removed.
2010-09-07 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
- 5:47 AM Changeset in webkit [66878] by
-
- 3 edits2 adds in trunk
2010-09-07 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181
- fast/speech/speech-button-ignore-generated-events-expected.txt: Added.
- fast/speech/speech-button-ignore-generated-events.html: Added.
2010-09-07 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181
Test: fast/speech/speech-button-ignore-generated-events.html
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
- 5:28 AM Changeset in webkit [66877] by
-
- 3 edits5 adds in trunk
2010-09-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262
- inspector/debugger-pause-on-breakpoint-expected.txt: Added.
- inspector/debugger-pause-on-breakpoint.html: Added.
- inspector/debugger-pause-on-exception-expected.txt: Added.
- inspector/debugger-pause-on-exception.html: Added.
- platform/chromium/inspector/debugger-pause-on-exception-expected.txt: Added.
2010-09-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262
- src/js/Tests.js:
- 5:11 AM Changeset in webkit [66876] by
-
- 5 edits15 adds in trunk/LayoutTests
2010-09-07 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Provide DeviceOrientation LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=39590
Adds several new DeviceOrientation tests. Also fixes some style in existing tests.
- fast/dom/DeviceOrientation/add-listener-from-callback.html: Added.
- fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: Added.
- fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt: Added.
- fast/dom/DeviceOrientation/multiple-frames.html: Added.
- fast/dom/DeviceOrientation/script-tests/multiple-frames.js: Added.
- fast/dom/DeviceOrientation/multiple-frames-expected.txt: Added.
- fast/dom/DeviceOrientation/no-synchronous-events.html: Added.
- fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js: Added.
- fast/dom/DeviceOrientation/no-synchronous-events-expected.txt: Added.
- fast/dom/DeviceOrientation/null-values.html: Added.
- fast/dom/DeviceOrientation/script-tests/null-values.js: Added.
- fast/dom/DeviceOrientation/null-values-expected.txt: Added.
- fast/dom/DeviceOrientation/updates.html: Added.
- fast/dom/DeviceOrientation/script-tests/updates.js: Added.
- fast/dom/DeviceOrientation/updates-expected.txt: Added.
- fast/dom/DeviceOrientation/script-tests/basic-operation.js:
- fast/dom/DeviceOrientation/script-tests/create-event.js:
- fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:
- fast/dom/DeviceOrientation/script-tests/window-property.js:
- 4:14 AM Changeset in webkit [66875] by
-
- 2 edits in trunk/WebCore
2010-09-07 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because qt_sender is never set
https://bugs.webkit.org/show_bug.cgi?id=44697
When the signal handler is a JS function, qt_sender is stuffed into a temporary
object that's pushed onto the function's scope before the function is invoked, and
popped again afterwards.
We were pushing this new scope object _after_ calling JSFunction::getCallData(),
and relying on JSC::call() to use the fresh scope chain from the function object.
However, this is no longer the case; JSC::call() uses the scope chain passed in
the CallData argument. Hence, we need to set up the scope before the function's
CallData is queried.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
- 3:22 AM Changeset in webkit [66874] by
-
- 1 edit78 adds in trunk/LayoutTests
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
- platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
- platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
- platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
- platform/qt/fast/forms/placeholder-stripped-expected.checksum: Added.
- platform/qt/fast/forms/placeholder-stripped-expected.png: Added.
- platform/qt/fast/forms/placeholder-stripped-expected.txt: Added.
- platform/qt/fast/gradients/radial-centered-expected.checksum: Added.
- platform/qt/fast/gradients/radial-centered-expected.png: Added.
- platform/qt/fast/gradients/radial-centered-expected.txt: Added.
- platform/qt/fast/multicol/float-paginate-expected.checksum: Added.
- platform/qt/fast/multicol/float-paginate-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-expected.txt: Added.
- platform/qt/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/qt/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/qt/fast/multicol/paginate-block-replaced-expected.txt: Added.
- platform/qt/fast/repaint/multicol-repaint-expected.checksum: Added.
- platform/qt/fast/repaint/multicol-repaint-expected.png: Added.
- platform/qt/fast/repaint/multicol-repaint-expected.txt: Added.
- platform/qt/fast/repaint/view-background-from-body-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.checksum.
- platform/qt/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-property-synchronization-crash-expected.png.
- platform/qt/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-1-expected.txt.
- platform/qt/fast/repaint/view-background-from-body-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.checksum.
- platform/qt/fast/repaint/view-background-from-body-2-expected.png: Added.
- platform/qt/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-2-expected.txt.
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/qt/svg/css/composite-shadow-text-expected.checksum: Added.
- platform/qt/svg/css/composite-shadow-text-expected.png: Added.
- platform/qt/svg/css/composite-shadow-text-expected.txt: Added.
- platform/qt/svg/custom/bug45331-expected.checksum: Added.
- platform/qt/svg/custom/bug45331-expected.png: Added.
- platform/qt/svg/custom/bug45331-expected.txt: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
- platform/qt/svg/custom/marker-empty-path-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.checksum.
- platform/qt/svg/custom/marker-empty-path-expected.png: Added.
- platform/qt/svg/custom/marker-empty-path-expected.txt: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
- platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum.
- platform/qt/svg/custom/non-scaling-stroke-markers-expected.png: Added.
- platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
- platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
- platform/qt/svg/custom/pattern-incorrect-tiling-expected.png: Added.
- platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
- platform/qt/svg/custom/pattern-no-pixelation-expected.checksum: Added.
- platform/qt/svg/custom/pattern-no-pixelation-expected.png: Added.
- platform/qt/svg/custom/pattern-no-pixelation-expected.txt: Added.
- platform/qt/svg/custom/use-font-face-crash-expected.checksum: Added.
- platform/qt/svg/custom/use-font-face-crash-expected.png: Added.
- platform/qt/svg/custom/use-font-face-crash-expected.txt: Added.
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/qt/transitions/svg-text-shadow-transition-expected.checksum: Added.
- platform/qt/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/qt/transitions/svg-text-shadow-transition-expected.txt: Added.
- 3:12 AM Changeset in webkit [66873] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix.
webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832
- Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the tests are present when building the expectations. This is needed for the unittests.
- 2:53 AM Changeset in webkit [66872] by
-
- 14 edits in trunk/WebKitTools
2010-09-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Adam Barth.
webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832
To use it: webkit-patch skipped-ports some/layout/test.html
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- 2:20 AM Changeset in webkit [66871] by
-
- 2 edits in trunk/LayoutTests
2010-09-07 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Remove a duplicated entry.
- 2:12 AM Changeset in webkit [66870] by
-
- 2 edits in trunk
2010-09-07 Arno Renevier <arno@renevier.net>
Reviewed by Holger Freyther.
gitignore *~ files and gtk *.pot files
https://bugs.webkit.org/show_bug.cgi?id=45129
- .gitignore:
- 1:51 AM Changeset in webkit [66869] by
-
- 2 edits in trunk/WebCore
2010-09-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
Add ENABLE(INSPECTOR) guard in InspectorController::inspectorControllerForNode
https://bugs.webkit.org/show_bug.cgi?id=45272
Build fix.
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForNode):
- 1:50 AM Changeset in webkit [66868] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed. Build fix.
Update test expectations for Chromium.
- platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt: Added.
- platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Added.
- platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt: Added.
- 1:38 AM Changeset in webkit [66867] by
-
- 3 edits in trunk/LayoutTests
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
Fix wrong position calculation of fast/forms/listbox-selection.html
https://bugs.webkit.org/show_bug.cgi?id=45285
- fast/forms/script-tests/listbox-selection.js: (mouseDownOnSelect): Refer window.pageYOffset after sl.focus() call because focus() might scroll the page.
- platform/chromium/test_expectations.txt:
- 1:35 AM Changeset in webkit [66866] by
-
- 4 edits in trunk/LayoutTests
2010-09-07 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update DRT/Chromium expectations, and skip meter-percent-size.html
for platforms without <meter> support.
- platform/chromium/drt_expectations.txt:
- platform/gtk/Skipped:
- platform/win/Skipped:
- 1:28 AM Changeset in webkit [66865] by
-
- 2 edits in trunk/WebCore
2010-09-07 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by Ariya Hidayat.
Fix QtWebKit linker error on Windows CE 6.
https://bugs.webkit.org/show_bug.cgi?id=43442
Doesn't affect any tests.
- WebCore.pro:
- 1:12 AM Changeset in webkit [66864] by
-
- 4 edits2 adds in trunk
2010-09-07 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Adds tests for percent-based attributes on the <meter> element.
- fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
- fast/dom/HTMLMeterElement/meter-percent-size.html: Added.
2010-09-07 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Crash rendering <meter/> with percent padding
https://bugs.webkit.org/show_bug.cgi?id=45081
Avoids a crash caused by RenderMeter checking its own dimensions to
determine whether it needs layout. The crash is avoided by removing
the check and always calling setNeedsLayout(true).
Test: fast/dom/HTMLMeterElement/meter-percent-size.html
- rendering/RenderIndicator.cpp: (WebCore::RenderIndicator::updateFromElement):
- rendering/RenderIndicator.h:
- 12:30 AM Changeset in webkit [66863] by
-
- 2 edits in trunk/WebKitTools
2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Eric Seidel.
[NRWT] Add temp directory to all running drivers.
https://bugs.webkit.org/show_bug.cgi?id=45261
- Scripts/webkitpy/layout_tests/port/webkit.py:
Sep 6, 2010:
- 9:06 PM Changeset in webkit [66862] by
-
- 3 edits2 adds in trunk
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279
In principle, attributeChanged can do anything. If we supported more
DOM mutation events, it could even run JavaScript. That means we need
to be prepared for the attribute map to change when running
attributeChanged. This patch makes this loop resilient to the
attribute map changing by storing the list of changed attributes on the
stack.
Test: fast/parser/changing-attrbutes-crash.html
- dom/Element.cpp: (WebCore::Element::setAttributeMap):
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279
Test what happens when SVG changes the attribute map out from under us.
- fast/parser/changing-attrbutes-crash-expected.txt: Added.
- fast/parser/changing-attrbutes-crash.html: Added.
- 8:13 PM Changeset in webkit [66861] by
-
- 2 edits in trunk/WebKitTools
2010-09-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
[Chromium/DRT] Empty out user stylesheet after each test run.
https://bugs.webkit.org/show_bug.cgi?id=45282
This should significantly cut down on the number of the mysterious flaky tests
whose diffs looked like the page was blown up to a very lage size. This
was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
which set the base body font to 100px.
Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
the same thread failed.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
- 8:05 PM Changeset in webkit [66860] by
-
- 4 edits in trunk
2010-09-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253
- platform/chromium/drt_expectations.txt: Remove slow-utf8-text.pl failure.
2010-09-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
- 7:09 PM UsingGitWithWebKit edited by
- (diff)
- 7:05 PM Changeset in webkit [66859] by
-
- 2 edits in trunk/WebKitTools
2010-09-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Kent Tamura.
print out correct error when a DRT thread dies in NRWT
https://bugs.webkit.org/show_bug.cgi?id=45281
Not sure why, but with the parens, python 2.6.5 on Linux
gives an error that raise takes 5 arguments and 0 were given.
Didn't test other platforms or python versions, but putting it
all on one line fixes it and correctly prints the exception
from the DRT thread.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:31 PM Changeset in webkit [66858] by
-
- 2 edits in trunk/WebKitTools
2010-09-06 Eric Seidel <eric@webkit.org>
Unreviewed, just adding some emails from lists.webkit.org.
Update committers.py to include emails from lists.webkit.org
as found by the validate-committer-lists script.
- Scripts/webkitpy/common/config/committers.py:
- 4:46 PM Changeset in webkit [66857] by
-
- 2 edits in trunk/BugsSite
2010-09-06 Adam Barth <abarth@webkit.org>
Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit
bigger.
- PrettyPatch/PrettyPatch.rb:
- 4:44 PM Changeset in webkit [66856] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- 4:39 PM Changeset in webkit [66855] by
-
- 2 edits in trunk/BugsSite
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Add a quick animation for opening/closing comment boxes
https://bugs.webkit.org/show_bug.cgi?id=45278
The 200ms animation slides in and out the line-by-line comment box.
- code-review.js:
- 4:31 PM Changeset in webkit [66854] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 4:00 PM Changeset in webkit [66853] by
-
- 2 edits in trunk/WebKit/qt
2010-09-06 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45231
Make possible to get the current QNAM when NetwokingContext request it.
- WebCoreSupport/FrameNetworkingContextQt.cpp: (WebCore::FrameNetworkingContextQt::networkAccessManager):
- 3:53 PM Changeset in webkit [66852] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 3:35 PM Changeset in webkit [66851] by
-
- 1 edit1 add in trunk/LayoutTests
2010-09-06 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Update test expectations for Leopard.
- platform/mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
- 2:29 PM Changeset in webkit [66850] by
-
- 10 edits in trunk
2010-09-05 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244
Export JSArray::put
- JavaScriptCore.exp:
2010-09-05 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244
Add a few more test cases to cover the new branches in the
rewritten serialization logic.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
2010-09-05 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244
Rewrite the old tree to tree serialization logic to use
flat storage. Unfortunately this basically required a
complete rewrite.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneBase::CloneBase): (WebCore::CloneBase::shouldTerminate): (WebCore::CloneBase::ticksUntilNextCheck): (WebCore::CloneBase::didTimeOut): (WebCore::CloneBase::throwStackOverflow): (WebCore::CloneBase::throwInterruptedException): (WebCore::CloneBase::fail): (WebCore::CloneSerializer::serialize): (WebCore::CloneSerializer::CloneSerializer): (WebCore::CloneSerializer::isArray): (WebCore::CloneSerializer::startObject): (WebCore::CloneSerializer::startArray): (WebCore::CloneSerializer::endObject): (WebCore::CloneSerializer::getSparseIndex): (WebCore::CloneSerializer::getProperty): (WebCore::CloneSerializer::dumpImmediate): (WebCore::CloneSerializer::dumpString): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneSerializer::write): (WebCore::CloneSerializer::writeLittleEndian): (WebCore::CloneSerializer::writeStringIndex): (WebCore::CloneDeserializer::deserializeString): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::throwValidationError): (WebCore::CloneDeserializer::isValid): (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::read): (WebCore::CloneDeserializer::readStringIndex): (WebCore::CloneDeserializer::readString): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readTag): (WebCore::CloneDeserializer::putProperty): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::SerializedScriptValue::~SerializedScriptValue): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::toString): (WebCore::SerializedScriptValue::deserialize): (WebCore::SerializedScriptValue::nullValue):
- bindings/js/SerializedScriptValue.h:
- dom/MessagePortChannel.cpp: (WebCore::MessagePortChannel::EventData::EventData):
- workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerTask::MessageWorkerTask):
- 2:09 PM Changeset in webkit [66849] by
-
- 3 edits in trunk/BugsSite
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Add a field for overall comments
https://bugs.webkit.org/show_bug.cgi?id=45273
This patch does a couple logically separate things that could be
separated into smaller patches:
1) This patch adds an "overall comments" field where you can enter
overall comments about the patch. These comments appear at the top
of the bugzilla posting. Currently, these aren't redisplayed when
viewing the patch, but I plan to add that in a future patch.
2) This patch renames some of the CSS classes to more consistently
follow the camelCase style that PrettyPatch uses.
3) This patch moves the "prepare comments" button to the left of the
toolbar and renames is to "publish comments". This makes more sense
when you scroll to the bottom of the page and enter in some overall
comments.
4) When you attempt to add a comment to a line that already has a
"frozen" comment, we now unfreeze the comment instead of doing
nothing. The old behavior was kind of frustrating if you didn't
know that you could unfreeze a comment by clicking on it.
- PrettyPatch/PrettyPatch.rb:
- Update CSS.
- code-review.js:
- 2:04 PM Changeset in webkit [66848] by
-
- 5 edits2 adds2 deletes in trunk/WebCore
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] ScrollbarThemeGtk should be enabled for interior frame scrollbars
https://bugs.webkit.org/show_bug.cgi?id=45046
Make interior frame scrollbars "fully-fake," which means they do not rely
at all on GTK+ for painting or behavior, but instead are typical WebCore
scrollbars drawn according to the GTK+ theme. Move ScrollbarGtk to
MainFrameScrollbarGtk and remove all logic in that file dealing with interior
frame scrollbars.
No new tests, as this is already covered by pixel tests for scrollbars,
which were added in r66605.
- GNUmakefile.am: Update sources list.
- platform/ScrollView.h: Change the adjustment members to be smart pointers.
- platform/Scrollbar.cpp: Enable THUMB_POSITION_AFFECTS_BUTTONS for GTK+ as well.
- platform/gtk/MainFrameScrollbarGtk.cpp: Added. (MainFrameScrollbarGtk::create): Create a MainFrameScrollbarGtk instead of ScrollbarGtk. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): (MainFrameScrollbarGtk::~MainFrameScrollbarGtk): (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::detachAdjustment): (MainFrameScrollbarGtk::updateThumbPosition): (MainFrameScrollbarGtk::updateThumbProportion): (MainFrameScrollbarGtk::gtkValueChanged): (MainFrameScrollbarGtk::paint):
- platform/gtk/MainFrameScrollbarGtk.h: Added.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): Remove unnecessary initialization because of smart pointer change. (WebCore::ScrollView::createScrollbar): Instead of creating ScrollbarGtk for interior frame scrollbars, create a normal WebCore scrollbar. (WebCore::ScrollView::setGtkAdjustments): Added an extra assert which ensures that this method is never called with a non-null adjustment on an interior frame scrollbar. (WebCore::ScrollView::platformAddChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::platformRemoveChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::visibleContentRect): Use a more accurate guard for detecting transitionary states when accessing parent widgets. Explcitly guard against interior frame ScrollView's trying to determine size based on parent widgets. (WebCore::ScrollView::setScrollbarModes): This method was out of sync with the one it copy-and-pasted from. Update it and change the logic to do the right thing for interior frame scrollbars.
- platform/gtk/ScrollbarGtk.cpp: Removed.
- platform/gtk/ScrollbarGtk.h: Removed.
- 2:00 PM Changeset in webkit [66847] by
-
- 6 edits4 adds in trunk
2010-09-06 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Make SVG PendingResources use RefPtr
https://bugs.webkit.org/show_bug.cgi?id=43587
Convert SVGDocumentExtensions::m_pendingResources to use a RefPtr for
pending elements instead of a raw pointer so that pending elements can't
be freed prematurely.
Test: svg/custom/use-invalid-pattern.svg
- rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):
2010-09-06 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Test that an invalid pending resource pattern doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=43587
- platform/mac-snowleopard/svg: Added.
- platform/mac-snowleopard/svg/custom: Added.
- platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt: Added.
- svg/custom/use-invalid-pattern.svg: Added.
- 1:29 PM Changeset in webkit [66846] by
-
- 9 edits in trunk/JavaScriptCore
2010-09-06 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
Support JSVALUE32_64 on MIPS
https://bugs.webkit.org/show_bug.cgi?id=43999
Add missing functions to support JSVALUE32_64 on MIPS.
Remove JSVALUE32 as the default for MIPS.
- assembler/MIPSAssembler.h: (JSC::MIPSAssembler::divd): (JSC::MIPSAssembler::mthc1): (JSC::MIPSAssembler::cvtwd):
- assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::neg32): (JSC::MacroAssemblerMIPS::branchOr32): (JSC::MacroAssemblerMIPS::set8): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::divDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32): (JSC::MacroAssemblerMIPS::zeroDouble):
- jit/JIT.h:
- jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- jit/JITStubs.h:
- wtf/Platform.h:
- 12:49 PM Changeset in webkit [66845] by
-
- 5 edits in trunk/WebCore
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] ScrollbarThemeGtk should support secondary steppers
https://bugs.webkit.org/show_bug.cgi?id=44791
Add support to ScrollbarThemeGtk for drawing alternate steppers. Adjust
the algorithms for calculating forward and back button rects, if they
are active in the theme. Expose this information via GtkScrollbarMetrics.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateThemeProperties): Access the secondary stepper properties of GtkScrollbarMetrics when updating the style cache. (WebCore::ScrollbarThemeGtk::backButtonRect): Account for alternate steppers. (WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto. (WebCore::ScrollbarThemeGtk::trackRect): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
- platform/gtk/ScrollbarThemeGtk.h:
- platform/gtk/gtk2drawing.c: Expose whether or not the style uses alternate steppers via GtkScrollbarMetrics.
- platform/gtk/gtkdrawing.h: Added fields to GtkScrollbarMetrics.
- 12:38 PM Changeset in webkit [66844] by
-
- 2 edits in trunk/JavaScriptCore
Fix compile failure in r66843
Revert to original patch in bugzilla. Leave bug open for
discussion on potential removal of double utf8 conversion.
- 12:11 PM Changeset in webkit [66843] by
-
- 4 edits in trunk
2010-09-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] utf8 encoding of console() messages
Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.
- wtf/text/WTFString.cpp: (WTF::String::format):
2010-09-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] utf8 encoding of console() messages
Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.
- platform/qt/Skipped:
- 11:52 AM Changeset in webkit [66842] by
-
- 1 edit1 add in trunk/LayoutTests
2010-09-06 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Update test expectations for Chromium Mac.
- platform/chromium-mac/svg/custom/use-invalid-style-expected.txt: Added.
- 11:32 AM Changeset in webkit [66841] by
-
- 9 edits2 adds in trunk
2010-09-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119
- fast/dom/Document/readystate-expected.txt: Added.
- fast/dom/Document/readystate.html: Added. Reads readyState inline script, external script, deferred script, DOMContentLoaded, onload, and dynamic post-onload script.
2010-09-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119
The legacy behavior was "loading" -> "loaded" -> "complete". The new
HTML5 behavior is "loading" -> "interactive" -> "complete". There is
some potential for this to cause compat problems if for instance a
page expects readyState to be "loaded" during the DOMContentLoaded event.
Test: fast/dom/Document/readystate.html
- dom/Document.cpp: (WebCore::Document::Document): Initial value is Complete because according to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-readystate, when a Document is created the initial value is "complete" unless it has a parser associated with it, in which case it is "loading". So the ctor starts it Complete, and when the parser is created it is flipped to Loading. (WebCore::Document::readyState): (WebCore::Document::setReadyState): (WebCore::Document::implicitOpen): (WebCore::Document::finishedParsing): Ensure that XML and HTML parser have transition to Stopping state.
- dom/Document.h:
- dom/DocumentParser.cpp: (WebCore::DocumentParser::prepareToStopParsing): Previously this was being called when parsing had stopped. It is better to ensure it is only called while parsing.
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::end): Transition to stopping before calling document finishedParsiong().
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): Set state to interactive before running deferred scripts. This method is also called when parsing fragments, so we need to ensure it isn't done in that case. (WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Added. Break out this part s that notifyFinished doesn't go through the additional steps of pumping tokenizer, setting the state, etc. (WebCore::HTMLDocumentParser::notifyFinished): Now that prepareToStopParsing is split up, we must protect. It also makes sense to add a couple of ASSERTs.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): It looks like an aborted load should never transition to "complete" according the HTML5. I've left the legacy behavior for now though. (WebCore::FrameLoader::checkCompleted): The FrameLoader now sets the state on the Document instead of the Document polling the FrameLoader.
- 10:46 AM Changeset in webkit [66840] by
-
- 7 edits in trunk/WebCore
2010-09-06 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Inline hot methods for V8 to WebCore and back conversions
https://bugs.webkit.org/show_bug.cgi?id=45270
Inline fast paths of hot functions performing conversions from V8 wrappers
to WebCore native objects and back.
That slightly increases the size of binary (within 0.1% for both Ubuntu
and Windows, but those builds are slightly different from official ones),
but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getWrapperSlow):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getWrapper):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
- 10:30 AM Changeset in webkit [66839] by
-
- 2 edits1 add in trunk/WebKit/efl
2010-09-06 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] REGRESSION(66794) Need to fix build break.
https://bugs.webkit.org/show_bug.cgi?id=45241
Add dummy class(FrameNetworkingContextEfl) like GTK+ port and implement
as EFL style.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::createNetworkingContext):
- WebCoreSupport/FrameNetworkingContextEfl.h: Added. (WebCore::FrameNetworkingContextEfl::create): (WebCore::FrameNetworkingContextEfl::coreFrame): (WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
- 10:19 AM Changeset in webkit [66838] by
-
- 2 edits in trunk/BugsSite
2010-09-06 Adam Barth <abarth@webkit.org>
[reviewtool] Tweak the ok button to cancel the comment if the comment
is empty. Previously we would get into a bad state where a line had a
comment but there was no longer any way to access it.
- code-review.js:
- 10:09 AM Changeset in webkit [66837] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-06 Jonathan Dixon <joth@chromium.org>
Reviewed by Jeremy Orlow.
Add new interface and empty impl. as precursor to bug 45112
https://bugs.webkit.org/show_bug.cgi?id=45257
- public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
- 9:51 AM Changeset in webkit [66836] by
-
- 3 edits2 adds in trunk
2010-09-06 Shane Stephens <shanestephens@google.com>
Reviewed by Dimitri Glazkov.
[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750
Added test case to demonstrate crash bug.
- svg/dom/symbol-embeddedAnimation-expected.txt: Added.
- svg/dom/symbol-embeddedAnimation.svg: Added.
2010-09-06 Shane Stephens <shanestephens@google.com>
Reviewed by Dimitri Glazkov.
[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750
Fixes crash by checking for null transforms and skipping update step
when appropriate.
Test: svg/dom/symbol-embeddedAnimation.svg
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- 9:42 AM Changeset in webkit [66835] by
-
- 2 edits in trunk/WebKit/qt
2010-09-06 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
Web Inspector: Tests crash on Qt bots revealed by r66720
https://bugs.webkit.org/show_bug.cgi?id=45256
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): m_frontendClient must be initialized by constructor
- 9:14 AM Changeset in webkit [66834] by
-
- 2 edits in trunk/WebKitTools
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Small code cleanup in DumpRenderTreeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=45213
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't have to surround the invocation with #ifdefs. (useLongRunningServerMode): Added. (runTestingServerLoop): Added. (initializeGlobalsFromCommandLineOptions): Added. (runTest): Removed ifdefs. (main): Use new helper functions.
- 9:12 AM Changeset in webkit [66833] by
-
- 2 edits in trunk/LayoutTests
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Unskip a couple of plugin tests which are now passing.
- platform/gtk/Skipped:
- 8:38 AM Changeset in webkit [66832] by
-
- 2 edits in trunk/LayoutTests
2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
- inspector/report-API-errors.html:
- 8:29 AM Changeset in webkit [66831] by
-
- 2 edits in trunk/WebCore
2010-09-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Tor Arne Vestbø.
WebCore already generates a focus-{out,in} events on its setFocus
method, there's no need to duplicate it here. Previously this was
needed because we were not catching all possible names of focus
events in PluginView::handleEvent and were missing the ones
WebCore does, but this has been fixed in r66827.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
- 8:01 AM Changeset in webkit [66830] by
-
- 19 edits2 deletes in trunk
Unreviewed, rolling out r66823.
http://trac.webkit.org/changeset/66823
https://bugs.webkit.org/show_bug.cgi?id=45266
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-09-06
Windows build fails with unknown reason (Requested by zherczeg
on #webkit).
WebCore:
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.h:
- rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
- rendering/RenderSVGResourceFilterPrimitive.h: Removed.
- rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGContainer):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
- svg/SVGFilterElement.h:
(WebCore::SVGFilterElement::invalidateFilter):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
LayoutTests:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
- 7:44 AM Changeset in webkit [66829] by
-
- 4 edits in trunk
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235
- platform/gtk/Skipped: Unskip a test which is now passing.
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235
Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
methods of the EventSender.
- DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd with the current modifiers. (contextClickCallback): Always send no modifiers when preparing the mouse event. (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask. (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent. (mouseUpCallback): Ditto.
- 7:42 AM Changeset in webkit [66828] by
-
- 3 edits1 delete in trunk/LayoutTests
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Antonio Gomes.
Convert editing/selection/shift-click.html to use setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=45233
- editing/selection/script-tests/shift-click.js: (shiftClick): Take only one expected string. (assertSelectionString): Take only one expected string. (runShiftClickTest): Added. Runs the test with a particular editing behavior.
- editing/selection/shift-click-expected.txt: Updated to reflect new results.
- platform/win/editing/selection/shift-click-expected.txt: Removed.
- 7:38 AM Changeset in webkit [66827] by
-
- 5 edits in trunk
WebCore:
2010-09-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613
Fix keyboard event delivery for windowless plugins.
Based on a patch by Bharathwaaj.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): also take into account focused{in,out} events
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent): we want the keyval here, not the hardware keycode (WebCore::PluginView::handleMouseEvent): focus the pluginview on mouse events
LayoutTests:
2010-09-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613
Unskip passing test.
- platform/gtk/Skipped:
- 7:31 AM Changeset in webkit [66826] by
-
- 4 edits in trunk
2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: it'd be nice to be able to pass undefined argument as a callback to InspectorBackend functions.
There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
will be called with additional argument for callback but with undefined value.
- inspector/CodeGeneratorInspector.pm:
- 6:36 AM Changeset in webkit [66825] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix chromium devtools tests
https://bugs.webkit.org/show_bug.cgi?id=45258
- src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):
- 6:29 AM Changeset in webkit [66824] by
-
- 3 edits in trunk/WebKit/qt
2010-09-06 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Attempt to fix random test crashes after r66720.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::~InspectorFrontendClientQt):
- WebCoreSupport/InspectorClientQt.h:
- 6:26 AM Changeset in webkit [66823] by
-
- 19 edits2 adds in trunk
An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954
Reviewed by Dirk Schulze.
WebCore:
RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilterPrimitive):
- rendering/RenderSVGResourceFilterPrimitive.cpp: Added.
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
- rendering/RenderSVGResourceFilterPrimitive.h: Added.
(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):
- rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGContainer):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):
LayoutTests:
The layout test below is fixed by this patch.
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
- 6:20 AM Changeset in webkit [66822] by
-
- 2 edits in trunk/WebCore
2010-09-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Dirk Schulze.
[WML] Use RenderImageResource in WMLImageElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=44952
The hasImage() and setCachedImage() were moved to RenderImageResource class.
So, WML also should use the functions from RenderImageResource.
- wml/WMLImageElement.cpp: (WebCore::WMLImageElement::attach):
- 6:19 AM MathML 3 testsuite results edited by
- (diff)
- 5:59 AM Changeset in webkit [66821] by
-
- 2 edits in trunk/BugsSite
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Add an "ok" button that collapses review comments
https://bugs.webkit.org/show_bug.cgi?id=45255
Many folks (including myself) are too trigger-happy with the "delete"
button that we end up deleting perfectly good review comments. This
patch adds an "ok" button to absorb these clicks (and renames "delete"
to "cancel"). When you click the ok button, the comment becomes
non-editable and the box shrinks to fit the text. You can click the
text to get back to the editable version.
- code-review.js:
- 3:33 AM Changeset in webkit [66820] by
-
- 16 edits in trunk
2010-08-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/script-tests/objectstore-basics.js: (createSuccess): (addIndexSuccess): (getSuccess):
2010-08-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695
Whenever you insert an item into an ObjectStore, it should use all
indexes' key paths to insert corresponding entries into each index.
Also data should be deleted out of the index when it goes away.
Not much testing yet since there's no way to directly observe indexes.
More will be in next patch.
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
- storage/IDBIndex.idl:
- storage/IDBIndexBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
- storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::id):
- storage/IDBKey.cpp: (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
- storage/IDBKey.h:
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::fetchKeyFromKeyPath): (WebCore::putObjectStoreData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBObjectStoreBackendImpl.h:
2010-08-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695
Add asserts on the [] operator.
- public/WebVector.h: (WebKit::WebVector::operator[]):
- 3:19 AM MathML 3 testsuite results edited by
- (diff)
- 3:09 AM MathML 3 testsuite results edited by
- (diff)
- 2:56 AM Changeset in webkit [66819] by
-
- 2 edits in trunk/WebKitSite
2010-09-06 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=43982
This js file seems to be a popular script for detecting mobile WebKit but
it has a flaw that makes it fail on Android and BlackBerry.
The issue is that it looks for "Mobile/" but Android and BlackBerry
use "Mobile" with no numbering after it.
Changed RegExp pattern " Mobile/" to " Mobile
b".
- misc/WebKitDetect.js: (WebKitDetect.isMobile):
- 1:31 AM Changeset in webkit [66818] by
-
- 5 edits in trunk
2010-09-06 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036
Add Chromium-specific API to query actual memory usage which bypasses any caches.
- platform/chromium/ChromiumBridge.h:
2010-09-06 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036
Add Chromium-specific API to query actual memory usage which bypasses any caches.
- public/WebKitClient.h: (WebKit::WebKitClient::actualMemoryUsageMB):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::actualMemoryUsageMB):
- 1:31 AM Changeset in webkit [66817] by
-
- 2 edits in trunk/LayoutTests
2010-09-06 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping a crashing media test.
[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235
- platform/gtk/Skipped: Skip media/controls-styling.html
- 1:14 AM Changeset in webkit [66816] by
-
- 2 edits in trunk/LayoutTests
2010-09-06 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: upstream Chromium SVG test_expectations
- platform/chromium/test_expectations.txt:
- 12:59 AM Changeset in webkit [66815] by
-
- 21 edits in trunk
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
canLoad is a pretty opaque name. This function is really about whether
you can display the contents of the URL in an iframe, an image, or a
plugin.
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
- loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
- page/SecurityOrigin.h:
- plugins/PluginView.cpp: (WebCore::PluginView::load):
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
Propagate name change.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
- WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
Propagate name change.
- WebFrame.cpp: (WebFrame::allowsFollowingLink):
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
Propagate name change.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
- 12:24 AM Changeset in webkit [66814] by
-
- 2 edits in trunk/LayoutTests
2010-09-06 Adam Barth <abarth@webkit.org>
Update expected results to match change in test. Qt's behavior is
unchanged. It's just the redundant expectations in the test that are
changing.
- platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
- 12:12 AM Changeset in webkit [66813] by
-
- 3 edits2 adds in trunk
2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
Test: inspector/debugger-suspend-active-dom-objects.html
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
- inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
- inspector/debugger-suspend-active-dom-objects.html: Added.
