⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 11, 2010:

11:37 PM Changeset in webkit [67318] by dbates@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-11 Daniel Bates <​dbates@rim.com>

Attempt to fix the Qt Linux Release build after changeset 67312 <​http://trac.webkit.org/changeset/67312>.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add missing ',' in WKPageUIClient initialization list.
9:58 PM Changeset in webkit [67317] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Attempt to fix Windows MiniBrowser build (untested)
​https://bugs.webkit.org/show_bug.cgi?id=45609

  • MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt):
7:28 PM Changeset in webkit [67316] by abarth@webkit.org
  • 21 edits in trunk

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

This function was secretly an instance function because callers needed
to pass in a document (which owns a SecurityOrigin). Only the
FrameLoader actually needs the method to be static.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
    • Notice that DocLoader::doc() can never be 0.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • page/SecurityOrigin.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::load):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
7:17 PM Changeset in webkit [67315] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Remove nonexistent test from skipped list
​https://bugs.webkit.org/show_bug.cgi?id=45608

  • platform/mac-wk2/Skipped:
7:15 PM Changeset in webkit [67314] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix zoom related tests when testing WebKit2.

Reviewed by Maciej Stachowiak.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.

7:08 PM Changeset in webkit [67313] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Skip some new tests that depend on APIs missing from WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=45607

  • platform/mac-wk2/Skipped:
6:50 PM Changeset in webkit [67312] by weinig@apple.com
  • 13 edits in trunk

Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
​https://bugs.webkit.org/show_bug.cgi?id=45605

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::setStatusText):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

6:17 PM Changeset in webkit [67311] by weinig@apple.com
  • 15 edits in trunk

Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
​https://bugs.webkit.org/show_bug.cgi?id=45604

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::source):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Add ability to dump the main frame's source to the console.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dumpSourceToConsole:]):

  • MiniBrowser/mac/MainMenu.xib:
4:25 PM Changeset in webkit [67310] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove unneeded Empty Queue messages
​https://bugs.webkit.org/show_bug.cgi?id=45602

We already have a /gc job to delete these.
recentstatus.py is already smart enough to use the
most recent of the workitems last update or the most recent status,
so removing these should not change the _last_status_date() return
value more than a few milliseconds.

These messages just spam the recent status log.

  • Scripts/webkitpy/tool/commands/queues.py:
12:15 PM Changeset in webkit [67309] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed.

[Qt] Trivial V8 build fix.

  • WebCore.pri: Add storage, workers and css to the include paths for the

JS code generator.

11:28 AM Changeset in webkit [67308] by andreas.kling@nokia.com
  • 5 edits in trunk/WebCore

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
​https://bugs.webkit.org/show_bug.cgi?id=45157

Include CString.h where necessary. Chromium builds would get it from
KURLGooglePrivate.h so this is only an issue for Qt + V8.

  • bindings/v8/V8Proxy.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • plugins/PluginDatabase.cpp:
11:22 AM Changeset in webkit [67307] by Simon Hausmann
  • 4 edits in trunk

[Qt] V8 port: webkit project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45140

Reviewed by Andreas Kling.

.:

building with v8.

WebCore:

  • WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.
11:11 AM Changeset in webkit [67306] by Simon Hausmann
  • 6 edits
    1 add in trunk

JavaScriptCore: [Qt] V8 port: webcore project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

so that they can also be used from WebCore.pro for v8 builds.

  • wtf/wtf.pri: Added.

WebCore: [Qt] V8 port: webcore project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

Modify webcore project files to include V8 javascript engine. By default disabled.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
11:09 AM Changeset in webkit [67305] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

Web Inspector: Include CString.h in generated files

This is necessary for generated code that uses the CString
returned by String::utf8() (from generateBackendDispatcher)

Chromium builds already get CString.h from KURLGooglePrivate.h
so this issue only occurs when building Qt against V8.

  • inspector/CodeGeneratorInspector.pm:
10:44 AM Changeset in webkit [67304] by andreas.kling@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port for Qt platform: Qt WebCoreSupport changes
​https://bugs.webkit.org/show_bug.cgi?id=45149

Original patch by Vlad Burlik <​volodimir.burlik@nokia.com>

Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
FrameLoaderClientQt.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame): (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame): (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext): (WebCore::FrameLoaderClientQt::createDocumentLoader):
  • WebCoreSupport/FrameLoaderClientQt.h:
10:42 AM Changeset in webkit [67303] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-11 Martin Robinson <​mrobinson@igalia.com>

Add a platform-specific result after r67281.

  • platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.
10:09 AM Changeset in webkit [67302] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Fix Python exception when generating synthetic patch IDs
​https://bugs.webkit.org/show_bug.cgi?id=45592

Can't concatenate strings and numbers directly.

  • QueueStatusServer/handlers/queuestatus.py:
10:06 AM Changeset in webkit [67301] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit/qt

2010-09-11 Vlad Burlik <​volodimir.burlik@nokia.com>

Reviewed by Andreas Kling.

[Qt] V8 port for QT platform: QT API implementation changes
​https://bugs.webkit.org/show_bug.cgi?id=45148

V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
and QWebFrame::evaluateJavaScript()

  • Api/qwebelement.cpp: (setupScriptContext): JSC and V8 variations (QWebElement::evaluateJavaScript):
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: QObject injection to V8 world (QWebFrame::addToJavaScriptWindowObject): (QWebFrame::evaluateJavaScript):
  • Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8 (QWebPagePrivate::QWebPagePrivate):
9:25 AM Changeset in webkit [67300] by xan@webkit.org
  • 4 edits in trunk

2010-09-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
​https://bugs.webkit.org/show_bug.cgi?id=45590

Bump required gobject-introspection version to 0.9.5.

  • configure.ac:

WebKit/gtk:

2010-09-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
​https://bugs.webkit.org/show_bug.cgi?id=45590

Use new type syntax and bump version number of the gir file.

  • JSCore.gir.in:
9:19 AM Changeset in webkit [67299] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

chromium fast/dom/replaceChild.html regression by r67182
​https://bugs.webkit.org/show_bug.cgi?id=45527

Turns out this is a progression! Our new images
match minefield (and sanity). The old image had a
border drawn which should have been removed when the
iframe was replaced.

Other platforms may need to update their results as well.

  • platform/mac/fast/dom/replaceChild-expected.checksum:
  • platform/mac/fast/dom/replaceChild-expected.png:
9:09 AM Changeset in webkit [67298] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-11 Robert Hogan <​robert@webkit.org>

Unreviewed, unskip passing test.

Test fixed by ​http://trac.webkit.org/changeset/56511

See ​https://bugs.webkit.org/show_bug.cgi?id=36492

  • platform/qt/Skipped:
8:04 AM Changeset in webkit [67297] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-11 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fix EFL build after r67274
​https://bugs.webkit.org/show_bug.cgi?id=45584

Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
to proper apis chaged by r67264.

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
6:20 AM Changeset in webkit [67296] by adele@apple.com
  • 3 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.

Reviewed by Sam Weinig.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderFlexibleBox.h:
3:06 AM Changeset in webkit [67295] by commit-queue@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Group statuses in queue status by patch ID
​https://bugs.webkit.org/show_bug.cgi?id=45588

Group statuses by patch ID so that the status page is easier
to scan.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/stylesheets/dashboard.css: (.status-group): (.status-bug): (.status-group ul): (.status-group ul li): (.status-group ul li:hover): (.status-cell): (.status-cell:hover): (.status-cell.pass): (.status-cell.fail): (.status-cell.pending): (.status-cell.error):
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/queuestatus.html:
2:48 AM Changeset in webkit [67294] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45479

Remove tests from Chromium expectations that now pass. Add
Chromium/Linux expectations for the script test, since it reports a
different MIME type (application/javascript vs.
application/x-javascript).

  • platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium-linux/fast/preloader/script-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45479

Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse):
2:32 AM Changeset in webkit [67293] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-11 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
​https://bugs.webkit.org/show_bug.cgi?id=45579

  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [67292] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of ​http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
12:54 AM Changeset in webkit [67291] by diegohcg@webkit.org
  • 30 edits in trunk

Add NetworkingContext to avoid layer violations ​https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.

WebCore:

Activate NetworkingContext:

Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::PingLoader):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::load):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/icon/IconFetcher.cpp:

(WebCore::IconFetcher::loadEntry):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

WebKit/chromium:

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

WebKit/gtk:

  • webkit/webkitdownload.cpp:

(webkit_download_start):

  • webkit/webkitprivate.cpp:

(currentToplevelCallback):

WebKit/win:

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::blockedError):

  • WebCoreSupport/WebFrameNetworkingContext.h:

WebKit2:

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):

12:23 AM Changeset in webkit [67290] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should expose /remote_api for data upload/download
​https://bugs.webkit.org/show_bug.cgi?id=45559

  • QueueStatusServer/app.yaml:
    • /remote_api is a standard app-engine service which allows use of the bulk uploader for data upload/download. Exposing this (for admin access only) allows us to use
12:07 AM Changeset in webkit [67289] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-09-10 yi shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt] selected text gets deleted when qgraphicswebview losts focus
​https://bugs.webkit.org/show_bug.cgi?id=45539

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

Sep 10, 2010:

11:52 PM Changeset in webkit [67288] by jer.noble@apple.com
  • 3 edits in trunk/WebCore

No review; build fix only.

<CoreGraphics/CGAffineTransform.h> isn't on the build bots either. Wrap
all references to m_movieTransform in #if USE(ACCELERATED_COMPOSITING) guards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveAndResetMovieTransform):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
11:45 PM Changeset in webkit [67287] by weinig@apple.com
  • 15 edits in trunk

Add zoom support to WebKit2 API
<rdar://problem/7660657>
​https://bugs.webkit.org/show_bug.cgi?id=45585

Reviewed by Dan Bernstein.

WebKit2:

  • Add UIProcess API for setting zoom factors.
  • Change bundle zoom API to be in terms of doubles for consistency.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetTextZoomFactor):
(WKPageSetTextZoomFactor):
(WKPageGetPageZoomFactor):
(WKPageSetPageZoomFactor):
(WKPageSetPageAndTextZoomFactors):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

  • Add zoom options to MiniBrowser that mimic Safari's options using the new WebKit2 zoom APIs.
  • Switch uses of float for the zoom APIs to use double.
  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController validateMenuItem:]):
(-[BrowserWindowController validateUserInterfaceItem:]):
(-[BrowserWindowController currentZoomFactor]):
(-[BrowserWindowController setCurrentZoomFactor:]):
(-[BrowserWindowController canZoomIn]):
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController canZoomOut]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController canResetZoom]):
(-[BrowserWindowController resetZoom:]):
(-[BrowserWindowController toggleZoomMode:]):

  • MiniBrowser/mac/MainMenu.xib:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

11:36 PM Changeset in webkit [67286] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No review; build fix only.

<CoreGraphics/CGFloat.h> does not exist on the build bots. Replace
instances of CGFAbs() with abs().

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):

11:24 PM Changeset in webkit [67285] by jer.noble@apple.com
  • 9 edits
    2 adds in trunk

2010-09-10 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
​https://bugs.webkit.org/show_bug.cgi?id=45333


The rootChild layer must be set as flipped, otherwise transformed movies will appear
incorrectly rotated.

  • FullscreenVideoController.cpp: (FullscreenVideoController::enterFullscreen):

2010-09-10 Dan Bernstein <​mitz@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Test: fast/dynamic/first-letter-display-change.html

  • rendering/RenderBlock.cpp: (WebCore::styleForFirstLetter): Factored this helper function out. (WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the “update style” and “create new” branches use the same terminology. In the update case, if the style change requires a new renderer, handle it.
  • rendering/RenderTextFragment.h: (WebCore::toRenderTextFragment): Added.
11:19 PM Changeset in webkit [67284] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-10 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=45563
Assertion failure: useTransforms when scrolling to an SVG element

This has been indirectly fixed in r63633, just adding a test.

  • svg/custom/scroll-to-svg-element-assertion-expected.txt: Added.
  • svg/custom/scroll-to-svg-element-assertion.html: Added.
10:57 PM Changeset in webkit [67283] by weinig@apple.com
  • 2 edits in trunk/WebKit/chromium

Fix chromium build.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):

10:55 PM Changeset in webkit [67282] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-10 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix crash in DRT in standalone mode

​https://bugs.webkit.org/show_bug.cgi?id=45454

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
10:55 PM Changeset in webkit [67281] by mitz@apple.com
  • 4 edits
    4 adds in trunk

<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Reviewed by Darin Adler.

WebCore:

Test: fast/dynamic/first-letter-display-change.html

  • rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Factored this helper function out.
(WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
“update style” and “create new” branches use the same terminology. In the
update case, if the style change requires a new renderer, handle it.

  • rendering/RenderTextFragment.h:

(WebCore::toRenderTextFragment): Added.

LayoutTests:

  • fast/dynamic/first-letter-display-change-expected.checksum: Added.
  • fast/dynamic/first-letter-display-change-expected.png: Added.
  • fast/dynamic/first-letter-display-change-expected.txt: Added.
  • fast/dynamic/first-letter-display-change.html: Added.
10:50 PM Changeset in webkit [67280] by rniwa@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed, speculative chromium build fix.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel):
10:31 PM Changeset in webkit [67279] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added editing/style/style-3690704-fix.html to the gtk's skipped list
since the test requires editing delegates, which hasn't been implemented in gtk.

  • platform/gtk/Skipped:
10:21 PM Changeset in webkit [67278] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

Application cache directory should be checked before sending to the web process
​https://bugs.webkit.org/show_bug.cgi?id=45462

  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of m_context->applicationCacheDirectoy() to avoid sending a null string to the web process what makes it asserting.
10:08 PM Changeset in webkit [67277] by rniwa@webkit.org
  • 3 edits
    2 adds
    20 deletes in trunk/LayoutTests

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
​https://bugs.webkit.org/show_bug.cgi?id=45578

Modified insert-3659587-fix.html and style-3690704-fix.html to use runDumpAsTextEditingTest().

  • editing/inserting/insert-3659587-fix-expected.txt: Added.
  • editing/inserting/insert-3659587-fix.html:
  • editing/style/style-3690704-fix-expected.txt: Added.
  • editing/style/style-3690704-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/chromium-linux/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/gtk/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/qt/editing/style/style-3690704-fix-expected.txt: Removed.
9:11 PM Changeset in webkit [67276] by weinig@apple.com
  • 2 edits in trunk/WebKit/qt

Fix Qt build.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

9:09 PM Changeset in webkit [67275] by weinig@apple.com
  • 2 edits in trunk/WebKit/gtk

Fix GTK build.

  • webkit/webkitwebview.cpp:

(webkit_web_view_set_full_content_zoom):

9:01 PM Changeset in webkit [67274] by weinig@apple.com
  • 43 edits
    1 delete in trunk

Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
​https://bugs.webkit.org/show_bug.cgi?id=45522

Reviewed by Darin Adler.

WebCore:

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Remove ZoomMode.h

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
Remove uses of shouldApplyTextZoom(), it had turned into just a compare to 1.0f.

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Convert these to use the explicit pageZoomFactor() function, it made no sense for text zoom
anyway.

  • page/Frame.h:

Remove include of ZoomMode.h

  • page/FrameView.cpp:

(WebCore::parentPageZoomFactor):
(WebCore::parentTextZoomFactor):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setPageZoomFactor):
(WebCore::FrameView::setTextZoomFactor):
(WebCore::FrameView::setPageAndTextZoomFactors):

  • page/FrameView.h:

(WebCore::FrameView::pageZoomFactor):
(WebCore::FrameView::textZoomFactor):
Change FrameView to store two values for zoom, one for page zoom and one for text zoom.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Removed zoom mode.

  • page/ZoomMode.h: Removed.
  • rendering/RenderView.cpp:

(WebCore::RenderView::zoomFactor):
Remove now unnecessary call to shouldApplyPageZoom since it will be 1 if it should
be ignored.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentScale):
Use explicit setPageZoomFactor function.

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::createPlugin):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setZoomLevel):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::zoomTextOnly):
Move tracking of text only zoom here from WebCore.

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_zoom_level):
(webkit_web_view_apply_zoom_level):
(webkit_web_view_set_full_content_zoom):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):
(-[WebView _setZoomMultiplier:isTextOnly:]):
(-[WebView _realZoomMultiplierIsTextOnly]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):
Move tracking of text only zoom here from WebCore.

WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::setTextSizeMultiplier):
(QWebFrame::textSizeMultiplier):
(QWebFrame::setZoomFactor):
(QWebFrame::zoomFactor):

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
Move tracking of text only zoom here from WebCore.

WebKit/win:

  • WebFrame.cpp:
  • WebFrame.h:

Remove dead code.

  • WebView.cpp:

(WebView::WebView):
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):

  • WebView.h:

Move tracking of text only zoom here from WebCore.

WebKit2:

Now that WebCore doesn't require a mode, change the bundle API for zoom to not
require one either.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStopLoading):
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Update for changes to the Bundle API to allow separate control of page and text zoom
levels.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset):

8:59 PM Changeset in webkit [67273] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-09-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] Implement port specific part of WebKit::InjectedBundle
​https://bugs.webkit.org/show_bug.cgi?id=45541

  • WebProcess/InjectedBundle/InjectedBundle.h: Typedef PlatformBundle as QLibrary for qt.
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::load): Implemented.
8:42 PM Changeset in webkit [67272] by yael.aharon@nokia.com
  • 14 edits in trunk

2010-09-10 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
​https://bugs.webkit.org/show_bug.cgi?id=44836

  • fast/notifications/notifications-click-event-expected.txt:
  • platform/qt/Skipped:

2010-09-10 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
​https://bugs.webkit.org/show_bug.cgi?id=44836

Propagate click events to JavaScript from either the
platform plugn or from QSystemTrayIcon.
Also added the method NotificationWrapper::openerPageUrl so that
if the platform plugin can reopen the page that created the
notification directly, when the user clicks the notification.

Added DumpRenderTreeSupportQt::simulateDesktopNotificationClick
for testing purpose.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationWrapper::openerPageUrl): (WebCore::NotificationWrapper::notificationClicked): (WebCore::NotificationPresenterClientQt::displayNotification): (WebCore::NotificationPresenterClientQt::notificationClicked):
  • WebCoreSupport/NotificationPresenterClientQt.h:
  • examples/platformplugin/WebNotificationPresenter.cpp: (WebNotificationWidget::event):
  • examples/platformplugin/WebNotificationPresenter.h: (WebNotificationPresenter::WebNotificationPresenter):
  • examples/platformplugin/qwebkitplatformplugin.h:

2010-09-10 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
​https://bugs.webkit.org/show_bug.cgi?id=44836

Add support for simulateDesktopNotificationClick by calling
back to DumpRenderTreeSupportQt.cpp.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::simulateDesktopNotificationClick):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
8:25 PM Changeset in webkit [67271] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-10 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Andreas Kling.

Add a define missing when building with glib unicode backend
​https://bugs.webkit.org/show_bug.cgi?id=45544

  • wtf/unicode/glib/UnicodeMacrosFromICU.h:
7:47 PM Changeset in webkit [67270] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-09-10 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Fix warnings because of bad assignments in testatk.c
​https://bugs.webkit.org/show_bug.cgi?id=45538

Use AtkObject and AtkText instances properly in the code.

  • tests/testatk.c: (testWebkitAtkListsOfItems):
7:33 PM Changeset in webkit [67269] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-10 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Update queue status when patches fail their first land attempt
​https://bugs.webkit.org/show_bug.cgi?id=45583

Add a few more _update_status calls to make it more obvious if a patch is
being retried because tests failed.

  • Scripts/webkitpy/tool/commands/queues.py:
7:28 PM Changeset in webkit [67268] by abarth@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-09-10 Adam Barth <​abarth@webkit.org>

Attempt to fix the failign Qt tests. This patch adapts code from
Chromium. The long-term fix is to remove the need for this code, but
that's a bit too complicated for a buildfix patch.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::finishedLoading):
  • WebCoreSupport/FrameLoaderClientQt.h:
7:27 PM Changeset in webkit [67267] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix for EFL.

[EFL] REGRESSION(67167) build break because of newly added JSBindingState.cpp
​https://bugs.webkit.org/show_bug.cgi?id=45537

  • CMakeLists.txt:
6:56 PM Changeset in webkit [67266] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] MiniBrowser crashes with multiply windows when closing one of them
​https://bugs.webkit.org/show_bug.cgi?id=45536

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::~QWKPage): Do not call WKPageTerminate since this is designed to terminate the web process. We are correctly detaching the page without this call anyway.

2010-09-10 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] MiniBrowser crashes with multiply windows when closing one of them
​https://bugs.webkit.org/show_bug.cgi?id=45536

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Reference the context instead of adopting it because it can be shared across different views.
6:40 PM Changeset in webkit [67265] by Stephanie Lewis
  • 5 edits
    2 adds in trunk

JavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know
about the JIT and other implementation details of JavaScriptCore. Necessary
to fix PPC build.

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=45528

(JSC::memoryStatistics):

  • runtime/MemoryStatistics.h: Added.

WebKit/mac: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
other implementation details of JavaScriptCore. Necessary to fix PPC build.

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=45528

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics memoryStatistics]):

6:28 PM Changeset in webkit [67264] by Darin Adler
  • 11 edits
    2 moves in trunk

2010-09-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45582

  • WebKit.xcodeproj/project.pbxproj: Added WebDashboardRegion.h/mm and also gave the header private visibility so it will get installed in the PrivateHeaders directory.

2010-09-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45582

  • MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::dashboardRegionsChanged): Changed this to call -[WebView _dashboardRegions] so we don't have two copies of that code.
  • WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
  • WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.

2010-09-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45582

  • WebCore.exp.in: Updated.
  • WebCore.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h/m.
  • page/mac/WebDashboardRegion.h: Removed.
  • page/mac/WebDashboardRegion.m: Removed.
  • page/Frame.h: Removed unneeded #if. Removed dashboardRegionsDictionary function, now handled in WebKit. Removed searchForNSLabelsAboveCell function, which had become dead code.
  • page/mac/FrameMac.mm: Ditto. Also tweaked a place that said "int unsigned".
6:27 PM Changeset in webkit [67263] by pkasting@chromium.org
  • 7 edits in branches/chromium/517

Merge 67261 - Make middle clicks not fire DOM onclick events.
​https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

  • html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the

computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):

  • html/HTMLInputElement.cpp: Removed unneeded checks that click events

are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):

  • page/EventHandler.cpp: Changed logic to send a click event only for

the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

TBR=​pkasting@chromium.org
Review URL: ​http://codereview.chromium.org/3325025

6:24 PM Changeset in webkit [67262] by pkasting@chromium.org
  • 6 edits in branches/chromium/517/WebCore

Merge 67246 - 2010-09-109 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
​https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp:

(WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
check if the event is a MouseEvent. Any click event will do.

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Added. Factors out the
modifications to the URL to add the mouse position to make the default
event handler function easier to read.
(WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
the enter key logic separate from the link clicking logic and simplify
the function. This makes minor functional changes like not calling
FrameLoader::urlSelected() for fake "keydown" events constructed from
JavaScript.
(WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
implementation in treatLinkAsLiveForEventType().
(WebCore::eventType): Factors out event type calculation (for
treatLinkAsLiveForEventType()) from the default event handler to make it
easier to read.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
Implementation of the portions of isLiveLink() that are common with the
checks defaultEventHandler() wants to do.
(WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
event handlers for all three anchor elements.
(WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
function below and some code in SVG. Later we can make this private to
this source file once we remove the unneeded SVG code.
(WebCore::isLinkClick): Added. Shared by the default event handlers for
all three anchor elements.
(WebCore::handleLinkClick): Ditto.

  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
logic and streamlined the code to more closely match the
HTMLAnchorElement code and share functions with it.

  • wml/WMLAElement.cpp:

(WebCore::WMLAElement::defaultEventHandler): Ditto.

TBR=​pkasting@chromium.org
Review URL: ​http://codereview.chromium.org/3366025

6:16 PM Changeset in webkit [67261] by pkasting@chromium.org
  • 7 edits in trunk

Make middle clicks not fire DOM onclick events.
​https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

  • html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the

computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):

  • html/HTMLInputElement.cpp: Removed unneeded checks that click events

are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):

  • page/EventHandler.cpp: Changed logic to send a click event only for

the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:
6:07 PM Changeset in webkit [67260] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
SelectionController instead of frame. Also fix a style issue.

  • WebFrame.cpp:

(WebFrame::currentForm):

6:03 PM Changeset in webkit [67259] by crogers@google.com
  • 26 edits in branches/audio/WebCore

audio branch: lots of cleanup for moving to trunk

  • Biquad
  • ArrayBufferView, TypedArrayBase, AudioBuffer
  • Lots of general cleanup in AudioNode, AudioNodeInput, AudioNodeOutput, AudioContext
  • AudioSourceNode
6:03 PM Changeset in webkit [67258] by crogers@google.com
  • 8 edits in branches/audio/WebCore/platform/audio

audio branch: cleanup of HRTF-related files

6:03 PM Changeset in webkit [67257] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Adam Barth <​abarth@webkit.org>

Attempted build fix for Qt Minimal.

  • dom/Element.cpp: (WebCore::Element::getBoundingClientRect):
5:58 PM Changeset in webkit [67256] by dpranke@chromium.org
  • 30 edits in trunk/LayoutTests

2010-09-10 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Need to rebaseline a bunch of files resulting from the SVG change
in r67200.

​https://bugs.webkit.org/show_bug.cgi?id=45580

  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.txt
  • platform/chromium-win/svg/batik/text/textAnchor3-expected.txt
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt
  • platform/chromium-win/svg/text/select-x-list-1-expected.txt
  • platform/chromium-win/svg/text/select-x-list-2-expected.txt
  • platform/chromium-win/svg/text/select-x-list-3-expected.txt
  • platform/chromium-win/svg/text/select-x-list-4-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt
  • platform/chromium-win/svg/text/text-text-07-t-expected.txt
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.txt
  • platform/chromium/test_expectations.txt:
5:53 PM Changeset in webkit [67255] by mitz@apple.com
  • 6 edits in trunk

2010-09-10 Dan Bernstein <​mitz@apple.com>

Reviewed by Anders Carlsson.

Pseudostyle resolution corrupts cached child index values
​https://bugs.webkit.org/show_bug.cgi?id=45574

Covered by fast/dom/firstline-fixed-crash.html and fast/dom/firstletter-tablecell-crash.html.

RenderBlock::updateFirstLetter() calls getCachedPseudoStyle() passing as the parent style the
style of the parent of the first letter, which is not always the parent of the element for
which we are getting :first-letter style. As a result, style resolution caches childIndex values
in the wrong element’s style.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement): Create the new style and inherit from the parent style before matching rules, to avoid corrupting the parent style itself. (WebCore::CSSStyleSelector::checkSelector): Always pass the element’s parent style as the parent style here.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Removed the null check that was added in r67183.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak): Removed the null check that was added in r67184.

2010-09-10 Dan Bernstein <​mitz@apple.com>

Reviewed by Anders Carlsson.

Pseudostyle resolution corrupts cached child index values
​https://bugs.webkit.org/show_bug.cgi?id=45574

  • fast/dom/firstline-fixed-crash-expected.txt: Updated results.
5:50 PM Changeset in webkit [67254] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No review; build fix only.

Touch mediaControlsQuickTime in order to trigger the UserAgentStyleSheet.h to be rebuilt.

  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

5:49 PM Changeset in webkit [67253] by abarth@webkit.org
  • 31 edits in trunk

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

This code didn't know that setEncoding can be called multiple times.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::committedLoad):
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

This code is the most confused, but now should be a bit cleaner.
There's still a magical fake-setting for creating renderers that needs
to be cleaned up, but we can do that in a separate patch.

  • WebView/WebFrame.mm: (-[WebFrame _commitData:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation receivedData:withDataSource:]): (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

This code didn't know that setEncoding could be called multiple times
safely.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): (WebCore::FrameLoaderClientEfl::committedLoad): (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientEfl::finishedLoading): (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): (WebCore::FrameLoaderClientEfl::setMainDocumentError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

There's a bunch of code that's copy/pasted (poorly) across all the
ports that really belongs in WebCore. This patch moves that logic into
DocumentLoader. This patch is a step on the path to having
DocumentLoader own DocumentWriter.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=45569

This code looks copy/pasted from Mac. It's unclear whether whether all
the complexity is needed here, but I don't have a good way to find out.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::committedLoad):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
5:47 PM Changeset in webkit [67252] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-10 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect Broken for SVG Elements
​https://bugs.webkit.org/show_bug.cgi?id=42815

Added tests for getBoundingClientRect applied to SVG elements.

  • svg/custom/getBoundingClientRect.xhtml: Added
  • svg/custom/getBoundingClientRect-expected.txt: Added

2010-09-10 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect Broken for SVG Elements
​https://bugs.webkit.org/show_bug.cgi?id=42815

Use getBBox to retrieve the bounding rectangle for SVG elements.

Test: svg/dom/getBoundingClientRect.xhtml

  • dom/Element.cpp: (Element::getBoundingClientRect):
4:56 PM Changeset in webkit [67251] by jer.noble@apple.com
  • 17 edits in trunk

2010-09-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Adopt shared control drawing for <video> controls on Windows
​https://bugs.webkit.org/show_bug.cgi?id=45490

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:

2010-09-09 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Adopt shared control drawing for <video> controls on Windows
​https://bugs.webkit.org/show_bug.cgi?id=45490


  • DerivedSources.make: Remove the OS check around mediaControlsQuickTime.css.
  • rendering/RenderMediaControls.cpp: (WebCore::determineState): Use WKMediaControllerThemeState flags instead of SafariTheme ones. (WebCore::getUnzoomedRectAndAdjustCurrentContext): Added. Copied verbatim from RenderMediaMac.mm. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Use wkMeasureMediaUIPart to adjust the thumb size. (WebCore::RenderMediaControls::paintMediaControlsPart): Use wkDrawMediaUIPart instead of paintThemePart. (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Added. Copied verbatim from RenderMediaMac.mm.
  • rendering/RenderMediaControls.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): Adjust both sliders and volume sliders. (WebCore::RenderThemeWin::extraMediaControlsStyleSheet): Added. Returns the mediaControlsQuickTime sheet. (WebCore::RenderThemeWin::paintMediaRewindButton): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaControlsBackground): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderContainer): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderTrack): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderThumb): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Added. Pass through to RenderMediaControls.
  • rendering/RenderThemeWin.h:

2010-09-109 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
​https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp: (WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to check if the event is a MouseEvent. Any click event will do.
  • html/HTMLAnchorElement.cpp: (WebCore::appendServerMapMousePosition): Added. Factors out the modifications to the URL to add the mouse position to make the default event handler function easier to read. (WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make the enter key logic separate from the link clicking logic and simplify the function. This makes minor functional changes like not calling FrameLoader::urlSelected() for fake "keydown" events constructed from JavaScript. (WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared implementation in treatLinkAsLiveForEventType(). (WebCore::eventType): Factors out event type calculation (for treatLinkAsLiveForEventType()) from the default event handler to make it easier to read. (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType): Implementation of the portions of isLiveLink() that are common with the checks defaultEventHandler() wants to do. (WebCore::isEnterKeyKeydownEvent): Added. Shared by the default event handlers for all three anchor elements. (WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick function below and some code in SVG. Later we can make this private to this source file once we remove the unneeded SVG code. (WebCore::isLinkClick): Added. Shared by the default event handlers for all three anchor elements. (WebCore::handleLinkClick): Ditto.
  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded logic and streamlined the code to more closely match the HTMLAnchorElement code and share functions with it.
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): Ditto.
4:47 PM Changeset in webkit [67250] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-10 Tony Chang <​tony@chromium.org>

Unreviewed, fix chromium compile after r67238.

shouldChangeSelection was removed from Frame.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition):
4:40 PM Changeset in webkit [67249] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Update mac/Skipped to include the bug numbers for newly added skip entries.

  • platform/mac/Skipped:
4:31 PM Changeset in webkit [67248] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-10 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Rebaseline transitions/opacity-transition-zindex.html
​https://bugs.webkit.org/show_bug.cgi?id=45515

Difference was off-by-one on the green channel.

  • platform/chromium-win/transitions/opacity-transition-zindex-expected.checksum: Added.
  • platform/chromium-win/transitions/opacity-transition-zindex-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [67247] by andersca@apple.com
  • 7 edits in trunk

WebKit2: Set the visible name for the web process
​https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

Reviewed by Mark Rowe and Darin Adler.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::processName):
Add a thread safe implementation of -[NSProcessInfo processName].

(WebKit::ProcessLauncher::launchProcess):
Pass the process name to the child process.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):
Set the visible name.

WebKitLibraries: WebKitSystemInterface part of:
Set the visible name for the web process
​https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:42 PM Changeset in webkit [67246] by pkasting@chromium.org
  • 6 edits in trunk/WebCore

2010-09-109 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
​https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp:

(WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
check if the event is a MouseEvent. Any click event will do.

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Added. Factors out the
modifications to the URL to add the mouse position to make the default
event handler function easier to read.
(WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
the enter key logic separate from the link clicking logic and simplify
the function. This makes minor functional changes like not calling
FrameLoader::urlSelected() for fake "keydown" events constructed from
JavaScript.
(WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
implementation in treatLinkAsLiveForEventType().
(WebCore::eventType): Factors out event type calculation (for
treatLinkAsLiveForEventType()) from the default event handler to make it
easier to read.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
Implementation of the portions of isLiveLink() that are common with the
checks defaultEventHandler() wants to do.
(WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
event handlers for all three anchor elements.
(WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
function below and some code in SVG. Later we can make this private to
this source file once we remove the unneeded SVG code.
(WebCore::isLinkClick): Added. Shared by the default event handlers for
all three anchor elements.
(WebCore::handleLinkClick): Ditto.

  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
logic and streamlined the code to more closely match the
HTMLAnchorElement code and share functions with it.

  • wml/WMLAElement.cpp:

(WebCore::WMLAElement::defaultEventHandler): Ditto.

3:38 PM Changeset in webkit [67245] by tonyg@chromium.org
  • 7 edits in trunk

2010-09-10 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Implement HTML5 definition of script for-event neutering
​https://bugs.webkit.org/show_bug.cgi?id=45493

  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
  • fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Beef up test with some more cases, change style to be more readable, and remove obsolete comments about supporting for-event.

2010-09-10 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Implement HTML5 definition of script for-event neutering
​https://bugs.webkit.org/show_bug.cgi?id=45493

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::shouldExecuteAsJavaScript): Same behavior, but reads more like the spec. Removed obsolete comments about supporting for-event.
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executeScript): Moved to runScript. (WebCore::HTMLScriptRunner::runScript): Checking shouldExecuteAsJavaScript() here means that external scripts which fail the check will never be requested.
3:33 PM Changeset in webkit [67244] by darin@chromium.org
  • 14 edits in trunk

2010-09-10 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Accelerated Compositing: screen garbage when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=45092

Split LayerRenderChromium::drawLayers into several different
functions, responsible for preparing the backbuffer, updating the
root texture, compositing and performing the final
swapbuffers. This are then used by the new
WebViewImpl::composite rendering path.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::setNeedsDisplay): (WebCore::LayerChromium::resetNeedsDisplay):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::dirtyRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::present):
  • platform/graphics/chromium/LayerRendererChromium.h:
3:26 PM Changeset in webkit [67243] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand("fontsize") on certain selected html generates too many SPAN tags.
​https://bugs.webkit.org/show_bug.cgi?id=28968

Added a test to ensure only one font element is added when applying font-size
to multiple inline nodes.

  • editing/style/apply-font-size-to-multiple-nodes-expected.txt: Added.
  • editing/style/apply-font-size-to-multiple-nodes.html: Added.
3:24 PM Changeset in webkit [67242] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-10 Tony Chang <​tony@chromium.org>

Unreviewed, rolling out r67241.
​http://trac.webkit.org/changeset/67241
​https://bugs.webkit.org/show_bug.cgi?id=44709

Accidentally committed.

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3:16 PM Changeset in webkit [67241] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

deduplicate-tests should be runnable from any WebKit directory
​https://bugs.webkit.org/show_bug.cgi?id=44709

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3:16 PM Changeset in webkit [67240] by inferno@chromium.org
  • 5 edits in trunk

2010-09-10 David Holloway <​dhollowa@chromium.org>

Reviewed by Adam Barth.

Change WebKit::WebFormElement::wasUserSubmitted to use WebCore::HTMLFormElement::submittedByUserGesture
instead of WebCore::HTMLFormElement::submissionTrigger.
Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form. A
more accurate measure of the user manually submitting a form is via user gesture.
​https://bugs.webkit.org/show_bug.cgi?id=45128

  • src/WebFormElement.cpp: (WebKit::WebFormElement::wasUserSubmitted):

2010-09-10 David Holloway <​dhollowa@chromium.org>

Reviewed by Adam Barth.

Replace WebCore::HTMLFormElement::submissionTrigger with WebCore::HTMLFormElement::submittedByUserGesture.
Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form. A
more accurate measure of the user manually submitting a form is via user gesture.
​https://bugs.webkit.org/show_bug.cgi?id=45128

No new tests as this is only used by the Chromium WebKit API.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::submittedByUserGesture):
  • html/HTMLFormElement.h:
3:08 PM Changeset in webkit [67239] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove mention of "part" from Document.cpp
​https://bugs.webkit.org/show_bug.cgi?id=45566

This is an old KHTML name that's lingering around.

  • dom/Document.cpp: (WebCore::Document::parentDocument):
3:06 PM Changeset in webkit [67238] by Darin Adler
  • 39 edits in trunk

2010-09-09 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
​https://bugs.webkit.org/show_bug.cgi?id=45508

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect): Call functions on selection().

2010-09-09 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
​https://bugs.webkit.org/show_bug.cgi?id=45508

  • WebView.cpp: (WebView::selectionRect): (WebView::centerSelectionInVisibleArea): Call functions on selection().

2010-09-09 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
​https://bugs.webkit.org/show_bug.cgi?id=45508

  • WebView/WebFrame.mm: (-[WebFrame _selectionGranularity]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _typingStyle]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation currentForm]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView centerSelectionInVisibleArea:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionTextRects]): (-[WebHTMLView selectionImageRect]):
  • WebView/WebView.mm: (-[WebView setEditable:]): Call functions on selection().

2010-09-09 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
​https://bugs.webkit.org/show_bug.cgi?id=45508

Also removed Frame::dragCaretController since it just called Page::dragCaretController.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::selectAll): (WebCore::SelectionController::focusedOrActiveStateChanged): (WebCore::SelectionController::notifyRendererOfSelectionChange): (WebCore::isFrameElement): (WebCore::SelectionController::setFocusedNodeIfNeeded): (WebCore::SelectionController::paintDragCaret): (WebCore::SelectionController::shouldDeleteSelection): (WebCore::SelectionController::selectionBounds): (WebCore::SelectionController::selectionTextRects): (WebCore::scanForForm): (WebCore::SelectionController::currentForm): (WebCore::SelectionController::revealSelection): (WebCore::SelectionController::setSelectionFromNone): (WebCore::SelectionController::shouldChangeSelection):
  • editing/SelectionController.h: Moved functions here from Frame.
  • page/Frame.cpp:
  • page/Frame.h: Moved functions to SelectionController. Reorganized header to be easier to read and a bit more logical.
  • WebCore.exp.in: Updated.
  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): Call Page::dragCaretController directly.
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/InputElement.cpp: (WebCore::InputElement::updateFocusAppearance):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::editingStyleAtPosition):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/Editor.cpp: (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::textDirectionForSelection): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::revealSelectionAfterEditingOperation): (WebCore::Editor::transpose): (WebCore::Editor::changeSelectionAfterCommand): (WebCore::Editor::computeAndSetTypingStyle): (WebCore::Editor::selectionComputedStyle): (WebCore::Editor::styleForSelectionStart): (WebCore::Editor::findString):
  • editing/EditorCommand.cpp: (WebCore::executeDelete):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): (WebCore::dragLocForSelectionDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
  • page/chromium/FrameChromium.cpp: (WebCore::Frame::dragImageForSelection):
  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::writeRange):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Call functions on selection().
3:04 PM Changeset in webkit [67237] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-09-10 Simon Fraser <Simon Fraser>

Re-enable some Windows compositing tests that no longer assert.

  • platform/win/Skipped:
3:00 PM Changeset in webkit [67236] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2010-09-10 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

SVGGElement::rendererIsNeeded should return false when parent isn't SVG
​https://bugs.webkit.org/show_bug.cgi?id=45562

Test: svg/custom/g-outside-svg.html

  • svg/SVGGElement.cpp: (WebCore::SVGGElement::rendererIsNeeded):
  • svg/SVGGElement.h:

2010-09-10 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

SVGGElement::rendererIsNeeded should return false when parent isn't SVG
​https://bugs.webkit.org/show_bug.cgi?id=45562

  • svg/custom/g-outside-svg-expected.txt: Added.
  • svg/custom/g-outside-svg.html: Added.
2:31 PM Changeset in webkit [67235] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip file api tests for workers that could crash occasionally before
we figure out how to fix them.

  • platform/mac/Skipped:
2:29 PM Changeset in webkit [67234] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-09-10 Adam Barth <​abarth@webkit.org>

Chromium build fix (one hopes!)

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):
2:25 PM Changeset in webkit [67233] by abarth@webkit.org
  • 7 edits in trunk

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
​https://bugs.webkit.org/show_bug.cgi?id=41371

Drop support for closing comments with "-- >". This was an attempt to
be more IE-like in comment parsing, but it turns out to cause problems
for some high-profile sites. Firefox 4 is dropping support as well.
We expect the spec to change soon too.

  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/parser/HTMLTokenizer.h:

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
​https://bugs.webkit.org/show_bug.cgi?id=41371

Update test results for new behavior.

  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html:
    • Removed the redundant in-test expectations.
  • html5lib/runner-expected.txt:
    • We now "fail" these two tests. We'll pass them again once the spec changes and HTML5lib updates its expectations.
2:22 PM Changeset in webkit [67232] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2010-09-10 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

compositing/iframes/iframe-src-change.html test fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=45554

This test had the wrong behavior. It never actually entered compositing mode.
Now give it a chance to do so (and test for it), and then test that the layers
disappeared.

  • compositing/iframes/iframe-src-change-expected.txt:
  • compositing/iframes/iframe-src-change.html:
2:10 PM Changeset in webkit [67231] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Restored a Changelog entry for a change that was reverted. I mistakenly thought reverted changes should be removed.

2:04 PM Changeset in webkit [67230] by Adam Roben
  • 1 edit
    3 moves in trunk/LayoutTests

Give expected results files the right names

  • platform/win/fast/text/hyphenate-first-word-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-first-word-actual.txt.
  • platform/win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-locale-actual.txt.
  • platform/win/html5lib/runner-expected.txt: Renamed from LayoutTests/platform/win/html5lib/runner-actual.txt.
2:02 PM Changeset in webkit [67229] by cmarrin@apple.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-10 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Adding file that should have been in ​http://trac.webkit.org/changeset/67226 but
I forgot to svn add.


  • platform/graphics/opengl: Added.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Copied from platform/graphics/mac/GraphicsContext3DMac.mm.
1:56 PM Changeset in webkit [67228] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

one more typo fix in Changelog

1:54 PM Changeset in webkit [67227] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

fixed typo in Changelog

1:51 PM Changeset in webkit [67226] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

2010-09-10 Paul Sawaya <​psawaya@apple.com>

Reviewed by Chris Marr.

Refactored non-Mac specific code into GraphicsContext3DOpenGL.


Moving this file into platform/graphics/mac for now, and only building on Mac.


​https://bugs.webkit.org/show_bug.cgi?id=30625

1:28 PM Changeset in webkit [67225] by oliver@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

1:01 PM Changeset in webkit [67224] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove useless FrameLoader method
​https://bugs.webkit.org/show_bug.cgi?id=45492

This method has one caller, and that caller already has a more direct
way of accessing the correct DocumentLoader.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::addData):
12:54 PM Changeset in webkit [67223] by abarth@webkit.org
  • 24 edits in trunk

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

After the MainResourceLoader hands the bytes for the main resource to
the DocumentLoader, the DocumentLoader hands the bytes to the
FrameLoaderClient. The FrameLoaderClient, in turn, returns the bytes
to WebCore. Prior to this patch, the FrameLoaderClient returned the
bytes to the FrameLoader. However, the FrameLoader was actually adding
any value.

In this patch, we change the FrameLoaderClient to return the bytes to
the DocumentLoader directly. In a future patch, we'll cut out the
FrameLoaderClient middleman and handle the bytes internally in the
DocumentLoader.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::addData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

Also, removed comment about wrong code in the Mac port.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

Previously, we were checking the document for null. However, Frame can
never have a null document, so this check is no longer needed.

  • WebView/WebFrame.mm: (-[WebFrame _addData:]):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::receivedData):
12:52 PM Changeset in webkit [67222] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-09-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Speed up deserialisation of strings
​https://bugs.webkit.org/show_bug.cgi?id=45555

Rather than building a list of Identifiers for the string pool
we now build a list of a tuple of UString and JSString*. This
doesn't hurt the property name case as ustring->identifier conversion
is essentially free if the ustring has already been converted to
an Identifier, but saves an unnecessary Identifier creation for
strings we only ever use to create JSStrings. We also reduce
GC pressure for duplicate strings by caching the JSStrings.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedString::CachedString): (WebCore::CloneDeserializer::CachedString::jsString): (WebCore::CloneDeserializer::CachedString::ustring): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::putProperty): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
12:40 PM Changeset in webkit [67221] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=45525

The crash was caused by ancestorToRetainStructureAndAppearance not taking into consideration
the case where there is no common block ancestor. Fixed this by adding a null check.

Test: editing/pasteboard/copy-without-common-block-crash.html

  • editing/markup.cpp: (WebCore::ancestorToRetainStructureAndAppearance): Added a null check.

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=45525

Added a test to ensure WebKit does not crash when copying a region that doesn't have any common block ancestor.
Also removed doubleclick-inline-first-last-contenteditable.html from the qt's skipped list since
this test should not crash anymore.

  • editing/pasteboard/copy-without-common-block-crash-expected.txt: Added.
  • editing/pasteboard/copy-without-common-block-crash.html: Added.
  • platform/qt/Skipped: Removed doubleclick-inline-first-last-contenteditable.html from the list.
11:43 AM Changeset in webkit [67220] by kinuko@chromium.org
  • 4 edits in trunk/WebCore

2010-09-09 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Do not call EntriesCallback more than once if there're no entries.
​https://bugs.webkit.org/show_bug.cgi?id=45498

No new tests, layout-tests that confirm the behavior will be added in later patches.

  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::EntriesCallbacks): (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries):
11:34 AM Changeset in webkit [67219] by Chris Fleizach
  • 6 edits
    2 adds in trunk

WebCore: Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=45488

Patch by Patrick Gansterer <​paroga@paroga.com> on 2010-09-10
Reviewed by Darin Adler.

  • dom/XMLDocumentParserLibxml2.cpp:

(WebCore::toString):

LayoutTests: Land new expected results for some tests on Windows

Patch by Adam Roben <Adam Roben> on 2010-09-10
Rubber-stamped in advance by Simon Fraser.

  • platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
  • platform/win/fast/text/hyphenate-locale-actual.txt: Added.

Windows doesn't support hyphenation.

  • platform/win/html5lib/runner-actual.txt: Added.

We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

11:31 AM Changeset in webkit [67218] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-10 Tony Chang <​tony@chromium.org>

Unreviewed, rolling out r67216.
​http://trac.webkit.org/changeset/67216
​https://bugs.webkit.org/show_bug.cgi?id=44709

Broke

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
11:21 AM Changeset in webkit [67217] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Land new expected results for some tests on Windows

Rubber-stamped in advance by Simon Fraser.

  • platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
  • platform/win/fast/text/hyphenate-locale-actual.txt: Added.

Windows doesn't support hyphenation.

  • platform/win/html5lib/runner-actual.txt: Added.

We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

11:10 AM Changeset in webkit [67216] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

deduplicate-tests should be runnable from any WebKit directory
​https://bugs.webkit.org/show_bug.cgi?id=44709

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
11:04 AM Changeset in webkit [67215] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-09-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Placement new / manual destructor invocation should be used on private GObject memory
​https://bugs.webkit.org/show_bug.cgi?id=45550

GLib allocates and deallocates GObject private data structs itself. When
those structs contain C++ members, their constructors and destructors are not
called. This is not only dangerous, it makes RefPtr-type smart pointers much
less useful. We can fix this problem by calling placement new on the private
data struct during instance initialization and calling the destructor during
finalization.

This patch takes that approach and switches plain char* members of
WebKitWebView (with manual memory allocation) to use CString.

  • webkit/webkitprivate.h: Switch char* members to CString.
  • webkit/webkitwebview.cpp: (webkit_web_view_finalize): Manually call the destructor on the private data. Remove manual deallocation of members which are now CString. (webkit_web_view_query_tooltip): Update to reflect CString change. (webkit_web_view_init): Use placement new to initialize C++ members of the private data section. (webkit_web_view_get_encoding): Update to reflect CString change. (webkit_web_view_get_custom_encoding): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_set_tooltip_text): Ditto. (webkit_web_view_get_icon_uri): Ditto.
10:44 AM Changeset in webkit [67214] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=45488

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::toString):
10:39 AM Changeset in webkit [67213] by Joseph Pecoraro
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-09-09 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Andreas Kling.

Clean Up Some Expected Results for Missing Tests
​https://bugs.webkit.org/show_bug.cgi?id=45489

Test was removed in r35456 but expected results were missed.

  • http/tests/xmlhttprequest/access-control-basic-exclude-expected.txt: Removed.

Results were added in r19036 but the test was never added. No record of the test.

  • editing/pasteboard/4944770-expected.txt: Removed.
  • platform/mac/editing/pasteboard/4944770-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/4944770-expected.png: Removed.
10:29 AM BuildingOnWindows edited by Adam Roben
Simplify symbol path a bit (diff)
10:15 AM Changeset in webkit [67212] by Simon Fraser
  • 1 edit
    3 adds
    4 deletes in trunk/LayoutTests

2010-09-10 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Update Windows LayoutTest/compositing results
​https://bugs.webkit.org/show_bug.cgi?id=45323

Fix up some windows compositing test results.

  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Copied from LayoutTests/compositing/iframes/leave-compositing-iframe-expected.txt.
10:14 AM Changeset in webkit [67211] by kov@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-09-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] Google sites do not like WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=39617

Special-case Google domains, and spoof User-Agent when talking to
them, to stop being treated as a second-class citizen.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::initializeDomainsList): (WebKit::isGoogleDomain): (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks is enabled, send the standard WebKit User-Agent string, disregarding the custom one set by the browser for Google domains.
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkitPlatform): Fix style, and simplify. (webkitOSVersion): Ditto. (webkitUserAgent): Add the Version/x.y string Safari has been using since Safari 2.2.
9:49 AM Changeset in webkit [67210] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

2010-09-10 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] rebaseline SVGFEDiffuseLightingElement-lighting-color-css-prop.html
​https://bugs.webkit.org/show_bug.cgi?id=45540

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
9:38 AM Changeset in webkit [67209] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Mail crashes with searching for next misspelled word with VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=45501

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/crash-in-element-for-text-marker.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Check that the AX object is not nil before asking for the wrapper().

LayoutTests:

  • platform/mac/accessibility/crash-in-element-for-text-marker-expected.txt: Added.
  • platform/mac/accessibility/crash-in-element-for-text-marker.html: Added.
9:19 AM Changeset in webkit [67208] by commit-queue@webkit.org
  • 26 edits in trunk/WebCore

2010-09-10 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Decouple Blob from ScriptExecutionContext.
​https://bugs.webkit.org/show_bug.cgi?id=45410

  • Removed ScriptExecutionContext pointers from Blob and File constructors.
  • Removed ScriptExecutionContext's collection of Blobs instance in that context.
  • Refactored BlobURL to make a distinction between 'public' blob urls and 'internal' urls that are used solely as identifiers. The former requires a SecurityOrigin to to manufacture, the latter does not.
  • Added a constant and accessor for the blob protocol scheme on the BlobURL class.

No new tests are added since this is a cleanup.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal):
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Reader::readBlob): (WebCore::ZigZag::Reader::readFile): (WebCore::ZigZag::Reader::readFileList):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::createPublicBlobURL): (WebCore::ScriptExecutionContext::revokePublicBlobURL):
  • dom/ScriptExecutionContext.h:
  • fileapi/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::~Blob): (WebCore::Blob::slice):
  • fileapi/Blob.h: (WebCore::Blob::create): (WebCore::Blob::url):
  • fileapi/Blob.idl:
  • fileapi/BlobBuilder.cpp: (WebCore::BlobBuilder::getBlob):
  • fileapi/BlobBuilder.h:
  • fileapi/BlobBuilder.idl:
  • fileapi/BlobURL.cpp: (WebCore::BlobURL::createPublicURL): (WebCore::BlobURL::createInternalURL): (WebCore::BlobURL::getOrigin): (WebCore::BlobURL::getIdentifier): (WebCore::BlobURL::createBlobURL):
  • fileapi/BlobURL.h: (WebCore::BlobURL::blobProtocol): (WebCore::BlobURL::BlobURL):
  • fileapi/File.cpp: (WebCore::File::File):
  • fileapi/File.h: (WebCore::File::create):
  • fileapi/FileReader.cpp: Register a public url to perform the read. (WebCore::FileReader::cleanup): (WebCore::FileReader::start): (WebCore::FileReader::didFinishLoading): (WebCore::FileReader::failed):
  • fileapi/FileReader.h: Added m_urlForReading data member.
  • fileapi/FileReaderSync.cpp: (WebCore::FileReaderSync::read): Register a public url to perform the read.
  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerBlobURL): (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
  • fileapi/ThreadableBlobRegistry.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • page/SecurityOrigin.cpp: Use BlobURL.blobProtocol(). (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::canDisplay):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
9:16 AM Changeset in webkit [67207] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

GDK_DISPLAY was removed in GTK+ 3.x, re-declare it when built
against that.

  • platform/gtk/GtkVersioning.h:
9:16 AM Changeset in webkit [67206] by xan@webkit.org
  • 5 edits in trunk

WebCore:

2010-09-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix compilation with GTK+ 3.x.

GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
to include the compat header provided if we want to keep using the
old names.

  • platform/gtk/GtkVersioning.h: add the compatibility header.
  • platform/gtk/KeyEventGtk.cpp: include GtkVersioning.h

WebKit/gtk:

2010-09-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix compilation with GTK+ 3.x.

GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
to include the compat header provided if we want to keep using the
old names.

  • WebCoreSupport/FullscreenVideoController.cpp: include GtkVersioning.h
9:13 AM Changeset in webkit [67205] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a few media tests that started randomly failing after r66961

Reviewed by Eric Carlson.

  • platform/mac-leopard/Skipped:
9:03 AM Changeset in webkit [67204] by tonyg@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2010-09-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Factor out the NestingLevelIncrementer
​https://bugs.webkit.org/show_bug.cgi?id=45471

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp:
  • html/parser/NestingLevelIncrementer.h: Added. (WebCore::NestingLevelIncrementer::NestingLevelIncrementer): (WebCore::NestingLevelIncrementer::~NestingLevelIncrementer):
9:02 AM Changeset in webkit [67203] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-09-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix wrong gtk baseline for select-x-list-1.svg.

  • platform/gtk/svg/text/select-x-list-1-expected.txt:
8:50 AM Changeset in webkit [67202] by Adam Roben
  • 2 edits in trunk/WebKit2

Don't crash when a frame is destroyed after the UI process has disconnected

Fixes <​http://webkit.org/b/45535> <rdar://problem/8412928> Crash in
WebProcess::removeWebFrame on exit with WebKit2 (Release builds only)

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::removeWebFrame): Null-check m_connection before
dereferencing it.

8:47 AM Changeset in webkit [67201] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-09-10 Martin Robinson <​mrobinson@igalia.com>

Slight skipped list reorganization.

  • platform/gtk/Skipped: Group one more test in the beginDragWithFiles section.
8:35 AM Changeset in webkit [67200] by Nikolas Zimmermann
  • 65 edits
    5 adds in trunk

2010-09-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG text chunk concept needs to be integrated in the InlineBox structure
​https://bugs.webkit.org/show_bug.cgi?id=45533

Begin rewriting the SVG text layout code. As first step move the text chunk concept right into the inline box structure.
This obsoletes the whole text chunk part concept (see SVGTextChunkLayoutInfo.h for details), and will soon simplify the
whole layout code a lot. Previously we hacked around the fact that a single InlineTextBox could contain multiple text chunks
For example: <text x="20 30 40">ABC</text> only led to the creation of one InlineTextBox containing three chunks. When
painting such an InlineTextBox, we had to do nasty hacks (same for text selection etc.)


This is finally fixed by incorporating the knownledge about text chunks into the line layout algorithm.
Note, this has no impact on HTML at all, no worries.

It's even required to do it this way as BiDi reordering shouldn't happen across text chunks.
These are only the first bits, and currently slows down text layouting. Follow-up patches will remove the old layout
algorithm, and will rely on the stored SVGTextLayoutAttributes in the RenerSVGInlineText renderers (instead of computing again).

  • Android.mk: Add rendering/svg/SVGTextLayoutAttributes.* & rendering/svg/SVGTextLayoutBuilder.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gyp/WebCore.gyp: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto. (Recognize new rendering/svg directory.)
  • WebCore.vcproj/copyForwardingHeaders.cmd: Ditto. (Copy forwarding headers from rendering/svg directory.)
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderBlockLineLayout.cpp: This is the key of the new concept, take text chunks into account when building the InlineBox structure. (WebCore::RenderBlock::findNextLineBreak): Split midpointState, if we encounter the beginning of a new text chunk.
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGInline): New method, which will be used to identify RenderSVGInline objects.
  • rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::isSVGInline): Return true.
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::linesBoundingBox): Overriden, to simplify the calculations for SVG. (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Determines wheter the given position starts a new text chunk.
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::storeLayoutAttributes): Stores the layout attributes calculated in the text layout process (will be used everywhere in follow-up patches).
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Invoke SVGTextLayoutBuilder before creating the inline box tree, so we can decide which characters start new text chunks.
  • rendering/RenderText.h: Made linesBoundingBox() virtual so RenderSVGInlineText can override it.
  • rendering/svg: Added.
  • rendering/svg/SVGTextLayoutAttributes.cpp: Added. Holds x/y/dx/dy/rotate values and all kerning/ligature information used during layout.
  • rendering/svg/SVGTextLayoutAttributes.h: Added.
  • rendering/svg/SVGTextLayoutBuilder.cpp: Added.
  • rendering/svg/SVGTextLayoutBuilder.h: Added.

2010-09-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG text chunk concept needs to be integrated in the InlineBox structure
​https://bugs.webkit.org/show_bug.cgi?id=45533

Updated all tests containing text chunks, to reflect the fact that more SVGInlineTextBoxes are created now.
All 'startOffset' dumps now begin at 0, indicating that there's only one chunk contained in a single SVGInlineTextBox.
These dumps will be removed in follow-up patches, as they don't make any sense anymore in the new concept.

  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/custom/text-letter-spacing-expected.txt:
  • platform/mac/svg/custom/text-x-dx-lists-expected.txt:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
7:41 AM Changeset in webkit [67199] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed fix after r67085.

  • WebCore.pro: Fix previously moved filenames.
7:30 AM Changeset in webkit [67198] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Inline FrameLoader::committedLoad into its one caller
​https://bugs.webkit.org/show_bug.cgi?id=45481

This saves one round-trip through the FrameLoader when loading
documents.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
7:05 AM Changeset in webkit [67197] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Remove ImageBuffer::toDataURL implementation
​https://bugs.webkit.org/show_bug.cgi?id=45478

At the moment ImageBuffer::toDataURL uses JPEGEncoder.h and PNGEncoder.h.
Both files are not in the repository. So remove the implementation for now.

  • platform/graphics/wince/ImageBufferWince.cpp: (WebCore::ImageBuffer::toDataURL):
6:44 AM Changeset in webkit [67196] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Anton Muhin <​antonm@chromium.org>

Unreview fixed.

Remove duplicate test expectations for media/media-can-play-mpeg4-video.html.

6:36 AM Changeset in webkit [67195] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix.

  • inspector/elements-panel-rewrite-href.html:
5:54 AM Changeset in webkit [67194] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-10 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

WebGL: Fix GCC warnings about suggested parentheses around && within

​https://bugs.webkit.org/show_bug.cgi?id=45534

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::handleNPOTTextures):
5:50 AM Changeset in webkit [67193] by hans@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Un-skip DeviceOrientation layout tests for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45531

fast/dom/DeviceOrientation/window-property.html and
fast/dom/Window/window-properties-device-orientation.html need to be
rebaselined, which will be done in a subsequent patch.

  • platform/chromium/test_expectations.txt:
5:28 AM Changeset in webkit [67192] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Anton Muhin <​antonm@chromium.org>

Reviewed by Kent Tamura.

[Chromium] media/media-can-play-mpeg4-video.html fails under Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45102

Chromium is not going to support mpeg, so media/media-can-play-mpeg4-video.html
is expected to fail.

  • platform/chromium/test_expectations.txt:
5:08 AM Changeset in webkit [67191] by apavlov@chromium.org
  • 6 edits in trunk/WebCore

2010-09-09 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add navigation items into the Elements panel context menu.

For all anchors that have the class of "webkit-html-resource-link" or "webkit-html-external-link",
a custom context menu with the items "Open Link in New Window" (invokes InspectorBackend.openInInspectedWindow() with
the related URL) and "Open Link in Resources Panel" (opens the related resource in the Resources panel) is shown
(the latter item is displayed only if the corresponding resource is known to the Web Inspector).
​https://bugs.webkit.org/show_bug.cgi?id=34250

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype._attributeHTML):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
  • inspector/front-end/inspector.js: (WebInspector.openResource): (WebInspector.resourceURLForRelatedNode):
5:01 AM Changeset in webkit [67190] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2010-09-10 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Unskip canvas/philip/tests/2d.text.draw.fontface.repeat.html

This test was fixed by <​http://trac.webkit.org/changeset/62016>

  • platform/qt/Skipped:
4:48 AM Changeset in webkit [67189] by zherczeg@webkit.org
  • 5 edits in trunk/LayoutTests

An individual renderer should be assigned to each SVGFE*Element class
​https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Nikolas Zimmermann.

Updating the description of the following test (it does not fail anymore):

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-lighting-color-css-prop.js:
4:36 AM Changeset in webkit [67188] by Darin Adler
  • 2 edits in trunk/WebKit/chromium

2010-09-08 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions from Frame to Editor as planned
​https://bugs.webkit.org/show_bug.cgi?id=45218

  • src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::scopeStringMatches):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds): Changed call sites to use editor().
3:57 AM Changeset in webkit [67187] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-09-10 Kwang Yul Seo <​skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
​https://bugs.webkit.org/show_bug.cgi?id=39672

Move Image::loadPlatformResource to platform/graphics/chromium/ImageChromium.cpp.
Other ports can use ImageSkia.cpp.

No new tests because this is pure refacotring.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/ImageChromium.cpp: Added. (WebCore::Image::loadPlatformResource):
  • platform/graphics/skia/ImageSkia.cpp:
3:31 AM Changeset in webkit [67186] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. expectations update.

fast/dom/replaceChild.html image failure.

  • platform/chromium/test_expectations.txt:
3:18 AM Changeset in webkit [67185] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-09-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Joseph Pecoraro.

WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.

  1. Open any page
  2. Right-click on any element, select "Inspect Element"
  3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
  4. Inspect the Web Inspector. An error message is logged in the console.

The regression was introduced in ​http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).

​https://bugs.webkit.org/show_bug.cgi?id=45374

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
3:04 AM Changeset in webkit [67184] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-10 Cris Neckar <​cdn@chromium.org>

Reviewed by Chris Fleizach.

Test for null deref in RenderBlock::updateFirstLetter().
​https://bugs.webkit.org/show_bug.cgi?id=45404

  • fast/dom/firstletter-tablecell-crash-expected.txt: Added.
  • fast/dom/firstletter-tablecell-crash.html: Added.

2010-09-10 Cris Neckar <​cdn@chromium.org>

Reviewed by Chris Fleizach.

Null deref in RenderBlock::updateFirstLetter(). Check for null psuedo style.
​https://bugs.webkit.org/show_bug.cgi?id=45404

Test: fast/dom/firstletter-tablecell-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
2:45 AM Changeset in webkit [67183] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-10 Cris Neckar <​cdn@chromium.org>

Reviewed by Chris Fleizach.

Test for null deref in RenderBlock::findNextLineBreak().
​https://bugs.webkit.org/show_bug.cgi?id=45350

  • fast/dom/firstline-fixed-crash-expected.txt: Added.
  • fast/dom/firstline-fixed-crash.html: Added.

2010-09-10 Cris Neckar <​cdn@chromium.org>

Reviewed by Chris Fleizach.

Null deref in RenderBlock::findNextLineBreak(). Check for null style with
first-line style and fixed position.
​https://bugs.webkit.org/show_bug.cgi?id=45350

Test: fast/dom/firstline-fixed-crash.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
2:12 AM Changeset in webkit [67182] by eric@webkit.org
  • 11 edits in trunk

2010-09-10 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
​https://bugs.webkit.org/show_bug.cgi?id=45365

  • fast/dom/beforeload/remove-frame-in-beforeload-listener.html:
    • Add a comment to make clear that this test intentionally does not cancel the load in the beforeload event, but rather relies on WebCore's own Node::willRemove() implementation to cancel the load when the frame is removed. (The load is not actually directly canceled per say, but the loading logic checks to see if the frame is still in the frame tree right after creating the frame and aborts if its not. HTMLFrameOwnerElement::willRemove clears the frame owner pointer causing the frame to be removed from the tree.)

2010-09-10 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
​https://bugs.webkit.org/show_bug.cgi?id=45365

This change is the last piece of the puzzle which was preventing us from
removing all eager-attach logic and moving WebCore to using an entirely
recalcStyle-driven, on-demand renderer creation system, instead of every
element being synchronously attached during parsing, regardless of whether
it was ever going to be displayed or not.

This does not change the places we call lazyAttach vs. attach. This only
changes the behavior of frame/plugin elements when lazyAttach is called.
Previously lazyAttach would eager-attach those elements (and their ancestors)
because they were marked as canLazyAttach() { return false; }.

This is a very tricky change, please review carefully.

Mostly I'm moving logic which used to be in attach() into
insertedIntoDocument. Once it was there, there was no longer any reason
why frame elements couldn't lazyAttach, thus removing the need
for the non-lazy attach code path entirely.
We've not yet converted all callsites over to using lazyAttach() instead
of attach() however.

In order to move frame loading logic into insertedIntoDocument
instead of attach, I needed to make sure that any javascript calls
during the load would see an attached element. Thus I needed to mark
the element as needing style resolve so that it would attach itself
if needed.

I was not able to just call lazyAttach() from insertedIntoDocument directly
due to two conflicting assumptions in the rendering tree:

  1. ContainerNode::attach() assumes its "safe" to call attach on all children without checking first if the child is already attached. This seems sane since its strange to think of a subtree as being attached w/o ancestors already being attached. Although it is a hard rule that subtrees may not have renderers w/o ancestors also having renderers, I do not believe it's a hard rule that subtrees may not be attached. Remember, attached() does not imply renderer()! It's possible ContainerNode::attach()'s assumption is wrong here.
  2. Node::attach() asserts !attached(). This makes sense and I would not want to remove this assert, however it means that if insertedIntoDocument were to call lazyAttach() (thus marking the element as attached()) then all callers would need to check if the element was already attached after insertedIntoDocument (called by appendChild, parserAppendChild, etc.) before calling attach or lazyAttach(). The following example: element.innerHTML = "<span><iframe></span>" is one case where this ASSERT would be hit if insertedIntoDocument called lazyAttach, since ContainerNode::attach() (called on the span by in appendChild(DocumentFragment) code) does not check if iframe is already attached.

Note: One subtle change here is that synchronous javascript which results
from javascript: or beforeload is now run as part of insertedIntoDocument
(thus any insert/append call *even* parserAddChild) instead of being
run during attach (technically in the post-attach callbacks).

This is covered by numerous layout tests.

  • dom/ContainerNode.cpp: (WebCore::willRemoveChild): (WebCore::willRemoveChildren):
    • Since insertedIntoDocument starts a load and yet does not mark the element as attached, we need to always call willRemove(). See note above as to why we don't just mark attached() in insertedIntoDocument.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):
    • Share some code between lazyAttach and setNeedsStyleRecalc.

(WebCore::Node::setNeedsStyleRecalc):

  • Use the new markAncestorsWithChildNeedsStyleRecalc

(WebCore::Node::lazyAttach):

  • Remove the non-lazy code path, and use markAncestorsWithChildNeedsStyleRecalc.
  • Add an option to lazyAttach without marking attached(), used by HTMLFrameElementBase::insertedIntoDocument.
  • dom/Node.h:
  • html/HTMLFrameElementBase.cpp:
    • m_shouldOpenURLAfterAttach is no longer needed, yay!
    • m_checkAttachedTimer no longer has anything to do with attached(), so renamed it. I also documented that the newly named m_checkInDocumentTimer is all about the "magic iframe" performance quirk. (Which is actually speced in HTML5). I was initially baffled by this code, so I documented it.

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase)
(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • This is the meat of this change, see discussion above.

(WebCore::HTMLFrameElementBase::attach):

  • Code deleted or moved to insertedIntoDocument.

(WebCore::HTMLFrameElementBase::width):

  • Fixed a bug in height()/width() which was probably causing crashes and was causing incorrect behavior after this change. renderBox() is not necessarily valid unless layout is up to date. Updating layout, can cause renderBox() to go invalid, thus this could have been a null-pointer crash.

(WebCore::HTMLFrameElementBase::height): see width()
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Timer rename.
(WebCore::HTMLFrameElementBase::checkInDocumentTimerFired): Timer rename.

  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
    • Disconnecting the owner element removes the frame from the frame tree. frameDetached() calls Page::frameCount which expects that the frame is already gone at this point and asserts when it's not. It's unclear how this worked before, except that the frame removal was likely done in the post-attach callback, so the frameCount was wrong (too high) during frameDetached(), but was fixed up in the post-detach callback.
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attachAtSite):
    • Simplified this code, and added a check for the case when the node was already removed. Since the load logic is now run during insertedIntoDocument instead of attach(), synchronous javascript is now running during insertedIntoDocument and we need to make sure that the child is still in the tree.
2:04 AM Changeset in webkit [67181] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add some comments and sort.
1:16 AM Changeset in webkit [67180] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added editing/selection/doubleclick-inline-first-last-contenteditable.html to the qt's skipped list.
See ​https://bugs.webkit.org/show_bug.cgi?id=45525 for the detail.

  • platform/qt/Skipped:
12:48 AM Changeset in webkit [67179] by dpranke@chromium.org
  • 8 edits in trunk

2010-09-10 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, rolling out r67178.
​http://trac.webkit.org/changeset/67178
​https://bugs.webkit.org/show_bug.cgi?id=45524

re-roll-out patch to put original changes back in

  • fast/replaced/object-param-url-control-char.html:
  • fast/replaced/object-with-embed-url-param-expected.txt:
  • fast/replaced/object-with-embed-url-param.html:

2010-09-10 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, rolling out r67178.
​http://trac.webkit.org/changeset/67178
​https://bugs.webkit.org/show_bug.cgi?id=45524

re-roll-out patch to put original changes back in

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::updateWidget):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin):
  • loader/SubframeLoader.h:
12:45 AM Changeset in webkit [67178] by dpranke@chromium.org
  • 8 edits in trunk

2010-09-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Kent Tamura.

roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
​https://bugs.webkit.org/show_bug.cgi?id=45524

  • fast/replaced/object-param-url-control-char.html:
  • fast/replaced/object-with-embed-url-param-expected.txt:
  • fast/replaced/object-with-embed-url-param.html:

2010-09-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Kent Tamura.

roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
​https://bugs.webkit.org/show_bug.cgi?id=45524

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::updateWidget):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestFrame):
  • loader/SubframeLoader.h:
12:16 AM Changeset in webkit [67177] by hans@chromium.org
  • 5 edits in trunk/WebKitTools

2010-09-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=45460

This enables DumpRenderTree to run layout tests for DeviceOrientation.

Also declare the LayoutTestController destructor out-of-line.
Otherwise the implicit destructor would cause compiler errors because
of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::~LayoutTestController): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClient):
  • DumpRenderTree/chromium/WebViewHost.h:
12:13 AM Changeset in webkit [67176] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Extract the code to find special ancestors in createMarkup into a function
​https://bugs.webkit.org/show_bug.cgi?id=45449

Extracted the code to find special common ancestors in createMarkup as highestAncestorToWrapMarkup.
Also isolated the code to find ancestors required to retain structure and appearance into
ancestorToRetainStructureAndAppearance.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::ancestorToRetainStructureAndAppearance): Added. (WebCore::propertyMissingOrEqualToNone): Moved. (WebCore::isElementPresentational): Moved. (WebCore::shouldIncludeWrapperForFullySelectedRoot): Added. isSpecialAncestorBlock is merged into this function. (WebCore::highestAncestorToWrapMarkup): Extracted from createMarkup. (WebCore::createMarkup): Calls highestAncestorToWrapMarkup.
12:03 AM Changeset in webkit [67175] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-10 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added editing/spelling/spelling-backspace-between-lines.html to the skipped list for WebKit2
since the test uses textInputController, which hasn't been implemented yet in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.