⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2010:

11:43 PM Changeset in webkit [67366] by abarth@webkit.org
  • 3 edits
    8 adds in trunk

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
​https://bugs.webkit.org/show_bug.cgi?id=45634

Add tests recommended by Hixie.

  • fast/parser/form-pointer-1-expected.txt: Added.
  • fast/parser/form-pointer-1.html: Added.
  • fast/parser/form-pointer-2-expected.txt: Added.
  • fast/parser/form-pointer-2.html: Added.
  • fast/parser/form-pointer-3-expected.txt: Added.
  • fast/parser/form-pointer-3.html: Added.
  • fast/parser/form-pointer-4-expected.txt: Added.
  • fast/parser/form-pointer-4.html: Added.

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
​https://bugs.webkit.org/show_bug.cgi?id=45634

The spec changed to say what we do here so this FIXME isn't needed
anymore.

Tests: fast/parser/form-pointer-1.html

fast/parser/form-pointer-2.html
fast/parser/form-pointer-3.html
fast/parser/form-pointer-4.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
11:24 PM Changeset in webkit [67365] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk

2010-09-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

​https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

  • scrollbars/resources/scrollable-iframe.html: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-expected.txt: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-wheel-expected.txt: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-wheel.html: Added.
  • scrollbars/scrollevent-iframe-no-scrolling.html: Added.

2010-09-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

​https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html

scrollbars/scrollevent-iframe-no-scrolling.html

  • page/FrameView.cpp: (WebCore::FrameView::valueChanged): Added.
  • page/FrameView.h: Added a new method.
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged): Added. (WebCore::ScrollView::updateScrollbars):
  • platform/ScrollView.h: Added a new method.
10:45 PM Changeset in webkit [67364] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-09-12 Adam Barth <​abarth@webkit.org>

Revert mistaken changes to test baselines.

  • platform/mac/http/tests/navigation/post-goback1-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
9:21 PM Changeset in webkit [67363] by tkent@chromium.org
  • 6 edits in trunk

2010-09-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
​https://bugs.webkit.org/show_bug.cgi?id=45517

  • DEPS: Roll Chromium revision to r59033 to have webkit_support_gfx.h.
  • WebKit.gyp:

2010-09-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
​https://bugs.webkit.org/show_bug.cgi?id=45517

Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): (Image::createFromFilename): (diffImages):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
9:21 PM Changeset in webkit [67362] by morrita@google.com
  • 15 edits in trunk

2010-09-10 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45441

Add an note for API readiness.

  • platform/chromium/test_expectations.txt:

2010-09-10 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45441

Added an API for testing marker state.
We locate this here instead of DRT for sharing the logic between
multiple ports.

  • WebCore.exp.in:
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasSpellingMarkerFor):
  • editing/Editor.h:

2010-09-10 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45441

Exported Frame::selectionStartHasSpellingMarkerFor() for DRT use.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
  • src/WebFrameImpl.h:

2010-09-10 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45441

Moved the actual logic of hasSpellingMarker into WebCore to share
it with other ports.

  • WebView/WebFrame.mm: (-[WebFrame hasSpellingMarker:length:]):

2010-09-10 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45441

Added TextInputController::hasSpellingMarker().

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::hasSpellingMarker):
  • DumpRenderTree/chromium/TextInputController.h:
8:30 PM Changeset in webkit [67361] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Think this is the last set.

  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [67360] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Suppress some more failures so I can triage the WebKit roll
without the tree being red.

  • platform/chromium/test_expectations.txt:
7:39 PM Changeset in webkit [67359] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Suppress some failures so I can
triage the WebKit roll without the tree being red.

  • platform/chromium/test_expectations.txt:
6:09 PM Changeset in webkit [67358] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Fix a duplicate expectation and
remove some passing tests.

  • platform/chromium/test_expectations.txt:
6:04 PM Changeset in webkit [67357] by abarth@webkit.org
  • 10 edits in trunk

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
​https://bugs.webkit.org/show_bug.cgi?id=45570

Before this patch, we were using an unsafe pattern of walking the
sibling list without grabbing references. Instead, we should use the
shiny new takeAllChildrenFrom method that shoves the children into a
vector first. Also, update takeAllChildrenFrom to handle the case
where the old parent is attached.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
  • html/parser/HTMLTreeBuilder.h:

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
​https://bugs.webkit.org/show_bug.cgi?id=45570

More test cases.

  • html5lib/resources/webkit01.dat:
5:42 PM Changeset in webkit [67356] by abarth@webkit.org
  • 5 edits in trunk

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=45621

Add new tests and (minor) test progression.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected.txt:

2010-09-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=45621

Update our list of special tags to match the spec.

  • html/parser/HTMLTreeBuilder.cpp:
5:19 PM Changeset in webkit [67355] by robert@webkit.org
  • 5 edits in trunk

2010-09-12 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

Unskip http/tests/navigation/reload-subframe-object.html

​https://bugs.webkit.org/show_bug.cgi?id=45613

  • platform/qt/Skipped:

2010-09-12 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

We need to bring our use of getMimeTypeForPath() and
getMimeTypeForExtension() into line with WebCore expectations.

We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
where an empty mimetype should be returned if no match is found, and
MIMETypeRegistry::getMIMETypeForPath() for cases where
'application/octet-stream' should be returned if no match is found.

Fixes http/tests/navigation/reload-subframe-object.html

Based on findings in webkit.org/b/31398 and webkit.org/b/15554.

​https://bugs.webkit.org/show_bug.cgi?id=45613

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
5:02 PM Changeset in webkit [67354] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by James Robinson.

Remove some tests from the WebKit2 skipped list that are now passing
​https://bugs.webkit.org/show_bug.cgi?id=45625

  • platform/mac-wk2/Skipped:
4:40 PM Changeset in webkit [67353] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
4:37 PM Changeset in webkit [67352] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

My last change accidentally contained a local change to the
rebaselinig script; webkit-patch land picked it up without telling
me and committed it :(

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4:34 PM Changeset in webkit [67351] by dpranke@chromium.org
  • 3 edits in trunk

2010-09-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
4:04 PM Changeset in webkit [67350] by mitz@apple.com
  • 2 edits in trunk/WebCore

Neglect unlikely hyphenation opportunities
​https://bugs.webkit.org/show_bug.cgi?id=45606

Reviewed by Adele Peterson.

Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about
3% of the hyphenation opportunities.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more
than 5/4 the font size.

3:58 PM Changeset in webkit [67349] by jamesr@google.com
  • 5 edits
    16 adds
    3 deletes in trunk/LayoutTests

2010-09-12 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r67328.
​http://trac.webkit.org/changeset/67328
​https://bugs.webkit.org/show_bug.cgi?id=45610

Broke layout tests on mac and chromium.

  • http/tests/navigation/post-basic-expected.txt: Removed.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Removed.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/page-that-posts.html: Removed.
  • http/tests/navigation/resources/postresult.pl:
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Added.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Added.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.checksum.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.png.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Added.
2:19 PM Changeset in webkit [67348] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

doc: Changed the title so lists of contents sort better.

Patch by Martin Smith <​martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
2:08 PM Changeset in webkit [67347] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: More work on the QML documentation.

Patch by David Boddie <​david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
1:58 PM Changeset in webkit [67346] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qml] Ensure WebView gets focus when an editable node is clicked on.

Patch by Martin Jones <​martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-13342

  • declarative/qdeclarativewebview.cpp:

(GraphicsWebView::mousePressEvent):

1:56 PM Changeset in webkit [67345] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: qdoc fixes.

Patch by David Boddie <​david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
1:53 PM Changeset in webkit [67344] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] fix qt_webkit_version.pri install for in-Qt builds

Patch by Oswald Buddenhagen <​oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.

Task-number: QTBUG-13306

  • WebCore.pro:
1:50 PM Changeset in webkit [67343] by Simon Hausmann
  • 4 edits in trunk

WebCore: [Qt] Let QtWebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <​oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.

Task-number: QTBUG-12379

  • WebCore.pro:

WebKit/qt: [Qt] let WebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <​oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-12379

  • qt_webkit_version.pri: Use the faster + instead of *

operator to add webkit to the config.

1:44 PM Changeset in webkit [67342] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix group of declarative web view in QML docs.

Patch by Martin Smith <​martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
12:08 PM Changeset in webkit [67341] by Simon Hausmann
  • 5 edits in trunk/LayoutTests

[Qt] Rebase a bunch of tests after r67200.

Reviewed by Antonio Gomes.

  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
11:40 AM Changeset in webkit [67340] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Build fix.

  • WebCore.pro: Re-add erroneously removed sources.
11:35 AM Changeset in webkit [67339] by andreas.kling@nokia.com
  • 6 edits in trunk

2010-09-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
​https://bugs.webkit.org/show_bug.cgi?id=45618

Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG
paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
  • platform/graphics/Path.h:
  • platform/graphics/qt/PathQt.cpp:

2010-09-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
​https://bugs.webkit.org/show_bug.cgi?id=45618

Skip fast/canvas/canvas-closePath-single-point.html - it can be unskipped again
once the bot is upgraded to Qt 4.7.1.

  • platform/qt/Skipped:
11:32 AM Changeset in webkit [67338] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Gtk and minimal builds.

  • plugins/PluginView.cpp:

(WebCore::PluginView::npObject): Correct the #ifdefs.
(WebCore::PluginView::bindingInstance): Moved npErr variable
into npObject() function where it is used.

11:28 AM Changeset in webkit [67337] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Prospective build fix for minimal build.

  • plugins/PluginView.cpp: Guard newly added function

by ENABLE_NETSCAPE_PLUGIN feature.
(WebCore::PluginView::npObject):

  • plugins/PluginView.h:
11:21 AM Changeset in webkit [67336] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[Qt] Partial implementation of Qt bridge using V8 and QtScript.

Reviewed by Andreas Kling.

  • Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript): Stub it out for now,
to compile, until we have a conversion path between v8::Object
and QScriptValue.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject): Implemented using
few lines of QtScript code.
(QWebFrame::evaluateJavaScript): Ditto.

11:19 AM Changeset in webkit [67335] by Simon Hausmann
  • 4 edits
    1 add in trunk/WebCore

[Qt] Add support for binding QtWebKit to a QScriptEngine.

Reviewed by Andreas Kling.

The ScriptController owns the V8 context, and this patch
for the Qt build also gives it a QScriptEngine, that has
been instructed to adopt the V8 context.

This is the enabler for the QObject bindings, used in
the API and DRT.

  • WebCore.pro:
  • bindings/v8/ScriptController.cpp: Include QScriptEngine

for the Qt build, to let the ~ScriptController destructor
find the QScriptEngine destructor (via OwnPtr).

  • bindings/v8/ScriptController.h: Declare getters.
  • bindings/v8/ScriptControllerQt.cpp: Added.

(WebCore::ScriptController::qtScriptEngine): Implement
engine adoption.

11:15 AM Changeset in webkit [67334] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Last bits and pieces for a V8 build.

Reviewed by Andreas Kling.

When building with V8, get it from QtScript.

  • WebCore.pro: Use QtScript, removed non-existant

bridge files from the build.

11:12 AM Changeset in webkit [67333] by Simon Hausmann
  • 4 edits
    2 adds in trunk/WebCore

[Qt] Add PlatformBridge for V8 build.

Reviewed by Andreas Kling.

Add the minimalisting platform bridge with the two
methods needed by NPV8Object.cpp.

  • WebCore.pro:
  • platform/qt/PlatformBridge.h: Added.
  • platform/qt/PlatformBridgeQt.cpp: Added.

(WebCore::PlatformBridge::popupsAllowed):
(WebCore::PlatformBridge::pluginScriptableObject):

  • plugins/PluginView.cpp: Refactor the plugin object

retrieval code into a separate function, called by
bindingInstance() and PlatformBridge.
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):

  • plugins/PluginView.h:
11:08 AM Changeset in webkit [67332] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix the build with V8.

Reviewed by Andreas Kling.

This is a temporary kludge until the scriptworld stuff is properly
ported, as part of the upcoming DRT work.

  • Api/qwebscriptworld.cpp:

(QWebScriptWorld::QWebScriptWorld):

11:08 AM Changeset in webkit [67331] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

This changes brings the file in sync with its copy in bridge/,
adding additional conflicting X11 keywords to undef. This is
a temporary fix until the file is removed altogether, which is
tracked in ​https://bugs.webkit.org/show_bug.cgi?id=45617

  • bindings/v8/npruntime_internal.h:
10:38 AM Changeset in webkit [67330] by jer.noble@apple.com
  • 4 edits in trunk/WebCore

2010-09-11 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

http/tests/media/text-served-as-text.html failing on Windows (Debug+Release)
​https://bugs.webkit.org/show_bug.cgi?id=45603

Disable the eat/text components under Windows the same way as we do on the Mac.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/QTMovie.cpp:
  • platform/graphics/win/QTMovie.h:
9:57 AM Changeset in webkit [67329] by Simon Hausmann
  • 4 edits in trunk/WebCore

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

These headers include npruntime, which drag on X11Resources.h, which
among other things #define's None and Boolean. Later on v8.h is included,
which declares these in enums and therefore conflicts. npruntime_internal.h
was introduced exactly to address this problem by including npruntime.h
and undeff'ing the offending constants.

  • bindings/v8/V8Helpers.h:
  • bindings/v8/V8NPObject.h:
  • bindings/v8/V8NPUtils.h:
8:11 AM Changeset in webkit [67328] by Dimitri Glazkov
  • 5 edits
    3 adds
    16 deletes in trunk/LayoutTests

2010-09-12 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=45610

post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.

  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/page-that-posts.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
7:47 AM Changeset in webkit [67327] by Simon Hausmann
  • 2 edits in trunk/WebCore

Gtk build fix.

Use false instead of False after
​http://trac.webkit.org/changeset/67323

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):

7:28 AM Changeset in webkit [67326] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.

Reviewed by Andreas Kling.

  • bindings/v8/V8Binding.cpp:

(WebCore::WebCoreStringResource::WebCoreStringResource): In this
line an AtomicString should be converted to a WTF::String. The former
has a conversion operator to the latter, to be able to call the
WTF::String copy constructor. When compiling with Qt, then AtomicString
also has a conversion operator to QString _and_ WTF::String has an
implicit constructor that takes a QString. Therefore the compiler is
confused and not sure which conversion to prefer, the one that isn't
actually a conversion - going to WTF::String - or the conversion from
AtomicString to QString and then constructing the WTF::String from
a QString. To resolve this ambiguity we explicitly call the string()
helper function on the AtomicString, which is equivalent to the
operator WTF::String().

6:57 AM Changeset in webkit [67325] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fix the build without JSC.

Reviewed by Andreas Kling.

Complement ​http://trac.webkit.org/changeset/59826 and
add missing JSC guards.

  • plugins/PluginView.cpp:

(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

6:57 AM Changeset in webkit [67324] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fix compilation with V8 and XPath enabled.

Reviewed by Andreas Kling.

V8XPathNSResolver.cpp includes V8XPathNSResolver.h,
which includes V8DOMWrapper.h as its first header.
V8DOMWrapper.h then uses V8XPathNSResolver in an inline
function, and gcc doesn't seem to like this, because
at this point the type isn't known ("V8XPathNSResolver
has not been declared"). Forward declaring the type
doesn't help unfortunately: "incomplete type
'WebCore::V8XPathNSResolver' used in nested name
specifier".

To resolve this circular dependency, this patch moves
the inline function into the .cpp file.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

  • bindings/v8/V8DOMWrapper.h:
6:33 AM Changeset in webkit [67323] by Simon Hausmann
  • 4 edits in trunk/WebCore

[Qt][X11] Fix build with V8 against X11 headers.

Reviewed by Andreas Kling.

Added "True" and "False" to the list of words
we free from the X11 macro jail.

  • bridge/npruntime_internal.h:
  • config.h: The V8 bindings end up indirectly pulling

in X11 headers and they use True/False. There's no
central header apart from this one, so include the
x11 fixing header here for Qt/X11/V8.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paint): Use false instead of False
since False isn't available anymore.

6:28 AM Changeset in webkit [67322] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix compilation with V8 and Qt.

Reviewed by Andreas Kling.

Use WebKit's page cache for ScriptCachedFrameData.

  • bindings/v8/ScriptCachedFrameData.h:
6:25 AM Changeset in webkit [67321] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix compiler warning.

Reviewed by Andreas Kling.

NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't
initialized explicitly.

  • bindings/v8/NPV8Object.cpp:
4:16 AM Changeset in webkit [67320] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-12 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] get_n_selections and get_selection fail when selecting text across object boundaries
​https://bugs.webkit.org/show_bug.cgi?id=26991

Fix AtkText getNSelections() and getSelection() to work properly

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): Check that both the selection intersects the node AND that the selection is not just "touching" one of the boundaries for the selected node. We want to check whether the node is actually inside the region, at least partially (getSelectionOffsetsForObject): New function to get the start and end offsets of a selection for a given accessible object. (webkit_accessible_text_get_selection): Return zero when both start and end offsets are equal, following the lead of GAIL.
12:37 AM Changeset in webkit [67319] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Animations don't seem to run in multiple WebKit2 animation tests
​https://bugs.webkit.org/show_bug.cgi?id=42137

  • platform/mac-wk2/Skipped: These tests no longer fail, so simply unskip them.

Sep 11, 2010:

11:37 PM Changeset in webkit [67318] by dbates@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-11 Daniel Bates <​dbates@rim.com>

Attempt to fix the Qt Linux Release build after changeset 67312 <​http://trac.webkit.org/changeset/67312>.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add missing ',' in WKPageUIClient initialization list.
9:58 PM Changeset in webkit [67317] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Attempt to fix Windows MiniBrowser build (untested)
​https://bugs.webkit.org/show_bug.cgi?id=45609

  • MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt):
7:28 PM Changeset in webkit [67316] by abarth@webkit.org
  • 21 edits in trunk

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

This function was secretly an instance function because callers needed
to pass in a document (which owns a SecurityOrigin). Only the
FrameLoader actually needs the method to be static.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
    • Notice that DocLoader::doc() can never be 0.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • page/SecurityOrigin.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::load):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):

2010-09-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
​https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
7:17 PM Changeset in webkit [67315] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Remove nonexistent test from skipped list
​https://bugs.webkit.org/show_bug.cgi?id=45608

  • platform/mac-wk2/Skipped:
7:15 PM Changeset in webkit [67314] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix zoom related tests when testing WebKit2.

Reviewed by Maciej Stachowiak.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.

7:08 PM Changeset in webkit [67313] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Skip some new tests that depend on APIs missing from WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=45607

  • platform/mac-wk2/Skipped:
6:50 PM Changeset in webkit [67312] by weinig@apple.com
  • 13 edits in trunk

Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
​https://bugs.webkit.org/show_bug.cgi?id=45605

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::setStatusText):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

6:17 PM Changeset in webkit [67311] by weinig@apple.com
  • 15 edits in trunk

Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
​https://bugs.webkit.org/show_bug.cgi?id=45604

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::source):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Add ability to dump the main frame's source to the console.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dumpSourceToConsole:]):

  • MiniBrowser/mac/MainMenu.xib:
4:25 PM Changeset in webkit [67310] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove unneeded Empty Queue messages
​https://bugs.webkit.org/show_bug.cgi?id=45602

We already have a /gc job to delete these.
recentstatus.py is already smart enough to use the
most recent of the workitems last update or the most recent status,
so removing these should not change the _last_status_date() return
value more than a few milliseconds.

These messages just spam the recent status log.

  • Scripts/webkitpy/tool/commands/queues.py:
12:15 PM Changeset in webkit [67309] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed.

[Qt] Trivial V8 build fix.

  • WebCore.pri: Add storage, workers and css to the include paths for the

JS code generator.

11:28 AM Changeset in webkit [67308] by andreas.kling@nokia.com
  • 5 edits in trunk/WebCore

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
​https://bugs.webkit.org/show_bug.cgi?id=45157

Include CString.h where necessary. Chromium builds would get it from
KURLGooglePrivate.h so this is only an issue for Qt + V8.

  • bindings/v8/V8Proxy.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • plugins/PluginDatabase.cpp:
11:22 AM Changeset in webkit [67307] by Simon Hausmann
  • 4 edits in trunk

[Qt] V8 port: webkit project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45140

Reviewed by Andreas Kling.

.:

building with v8.

WebCore:

  • WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.
11:11 AM Changeset in webkit [67306] by Simon Hausmann
  • 6 edits
    1 add in trunk

JavaScriptCore: [Qt] V8 port: webcore project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

so that they can also be used from WebCore.pro for v8 builds.

  • wtf/wtf.pri: Added.

WebCore: [Qt] V8 port: webcore project files changes
​https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

Modify webcore project files to include V8 javascript engine. By default disabled.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
11:09 AM Changeset in webkit [67305] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

Web Inspector: Include CString.h in generated files

This is necessary for generated code that uses the CString
returned by String::utf8() (from generateBackendDispatcher)

Chromium builds already get CString.h from KURLGooglePrivate.h
so this issue only occurs when building Qt against V8.

  • inspector/CodeGeneratorInspector.pm:
10:44 AM Changeset in webkit [67304] by andreas.kling@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-09-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port for Qt platform: Qt WebCoreSupport changes
​https://bugs.webkit.org/show_bug.cgi?id=45149

Original patch by Vlad Burlik <​volodimir.burlik@nokia.com>

Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
FrameLoaderClientQt.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame): (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame): (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext): (WebCore::FrameLoaderClientQt::createDocumentLoader):
  • WebCoreSupport/FrameLoaderClientQt.h:
10:42 AM Changeset in webkit [67303] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-11 Martin Robinson <​mrobinson@igalia.com>

Add a platform-specific result after r67281.

  • platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.
10:09 AM Changeset in webkit [67302] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Fix Python exception when generating synthetic patch IDs
​https://bugs.webkit.org/show_bug.cgi?id=45592

Can't concatenate strings and numbers directly.

  • QueueStatusServer/handlers/queuestatus.py:
10:06 AM Changeset in webkit [67301] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit/qt

2010-09-11 Vlad Burlik <​volodimir.burlik@nokia.com>

Reviewed by Andreas Kling.

[Qt] V8 port for QT platform: QT API implementation changes
​https://bugs.webkit.org/show_bug.cgi?id=45148

V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
and QWebFrame::evaluateJavaScript()

  • Api/qwebelement.cpp: (setupScriptContext): JSC and V8 variations (QWebElement::evaluateJavaScript):
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: QObject injection to V8 world (QWebFrame::addToJavaScriptWindowObject): (QWebFrame::evaluateJavaScript):
  • Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8 (QWebPagePrivate::QWebPagePrivate):
9:25 AM Changeset in webkit [67300] by xan@webkit.org
  • 4 edits in trunk

2010-09-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
​https://bugs.webkit.org/show_bug.cgi?id=45590

Bump required gobject-introspection version to 0.9.5.

  • configure.ac:

WebKit/gtk:

2010-09-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
​https://bugs.webkit.org/show_bug.cgi?id=45590

Use new type syntax and bump version number of the gir file.

  • JSCore.gir.in:
9:19 AM Changeset in webkit [67299] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

chromium fast/dom/replaceChild.html regression by r67182
​https://bugs.webkit.org/show_bug.cgi?id=45527

Turns out this is a progression! Our new images
match minefield (and sanity). The old image had a
border drawn which should have been removed when the
iframe was replaced.

Other platforms may need to update their results as well.

  • platform/mac/fast/dom/replaceChild-expected.checksum:
  • platform/mac/fast/dom/replaceChild-expected.png:
9:09 AM Changeset in webkit [67298] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-11 Robert Hogan <​robert@webkit.org>

Unreviewed, unskip passing test.

Test fixed by ​http://trac.webkit.org/changeset/56511

See ​https://bugs.webkit.org/show_bug.cgi?id=36492

  • platform/qt/Skipped:
8:04 AM Changeset in webkit [67297] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-11 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fix EFL build after r67274
​https://bugs.webkit.org/show_bug.cgi?id=45584

Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
to proper apis chaged by r67264.

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
6:20 AM Changeset in webkit [67296] by adele@apple.com
  • 3 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.

Reviewed by Sam Weinig.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderFlexibleBox.h:
3:06 AM Changeset in webkit [67295] by commit-queue@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Group statuses in queue status by patch ID
​https://bugs.webkit.org/show_bug.cgi?id=45588

Group statuses by patch ID so that the status page is easier
to scan.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/stylesheets/dashboard.css: (.status-group): (.status-bug): (.status-group ul): (.status-group ul li): (.status-group ul li:hover): (.status-cell): (.status-cell:hover): (.status-cell.pass): (.status-cell.fail): (.status-cell.pending): (.status-cell.error):
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/queuestatus.html:
2:48 AM Changeset in webkit [67294] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45479

Remove tests from Chromium expectations that now pass. Add
Chromium/Linux expectations for the script test, since it reports a
different MIME type (application/javascript vs.
application/x-javascript).

  • platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium-linux/fast/preloader/script-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45479

Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse):
2:32 AM Changeset in webkit [67293] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-11 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
​https://bugs.webkit.org/show_bug.cgi?id=45579

  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [67292] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of ​http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
12:54 AM Changeset in webkit [67291] by diegohcg@webkit.org
  • 30 edits in trunk

Add NetworkingContext to avoid layer violations ​https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.

WebCore:

Activate NetworkingContext:

Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::PingLoader):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::load):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/icon/IconFetcher.cpp:

(WebCore::IconFetcher::loadEntry):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

WebKit/chromium:

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

WebKit/gtk:

  • webkit/webkitdownload.cpp:

(webkit_download_start):

  • webkit/webkitprivate.cpp:

(currentToplevelCallback):

WebKit/win:

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::blockedError):

  • WebCoreSupport/WebFrameNetworkingContext.h:

WebKit2:

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):

12:23 AM Changeset in webkit [67290] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should expose /remote_api for data upload/download
​https://bugs.webkit.org/show_bug.cgi?id=45559

  • QueueStatusServer/app.yaml:
    • /remote_api is a standard app-engine service which allows use of the bulk uploader for data upload/download. Exposing this (for admin access only) allows us to use
12:07 AM Changeset in webkit [67289] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-09-10 yi shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt] selected text gets deleted when qgraphicswebview losts focus
​https://bugs.webkit.org/show_bug.cgi?id=45539

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
Note: See TracTimeline for information about the timeline view.