Context Navigation

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
inspector/InspectorController.h:
inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
websockets/WebSocketChannel.h:

11:17 PM WebKit Team edited by kinuko@chromium.org

(diff)

11:06 PM Changeset in webkit [67446] by commit-queue@webkit.org

3 edits
4 adds in trunk/WebKit/chromium

2010-09-13 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Add Chromium API for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44360

Build file changes.

WebKit.gyp:

Added a way to get a WebFileWriter.

public/WebFileSystem.h: (WebKit::WebFileSystem::createFileWriter):

WebFileWriter writes and truncates files.

public/WebFileWriter.h: Added.

WebFileWriterClient reports success/failure and progress events.

public/WebFileWriterClient.h: Added.

AsyncFileWriterChromium is a connector that links FileWriter and WebFileWriter, FileWriterClient and WebFileWriterClient.

src/AsyncFileWriterChromium.cpp: Added.
src/AsyncFileWriterChromium.h: Added.

10:26 PM Changeset in webkit [67445] by commit-queue@webkit.org

6 edits in trunk

2010-09-13 W. James MacLean <wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127

Replicates existing functionality, use existing tests.
Adds pixel-readback for GPU composited pages to allow for thumbnailing,
printing and other services to work with GPU rendered pages.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels):
platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerTextureSize):

2010-09-13 W. James MacLean <wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127

Modified WebViewImpl::paint() to detect non-null canvas pointers when
accelerated compositing is active, and instead fills the pixel buffer
from the GPU framebuffer. Includes re-scaling support when provided
canvas does not match size of current render layer. Limits pixel
readback to rect passed to paint(), clipped by size of rootLayerTexture.

src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint):
src/WebViewImpl.h:

10:05 PM Changeset in webkit [67444] by kinuko@chromium.org

2 edits in trunk/WebCore

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, build fix for Gtk.

bindings/js/JSEntryCustom.cpp:

9:59 PM Changeset in webkit [67443] by kinuko@chromium.org

13 edits
2 adds in trunk/WebCore

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Make FileEntry and DirectoryEntry methods accessible via Entry instance
https://bugs.webkit.org/show_bug.cgi?id=45553

FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type.

Added custom toJS/toV8 implementation to Entry interface.

No new tests; test will be added later when we have complete implementation for the API.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEntryCustom.cpp: Added. (WebCore::toJS):
bindings/v8/custom/V8EntryCustom.cpp: Added. (WebCore::toV8):
fileapi/DirectoryEntry.h: Nits fix.
fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter.
fileapi/Entry.idl: Added CustomToJS attribute.
fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter): (WebCore::FileEntry::file):
fileapi/FileEntry.h:
fileapi/FileEntry.idl:

9:29 PM Changeset in webkit [67442] by dbates@webkit.org

2 edits in trunk/WebKit/qt

2010-09-13 Daniel Bates <dbates@rim.com>

https://bugs.webkit.org/show_bug.cgi?id=45732

Fix the Qt build. I missed this when reviewing the patch
for Bug #45732.

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Change enum value ActiveDOMObject::JavaScriptPaused to ActiveDOMObject::JavaScriptDebuggerPaused

9:18 PM Changeset in webkit [67441] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632

Test: editing/execCommand/query-font-size-with-typing-style.html

The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before
retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function.

editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632

Added a test to ensure WebKit does not crash when querying font size even if there is a typing style.

editing/execCommand/query-font-size-with-typing-style-expected.txt: Added.
editing/execCommand/query-font-size-with-typing-style.html: Added.

9:17 PM Changeset in webkit [67440] by eric.carlson@apple.com

2 edits in trunk/WebKit/qt

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Daniel Bates.

[Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter
https://bugs.webkit.org/show_bug.cgi?id=45732

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Pass ActiveDOMObject::JavaScriptPaused to suspendActiveDOMObjects.

9:08 PM Changeset in webkit [67439] by jamesr@google.com

2 edits in trunk/WebKit/chromium

2010-09-13 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Return NULL from getSharedGraphicsContext3D if we couldn't initialize
https://bugs.webkit.org/show_bug.cgi?id=45731

If we can't create a GraphicsContext3D, return NULL from getSharedGraphicsContext3D rather
than an object with NULL internal pointers. Callers know how to handle a null return value
but not one that has inconsistent internal state.

src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):

9:00 PM Changeset in webkit [67438] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-13 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

[BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45690

WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already
in namespace WebCore block.

platform/brew/SSLKeyGeneratorBrew.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):

8:40 PM Changeset in webkit [67437] by weinig@apple.com

6 edits in trunk/WebKit2

URL in address bar doesn't update when navigating to http://webkit.org/new-bug when using WebKit2
<rdar://problem/8272775>
https://bugs.webkit.org/show_bug.cgi?id=45729

Reviewed by Jon Honeycutt.

Pass an updated provisional url while notifying the UIProcess of
didReceiveServerRedirectForProvisionalLoadForFrame.

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):

UIProcess/WebFrameProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):

UIProcess/WebPageProxy.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

8:23 PM Changeset in webkit [67436] by weinig@apple.com

2 edits in trunk/WebKit2

Fix windows build.

UIProcess/Launcher/win/ProcessLauncherWin.cpp:

8:15 PM Changeset in webkit [67435] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Code simplification needed in Atk Wrapper
https://bugs.webkit.org/show_bug.cgi?id=45687

Use TextIterator::rangeLength() to calculate endOffset

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Don't manually iterate over a artificial new range but just call TextIterator::rangeLength on the range created between the start and end positions.

7:54 PM Changeset in webkit [67434] by weinig@apple.com

2 edits in trunk/WebCore

Clean up xcode project.

Reviewed by Alice Liu.

WebCore.xcodeproj/project.pbxproj:

7:48 PM Changeset in webkit [67433] by weinig@apple.com

11 edits
5 adds in trunk/WebKit2

Threaded mode should work in WebKit2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45727

Reviewed by Jon Honeycutt.

Make starting the web thread more like starting a new process (encapsulate it in a thread launcher class).
Make the call to didFinishLaunching asynchronous so that WebProcess is fully constructed before it is called.

Platform/WorkItem.h:

(MemberFunctionWorkItem1::MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::~MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::execute):
(WorkItem::create):

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/ThreadLauncher.cpp: Added.

(WebKit::ThreadLauncher::ThreadLauncher):
(WebKit::ThreadLauncher::launchThread):
(WebKit::ThreadLauncher::didFinishLaunchingThread):
(WebKit::ThreadLauncher::invalidate):

UIProcess/Launcher/ThreadLauncher.h: Added.

(WebKit::ThreadLauncher::Client::~Client):
(WebKit::ThreadLauncher::create):
(WebKit::ThreadLauncher::isLaunching):

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):

UIProcess/Launcher/mac/ThreadLauncherMac.mm: Added.

(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

UIProcess/Launcher/win/ProcessLauncherWin.cpp:
UIProcess/Launcher/win/ThreadLauncherWin.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
(WebKit::WebProcessProxy::didFinishLaunching):

UIProcess/WebProcessProxy.h:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

7:41 PM Changeset in webkit [67432] by eric.carlson@apple.com

20 edits
2 adds in trunk

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688

Test: http/tests/media/reload-after-dialog.html

bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter.

bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects.

dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter.
dom/ActiveDOMObject.h:

dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto.
dom/ScriptExecutionContext.h:

history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects.

html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter.
html/HTMLMarqueeElement.h:

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): Deal with element being suspended. (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document becoming inactive.
html/HTMLMediaElement.h:

page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects.

page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter.
page/SuspendableTimer.h:

websockets/WebSocket.cpp: (WebCore::WebSocket::suspend): Ditto.
websockets/WebSocket.h:

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::suspend): Ditto.
xml/XMLHttpRequest.h:

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688

http/tests/media/reload-after-dialog-expected.txt: Added.
http/tests/media/reload-after-dialog.html: Added.

7:15 PM Changeset in webkit [67431] by weinig@apple.com

2 edits in trunk/WebCore

Fix the mac build.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMousePressEventToSubframe):

7:03 PM Changeset in webkit [67430] by weinig@apple.com

2 edits in trunk/WebCore

Can't scroll on Bugzilla patch review pages on Mac with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43555

Reviewed by Anders Carlsson.

<rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks
<rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555)

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Add WebKit2 mode for these functions based on the presence of a platform widget for a
FrameView.

6:38 PM Changeset in webkit [67429] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-09-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should log when it's retrying due to checkout out of date error
https://bugs.webkit.org/show_bug.cgi?id=45725

This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.

In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.

Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

6:37 PM Changeset in webkit [67428] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-09-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Upload results when cq patch landing fails
https://bugs.webkit.org/show_bug.cgi?id=45683

Include script errors when CommitQueue._land fails.

Scripts/webkitpy/tool/commands/queues.py:

6:10 PM Changeset in webkit [67427] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ViewportArguments.cpp
https://bugs.webkit.org/show_bug.cgi?id=45678

Use fabs() instead of abs().
This patch also fixes the return value, when
the value is between -1 and 1.

dom/ViewportArguments.cpp: (WebCore::findUserScalableValue):

6:02 PM Changeset in webkit [67426] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix duplicate entries in expectations file; we really need to fix
the checkin trigger to catch these.

platform/chromium/test_expectations.txt:

5:56 PM Changeset in webkit [67425] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Add some suppressions back in - it looks like we are probably tripping
over some debug asserts that I need to triage downstream.

platform/chromium/test_expectations.txt:

5:29 PM Changeset in webkit [67424] by commit-queue@webkit.org

2 edits in trunk/WebKit/efl

2010-09-13 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Fix build break when enabling HTML5 video support
https://bugs.webkit.org/show_bug.cgi?id=45674

The correct include variable for LibXml2 in cmake is
LIBXML2_INCLUDE_DIR instead of LIBXML2_INCLUDE_DIRS.

CMakeListsEfl.txt:

4:42 PM Changeset in webkit [67423] by Darin Adler

22 edits
2 adds in trunk

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

wtf/text/WTFString.h: Added isAllSpecialCharacters, moved here from the HTML tree builder.

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

DOM/WebDOMOperations.mm: (-[DOMDocument webFrame]): Get rid of unneeded local variable. (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

Added new HTMLParserIdioms source file, with a name inspired by the HTML
specification, which has a section defining things like "space character"
that talks about common parser idioms. These are idioms for the main HTML
parser and for parsers for various microlanguages as well.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj: Added HTMLParserIdioms.

css/CSSHelper.h: Fixed indentation and comments here. Point to the new stripLeadingAndTrailingHTMLSpaces function.

html/parser/HTMLParserIdioms.cpp: Added.
html/parser/HTMLParserIdioms.h: Added.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Updated for name changes.

html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h.

html/HTMLInputElement.cpp:
html/HTMLMeterElement.cpp:
html/HTMLProgressElement.cpp:
html/StepRange.cpp:
rendering/RenderSlider.cpp: Updated includes.

svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. This is for use on the attribute value before building the URL, not on the URL after building it. I did not add a test case; this is an obscure corner and soon we will be moving to stripLeadingAndTrailingHTMLSpaces anyway.
wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Ditto.

4:27 PM Changeset in webkit [67422] by Chris Fleizach

3 edits
2 adds in trunk

AX: REGRESSION: WebKit does not report label of web popup buttons
https://bugs.webkit.org/show_bug.cgi?id=45715

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/popup-button-title.html

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

platform/mac/accessibility/popup-button-title-expected.txt: Added.
platform/mac/accessibility/popup-button-title.html: Added.

4:14 PM Changeset in webkit [67421] by kinuko@chromium.org

15 edits in trunk/WebCore

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Expose Flags constructor if FileSystem API is Enabled
https://bugs.webkit.org/show_bug.cgi?id=45165

This change also includes:

Changed Flags' attribute names from UPPERCASE to camelCase to reflect the recent spec change. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
Enhanced EnabledAtRuntime attribute to take parameter that is used to generate a RuntimeEnabledFeatures method name.

No new tests; tests will be added when we fully expose the interface.

bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor.
fileapi/Flags.idl: Changed attribute names to camelCase.
page/DOMWindow.idl: Exposed Flags constructor.

bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object).
bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support.
bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::create): (WebDOMTestObj::setCreate):
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::createAttrGetter): (WebCore::TestObjInternal::createAttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): (WebCore::ConfigureV8TestObjTemplate):

4:10 PM Changeset in webkit [67420] by abarth@webkit.org

2 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

"Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=45647

Implements the notImplemented by doing nothing, which is the proper
behavior according to the spec.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

4:08 PM Changeset in webkit [67419] by abarth@webkit.org

2 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

More trivial EOF handling in tree builder
https://bugs.webkit.org/show_bug.cgi?id=45648

The spec says to treat these modes like the InBodyMode, which is what
this patch does. Doing so is indistinguishable from our current
behavior, which is why we didn't catch this based on tests.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

3:59 PM Changeset in webkit [67418] by commit-queue@webkit.org

4 edits in trunk/WebKit/chromium

2010-09-13 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572

public/WebAccessibilityObject.h:
src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):

3:58 PM Changeset in webkit [67417] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of tests that are now passing.

platform/chromium/test_expectations.txt:

3:27 PM Changeset in webkit [67416] by dpranke@chromium.org

4 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] rebaseline two svg tests after r67200
https://bugs.webkit.org/show_bug.cgi?id=45665

platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
platform/chromium/test_expectations.txt:

3:26 PM Changeset in webkit [67415] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] mark fast/files/read-blob-async.html as CRASH PASS on linux
https://bugs.webkit.org/show_bug.cgi?id=45672

platform/chromium/test_expectations.txt:

3:10 PM Changeset in webkit [67414] by dpranke@chromium.org

2 edits in trunk/WebKit/chromium

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] fix broken dependency in ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=45684

WebKit.gyp:

3:05 PM Changeset in webkit [67413] by commit-queue@webkit.org

3 edits in trunk/WebKit/efl

2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add setting API for enabling page cache
https://bugs.webkit.org/show_bug.cgi?id=44931

ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_page_cache_get): Added. (ewk_view_setting_page_cache_set): Added.
ewk/ewk_view.h:

2:39 PM Changeset in webkit [67412] by jamesr@google.com

5 edits in trunk/WebCore

2010-09-13 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

SharedGraphicsContext3D's texture cache holds on to images after free
https://bugs.webkit.org/show_bug.cgi?id=45706

Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs.
Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know
so that the cache entry and associated texture can also be removed.

platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::removeTextureFor): (WebCore::SharedGraphicsContext3D::removeTexturesFor): (WebCore::SharedGraphicsContext3D::allContexts):
platform/graphics/gpu/SharedGraphicsContext3D.h:
platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::~NativeImageSkia):
platform/graphics/skia/NativeImageSkia.h:

2:23 PM Changeset in webkit [67411] by weinig@apple.com

2 edits in trunk/WebKit2

didFinishDocumentLoadForFrame() is not being sent by WebKit2
<rdar://problem/8424171>

Reviewed by Anders Carlsson.

Finish wiring up didFinishDocumentLoad to the UIProcess.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

2:08 PM Changeset in webkit [67410] by darin@chromium.org

6 edits in branches/chromium/517

Merge 67401 - 210-09-13 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

platform/ScrollAnimator.cpp:
platform/ScrollAnimatorWin.cpp:
platform/ScrollAnimatorWin.h:

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/3290027

2:08 PM Changeset in webkit [67409] by enrica@apple.com

1 edit in trunk/WebKit/win/WebFrame.cpp

One more attempt at fixing the Windows build.
Not reviewed.

2:06 PM Changeset in webkit [67408] by Chris Fleizach

9 edits
2 adds in trunk

AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
https://bugs.webkit.org/show_bug.cgi?id=45548

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/element-is-ignored.html

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityIsIgnored]):

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isIgnored):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isIgnored):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isIgnored):

LayoutTests:

platform/mac/accessibility/element-is-ignored-expected.txt: Added.
platform/mac/accessibility/element-is-ignored.html: Added.

1:55 PM Changeset in webkit [67407] by Chris Fleizach

3 edits
2 adds in trunk

CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663
https://bugs.webkit.org/show_bug.cgi?id=45697

Reviewed by Darin Adler.

WebCore:

Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may
be in a bad state and accessing internal variables can lead to a crash.

Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt: Added.
platform/mac/accessibility/updating-attribute-in-table-row-crash.html: Added.

1:49 PM Changeset in webkit [67406] by abarth@webkit.org

3 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement EOF handling in TextMode
https://bugs.webkit.org/show_bug.cgi?id=45644

This patch is actually covered by a bunch of tests. We were just
magically passing the tests before because of some nutty code in
Document.cpp.

dom/Document.cpp: (WebCore::Document::implicitClose):
- This code was masking the notImplemented in the tree builder. I also removed the use of the setting because it wasn't working properly anyway. I'll implement a working version shortly.
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- Implement per the spec.

1:43 PM Changeset in webkit [67405] by enrica@apple.com

1 edit in trunk/WebKit/win/WebFrame.h

Fixing Windows build.
Not reviewed.

12:40 PM Changeset in webkit [67404] by tony@chromium.org

1 edit
173 deletes in trunk/LayoutTests

2010-09-13 Tony Chang <tony@chromium.org>

Unreviewed, removing chromium-linux results that deduplicate-tests says are
unnecessary (mostly due to the checksum computation change last week).

platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-image-004-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-select-all-002-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-select-all-003-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Removed.
platform/chromium-linux/editing/undo/5378473-expected.checksum: Removed.
platform/chromium-linux/editing/undo/5378473-expected.png: Removed.
platform/chromium-linux/editing/undo/undo-misspellings-expected.checksum: Removed.
platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.checksum: Removed.
platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Removed.
platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Removed.
platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Removed.
platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-linux/fast/dom/attr_dead_doc-expected.checksum: Removed.
platform/chromium-linux/fast/dom/attr_dead_doc-expected.png: Removed.
platform/chromium-linux/fast/frames/content-opacity-1-expected.checksum: Removed.
platform/chromium-linux/fast/frames/content-opacity-1-expected.png: Removed.
platform/chromium-linux/fast/frames/content-opacity-2-expected.checksum: Removed.
platform/chromium-linux/fast/frames/content-opacity-2-expected.png: Removed.
platform/chromium-linux/fast/frames/iframe-text-contents-expected.checksum: Removed.
platform/chromium-linux/fast/frames/iframe-text-contents-expected.png: Removed.
platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.checksum: Removed.
platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
platform/chromium-linux/fast/layers/self-painting-outline-expected.checksum: Removed.
platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Removed.
platform/chromium-linux/fast/repaint/background-generated-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/background-generated-expected.png: Removed.
platform/chromium-linux/fast/repaint/background-misaligned-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Removed.
platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Removed.
platform/chromium-linux/fast/repaint/content-into-overflow-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Removed.
platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
platform/chromium-linux/fast/repaint/float-new-in-block-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Removed.
platform/chromium-linux/fast/repaint/focus-ring-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/focus-ring-expected.png: Removed.
platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Removed.
platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Removed.
platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
platform/chromium-linux/fast/repaint/outline-inset-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/outline-inset-expected.png: Removed.
platform/chromium-linux/fast/repaint/overflow-into-content-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Removed.
platform/chromium-linux/fast/repaint/selection-clear-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/selection-clear-expected.png: Removed.
platform/chromium-linux/fast/repaint/table-outer-border-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Removed.
platform/chromium-linux/fast/repaint/table-section-repaint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Removed.
platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Removed.
platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Removed.
platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.checksum: Removed.
platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Removed.
platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Removed.
platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Removed.
platform/chromium-linux/fast/table/giantRowspan-expected.checksum: Removed.
platform/chromium-linux/fast/table/giantRowspan-expected.png: Removed.
platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.checksum: Removed.
platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Removed.
platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Removed.
platform/chromium-linux/svg/custom/dynamic-empty-path-expected.checksum: Removed.
platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Removed.
platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Removed.
platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
platform/chromium-linux/svg/custom/group-opacity-expected.checksum: Removed.
platform/chromium-linux/svg/custom/group-opacity-expected.png: Removed.
platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-container-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-container-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-container2-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-container2-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-style-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-style-expected.png: Removed.
platform/chromium-linux/svg/custom/js-update-transform-addition-expected.checksum: Removed.
platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Removed.
platform/chromium-linux/svg/custom/marker-referencePoint-expected.checksum: Removed.
platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Removed.
platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
platform/chromium-linux/svg/custom/mask-changes-expected.png: Removed.
platform/chromium-linux/svg/custom/pattern-y-offset-expected.checksum: Removed.
platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Removed.
platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Removed.
platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Removed.
platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Removed.
platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
platform/chromium-linux/svg/custom/text-dom-removal-expected.checksum: Removed.
platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Removed.
platform/chromium-linux/svg/custom/use-forward-refs-expected.checksum: Removed.
platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Removed.
platform/chromium-linux/svg/hixie/data-types/001-expected.checksum: Removed.
platform/chromium-linux/svg/hixie/data-types/001-expected.png: Removed.
platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Removed.
platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Removed.
platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Removed.
platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Removed.
platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Removed.
platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Removed.
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.checksum: Removed.
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.

12:16 PM Changeset in webkit [67403] by enrica@apple.com

39 edits in trunk

Paste should be implemented in WebCore like Copy and Cut for Mac also.
https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>

WebCore:

Reviewed by Sam Weining.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

editing/Editor.cpp:

(WebCore::Editor::shouldInsertFragment):

editing/mac/EditorMac.mm: extended to support Mail specific scenarios.

(WebCore::Editor::pasteWithPasteboard):

loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added.
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added.
(WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail.

loader/FrameLoaderClient.h:
page/EditorClient.h:
platform/Pasteboard.h:
platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that
doesn't calll back into WebKit.
(WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the
WebCore level.
(WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the
WebCore level.
(WebCore::uniqueURLWithRelativePart): Added.
(WebCore::Pasteboard::documentFragment): Extended to include all the functionality
provided in documentFragmentFromPasteboard in WebHTMLView.mm.

WebKit/chromium:

Reviewed by Sam Weinig.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMETypeAsHTML): Added stub.

src/FrameLoaderClientImpl.h:

WebKit/efl:

Reviewed by Sam Weinig.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML): Added stub.

WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Reviewed by Sam Weinig.

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.

WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

Reviewed by Sam Weinig.

WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::canShowMIMETypeAsHTML): Added stub.

WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

Reviewed by Sam Weinig.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(excludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Added.
(WebEditorClient::setInsertionPasteboard):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
of the editor client.

WebView/WebHTMLView.mm: Removed paste method.

WebKit/qt:

Reviewed by Sam Weinig.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMETypeAsHTML): Added stub.

WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam Weinig.

WebFrame.cpp:

(WebFrame::canShowMIMETypeASHTML): Added.

WebKit/wx:

Reviewed by Sam Weinig.

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::canShowMIMETypeAsHTML): Added stub.

WebKitSupport/FrameLoaderClientWx.h:

WebKit2:

Reviewed by Sam Weinig.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added.
(WebKit::WebEditorClient::setInsertionPasteboard): Added.

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML): Added.

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

12:05 PM Changeset in webkit [67402] by alex

2 edits in trunk/WebCore

2010-09-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
https://bugs.webkit.org/show_bug.cgi?id=44699

Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):

11:56 AM Changeset in webkit [67401] by darin@chromium.org

6 edits in trunk

210-09-13 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

platform/ScrollAnimator.cpp:
platform/ScrollAnimatorWin.cpp:
platform/ScrollAnimatorWin.h:

11:45 AM Changeset in webkit [67400] by agl@chromium.org

5 edits in trunk/LayoutTests

2010-09-13 Adam Langley <agl@chromium.org>

Unreviewed. Layout test re-baseline.

After r66882, complex text word spacing changed due to a bug fix. This
rebaselines the layout test for that case.

https://bugs.webkit.org/show_bug.cgi?id=45191

platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
platform/chromium/test_expectations.txt:

11:41 AM Changeset in webkit [67399] by rniwa@webkit.org

2 edits in trunk/WebCore

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Move functions of StyledMarkupAccumulator below that of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=45624

Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions
to below the definitions of MarkupAccumulator's member functions.

No new tests are added since this is a cleanup.

editing/markup.cpp: (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): (WebCore::StyledMarkupAccumulator::appendElement): (WebCore::StyledMarkupAccumulator::shouldAnnotate): (WebCore::StyledMarkupAccumulator::wrapWithNode): (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): (WebCore::StyledMarkupAccumulator::takeResults): (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::renderedText): (WebCore::StyledMarkupAccumulator::stringValueForRange): (WebCore::styleFromMatchedRulesForElement): (WebCore::StyledMarkupAccumulator::removeExteriorStyles): (WebCore::needInterchangeNewlineAfter): (WebCore::styleFromMatchedRulesAndInlineDecl): (WebCore::removeEnclosingMailBlockquoteStyle): (WebCore::removeDefaultStyles):

11:34 AM Changeset in webkit [67398] by alex

4 edits in trunk/WebCore

2010-09-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leak in the GraphicsContextCairo drawPathShadow
https://bugs.webkit.org/show_bug.cgi?id=44959

Fix a leak of the cairo_path.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
platform/graphics/cairo/OwnPtrCairo.cpp: (WTF::cairo_path_t):
platform/graphics/cairo/OwnPtrCairo.h:

11:28 AM WinCE edited by paroga@paroga.com

(diff)

11:25 AM Changeset in webkit [67397] by mrowe@apple.com

18 edits in trunk

Build fix. Clear the executable bit on files that should not be executable.

11:15 AM WinCE edited by paroga@paroga.com

(diff)

10:40 AM Changeset in webkit [67396] by abarth@webkit.org

4 edits in trunk

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645

Test that </sarcasm> works properly.

html5lib/resources/webkit02.dat:

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645

Umm... Yeah.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):

10:21 AM Changeset in webkit [67395] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Darin Adler.

[WML] Fix build breaks when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=45628

There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter.
So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent()
was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp

wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

10:00 AM Changeset in webkit [67394] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline inspector/extensions-events.html

inspector/extensions-events-expected.txt:

9:32 AM Changeset in webkit [67393] by sullivan@apple.com

2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=45677
[WebView canMarkAllTextMatches] can crash if called after [WebView close]

Reviewed by Adam Roben.

<rdar://problem/8404890>

WebView/WebView.mm:

(-[WebView canMarkAllTextMatches]):
Return NO immediately if the webview has already been closed. This was an overlooked
case from the fix for 45175.

9:26 AM Changeset in webkit [67392] by Martin Robinson

2 edits in trunk/WebCore

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
https://bugs.webkit.org/show_bug.cgi?id=45230

No new tests as this is just a build change.

GNUmakefile.am: Move as many sources as possible to the SOURCES primary. Others should be moved over time as we solve issues with them.

9:17 AM Changeset in webkit [67391] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

2010-09-13 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651

Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.

9:03 AM Changeset in webkit [67390] by Chris Fleizach

7 edits
2 adds in trunk

REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43807

Reviewed by Darin Adler.

WebCore:

Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types.

Test: platform/mac/accessibility/visible-position-crash-for-text-node.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::textMarkerForPoint):

LayoutTests:

platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt: Added.
platform/mac/accessibility/visible-position-crash-for-text-node.html: Added.

8:25 AM Changeset in webkit [67389] by Martin Robinson

4 edits in trunk

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365

platform/qt/Skipped: Unskip tests that are now passing.

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365

Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.

platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.

8:13 AM Changeset in webkit [67388] by Adam Roben

2 edits in trunk/JavaScriptCore

Copy JavaScriptCore's generated sources to the right directory

JavaScriptCore.vcproj/JavaScriptCore.make: Fixed typo.

7:20 AM Changeset in webkit [67387] by commit-queue@webkit.org

12 edits in trunk

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Remove exceptions for tests that now pass (in DRT and downstream test_shell)

platform/chromium/drt_expectations.txt:
platform/chromium/test_expectations.txt:

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Add missing virtual destructor to the abstract base class.

platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
platform/chromium/GeolocationServiceChromium.h:

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Ports over fixes from test shell:

Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html

Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably

Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService

public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService):
public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed):
public/WebGeolocationServiceMock.h:
src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached):
src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions):

7:17 AM Changeset in webkit [67386] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Skip new debugger test on Qt.

platform/qt/Skipped:

6:39 AM Changeset in webkit [67385] by yurys@chromium.org

6 edits
3 adds in trunk

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

Test that scope sections in Scripts panel are expandable and
contain correct data.

inspector/debugger-expand-scope-expected.txt: Added.
inspector/debugger-expand-scope.html: Added.
platform/chromium/inspector/debugger-expand-scope-expected.txt: Added.

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

Test: inspector/debugger-expand-scope.html

inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. (injectedScriptConstructor.):

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

src/js/DebuggerScript.js: copy scope variables into a new object, but for global scope object, with statement parameter and catch block exception variable pass the object itself to the injected script.
src/js/Tests.js: moved testExpandScope to LayoutTests

6:03 AM Changeset in webkit [67384] by caseq@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] add viewport meta tag tests to expectations
https://bugs.webkit.org/show_bug.cgi?id=45655

platform/chromium/test_expectations.txt:

5:29 AM Changeset in webkit [67383] by commit-queue@webkit.org

8 edits in trunk

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673

Implement AtkText's setSelection and removeSelection functions

accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange): Moved some GTK specific code from a ifdef-endif region to AccessibilityObjectAtk.cpp
accessibility/AccessibilityObject.h:
accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::getLengthForTextRange): New.
accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_remove_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_caret_offset): Changed to directly use visiblePositionRangeForRange now that there's no longer a problem with that, as it was in the past (only worked for text controls).

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide unit tests for AtkText's text selection functions
https://bugs.webkit.org/show_bug.cgi?id=43919

New tests to check getting, setting and removing text selections

tests/testatk.c: (testWekitAtkTextSelections): New unit tests to check all the text selection related functions altogether through a single test function. (main):

Make sure that code dependant on getting information from the
clipboard gets executed only when there's a GDK window associated
to the webview widget, as that's not the case when executing the
unit tests (the wedbview is not inside of any toplevel window) and
will make the tests crash if not taken into account.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):

5:09 AM Changeset in webkit [67382] by morrita@google.com

2 edits
10 adds in trunk/LayoutTests

2010-09-13 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][Test] custom-scrollbar-with-incomplete-style.html need expectation files.
https://bugs.webkit.org/show_bug.cgi?id=45646

Added missing expectations.

platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:06 AM Changeset in webkit [67381] by morrita@google.com

2 edits in trunk/LayoutTests

2010-09-13 MORITA Hajime <morrita@google.com>

Reviewed by Dirk Schulze.

[chromium] svg/filters/filter-empty-g.svg crashes in linux/mac debug after r63530
https://bugs.webkit.org/show_bug.cgi?id=42486

Removed skip line.
This looks fixed with a fix for http://webkit.org/b/41175.

platform/chromium/test_expectations.txt:

4:35 AM Changeset in webkit [67380] by andreas.kling@nokia.com

2 edits in trunk/LayoutTests

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Unreviewed.

[Qt] Skip three viewport meta tag tests that fail on the bot.

platform/qt/Skipped:

4:19 AM Changeset in webkit [67379] by andreas.kling@nokia.com

2 edits in trunk/WebKitTools

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] build-webkit: Add --v8 option to build against V8

Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.

Scripts/build-webkit:

4:05 AM Changeset in webkit [67378] by hans@chromium.org

5 edits in trunk

2010-09-13 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650

Since the virtual member functions of WebDeviceOrientationClientMock
are not exported from the DLL, construction of the object must be done inside
the DLL, or else the linker will complain (because the vtable cannot
be set up). Clients should use the create() member function, and the constructor
will be made private in a subsequent patch.

public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::create):

2010-09-13 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650

Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.

This should fix the linker errors for the multi-DLL Chromium DRT build.

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):

3:58 AM Changeset in webkit [67377] by apavlov@chromium.org

2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] update test expectations for tests that pass after rolling out r67328
https://bugs.webkit.org/show_bug.cgi?id=45642

platform/chromium/test_expectations.txt:

3:37 AM Changeset in webkit [67376] by kenneth@webkit.org

20 edits
229 adds in trunk

WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

Tests: fast/viewport/viewport-1.html

fast/viewport/viewport-10.html
fast/viewport/viewport-100.html
fast/viewport/viewport-101.html
fast/viewport/viewport-102.html
fast/viewport/viewport-103.html
fast/viewport/viewport-104.html
fast/viewport/viewport-105.html
fast/viewport/viewport-106.html
fast/viewport/viewport-107.html
fast/viewport/viewport-108.html
fast/viewport/viewport-109.html
fast/viewport/viewport-11.html
fast/viewport/viewport-110.html
fast/viewport/viewport-111.html
fast/viewport/viewport-112.html
fast/viewport/viewport-113.html
fast/viewport/viewport-114.html
fast/viewport/viewport-115.html
fast/viewport/viewport-116.html
fast/viewport/viewport-117.html
fast/viewport/viewport-118.html
fast/viewport/viewport-119.html
fast/viewport/viewport-12.html
fast/viewport/viewport-120.html
fast/viewport/viewport-121.html
fast/viewport/viewport-122.html
fast/viewport/viewport-123.html
fast/viewport/viewport-124.html
fast/viewport/viewport-125.html
fast/viewport/viewport-126.html
fast/viewport/viewport-127.html
fast/viewport/viewport-13.html
fast/viewport/viewport-14.html
fast/viewport/viewport-15.html
fast/viewport/viewport-16.html
fast/viewport/viewport-17.html
fast/viewport/viewport-18.html
fast/viewport/viewport-19.html
fast/viewport/viewport-2.html
fast/viewport/viewport-20.html
fast/viewport/viewport-21.html
fast/viewport/viewport-22.html
fast/viewport/viewport-23.html
fast/viewport/viewport-24.html
fast/viewport/viewport-25.html
fast/viewport/viewport-26.html
fast/viewport/viewport-27.html
fast/viewport/viewport-28.html
fast/viewport/viewport-29.html
fast/viewport/viewport-3.html
fast/viewport/viewport-30.html
fast/viewport/viewport-31.html
fast/viewport/viewport-32.html
fast/viewport/viewport-33.html
fast/viewport/viewport-34.html
fast/viewport/viewport-35.html
fast/viewport/viewport-36.html
fast/viewport/viewport-37.html
fast/viewport/viewport-38.html
fast/viewport/viewport-39.html
fast/viewport/viewport-4.html
fast/viewport/viewport-40.html
fast/viewport/viewport-41.html
fast/viewport/viewport-42.html
fast/viewport/viewport-43.html
fast/viewport/viewport-44.html
fast/viewport/viewport-45.html
fast/viewport/viewport-46.html
fast/viewport/viewport-47.html
fast/viewport/viewport-48.html
fast/viewport/viewport-49.html
fast/viewport/viewport-5.html
fast/viewport/viewport-50.html
fast/viewport/viewport-51.html
fast/viewport/viewport-52.html
fast/viewport/viewport-53.html
fast/viewport/viewport-54.html
fast/viewport/viewport-55.html
fast/viewport/viewport-56.html
fast/viewport/viewport-57.html
fast/viewport/viewport-58.html
fast/viewport/viewport-59.html
fast/viewport/viewport-6.html
fast/viewport/viewport-60.html
fast/viewport/viewport-61.html
fast/viewport/viewport-62.html
fast/viewport/viewport-63.html
fast/viewport/viewport-64.html
fast/viewport/viewport-65.html
fast/viewport/viewport-66.html
fast/viewport/viewport-67.html
fast/viewport/viewport-68.html
fast/viewport/viewport-69.html
fast/viewport/viewport-7.html
fast/viewport/viewport-70.html
fast/viewport/viewport-71.html
fast/viewport/viewport-72.html
fast/viewport/viewport-73.html
fast/viewport/viewport-74.html
fast/viewport/viewport-75.html
fast/viewport/viewport-76.html
fast/viewport/viewport-77.html
fast/viewport/viewport-78.html
fast/viewport/viewport-79.html
fast/viewport/viewport-8.html
fast/viewport/viewport-80.html
fast/viewport/viewport-81.html
fast/viewport/viewport-82.html
fast/viewport/viewport-83.html
fast/viewport/viewport-84.html
fast/viewport/viewport-85.html
fast/viewport/viewport-86.html
fast/viewport/viewport-87.html
fast/viewport/viewport-88.html
fast/viewport/viewport-9.html
fast/viewport/viewport-90.html

dom/ViewportArguments.cpp:

(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):

dom/ViewportArguments.h:

(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):

WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):

Api/qwebpage.cpp:

(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):

Api/qwebpage.h:
Api/qwebpage_p.h:

(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::didReceiveViewportArguments):

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):

WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::dumpConfigurationForViewport):

DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

fast/viewport/viewport-1-expected.txt: Added.
fast/viewport/viewport-1.html: Added.
fast/viewport/viewport-10-expected.txt: Added.
fast/viewport/viewport-10.html: Added.
fast/viewport/viewport-100-expected.txt: Added.
fast/viewport/viewport-100.html: Added.
fast/viewport/viewport-101-expected.txt: Added.
fast/viewport/viewport-101.html: Added.
fast/viewport/viewport-102-expected.txt: Added.
fast/viewport/viewport-102.html: Added.
fast/viewport/viewport-103-expected.txt: Added.
fast/viewport/viewport-103.html: Added.
fast/viewport/viewport-104-expected.txt: Added.
fast/viewport/viewport-104.html: Added.
fast/viewport/viewport-105-expected.txt: Added.
fast/viewport/viewport-105.html: Added.
fast/viewport/viewport-106-expected.txt: Added.
fast/viewport/viewport-106.html: Added.
fast/viewport/viewport-107-expected.txt: Added.
fast/viewport/viewport-107.html: Added.
fast/viewport/viewport-108-expected.txt: Added.
fast/viewport/viewport-108.html: Added.
fast/viewport/viewport-109-expected.txt: Added.
fast/viewport/viewport-109.html: Added.
fast/viewport/viewport-11-expected.txt: Added.
fast/viewport/viewport-11.html: Added.
fast/viewport/viewport-110-expected.txt: Added.
fast/viewport/viewport-110.html: Added.
fast/viewport/viewport-111-expected.txt: Added.
fast/viewport/viewport-111.html: Added.
fast/viewport/viewport-112-expected.txt: Added.
fast/viewport/viewport-112.html: Added.
fast/viewport/viewport-113-expected.txt: Added.
fast/viewport/viewport-113.html: Added.
fast/viewport/viewport-114-expected.txt: Added.
fast/viewport/viewport-114.html: Added.
fast/viewport/viewport-115-expected.txt: Added.
fast/viewport/viewport-115.html: Added.
fast/viewport/viewport-116-expected.txt: Added.
fast/viewport/viewport-116.html: Added.
fast/viewport/viewport-117-expected.txt: Added.
fast/viewport/viewport-117.html: Added.
fast/viewport/viewport-118-expected.txt: Added.
fast/viewport/viewport-118.html: Added.
fast/viewport/viewport-119-expected.txt: Added.
fast/viewport/viewport-119.html: Added.
fast/viewport/viewport-12-expected.txt: Added.
fast/viewport/viewport-12.html: Added.
fast/viewport/viewport-120-expected.txt: Added.
fast/viewport/viewport-120.html: Added.
fast/viewport/viewport-121-expected.txt: Added.
fast/viewport/viewport-121.html: Added.
fast/viewport/viewport-122-expected.txt: Added.
fast/viewport/viewport-122.html: Added.
fast/viewport/viewport-123-expected.txt: Added.
fast/viewport/viewport-123.html: Added.
fast/viewport/viewport-124-expected.txt: Added.
fast/viewport/viewport-124.html: Added.
fast/viewport/viewport-125-expected.txt: Added.
fast/viewport/viewport-125.html: Added.
fast/viewport/viewport-126.html: Added.
fast/viewport/viewport-127.html: Added.
fast/viewport/viewport-13-expected.txt: Added.
fast/viewport/viewport-13.html: Added.
fast/viewport/viewport-14-expected.txt: Added.
fast/viewport/viewport-14.html: Added.
fast/viewport/viewport-15-expected.txt: Added.
fast/viewport/viewport-15.html: Added.
fast/viewport/viewport-16-expected.txt: Added.
fast/viewport/viewport-16.html: Added.
fast/viewport/viewport-17-expected.txt: Added.
fast/viewport/viewport-17.html: Added.
fast/viewport/viewport-18-expected.txt: Added.
fast/viewport/viewport-18.html: Added.
fast/viewport/viewport-19-expected.txt: Added.
fast/viewport/viewport-19.html: Added.
fast/viewport/viewport-2-expected.txt: Added.
fast/viewport/viewport-2.html: Added.
fast/viewport/viewport-20-expected.txt: Added.
fast/viewport/viewport-20.html: Added.
fast/viewport/viewport-21-expected.txt: Added.
fast/viewport/viewport-21.html: Added.
fast/viewport/viewport-22-expected.txt: Added.
fast/viewport/viewport-22.html: Added.
fast/viewport/viewport-23-expected.txt: Added.
fast/viewport/viewport-23.html: Added.
fast/viewport/viewport-24-expected.txt: Added.
fast/viewport/viewport-24.html: Added.
fast/viewport/viewport-25-expected.txt: Added.
fast/viewport/viewport-25.html: Added.
fast/viewport/viewport-26-expected.txt: Added.
fast/viewport/viewport-26.html: Added.
fast/viewport/viewport-27-expected.txt: Added.
fast/viewport/viewport-27.html: Added.
fast/viewport/viewport-28-expected.txt: Added.
fast/viewport/viewport-28.html: Added.
fast/viewport/viewport-29-expected.txt: Added.
fast/viewport/viewport-29.html: Added.
fast/viewport/viewport-3-expected.txt: Added.
fast/viewport/viewport-3.html: Added.
fast/viewport/viewport-30-expected.txt: Added.
fast/viewport/viewport-30.html: Added.
fast/viewport/viewport-31-expected.txt: Added.
fast/viewport/viewport-31.html: Added.
fast/viewport/viewport-32-expected.txt: Added.
fast/viewport/viewport-32.html: Added.
fast/viewport/viewport-33-expected.txt: Added.
fast/viewport/viewport-33.html: Added.
fast/viewport/viewport-34-expected.txt: Added.
fast/viewport/viewport-34.html: Added.
fast/viewport/viewport-35-expected.txt: Added.
fast/viewport/viewport-35.html: Added.
fast/viewport/viewport-36-expected.txt: Added.
fast/viewport/viewport-36.html: Added.
fast/viewport/viewport-37-expected.txt: Added.
fast/viewport/viewport-37.html: Added.
fast/viewport/viewport-38-expected.txt: Added.
fast/viewport/viewport-38.html: Added.
fast/viewport/viewport-39-expected.txt: Added.
fast/viewport/viewport-39.html: Added.
fast/viewport/viewport-4-expected.txt: Added.
fast/viewport/viewport-4.html: Added.
fast/viewport/viewport-40-expected.txt: Added.
fast/viewport/viewport-40.html: Added.
fast/viewport/viewport-41-expected.txt: Added.
fast/viewport/viewport-41.html: Added.
fast/viewport/viewport-42-expected.txt: Added.
fast/viewport/viewport-42.html: Added.
fast/viewport/viewport-43-expected.txt: Added.
fast/viewport/viewport-43.html: Added.
fast/viewport/viewport-44-expected.txt: Added.
fast/viewport/viewport-44.html: Added.
fast/viewport/viewport-45-expected.txt: Added.
fast/viewport/viewport-45.html: Added.
fast/viewport/viewport-46-expected.txt: Added.
fast/viewport/viewport-46.html: Added.
fast/viewport/viewport-47-expected.txt: Added.
fast/viewport/viewport-47.html: Added.
fast/viewport/viewport-48-expected.txt: Added.
fast/viewport/viewport-48.html: Added.
fast/viewport/viewport-49-expected.txt: Added.
fast/viewport/viewport-49.html: Added.
fast/viewport/viewport-5-expected.txt: Added.
fast/viewport/viewport-5.html: Added.
fast/viewport/viewport-50-expected.txt: Added.
fast/viewport/viewport-50.html: Added.
fast/viewport/viewport-51-expected.txt: Added.
fast/viewport/viewport-51.html: Added.
fast/viewport/viewport-52-expected.txt: Added.
fast/viewport/viewport-52.html: Added.
fast/viewport/viewport-53-expected.txt: Added.
fast/viewport/viewport-53.html: Added.
fast/viewport/viewport-54-expected.txt: Added.
fast/viewport/viewport-54.html: Added.
fast/viewport/viewport-55-expected.txt: Added.
fast/viewport/viewport-55.html: Added.
fast/viewport/viewport-56-expected.txt: Added.
fast/viewport/viewport-56.html: Added.
fast/viewport/viewport-57-expected.txt: Added.
fast/viewport/viewport-57.html: Added.
fast/viewport/viewport-58-expected.txt: Added.
fast/viewport/viewport-58.html: Added.
fast/viewport/viewport-59-expected.txt: Added.
fast/viewport/viewport-59.html: Added.
fast/viewport/viewport-6-expected.txt: Added.
fast/viewport/viewport-6.html: Added.
fast/viewport/viewport-60-expected.txt: Added.
fast/viewport/viewport-60.html: Added.
fast/viewport/viewport-61-expected.txt: Added.
fast/viewport/viewport-61.html: Added.
fast/viewport/viewport-62-expected.txt: Added.
fast/viewport/viewport-62.html: Added.
fast/viewport/viewport-63-expected.txt: Added.
fast/viewport/viewport-63.html: Added.
fast/viewport/viewport-64-expected.txt: Added.
fast/viewport/viewport-64.html: Added.
fast/viewport/viewport-65.html: Added.
fast/viewport/viewport-66-expected.txt: Added.
fast/viewport/viewport-66.html: Added.
fast/viewport/viewport-67-expected.txt: Added.
fast/viewport/viewport-67.html: Added.
fast/viewport/viewport-68-expected.txt: Added.
fast/viewport/viewport-68.html: Added.
fast/viewport/viewport-69-expected.txt: Added.
fast/viewport/viewport-69.html: Added.
fast/viewport/viewport-7-expected.txt: Added.
fast/viewport/viewport-7.html: Added.
fast/viewport/viewport-70-expected.txt: Added.
fast/viewport/viewport-70.html: Added.
fast/viewport/viewport-71-expected.txt: Added.
fast/viewport/viewport-71.html: Added.
fast/viewport/viewport-72-expected.txt: Added.
fast/viewport/viewport-72.html: Added.
fast/viewport/viewport-73-expected.txt: Added.
fast/viewport/viewport-73.html: Added.
fast/viewport/viewport-74-expected.txt: Added.
fast/viewport/viewport-74.html: Added.
fast/viewport/viewport-75-expected.txt: Added.
fast/viewport/viewport-75.html: Added.
fast/viewport/viewport-76-expected.txt: Added.
fast/viewport/viewport-76.html: Added.
fast/viewport/viewport-77-expected.txt: Added.
fast/viewport/viewport-77.html: Added.
fast/viewport/viewport-78-expected.txt: Added.
fast/viewport/viewport-78.html: Added.
fast/viewport/viewport-79-expected.txt: Added.
fast/viewport/viewport-79.html: Added.
fast/viewport/viewport-8-expected.txt: Added.
fast/viewport/viewport-8.html: Added.
fast/viewport/viewport-80-expected.txt: Added.
fast/viewport/viewport-80.html: Added.
fast/viewport/viewport-81-expected.txt: Added.
fast/viewport/viewport-81.html: Added.
fast/viewport/viewport-82.html: Added.
fast/viewport/viewport-83-expected.txt: Added.
fast/viewport/viewport-83.html: Added.
fast/viewport/viewport-84.html: Added.
fast/viewport/viewport-85-expected.txt: Added.
fast/viewport/viewport-85.html: Added.
fast/viewport/viewport-86-expected.txt: Added.
fast/viewport/viewport-86.html: Added.
fast/viewport/viewport-87.html: Added.
fast/viewport/viewport-88-expected.txt: Added.
fast/viewport/viewport-88.html: Added.
fast/viewport/viewport-9-expected.txt: Added.
fast/viewport/viewport-9.html: Added.
fast/viewport/viewport-90-expected.txt: Added.
fast/viewport/viewport-90.html: Added.
platform/gtk/Skipped: Skip tests due to missing DRT support.
platform/mac/Skipped: Skip tests due to missing DRT support.
platform/win/Skipped: Skip tests due to missing DRT support.
platform/qt/Skipped: Skip failing tests.

3:15 AM Changeset in webkit [67375] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't add empty strings to list of supported image MIME types
https://bugs.webkit.org/show_bug.cgi?id=45643

After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
returns an empty string instead of "application/octet-stream" for unsupported
extensions. Don't add these to the list of supported types, and clean out
the logic that removed "application/octet-stream" from supported types.

Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
a HashSet<String>.

platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):

3:12 AM Changeset in webkit [67374] by mjs@apple.com

2 edits in trunk/LayoutTests

2010-09-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Re-skip some layout tests that fail on the bots but not on my system
https://bugs.webkit.org/show_bug.cgi?id=45626

platform/mac-wk2/Skipped:

2:50 AM Changeset in webkit [67373] by abarth@webkit.org

2 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Attempted Qt build fix.

html/parser/HTMLElementStack.cpp:

2:19 AM Changeset in webkit [67372] by abarth@webkit.org

6 edits in trunk

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636

Add some tests of breaking out of foreign content.

html5lib/resources/webkit01.dat:

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636

Now breaking out of foreign content doesn't always bring you back to
HTML. If you have a foreign content element that can contain HTML, you
just get brought back to that element.

html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
html/parser/HTMLElementStack.h:
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndOfFile):

1:58 AM Changeset in webkit [67371] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-09-13 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't call _msize
https://bugs.webkit.org/show_bug.cgi?id=45556

Because Brew MP uses its own memory allocator, it is not correct to use
_msize in fastMallocSize. Add !PLATFORM(BREWMP) guard.

wtf/FastMalloc.cpp: (WTF::fastMallocSize):

1:39 AM Changeset in webkit [67370] by abarth@webkit.org

2 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert notImplemented() to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=45639

The reason we never implemented this state is because it's not actually
reachable.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

1:20 AM Changeset in webkit [67369] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ScrollAnimatorWin
https://bugs.webkit.org/show_bug.cgi?id=45595

Use fabs() instead of abs().

platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::animateScroll):

1:03 AM Changeset in webkit [67368] by commit-queue@webkit.org

1 edit
2 adds in trunk/WebKit/wince

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

Add FrameNetworkingContextWinCE
https://bugs.webkit.org/show_bug.cgi?id=45474

WebCoreSupport/FrameNetworkingContextWinCE.cpp: Added. (WebKit::FrameNetworkingContextWinCE::FrameNetworkingContextWinCE): (WebKit::FrameNetworkingContextWinCE::userAgent): (WebKit::FrameNetworkingContextWinCE::referrer):
WebCoreSupport/FrameNetworkingContextWinCE.h: Added. (WebKit::FrameNetworkingContextWinCE::create):

12:22 AM Changeset in webkit [67367] by abarth@webkit.org

2 edits in trunk/WebCore

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove fixed FIXME
https://bugs.webkit.org/show_bug.cgi?id=45637

The spec made assertions that were false. Hixie fixed the spec by
removing the assertions. There's no need to keep these FIXMEs in the
code.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):

Sep 12, 2010:

11:43 PM Changeset in webkit [67366] by abarth@webkit.org

3 edits
8 adds in trunk

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634

Add tests recommended by Hixie.

fast/parser/form-pointer-1-expected.txt: Added.
fast/parser/form-pointer-1.html: Added.
fast/parser/form-pointer-2-expected.txt: Added.
fast/parser/form-pointer-2.html: Added.
fast/parser/form-pointer-3-expected.txt: Added.
fast/parser/form-pointer-3.html: Added.
fast/parser/form-pointer-4-expected.txt: Added.
fast/parser/form-pointer-4.html: Added.

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634

The spec changed to say what we do here so this FIXME isn't needed
anymore.

Tests: fast/parser/form-pointer-1.html

fast/parser/form-pointer-2.html
fast/parser/form-pointer-3.html
fast/parser/form-pointer-4.html

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):

11:24 PM Changeset in webkit [67365] by commit-queue@webkit.org

6 edits
5 adds in trunk

2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

scrollbars/resources/scrollable-iframe.html: Added.
scrollbars/scrollevent-iframe-no-scrolling-expected.txt: Added.
scrollbars/scrollevent-iframe-no-scrolling-wheel-expected.txt: Added.
scrollbars/scrollevent-iframe-no-scrolling-wheel.html: Added.
scrollbars/scrollevent-iframe-no-scrolling.html: Added.

2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html

scrollbars/scrollevent-iframe-no-scrolling.html

page/FrameView.cpp: (WebCore::FrameView::valueChanged): Added.
page/FrameView.h: Added a new method.
platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged): Added. (WebCore::ScrollView::updateScrollbars):
platform/ScrollView.h: Added a new method.

10:45 PM Changeset in webkit [67364] by abarth@webkit.org

5 edits in trunk/LayoutTests

2010-09-12 Adam Barth <abarth@webkit.org>

Revert mistaken changes to test baselines.

platform/mac/http/tests/navigation/post-goback1-expected.txt:
platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
platform/mac/http/tests/navigation/postredirect-frames-expected.txt:
platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:

9:21 PM Changeset in webkit [67363] by tkent@chromium.org

6 edits in trunk

2010-09-12 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517

DEPS: Roll Chromium revision to r59033 to have webkit_support_gfx.h.
WebKit.gyp:

2010-09-12 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517

Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h

DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): (Image::createFromFilename): (diffImages):
DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):

9:21 PM Changeset in webkit [67362] by morrita@google.com

15 edits in trunk

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Add an note for API readiness.

platform/chromium/test_expectations.txt:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Added an API for testing marker state.
We locate this here instead of DRT for sharing the logic between
multiple ports.

WebCore.exp.in:
editing/Editor.cpp: (WebCore::Editor::selectionStartHasSpellingMarkerFor):
editing/Editor.h:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Exported Frame::selectionStartHasSpellingMarkerFor() for DRT use.

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
src/WebFrameImpl.h:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Moved the actual logic of hasSpellingMarker into WebCore to share
it with other ports.

WebView/WebFrame.mm: (-[WebFrame hasSpellingMarker:length:]):

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Added TextInputController::hasSpellingMarker().

DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::hasSpellingMarker):
DumpRenderTree/chromium/TextInputController.h:

8:30 PM Changeset in webkit [67361] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Think this is the last set.

platform/chromium/test_expectations.txt:

8:19 PM Changeset in webkit [67360] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Suppress some more failures so I can triage the WebKit roll
without the tree being red.

platform/chromium/test_expectations.txt:

7:39 PM Changeset in webkit [67359] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Suppress some failures so I can
triage the WebKit roll without the tree being red.

platform/chromium/test_expectations.txt:

6:09 PM Changeset in webkit [67358] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix a duplicate expectation and
remove some passing tests.

platform/chromium/test_expectations.txt:

6:04 PM Changeset in webkit [67357] by abarth@webkit.org

10 edits in trunk

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570

Before this patch, we were using an unsafe pattern of walking the
sibling list without grabbing references. Instead, we should use the
shiny new takeAllChildrenFrom method that shoves the children into a
vector first. Also, update takeAllChildrenFrom to handle the case
where the old parent is attached.

dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom):
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
html/parser/HTMLTreeBuilder.h:

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570

More test cases.

html5lib/resources/webkit01.dat:

5:42 PM Changeset in webkit [67356] by abarth@webkit.org

5 edits in trunk

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621

Add new tests and (minor) test progression.

html5lib/resources/webkit01.dat:
html5lib/runner-expected.txt:

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621

Update our list of special tags to match the spec.

html/parser/HTMLTreeBuilder.cpp:

5:19 PM Changeset in webkit [67355] by robert@webkit.org

5 edits in trunk

2010-09-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

Unskip http/tests/navigation/reload-subframe-object.html

https://bugs.webkit.org/show_bug.cgi?id=45613

platform/qt/Skipped:

2010-09-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

We need to bring our use of getMimeTypeForPath() and
getMimeTypeForExtension() into line with WebCore expectations.

We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
where an empty mimetype should be returned if no match is found, and
MIMETypeRegistry::getMIMETypeForPath() for cases where
'application/octet-stream' should be returned if no match is found.

Fixes http/tests/navigation/reload-subframe-object.html

Based on findings in webkit.org/b/31398 and webkit.org/b/15554.

https://bugs.webkit.org/show_bug.cgi?id=45613

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

5:02 PM Changeset in webkit [67354] by mjs@apple.com

2 edits in trunk/LayoutTests

2010-09-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by James Robinson.

Remove some tests from the WebKit2 skipped list that are now passing
https://bugs.webkit.org/show_bug.cgi?id=45625

platform/mac-wk2/Skipped:

4:40 PM Changeset in webkit [67353] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

4:37 PM Changeset in webkit [67352] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

My last change accidentally contained a local change to the
rebaselinig script; webkit-patch land picked it up without telling
me and committed it :(

Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

4:34 PM Changeset in webkit [67351] by dpranke@chromium.org

3 edits in trunk

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

4:04 PM Changeset in webkit [67350] by mitz@apple.com

2 edits in trunk/WebCore

Neglect unlikely hyphenation opportunities
https://bugs.webkit.org/show_bug.cgi?id=45606

Reviewed by Adele Peterson.

Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about
3% of the hyphenation opportunities.

rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more
than 5/4 the font size.

3:58 PM Changeset in webkit [67349] by jamesr@google.com

5 edits
16 adds
3 deletes in trunk/LayoutTests

2010-09-12 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r67328.
http://trac.webkit.org/changeset/67328
https://bugs.webkit.org/show_bug.cgi?id=45610

Broke layout tests on mac and chromium.

http/tests/navigation/post-basic-expected.txt: Removed.
http/tests/navigation/post-basic.html:
http/tests/navigation/post-frames-expected.txt: Removed.
http/tests/navigation/post-frames.html:
http/tests/navigation/resources/page-that-posts.html: Removed.
http/tests/navigation/resources/postresult.pl:
platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Added.
platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Added.
platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Added.
platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Added.
platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Added.
platform/chromium-win/http/tests/navigation/post-basic-expected.png: Added.
platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Added.
platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Added.
platform/chromium-win/http/tests/navigation/post-frames-expected.png: Added.
platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/mac/http/tests/navigation/post-basic-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.checksum.
platform/mac/http/tests/navigation/post-basic-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.png.
platform/mac/http/tests/navigation/post-basic-expected.txt: Added.
platform/mac/http/tests/navigation/post-frames-expected.checksum: Added.
platform/mac/http/tests/navigation/post-frames-expected.png: Added.
platform/mac/http/tests/navigation/post-frames-expected.txt: Added.

2:19 PM Changeset in webkit [67348] by Simon Hausmann

2 edits in trunk/WebKit/qt

doc: Changed the title so lists of contents sort better.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

docs/qtwebkit.qdoc:

2:08 PM Changeset in webkit [67347] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: More work on the QML documentation.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

declarative/qdeclarativewebview.cpp:

1:58 PM Changeset in webkit [67346] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qml] Ensure WebView gets focus when an editable node is clicked on.

Patch by Martin Jones <martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-13342

declarative/qdeclarativewebview.cpp:

(GraphicsWebView::mousePressEvent):

1:56 PM Changeset in webkit [67345] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: qdoc fixes.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

declarative/qdeclarativewebview.cpp:

1:53 PM Changeset in webkit [67344] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] fix qt_webkit_version.pri install for in-Qt builds

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.

Task-number: QTBUG-13306

WebCore.pro:

1:50 PM Changeset in webkit [67343] by Simon Hausmann

4 edits in trunk

WebCore: [Qt] Let QtWebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.

Task-number: QTBUG-12379

WebCore.pro:

WebKit/qt: [Qt] let WebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-12379

qt_webkit_version.pri: Use the faster + instead of *

operator to add webkit to the config.

1:44 PM Changeset in webkit [67342] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Fix group of declarative web view in QML docs.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

declarative/qdeclarativewebview.cpp:

12:08 PM Changeset in webkit [67341] by Simon Hausmann

5 edits in trunk/LayoutTests

[Qt] Rebase a bunch of tests after r67200.

Reviewed by Antonio Gomes.

platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:

11:40 AM Changeset in webkit [67340] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Build fix.

WebCore.pro: Re-add erroneously removed sources.

11:35 AM Changeset in webkit [67339] by andreas.kling@nokia.com

6 edits in trunk

2010-09-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618

Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG
paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1.

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
platform/graphics/Path.h:
platform/graphics/qt/PathQt.cpp:

2010-09-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618

Skip fast/canvas/canvas-closePath-single-point.html - it can be unskipped again
once the bot is upgraded to Qt 4.7.1.

platform/qt/Skipped:

11:32 AM Changeset in webkit [67338] by Simon Hausmann

2 edits in trunk/WebCore

Fix the Gtk and minimal builds.

plugins/PluginView.cpp:

(WebCore::PluginView::npObject): Correct the #ifdefs.
(WebCore::PluginView::bindingInstance): Moved npErr variable
into npObject() function where it is used.

11:28 AM Changeset in webkit [67337] by Simon Hausmann

3 edits in trunk/WebCore

[Qt] Prospective build fix for minimal build.

plugins/PluginView.cpp: Guard newly added function

by ENABLE_NETSCAPE_PLUGIN feature.
(WebCore::PluginView::npObject):

plugins/PluginView.h:

11:21 AM Changeset in webkit [67336] by Simon Hausmann

3 edits in trunk/WebKit/qt

[Qt] Partial implementation of Qt bridge using V8 and QtScript.

Reviewed by Andreas Kling.

Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript): Stub it out for now,
to compile, until we have a conversion path between v8::Object
and QScriptValue.

Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject): Implemented using
few lines of QtScript code.
(QWebFrame::evaluateJavaScript): Ditto.

11:19 AM Changeset in webkit [67335] by Simon Hausmann

4 edits
1 add in trunk/WebCore

[Qt] Add support for binding QtWebKit to a QScriptEngine.

Reviewed by Andreas Kling.

The ScriptController owns the V8 context, and this patch
for the Qt build also gives it a QScriptEngine, that has
been instructed to adopt the V8 context.

This is the enabler for the QObject bindings, used in
the API and DRT.

WebCore.pro:
bindings/v8/ScriptController.cpp: Include QScriptEngine

for the Qt build, to let the ~ScriptController destructor
find the QScriptEngine destructor (via OwnPtr).

bindings/v8/ScriptController.h: Declare getters.
bindings/v8/ScriptControllerQt.cpp: Added.

(WebCore::ScriptController::qtScriptEngine): Implement
engine adoption.

11:15 AM Changeset in webkit [67334] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Last bits and pieces for a V8 build.

Reviewed by Andreas Kling.

When building with V8, get it from QtScript.

WebCore.pro: Use QtScript, removed non-existant

bridge files from the build.

11:12 AM Changeset in webkit [67333] by Simon Hausmann

4 edits
2 adds in trunk/WebCore

[Qt] Add PlatformBridge for V8 build.

Reviewed by Andreas Kling.

Add the minimalisting platform bridge with the two
methods needed by NPV8Object.cpp.

WebCore.pro:
platform/qt/PlatformBridge.h: Added.
platform/qt/PlatformBridgeQt.cpp: Added.

(WebCore::PlatformBridge::popupsAllowed):
(WebCore::PlatformBridge::pluginScriptableObject):

plugins/PluginView.cpp: Refactor the plugin object

retrieval code into a separate function, called by
bindingInstance() and PlatformBridge.
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):

plugins/PluginView.h:

11:08 AM Changeset in webkit [67332] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fix the build with V8.

Reviewed by Andreas Kling.

This is a temporary kludge until the scriptworld stuff is properly
ported, as part of the upcoming DRT work.

Api/qwebscriptworld.cpp:

(QWebScriptWorld::QWebScriptWorld):

11:08 AM Changeset in webkit [67331] by Simon Hausmann

2 edits in trunk/WebCore

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

This changes brings the file in sync with its copy in bridge/,
adding additional conflicting X11 keywords to undef. This is
a temporary fix until the file is removed altogether, which is
tracked in https://bugs.webkit.org/show_bug.cgi?id=45617

bindings/v8/npruntime_internal.h:

10:38 AM Changeset in webkit [67330] by jer.noble@apple.com

4 edits in trunk/WebCore

2010-09-11 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

http/tests/media/text-served-as-text.html failing on Windows (Debug+Release)
https://bugs.webkit.org/show_bug.cgi?id=45603

Disable the eat/text components under Windows the same way as we do on the Mac.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
platform/graphics/win/QTMovie.cpp:
platform/graphics/win/QTMovie.h:

9:57 AM Changeset in webkit [67329] by Simon Hausmann

4 edits in trunk/WebCore

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

These headers include npruntime, which drag on X11Resources.h, which
among other things #define's None and Boolean. Later on v8.h is included,
which declares these in enums and therefore conflicts. npruntime_internal.h
was introduced exactly to address this problem by including npruntime.h
and undeff'ing the offending constants.

bindings/v8/V8Helpers.h:
bindings/v8/V8NPObject.h:
bindings/v8/V8NPUtils.h:

8:11 AM Changeset in webkit [67328] by Dimitri Glazkov

5 edits
3 adds
16 deletes in trunk/LayoutTests

2010-09-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610

post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.

http/tests/navigation/post-basic-expected.txt: Added.
http/tests/navigation/post-basic.html:
http/tests/navigation/post-frames-expected.txt: Added.
http/tests/navigation/post-frames.html:
http/tests/navigation/resources/page-that-posts.html: Added.
http/tests/navigation/resources/postresult.pl:
platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
platform/chromium/test_expectations.txt:
platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.

7:47 AM Changeset in webkit [67327] by Simon Hausmann

2 edits in trunk/WebCore

Gtk build fix.

Use false instead of False after
http://trac.webkit.org/changeset/67323

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):

7:28 AM Changeset in webkit [67326] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.

Reviewed by Andreas Kling.

bindings/v8/V8Binding.cpp:

(WebCore::WebCoreStringResource::WebCoreStringResource): In this
line an AtomicString should be converted to a WTF::String. The former
has a conversion operator to the latter, to be able to call the
WTF::String copy constructor. When compiling with Qt, then AtomicString
also has a conversion operator to QString _and_ WTF::String has an
implicit constructor that takes a QString. Therefore the compiler is
confused and not sure which conversion to prefer, the one that isn't
actually a conversion - going to WTF::String - or the conversion from
AtomicString to QString and then constructing the WTF::String from
a QString. To resolve this ambiguity we explicitly call the string()
helper function on the AtomicString, which is equivalent to the
operator WTF::String().

6:57 AM Changeset in webkit [67325] by Simon Hausmann

3 edits in trunk/WebCore

Fix the build without JSC.

Reviewed by Andreas Kling.

Complement http://trac.webkit.org/changeset/59826 and
add missing JSC guards.

plugins/PluginView.cpp:

(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):

plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

6:57 AM Changeset in webkit [67324] by Simon Hausmann

3 edits in trunk/WebCore

Fix compilation with V8 and XPath enabled.

Reviewed by Andreas Kling.

V8XPathNSResolver.cpp includes V8XPathNSResolver.h,
which includes V8DOMWrapper.h as its first header.
V8DOMWrapper.h then uses V8XPathNSResolver in an inline
function, and gcc doesn't seem to like this, because
at this point the type isn't known ("V8XPathNSResolver
has not been declared"). Forward declaring the type
doesn't help unfortunately: "incomplete type
'WebCore::V8XPathNSResolver' used in nested name
specifier".

To resolve this circular dependency, this patch moves
the inline function into the .cpp file.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

bindings/v8/V8DOMWrapper.h:

6:33 AM Changeset in webkit [67323] by Simon Hausmann

4 edits in trunk/WebCore

[Qt][X11] Fix build with V8 against X11 headers.

Reviewed by Andreas Kling.

Added "True" and "False" to the list of words
we free from the X11 macro jail.

bridge/npruntime_internal.h:
config.h: The V8 bindings end up indirectly pulling

in X11 headers and they use True/False. There's no
central header apart from this one, so include the
x11 fixing header here for Qt/X11/V8.

plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paint): Use false instead of False
since False isn't available anymore.

6:28 AM Changeset in webkit [67322] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix compilation with V8 and Qt.

Reviewed by Andreas Kling.

Use WebKit's page cache for ScriptCachedFrameData.

bindings/v8/ScriptCachedFrameData.h:

6:25 AM Changeset in webkit [67321] by Simon Hausmann

2 edits in trunk/WebCore

Fix compiler warning.

Reviewed by Andreas Kling.

NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't
initialized explicitly.

bindings/v8/NPV8Object.cpp:

4:16 AM Changeset in webkit [67320] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-12 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] get_n_selections and get_selection fail when selecting text across object boundaries
https://bugs.webkit.org/show_bug.cgi?id=26991

Fix AtkText getNSelections() and getSelection() to work properly

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): Check that both the selection intersects the node AND that the selection is not just "touching" one of the boundaries for the selected node. We want to check whether the node is actually inside the region, at least partially (getSelectionOffsetsForObject): New function to get the start and end offsets of a selection for a given accessible object. (webkit_accessible_text_get_selection): Return zero when both start and end offsets are equal, following the lead of GAIL.

12:37 AM Changeset in webkit [67319] by mjs@apple.com

2 edits in trunk/LayoutTests

2010-09-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Animations don't seem to run in multiple WebKit2 animation tests
https://bugs.webkit.org/show_bug.cgi?id=42137

platform/mac-wk2/Skipped: These tests no longer fail, so simply unskip them.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed