Timeline
Sep 14, 2010:
- 11:41 PM Changeset in webkit [67538] by
-
- 8 edits2 adds in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
https://bugs.webkit.org/show_bug.cgi?id=45724
No new tests; tests will be added later.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDirectoryEntryCustom.cpp: Added. (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
- fileapi/DirectoryEntry.h:
- fileapi/DirectoryEntry.idl:
- 10:59 PM Changeset in webkit [67537] by
-
- 5 edits3 adds1 delete in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline to fix build.
[chromium] rebaselines for bug16012.html after font-size changes
https://bugs.webkit.org/show_bug.cgi?id=45805
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.png: Added.
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.txt:
- 10:26 PM Changeset in webkit [67536] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline.
Rebaseline xss-DENIED-frame-name-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=45795
- platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- 10:03 PM Changeset in webkit [67535] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Attempt to fix test failure on Qt and Gtk. It's tricky to write a test
for an API that supposed to report the current date and time without a
timezone. This patch increases the allowably time window to a day +
one hour, which should be enough to account for any timezone issues.
- http/tests/misc/no-last-modified.html:
- 9:38 PM Changeset in webkit [67534] by
-
- 12 edits in trunk
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp: (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp: (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() when autocorrection panel is shown. (WebCore::createCommandMap): Replaced isSupported function pointer for executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, for invalid correction panel tag. Replaced -1 with this constant. (WebEditorClient::dismissCorrectionPanel): Ditto (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 9:09 PM Changeset in webkit [67533] by
-
- 2 edits in trunk/WebKit/mac
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
- WebView/WebView.mm: (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
when the application level preferences are not set.
- 8:47 PM Changeset in webkit [67532] by
-
- 12 edits in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fileapi/ThreadableBlobRegistry.cpp: (WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- src/ResourceHandle.cpp:
- 8:37 PM Changeset in webkit [67531] by
-
- 2 edits in trunk/WebCore
2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Zoom factor for checkboxes and radios.
https://bugs.webkit.org/show_bug.cgi?id=45776
RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.
Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
- 8:19 PM Changeset in webkit [67530] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-14 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add AudioFileReader files (Mac implementation)
https://bugs.webkit.org/show_bug.cgi?id=36475
No new tests since audio API is not yet implemented.
- platform/audio/AudioFileReader.h: Added.
- platform/audio/mac/AudioFileReaderMac.cpp: Added. (WebCore::createAudioBufferList): (WebCore::destroyAudioBufferList): (WebCore::AudioFileReader::AudioFileReader): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::readProc): (WebCore::AudioFileReader::getSizeProc): (WebCore::AudioFileReader::createBus): (WebCore::createBusFromAudioFile): (WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h: Added. (WebCore::AudioFileReader::data): (WebCore::AudioFileReader::dataSize):
- 7:31 PM Changeset in webkit [67529] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
https://bugs.webkit.org/show_bug.cgi?id=44764
- wtf/OwnPtrCommon.h:
- wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
- 7:04 PM Changeset in webkit [67528] by
-
- 2 edits1 add in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugs.webkit.org should autocomplete WebKit Committers and Reviewers
https://bugs.webkit.org/show_bug.cgi?id=45799
This patch implements an autocomplete dropdown that helps users type
the names of WebKit committers and reviewers. The script grabs the
data from SVN now that wms set up CORS for http://svn.webkit.org.
Security technology for the win.
This script is based on (well, essentially copied from) the popular
autocomplete extension:
https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb
I asked Ojan, and said he was fine licensing the code under the BSD
license. I'm not sure how the patch interacts with the extension, but
we can retire the extension if they interact poorly.
- committers-autocomplete.js: Added.
- template/en/default/global/footer.html.tmpl:
- Add the script to every page on bugs.webkit.org
- 6:59 PM Changeset in webkit [67527] by
-
- 2 edits in trunk/WebKitTools
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156
Move printf inside shouldDumpAccessibilityNotifications check.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- 6:55 PM Changeset in webkit [67526] by
-
- 2 edits in trunk/WebCore
2010-09-14 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
Drawing an image outside the bounds of a canvas still causes repaints
https://bugs.webkit.org/show_bug.cgi?id=45792
Some canvas examples, such as http://www.phoboslab.org/biolab/, draw
images outide the bounds of the canvas. If the canvas already had a
non-empty m_dirtyRect, such draws would cause us to do a repaint of
m_dirtyRect again (which goes through the platform-specific invalidation
machinery, which can be slow).
Optimize this by avoiding extra invalidation when the dirty rect
does not intersect the canvas bounds.
Not testable because this avoids additional repaints of m_dirtyRect, but
m_dirtyRect has to be non-empty for this to benefit.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
- 6:42 PM Changeset in webkit [67525] by
-
- 5 edits in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link
- inspector/front-end/inspector.js: code cleanup: removed no-op method (WebInspector.addMainEventListeners):
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- src/js/DevTools.js: remove obsolete code
- 6:26 PM BuildingGtk edited by
- (diff)
- 6:25 PM Changeset in webkit [67524] by
-
- 6 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DEPS: Include webkit_support::LocalFileToDataURL
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
- 6:23 PM Changeset in webkit [67523] by
-
- 3 edits in trunk/WebCore
2010-09-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Use codePage instead of TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=45466
Use codePage as member variable to avoid repeated lookup.
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode):
- platform/text/wince/TextCodecWinCE.h:
- 5:48 PM Changeset in webkit [67522] by
-
- 2 edits in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Add a license block to the reviewtool. I should have added this from
the start. According to the SVN log, I'm the only one to have ever
touched this file.
- code-review.js:
- 5:45 PM Changeset in webkit [67521] by
-
- 5 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- public/WebKit.h:
- src/WebKit.cpp:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
- 5:36 PM Changeset in webkit [67520] by
-
- 2 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Attempted Chromium build fix. The compiler can't tell that
ASSERT_NOT_REACHED is not reached and so it demands an initialization
of this variable.
- html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
- 5:34 PM Changeset in webkit [67519] by
-
- 3 edits in trunk/WebKit/efl
2010-09-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] ewk_frame_view_create_for_view set null as theme.
https://bugs.webkit.org/show_bug.cgi?id=45741
Add theme in ewk_view to use instead of frame's theme which is null in
ewk_frame_view_create_for_view.
- ewk/ewk_frame.cpp: (ewk_frame_view_create_for_view):
- ewk/ewk_view.cpp: (ewk_view_theme_set): (ewk_view_theme_get):
- 5:19 PM Changeset in webkit [67518] by
-
- 5 edits in trunk/WebKit/mac
Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
Reviewed by John Sullivan.
- Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
- Misc/WebKitVersionChecks.m:
(WebKitLinkedOnOrAfter):
(setWebKitLinkTimeVersion): Set the overridden version.
(WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
- WebView/WebPreferences.mm:
(+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
- WebView/WebPreferencesPrivate.h:
- 5:19 PM Changeset in webkit [67517] by
-
- 4 edits in trunk
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Remove blob-related tests that now pass.
- platform/chromium/drt_expectations.txt:
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Roll Chromium forward to r59406, which registers the blob
URL scheme for the Chromium DRT too.
- DEPS:
- 4:53 PM Changeset in webkit [67516] by
-
- 2 edits in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Wheeling over windowed plugins sometimes cause them to disappear
- plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::x11Event): Pass on captured mouse wheel events to the effective native window rather than the grandparent widget. We were calling QWidget::winId() which caused a new X11 window to be created for the grandparent widget and generally mess things up.
- 4:46 PM Changeset in webkit [67515] by
-
- 8 edits1 add in trunk
[wx] Build fixes after recent changes.
- 4:32 PM Changeset in webkit [67514] by
-
- 7 edits in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update font size parser to match HTML5 spec. The main difference here
is the handling of 0, which now maps to 1 instead of 3.
- html/HTMLFontElement.cpp: (WebCore::parseFontSize): (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update tests and results to match new behavior.
- editing/execCommand/query-font-size-expected.txt:
- fast/dom/HTMLFontElement/script-tests/size-attribute.js:
- fast/dom/HTMLFontElement/size-attribute-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
- 4:29 PM Changeset in webkit [67513] by
-
- 3 edits5 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
Implement document.lastModified as per HTML5.
Tests: http/tests/misc/last-modified-parsing.html
http/tests/misc/no-last-modified.html
- dom/Document.cpp: (WebCore::Document::lastModified):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
- http/tests/misc/last-modified-parsing-expected.txt: Added.
- http/tests/misc/last-modified-parsing.html: Added.
- Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
- http/tests/misc/no-last-modified-expected.txt: Added.
- http/tests/misc/no-last-modified.html: Added.
- Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
- http/tests/resources/last-modified.php: Added.
- PHP helper script.
- 4:27 PM Changeset in webkit [67512] by
-
- 7 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Moving the compatMode IDL attribute from HTMLDocument.idl to
Document.idl fixes this bug and improve compliance with HTML5.
Test: fast/parser/compatMode-in-xhtml.xhtml
- dom/Document.cpp: (WebCore::Document::compatMode):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLDocument.cpp:
- html/HTMLDocument.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Test the value of compatMode in XHTML. I'm terrible at XML, but this
test seems to work.
- fast/parser/compatMode-in-xhtml-expected.txt: Added.
- fast/parser/compatMode-in-xhtml.xhtml: Added.
- 4:15 PM Changeset in webkit [67511] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-09-14 James Kozianski <soulplant@gmail.com>
Reviewed by Ojan Vafai.
Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window
https://bugs.webkit.org/show_bug.cgi?id=18447
Add a test for CSSStyleDeclaration.prototype.foo leaking into inner
windows.
- fast/frames/css-style-declaration-isolation-expected.txt: Added.
- fast/frames/css-style-declaration-isolation.html: Added.
- 4:13 PM Changeset in webkit [67510] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- win/WebKit2Generated.make:
- 4:12 PM Changeset in webkit [67509] by
-
- 3 edits3 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test: http/tests/security/xss-DENIED-frame-name.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheck):
- If the property name exists on the object, it will shadow the named property lookup on the window object. That means we need to block access if there's shadowing going on.
(WebCore::V8DOMWindow::indexedSecurityCheck):
- I made the corresponding change to this function too, but I don't think this one can actually be triggered because JavaScript variable names need to start with a non-digit.
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test whether cross-origin observers can see global variables shadowing
named frames.
- http/tests/security/resources/frame-for-parent-name.html: Added.
- http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- http/tests/security/xss-DENIED-frame-name.html: Added.
- 4:12 PM Changeset in webkit [67508] by
-
- 4 edits in branches/chromium/517/WebKit/chromium
Merge 67418 - 2010-09-13 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572
- public/WebAccessibilityObject.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/3398006
- 3:53 PM Changeset in webkit [67507] by
-
- 12 edits2 deletes in trunk
Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785
Reviewed by Anders Carlsson.
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Remove files.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleNode.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp:
(WKBundleRangeCopyStartContainer):
(WKBundleRangeCopyEndContainer):
- WebProcess/InjectedBundle/API/c/WKBundleRange.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
Change to be in terms of WKBundleNodeHandleRef.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 3:53 PM Changeset in webkit [67506] by
-
- 9 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Updated our integer parsing for tabindex to use the algorithm from the
HTML5 spec.
Test: fast/parser/tabindex-parsing-2.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTMLInteger):
- html/parser/HTMLParserIdioms.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
- fast/parser/tabindex-parsing-2-expected.txt: Added.
- fast/parser/tabindex-parsing-2.html: Added.
- Test a bunch of corner cases in tabindex parsing.
- fast/parser/tabindex-parsing-expected.txt:
- fast/parser/tabindex-parsing.html:
- Update expected result. This case is actually the one that the original reporter was complaining about.
- 3:48 PM Changeset in webkit [67505] by
-
- 2 edits in trunk/WebCore
Build correction, no review.
- WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from
non-Cairo based builds.
- 3:38 PM Changeset in webkit [67504] by
-
- 3 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:26 PM Changeset in webkit [67503] by
-
- 12 edits in trunk
fast/files/apply-blob-url-to-img.html timeout on Leopard
https://bugs.webkit.org/show_bug.cgi?id=45576
Reviewed by David Levin.
WebCore:
The failure on Leopard is caused by the static method
ResourceHandle::supportsBufferedData that returns true to indicate that
the buffered data support is enabled for blob resource. However,
BlobResourceHandle does not support this and we need to override this.
The fix is to change supportsBufferedData method from static to virtual
so that we can override the default behavior in BlobResourceHandle.
- fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread.
(WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::supportsBufferedData): Override the default
behavior.
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h: Made supportsBufferedData virtual.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::bufferedData):
WebKit/chromium:
- src/ResourceHandle.cpp: Remove the no longer applicable static comment.
LayoutTests:
Update the test to compute the right coordinates to drag the file to.
This fixes the problem that onInputFileChange() is not called on
Leopard.
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped: Remove the passing test from Skipped list.
- 3:19 PM Changeset in webkit [67502] by
-
- 1 edit24 deletes in trunk/LayoutTests
2010-09-14 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Remove the wrong chromium-win-vista expectations.
Layout test results generated from Chromium vista bots match
the expectations in chromium-win. These baselines are either
wrong or out of date. Need to be cleaned up so chromium
vista bots can pass on these tests.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.png: Removed.
- 3:00 PM Changeset in webkit [67501] by
-
- 4 edits in trunk
2010-09-14 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Exceptions are getting ignored on 64-bit Windows in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=45779
WebKit2:
- WebProcess/WebKitMain.cpp: (disableProcessCallbackFilterForExceptions): Clear the PROCESS_CALLBACK_FILTER_ENABLED flag so that exceptions thrown in callback routines are not ignored, as described in http://support.microsoft.com/kb/976038 and http://blog.paulbetts.org/index.php/2010/07/20/the-case-of-the-disappearing-onload-exception-user-mode-callback-exceptions-in-x64/. (WebKitMain):
WebKitSite:
- building/tools.html: Add instructions about how to optionally get hotfix 976038.
- 2:55 PM Changeset in webkit [67500] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Fixed layout test failure seen on buildbot by correcting expected results.
It looks like Darin accidentally checked in the wrong expected results.
- fast/css/visited-link-hang-expected.txt:
- 2:43 PM Changeset in webkit [67499] by
-
- 5 edits in trunk
Build correction, no review.
WebCore:
- WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp implementation file.
- platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include for <cairo.h>
WebKit2:
- win/WebKit2.vcproj: Disable build for Cairo targets of
the WebURLRequestWin.cpp and WebURLResponseWin.cpp files.
- 2:29 PM Changeset in webkit [67498] by
-
- 14 edits32 adds2 deletes in trunk
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
- WebKit.gyp:
- public/WebAccessibilityNotification.h: Added.
- public/WebViewClient.h: (WebKit::WebViewClient::postAccessibilityNotification):
- src/AssertMatchingEnums.h: Added.
- src/ChromeClientImpl.cpp: (WebKit::toWebAccessibilityNotification): (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren): (WebKit::ChromeClientImpl::postAccessibilityNotification):
- src/ChromeClientImpl.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html
platform/chromium/accessibility/post-notification-CheckedStateChanged.html
platform/chromium/accessibility/post-notification-ChildrenChanged.html
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html
platform/chromium/accessibility/post-notification-LayoutComplete.html
platform/chromium/accessibility/post-notification-LiveRegionChanged.html
platform/chromium/accessibility/post-notification-LoadComplete.html
platform/chromium/accessibility/post-notification-MenuListValueChanged.html
platform/chromium/accessibility/post-notification-RowCollapsed.html
platform/chromium/accessibility/post-notification-RowCountChanged.html
platform/chromium/accessibility/post-notification-RowExpanded.html
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html
platform/chromium/accessibility/post-notification-SelectedTextChanged.html
platform/chromium/accessibility/post-notification-ValueChanged.html
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- platform/chromium/accessibility/children-changed-notification-expected.txt: Removed.
- platform/chromium/accessibility/children-changed-notification.html: Removed.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete.html: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Added.
- platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LoadComplete.html: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed.html: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowExpanded.html: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Added.
- platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ValueChanged.html: Added.
- platform/chromium/accessibility/post-notification.js: Added. (enumAccessibilityObjects): (testDone): (test):
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:22 PM Changeset in webkit [67497] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Adam Roben.
Add an IWebFramePrivate API to load string as plain text into the WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=45782
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl: Touch the file.
- WebFrame.cpp: (WebFrame::loadPlainTextString):
- WebFrame.h:
- 2:10 PM Changeset in webkit [67496] by
-
- 3 edits2 adds in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
Test: fast/css/visited-link-hang.html
- platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): Added a start position argument and changed types to use size_t consistently instead of a mix. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::squeezeOutNullCharacters): Added. (WebCore::cleanSlashDotDotSlashes): Added. Factored out part of cleanPath (see below). (WebCore::mergeDoubleSlashes): Ditto. (WebCore::cleanSlashDotSlashes): Ditto. (WebCore::cleanPath): Changed algorithm to not remove as we go to avoid N2 behavior; instead replace with null characters and then do a squeeze operation after the fact. Also moved the body of the function out of line since we normally don't have to do any cleaning. This whole thing should go at some point -- it's not the right algorithm -- but this should eliminate the performance problems without changing behavior.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
- fast/css/visited-link-hang-expected.txt: Added.
- fast/css/visited-link-hang.html: Added.
- 2:07 PM Changeset in webkit [67495] by
-
- 4 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue is slow during the day
https://bugs.webkit.org/show_bug.cgi?id=45780
Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.
This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:06 PM Changeset in webkit [67494] by
-
- 5 edits in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- runtime/JSArray.cpp: (JSC::JSArray::sort): Replaced early exit for an array of length zero to instead exit for any array without values, even if it has a non-0 length.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- fast/js/script-tests/sort-large-array.js: Added test cases.
- fast/js/sort-large-array-expected.txt: Updated.
- 2:02 PM Changeset in webkit [67493] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: On Mac, let image layer data row order match skia.
https://bugs.webkit.org/show_bug.cgi?id=45400
Make CoreGraphics texture row order match skia's row order, remove all
code that worked around this difference. This also fixes a problem where
image layers would be drawn upside down.
Covered by existing layout tests, but we don't run these with
compositing yet.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::drawLayers):
- 1:45 PM Changeset in webkit [67492] by
-
- 2 edits in tags/Safari-534.7.2/JavaScriptCore
Merge r67482.
- 1:41 PM Changeset in webkit [67491] by
-
- 5 edits in tags/Safari-534.7.2
Versioning.
- 1:29 PM Changeset in webkit [67490] by
-
- 10 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
- fast/events/event-input-contentEditable-expected.txt: Merged two anchor elements.
- fast/events/event-input-contentEditable.html: Ditto.
- 1:27 PM Changeset in webkit [67489] by
-
- 1 copy in tags/Safari-534.7.2
New tag.
- 1:08 PM Changeset in webkit [67488] by
-
- 4 edits in trunk
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::ensureDebuggerScriptLoaded): Added, loads DebuggerScript.js into ScriptDebugServer. (WebCore::InspectorClientQt::openInspectorFrontend): Ensure that DebuggerScript.js is loaded before opening an inspector.
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- inspector/front-end/WebKit.qrc: Add DebuggerScript.js
- 12:56 PM Changeset in webkit [67487] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium win compile.
- public/WebView.h:
- 12:48 PM Changeset in webkit [67486] by
-
- 2 edits in trunk/WebCore
PPC Build fix.
- 12:44 PM Changeset in webkit [67485] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[chromium] Remove unused ICU headers
https://bugs.webkit.org/show_bug.cgi?id=45698
Remove unused headers.
- platform/graphics/chromium/FontCacheLinux.cpp:
- 12:23 PM Changeset in webkit [67484] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode
https://bugs.webkit.org/show_bug.cgi?id=17722
I believe our behavior matches the HTML5 spec. When we see a </x>, we
correctly kick out of standards mode. In the </> case, however, the
tokenizer just eats the bytes, without emitting a token, which means we
don't get kicked out of standards mode. Our behavior matches Minefield.
- fast/parser/strange-doctype-compatmode-1-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-1.html: Added.
- fast/parser/strange-doctype-compatmode-2-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-2.html: Added.
- 12:02 PM Changeset in webkit [67483] by
-
- 2 edits1 add in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Numpad Enter key returns keyCode 0 instead of 13
https://bugs.webkit.org/show_bug.cgi?id=45014
Original patch by Jarred Nicholls <jarred.nicholls@gmail.com>
There is a missing case statement in the PlatformKeyboardEventQt.cpp
file to handle the Enter button on the number pad. Because it is not
handled, the keyCode returned in a JavaScript event is 0 rather than 13.
Test: manual-tests/qt/numpad-enter-key.html
- manual-tests/qt/numpad-enter-key.html: Added.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 11:49 AM Changeset in webkit [67482] by
-
- 2 edits in trunk/JavaScriptCore
Windows production build fix.
Roll out r65143.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- 11:15 AM Changeset in webkit [67481] by
-
- 2 edits in trunk/WebCore
2010-09-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Fisher.
[chromium] building without debug syms broke after recent refactoring
https://bugs.webkit.org/show_bug.cgi?id=45720
Now that we build WebCore as multiple libraries, we need to adjust the
flags to turn off debug symbols for all of these libraries.
No new tests; should only affect an uncommon build flag.
- WebCore.gyp/WebCore.gyp:
- 10:59 AM Changeset in webkit [67480] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, remove tests that are now passing after Noel Gordon's
fix to test_shell delete key handling.
- platform/chromium/test_expectations.txt:
- 10:38 AM Changeset in webkit [67479] by
-
- 9 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- public/WebView.h: add WebView::setDomainRelaxationForbidden
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDomainRelaxationForbidden):
- src/WebViewImpl.h:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/chromium/LayoutTestController.h:
- 10:27 AM Changeset in webkit [67478] by
-
- 2 edits in trunk/WebCore
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile.
- platform/graphics/chromium/ImageLayerChromium.h:
- 10:16 AM Changeset in webkit [67477] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
[chromium]: crash less in compositor mode on mac
https://bugs.webkit.org/show_bug.cgi?id=45714
The contents image can go away when the dom is updated. Since the
layer tree is updated asynchronously, it needs to ref the native image,
else it will hold on to a stale object.
This still needs to be done for skia, too.
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- 10:04 AM Changeset in webkit [67476] by
-
- 2 edits in trunk/WebKit/efl
2010-09-14 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix: remove "virtual" keyword from
implementation file.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
- 9:49 AM Changeset in webkit [67475] by
-
- 3 edits1 move in trunk/JavaScriptCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Share UnicodeMacrosFromICU.h
https://bugs.webkit.org/show_bug.cgi?id=45710
glib, qt4 and wince use the same macros from ICU.
Remove the code duplication and use the same header file.
- wtf/unicode/UnicodeMacrosFromICU.h: Copied from JavaScriptCore/wtf/unicode/glib/UnicodeMacrosFromICU.h.
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Removed.
- wtf/unicode/qt4/UnicodeQt4.h:
- wtf/unicode/wince/UnicodeWince.h:
- 9:30 AM Changeset in webkit [67474] by
-
- 7 edits in trunk
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support for resource timings to HAREntry.
https://bugs.webkit.org/show_bug.cgi?id=45663
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildTimings): (WebInspector.HAREntry.prototype._toMilliseconds): (WebInspector.HAREntry.prototype._interval):
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
https://bugs.webkit.org/show_bug.cgi?id=45663
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resource-test2.js: Added entire timings object to list of non-deterministic fields.
- http/tests/inspector/resource-tests.js: Ditto.
- 9:19 AM Changeset in webkit [67473] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Always set LeftButton in PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=45705
AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
which button is pressed or released. The current code erroneously sets NoButton.
Set LeftButton unconditionally because Brew MP usually runs on touch device.
- platform/brew/PlatformMouseEventBrew.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 8:40 AM Changeset in webkit [67472] by
-
- 4 edits1 move1 delete in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- bindings/v8/DebuggerScript.js: Added.
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- WebKit.grd:
- WebKit.gypi:
- src/js/DebuggerScript.js: Removed.
- src/js/DevToolsHostStub.js: Removed.
- 8:31 AM Changeset in webkit [67471] by
-
- 4 edits9 adds2 deletes in trunk/LayoutTests
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Rebaseline DeviceOrientation related layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45542
Some DeviceOrientation layout tests need Chromium-specific
baselines because of differences between JSC and V8.
Also enable prototype-inheritance.html again and unfork its
expectations.
- fast/dom/script-tests/prototype-inheritance.js:
- platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:18 AM Changeset in webkit [67470] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] add new tests from r67463 to expectations
https://bugs.webkit.org/show_bug.cgi?id=45753
- platform/chromium/test_expectations.txt:
- 7:59 AM Changeset in webkit [67469] by
-
- 7 edits in trunk
2010-09-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore
https://bugs.webkit.org/show_bug.cgi?id=45530
WebCore:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
- css/CSSStyleSelector.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
LayoutTests:
- inspector/elements-panel-styles-expected.txt:
- inspector/resources/elements-panel-styles.css: (.foo): (.foo::before):
- 7:42 AM Changeset in webkit [67468] by
-
- 2 edits in trunk/WebCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Darin Adler.
[BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
https://bugs.webkit.org/show_bug.cgi?id=45701
SharedBuffer::createWithContentsOfFile() reads file content and saves to
result.m_buffer directly, leaving result.m_size unchanged.
- platform/brew/SharedBufferBrew.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 7:25 AM Changeset in webkit [67467] by
-
- 7 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move adjustLexerState to the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=45649
This function used let us share code between the tree builder and the
two other users of the HTMLTokenizer. However, now that the tree
builder is all grown up, it can't use this code anymore. The other
users would much rather this code lived on HTMLTokenizer and understood
<script>. This patch attempts to make them happy.
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTokenizer.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::scriptEnabled):
- html/parser/HTMLTreeBuilder.h:
- html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
- 7:06 AM Changeset in webkit [67466] by
-
- 4 edits4 adds16 deletes in trunk/LayoutTests
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610
post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.
- http/tests/navigation/post-basic-expected.txt: Added.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames-expected.txt: Added.
- http/tests/navigation/post-frames.html:
- http/tests/navigation/resources/form-target.pl: Added
- http/tests/navigation/resources/page-that-posts.html: Added.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
- 7:04 AM Changeset in webkit [67465] by
-
- 2 edits in trunk
2010-09-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] qmake doesn't generate correct dependencies for rcc resource files
https://bugs.webkit.org/show_bug.cgi?id=45747
- WebKit.pri: add OUT_PWD to DEPENDPATH
- 6:33 AM Changeset in webkit [67464] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Anton Muhin <antonm@chromium.org>
Unreviewed cleanup of test expectations for Chromium.
ietestcenter/Javascript/15.4.4.15-3-14.html, ietestcenter/Javascript/15.4.4.15-3-29.html and
ietestcenter/Javascript/15.4.4.15-3-8.html are passing now.
- platform/chromium/test_expectations.txt:
- 6:25 AM Changeset in webkit [67463] by
-
- 3 edits8 adds in trunk
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.
- fast/repaint/block-layout-inline-children-float-positioned.html: Added.
- fast/repaint/block-layout-inline-children-replaced.html: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.
Patch by: Dave Hyatt
Tests: fast/repaint/block-layout-inline-children-float-positioned.html
fast/repaint/block-layout-inline-children-replaced.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 6:20 AM Changeset in webkit [67462] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Make WebDeviceOrientationClientMock constructor private.
https://bugs.webkit.org/show_bug.cgi?id=45743
Clients should use the create member function instead. DumpRenderTree
and the Chromium test_shell have previously been updated to call create.
- public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
- 6:16 AM Changeset in webkit [67461] by
-
- 2 edits in trunk/WebCore
2010-09-14 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Andreas Kling.
[Qt] Cookie operations should use NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45745
No new functionality so no new tests.
- platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager instead of directly accessing the FrameLoaderClient.
- 5:38 AM Changeset in webkit [67460] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] mark fast/frames/frame-limit.html as DEBUG SLOW CRASH
https://bugs.webkit.org/show_bug.cgi?id=45738
- platform/chromium/test_expectations.txt:
- 5:26 AM Changeset in webkit [67459] by
-
- 8 edits3 deletes in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/execCommand/script-tests/toggle-style-3.js:
- editing/execCommand/toggle-style-3-expected.txt:
- editing/execCommand/unlink-expected.txt:
- editing/style/inline-style-extend-run-expected.txt: Removed.
- editing/style/inline-style-extend-run.html: Removed.
- editing/style/script-tests/inline-style-extend-run.js: Removed.
- editing/style/script-tests/make-text-writing-direction-inline.js:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown):
- editing/ApplyStyleCommand.h:
- 4:07 AM Changeset in webkit [67458] by
-
- 12 edits in trunk
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::createCommandMap):
- loader/EmptyClients.h:
- page/EditorClient.h:
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::dismissCorrectionPanel):
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::dismissCorrectionPanel):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 2:52 AM Changeset in webkit [67457] by
-
- 2 edits in trunk/WebKitTools
Adding myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 AM Changeset in webkit [67456] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
https://bugs.webkit.org/show_bug.cgi?id=45736
Reviewed by Kenneth Rohde Christiansen.
Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.
- Scripts/build-webkit:
- 2:23 AM Changeset in webkit [67455] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; an attempt to fix Chromium Windows build.
- fileapi/FileEntry.cpp:
- 2:10 AM Changeset in webkit [67454] by
-
- 3 edits in trunk/WebCore
2010-09-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide support for opening external navigation for links within certain elements
Use default handling for clicks on links that have target="_blank"
Add option for external navigation to URL audit formatter.
https://bugs.webkit.org/show_bug.cgi?id=45671
- inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.url):
- inspector/front-end/inspector.js:
- 1:26 AM Changeset in webkit [67453] by
-
- 2 edits in trunk/WebKit/qt
2010-09-14 Enrico Ros <eros@codeaurora.org>
Reviewed by Andreas Kling.
[Qt] Respect title attribute on option elements
https://bugs.webkit.org/show_bug.cgi?id=45084
Set the tooltip in the combo box model, so it's reflected in the view.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
- 1:03 AM Changeset in webkit [67452] by
-
- 2 edits in trunk/WebCore
Build fix.
- editing/EditorCommand.cpp:
- 12:50 AM Changeset in webkit [67451] by
-
- 12 edits in trunk
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Patch by Jia Pu <jpu@apple.com> on 2010-09-14
Reviewed by Dan Bernstein.
WebCore:
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp:
(WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection
panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp:
(WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation()
when autocorrection panel is shown.
(WebCore::createCommandMap): Replaced isSupported function pointer for
executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of
new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
WebKit/mac:
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
for invalid correction panel tag. Replaced -1 with this constant.
(WebEditorClient::dismissCorrectionPanel): Ditto
(WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 12:40 AM Changeset in webkit [67450] by
-
- 1 edit1 delete in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45691
Brew MP no longer depends on ICU for internationalization.
Remove TextBreakIteratorInternalICUBrew.cpp.
- platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed.
- 12:12 AM Changeset in webkit [67449] by
-
- 8 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
Sep 13, 2010:
- 11:51 PM Changeset in webkit [67448] by
-
- 2 edits in trunk/WebCore
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
Add one #if guard block to fix Qt builds.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/InspectorResource.cpp:
- 11:27 PM Changeset in webkit [67447] by
-
- 13 edits in trunk
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/extensions-api-expected.txt: Added a new resource type.
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Add WebSocket resource type to Web Inspector.
When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
- inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
- inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
- websockets/WebSocketChannel.h:
- 11:17 PM WebKit Team edited by
- (diff)
- 11:06 PM Changeset in webkit [67446] by
-
- 3 edits4 adds in trunk/WebKit/chromium
2010-09-13 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Add Chromium API for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44360
Build file changes.
- WebKit.gyp:
Added a way to get a WebFileWriter.
- public/WebFileSystem.h: (WebKit::WebFileSystem::createFileWriter):
WebFileWriter writes and truncates files.
- public/WebFileWriter.h: Added.
WebFileWriterClient reports success/failure and progress events.
- public/WebFileWriterClient.h: Added.
AsyncFileWriterChromium is a connector that links FileWriter and WebFileWriter, FileWriterClient and WebFileWriterClient.
- src/AsyncFileWriterChromium.cpp: Added.
- src/AsyncFileWriterChromium.h: Added.
- 10:26 PM Changeset in webkit [67445] by
-
- 6 edits in trunk
2010-09-13 W. James MacLean <wjmaclean@google.com>
Reviewed by Darin Fisher.
[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127
Replicates existing functionality, use existing tests.
Adds pixel-readback for GPU composited pages to allow for thumbnailing,
printing and other services to work with GPU rendered pages.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerTextureSize):
2010-09-13 W. James MacLean <wjmaclean@google.com>
Reviewed by Darin Fisher.
[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127
Modified WebViewImpl::paint() to detect non-null canvas pointers when
accelerated compositing is active, and instead fills the pixel buffer
from the GPU framebuffer. Includes re-scaling support when provided
canvas does not match size of current render layer. Limits pixel
readback to rect passed to paint(), clipped by size of rootLayerTexture.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
- 10:05 PM Changeset in webkit [67444] by
-
- 2 edits in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, build fix for Gtk.
- bindings/js/JSEntryCustom.cpp:
- 9:59 PM Changeset in webkit [67443] by
-
- 13 edits2 adds in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Adam Barth.
Make FileEntry and DirectoryEntry methods accessible via Entry instance
https://bugs.webkit.org/show_bug.cgi?id=45553
FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type.
Added custom toJS/toV8 implementation to Entry interface.
No new tests; test will be added later when we have complete implementation for the API.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEntryCustom.cpp: Added. (WebCore::toJS):
- bindings/v8/custom/V8EntryCustom.cpp: Added. (WebCore::toV8):
- fileapi/DirectoryEntry.h: Nits fix.
- fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter.
- fileapi/Entry.idl: Added CustomToJS attribute.
- fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter): (WebCore::FileEntry::file):
- fileapi/FileEntry.h:
- fileapi/FileEntry.idl:
- 9:29 PM Changeset in webkit [67442] by
-
- 2 edits in trunk/WebKit/qt
2010-09-13 Daniel Bates <dbates@rim.com>
Fix the Qt build. I missed this when reviewing the patch
for Bug #45732.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Change enum value ActiveDOMObject::JavaScriptPaused to ActiveDOMObject::JavaScriptDebuggerPaused
- 9:18 PM Changeset in webkit [67441] by
-
- 3 edits2 adds in trunk
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632
Test: editing/execCommand/query-font-size-with-typing-style.html
The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before
retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function.
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632
Added a test to ensure WebKit does not crash when querying font size even if there is a typing style.
- editing/execCommand/query-font-size-with-typing-style-expected.txt: Added.
- editing/execCommand/query-font-size-with-typing-style.html: Added.
- 9:17 PM Changeset in webkit [67440] by
-
- 2 edits in trunk/WebKit/qt
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Daniel Bates.
[Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter
https://bugs.webkit.org/show_bug.cgi?id=45732
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Pass ActiveDOMObject::JavaScriptPaused to suspendActiveDOMObjects.
- 9:08 PM Changeset in webkit [67439] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-13 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Return NULL from getSharedGraphicsContext3D if we couldn't initialize
https://bugs.webkit.org/show_bug.cgi?id=45731
If we can't create a GraphicsContext3D, return NULL from getSharedGraphicsContext3D rather
than an object with NULL internal pointers. Callers know how to handle a null return value
but not one that has inconsistent internal state.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
- 9:00 PM Changeset in webkit [67438] by
-
- 2 edits in trunk/WebCore
2010-09-13 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
[BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45690
WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already
in namespace WebCore block.
- platform/brew/SSLKeyGeneratorBrew.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
- 8:40 PM Changeset in webkit [67437] by
-
- 6 edits in trunk/WebKit2
URL in address bar doesn't update when navigating to http://webkit.org/new-bug when using WebKit2
<rdar://problem/8272775>
https://bugs.webkit.org/show_bug.cgi?id=45729
Reviewed by Jon Honeycutt.
Pass an updated provisional url while notifying the UIProcess of
didReceiveServerRedirectForProvisionalLoadForFrame.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
- 8:23 PM Changeset in webkit [67436] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- 8:15 PM Changeset in webkit [67435] by
-
- 2 edits in trunk/WebCore
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Code simplification needed in Atk Wrapper
https://bugs.webkit.org/show_bug.cgi?id=45687
Use TextIterator::rangeLength() to calculate endOffset
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Don't manually iterate over a artificial new range but just call TextIterator::rangeLength on the range created between the start and end positions.
- 7:54 PM Changeset in webkit [67434] by
-
- 2 edits in trunk/WebCore
Clean up xcode project.
Reviewed by Alice Liu.
- WebCore.xcodeproj/project.pbxproj:
- 7:48 PM Changeset in webkit [67433] by
-
- 11 edits5 adds in trunk/WebKit2
Threaded mode should work in WebKit2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45727
Reviewed by Jon Honeycutt.
- Make starting the web thread more like starting a new process (encapsulate it in a thread launcher class).
- Make the call to didFinishLaunching asynchronous so that WebProcess is fully constructed before it is called.
- Platform/WorkItem.h:
(MemberFunctionWorkItem1::MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::~MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::execute):
(WorkItem::create):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/ThreadLauncher.cpp: Added.
(WebKit::ThreadLauncher::ThreadLauncher):
(WebKit::ThreadLauncher::launchThread):
(WebKit::ThreadLauncher::didFinishLaunchingThread):
(WebKit::ThreadLauncher::invalidate):
- UIProcess/Launcher/ThreadLauncher.h: Added.
(WebKit::ThreadLauncher::Client::~Client):
(WebKit::ThreadLauncher::create):
(WebKit::ThreadLauncher::isLaunching):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::terminateProcess):
- UIProcess/Launcher/mac/ThreadLauncherMac.mm: Added.
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Added.
(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- UIProcess/Launcher/win/ThreadLauncherWin.cpp: Added.
(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
(WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/WebProcessProxy.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 7:41 PM Changeset in webkit [67432] by
-
- 20 edits2 adds in trunk
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Geoff Garen.
JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688
Test: http/tests/media/reload-after-dialog.html
- bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter.
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects.
- dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter.
- dom/ActiveDOMObject.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto.
- dom/ScriptExecutionContext.h:
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects.
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter.
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): Deal with element being suspended. (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document becoming inactive.
- html/HTMLMediaElement.h:
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects.
- page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter.
- page/SuspendableTimer.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::suspend): Ditto.
- websockets/WebSocket.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::suspend): Ditto.
- xml/XMLHttpRequest.h:
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Geoff Garen.
JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688
- http/tests/media/reload-after-dialog-expected.txt: Added.
- http/tests/media/reload-after-dialog.html: Added.
- 7:15 PM Changeset in webkit [67431] by
-
- 2 edits in trunk/WebCore
Fix the mac build.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToSubframe):
- 7:03 PM Changeset in webkit [67430] by
-
- 2 edits in trunk/WebCore
Can't scroll on Bugzilla patch review pages on Mac with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43555
Reviewed by Anders Carlsson.
<rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks
<rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555)
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Add WebKit2 mode for these functions based on the presence of a platform widget for a
FrameView.
- 6:38 PM Changeset in webkit [67429] by
-
- 4 edits in trunk/WebKitTools
2010-09-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should log when it's retrying due to checkout out of date error
https://bugs.webkit.org/show_bug.cgi?id=45725
This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.
In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 6:37 PM Changeset in webkit [67428] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Upload results when cq patch landing fails
https://bugs.webkit.org/show_bug.cgi?id=45683
Include script errors when CommitQueue._land fails.
- Scripts/webkitpy/tool/commands/queues.py:
- 6:10 PM Changeset in webkit [67427] by
-
- 2 edits in trunk/WebCore
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Buildfix for ViewportArguments.cpp
https://bugs.webkit.org/show_bug.cgi?id=45678
Use fabs() instead of abs().
This patch also fixes the return value, when
the value is between -1 and 1.
- dom/ViewportArguments.cpp: (WebCore::findUserScalableValue):
- 6:02 PM Changeset in webkit [67426] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix duplicate entries in expectations file; we really need to fix
the checkin trigger to catch these.
- platform/chromium/test_expectations.txt:
- 5:56 PM Changeset in webkit [67425] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Add some suppressions back in - it looks like we are probably tripping
over some debug asserts that I need to triage downstream.
- platform/chromium/test_expectations.txt:
- 5:29 PM Changeset in webkit [67424] by
-
- 2 edits in trunk/WebKit/efl
2010-09-13 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[EFL] Fix build break when enabling HTML5 video support
https://bugs.webkit.org/show_bug.cgi?id=45674
The correct include variable for LibXml2 in cmake is
LIBXML2_INCLUDE_DIR instead of LIBXML2_INCLUDE_DIRS.
- CMakeListsEfl.txt:
- 4:42 PM Changeset in webkit [67423] by
-
- 22 edits2 adds in trunk
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
- wtf/text/WTFString.h: Added isAllSpecialCharacters, moved here from the HTML tree builder.
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
- DOM/WebDOMOperations.mm: (-[DOMDocument webFrame]): Get rid of unneeded local variable. (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
Added new HTMLParserIdioms source file, with a name inspired by the HTML
specification, which has a section defining things like "space character"
that talks about common parser idioms. These are idioms for the main HTML
parser and for parsers for various microlanguages as well.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Added HTMLParserIdioms.
- css/CSSHelper.h: Fixed indentation and comments here. Point to the new stripLeadingAndTrailingHTMLSpaces function.
- html/parser/HTMLParserIdioms.cpp: Added.
- html/parser/HTMLParserIdioms.h: Added.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Updated for name changes.
- html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h.
- html/HTMLInputElement.cpp:
- html/HTMLMeterElement.cpp:
- html/HTMLProgressElement.cpp:
- html/StepRange.cpp:
- rendering/RenderSlider.cpp: Updated includes.
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. This is for use on the attribute value before building the URL, not on the URL after building it. I did not add a test case; this is an obscure corner and soon we will be moving to stripLeadingAndTrailingHTMLSpaces anyway.
- wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Ditto.
- 4:27 PM Changeset in webkit [67422] by
-
- 3 edits2 adds in trunk
AX: REGRESSION: WebKit does not report label of web popup buttons
https://bugs.webkit.org/show_bug.cgi?id=45715
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/popup-button-title.html
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
LayoutTests:
- platform/mac/accessibility/popup-button-title-expected.txt: Added.
- platform/mac/accessibility/popup-button-title.html: Added.
- 4:14 PM Changeset in webkit [67421] by
-
- 15 edits in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Expose Flags constructor if FileSystem API is Enabled
https://bugs.webkit.org/show_bug.cgi?id=45165
This change also includes:
- Changed Flags' attribute names from UPPERCASE to camelCase to reflect the recent spec change. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
- Enhanced EnabledAtRuntime attribute to take parameter that is used to generate a RuntimeEnabledFeatures method name.
No new tests; tests will be added when we fully expose the interface.
- bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor.
- fileapi/Flags.idl: Changed attribute names to camelCase.
- page/DOMWindow.idl: Exposed Flags constructor.
- bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object).
- bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::create): (WebDOMTestObj::setCreate):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::createAttrGetter): (WebCore::TestObjInternal::createAttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): (WebCore::ConfigureV8TestObjTemplate):
- 4:10 PM Changeset in webkit [67420] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
"Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=45647
Implements the notImplemented by doing nothing, which is the proper
behavior according to the spec.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 4:08 PM Changeset in webkit [67419] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
More trivial EOF handling in tree builder
https://bugs.webkit.org/show_bug.cgi?id=45648
The spec says to treat these modes like the InBodyMode, which is what
this patch does. Doing so is indistinguishable from our current
behavior, which is why we didn't catch this based on tests.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 3:59 PM Changeset in webkit [67418] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-13 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572
- public/WebAccessibilityObject.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
- 3:58 PM Changeset in webkit [67417] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Remove a bunch of tests that are now passing.
- platform/chromium/test_expectations.txt:
- 3:27 PM Changeset in webkit [67416] by
-
- 4 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] rebaseline two svg tests after r67200
https://bugs.webkit.org/show_bug.cgi?id=45665
- platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
- platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:26 PM Changeset in webkit [67415] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] mark fast/files/read-blob-async.html as CRASH PASS on linux
https://bugs.webkit.org/show_bug.cgi?id=45672
- platform/chromium/test_expectations.txt:
- 3:10 PM Changeset in webkit [67414] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] fix broken dependency in ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=45684
- WebKit.gyp:
- 3:05 PM Changeset in webkit [67413] by
-
- 3 edits in trunk/WebKit/efl
2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add setting API for enabling page cache
https://bugs.webkit.org/show_bug.cgi?id=44931
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_page_cache_get): Added. (ewk_view_setting_page_cache_set): Added.
- ewk/ewk_view.h:
- 2:39 PM Changeset in webkit [67412] by
-
- 5 edits in trunk/WebCore
2010-09-13 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
SharedGraphicsContext3D's texture cache holds on to images after free
https://bugs.webkit.org/show_bug.cgi?id=45706
Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs.
Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know
so that the cache entry and associated texture can also be removed.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::removeTextureFor): (WebCore::SharedGraphicsContext3D::removeTexturesFor): (WebCore::SharedGraphicsContext3D::allContexts):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::~NativeImageSkia):
- platform/graphics/skia/NativeImageSkia.h:
- 2:23 PM Changeset in webkit [67411] by
-
- 2 edits in trunk/WebKit2
didFinishDocumentLoadForFrame() is not being sent by WebKit2
<rdar://problem/8424171>
Reviewed by Anders Carlsson.
Finish wiring up didFinishDocumentLoad to the UIProcess.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
- 2:08 PM Changeset in webkit [67410] by
-
- 6 edits in branches/chromium/517
Merge 67401 - 210-09-13 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689
The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimatorWin.cpp:
- platform/ScrollAnimatorWin.h:
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/3290027
- 2:08 PM Changeset in webkit [67409] by
-
- 1 edit in trunk/WebKit/win/WebFrame.cpp
One more attempt at fixing the Windows build.
Not reviewed.
- 2:06 PM Changeset in webkit [67408] by
-
- 9 edits2 adds in trunk
AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
https://bugs.webkit.org/show_bug.cgi?id=45548
Reviewed by David Kilzer.
WebCore:
Test: platform/mac/accessibility/element-is-ignored.html
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isIgnored):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isIgnored):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isIgnored):
LayoutTests:
- platform/mac/accessibility/element-is-ignored-expected.txt: Added.
- platform/mac/accessibility/element-is-ignored.html: Added.
- 1:55 PM Changeset in webkit [67407] by
-
- 3 edits2 adds in trunk
CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663
https://bugs.webkit.org/show_bug.cgi?id=45697
Reviewed by Darin Adler.
WebCore:
Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may
be in a bad state and accessing internal variables can lead to a crash.
Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::parentTable):
LayoutTests:
- platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt: Added.
- platform/mac/accessibility/updating-attribute-in-table-row-crash.html: Added.
- 1:49 PM Changeset in webkit [67406] by
-
- 3 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement EOF handling in TextMode
https://bugs.webkit.org/show_bug.cgi?id=45644
This patch is actually covered by a bunch of tests. We were just
magically passing the tests before because of some nutty code in
Document.cpp.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- This code was masking the notImplemented in the tree builder. I also removed the use of the setting because it wasn't working properly anyway. I'll implement a working version shortly.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndOfFile):
- Implement per the spec.
- 1:43 PM Changeset in webkit [67405] by
-
- 1 edit in trunk/WebKit/win/WebFrame.h
Fixing Windows build.
Not reviewed.
- 12:40 PM Changeset in webkit [67404] by
-
- 1 edit173 deletes in trunk/LayoutTests
2010-09-13 Tony Chang <tony@chromium.org>
Unreviewed, removing chromium-linux results that deduplicate-tests says are
unnecessary (mostly due to the checksum computation change last week).
- platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-image-004-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-002-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-003-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Removed.
- platform/chromium-linux/editing/undo/5378473-expected.checksum: Removed.
- platform/chromium-linux/editing/undo/5378473-expected.png: Removed.
- platform/chromium-linux/editing/undo/undo-misspellings-expected.checksum: Removed.
- platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.checksum: Removed.
- platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
- platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
- platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Removed.
- platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Removed.
- platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-linux/fast/dom/attr_dead_doc-expected.checksum: Removed.
- platform/chromium-linux/fast/dom/attr_dead_doc-expected.png: Removed.
- platform/chromium-linux/fast/frames/content-opacity-1-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/content-opacity-1-expected.png: Removed.
- platform/chromium-linux/fast/frames/content-opacity-2-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/content-opacity-2-expected.png: Removed.
- platform/chromium-linux/fast/frames/iframe-text-contents-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/iframe-text-contents-expected.png: Removed.
- platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.checksum: Removed.
- platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-linux/fast/layers/self-painting-outline-expected.checksum: Removed.
- platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Removed.
- platform/chromium-linux/fast/repaint/background-generated-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/background-generated-expected.png: Removed.
- platform/chromium-linux/fast/repaint/background-misaligned-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
- platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Removed.
- platform/chromium-linux/fast/repaint/content-into-overflow-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Removed.
- platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
- platform/chromium-linux/fast/repaint/float-new-in-block-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Removed.
- platform/chromium-linux/fast/repaint/focus-ring-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/focus-ring-expected.png: Removed.
- platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Removed.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/outline-inset-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/outline-inset-expected.png: Removed.
- platform/chromium-linux/fast/repaint/overflow-into-content-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Removed.
- platform/chromium-linux/fast/repaint/selection-clear-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/selection-clear-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-outer-border-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-section-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Removed.
- platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Removed.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Removed.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Removed.
- platform/chromium-linux/fast/table/giantRowspan-expected.checksum: Removed.
- platform/chromium-linux/fast/table/giantRowspan-expected.png: Removed.
- platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.checksum: Removed.
- platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Removed.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Removed.
- platform/chromium-linux/svg/custom/dynamic-empty-path-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Removed.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
- platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
- platform/chromium-linux/svg/custom/group-opacity-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-container-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-container-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-container2-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-container2-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-style-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-style-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-transform-addition-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Removed.
- platform/chromium-linux/svg/custom/marker-referencePoint-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Removed.
- platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/mask-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/pattern-y-offset-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Removed.
- platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/text-dom-removal-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Removed.
- platform/chromium-linux/svg/custom/use-forward-refs-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Removed.
- platform/chromium-linux/svg/hixie/data-types/001-expected.checksum: Removed.
- platform/chromium-linux/svg/hixie/data-types/001-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
- 12:16 PM Changeset in webkit [67403] by
-
- 39 edits in trunk
Paste should be implemented in WebCore like Copy and Cut for Mac also.
https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>
WebCore:
Reviewed by Sam Weining.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- editing/Editor.cpp:
(WebCore::Editor::shouldInsertFragment):
- editing/mac/EditorMac.mm: extended to support Mail specific scenarios.
(WebCore::Editor::pasteWithPasteboard):
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added.
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added.
(WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail.
- loader/FrameLoaderClient.h:
- page/EditorClient.h:
- platform/Pasteboard.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that
doesn't calll back into WebKit.
(WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the
WebCore level.
(WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the
WebCore level.
(WebCore::uniqueURLWithRelativePart): Added.
(WebCore::Pasteboard::documentFragment): Extended to include all the functionality
provided in documentFragmentFromPasteboard in WebHTMLView.mm.
WebKit/chromium:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::canShowMIMETypeAsHTML): Added stub.
- src/FrameLoaderClientImpl.h:
WebKit/efl:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientEfl.h:
WebKit/gtk:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/haiku:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientHaiku.h:
WebKit/mac:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(excludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Added.
(WebEditorClient::setInsertionPasteboard):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
of the editor client.
- WebView/WebHTMLView.mm: Removed paste method.
WebKit/qt:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebFrame.cpp:
(WebFrame::canShowMIMETypeASHTML): Added.
WebKit/wx:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::canShowMIMETypeAsHTML): Added stub.
- WebKitSupport/FrameLoaderClientWx.h:
WebKit2:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added.
(WebKit::WebEditorClient::setInsertionPasteboard): Added.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 12:05 PM Changeset in webkit [67402] by
-
- 2 edits in trunk/WebCore
2010-09-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
https://bugs.webkit.org/show_bug.cgi?id=44699
Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- 11:56 AM Changeset in webkit [67401] by
-
- 6 edits in trunk
210-09-13 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689
The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimatorWin.cpp:
- platform/ScrollAnimatorWin.h:
- 11:45 AM Changeset in webkit [67400] by
-
- 5 edits in trunk/LayoutTests
2010-09-13 Adam Langley <agl@chromium.org>
Unreviewed. Layout test re-baseline.
After r66882, complex text word spacing changed due to a bug fix. This
rebaselines the layout test for that case.
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:41 AM Changeset in webkit [67399] by
-
- 2 edits in trunk/WebCore
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Move functions of StyledMarkupAccumulator below that of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=45624
Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions
to below the definitions of MarkupAccumulator's member functions.
No new tests are added since this is a cleanup.
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): (WebCore::StyledMarkupAccumulator::appendElement): (WebCore::StyledMarkupAccumulator::shouldAnnotate): (WebCore::StyledMarkupAccumulator::wrapWithNode): (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): (WebCore::StyledMarkupAccumulator::takeResults): (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::renderedText): (WebCore::StyledMarkupAccumulator::stringValueForRange): (WebCore::styleFromMatchedRulesForElement): (WebCore::StyledMarkupAccumulator::removeExteriorStyles): (WebCore::needInterchangeNewlineAfter): (WebCore::styleFromMatchedRulesAndInlineDecl): (WebCore::removeEnclosingMailBlockquoteStyle): (WebCore::removeDefaultStyles):
- 11:34 AM Changeset in webkit [67398] by
-
- 4 edits in trunk/WebCore
2010-09-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Leak in the GraphicsContextCairo drawPathShadow
https://bugs.webkit.org/show_bug.cgi?id=44959
Fix a leak of the cairo_path.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- platform/graphics/cairo/OwnPtrCairo.cpp: (WTF::cairo_path_t):
- platform/graphics/cairo/OwnPtrCairo.h:
- 11:28 AM WinCE edited by
- (diff)
- 11:25 AM Changeset in webkit [67397] by
-
- 18 edits in trunk
Build fix. Clear the executable bit on files that should not be executable.
- 11:15 AM WinCE edited by
- (diff)
- 10:40 AM Changeset in webkit [67396] by
-
- 4 edits in trunk
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645
Test that </sarcasm> works properly.
- html5lib/resources/webkit02.dat:
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645
Umm... Yeah.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
- 10:21 AM Changeset in webkit [67395] by
-
- 3 edits in trunk/WebCore
2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Darin Adler.
[WML] Fix build breaks when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=45628
There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter.
So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent()
was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp
- wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 10:00 AM Changeset in webkit [67394] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline inspector/extensions-events.html
- inspector/extensions-events-expected.txt:
- 9:32 AM Changeset in webkit [67393] by
-
- 2 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=45677
[WebView canMarkAllTextMatches] can crash if called after [WebView close]
Reviewed by Adam Roben.
<rdar://problem/8404890>
- WebView/WebView.mm:
(-[WebView canMarkAllTextMatches]):
Return NO immediately if the webview has already been closed. This was an overlooked
case from the fix for 45175.
- 9:26 AM Changeset in webkit [67392] by
-
- 2 edits in trunk/WebCore
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
https://bugs.webkit.org/show_bug.cgi?id=45230
No new tests as this is just a build change.
- GNUmakefile.am: Move as many sources as possible to the SOURCES primary. Others should be moved over time as we solve issues with them.
- 9:17 AM Changeset in webkit [67391] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Andreas Kling.
jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651
- Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
- 9:03 AM Changeset in webkit [67390] by
-
- 7 edits2 adds in trunk
REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43807
Reviewed by Darin Adler.
WebCore:
Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types.
Test: platform/mac/accessibility/visible-position-crash-for-text-node.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::textMarkerForPoint):
LayoutTests:
- platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt: Added.
- platform/mac/accessibility/visible-position-crash-for-text-node.html: Added.
- 8:25 AM Changeset in webkit [67389] by
-
- 4 edits in trunk
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
- platform/qt/Skipped: Unskip tests that are now passing.
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
- 8:13 AM Changeset in webkit [67388] by
-
- 2 edits in trunk/JavaScriptCore
Copy JavaScriptCore's generated sources to the right directory
- JavaScriptCore.vcproj/JavaScriptCore.make: Fixed typo.
- 7:20 AM Changeset in webkit [67387] by
-
- 12 edits in trunk
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Remove exceptions for tests that now pass (in DRT and downstream test_shell)
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Add missing virtual destructor to the abstract base class.
- platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
- platform/chromium/GeolocationServiceChromium.h:
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Ports over fixes from test shell:
Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html
Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112
Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably
Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService
- public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService):
- public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed):
- public/WebGeolocationServiceMock.h:
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached):
- src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions):
- 7:17 AM Changeset in webkit [67386] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Skip new debugger test on Qt.
- platform/qt/Skipped:
- 6:39 AM Changeset in webkit [67385] by
-
- 6 edits3 adds in trunk
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
Test that scope sections in Scripts panel are expandable and
contain correct data.
- inspector/debugger-expand-scope-expected.txt: Added.
- inspector/debugger-expand-scope.html: Added.
- platform/chromium/inspector/debugger-expand-scope-expected.txt: Added.
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
Test: inspector/debugger-expand-scope.html
- inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. (injectedScriptConstructor.):
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
- src/js/DebuggerScript.js: copy scope variables into a new object, but for global scope object, with statement parameter and catch block exception variable pass the object itself to the injected script.
- src/js/Tests.js: moved testExpandScope to LayoutTests
- 6:03 AM Changeset in webkit [67384] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] add viewport meta tag tests to expectations
https://bugs.webkit.org/show_bug.cgi?id=45655
- platform/chromium/test_expectations.txt:
- 5:29 AM Changeset in webkit [67383] by
-
- 8 edits in trunk
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673
Implement AtkText's setSelection and removeSelection functions
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange): Moved some GTK specific code from a ifdef-endif region to AccessibilityObjectAtk.cpp
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::getLengthForTextRange): New.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_remove_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_caret_offset): Changed to directly use visiblePositionRangeForRange now that there's no longer a problem with that, as it was in the past (only worked for text controls).
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Provide unit tests for AtkText's text selection functions
https://bugs.webkit.org/show_bug.cgi?id=43919
New tests to check getting, setting and removing text selections
- tests/testatk.c: (testWekitAtkTextSelections): New unit tests to check all the text selection related functions altogether through a single test function. (main):
Make sure that code dependant on getting information from the
clipboard gets executed only when there's a GDK window associated
to the webview widget, as that's not the case when executing the
unit tests (the wedbview is not inside of any toplevel window) and
will make the tests crash if not taken into account.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):
- 5:09 AM Changeset in webkit [67382] by
-
- 2 edits10 adds in trunk/LayoutTests
2010-09-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium][Test] custom-scrollbar-with-incomplete-style.html need expectation files.
https://bugs.webkit.org/show_bug.cgi?id=45646
Added missing expectations.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:06 AM Changeset in webkit [67381] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 MORITA Hajime <morrita@google.com>
Reviewed by Dirk Schulze.
[chromium] svg/filters/filter-empty-g.svg crashes in linux/mac debug after r63530
https://bugs.webkit.org/show_bug.cgi?id=42486
Removed skip line.
This looks fixed with a fix for http://webkit.org/b/41175.
- platform/chromium/test_expectations.txt:
- 4:35 AM Changeset in webkit [67380] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Unreviewed.
[Qt] Skip three viewport meta tag tests that fail on the bot.
- platform/qt/Skipped:
- 4:19 AM Changeset in webkit [67379] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] build-webkit: Add --v8 option to build against V8
Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.
- Scripts/build-webkit:
- 4:05 AM Changeset in webkit [67378] by
-
- 5 edits in trunk
2010-09-13 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650
Since the virtual member functions of WebDeviceOrientationClientMock
are not exported from the DLL, construction of the object must be done inside
the DLL, or else the linker will complain (because the vtable cannot
be set up). Clients should use the create() member function, and the constructor
will be made private in a subsequent patch.
- public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
- src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::create):
2010-09-13 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650
Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.
This should fix the linker errors for the multi-DLL Chromium DRT build.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
- 3:58 AM Changeset in webkit [67377] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] update test expectations for tests that pass after rolling out r67328
https://bugs.webkit.org/show_bug.cgi?id=45642
- platform/chromium/test_expectations.txt:
- 3:37 AM Changeset in webkit [67376] by
-
- 20 edits229 adds in trunk
WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
Tests: fast/viewport/viewport-1.html
fast/viewport/viewport-10.html
fast/viewport/viewport-100.html
fast/viewport/viewport-101.html
fast/viewport/viewport-102.html
fast/viewport/viewport-103.html
fast/viewport/viewport-104.html
fast/viewport/viewport-105.html
fast/viewport/viewport-106.html
fast/viewport/viewport-107.html
fast/viewport/viewport-108.html
fast/viewport/viewport-109.html
fast/viewport/viewport-11.html
fast/viewport/viewport-110.html
fast/viewport/viewport-111.html
fast/viewport/viewport-112.html
fast/viewport/viewport-113.html
fast/viewport/viewport-114.html
fast/viewport/viewport-115.html
fast/viewport/viewport-116.html
fast/viewport/viewport-117.html
fast/viewport/viewport-118.html
fast/viewport/viewport-119.html
fast/viewport/viewport-12.html
fast/viewport/viewport-120.html
fast/viewport/viewport-121.html
fast/viewport/viewport-122.html
fast/viewport/viewport-123.html
fast/viewport/viewport-124.html
fast/viewport/viewport-125.html
fast/viewport/viewport-126.html
fast/viewport/viewport-127.html
fast/viewport/viewport-13.html
fast/viewport/viewport-14.html
fast/viewport/viewport-15.html
fast/viewport/viewport-16.html
fast/viewport/viewport-17.html
fast/viewport/viewport-18.html
fast/viewport/viewport-19.html
fast/viewport/viewport-2.html
fast/viewport/viewport-20.html
fast/viewport/viewport-21.html
fast/viewport/viewport-22.html
fast/viewport/viewport-23.html
fast/viewport/viewport-24.html
fast/viewport/viewport-25.html
fast/viewport/viewport-26.html
fast/viewport/viewport-27.html
fast/viewport/viewport-28.html
fast/viewport/viewport-29.html
fast/viewport/viewport-3.html
fast/viewport/viewport-30.html
fast/viewport/viewport-31.html
fast/viewport/viewport-32.html
fast/viewport/viewport-33.html
fast/viewport/viewport-34.html
fast/viewport/viewport-35.html
fast/viewport/viewport-36.html
fast/viewport/viewport-37.html
fast/viewport/viewport-38.html
fast/viewport/viewport-39.html
fast/viewport/viewport-4.html
fast/viewport/viewport-40.html
fast/viewport/viewport-41.html
fast/viewport/viewport-42.html
fast/viewport/viewport-43.html
fast/viewport/viewport-44.html
fast/viewport/viewport-45.html
fast/viewport/viewport-46.html
fast/viewport/viewport-47.html
fast/viewport/viewport-48.html
fast/viewport/viewport-49.html
fast/viewport/viewport-5.html
fast/viewport/viewport-50.html
fast/viewport/viewport-51.html
fast/viewport/viewport-52.html
fast/viewport/viewport-53.html
fast/viewport/viewport-54.html
fast/viewport/viewport-55.html
fast/viewport/viewport-56.html
fast/viewport/viewport-57.html
fast/viewport/viewport-58.html
fast/viewport/viewport-59.html
fast/viewport/viewport-6.html
fast/viewport/viewport-60.html
fast/viewport/viewport-61.html
fast/viewport/viewport-62.html
fast/viewport/viewport-63.html
fast/viewport/viewport-64.html
fast/viewport/viewport-65.html
fast/viewport/viewport-66.html
fast/viewport/viewport-67.html
fast/viewport/viewport-68.html
fast/viewport/viewport-69.html
fast/viewport/viewport-7.html
fast/viewport/viewport-70.html
fast/viewport/viewport-71.html
fast/viewport/viewport-72.html
fast/viewport/viewport-73.html
fast/viewport/viewport-74.html
fast/viewport/viewport-75.html
fast/viewport/viewport-76.html
fast/viewport/viewport-77.html
fast/viewport/viewport-78.html
fast/viewport/viewport-79.html
fast/viewport/viewport-8.html
fast/viewport/viewport-80.html
fast/viewport/viewport-81.html
fast/viewport/viewport-82.html
fast/viewport/viewport-83.html
fast/viewport/viewport-84.html
fast/viewport/viewport-85.html
fast/viewport/viewport-86.html
fast/viewport/viewport-87.html
fast/viewport/viewport-88.html
fast/viewport/viewport-9.html
fast/viewport/viewport-90.html
- dom/ViewportArguments.cpp:
(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):
WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- Api/qwebpage.cpp:
(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::didReceiveViewportArguments):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.
- fast/viewport/viewport-1-expected.txt: Added.
- fast/viewport/viewport-1.html: Added.
- fast/viewport/viewport-10-expected.txt: Added.
- fast/viewport/viewport-10.html: Added.
- fast/viewport/viewport-100-expected.txt: Added.
- fast/viewport/viewport-100.html: Added.
- fast/viewport/viewport-101-expected.txt: Added.
- fast/viewport/viewport-101.html: Added.
- fast/viewport/viewport-102-expected.txt: Added.
- fast/viewport/viewport-102.html: Added.
- fast/viewport/viewport-103-expected.txt: Added.
- fast/viewport/viewport-103.html: Added.
- fast/viewport/viewport-104-expected.txt: Added.
- fast/viewport/viewport-104.html: Added.
- fast/viewport/viewport-105-expected.txt: Added.
- fast/viewport/viewport-105.html: Added.
- fast/viewport/viewport-106-expected.txt: Added.
- fast/viewport/viewport-106.html: Added.
- fast/viewport/viewport-107-expected.txt: Added.
- fast/viewport/viewport-107.html: Added.
- fast/viewport/viewport-108-expected.txt: Added.
- fast/viewport/viewport-108.html: Added.
- fast/viewport/viewport-109-expected.txt: Added.
- fast/viewport/viewport-109.html: Added.
- fast/viewport/viewport-11-expected.txt: Added.
- fast/viewport/viewport-11.html: Added.
- fast/viewport/viewport-110-expected.txt: Added.
- fast/viewport/viewport-110.html: Added.
- fast/viewport/viewport-111-expected.txt: Added.
- fast/viewport/viewport-111.html: Added.
- fast/viewport/viewport-112-expected.txt: Added.
- fast/viewport/viewport-112.html: Added.
- fast/viewport/viewport-113-expected.txt: Added.
- fast/viewport/viewport-113.html: Added.
- fast/viewport/viewport-114-expected.txt: Added.
- fast/viewport/viewport-114.html: Added.
- fast/viewport/viewport-115-expected.txt: Added.
- fast/viewport/viewport-115.html: Added.
- fast/viewport/viewport-116-expected.txt: Added.
- fast/viewport/viewport-116.html: Added.
- fast/viewport/viewport-117-expected.txt: Added.
- fast/viewport/viewport-117.html: Added.
- fast/viewport/viewport-118-expected.txt: Added.
- fast/viewport/viewport-118.html: Added.
- fast/viewport/viewport-119-expected.txt: Added.
- fast/viewport/viewport-119.html: Added.
- fast/viewport/viewport-12-expected.txt: Added.
- fast/viewport/viewport-12.html: Added.
- fast/viewport/viewport-120-expected.txt: Added.
- fast/viewport/viewport-120.html: Added.
- fast/viewport/viewport-121-expected.txt: Added.
- fast/viewport/viewport-121.html: Added.
- fast/viewport/viewport-122-expected.txt: Added.
- fast/viewport/viewport-122.html: Added.
- fast/viewport/viewport-123-expected.txt: Added.
- fast/viewport/viewport-123.html: Added.
- fast/viewport/viewport-124-expected.txt: Added.
- fast/viewport/viewport-124.html: Added.
- fast/viewport/viewport-125-expected.txt: Added.
- fast/viewport/viewport-125.html: Added.
- fast/viewport/viewport-126.html: Added.
- fast/viewport/viewport-127.html: Added.
- fast/viewport/viewport-13-expected.txt: Added.
- fast/viewport/viewport-13.html: Added.
- fast/viewport/viewport-14-expected.txt: Added.
- fast/viewport/viewport-14.html: Added.
- fast/viewport/viewport-15-expected.txt: Added.
- fast/viewport/viewport-15.html: Added.
- fast/viewport/viewport-16-expected.txt: Added.
- fast/viewport/viewport-16.html: Added.
- fast/viewport/viewport-17-expected.txt: Added.
- fast/viewport/viewport-17.html: Added.
- fast/viewport/viewport-18-expected.txt: Added.
- fast/viewport/viewport-18.html: Added.
- fast/viewport/viewport-19-expected.txt: Added.
- fast/viewport/viewport-19.html: Added.
- fast/viewport/viewport-2-expected.txt: Added.
- fast/viewport/viewport-2.html: Added.
- fast/viewport/viewport-20-expected.txt: Added.
- fast/viewport/viewport-20.html: Added.
- fast/viewport/viewport-21-expected.txt: Added.
- fast/viewport/viewport-21.html: Added.
- fast/viewport/viewport-22-expected.txt: Added.
- fast/viewport/viewport-22.html: Added.
- fast/viewport/viewport-23-expected.txt: Added.
- fast/viewport/viewport-23.html: Added.
- fast/viewport/viewport-24-expected.txt: Added.
- fast/viewport/viewport-24.html: Added.
- fast/viewport/viewport-25-expected.txt: Added.
- fast/viewport/viewport-25.html: Added.
- fast/viewport/viewport-26-expected.txt: Added.
- fast/viewport/viewport-26.html: Added.
- fast/viewport/viewport-27-expected.txt: Added.
- fast/viewport/viewport-27.html: Added.
- fast/viewport/viewport-28-expected.txt: Added.
- fast/viewport/viewport-28.html: Added.
- fast/viewport/viewport-29-expected.txt: Added.
- fast/viewport/viewport-29.html: Added.
- fast/viewport/viewport-3-expected.txt: Added.
- fast/viewport/viewport-3.html: Added.
- fast/viewport/viewport-30-expected.txt: Added.
- fast/viewport/viewport-30.html: Added.
- fast/viewport/viewport-31-expected.txt: Added.
- fast/viewport/viewport-31.html: Added.
- fast/viewport/viewport-32-expected.txt: Added.
- fast/viewport/viewport-32.html: Added.
- fast/viewport/viewport-33-expected.txt: Added.
- fast/viewport/viewport-33.html: Added.
- fast/viewport/viewport-34-expected.txt: Added.
- fast/viewport/viewport-34.html: Added.
- fast/viewport/viewport-35-expected.txt: Added.
- fast/viewport/viewport-35.html: Added.
- fast/viewport/viewport-36-expected.txt: Added.
- fast/viewport/viewport-36.html: Added.
- fast/viewport/viewport-37-expected.txt: Added.
- fast/viewport/viewport-37.html: Added.
- fast/viewport/viewport-38-expected.txt: Added.
- fast/viewport/viewport-38.html: Added.
- fast/viewport/viewport-39-expected.txt: Added.
- fast/viewport/viewport-39.html: Added.
- fast/viewport/viewport-4-expected.txt: Added.
- fast/viewport/viewport-4.html: Added.
- fast/viewport/viewport-40-expected.txt: Added.
- fast/viewport/viewport-40.html: Added.
- fast/viewport/viewport-41-expected.txt: Added.
- fast/viewport/viewport-41.html: Added.
- fast/viewport/viewport-42-expected.txt: Added.
- fast/viewport/viewport-42.html: Added.
- fast/viewport/viewport-43-expected.txt: Added.
- fast/viewport/viewport-43.html: Added.
- fast/viewport/viewport-44-expected.txt: Added.
- fast/viewport/viewport-44.html: Added.
- fast/viewport/viewport-45-expected.txt: Added.
- fast/viewport/viewport-45.html: Added.
- fast/viewport/viewport-46-expected.txt: Added.
- fast/viewport/viewport-46.html: Added.
- fast/viewport/viewport-47-expected.txt: Added.
- fast/viewport/viewport-47.html: Added.
- fast/viewport/viewport-48-expected.txt: Added.
- fast/viewport/viewport-48.html: Added.
- fast/viewport/viewport-49-expected.txt: Added.
- fast/viewport/viewport-49.html: Added.
- fast/viewport/viewport-5-expected.txt: Added.
- fast/viewport/viewport-5.html: Added.
- fast/viewport/viewport-50-expected.txt: Added.
- fast/viewport/viewport-50.html: Added.
- fast/viewport/viewport-51-expected.txt: Added.
- fast/viewport/viewport-51.html: Added.
- fast/viewport/viewport-52-expected.txt: Added.
- fast/viewport/viewport-52.html: Added.
- fast/viewport/viewport-53-expected.txt: Added.
- fast/viewport/viewport-53.html: Added.
- fast/viewport/viewport-54-expected.txt: Added.
- fast/viewport/viewport-54.html: Added.
- fast/viewport/viewport-55-expected.txt: Added.
- fast/viewport/viewport-55.html: Added.
- fast/viewport/viewport-56-expected.txt: Added.
- fast/viewport/viewport-56.html: Added.
- fast/viewport/viewport-57-expected.txt: Added.
- fast/viewport/viewport-57.html: Added.
- fast/viewport/viewport-58-expected.txt: Added.
- fast/viewport/viewport-58.html: Added.
- fast/viewport/viewport-59-expected.txt: Added.
- fast/viewport/viewport-59.html: Added.
- fast/viewport/viewport-6-expected.txt: Added.
- fast/viewport/viewport-6.html: Added.
- fast/viewport/viewport-60-expected.txt: Added.
- fast/viewport/viewport-60.html: Added.
- fast/viewport/viewport-61-expected.txt: Added.
- fast/viewport/viewport-61.html: Added.
- fast/viewport/viewport-62-expected.txt: Added.
- fast/viewport/viewport-62.html: Added.
- fast/viewport/viewport-63-expected.txt: Added.
- fast/viewport/viewport-63.html: Added.
- fast/viewport/viewport-64-expected.txt: Added.
- fast/viewport/viewport-64.html: Added.
- fast/viewport/viewport-65.html: Added.
- fast/viewport/viewport-66-expected.txt: Added.
- fast/viewport/viewport-66.html: Added.
- fast/viewport/viewport-67-expected.txt: Added.
- fast/viewport/viewport-67.html: Added.
- fast/viewport/viewport-68-expected.txt: Added.
- fast/viewport/viewport-68.html: Added.
- fast/viewport/viewport-69-expected.txt: Added.
- fast/viewport/viewport-69.html: Added.
- fast/viewport/viewport-7-expected.txt: Added.
- fast/viewport/viewport-7.html: Added.
- fast/viewport/viewport-70-expected.txt: Added.
- fast/viewport/viewport-70.html: Added.
- fast/viewport/viewport-71-expected.txt: Added.
- fast/viewport/viewport-71.html: Added.
- fast/viewport/viewport-72-expected.txt: Added.
- fast/viewport/viewport-72.html: Added.
- fast/viewport/viewport-73-expected.txt: Added.
- fast/viewport/viewport-73.html: Added.
- fast/viewport/viewport-74-expected.txt: Added.
- fast/viewport/viewport-74.html: Added.
- fast/viewport/viewport-75-expected.txt: Added.
- fast/viewport/viewport-75.html: Added.
- fast/viewport/viewport-76-expected.txt: Added.
- fast/viewport/viewport-76.html: Added.
- fast/viewport/viewport-77-expected.txt: Added.
- fast/viewport/viewport-77.html: Added.
- fast/viewport/viewport-78-expected.txt: Added.
- fast/viewport/viewport-78.html: Added.
- fast/viewport/viewport-79-expected.txt: Added.
- fast/viewport/viewport-79.html: Added.
- fast/viewport/viewport-8-expected.txt: Added.
- fast/viewport/viewport-8.html: Added.
- fast/viewport/viewport-80-expected.txt: Added.
- fast/viewport/viewport-80.html: Added.
- fast/viewport/viewport-81-expected.txt: Added.
- fast/viewport/viewport-81.html: Added.
- fast/viewport/viewport-82.html: Added.
- fast/viewport/viewport-83-expected.txt: Added.
- fast/viewport/viewport-83.html: Added.
- fast/viewport/viewport-84.html: Added.
- fast/viewport/viewport-85-expected.txt: Added.
- fast/viewport/viewport-85.html: Added.
- fast/viewport/viewport-86-expected.txt: Added.
- fast/viewport/viewport-86.html: Added.
- fast/viewport/viewport-87.html: Added.
- fast/viewport/viewport-88-expected.txt: Added.
- fast/viewport/viewport-88.html: Added.
- fast/viewport/viewport-9-expected.txt: Added.
- fast/viewport/viewport-9.html: Added.
- fast/viewport/viewport-90-expected.txt: Added.
- fast/viewport/viewport-90.html: Added.
- platform/gtk/Skipped: Skip tests due to missing DRT support.
- platform/mac/Skipped: Skip tests due to missing DRT support.
- platform/win/Skipped: Skip tests due to missing DRT support.
- platform/qt/Skipped: Skip failing tests.
- 3:15 AM Changeset in webkit [67375] by
-
- 2 edits in trunk/WebCore
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Don't add empty strings to list of supported image MIME types
https://bugs.webkit.org/show_bug.cgi?id=45643
After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
returns an empty string instead of "application/octet-stream" for unsupported
extensions. Don't add these to the list of supported types, and clean out
the logic that removed "application/octet-stream" from supported types.
Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
a HashSet<String>.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- 3:12 AM Changeset in webkit [67374] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Re-skip some layout tests that fail on the bots but not on my system
https://bugs.webkit.org/show_bug.cgi?id=45626
- platform/mac-wk2/Skipped:
- 2:50 AM Changeset in webkit [67373] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Attempted Qt build fix.
- html/parser/HTMLElementStack.cpp:
- 2:19 AM Changeset in webkit [67372] by
-
- 6 edits in trunk
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636
Add some tests of breaking out of foreign content.
- html5lib/resources/webkit01.dat:
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636
Now breaking out of foreign content doesn't always bring you back to
HTML. If you have a foreign content element that can contain HTML, you
just get brought back to that element.
- html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
- html/parser/HTMLElementStack.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 1:58 AM Changeset in webkit [67371] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-13 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Don't call _msize
https://bugs.webkit.org/show_bug.cgi?id=45556
Because Brew MP uses its own memory allocator, it is not correct to use
_msize in fastMallocSize. Add !PLATFORM(BREWMP) guard.
- wtf/FastMalloc.cpp: (WTF::fastMallocSize):
- 1:39 AM Changeset in webkit [67370] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert notImplemented() to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=45639
The reason we never implemented this state is because it's not actually
reachable.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 1:20 AM Changeset in webkit [67369] by
-
- 2 edits in trunk/WebCore
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Buildfix for ScrollAnimatorWin
https://bugs.webkit.org/show_bug.cgi?id=45595
Use fabs() instead of abs().
- platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::animateScroll):
- 1:03 AM Changeset in webkit [67368] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
Add FrameNetworkingContextWinCE
https://bugs.webkit.org/show_bug.cgi?id=45474
- WebCoreSupport/FrameNetworkingContextWinCE.cpp: Added. (WebKit::FrameNetworkingContextWinCE::FrameNetworkingContextWinCE): (WebKit::FrameNetworkingContextWinCE::userAgent): (WebKit::FrameNetworkingContextWinCE::referrer):
- WebCoreSupport/FrameNetworkingContextWinCE.h: Added. (WebKit::FrameNetworkingContextWinCE::create):
- 12:22 AM Changeset in webkit [67367] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove fixed FIXME
https://bugs.webkit.org/show_bug.cgi?id=45637
The spec made assertions that were false. Hixie fixed the spec by
removing the assertions. There's no need to keep these FIXMEs in the
code.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
