Timeline
Sep 15, 2010:
- 10:47 PM Changeset in webkit [67598] by
-
- 3 edits in trunk/WebKit/chromium
Overload WebHTTPBody::appendFileRange() to take a double modification time argument.
https://bugs.webkit.org/show_bug.cgi?id=45829
Reviewed by Darin Fisher.
The plan is to change all callers of
WebHTTPBody::appendFileRange(..., const WebFileInfo&) to use the
new method, and then remove it.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
- 7:45 PM Changeset in webkit [67597] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2 should be able to encode and decode objects of type APIObject::TypeURL.
https://bugs.webkit.org/show_bug.cgi?id=45819
- Shared/UserMessageCoders.h: Add the ability to encode and decode the URL type. (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
- 7:18 PM Changeset in webkit [67596] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
[GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
https://bugs.webkit.org/show_bug.cgi?id=45865
When initializing the backForwardList private member of the WebView, do
so with adoptPlatformRef to prevent a memory leak.
- webkit/webkitwebview.cpp: (webkit_web_view_init): Initialize member with adoptPlatformRef.
- 7:15 PM Changeset in webkit [67595] by
-
- 2 edits in trunk/WebKit2
Add user message coding for WebUInt64 type.
Reviewed by Jon Honeycutt.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- 6:52 PM Changeset in webkit [67594] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Unreviewed.
Only show the review-in-context link if there are contextual comments.
- code-review.js:
- 6:50 PM Changeset in webkit [67593] by
-
- 3 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
We should save messages that can't be sent when postMessageToInjectedBundle is called and
send them in ensureWebProcess.
https://bugs.webkit.org/show_bug.cgi?id=45822
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Post any messages to the Injected Bundle that couldn't be sent earlier because the WebProcess hadn't been initialized yet. (WebKit::WebContext::postMessageToInjectedBundle):
- UIProcess/WebContext.h:
- 6:48 PM Changeset in webkit [67592] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Show the status bubbles on the toolbar
https://bugs.webkit.org/show_bug.cgi?id=45861
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 6:34 PM Changeset in webkit [67591] by
-
- 7 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Use GOwnPtr for code that needs it
https://bugs.webkit.org/show_bug.cgi?id=21594
Convert as reference counted private members of WebKitWebView to
smart pointers as possible. This removes a lot of unecessary manual
memory management. Also convert some pointer members away from pointer
types, now that we are sure their destructors are called.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Ditto.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::handleInputMethodKeydown): Ditto. (WebKit::EditorClient::handleInputMethodMousePress): Ditto. (WebKit::EditorClient::EditorClient): Ditto. (WebKit::EditorClient::~EditorClient): Ditto.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Ditto.
- webkit/webkitprivate.h: Ditto.
- webkit/webkitwebview.cpp: Ditto. (destroy_menu_cb): Ditto. (webkit_web_view_forward_context_menu_event): Ditto. (webkit_web_view_key_release_event): Ditto. (webkit_web_view_button_press_event): Ditto. (webkit_web_view_button_release_event): Ditto. (webkit_web_view_focus_in_event): Ditto. (webkit_web_view_focus_out_event): Ditto. (webkit_web_view_realize): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Changed all g_object_unref calls to PlatformRefPtr.clear(). Although this will also be done by the manual call to the WebKitWebViewPrivate destructor, the order that these fields are zero'd in is still very sensitive. (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes. (webViewGetDPI): Ditto. (webkit_web_view_screen_changed): Ditto. (webkit_web_view_drag_end): Ditto. (webkit_web_view_drag_data_get): Ditto. (doDragLeaveLater): Ditto. (webkit_web_view_drag_leave): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto. (webkit_web_view_get_im_context): Ditto. (webkit_web_view_update_settings): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_set_settings): Ditto. (webkit_web_view_get_settings): Ditto. (webkit_web_view_get_inspector): Ditto. (webkit_web_view_set_window_features): Ditto. (webkit_web_view_get_window_features): Ditto. (webkit_web_view_get_back_forward_list): Ditto. (webkit_web_view_zoom_in): Ditto. (webkit_web_view_zoom_out): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_get_main_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_get_subresources): Ditto.
- 6:19 PM Changeset in webkit [67590] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Allow setting review and commit-queue flags from main review screen
https://bugs.webkit.org/show_bug.cgi?id=45860
This patch adds drop down menus for adjusting the review and
commit-queue flags from the main review screen. These controls don't
appear immediately because we need to read the state of the flags off
the details page.
It's a slight sadness that bugzilla doesn't have a clean way of
identifying which select control is associated with a given flag. The
flags seem to have some sort of id, but it's unclear to me how to map
that id back to a notion of "review" or "commit-queue". Instead, we
look for some magic strings in the title. I'm sure this will come back
to bit us at some point, but I'm not sure what to do that's better.
(The webkitpy solution to this problem is to assume that the flags are
in a given order, but this seems better.)
- PrettyPatch/PrettyPatch.rb:
- Bump version number to bust throuh caches.
- code-review.js:
- 6:13 PM Changeset in webkit [67589] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
<rdar://problem/8214099> Mousewheel scrolling in WebKit2 is wonky
Use floats so that fractional scrollwheel deltas don't get lost.
- Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
- 5:40 PM Changeset in webkit [67588] by
-
- 3 edits in trunk/WebKitTools
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- 5:30 PM Changeset in webkit [67587] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-09-15 John Gregg <johnnyg@google.com>
Unreviewed, build fix after incomplete revert.
Remove layout test added in 67570 that wasn't reverted in 67574.
https://bugs.webkit.org/show_bug.cgi?id=45854
- fast/css/test-setting-canvas-color-expected.txt: Removed.
- fast/css/test-setting-canvas-color.html: Removed.
- 5:29 PM Changeset in webkit [67586] by
-
- 1 edit in trunk/ChangeLog
2010-09-15 Eric Seidel <eric@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 5:09 PM Changeset in webkit [67585] by
-
- 4 edits in trunk/WebKitTools
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] sort testing methods in DRT
https://bugs.webkit.org/show_bug.cgi?id=45850
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController):
- 5:05 PM Changeset in webkit [67584] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
CQ status shows items out of order
https://bugs.webkit.org/show_bug.cgi?id=45846
Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.
Also don't indent status items that only have a single item in their
group.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
- QueueStatusServer/templates/queuestatus.html:
- 5:05 PM Changeset in webkit [67583] by
-
- 10 edits in trunk/JavaScriptCore
2010-09-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Use free variable analysis to improve activation performance
https://bugs.webkit.org/show_bug.cgi?id=45837
Adds free and captured variable tracking to the JS parser. This
allows us to avoid construction of an activation object in some
cases. Future patches will make more use of this information to
improve those cases where activations are still needed.
- parser/ASTBuilder.h:
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::useVariable): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::capturedVariables): (JSC::JSParser::ScopeRef::ScopeRef): (JSC::JSParser::ScopeRef::operator->): (JSC::JSParser::ScopeRef::index): (JSC::JSParser::currentScope): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::parseProgram): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parsePrimaryExpression):
- parser/Nodes.cpp: (JSC::ScopeNodeData::ScopeNodeData): (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
- parser/Nodes.h: (JSC::ScopeNode::needsActivation): (JSC::ScopeNode::hasCapturedVariables):
- parser/Parser.cpp: (JSC::Parser::didFinishParsing):
- parser/Parser.h: (JSC::Parser::parse):
- parser/SyntaxChecker.h:
- runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h: (JSC::ScriptExecutable::needsActivation): (JSC::ScriptExecutable::recordParse):
- 5:04 PM Changeset in webkit [67582] by
-
- 8 edits in trunk/WebKitTools
2010-09-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.
There are also a few PEP8 changes needed to pass check-webkit-style.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 4:56 PM Changeset in webkit [67581] by
-
- 7 edits in trunk/WebKit2
Add WKUInt64Ref wrapper for sending uint64_ts.
Reviewed by Jon Honeycutt.
- Shared/APIObject.h:
- Shared/WebNumber.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetTypeID):
(WKUInt64Create):
(WKUInt64GetValue):
(WKUInt64SetValue):
- UIProcess/API/C/WKNumber.h:
- 4:51 PM Changeset in webkit [67580] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Simon Fraser <Simon Fraser>
https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url
Fix MiniBrowser crash when the url is not parseable.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]):
- 4:43 PM Changeset in webkit [67579] by
-
- 2 edits in trunk/WebCore
2010-09-15 Simon Fraser <Simon Fraser>
Fix chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- 4:30 PM Changeset in webkit [67578] by
-
- 28 edits1 add in branches/audio/WebCore
audio branch: lots of changes in preparation for moving to trunk
- more HRTF cleanup (added HRTFUtilities.cpp file)
- general cleanup AudioDestinationMac, AudioFileReaderMac, AudioResourcesMac
- added locking mechanism to AudioContext which is used by AudioNode
- removed some unnecessary method argument names in header files
- 4:29 PM Changeset in webkit [67577] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 4:27 PM Changeset in webkit [67576] by
-
- 18 edits in trunk
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44715
maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
be taken care of in platform code without the need to complicate the GraphicsLayer API.
RenderLayerCompositor no longer sets the geometry orientation for the root
platform layer; platform-specific code does this instead.
This fixes flipped layers in WebKit2, since WebKit2 was already flipping
geometry, and then RenderLayerCompositor was doing an additional flip.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::defaultContentsOrientation):
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
- platform/graphics/qt/GraphicsLayerQt.h:
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
- platform/graphics/win/GraphicsLayerCACF.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::setRootChildLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 4:25 PM Changeset in webkit [67575] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Comments should quote previous comments on the same line
https://bugs.webkit.org/show_bug.cgi?id=45847
Now when you reply to a previous comment, the tool will quote the
previous comment in the bugs.webkit.org post. This makes it eaiser for
folks following along in email to understand the discussion.
While I was editing this code, I also cleaned up some of the whitespace
handling in comments.
- code-review.js:
- 4:01 PM WebKit Team edited by
- (diff)
- 3:57 PM Changeset in webkit [67574] by
-
- 9 edits in trunk
Unreviewed.
Reverting my changes as it is breaking several tests on Gtk and Qt.
- 3:55 PM Changeset in webkit [67573] by
-
- 2 edits in trunk
[wx] Build fixes for wxMSW.
- 3:43 PM Changeset in webkit [67572] by
-
- 7 edits1 copy in trunk/WebKitTools
2010-09-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786
Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.
This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).
The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(
- QueueStatusServer/handlers/nextpatch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 3:43 PM Changeset in webkit [67571] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fix regression from bug 32230. The test needed to be updated to reflect the zoom adjusted font-size.
https://bugs.webkit.org/show_bug.cgi?id=45841
- editing/pasteboard/page-zoom.html:
- 3:31 PM Changeset in webkit [67570] by
-
- 9 edits2 adds in trunk
WebCore: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
Test: fast/css/test-setting-canvas-color.html
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
- css/CSSParser.h: Added the new parseSystemColor method.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.
- html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
LayoutTests: Test for: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
This tests that svg color, deprecated system color and different
type of colors and invalid inputs are still parsed as such.
- fast/css/test-setting-canvas-color-expected.txt: Added.
- fast/css/test-setting-canvas-color.html: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
- 3:10 PM Changeset in webkit [67569] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Minor UI tweak to the review tool. We want to display newlines in
previous and frozen comments instead of collapsing them.
- PrettyPatch/PrettyPatch.rb:
- 2:23 PM Changeset in webkit [67568] by
-
- 7 edits3 adds in trunk
2010-09-14 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230
Test: fast/css/getComputedStyle/computed-style-with-zoom.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::zoomAdjustedPixelValue): (WebCore::zoomAdjustedNumberValue): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::getBorderRadiusCornerValue): (WebCore::computedTransform): (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): (WebCore::CSSComputedStyleDeclaration::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- rendering/RenderObject.h: (WebCore::adjustForAbsoluteZoom):
- rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom):
- 12:52 PM Changeset in webkit [67567] by
-
- 4 edits2 moves4 adds in trunk/WebCore
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fully separate Pango and FreeType font backends
https://bugs.webkit.org/show_bug.cgi?id=27442
Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
Include the correct file via #ifdef'd includes, like the Chromium port. Also split
FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
compilation unit is used only by the FreeType backend. This change is important to
prevent upcoming fixes to the FreeType backend from affecting other backends.
No new tests as functionality has not changed.
- CMakeListsEfl.txt: Update source lists.
- GNUmakefile.am: Update source lists.
- platform/graphics/cairo/FontCacheCairo.cpp: Removed.
- platform/graphics/cairo/FontCacheFreeType.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::isWellKnownFontName): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/cairo/FontPlatformData.h:
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::description):
- platform/graphics/cairo/FontPlatformDataFreeType.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/gtk/FontCachePango.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/gtk/FontPlatformDataPango.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/win/FontPlatformDataCairoWin.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::useGDI): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
- 12:19 PM Changeset in webkit [67566] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=45775
Handle the toggle-overwrite signal on the GtkTextView used for generating editing
commands. Ignore this signals, as the default handler assumes that the GtkTextView
has a layout and this one does not.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): Added. Cancels the default handler. (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
- 12:16 PM Changeset in webkit [67565] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Allow for narrow columns in waterfall.
- 12:10 PM Changeset in webkit [67564] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Darken and improve contrast for success and failure boxes.
- 10:51 AM Changeset in webkit [67563] by
-
- 2 edits in trunk/LayoutTests
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Adding ellipsis-text.html to the skip list for GTK until the reason for its failure
is determined.
- platform/gtk/Skipped:
- 10:34 AM Changeset in webkit [67562] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Tony Chang <tony@chromium.org>
Unreviewed, remove test that is now passing in test_shell and DRT.
- platform/chromium/test_expectations.txt:
- 10:07 AM Changeset in webkit [67561] by
-
- 5 edits2 adds in trunk
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Reviewed by Simon Fraser.
WebCore:
Allow accessibility to retrieve the absoluteQuads of a text node that
clips to the ellipsis.
Test: accessibility/ellipsis-text.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
- rendering/RenderText.cpp:
(WebCore::ellipsisRectForBox):
Make a common method to retrieve the ellipsis rect.
(WebCore::RenderText::absoluteQuads):
Default into the absoluteQuads method that allows for ellipsis clipping.
(WebCore::RenderText::selectionRectForRepaint):
Use the common method for retrieving the ellipsis.
- rendering/RenderText.h:
LayoutTests:
- accessibility/ellipsis-text-expected.txt: Added.
- accessibility/ellipsis-text.html: Added.
- 10:05 AM Changeset in webkit [67560] by
-
- 3 edits in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=45791
Force filenames to be raw bytes before running difflib.unified_diff.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 9:44 AM Changeset in webkit [67559] by
-
- 5 edits in trunk
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Update pixel test result.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Rewrite the shadow blur function with loop unrolls and sliding step
unification for both horizontal and vertical directions.
This gives significant performance improvement on most cases.
- platform/graphics/qt/ContextShadow.cpp: (WebCore::shadowBlur):
- 9:06 AM Changeset in webkit [67558] by
-
- 3 adds1 delete in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
2010-09-15 William Siegrist <wsiegrist@apple.com>
Sync buildbot files after upgrade to v0.8.1
- 8:52 AM Changeset in webkit [67557] by
-
- 3 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
fast/dom/DeviceOrientation/add-listener-from-callback flaky
https://bugs.webkit.org/show_bug.cgi?id=45814
When we call addEventListener(), an event is sent to all registered
event listeners on that page. So in the existing test, both the calls
to setMockDeviceOrientation() and addEventListener() will trigger events
to fire asynchronously on both listeners (both will be registered by the
time the event fires), giving a total of five events. A race condition
exists as to whether the test finishes after the third event, before
the fourth event fires.
This patch fixes the problem by expecting the correct number of events
to fire. We also remove the call to setMockDeviceOrientation() as this
adds extra complication and is tested in update.html.
- fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt:
- fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: (checkOrientation): (firstListener):
- 8:35 AM Changeset in webkit [67556] by
-
- 2 edits in trunk/PlanetWebKit
Use Qt Labs' WebKit category feed instead of filtering on "webkit"
Looks like the URL of the WebKit category feed changed since this blog
was first added to Planet WebKit.
Rubber-stamped by David Kilzer.
- config.ini:
- 8:20 AM Changeset in webkit [67555] by
-
- 2 edits in trunk/PlanetWebKit
Only include Qt Labs posts that mention WebKit
All other feeds are either WebKit-specific or are filtered on
"webkit". This makes Qt Labs match all the others. This should help
keep off-topic posts off of Planet WebKit.
Fixes <http://webkit.org/b/45818> Planet WebKit contains many
off-topic posts from Qt Labs
Reviewed by David Kilzer.
- config.ini: Filter the Qt Labs feed on "webkit" like we do for all
other non-WebKit-specific feeds.
- 6:32 AM Changeset in webkit [67554] by
-
- 3 edits in trunk/WebKitTools
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247
Reviewed by Tor Arne Vestbø.
The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
- QtTestBrowser/mainwindow.h:
- 6:25 AM Changeset in webkit [67553] by
-
- 38 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:56 AM Changeset in webkit [67552] by
-
- 37 edits in trunk
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didFinishLoading):
- loader/MainResourceLoader.h:
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::finishedCallback): (WebCore::parseDataUrl):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:04 AM Changeset in webkit [67551] by
-
- 37 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 4:45 AM Changeset in webkit [67550] by
-
- 1 edit40 adds in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] rebaseline 10 new svg tests added in 67544
https://bugs.webkit.org/show_bug.cgi?id=45813
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- 4:34 AM Changeset in webkit [67549] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the Symbian def files
Re-freeze with the viewport meta tag updates.
- symbian/eabi/QtWebKitu.def:
- 4:34 AM Changeset in webkit [67548] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] mark new viewport tests as failing rather then skip them
https://bugs.webkit.org/show_bug.cgi?id=45652
- platform/chromium/test_expectations.txt:
- 4:17 AM Changeset in webkit [67547] by
-
- 10 edits in trunk
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
- 3:05 AM Changeset in webkit [67546] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Kent Tamura.
LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=45783
This test synchronously navigates the page to a new URL from its main script file.
This navigation causes WebView.onPageFinished() to be called for the test page.
The problem is that this may occur before js-test-post.js, which is included by the
test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a
result, the test is incorrectly deemed to have finished as soon as the navigation
is started and the output will therefore be incorrect.
This patch fixes the problem by initiating the page navigation from
the onload handler, which is not fired until all resources have been
loaded and parsed. This guarantees that WebView.onPageFinished() is
not called until after layoutTestController.waitUntilDone() has been
called.
- fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
- 2:44 AM Changeset in webkit [67545] by
-
- 2 edits in trunk/WebCore
2010-09-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Multiline console does not work on Windows / Linux.
https://bugs.webkit.org/show_bug.cgi?id=45807
- inspector/front-end/ConsoleView.js:
- 2:13 AM Changeset in webkit [67544] by
-
- 4 edits50 adds in trunk
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=45809
Adding layout tests for feTurbulence dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-baseFrequency-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-numOctaves-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-seed-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-stitchTiles-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-type-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-numOctaves-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-seed-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-stitchTiles-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-type-prop.js: Added. (executeTest):
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
A typo (noStich instead of nostitch) is also fixed in this patch.
https://bugs.webkit.org/show_bug.cgi?id=45809
Tests: svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
- svg/SVGFETurbulenceElement.h:
- 1:58 AM Changeset in webkit [67543] by
-
- 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp
Merge 67185 - 2010-09-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Joseph Pecoraro.
WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.
- Open any page
- Right-click on any element, select "Inspect Element"
- Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
- Inspect the Web Inspector. An error message is logged in the console.
The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/3385005
- 1:55 AM Changeset in webkit [67542] by
-
- 1 edit2 copies in branches/chromium/517
Merge 66813 - 2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
Test: inspector/debugger-suspend-active-dom-objects.html
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
- inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
- inspector/debugger-suspend-active-dom-objects.html: Added.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/3446004
- 1:46 AM Changeset in webkit [67541] by
-
- 2 edits in trunk/WebCore
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Avoid memcpy in TextCodecWinCE::encode
https://bugs.webkit.org/show_bug.cgi?id=45468
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::TextCodecWinCE::encode):
- 1:29 AM Changeset in webkit [67540] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Web Inspector] mark two debugger tests as slow on win debug chromium
https://bugs.webkit.org/show_bug.cgi?id=45742
- platform/chromium/test_expectations.txt:
- 12:20 AM Changeset in webkit [67539] by
-
- 2 edits in trunk/WebKit/mac
Roll out r67533 to fix the build.
Sep 14, 2010:
- 11:41 PM Changeset in webkit [67538] by
-
- 8 edits2 adds in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
https://bugs.webkit.org/show_bug.cgi?id=45724
No new tests; tests will be added later.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDirectoryEntryCustom.cpp: Added. (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
- fileapi/DirectoryEntry.h:
- fileapi/DirectoryEntry.idl:
- 10:59 PM Changeset in webkit [67537] by
-
- 5 edits3 adds1 delete in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline to fix build.
[chromium] rebaselines for bug16012.html after font-size changes
https://bugs.webkit.org/show_bug.cgi?id=45805
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.png: Added.
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.txt:
- 10:26 PM Changeset in webkit [67536] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline.
Rebaseline xss-DENIED-frame-name-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=45795
- platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- 10:03 PM Changeset in webkit [67535] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Attempt to fix test failure on Qt and Gtk. It's tricky to write a test
for an API that supposed to report the current date and time without a
timezone. This patch increases the allowably time window to a day +
one hour, which should be enough to account for any timezone issues.
- http/tests/misc/no-last-modified.html:
- 9:38 PM Changeset in webkit [67534] by
-
- 12 edits in trunk
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp: (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp: (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() when autocorrection panel is shown. (WebCore::createCommandMap): Replaced isSupported function pointer for executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, for invalid correction panel tag. Replaced -1 with this constant. (WebEditorClient::dismissCorrectionPanel): Ditto (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 9:09 PM Changeset in webkit [67533] by
-
- 2 edits in trunk/WebKit/mac
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
- WebView/WebView.mm: (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
when the application level preferences are not set.
- 8:47 PM Changeset in webkit [67532] by
-
- 12 edits in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fileapi/ThreadableBlobRegistry.cpp: (WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- src/ResourceHandle.cpp:
- 8:37 PM Changeset in webkit [67531] by
-
- 2 edits in trunk/WebCore
2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Zoom factor for checkboxes and radios.
https://bugs.webkit.org/show_bug.cgi?id=45776
RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.
Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
- 8:19 PM Changeset in webkit [67530] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-14 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add AudioFileReader files (Mac implementation)
https://bugs.webkit.org/show_bug.cgi?id=36475
No new tests since audio API is not yet implemented.
- platform/audio/AudioFileReader.h: Added.
- platform/audio/mac/AudioFileReaderMac.cpp: Added. (WebCore::createAudioBufferList): (WebCore::destroyAudioBufferList): (WebCore::AudioFileReader::AudioFileReader): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::readProc): (WebCore::AudioFileReader::getSizeProc): (WebCore::AudioFileReader::createBus): (WebCore::createBusFromAudioFile): (WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h: Added. (WebCore::AudioFileReader::data): (WebCore::AudioFileReader::dataSize):
- 7:31 PM Changeset in webkit [67529] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
https://bugs.webkit.org/show_bug.cgi?id=44764
- wtf/OwnPtrCommon.h:
- wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
- 7:04 PM Changeset in webkit [67528] by
-
- 2 edits1 add in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugs.webkit.org should autocomplete WebKit Committers and Reviewers
https://bugs.webkit.org/show_bug.cgi?id=45799
This patch implements an autocomplete dropdown that helps users type
the names of WebKit committers and reviewers. The script grabs the
data from SVN now that wms set up CORS for http://svn.webkit.org.
Security technology for the win.
This script is based on (well, essentially copied from) the popular
autocomplete extension:
https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb
I asked Ojan, and said he was fine licensing the code under the BSD
license. I'm not sure how the patch interacts with the extension, but
we can retire the extension if they interact poorly.
- committers-autocomplete.js: Added.
- template/en/default/global/footer.html.tmpl:
- Add the script to every page on bugs.webkit.org
- 6:59 PM Changeset in webkit [67527] by
-
- 2 edits in trunk/WebKitTools
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156
Move printf inside shouldDumpAccessibilityNotifications check.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- 6:55 PM Changeset in webkit [67526] by
-
- 2 edits in trunk/WebCore
2010-09-14 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
Drawing an image outside the bounds of a canvas still causes repaints
https://bugs.webkit.org/show_bug.cgi?id=45792
Some canvas examples, such as http://www.phoboslab.org/biolab/, draw
images outide the bounds of the canvas. If the canvas already had a
non-empty m_dirtyRect, such draws would cause us to do a repaint of
m_dirtyRect again (which goes through the platform-specific invalidation
machinery, which can be slow).
Optimize this by avoiding extra invalidation when the dirty rect
does not intersect the canvas bounds.
Not testable because this avoids additional repaints of m_dirtyRect, but
m_dirtyRect has to be non-empty for this to benefit.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
- 6:42 PM Changeset in webkit [67525] by
-
- 5 edits in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link
- inspector/front-end/inspector.js: code cleanup: removed no-op method (WebInspector.addMainEventListeners):
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- src/js/DevTools.js: remove obsolete code
- 6:26 PM BuildingGtk edited by
- (diff)
- 6:25 PM Changeset in webkit [67524] by
-
- 6 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DEPS: Include webkit_support::LocalFileToDataURL
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
- 6:23 PM Changeset in webkit [67523] by
-
- 3 edits in trunk/WebCore
2010-09-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Use codePage instead of TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=45466
Use codePage as member variable to avoid repeated lookup.
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode):
- platform/text/wince/TextCodecWinCE.h:
- 5:48 PM Changeset in webkit [67522] by
-
- 2 edits in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Add a license block to the reviewtool. I should have added this from
the start. According to the SVN log, I'm the only one to have ever
touched this file.
- code-review.js:
- 5:45 PM Changeset in webkit [67521] by
-
- 5 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- public/WebKit.h:
- src/WebKit.cpp:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
- 5:36 PM Changeset in webkit [67520] by
-
- 2 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Attempted Chromium build fix. The compiler can't tell that
ASSERT_NOT_REACHED is not reached and so it demands an initialization
of this variable.
- html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
- 5:34 PM Changeset in webkit [67519] by
-
- 3 edits in trunk/WebKit/efl
2010-09-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] ewk_frame_view_create_for_view set null as theme.
https://bugs.webkit.org/show_bug.cgi?id=45741
Add theme in ewk_view to use instead of frame's theme which is null in
ewk_frame_view_create_for_view.
- ewk/ewk_frame.cpp: (ewk_frame_view_create_for_view):
- ewk/ewk_view.cpp: (ewk_view_theme_set): (ewk_view_theme_get):
- 5:19 PM Changeset in webkit [67518] by
-
- 5 edits in trunk/WebKit/mac
Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
Reviewed by John Sullivan.
- Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
- Misc/WebKitVersionChecks.m:
(WebKitLinkedOnOrAfter):
(setWebKitLinkTimeVersion): Set the overridden version.
(WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
- WebView/WebPreferences.mm:
(+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
- WebView/WebPreferencesPrivate.h:
- 5:19 PM Changeset in webkit [67517] by
-
- 4 edits in trunk
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Remove blob-related tests that now pass.
- platform/chromium/drt_expectations.txt:
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Roll Chromium forward to r59406, which registers the blob
URL scheme for the Chromium DRT too.
- DEPS:
- 4:53 PM Changeset in webkit [67516] by
-
- 2 edits in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Wheeling over windowed plugins sometimes cause them to disappear
- plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::x11Event): Pass on captured mouse wheel events to the effective native window rather than the grandparent widget. We were calling QWidget::winId() which caused a new X11 window to be created for the grandparent widget and generally mess things up.
- 4:46 PM Changeset in webkit [67515] by
-
- 8 edits1 add in trunk
[wx] Build fixes after recent changes.
- 4:32 PM Changeset in webkit [67514] by
-
- 7 edits in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update font size parser to match HTML5 spec. The main difference here
is the handling of 0, which now maps to 1 instead of 3.
- html/HTMLFontElement.cpp: (WebCore::parseFontSize): (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update tests and results to match new behavior.
- editing/execCommand/query-font-size-expected.txt:
- fast/dom/HTMLFontElement/script-tests/size-attribute.js:
- fast/dom/HTMLFontElement/size-attribute-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
- 4:29 PM Changeset in webkit [67513] by
-
- 3 edits5 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
Implement document.lastModified as per HTML5.
Tests: http/tests/misc/last-modified-parsing.html
http/tests/misc/no-last-modified.html
- dom/Document.cpp: (WebCore::Document::lastModified):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
- http/tests/misc/last-modified-parsing-expected.txt: Added.
- http/tests/misc/last-modified-parsing.html: Added.
- Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
- http/tests/misc/no-last-modified-expected.txt: Added.
- http/tests/misc/no-last-modified.html: Added.
- Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
- http/tests/resources/last-modified.php: Added.
- PHP helper script.
- 4:27 PM Changeset in webkit [67512] by
-
- 7 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Moving the compatMode IDL attribute from HTMLDocument.idl to
Document.idl fixes this bug and improve compliance with HTML5.
Test: fast/parser/compatMode-in-xhtml.xhtml
- dom/Document.cpp: (WebCore::Document::compatMode):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLDocument.cpp:
- html/HTMLDocument.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Test the value of compatMode in XHTML. I'm terrible at XML, but this
test seems to work.
- fast/parser/compatMode-in-xhtml-expected.txt: Added.
- fast/parser/compatMode-in-xhtml.xhtml: Added.
- 4:15 PM Changeset in webkit [67511] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-09-14 James Kozianski <soulplant@gmail.com>
Reviewed by Ojan Vafai.
Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window
https://bugs.webkit.org/show_bug.cgi?id=18447
Add a test for CSSStyleDeclaration.prototype.foo leaking into inner
windows.
- fast/frames/css-style-declaration-isolation-expected.txt: Added.
- fast/frames/css-style-declaration-isolation.html: Added.
- 4:13 PM Changeset in webkit [67510] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- win/WebKit2Generated.make:
- 4:12 PM Changeset in webkit [67509] by
-
- 3 edits3 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test: http/tests/security/xss-DENIED-frame-name.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheck):
- If the property name exists on the object, it will shadow the named property lookup on the window object. That means we need to block access if there's shadowing going on.
(WebCore::V8DOMWindow::indexedSecurityCheck):
- I made the corresponding change to this function too, but I don't think this one can actually be triggered because JavaScript variable names need to start with a non-digit.
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test whether cross-origin observers can see global variables shadowing
named frames.
- http/tests/security/resources/frame-for-parent-name.html: Added.
- http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- http/tests/security/xss-DENIED-frame-name.html: Added.
- 4:12 PM Changeset in webkit [67508] by
-
- 4 edits in branches/chromium/517/WebKit/chromium
Merge 67418 - 2010-09-13 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572
- public/WebAccessibilityObject.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/3398006
- 3:53 PM Changeset in webkit [67507] by
-
- 12 edits2 deletes in trunk
Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785
Reviewed by Anders Carlsson.
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Remove files.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleNode.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp:
(WKBundleRangeCopyStartContainer):
(WKBundleRangeCopyEndContainer):
- WebProcess/InjectedBundle/API/c/WKBundleRange.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
Change to be in terms of WKBundleNodeHandleRef.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 3:53 PM Changeset in webkit [67506] by
-
- 9 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Updated our integer parsing for tabindex to use the algorithm from the
HTML5 spec.
Test: fast/parser/tabindex-parsing-2.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTMLInteger):
- html/parser/HTMLParserIdioms.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
- fast/parser/tabindex-parsing-2-expected.txt: Added.
- fast/parser/tabindex-parsing-2.html: Added.
- Test a bunch of corner cases in tabindex parsing.
- fast/parser/tabindex-parsing-expected.txt:
- fast/parser/tabindex-parsing.html:
- Update expected result. This case is actually the one that the original reporter was complaining about.
- 3:48 PM Changeset in webkit [67505] by
-
- 2 edits in trunk/WebCore
Build correction, no review.
- WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from
non-Cairo based builds.
- 3:38 PM Changeset in webkit [67504] by
-
- 3 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:26 PM Changeset in webkit [67503] by
-
- 12 edits in trunk
fast/files/apply-blob-url-to-img.html timeout on Leopard
https://bugs.webkit.org/show_bug.cgi?id=45576
Reviewed by David Levin.
WebCore:
The failure on Leopard is caused by the static method
ResourceHandle::supportsBufferedData that returns true to indicate that
the buffered data support is enabled for blob resource. However,
BlobResourceHandle does not support this and we need to override this.
The fix is to change supportsBufferedData method from static to virtual
so that we can override the default behavior in BlobResourceHandle.
- fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread.
(WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::supportsBufferedData): Override the default
behavior.
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h: Made supportsBufferedData virtual.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::bufferedData):
WebKit/chromium:
- src/ResourceHandle.cpp: Remove the no longer applicable static comment.
LayoutTests:
Update the test to compute the right coordinates to drag the file to.
This fixes the problem that onInputFileChange() is not called on
Leopard.
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped: Remove the passing test from Skipped list.
- 3:19 PM Changeset in webkit [67502] by
-
- 1 edit24 deletes in trunk/LayoutTests
2010-09-14 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Remove the wrong chromium-win-vista expectations.
Layout test results generated from Chromium vista bots match
the expectations in chromium-win. These baselines are either
wrong or out of date. Need to be cleaned up so chromium
vista bots can pass on these tests.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.png: Removed.
- 3:00 PM Changeset in webkit [67501] by
-
- 4 edits in trunk
2010-09-14 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Exceptions are getting ignored on 64-bit Windows in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=45779
WebKit2:
- WebProcess/WebKitMain.cpp: (disableProcessCallbackFilterForExceptions): Clear the PROCESS_CALLBACK_FILTER_ENABLED flag so that exceptions thrown in callback routines are not ignored, as described in http://support.microsoft.com/kb/976038 and http://blog.paulbetts.org/index.php/2010/07/20/the-case-of-the-disappearing-onload-exception-user-mode-callback-exceptions-in-x64/. (WebKitMain):
WebKitSite:
- building/tools.html: Add instructions about how to optionally get hotfix 976038.
- 2:55 PM Changeset in webkit [67500] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Fixed layout test failure seen on buildbot by correcting expected results.
It looks like Darin accidentally checked in the wrong expected results.
- fast/css/visited-link-hang-expected.txt:
- 2:43 PM Changeset in webkit [67499] by
-
- 5 edits in trunk
Build correction, no review.
WebCore:
- WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp implementation file.
- platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include for <cairo.h>
WebKit2:
- win/WebKit2.vcproj: Disable build for Cairo targets of
the WebURLRequestWin.cpp and WebURLResponseWin.cpp files.
- 2:29 PM Changeset in webkit [67498] by
-
- 14 edits32 adds2 deletes in trunk
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
- WebKit.gyp:
- public/WebAccessibilityNotification.h: Added.
- public/WebViewClient.h: (WebKit::WebViewClient::postAccessibilityNotification):
- src/AssertMatchingEnums.h: Added.
- src/ChromeClientImpl.cpp: (WebKit::toWebAccessibilityNotification): (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren): (WebKit::ChromeClientImpl::postAccessibilityNotification):
- src/ChromeClientImpl.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html
platform/chromium/accessibility/post-notification-CheckedStateChanged.html
platform/chromium/accessibility/post-notification-ChildrenChanged.html
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html
platform/chromium/accessibility/post-notification-LayoutComplete.html
platform/chromium/accessibility/post-notification-LiveRegionChanged.html
platform/chromium/accessibility/post-notification-LoadComplete.html
platform/chromium/accessibility/post-notification-MenuListValueChanged.html
platform/chromium/accessibility/post-notification-RowCollapsed.html
platform/chromium/accessibility/post-notification-RowCountChanged.html
platform/chromium/accessibility/post-notification-RowExpanded.html
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html
platform/chromium/accessibility/post-notification-SelectedTextChanged.html
platform/chromium/accessibility/post-notification-ValueChanged.html
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- platform/chromium/accessibility/children-changed-notification-expected.txt: Removed.
- platform/chromium/accessibility/children-changed-notification.html: Removed.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete.html: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Added.
- platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LoadComplete.html: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed.html: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowExpanded.html: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Added.
- platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ValueChanged.html: Added.
- platform/chromium/accessibility/post-notification.js: Added. (enumAccessibilityObjects): (testDone): (test):
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:22 PM Changeset in webkit [67497] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Adam Roben.
Add an IWebFramePrivate API to load string as plain text into the WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=45782
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl: Touch the file.
- WebFrame.cpp: (WebFrame::loadPlainTextString):
- WebFrame.h:
- 2:10 PM Changeset in webkit [67496] by
-
- 3 edits2 adds in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
Test: fast/css/visited-link-hang.html
- platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): Added a start position argument and changed types to use size_t consistently instead of a mix. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::squeezeOutNullCharacters): Added. (WebCore::cleanSlashDotDotSlashes): Added. Factored out part of cleanPath (see below). (WebCore::mergeDoubleSlashes): Ditto. (WebCore::cleanSlashDotSlashes): Ditto. (WebCore::cleanPath): Changed algorithm to not remove as we go to avoid N2 behavior; instead replace with null characters and then do a squeeze operation after the fact. Also moved the body of the function out of line since we normally don't have to do any cleaning. This whole thing should go at some point -- it's not the right algorithm -- but this should eliminate the performance problems without changing behavior.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
- fast/css/visited-link-hang-expected.txt: Added.
- fast/css/visited-link-hang.html: Added.
- 2:07 PM Changeset in webkit [67495] by
-
- 4 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue is slow during the day
https://bugs.webkit.org/show_bug.cgi?id=45780
Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.
This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:06 PM Changeset in webkit [67494] by
-
- 5 edits in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- runtime/JSArray.cpp: (JSC::JSArray::sort): Replaced early exit for an array of length zero to instead exit for any array without values, even if it has a non-0 length.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- fast/js/script-tests/sort-large-array.js: Added test cases.
- fast/js/sort-large-array-expected.txt: Updated.
- 2:02 PM Changeset in webkit [67493] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: On Mac, let image layer data row order match skia.
https://bugs.webkit.org/show_bug.cgi?id=45400
Make CoreGraphics texture row order match skia's row order, remove all
code that worked around this difference. This also fixes a problem where
image layers would be drawn upside down.
Covered by existing layout tests, but we don't run these with
compositing yet.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::drawLayers):
- 1:45 PM Changeset in webkit [67492] by
-
- 2 edits in tags/Safari-534.7.2/JavaScriptCore
Merge r67482.
- 1:41 PM Changeset in webkit [67491] by
-
- 5 edits in tags/Safari-534.7.2
Versioning.
- 1:29 PM Changeset in webkit [67490] by
-
- 10 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
- fast/events/event-input-contentEditable-expected.txt: Merged two anchor elements.
- fast/events/event-input-contentEditable.html: Ditto.
- 1:27 PM Changeset in webkit [67489] by
-
- 1 copy in tags/Safari-534.7.2
New tag.
- 1:08 PM Changeset in webkit [67488] by
-
- 4 edits in trunk
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::ensureDebuggerScriptLoaded): Added, loads DebuggerScript.js into ScriptDebugServer. (WebCore::InspectorClientQt::openInspectorFrontend): Ensure that DebuggerScript.js is loaded before opening an inspector.
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- inspector/front-end/WebKit.qrc: Add DebuggerScript.js
- 12:56 PM Changeset in webkit [67487] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium win compile.
- public/WebView.h:
- 12:48 PM Changeset in webkit [67486] by
-
- 2 edits in trunk/WebCore
PPC Build fix.
- 12:44 PM Changeset in webkit [67485] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[chromium] Remove unused ICU headers
https://bugs.webkit.org/show_bug.cgi?id=45698
Remove unused headers.
- platform/graphics/chromium/FontCacheLinux.cpp:
- 12:23 PM Changeset in webkit [67484] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode
https://bugs.webkit.org/show_bug.cgi?id=17722
I believe our behavior matches the HTML5 spec. When we see a </x>, we
correctly kick out of standards mode. In the </> case, however, the
tokenizer just eats the bytes, without emitting a token, which means we
don't get kicked out of standards mode. Our behavior matches Minefield.
- fast/parser/strange-doctype-compatmode-1-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-1.html: Added.
- fast/parser/strange-doctype-compatmode-2-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-2.html: Added.
- 12:02 PM Changeset in webkit [67483] by
-
- 2 edits1 add in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Numpad Enter key returns keyCode 0 instead of 13
https://bugs.webkit.org/show_bug.cgi?id=45014
Original patch by Jarred Nicholls <jarred.nicholls@gmail.com>
There is a missing case statement in the PlatformKeyboardEventQt.cpp
file to handle the Enter button on the number pad. Because it is not
handled, the keyCode returned in a JavaScript event is 0 rather than 13.
Test: manual-tests/qt/numpad-enter-key.html
- manual-tests/qt/numpad-enter-key.html: Added.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 11:49 AM Changeset in webkit [67482] by
-
- 2 edits in trunk/JavaScriptCore
Windows production build fix.
Roll out r65143.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- 11:15 AM Changeset in webkit [67481] by
-
- 2 edits in trunk/WebCore
2010-09-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Fisher.
[chromium] building without debug syms broke after recent refactoring
https://bugs.webkit.org/show_bug.cgi?id=45720
Now that we build WebCore as multiple libraries, we need to adjust the
flags to turn off debug symbols for all of these libraries.
No new tests; should only affect an uncommon build flag.
- WebCore.gyp/WebCore.gyp:
- 10:59 AM Changeset in webkit [67480] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, remove tests that are now passing after Noel Gordon's
fix to test_shell delete key handling.
- platform/chromium/test_expectations.txt:
- 10:38 AM Changeset in webkit [67479] by
-
- 9 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- public/WebView.h: add WebView::setDomainRelaxationForbidden
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDomainRelaxationForbidden):
- src/WebViewImpl.h:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/chromium/LayoutTestController.h:
- 10:27 AM Changeset in webkit [67478] by
-
- 2 edits in trunk/WebCore
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile.
- platform/graphics/chromium/ImageLayerChromium.h:
- 10:16 AM Changeset in webkit [67477] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
[chromium]: crash less in compositor mode on mac
https://bugs.webkit.org/show_bug.cgi?id=45714
The contents image can go away when the dom is updated. Since the
layer tree is updated asynchronously, it needs to ref the native image,
else it will hold on to a stale object.
This still needs to be done for skia, too.
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- 10:04 AM Changeset in webkit [67476] by
-
- 2 edits in trunk/WebKit/efl
2010-09-14 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix: remove "virtual" keyword from
implementation file.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
- 9:49 AM Changeset in webkit [67475] by
-
- 3 edits1 move in trunk/JavaScriptCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Share UnicodeMacrosFromICU.h
https://bugs.webkit.org/show_bug.cgi?id=45710
glib, qt4 and wince use the same macros from ICU.
Remove the code duplication and use the same header file.
- wtf/unicode/UnicodeMacrosFromICU.h: Copied from JavaScriptCore/wtf/unicode/glib/UnicodeMacrosFromICU.h.
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Removed.
- wtf/unicode/qt4/UnicodeQt4.h:
- wtf/unicode/wince/UnicodeWince.h:
- 9:30 AM Changeset in webkit [67474] by
-
- 7 edits in trunk
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support for resource timings to HAREntry.
https://bugs.webkit.org/show_bug.cgi?id=45663
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildTimings): (WebInspector.HAREntry.prototype._toMilliseconds): (WebInspector.HAREntry.prototype._interval):
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
https://bugs.webkit.org/show_bug.cgi?id=45663
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resource-test2.js: Added entire timings object to list of non-deterministic fields.
- http/tests/inspector/resource-tests.js: Ditto.
- 9:19 AM Changeset in webkit [67473] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Always set LeftButton in PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=45705
AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
which button is pressed or released. The current code erroneously sets NoButton.
Set LeftButton unconditionally because Brew MP usually runs on touch device.
- platform/brew/PlatformMouseEventBrew.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 8:40 AM Changeset in webkit [67472] by
-
- 4 edits1 move1 delete in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- bindings/v8/DebuggerScript.js: Added.
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- WebKit.grd:
- WebKit.gypi:
- src/js/DebuggerScript.js: Removed.
- src/js/DevToolsHostStub.js: Removed.
- 8:31 AM Changeset in webkit [67471] by
-
- 4 edits9 adds2 deletes in trunk/LayoutTests
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Rebaseline DeviceOrientation related layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45542
Some DeviceOrientation layout tests need Chromium-specific
baselines because of differences between JSC and V8.
Also enable prototype-inheritance.html again and unfork its
expectations.
- fast/dom/script-tests/prototype-inheritance.js:
- platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:18 AM Changeset in webkit [67470] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] add new tests from r67463 to expectations
https://bugs.webkit.org/show_bug.cgi?id=45753
- platform/chromium/test_expectations.txt:
- 7:59 AM Changeset in webkit [67469] by
-
- 7 edits in trunk
2010-09-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore
https://bugs.webkit.org/show_bug.cgi?id=45530
WebCore:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
- css/CSSStyleSelector.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
LayoutTests:
- inspector/elements-panel-styles-expected.txt:
- inspector/resources/elements-panel-styles.css: (.foo): (.foo::before):
- 7:42 AM Changeset in webkit [67468] by
-
- 2 edits in trunk/WebCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Darin Adler.
[BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
https://bugs.webkit.org/show_bug.cgi?id=45701
SharedBuffer::createWithContentsOfFile() reads file content and saves to
result.m_buffer directly, leaving result.m_size unchanged.
- platform/brew/SharedBufferBrew.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 7:25 AM Changeset in webkit [67467] by
-
- 7 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move adjustLexerState to the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=45649
This function used let us share code between the tree builder and the
two other users of the HTMLTokenizer. However, now that the tree
builder is all grown up, it can't use this code anymore. The other
users would much rather this code lived on HTMLTokenizer and understood
<script>. This patch attempts to make them happy.
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTokenizer.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::scriptEnabled):
- html/parser/HTMLTreeBuilder.h:
- html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
- 7:06 AM Changeset in webkit [67466] by
-
- 4 edits4 adds16 deletes in trunk/LayoutTests
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610
post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.
- http/tests/navigation/post-basic-expected.txt: Added.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames-expected.txt: Added.
- http/tests/navigation/post-frames.html:
- http/tests/navigation/resources/form-target.pl: Added
- http/tests/navigation/resources/page-that-posts.html: Added.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
- 7:04 AM Changeset in webkit [67465] by
-
- 2 edits in trunk
2010-09-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] qmake doesn't generate correct dependencies for rcc resource files
https://bugs.webkit.org/show_bug.cgi?id=45747
- WebKit.pri: add OUT_PWD to DEPENDPATH
- 6:33 AM Changeset in webkit [67464] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Anton Muhin <antonm@chromium.org>
Unreviewed cleanup of test expectations for Chromium.
ietestcenter/Javascript/15.4.4.15-3-14.html, ietestcenter/Javascript/15.4.4.15-3-29.html and
ietestcenter/Javascript/15.4.4.15-3-8.html are passing now.
- platform/chromium/test_expectations.txt:
- 6:25 AM Changeset in webkit [67463] by
-
- 3 edits8 adds in trunk
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.
- fast/repaint/block-layout-inline-children-float-positioned.html: Added.
- fast/repaint/block-layout-inline-children-replaced.html: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.
Patch by: Dave Hyatt
Tests: fast/repaint/block-layout-inline-children-float-positioned.html
fast/repaint/block-layout-inline-children-replaced.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 6:20 AM Changeset in webkit [67462] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Make WebDeviceOrientationClientMock constructor private.
https://bugs.webkit.org/show_bug.cgi?id=45743
Clients should use the create member function instead. DumpRenderTree
and the Chromium test_shell have previously been updated to call create.
- public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
- 6:16 AM Changeset in webkit [67461] by
-
- 2 edits in trunk/WebCore
2010-09-14 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Andreas Kling.
[Qt] Cookie operations should use NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45745
No new functionality so no new tests.
- platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager instead of directly accessing the FrameLoaderClient.
- 5:38 AM Changeset in webkit [67460] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] mark fast/frames/frame-limit.html as DEBUG SLOW CRASH
https://bugs.webkit.org/show_bug.cgi?id=45738
- platform/chromium/test_expectations.txt:
- 5:26 AM Changeset in webkit [67459] by
-
- 8 edits3 deletes in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/execCommand/script-tests/toggle-style-3.js:
- editing/execCommand/toggle-style-3-expected.txt:
- editing/execCommand/unlink-expected.txt:
- editing/style/inline-style-extend-run-expected.txt: Removed.
- editing/style/inline-style-extend-run.html: Removed.
- editing/style/script-tests/inline-style-extend-run.js: Removed.
- editing/style/script-tests/make-text-writing-direction-inline.js:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown):
- editing/ApplyStyleCommand.h:
- 4:07 AM Changeset in webkit [67458] by
-
- 12 edits in trunk
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::createCommandMap):
- loader/EmptyClients.h:
- page/EditorClient.h:
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::dismissCorrectionPanel):
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::dismissCorrectionPanel):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 2:52 AM Changeset in webkit [67457] by
-
- 2 edits in trunk/WebKitTools
Adding myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 AM Changeset in webkit [67456] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
https://bugs.webkit.org/show_bug.cgi?id=45736
Reviewed by Kenneth Rohde Christiansen.
Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.
- Scripts/build-webkit:
- 2:23 AM Changeset in webkit [67455] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; an attempt to fix Chromium Windows build.
- fileapi/FileEntry.cpp:
- 2:10 AM Changeset in webkit [67454] by
-
- 3 edits in trunk/WebCore
2010-09-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide support for opening external navigation for links within certain elements
Use default handling for clicks on links that have target="_blank"
Add option for external navigation to URL audit formatter.
https://bugs.webkit.org/show_bug.cgi?id=45671
- inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.url):
- inspector/front-end/inspector.js:
- 1:26 AM Changeset in webkit [67453] by
-
- 2 edits in trunk/WebKit/qt
2010-09-14 Enrico Ros <eros@codeaurora.org>
Reviewed by Andreas Kling.
[Qt] Respect title attribute on option elements
https://bugs.webkit.org/show_bug.cgi?id=45084
Set the tooltip in the combo box model, so it's reflected in the view.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
- 1:03 AM Changeset in webkit [67452] by
-
- 2 edits in trunk/WebCore
Build fix.
- editing/EditorCommand.cpp:
- 12:50 AM Changeset in webkit [67451] by
-
- 12 edits in trunk
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Patch by Jia Pu <jpu@apple.com> on 2010-09-14
Reviewed by Dan Bernstein.
WebCore:
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp:
(WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection
panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp:
(WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation()
when autocorrection panel is shown.
(WebCore::createCommandMap): Replaced isSupported function pointer for
executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of
new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
WebKit/mac:
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
for invalid correction panel tag. Replaced -1 with this constant.
(WebEditorClient::dismissCorrectionPanel): Ditto
(WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 12:40 AM Changeset in webkit [67450] by
-
- 1 edit1 delete in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45691
Brew MP no longer depends on ICU for internationalization.
Remove TextBreakIteratorInternalICUBrew.cpp.
- platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed.
- 12:12 AM Changeset in webkit [67449] by
-
- 8 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
