Context Navigation

← Previous Period
Next Period →

Timeline

Sep 16, 2010:

11:20 PM Changeset in webkit [67695] by tkent@chromium.org

3 edits in trunk/WebCore

2010-09-16 takano takumi <takano1@asia.apple.com>

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Fixed a regression in SVG test introduced by my previous change.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EWritingMode):
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):

10:26 PM Changeset in webkit [67694] by dumi@chromium.org

3 edits in trunk/WebKit/chromium

2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67693.
http://trac.webkit.org/changeset/67693
https://bugs.webkit.org/show_bug.cgi?id=45946

"Need to pick up a chromium change first" (Requested by dumi
on #webkit).

public/WebHTTPBody.h:
src/WebHTTPBody.cpp: (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendFileRange):

9:56 PM Changeset in webkit [67693] by dumi@chromium.org

3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

public/WebHTTPBody.h:
src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

9:30 PM Changeset in webkit [67692] by kinuko@chromium.org

4 edits in trunk/WebKitTools

2010-09-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408

This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

9:05 PM Changeset in webkit [67691] by sullivan@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/8395558>
https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it

Reviewed by Darin Adler.

WebView/WebHTMLView.mm:

(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.

6:53 PM Changeset in webkit [67690] by kbr@google.com

8 edits in trunk

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::create):
src/GraphicsContext3DInternal.h:

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM): (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
platform/graphics/GraphicsContext3D.h:
platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

6:34 PM Changeset in webkit [67689] by tonikitoo@webkit.org

4 edits in trunk/WebKitTools

2010-09-16 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage):
QtTestBrowser/mainwindow.h:

6:33 PM Changeset in webkit [67688] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.

This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.

QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip):
QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode):

6:32 PM Changeset in webkit [67687] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

We usually separate methods whose body are larger the a few lines from the class definition.

QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):

6:32 PM Changeset in webkit [67686] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make initializeView method of LauncherWindow private.

No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.

QtTestBrowser/launcherwindow.h:

QtTestBrowser/launcherwindow.h:

6:31 PM Changeset in webkit [67685] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make the getter 'page' method of MainWindow const.

QtTestBrowser/mainwindow.cpp: (MainWindow::page):
QtTestBrowser/mainwindow.h:

6:31 PM Changeset in webkit [67684] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Remove useless parameter from MainWindow class' constructor.

The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.

QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
QtTestBrowser/mainwindow.h:

6:18 PM Changeset in webkit [67683] by oliver@apple.com

5 edits in trunk/JavaScriptCore

2010-09-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash due to timer triggered GC on one heap while another heap is active
https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/8318446>

The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.

runtime/Collector.cpp: (JSC::Heap::allocate): (JSC::Heap::reset): (JSC::Heap::collectAllGarbage):

Add assertions to ensure we have the correct identifierTable active
while collecting.

runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger):

Temporarily make the expected IdentifierTable active

wtf/WTFThreadData.h: (JSC::IdentifierTable::remove):

Make it possible to see when IdentifierTable::remove has succeeded

wtf/text/StringImpl.cpp: (WTF::StringImpl::~StringImpl):

CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.

6:04 PM Changeset in webkit [67682] by Simon Fraser

35 edits in trunk

2010-09-16 Simon Fraser <Simon Fraser>

Reviewed by James Robinson.

In layerTreeAsText output, avoid printing properties which have their default values
https://bugs.webkit.org/show_bug.cgi?id=45931

Don't dump properties that have their default values to simplify output.

platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):

5:55 PM Changeset in webkit [67681] by johnnyg@google.com

96 edits
98 adds
4 deletes in trunk/LayoutTests

2010-09-16 John Gregg <johnnyg@google.com>

Unreviewed, chromium rebaselines.

[chromium] Rebaseline multicol tests
https://bugs.webkit.org/show_bug.cgi?id=45936

platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
platform/chromium-linux/fast/multicol/client-rects-expected.png:
platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
platform/chromium-linux/fast/multicol/column-rules-expected.png:
platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
platform/chromium-linux/fast/multicol/float-multicol-expected.png:
platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
platform/chromium-linux/fast/multicol/nested-columns-expected.png:
platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
platform/chromium-linux/fast/multicol/single-line-expected.checksum:
platform/chromium-linux/fast/multicol/single-line-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
platform/chromium-win/fast/multicol/client-rects-expected.checksum:
platform/chromium-win/fast/multicol/client-rects-expected.png:
platform/chromium-win/fast/multicol/client-rects-expected.txt:
platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
platform/chromium-win/fast/multicol/column-rules-expected.checksum:
platform/chromium-win/fast/multicol/column-rules-expected.png:
platform/chromium-win/fast/multicol/column-rules-expected.txt:
platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
platform/chromium-win/fast/multicol/float-avoidance-expected.png:
platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
platform/chromium-win/fast/multicol/float-multicol-expected.png:
platform/chromium-win/fast/multicol/float-multicol-expected.txt:
platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
platform/chromium-win/fast/multicol/float-paginate-expected.txt:
platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
platform/chromium-win/fast/multicol/nested-columns-expected.png:
platform/chromium-win/fast/multicol/nested-columns-expected.txt:
platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
platform/chromium-win/fast/multicol/single-line-expected.checksum:
platform/chromium-win/fast/multicol/single-line-expected.png:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:

5:35 PM Changeset in webkit [67680] by bweinstein@apple.com

3 edits in trunk/LayoutTests

Update Windows-specific results to getComputedStyle tests after r67667.

Rubber-stamped by Jon Honeycutt.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

4:34 PM Changeset in webkit [67679] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Remove unused variable

GraphicsContextPlatformPrivate::redirect wasn't used for anything.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

4:15 PM Changeset in webkit [67678] by tony@chromium.org

3 edits
1 add
8 deletes in trunk/LayoutTests

2010-09-16 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

convert fast/events/5056619.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=45907

fast/events/5056619.html:
platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
platform/chromium-linux/fast/events/5056619-expected.png: Removed.
platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
platform/chromium-win/fast/events/5056619-expected.png: Removed.
platform/chromium-win/fast/events/5056619-expected.txt: Removed.
platform/chromium/test_expectations.txt:
platform/mac/fast/events/5056619-expected.checksum: Removed.
platform/mac/fast/events/5056619-expected.png: Removed.
platform/mac/fast/events/5056619-expected.txt: Removed.

4:03 PM Changeset in webkit [67677] by kbr@google.com

4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Add needed entry points to WebGraphicsContext3D for compositor
https://bugs.webkit.org/show_bug.cgi?id=45921

public/WebGraphicsContext3D.h:
src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
src/WebGraphicsContext3DDefaultImpl.h:

3:45 PM Changeset in webkit [67676] by tony@chromium.org

10 edits in trunk

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

platform/chromium/test_expectations.txt:

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

public/WebDataSource.h:
src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost): (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
src/WebDataSourceImpl.h:

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad):
DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad):
DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource):

3:35 PM Changeset in webkit [67675] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
https://bugs.webkit.org/show_bug.cgi?id=45923

QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().

platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):

3:30 PM Changeset in webkit [67674] by barraclough@apple.com

3 edits in trunk/SunSpider

https://bugs.webkit.org/show_bug.cgi?id=45924

Reviewed by Mark Rowe.

Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.

Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').

resources/sunspider-standalone-driver.js:
sunspider:

3:18 PM Changeset in webkit [67673] by hyatt@apple.com

2 edits in trunk/WebCore

Fix for regression from my previous check-in. Make sure not to move the LayoutRepainter line
below the setHeight(0) call. This meant it snagged the wrong rectangle and we ended up repainting
the world.

Reviewed by Eric Seidel.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

2:58 PM Changeset in webkit [67672] by zmo@google.com

2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing WebGL tests from platform/chromium/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45905

Remove passing tests; also, put webgl tests in one place.

platform/chromium/test_expectations.txt:

2:53 PM Changeset in webkit [67671] by hyatt@apple.com

1 edit in trunk/WebCore/rendering/ColumnInfo.h

Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.

2:51 PM Changeset in webkit [67670] by eric@webkit.org

2 edits
1 add in trunk/LayoutTests

2010-09-16 Eric Seidel <eric@webkit.org>

Unreviewed. Just changing the path to the PNG file.

fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
https://bugs.webkit.org/show_bug.cgi?id=45919

Fixing the underlying issue in a separate bug. For now
give this test its own png so to unblock the commit-queue.

fast/css/font-face-svg-decoding-error.html:
fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.

2:44 PM Changeset in webkit [67669] by commit-queue@webkit.org

1 edit
3 adds in trunk/WebKitTools

2010-09-16 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add script to synchronize WebKit and Khronos WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42336

Scripts/update-webgl-conformance-tests: Added.
Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.

2:39 PM Changeset in webkit [67668] by Martin Robinson

11 edits
38 adds in trunk/LayoutTests

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Update baselines for GTK+ and unskip a test which is passing.

platform/gtk/Skipped: Update baselines for GTK+.
platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
platform/gtk/fast/multicol/client-rects-expected.txt: Added.
platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
platform/gtk/fast/multicol/column-rules-expected.txt: Added.
platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
platform/gtk/fast/multicol/nested-columns-expected.txt:
platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/gtk/svg/css/shadow-changes-expected.txt: Added.
platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.

2:37 PM Changeset in webkit [67667] by hyatt@apple.com

17 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Patch by takano takumi <takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.

Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.

WebCore:

Test: fast/text/international/block-flow-parser-test.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/CSSValueKeywords.in:
css/SVGCSSValueKeywords.in:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):

rendering/style/RenderStyleConstants.h:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/text/international/block-flow-parser-test-expected.txt: Added.
fast/text/international/block-flow-parser-test.html: Added.
svg/css/getComputedStyle-basic-expected.txt:

2:04 PM Changeset in webkit [67666] by weinig@apple.com

15 edits in trunk

Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
https://bugs.webkit.org/show_bug.cgi?id=44785

Reviewed by Anders Carlsson.

WebKit2:

Shared/CoreIPCSupport/WebContextMessageKinds.h:
UIProcess/API/C/WKContext.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

UIProcess/WebContext.h:
UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):

UIProcess/WebContextInjectedBundleClient.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postSynchronousMessage):

WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

MiniBrowser/mac/AppDelegate.m:

(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didCreatePage):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

1:55 PM Changeset in webkit [67665] by kbr@google.com

2 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Roll forward Chromium DEPS to r59706
https://bugs.webkit.org/show_bug.cgi?id=45916

DEPS:

1:51 PM Changeset in webkit [67664] by Martin Robinson

10 edits in trunk

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
might this allow code to be shared between Cairo ports it prevents a
full data copy when the image is not resized and makes the implementation
of dissolveDragImageToFraction more straight-forward.

This feature is covered by manual-tests/drag-image.html.

page/gtk/DragControllerGtk.cpp: (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag image a little smaller.
platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): Reimplemented to reflect new drag image type. (WebCore::deleteDragImage): Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Filled the stub of this function. (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

To support full alpha in the drag icon, changed the drag icon to be a
GtkWindow with an RGBA colormap. Added logic to support painting the drag
image to this window during the expose event.

WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowExposeEventCallback): Added. (WebKit::DragClient::DragClient): Initialize the new drag icon window. (WebKit::DragClient::~DragClient): Disconnect the expose event signal. (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and if necessary, set its colormap. (WebKit::DragClient::dragIconWindowExposeEvent): Added.
WebCoreSupport/DragClientGtk.h: Added new member and method declarations.

1:42 PM Changeset in webkit [67663] by jianli@chromium.org

2 edits in branches/chromium/517

Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
https://bugs.webkit.org/show_bug.cgi?id=45412

BUG=45412
TEST=none

Reviewed by Darin Adler.

WebCore:

This is caused by not including the final null character into the count
that is provided to fgets.

This is covered by the existing test: send-form-data-with-sliced-file.html.

platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

LayoutTests:

Remove the test that is now passing on Linux for chromium.

platform/chromium/test_expectations.txt:

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3389014

1:31 PM Changeset in webkit [67662] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-09-16 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=45885

Avoid creation of an additional window for screenshot to prevent overlapping with original window.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot):

1:26 PM Changeset in webkit [67661] by jianli@chromium.org

2 edits in branches/chromium/517

Merge 67646 - BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909

BUG=55910
TEST=none

Reviewed by David Levin.

WebCore:

fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

fast/files/apply-blob-url-to-img.html:

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3449009

1:20 PM Changeset in webkit [67660] by hyatt@apple.com

74 edits
42 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.

Reviewed by Darin Adler.

WebCore:

This patch adds support for column breaking at layout time rather than at paint time. New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.

The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns. Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.

Many new tests added in fast/multicol and new results added for existing fast/multicol tests.

rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):

rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):

rendering/RenderBox.h:
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

rendering/RenderFlexibleBox.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):

rendering/RenderTable.h:
rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):

rendering/RenderView.h:

(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):

LayoutTests:

Add many new multicol layout tests that demonstrate new pagination features.

fast/multicol/border-padding-pagination.html: Added.
fast/multicol/client-rects-expected.checksum:
fast/multicol/client-rects-expected.png:
fast/multicol/client-rects-expected.txt:
fast/multicol/column-break-with-balancing.html: Added.
fast/multicol/float-paginate-complex.html: Added.
fast/multicol/float-paginate.html:
fast/multicol/float-truncation.html:
fast/multicol/margin-collapse.html: Added.
fast/multicol/max-height-columns-block.html: Added.
fast/multicol/positioned-split.html: Added.
fast/multicol/shadow-breaking.html: Added.
fast/multicol/single-line-expected.checksum:
fast/multicol/single-line-expected.png:
fast/multicol/table-margin-collapse.html: Added.
fast/multicol/table-vertical-align.html: Added.
fast/multicol/unsplittable-inline-block.html: Added.
platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
platform/mac/fast/multicol/column-count-with-rules-expected.txt:
platform/mac/fast/multicol/column-rules-expected.checksum:
platform/mac/fast/multicol/column-rules-expected.png:
platform/mac/fast/multicol/column-rules-expected.txt:
platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
platform/mac/fast/multicol/column-rules-stacking-expected.png:
platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
platform/mac/fast/multicol/float-avoidance-expected.checksum:
platform/mac/fast/multicol/float-avoidance-expected.png:
platform/mac/fast/multicol/float-avoidance-expected.txt:
platform/mac/fast/multicol/float-multicol-expected.checksum:
platform/mac/fast/multicol/float-multicol-expected.png:
platform/mac/fast/multicol/float-multicol-expected.txt:
platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
platform/mac/fast/multicol/float-paginate-expected.txt:
platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
platform/mac/fast/multicol/layers-in-multicol-expected.png:
platform/mac/fast/multicol/layers-in-multicol-expected.txt:
platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
platform/mac/fast/multicol/margin-collapse-expected.png: Added.
platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
platform/mac/fast/multicol/nested-columns-expected.checksum:
platform/mac/fast/multicol/nested-columns-expected.png:
platform/mac/fast/multicol/nested-columns-expected.txt:
platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
platform/mac/fast/multicol/positioned-split-expected.png: Added.
platform/mac/fast/multicol/positioned-split-expected.txt: Added.
platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.

1:18 PM Changeset in webkit [67659] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
https://bugs.webkit.org/show_bug.cgi?id=45737

Test: fast/frames/frame-limit.html

html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):

1:15 PM Changeset in webkit [67658] by andersca@apple.com

2 edits in trunk/WebKitTools

Fix clang++ build.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.

1:05 PM Changeset in webkit [67657] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-16 Thomas Zander <t.zander@nokia.com>

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=45878

[Qt] Fixed incorrect Symbian scoping.

The missing install functionality is only true for mmp based systems.

WebCore.pro: limit functionality to mmp systems.

1:00 PM Changeset in webkit [67656] by andersca@apple.com

2 edits in trunk/WebCore

Fix clang build.

page/animation/AnimationBase.h:

Fix struct/class mismatch.

12:48 PM Changeset in webkit [67655] by Darin Adler

4 edits in trunk/WebKit

Fix build.

WebKit/efl:

ewk/ewk_view.cpp:

(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.

WebKit/qt:

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.

12:44 PM Changeset in webkit [67654] by levin@chromium.org

1 edit in branches/chromium/517/WebCore/page/chromium/FrameChromium.cpp

Merge 67645 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/3422008

12:40 PM Changeset in webkit [67653] by Darin Adler

21 edits in trunk