⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 17, 2010:

11:16 PM Changeset in webkit [67776] by weinig@apple.com
  • 10 edits in trunk

Need a way to load data (as plain text) in a WKPage
<rdar://problem/8424239>

Reviewed by Jon Honeycutt.

WebCore:

  • WebCore.exp.in:

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadHTMLString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadHTMLString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
10:34 PM Changeset in webkit [67775] by weinig@apple.com
  • 60 edits in trunk/WebKit2

Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.

Rubber-stamped by Anders Carlsson.

  • Platform/Module.h:
  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/WebString.h:

(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):

  • Shared/WebURL.h:

(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):

  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):

  • UIProcess/PageClient.h:
  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::injectedBundlePath):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveTitle):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginHostConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::start):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::showCorrectionPanel):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):

  • WebProcess/WebProcess.h:
9:09 PM Changeset in webkit [67774] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.

Reviewed by Sam Weinig.

Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate. An image on a line did this, but a block-level image did not.

Added fast/multicol/image-inside-nested-blocks-with-border.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):

LayoutTests:

  • fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/image-inside-nested-blocks-with-border.html: Added.
8:38 PM Changeset in webkit [67773] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests from expectations.

  • platform/chromium/drt_expectations.txt: Removed tests that are now

consistently passing on Chromium Windows DRT.

7:59 PM Changeset in webkit [67772] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Removed a helper function,

added direct calls to frame->pageZoomFactor().

7:13 PM Changeset in webkit [67771] by hyatt@apple.com
  • 17 edits
    2 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.

Reviewed by Simon Fraser.

WebCore:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):

  • page/FrameView.h:
  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcHeight):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):

  • rendering/RenderView.h:

(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):

WebKit/mac:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):

LayoutTests:

Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.

  • printing/page-break-always-for-overflow-expected.txt: Removed.
  • printing/page-break-always-for-overflow.html: Removed.
7:09 PM Changeset in webkit [67770] by mitz@apple.com
  • 11 edits in trunk

Canvas sizing ignores intrinsic size
​https://bugs.webkit.org/show_bug.cgi?id=46024

Reviewed by Simon Fraser.

WebCore:

Updated fast/replaced/table-percent-height.html

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.

  • rendering/RenderReplaced.h:

(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.

  • rendering/RenderVideo.h:

LayoutTests:

  • fast/replaced/table-percent-height-expected.txt: Updated.
  • fast/replaced/table-percent-height.html: Changed to expect canvas to maintain

its intrinsic ratio.

6:06 PM Changeset in webkit [67769] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-09-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Imprecise tracking of variable capture leads to overly pessimistic creation of activations
​https://bugs.webkit.org/show_bug.cgi?id=46020

The old logic for track free and captured variables would cause us
to decide we needed an activation in every function along the scope
chain between a variable capture and its declaration. We now track
captured variables precisely which requires a bit of additional work

The most substantial change is that the parsing routine needs to
be passed the list of function parameters when reparsing a function
as when reparsing we don't parse the function declaration itself only
its body.

  • JavaScriptCore.exp:
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::needsFullActivation):

We need to distinguish between use of a feature that requires
an activation and eval so we now get this additional flag.

(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::getCapturedVariables):

We can't simply return the list of "capturedVariables" now as
is insufficiently precise, so we compute them instead.

(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):

  • parser/JSParser.h:
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode):

Pass function parameters (if available) to the parser.

6:01 PM Changeset in webkit [67768] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):

6:00 PM Changeset in webkit [67767] by Darin Adler
  • 2 edits in trunk/WebCore

Build fix for platforms that compile Touch.

  • dom/Touch.cpp:

(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.

5:57 PM Changeset in webkit [67766] by abarth@webkit.org
  • 1 edit
    5 deletes in trunk/LayoutTests

2010-09-17 Adam Barth <​abarth@webkit.org>

Remove Leopard specific expected results because these now match Snow
Leopard.

​https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
5:40 PM Changeset in webkit [67765] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

Add IsFloatingPoint and IsArithmetic type traits
​https://bugs.webkit.org/show_bug.cgi?id=46018

Reviewed by Sam Weinig.

  • wtf/TypeTraits.h:
  • wtf/TypeTraits.cpp:
5:38 PM Changeset in webkit [67764] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67692.
​http://trac.webkit.org/changeset/67692
​https://bugs.webkit.org/show_bug.cgi?id=46011

broke layout test dashboard (Requested by johnny_g on
#webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:34 PM Changeset in webkit [67763] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix Windows and Qt builds.

  • Shared/qt/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

5:32 PM Changeset in webkit [67762] by Darin Adler
  • 34 edits
    4 adds in trunk

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • webkit/webkitwebview.cpp: (webkit_web_view_get_zoom_level): (webkit_web_view_apply_zoom_level): (webkit_web_view_set_full_content_zoom): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView.cpp: (WebView::setZoomMultiplier): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_set): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

Moved zoom level back from FrameView to Frame.
I had forgotten that FrameView's lifetime is much shorter than
Frame's, and until that is fixed it's best to leave this on Frame.

  • WebCore.exp.in: Updated.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • dom/Document.cpp: (WebCore::Document::nodesFromRect): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY): (WebCore::pageZoomFactor):
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent):
  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
  • html/ImageDocument.cpp: (WebCore::pageZoomFactor): (WebCore::ImageDocument::scale): (WebCore::ImageDocument::imageFitsInWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/DragController.cpp: (WebCore::elementUnderMouse):
  • rendering/RenderView.cpp: (WebCore::RenderView::zoomFactor):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): Get zoom factor from Frame rather than FrameView.
  • page/Frame.cpp: (WebCore::parentPageZoomFactor): Moved back here from FrameView. (WebCore::parentTextZoomFactor): Ditto. (WebCore::Frame::Frame): Ditto. (WebCore::Frame::setPageZoomFactor): Ditto. (WebCore::Frame::setTextZoomFactor): Ditto. (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
  • page/Frame.h: Moved functions and data for zooming back here from FrameView.
  • page/FrameView.cpp: (WebCore::FrameView::FrameView):
  • page/FrameView.h: Removed code from here.

2010-09-17 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::textZoomFactor): (WebKit::WebPage::setTextZoomFactor): (WebKit::WebPage::pageZoomFactor): (WebKit::WebPage::setPageZoomFactor): (WebKit::WebPage::setPageAndTextZoomFactors): Call functions on Frame instead of FrameView.
5:23 PM Changeset in webkit [67761] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/7897425>
​https://bugs.webkit.org/show_bug.cgi?id=45601

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowResizerRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowResizerRect):

  • WebProcess/WebPage/WebPage.h:

Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.

5:20 PM Changeset in webkit [67760] by weinig@apple.com
  • 16 edits
    9 adds in trunk/WebKit2

Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/8350189>
​https://bugs.webkit.org/show_bug.cgi?id=45998

Reviewed by Anders Carlsson.

  • Shared/APIObject.h:

Add new type.

  • Shared/WebCertificateInfo.h: Added.

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.

  • Shared/mac/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::peerCertificates):

  • Shared/mac/PlatformCertificateInfo.mm: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):

  • Shared/qt/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKCertificateInfo.cpp: Added.

(WKCertificateInfoGetTypeID):

  • UIProcess/API/C/WKCertificateInfo.h: Added.

Add wrapper for WebCertificateInfo.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetCertificateInfo):

  • UIProcess/API/C/WKFrame.h:

Add getter for a WKCertificateInfo.

  • UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
  • UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.

(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::setCertificateInfo):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::certificateInfo):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Pipe the certificate info through to the WebFrameProxy on
commit.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:09 PM Changeset in webkit [67759] by tony@chromium.org
  • 34 edits in trunk/LayoutTests

2010-09-17 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] 16 more chromium linux baselines (scrollbars change)
​https://bugs.webkit.org/show_bug.cgi?id=46009

  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [67758] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.

No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.

  • WebCore.exp.in:
  • page/DOMTimer.cpp: Removed old comments.
  • page/DOMTimer.h: Removed old comments.
  • page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
  • page/Settings.h:

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
4:12 PM Changeset in webkit [67757] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
​https://bugs.webkit.org/show_bug.cgi?id=46006

  • DEPS:
3:50 PM Changeset in webkit [67756] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

3:49 PM Changeset in webkit [67755] by mrowe@apple.com
  • 1 copy in tags/Safari-534.8

New tag.

3:48 PM Changeset in webkit [67754] by andersca@apple.com
  • 3 edits in trunk/WebKit2

CoreIPC argument coder improvements
​https://bugs.webkit.org/show_bug.cgi?id=45999

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Add explicit specialization for a vector of bytes.

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.

(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.

3:43 PM Changeset in webkit [67753] by tony@chromium.org
  • 24 edits in trunk/LayoutTests

2010-09-17 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] rebaseline tests that are only scrollbar differences on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46000

  • platform/chromium-linux/css1/basic/containment-expected.checksum:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [67752] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add mesa as DumpRenderTree dependency
​https://bugs.webkit.org/show_bug.cgi?id=46001

  • WebKit.gyp:
3:23 PM Changeset in webkit [67751] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Split webcore_platform off webcore_remaining

Further reduce webcore_remaining size by moving platform/ code in its
own static libary.
​https://bugs.webkit.org/show_bug.cgi?id=45915

  • WebCore.gyp/WebCore.gyp:
2:59 PM Changeset in webkit [67750] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
​https://bugs.webkit.org/show_bug.cgi?id=37540

2:57 PM Changeset in webkit [67749] by mpcomplete@chromium.org
  • 12 edits in trunk

2010-09-13 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
​https://bugs.webkit.org/show_bug.cgi?id=45721

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
  • loader/FrameLoaderClient.h:
2:50 PM Changeset in webkit [67748] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-17 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8440903> WK2: REGRESSION (r66156): Web sites using
AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
​https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
2:47 PM Changeset in webkit [67747] by commit-queue@webkit.org
  • 6 edits
    2 adds
    7 deletes in trunk/LayoutTests

2010-09-17 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

http/tests/navigation/post-goback1.html should not be a pixel test
​https://bugs.webkit.org/show_bug.cgi?id=45834

Convert post-goback1.html to be a simpler dumpAsText test. It can use
the form-target.pl that was added r67466 with some small modifications.

To be extra safe, clear the back forward list for all the tests that
were converted to use dumpAsText.

  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/post-goback1-expected.txt: Added.
  • http/tests/navigation/post-goback1.html:
  • http/tests/navigation/resources/form-target.pl:
  • http/tests/navigation/resources/go-back.html: Added.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.
2:29 PM Changeset in webkit [67746] by andersca@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r66711): Plug-in replacement text is never shown
​https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/8446766>

Reviewed by Sam Weinig.

Don't return when the plug-in has replacement text.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):

2:27 PM Changeset in webkit [67745] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Eric Carlson <​eric.carlson@apple.com>

Rubber-stamped by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=45983

  • platform/win/Skipped: Skip media-can-play-mpeg4-video.html.
1:42 PM Changeset in webkit [67744] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Unskip the canvas philip suite
​https://bugs.webkit.org/show_bug.cgi?id=45991

  • platform/chromium/test_expectations.txt:
1:27 PM Changeset in webkit [67743] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed, tweaked, and landed by Anders Carlsson.

Patch by Sam Weinig <​sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
1:17 PM Changeset in webkit [67742] by jianli@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67734 - createBlobURL with no argument causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.

BUG=45880
TEST=create-blob-url-crash.html
TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3444009

1:11 PM Changeset in webkit [67741] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Make WebNumbers immutable matching CF.

Reviewed by Anders Carlsson.

  • Shared/WebNumber.h:

(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):

  • UIProcess/API/C/WKNumber.cpp:

(WKUInt64GetValue):

  • UIProcess/API/C/WKNumber.h:
1:04 PM Changeset in webkit [67740] by levin@chromium.org
  • 2 edits in trunk/WebKit/chromium

Remove unimplemented destructor declaration to fix Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=45987

Patch by Eric Uhrhane <​ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.

  • src/AsyncFileWriterChromium.h:
1:01 PM Changeset in webkit [67739] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit

<​http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project

Reviewed by Joseph Pecoraro.

  • WebKit.xcodeproj/project.pbxproj: Added missing

WebArchiveInternal.h header file to the project. It has been
missing since r31281!

12:35 PM Changeset in webkit [67738] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Add bool wrapper for WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=45985

Reviewed by John Sullivan.

  • Shared/APIObject.h:
  • Shared/WebNumber.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNumber.cpp:

(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):

  • UIProcess/API/C/WKNumber.h:
12:25 PM Changeset in webkit [67737] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.

  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:07 PM Changeset in webkit [67736] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed, build fix. Add files missed in r67704.

  • CMakeLists.txt:
12:00 PM Changeset in webkit [67735] by Simon Fraser
  • 11 edits in trunk

2010-09-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
​https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame(). (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
  • platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::setRootChildLayer): (WebCore::WKCACFLayerRenderer::destroyRenderer): (WebCore::WKCACFLayerRenderer::resize):
  • platform/graphics/win/WKCACFLayerRenderer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer. (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows, always say yes.

2010-09-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
​https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • WebView.cpp: (WebView::sizeChanged): Moved code that handles the WM_SIZE message into this method. Use it to resize the layer renderer. (WebView::WebViewWndProc): Call sizeChanged(). (WebView::updateRootLayerContents): No need to call setScrollFrame() any more. (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
  • WebView.h:
11:59 AM Changeset in webkit [67734] by jianli@chromium.org
  • 4 edits
    2 adds in trunk

createBlobURL with no argument causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.
11:48 AM Changeset in webkit [67733] by tonyg@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 67627 - 2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.

BUG=55598
TBR=​tonyg@chromium.org
Review URL: ​http://codereview.chromium.org/3394006

11:39 AM Changeset in webkit [67732] by tonyg@chromium.org
  • 8 edits
    2 copies in branches/chromium/517

Merge 67292 - 2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of ​http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):

BUG=56034
TBR=​mihaip@chromium.org
Review URL: ​http://codereview.chromium.org/3400014

11:35 AM Changeset in webkit [67731] by cmarrin@apple.com
  • 7 edits in trunk

2010-09-17 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
​https://bugs.webkit.org/show_bug.cgi?id=45911

11:34 AM Changeset in webkit [67730] by bweinstein@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the bug number in the ChangeLog.

11:32 AM Changeset in webkit [67729] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <​http://webkit.org/b/44199>.

Rubber-stamped by Adam Roben.

  • platform/win/Skipped:
11:04 AM Changeset in webkit [67728] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERTION FAILED: m_loadEventDelayCount
​https://bugs.webkit.org/show_bug.cgi?id=45790

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
11:01 AM Changeset in webkit [67727] by senorblanco@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] GPU-accelerated canvas should work in test_shell.
​https://bugs.webkit.org/show_bug.cgi?id=45968

In order for the shaders in GPU-accelerated canvas to work in both the
GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
passes them to the Mesa backend unmodified), the precision specifiers
in the fragment shader have to be wrapped in #if GL_ES.

Soon to be covered by many layout tests.

  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
11:00 AM Changeset in webkit [67726] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-09-17 William Siegrist <​wsiegrist@apple.com>

Replaces branches option with ChangeFilter since branches is now deprecated.

10:47 AM Changeset in webkit [67725] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] Listbox rendering is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=45941

Only apply the shadow tiling optimization to a layer if the GraphicsContext
has a shadow.

This is covered by manual-tests/select-element-type-select.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization first check to see if the context has a shadow at all.
10:42 AM Changeset in webkit [67724] by Martin Robinson
  • 13 edits in trunk

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
​https://bugs.webkit.org/show_bug.cgi?id=45917

Added support to PlatformRefPtr for handling HashTableDeletedValue.

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue. (WTF::PlatformRefPtr::isHashTableDeletedValue): Added.

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
​https://bugs.webkit.org/show_bug.cgi?id=45917

Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
as this type is reference-counted.

No new tests as this should not introduce any functionality changes.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes. (WebCore::FontCache::createFontPlatformData): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::operator=): Ditto. (WebCore::FontPlatformData::~FontPlatformData): Ditto. (WebCore::FontPlatformData::isFixedPitch): Ditto. (WebCore::FontPlatformData::operator==): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::scaledFont): Ditto. (WebCore::FontPlatformData::hash): Ditto. (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill): Ditto.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
  • platform/graphics/cairo/OwnPtrCairo.h: Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations. (WTF::refPlatformPtr): Ditto. (WTF::derefPlatformPtr): Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): Ditto.
10:40 AM Changeset in webkit [67723] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land new Windows results for fast/forms/file-input-disabled.html

This corresponds to the changes made in r64712.

Rubber-stamped by John Sullivan.

  • platform/win/fast/forms/file-input-disabled-expected.txt:
10:20 AM Changeset in webkit [67722] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

Style bot complains about cairo forward declaration naming
​https://bugs.webkit.org/show_bug.cgi?id=45867

Exclude Cairo forward declarations from indentifiers with underscores checks.

  • Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
10:16 AM Changeset in webkit [67721] by pfeldman@chromium.org
  • 14 edits in trunk

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=45114

  • English.lproj/localizedStrings.js:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeById):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.css: (.pane > .body .placard + .info):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.formatLocalized):

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=45114

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
10:02 AM Changeset in webkit [67720] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/WebKitSite

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Adding a timeline screenshot for blocking and defer scripts
​https://bugs.webkit.org/show_bug.cgi?id=45933

  • blog-files/timeline-blocking-script.png: Added.
  • blog-files/timeline-defer-script.png: Added.
9:56 AM Changeset in webkit [67719] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/517

Merge 67281
Review URL: ​http://codereview.chromium.org/3419009

9:47 AM Changeset in webkit [67718] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/517

Merge 67509
Review URL: ​http://codereview.chromium.org/3452011

9:38 AM Changeset in webkit [67717] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67240
Review URL: ​http://codereview.chromium.org/3464001

9:36 AM Changeset in webkit [67716] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-17 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
Now history reload can only navigate the page in self frame, no matter
what target frame is defined in <base> and no new window can be created.
​https://bugs.webkit.org/show_bug.cgi?id=45369

Test: fast/events/popup-blocked-from-history-reload.html

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::wasUserGesture): Move the m_wasUserGesture to base class ScheduledNavigation. Then all asynchronous navigation situations can restore the correct gesture state during the real navigation process. (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleHistoryNavigation):

2010-09-17 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
​https://bugs.webkit.org/show_bug.cgi?id=45369

  • fast/events/popup-blocked-from-history-reload-expected.txt: Added.
  • fast/events/popup-blocked-from-history-reload.html: Added.
9:30 AM Changeset in webkit [67715] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Zhenyao Mo <​zmo@google.com>

Unreviewed.

Add failing WebGL tests in drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
9:27 AM Changeset in webkit [67714] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Clip the update region of an ImageLayerChromium to actual size
of the image bitmap to prevent uninitialized memory access when uploading
the dirty region to the texture.
​https://bugs.webkit.org/show_bug.cgi?id=45937

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
9:25 AM Changeset in webkit [67713] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67236

TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/3419008

9:20 AM Changeset in webkit [67712] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67356

TBR=​abarth@webkit.org
Review URL: ​http://codereview.chromium.org/3402012

9:15 AM Changeset in webkit [67711] by inferno@chromium.org
  • 8 edits in branches/chromium/517

Merge 67357

Review URL: ​http://codereview.chromium.org/3403012

9:13 AM Changeset in webkit [67710] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Remove extraneous RenderObject traversal.
​https://bugs.webkit.org/show_bug.cgi?id=45821

This code always exits in the first iteration of the loop,
because in the context of this call, node->renderer()->node() != 0
is always true.

No behavior change, covered by existing tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop. (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
9:02 AM Changeset in webkit [67709] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-09-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
8:52 AM Changeset in webkit [67708] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land new Windows results for html5lib/runner.html

This corresponds to the changes made in r67233 and r67356.

Rubber-stamped by Anders Carlsson.

  • platform/win/html5lib/runner-expected.txt:
8:38 AM Changeset in webkit [67707] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file

  • platform/win/Skipped: Added two tests which fail due to

already-known limitations of Windows DRT.

8:11 AM Changeset in webkit [67706] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-17 William Siegrist <​wsiegrist@apple.com>

Remove centering on results directory listing.

8:00 AM Changeset in webkit [67705] by apavlov@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2010-09-17 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix. Add files missed in the previous commit.

  • GNUmakefile.am:
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
7:37 AM Changeset in webkit [67704] by apavlov@chromium.org
  • 20 edits in trunk

2010-09-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Provide source-based properties for style declarations to CSSParser clients

This change:

  • Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets, even with the resource tracking turned off.
  • Adds to CSSParser a capability of source-related style declaration data extraction:
    • Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
    • Start/end source offsets for CSS properties, relative to the declaration start.
    • CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
  • Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData(). ​https://bugs.webkit.org/show_bug.cgi?id=44949

WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::node):
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
  • css/CSSParser.h: (WebCore::CSSParser::resetPropertyMarks):
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
  • inspector/Inspector.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::reset): (WebCore::InspectorCSSStore::styleSheetText): (WebCore::InspectorCSSStore::resourceStyleSheetText): (WebCore::InspectorCSSStore::inlineStyleSheetText): (WebCore::InspectorCSSStore::getStyleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges): (WebCore::InspectorCSSStore::getParentStyleSheet): (WebCore::InspectorCSSStore::inlineStyleElement):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::resourceContentForURL):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData): (WebCore::InspectorDOMAgent::buildObjectForStyle):
  • inspector/InspectorDOMAgent.h:

LayoutTests:

  • inspector/resources/styles-source-offsets.css: (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles-source-offsets-expected.txt:
  • inspector/styles-source-offsets.html:
6:36 AM Changeset in webkit [67703] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show node description in inspector highlight
​https://bugs.webkit.org/show_bug.cgi?id=20930

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
  • inspector/InspectorController.h:
6:06 AM Changeset in webkit [67702] by alex
  • 3 edits in trunk/LayoutTests

2010-09-17 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, GTK+ rebaselines.

  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
4:09 AM Changeset in webkit [67701] by satish@chromium.org
  • 7 edits
    3 copies in trunk/LayoutTests/platform

2010-09-17 Satish Sampath <​satish@chromium.org>

Unreviewed, updated chromium baselines and disabled a failing test.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium/test_expectations.txt
1:15 AM Changeset in webkit [67700] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp

Merge 67651 - 2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
​https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/3380012

1:13 AM Changeset in webkit [67699] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/front-end/ResourcesPanel.js

Merge 67629 - 2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
​https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/3442005

1:10 AM Changeset in webkit [67698] by pfeldman@chromium.org
  • 4 edits in branches/chromium/517

Merge 67623 - 2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.

TBR=​yurys@chromium.org
Review URL: ​http://codereview.chromium.org/3389017

1:07 AM Changeset in webkit [67697] by pfeldman@chromium.org
  • 2 edits in branches/chromium/517/WebCore/inspector/front-end

Merge 67601 - 2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/3429016

12:20 AM Changeset in webkit [67696] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

WebKit should use system wide spell checking preference when application specific one isn't set.
​https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/8416041>

Patch by Jia Pu <​jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(+[WebView initialize]): Use system wide autocorrection and text substitution preferences

when the application level preferences are not set.

Sep 16, 2010:

11:20 PM Changeset in webkit [67695] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 takano takumi <​takano1@asia.apple.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Fixed a regression in SVG test introduced by my previous change.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EWritingMode):
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
10:26 PM Changeset in webkit [67694] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67693.
​http://trac.webkit.org/changeset/67693
​https://bugs.webkit.org/show_bug.cgi?id=45946

"Need to pick up a chromium change first" (Requested by dumi
on #webkit).

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp: (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendFileRange):
9:56 PM Changeset in webkit [67693] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

9:30 PM Changeset in webkit [67692] by kinuko@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
​https://bugs.webkit.org/show_bug.cgi?id=45408

This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:05 PM Changeset in webkit [67691] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/8395558>
​https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.

6:53 PM Changeset in webkit [67690] by kbr@google.com
  • 8 edits in trunk

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
​https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
​https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM): (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
6:34 PM Changeset in webkit [67689] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage):
  • QtTestBrowser/mainwindow.h:
6:33 PM Changeset in webkit [67688] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.

This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode):
6:32 PM Changeset in webkit [67687] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

We usually separate methods whose body are larger the a few lines from the class definition.

  • QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):
6:32 PM Changeset in webkit [67686] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make initializeView method of LauncherWindow private.

No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.

  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/launcherwindow.h:
6:31 PM Changeset in webkit [67685] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make the getter 'page' method of MainWindow const.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::page):
  • QtTestBrowser/mainwindow.h:
6:31 PM Changeset in webkit [67684] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Remove useless parameter from MainWindow class' constructor.

The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
  • QtTestBrowser/mainwindow.h:
6:18 PM Changeset in webkit [67683] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-09-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash due to timer triggered GC on one heap while another heap is active
​https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/8318446>

The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.

  • runtime/Collector.cpp: (JSC::Heap::allocate): (JSC::Heap::reset): (JSC::Heap::collectAllGarbage):

Add assertions to ensure we have the correct identifierTable active
while collecting.

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger):

Temporarily make the expected IdentifierTable active

  • wtf/WTFThreadData.h: (JSC::IdentifierTable::remove):

Make it possible to see when IdentifierTable::remove has succeeded

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::~StringImpl):

CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.

6:04 PM Changeset in webkit [67682] by Simon Fraser
  • 35 edits in trunk

2010-09-16 Simon Fraser <Simon Fraser>

Reviewed by James Robinson.

In layerTreeAsText output, avoid printing properties which have their default values
​https://bugs.webkit.org/show_bug.cgi?id=45931

Don't dump properties that have their default values to simplify output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
5:55 PM Changeset in webkit [67681] by johnnyg@google.com
  • 96 edits
    98 adds
    4 deletes in trunk/LayoutTests

2010-09-16 John Gregg <​johnnyg@google.com>

Unreviewed, chromium rebaselines.

[chromium] Rebaseline multicol tests
​https://bugs.webkit.org/show_bug.cgi?id=45936

  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/single-line-expected.checksum:
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
  • platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-win/fast/multicol/client-rects-expected.png:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.checksum:
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
5:35 PM Changeset in webkit [67680] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update Windows-specific results to getComputedStyle tests after r67667.

Rubber-stamped by Jon Honeycutt.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:34 PM Changeset in webkit [67679] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Remove unused variable

GraphicsContextPlatformPrivate::redirect wasn't used for anything.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
4:15 PM Changeset in webkit [67678] by tony@chromium.org
  • 3 edits
    1 add
    8 deletes in trunk/LayoutTests

2010-09-16 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

convert fast/events/5056619.html to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=45907

  • fast/events/5056619.html:
  • platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-linux/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-win/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/events/5056619-expected.checksum: Removed.
  • platform/mac/fast/events/5056619-expected.png: Removed.
  • platform/mac/fast/events/5056619-expected.txt: Removed.
4:03 PM Changeset in webkit [67677] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Add needed entry points to WebGraphicsContext3D for compositor
​https://bugs.webkit.org/show_bug.cgi?id=45921

  • public/WebGraphicsContext3D.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
  • src/WebGraphicsContext3DDefaultImpl.h:
3:45 PM Changeset in webkit [67676] by tony@chromium.org
  • 10 edits in trunk

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • platform/chromium/test_expectations.txt:

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • public/WebDataSource.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost): (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
  • src/WebDataSourceImpl.h:

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource):
3:35 PM Changeset in webkit [67675] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
​https://bugs.webkit.org/show_bug.cgi?id=45923

QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
3:30 PM Changeset in webkit [67674] by barraclough@apple.com
  • 3 edits in trunk/SunSpider

​https://bugs.webkit.org/show_bug.cgi?id=45924

Reviewed by Mark Rowe.

Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.

Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').

  • resources/sunspider-standalone-driver.js:
  • sunspider:
3:18 PM Changeset in webkit [67673] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for regression from my previous check-in. Make sure not to move the LayoutRepainter line
below the setHeight(0) call. This meant it snagged the wrong rectangle and we ended up repainting
the world.

Reviewed by Eric Seidel.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

2:58 PM Changeset in webkit [67672] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed.

Remove passing WebGL tests from platform/chromium/test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=45905

Remove passing tests; also, put webgl tests in one place.

  • platform/chromium/test_expectations.txt:
2:53 PM Changeset in webkit [67671] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/ColumnInfo.h

Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.

2:51 PM Changeset in webkit [67670] by eric@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Eric Seidel <​eric@webkit.org>

Unreviewed. Just changing the path to the PNG file.

fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
​https://bugs.webkit.org/show_bug.cgi?id=45919

Fixing the underlying issue in a separate bug. For now
give this test its own png so to unblock the commit-queue.

  • fast/css/font-face-svg-decoding-error.html:
  • fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.
2:44 PM Changeset in webkit [67669] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-09-16 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add script to synchronize WebKit and Khronos WebGL tests
​https://bugs.webkit.org/show_bug.cgi?id=42336

  • Scripts/update-webgl-conformance-tests: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2:39 PM Changeset in webkit [67668] by Martin Robinson
  • 11 edits
    38 adds in trunk/LayoutTests

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Update baselines for GTK+ and unskip a test which is passing.

  • platform/gtk/Skipped: Update baselines for GTK+.
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/gtk/fast/multicol/client-rects-expected.txt: Added.
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/gtk/svg/css/shadow-changes-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
  • platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.
2:37 PM Changeset in webkit [67667] by hyatt@apple.com
  • 17 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Patch by takano takumi <​takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.

Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.

WebCore:

Test: fast/text/international/block-flow-parser-test.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/text/international/block-flow-parser-test-expected.txt: Added.
  • fast/text/international/block-flow-parser-test.html: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
2:04 PM Changeset in webkit [67666] by weinig@apple.com
  • 15 edits in trunk

Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
​https://bugs.webkit.org/show_bug.cgi?id=44785

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

  • MiniBrowser/mac/AppDelegate.m:

(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didCreatePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

1:55 PM Changeset in webkit [67665] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Roll forward Chromium DEPS to r59706
​https://bugs.webkit.org/show_bug.cgi?id=45916

  • DEPS:
1:51 PM Changeset in webkit [67664] by Martin Robinson
  • 10 edits in trunk

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

  • wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
might this allow code to be shared between Cairo ports it prevents a
full data copy when the image is not resized and makes the implementation
of dissolveDragImageToFraction more straight-forward.

This feature is covered by manual-tests/drag-image.html.

  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag image a little smaller.
  • platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
  • platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): Reimplemented to reflect new drag image type. (WebCore::deleteDragImage): Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Filled the stub of this function. (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
  • platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

To support full alpha in the drag icon, changed the drag icon to be a
GtkWindow with an RGBA colormap. Added logic to support painting the drag
image to this window during the expose event.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowExposeEventCallback): Added. (WebKit::DragClient::DragClient): Initialize the new drag icon window. (WebKit::DragClient::~DragClient): Disconnect the expose event signal. (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and if necessary, set its colormap. (WebKit::DragClient::dragIconWindowExposeEvent): Added.
  • WebCoreSupport/DragClientGtk.h: Added new member and method declarations.
1:42 PM Changeset in webkit [67663] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=45412

BUG=45412
TEST=none

Reviewed by Darin Adler.

WebCore:

This is caused by not including the final null character into the count
that is provided to fgets.

This is covered by the existing test: send-form-data-with-sliced-file.html.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

LayoutTests:

Remove the test that is now passing on Linux for chromium.

  • platform/chromium/test_expectations.txt:

TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3389014

1:31 PM Changeset in webkit [67662] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Leonid Ebril <​leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
​https://bugs.webkit.org/show_bug.cgi?id=45885

Avoid creation of an additional window for screenshot to prevent overlapping with original window.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot):
1:26 PM Changeset in webkit [67661] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67646 - BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
​https://bugs.webkit.org/show_bug.cgi?id=45909

BUG=55910
TEST=none

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:

TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3449009

1:20 PM Changeset in webkit [67660] by hyatt@apple.com
  • 74 edits
    42 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.

Reviewed by Darin Adler.

WebCore:

This patch adds support for column breaking at layout time rather than at paint time. New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.

The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns. Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.

Many new tests added in fast/multicol and new results added for existing fast/multicol tests.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):

  • rendering/RenderView.h:

(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):

LayoutTests:

Add many new multicol layout tests that demonstrate new pagination features.

  • fast/multicol/border-padding-pagination.html: Added.
  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/column-break-with-balancing.html: Added.
  • fast/multicol/float-paginate-complex.html: Added.
  • fast/multicol/float-paginate.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/margin-collapse.html: Added.
  • fast/multicol/max-height-columns-block.html: Added.
  • fast/multicol/positioned-split.html: Added.
  • fast/multicol/shadow-breaking.html: Added.
  • fast/multicol/single-line-expected.checksum:
  • fast/multicol/single-line-expected.png:
  • fast/multicol/table-margin-collapse.html: Added.
  • fast/multicol/table-vertical-align.html: Added.
  • fast/multicol/unsplittable-inline-block.html: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.checksum:
  • platform/mac/fast/multicol/column-rules-expected.png:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.checksum:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/float-paginate-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum:
  • platform/mac/fast/multicol/nested-columns-expected.png:
  • platform/mac/fast/multicol/nested-columns-expected.txt:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/mac/fast/multicol/positioned-split-expected.png: Added.
  • platform/mac/fast/multicol/positioned-split-expected.txt: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.
1:18 PM Changeset in webkit [67659] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
​https://bugs.webkit.org/show_bug.cgi?id=45737

Test: fast/frames/frame-limit.html

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
1:15 PM Changeset in webkit [67658] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix clang++ build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.

1:05 PM Changeset in webkit [67657] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Thomas Zander <​t.zander@nokia.com>

Reviewed by Andreas Kling.

​https://bugs.webkit.org/show_bug.cgi?id=45878

[Qt] Fixed incorrect Symbian scoping.

The missing install functionality is only true for mmp based systems.

  • WebCore.pro: limit functionality to mmp systems.
1:00 PM Changeset in webkit [67656] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang build.

  • page/animation/AnimationBase.h:

Fix struct/class mismatch.

12:48 PM Changeset in webkit [67655] by Darin Adler
  • 4 edits in trunk/WebKit

Fix build.

WebKit/efl:

  • ewk/ewk_view.cpp:

(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.

WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.

12:44 PM Changeset in webkit [67654] by levin@chromium.org
  • 1 edit in branches/chromium/517/WebCore/page/chromium/FrameChromium.cpp

Merge 67645 - 2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
​https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):

TBR=​dcheng@chromium.org
Review URL: ​http://codereview.chromium.org/3422008

12:40 PM Changeset in webkit [67653] by Darin Adler
  • 21 edits in trunk

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute): Use isImageButton.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Use isPasswordField.
  • src/WebSearchableFormData.cpp: (WebCore::IsInDefaultState): Use isCheckbox and isRadioButton. (WebCore::HasSuitableTextElement): Use isFileUpload and isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Use isPasswordField. (WebFrame::elementIsPassword): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField. (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload. (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton. (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use isCheckbox and isRadioButton.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Use isTextField.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
  • editing/SelectionController.cpp: (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
  • html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
  • page/DragController.cpp: (WebCore::asFileInput): Use isFileUpload.
  • page/EventHandler.cpp: (WebCore::isSubmitImage): Use isImageButton.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
12:33 PM Changeset in webkit [67652] by Darin Adler
  • 1 edit
    3 adds in trunk/LayoutTests

Mac results for recently-added test.

  • platform/mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.txt: Added.
12:31 PM Changeset in webkit [67651] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
​https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):
12:31 PM Changeset in webkit [67650] by kbr@google.com
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Expose separate GraphicsContext3DInternal.h
​https://bugs.webkit.org/show_bug.cgi?id=45914

  • WebKit.gyp:
  • src/GraphicsContext3D.cpp:
  • src/GraphicsContext3DInternal.h: Added.
12:26 PM Changeset in webkit [67649] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Add WebGraphicsContext3D accessor to WebView
​https://bugs.webkit.org/show_bug.cgi?id=45913

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
12:17 PM Changeset in webkit [67648] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
​https://bugs.webkit.org/show_bug.cgi?id=45892

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
12:13 PM Changeset in webkit [67647] by loislo@chromium.org
  • 16 edits in trunk

2010-09-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move resourceTracking flag under control of BackendSettings.

Four Inspector API methods about resourceTracking flag were removed.
Actual state of the flag is transfered as the response of setResourceTracking request.
Initial state of the flag on the frontend side is obtained from settings.backend.

​https://bugs.webkit.org/show_bug.cgi?id=45887

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getBackendSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::setResourceTracking):
  • inspector/InspectorController.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize.populateBackendSettings): (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js:

WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

LayoutTests:

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/styles-source-offsets.html:
12:09 PM Changeset in webkit [67646] by jianli@chromium.org
  • 4 edits in trunk

BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
​https://bugs.webkit.org/show_bug.cgi?id=45909

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:
12:05 PM Changeset in webkit [67645] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
​https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
11:55 AM Changeset in webkit [67644] by levin@chromium.org
  • 1 edit
    1 copy in branches/chromium/517/WebCore

Merge 67641 - 2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
​https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):

TBR=​tony@chromium.org
Review URL: ​http://codereview.chromium.org/3452007

11:36 AM Changeset in webkit [67643] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed, TAG fix for two webgl tests in Linux/Win.

  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [67642] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
​https://bugs.webkit.org/show_bug.cgi?id=41510

  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
  • platform/mac/fast/loader/user-stylesheet-fast-path.html:

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
​https://bugs.webkit.org/show_bug.cgi?id=41510

This prevents usage of nil value, which would cause an uncaught exception.

  • WebView/WebPreferences.mm: (-[WebPreferences setUserStyleSheetLocation:]):
11:06 AM Changeset in webkit [67641] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
​https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):
10:59 AM Changeset in webkit [67640] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed, test TAG fix.

  • platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.
10:52 AM Changeset in webkit [67639] by mitz@apple.com
  • 5 edits in trunk/WebKit

Reverted the previous change because r67628 has been reverted.

WebKit:

  • English.lproj/Localizable.strings:

WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
10:39 AM Changeset in webkit [67638] by mitz@apple.com
  • 5 edits in trunk/WebKit

WebKit: Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):

10:37 AM Changeset in webkit [67637] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-16 Balazs Kelemen <​kbalazs@webkit.org>

Unreviewed trivial typo fix.

Remove old debug helper code inside |#if 0| from ConnectionQt.cpp

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
10:33 AM Changeset in webkit [67636] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Unskip some tests that are now passing after libxml fixes in r66336.

  • platform/gtk/Skipped: Unskip passing tests.
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
10:32 AM Changeset in webkit [67635] by commit-queue@webkit.org
  • 22 edits
    2 deletes in trunk

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • media/context-menu-actions-expected.txt: Removed.
  • media/context-menu-actions.html: Removed.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:
  • platform/brew/LocalizedStringsBrew.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/haiku/LocalizedStringsHaiku.cpp:
  • platform/wx/LocalizedStringsWx.cpp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
  • rendering/HitTestResult.h:

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):
10:21 AM Changeset in webkit [67634] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Fraser.

CSS: Fix crash in getTimingFunctionValue()
​https://bugs.webkit.org/show_bug.cgi?id=45896

Use a RefPtr to avoid deleting the TimingFunction prematurely.

This is covered by existing tests, e.g transitions/inherit-other-props.html
but will only actually crash on picky platforms (or in valgrind.)

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getTimingFunctionValue):
10:15 AM Changeset in webkit [67633] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Turn on WebGL layout tests for Chromium win/linux
​https://bugs.webkit.org/show_bug.cgi?id=45859

  • platform/chromium/test_expectations.txt: Re-enabling WebGL tests.
10:04 AM Changeset in webkit [67632] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 John Gregg <​johnnyg@google.com>

Unreviewed; chromium test expectations.

editing/selection/context-menu-on-text.html fails on chromium
​https://bugs.webkit.org/show_bug.cgi?id=45898

  • platform/chromium/test_expectations.txt:
9:28 AM Changeset in webkit [67631] by enrica@apple.com
  • 8 edits in trunk/WebKit2

Pasteboard doesn't work in WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the

new editing commands.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.

  • UIProcess/WebPageProxy.cpp: Added all the proxy methods.

(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.

  • WebProcess/WebPage/WebPage.cpp: Added all the stub methods.

(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.

  • WebProcess/WebPage/WebPage.h:
9:27 AM Changeset in webkit [67630] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Balazs Kelemen <​kbalazs@webkit.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
9:24 AM Changeset in webkit [67629] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
​https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
9:21 AM Changeset in webkit [67628] by Philippe Normand
  • 22 edits
    2 adds in trunk

2010-09-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:12 AM Changeset in webkit [67627] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
9:06 AM Changeset in webkit [67626] by Philippe Normand
  • 8 edits
    2 adds in trunk

2010-09-14 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):

WebKit/gtk:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

New private WebView API to retrieve the context-menu widget. This
is used by DRT only.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_context_menu):

LayoutTests:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

New test checking the return value of eventSender.contextClick()
on a non-editable element. Skipped on qt and win.

  • editing/selection/context-menu-on-text-expected.txt: Added.
  • editing/selection/context-menu-on-text.html: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
8:58 AM Changeset in webkit [67625] by vangelis@chromium.org
  • 4 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] ImageLayerChromium needs to keep a ref to the Image it uses
so that it never tries to access an already destroyed Image.
​https://bugs.webkit.org/show_bug.cgi?id=45869

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/ImageLayerChromium.h:
8:57 AM Changeset in webkit [67624] by Patrick Gansterer
  • 1 edit
    1 add in trunk/WebCore

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add platform-specific Image methods
​https://bugs.webkit.org/show_bug.cgi?id=28272

  • platform/graphics/wince/ImageWinCE.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::FrameData::clear): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::drawPattern): (WebCore::BitmapImage::checkForSolidColor):
8:37 AM Changeset in webkit [67623] by yurys@chromium.org
  • 6 edits in trunk

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.
8:33 AM Changeset in webkit [67622] by satish@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Satish Sampath <​satish@chromium.org>

Unreviewed, fixing a build break with VS 2008.

Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
​https://bugs.webkit.org/show_bug.cgi?id=45893

  • fileapi/FileWriter.h:
8:30 AM Changeset in webkit [67621] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] XOverlay API changes break the build
​https://bugs.webkit.org/show_bug.cgi?id=45810

Cope with the GStreamer XOverlay API change for the upcoming
0.10.31 version.
No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
8:24 AM Changeset in webkit [67620] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/wince

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add missing FrameNetworkingContextWinCE::blockedError
​https://bugs.webkit.org/show_bug.cgi?id=45680

  • WebCoreSupport/FrameNetworkingContextWinCE.cpp: (WebKit::FrameNetworkingContextWinCE::blockedError):
  • WebCoreSupport/FrameNetworkingContextWinCE.h:
8:17 AM Changeset in webkit [67619] by andreas.kling@nokia.com
  • 11 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Fix debug build

Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.

  • history/PageCache.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/DocumentLoader.cpp:
  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconLoader.cpp:
  • storage/AbstractDatabase.cpp:
  • storage/Database.cpp:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseTracker.cpp:
8:05 AM Changeset in webkit [67618] by ap@apple.com
  • 4 edits
    2 adds in trunk

2010-09-16 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

  • fast/dom/Range/select-node-different-document-expected.txt: Added.
  • fast/dom/Range/select-node-different-document.html: Added.

2010-09-16 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

Test: fast/dom/Range/select-node-different-document.html

There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
Firefox.

  • dom/Range.cpp: (WebCore::Range::setDocument): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents):
  • dom/Range.h:
7:44 AM Changeset in webkit [67617] by satish@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2010-09-16 Satish Sampath <​satish@chromium.org>

Unreviewed, build fix after checking in the wrong location.

Moving a test expectation which should have been under the chromium platform.

  • platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/fast/images/gif-large-checkerboard-expected.txt.
7:08 AM Changeset in webkit [67616] by satish@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-09-16 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add chromium baselines for a recently added layout test.
​https://bugs.webkit.org/show_bug.cgi?id=45886

  • fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.png: Added.
6:56 AM Changeset in webkit [67615] by caseq@chromium.org
  • 6 edits in trunk/WebCore

2010-09-16 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support to export HAR to file from Resources panel (conditional on Preferences)
Added support for HARLog (a higher-level aggregate than HAREntry)
​https://bugs.webkit.org/show_bug.cgi?id=45663

6:45 AM Changeset in webkit [67614] by commit-queue@webkit.org
  • 49 edits in trunk

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • configure.ac:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExceptionCode.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
  • dom/ScriptExecutionContext.h:
  • fileapi/AsyncFileWriter.h:
  • fileapi/FileEntry.cpp:
  • fileapi/FileEntry.h:
  • fileapi/FileEntry.idl:
  • fileapi/FileError.h:
  • fileapi/FileError.idl:
  • fileapi/FileException.h:
  • fileapi/FileException.idl:
  • fileapi/FileStreamProxy.cpp:
  • fileapi/FileStreamProxy.h:
  • fileapi/FileThread.cpp:
  • fileapi/FileThread.h:
  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h:
  • fileapi/FileWriter.idl:
  • fileapi/FileWriterCallback.h:
  • fileapi/FileWriterCallback.idl:
  • fileapi/FileWriterClient.h:
  • page/DOMWindow.idl:
  • platform/AsyncFileStream.h:
  • platform/FileStream.cpp:
  • platform/FileStream.h:
  • platform/FileStreamClient.h:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • src/AsyncFileWriterChromium.h:
  • src/AsyncFileWriterChromium.cpp:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Scripts/build-webkit:
6:19 AM Changeset in webkit [67613] by satish@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Rename an image file to all lower case matching how it is used in the layout test. The original patch and layout test is at ​https://bugs.webkit.org/show_bug.cgi?id=45322

6:15 AM Changeset in webkit [67612] by robert@webkit.org
  • 13 edits in trunk

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • platform/qt/Skipped:

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::populateVisitedLinks):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpHistoryCallbacks): (DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isGlobalHistoryTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpHistoryCallbacks): (LayoutTestController::removeAllVisitedLinks):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:03 AM Changeset in webkit [67611] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-16 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.

This is necessary because sources! is processed before sources/. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.

Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp

​https://bugs.webkit.org/show_bug.cgi?id=45823

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
5:51 AM Changeset in webkit [67610] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
​https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::finish):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-09-16 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
​https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
5:47 AM Changeset in webkit [67609] by alex
  • 5 edits in trunk

2010-09-16 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
  • platform/gtk/gtk2drawing.c: (moz_gtk_scrollbar_thumb_paint): (moz_gtk_combo_box_paint):

2010-09-16 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
5:38 AM Changeset in webkit [67608] by diegohcg@webkit.org
  • 8 edits in trunk

2010-09-16 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
​https://bugs.webkit.org/show_bug.cgi?id=42293

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::commitLoad):

2010-09-16 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
​https://bugs.webkit.org/show_bug.cgi?id=42293

  • Api/qwebframe.cpp: (QWebFrame::childFrames): (QWebFramePrivate::kit):
  • Api/qwebpage.cpp: (QWebPage::currentFrame):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::contentsSizeChanged):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::chooseFile):
  • WebCoreSupport/FrameLoaderClientQt.h:
5:07 AM Changeset in webkit [67607] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix for EFL

[EFL] REGRESSION(67567) FontCacheCairo was removed
​https://bugs.webkit.org/show_bug.cgi?id=45858

  • CMakeListsEfl.txt:
4:47 AM Changeset in webkit [67606] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=37117

Add platform-independent JPEG/PNG image encoders that
work with big endian RGBA source data.

There's no layout test because this patch does't make
any port start using the encoders.

  • platform/image-encoders/JPEGImageEncoder.cpp: Added.
  • platform/image-encoders/JPEGImageEncoder.h: Added.
  • platform/image-encoders/PNGImageEncoder.cpp: Added.
  • platform/image-encoders/PNGImageEncoder.h: Added.
4:27 AM Changeset in webkit [67605] by jorlow@chromium.org
  • 11 edits in trunk

2010-09-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
​https://bugs.webkit.org/show_bug.cgi?id=45815

Existing tests provide coverage. Use the indexedDBPath parameter that's
already on the group settings object. Pass this parameter into the backend
which will use it rather than a hard coded tmp directory location. If
nothing is specified, assume it should be an in-memory temporary database.
(This is useful for bringup and Chromium's incognito mode.)

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2010-09-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
​https://bugs.webkit.org/show_bug.cgi?id=45815

Need to add the extra .open() parameter to make this all work.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
4:16 AM Changeset in webkit [67604] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

Add a test for GIF down sampling.

GIF image down sampling can miss some lines
​https://bugs.webkit.org/show_bug.cgi?id=45322

  • fast/images/gif-large-checkerboard.html: Added.
  • fast/images/resources/large-gif-checkerboard.GIF: Added.

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

Fix the bug that GIF image down sampling can miss some lines.
​https://bugs.webkit.org/show_bug.cgi?id=45322

Test: fast/images/gif-large-checkerboard.html

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
4:13 AM Changeset in webkit [67603] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Jeremy Orlow <​jorlow@chromium.org>

Speculative build fix.

  • src/IDBIndexBackendProxy.cpp:
3:50 AM Changeset in webkit [67602] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-16 Philippe Normand <​pnormand@igalia.com>

Reviewed by Andreas Kling.

[GStreamer] un-needed header includes in MediaPlayerPrivate
​https://bugs.webkit.org/show_bug.cgi?id=45877

Include only the headers we need.
No new tests, #includes cleanup only.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3:41 AM Changeset in webkit [67601] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):
3:23 AM Changeset in webkit [67600] by jorlow@chromium.org
  • 34 edits
    4 adds in trunk

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

  • storage/indexeddb/index-basics-expected.txt: Added.
  • storage/indexeddb/index-basics.html: Added.
  • storage/indexeddb/index-cursor-expected.txt: Added.
  • storage/indexeddb/index-cursor.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/script-tests/objectstore-basics.js: Removed.

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

Add the rest of the index related API for IndexedDB. This
includes cursor suport. A bunch of code was also refactored
since it is shared between indexes and objectStores.

Tests: storage/indexeddb/index-basics.html

storage/indexeddb/index-cursor.html
+ additions to others.

  • storage/IDBAny.cpp: (WebCore::IDBAny::set):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::value):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::loadCurrentRow): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
  • storage/IDBIndex.h: (WebCore::IDBIndex::storeName):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::storeName): (WebCore::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::objectStore):
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::leftCursorWhereFragment): (WebCore::IDBKey::rightCursorWhereFragment):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator): (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::timerFired):

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::storeName): (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBKey.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::value):
  • src/IDBCursorBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::storeName): (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
  • src/IDBIndexBackendProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::value):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::storeName): (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
2:07 AM Changeset in webkit [67599] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-09-15 Commit Queue <​commit-queue@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

Note: See TracTimeline for information about the timeline view.