⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 19, 2010:

11:16 PM Changeset in webkit [67839] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Publish button should actually publish the review comments
​https://bugs.webkit.org/show_bug.cgi?id=46074

Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.

  • code-review.js:
10:29 PM Changeset in webkit [67838] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/API/C/WKPage.h:
10:23 PM Changeset in webkit [67837] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix Qt build.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::doTextFieldCommandFromEvent):

10:20 PM Changeset in webkit [67836] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Add WebKit2 equivalent of the WebFormDelegate's doCommandBySelector
<rdar://problem/8377088>
​https://bugs.webkit.org/show_bug.cgi?id=46073

Reviewed by Anders Carlsson.

Add bundle client to match the behavior of:

  • (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::getActionTypeForKeyEvent):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

9:26 PM Changeset in webkit [67835] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move reviewtool to action=review
​https://bugs.webkit.org/show_bug.cgi?id=46071

This patch removes the old Review Patch screen and moves the new
reviewtool from Pretty Diff to Review Patch.

  • attachment.cgi:
  • code-review.js:
9:06 PM Changeset in webkit [67834] by weinig@apple.com
  • 10 edits in trunk

WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
​https://bugs.webkit.org/show_bug.cgi?id=46060

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

8:05 PM Changeset in webkit [67833] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <​abarth@webkit.org>

Review tool UI tweak. This patch lengthens the status bubbles so all
the bubble fit (even when they have numbers inside).

  • PrettyPatch/PrettyPatch.rb:
7:41 PM Changeset in webkit [67832] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
​https://bugs.webkit.org/show_bug.cgi?id=46046

Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.

  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
    • Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
7:27 PM Changeset in webkit [67831] by abarth@webkit.org
  • 12 edits in trunk

2010-09-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
​http://trac.webkit.org/changeset/67749
​https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

2010-09-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
​http://trac.webkit.org/changeset/67749
​https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • public/WebFrameClient.h:
  • public/WebScriptController.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
7:00 PM Changeset in webkit [67830] by Dimitri Glazkov
  • 1 edit
    16 moves in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Move win-xp-specific baselines to their proper places.

  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.
6:59 PM Changeset in webkit [67829] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 2.

6:52 PM Changeset in webkit [67828] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-19 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
​https://bugs.webkit.org/show_bug.cgi?id=46064

r62958 added incorrect expectations for this test. Chromium DRT actually
gets this test right if we let it use the base expectations file. Mark
the test as failing with test_shell only.

  • platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
6:43 PM Changeset in webkit [67827] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

6:35 PM Changeset in webkit [67826] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix - implicit double-to-int conversion invalid on 32-bit.

  • runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

6:23 PM Changeset in webkit [67825] by barraclough@apple.com
  • 12 edits
    3 adds in trunk

Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.

Reviewed by Oliver Hunt.

These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.

JavaScriptCore:

Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32). This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).

(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSValue.cpp:

(JSC::toInt32):

  • runtime/JSValue.h:

(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):

WebCore:

Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.

Test: fast/js/toInt32UInt32.html

  • bindings/js/JSDOMBinding.h:

(WebCore::finiteInt32Value):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSVGPODListCustom.h:

(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):

  • bindings/js/JSSVGPathSegListCustom.cpp:

(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):

LayoutTests:

Add test cases for ToInt32 / ToUInt32 functionality.

  • fast/js/script-tests/toInt32UInt32.js: Added.
  • fast/js/toInt32UInt32-expected.txt: Added.
  • fast/js/toInt32UInt32.html: Added.
4:45 PM Changeset in webkit [67824] by Dimitri Glazkov
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Fix up expectation sadness I introduced in ​http://trac.webkit.org/changeset/67822, because no sadness is allowed.

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
3:46 PM Changeset in webkit [67823] by Dimitri Glazkov
  • 3 edits
    1 add in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Create one more text baseline for win-vista.

  • platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
  • platform/chromium/test_expectations.txt: Removed an errant line break.
3:31 PM Changeset in webkit [67822] by Dimitri Glazkov
  • 6 edits
    20 adds
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Update win-vista baselines for Chromium to make a few more tests pass.
​https://bugs.webkit.org/show_bug.cgi?id=46056

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.
3:09 PM Changeset in webkit [67821] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <​abarth@webkit.org>

Turns out these still fail.

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [67820] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <​abarth@webkit.org>

These tests now pass. Go team.

  • platform/chromium/test_expectations.txt:
2:14 PM Changeset in webkit [67819] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] clipBoundingRect() should return rect relevant to current layer
​https://bugs.webkit.org/show_bug.cgi?id=46059

r65791 inadvertently changed clipBoundingRect() to always use the GC painter
without checking the TransparencyLayer stack first.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
2:10 PM Changeset in webkit [67818] by weinig@apple.com
  • 3 edits in trunk/WebCore

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
​https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
2:08 PM Changeset in webkit [67817] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-19 Adam Barth <​abarth@webkit.org>

Also update mac-leopard and mac-tiger.
See ​https://bugs.webkit.org/show_bug.cgi?id=46042

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
12:54 PM Changeset in webkit [67816] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-19 Patrick Gansterer <​paroga@paroga.com>

Unreviewed.

[WINCE] Buildfix for Gradient after r67801.

  • platform/graphics/Gradient.h:
  • platform/graphics/wince/GradientWinCE.cpp: (WebCore::Gradient::getStops):
11:25 AM Changeset in webkit [67815] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67813.

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
​https://bugs.webkit.org/show_bug.cgi?id=46054

  • DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2
10:47 AM Changeset in webkit [67814] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67802.

WebKit2: Improve/unify the PageLoadClient interfaces.
​https://bugs.webkit.org/show_bug.cgi?id=46043

  • UIProcess/API/qt/ClientImpl.h:
10:40 AM Changeset in webkit [67813] by weinig@apple.com
  • 19 edits
    4 adds
    2 deletes in trunk

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
​https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.

WebKit2:

  • Shared/APIObject.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.

(WKBundleRangeHandleGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.

(WebKit::InjectedBundleRangeHandle::type):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebFrame.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
10:37 AM Changeset in webkit [67812] by mitz@apple.com
  • 2 edits in trunk/BugsSite

Fixed a typo.

Reviewed by Anders Carlsson.

  • code-review.js: Changed the label of the OK button from Ok to OK.
6:31 AM Changeset in webkit [67811] by tkent@chromium.org
  • 5 edits in trunk

2010-09-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
​https://bugs.webkit.org/show_bug.cgi?id=46035

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.

2010-09-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
​https://bugs.webkit.org/show_bug.cgi?id=46035

We're going to stop exposing HTMLInputElemnt::InputType. So, add
isFoo() functions in order to remove WebInputElement::InputType.

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isTextField): (WebKit::WebInputElement::isText): (WebKit::WebInputElement::isPasswordField): (WebKit::WebInputElement::isImageButton):
6:30 AM Changeset in webkit [67810] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Kent Tamura <​tkent@chromium.org>

Unreviewed. Fix WebGL test regressions by r67809.

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
5:55 AM Changeset in webkit [67809] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2010-09-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
​https://bugs.webkit.org/show_bug.cgi?id=45945

  • platform/chromium/drt_expectations.txt: Remove link-opens-new-window.html, which is fixed by this revision.

2010-09-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
​https://bugs.webkit.org/show_bug.cgi?id=45945

Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
  • DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences):
  • DumpRenderTree/chromium/WebPreferences.cpp: Added.
  • DumpRenderTree/chromium/WebPreferences.h: Added.

Sep 18, 2010:

8:12 PM Changeset in webkit [67808] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-09-18 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Path: Remove unused member variable
​https://bugs.webkit.org/show_bug.cgi?id=46048

Path::m_lastMoveToIndex is not used for anything, so remove it.

  • platform/graphics/Path.h:
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo):
8:01 PM Changeset in webkit [67807] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Use AtomicString insted of String in XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=45990

Create AtomicString as early as possible.
This can avoid unnecessary memcpy of String content.

  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs):
6:21 PM Changeset in webkit [67806] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-18 Prasad Tammana <​prasadt@chromium.org>

Reviewed by David Levin.

update-webkit --chromium spitting out a spurious error
​https://bugs.webkit.org/show_bug.cgi?id=45868

  • Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
6:05 PM Changeset in webkit [67805] by abarth@webkit.org
  • 7 edits in trunk

2010-09-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Nate Chapin.

[Chromium] fast/dom/dataset-gc.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=45426

  • platform/chromium/test_expectations.txt:

2010-09-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Nate Chapin.

[Chromium] fast/dom/dataset-gc.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=45426

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8):
  • dom/DOMStringMap.h:
  • dom/DatasetDOMStringMap.h: (WebCore::DatasetDOMStringMap::element):
5:52 PM Changeset in webkit [67804] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
​https://bugs.webkit.org/show_bug.cgi?id=46045

Avoid calling std::stable_sort for 2-stop gradients that are already in order.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary):
5:46 PM Changeset in webkit [67803] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-18 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Fix a typo in key code name
​https://bugs.webkit.org/show_bug.cgi?id=46003

AVK_CLR is the right Brew MP key code name for VK_BACK.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::windowsKeyCodeForKeyEvent):
5:30 PM Changeset in webkit [67802] by weinig@apple.com
  • 17 edits in trunk

WebKit2: Improve/unify the PageLoadClient interfaces.
​https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

  • Ensure that all the PageLoadClient functions (that are load related) have bundle API equivalents (this meant adding didFirstLayoutForFrame and didFirstVisuallyNonEmptyLayoutForFrame to the BundlePageLoadClient).
  • Add a userData out parameters to all the now paired BundlePageLoadClient functions, and a matching userData parameter to the PageLoadClient ones.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishDocumentLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::didBecomeUnresponsive):
(WebKit::WebLoaderClient::didBecomeResponsive):
(WebKit::WebLoaderClient::processDidExit):
(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):

WebKitTools: Improve/unify the PageLoadClient interfaces
​https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m:

(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestController.h:
5:23 PM Changeset in webkit [67801] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Gradient: Pre-reserve space for 2 color stops
​https://bugs.webkit.org/show_bug.cgi?id=46044

Most gradients have only 2 color stops, pre-reserve space for these in m_stops
to avoid growing the vector dynamically in the common case.

  • platform/graphics/Gradient.h:
4:54 PM Changeset in webkit [67800] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Adam Barth <​abarth@webkit.org>

Also update the snow-leopard result.

  • platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
4:48 PM Changeset in webkit [67799] by Dimitri Glazkov
  • 4 edits
    4 deletes in trunk

2010-09-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r67792.
​http://trac.webkit.org/changeset/67792
​https://bugs.webkit.org/show_bug.cgi?id=45976

Broke over a hundred SVG tests.

  • canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneDest.html: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneSource.html: Removed.

2010-09-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r67792.
​http://trac.webkit.org/changeset/67792
​https://bugs.webkit.org/show_bug.cgi?id=45976

Broke over a hundred SVG tests.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawImageBuffer):
  • platform/graphics/GraphicsContext.h:
4:28 PM Changeset in webkit [67798] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

file-url-mimetypes-2.html fails on my Snow Leopard box
​https://bugs.webkit.org/show_bug.cgi?id=46042

This line of this test seems to depend on something besides WebKit. It
fails on my Snow Leopard box because it reports text/plain instead of
postscript. This is blocking me from running a commit-cluster machine
on my box.

  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-2.html:
4:02 PM Changeset in webkit [67797] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Simon Fraser.

webkitAnimationEnd event doesn't fire when skipping over final iteration
​https://bugs.webkit.org/show_bug.cgi?id=46010

Add a test with a short enough animation interval (0.001s) that we
appear to always skip the second iteration.

  • animations/animation-end-event-short-iterations-expected.txt: Added.
  • animations/animation-end-event-short-iterations.html: Added.

2010-09-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Simon Fraser.

webkitAnimationEnd event doesn't fire when skipping over final iteration
​https://bugs.webkit.org/show_bug.cgi?id=46010

It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
that the animation is ended while we're in the looping state, if the
animation timer never fires during an iteration. That then fails the
assert in AnimationBase::updateStateMachine (we don't expect
AnimationStateInputEndTimerFired while in the looping state). Jump the
state to AnimationStateEnding, which is more accurate.

Test: animations/animation-end-event-short-iterations.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
4:02 PM Changeset in webkit [67796] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

First step in fixing Windows build.

Removed incorrect symbol. The build will probably still fail,
but the failure will tell us what symbol to add.

3:52 PM Changeset in webkit [67795] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fix, fix use of wrong case in name.

3:48 PM Changeset in webkit [67794] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-18 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
​https://bugs.webkit.org/show_bug.cgi?id=46005

The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode):
3:43 PM Changeset in webkit [67793] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Mihai Parparita <​mihaip@chromium.org>

Reviewed by James Robinson.

Remove passing animation tests from Chromium's test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=45996

Update Chromium test_expectations.txt to remove tests that now pass:

animations/animation-shorthand-removed.html, animations/
animation-shorthand.html, and transitions/inherit-other-props.html were
fixed by ​http://trac.webkit.org/changeset/67634.

transforms/2d/transform-value-types.html has not failed in the last
1,500 runs.

animations/animation-drt-api.html was most likely fixed by 66641 (it
hasn't failed in the last 1,500 runs either).

  • platform/chromium/test_expectations.txt:
2:47 PM Changeset in webkit [67792] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-09-18 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=45976

  • canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1 for the destination width/height renders correctly.
  • canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1 for the source width/height renders correctly.

2010-09-18 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=45976

Specifying a -1 width or height for either the source or destination rectangle in drawImage
get improperly drawn with -1 replaced as the corresponding image width or height. This was because
the value -1 was being passed around to signal non-specified widths and heights and thus was
interpreted lower down in the drawImage implementation which disallowed any calls that actually
wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
-1 in-band signaling to denote default behavior.

Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html

canvas/philip/tests/2d.drawImage.negativeOneSource.html

  • platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have the desired replaces for unspecified widths and heights earlier on.
  • platform/graphics/GraphicsContext.h: Removed faulty default value.
2:30 PM Changeset in webkit [67791] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-09-17 Eric Seidel <​eric@webkit.org>

Unreviewed. Adding a shell script I use to run the
commit-queue. Now that multiple machines run the cq,
it makes sense to share the script between them.

  • EWSTools/start-commit-queue.sh: Added.
2:04 PM Changeset in webkit [67790] by msaboff@apple.com
  • 5 edits
    3 adds in trunk

2010-09-18 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added code to unroll regular expressions containing .
Alternatives that begin with are tagged during parsing
and rolled up in containing sub expression structs.
After parsing, a regular expression flagged as containing
a (a.k.a. BOL) is processed further in optimizeBOL().
A copy of the disjunction is made excluding alternatives that
are rooted with BOL. The original alternatives are flagged
to only be executed once. The copy of the other alternatives are
added to the original expression.
In the case that all original alternatives are flagged, there
won't be any looping alternatives.
The JIT generator will emit code accordingly, executing the
original alternatives once and then looping over the
alternatives that aren't anchored with a BOL (if any).
​https://bugs.webkit.org/show_bug.cgi?id=45787

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::assertionBOL): (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd): (JSC::Yarr::RegexPatternConstructor::copyDisjunction): (JSC::Yarr::RegexPatternConstructor::copyTerm): (JSC::Yarr::RegexPatternConstructor::optimizeBOL): (JSC::Yarr::compileRegex):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):
  • yarr/RegexPattern.h: (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::setOnceThrough): (JSC::Yarr::PatternAlternative::onceThrough): (JSC::Yarr::PatternDisjunction::PatternDisjunction): (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):

2010-09-18 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added new tests to check for proper handling of in multiline
regular expressions. Added as part of
​https://bugs.webkit.org/show_bug.cgi?id=45787

  • fast/js/regexp-bol-with-multiline-expected.txt: Added.
  • fast/js/regexp-bol-with-multiline.html: Added.
  • fast/js/script-tests/regexp-bol-with-multiline.js: Added.
1:52 PM Changeset in webkit [67789] by Dimitri Glazkov
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-09-18 Dimitri Glazkov <Dimitri Glazkov>

Remove duplicate expectations from platform/chromium-win-xp.

  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
1:41 PM Changeset in webkit [67788] by Patrick Gansterer
  • 4 edits
    38 moves in trunk

2010-09-18 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Rename Wince files to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=37287

  • wtf/unicode/Unicode.h:
  • wtf/unicode/wince/UnicodeWinCE.cpp: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp.
  • wtf/unicode/wince/UnicodeWinCE.h: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.h.
  • wtf/unicode/wince/UnicodeWince.cpp: Removed.
  • wtf/unicode/wince/UnicodeWince.h: Removed.
  • wtf/wince/FastMallocWinCE.h: Copied from JavaScriptCore/wtf/wince/FastMallocWince.h.
  • wtf/wince/FastMallocWince.h: Removed.

2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
​https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebCore.pro: Adding/removing implementation files
  • platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
  • platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
  • plugins/qt/PluginDataQt.cpp: Removed (idem)
1:15 PM Changeset in webkit [67787] by commit-queue@webkit.org
  • 8 edits
    1 move
    2 adds
    1 delete in trunk

2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
​https://bugs.webkit.org/show_bug.cgi?id=45831

  • wtf/Platform.h: Enable Platform Strategies when building QtWebkit

2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
​https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebCore.pro: Adding/removing implementation files
  • platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
  • platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
  • plugins/qt/PluginDataQt.cpp: Removed (idem)

2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
​https://bugs.webkit.org/show_bug.cgi?id=45831

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Initialize the PlatformStrategy singleton.
  • WebCoreSupport/WebPlatformStrategies.cpp: Added, code was moved from platform/qt/Localizations.cpp and plugins/qt/PluginDataQt.cpp (WebPlatformStrategies::initialize): create the singleton, following the same "pattern" used by Mac and Win ports. (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::createLocalizationStrategy): (WebPlatformStrategies::createVisitedLinkStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo): (WebPlatformStrategies::inputElementAltText): (WebPlatformStrategies::resetButtonDefaultLabel): (WebPlatformStrategies::searchableIndexIntroduction): (WebPlatformStrategies::submitButtonDefaultLabel): (WebPlatformStrategies::fileButtonChooseFileLabel): (WebPlatformStrategies::fileButtonNoFileSelectedLabel): (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk): (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk): (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopy): (WebPlatformStrategies::contextMenuItemTagGoBack): (WebPlatformStrategies::contextMenuItemTagGoForward): (WebPlatformStrategies::contextMenuItemTagStop): (WebPlatformStrategies::contextMenuItemTagReload): (WebPlatformStrategies::contextMenuItemTagCut): (WebPlatformStrategies::contextMenuItemTagPaste): (WebPlatformStrategies::contextMenuItemTagNoGuessesFound): (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling): (WebPlatformStrategies::contextMenuItemTagLearnSpelling): (WebPlatformStrategies::contextMenuItemTagSearchWeb): (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): (WebPlatformStrategies::contextMenuItemTagOpenLink): (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar): (WebPlatformStrategies::contextMenuItemTagSpellingMenu): (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel): (WebPlatformStrategies::contextMenuItemTagCheckSpelling): (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping): (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling): (WebPlatformStrategies::contextMenuItemTagFontMenu): (WebPlatformStrategies::contextMenuItemTagBold): (WebPlatformStrategies::contextMenuItemTagItalic): (WebPlatformStrategies::contextMenuItemTagUnderline): (WebPlatformStrategies::contextMenuItemTagOutline): (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu): (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu): (WebPlatformStrategies::contextMenuItemTagDefaultDirection): (WebPlatformStrategies::contextMenuItemTagLeftToRight): (WebPlatformStrategies::contextMenuItemTagRightToLeft): (WebPlatformStrategies::contextMenuItemTagInspectElement): (WebPlatformStrategies::searchMenuNoRecentSearchesText): (WebPlatformStrategies::searchMenuRecentSearchesText): (WebPlatformStrategies::searchMenuClearRecentSearchesText): (WebPlatformStrategies::AXWebAreaText): (WebPlatformStrategies::AXLinkText): (WebPlatformStrategies::AXListMarkerText): (WebPlatformStrategies::AXImageMapText): (WebPlatformStrategies::AXHeadingText): (WebPlatformStrategies::AXDefinitionListTermText): (WebPlatformStrategies::AXDefinitionListDefinitionText): (WebPlatformStrategies::AXButtonActionVerb): (WebPlatformStrategies::AXRadioButtonActionVerb): (WebPlatformStrategies::AXTextFieldActionVerb): (WebPlatformStrategies::AXCheckedCheckBoxActionVerb): (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb): (WebPlatformStrategies::AXMenuListActionVerb): (WebPlatformStrategies::AXMenuListPopupActionVerb): (WebPlatformStrategies::AXLinkActionVerb): (WebPlatformStrategies::missingPluginText): (WebPlatformStrategies::crashedPluginText): (WebPlatformStrategies::multipleFileUploadText): (WebPlatformStrategies::unknownFileSizeText): (WebPlatformStrategies::imageTitle): (WebPlatformStrategies::mediaElementLoadingStateText): (WebPlatformStrategies::mediaElementLiveBroadcastStateText): (WebPlatformStrategies::localizedMediaControlElementString): (WebPlatformStrategies::localizedMediaControlElementHelpText): (WebPlatformStrategies::localizedMediaTimeDescription): (WebPlatformStrategies::validationMessageValueMissingText): (WebPlatformStrategies::validationMessageTypeMismatchText): (WebPlatformStrategies::validationMessagePatternMismatchText): (WebPlatformStrategies::validationMessageTooLongText): (WebPlatformStrategies::validationMessageRangeUnderflowText): (WebPlatformStrategies::validationMessageRangeOverflowText): (WebPlatformStrategies::validationMessageStepMismatchText): (WebPlatformStrategies::isLinkVisited): (WebPlatformStrategies::addVisitedLink):
  • WebCoreSupport/WebPlatformStrategies.h: Added, based on Mac and Win versions.

2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
​https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebKit2.pro: Added Added WebPlatformStrategies.{cpp,h}
12:33 PM Changeset in webkit [67786] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Nate Chapin.

Remove passing tests from chromium test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=45948

Removes tests the flakiness dashboard shows as having passed for a couple of weeks

12:21 PM Changeset in webkit [67785] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
​https://bugs.webkit.org/show_bug.cgi?id=45900

PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
Move them into plaform sepcific build system.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
12:03 PM Changeset in webkit [67784] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-18 William Siegrist <​wsiegrist@apple.com>

Increase alternating row contract in result viewer.

11:16 AM Changeset in webkit [67783] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Daniel Bates <​dbates@rim.com>

Rubber-stamped by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

Fix some minor, non-visual typos that do not affect the test result.

  • fast/css/preserve-user-specified-zoom-level-on-reload.html:
10:44 AM Changeset in webkit [67782] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dirk Schulze.

fast/css/preserve-user-specified-zoom-level-on-reload.html does not clean up after itself
​https://bugs.webkit.org/show_bug.cgi?id=46040

Delete the sessionStorage property that this test adds once it's complete.
Otherwise it fails when run with --iterations=2 and also causes a diff in
in fast/dom/prototype-inheritance-2.html (which runs after it).

  • fast/css/preserve-user-specified-zoom-level-on-reload.html:
9:37 AM Changeset in webkit [67781] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-18 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] V8 port: Add FrameLoaderClientQt::allowScriptExtension()
​https://bugs.webkit.org/show_bug.cgi?id=46034

r67749 added FrameLoaderClient::allowScriptExtension() (V8-specific)
Add a stub implementation that simply returns false for now.

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::allowScriptExtension):
8:23 AM Changeset in webkit [67780] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Don't copy clip path to TransparencyLayer
​https://bugs.webkit.org/show_bug.cgi?id=45965

We don't need to copy the GC's clip path to the TransparencyLayer since it will
clip anyway when ending the layer.

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
6:55 AM Changeset in webkit [67779] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <​paroga@paroga.com>

Unreviewed.

[WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.

  • page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame): (WebCore::imageFromSelection):
5:19 AM Changeset in webkit [67778] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-18 Kent Tamura <​tkent@chromium.org>

Unreviewed, a trivial change.

Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
3:04 AM Changeset in webkit [67777] by mitz@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
​https://bugs.webkit.org/show_bug.cgi?id=46031

Reviewed by Eric Seidel.

  • page/Frame.cpp:

(WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
(WebCore::parentTextZoomFactor): Ditto.

Note: See TracTimeline for information about the timeline view.