Timeline
Sep 20, 2010:
- 11:54 PM Changeset in webkit [67928] by
-
- 38 edits2 adds in trunk
2010-09-20 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New items in the media Element context menu:
- play/pause
- mute/unmute
- controls display control
- switch to fullscreen (for video only)
- loop playback control
- copy media url to clipboard
- open in new window
Test: media/context-menu-actions.html
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/LocalizedStrings.h:
- platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
- rendering/HitTestResult.h:
LayoutTests:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.
- media/context-menu-actions-expected.txt: Added.
- media/context-menu-actions.html: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
WebKit:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
Updated localizable strings.
- English.lproj/Localizable.strings:
WebKit/chromium:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New localized strings for the media element context-menu.
- src/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
WebKit/mac:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New localized strings for the media element context-menu.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):
Webkit/qt:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls) (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop) (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen) (WebPlatformStrategies::contextMenuItemTagMediaPlay) (WebPlatformStrategies::contextMenuItemTagMediaPause) (WebPlatformStrategies::contextMenuItemTagMediaMute)
WebKit/win:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New localized strings for the media element context-menu.
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):
- WebCoreSupport/WebPlatformStrategies.h:
WebKit2:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New localized strings for the media element context-menu.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebKit::WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPause): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaMute): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaUnMute):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebKitTools:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.
- DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):
- 11:44 PM Changeset in webkit [67927] by
-
- 3 edits in trunk/BugsSite
2010-09-20 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Add Preview button and link to bug to patch review bar
https://bugs.webkit.org/show_bug.cgi?id=46153
- PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
- code-review.js: Added Preview button and link to bug.
- 10:44 PM Changeset in webkit [67926] by
-
- 2 edits in trunk/WebKitTools
2010-09-20 Hayato Ito <hayato@chromium.org>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 10:25 PM Changeset in webkit [67925] by
-
- 2 edits in trunk/WebCore
2010-09-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Daniel Bates.
[BREWMP] Handle tab key
https://bugs.webkit.org/show_bug.cgi?id=46104
In Brew MP, AVK_FUNCTION is the key code for tab.
Process AVK_FUNCTION as tab in PlatformKeyboardEvent.
- platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
- 10:06 PM Changeset in webkit [67924] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
All of the fill-mode tests that used to fail on Windows were fixed by
r67877. change-one-anim.html and combo-transform-translate+scale.html
haven't failed in the past 750 runs.
- platform/chromium/test_expectations.txt:
- 9:50 PM Changeset in webkit [67923] by
-
- 4 edits in trunk/LayoutTests
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed expectations update for Windows for r67898.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 9:36 PM Changeset in webkit [67922] by
-
- 3 edits1 move in trunk/WebCore
2010-09-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67918.
http://trac.webkit.org/changeset/67918
https://bugs.webkit.org/show_bug.cgi?id=46162
Broke chromium win compile (Requested by jamesr on #webkit).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp. (WebCore::GlyphPage::fill):
- 9:27 PM Changeset in webkit [67921] by
-
- 2 edits in trunk/WebCore
2010-09-20 Daniel Bates <dbates@rim.com>
Reviewed by Dan Bernstein.
Cleanup: Extract common border radii expansion code in
RenderBoxModelObject::paintBoxShadow() into function
https://bugs.webkit.org/show_bug.cgi?id=45934
Extracted code for expanding and clamping the border radii
into common function to remove duplicate code.
No functionality was changed. So, no new tests.
- rendering/RenderBoxModelObject.cpp: (WebCore::uniformlyExpandBorderRadii): Added. (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
- 9:07 PM Changeset in webkit [67920] by
-
- 18 edits18 adds in trunk/LayoutTests
2010-09-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
Create Chromium/Skia baselines for tests, affected by http://trac.webkit.org/changeset/65665.
https://bugs.webkit.org/show_bug.cgi?id=46062
- platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
- platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
- platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
- platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
- platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.checksum:
- platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
- platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
- platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png: Added.
- platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
- platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.checksum: Added.
- platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.png: Added.
- platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum: Added.
- platform/chromium-linux/svg/custom/stroked-pattern-expected.png: Added.
- platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
- platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
- platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
- platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
- platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/chromium-win/svg/custom/js-late-pattern-creation-expected.checksum:
- platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
- platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum:
- platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
- platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
- platform/chromium-win/svg/custom/pattern-no-pixelation-expected.checksum: Added.
- platform/chromium-win/svg/custom/pattern-no-pixelation-expected.png: Added.
- platform/chromium-win/svg/custom/stroked-pattern-expected.checksum:
- platform/chromium-win/svg/custom/stroked-pattern-expected.png:
- platform/chromium/test_expectations.txt:
- 8:51 PM Changeset in webkit [67919] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-20 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Trivial clang warning fix
https://bugs.webkit.org/show_bug.cgi?id=46143
- src/WebFileSystemCallbacksImpl.h:
- 8:45 PM Changeset in webkit [67918] by
-
- 3 edits1 move in trunk/WebCore
2010-09-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by James Robinson.
Make sure skia is not Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=39672
GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
GlyphPageTreeNodeSkia.cpp so that other ports can use it.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
- 8:37 PM Changeset in webkit [67917] by
-
- 9 edits in trunk/WebCore
2010-09-20 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
https://bugs.webkit.org/show_bug.cgi?id=46021
Added NoStaticTables attributes to IDLs except for ones for Callbacks.
(As NoStaticTables only affects non-callback interfaces.)
- fileapi/DOMFileSystem.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryReader.idl:
- fileapi/Entry.idl:
- fileapi/EntryArray.idl:
- fileapi/FileEntry.idl:
- fileapi/Flags.idl:
- fileapi/Metadata.idl:
- 8:24 PM Changeset in webkit [67916] by
-
- 10 edits in trunk/WebKitTools
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The tool member variable should be called _tool
https://bugs.webkit.org/show_bug.cgi?id=46160
Created by find-and-replace.
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/openbugs.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/multicommandtool.py:
- 8:08 PM Changeset in webkit [67915] by
-
- 3 edits in trunk/WebCore
2010-09-20 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
Fix "operands of ? are integers of different signs" clang warnings
https://bugs.webkit.org/show_bug.cgi?id=46157
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
- 7:52 PM Changeset in webkit [67914] by
-
- 2 edits in trunk/WebKitTools
2010-09-20 Adam Barth <abarth@webkit.org>
I ran the tests before landing but ignored the fact that they failed. :(
- Scripts/webkitpy/tool/commands/queues.py:
- 7:45 PM Changeset in webkit [67913] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a feeder queue that polls bugs.webkit.org for the commit-cluster
https://bugs.webkit.org/show_bug.cgi?id=46141
The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
list of work items on the status server. The individual commit-cluster
nodes then grab the patches from the server and process them.
- Scripts/webkitpy/tool/bot/feeders.py: Added.
- Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- 7:12 PM Changeset in webkit [67912] by
-
- 3 edits in trunk/WebCore
2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>
Unreviewed, rolling out r67906.
http://trac.webkit.org/changeset/67906
https://bugs.webkit.org/show_bug.cgi?id=46139
Change causes chromium to crash when switching pages
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h:
- 7:07 PM Changeset in webkit [67911] by
-
- 3 edits in trunk/WebKitTools
2010-09-20 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Darin Adler.
build-webkit: Add support for CMake build system
https://bugs.webkit.org/show_bug.cgi?id=44979
- Scripts/build-webkit: Add "--efl" command-line option to build the EFL port of WebKit.
- Scripts/webkitdirs.pm: Define buildCMakeProject() and buildEflCMakeProject() subroutines.
- 7:03 PM Changeset in webkit [67910] by
-
- 1 edit in trunk/WebKit/chromium
Update svn:ignore to ignore more Chromium specific files that are not part of the repository
- 6:51 PM Changeset in webkit [67909] by
-
- 4 edits in trunk/WebCore
2010-09-19 Antonio Gomes <agomes@rim.com>
Reviewed by Ojan Vafai.
SelectionController::modify should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41975
As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior class.
Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.
No behavior change, so no new tests.
- editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
- editing/SelectionController.cpp: (WebCore::SelectionController::modify):
- editing/SelectionController.h:
- 6:45 PM Changeset in webkit [67908] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update for r67898.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
Updated to reflect r67898.
- 6:38 PM Changeset in webkit [67907] by
-
- 9 edits in trunk/LayoutTests
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Rebaseline tests after HashChangeEvent was added by r67898
https://bugs.webkit.org/show_bug.cgi?id=46155
GTK and Qt changes that mirror the changes from r67898, plus a missed
test window-property-descriptors from the original change.
- fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 6:35 PM Changeset in webkit [67906] by
-
- 3 edits in trunk/WebCore
2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
so that the derived class' destructor code gets called.
https://bugs.webkit.org/show_bug.cgi?id=46139
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h:
- 6:26 PM Changeset in webkit [67905] by
-
- 9 edits in trunk/WebKitTools
2010-09-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: refactor command line args getting passed to DRT
This change cleans up some argument parsing between functions to get
rid of some overlapping data structures. There should be no functional
changes in this patch; it is pure refactoring in preparation for
landing the Chrome GPU port and adding a generic way to pass
args to DRT/TestShell.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- pass the options argument explicitly to the threads and drivers, also consolidate the passing of options to the driver.
- pass options directly to process_output() to remove a couple parameters (minor cleanup).
- Scripts/webkitpy/layout_tests/port/base.py:
- pass the options argument to Port.create_driver().
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- update Port.create_driver() test
- Scripts/webkitpy/layout_tests/port/chromium.py:
- pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- pass the options argument to Port.create_driver()
- Scripts/webkitpy/layout_tests/port/test.py:
- pass the options argument to Port.create_driver()
- Scripts/webkitpy/layout_tests/port/webkit.py:
- pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- consolidate args in _get_dump_render_tree_args and rename to _get_test_args(); move all of the command-line args to the Port implementations.
- 6:11 PM Changeset in webkit [67904] by
-
- 2 edits in trunk
Fix wrong change log! It should have said this:
Deprecate the inputType function on HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=46023
Reviewed by James Robinson.
WebCore:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
(WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
(WebCore::HTMLInputElement::typeMismatch): Ditto.
(WebCore::HTMLInputElement::valueMissing): Ditto.
(WebCore::HTMLInputElement::rangeUnderflow): Ditto.
(WebCore::HTMLInputElement::rangeOverflow): Ditto.
(WebCore::HTMLInputElement::minimum): Ditto.
(WebCore::HTMLInputElement::maximum): Ditto.
(WebCore::HTMLInputElement::stepBase): Ditto.
(WebCore::HTMLInputElement::stepMismatch): Ditto.
(WebCore::HTMLInputElement::getStepParameters): Ditto.
(WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
(WebCore::HTMLInputElement::handleBlurEvent): Ditto.
(WebCore::HTMLInputElement::setType): Added a comment.
(WebCore::HTMLInputElement::updateType): Replaced the setInputType function
with this. The type is always the type attribute value, so there is no value
in passing the type string in, and this is an internal implementation detail,
not a public function.
(WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
(WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
(WebCore::HTMLInputElement::saveFormControlState): Ditto.
(WebCore::HTMLInputElement::restoreFormControlState): Ditto.
(WebCore::HTMLInputElement::accessKeyAction): Ditto.
(WebCore::HTMLInputElement::mapToEntry): Ditto.
(WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
(WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
(WebCore::HTMLInputElement::createRenderer): Ditto.
(WebCore::HTMLInputElement::attach): Ditto.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
(WebCore::HTMLInputElement::appendFormData): Ditto.
(WebCore::HTMLInputElement::isTextField): Ditto.
(WebCore::HTMLInputElement::isTextType): Ditto.
(WebCore::HTMLInputElement::setChecked): Ditto.
(WebCore::HTMLInputElement::value): Ditto.
(WebCore::HTMLInputElement::valueWithDefault): Ditto.
(WebCore::HTMLInputElement::setSuggestedValue): Ditto.
(WebCore::HTMLInputElement::setValue): Ditto.
(WebCore::HTMLInputElement::parseToDouble): Ditto.
(WebCore::HTMLInputElement::valueAsDate): Ditto.
(WebCore::HTMLInputElement::setValueAsDate): Ditto.
(WebCore::HTMLInputElement::valueAsNumber): Ditto.
(WebCore::HTMLInputElement::setValueAsNumber): Ditto.
(WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
(WebCore::HTMLInputElement::serialize): Ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
(WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
(WebCore::HTMLInputElement::files): Ditto.
(WebCore::HTMLInputElement::isAcceptableValue): Ditto.
(WebCore::HTMLInputElement::sanitizeValue): Ditto.
(WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
(WebCore::HTMLInputElement::needsActivationCallback): Ditto.
(WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
(WebCore::HTMLInputElement::recalcWillValidate): Ditto.
(WebCore::HTMLInputElement::parseToDateComponents): Ditto.
(WebCore::HTMLInputElement::dataList): Ditto.
(WebCore::HTMLInputElement::isSpeechEnabled): Ditto.
- html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it
should not be used outside this class. Renamed numberOfTypes to
dprecatedNumberOfTypes for the same reason. Changed all code to use
deprecatedInputType function instead of m_type. Renamed inputType function
to deprecatedInputType. Replaced public setInputType function with private
updateType function. Renamed m_type data member to m_deprecatedTypeNumber.
- rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
Use setType instead of setInputType.
WebKit/chromium:
- src/WebInputElement.cpp:
(WebKit::WebInputElement::inputType):
- src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
- src/WebSearchableFormData.cpp:
(WebCore::HasSuitableTextElement):
Use deprecatedInputType instead of inputType.
- 6:06 PM Changeset in webkit [67903] by
-
- 9 edits in trunk
2010-09-20 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912
Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.
The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.
Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DInternal.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
- src/WebViewImpl.h:
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed; an attempt to fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 5:51 PM Changeset in webkit [67902] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations changes (added back mistakenly-deleted lines).
- platform/chromium/test_expectations.txt:
- 5:46 PM Changeset in webkit [67901] by
-
- 2 edits in trunk/WebCore
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed; an attempt to fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 5:42 PM Changeset in webkit [67900] by
-
- 3 edits4 adds in trunk
2010-09-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
When PDF image is directly composited, it does not display
https://bugs.webkit.org/show_bug.cgi?id=46144
In the "direct image compositing" code path, we set the image directly
as the contents of the GraphicsLayer. However, this only works with
bitmap images, so we have to check that the image is a bitmap image.
Test: compositing/images/direct-pdf-image.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
- 5:42 PM Changeset in webkit [67899] by
-
- 3 edits2 adds in trunk
2010-09-20 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Crash when div with content set to image gets composited (Vimeo).
https://bugs.webkit.org/show_bug.cgi?id=46140
When CSS specifies that the content of an element is an image, we make
a RenderImage, and setStyle() before setting the image resource. In this
case the compositing code can attempt to access the cached image, which
would crash with a null deref.
Fix by null-checking m_imageResource.
Test: compositing/images/content-image.html
- rendering/RenderImage.h: (WebCore::RenderImage::cachedImage):
- 5:22 PM Changeset in webkit [67898] by
-
- 21 edits4 adds in trunk
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335
Add explicit test for newURL and oldURL properties of hashchange events.
Add HashChangeEvent to expected global objects.
Update stateobjects tests to also check newURL on the hashchange event.
The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- fast/loader/hashchange-event-properties-expected.txt: Added.
- fast/loader/hashchange-event-properties.html: Added.
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335
Add HashChangeEvent.idl and supporting files/changes.
Test: fast/loader/hashchange-event-properties.html
The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
- dom/Document.cpp: (WebCore::Document::enqueueHashchangeEvent):
- dom/Event.cpp: (WebCore::Event::isHashChangeEvent):
- dom/Event.h:
- dom/HashChangeEvent.h: Added. (WebCore::HashChangeEvent::isHashChangeEvent): (WebCore::HashChangeEvent::create): (WebCore::HashChangeEvent::initHashChangeEvent): (WebCore::HashChangeEvent::oldURL): (WebCore::HashChangeEvent::newURL): (WebCore::HashChangeEvent::HashChangeEvent):
- dom/HashChangeEvent.idl: Added.
- page/DOMWindow.idl:
- 5:18 PM Changeset in webkit [67897] by
-
- 8 edits4 deletes in trunk
Revert r67892 (expectations update) as the expectations are out-of-date due to r67879.
- Scripts/webkitpy/layout_tests/port/base.py:
- platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Removed.
- platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Removed.
- platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Removed.
- platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Removed.
- platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
- platform/chromium-win/fast/repaint/table-cell-move-expected.png:
- platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
- platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
- platform/chromium/test_expectations.txt:
- 5:12 PM Changeset in webkit [67896] by
-
- 3 edits in trunk/WebKitTools
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Add explicit --force-patch flag to webkitpy tools
https://bugs.webkit.org/show_bug.cgi?id=46103
It wasn't obvious until I read the applypatch.py source code that
--non-interfactive implies passing --force to patch. Add --force-patch
as an alias to the flag, so that this behavior is more discoverable.
- Scripts/webkitpy/tool/steps/applypatch.py:
- Scripts/webkitpy/tool/steps/options.py:
- 5:07 PM Changeset in webkit [67895] by
-
- 3 edits in trunk/WebKitTools
2010-09-20 Eric Seidel <eric@webkit.org>
Unreviewed, adding a line which got dropped and is trivially correct (and tested).
commit-queue can't land patches
https://bugs.webkit.org/show_bug.cgi?id=46138
Add a line of code I forgot in my last commit.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- 5:04 PM Changeset in webkit [67894] by
-
- 2 edits in trunk/JavaScriptCore
Fixed detection of alternative smaller than the first alternative
to only check looping alternatives.
https://bugs.webkit.org/show_bug.cgi?id=46049
Patch by Michael Saboff <msaboff@apple.com> on 2010-09-20
Reviewed by Gavin Barraclough.
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateDisjunction):
- 4:59 PM Changeset in webkit [67893] by
-
- 2 edits1 copy in trunk/WebKitTools
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The commit-cluster bots still race to lock patch_ids
https://bugs.webkit.org/show_bug.cgi?id=46130
It turns out we need to use a transaction object to make the
read/modify/write lock operation atomic. From reading the AppEngine
documentation, I think this patch should do what we want. It's hard to
test locally because the test instance isn't distributed in the same
way the production instance is.
- QueueStatusServer/handlers/nextpatch.py:
- QueueStatusServer/model/activeworkitems.py: Added.
- 4:57 PM CommitQueue edited by
- The commit queue no longer blocks on tree redness (as of r66058) (diff)
- 4:55 PM Changeset in webkit [67892] by
-
- 7 edits4 adds in trunk
Unreviewed expectations update for chromium.
- platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Added.
- platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
- platform/chromium-win/fast/repaint/table-cell-move-expected.png:
- platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
- platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
- platform/chromium/test_expectations.txt:
Removed duplicate expectations entries to allow rebaselining tool to work.
Disabled 2d.imageData.get.source.outside.html test as it fails on Chromium.
- 4:25 PM Changeset in webkit [67891] by
-
- 5 edits in trunk/WebKit2
Add a way to delay sending replies to sync requests
https://bugs.webkit.org/show_bug.cgi?id=46117
Reviewed by Adam Roben.
Change the didReceiveSyncMessage client message to return a SyncReplyMode. If the SyncReplyMode is
AutomaticReply, the reply will be sent when the didReceiveSyncMessage function returns. However, if it is
ManualReply, then the client is handed ownership of the reply ArgumentEncoder and can choose to send it
at a later time using Connection::sendSyncReply.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncReply):
Send the message as a sync reply.
(CoreIPC::Connection::dispatchMessages):
Check the return value of didReceiveSyncMessage. If it is AutomaticReply, immediately send the reply.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change return type.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
Update for changed return type.
- 4:01 PM Changeset in webkit [67890] by
-
- 22 edits9 adds in trunk
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961
Implement WebKitUsePreHTML5ParserQuirks preference.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to false. (-[WebPreferences usePreHTML5ParserQuirks]): (-[WebPreferences setUsePreHTML5ParserQuirks:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings with the value of WebKitUsePreHTML5ParserQuirks when a preference changes.
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961
Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
legacy behavior when the start of a new token is encountered before the
current token is finished parsing. The legacy behavior is to emit the
current token as if it were properly closed and being parsing the new
token.
Test: fast/parser/pre-html5-parser-quirks.html
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks(). (WebCore::usePreHTMLParserQuirks): Add a helper function to return the value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
- html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an unexpected '<' is encountered in certain states, emit the current token and reprocess the '<' as the start of a new token.
- html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::create):
- html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: (WebCore::Settings::setUsePreHTML5ParserQuirks): (WebCore::Settings::usePreHTML5ParserQuirks):
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961
- fast/parser/pre-html5-parser-quirks-expected.txt: Added.
- fast/parser/pre-html5-parser-quirks.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-document-fragment.html: Added.
- fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html: Added.
- platform/chromium/test_expectations.txt: Skip pre-html5-parser-quirks.html.
- platform/gtk/Skipped: Skip pre-html5-parser-quirks.html.
- platform/mac-wk2/Skipped: Skip pre-html5-parser-quirks.html.
- platform/qt/Skipped: Skip pre-html5-parser-quirks.html.
- platform/win/Skipped: Skip pre-html5-parser-quirks.html.
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961
Implement WebKitUsePreHTML5ParserQuirks preference.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks to false after a test finishes.
- 3:49 PM Changeset in webkit [67889] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.
Reviewed by Dan Bernstein.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalWidth):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isVerticalBlockFlow):
- 3:39 PM Changeset in webkit [67888] by
-
- 2 edits in trunk/WebKitTools
Windows build fix
- MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
$(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
we'll pick up the most recent versions of the headers.
- 3:38 PM Changeset in webkit [67887] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
RenderBoxModelObject.
Reviewed by Dan Bernstein.
Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
we can see it start passing.
WebCore:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
- rendering/RenderBoxModelObject.h:
LayoutTests:
- fast/blockflow: Added.
- fast/blockflow/percentage-padding-expected.txt: Added.
- fast/blockflow/percentage-padding.html: Added.
- 3:35 PM Changeset in webkit [67886] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.
Reviewed by Dan Bernstein.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableWidth):
(WebCore::RenderBlock::availableLogicalWidth):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalWidth):
- rendering/RenderBox.h:
(WebCore::RenderBox::availableWidth):
- 3:28 PM Changeset in webkit [67885] by
-
- 20 edits in trunk
2010-09-20 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912
Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.
The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.
Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DInternal.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
- src/WebViewImpl.h:
2010-09-20 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912
Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.
The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.
Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents):
- platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::SharedValues::SharedValues): (WebCore::CanvasLayerChromium::SharedValues::~SharedValues): (WebCore::CanvasLayerChromium::draw):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::SharedValues::~SharedValues): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::SharedValues::~SharedValues): (WebCore::LayerChromium::createShaderProgram): (WebCore::LayerChromium::layerRendererContext): (WebCore::LayerChromium::drawTexturedQuad): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::drawAsMask): (WebCore::LayerChromium::prepareForDraw):
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::SharedValues::context):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::context): (WebCore::LayerRendererChromium::debugGLCall): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::finish): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::scissorToRect): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::resizeOnscreenContent): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
- platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::flush): (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- 2:35 PM Changeset in webkit [67884] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle. Not used by any RenderObjects yet, so no tests
until then.
Reviewed by Dan Bernstein.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):
- rendering/style/RenderStyle.h:
- 2:07 PM Changeset in webkit [67883] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 Eric Carlson <eric.carlson@apple.com>
Rubber-stamped by by Simon Fraser.
video-served-as-text.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46111
- platform/win/Skipped: Skip http/tests/media/video-served-as-text.html.
- 2:03 PM Changeset in webkit [67882] by
-
- 8 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.
Reviewed by Dan Bernstein.
This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
width and height.
Added fast/css/logical-property-resolution.html
WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
- css/CSSProperty.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
LayoutTests:
- fast/css/logical-property-resolution-expected.txt: Added.
- fast/css/logical-property-resolution.html: Added.
- 2:00 PM Changeset in webkit [67881] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 James Robinson <jamesr@chromium.org>
Fix mis-merge of chromium mac expectations.
- platform/chromium/test_expectations.txt:
- 1:49 PM Changeset in webkit [67880] by
-
- 7 edits in trunk/WebKitTools
2010-09-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should check commit-queue+ again just before committing
https://bugs.webkit.org/show_bug.cgi?id=32679
Added a _revalidate_patch check, right before landing.
Since _revalidate_patch passes the patch_id from the work item
back to bugzilla, I had to fix all of the previous queue tests to
use valid attachment ids (that's the majority of this change).
In order to validate that the bug was still open, I had to teach
bugzilla.Bug about open/closed states.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 1:21 PM Changeset in webkit [67879] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.
Reviewed by Beth Dakin.
Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.
The layout delta is then removed after layout has happened when the repaint check is done. This change
makes cell layout match block child layout, and now the cells have the correct new location up front
when laying out (a necessity for pagination).
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- 1:20 PM Changeset in webkit [67878] by
-
- 4 edits in trunk
2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>
Reviewed by Adam Barth.
When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
that all initialzations are done before calling client dispatchDidCommitLoad to avoid
client from accessing incorrect data.
https://bugs.webkit.org/show_bug.cgi?id=41155
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):
2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>
Reviewed by Adam Barth.
Added a new qwebpage test for loading a cached page
https://bugs.webkit.org/show_bug.cgi?id=41155
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadCachedPage):
- 1:19 PM Changeset in webkit [67877] by
-
- 4 edits2 adds in trunk
2010-09-20 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
REGRESSION: alternating animation direction doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=46017
Animation-direction on Windows was broken because bitfields on
Windows are signed.
Fixed by making m_direction an unsigned in the bitfield, and
casting in the accessor.
Test: animations/animation-direction.html
- platform/animation/Animation.h: (WebCore::Animation::direction):
- 1:18 PM WebKit Team edited by
- (diff)
- 1:09 PM Changeset in webkit [67876] by
-
- 2 edits in trunk/WebKitTools
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed.
Adding myself as a comitter.
- Scripts/webkitpy/common/config/committers.py:
- 1:01 PM Changeset in webkit [67875] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 James Robinson <jamesr@chromium.org>
Fix bad merge in chromium test_expectations.txt
- platform/chromium/test_expectations.txt:
- 12:59 PM Changeset in webkit [67874] by
-
- 3 edits in trunk/WebKit2
Don't use bufferIsLargeEnoughToContain for Vectors with variable sized elements
https://bugs.webkit.org/show_bug.cgi?id=46109
Reviewed by Adam Roben.
Add a new VectorArgumentCoder class template, with specializations based on whether the
element is fixed size or not. Then update the ArgumentEncoder<Vector<T>> specialization to choose the
right VectorArgumentCoder specialization. To determine this, we use the "IsArithmetic" type trait,
which holds true for all integer types and all floating point types.
- Platform/CoreIPC/ArgumentCoders.h:
- 12:57 PM Changeset in webkit [67873] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-20 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Roll forward Chromium DEPS to pick up WebGraphicsContext3D implementation changes
https://bugs.webkit.org/show_bug.cgi?id=46115
- DEPS:
- 12:49 PM CommitterTips edited by
- (diff)
- 12:40 PM Changeset in webkit [67872] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 James Robinson <jamesr@chromium.org>
Reviewed by Andreas Kling
[chromium] Add specific expectations for canvas/philip tests
https://bugs.webkit.org/show_bug.cgi?id=45991
Instead of marking all of canvas/philip and http/tests/canvas/philip/ as
TEXT failures, this marks each test exactly.
- platform/chromium/test_expectations.txt:
- 12:32 PM Changeset in webkit [67871] by
-
- 2 edits in trunk/WebKitTools
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Two instances of commit-queue try to process the same patch
https://bugs.webkit.org/show_bug.cgi?id=46113
This patch makes next-patch atomic so that the server won't vend the
same patch twice in the same hour.
- QueueStatusServer/handlers/nextpatch.py:
- 12:30 PM Changeset in webkit [67870] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
2010-09-20 Dimitri Glazkov <Dimitri Glazkov>
Fix up the goober from http://trac.webkit.org/changeset/67856.
- platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Removed.
- platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum.
- 12:29 PM Changeset in webkit [67869] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-20 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
REGRESSION(67790): jsc tests are failed with YARR interpreter
https://bugs.webkit.org/show_bug.cgi?id=46083
Fix the initializing of the lastSubpatternId member of
parentheses.
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
- 11:51 AM Changeset in webkit [67868] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Attributes not interpreted correctly if there is a syntax error
https://bugs.webkit.org/show_bug.cgi?id=16254
The underlying bug was fixed by the HTML5 parser, but I don't think we
have a test for this particular tokenization behavior.
- html5lib/resources/webkit01.dat:
- 11:31 AM Changeset in webkit [67867] by
-
- 3 edits3 adds in trunk
2010-09-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 46077 - ASSERT failure in YARR JIT
We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):
2010-09-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 46077 - ASSERT failure in YARR JIT
We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.
- fast/js/regexp-norepeat-expected.txt: Added.
- fast/js/regexp-norepeat.html: Added.
- fast/js/script-tests/regexp-norepeat.js: Added.
- 11:18 AM Changeset in webkit [67866] by
-
- 2 edits in trunk/LayoutTests
Skip some failing animation tests on Windows
The failures are covered by http://webkit.org/b/46017
Rubber-stamped by Simon Fraser.
- platform/win/Skipped:
- 11:12 AM Changeset in webkit [67865] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 Martin Robinson <mrobinson@igalia.com>
Correct a GTK+ baseline. These issues should hopefully be mitigated
by upcoming font fixes.
- platform/gtk/fast/events/keydown-1-expected.txt: Updated baseline.
- 11:10 AM Changeset in webkit [67864] by
-
- 11 edits1 add in trunk
Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>
Reviewed by Sam Weinig.
WebCore:
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
be a Vector of RefPtr.
- page/EditorClient.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.
WebKit/mac:
Some changes to fix style inconsistencies.
Added OBJC 2.0 style enumeration.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::userVisibleString):
(createExcludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
a Vector of RefPtr.
(WebEditorClient::setInsertionPasteboard):
(WebEditorClient::pasteboardTypesForSelection):
WebKit2:
Adding support for RTF, RTFD and NSUrl formats on the Mac.
Still missing the selective enabling of the menu entries.
- WebKit2.xcodeproj/project.pbxproj: Added WebEditorClientMac.mm.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed Mac only methods
that are now in WebEditorClientMac.mm
- WebProcess/WebCoreSupport/WebEditorClient.h: Fixed style and changed parameter
type in documentFragmentFromAttributedString to be a Vector of RefPtr.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added.
All the following methods have been moved from WebEditorClient.cpp.
(WebKit::WebEditorClient::userVisibleString): Added implementation.
(WebKit::createExcludedElementsForAttributedStringConversion): Added.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added implementation.
(WebKit::WebEditorClient::setInsertionPasteboard):
(WebKit::WebEditorClient::pasteboardTypesForSelection):
(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
(WebKit::WebEditorClient::showSubstitutionsPanel):
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
(WebKit::WebEditorClient::toggleSmartInsertDelete):
(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
(WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticLinkDetection):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::toggleAutomaticTextReplacement):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticSpellingCorrection):
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):
(WebKit::WebEditorClient::isShowingCorrectionPanel):
- 11:07 AM Changeset in webkit [67863] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-09-20 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Add FrameLoaderClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=45682
- WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
- WebCoreSupport/FrameLoaderClientWinCE.h: Added.
- 10:55 AM Changeset in webkit [67862] by
-
- 2 edits in trunk/WebCore
2010-09-20 Yong Li <yoli@rim.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=39966
Make compareBorders() a consistent compare function which can beused by qsort().
New test case added: LayoutTests/tables/sort-collapsed-border-styles.html
- rendering/RenderTableCell.cpp: (WebCore::compareBorders): (WebCore::chooseBorder): (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder): (WebCore::compareBorderStylesForQSort):
- 10:50 AM Changeset in webkit [67861] by
-
- 6 edits2 adds in trunk/WebKitTools
Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
We were previously trying to use a CFRunLoopTimer, but since Windows
doesn't use CFRunLoop on most threads this doesn't work. Now we use a
Windows-style timer on Windows.
I also replaced all uses of "watchdog" with "watchdog timer".
Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
watchdog timer doesn't work on Windows
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Updated for rename.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
platform-specific functions.
(WTR::LayoutTestController::LayoutTestController): Added call to
platformInitialize.
(WTR::LayoutTestController::waitUntilDone): Changed to call
initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
right in this function.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
rename.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
members needed to support the watchdog timer abstraction. Replaced
some "watchdog"s with "watchdog timer".
- WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
Added.
(WTR::LayoutTestController::platformInitialize): Does nothing on this
platform.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
from LayoutTestController.cpp and changed to use an early return.
(WTR::waitUntilDoneWatchdogTimerFired): Moved here from
LayoutTestController.cpp.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Moved code here from LayoutTestController::waitUntilDone and changed
to use an early return.
- WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
Added.
(WTR::LayoutTestController::platformInitialize): Initialize our
watchdog timer.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
Kills and clears the watchdog timer.
(WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
LayoutTestController member function of the same name.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Added. Sets up the timer if it isn't already set.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
LayoutTestControllerMac.mm.
- WebKitTestRunner/win/InjectedBundle.vcproj: Added
LayoutTestControllerWin.cpp.
- 10:44 AM Changeset in webkit [67860] by
-
- 4 edits1 add in trunk
2010-09-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942
- platform/gtk/Skipped: Unskip test which is now passing.
- platform/gtk/fast/events/keydown-1-expected.txt: Added.
2010-09-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942
Use the gdkModifersFromJSValue helper to parse all appropriate modifier
strings in keyDownCallback.
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the modifier parsing logic.
- 10:26 AM Changeset in webkit [67859] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 Dimitri Glazkov <Dimitri Glazkov>
Update a win-xp-specific baseline.
- platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png: Updated.
- 10:14 AM Changeset in webkit [67858] by
-
- 2 edits in trunk/WebKit2
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Fix a style issue and add a FIXME to make the AppleConnect plug-in
workaround dependent on site-specific quirks being enabled, which
WebKit2 does not yet support in its WebPreferences implementation.
https://bugs.webkit.org/show_bug.cgi?id=45960
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
- 9:48 AM Changeset in webkit [67857] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
script element created with html element as parent
https://bugs.webkit.org/show_bug.cgi?id=17023
The underlying bug is fixed by the HTML5 parser. We have lots of tests
for the resulting DOM in this case, but we don't have a test for what
the DOM looks like to a script running inline at that time. Since
that's how the test case attached to the bug was written, it seems
worth adding.
- fast/parser/parent-of-script-before-head-expected.txt: Added.
- fast/parser/parent-of-script-before-head.html: Added.
- 9:20 AM Changeset in webkit [67856] by
-
- 2 edits6 moves1 add in trunk/LayoutTests
2010-09-20 Dimitri Glazkov <Dimitri Glazkov>
Move a few more xp-specific results to win-xp and clean up test expectations.
- platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt.
- platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.checksum.
- platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.png.
- platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.checksum.
- platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.png.
- platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.checksum.
- platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.png.
- platform/chromium/test_expectations.txt:
- 9:18 AM Changeset in webkit [67855] by
-
- 2 edits in trunk/JavaScriptCore
Export RegExpObject::info from JavaScriptCore
This allows obj->inherits(&RegExpObject::info) to work correctly from
outside JavaScriptCore.dll on Windows.
Fixes <http://webkit.org/b/46098>
fast/loader/stateobjects/pushstate-object-types.html fails on Windows
Reviewed by John Sullivan.
- runtime/RegExpObject.h: Added JS_EXPORTDATA to the info member, as
we already have for some other classes whose info members have to be
used from outside the DLL.
- 9:16 AM Changeset in webkit [67854] by
-
- 2 edits in trunk/WebCore
2010-09-20 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46033
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::snapshot):
- 9:12 AM Changeset in webkit [67853] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.
Reviewed by Sam Weinig.
This happens because the site always has a document width that will exceed the page width.
We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
The fix for the issue is to cap the right layout overflow to the page width and to just clip out
any additional excess. This is the code in FrameView.cpp.
This patch also cleans up table cell invalidation to reduce the # of relayouts. This change is not
a correctness fix. It's just performance.
I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
back in when really printing.
- page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::positionNewFloats):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::markForPaginationRelayout):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- 9:07 AM BuildingGtk edited by
- (diff)
- 8:47 AM Changeset in webkit [67852] by
-
- 18 edits in trunk
2010-09-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: merge Inspector client runtime events into the serialized inspector state object.
Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.
WebCore:
- inspector/Inspector.idl:
- inspector/InspectorClient.h: (WebCore::InspectorClient::updateInspectorStateCookie):
- inspector/InspectorController.cpp: (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/Settings.js: (WebInspector.Settings.initialize):
- inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone):
WebKit/chromium:
- src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::updateInspectorStateCookie):
- src/InspectorClientImpl.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
- src/WebDevToolsAgentImpl.h:
LayoutTests:
- http/tests/inspector/console-xhr-logging.html:
- inspector/report-API-errors-expected.txt:
- inspector/report-API-errors.html:
- 8:18 AM Changeset in webkit [67851] by
-
- 2 edits in trunk/LayoutTests
[Qt]REGRESSION? (r67762): 23 layout tests fail
https://bugs.webkit.org/show_bug.cgi?id=46093
- platform/qt/Skipped: Skip failing tests until fix.
- 8:10 AM Changeset in webkit [67850] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove no-longer-needed Windows-specific results for a Sputnik Array.prototype.splice test
Rubber-stamped by Anders Carlsson.
- platform/win/fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Removed.
- 8:08 AM Changeset in webkit [67849] by
-
- 8 edits in trunk/WebKit2
Add WebKit2 API to load a string as plain text
https://bugs.webkit.org/show_bug.cgi?id=46091
Reviewed by Adam Roben.
- Shared/CoreIPCSupport/WebPageMessageKinds.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadPlainTextString):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadPlainTextString):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- 7:56 AM Changeset in webkit [67848] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update Qt specific expected result after r67770.
Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024
- platform/qt/fast/replaced/table-percent-height-expected.txt: Updated.
- 7:39 AM Changeset in webkit [67847] by
-
- 55 edits in trunk/WebCore
2010-09-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612
All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
their own. Working on it in a followup patch.
The subregions code is SVG specific and moving this calculation to FilterEffect is an
intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
The new FilterEffectVector will also make it possible to add code to determine the
smallest used region of an effect and will help save memory and resources in the future.
subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
renamed to repaintRectInLocalCoordinates since this is its proper meaning.
Removed unnecessary member variables and functions from FilterEffect.
No new tests added since the functionality didn't change.
- platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
- platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor. (WebCore::FEBlend::FEBlend): (WebCore::FEBlend::create): (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives. (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::FEColorMatrix): (WebCore::FEColorMatrix::create): (WebCore::FEColorMatrix::apply): (WebCore::FEColorMatrix::externalRepresentation):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::FEComponentTransfer): (WebCore::FEComponentTransfer::create): (WebCore::FEComponentTransfer::apply): (WebCore::FEComponentTransfer::externalRepresentation):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::FEComposite): (WebCore::FEComposite::create): (WebCore::FEComposite::apply): (WebCore::FEComposite::externalRepresentation):
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::create): (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/Filter.h: (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation. (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now. (WebCore::FilterEffect::calculateDrawingRect): ditto. (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
- platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.
Seperate SVG specific member variables and functions. Will get removed in followup patches.
(WebCore::FilterEffect::resultImage):
(WebCore::FilterEffect::setEffectBuffer):
(WebCore::FilterEffect::inputEffect):
(WebCore::FilterEffect::inputEffects):
(WebCore::FilterEffect::numberOfinputEffects):
(WebCore::FilterEffect::isAlphaImage):
(WebCore::FilterEffect::setIsAlphaImage):
(WebCore::FilterEffect::repaintRectInLocalCoordinates):
(WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
(WebCore::FilterEffect::isSourceInput):
(WebCore::FilterEffect::hasX):
(WebCore::FilterEffect::setHasX):
(WebCore::FilterEffect::hasY):
(WebCore::FilterEffect::setHasY):
(WebCore::FilterEffect::hasWidth):
(WebCore::FilterEffect::setHasWidth):
(WebCore::FilterEffect::hasHeight):
(WebCore::FilterEffect::setHasHeight):
(WebCore::FilterEffect::filterPrimitiveSubregion):
(WebCore::FilterEffect::setFilterPrimitiveSubregion):
(WebCore::FilterEffect::effectBoundaries):
(WebCore::FilterEffect::setEffectBoundaries):
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
- platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
- platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
- rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect. (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
- svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards. (WebCore::SVGFEBlendElement::build):
- svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEComponentTransferElement.cpp: Ditto. (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFECompositeElement.cpp: Ditto. (WebCore::SVGFECompositeElement::build):
- svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::build):
- svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDisplacementMapElement.cpp: Ditto. (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEMergeElement.cpp: Ditto. (WebCore::SVGFEMergeElement::build):
- svg/SVGFEMorphologyElement.cpp: Ditto. (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEOffsetElement.cpp: Ditto. (WebCore::SVGFEOffsetElement::build):
- svg/SVGFESpecularLightingElement.cpp: Ditto. (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFETileElement.cpp: Ditto. (WebCore::SVGFETileElement::build):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::FEConvolveMatrix): (WebCore::FEConvolveMatrix::create): (WebCore::FEConvolveMatrix::apply): (WebCore::FEConvolveMatrix::externalRepresentation):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto. (WebCore::FEDiffuseLighting::FEDiffuseLighting): (WebCore::FEDiffuseLighting::create): (WebCore::FEDiffuseLighting::externalRepresentation):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::FEDisplacementMap): (WebCore::FEDisplacementMap::create): (WebCore::FEDisplacementMap::apply): (WebCore::FEDisplacementMap::externalRepresentation):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFELighting.cpp: Ditto. (WebCore::FELighting::FELighting): (WebCore::FELighting::apply):
- svg/graphics/filters/SVGFELighting.h:
- svg/graphics/filters/SVGFEMerge.cpp: Ditto. (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::apply): (WebCore::FEMerge::externalRepresentation):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: Ditto. (WebCore::FEMorphology::FEMorphology): (WebCore::FEMorphology::create): (WebCore::FEMorphology::apply): (WebCore::FEMorphology::externalRepresentation):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: Ditto. (WebCore::FEOffset::FEOffset): (WebCore::FEOffset::create): (WebCore::FEOffset::apply): (WebCore::FEOffset::externalRepresentation):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto. (WebCore::FESpecularLighting::FESpecularLighting): (WebCore::FESpecularLighting::create): (WebCore::FESpecularLighting::externalRepresentation):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: Ditto. (WebCore::FETile::FETile): (WebCore::FETile::create): (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::FETile::apply): (WebCore::FETile::externalRepresentation):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::sourceImageRect):
- 7:28 AM CommitQueue edited by
- (diff)
- 6:23 AM Changeset in webkit [67846] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix forward includes generation for MSVC when sh is in PATH.
Reviewed by Simon Hausmann.
MSVC's nmake isn't affected by having sh in PATH.
- Api/DerivedSources.pro:
- 6:13 AM Changeset in webkit [67845] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-09-20 Satish Sampath <satish@chromium.org>
Unreviewed, updating baselines for a layout test and setting expectations for 3 others.
- platform/chromium-linux/animations/animation-drt-api-expected.checksum: Added.
- platform/chromium-linux/animations/animation-drt-api-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:42 AM Changeset in webkit [67844] by
-
- 5 edits in trunk/WebCore
2010-09-20 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45897
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.JSBreakpointItem): (WebInspector.DOMBreakpointItem): (WebInspector.DOMBreakpointItem.prototype.compareTo): (WebInspector.DOMBreakpointItem.prototype._breakpointClicked):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectNode): (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs): (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs): (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeOutline.prototype._onmouseout):
- inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.highlightDOMNodeForTwoSeconds): (WebInspector.wireElementWithDOMNode): (WebInspector._updateFocusedNode): (WebInspector.reset): (WebInspector.updateFocusedNode):
- 4:27 AM Changeset in webkit [67843] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-09-20 Satish Sampath <satish@chromium.org>
Unreviewed, updating baselines for a layout test and adding 5 others to the skip list.
- platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:57 AM Changeset in webkit [67842] by
-
- 19 edits in trunk/LayoutTests
Unreviewed. Update Qt specific expected results after r67660.
Paginate and column-break at layout time rather than when painting
https://bugs.webkit.org/show_bug.cgi?id=38402
- platform/qt/fast/multicol/client-rects-expected.txt:
- platform/qt/fast/multicol/column-count-with-rules-expected.txt:
- platform/qt/fast/multicol/float-paginate-expected.txt:
- platform/qt/fast/multicol/layers-in-multicol-expected.txt:
- platform/qt/fast/multicol/nested-columns-expected.txt:
- platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
- platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/qt/fast/repaint/multicol-repaint-expected.txt:
- 1:28 AM Changeset in webkit [67841] by
-
- 5 edits in branches/chromium/517/WebCore
Merge 67709 - 2010-09-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961
There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.
- inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
- inspector/InspectorResource.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3441018
- 12:10 AM Changeset in webkit [67840] by
-
- 2 edits in trunk/LayoutTests
2010-09-20 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991
Adds failing mac canvas/philip tests to test_expectations.txt.
- platform/chromium/test_expectations.txt:
Sep 19, 2010:
- 11:16 PM Changeset in webkit [67839] by
-
- 2 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Publish button should actually publish the review comments
https://bugs.webkit.org/show_bug.cgi?id=46074
Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.
- code-review.js:
- 10:29 PM Changeset in webkit [67838] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- UIProcess/API/C/WKPage.h:
- 10:23 PM Changeset in webkit [67837] by
-
- 2 edits in trunk/WebKit2
Attempt to fix Qt build.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
- 10:20 PM Changeset in webkit [67836] by
-
- 5 edits in trunk/WebKit2
Add WebKit2 equivalent of the WebFormDelegate's doCommandBySelector
<rdar://problem/8377088>
https://bugs.webkit.org/show_bug.cgi?id=46073
Reviewed by Anders Carlsson.
Add bundle client to match the behavior of:
- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::getActionTypeForKeyEvent):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- 9:26 PM Changeset in webkit [67835] by
-
- 3 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move reviewtool to action=review
https://bugs.webkit.org/show_bug.cgi?id=46071
This patch removes the old Review Patch screen and moves the new
reviewtool from Pretty Diff to Review Patch.
- attachment.cgi:
- code-review.js:
- 9:06 PM Changeset in webkit [67834] by
-
- 10 edits in trunk
WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
- UIProcess/WebPolicyClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
- 8:05 PM Changeset in webkit [67833] by
-
- 2 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Review tool UI tweak. This patch lengthens the status bubbles so all
the bubble fit (even when they have numbers inside).
- PrettyPatch/PrettyPatch.rb:
- 7:41 PM Changeset in webkit [67832] by
-
- 2 edits in trunk/WebKitTools
2010-09-19 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
https://bugs.webkit.org/show_bug.cgi?id=46046
Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.
- Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
- Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
- 7:27 PM Changeset in webkit [67831] by
-
- 12 edits in trunk
2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068
breaking ToT chromium canary build (Requested by shans on
#webkit).
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068
breaking ToT chromium canary build (Requested by shans on
#webkit).
- public/WebFrameClient.h:
- public/WebScriptController.h:
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
- src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
- 7:00 PM Changeset in webkit [67830] by
-
- 1 edit16 moves in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Move win-xp-specific baselines to their proper places.
- platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
- platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
- platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
- platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.
- 6:59 PM Changeset in webkit [67829] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:52 PM Changeset in webkit [67828] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=46064
r62958 added incorrect expectations for this test. Chromium DRT actually
gets this test right if we let it use the base expectations file. Mark
the test as failing with test_shell only.
- platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
- platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 6:43 PM Changeset in webkit [67827] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:35 PM Changeset in webkit [67826] by
-
- 2 edits in trunk/JavaScriptCore
Build fix - implicit double-to-int conversion invalid on 32-bit.
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):
- 6:23 PM Changeset in webkit [67825] by
-
- 12 edits3 adds in trunk
Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.
Reviewed by Oliver Hunt.
These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.
Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32). This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).
- JavaScriptCore.exp:
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):
- runtime/JSValue.cpp:
(JSC::toInt32):
- runtime/JSValue.h:
(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
WebCore:
Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.
Test: fast/js/toInt32UInt32.html
- bindings/js/JSDOMBinding.h:
(WebCore::finiteInt32Value):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSVGPODListCustom.h:
(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):
- bindings/js/JSSVGPathSegListCustom.cpp:
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
LayoutTests:
Add test cases for ToInt32 / ToUInt32 functionality.
- fast/js/script-tests/toInt32UInt32.js: Added.
- fast/js/toInt32UInt32-expected.txt: Added.
- fast/js/toInt32UInt32.html: Added.
- 4:45 PM Changeset in webkit [67824] by
-
- 1 edit2 moves2 deletes in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Fix up expectation sadness I introduced in http://trac.webkit.org/changeset/67822, because no sadness is allowed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
- 3:46 PM Changeset in webkit [67823] by
-
- 3 edits1 add in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Create one more text baseline for win-vista.
- platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
- platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
- platform/chromium/test_expectations.txt: Removed an errant line break.
- 3:31 PM Changeset in webkit [67822] by
-
- 6 edits20 adds2 deletes in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Update win-vista baselines for Chromium to make a few more tests pass.
https://bugs.webkit.org/show_bug.cgi?id=46056
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
- platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
- platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
- platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
- platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
- platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.
- 3:09 PM Changeset in webkit [67821] by
-
- 2 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
Turns out these still fail.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [67820] by
-
- 2 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
These tests now pass. Go team.
- platform/chromium/test_expectations.txt:
- 2:14 PM Changeset in webkit [67819] by
-
- 2 edits in trunk/WebCore
2010-09-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] clipBoundingRect() should return rect relevant to current layer
https://bugs.webkit.org/show_bug.cgi?id=46059
r65791 inadvertently changed clipBoundingRect() to always use the GC painter
without checking the TransparencyLayer stack first.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
- 2:10 PM Changeset in webkit [67818] by
-
- 3 edits in trunk/WebCore
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- 2:08 PM Changeset in webkit [67817] by
-
- 3 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
Also update mac-leopard and mac-tiger.
See https://bugs.webkit.org/show_bug.cgi?id=46042
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- 12:54 PM Changeset in webkit [67816] by
-
- 3 edits in trunk/WebCore
2010-09-19 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
[WINCE] Buildfix for Gradient after r67801.
- platform/graphics/Gradient.h:
- platform/graphics/wince/GradientWinCE.cpp: (WebCore::Gradient::getStops):
- 11:25 AM Changeset in webkit [67815] by
-
- 2 edits in trunk/WebKit2
[Qt] Unreviewed buildfix after r67813.
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
- DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2
- 10:47 AM Changeset in webkit [67814] by
-
- 2 edits in trunk/WebKit2
[Qt] Unreviewed buildfix after r67802.
WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043
- UIProcess/API/qt/ClientImpl.h:
- 10:40 AM Changeset in webkit [67813] by
-
- 19 edits4 adds2 deletes in trunk
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
Reviewed by Anders Carlsson.
The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.
WebKit2:
- Shared/APIObject.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.
(WKBundleRangeHandleGetTypeID):
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.
(WebKit::InjectedBundleRangeHandle::type):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
- WebProcess/WebPage/WebFrame.h:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 10:37 AM Changeset in webkit [67812] by
-
- 2 edits in trunk/BugsSite
Fixed a typo.
Reviewed by Anders Carlsson.
- code-review.js: Changed the label of the OK button from Ok to OK.
- 6:31 AM Changeset in webkit [67811] by
-
- 5 edits in trunk
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035
We're going to stop exposing HTMLInputElemnt::InputType. So, add
isFoo() functions in order to remove WebInputElement::InputType.
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::isTextField): (WebKit::WebInputElement::isText): (WebKit::WebInputElement::isPasswordField): (WebKit::WebInputElement::isImageButton):
- 6:30 AM Changeset in webkit [67810] by
-
- 2 edits in trunk/WebKitTools
2010-09-19 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix WebGL test regressions by r67809.
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
- 5:55 AM Changeset in webkit [67809] by
-
- 7 edits2 adds in trunk
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945
- platform/chromium/drt_expectations.txt: Remove link-opens-new-window.html, which is fixed by this revision.
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945
Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
- DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences):
- DumpRenderTree/chromium/WebPreferences.cpp: Added.
- DumpRenderTree/chromium/WebPreferences.h: Added.
