⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 21, 2010:

10:56 PM Changeset in webkit [68016] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Each EntityMaskIn* needs explanation
​https://bugs.webkit.org/show_bug.cgi?id=44833

Added a description as to why we escape nbsp when serializing HTML documents but not when serializing XML documents.

  • editing/markup.cpp:
10:53 PM Changeset in webkit [68015] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-21 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Check if the acceleratedCompositingEnabled setting is active in WebViewImpl::graphicsContext3D()
​https://bugs.webkit.org/show_bug.cgi?id=46239

This adds a check for whether acceleratedCompositingEnabled is true on the Page's Settings
object before creating and vending a GraphicsContext3D object. This is needed because when
an offscreen WebGraphicsContext3DCommandBufferImpl is initialized it first asks the WebViewImpl
for the compositor context. WebGraphicsContext3DCommandBufferImpl::initialize checks if the
disable accelerated compositing command line switch is set, but this is insufficient as sometimes
the Setting object does not agree exactly with the command line switches. For example,
we explicitly toggle accelerated compositing for some chrome UI URLs regardless of what the
flag says.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::graphicsContext3D):
10:36 PM Changeset in webkit [68014] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-09-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
​https://bugs.webkit.org/show_bug.cgi?id=46205

Cleanup required to fix the bug 27818. Added the style extraction mechanism to removeInlineStyleFromElement
and removeCSSStyle and replaced the call to extractInlineStyleToPushDown by a call to removeInlineStyleFromElement.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle argument. (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle argument. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement instead of extractInlineStyleToPushDown which has been deleted.
  • editing/ApplyStyleCommand.h:
10:22 PM Changeset in webkit [68013] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <​tkent@chromium.org>

Unreviewed, text expectation update.

  • platform/chromium/drt_expectations.txt:
8:45 PM Changeset in webkit [68012] by tkent@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-09-21 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

[Chromium] Remove WebInputElement::InputType and inputType()
​https://bugs.webkit.org/show_bug.cgi?id=46238

  • DEPS: Roll Chromium revision to 60132, which removed all usage of inputType().
  • public/WebInputElement.h: Remove InputType and inputType().
  • src/AssertMatchingEnums.cpp: Remove WebInputElement::InputType - HTMLInputElement::InputType matching tests.
  • src/WebInputElement.cpp: Remove inputType().
8:35 PM Changeset in webkit [68011] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove passing tests, and fix typo.
8:31 PM Changeset in webkit [68010] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update DRT results.
8:13 PM Changeset in webkit [68009] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: fix bug introduced in r68008 where if you
specify --chromium and no --platform, and you're running on
windows, you use the 'chromium-win' port by default instead of the
version-specific port. This breaks the buildbots.

It will be good for this refactoring to settle down so I can
rewrite the logic for default ports and the unit tests to be
clearer (and the testing more comprehensive).

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
7:24 PM Changeset in webkit [68008] by dpranke@chromium.org
  • 21 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Modify the Port interface to take only a series of keyword arguments
in the constructor, and modify Port/factory.get() to accomodate that,
and to accept user=XXX as an argument so we can pass
webkitpy.common.system.user.User objects in.

Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
to use the common routine in webkitpy.common.system.user.open_url()
to display HTML files.

There was a routine in the Port interface to do the same thing,
but I see no need for a port-specific hook for this, since it is
something that will always be executed by the host environment
and displaying web pages has nothing to do with running layout tests.

Note that new-run-webkit-tests used to use test_shell to display
the page; this is potentially useful so that you can actually click
from a result to the broken page; however, since DumpRenderTree
doesn't support this functionality, it will be going away eventually.

​https://bugs.webkit.org/show_bug.cgi?id=46128

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:25 PM Changeset in webkit [68007] by jamesr@google.com
  • 4 edits
    2 copies in branches/chromium/517

Merge 68004 - 2010-09-21 Cosmin Truta <​ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
​https://bugs.webkit.org/show_bug.cgi?id=46120

Test a style change applied to a zoomed image.

  • css3/style-zoomed-image.html: Added.
  • css3/style-zoomed-image-expected.txt: Added.

2010-09-21 Cosmin Truta <​ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
​https://bugs.webkit.org/show_bug.cgi?id=46120

Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
  • html/HTMLImageElement.cpp: (HTMLImageElement::createRenderer): Fixed indentation.

TBR=​jamesr@google.com
BUG=54972
Review URL: ​http://codereview.chromium.org/3431018

6:22 PM Changeset in webkit [68006] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-09-21 Oliver Hunt <​oliver@apple.com>

RS=Gavin Barraclough.

Fix codeblock dumping

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable):
6:10 PM Changeset in webkit [68005] by atwilson@chromium.org
  • 35 edits
    1 delete in trunk

Revert "2010-09-21 Chris Guillory <​chris.guillory@google.com>"

This reverts commit 347aab9430be62b827cd1130adbfdf99d18bfaf0.

6:08 PM Changeset in webkit [68004] by jamesr@google.com
  • 4 edits
    2 adds in trunk

2010-09-21 Cosmin Truta <​ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
​https://bugs.webkit.org/show_bug.cgi?id=46120

Test a style change applied to a zoomed image.

  • css3/style-zoomed-image.html: Added.
  • css3/style-zoomed-image-expected.txt: Added.

2010-09-21 Cosmin Truta <​ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
​https://bugs.webkit.org/show_bug.cgi?id=46120

Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
  • html/HTMLImageElement.cpp: (HTMLImageElement::createRenderer): Fixed indentation.
6:07 PM Changeset in webkit [68003] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated test after r67994.

Reviewed by Geoffrey Garen.

  • fast/dom/Range/range-expand.html: Do not expect sentence selections to include

trailing newline characters.

5:38 PM Changeset in webkit [68002] by demarchi@webkit.org
  • 5 edits in trunk

2010-09-21 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Get fresh theme when running EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=46210

If user tried to run EWebLauncher outside of the build tree, it would
not find the theme and fallback to the installed one. However, since
EWebLauncher is not installed, we always want to take the theme from
the just compiled source code. If user had never installed WebKit's
EFL port it could even receive a segv since no theme would be found.

Now EWebLauncher does not fallback to the installed theme and CMake
gives as DATA_DIR the directory of the theme it has just built.

  • CMakeListsEfl.txt: export DATA_DIR to parent CMakeLists.txt in order to be used by EWebLauncher.

2010-09-21 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Get fresh theme when running EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=46210

If user tried to run EWebLauncher outside of the build tree, it would
not find the theme and fallback to the installed one. However, since
EWebLauncher is not installed, we always want to take the theme from
the just compiled source code. If user had never installed WebKit's
EFL port it could even receive a segv since no theme would be found.

Now EWebLauncher does not fallback to the installed theme and CMake
gives as DATA_DIR the directory of the theme it has just built.

  • CMakeListsEfl.txt: Pass the build directory as DATA_DIR to EWebLauncher.
  • EWebLauncher/main.c: Use only the theme from build director. Do not fallback to others as this could hide real bugs. (quit): (browserCreate): (findThemePath): (main):
5:35 PM Changeset in webkit [68001] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-09-21 John Gregg <​johnnyg@google.com>

Unreviewed, chromium test expecations.

[chromium] update test expectations
​https://bugs.webkit.org/show_bug.cgi?id=46235

  • platform/chromium/test_expectations.txt:
5:34 PM Changeset in webkit [68000] by kbr@google.com
  • 13 edits
    5 deletes in trunk

2010-09-21 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove GLES2Context and WebGLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=46131

Removed now-obsolete GLES2Context and WebGLES2Context classes, and
dependency on command buffer client code from WebCore. Built and
tested 3D CSS and WebGL content on Mac OS X to test.

  • WebKit.gyp:
  • public/WebGLES2Context.h: Removed.
  • public/WebGraphicsContext3D.h:
  • public/WebKitClient.h:
  • public/WebView.h:
  • src/ChromeClientImpl.cpp:
  • src/GLES2Context.cpp: Removed.
  • src/GLES2ContextInternal.cpp: Removed.
  • src/GLES2ContextInternal.h: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2010-09-21 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove GLES2Context and WebGLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=46131

Removed now-obsolete GLES2Context and WebGLES2Context classes, and
dependency on command buffer client code from WebCore. Built and
tested 3D CSS and WebGL content on Mac OS X to test.

  • WebCore.gypi:
  • platform/chromium/GLES2Context.h: Removed.
  • platform/graphics/skia/ImageSkia.cpp:
5:33 PM Changeset in webkit [67999] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Don't pass the --test-shell arg to the Chromium Mac port of DRT;
it just confuses it.

​https://bugs.webkit.org/show_bug.cgi?id=46230

  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:31 PM Changeset in webkit [67998] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Windows build.

  • loader/Cache.cpp:

(WebCore::Cache::makeResourcePurgeable):
(WebCore::Cache::evict): Cast to int before using unary '-', to avoid an
MSVC warning.

5:27 PM Changeset in webkit [67997] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Add DirectX SDK include path.

Rubber stamped by Simon Fraser.

  • win/WebKit2DirectX.vsprops:
5:18 PM Changeset in webkit [67996] by ggaren@apple.com
  • 6 edits in trunk/WebCore

Use purgeable memory to keep more dead resources in cache
​https://bugs.webkit.org/show_bug.cgi?id=44806
<rdar://problem/8350901>

Patch by Pratik Solanki <​psolanki@apple.com> on 2010-09-21
Reviewed by Geoffrey Garen and Darin Adler.

This changes the behavior of dead resources in the WebCore cache to be the following if
shouldMakeResourcePurgeableOnEviction() returns true.

  1. Dead resources in the cache are kept in non-purgeable memory.
  2. When we prune dead resources, instead of freeing them, we mark their memory as purgeable

and keep the resources until the kernel reclaims the purgeable memory.

By leaving the in-cache dead resources in dirty resident memory, we decrease the likelihood
of the kernel claiming that memory and forcing us to refetch the resource (for example when
a user presses back).

And by having an unbounded number of resource objects using purgeable memory, we can use
as much memory as is available on the machine. The trade-off is that the CachedResource
object (and its member variables) are allocated in non-purgeable TC-malloc'd memory so
we would see slightly more memory use due to this.

  • loader/Cache.cpp:

(WebCore::Cache::resourceForURL): Adjust sizes appropriately if we made resource memory
non-purgeable.
(WebCore::Cache::pruneDeadResources): When removing dead resources, try first to mark their
memory as purgeable. If not, evict the resource.
(WebCore::Cache::makeResourcePurgeable): Added. Try to mark resource
memory as purgeable. If successful, adjust the sizes so that we don't
factor this resources size in the Cache size calculation.
(WebCore::Cache::evict): Don't decrement size if we already did it in makeResourcePurgeable.
(WebCore::Cache::dumpLRULists): Extra debug logging.

  • loader/Cache.h:

(WebCore::Cache::shouldMakeResourcePurgeableOnEviction): Added. Indicates if the new
behaviour is enabled.

  • loader/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::allClientsRemoved): Do not mark memory as purgeable. The
Cache class takes care of this.

  • loader/CachedImage.cpp:

(WebCore::CachedImage::destroyDecodedData): Ditto.

  • loader/CachedScript.cpp:

(WebCore::CachedScript::destroyDecodedData): Ditto.

5:17 PM Changeset in webkit [67995] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

Make a new buildbot for Leopard Debug Test

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:13 PM Changeset in webkit [67994] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7729077> Extending the selection to sentence boundary after a line break may select extra character
​https://bugs.webkit.org/show_bug.cgi?id=46232

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/extend-by-sentence-002.html

  • editing/visible_units.cpp:

(WebCore::nextBoundary): The text iterator’s range end can be the position after
the line break, in which case the next visible is actually after the first character
of the next sentence. Instead, advance the text iterator past the newline character
and return the beginning of its range, which is guaranteed to still be before the
next sentence.

LayoutTests:

  • editing/selection/extend-by-sentence-002-expected.txt: Added.
  • editing/selection/extend-by-sentence-002.html: Added.
5:06 PM Changeset in webkit [67993] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix breakage of Chromium Mac DRT port caused by r67905.

​https://bugs.webkit.org/show_bug.cgi?id=46230

  • Scripts/webkitpy/layout_tests/port/webkit.py:
4:59 PM Changeset in webkit [67992] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-21 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Roll forward Chromium DEPS to pick up removal of WebGLES2Context dependencies
​https://bugs.webkit.org/show_bug.cgi?id=46231

Ran build-webkit --chromium --debug on Mac OS X to test the roll-forward.

  • DEPS:
4:39 PM Changeset in webkit [67991] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Forward window focus changes to the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=46227

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowFocusChanged):
Send the NPCocoaEventWindowFocusChanged event.

(WebKit::NetscapePlugin::windowFrameChanged):
(WebKit::NetscapePlugin::windowVisibilityChanged):
Add stubs.

  • WebProcess/Plugins/Plugin.h:

Add windowFocusChanged, windowFrameChanged and windowVisibilityChanged.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::webPage):
Make webPage a member function instead.

(WebKit::PluginView::setWindowIsFocused):
Call the plug-in member function.

(WebKit::PluginView::initializePlugin):
When the plug-in has been initialized, update its window frame, window visibility
and window focus states.

(WebKit::PluginView::setParent):
Move viewGeometryDidChange to initializePlugin.

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActive):
Tell all plug-in views about the new window focus state.

(WebKit::WebPage::windowIsFocused):
Return whether the window is focused or not.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowIsVisible):
(WebKit::WebPage::windowFrame):
Add getters.

4:19 PM Changeset in webkit [67990] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-09-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Speed up function.apply(..., arguments)
​https://bugs.webkit.org/show_bug.cgi?id=46207

Add code to do argument copying inline in the case
where we're using Function.apply to forward our arguments
directly.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):

Splitted op_load_varargs into fast and slow paths, so add the call
to the slow path generator.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp: Remove 32bit specific emit_op_load_varargs as the logic is the same for all value representations
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_load_varargs): Copy arguments inline (JSC::JIT::emitSlow_op_load_varargs):
3:27 PM Changeset in webkit [67989] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Ariya Hidayat.

[Qt] Build fix against qt trunk

  • platform/graphics/qt/ContextShadow.cpp: (WebCore::ContextShadow::beginShadowLayer):
2:25 PM Changeset in webkit [67988] by crogers@google.com
  • 28 edits in branches/audio/WebCore

audio branch: changes in preparation for landing in trunk

  • added more rigorous thread safety and ASSERTS in AudioNode and AudioContext
  • added HRTFDatabaseLoader to load HRTF datasets asynchronously in another thread
  • cleaned up HRTF audio resource loading abstraction in HRTFElevation
  • general cleanup in the HRTF classes
  • added addInput() and addOutput() protected methods to AudioNode and added calls in AudioNode constructors
2:25 PM Changeset in webkit [67987] by crogers@google.com
  • 2 adds in branches/audio/WebCore/platform/audio

audio branch: add HRTFDatabaseLoader files

2:04 PM Changeset in webkit [67986] by jorlow@chromium.org
  • 9 edits in trunk/WebKit/chromium

2010-09-21 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Plumb the IDBTransansaction's id
​https://bugs.webkit.org/show_bug.cgi?id=46197

Next step, add the plumbing to Chromium. Then we add code to WebKit
that uses it (and take out the default IDBTransaction param).

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
2:00 PM Changeset in webkit [67985] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Tony Chang <​tony@chromium.org>

Unreviewed, QT build fix.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt):
1:51 PM Changeset in webkit [67984] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Handle booleans in injected bundle messages
​https://bugs.webkit.org/show_bug.cgi?id=46213

Reviewed by John Sullivan.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

1:43 PM Changeset in webkit [67983] by aestes@apple.com
  • 7 edits in trunk

2010-09-21 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
​https://bugs.webkit.org/show_bug.cgi?id=46134

AIM clients linked against versions of WebKit prior to the introduction
of the HTML5 parser contain markup incompatible with the new parser.
Enable parser quirks in this case to remain compatible with these
clients.

  • WebView/WebView.mm: (shouldUsePreHTML5ParserQuirks): Returns true if the embedding application is AIM and was linked against a version of WebKit prior to the introduction of the HTML5 parser, or if the WebKitPreHTML5ParserQuirks WebPreference is enabled. (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setUsePreHTML5ParserQuirks().

2010-09-21 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
​https://bugs.webkit.org/show_bug.cgi?id=46134

  • WebCore.exp.in: Export ZN7WebCore32applicationIsAOLInstantMessengerEv.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAOLInstantMessenger): Determine if the embedding application is AOL Instant Messenger by checking the bundle identifier.
1:22 PM Changeset in webkit [67982] by commit-queue@webkit.org
  • 35 edits
    1 copy in trunk

2010-09-21 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156

  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
  • platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LayoutComplete.html:
  • platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete.html:
  • platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification.js: (test):

2010-09-21 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156

  • WebCore.gypi:
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setFocusedNode):
  • editing/SelectionController.h:
  • editing/chromium/SelectionControllerChromium.cpp: Added. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/chromium/ChromeClientChromium.h:

2010-09-21 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156

  • public/WebAccessibilityCache.h:
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::getPopupMenuInfo):
  • src/ChromeClientImpl.h:
  • src/WebAccessibilityCache.cpp: (WebKit::WebAccessibilityCache::accessibilityEnabled):
1:21 PM Changeset in webkit [67981] by alex
  • 5 edits
    2 copies
    2 moves in trunk/WebCore

2010-09-21 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Move copyContextProperties outside the GraphicsContextCairo
​https://bugs.webkit.org/show_bug.cgi?id=46179.

Moved the copyContextProperties function to the CairoUtilities so
we can use it outside GraphicsContextCairo. We moved also the old
gtk CairoUtilities file to GdkCairoUtilities and added the new
file in the cairo directory.

  • GNUmakefile.am:
  • platform/graphics/cairo/CairoUtilities.cpp: Added. (WebCore::copyContextProperties):
  • platform/graphics/cairo/CairoUtilities.h: Added.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/gtk/CairoUtilities.cpp: Removed.
  • platform/graphics/gtk/CairoUtilities.h: Removed.
  • platform/graphics/gtk/GdkCairoUtilities.cpp: Added. (getCairoSurfacePixel): (getGdkPixbufPixel): (cairoImageSurfaceToGdkPixbuf):
  • platform/graphics/gtk/GdkCairoUtilities.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
1:20 PM Changeset in webkit [67980] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [67979] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

WebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll
​https://bugs.webkit.org/show_bug.cgi?id=46209
<rdar://problem/8445639>

Reviewed by Adam Roben.

Find WebKit2WebProcess.exe by getting the full path to WebKit.dll, and then
removing the last path component and replacing it with WebKit2WebProcess.exe.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):

1:06 PM Changeset in webkit [67978] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Add missing import of 'tempfile'.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
12:48 PM Changeset in webkit [67977] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Cleaned up LayerRendererChromium::prepareToDrawLayers
logic to avoid unnecessary copy operations if the existing root layer
contents aren't useful for scrolling. Also removed call to updateLayersRecursive()
as the composited layer update is actually happening in the drawLayers() method.
​https://bugs.webkit.org/show_bug.cgi?id=46199

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::prepareToDrawLayers):
12:47 PM Changeset in webkit [67976] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-21 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

stray param elements are dropped during parsing
​https://bugs.webkit.org/show_bug.cgi?id=14551

This bug was fixed by the HTML5 parser. Add tests from bug.

  • fast/parser/stray-param-expected.txt: Added.
  • fast/parser/stray-param.html: Added.
12:37 PM Changeset in webkit [67975] by abarth@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-09-21 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

[html-parsing] make entity handling match IE7 / HTML5
​https://bugs.webkit.org/show_bug.cgi?id=14391

This patch adds more test coverage of entity parsing. We seem to have
a bug with AElig, but I'll fix that in a future patch.

  • fast/tokenizer/entities-01.html: Added.
  • fast/tokenizer/entities-02.html: Added.
  • fast/tokenizer/entities-03.html: Added.
  • fast/tokenizer/entities-04.html: Added.
12:11 PM Changeset in webkit [67974] by dpranke@chromium.org
  • 21 edits
    1 move
    1 add
    51 deletes in trunk/WebKitTools

2010-09-17 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: pull the list of tests from the Port, and

make it possible to run with no actual test files in the filesystem.

This set of changes allows us to delete the special
webkitpy/layout_tests/data directory and test the generic code without
touching the filesystem (except to write results). This speeds up
test-webkitpy substantially.

This also cleans up and removes several code paths in the generic
code and fixes some minor bugs, notably in the test_expectations
parsing, which was previously fragile if the tests weren't present.

We also change the way we diff image results to be able to do so
in memory, without relying on files. This slows down chromium
test_shell, which always writes images to files, but should speed
up DRT and ImageDiff-based implementations slightly.

Note that pulling the list of tests to run from the Port will allow
ports to specify what tests to run as an inclusive list; previously
you could only do this as an exclusive list by using a
test_expectations file or Skipped files; nothing actually uses this
feature yet and it's unclear if it should be used.

Note that there are no functional changes -- apart from now
always printing out the location of the checksum file when we are
tracing test runs -- and the total number of lines of non-test code
actually drops by two.

There is some more cleanup that can be done in the Port/Driver
interface and in some handling of filenames, but I'll save that
for another change.

​https://bugs.webkit.org/show_bug.cgi?id=45801

  • Scripts/webkitpy/layout_tests/data/*: Removed.
    • no longer need special mock layout_tests_directory in the repository.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
    • add code to display missing text files, checksums when tracing
    • update to not look at the filesystem directly.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
    • remove tests_are_present flag
    • update with changes in Port interface - no longer access the filesystem directly, although we still use os.path for filename manipulation.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
    • renamed to port/test_files.py
  • Scripts/webkitpy/layout_tests/port/base.py:
    • change diff_image() to expect actual image data, not filenames
    • add expected_checksum(), expected_image(), expected_text() to return the content of the files so that we don't need a filesystem
    • add path_exists(), path_isdir() for filesystem-like access.
    • add test_dirs() to keep clobber-test-results from needing to actually look at a real layout tests dir
    • add tests() to return the list of tests to run on the port (calls port/test_files to do the work).
    • add update_baseline() to be able to save new baselines
    • add uri_to_test_name() from port/dryrun.py so we can easily check filename_to_uri()
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • change diff_image() to accept image content, not filenames. This will be slower for test_shell/image_diff, but faster for DRT/ImageDiff.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • simplify greatly
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/test.py:
    • massive rewrite to use in-script list of tests and expectations
  • Scripts/webkitpy/layout_tests/port/test_files.py:
    • rename from layout_package/test_files.
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
    • add unit tests
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • update diff_image() to take image contents, not files. Should make things slightly faster.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • update with changes to diff_image()
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
    • update with changes to diff_image()
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • remove tests_are_present from test_expectations
    • pull the list of tests from port.tests() instead of calling test_files.py directly.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • update unit tests
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • update with changes to
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • update with change in Port interface
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • update with change in Port interface
  • Scripts/webkitpy/style/checkers/test_expectations.py:
    • remove the tests_are_present flag
11:50 AM Changeset in webkit [67973] by commit-queue@webkit.org
  • 40 edits in trunk/WebCore

2010-09-21 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Change Clipboard to use an enum instead of isForDragging = true/false
​https://bugs.webkit.org/show_bug.cgi?id=46004

No new tests, since it's just a refactoring change.

  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::setDragImage):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::V8Clipboard::setDragImageCallback):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed):
  • dom/Clipboard.h: (WebCore::Clipboard::isForCopyAndPaste): (WebCore::Clipboard::isForDragAndDrop):
  • editing/android/EditorAndroid.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/brew/EditorBrew.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/haiku/EditorHaiku.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard):
  • editing/wx/EditorWx.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/android/ClipboardAndroid.cpp: (WebCore::ClipboardAndroid::ClipboardAndroid): (WebCore::ClipboardAndroid::clearData): (WebCore::ClipboardAndroid::clearAllData): (WebCore::ClipboardAndroid::setData):
  • platform/android/ClipboardAndroid.h:
  • platform/brew/ClipboardBrew.cpp: (WebCore::ClipboardBrew::ClipboardBrew): (WebCore::ClipboardBrew::clearData): (WebCore::ClipboardBrew::clearAllData): (WebCore::ClipboardBrew::setData):
  • platform/brew/ClipboardBrew.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::create): (WebCore::ClipboardChromium::getData):
  • platform/chromium/ClipboardChromium.h:
  • platform/efl/ClipboardEfl.cpp: (WebCore::Editor::newGeneralClipboard): (WebCore::ClipboardEfl::ClipboardEfl):
  • platform/efl/ClipboardEfl.h: (WebCore::ClipboardEfl::create):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard): (WebCore::Clipboard::create): (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::dataObjectTypeFromHTMLClipboardType): (WebCore::ClipboardGtk::clearData): (WebCore::ClipboardGtk::getData): (WebCore::ClipboardGtk::setData):
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create):
  • platform/haiku/ClipboardHaiku.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardHaiku::ClipboardHaiku):
  • platform/haiku/ClipboardHaiku.h: (WebCore::ClipboardHaiku::create):
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::create):
  • platform/mac/ClipboardMac.mm: (WebCore::Clipboard::create): (WebCore::ClipboardMac::ClipboardMac):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::writePlainText):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/win/ClipboardWin.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::setData): (WebCore::ClipboardWin::setExternalDataObject):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create):
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::ClipboardWx):
  • platform/wx/ClipboardWx.h: (WebCore::ClipboardWx::create):
11:43 AM Changeset in webkit [67972] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8363003> REGRESSION: ~1.4% sunspider regression in
interpreter due to 54724 and 54596


Fixed a typo (using "UNLIKELY" instead of "LIKELY").


  • wtf/PassRefPtr.h: (WTF::refIfNotNull): (WTF::derefIfNotNull): It is likely that m_ptr != 0 because most RefPtrs hold real data. Also, in cases where they do not hold real data, the compiler usually sees a call to release() right before the call to the destructor, so it can probably optimize out the test completely.
11:42 AM Changeset in webkit [67971] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Send window visibility and window frame change sizes to the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=46202

Reviewed by Adam Roben.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Call WebPageProxy::setWindowIsVisible.

(-[WKView addWindowObserversForWindow:]):
Add additional observers.

(-[WKView removeWindowObservers]):
Remove observers.

(-[WKView _updateWindowFrame]):
Call WebPageProxy::setWindowFrame.

(-[WKView viewDidMoveToWindow]):
Update the window visibility and the web frame.

(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
Update the window visibility.

(-[WKView _windowFrameDidChange:]):
Update the window frame.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowIsVisible):
(WebKit::WebPageProxy::setWindowFrame):
Send messages along to the web process.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Register the plug-in view.

(WebKit::PluginView::~PluginView):
Unregister the plug-in view.

(WebKit::PluginView::setWindowIsVisible):
(WebKit::PluginView::setWindowFrame):
Add empty stubs.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Initialize m_windowIsVisible.

(WebKit::WebPage::~WebPage):
Assert that all plug-in views have been removed.

(WebKit::WebPage::setWindowIsVisible):
Notify all plug-ins about the window visibility change.

(WebKit::WebPage::setWindowFrame):
Notify all plug-ins about the window frame change.

(WebKit::WebPage::didReceiveMessage):
Handle setWindowIsVisible and setWindowFrame.

11:39 AM Changeset in webkit [67970] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Disable logging.

  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
11:32 AM Changeset in webkit [67969] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Closing <li> should close nested <div>
​https://bugs.webkit.org/show_bug.cgi?id=26170

This bug is fixed by the HTML5 parser. Adding test. (We have lots of
variations of this test, but I'm adding another one to make Alexey
happy.)

  • html5lib/resources/webkit01.dat:
11:21 AM Changeset in webkit [67968] by andersca@apple.com
  • 3 edits in trunk/WebKit2
  • Configurations/WebKit2.xcconfig:

Add a note about keeping the path in MainMac.cpp in sync with the install path.

Reviewed by Mark Rowe.

  • mac/MainMac.cpp:

(main):
Use the correct framework path.

11:16 AM Changeset in webkit [67967] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Take isValueList() checks out of the asserts for memory safety.
​https://bugs.webkit.org/show_bug.cgi?id=46194

Test: editing/execCommand/apply-style-text-decoration-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):

2010-09-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that applying a text decoration style does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=46194

  • editing/execCommand/apply-style-text-decoration-crash-expected.txt: Added.
  • editing/execCommand/apply-style-text-decoration-crash.html: Added.
10:51 AM Changeset in webkit [67966] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing double translation of composited layers when scrolling.
The scrolling transform is now applied by a separate layer maintained in
the RenderLayerCompositor.
​https://bugs.webkit.org/show_bug.cgi?id=46193

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
10:50 AM Changeset in webkit [67965] by tony@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-09-21 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

add a script for running webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=46014

  • Scripts/run-chromium-webkit-unit-tests: Added.
10:49 AM Changeset in webkit [67964] by hyatt@apple.com
  • 6 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginStart):
(WebCore::RenderInline::marginEnd):

  • rendering/RenderInline.h:

(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

10:44 AM Changeset in webkit [67963] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-21 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Fix linking issues of the GTK+ port on Windows
​https://bugs.webkit.org/show_bug.cgi?id=45844

  • GNUmakefile.am: link on Windows with ole32.dll, winmm.dll and shlwapi.dll
  • configure.ac: link on Windows with ole32.dll, winmm.dll and shlwapi.dll and export correctly all needed symbols from the libwebkitgtk DLL.

2010-09-21 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Build issues with Windows versions of the GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=45844

Link with winmm.dll when necessary and specify the executable extension
explicitely so that the Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@
rule actually works.

Don't try to build the ThreadSpecificWin.cpp since GTK+ port uses
a section in ThreadSpecific.cpp

  • GNUmakefile.am:

2010-09-21 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Fix linking problems on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=45844

  • GNUmakefile.am: link the executables with winmm.dll
10:05 AM Changeset in webkit [67962] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-21 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

HTML parser double quote error recovery doesn't match Firefox 3.0.x
​https://bugs.webkit.org/show_bug.cgi?id=23970

This bug is fixed by the HTML5 parser. Adding test.

  • fast/tokenizer/unterminated-quote-in-noscript-expected.txt: Added.
  • fast/tokenizer/unterminated-quote-in-noscript.html: Added.
  • html5lib/resources/webkit02.dat:
9:48 AM Changeset in webkit [67961] by tony@chromium.org
  • 34 edits in trunk/LayoutTests

2010-09-17 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] last 16 linux baselines due to scrollbar arrows
​https://bugs.webkit.org/show_bug.cgi?id=46019

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/test_expectations.txt:
9:34 AM Changeset in webkit [67960] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):

  • rendering/RenderTableCell.h:
9:26 AM Changeset in webkit [67959] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • mac/MainMac.cpp:

(closeUnusedFileDescriptors):
Move this out into a separate function.

(main):
Don't use the soft linking macros, they were bringing in WTFReportAssertionFailure.

9:16 AM Changeset in webkit [67958] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a typo in the change log

9:02 AM Changeset in webkit [67957] by Martin Robinson
  • 4 edits in trunk

2010-09-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] 'make dist' should be fixed in preparation for the next release
​https://bugs.webkit.org/show_bug.cgi?id=46129

  • GNUmakefile.am: Update the sources list to include missing headers.

2010-09-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] 'make dist' should be fixed in preparation for the next release
​https://bugs.webkit.org/show_bug.cgi?id=46129

  • GNUmakefile.am: Update the sources list to include missing headers.
8:58 AM Changeset in webkit [67956] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting method match the Mac version of the method.
Specifically don't pass the page size down to subframes of the one you're printing.

Reviewed by John Sullivan.

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

8:53 AM Changeset in webkit [67955] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Generate correct WebKit gir file with g-i 0.9.5
​https://bugs.webkit.org/show_bug.cgi?id=46173

Generate a correct gir file for WebKit with the
gobject-introspection 0.9.5 scanner.

  • GNUmakefile.am:
8:39 AM Changeset in webkit [67954] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Zombie WebProcesses are left around
​https://bugs.webkit.org/show_bug.cgi?id=46148
<rdar://problem/8455898>

Reviewed by Dan Bernstein.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::setupTerminationNotificationHandler):
Register a dispatch handler that calls waitpid when the child process exits. This prevents zombies from
staying around after the child process has quit.

(WebKit::ProcessLauncher::launchProcess):
Pass POSIX_SPAWN_START_SUSPENDED to posix_spawn to avoid race conditions when setting up the termination
notification handler. When the handler is set up we send the SIGCONT signal to the child process.

  • mac/MainMac.cpp:

(main):
Loop through all file descriptors except for stdin, stdout and stderr and close them.

  • WebKit2.xcodeproj/project.pbxproj:

Soft-link the Web process with WebKit2. We do this so we can ensure that we won't accidentally close any
file descriptors opened by initialization code that would have been called before main().

7:35 AM Changeset in webkit [67953] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use WTF::Vector for storing formData in ResourceHandleWin.
​https://bugs.webkit.org/show_bug.cgi?id=46180

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete):
7:34 AM Changeset in webkit [67952] by satish@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-09-21 Satish Sampath <​satish@chromium.org>

Unreviewed, rename a test baseline to the correct name and update a test's expectation for chromium linux.

  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt.
  • platform/chromium/test_expectations.txt:
7:30 AM Changeset in webkit [67951] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

2010-09-21 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

[Qt] Check if the reply has been deleted before finishing a network request
​https://bugs.webkit.org/show_bug.cgi?id=46174

A crash can happen with the following sequence:

  1. QNetworkReplyHandler::abort() emits reply->deleteLater()
  2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
  3. event loop would call reply->deleteLater() However a crash occurs since m_reply == 0 on step 2.
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
7:19 AM Changeset in webkit [67950] by jochen@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Use @ to concatenate the database name and the database identifier when building
the filename to use for indexed databases. That character is valid for filenames
but cannot occur in a database identifier derived from a security origin.
​https://bugs.webkit.org/show_bug.cgi?id=46178

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::databaseFileName):
7:03 AM Changeset in webkit [67949] by steveblock@google.com
  • 15 edits in trunk

2010-09-21 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
​https://bugs.webkit.org/show_bug.cgi?id=45891

Tested by existing DeviceOrientation tests.

  • dom/DeviceMotionClient.h:
  • dom/DeviceMotionController.cpp: (WebCore::DeviceMotionController::~DeviceMotionController):
  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationClient.h:
  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::~DeviceOrientationController):
  • dom/DeviceOrientationController.h:
  • loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::deviceOrientationControllerDestroyed): (WebCore::EmptyDeviceOrientationClient::deviceOrientationControllerDestroyed):
  • platform/mock/DeviceOrientationClientMock.h: (WebCore::DeviceOrientationClientMock::deviceOrientationControllerDestroyed):

2010-09-21 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
​https://bugs.webkit.org/show_bug.cgi?id=45891

Implements DeviceOrientationClientProxy::deviceOrientationControllerDestroyed() as a no-op,
as the client's lifetime is determined by the WebViewImpl.

  • src/DeviceOrientationClientProxy.cpp: (WebKit::DeviceOrientationClientProxy::deviceOrientationControllerDestroyed):
  • src/DeviceOrientationClientProxy.h:

2010-09-21 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
​https://bugs.webkit.org/show_bug.cgi?id=45891

Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.

  • WebCoreSupport/WebDeviceOrientationClient.h:
  • WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
6:47 AM Changeset in webkit [67948] by Patrick Gansterer
  • 9 edits in trunk/WebKit/wince

2010-09-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add "WinCE" to classname for all WebCoreSupport classes to match filename.
​https://bugs.webkit.org/show_bug.cgi?id=46175

  • WebCoreSupport/ContextMenuClientWinCE.cpp: Rename ContextMenuClient to ContextMenuClientWinCE.
  • WebCoreSupport/ContextMenuClientWinCE.h: Ditto.
  • WebCoreSupport/DragClientWinCE.cpp: Rename DragClient to DragClientWinCE.
  • WebCoreSupport/DragClientWinCE.h: Ditto.
  • WebCoreSupport/EditorClientWinCE.cpp: Rename EditorClient to EditorClientWinCE.
  • WebCoreSupport/EditorClientWinCE.h: Ditto.
  • WebCoreSupport/InspectorClientWinCE.cpp: Rename InspectorClient to InspectorClientWinCE.
  • WebCoreSupport/InspectorClientWinCE.h: Ditto.
6:32 AM Changeset in webkit [67947] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

feeder-queue svn updates more often than needed
​https://bugs.webkit.org/show_bug.cgi?id=46171

We don't need to poll SVN every time we feed the feeders. Rather, we
can count on the wrapper shell script to auto-update the queue.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
6:10 AM Changeset in webkit [67946] by xan@webkit.org
  • 4 edits in trunk

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.4 release.

  • configure.ac:

WebKit/gtk:

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.4 release.

  • NEWS:
6:05 AM Changeset in webkit [67945] by commit-queue@webkit.org
  • 4 edits
    1 copy
    1 add in trunk/WebKit2

2010-09-21 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] QtWebProcess should clean up shared memory map files on close
​https://bugs.webkit.org/show_bug.cgi?id=45984

Relocate MappedMemory struct code to it's own header and implement
a singleton pool class (MappedMemoryPool) which tracks shared memory
to be able to clean up map files from disk if RunLoop stops.

  • Shared/qt/MappedMemory.h: Added. (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree):
  • Shared/qt/MappedMemoryPool.cpp: Added. (WebKit::MappedMemoryPool::MappedMemoryPool): (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::size): (WebKit::MappedMemoryPool::at): (WebKit::MappedMemoryPool::append): (WebKit::MappedMemoryPool::cleanUp):
  • Shared/qt/UpdateChunk.cpp: (WebKit::mapMemory): (WebKit::mapFile):
  • Shared/qt/UpdateChunk.h:
  • WebKit2.pro:
5:31 AM Changeset in webkit [67944] by satish@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-21 Satish Sampath <​satish@chromium.org>

Unreviewed, disable a test in chromium per the original author and added missing expectations for another.

  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt: Added.
  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [67943] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-21 Dave Tapuska <​dtapuska@rim.com>

Reviewed by Csaba Osztrogonác.

​https://bugs.webkit.org/show_bug.cgi?id=45673

r65596 caused ENABLE_PROFILER_REFERENCE_OFFSET to not be
8 byte aligned. A non 8 byte divisible value for this will
cause the sp to become non 8 byte aligned.

Verify and correct offset values that r65596 effected that
weren't updated.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
4:25 AM Changeset in webkit [67942] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/WebKitTools

[Qt] Add robot loader timeout and extra time options.
​https://bugs.webkit.org/show_bug.cgi?id=46172

Reviewed by Andreas Kling.

[-robot-timeout <s>]: Load the next page after s seconds if the current
page didn't finish loading.
[-robot-extra-time <s>]: Wait s seconds after the current page finished
loading before loading the next one. This should allow some time for the
page's JavaScript to execute.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::applyPrefs):

  • QtTestBrowser/main.cpp:

(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::LauncherApplication):
(LauncherApplication::handleUserOptions):
(main):

  • QtTestBrowser/urlloader.cpp:

(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::loadUrlList):

  • QtTestBrowser/urlloader.h:
4:15 AM Changeset in webkit [67941] by jochen@chromium.org
  • 6 edits
    1 add in trunk

2010-09-21 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Factor out the file name used for a given indexed database to a static method.
​https://bugs.webkit.org/show_bug.cgi?id=46090

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::databaseFileName):
  • storage/IDBFactoryBackendImpl.h:

2010-09-21 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] expose the filename used for a given indexed DB
​https://bugs.webkit.org/show_bug.cgi?id=46090

  • WebKit.gyp:
  • public/WebIDBFactory.h:
  • src/WebIDBFactory.cpp: (WebKit::WebIDBFactory::databaseFileName):
3:55 AM Changeset in webkit [67940] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Configure flag for Opcode stats
​https://bugs.webkit.org/show_bug.cgi?id=46081

Opcode stats won't work with JIT enabled, so bail out if both are
enabled at the same time.

  • configure.ac:
3:55 AM Changeset in webkit [67939] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix Opcode stats compilation
​https://bugs.webkit.org/show_bug.cgi?id=46079

The FixedArray API had changed, and <stdio.h> was not included for
printf.

  • bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
3:55 AM Changeset in webkit [67938] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix --disable-jit
​https://bugs.webkit.org/show_bug.cgi?id=46080

Manually define ENABLE_JIT to 0 when we want the feature disabled.

If the value is undefined Platform.h will enable it again
automatically in some platforms, which is probably not what the
user wanted if he passed --disable-jit.

  • configure.ac:
3:27 AM Changeset in webkit [67937] by satish@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

2010-09-21 Satish Sampath <​satish@chromium.org>

Unreviewed, move an xp-specific results to win-xp

  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt.
3:21 AM Changeset in webkit [67936] by aestes@apple.com
  • 9 edits in trunk/LayoutTests

2010-09-21 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Test that parser quirks apply when processing both start and end tags.
​https://bugs.webkit.org/show_bug.cgi?id=40961

  • fast/parser/pre-html5-parser-quirks-expected.txt:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html:
  • fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html:
3:09 AM Changeset in webkit [67935] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed.

[Chromium] remove test expectations for tests regressed in r67178:r67358 (fixed in r67659)

  • platform/chromium/test_expectations.txt:
2:24 AM Changeset in webkit [67934] by podivilov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
2:21 AM Changeset in webkit [67933] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Dirk Schulze <​krit@webkit.org>

SVG Filter cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45612

Unreviewed change of episolon back to a more tolerant value in RenderTreeAsText and made it a static const.
This should turn the bots green again.

  • rendering/RenderTreeAsText.cpp: (WebCore::hasFractions):
2:02 AM CommitterTips edited by podivilov@chromium.org
(diff)
1:29 AM Changeset in webkit [67932] by alex
  • 2 edits in trunk/LayoutTests

2010-09-21 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped crashing test:
media/video-controls-with-mutation-event-handler.html. Added the
bug: ​https://bugs.webkit.org/show_bug.cgi?id=46169

  • platform/gtk/Skipped:
1:02 AM Changeset in webkit [67931] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-21 Adam Barth <​abarth@webkit.org>

Unreviewed.

[reviewtool] Publish button doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=46168

Darin's recent patch had a runtime error. Sadly, we don't have any
testing for this code.

  • code-review.js:
12:45 AM Changeset in webkit [67930] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding from top/bottom-based
to before/after-based. A vertical text table can have intrinsic padding built into the left/right
direction (and this allows the base class logical padding methods on RenderBoxModelObject to be safe to use).

Reviewed by Dan Bernstein.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
(WebCore::RenderTableCell::intrinsicPaddingBefore):
(WebCore::RenderTableCell::intrinsicPaddingAfter):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeTextRun):

12:36 AM Changeset in webkit [67929] by krit@webkit.org
  • 48 edits in trunk/WebCore

2010-09-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45612

Second cleanup patch. Modified files to follow webkit style. Removed dependencies
to SVG of most of the filter effects and prepared them to move from WebCore/svg/graphics/filters
to WebCore/platform/graphics/filters/.
Renamed calculateDrawingIntRect and calculateDrawingRect to requestedRegionOfInputImageData and
drawingRegionOfInputImage to clarify the functionality and make both functions distinguishable.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h: (WebCore::ComponentTransferFunction::ComponentTransferFunction):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/Filter.h:
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::requestedRegionOfInputImageData): (WebCore::FilterEffect::drawingRegionOfInputImage): (WebCore::FilterEffect::effectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/ImageBufferFilter.cpp:
  • platform/graphics/filters/ImageBufferFilter.h:
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput): (WebCore::SourceAlpha::SourceAlpha):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput): (WebCore::SourceGraphic::SourceGraphic):
  • rendering/RenderTreeAsText.cpp: (WebCore::hasFractions): (WebCore::operator<<):
  • rendering/RenderTreeAsText.h: (WebCore::operator<<):
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply): (WebCore::FEFlood::externalRepresentation):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFELighting.cpp: (WebCore::FELighting::apply):
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:

Sep 20, 2010:

11:54 PM Changeset in webkit [67928] by Philippe Normand
  • 38 edits
    2 adds in trunk

2010-09-20 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

WebKit:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/chromium:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • src/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):

WebKit/mac:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):

Webkit/qt:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls) (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop) (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen) (WebPlatformStrategies::contextMenuItemTagMediaPlay) (WebPlatformStrategies::contextMenuItemTagMediaPause) (WebPlatformStrategies::contextMenuItemTagMediaMute)

WebKit/win:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):
  • WebCoreSupport/WebPlatformStrategies.h:

WebKit2:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebKit::WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPause): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaMute): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaUnMute):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):
11:44 PM Changeset in webkit [67927] by Darin Adler
  • 3 edits in trunk/BugsSite

2010-09-20 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Add Preview button and link to bug to patch review bar
​https://bugs.webkit.org/show_bug.cgi?id=46153

  • PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
  • code-review.js: Added Preview button and link to bug.
10:44 PM Changeset in webkit [67926] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Hayato Ito <​hayato@chromium.org>

Unreviewed.
Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
10:25 PM Changeset in webkit [67925] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Daniel Bates.

[BREWMP] Handle tab key
​https://bugs.webkit.org/show_bug.cgi?id=46104

In Brew MP, AVK_FUNCTION is the key code for tab.
Process AVK_FUNCTION as tab in PlatformKeyboardEvent.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
10:06 PM Changeset in webkit [67924] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test_expectations.txt update.

All of the fill-mode tests that used to fail on Windows were fixed by
r67877. change-one-anim.html and combo-transform-translate+scale.html
haven't failed in the past 750 runs.

  • platform/chromium/test_expectations.txt:
9:50 PM Changeset in webkit [67923] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Unreviewed expectations update for Windows for r67898.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
9:36 PM Changeset in webkit [67922] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67918.
​http://trac.webkit.org/changeset/67918
​https://bugs.webkit.org/show_bug.cgi?id=46162

Broke chromium win compile (Requested by jamesr on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp. (WebCore::GlyphPage::fill):
9:27 PM Changeset in webkit [67921] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Daniel Bates <​dbates@rim.com>

Reviewed by Dan Bernstein.

Cleanup: Extract common border radii expansion code in
RenderBoxModelObject::paintBoxShadow() into function
​https://bugs.webkit.org/show_bug.cgi?id=45934

Extracted code for expanding and clamping the border radii
into common function to remove duplicate code.

No functionality was changed. So, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::uniformlyExpandBorderRadii): Added. (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
9:07 PM Changeset in webkit [67920] by Dimitri Glazkov
  • 18 edits
    18 adds in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Create Chromium/Skia baselines for tests, affected by ​http://trac.webkit.org/changeset/65665.
​https://bugs.webkit.org/show_bug.cgi?id=46062

  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-win/svg/custom/stroked-pattern-expected.checksum:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium/test_expectations.txt:
8:51 PM Changeset in webkit [67919] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Trivial clang warning fix
​https://bugs.webkit.org/show_bug.cgi?id=46143

  • src/WebFileSystemCallbacksImpl.h:
8:45 PM Changeset in webkit [67918] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
​https://bugs.webkit.org/show_bug.cgi?id=39672

GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
GlyphPageTreeNodeSkia.cpp so that other ports can use it.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
8:37 PM Changeset in webkit [67917] by kinuko@chromium.org
  • 9 edits in trunk/WebCore

2010-09-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
​https://bugs.webkit.org/show_bug.cgi?id=46021

Added NoStaticTables attributes to IDLs except for ones for Callbacks.
(As NoStaticTables only affects non-callback interfaces.)

  • fileapi/DOMFileSystem.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/FileEntry.idl:
  • fileapi/Flags.idl:
  • fileapi/Metadata.idl:
8:24 PM Changeset in webkit [67916] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The tool member variable should be called _tool
​https://bugs.webkit.org/show_bug.cgi?id=46160

Created by find-and-replace.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
8:08 PM Changeset in webkit [67915] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Nico Weber <​thakis@chromium.org>

Reviewed by Adam Barth.

Fix "operands of ? are integers of different signs" clang warnings
​https://bugs.webkit.org/show_bug.cgi?id=46157

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
7:52 PM Changeset in webkit [67914] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <​abarth@webkit.org>

I ran the tests before landing but ignored the fact that they failed. :(

  • Scripts/webkitpy/tool/commands/queues.py:
7:45 PM Changeset in webkit [67913] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a feeder queue that polls bugs.webkit.org for the commit-cluster
​https://bugs.webkit.org/show_bug.cgi?id=46141

The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
list of work items on the status server. The individual commit-cluster
nodes then grab the patches from the server and process them.

  • Scripts/webkitpy/tool/bot/feeders.py: Added.
  • Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
7:12 PM Changeset in webkit [67912] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <​vangelis@chromium.org>

Unreviewed, rolling out r67906.
​http://trac.webkit.org/changeset/67906
​https://bugs.webkit.org/show_bug.cgi?id=46139

Change causes chromium to crash when switching pages

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
7:07 PM Changeset in webkit [67911] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Darin Adler.

build-webkit: Add support for CMake build system
​https://bugs.webkit.org/show_bug.cgi?id=44979

  • Scripts/build-webkit: Add "--efl" command-line option to build the EFL port of WebKit.
  • Scripts/webkitdirs.pm: Define buildCMakeProject() and buildEflCMakeProject() subroutines.
7:03 PM Changeset in webkit [67910] by commit-queue@webkit.org
  • 1 edit in trunk/WebKit/chromium

Update svn:ignore to ignore more Chromium specific files that are not part of the repository

6:51 PM Changeset in webkit [67909] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-09-19 Antonio Gomes <​agomes@rim.com>

Reviewed by Ojan Vafai.

SelectionController::modify should ask EditingBehavior for platform specific behavior
​https://bugs.webkit.org/show_bug.cgi?id=41975

As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior class.

Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.

No behavior change, so no new tests.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
6:45 PM Changeset in webkit [67908] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for r67898.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:

Updated to reflect r67898.

6:38 PM Changeset in webkit [67907] by mihaip@chromium.org
  • 9 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Reviewed by James Robinson.

Rebaseline tests after HashChangeEvent was added by r67898
​https://bugs.webkit.org/show_bug.cgi?id=46155

GTK and Qt changes that mirror the changes from r67898, plus a missed
test window-property-descriptors from the original change.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
6:35 PM Changeset in webkit [67906] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
so that the derived class' destructor code gets called.
​https://bugs.webkit.org/show_bug.cgi?id=46139

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
6:26 PM Changeset in webkit [67905] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-09-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: refactor command line args getting passed to DRT

This change cleans up some argument parsing between functions to get
rid of some overlapping data structures. There should be no functional
changes in this patch; it is pure refactoring in preparation for
landing the Chrome GPU port and adding a generic way to pass
args to DRT/TestShell.

​https://bugs.webkit.org/show_bug.cgi?id=46135

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • pass the options argument explicitly to the threads and drivers, also consolidate the passing of options to the driver.
    • pass options directly to process_output() to remove a couple parameters (minor cleanup).
  • Scripts/webkitpy/layout_tests/port/base.py:
    • pass the options argument to Port.create_driver().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
    • update Port.create_driver() test
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/test.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • consolidate args in _get_dump_render_tree_args and rename to _get_test_args(); move all of the command-line args to the Port implementations.
6:11 PM Changeset in webkit [67904] by Darin Adler
  • 2 edits in trunk

Fix wrong change log! It should have said this:

Deprecate the inputType function on HTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=46023

Reviewed by James Robinson.

WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
(WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
(WebCore::HTMLInputElement::typeMismatch): Ditto.
(WebCore::HTMLInputElement::valueMissing): Ditto.
(WebCore::HTMLInputElement::rangeUnderflow): Ditto.
(WebCore::HTMLInputElement::rangeOverflow): Ditto.
(WebCore::HTMLInputElement::minimum): Ditto.
(WebCore::HTMLInputElement::maximum): Ditto.
(WebCore::HTMLInputElement::stepBase): Ditto.
(WebCore::HTMLInputElement::stepMismatch): Ditto.
(WebCore::HTMLInputElement::getStepParameters): Ditto.
(WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
(WebCore::HTMLInputElement::handleBlurEvent): Ditto.
(WebCore::HTMLInputElement::setType): Added a comment.
(WebCore::HTMLInputElement::updateType): Replaced the setInputType function
with this. The type is always the type attribute value, so there is no value
in passing the type string in, and this is an internal implementation detail,
not a public function.
(WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
(WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
(WebCore::HTMLInputElement::saveFormControlState): Ditto.
(WebCore::HTMLInputElement::restoreFormControlState): Ditto.
(WebCore::HTMLInputElement::accessKeyAction): Ditto.
(WebCore::HTMLInputElement::mapToEntry): Ditto.
(WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
(WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
(WebCore::HTMLInputElement::createRenderer): Ditto.
(WebCore::HTMLInputElement::attach): Ditto.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
(WebCore::HTMLInputElement::appendFormData): Ditto.
(WebCore::HTMLInputElement::isTextField): Ditto.
(WebCore::HTMLInputElement::isTextType): Ditto.
(WebCore::HTMLInputElement::setChecked): Ditto.
(WebCore::HTMLInputElement::value): Ditto.
(WebCore::HTMLInputElement::valueWithDefault): Ditto.
(WebCore::HTMLInputElement::setSuggestedValue): Ditto.
(WebCore::HTMLInputElement::setValue): Ditto.
(WebCore::HTMLInputElement::parseToDouble): Ditto.
(WebCore::HTMLInputElement::valueAsDate): Ditto.
(WebCore::HTMLInputElement::setValueAsDate): Ditto.
(WebCore::HTMLInputElement::valueAsNumber): Ditto.
(WebCore::HTMLInputElement::setValueAsNumber): Ditto.
(WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
(WebCore::HTMLInputElement::serialize): Ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
(WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
(WebCore::HTMLInputElement::files): Ditto.
(WebCore::HTMLInputElement::isAcceptableValue): Ditto.
(WebCore::HTMLInputElement::sanitizeValue): Ditto.
(WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
(WebCore::HTMLInputElement::needsActivationCallback): Ditto.
(WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
(WebCore::HTMLInputElement::recalcWillValidate): Ditto.
(WebCore::HTMLInputElement::parseToDateComponents): Ditto.
(WebCore::HTMLInputElement::dataList): Ditto.
(WebCore::HTMLInputElement::isSpeechEnabled): Ditto.

  • html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it

should not be used outside this class. Renamed numberOfTypes to
dprecatedNumberOfTypes for the same reason. Changed all code to use
deprecatedInputType function instead of m_type. Renamed inputType function
to deprecatedInputType. Replaced public setInputType function with private
updateType function. Renamed m_type data member to m_deprecatedTypeNumber.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Use setType instead of setInputType.

WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::inputType):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebSearchableFormData.cpp:

(WebCore::HasSuitableTextElement):
Use deprecatedInputType instead of inputType.

6:06 PM Changeset in webkit [67903] by Darin Adler
  • 9 edits in trunk

2010-09-20 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
5:51 PM Changeset in webkit [67902] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations changes (added back mistakenly-deleted lines).

  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [67901] by mihaip@chromium.org
  • 2 edits in trunk/WebCore

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
5:42 PM Changeset in webkit [67900] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

When PDF image is directly composited, it does not display
​https://bugs.webkit.org/show_bug.cgi?id=46144

In the "direct image compositing" code path, we set the image directly
as the contents of the GraphicsLayer. However, this only works with
bitmap images, so we have to check that the image is a bitmap image.

Test: compositing/images/direct-pdf-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
5:42 PM Changeset in webkit [67899] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Crash when div with content set to image gets composited (Vimeo).
​https://bugs.webkit.org/show_bug.cgi?id=46140

When CSS specifies that the content of an element is an image, we make
a RenderImage, and setStyle() before setting the image resource. In this
case the compositing code can attempt to access the cached image, which
would crash with a null deref.

Fix by null-checking m_imageResource.

Test: compositing/images/content-image.html

  • rendering/RenderImage.h: (WebCore::RenderImage::cachedImage):
5:22 PM Changeset in webkit [67898] by mihaip@chromium.org
  • 21 edits
    4 adds in trunk

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
​https://bugs.webkit.org/show_bug.cgi?id=36335

Add explicit test for newURL and oldURL properties of hashchange events.
Add HashChangeEvent to expected global objects.
Update stateobjects tests to also check newURL on the hashchange event.

The original version of this patch was written by
Steven Lai <​s3lance@hotmail.com>.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • fast/loader/hashchange-event-properties-expected.txt: Added.
  • fast/loader/hashchange-event-properties.html: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
​https://bugs.webkit.org/show_bug.cgi?id=36335

Add HashChangeEvent.idl and supporting files/changes.

Test: fast/loader/hashchange-event-properties.html

The original version of this patch was written by
Steven Lai <​s3lance@hotmail.com>.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Document.cpp: (WebCore::Document::enqueueHashchangeEvent):
  • dom/Event.cpp: (WebCore::Event::isHashChangeEvent):
  • dom/Event.h:
  • dom/HashChangeEvent.h: Added. (WebCore::HashChangeEvent::isHashChangeEvent): (WebCore::HashChangeEvent::create): (WebCore::HashChangeEvent::initHashChangeEvent): (WebCore::HashChangeEvent::oldURL): (WebCore::HashChangeEvent::newURL): (WebCore::HashChangeEvent::HashChangeEvent):
  • dom/HashChangeEvent.idl: Added.
  • page/DOMWindow.idl:
5:18 PM Changeset in webkit [67897] by atwilson@chromium.org
  • 8 edits
    4 deletes in trunk

Revert r67892 (expectations update) as the expectations are out-of-date due to r67879.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Removed.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [67896] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Add explicit --force-patch flag to webkitpy tools
​https://bugs.webkit.org/show_bug.cgi?id=46103

It wasn't obvious until I read the applypatch.py source code that
--non-interfactive implies passing --force to patch. Add --force-patch
as an alias to the flag, so that this behavior is more discoverable.

  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/options.py:
5:07 PM Changeset in webkit [67895] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <​eric@webkit.org>

Unreviewed, adding a line which got dropped and is trivially correct (and tested).

commit-queue can't land patches
​https://bugs.webkit.org/show_bug.cgi?id=46138

Add a line of code I forgot in my last commit.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
5:04 PM Changeset in webkit [67894] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed detection of alternative smaller than the first alternative
to only check looping alternatives.
​https://bugs.webkit.org/show_bug.cgi?id=46049

Patch by Michael Saboff <​msaboff@apple.com> on 2010-09-20
Reviewed by Gavin Barraclough.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

4:59 PM Changeset in webkit [67893] by abarth@webkit.org
  • 2 edits
    1 copy in trunk/WebKitTools

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The commit-cluster bots still race to lock patch_ids
​https://bugs.webkit.org/show_bug.cgi?id=46130

It turns out we need to use a transaction object to make the
read/modify/write lock operation atomic. From reading the AppEngine
documentation, I think this patch should do what we want. It's hard to
test locally because the test instance isn't distributed in the same
way the production instance is.

  • QueueStatusServer/handlers/nextpatch.py:
  • QueueStatusServer/model/activeworkitems.py: Added.
4:57 PM CommitQueue edited by mihaip@chromium.org
The commit queue no longer blocks on tree redness (as of r66058) (diff)
4:55 PM Changeset in webkit [67892] by atwilson@chromium.org
  • 7 edits
    4 adds in trunk

Unreviewed expectations update for chromium.

  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:

Removed duplicate expectations entries to allow rebaselining tool to work.
Disabled 2d.imageData.get.source.outside.html test as it fails on Chromium.

4:25 PM Changeset in webkit [67891] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add a way to delay sending replies to sync requests
​https://bugs.webkit.org/show_bug.cgi?id=46117

Reviewed by Adam Roben.

Change the didReceiveSyncMessage client message to return a SyncReplyMode. If the SyncReplyMode is
AutomaticReply, the reply will be sent when the didReceiveSyncMessage function returns. However, if it is
ManualReply, then the client is handed ownership of the reply ArgumentEncoder and can choose to send it
at a later time using Connection::sendSyncReply.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncReply):
Send the message as a sync reply.

(CoreIPC::Connection::dispatchMessages):
Check the return value of didReceiveSyncMessage. If it is AutomaticReply, immediately send the reply.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change return type.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:

Update for changed return type.

4:01 PM Changeset in webkit [67890] by aestes@apple.com
  • 22 edits
    9 adds in trunk

2010-09-20 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
​https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to false. (-[WebPreferences usePreHTML5ParserQuirks]): (-[WebPreferences setUsePreHTML5ParserQuirks:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings with the value of WebKitUsePreHTML5ParserQuirks when a preference changes.

2010-09-20 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
​https://bugs.webkit.org/show_bug.cgi?id=40961

Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
legacy behavior when the start of a new token is encountered before the
current token is finished parsing. The legacy behavior is to emit the
current token as if it were properly closed and being parsing the new
token.

Test: fast/parser/pre-html5-parser-quirks.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks(). (WebCore::usePreHTMLParserQuirks): Add a helper function to return the value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an unexpected '<' is encountered in certain states, emit the current token and reprocess the '<' as the start of a new token.
  • html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::create):
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUsePreHTML5ParserQuirks): (WebCore::Settings::usePreHTML5ParserQuirks):

2010-09-20 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
​https://bugs.webkit.org/show_bug.cgi?id=40961

  • fast/parser/pre-html5-parser-quirks-expected.txt: Added.
  • fast/parser/pre-html5-parser-quirks.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html: Added.
  • platform/chromium/test_expectations.txt: Skip pre-html5-parser-quirks.html.
  • platform/gtk/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/mac-wk2/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/qt/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/win/Skipped: Skip pre-html5-parser-quirks.html.

2010-09-20 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
​https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks to false after a test finishes.
3:49 PM Changeset in webkit [67889] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isVerticalBlockFlow):

3:39 PM Changeset in webkit [67888] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put

$(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
we'll pick up the most recent versions of the headers.

3:38 PM Changeset in webkit [67887] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
RenderBoxModelObject.

Reviewed by Dan Bernstein.

Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
we can see it start passing.

WebCore:

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow: Added.
  • fast/blockflow/percentage-padding-expected.txt: Added.
  • fast/blockflow/percentage-padding.html: Added.
3:35 PM Changeset in webkit [67886] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.

Reviewed by Dan Bernstein.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableWidth):
(WebCore::RenderBlock::availableLogicalWidth):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/RenderBox.h:

(WebCore::RenderBox::availableWidth):

3:28 PM Changeset in webkit [67885] by kbr@google.com
  • 20 edits in trunk

2010-09-20 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents):
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::SharedValues::SharedValues): (WebCore::CanvasLayerChromium::SharedValues::~SharedValues): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::SharedValues::~SharedValues): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::SharedValues::~SharedValues): (WebCore::LayerChromium::createShaderProgram): (WebCore::LayerChromium::layerRendererContext): (WebCore::LayerChromium::drawTexturedQuad): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::drawAsMask): (WebCore::LayerChromium::prepareForDraw):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::SharedValues::context):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::context): (WebCore::LayerRendererChromium::debugGLCall): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::finish): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::scissorToRect): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::resizeOnscreenContent): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::flush): (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
2:35 PM Changeset in webkit [67884] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle. Not used by any RenderObjects yet, so no tests
until then.

Reviewed by Dan Bernstein.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:
2:07 PM Changeset in webkit [67883] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-20 Eric Carlson <​eric.carlson@apple.com>

Rubber-stamped by by Simon Fraser.

video-served-as-text.html failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=46111

  • platform/win/Skipped: Skip http/tests/media/video-served-as-text.html.
2:03 PM Changeset in webkit [67882] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.

Reviewed by Dan Bernstein.

This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
width and height.

Added fast/css/logical-property-resolution.html

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

  • css/CSSProperty.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt: Added.
  • fast/css/logical-property-resolution.html: Added.
2:00 PM Changeset in webkit [67881] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <​jamesr@chromium.org>

Fix mis-merge of chromium mac expectations.

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [67880] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should check commit-queue+ again just before committing
​https://bugs.webkit.org/show_bug.cgi?id=32679

Added a _revalidate_patch check, right before landing.

Since _revalidate_patch passes the patch_id from the work item
back to bugzilla, I had to fix all of the previous queue tests to
use valid attachment ids (that's the majority of this change).

In order to validate that the bug was still open, I had to teach
bugzilla.Bug about open/closed states.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
1:21 PM Changeset in webkit [67879] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.

Reviewed by Beth Dakin.

Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.

The layout delta is then removed after layout has happened when the repaint check is done. This change
makes cell layout match block child layout, and now the cells have the correct new location up front
when laying out (a necessity for pagination).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

1:20 PM Changeset in webkit [67878] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-20 Jacob Dinu <​dinu.jacob@nokia.com>

Reviewed by Adam Barth.

When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
that all initialzations are done before calling client dispatchDidCommitLoad to avoid
client from accessing incorrect data.
​https://bugs.webkit.org/show_bug.cgi?id=41155

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):

2010-09-20 Jacob Dinu <​dinu.jacob@nokia.com>

Reviewed by Adam Barth.

Added a new qwebpage test for loading a cached page
​https://bugs.webkit.org/show_bug.cgi?id=41155

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadCachedPage):
1:19 PM Changeset in webkit [67877] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

REGRESSION: alternating animation direction doesn't work on Windows
​https://bugs.webkit.org/show_bug.cgi?id=46017

Animation-direction on Windows was broken because bitfields on
Windows are signed.

Fixed by making m_direction an unsigned in the bitfield, and
casting in the accessor.

Test: animations/animation-direction.html

  • platform/animation/Animation.h: (WebCore::Animation::direction):
1:18 PM WebKit Team edited by mihaip@chromium.org
(diff)
1:09 PM Changeset in webkit [67876] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <​mihaip@chromium.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
1:01 PM Changeset in webkit [67875] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <​jamesr@chromium.org>

Fix bad merge in chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
12:59 PM Changeset in webkit [67874] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Don't use bufferIsLargeEnoughToContain for Vectors with variable sized elements
​https://bugs.webkit.org/show_bug.cgi?id=46109

Reviewed by Adam Roben.

Add a new VectorArgumentCoder class template, with specializations based on whether the
element is fixed size or not. Then update the ArgumentEncoder<Vector<T>> specialization to choose the
right VectorArgumentCoder specialization. To determine this, we use the "IsArithmetic" type trait,
which holds true for all integer types and all floating point types.

  • Platform/CoreIPC/ArgumentCoders.h:
12:57 PM Changeset in webkit [67873] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Roll forward Chromium DEPS to pick up WebGraphicsContext3D implementation changes
​https://bugs.webkit.org/show_bug.cgi?id=46115

  • DEPS:
12:49 PM CommitterTips edited by mihaip@chromium.org
(diff)
12:40 PM Changeset in webkit [67872] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <​jamesr@chromium.org>

Reviewed by Andreas Kling

[chromium] Add specific expectations for canvas/philip tests
​https://bugs.webkit.org/show_bug.cgi?id=45991

Instead of marking all of canvas/philip and http/tests/canvas/philip/ as
TEXT failures, this marks each test exactly.

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [67871] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Two instances of commit-queue try to process the same patch
​https://bugs.webkit.org/show_bug.cgi?id=46113

This patch makes next-patch atomic so that the server won't vend the
same patch twice in the same hour.

  • QueueStatusServer/handlers/nextpatch.py:
12:30 PM Changeset in webkit [67870] by Dimitri Glazkov
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Fix up the goober from ​http://trac.webkit.org/changeset/67856.

  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum.
12:29 PM Changeset in webkit [67869] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-20 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

REGRESSION(67790): jsc tests are failed with YARR interpreter
​https://bugs.webkit.org/show_bug.cgi?id=46083

Fix the initializing of the lastSubpatternId member of
parentheses.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
11:51 AM Changeset in webkit [67868] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Attributes not interpreted correctly if there is a syntax error
​https://bugs.webkit.org/show_bug.cgi?id=16254

The underlying bug was fixed by the HTML5 parser, but I don't think we
have a test for this particular tokenization behavior.

  • html5lib/resources/webkit01.dat:
11:31 AM Changeset in webkit [67867] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

2010-09-20 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):

2010-09-20 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • fast/js/regexp-norepeat-expected.txt: Added.
  • fast/js/regexp-norepeat.html: Added.
  • fast/js/script-tests/regexp-norepeat.js: Added.
11:18 AM Changeset in webkit [67866] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some failing animation tests on Windows

The failures are covered by ​http://webkit.org/b/46017

Rubber-stamped by Simon Fraser.

  • platform/win/Skipped:
11:12 AM Changeset in webkit [67865] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-09-20 Martin Robinson <​mrobinson@igalia.com>

Correct a GTK+ baseline. These issues should hopefully be mitigated
by upcoming font fixes.

  • platform/gtk/fast/events/keydown-1-expected.txt: Updated baseline.
11:10 AM Changeset in webkit [67864] by enrica@apple.com
  • 11 edits
    1 add in trunk

Pasteboard doesn't work in WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
be a Vector of RefPtr.

  • page/EditorClient.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.

WebKit/mac:

Some changes to fix style inconsistencies.
Added OBJC 2.0 style enumeration.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::userVisibleString):
(createExcludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
a Vector of RefPtr.
(WebEditorClient::setInsertionPasteboard):
(WebEditorClient::pasteboardTypesForSelection):

WebKit2:

Adding support for RTF, RTFD and NSUrl formats on the Mac.
Still missing the selective enabling of the menu entries.

  • WebKit2.xcodeproj/project.pbxproj: Added WebEditorClientMac.mm.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed Mac only methods

that are now in WebEditorClientMac.mm

  • WebProcess/WebCoreSupport/WebEditorClient.h: Fixed style and changed parameter

type in documentFragmentFromAttributedString to be a Vector of RefPtr.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added.

All the following methods have been moved from WebEditorClient.cpp.
(WebKit::WebEditorClient::userVisibleString): Added implementation.
(WebKit::createExcludedElementsForAttributedStringConversion): Added.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added implementation.
(WebKit::WebEditorClient::setInsertionPasteboard):
(WebKit::WebEditorClient::pasteboardTypesForSelection):
(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
(WebKit::WebEditorClient::showSubstitutionsPanel):
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
(WebKit::WebEditorClient::toggleSmartInsertDelete):
(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
(WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticLinkDetection):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::toggleAutomaticTextReplacement):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticSpellingCorrection):
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):
(WebKit::WebEditorClient::isShowingCorrectionPanel):

11:07 AM Changeset in webkit [67863] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-20 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Add FrameLoaderClientWinCE
​https://bugs.webkit.org/show_bug.cgi?id=45682

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h: Added.
10:55 AM Changeset in webkit [67862] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Yong Li <​yoli@rim.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=39966
Make compareBorders() a consistent compare function which can beused by qsort().

New test case added: LayoutTests/tables/sort-collapsed-border-styles.html

  • rendering/RenderTableCell.cpp: (WebCore::compareBorders): (WebCore::chooseBorder): (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder): (WebCore::compareBorderStylesForQSort):
10:50 AM Changeset in webkit [67861] by Adam Roben
  • 6 edits
    2 adds in trunk/WebKitTools

Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows

We were previously trying to use a CFRunLoopTimer, but since Windows
doesn't use CFRunLoop on most threads this doesn't work. Now we use a
Windows-style timer on Windows.

I also replaced all uses of "watchdog" with "watchdog timer".

Fixes <​http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
watchdog timer doesn't work on Windows

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed

platform-specific functions.
(WTR::LayoutTestController::LayoutTestController): Added call to
platformInitialize.
(WTR::LayoutTestController::waitUntilDone): Changed to call
initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
right in this function.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new

members needed to support the watchdog timer abstraction. Replaced
some "watchdog"s with "watchdog timer".

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

Added.
(WTR::LayoutTestController::platformInitialize): Does nothing on this
platform.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
from LayoutTestController.cpp and changed to use an early return.
(WTR::waitUntilDoneWatchdogTimerFired): Moved here from
LayoutTestController.cpp.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Moved code here from LayoutTestController::waitUntilDone and changed
to use an early return.

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

Added.
(WTR::LayoutTestController::platformInitialize): Initialize our
watchdog timer.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
Kills and clears the watchdog timer.
(WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
LayoutTestController member function of the same name.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Added. Sets up the timer if it isn't already set.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added

LayoutTestControllerMac.mm.

  • WebKitTestRunner/win/InjectedBundle.vcproj: Added

LayoutTestControllerWin.cpp.

10:44 AM Changeset in webkit [67860] by Martin Robinson
  • 4 edits
    1 add in trunk

2010-09-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
​https://bugs.webkit.org/show_bug.cgi?id=45942

  • platform/gtk/Skipped: Unskip test which is now passing.
  • platform/gtk/fast/events/keydown-1-expected.txt: Added.

2010-09-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
​https://bugs.webkit.org/show_bug.cgi?id=45942

Use the gdkModifersFromJSValue helper to parse all appropriate modifier
strings in keyDownCallback.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the modifier parsing logic.
10:26 AM Changeset in webkit [67859] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Update a win-xp-specific baseline.

  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png: Updated.
10:14 AM Changeset in webkit [67858] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-20 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Fix a style issue and add a FIXME to make the AppleConnect plug-in
workaround dependent on site-specific quirks being enabled, which
WebKit2 does not yet support in its WebPreferences implementation.
​https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
9:48 AM Changeset in webkit [67857] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

script element created with html element as parent
​https://bugs.webkit.org/show_bug.cgi?id=17023

The underlying bug is fixed by the HTML5 parser. We have lots of tests
for the resulting DOM in this case, but we don't have a test for what
the DOM looks like to a script running inline at that time. Since
that's how the test case attached to the bug was written, it seems
worth adding.

  • fast/parser/parent-of-script-before-head-expected.txt: Added.
  • fast/parser/parent-of-script-before-head.html: Added.
9:20 AM Changeset in webkit [67856] by Dimitri Glazkov
  • 2 edits
    6 moves
    1 add in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Move a few more xp-specific results to win-xp and clean up test expectations.

  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.checksum.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.png.
  • platform/chromium/test_expectations.txt:
9:18 AM Changeset in webkit [67855] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Export RegExpObject::info from JavaScriptCore

This allows obj->inherits(&RegExpObject::info) to work correctly from
outside JavaScriptCore.dll on Windows.

Fixes <​http://webkit.org/b/46098>
fast/loader/stateobjects/pushstate-object-types.html fails on Windows

Reviewed by John Sullivan.

  • runtime/RegExpObject.h: Added JS_EXPORTDATA to the info member, as

we already have for some other classes whose info members have to be
used from outside the DLL.

9:16 AM Changeset in webkit [67854] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for PluginViewWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=46033

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::snapshot):
9:12 AM Changeset in webkit [67853] by hyatt@apple.com
  • 6 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.

Reviewed by Sam Weinig.

This happens because the site always has a document width that will exceed the page width.
We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
The fix for the issue is to cap the right layout overflow to the page width and to just clip out
any additional excess. This is the code in FrameView.cpp.

This patch also cleans up table cell invalidation to reduce the # of relayouts. This change is not
a correctness fix. It's just performance.

I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
back in when really printing.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::markForPaginationRelayout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

9:07 AM BuildingGtk edited by Martin Robinson
(diff)
8:47 AM Changeset in webkit [67852] by loislo@chromium.org
  • 18 edits in trunk

2010-09-20 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: merge Inspector client runtime events into the serialized inspector state object.

Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.

​https://bugs.webkit.org/show_bug.cgi?id=45974

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::updateInspectorStateCookie):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone):

WebKit/chromium:

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::updateInspectorStateCookie):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/console-xhr-logging.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
8:18 AM Changeset in webkit [67851] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION? (r67762): 23 layout tests fail
​https://bugs.webkit.org/show_bug.cgi?id=46093

  • platform/qt/Skipped: Skip failing tests until fix.
8:10 AM Changeset in webkit [67850] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove no-longer-needed Windows-specific results for a Sputnik Array.prototype.splice test

Rubber-stamped by Anders Carlsson.

  • platform/win/fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Removed.
8:08 AM Changeset in webkit [67849] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add WebKit2 API to load a string as plain text
​https://bugs.webkit.org/show_bug.cgi?id=46091

Reviewed by Adam Roben.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadPlainTextString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadPlainTextString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
7:56 AM Changeset in webkit [67848] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, update Qt specific expected result after r67770.

Canvas sizing ignores intrinsic size
​https://bugs.webkit.org/show_bug.cgi?id=46024

  • platform/qt/fast/replaced/table-percent-height-expected.txt: Updated.
7:39 AM Changeset in webkit [67847] by krit@webkit.org
  • 55 edits in trunk/WebCore

2010-09-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter cleanup
​https://bugs.webkit.org/show_bug.cgi?id=45612


All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
their own. Working on it in a followup patch.
The subregions code is SVG specific and moving this calculation to FilterEffect is an
intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
The new FilterEffectVector will also make it possible to add code to determine the
smallest used region of an effect and will help save memory and resources in the future.
subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
renamed to repaintRectInLocalCoordinates since this is its proper meaning.
Removed unnecessary member variables and functions from FilterEffect.

No new tests added since the functionality didn't change.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
  • platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor. (WebCore::FEBlend::FEBlend): (WebCore::FEBlend::create): (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives. (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::FEColorMatrix): (WebCore::FEColorMatrix::create): (WebCore::FEColorMatrix::apply): (WebCore::FEColorMatrix::externalRepresentation):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::FEComponentTransfer): (WebCore::FEComponentTransfer::create): (WebCore::FEComponentTransfer::apply): (WebCore::FEComponentTransfer::externalRepresentation):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::FEComposite): (WebCore::FEComposite::create): (WebCore::FEComposite::apply): (WebCore::FEComposite::externalRepresentation):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::create): (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/Filter.h: (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation. (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now. (WebCore::FilterEffect::calculateDrawingRect): ditto. (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
  • platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.

Seperate SVG specific member variables and functions. Will get removed in followup patches.

(WebCore::FilterEffect::resultImage):
(WebCore::FilterEffect::setEffectBuffer):
(WebCore::FilterEffect::inputEffect):
(WebCore::FilterEffect::inputEffects):
(WebCore::FilterEffect::numberOfinputEffects):
(WebCore::FilterEffect::isAlphaImage):
(WebCore::FilterEffect::setIsAlphaImage):
(WebCore::FilterEffect::repaintRectInLocalCoordinates):
(WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
(WebCore::FilterEffect::isSourceInput):
(WebCore::FilterEffect::hasX):
(WebCore::FilterEffect::setHasX):
(WebCore::FilterEffect::hasY):
(WebCore::FilterEffect::setHasY):
(WebCore::FilterEffect::hasWidth):
(WebCore::FilterEffect::setHasWidth):
(WebCore::FilterEffect::hasHeight):
(WebCore::FilterEffect::setHasHeight):
(WebCore::FilterEffect::filterPrimitiveSubregion):
(WebCore::FilterEffect::setFilterPrimitiveSubregion):
(WebCore::FilterEffect::effectBoundaries):
(WebCore::FilterEffect::setEffectBoundaries):

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect. (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards. (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEComponentTransferElement.cpp: Ditto. (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFECompositeElement.cpp: Ditto. (WebCore::SVGFECompositeElement::build):
  • svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::build):
  • svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDisplacementMapElement.cpp: Ditto. (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEMergeElement.cpp: Ditto. (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMorphologyElement.cpp: Ditto. (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEOffsetElement.cpp: Ditto. (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFESpecularLightingElement.cpp: Ditto. (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFETileElement.cpp: Ditto. (WebCore::SVGFETileElement::build):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::FEConvolveMatrix): (WebCore::FEConvolveMatrix::create): (WebCore::FEConvolveMatrix::apply): (WebCore::FEConvolveMatrix::externalRepresentation):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto. (WebCore::FEDiffuseLighting::FEDiffuseLighting): (WebCore::FEDiffuseLighting::create): (WebCore::FEDiffuseLighting::externalRepresentation):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::FEDisplacementMap): (WebCore::FEDisplacementMap::create): (WebCore::FEDisplacementMap::apply): (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFELighting.cpp: Ditto. (WebCore::FELighting::FELighting): (WebCore::FELighting::apply):
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp: Ditto. (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::apply): (WebCore::FEMerge::externalRepresentation):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: Ditto. (WebCore::FEMorphology::FEMorphology): (WebCore::FEMorphology::create): (WebCore::FEMorphology::apply): (WebCore::FEMorphology::externalRepresentation):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: Ditto. (WebCore::FEOffset::FEOffset): (WebCore::FEOffset::create): (WebCore::FEOffset::apply): (WebCore::FEOffset::externalRepresentation):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto. (WebCore::FESpecularLighting::FESpecularLighting): (WebCore::FESpecularLighting::create): (WebCore::FESpecularLighting::externalRepresentation):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: Ditto. (WebCore::FETile::FETile): (WebCore::FETile::create): (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::FETile::apply): (WebCore::FETile::externalRepresentation):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::sourceImageRect):
7:28 AM CommitQueue edited by Patrick Gansterer
(diff)
6:23 AM Changeset in webkit [67846] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix forward includes generation for MSVC when sh is in PATH.

Reviewed by Simon Hausmann.

MSVC's nmake isn't affected by having sh in PATH.

  • Api/DerivedSources.pro:
6:13 AM Changeset in webkit [67845] by satish@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <​satish@chromium.org>

Unreviewed, updating baselines for a layout test and setting expectations for 3 others.

  • platform/chromium-linux/animations/animation-drt-api-expected.checksum: Added.
  • platform/chromium-linux/animations/animation-drt-api-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:42 AM Changeset in webkit [67844] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-09-20 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=45897

4:27 AM Changeset in webkit [67843] by satish@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <​satish@chromium.org>

Unreviewed, updating baselines for a layout test and adding 5 others to the skip list.

  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [67842] by Csaba Osztrogonác
  • 19 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r67660.

Paginate and column-break at layout time rather than when painting
​https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/repaint/multicol-repaint-expected.txt:
1:28 AM Changeset in webkit [67841] by pfeldman@chromium.org
  • 5 edits in branches/chromium/517/WebCore

Merge 67709 - 2010-09-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/3441018

12:10 AM Changeset in webkit [67840] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 James Kozianski <​koz@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Unskip the canvas philip suite
​https://bugs.webkit.org/show_bug.cgi?id=45991

Adds failing mac canvas/philip tests to test_expectations.txt.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.