Context Navigation

← Previous Period
Next Period →

Timeline

Sep 26, 2010:

11:24 PM Changeset in webkit [68373] by commit-queue@webkit.org

4 edits
4 adds in trunk

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

This test case fails on mac (see related bug 44713), which will
be fixed in a separate patch.

fast/frames/iframe-reparenting-adopt-node-expected.txt: Added.
fast/frames/iframe-reparenting-adopt-node.html: Added.
fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Added.
fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Added.
platform/mac/Skipped:

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

Test: fast/frames/iframe-reparenting-adopt-node.html

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): Update the webView for the frame to match the parent frame's webView.

11:11 PM Changeset in webkit [68372] by victorw@chromium.org

3 edits
2 deletes in trunk/LayoutTests

2010-09-26 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Update layout test notification-replace.html to be platform independent.

This layout test fails on windows if it is not running from C drive.
This is caused by local icon urls used by the test and this makes the
test becomes platform dependent. Change the icon urls so that the test
results are same for all platforms.

https://bugs.webkit.org/show_bug.cgi?id=45824

fast/notifications/notifications-replace-expected.txt:
fast/notifications/notifications-replace.html:
platform/chromium-linux/fast/notifications: Removed.
platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Removed.
platform/chromium-win/fast/notifications: Removed.
platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Removed.

11:05 PM Changeset in webkit [68371] by Patrick Gansterer

4 edits
1 delete in trunk/WebCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove dead code and fix header includes in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46479

Also add missing member varibale from r68167.

platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onRequestComplete):
platform/network/win/ResourceHandleWin.h: Removed.

10:59 PM Changeset in webkit [68370] by andreip@google.com

2 edits in trunk/LayoutTests

2010-09-26 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

[Chromium] storage/indexeddb/transaction-basics.html is expected to fail but actually passes.
https://bugs.webkit.org/show_bug.cgi?id=46484

platform/chromium/test_expectations.txt:

10:28 PM Changeset in webkit [68369] by Patrick Gansterer

5 edits in trunk

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

wtf/StringHashFunctions.h: (WTF::StringHasher::createBlobHash):

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
dom/QualifiedName.h: (WebCore::hashComponents): (WebCore::QualifiedNameHash::hash):

10:09 PM Changeset in webkit [68368] by Patrick Gansterer

2 edits in trunk/JavaScriptCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

REGRESSION (r68289): Assertion failure in StringHasher::addCharacter() (ch != invalidCharacterValue)
running websocket/tests/bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/show_bug.cgi?id=46553

Because we use StringHasher for binary data too, so the check for invalid unicode input is wrong.
Add an additional member variable to indicate if we have an pending character
instead of only using an invalid character for this purpose.

wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash):

9:56 PM Changeset in webkit [68367] by mihaip@chromium.org

2 edits in trunk/WebKit/chromium

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Remove no longer used WebView member functions
https://bugs.webkit.org/show_bug.cgi?id=46515

With http://crrev.com/60526 there's no longer any Chromium code calling
the non-static versions of addUserScript and addUserStyleSheet.

public/WebView.h:

9:35 PM Changeset in webkit [68366] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2010-09-26 Shane Stephens <shanestephens@google.com>

Reviewed by Adam Barth.

[Chromium] Test expectations update to green canary bots.
https://bugs.webkit.org/show_bug.cgi?id=46604

https://bugs.webkit.org/show_bug.cgi?id=46596 and
https://bugs.webkit.org/show_bug.cgi?id=46597

platform/chromium/test_expectations.txt:

7:58 PM Changeset in webkit [68365] by mihaip@chromium.org

3 edits in trunk/WebKitTools

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-httpd fails if Perl is not installed
https://bugs.webkit.org/show_bug.cgi?id=46602

Make Port._read_configuration catch all exceptions, since trying to run
perl (because of _webkit_build_directory) when it's not installed throws
a WindowsError or OSError, not an IOError (this became an issue after
r68268, since ChromiumPort ends up calling Port.default_configuration in
its constructor, which means that we're ending up on this codepath in
non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
new-run-webkit-httpd).

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:

7:53 PM Changeset in webkit [68364] by weinig@apple.com

3 edits in trunk/WebKit2

MiniBrowser crashes when opening main menu item
https://bugs.webkit.org/show_bug.cgi?id=46588

Reviewed by Simon Fraser.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setEditCommandState): Don't allow default
String -> NSString conversion to take place, and use the increasingly
misnamed nsStringFromWebCoreString instead.

7:43 PM Changeset in webkit [68363] by commit-queue@webkit.org

5 edits in trunk

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_setting_local_storage_database_path_get): Added. (ewk_view_setting_local_storage_database_path_set): Added.
ewk/ewk_view.h:

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

EWebLauncher/main.c: (on_key_down): (browserCreate): (main):

7:09 PM Changeset in webkit [68362] by hyatt@apple.com

13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46519

Reviewed by Sam Weinig.

Convert the implementation of computeLogicalWidth to work with block-flow.

WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
Patched to call the new computeMarginsInContainingBlockInlineDirection. Eventually determineHorizontalPosition will
be placing children along the inline direction of the containing block, and those children may have mismatched
block flows. The new computeMarginsInContainingBlockInlineDirection function is designed to handle that.

rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginStartUsing):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::marginEndUsing):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginStartUsing):
(WebCore::RenderBox::setMarginEndUsing):
Helpers that allow for marginStart/End access and that also allow for marginStart/End to be computed based off another
element's block-flow and direction (typically the containing block).

(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
Patched to use logical border/padding widths and heights.

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
A function for returning the available logical height of a perpendicular containing block. If a child has vertical
text for example and its block-flow is "lr", its available logical width is determined by the logical
height of the containing block when that containing block is perpendicular, e.g. "tb".

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
Patched to be block-flow-aware and to use logical width values everywhere.

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
Patched to use logical widths.

(WebCore::RenderBox::computeMarginsInContainingBlockInlineDirection):
A new function that is directionally abstract and that can handle the computation of margins in the containing
block's inline direction. This function is written such that a perpendicular child block flow can still be
pushed to the center, left or right in the containing block's inline direction.

(WebCore::RenderBox::computePositionedLogicalWidth):
This function is still largely unpatched. A future patch will address positioend elements.

rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToMinIntrinsicLogicalWidth):

rendering/RenderFieldset.h:

(WebCore::RenderFieldset::stretchesToMinIntrinsicLogicalWidth):
Renames.

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Renames, but not converted yet. Tables will happen in a future patch.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):

rendering/style/RenderStyle.h:

Added helpers for accessing marginStart and End using another style's direction and block flow (typically will
be the containing block's).

fast/block/basic/016.html changed, since centering now always awards the extra pixel for odd widths to the end margin
instead of the right margin. This is a progression.

fast/css/logical-property-values.html is now reporting garbage results, which is expected now that some of the core layout
functions have been patched.

Horizontal block flows are untestable still, since the normal layout process incorrectly blows away any computed height values.

LayoutTests:

fast/css/logical-property-resolution-expected.txt:
platform/mac/fast/block/basic/016-expected.checksum:
platform/mac/fast/block/basic/016-expected.png:
platform/mac/fast/block/basic/016-expected.txt:

6:56 PM Changeset in webkit [68361] by weinig@apple.com

2 edits in trunk/WebKit2

Another windows build fix windows attempt.

win/WebKit2Common.vsprops:

6:47 PM Changeset in webkit [68360] by weinig@apple.com

2 edits in trunk/WebKit2

Another windows build fix windows attempt.

win/WebKit2Generated.make:

6:34 PM Changeset in webkit [68359] by weinig@apple.com

2 edits in trunk/WebKit2

Attempt to fix windows build.

win/WebKit2Common.vsprops:

6:31 PM Changeset in webkit [68358] by weinig@apple.com

2 edits in trunk/WebKit2

Attempt to fix Qt build.

WebKit2.pro:

6:22 PM Changeset in webkit [68357] by weinig@apple.com

19 edits
6 copies
33 moves
4 adds
2 deletes in trunk

Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=46587

Reviewed by Anders Carlsson.

WebKit2:

Moves shared types (WKArrayRef, WKDictionaryRef, etc) to Shared/API/c.
Removes WKBundleBase.h and moves all opaque type declarations to WKBase.h (which moves to Shared/API/c).
Adds WKSharedAPICast.h which includes shared API casting logic and is included by both WKAPICast.h and WKBundleAPICast.h now. Moved to using macros for API mappings to reduce verbosity.
Move windows c API files from UIProcess/API/win to UIProcess/API/C/win.

Shared/API: Added.
Shared/API/c: Added.
Shared/API/c/WKArray.cpp: Copied from UIProcess/API/C/WKArray.cpp.
Shared/API/c/WKArray.h: Copied from UIProcess/API/C/WKArray.h.
Shared/API/c/WKBase.h: Copied from UIProcess/API/C/WKBase.h.
Shared/API/c/WKCertificateInfo.cpp: Copied from UIProcess/API/C/WKCertificateInfo.cpp.
Shared/API/c/WKCertificateInfo.h: Copied from UIProcess/API/C/WKCertificateInfo.h.
Shared/API/c/WKData.cpp: Copied from UIProcess/API/C/WKData.cpp.
Shared/API/c/WKData.h: Copied from UIProcess/API/C/WKData.h.
Shared/API/c/WKDictionary.cpp: Copied from UIProcess/API/C/WKDictionary.cpp.
Shared/API/c/WKDictionary.h: Copied from UIProcess/API/C/WKDictionary.h.
Shared/API/c/WKError.cpp: Copied from UIProcess/API/C/WKError.cpp.
Shared/API/c/WKError.h: Copied from UIProcess/API/C/WKError.h.
Shared/API/c/WKMutableArray.cpp: Copied from UIProcess/API/C/WKMutableArray.cpp.
Shared/API/c/WKMutableArray.h: Copied from UIProcess/API/C/WKMutableArray.h.
Shared/API/c/WKMutableDictionary.cpp: Copied from UIProcess/API/C/WKMutableDictionary.cpp.
Shared/API/c/WKMutableDictionary.h: Copied from UIProcess/API/C/WKMutableDictionary.h.
Shared/API/c/WKNumber.cpp: Copied from UIProcess/API/C/WKNumber.cpp.
Shared/API/c/WKNumber.h: Copied from UIProcess/API/C/WKNumber.h.
Shared/API/c/WKSerializedScriptValue.cpp: Copied from UIProcess/API/C/WKSerializedScriptValue.cpp.
Shared/API/c/WKSerializedScriptValue.h: Copied from UIProcess/API/C/WKSerializedScriptValue.h.
Shared/API/c/WKSharedAPICast.h: Copied from UIProcess/API/C/WKAPICast.h.
Shared/API/c/WKString.cpp: Copied from UIProcess/API/C/WKString.cpp.
Shared/API/c/WKString.h: Copied from UIProcess/API/C/WKString.h.
Shared/API/c/WKType.cpp: Copied from UIProcess/API/C/WKType.cpp.
Shared/API/c/WKType.h: Copied from UIProcess/API/C/WKType.h.
Shared/API/c/WKURL.cpp: Copied from UIProcess/API/C/WKURL.cpp.
Shared/API/c/WKURL.h: Copied from UIProcess/API/C/WKURL.h.
Shared/API/c/WKURLRequest.cpp: Copied from UIProcess/API/C/WKURLRequest.cpp.
Shared/API/c/WKURLRequest.h: Copied from UIProcess/API/C/WKURLRequest.h.
Shared/API/c/WKURLResponse.cpp: Copied from UIProcess/API/C/WKURLResponse.cpp.
Shared/API/c/WKURLResponse.h: Copied from UIProcess/API/C/WKURLResponse.h.
Shared/API/c/cf: Copied from UIProcess/API/C/cf.
Shared/API/c/mac: Copied from UIProcess/API/C/mac.
Shared/API/c/win: Added.
Shared/API/c/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
Shared/API/c/win/WKCertificateInfoWin.cpp: Copied from UIProcess/API/C/win/WKCertificateInfoWin.cpp.
Shared/API/c/win/WKCertificateInfoWin.h: Copied from UIProcess/API/C/win/WKCertificateInfoWin.h.
UIProcess/API/C/WKAPICast.h: Replaced.
UIProcess/API/C/WKArray.cpp: Removed.
UIProcess/API/C/WKArray.h: Removed.
UIProcess/API/C/WKBase.h: Removed.
UIProcess/API/C/WKCertificateInfo.cpp: Removed.
UIProcess/API/C/WKCertificateInfo.h: Removed.
UIProcess/API/C/WKData.cpp: Removed.
UIProcess/API/C/WKData.h: Removed.
UIProcess/API/C/WKDictionary.cpp: Removed.
UIProcess/API/C/WKDictionary.h: Removed.
UIProcess/API/C/WKError.cpp: Removed.
UIProcess/API/C/WKError.h: Removed.
UIProcess/API/C/WKMutableArray.cpp: Removed.
UIProcess/API/C/WKMutableArray.h: Removed.
UIProcess/API/C/WKMutableDictionary.cpp: Removed.
UIProcess/API/C/WKMutableDictionary.h: Removed.
UIProcess/API/C/WKNumber.cpp: Removed.
UIProcess/API/C/WKNumber.h: Removed.
UIProcess/API/C/WKSerializedScriptValue.cpp: Removed.
UIProcess/API/C/WKSerializedScriptValue.h: Removed.
UIProcess/API/C/WKString.cpp: Removed.
UIProcess/API/C/WKString.h: Removed.
UIProcess/API/C/WKType.cpp: Removed.
UIProcess/API/C/WKType.h: Removed.
UIProcess/API/C/WKURL.cpp: Removed.
UIProcess/API/C/WKURL.h: Removed.
UIProcess/API/C/WKURLRequest.cpp: Removed.
UIProcess/API/C/WKURLRequest.h: Removed.
UIProcess/API/C/WKURLResponse.cpp: Removed.
UIProcess/API/C/WKURLResponse.h: Removed.
UIProcess/API/C/cf: Removed.
UIProcess/API/C/cf/WKStringCF.cpp: Removed.
UIProcess/API/C/cf/WKStringCF.h: Removed.
UIProcess/API/C/cf/WKURLCF.cpp: Removed.
UIProcess/API/C/cf/WKURLCF.h: Removed.
UIProcess/API/C/cf/WKURLRequestCF.cpp: Removed.
UIProcess/API/C/cf/WKURLRequestCF.h: Removed.
UIProcess/API/C/cf/WKURLResponseCF.cpp: Removed.
UIProcess/API/C/cf/WKURLResponseCF.h: Removed.
UIProcess/API/C/mac: Removed.
UIProcess/API/C/mac/WKCertificateInfoMac.h: Removed.
UIProcess/API/C/mac/WKCertificateInfoMac.mm: Removed.
UIProcess/API/C/mac/WKURLRequestNS.h: Removed.
UIProcess/API/C/mac/WKURLRequestNS.mm: Removed.
UIProcess/API/C/mac/WKURLResponseNS.h: Removed.
UIProcess/API/C/mac/WKURLResponseNS.mm: Removed.
UIProcess/API/C/win/WKAPICastWin.h: Copied from UIProcess/API/win/WKAPICastWin.h.
UIProcess/API/C/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
UIProcess/API/C/win/WKCertificateInfoWin.cpp: Removed.
UIProcess/API/C/win/WKCertificateInfoWin.h: Removed.
UIProcess/API/C/win/WKView.cpp: Copied from UIProcess/API/win/WKView.cpp.
UIProcess/API/C/win/WKView.h: Copied from UIProcess/API/win/WKView.h.
UIProcess/API/win: Removed.
UIProcess/API/win/WKAPICastWin.h: Removed.
UIProcess/API/win/WKBaseWin.h: Removed.
UIProcess/API/win/WKView.cpp: Removed.
UIProcess/API/win/WKView.h: Removed.
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
WebProcess/InjectedBundle/API/c/WKBundleBase.h: Removed.
WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h:
WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

WebKitTools:

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

5:23 PM Changeset in webkit [68356] by tonikitoo@webkit.org

16 edits in trunk

[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580

Patch by Antonio Gomes <agomes@rim.comg> on 2010-09-26
Reviewed by Kenneth Christiansen.

WebCore:

Symbol files updated.

WebCore.exp.in: Added symbols to Document::nodesFromRect and bits of JSDocument now

needed in WebKit/mac.

WebCore.xcodeproj/project.pbxproj: Set both JSDocument.h and JSNodeList as private headers

now that they are referred in WebKit/mac.

WebKit/mac:

Implement nodesFromRect as a private method to access non-exposed Document
methods, similarly to computedStyleIncludingVisitedInfo.

WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.

These headers makes it possible to:
1) Get a Document off of a JSDocument;
2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
gotten from Document::nodesFromRect to JS bindings.
(-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):

WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the

Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.

WebKitTools:

Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.

DumpRenderTree/LayoutTestController.cpp:

(nodesFromRectCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController::LayoutTestController::nodesFromRect):

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::nodesFromRect):

LayoutTests:

Unskipping fast/dom/nodesFromRect-based.html on Mac, and changes it
so that it calls layoutTestController.nodesFromRect() instead of
document.nodesFromRect().

fast/dom/resources/nodesFromRect.js:

(check):

platform/mac/Skipped:

3:59 PM Changeset in webkit [68355] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-09-26 Adam Barth <abarth@webkit.org>

Rebaseline Qt results.

platform/qt/fast/dom/Window/window-properties-expected.txt:

3:22 PM Changeset in webkit [68354] by abarth@webkit.org

11 edits
4 adds in trunk

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

Test the origin attribute of Location and HTMLAnchorElement.

fast/dom/anchor-origin-expected.txt: Added.
fast/dom/anchor-origin.html: Added.
http/tests/misc/location-origin-expected.txt: Added.
http/tests/misc/location-origin.html: Added.

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

These attributes are part of my proposed URL API:
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en

Hixie thought we should implement as much of this API as makes sense on
Location and HTMLAnchorElement as well. I'm starting with the origin
attribute, because that seems like the biggest bang for the buck.

Tests: fast/dom/anchor-origin.html

http/tests/misc/location-origin.html

WebCore.xcodeproj/project.pbxproj:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::origin):
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:
page/Location.cpp: (WebCore::Location::origin):
page/Location.h:
page/Location.idl:

3:11 PM Changeset in webkit [68353] by andersca@apple.com

3 edits in trunk/WebKit2

Fix non-Mac builds.

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::isNull):

2:48 PM Changeset in webkit [68352] by andersca@apple.com

3 edits in trunk/WebKit2

Make it possible to encode null SharedMemory::Handle objects
https://bugs.webkit.org/show_bug.cgi?id=46585

Reviewed by Sam Weinig.

Platform/SharedMemory.h:

(WebKit::SharedMemory::Handle::isNull):
Add isNull.

Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):
Remove asserts.

(WebKit::SharedMemory::create):
Bail if we see a null handle. Also work around a kernel bug where
mach_vm_map fails if the given address to map is already mapped, even if
VM_FLAG_ANYWHERE is set.

2:48 PM Changeset in webkit [68351] by andersca@apple.com

2 edits
3 adds in trunk/WebKit2

Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=46584

Reviewed by Sam Weinig.

Shared/BackingStore.cpp: Added.

(WebKit::BackingStore::create):
Create a backing store backed by fastMalloc memory.

(WebKit::BackingStore::createSharable):
Create a backing store backed by shared memory.

(WebKit::BackingStore::createHandle):
Create a handle that can be sent over the wire.

(WebKit::BackingStore::resize):
Resize the backing store memory.

(WebKit::BackingStore::data):
Return the backing store data.

Shared/mac/BackingStoreMac.mm: Added.

(WebKit::BackingStore::createGraphicsContext):
Create a graphics context that will paint into the backing store.

(WebKit::BackingStore::paint):
Paint the backing store in a graphics context.

WebKit2.xcodeproj/project.pbxproj:

Add files.

2:48 PM Changeset in webkit [68350] by andersca@apple.com

11 edits in trunk/WebKit2

Establish a connection between the plug-in process and the web process
https://bugs.webkit.org/show_bug.cgi?id=46583

Reviewed by Sam Weinig.

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

PluginProcess/PluginProcess.h:

Add didReceivePluginProcessMessage declaration.

PluginProcess/PluginProcess.messages.in:

Add new "CreateWebProcessConnection" message.

PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection):
Ask the plug-in process proxy to create a connection.

UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::createWebProcessConnection):
Add the WebProcessProxy and the reply encoder to the queue of pending replies.
If the process is still launching, keep track of how many pending requests we have, otherwise
just send the request.

(WebKit::PluginProcessProxy::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

(WebKit::PluginProcessProxy::didFinishLaunching):
Send all pending connection requests.

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Get the first pending reply and send it with the mach port.

WebKit2.xcodeproj/project.pbxproj:

Actually compile PluginProcessMessageReceiver.

WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
Create a CoreIPC connection.

(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Ask the plug-in process connection manager for a connection.

2:47 PM Changeset in webkit [68349] by andersca@apple.com

3 edits in trunk/WebKit2

Generated message handlers should include argument coder headers for some types
https://bugs.webkit.org/show_bug.cgi?id=46582

Reviewed by Sam Weinig.

Scripts/webkit2/messages.py:

When determining which headers to use when generating a message handler, consider the
argument coder headers.

Scripts/webkit2/messages_unittest.py:

Update test result.

2:38 PM Changeset in webkit [68348] by commit-queue@webkit.org

5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the bug where the arguments to atan2 were being evaluated
out of order.

runtime/MathObject.cpp: (JSC::mathProtoFuncATan2):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Regression test for the issue where the arguments to atan2 were
evaluated out of order.

fast/js/math-expected.txt:
fast/js/script-tests/math.js: (v.valueOf): (w.valueOf):

2:26 PM Changeset in webkit [68347] by commit-queue@webkit.org

5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the issue where the parameters to the Date constructor
were being evaluated to numbers more than once.

runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateUTC):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Added regression test for the Date constructor issue.

fast/js/date-constructor-expected.txt:
fast/js/script-tests/date-constructor.js: (year.valueOf): (month.valueOf): (date.valueOf): (hours.valueOf): (minutes.valueOf): (seconds.valueOf): (ms.valueOf):

12:21 PM Changeset in webkit [68346] by andreas.kling@nokia.com

3 edits
3 deletes in trunk

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

fast/canvas/canvas-font-ex-units-crash-expected.txt: Removed.
fast/canvas/canvas-font-ex-units-crash.html: Removed.
fast/canvas/script-tests/canvas-font-ex-units-crash.js: Removed.

12:00 PM Changeset in webkit [68345] by tonikitoo@webkit.org

9 edits in trunk

document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

fast/dom/Window/window-properties-expected.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/win/Skipped:

10:45 AM Changeset in webkit [68344] by commit-queue@webkit.org

4 edits
30 adds in trunk

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464
Adding layout tests for feBlend dynamic changes.

platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added. (executeTest):
svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added. (executeTest):
svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added. (executeTest):
svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added. (executeTest):
svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added. (executeTest):
svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added. (executeTest):

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464

Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html

svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html

svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::svgAttributeChanged):
svg/SVGFEBlendElement.h:

10:39 AM Changeset in webkit [68343] by andreas.kling@nokia.com

3 edits
3 adds in trunk

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)

Fixes crash on IE test center's canvas-text-font-002 test.

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
fast/canvas/canvas-font-ex-units-crash.html: Added.
fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.

10:25 AM Changeset in webkit [68342] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-09-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't pass PassOwnPtr in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=42058

Change makeAllDirectories to take a raw FileMgr pointer
because it is not safe to pass PassOwnPtr recursively.

platform/brew/FileSystemBrew.cpp: (WebCore::makeAllDirectories):

6:12 AM Changeset in webkit [68341] by robert@webkit.org

4 edits in trunk

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

platform/qt/Skipped:

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::encode):

Sep 25, 2010:

10:56 PM Changeset in webkit [68340] by inferno@chromium.org

3 edits
2 adds in trunk

2010-09-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix the macro to bail out after setting the SVG style to 'initial'. Check that color is
SVGColor before calling colorFromSVGColorCSSValue which makes sure we don't set invalid
color. Also, doing the static cast in the caller and keeping the function
colorFromSVGColorCSSValue clean to accept only take SVGColor objects.

https://bugs.webkit.org/show_bug.cgi?id=46471

Test: svg/css/invalid-color-crash.svg

css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty):

2010-09-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests that we dont crash when setting color to initial for SVG.
https://bugs.webkit.org/show_bug.cgi?id=46471

svg/css/invalid-color-crash-expected.txt: Added.
svg/css/invalid-color-crash.svg: Added.

3:57 PM Changeset in webkit [68339] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Relearning the lesson that last minute changes are bad.

2:42 PM Changeset in webkit [68338] by oliver@apple.com

11 edits in trunk/JavaScriptCore

2010-09-25 Oliver Hunt <oliver@apple.com>

Reviewed by Cameron Zwarich.

Avoid constructing arguments object when accessing length and index properties
https://bugs.webkit.org/show_bug.cgi?id=46572

Add opcodes to read argument length and properties, and then implement them.
Much like other lazy opcodes these opcodes take a fast path when the arguments
object has not been instantiated, and fall back on generic access mechanisms
if they are acting on an instantiated object.

3% win on v8-earleyboyer, no change elsewhere.

bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetArgumentsLength): (JSC::BytecodeGenerator::emitGetArgumentByVal):
bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp: (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode):
interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
jit/JIT.h:
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):

1:42 PM Changeset in webkit [68337] by rniwa@webkit.org

3 edits in trunk/WebCore

2010-09-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

FormatBlockCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=46504

Isolated the code in doApply to insert and remove lists for single paragraph into doApplyForSingleParagraph.
Merged the code in modifyRange into doApply and cleaned up.

No new tests are added since this is a cleanup.

editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Merged with modifyRange; calls doApplyForSingleParagraph. (WebCore::FormatBlockCommand::doApplyForSingleParagraph): Added.
editing/FormatBlockCommand.h:

11:09 AM Changeset in webkit [68336] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-09-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium drt_expectations.txt update.

Speech input appearance tests have image diffs on Linux too.

platform/chromium/drt_expectations.txt:

10:34 AM Changeset in webkit [68335] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/8478160> Null deref in InlineBox::height()
https://bugs.webkit.org/show_bug.cgi?id=45344

Reviewed by John Sullivan.

WebCore:

Test: fast/css/first-line-parent-style-different.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::firstLineStyleSlowCase): Set the pseudo style bit on the RenderStyle
which is going to supply the first-line style rather than on this object’s RenderStyle. The
styles may differ.

LayoutTests:

fast/css/first-line-parent-style-different-expected.txt: Added.
fast/css/first-line-parent-style-different.html: Added.

10:30 AM Changeset in webkit [68334] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/8478182> Make canHyphenate() return false for unsupported locales

Reviewed by John Sullivan.

No change in functionality, hence no new test.

platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForKey): Return 0 if hyphenation is not available for the locale.
(WebCore::cfLocaleCache): Moved the definition of the cache from lastHyphenLocation() to
this new getter to allow canHyphenate() to share it.
(WebCore::canHyphenate): Now returns true only if hyphenation is available.
(WebCore::lastHyphenLocation): Added an assertion.

10:01 AM Changeset in webkit [68333] by thakis@chromium.org