⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 29, 2010:

11:52 PM Changeset in webkit [68758] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-29 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Rebaseline image-rescale.svg results for chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=46818

  • platform/chromium-win/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
  • platform/chromium-win/svg/custom/image-rescale-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.png.
  • platform/chromium/test_expectations.txt:
11:49 PM Changeset in webkit [68757] by crogers@google.com
  • 3 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Put default initialize() and uninitialize() methods in AudioNode
​https://bugs.webkit.org/show_bug.cgi?id=46767

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: (WebCore::AudioNode::initialize): (WebCore::AudioNode::uninitialize):
  • webaudio/AudioNode.h:
11:34 PM Changeset in webkit [68756] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Adam Barth <​abarth@webkit.org>

Unreviewed. See comments in the Skipped file.

  • platform/mac/Skipped:
11:29 PM Changeset in webkit [68755] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch find-flaky-tests
​https://bugs.webkit.org/show_bug.cgi?id=46876

This command helps us find flaky tests so we can squash them.

  • Scripts/webkitpy/tool/commands/queries.py:
11:26 PM Changeset in webkit [68754] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/plugin-document-load-prevented-userscript.html on Qt, because it doesn't
support window.layoutTestController.addUserScript yet.

Rubber-stamped by Adam Barth.

  • platform/qt/Skipped:
11:24 PM Changeset in webkit [68753] by alex
  • 2 edits in trunk/LayoutTests

2010-09-29 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, LayoutTestController::addUserScript not supported in
GTK+, skip plugin-document-load-prevented-userscript.html.

  • platform/gtk/Skipped:
10:56 PM Changeset in webkit [68752] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
10:27 PM Changeset in webkit [68751] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Fix export to use '?' instead of 'null' for
tests with no results.

  • CSSTestSuiteHarness/harness/harness.js:
9:41 PM Changeset in webkit [68750] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [68749] by tkent@chromium.org
  • 6 edits in trunk

2010-09-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
​https://bugs.webkit.org/show_bug.cgi?id=46791

No new tests because this doesn't change any behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createTypeMap):
  • html/HTMLInputElement.h: Move DeprecatedInputType, deprecatedInputType() and parseToDateComponents() to the private section, make createTypeMap() a member function of HTMLInputElement. (WebCore::HTMLInputElement::deprecatedInputType):

2010-09-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
​https://bugs.webkit.org/show_bug.cgi?id=46791

  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Accept any text field types as a username field.
  • src/WebSearchableFormData.cpp: (WebCore::HasSuitableTextElement): Accept any text field types as a search query field.
9:14 PM Changeset in webkit [68748] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.

  • CSSTestSuiteHarness/harness/harness.css:
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.processFlags):
9:07 PM Changeset in webkit [68747] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove revisions_casuing_failures
​https://bugs.webkit.org/show_bug.cgi?id=46872

This function exists only to be unit tested.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:57 PM Changeset in webkit [68746] by abarth@webkit.org
  • 12 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should post the list of failing tests to bugs
​https://bugs.webkit.org/show_bug.cgi?id=46871

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:42 PM Changeset in webkit [68745] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <​eric@webkit.org>

Unreviewed. Skipping crashing test to green the tree.
This crash started when I skipped some canvas tests
as part of rolling out r68568.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/mac-snowleopard/Skipped:
8:33 PM Changeset in webkit [68744] by bfulgham@webkit.org
  • 5 edits in trunk/WebKitTools

[WinCairo] Adds a build slave.
​https://bugs.webkit.org/show_bug.cgi?id=46360

Patch by Brent Fulgham <​bfulgham@webkit.org> on 2010-09-29
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add

entries for a debug build of the WinCairo port.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add

platform flag to configuration for wincairo (like gtk, chromium, etc.)

  • Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
  • Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
8:27 PM Changeset in webkit [68743] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
8:06 PM Changeset in webkit [68742] by mihaip@chromium.org
  • 5 edits
    4 adds in trunk

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
​https://bugs.webkit.org/show_bug.cgi?id=46324

Add test which uses pushState to generate history entries while also
changing the frames that are present in the document between history
states. Add a similar test that uses fragment changes.

  • fast/history/same-document-iframes-changing-fragment-expected.txt: Added.
  • fast/history/same-document-iframes-changing-fragment.html: Added.
  • fast/history/same-document-iframes-changing-pushstate-expected.txt: Added.
  • fast/history/same-document-iframes-changing-pushstate.html: Added.

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
​https://bugs.webkit.org/show_bug.cgi?id=46324

Revert same document check to the way it was before r66238 for history
entries created by pushState or fragment changes. Logic fror determining
if same document navigation should be used is moved to HistoryItem.

Tests: fast/history/same-document-iframes-changing-fragment.html

fast/history/same-document-iframes-changing-pushstate.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::shouldDoSameDocumentNavigationTo): (WebCore::HistoryItem::hasSameDocumentTree): (WebCore::HistoryItem::hasSameFrames):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
8:01 PM Changeset in webkit [68741] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add removeRecursively to WebKit WebFileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=46842

  • public/WebFileSystem.h: (WebKit::WebFileSystem::removeRecursively): Added.
7:53 PM Changeset in webkit [68740] by abarth@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move more SheriffBot smarts into FailureMap
​https://bugs.webkit.org/show_bug.cgi?id=46703

This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.

Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:49 PM Changeset in webkit [68739] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

2010-09-29 Adam Barth <​abarth@webkit.org>

This test result seems to be platform specific.

  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt: Renamed from LayoutTests/plugins/plugin-initiate-popup-window-expected.txt.
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt: Added.
7:34 PM Changeset in webkit [68738] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

WebCore::ESpeak causes missing symbol with no ENABLE_SVG
​https://bugs.webkit.org/show_bug.cgi?id=46865

Moves ESpeak related function definitions outside ENABLE_SVG block.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ESpeak): (WebCore::CSSPrimitiveValue::operator EVectorEffect):
7:24 PM Changeset in webkit [68737] by eric@webkit.org
  • 71 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r68568.
​http://trac.webkit.org/changeset/68568
​https://bugs.webkit.org/show_bug.cgi?id=46439

Failing tests on both Leopard and Snow Leopard

  • canvas/philip/tests/2d.composite.operation.darker-expected.txt:
  • canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
  • canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
  • canvas/philip/tests/2d.drawImage.null-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • canvas/philip/tests/2d.missingargs-expected.txt:
  • canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • canvas/philip/tests/2d.pattern.image.null-expected.txt:
  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • canvas/philip/tests/type.prototype-expected.txt:
  • platform/mac/Skipped:
6:27 PM Changeset in webkit [68736] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelSplitter files
​https://bugs.webkit.org/show_bug.cgi?id=46290

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelSplitter.cpp: Added. (WebCore::AudioChannelSplitter::AudioChannelSplitter): (WebCore::AudioChannelSplitter::process): (WebCore::AudioChannelSplitter::reset):
  • webaudio/AudioChannelSplitter.h: Added. (WebCore::AudioChannelSplitter::create):
  • webaudio/AudioChannelSplitter.idl: Added.
6:16 PM Changeset in webkit [68735] by kinuko@chromium.org
  • 15 edits
    5 adds in trunk

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadDirectory):

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

Test: fast/filesystem/read-directory.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::readDirectory): Changed to take DirectoryReader as a parameter.
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback): Added.
  • fileapi/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added initializer for m_hasMore flag. (WebCore::DirectoryReader::readEntries): Changed to schedule EntriesCallback with an empty array if m_hasMore flag is set false.
  • fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem): Added. (WebCore::DirectoryReader::setHasMore): Added.
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): (WebCore::EntriesCallbacks::EntriesCallbacks): Changed to take DirectoryReader as a parameter. (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries): Changed 1) not to trigger the second callback when hasMore is false, and 2) to update the DirectoryReader's m_hasMore flag.
  • fileapi/FileSystemCallbacks.h:

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

  • fast/filesystem/flags-passing.html: Updated to make it match with the updated TEMPLATE.html.
  • fast/filesystem/flags-passing-expected.txt: Updated.
  • fast/filesystem/read-directory.html: Added.
  • fast/filesystem/read-directory-expected.txt: Added.
  • fast/filesystem/resources/fs-test-util.js: Added for common test utilities.
  • fast/filesystem/script-tests/TEMPLATE.html: Updated to include fs-test-util.js.
  • fast/filesystem/script-tests/flags-passing.js: Updated to use jsTestIsAsync and finishJSTest (so that all the tests look alike).
  • fast/filesystem/script-tests/read-directory.js: Added.
6:12 PM Changeset in webkit [68734] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioGainNode files
​https://bugs.webkit.org/show_bug.cgi?id=46286

No new tests since audio API is not yet implemented.

  • webaudio/AudioGainNode.cpp: Added. (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process): (WebCore::AudioGainNode::reset): (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
  • webaudio/AudioGainNode.h: Added. (WebCore::AudioGainNode::create): (WebCore::AudioGainNode::gain):
  • webaudio/AudioGainNode.idl: Added.
6:07 PM Changeset in webkit [68733] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated expectations.

  • platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
  • platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
5:55 PM Changeset in webkit [68732] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelMerger files
​https://bugs.webkit.org/show_bug.cgi?id=46291

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelMerger.cpp: Added. (WebCore::AudioChannelMerger::AudioChannelMerger): (WebCore::AudioChannelMerger::process): (WebCore::AudioChannelMerger::reset):
  • webaudio/AudioChannelMerger.h: Added. (WebCore::AudioChannelMerger::create):
  • webaudio/AudioChannelMerger.idl: Added.
5:45 PM Changeset in webkit [68731] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Calling Connection::send/sendSync from Connection::Client::didClose should always fail
​https://bugs.webkit.org/show_bug.cgi?id=46859
<rdar://problem/8212583>

Reviewed by Simon Fraser.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchConnectionDidClose):

5:31 PM Changeset in webkit [68730] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. Missed file for patch.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

5:30 PM Changeset in webkit [68729] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68340.

5:14 PM Changeset in webkit [68728] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

No review. Update layout tests after new CSS property.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
5:11 PM Changeset in webkit [68727] by enrica@apple.com
  • 2 edits in trunk/WebCore

Crash at lineBreakExistsAtPosition + 125
<rdar://problem/7028809>
​https://bugs.webkit.org/show_bug.cgi?id=46770

Reviewed by Darin Adler.

lineBreakExistsAtPosition is called from InsertTextCommand::input,
where we compute the downstream position of the endingSelection().
Downstream can return the original position, that comes from a VisibleSelection
but there is no guarantee that its renderer is still there. Everywhere we dereference
a renderer we check if it's null.

There is no regression test.

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition): Added check that the renderer is not null
before dereferencing it.

5:10 PM Changeset in webkit [68726] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-09-29 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Assertion then crash closing WebKit2 window with accelerated compositing in
​https://bugs.webkit.org/show_bug.cgi?id=46857

Fix two issues when closing a WebKit2 window using accelerated
compositing.

The first is that the response to the sync DidChangeAcceleratedCompositing message
sent by changeAcceleratedCompositingMode() may be empty, because the corresponding
page may have been destroyed already in the UI process. In that case newDrawingAreaInfo
is not filled in, so we get a DrawingArea::Type of None. Don't attempt to make a new
drawing area in that case.

We then have to null-check the drawing area in WebPage::didReceiveMessage(),
in the case where the UI process is calling back with a SuspendPainting message,
before our page has gone away.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::didReceiveMessage):
5:10 PM Changeset in webkit [68725] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r66028.

5:08 PM Changeset in webkit [68724] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r67288.

5:08 PM Changeset in webkit [68723] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r67286.

5:08 PM Changeset in webkit [68722] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-533.19-branch

Merge r67285.

5:00 PM Changeset in webkit [68721] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68278.

4:59 PM Changeset in webkit [68720] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68158.

4:57 PM Changeset in webkit [68719] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68485.

4:55 PM Changeset in webkit [68718] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68408.

4:52 PM Changeset in webkit [68717] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-533.19-branch

Merge r64780.

4:52 PM Changeset in webkit [68716] by andersca@apple.com
  • 5 edits in trunk

plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown
​https://bugs.webkit.org/show_bug.cgi?id=46715
<rdar://problem/8485909>

Reviewed by Darin Adler.

WebCore:

Remove exclamation points from exceptions.

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):

LayoutTests:

Remove exclamation point.

  • plugins/npruntime/invoke-failure-expected.txt:
4:51 PM Changeset in webkit [68715] by weinig@apple.com
  • 4 edits in trunk/WebCore

Add additional checks to StringBuilder.
<rdar://problem/7761248>

Reviewed by Darin Adler.

  • platform/text/StringBuilder.cpp:

(WebCore::checkAppend):
(WebCore::StringBuilder::append):
(WebCore::StringBuilder::toString):
(WebCore::StringBuilder::clear):
(WebCore::StringBuilder::length):

  • platform/text/StringBuilder.h:

(WebCore::StringBuilder::StringBuilder):
(WebCore::StringBuilder::setNonNull):
(WebCore::StringBuilder::isNull):

4:51 PM Changeset in webkit [68714] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test results.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

Rebaseline GTK test after CSS change.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
4:42 PM Changeset in webkit [68713] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.19-branch

Merge r65900.

4:31 PM Changeset in webkit [68712] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r68096.

4:22 PM Changeset in webkit [68711] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r61709.

4:20 PM Changeset in webkit [68710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r62873.

4:19 PM Changeset in webkit [68709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67967.

4:13 PM Changeset in webkit [68708] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68461.

4:09 PM Changeset in webkit [68707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67407.

4:07 PM Changeset in webkit [68706] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.19-branch

Merge r61622.

4:05 PM Changeset in webkit [68705] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add additional check to Text::wholeText.
<rdar://problem/8304795>

Reviewed by Darin Adler.

  • dom/Text.cpp:

(WebCore::Text::wholeText):

4:05 PM Changeset in webkit [68704] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r65313.

4:04 PM Changeset in webkit [68703] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-533.19-branch

Merge r65135.

3:59 PM Changeset in webkit [68702] by bweinstein@apple.com
  • 6 edits
    4 adds in trunk

REGRESSION (r66129): Loading full-frame .swf file crashes with flash blocker extension enabled
<​https://bugs.webkit.org/show_bug.cgi?id=46773>
<rdar://problem/8390975>

Reviewed by Brady Eidson.

WebCore:

After r66129, start scripts were run on plugin documents, and cancelling the load of a plugin
document could cause Safari to crash.

If a plugin load on an initial document is cancelled, we cancel the main resource load (where the
main resource is the plugin), and if the load is restarted and allowed, we don't go through the manual
loading path like we do on the initial load of a plugin in a plugin document.

Tests: plugins/plugin-document-load-prevented-userscript.html

plugins/plugin-document-willSendRequest-null.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): If the plugin load was cancelled, and this is in a

plugin document, call a function on PluginDocument that cancels the main resource load, and
sets a plugin document flag.

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::appendBytes): Null check the widget's renderer, because it could be

null if the load was cancelled.

(WebCore::PluginDocument::PluginDocument): Initialize the new variable.
(WebCore::PluginDocument::cancelManualPluginLoad): Cancel the main resource load of the plugin document

(which is a plugin in the case of a plugin document).

  • html/PluginDocument.h:

(WebCore::PluginDocument::shouldLoadPluginManually): Returns whether or not we should load the plugin

manually.

(WebCore::PluginDocument::setShouldLoadPluginManually): Set whether or not we should load the plugin

manually.

(WebCore::toPluginDocument):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin): Check if we should load the plugin manually according to the plugin

document.

LayoutTests:

Add tests testing how plugin documents behave when the loading of their plugins are cancelled.

  • plugins/plugin-document-load-prevented-userscript-expected.txt: Added.
  • plugins/plugin-document-load-prevented-userscript.html: Added. Tests cancelling the load of a

plugin in a plugin document using beforeload and preventDefault.

  • plugins/plugin-document-willSendRequest-null-expected.txt: Added.
  • plugins/plugin-document-willSendRequest-null.html: Added. Tests cancelling the load of a plugin

in a plugin document by having willSendRequest return null.

3:58 PM Changeset in webkit [68701] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63138.

3:53 PM Changeset in webkit [68700] by tony@chromium.org
  • 8 edits in trunk

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46829

  • WebKit.gyp:
  • tests/ArenaTestHelpers.h: (WebCore::ArenaTestHelpers::TrackedAllocator::free):
  • tests/IDBKeyPathTest.cpp: (WebCore::checkKeyPath):

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46829

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): (WebViewHost::WebViewHost):
3:52 PM Changeset in webkit [68699] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r63836.

3:52 PM Changeset in webkit [68698] by mrowe@apple.com
  • 6 edits
    7 adds in branches/safari-533.19-branch

Merge r63834.

3:51 PM Changeset in webkit [68697] by mrowe@apple.com
  • 4 edits
    8 adds in branches/safari-533.19-branch

Merge r59185.

3:22 PM Changeset in webkit [68696] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46844, make estimateLogicalTopPosition
block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):

  • rendering/RenderBlock.h:
3:22 PM Changeset in webkit [68695] by crogers@google.com
  • 5 edits in branches/audio/WebCore

audio branch: fixes for landing in trunk

  • AudioContext fix to avoid deleting very large number of AudioNodes all at once
  • HRTFPanner and DelayDSPKernel cleanup
3:11 PM Changeset in webkit [68694] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r66119.

3:08 PM Changeset in webkit [68693] by mrowe@apple.com
  • 6 edits
    1 add in branches/safari-533.19-branch

Merge r65947.

3:06 PM Changeset in webkit [68692] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Minor cleanup to AudioContext
​https://bugs.webkit.org/show_bug.cgi?id=46843

No new tests since audio API is not yet implemented

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::lock): (WebCore::AudioContext::handleDeferredFinishDerefs):
3:06 PM Changeset in webkit [68691] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror on chromium linux webkit
​https://bugs.webkit.org/show_bug.cgi?id=46821

  • WebKit.gyp:
  • src/gtk/WebInputEventFactory.cpp:
3:02 PM Changeset in webkit [68690] by senorblanco@chromium.org
  • 3 edits in trunk

2010-09-29 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
​https://bugs.webkit.org/show_bug.cgi?id=46798


There was a switch statement which missed enum entries in getPropertyCSSValue().
This change added these entries to prevent the leak.
It also added extra case statements to encourage the compiler's help.

Test: fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

2010-09-29 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
​https://bugs.webkit.org/show_bug.cgi?id=46798

  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias-expected.txt: Added.
  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html: Added.
  • fast/css/getComputedStyle/script-tests/margin-top-bottom-collapse-alias.js: Added.
2:56 PM Changeset in webkit [68689] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Limit number of AudioNode deletions per render quantum in AudioContext
​https://bugs.webkit.org/show_bug.cgi?id=46834

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::deleteMarkedNodes):
2:46 PM Changeset in webkit [68688] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed removal of unused #define from WebHistory.h.
Chromium usage of WEBKIT_BUG_40451_IS_FIXED was removed with
​http://crrev.com/50642.

  • public/WebHistoryItem.h:
2:45 PM Changeset in webkit [68687] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46838

Reviewed by Simon Fraser.

Get rid of the marginXXXUsing/setMarginXXXUsing methods on RenderBox. I'm inverting the way these are called
and putting the methods on RenderBlock instead. The methods can be named better this way and the getters
can operate on RenderBoxModelObjects instead of just RenderBoxes.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginTop):
(WebCore::RenderBox::setMarginBottom):
(WebCore::RenderBox::setMarginLeft):
(WebCore::RenderBox::setMarginRight):

2:39 PM Changeset in webkit [68686] by andersca@apple.com
  • 14 edits
    2 adds in trunk/WebKit2

Implement more of PluginProxy and PLuginControllerProxy.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeBytes):

  • Platform/CoreIPC/ArgumentDecoder.h:

Add new overload that takes a DataReference. Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.h:

Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/Arguments.h:

Add new typedefs.

  • Platform/CoreIPC/DataReference.cpp:
  • Platform/CoreIPC/DataReference.h:

Add a DataReference class.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::didEvaluateJavaScript):
(WebKit::PluginControllerProxy::streamDidReceiveResponse):
(WebKit::PluginControllerProxy::streamDidReceiveData):
(WebKit::PluginControllerProxy::streamDidFinishLoading):
(WebKit::PluginControllerProxy::streamDidFail):
call Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add DataReference.cpp and DataReference.h

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::didEvaluateJavaScript):
(WebKit::PluginProxy::streamDidReceiveResponse):
(WebKit::PluginProxy::streamDidReceiveData):
(WebKit::PluginProxy::streamDidFinishLoading):
(WebKit::PluginProxy::streamDidFail):
Send messages.

2:21 PM Changeset in webkit [68685] by senorblanco@chromium.org
  • 10 edits in trunk/LayoutTests

2010-09-29 Stephen White <​senorblanco@chromium.org>

Unreviewed; updated test results.

[CHROMIUM] New test results after r68680.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
2:12 PM Changeset in webkit [68684] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Update expected results.

  • Scripts/webkit2/messages_unittest.py:
2:12 PM Changeset in webkit [68683] by mitz@apple.com
  • 3 edits in trunk/WebCore

Removed input type site-specific quirk for mail.google.com
​https://bugs.webkit.org/show_bug.cgi?id=46836

Reviewed by Sam Weinig.

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::needsGmailQuirk): Removed.
(WebCore::JSHTMLInputElement::type): Removed this custom getter.

  • html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute

from the type attribute.

1:56 PM Changeset in webkit [68682] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-09-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=46777

It should not be possible to get to be in the LoadingFromSourceElement
state with a null current source node. This was a possible scenario
where the current source node was cleared but the load state was not
cleared as well. Tried and could not create a test case for this.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.
1:12 PM Changeset in webkit [68681] by hyatt@apple.com
  • 9 edits in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights. Rename stretchesToViewHeight.

Reviewed by Dan Bernstein.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.

Reviewed by Dan Bernstein.

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:59 PM Changeset in webkit [68680] by Chris Fleizach
  • 19 edits
    2 adds in trunk

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

Reviewed by Darin Adler.

WebCore:

Support the "speak" style as defined in
​http://www.w3.org/TR/css3-speech/#speak

This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.

Test: platform/mac/accessibility/css-speech-speak.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::speakProperty):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::speakProperty):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::speak):
(WebCore::InheritedFlags::setSpeak):
(WebCore::InheritedFlags::initialSpeak):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::speak):

LayoutTests:

  • platform/mac/accessibility/css-speech-speak-expected.txt: Added.
  • platform/mac/accessibility/css-speech-speak.html: Added.
12:33 PM Changeset in webkit [68679] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[Curl] Fix unused and unitialized warnings.
​https://bugs.webkit.org/show_bug.cgi?id=46831

No new tests since no new funcionality has been added.

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::allowsAnyHTTPSCertificateHosts):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::handleLocalReceiveResponse): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::initializeHandle):
12:32 PM Changeset in webkit [68678] by hyatt@apple.com
  • 6 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46824

Reviewed by Sam Weinig.

Convert layoutBlockChild (but not the functions it calls) to be block-flow-aware.

fast/blockflow/root-lr.html progresses as a result of this change.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.h:

LayoutTests:

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:17 PM Changeset in webkit [68677] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Implement LoadURL
​https://bugs.webkit.org/show_bug.cgi?id=46826

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Move String argument coder here from WebCoreArgumentCoders.h. Add
argument coder for AtomicString.

  • Platform/CoreIPC/Arguments.h:

Add typedefs for Arguments7.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add handleMessage overload that takes 7 parameters.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::loadURL):
Send the LoadURL message.

  • Scripts/webkit2/messages.py:

(parse_parameter_string): Use rsplit in case the type name contains spaces.
(argument_coder_headers_for_type): Special case Vector.

  • Scripts/webkit2/messages_unittest.py:

Update results.

  • Shared/WebCoreArgumentCoders.h:

Add argument coder for HTTPHeaderMap.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::loadURL):
Ask the plug-in controller to load the URL.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add LoadURL message.

12:12 PM Changeset in webkit [68676] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.

[CHROMIUM] Update test_expectations to better reflect the state of the
build.

  • platform/chromium/test_expectations.txt:
12:08 PM Changeset in webkit [68675] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding one more missing change from the last patch.
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • WebKit.gyp:
12:08 PM Changeset in webkit [68674] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Avoid touching the po files automatically during the build
process. The maintainers still have the option of forcing an
update with make update-po.

  • GNUmakefile.am:
12:07 PM Changeset in webkit [68673] by mihaip@chromium.org
  • 11 edits
    1 copy in trunk/WebKitTools

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Record bot ID when updating queue status
​https://bugs.webkit.org/show_bug.cgi?id=46764

Since we now have multiple bots handling patches from the commit queue,
we need to differentiate status updates from them, so that we can group
the queue status page in a less confusing way.

  • QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
  • QueueStatusServer/model/queuestatus.py: Add bot_id property
  • QueueStatusServer/templates/updatestatus.html: Add bot_id input
  • Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
  • Scripts/webkitpy/common/net/statusserver.py: Add bot_id
  • Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
  • Scripts/webkitpy/tool/main.py: Add --bot-id
  • Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
12:04 PM Changeset in webkit [68672] by kinuko@chromium.org
  • 1 edit
    2 adds in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding the new files that were supposed to be added
but I missed to include in my previous patch.
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
11:47 AM Changeset in webkit [68671] by rniwa@webkit.org
  • 2 edits in trunk

Fixed reviewer names.

11:44 AM Changeset in webkit [68670] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

2010-09-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
​https://bugs.webkit.org/show_bug.cgi?id=21305

Implemented queryCommandValue('formatBlock'). We match the Firefox's behavior exactly
because Firefox and Internet Explorer support the same set of elements
(address, h1, h2, h3, h4, h5, h6, and p) and Firefox's behavior is more compatible with Opera.
See the bug for the detailed discussion.

WebKit's implementation returns the local name of the lowest common ancestor
of the selection with the tag name address, h1, h2, h3, h4, h5, h6, or p.
It returns "" when there is no such an ancestor or there is no selection.

Test: editing/execCommand/query-format-block.html

  • editing/Editor.cpp: (WebCore::isElementForFormatBlockCommand): (WebCore::Editor::elementForFormatBlockCommand):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::valueFormatBlock): (WebCore::createCommandMap):

2010-09-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
​https://bugs.webkit.org/show_bug.cgi?id=21305

Added a test for queryCommandValue('formatBlock').

  • editing/execCommand/query-format-block-expected.txt: Added.
  • editing/execCommand/query-format-block.html: Added.
  • editing/execCommand/script-tests/query-format-block.js: Added. (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
11:12 AM Changeset in webkit [68669] by kinuko@chromium.org
  • 9 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Bridge all FileSystem operations on Workers to the MainThread
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed the worker case code to create WebFileSystemCallbacksImpl with the current ScriptExecutionContext (WorkerContext).
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a new constructor that takes ScriptExecutionContext (WorkerContext) for workers. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Added the code for workers that creates WorkerAsyncFileSystemChromium.
  • src/WebFileSystemCallbacksImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
  • src/WorkerFileSystemCallbacksBridge.cpp: Added methods for regular file system operations to proxy them to the main thread. (WebKit::WorkerFileSystemCallbacksBridge::createForOpenFileSystem): (WebKit::WorkerFileSystemCallbacksBridge::createForMove): (WebKit::WorkerFileSystemCallbacksBridge::createForCopy): (WebKit::WorkerFileSystemCallbacksBridge::createForRemove): (WebKit::WorkerFileSystemCallbacksBridge::createForReadMetadata): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateFile): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateDirectory): (WebKit::WorkerFileSystemCallbacksBridge::createForFileExists): (WebKit::WorkerFileSystemCallbacksBridge::createForDirectoryExists): (WebKit::WorkerFileSystemCallbacksBridge::createForReadDirectory): (WebKit::MainThreadFileSystemCallbacks::didSucceed): (WebKit::MainThreadFileSystemCallbacks::didReadMetadata): (WebKit::MainThreadFileSystemCallbacks::didReadDirectory): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::derefIfWorkerIsStopped):
  • src/WorkerFileSystemCallbacksBridge.h:
11:08 AM Changeset in webkit [68668] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk/po

2010-09-29 Miloš Popović <​gpopac@gmail.com>

Reviewed by Gustavo Noronha Silva.

Serbian translations update.

11:01 AM Changeset in webkit [68667] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68485

BUG=56621
Review URL: ​http://codereview.chromium.org/3520007

11:01 AM Changeset in webkit [68666] by mpcomplete@chromium.org
  • 7 edits in trunk

2010-09-29 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=46683

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:

2010-09-29 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=46683

  • public/WebScriptController.h:
  • src/WebScriptController.cpp:
10:58 AM Changeset in webkit [68665] by Martin Robinson
  • 5 edits in trunk

2010-09-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
​https://bugs.webkit.org/show_bug.cgi?id=46822

  • platform/gtk/Skipped: Unskip a test which is no longer crashing.

2010-09-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
​https://bugs.webkit.org/show_bug.cgi?id=46822

When parentObjectUnignored returns null in objectAndOffsetUnignored consider that
a failure case. Handle this failure appropriately at all call sites.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Handle the failure of objectAndOffsetUnignored. (objectAndOffsetUnignored): Always check the return value of parentObjectUnignored and return 0 to indicate failure when that happens.
  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Handle the failure case of objectAndOffsetUnignored.
10:56 AM Changeset in webkit [68664] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 68408

BUG=56692
Review URL: ​http://codereview.chromium.org/3559003

10:52 AM Changeset in webkit [68663] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68340

BUG=56796
Review URL: ​http://codereview.chromium.org/3521003

10:46 AM Changeset in webkit [68662] by andersca@apple.com
  • 12 edits in trunk/WebKit2

Handle getting the user agent in the plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=46819

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::create):
(WebKit::PluginControllerProxy::PluginControllerProxy):
Pass the user agent to the plug-in controller proxy.

(WebKit::PluginControllerProxy::userAgent):
Return the user agent.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass the user agent when creating the plug-in controller proxy.

  • PluginProcess/WebProcessConnection.messages.in:

Add userAgent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

  • WebProcess/Plugins/PluginController.h:

Remove the URL parameter to userAgent.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Pass the user agent to WebProcessConnection::CreatePlugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::userAgent):
Remove url parameter.

10:46 AM Changeset in webkit [68661] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-09-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r68657.
​http://trac.webkit.org/changeset/68657
​https://bugs.webkit.org/show_bug.cgi?id=46820

reason "Breaks win debug build" (Requested by podivilov on
#webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl): (WebCore::InspectorController::characterDataModifiedImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::characterDataModified): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
  • inspector/InspectorInstrumentation.cpp: Removed.
  • inspector/InspectorInstrumentation.h: Removed.
  • workers/SharedWorker.cpp:
10:32 AM Changeset in webkit [68660] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Performance improvement for FontLinux.
​https://bugs.webkit.org/show_bug.cgi?id=46374

Reduce new/delete operations by storing the maximum capacity of the glyph
array and use that value in subsequent HB_ShapeItem calls. (Note that a
call to HB_ShapeItem may reduce the value of m_item.num_glyphs below the
capacity.)

Also be consistent with zero'ing the glyph arrays before calling
HB_ShapeItem.

There is no functionality changes so no new tests are added.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
10:23 AM Changeset in webkit [68659] by andersca@apple.com
  • 9 edits in trunk

Implement more PluginProxy member functions
​https://bugs.webkit.org/show_bug.cgi?id=46815

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleMouseEvent):
(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::setFocus):
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowFrameChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
Call the appropriate Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
It's OK to get a message for a plug-in controller proxy that has gone away.

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Forward the message to the PluginControllerProxy handler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::setFocus):
(WebKit::PluginProxy::windowFocusChanged):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::windowVisibilityChanged):
Send messages to the plug-in process.

(WebKit::PluginProxy::controller):
Return the plug-in controller.

10:19 AM Changeset in webkit [68658] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-09-29 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Add method which checks if a WebAccessibilityObject is in the cache.
​https://bugs.webkit.org/show_bug.cgi?id=46605

  • public/WebAccessibilityCache.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::isCached):
  • src/WebAccessibilityCacheImpl.h:
10:19 AM Changeset in webkit [68657] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-09-29 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class.
​https://bugs.webkit.org/show_bug.cgi?id=46614

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
10:15 AM Changeset in webkit [68656] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-29 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
​https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/iframe-shims.html:

2010-09-29 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
​https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • src/WebPluginContainerImpl.cpp:
10:10 AM Changeset in webkit [68655] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

No review.

References always refert to a file in .xht format, even
for HTML tests, so fix their loading.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
10:00 AM Changeset in webkit [68654] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not any functions it calls)
to be block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

9:46 AM Changeset in webkit [68653] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-29 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
​https://bugs.webkit.org/show_bug.cgi?id=46812

Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
instead of keeping a local pointer to it.

This is cleanup for a follow-up patch.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay): (QGraphicsWebView::paint): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry):
9:43 AM Changeset in webkit [68652] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
​https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

No new tests since no new funcionality has been added.

  • platform/efl/SharedBufferEfl.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
​https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: (FullscreenVideoController::canPlay):
9:31 AM Changeset in webkit [68651] by commit-queue@webkit.org
  • 10 edits in trunk/JavaScriptCore/qt

2010-09-29 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QScriptEngine should have an API for creating Date objects
​https://bugs.webkit.org/show_bug.cgi?id=41667

Implement newDate(), isDate() and toDateTime() functions. Use the
QDateTime::{to,set}MSecsSinceEpoch() functions to do the
calculations.

  • api/qscriptengine.cpp: (QScriptEngine::newDate):
  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::newDate):
  • api/qscriptengine_p.h: (QScriptEnginePrivate::isDate):
  • api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): need to keep track of Date Constructor and Prototype. (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): ditto. (QScriptOriginalGlobalObject::isDate): use the Date Constructor and Prototype to identify Date values.
  • api/qscriptvalue.cpp: (QScriptValue::isDate): (QScriptValue::toDateTime):
  • api/qscriptvalue.h:
  • api/qscriptvalue_p.h: (QScriptValuePrivate::isDate): (QScriptValuePrivate::toDateTime):
  • tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newDate):
9:06 AM Changeset in webkit [68650] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, updated baselines of
svg/css/getComputedStyle-basic.xhtml after the css properties
were renamed in r68561.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
8:55 AM Changeset in webkit [68649] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Next try to fix cygwin build.

  • wtf/Assertions.cpp:
8:44 AM Changeset in webkit [68648] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin #2. Oops, it's OS(WINDOWS), not OS(WIN).

  • wtf/Assertions.cpp:
8:35 AM Changeset in webkit [68647] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin.

  • wtf/Assertions.cpp:
8:34 AM Changeset in webkit [68646] by Adam Roben
  • 2 edits in trunk/WebKit2

Look for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug builds

Fixes <​http://webkit.org/b/46809> <rdar://problem/8491809> REGRESSION
(r67979): All tests crashing on Windows WebKit2 test bot

Reviewed by Sam Weinig.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: WebKit_debug.dll is

only used in Debug_All builds (but WebKit2WebProcess_debug.exe is used
in all non-Debug_Internal debug-style builds).

8:11 AM Changeset in webkit [68645] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

build still broken since r68521
​https://bugs.webkit.org/show_bug.cgi?id=46795

Call make-values.pl once only. It seems calling it multiple times
in the same build produces a wrong CSSValueKeywordsHash.h which
has a duplicate declaration of its valueList variable. The double
call is triggered by the double targets in the Makefile rules and
makevalues.pl generates one of them, which screws up the build. A
more proper fix should be done with the advices on
​http://www.cmcrossroads.com/cm-basics/12905-rules-with-multiple-outputs-in-gnu-make

  • GNUmakefile.am:
8:06 AM Changeset in webkit [68644] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Buildfix for Assertions.cpp after r68511.
​https://bugs.webkit.org/show_bug.cgi?id=46807

Some, but not all WinCE environments have support for IsDebuggerPresent().
Add HAVE(ISDEBUGGERPRESENT) to make this a build option.
HAVE(ISDEBUGGERPRESENT) will be 1 for all OS(WIN) by default.

  • wtf/Assertions.cpp:
  • wtf/Platform.h:
7:46 AM Changeset in webkit [68643] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Unreviewed build fix.

Fix CMake build for ENABLE_PROGRESS_TAG.
​https://bugs.webkit.org/show_bug.cgi?id=46808

No new tests since it's a build fix.

  • CMakeLists.txt:
6:56 AM Changeset in webkit [68642] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Reinout van Schouwen <​reinouts@gnome.org>

Reviewed by Gustavo Noronha.

[GTK] Updated Dutch translation
​https://bugs.webkit.org/show_bug.cgi?id=46050

  • nl.po:
6:46 AM Changeset in webkit [68641] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
​https://bugs.webkit.org/show_bug.cgi?id=46803

No new tests. It's covered by existing tests under LayoutTests/storage

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
6:45 AM Changeset in webkit [68640] by satish@chromium.org
  • 14 edits in trunk

2010-09-29 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
​https://bugs.webkit.org/show_bug.cgi?id=46799

  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton.html:
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:

2010-09-29 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
​https://bugs.webkit.org/show_bug.cgi?id=46799

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitspeechEnabled): Rename the runtime feature flag getter.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in: Rename the css style name.
  • css/html.css: Rename the css style name. (input::-webkit-input-speech-button):
  • html/HTMLAttributeNames.in: Rename the @speech attribute.
  • html/HTMLInputElement.cpp: Update code using the attribute. (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::isSpeechEnabled):
  • html/HTMLInputElement.idl: Rename the @speech attribute.
5:45 AM Changeset in webkit [68639] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

JSC compile fails on 32bit platform when Regexp Tracing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=46713

Fix the cast of pointer in regexp tracing to avoid the warning.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
5:17 AM Changeset in webkit [68638] by morrita@google.com
  • 3 edits
    1 add in trunk/WebCore

2010-09-29 MORITA Hajime <​morrita@google.com>

[Chromium] failed to build without ACCELERATED_COMPOSITING
​https://bugs.webkit.org/show_bug.cgi?id=46793

Moved constant definitions from inside ACCELERATED_COMPOSITING to
outside of the condition.

  • WebCore.gypi:
  • platform/graphics/chromium/VideoFrameChromium.cpp: Added just for defining constants.
  • platform/graphics/chromium/VideoLayerChromium.cpp:
3:35 AM Changeset in webkit [68637] by Simon Hausmann
  • 2 edits in trunk

[Qt] Fix the build on non-x86 platforms with gcc

Reviewed by Csaba Osztrogonác.

Don't disable -Werror on arm, that doesn't work when QT_ARCH is
for example armv6. Instead change the condition as the comment says,
enable -Werror on x86/gcc where we know it passes. On other platforms
gcc produces difference warnings, and when they're fixed we can add
them to the whitelist of -Werror-supported architectures.

  • WebKit.pri:
2:14 AM Changeset in webkit [68636] by pfeldman@chromium.org
  • 10 edits
    3 adds in trunk/WebCore

2010-09-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [Resources panel] Need more visible "at a glance".
​https://bugs.webkit.org/show_bug.cgi?id=45657

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.updateWidths): (WebInspector.DataGrid.prototype.sortNodes): (WebInspector.DataGrid.prototype._resizerDragging): (WebInspector.DataGrid.prototype._endResizerDragging): (WebInspector.DataGridNode.prototype.selectable.true.get element): (WebInspector.DataGridNode.prototype.createCells): (WebInspector.DataGridNode.prototype.refresh):
  • inspector/front-end/Images/networkIcon.png: Copied from WebCore/inspector/front-end/Images/resourcesIcon.png.
  • inspector/front-end/NetworkPanel.js: Added.
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.toolbar-item.network .toolbar-icon): (.data-grid .data-container):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: Added.
12:59 AM Changeset in webkit [68635] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-09-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move pauseOnExceptionState under control of InspectorState
It is Inspector Protocol cleanup activity.
The actual state of this flag can be obtained as a return value of setPauseOnExceptionState command
or as a value in InspectorState object.

​https://bugs.webkit.org/show_bug.cgi?id=46724

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::pauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone): (WebInspector.reportProtocolError):
12:09 AM Changeset in webkit [68634] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 James Kozianski <​koz@chromium.org>

Reviewed by James Robinson.

Update test_expectations.txt from the flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=46787

Updates some canvas/philip tests in test_expectations.txt that have
started passing on the flakiness dashboard.

  • platform/chromium/test_expectations.txt:

Sep 28, 2010:

11:55 PM Changeset in webkit [68633] by Csaba Osztrogonác
  • 1 edit
    17 adds in trunk/LayoutTests

Unreviewed fix after r68568. Add Qt specific expected files for passing tests.

Unskip remaining canvas layout tests so that they can track progressions/regressions
​https://bugs.webkit.org/show_bug.cgi?id=46439

  • platform/qt/canvas: Added.
  • platform/qt/canvas/philip: Added.
  • platform/qt/canvas/philip/tests: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
  • platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
11:50 PM Changeset in webkit [68632] by Philippe Normand
  • 23 edits in trunk

2010-09-28 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
​https://bugs.webkit.org/show_bug.cgi?id=46717

Define WTF_USE_GSTREAMER if configure found the gstreamer
development files and add the macro in the gcc command-line if needed.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

Reviewed by Martin Robinson.

check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
​https://bugs.webkit.org/show_bug.cgi?id=46717

Guard the gstreamer/ files with USE(GSTREAMER), which is more
explicit than ENABLE(VIDEO).

  • GNUmakefile.am: Define WTF_USE_GSTREAMER only if GStreamer support is enabled.
  • platform/graphics/gstreamer/DataSourceGStreamer.cpp:
  • platform/graphics/gstreamer/DataSourceGStreamer.h:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h:
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCG.mm:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/PlatformVideoWindow.h:
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
11:30 PM Changeset in webkit [68631] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Kent Tamura <​tkent@chromium.org>

Unreviewed, windows build fix for r68629.

  • WebCore.vcproj/WebCore.vcproj: Add TimeInputType.{cpp,h}
11:27 PM Changeset in webkit [68630] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Some windowed plugins did not handle events through EventHandler, so we
never set right gesture state for those events.
This change is to set right allowPopupsFromPlugin flag to current
execution frame, so WeKit can always get right gesture state on Mac.
From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
process, that process passes the allowPopupsFromPlugin flag to
WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
NetscapePluginInstanceProxy::evaluate.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Pass the right popupAllowed flag to current execution frame,
so WebKit can get right gesture status for popups initiated
from plugins.
This also makes v8 binding's ScriptController::processingUserGesture
match what jsc version.

Test: plugins/plugin-initiate-popup-window.html

  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292.
Add a test to initiate popup windows from plugin during plugin is
handling mouse/keyboard event.
Disable this test on gtk/qt/win since the test plugin in those platforms
didn't implement NPP_HandleEvent.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/plugin-initiate-popup-window-expected.txt: Added.
  • plugins/plugin-initiate-popup-window.html: Added.

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):
11:18 PM Changeset in webkit [68629] by tkent@chromium.org
  • 10 edits
    54 adds in trunk/WebCore

Refactor HTMLInputElement: Introducing InputType class and classes
for each input element types.
​https://bugs.webkit.org/show_bug.cgi?id=45872

Reviewed by Darin Adler.

No new tests because this doesn't change any behavior.

  • Android.mk: Add new files.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/BaseTextInputType.cpp: Added.

(WebCore::BaseTextInputType::isTextType):
(WebCore::BaseTextInputType::patternMismatch):

  • html/BaseTextInputType.h: Added.

(WebCore::BaseTextInputType::BaseTextInputType):

  • html/ButtonInputType.cpp: Added.

(WebCore::ButtonInputType::create):
(WebCore::ButtonInputType::formControlType):

  • html/ButtonInputType.h: Added.

(WebCore::ButtonInputType::ButtonInputType):

  • html/CheckboxInputType.cpp: Added.

(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::formControlType):

  • html/CheckboxInputType.h: Added.

(WebCore::CheckboxInputType::CheckboxInputType):

  • html/ColorInputType.cpp: Added.

(WebCore::ColorInputType::create):
(WebCore::ColorInputType::formControlType):

  • html/ColorInputType.h: Added.

(WebCore::ColorInputType::ColorInputType):

  • html/DateInputType.cpp: Added.

(WebCore::DateInputType::create):
(WebCore::DateInputType::formControlType):

  • html/DateInputType.h: Added.

(WebCore::DateInputType::DateInputType):

  • html/DateTimeInputType.cpp: Added.

(WebCore::DateTimeInputType::create):
(WebCore::DateTimeInputType::formControlType):

  • html/DateTimeInputType.h: Added.

(WebCore::DateTimeInputType::DateTimeInputType):

  • html/DateTimeLocalInputType.cpp: Added.

(WebCore::DateTimeLocalInputType::create):
(WebCore::DateTimeLocalInputType::formControlType):

  • html/DateTimeLocalInputType.h: Added.

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • html/EmailInputType.cpp: Added.

(WebCore::EmailInputType::create):
(WebCore::EmailInputType::formControlType):

  • html/EmailInputType.h: Added.

(WebCore::EmailInputType::EmailInputType):

  • html/FileInputType.cpp: Added.

(WebCore::FileInputType::create):
(WebCore::FileInputType::formControlType):

  • html/FileInputType.h: Added.

(WebCore::FileInputType::FileInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Initialize m_inputType.
(WebCore::HTMLInputElement::patternMismatch): Delegate to InputType.
(WebCore::HTMLInputElement::updateType): Update m_inputType with new type.
(WebCore::HTMLInputElement::formControlType): Delegate to InputType.
(WebCore::HTMLInputElement::isTextField): ditto.
(WebCore::HTMLInputElement::isTextType): ditto.

  • html/HTMLInputElement.h:
  • html/HiddenInputType.cpp: Added.

(WebCore::HiddenInputType::create):
(WebCore::HiddenInputType::formControlType):

  • html/HiddenInputType.h: Added.

(WebCore::HiddenInputType::HiddenInputType):

  • html/ImageInputType.cpp: Added.

(WebCore::ImageInputType::create):
(WebCore::ImageInputType::formControlType):

  • html/ImageInputType.h: Added.

(WebCore::ImageInputType::ImageInputType):

  • html/InputType.cpp: Added.

(WebCore::createInputTypeFactoryMap):
(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::~InputType):
(WebCore::InputType::isTextField):
(WebCore::InputType::isTextType):
(WebCore::InputType::patternMismatch):
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::isindex):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):

  • html/InputType.h: Added.

(WebCore::InputType::InputType):
(WebCore::InputType::element):

  • html/IsIndexInputType.cpp: Added.

(WebCore::IsIndexInputType::create):
(WebCore::IsIndexInputType::formControlType):

  • html/IsIndexInputType.h: Added.

(WebCore::IsIndexInputType::IsIndexInputType):

  • html/MonthInputType.cpp: Added.

(WebCore::MonthInputType::create):
(WebCore::MonthInputType::formControlType):

  • html/MonthInputType.h: Added.

(WebCore::MonthInputType::MonthInputType):

  • html/NumberInputType.cpp: Added.

(WebCore::NumberInputType::create):
(WebCore::NumberInputType::formControlType):

  • html/NumberInputType.h: Added.

(WebCore::NumberInputType::NumberInputType):

  • html/PasswordInputType.cpp: Added.

(WebCore::PasswordInputType::create):
(WebCore::PasswordInputType::formControlType):

  • html/PasswordInputType.h: Added.

(WebCore::PasswordInputType::PasswordInputType):

  • html/RadioInputType.cpp: Added.

(WebCore::RadioInputType::create):
(WebCore::RadioInputType::formControlType):

  • html/RadioInputType.h: Added.

(WebCore::RadioInputType::RadioInputType):

  • html/RangeInputType.cpp: Added.

(WebCore::RangeInputType::create):
(WebCore::RangeInputType::formControlType):

  • html/RangeInputType.h: Added.

(WebCore::RangeInputType::RangeInputType):

  • html/ResetInputType.cpp: Added.

(WebCore::ResetInputType::create):
(WebCore::ResetInputType::formControlType):

  • html/ResetInputType.h: Added.

(WebCore::ResetInputType::ResetInputType):

  • html/SearchInputType.cpp: Added.

(WebCore::SearchInputType::create):
(WebCore::SearchInputType::formControlType):

  • html/SearchInputType.h: Added.

(WebCore::SearchInputType::SearchInputType):

  • html/SubmitInputType.cpp: Added.

(WebCore::SubmitInputType::create):
(WebCore::SubmitInputType::formControlType):

  • html/SubmitInputType.h: Added.

(WebCore::SubmitInputType::SubmitInputType):

  • html/TelephoneInputType.cpp: Added.

(WebCore::TelephoneInputType::create):
(WebCore::TelephoneInputType::formControlType):

  • html/TelephoneInputType.h: Added.

(WebCore::TelephoneInputType::TelephoneInputType):

  • html/TextFieldInputType.cpp: Added.

(WebCore::TextFieldInputType::isTextField):

  • html/TextFieldInputType.h: Added.

(WebCore::TextFieldInputType::TextFieldInputType):

  • html/TextInputType.cpp: Added.

(WebCore::TextInputType::create):
(WebCore::TextInputType::formControlType):

  • html/TextInputType.h: Added.

(WebCore::TextInputType::TextInputType):

  • html/TimeInputType.cpp: Added.

(WebCore::TimeInputType::create):
(WebCore::TimeInputType::formControlType):

  • html/TimeInputType.h: Added.

(WebCore::TimeInputType::TimeInputType):

  • html/URLInputType.cpp: Added.

(WebCore::URLInputType::create):
(WebCore::URLInputType::formControlType):

  • html/URLInputType.h: Added.

(WebCore::URLInputType::URLInputType):

  • html/WeekInputType.cpp: Added.

(WebCore::WeekInputType::create):
(WebCore::WeekInputType::formControlType):

  • html/WeekInputType.h: Added.

(WebCore::WeekInputType::WeekInputType):

10:59 PM Changeset in webkit [68628] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46782, rename the top and bottom margin quirk getters/setters.

Reviewed by Maciej Stachowiak.

Also do a bit of cleanup for block flow roots. Make sure they don't try to propagate overhanging floats out
to ancestors.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::addOverhangingFloats):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMarginBeforeQuirk):
(WebCore::RenderObject::isMarginAfterQuirk):
(WebCore::RenderObject::setMarginBeforeQuirk):
(WebCore::RenderObject::setMarginAfterQuirk):

10:59 PM Changeset in webkit [68627] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

Fix export by adding missing argument.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.showResultsForAllTests):
10:38 PM Changeset in webkit [68626] by hyatt@apple.com
  • 7 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46780

Reviewed by Sam Weinig.

Rename the pos/neg/collapsed margin methods. Rename all the members of the RenderBlockRareData struct.
No logical changes. Just renames.

  • editing/TextIterator.cpp:

(WebCore::shouldEmitExtraNewlineForNode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::maxPosMarginBefore):
(WebCore::RenderBlock::maxNegMarginBefore):
(WebCore::RenderBlock::maxPosMarginAfter):
(WebCore::RenderBlock::maxNegMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::maxMarginBefore):
(WebCore::RenderBlock::maxMarginAfter):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::beforePosDefault):
(WebCore::RenderBlock::RenderBlockRareData::beforeNegDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterPosDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterNegDefault):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
(WebCore::RenderBox::maxMarginBefore):
(WebCore::RenderBox::maxMarginAfter):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

10:14 PM Changeset in webkit [68625] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review

Show which tests have been run by dimming them out in the test list.

Adjust some element sizes.

  • CSSTestSuiteHarness/harness/harness.css: (#test-list > option.untested): (#test-list > option.completed): (#output): (.output-options):
  • CSSTestSuiteHarness/harness/harness.js: (Test): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.setSelectedChapter): (TestSuite.prototype.recordResult): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.testCompletionStateChanged): (TestSuite.prototype.loadTestStatus):
9:35 PM Changeset in webkit [68624] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <​morrita@google.com>

Unreviewed; update test expectations.

  • platform/chromium/test_expectations.txt:
9:10 PM Changeset in webkit [68623] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix, add missing import.

9:06 PM Changeset in webkit [68622] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] wxMSW build fix. Don't use multiple inheritance in PopupMenuWx to avoid debug build
compiler error about ambiguity over which new override (wx's or FastAllocBase's) to use.

9:00 PM Changeset in webkit [68621] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review.

Implement export of various queries on the test database, sharing
code with that which displays results inline.

  • CSSTestSuiteHarness/harness/harness.js: (): (TestSuite.prototype.exportResultsCompletion.var): (TestSuite.prototype.exportResultsCompletion): (TestSuite.prototype.showResultsForCompletedTests): (TestSuite.prototype.exportResultsForCompletedTests): (TestSuite.prototype.showResultsForAllTests): (TestSuite.prototype.exportResultsForAllTests): (TestSuite.prototype.exportResultsForTestsNotRun): (TestSuite.prototype.exportResultsForTestsWithStatus): (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
7:43 PM Changeset in webkit [68620] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-28 MORITA Hajime <​morrita@google.com>

Unreviewed; new test baselines.

  • platform/chromium-win/animations/opacity-transform-animation-expected.checksum: Added.
  • platform/chromium-win/animations/opacity-transform-animation-expected.png: Added.
6:37 PM Changeset in webkit [68619] by mihaip@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2010-09-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Simon Fraser.

[Chromium] animations/opacity-transform-animation.html fails on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=46557

Make transition from .7 opacity to 1.0 (instead of .8 to .9). The
mid-point (where the pixel dump is done) is the same, but the overall
change is more obvious, so failures are more noticeable.

Update Chromium baselines (it has a slightly different intermediate
color; (38, 109, 0) vs. (32, 110, 0) for the Mac port, albeit one which
agrees with the expected interpolated value better).

  • animations/opacity-transform-animation.html:
  • platform/chromium/animations/opacity-transform-animation-expected.checksum: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [68618] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Xiaomei Ji <​xji@chromium.org>

Reviewed by NOBODY (revert unsquashed git commits)

Revert change sets 68583 to 68590, which are un-squashed git-commits: Performance improvement for FontLinux regarding issue 46374.
​https://bugs.webkit.org/show_bug.cgi?id=46374

6:20 PM Changeset in webkit [68617] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review.

Work around uncertainty about the order of database
transactions when creating the database, so that we don't
try to query the table before it has been created.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.queryDatabaseForTestsWithStatus): (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus): (TestSuite.prototype.queryDatabaseForCompletedTests): (TestSuite.prototype.queryDatabaseForTestsNotRun):
5:45 PM Changeset in webkit [68616] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; update test expectations.

[CHROMIUM] Update Chromium/Linux test expectations.

  • platform/chromium/test_expectations.txt:
5:44 PM Changeset in webkit [68615] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Tony Chang.

Split webcore_html off webcore_remaining.

webcore_remaining is still too large for certain 32 bits toolsets.
​https://bugs.webkit.org/show_bug.cgi?id=46445

  • WebCore.gyp/WebCore.gyp:
5:23 PM Changeset in webkit [68614] by senorblanco@chromium.org
  • 5 edits
    5 adds in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; update test expectations.

[CHROMIUM] Add some new test baselines and expectations.

  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/canvas: Added.
  • platform/chromium-mac/canvas/philip: Added.
  • platform/chromium-mac/canvas/philip/tests: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/test_expectations.txt:
5:14 PM Changeset in webkit [68613] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-28 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Delete and forward delete shouldn't start autocorrection panel timer.
​https://bugs.webkit.org/show_bug.cgi?id=46679
<rdar://problem/8463917>

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Only start correction panel timer when the editing command is InsertText. (WebCore::TypingCommand::typingAddedToOpenCommand): Add an argument to pass in command type.
  • editing/TypingCommand.h: Add an argument to typingAddedToOpenCommand().
5:13 PM Changeset in webkit [68612] by andersca@apple.com
  • 8 edits
    1 add in trunk/WebKit2

Paint the plug-in backing store into the WebProcess backing store
​https://bugs.webkit.org/show_bug.cgi?id=46768

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProxy.

  • Platform/CoreIPC/MessageID.h:

Add PluginProxy message class.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Let the web process know that we've painted.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveMessage):
Pass the message on to a plug-in proxy.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Paint our backing store into the graphics context.

(WebKit::PluginProxy::controller):
Add notImplemented().

(WebKit::PluginProxy::update):
Blit the plug-in backing store into the local backing store and tell the plug-in
controller that we want to repaint.

  • WebProcess/Plugins/PluginProxy.messages.in: Added.
5:04 PM Changeset in webkit [68611] by crogers@google.com
  • 32 edits
    2 copies in branches/audio/WebCore

audio branch: changes in preparation for moving code to trunk

  • split out DelayDSPKernel from DelayProcessor file
  • HRTFDatabase and HRTFDatabaseLoader (as landed in trunk)
  • HRTFPanner, AudioChannelMerger, AudioChannelSplitter, AudioGainNode cleanup
  • implemented basic versions of initialize() and uninitialize() in AudioNode - made m_isInitialized private
  • fix AudioContext to use newest HRTFDatabaseLoader API
  • fix AudioParam to reject NAN and INF values.
  • fix CachedAudio to not crash and instead call onerror handler if audio file data is invalid.
4:53 PM Changeset in webkit [68610] by andersca@apple.com
  • 12 edits
    1 add in trunk

Begin hooking up painting in the plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=46766

Reviewed by Sam Weinig.

JavaScriptCore:

Add tryFastRealloc, used by WebKit2.

WebKit2:

  • DerivedSources.make:

Add PluginControllerProxy.

  • Platform/CoreIPC/MessageID.h:

Add a MessageClassPluginControllerProxy message class.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize the paint timer.

(WebKit::PluginControllerProxy::paint):
Create a graphics context referencing our backing store and paint into it.

(WebKit::PluginControllerProxy::invalidate):
Update the dirty rect and start the paint timer if necessary.

(WebKit::PluginControllerProxy::geometryDidChange):
If we're passed a new backing store handle, reinitialize the backing store.

  • PluginProcess/PluginControllerProxy.messages.in: Added.
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
If the message has a destination ID, forward it to the plug-in controller proxy.

  • Scripts/webkit2/messages.py:

Always include WebCoreArgumentCoders.h if the type is in the WebCore namespace.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Update the size of the backing store. Create a new plug-in backing store if needed and send
it over to the plug-in process.

4:50 PM Changeset in webkit [68609] by mihaip@chromium.org
  • 3 edits
    6 adds in trunk

2010-09-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

No back/forward list entry added when submitting a form via an onclick handler inside a frame
​https://bugs.webkit.org/show_bug.cgi?id=44140

Add tests for user-gesture initiated form submissions inside iframes to
make sure that they generate back/forward list entries.

  • fast/history/form-submit-in-frame-expected.txt: Added.
  • fast/history/form-submit-in-frame-via-onclick-expected.txt: Added.
  • fast/history/form-submit-in-frame-via-onclick.html: Added.
  • fast/history/form-submit-in-frame.html: Added.
  • fast/history/resources/form-with-input-submit.html: Added.
  • fast/history/resources/form-with-onclick-submit.html: Added.

2010-09-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

No back/forward list entry added when submitting a form via an onclick handler inside a frame
​https://bugs.webkit.org/show_bug.cgi?id=44140

Lock the back/forward list for JavaScript form submissions inside frames
only if they're not in response to user gestures.

Tests: fast/history/form-submit-in-frame-via-onclick.html

fast/history/form-submit-in-frame.html

  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleFormSubmission):
4:42 PM Changeset in webkit [68608] by senorblanco@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; new Chromium/Win test baselines.

[CHROMIUM] These are tests we were passing on Chrome, but are now listed as failing due to r68568. Adding platform-specific baselines should make us pass them again.

  • platform/chromium-win/canvas: Added.
  • platform/chromium-win/canvas/philip: Added.
  • platform/chromium-win/canvas/philip/tests: Added.
  • platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
4:34 PM Changeset in webkit [68607] by mrowe@apple.com
  • 4 edits in branches/safari-533.19-branch/WebKitTools

Build fix. Roll out some DRT changes that lack the necessary infrastructure to build correctly.

4:34 PM Changeset in webkit [68606] by vangelis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-28 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Keep the accelerated compositor around even after a page is
done using it to avoid startup costs in pages that frequently switch
the compositor on and off.
​https://bugs.webkit.org/show_bug.cgi?id=45845

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
4:19 PM Changeset in webkit [68605] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix typo in previous checkin.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

4:04 PM Changeset in webkit [68604] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-28 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] invalidateRootLayerRect needs to schedule compositor
​https://bugs.webkit.org/show_bug.cgi?id=46219

Update comments on LayerChromium commit/display functions to clarify
their limitations. Remove unused dirtying logic from
LayerRendererChromium.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::present):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-09-28 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] invalidateRootLayerRect needs to schedule compositor
​https://bugs.webkit.org/show_bug.cgi?id=46219

Make sure setRootLayerNedsDisplay is called by root invalidation.
To avoid confusion about root-layer versus non-root-layer
behavior, move the root layer damage state to the WebView.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::doComposite):
  • src/WebViewImpl.h:
4:02 PM Changeset in webkit [68603] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r67236.

4:00 PM Changeset in webkit [68602] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63865.

3:58 PM Changeset in webkit [68601] by mrowe@apple.com
  • 3 edits
    6 adds in branches/safari-533.19-branch

Merge r65329.

3:56 PM Changeset in webkit [68600] by mrowe@apple.com
  • 5 edits
    9 adds in branches/safari-533.19-branch

Merge r60608.

3:55 PM Changeset in webkit [68599] by tony@chromium.org
  • 6 edits in trunk/WebKitTools

2010-09-28 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

add python keyring support to webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=41269

  • Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using

the python keyring module

  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
  • Scripts/webkitpy/common/system/user_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:53 PM Changeset in webkit [68598] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r66911.

3:52 PM Changeset in webkit [68597] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r66052.

3:52 PM Changeset in webkit [68596] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ojan Vafai.

Fix perf/class-list-remove test
​https://bugs.webkit.org/show_bug.cgi?id=46745

Make sure we precompute the className in the setup functions and that
we reset it before calling classList.remove.

  • perf/class-list-remove.html:
3:50 PM Changeset in webkit [68595] by senorblanco@chromium.org
  • 7 edits in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

[CHROMIUM] Update test baselines after r68561.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
3:50 PM Changeset in webkit [68594] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r64158.

3:48 PM Changeset in webkit [68593] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65748.

3:47 PM Changeset in webkit [68592] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65090.

3:44 PM Changeset in webkit [68591] by mrowe@apple.com
  • 4 edits in branches/safari-533.19-branch

Merge r65280.

3:43 PM Changeset in webkit [68590] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68589] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68588] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68587] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68586] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68585] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68584] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:42 PM Changeset in webkit [68583] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvment for FontLinux

3:42 PM Changeset in webkit [68582] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r64293.

3:40 PM Changeset in webkit [68581] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r63622.

3:38 PM Changeset in webkit [68580] by mrowe@apple.com
  • 3 edits
    5 adds in branches/safari-533.19-branch

Merge r64077.

3:35 PM Changeset in webkit [68579] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.19-branch

Merge r63773.

3:33 PM Changeset in webkit [68578] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.19-branch

Merge r64083.

3:33 PM Changeset in webkit [68577] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r64028.

3:27 PM Changeset in webkit [68576] by commit-queue@webkit.org
  • 34 edits in trunk

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

No new tests. API addition only. Will be used in separate patch.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didTransferChildFrameToNewDocument):
  • loader/FrameLoaderClient.h:
  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): Pass former page to didTransferChildFrameToNewDocument.

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didTransferChildFrameToNewDocument):
  • src/FrameLoaderClientImpl.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didTransferChildFrameToNewDocument):

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didTransferChildFrameToNewDocument):
  • WebKitSupport/FrameLoaderClientWx.h:

2010-09-28 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
​https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:26 PM Changeset in webkit [68575] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65826.

3:26 PM Changeset in webkit [68574] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk

2010-09-28 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
​https://bugs.webkit.org/show_bug.cgi?id=42370

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-expected.txt: Added.
  • svg/custom/image-rescale.svg: Added.
  • svg/custom/resources/image-rescale.jpg: Added.

2010-09-28 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
​https://bugs.webkit.org/show_bug.cgi?id=42370

This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.

Test: svg/custom/image-rescale.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
3:24 PM Changeset in webkit [68573] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.19-branch

Merge r67390.

3:19 PM Changeset in webkit [68572] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68108.

3:19 PM Changeset in webkit [68571] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-09-28 James Robinson <​jamesr@chromium.org>

[chromium] Decrease warning level on chromium linux temporarily. This is causing failures on some bots

  • WebCore.gyp/WebCore.gyp:
3:14 PM Changeset in webkit [68570] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67209.

3:11 PM Changeset in webkit [68569] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63466.

3:10 PM Changeset in webkit [68568] by commit-queue@webkit.org
  • 71 edits in trunk/LayoutTests

2010-09-28 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Adele Peterson.

Unskip remaining canvas layout tests so that they can track progressions/regressions
​https://bugs.webkit.org/show_bug.cgi?id=46439

3:08 PM Changeset in webkit [68567] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r65847.

3:08 PM Changeset in webkit [68566] by mrowe@apple.com
  • 14 edits
    3 adds in branches/safari-533.19-branch

Merge r62896.

2:49 PM Changeset in webkit [68565] by senorblanco@chromium.org
  • 16 edits
    7 adds in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

[CHROMIUM] New chromium baselines post-r68334.

  • platform/chromium-linux/fast/text/basic/014-expected.checksum:
  • platform/chromium-linux/fast/text/basic/014-expected.png:
  • platform/chromium-linux/fast/text/basic/014-expected.txt: Added.
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.checksum:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.png:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/chromium-linux/fast/text/softHyphen-expected.txt: Added.
  • platform/chromium-linux/fast/text/word-break-soft-hyphen-expected.txt: Added.
  • platform/chromium-mac/fast/text/basic/014-expected.checksum: Added.
  • platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.checksum: Added.
  • platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.png: Added.
  • platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/chromium-win/fast/text/basic/014-expected.checksum:
  • platform/chromium-win/fast/text/basic/014-expected.png:
  • platform/chromium-win/fast/text/basic/014-expected.txt:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/chromium-win/fast/text/softHyphen-expected.txt:
  • platform/chromium-win/fast/text/word-break-soft-hyphen-expected.txt:
2:48 PM Changeset in webkit [68564] by jamesr@google.com
  • 10 edits in trunk/WebCore

2010-09-27 James Robinson <​jamesr@chromium.org>

Reviewed by Tony Chang.

[chromium] Increase warning level for chromium linux build
​https://bugs.webkit.org/show_bug.cgi?id=46687

This sets the chromium_code gyp variable to 1 for the chromium
linux WebCore build and fixes the warnings that exposes. This
matches the chromium mac build's compiler settings more closely
and should cut down on the number of patches that break mac but
compile cleaning on linux.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintButton):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
  • platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.h:
2:35 PM Changeset in webkit [68563] by Csaba Osztrogonác
  • 4 edits in trunk/WebCore

Fix for r68521 to build on VS2008/Release.

Patch by Stephen White <​senorblanco@chromium.org> on 2010-09-28
Reviewed by Csaba Osztrogonác.

  • html/DocTypeStrings.gperf:

Don't emit "#include <string.h>" here, since we're inside a namespace.

  • make-hash-tools.pl:

Emit #include <string.h> manually where required.

  • platform/ColorData.gperf:

Don't emit "#include <string.h>" here, since we're inside a namespace.

2:27 PM Changeset in webkit [68562] by andersca@apple.com
  • 4 edits in trunk/WebKit2

ASSERT when launching the plugin process
​https://bugs.webkit.org/show_bug.cgi?id=46754
<rdar://problem/8484570>

Reviewed by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Don't assert if we fail to launch the process. Instead, set the connection identifier
and process ID to null and deallocate the port we created.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Move all code from didClose here.

(WebKit::PluginProcessProxy::didClose):
Call pluginProcessCrashedOrFailedToLaunch.

(WebKit::PluginProcessProxy::didFinishLaunching):
If we failed to launch, call pluginProcessCrashedOrFailedToLaunch.

2:16 PM Changeset in webkit [68561] by hyatt@apple.com
  • 16 edits in trunk

Right now we have two properties named margin-top-collapse and margin-after-collapse. They are proprietary and only used by Safari RSS.

Reviewed by Sam Weinig.

I am adding margin-before-collapse and margin-after-collapse and just aliasing the old properties to the new ones.
This way we have some names that are directionally independent.

Note that these properties aren't like other directional properties. They are about what to do with the before side and after side of
your block's margins when collapsing with adjacent blocks. The meaning of before/after depend on the block-flow directionality
of the containing block.

Computed style tests all changed and the remove-shorthand.html test covers manipulation of the shorthand.

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::marginBeforeCollapse):
(WebCore::InheritedFlags::marginAfterCollapse):
(WebCore::InheritedFlags::setMarginBeforeCollapse):
(WebCore::InheritedFlags::setMarginAfterCollapse):
(WebCore::InheritedFlags::initialMarginBeforeCollapse):
(WebCore::InheritedFlags::initialMarginAfterCollapse):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:15 PM Changeset in webkit [68560] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fix, build sources that used to be built as part of other sources.

2:00 PM Changeset in webkit [68559] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Differentiate waitForSyncReply from waitForReply
​https://bugs.webkit.org/show_bug.cgi?id=46752

Reviewed by Sam Weinig.

Since waitForSyncReply is going to need to dispatch incoming sync messages while
waiting for the correct reply, we need to add a new waitForSyncReply function that
can do this.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
Push the pending sync reply information on the m_pendingSyncReplies stack,
send the message, wait for a reply and pop the information off the stack.

(CoreIPC::Connection::waitForSyncReply):
Block while waiting for a reply to the sync message with the given ID.

(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync reply, set the didReceiveReply flag and the replyDecoder
members in the pending sync reply and signal the client thread to wakeup.

  • Platform/CoreIPC/Connection.h:

Add a stack of PendingSyncReply structs.

1:45 PM Changeset in webkit [68558] by Martin Robinson
  • 5 edits
    4 adds in trunk

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
​https://bugs.webkit.org/show_bug.cgi?id=46740

Added a test adapted from platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html
which verifies that when rendering text the GTK+ port follows FontConfig settings.

  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.checksum: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.png: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings.html: Added.

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
​https://bugs.webkit.org/show_bug.cgi?id=46740

When creating a font from a FontConfig pattern, use the FontConfig pattern's
hinting and anti-aliasing settings. This follows the Chromium Linux approach
of having FontConfig settings take precedence over GTK+ settings, as GTK+
settings cannot be configured per-font and per-font-size.

Test: platform/gtk/fonts/fontconfig-aliasing-settings.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::convertFontConfigSubpixelOrder): Added this helper which converts the FontConfig subpixel order into the cairo equivalent. (WebCore::convertFontConfigHintStyle): Added this helper which converts the FontConfig hint style into the cairo equivalent. (WebCore::setCairoFontOptionsFromFontConfigPattern): Added this helper which reads the font rendering settings from a pattern and translates them into the appropriate cairo_font_options_t settings. (WebCore::FontPlatformData::FontPlatformData): When creating a font from a FontConfig pattern use setCairoFontOptionsFromFontConfigPattern to get the appropriate rendering options for the font.

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
​https://bugs.webkit.org/show_bug.cgi?id=46740

  • DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common fonts which can be used to fully test FontConfig rendering settings.
1:31 PM Changeset in webkit [68557] by weinig@apple.com
  • 11 edits in trunk

Vertical scroll bar on apple.com is too short with WebKit2
<rdar://problem/8379230>
​https://bugs.webkit.org/show_bug.cgi?id=46739

Reviewed by Darin Adler and Dave Hyatt.

WebCore:

Adds a function to recalculate the scrollbars to take advantage of
a changed window re-sizer rect.

  • WebCore.exp.in:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::windowResizerRectChanged):

  • platform/ScrollView.h:

WebKit2:

This gets us most of the way to having correct scroll corner behavior. We should
follow this up by moving to painting the window re-sizer in WebCore.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _ownsWindowGrowBox]):
(-[WKView _updateGrowBoxForWindowFrameChange]): Calculate whether we should
be taking the scroll corner into account when laying out scrollbars.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowResizerSize):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowResizerSize):
(WebKit::WebPage::windowResizerRect): This now returns IntRect() for
non-mac platforms (or any platform that never sends a setWindowResizerSize
message).

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
1:28 PM Changeset in webkit [68556] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46750

Reviewed by Sam Weinig.

Rename the MarginInfo members and functions to be block-flow independent.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::applyAfterBreak):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::setAtBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setAtAfterSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::setMarginAfterQuirk):
(WebCore::RenderBlock::MarginInfo::setDeterminedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::atBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginBefore):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginAfter):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginBeforeWithChildren):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::determinedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginAfterQuirk):

1:19 PM Changeset in webkit [68555] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected result to include the soft hyphen character in the plain text output.

  • fast/encoding/charset-xuser-defined-expected.txt:
1:15 PM Changeset in webkit [68554] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[gtk] Fedora has a different path for the liberation fonts
​https://bugs.webkit.org/show_bug.cgi?id=46709

When searching for DRT fonts, also look in the path where those fonts
are commonly found on Fedora systems.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Include logic for looking for Fedora-style font paths.
1:14 PM Changeset in webkit [68553] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added Qt-specific results for the test added in the previous change. Qt doesn’t use ICU so
it fails the test.

  • platform/qt/fast/text/find-soft-hyphen-expected.txt: Added.
12:51 PM Changeset in webkit [68552] by Martin Robinson
  • 4 edits in trunk/WebKitTools

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

run-webkit-tests needs an updated list of directories with webgl tests
​https://bugs.webkit.org/show_bug.cgi?id=46747

Update the list of directories containing WebGL tests and a unit test
which depends on this list.

  • Scripts/old-run-webkit-tests: Update the list of directories.
  • Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
12:38 PM Changeset in webkit [68551] by mitz@apple.com
  • 30 edits
    3 adds in trunk

WebCore: Improved the handling of soft hyphens in Copy and Find operations, addressing the following
bugs:

Reviewed by Darin Adler.

<rdar://problem/7938878> Soft hyphenation and the clipboard
​https://bugs.webkit.org/show_bug.cgi?id=11154

window.getSelection().toString() breaks soft hyphen &shy;
​https://bugs.webkit.org/show_bug.cgi?id=26774

<rdar://problem/5640505> soft hyphen breaks search function
​https://bugs.webkit.org/show_bug.cgi?id=16675

Test: fast/text/find-soft-hyphen.html

Changed line layout code to not skip over soft hyphens but rather include them in the text
boxes. Changed font code to render the soft hyphen character as a zero width space, so that
the former change will not affect rendering of soft hyphens in the middle of the line. Also
changed line layout code to mark text boxes where hyphenation occurred due to a soft hyphen
as hyphenated, so that the hyphen string specified in CSS will be appended to them.

Not omitting the soft hyphens from the text boxes makes the text iterator emit them, which
solves the Copy and plain-text conversion issues. Previously, the iterator would emit a space
to account for non-rendered characters between adjacent boxes, which was wrong in this case.

To make Find work, soft hyphens are folded into 0, which is ignorable in the collation used
for Find.

  • editing/TextIterator.cpp:

(WebCore::foldQuoteMarkOrSoftHyphen): Renamed foldQuoteMark() to this and added folding of
soft hyphen to 0.
(WebCore::foldQuoteMarksAndSoftHyphens): Renamed foldQuoteMarks() to thid and added folding
of soft hyphen to 0.
(WebCore::SearchBuffer::SearchBuffer): Updated for renames.
(WebCore::SearchBuffer::append): Ditto.

  • platform/graphics/Font.h:

(WebCore::Font::treatAsSpace): Replaced number literal with name.
(WebCore::Font::treatAsZeroWidthSpace): Added softHyphen.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage): Get the zero width space glyph for soft hyphen.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): Removed special handling that made
a trailing soft hyphen render as hyphen-minus. All soft hyphens are now rendered as zero width
spaces, and where a line break actually occurs at a soft hyphen, rendering code appends the
CSS-specified hyphenate character to the text run that is passed to us here.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::chopMidpointsAt): Removed this function, which was only used for skipping over soft
hyphens.
(WebCore::checkMidpoints): Removed code related to skipping over soft hyphens.
(WebCore::RenderBlock::findNextLineBreak): Removed code to skip over soft hyphens. Ignore
a line break opportunity at a soft hyphen if the style specifies 'hyphens: none'. Set
'hyphenated' to true if a line break occurs at a soft hyphen.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::hyphenString): Changed the assertion to allow querying for the hyphen
string for 'hyphens: manual'.

LayoutTests: Improved the handling of soft hyphens in copy and find operations, addressing the following
bugs:

Reviewed by Darin Adler.

<rdar://problem/7938878> Soft hyphenation and the clipboard
​https://bugs.webkit.org/show_bug.cgi?id=11154

window.getSelection().toString() breaks soft hyphen &shy;
​https://bugs.webkit.org/show_bug.cgi?id=26774

<rdar://problem/5640505> soft hyphen breaks search function
​https://bugs.webkit.org/show_bug.cgi?id=16675

  • fast/text/find-soft-hyphen-expected.txt: Added.
  • fast/text/find-soft-hyphen.html: Added.
  • fast/text/script-tests/find-soft-hyphen.js: Added.

(canFind):

  • platform/mac/fast/text/basic/014-expected.checksum:
  • platform/mac/fast/text/basic/014-expected.png:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphens-expected.checksum:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.png:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
  • platform/mac/fast/text/soft-hyphen-3-expected.png:
  • platform/mac/fast/text/soft-hyphen-3-expected.txt:
  • platform/mac/fast/text/softHyphen-expected.checksum:
  • platform/mac/fast/text/softHyphen-expected.png:
  • platform/mac/fast/text/softHyphen-expected.txt:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.checksum:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.png:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.txt:
12:33 PM Changeset in webkit [68550] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-28 Martin Robinson <​mrobinson@igalia.com>

More GTK+ build fixes after r68521.

  • GNUmakefile.am: Added proper dependency tracking for some new autogenerated files.
12:19 PM Changeset in webkit [68549] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Text drawing taints GraphicsContext's QPainter::pen()
​https://bugs.webkit.org/show_bug.cgi?id=46744

Test: fast/canvas/canvas-style-intact-after-text.html

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Make sure the QPainter's pen is restored after filling and/or stroking text.

2010-09-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Text drawing taints GraphicsContext's QPainter::pen()
​https://bugs.webkit.org/show_bug.cgi?id=46744

Add test to check that strokeText() doesn't break the fillStyle
and fillText() doesn't break the strokeStyle.

  • fast/canvas/canvas-style-intact-after-text-expected.txt: Added.
  • fast/canvas/canvas-style-intact-after-text.html: Added.
  • fast/canvas/script-tests/canvas-style-intact-after-text.js: Added.
12:14 PM Changeset in webkit [68548] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-09-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce FailureMap to summaries the failures status of all the bots
​https://bugs.webkit.org/show_bug.cgi?id=46700

This patch gives the SheriffBot a handle on the list of failing tests.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/failuremap.py: Added.
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
11:48 AM Changeset in webkit [68547] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-28 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Autocorrection panel is shown at incorrect location when WebView is scrolled.
​https://bugs.webkit.org/show_bug.cgi?id=46531
<rdar://problem/8455376>

  • dom/Range.h: Make getBorderAndTextQuads() public so that it can be used by Editor.
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced call to textQuads() with getBorderAndTextQuads().
11:28 AM Changeset in webkit [68546] by andreip@google.com
  • 15 edits in trunk

2010-09-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest should not have a method called abort.
​https://bugs.webkit.org/show_bug.cgi?id=46720

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/resources/shared.js: (verifyEventCommon): (verifyResult):
  • storage/indexeddb/transaction-basics-expected.txt:

2010-09-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest should not have a method called abort.
​https://bugs.webkit.org/show_bug.cgi?id=46720

IDBRequest::abort() was dropped from the spec following discussion in
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=10165

  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::scheduleEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:
11:12 AM Changeset in webkit [68545] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement PluginProxy::destroy
​https://bugs.webkit.org/show_bug.cgi?id=46737

Reviewed by Adam Roben.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add overload for a sync message with one in parameter and no out parameters.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::destroyPluginControllerProxy):
Rename this to avoid conflicts with the destroyPlugin message handler.

(WebKit::WebProcessConnection::destroyPlugin):
Call destroyPluginControllerProxy.

  • PluginProcess/WebProcessConnection.messages.in:

Add DestroyPlugin message.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::~PluginProxy):
Don't add and/the plug-in proxy from the map in the constructor/destructor. Instead,
do it in initialize/destroy, since otherwise we could be calling pluginProcessCrashed on a
PluginController that had already been freed.

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::destroy):
send the DestroyPlugin message.

11:10 AM Changeset in webkit [68544] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added editing/pasteboard/paste-table-001.html to the skipped list of gtk platforms
because the test requires editing delegates dump and gtk does not implement it yet.

  • platform/gtk/Skipped:
11:08 AM Changeset in webkit [68543] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations update.

[CHROMIUM] Mark window-geometry-initialized-before-set-window as failing.

  • platform/chromium/test_expectations.txt:
11:05 AM Changeset in webkit [68542] by kevino@webkit.org
  • 2 edits in trunk

[wx] One more build fix for Win.

10:59 AM Changeset in webkit [68541] by Chris Fleizach
  • 8 edits
    2 adds in trunk

CrashTracer: 1,382 crashes in Safari at com.apple.WebCore: WebCore::VisiblePosition::canonicalPosition + 78
​https://bugs.webkit.org/show_bug.cgi?id=45927

Reviewed by Beth Dakin.

WebCore:

AXTextMarkers store pointers to Nodes without any retain or reference. If a Node is deallocated and then
a client tries to use a text marker that references that node, it leads to this crash.

The AXObjectCache instance now keeps a HashSet of Node's being used. When a node becomes deallocated, it removes itself
from the HashSet. When creating a VisiblePosition from an AXTextMarker, the cache can then check if the node is valid
before proceeding.

Test: platform/mac/accessibility/crash-invalid-text-marker-node.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

Modify to check whether a node is valid before proceeeding.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):

Methods for managing whether a node is in use by text markers.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Change these calls so that the axObjectCache() can be passed in to create the visible position.

  • dom/Document.cpp:

(WebCore::Document::axObjectCacheExists):

  • dom/Document.h:
  • dom/Node.cpp:

(WebCore::Node::~Node):

If accessibility is enabled, inform the axObjectCache() that this node is disappearing.

LayoutTests:

  • platform/mac/accessibility/crash-invalid-text-marker-node-expected.txt: Added.
  • platform/mac/accessibility/crash-invalid-text-marker-node.html: Added.
10:55 AM Changeset in webkit [68540] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-28 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioDestinationNode files
​https://bugs.webkit.org/show_bug.cgi?id=45009

No new tests since audio API is not yet implemented.

  • webaudio/AudioDestinationNode.cpp: Added. (WebCore::AudioDestinationNode::AudioDestinationNode): (WebCore::AudioDestinationNode::~AudioDestinationNode): (WebCore::AudioDestinationNode::initialize): (WebCore::AudioDestinationNode::uninitialize): (WebCore::AudioDestinationNode::provideInput):
  • webaudio/AudioDestinationNode.h: Added. (WebCore::AudioDestinationNode::create): (WebCore::AudioDestinationNode::process): (WebCore::AudioDestinationNode::reset): (WebCore::AudioDestinationNode::currentTime): (WebCore::AudioDestinationNode::sampleRate): (WebCore::AudioDestinationNode::numberOfChannels):
  • webaudio/AudioDestinationNode.idl: Added.
10:43 AM Changeset in webkit [68539] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-28 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: audio output classes
​https://bugs.webkit.org/show_bug.cgi?id=34716

No new tests since audio API is not yet implemented.

  • platform/audio/AudioDestination.h: Added. (WebCore::AudioDestination::~AudioDestination):
  • platform/audio/mac/AudioDestinationMac.cpp: Added. (WebCore::AudioDestination::create): (WebCore::AudioDestination::hardwareSampleRate): (WebCore::AudioDestinationMac::AudioDestinationMac): (WebCore::AudioDestinationMac::~AudioDestinationMac): (WebCore::AudioDestinationMac::configure): (WebCore::AudioDestinationMac::start): (WebCore::AudioDestinationMac::stop): (WebCore::AudioDestinationMac::render): (WebCore::AudioDestinationMac::inputProc):
  • platform/audio/mac/AudioDestinationMac.h: Added. (WebCore::AudioDestinationMac::isPlaying): (WebCore::AudioDestinationMac::sampleRate):
10:43 AM Changeset in webkit [68538] by Adam Roben
  • 19 edits
    5 copies in trunk

Tell the UI client when a key event is not handled

When the web process receives an event, it sends a
WebPageProxyMessage::DidReceiveEvent message back to the UI process.
That message is now sent after handling the event, and includes a
boolean signifying whether or not the event was actually handled.

Every time WebPageProxy receives a key event, it adds it to a queue.
When it receives a WebPageProxyMessage::DidReceiveEvent for a key
event, the event is removed from the queue. If the event was not
handled, we tell the UI client.

Fixes <​http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
tell a WebKit2 client application that a key event was not handled

Reviewed by Kenneth Rohde Christiansen and Sam Weinig.

WebKit2:

  • Shared/NativeWebKeyboardEvent.h: Added. This class wraps a

WebKeyboardEvent and the native event that was used to construct it.
(WebKit::NativeWebKeyboardEvent::nativeEvent): Simple getter.

  • Shared/WebEvent.h: Made isKeyboardEventType public for

WebPageProxy's benefit.

  • Shared/mac/NativeWebKeyboardEventMac.mm: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • Shared/qt/NativeWebKeyboardEventQt.cpp: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • Shared/win/NativeWebKeyboardEventWin.cpp: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
The constructor creates a WebKeyboardEvent and stores the native
event.

  • UIProcess/API/C/WKNativeEvent.h: Added.
  • UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleKeyEventCallback

and WKPageUIClient::didNotHandleKeyEvent.

  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onKeyEvent):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
Changed to use NativeWebKeyboardEvent.

(QWKPage::QWKPage): Updated for addition of didNotHandleKeyEvent.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleKeyboardEvent): Changed to take a
NativeWebKeyboardEvent and to add it to m_keyEventQueue.
(WebKit::WebPageProxy::didReceiveMessage): Changed to expect a boolean
parameter in WebPageProxyMessage::DidReceiveEvent.
(WebKit::WebPageProxy::didReceiveEvent): Added a boolean "handled"
parameter. If the event was a keyboard event, we remove it from
m_keyEventQueue, and if it wasn't handled by WebCore, we tell the UI
client.

  • UIProcess/WebPageProxy.h: Added m_keyEventQueue.
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::didNotHandleKeyEvent):

  • UIProcess/WebUIClient.h:

Added. Just calls through to the WKPageUIClient.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::handleWheelEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::handleKeyEvent):
(WebKit::WebPage::keyEvent):
(WebKit::handleTouchEvent):
(WebKit::WebPage::touchEvent):
Moved code from the *Event functions into new helper handle*Event
functions, and changed to pass a boolean to
WebPageProxyMessage::DidReceiveEvent signaling whether the event was
handled or not.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Added WKNativeEvent.h and NativeWebKeyboardEvent.

WebKitTools:

Update for the addition of WKPageUIClient::didNotHandleKeyEvent

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

Conflicts:

WebKit2/WebKit2.xcodeproj/project.pbxproj

10:41 AM Changeset in webkit [68537] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-28 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioGain files
​https://bugs.webkit.org/show_bug.cgi?id=46285

No new tests since audio API is not yet implemented.

  • webaudio/AudioGain.h: Added. (WebCore::AudioGain::create): (WebCore::AudioGain::AudioGain):
  • webaudio/AudioGain.idl: Added.
10:33 AM Changeset in webkit [68536] by rniwa@webkit.org
  • 4 edits
    3 adds
    30 deletes in trunk/LayoutTests

2010-09-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/pasteboard/paste-4039777-fix.html, paste-list-001.html, and paste-table-001.html
​https://bugs.webkit.org/show_bug.cgi?id=46545

Converted the following tests to dump-as-markup tests:
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-table-001.html

  • editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • editing/pasteboard/paste-4039777-fix.html:
  • editing/pasteboard/paste-list-001-expected.txt: Added.
  • editing/pasteboard/paste-list-001.html:
  • editing/pasteboard/paste-table-001-expected.txt: Added.
  • editing/pasteboard/paste-table-001.html:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt: Removed.
10:31 AM Changeset in webkit [68535] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-28 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fix possible illegal float values in AudioParam
​https://bugs.webkit.org/show_bug.cgi?id=46681

No new tests since audio API is not yet implemented.

  • webaudio/AudioParam.h: (WebCore::AudioParam::setValue):
10:30 AM Changeset in webkit [68534] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Improve plug-in process lifecycle handling
​https://bugs.webkit.org/show_bug.cgi?id=46734

Reviewed by Adam Roben.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::destroyPlugin):
Destroy and delete the plug-in.

(WebKit::WebProcessConnection::didClose):
Our web process crashed, go through and delete all plug-in instances.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didClose):
The plug-in process crashed. Go through all pending replies and send them so the
web processes won't be blocked waiting for a reply.

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
We need to remove the pending reply connection once we've sent the reply.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):
The plug-in process crashed. Iterate over all proxies and let them know that the plug-in
process has crashed.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginProcessCrashed):
Tell our controller that the plug-in process crashed.

(WebKit::PluginProxy::destroy):
Null out the controller.

10:21 AM WebKitGtkLayoutTests edited by Martin Robinson
Updated to reflect new font requirements and calling convention (diff)
10:14 AM Changeset in webkit [68533] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp

Fix the Qt build

10:03 AM Changeset in webkit [68532] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Rename member variable in MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
9:54 AM Changeset in webkit [68531] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Implement PluginControllerProxy::initialize and have it create a plug-in
​https://bugs.webkit.org/show_bug.cgi?id=46731

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Create the plug-in and try to initialize it.

(WebKit::PluginControllerProxy::destroy):
Destroy the plug-in.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
Add the given plug-in controller proxy to the map and assume ownership of it.

(WebKit::WebProcessConnection::removePluginControllerProxy):
Remove the given plug-in controller proxy from the map and delete it.

(WebKit::WebProcessConnection::createPlugin):
Create a plug-in controller proxy and try to initialize it.

9:49 AM Changeset in webkit [68530] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

Unreviewed.

Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
for the test order, but instead use information from testinfo.data.

  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js:
9:46 AM Changeset in webkit [68529] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Andras Becsi <​abecsi@webkit.org>

[Gtk] Build fix. Remove leftover trailing backslash.

  • GNUmakefile.am:
9:41 AM Changeset in webkit [68528] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Unreviewed.

[Gtk] Build fix after r68521

No new tests needed.

  • GNUmakefile.am:
9:39 AM Changeset in webkit [68527] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

[CHROMIUM] Fix duplicate expectations (again).

  • platform/chromium/test_expectations.txt:
9:21 AM Changeset in webkit [68526] by vestbo@webkit.org
  • 6 edits in trunk/WebCore

[Qt] Rename MediaPlayerPrivate to MediaPlayerPrivateQt/Phonon

Reviewed by Andreas Kling.

​https://bugs.webkit.org/show_bug.cgi?id=36663

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
9:20 AM Changeset in webkit [68525] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-09-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean up QWebPage::ViewportConfiguration API
​https://bugs.webkit.org/show_bug.cgi?id=46730

  • Pass QSize parameter as const-reference
  • Style fixes
  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • Api/qwebpage.h:
9:17 AM Changeset in webkit [68524] by kevino@webkit.org
  • 5 edits in trunk

[wx] Build fixes for recent changes.

9:14 AM Changeset in webkit [68523] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

[CHROMIUM] Fix duplicate expectations.

  • platform/chromium/test_expectations.txt:
9:07 AM Changeset in webkit [68522] by andersca@apple.com
  • 4 edits
    1 copy
    1 add in trunk/WebKit2

Add PluginControllerProxy class
​https://bugs.webkit.org/show_bug.cgi?id=46728

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp: Added.
  • PluginProcess/PluginControllerProxy.h: Added.

Add stubbed out PluginControllerProxy class.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::~WebProcessConnection):
Assert that we don't have any live plug-in controller proxies.

(WebKit::WebProcessConnection::addPluginControllerProxy):
Add the plug-in controller proxy to the map.

(WebKit::WebProcessConnection::removePluginControllerProxy):
Remove the plug-in controller proxy from the map. If the last plug-in controller
proxy went away, invalidate the connection.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

9:01 AM Changeset in webkit [68521] by abecsi@webkit.org
  • 18 edits in trunk

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <​leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <​leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

No new tests needed.

  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:
  • css/makeprop.pl:
  • css/makevalues.pl:
  • html/DocTypeStrings.gperf:
  • html/HTMLDocument.cpp:
  • make-hash-tools.pl:
  • platform/ColorData.gperf:
  • platform/graphics/Color.cpp:

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <​leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

  • cmake/WebKitMacros.cmake:
8:44 AM Changeset in webkit [68520] by Adam Roben
  • 8 edits
    4 adds in trunk

Don't call NPP_SetWindow until the plugin's HWND has been sized/positioned

Test: platform/win/plugins/window-geometry-initialized-before-set-window.html

Reviewed by Anders Carlsson.

Fixes <​http://webkit.org/b/46716> <rdar://problem/8482014> Full-page
Adobe Reader does not paint until window is resized

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange): Call NPP_SetWindow after
updating the platform (HWND) geometry.

WebKitTools:

Test that a plugin's HWND is sized/positioned before NPP_SetWindow is called

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
this level.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared

NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.

(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
the plugin's HWND has a non-zero size and that its size/position
matches that specified in the NPWindow.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow): Call through to the PluginTest.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
the files as it saw fit.

LayoutTests:

Test that a plugin's HWND is sized/positioned before NPP_SetWindow is called

  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win/plugins/window-geometry-initialized-before-set-window.html: Added.
8:43 AM Changeset in webkit [68519] by Adam Roben
  • 2 edits in trunk/LayoutTests

Start running plugins tests in WebKit2 on Windows

Fixes <​http://webkit.org/b/46675> <rdar://problem/8484269>

Reviewed by John Sullivan.

  • platform/win-wk2/Skipped: Removed the plugins and

platform/win/plugins directories and added individual failing tests.
plugins/geturlnotify-during-document-teardown.html and
plugins/mouse-events-fixedpos.html will also fail on SnowLeopard, but
they're already skipped there on both WebKit1 and WebKit2 thanks to
platform/mac-snowleopard/Skipped.

8:29 AM Changeset in webkit [68518] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Out of process plug-ins shouldn't be turned on just yet...

  • WebKit2Prefix.h:
8:09 AM Changeset in webkit [68517] by andreas.kling@nokia.com
  • 13 edits in trunk/WebKit/qt

2010-09-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
​https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::sceneEvent): (QGraphicsWebViewPrivate::detachCurrentPage):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::handleSoftwareInputPanel): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::touchEvent): (QWebPage::inputMethodQuery): (QWebPage::view): (QWebPage::event):
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp: (QWebView::QWebView): (QWebViewPrivate::detachCurrentPage): (QWebView::event):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQWidget::setInputMethodHints): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHints):
  • WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page):
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods_data): (inputMethodHints): (inputMethodEnabled): (tst_QWebPage::inputMethods): (tst_QWebPage::originatingObjectInNetworkRequests):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
7:57 AM Changeset in webkit [68516] by Philippe Normand
  • 5 edits in trunk/JavaScriptCore

2010-09-28 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Guard GRefPtr/GOwnPtr files with ENABLE(GLIB_SUPPORT)
​https://bugs.webkit.org/show_bug.cgi?id=46721

Enable GOwnPtr/GRefPtr build only if glib support has been
explicitly enabled using the WTF_ENABLE_GLIB_SUPPORT macro.

  • wtf/gobject/GOwnPtr.cpp:
  • wtf/gobject/GOwnPtr.h:
  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:
7:51 AM Changeset in webkit [68515] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] ProcessLauncherHelper should not leave stray socket files in /tmp.
​https://bugs.webkit.org/show_bug.cgi?id=46722

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): close the socket. (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): delete the helper on exit.
7:40 AM Changeset in webkit [68514] by benjamin.poulain@nokia.com
  • 9 edits in trunk/WebKitTools

2010-09-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
​https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): (EventSender::updateTouchPoint): (EventSender::setTouchModifier): (EventSender::touchStart): (EventSender::touchMove): (EventSender::touchEnd): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::sendTouchEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText):
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::applyZoom): (LauncherWindow::setTouchMocking):
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/utils.cpp: (urlFromUserInput):
  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setYRotation):
7:24 AM Changeset in webkit [68513] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Crash when setting a font with size in 'ex' units
​https://bugs.webkit.org/show_bug.cgi?id=46538

update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)

Fixes crash on IE test center's canvas-text-font-002 test.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Crash when setting a font with size in 'ex' units
​https://bugs.webkit.org/show_bug.cgi?id=46538

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
  • fast/canvas/canvas-font-ex-units-crash.html: Added.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.
7:23 AM Changeset in webkit [68512] by benjamin.poulain@nokia.com
  • 4 edits in trunk/WebKit2

2010-09-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
​https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::event):
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage_p.h:
7:14 AM Changeset in webkit [68511] by andreas.kling@nokia.com
  • 6 edits in trunk

2010-09-28 İsmail Dönmez <​ismail@namtrac.org>

Reviewed by Andreas Kling.

Test for WINCE instead of WINCEBASIC, compiler always defines WINCE.
Remove reference to unexisting path JavaScriptCore/os-wince.

2010-09-28 İsmail Dönmez <​ismail@namtrac.org>

Reviewed by Andreas Kling.

Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
which should point to wcecompat installation. Needs wcecompat
library from ​http://github.com/mauricek/wcecompat .

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
7:09 AM Changeset in webkit [68510] by benjamin.poulain@nokia.com
  • 6 edits in trunk/WebCore

2010-09-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt 4.5
​https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • WebCore.pro:
  • features.pri:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/QWebPageClient.h:
5:52 AM Changeset in webkit [68509] by satish@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Satish Sampath <​satish@chromium.org>

Unreviewed, enable a couple of speech input layout tests in chromium as they run successfully now.

  • platform/chromium/test_expectations.txt:
5:30 AM Changeset in webkit [68508] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Clean up QWebPage initialization

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
  • Api/qwebpage_p.h:
5:18 AM Changeset in webkit [68507] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::testStopScheduledPageRefresh() fails on MeeGo handset
​https://bugs.webkit.org/show_bug.cgi?id=46706

The test require the network to succeed or fail in order to work.
On MeeGo, the network can simply timeout the because of the netword access
management. This patch makes the test use local URLs to avoid the
problem.

  • tests/qwebpage/tst_qwebpage.cpp: (TestNetworkManager::TestNetworkManager):
4:40 AM Changeset in webkit [68506] by vestbo@webkit.org
  • 2 edits in trunk/BugsSite

Convert verbatim unicode values in comitter names to characters

Reviewed by Csaba Osztrogonác.

  • committers-autocomplete.js:
4:13 AM Changeset in webkit [68505] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] 3 media tests fail with Qt version 4.6.3 and 4.7.0
​https://bugs.webkit.org/show_bug.cgi?id=46249

  • platform/qt/Skipped: 3 failing media tests added until fix.
3:52 AM Changeset in webkit [68504] by andreip@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-28 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Linking error due to wrong guard in WebIDBTransaction.h
​https://bugs.webkit.org/show_bug.cgi?id=46710

Remove the wrong guard.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
3:52 AM Changeset in webkit [68503] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <​morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
3:35 AM Changeset in webkit [68502] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix generation of WebPageMessages.h and WebPageMessageReceiver.cpp
to avoid rebuilding them every time.

  • DerivedSources.pro: add target to extra compilers.
2:39 AM Changeset in webkit [68501] by alex
  • 4 edits in trunk/LayoutTests

2010-09-28 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, GTK+ rebaselines.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
2:36 AM Changeset in webkit [68500] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Kent Tamura <​tkent@chromium.org>

Unreviewed, run sort-Xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
2:26 AM Changeset in webkit [68499] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

2010-09-28 Huahui Wu <​mediadependent@gmail.com>

Reviewed by Steve Block.

Add two multi-touch tests for Android.
​https://bugs.webkit.org/show_bug.cgi?id=45221

The original tests (touch-target.html and basic-multi-touch-events.html)
requires the system being able to release one point while maintain another point.
Current Android system can not provide this to browser, hence these tests are
slightly modified for Android. Since these are limited version of the original ones,
other platforms should pass these tests if they can pass the original ones.

  • fast/events/touch/basic-multi-touch-events-limited-expected.txt: Added.
  • fast/events/touch/basic-multi-touch-events-limited.html: Added.
  • fast/events/touch/script-tests/basic-multi-touch-events-limited.js: Added. (touchEventCallback): (verifyTouchEvent): (verifyTouchPoint): (verifyTouch): (multiTouchSequence):
  • fast/events/touch/script-tests/touch-target-limited.js: Added. (touchStartHandler): (touchMoveHandler):
  • fast/events/touch/touch-target-limited-expected.txt: Added.
  • fast/events/touch/touch-target-limited.html: Added.

2010-09-28 Huahui Wu <​mediadependent@gmail.com>

Reviewed by Steve Block.

Add multi-touch for Android.
​https://bugs.webkit.org/show_bug.cgi?id=45221

The Android touch event used to take one point as the touch point,
it's now changed to a vector of points to support multi-touch.

Tests: fast/events/touch/basic-multi-touch-events-limited.html

fast/events/touch/touch-target-limited.html

  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/android/PlatformTouchPointAndroid.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2:24 AM Changeset in webkit [68498] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <​morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
1:32 AM Changeset in webkit [68497] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <​morrita@google.com>

Unreviewed, removed some expectations.

  • platform/chromium/test_expectations.txt:
12:25 AM Changeset in webkit [68496] by dbates@webkit.org
  • 11 edits in trunk/WebKitTools

2010-09-28 Daniel Bates <​dbates@rim.com>

Rollout changeset 68493 <​http://trac.webkit.org/changeset/68493>
<​https://bugs.webkit.org/show_bug.cgi?id=39136>

Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
In particular, this change caused Sheriffbot to raise an exception when
trying to parse the bug id on a bug page. We need to look into this
some more.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
12:21 AM Changeset in webkit [68495] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move RegressionWindow further up the dependency chain
​https://bugs.webkit.org/show_bug.cgi?id=46698

Baby steps towards pushing this information into bug posts.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/queries.py:
12:09 AM Changeset in webkit [68494] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

Fix assertion failure in a case that the dirty flag of a textarea element is changed
​https://bugs.webkit.org/show_bug.cgi?id=45681

Reviewed by Alexey Proskuryakov.

WebCore:

We need to call setNeedsValidityCheck() after updating m_isDirty.

Test: fast/forms/textarea-checkValidity-crash.html

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):
(WebCore::HTMLTextAreaElement::setValueCommon):

  • html/HTMLTextAreaElement.h:

LayoutTests:

  • fast/forms/textarea-checkValidity-crash-expected.txt: Added.
  • fast/forms/textarea-checkValidity-crash.html: Added.
Note: See TracTimeline for information about the timeline view.