Timeline
Sep 30, 2010:
- 11:41 PM Changeset in webkit [68866] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The WebSocket server should flush its logs
https://bugs.webkit.org/show_bug.cgi?id=46946
The WebSocket server logs are truncated because the driver just
terminates the child. It should run Python without buffering so we can
see the end of the log.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 10:58 PM Changeset in webkit [68865] by
-
- 6 edits in trunk
2010-09-30 MORITA Hajime <morrita@google.com>
Reviewed by James Robinson.
[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955
Added ifdef guard around SharedGraphicsContext3D.
No new tests. just a build fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):
2010-09-30 MORITA Hajime <morrita@google.com>
Reviewed by James Robinson.
[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955
Added ifdef guard around SharedGraphicsContext3D.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
- src/WebViewImpl.h:
- 10:33 PM WebCoreRendering edited by
- (diff)
- 10:09 PM Changeset in webkit [68864] by
-
- 3 edits in trunk/WebCore
2010-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Chris Fleizach.
[Windows] Implement <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=38381
Implement theme drawing for inner-spin-button.
No new tests. Existing tests for type=number will cover this change.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): Handle m_spinButtonTheme. (WebCore::RenderThemeWin::spinButtonTheme): ditto. (WebCore::RenderThemeWin::close): ditto. (WebCore::RenderThemeWin::determineClassicState): Add ControlSubPart parameter, and add support for InnerSpinButtonPart. (WebCore::RenderThemeWin::determineSpinButtonState): Added. (WebCore::RenderThemeWin::getClassicThemeData): Add ControlSubPart parameter, and handle InnerSpinButtonPart. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle): Set SM_CXVSCROLL value to the width. (WebCore::RenderThemeWin::paintInnerSpinButton): Call drawControl() for the upper part and the lower part.
- rendering/RenderThemeWin.h:
- 10:05 PM Changeset in webkit [68863] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Add recent failures.
- 9:51 PM Changeset in webkit [68862] by
-
- 2 edits in trunk/WebCore
Unreviewed, Windows build fix for r68854
- WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCore/html/parser/*.h.
- 8:55 PM Changeset in webkit [68861] by
-
- 4 edits in trunk/WebKitTools
2010-09-30 Simon Fraser <Simon Fraser>
Add a button to jump to the next untested test.
- CSSTestSuiteHarness/harness/harness.css: (.test-type): (.name > button):
- CSSTestSuiteHarness/harness/harness.html:
- CSSTestSuiteHarness/harness/harness.js: (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.testInfoDataLoaded): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.buildTestListForChapter): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.testCompletionStateChanged):
- 8:25 PM Changeset in webkit [68860] by
-
- 3 edits2 adds in trunk
2010-09-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
While updating :before and :after content, make sure that the generated
container is allowed to add the child type.
https://bugs.webkit.org/show_bug.cgi?id=46106
Test: fast/css-generated-content/text-before-table-col-crash.html
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
2010-09-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Tests that adding text to a :before container that is styled as a
table column group does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46106
- fast/css-generated-content/text-before-table-col-crash-expected.txt: Added.
- fast/css-generated-content/text-before-table-col-crash.html: Added.
- 6:35 PM Changeset in webkit [68859] by
-
- 2 edits41 adds in trunk/LayoutTests
Not reviewed. Build fix.
Adjust test expectations for Chromium.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:24 PM Changeset in webkit [68858] by
-
- 2 edits in trunk/WebCore
2010-09-30 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Daniel Bates.
[GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=46886
Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().
So far, this assertion made sense because it was not possible that
a call to listMarkerSuffix() happened when the style of the list
item was one of the following: Asterisks, Circle, Discm Footnotes,
NoneListStyle or Square (it's easy to figure this out by checking
the functions where listMarkerSuffix() was called).
However, since revision 68415 (about bug 45381), there's a new
place where listMarkerSuffix() is being called (the suffix()
public method), regardless of the style of the item being or not
one of those pointed out, so the aforementioned assertion in
listMarkerSuffix() would no longer be correct, as now it's ok to
reach those cases in the switch statement.
- rendering/RenderListMarker.cpp: (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().
- 6:22 PM Changeset in webkit [68857] by
-
- 5 edits in branches/safari-533.19-branch
Build fixes.
- 6:13 PM Changeset in webkit [68856] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
whitespace separators for mfenced
Reviewed by Adele Peterson.
WebCore:
Check the size of characters instead of separators in case all the
separators were whitespace.
- mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
LayoutTests:
- mathml/fenced-whitespace-separators-crash-expected.txt: Added.
- mathml/fenced-whitespace-separators-crash.html: Added.
- 5:39 PM Changeset in webkit [68855] by
-
- 4 edits in trunk/LayoutTests
2010-09-30 Simon Fraser <Simon Fraser>
Reviewed by Jon Honeycutt.
REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
https://bugs.webkit.org/show_bug.cgi?id=46913
REGRESSION (r65681): platform/win/accessibility/img-alt-attribute.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46914
<rdar://problem/8497332&8497393>
Fix two layout tests that made incorrect assumptions about the structure of the
accessibility tree.
- platform/win/Skipped:
- platform/win/accessibility/img-alt-attribute.html:
- platform/win/accessibility/selection-and-focus.html:
- 5:04 PM Changeset in webkit [68854] by
-
- 75 edits2 moves1 delete in trunk
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
Test: fast/replaced/object-param-spaces.html
- css/CSSHelper.cpp: Removed.
- css/CSSHelper.h: Removed deprecatedParseURL.
- html/parser/HTMLParserIdioms.cpp: (WebCore::stripLeadingAndTrailingHTMLSpaces): Fixed bug where the function would turn the null string into the empty string. Fixed bug where the function would not strip all trailing spaces.
- html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state instead of calling the reset function. (WebCore::CSSPreloadScanner::scan): Tweaked coding style. (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of an identical local function named isWhitespace. (WebCore::parseCSSStringOrURL): Added. This function does what deprecatedParseURL did before, and this is the only place in WebKit that needs it. The code implements the rules for a string or URL token. The real CSS parser does this with flex and the code to hook flex up to yacc, so the function is not needed there. (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit and mae it call parseCSSStringOrURL.
- bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl):
- bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
- bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]):
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
- dom/Document.cpp: (WebCore::Document::processBaseElement):
- dom/Element.cpp: (WebCore::isAttributeToRemove): (WebCore::Element::getURLAttribute): (WebCore::Element::getNonEmptyURLAttribute):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::parseMappedAttribute): (WebCore::HTMLAnchorElement::href):
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
- html/HTMLMediaElement.cpp:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::parametersForPlugin):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
- html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute):
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
- loader/FormSubmission.cpp: (WebCore::FormSubmission::Attributes::parseAction):
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::absoluteLinkURL):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
- wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
- WebCore.exp.in: Updated.
- Android.mk: Removed CSSHelper.cpp.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSElementCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- css/CSSParser.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLVideoElement.cpp:
- loader/ImageLoader.cpp:
- rendering/style/RenderStyle.h: Removed unneeded include of CSSHelper.h.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- fast/replaced/object-param-spaces-expected.txt: Copied from LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
- fast/replaced/object-param-spaces.html: Copied from LayoutTests/fast/replaced/object-param-url-control-char.html.
- fast/replaced/object-param-url-control-char-expected.txt: Removed.
- fast/replaced/object-param-url-control-char.html: Removed. Changed this test to expect HTML standard space trimming, but not the WebKit-only control character stripping we had historically.
- fast/url/query-expected.txt: Updated to expect the test to pass.
- fast/url/script-tests/segments-from-data-url.js: Changed expected result to not expect stripping of newline characters.
- fast/url/script-tests/segments.js: Ditto.
- fast/url/segments-expected.txt: Updated results.
- fast/url/segments-from-data-url-expected.txt: Ditto.
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: These tests had multiple test cases with embedded control characters. These URLs no longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log messages for them. The test cases themselves need not be changed at this time.
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Updated expected results to reflect the fact that the control character is no longer stripped from the URL in these cases. The test is still valid, but these are not as interesting test cases any more since control characters do not have special handling.
- 4:41 PM Changeset in webkit [68853] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-09-30 Martin Robinson <mrobinson@igalia.com>
Unskip some tests that are passing and rebaseline a couple others.
- platform/gtk/Skipped: Unskip tests and do a little reorganization.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaselined.
- platform/gtk/fast/overflow/line-clamp-expected.txt: Added.
- 4:25 PM Changeset in webkit [68852] by
-
- 1 edit1 delete in trunk/LayoutTests
Build fix. Not reviewed.
Remove a test expectation since the problem was fixed.
- platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
- 4:18 PM Changeset in webkit [68851] by
-
- 3 edits in trunk/WebKit2
2010-09-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Background doesn't draw when entering accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=45848
LayerBackedDrawingArea::setSize() is normally called in response
to a message from the UI process, so this can come some time after
LayerBackedDrawingArea creation. Depending on the timing, we could
end up being at size 0x0 for the first invalidate and paint, resulting
in missing content.
The fix is to size the backing layer on creation, using the WebView's size.
Also changed various calls to syncCompositingStateForThisLayerOnly()
to do lazy updates via scheduleCompositingLayerSync().
Also add the fix for https://bugs.webkit.org/show_bug.cgi?id=46226 (r68028)
to the WebKit2 code, in scheduleUpdateLayoutRunLoopObserver().
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer): (WebKit::LayerBackedDrawingArea::syncCompositingLayers): (WebKit::LayerBackedDrawingArea::scheduleUpdateLayoutRunLoopObserver):
- 4:17 PM Changeset in webkit [68850] by
-
- 6 edits in trunk
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Chris Marrin.
Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850
Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
Mac and QT.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Chris Marrin.
Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850
Added a stub for GraphicsContext3D::getGraphicsResetStatusARB.
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
- 4:17 PM Changeset in webkit [68849] by
-
- 4 edits in trunk
WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>
Reviewed by Adam Roben.
WebKit2:
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Use Windows fonts on Windows.
WebKitTools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.
- 4:08 PM Changeset in webkit [68848] by
-
- 1 edit1 add in trunk/LayoutTests
Build fix. Not reviewed.
Add test expectations for Chromium.
- platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- 4:04 PM Changeset in webkit [68847] by
-
- 3 edits in trunk/LayoutTests
Build fix. Not reviewed.
Update test expectations for Chromium.
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
- 3:57 PM Changeset in webkit [68846] by
-
- 2 edits in tags/Safari-534.9.1/WebKit/mac
Merge r68266.
- 3:57 PM Changeset in webkit [68845] by
-
- 5 edits in tags/Safari-534.9.1
Versioning.
- 3:41 PM Changeset in webkit [68844] by
-
- 3 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API
Reviewed by Sam Weinig.
- Shared/API/c/WKString.cpp:
(WKStringIsEqual):
- Shared/API/c/WKString.h:
- 3:35 PM Changeset in webkit [68843] by
-
- 1 copy in tags/Safari-534.9.1
New tag.
- 3:24 PM Changeset in webkit [68842] by
-
- 10 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46938
Reviewed by Sam Weinig.
Rewrite margin collapsing to be block-flow-aware. Eliminate a bunch of the margin functions on RenderBox in favor of a single
master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock. Introduce a new
MarginValues struct to make returning the collection of 4 margin values easy.
fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
Added fast/blockflow/margin-collapse.html
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::marginValuesForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginValues::MarginValues):
(WebCore::RenderBlock::MarginValues::positiveMarginBefore):
(WebCore::RenderBlock::MarginValues::negativeMarginBefore):
(WebCore::RenderBlock::MarginValues::positiveMarginAfter):
(WebCore::RenderBlock::MarginValues::negativeMarginAfter):
(WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlock::maxPositiveMarginBefore):
(WebCore::RenderBlock::maxNegativeMarginBefore):
(WebCore::RenderBlock::maxPositiveMarginAfter):
(WebCore::RenderBlock::maxNegativeMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::positiveMargin):
(WebCore::RenderBlock::MarginInfo::negativeMargin):
(WebCore::RenderBlock::MarginInfo::margin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
- rendering/RenderBox.h:
(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
LayoutTests:
- fast/blockflow/margin-collapse.html: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum:
- platform/mac/fast/blockflow/inline-direction-positioning-expected.png:
- platform/mac/fast/blockflow/inline-direction-positioning-expected.txt:
- platform/mac/fast/blockflow/margin-collapse-expected.checksum: Added.
- platform/mac/fast/blockflow/margin-collapse-expected.png: Added.
- platform/mac/fast/blockflow/margin-collapse-expected.txt: Added.
- 3:19 PM Changeset in webkit [68841] by
-
- 2 edits in trunk/WebCore
2010-09-30 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Fix InternetGetCookie in CookieJarWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46929
If the InternetGetCookie fails the output size won't be set.
Set the default size to 0, so we always get the correct size
and check the return value of InternetGetCookie.
- platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
- 3:11 PM Changeset in webkit [68840] by
-
- 3 edits in trunk/LayoutTests
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed rebaseline for Qt and Windows platforms required by r68830.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Merged b elements.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Ditto.
- 3:08 PM Changeset in webkit [68839] by
-
- 2 edits in trunk/WebCore
2010-09-30 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=46881
Also add some missing SelectObject calls.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::createPen): (WebCore::createBrush): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- 3:06 PM Changeset in webkit [68838] by
-
- 2 edits in trunk/LayoutTests
Build fix. Not reviewed.
Update test expectations for chromium.
- platform/chromium/test_expectations.txt:
- 3:03 PM Changeset in webkit [68837] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add radar number to ChangeLog.
- 3:00 PM Changeset in webkit [68836] by
-
- 3 edits in trunk/WebCore
WebCore uses the main thread to process sleep notifications
https://bugs.webkit.org/show_bug.cgi?id=46935
Reviewed by Dan Bernstein and Darin Adler.
Rewrite the old WebCorePowerNotifier to use IOKit directly.
On Snow Leopard, set up power notifications to arrive on a dispatch queue,
so that we can handle them quickly even if the main thread is hung.
(Tiger and Leopard will still get the old behavior).
- WebCore.xcodeproj/project.pbxproj:
Link with IOKit.
- platform/mac/SharedTimerMac.mm:
(WebCore::PowerObserver::PowerObserver):
Initialize the IOKit machinery.
(WebCore::PowerObserver::~PowerObserver):
Tear down the IOKit notifications.
(WebCore::PowerObserver::didReceiveSystemPowerNotification):
Acknowledge the event immediately and then call the shared timer functions. On Snow Leopard, we
make sure to call the shared timer functions on the main thread.
- 2:55 PM Changeset in webkit [68835] by
-
- 5 edits in trunk
2010-09-30 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-expected.txt:
2010-09-30 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302
- page/Timing.cpp: (WebCore::Timing::requestEnd):
- 2:54 PM Changeset in webkit [68834] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Xiaomei Ji <xji@chromium.org>
Unreviewed, updated test_expectations.txt
- platform/chromium/test_expectations.txt:
- 2:48 PM Changeset in webkit [68833] by
-
- 4 edits in trunk
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
- platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Remove ShFinalize().
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
- platform/mac-snowleopard/Skipped: Re-enable the test.
- 2:47 PM Changeset in webkit [68832] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add a factory function which returns an instance wrapped in PlatformRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=46373
A Brew MP instance has reference count 1 when it is created, so call adoptPlatformRef
to wrap the instance in PlatformRefPtr.
- wtf/brew/ShellBrew.h: (WTF::createRefPtrInstance):
- 2:43 PM Changeset in webkit [68831] by
-
- 2 edits in trunk/WebKit/mac
-[DOMDocument _documentRange] throws an exception if there is no document element
https://bugs.webkit.org/show_bug.cgi?id=46934
<rdar://problem/8169260>
Reviewed by Darin Adler.
If there is no document element, just return an empty range. Otherwise we'll try to call
Range::selectNode with a null Node which will throw a NOT_FOUND exception.
- DOM/WebDOMOperations.mm:
(-[DOMDocument _documentRange]):
- 2:37 PM Changeset in webkit [68830] by
-
- 12 edits3 adds in trunk
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568
The bug was caused by fixRangeAndApplyInlineStyle's not including fully selected ancestors,
and addInlineStyleIfNeeded's always surrounding the contents by new elements as supposed to
adding font attributes or style attribute.
Fixed the bug by extending the node range in fixRangeAndApplyInlineStyle and finding
the appropriate container node to add attributes in addInlineStyleIfNeeded.
addInlineStyleIfNeeded now tires to add font and style attributes to the inner most font and
span elements respectively.
Also added an early exit check to removeStyleFromRunBeforeApplyingStyle so that WebKit does not
modify the contents when the entire contents already have the desired style.
Test: editing/style/inline-style-container.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568
Added a test to ensure WebKit does not add extra font elements when the content already has an enclosing font element.
The test also ensures WebKit tries to add style attribute to the inner most span.
- editing/execCommand/createLink-expected.txt: The ordering of anchor and span changed.
- editing/execCommand/unlink-expected.txt: Ditto.
- editing/execCommand/query-font-size-expected.txt: Merged font elements.
- editing/execCommand/script-tests/toggle-style-2.js: The ordering of s and u elements changed.
- editing/execCommand/toggle-style-2-expected.txt: Ditto.
- editing/style/inline-style-container-expected.txt: Added.
- editing/style/inline-style-container.html: Added.
- editing/style/make-text-writing-direction-inline-expected.txt: Removed some extraneous spans added by the bug 44359.
- editing/style/script-tests/inline-style-container.js: Added. (testSingleToggle):
- editing/style/style-3690704-fix-expected.txt: Merged two b elements.
- fast/events/event-input-contentEditable-expected.txt: Merged anchor elements.
- fast/events/script-tests/event-input-contentEditable-expected.txt: Ditto.
- 2:34 PM Changeset in webkit [68829] by
-
- 1 edit14 deletes in trunk/LayoutTests
Build fix. Not reviewed.
Remove expectation files in wrong place.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png: Removed.
- 2:33 PM Changeset in webkit [68828] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Port PlatformRefPtr
https://bugs.webkit.org/show_bug.cgi?id=46370
Implement refPlatformPtr and derefPlatformPtr to use PlatformRefPtr in Brew MP.
- wtf/brew/RefPtrBrew.h: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
- 2:29 PM Changeset in webkit [68827] by
-
- 3 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Third attempt. We need a better integration test environment.
- Scripts/webkitpy/common/net/failuremap.py:
- Scripts/webkitpy/common/net/failuremap_unittest.py:
- 2:25 PM Changeset in webkit [68826] by
-
- 1 edit42 moves14 adds in trunk/LayoutTests
Build fix. Not reviewed.
Rename test expectations last submitted.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
- 2:22 PM Changeset in webkit [68825] by
-
- 9 edits2 adds in trunk
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- platform/qt/Skipped:
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. (PlainTextController::PlainTextController): (PlainTextController::plainText):
- DumpRenderTree/qt/PlainTextControllerQt.h: Added.
- 2:20 PM Changeset in webkit [68824] by
-
- 2 edits in trunk/WebCore
2010-09-30 Jarred Nicholls <jarred@sencha.com>
Reviewed by Darin Adler.
Removed unnecessary calls to ceil() on an int
Removing the call fixes MSVC build errors
https://bugs.webkit.org/show_bug.cgi?id=46931
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::calculateLayerBoundingRect):
- 2:17 PM Changeset in webkit [68823] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed. Second attempt to fix sheriffbot.
- Scripts/webkitpy/common/net/buildbot.py:
- 2:12 PM Changeset in webkit [68822] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed.
This patch should stop the sheriffbot from throwing an exception.
- Scripts/webkitpy/common/net/buildbot.py:
- 1:48 PM Changeset in webkit [68821] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Martin Robinson <mrobinson@igalia.com>
Unskip websocket tests for GTK+, as the bots should be running
a version of the Linux kernel which has support for SOCK_CLOEXEC.
- platform/gtk/Skipped: Unskip websocket tests.
- 1:37 PM Changeset in webkit [68820] by
-
- 3 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46932
Reviewed by Beth Dakin.
Get fast/blockflow/root-lr-basic.html results to be correct by patching a few more
height() calls to be logicalHeight().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleAfterSideOfBlock):
- 1:31 PM Changeset in webkit [68819] by
-
- 5 edits2 adds in trunk
2010-09-30 Cris Neckar <cdn@chromium.org>
Reviewed by Darin Adler.
Added check to test for removed counter node when calling findPlaceForCounter() in updateCounters().
Added refcounting to counternodes in countermaps.
https://bugs.webkit.org/show_bug.cgi?id=46387
Test: fast/css/counters/counter-traverse-table-cell.html
- rendering/CounterNode.cpp: (WebCore::CounterNode::create):
- rendering/CounterNode.h:
- rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters):
2010-09-30 Cris Neckar <cdn@chromium.org>
Reviewed by Darin Adler.
Tests for crash in counter nodes when traversing table cells.
https://bugs.webkit.org/show_bug.cgi?id=46387
- fast/css/counters/counter-traverse-table-cell-expected.txt: Added.
- fast/css/counters/counter-traverse-table-cell.html: Added.
- 1:01 PM Changeset in webkit [68818] by
-
- 3 edits in trunk/WebKit/chromium
Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).
Reviewed by Darin Fisher.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
- 1:01 PM Changeset in webkit [68817] by
-
- 36 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46928
Reviewed by Beth Dakin.
Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::isLeftPage):
(WebCore::CSSStyleSelector::applyProperty):
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- rendering/InlineBox.h:
(WebCore::InlineBox::isLeftToRightDirection):
(WebCore::InlineBox::caretLeftmostOffset):
(WebCore::InlineBox::caretRightmostOffset):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::direction):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::getHorizontalSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::localCaretRect):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::localCaretRect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutLegend):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp:
(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeScrollDimensions):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::markerTextWithSuffix):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::suffix):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::valuePartRect):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::valuePartRect):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::collectBorderStyles):
(WebCore::RenderTableCell::paintCollapsedBorder):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::positionLineBox):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintProgressBar):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
- rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::measureCharacter):
(WebCore::SVGInlineTextBox::buildLayoutInformation):
- rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBox):
- rendering/SVGTextLayoutUtilities.cpp:
(WebCore::svgTextRunForInlineTextBox):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isLeftToRightDirection):
- wml/WMLTableElement.cpp:
(WebCore::WMLTableElement::alignCells):
- 12:35 PM Changeset in webkit [68816] by
-
- 1 edit56 adds in trunk/LayoutTests
done
- 12:27 PM Changeset in webkit [68815] by
-
- 2 edits in trunk/WebKitTools
The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
https://bugs.webkit.org/show_bug.cgi?id=46926
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
Release Tests, and two bots running Windows Debug Tests, instead of four running both.
- 11:54 AM Changeset in webkit [68814] by
-
- 4 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46923
Reviewed by Simon Fraser.
Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
completely separate LTR/RTL cases.
Added fast/blockflow/inline-direction-positioning.html
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
LayoutTests:
- fast/blockflow/inline-direction-positioning.html: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.txt: Added.
- 11:50 AM Changeset in webkit [68813] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917
Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.
- Scripts/webkitpy/tool/commands/queries.py:
- 11:50 AM Changeset in webkit [68812] by
-
- 2 edits in trunk/JavaScriptCore
Add additional checks to StringBuffer.
<rdar://problem/7756381>
Reviewed by Darin Adler.
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::resize):
- 11:42 AM Changeset in webkit [68811] by
-
- 3 edits in trunk/WebKit2
Forward declare structs with 'struct' in the message headers
https://bugs.webkit.org/show_bug.cgi?id=46925
<rdar://problem/8497940>
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
(struct_or_class): New function which given a type and a namespace returns the correct
forward declaration syntax (struct or class).
- Scripts/webkit2/messages_unittest.py:
Update expected results.
- 11:32 AM Changeset in webkit [68810] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-30 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
[chromium] Fix clang error in KURLTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=46861
- tests/KURLTest.cpp: (WTF::operator<<):
- 11:28 AM Changeset in webkit [68809] by
-
- 3 edits2 adds in trunk
Fix color media queries on Windows
Fixes <http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
media query does not evaluate to true for 32bpp displays on Windows
Test: fast/media/color-does-not-include-alpha.html
Reviewed by Darin Adler.
WebCore:
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepthPerComponent): Use screenDepth instead of trying
to interpret DEVMODE directly, since screenDepth knows how to correct
for video drivers that return 32 instead of 24.
LayoutTests:
Add test for color:8 media queries
- fast/media/color-does-not-include-alpha-expected.txt: Added.
- fast/media/color-does-not-include-alpha.html: Added.
- 11:27 AM Changeset in webkit [68808] by
-
- 5 edits in trunk
Make sure screen.colorDepth/screen.pixelDepth don't include the bits used for alpha
Fixes <http://webkit.org/b/42972> <rdar://problem/8234071>
screen.colorDepth and screen.pixelDepth return 32 on Windows, but
should return 24 (according to CSSOM View and Firefox)
Reviewed by Darin Adler.
WebCore:
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepth): If Windows says there are 32 bits per pixel,
return 24 instead, as 32 includes the alpha component but this
function is supposed to ignore the alpha component.
LayoutTests:
Update screen.colorDepth/screen.pixelDepth test to not allow values
that contain bits for alpha
- fast/dom/Window/window-screen-properties-expected.txt: Updated
results.
- fast/dom/Window/window-screen-properties.html: Changed only to
expect 16 or 24.
- 11:20 AM Changeset in webkit [68807] by
-
- 15 edits in trunk
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
This is covered by existing tests.
- editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
- platform/chromium/ClipboardChromium.cpp: (WebCore::normalizeType): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::files): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::writePlainText):
- platform/chromium/ClipboardChromiumWin.cpp: (WebCore::ClipboardChromium::validateFileName):
- platform/chromium/ClipboardMimeTypes.cpp:
- platform/chromium/ClipboardMimeTypes.h:
- platform/chromium/DragDataChromium.cpp: (WebCore::containsHTML): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::canSmartReplace): (WebCore::DragData::asFragment):
- platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getURL): (WebCore::ReadableDataObject::getHTML):
- platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::clearData): (WebCore::WritableDataObject::setData): (WebCore::WritableDataObject::setURL): (WebCore::WritableDataObject::setHTML):
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::initialize): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent):
- 11:12 AM Changeset in webkit [68806] by
-
- 5 edits81 adds in trunk
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
- src/WebGraphicsContext3DDefaultImpl.cpp: Make ShaderSourceMap as <ShaderID, ShaderSourceEntry*>, so map resizing will be efficient and we don't need to worry about pointer copying. (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
- src/WebGraphicsContext3DDefaultImpl.h: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
- fast/canvas/webgl/glsl-conformance-expected.txt: Added.
- fast/canvas/webgl/glsl-conformance.html: Added.
- fast/canvas/webgl/resources/webgl-test-utils.js: Add a function to turn off console output. (WebGLTestUtils.): (WebGLTestUtils):
- fast/canvas/webgl/shaders: Added.
- fast/canvas/webgl/shaders/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/implicit: Added.
- fast/canvas/webgl/shaders/implicit/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/implicit/add_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_int_to_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec2_to_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec3_to_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec4_to_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/construct_struct.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/greater_than.vert: Added.
- fast/canvas/webgl/shaders/implicit/greater_than_equal.vert: Added.
- fast/canvas/webgl/shaders/implicit/less_than.vert: Added.
- fast/canvas/webgl/shaders/implicit/less_than_equal.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/reserved: Added.
- fast/canvas/webgl/shaders/reserved/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_field.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_function.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_struct.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_variable.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_field.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_function.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_struct.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_variable.vert: Added.
- 11:04 AM Changeset in webkit [68805] by
-
- 2 edits in trunk/LayoutTests
Add some tests to the Windows Skipped list
These all have bugs filed about them.
- platform/win/Skipped:
- 10:59 AM Changeset in webkit [68804] by
-
- 1 edit in trunk/WebCore/platform/graphics/gpu/DrawingBuffer.h
Fixed chrome build issue in DrawingBuffer.h
- 10:57 AM Changeset in webkit [68803] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-30 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] WebIDBDatabase and WebIDBObjectStore are missing methods called from Chromium land.
https://bugs.webkit.org/show_bug.cgi?id=46922
The missing functions were removed in r68795.
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex):
- 10:43 AM Changeset in webkit [68802] by
-
- 21 edits2 adds in trunk
2010-09-30 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Make 2D accelerated canvas rendering build on Mac
https://bugs.webkit.org/show_bug.cgi?id=46007
Add accelerated 2D rendering files to Mac build, fix build errors,
add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
enabled, and add a skeleton of the mac specific file so it builds.
DrawingBufferMac.mm, the Mac specific file does nothing right now
other than initialize and create a layer. The rest will be added
when I do the actual implementation.
The most significant change was to SharedGraphicsContext3D, which
had a static local OwnPtr in one of the methods. This was causing
the exit time destructor warning. Getting rid of the OwnPtr fixed
the problem. Since the pointer that was being wrapped was to a
static object that would never get destroyed, the OwnPtr was not
necessary.
I also added the ACCELERATED_2D_CANVAS flag to build-webkit
and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
But right now the flag is off by default.
- 10:36 AM Changeset in webkit [68801] by
-
- 11 edits in trunk
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getPlatformTextureId): (WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
- src/WebGraphicsContext3DDefaultImpl.h:
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingEnabled):
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleComposite):
- DumpRenderTree/chromium/WebViewHost.h:
- 10:35 AM Changeset in webkit [68800] by
-
- 2 edits in trunk
[wx] Fix typo in build script.
- 10:35 AM Changeset in webkit [68799] by
-
- 2 edits in trunk/JavaScriptCore
[wx] wxMSW build fix. Make sure we copy the compiler flags and remove exception handling from
the copy so as not to alter global settings.
- 10:23 AM Changeset in webkit [68798] by
-
- 3 edits in trunk/LayoutTests
Make Windows match the Mac fallback font for the hyphen character in two tests
Fixes <http://webkit.org/b/46909> <rdar://problem/8497214> REGRESSION
(r68551): fast/text/midword-break-after-breakable-char.html and
fast/text/basic/014.html are failing on Windows
Rubber-stamped by Dan Bernstein.
- fast/text/basic/014.html:
- fast/text/midword-break-after-breakable-char.html:
Added a little @font-face magic to force the font for the hyphen
character.
- 10:21 AM Changeset in webkit [68797] by
-
- 4 edits70 adds in trunk
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Adding layout tests for feComposite dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in2-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k1-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k2-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k3-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k4-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-operator-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in2-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k1-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k2-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k3-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k4-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-operator-prop.js: Added. (executeTest):
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::svgAttributeChanged):
- svg/SVGFECompositeElement.h:
- 10:16 AM Changeset in webkit [68796] by
-
- 3 edits in trunk/WebKit/mac
Add printing SPI allowing full control over shrink-to-fit
https://bugs.webkit.org/show_bug.cgi?id=46877
Reviewed by John Sullivan.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
- WebView/WebHTMLViewPrivate.h:
- 9:55 AM Changeset in webkit [68795] by
-
- 79 edits in trunk
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
A bit of cleanup + use setVersion transactions for all of our work.
- storage/indexeddb/database-basics.html:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics.html:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Switch the rest of IndexedDB to use transactions.
Implement most of setVersion.
Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
Switch to using the standard cross thread task stuff.
Make everything threadsafe so it works with cross thread copy
(will be useful in the future).
Fix some subtle bugs in transactions.
Various bits of clean up (when I couldn't resist).
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h:
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- platform/CrossThreadCopier.cpp:
- storage/IDBAny.cpp: (WebCore::IDBAny::idbFactory): (WebCore::IDBAny::idbTransaction): (WebCore::IDBAny::set):
- storage/IDBAny.h:
- storage/IDBCallbacks.h:
- storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
- storage/IDBCursor.h: (WebCore::IDBCursor::create):
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::removeInternal):
- storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
- storage/IDBDatabase.h:
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::close):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
- storage/IDBIndex.h: (WebCore::IDBIndex::create):
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
- storage/IDBIndexBackendImpl.h:
- storage/IDBIndexBackendInterface.h:
- storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey):
- storage/IDBKey.h:
- storage/IDBKeyRange.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::removeInternal): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
- storage/IDBRequest.h: (WebCore::IDBRequest::create):
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
- storage/IDBTransactionBackendImpl.h:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Plumbing.
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::close):
- public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
- public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::close):
- src/IDBDatabaseProxy.h:
- src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
- src/IDBIndexBackendProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
- src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::close):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 9:46 AM Changeset in webkit [68794] by
-
- 2 edits in trunk/LayoutTests
Skip a crashing test on Windows
- platform/win/Skipped: Skip
fast/frames/iframe-reparenting-adopt-node.html. There's already a bug
filed about the issue.
- 9:40 AM Changeset in webkit [68793] by
-
- 3 edits in trunk/WebKitTools
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.init): Moved code here from
RaisingDelegate.init.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.init): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.
- 9:39 AM Changeset in webkit [68792] by
-
- 2 edits in trunk/WebKitTools
Fix path -> URL conversion on Cygwin
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.
- 9:31 AM Changeset in webkit [68791] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-09-30 William Siegrist <wsiegrist@apple.com>
Fix syntax error in r68744.
- 9:30 AM Changeset in webkit [68790] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg
2010-09-30 William Siegrist <wsiegrist@apple.com>
Set cache values for master.
- 9:16 AM Changeset in webkit [68789] by
-
- 2 edits in trunk/LayoutTests
Skip a test that fails on Windows due to lack of SSL support
- platform/win/Skipped: Added
http/tests/navigation/ping-cross-origin-from-https.html.
- 9:11 AM Changeset in webkit [68788] by
-
- 2 edits in trunk/WebKit2
Original patch by Zalan Bujtas.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-30
Reviewed by Antti Koivisto.
The m_readBuffer might be smaller than the incoming message size and
thus result in memory corruption. Do a similar fix as the win port,
resizing the m_readBuffer to have room for the message.
- Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
- 8:45 AM Changeset in webkit [68787] by
-
- 2 edits in trunk/WebCore
2010-09-30 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Martin Robinson.
[Gtk] build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795
makevalues.pl and makeprop.pl generate 3 files in one run.
Double or triple target is incorrect, because on a multicore
machine make processes targets in parallel.
Setting a->b->c dependencies for 3 generated files guarantees
that make doesn't execute the recipe of the rule more than one.
- GNUmakefile.am: Dependencies and missing headers added.
- 8:39 AM Changeset in webkit [68786] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/layers/video-layer.html on Windows
Fixes <http://webkit.org/b/46903> <rdar://problem/8496933> REGRESSION
(r67251): fast/layers/video-layer.html failing on Windows
- platform/win/fast/layers/video-layer-expected.txt:
- 8:18 AM Changeset in webkit [68785] by
-
- 2 edits in trunk/WebKitTools
Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once
The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.
Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows
Reviewed by Anders Carlsson.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.
- 7:55 AM Changeset in webkit [68784] by
-
- 8 edits in trunk/LayoutTests
Rebaseline Windows results for recent-ish changes
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- platform/win/html5lib/runner-expected.txt:
- 6:50 AM Changeset in webkit [68783] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fixup for the previous commit that accidently only had ChangeLog.
- 6:44 AM Changeset in webkit [68782] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-09-30 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix (marked ResourceRawHeaders.h as private).
- WebCore.xcodeproj/project.pbxproj:
- 5:53 AM Changeset in webkit [68781] by
-
- 19 edits2 copies1 add in trunk
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse):
- platform/network/ResourceRawHeaders.h: Added.
- platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting. (WebCore::ResourceRequestBase::reportRawHeaders): (WebCore::ResourceRequestBase::setReportRawHeaders): (WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/ResourceResponseBase.cpp: Added support for raw headers. (WebCore::ResourceResponseBase::resourceRawHeaders): (WebCore::ResourceResponseBase::setResourceRawHeaders):
- platform/network/ResourceResponseBase.h:
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
Added plumbing for raw headers flag and response field between chromium and WebCore.
https://bugs.webkit.org/show_bug.cgi?id=46092
- WebKit.gyp:
- public/WebResourceRawHeaders.h: Added.
- public/WebURLRequest.h:
- public/WebURLResponse.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
- src/WebResourceRawHeaders.cpp: Added. (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::addHeader): (WebKit::WebResourceRawHeaders::addRequestHeader): (WebKit::WebResourceRawHeaders::addResponseHeader):
- src/WebURLRequest.cpp: (WebKit::WebURLRequest::setReportRawHeaders): (WebKit::WebURLRequest::reportRawHeaders):
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::resourceRawHeaders): (WebKit::WebURLResponse::setResourceRawHeaders):
- src/WebURLResponsePrivate.h:
- 5:47 AM Changeset in webkit [68780] by
-
- 4 edits in trunk
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
- WebCoreSupport/InspectorServerQt.cpp:
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
- loader/PingLoader.cpp:
- 5:45 AM Changeset in webkit [68779] by
-
- 4 edits in trunk/WebCore
2010-09-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: assign the resource loading finish time which was obtained from the network stack
as the end time for the corresponding event in Timeline.
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
- inspector/InspectorTimelineAgent.h:
- 5:42 AM Changeset in webkit [68778] by
-
- 10 edits in trunk/WebCore
2010-09-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement sorting by timeline in network panel + filtering.
https://bugs.webkit.org/show_bug.cgi?id=45657
A number of drive-by fixes, sorting by timeline added,
0-based timeline for duration added, filters added,
more love for detailed view + nice headers.
- English.lproj/localizedStrings.js:
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.markColumnAsSortedBy): (WebInspector.DataGrid.prototype.headerTableHeader):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML): (WebInspector.NetworkPanel.prototype._createSortingFunctions): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._createFilterPanel): (WebInspector.NetworkPanel.prototype._showCategory): (WebInspector.NetworkPanel.prototype._hideCategory): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._createDivInTD): (WebInspector.NetworkDataGridNode.prototype._refreshURLCell): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._appendSubtitle): (WebInspector.NetworkDataGridNode.SizeComparator): (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel):
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
- inspector/front-end/inspector.css: (.data-grid th.sort-ascending > div::after): (.data-grid th.sort-descending > div::after): (.status-bar-items):
- inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid th): (.network.panel .data-grid.small th): (.network.panel .data-grid .data-container): (.network.panel .data-grid.small .data-container): (.network.panel .data-grid select): (.network.panel .data-grid td.time-column): (.network-cell-subtitle): (.network-header-subtitle): (.network-event-divider): (.network.panel .network-timeline-grid.small .network-event-divider): (.network.panel .resources-dividers-label-bar): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar): (.network.panel .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network.panel .resources-divider.first .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider.first): (#network-filter): (.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other): (.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
- 5:29 AM Changeset in webkit [68777] by
-
- 3 edits in trunk/WebCore
[Qt] Ensure we always report a valid size for the video
Reviewed by Simon Hausmann.
Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- 5:04 AM Changeset in webkit [68776] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct reviewer, Andreas was faster!
- 5:03 AM Changeset in webkit [68775] by
-
- 3 edits in trunk/WebCore
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGTextPath lacks isSVGTextPath() method
https://bugs.webkit.org/show_bug.cgi?id=46888
Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGTextPath): Return false.
- rendering/RenderSVGTextPath.h: Changed indentation of whole file. (WebCore::RenderSVGTextPath::isSVGTextPath): Return true. (WebCore::RenderSVGTextPath::renderName): (WebCore::toRenderSVGTextPath): Add helper casting methods.
- 5:00 AM Changeset in webkit [68774] by
-
- 2 edits in trunk/WebCore
[Qt] Ensure that the media player backend does not leave any resources around
Reviewed by Simon Hausmann.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
- 4:51 AM Changeset in webkit [68773] by
-
- 3 edits in trunk/WebCore
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
AffineTransform should expose methods calculating the x/y scale factors
https://bugs.webkit.org/show_bug.cgi?id=46887
Expose methods calculating the x/y scale factors for an AffineTransform.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions. (WebCore::AffineTransform::xScale): (WebCore::AffineTransform::yScale):
- platform/graphics/transforms/AffineTransform.h:
- 4:50 AM Changeset in webkit [68772] by
-
- 2 edits in trunk/WebCore
Minor cleanup of MediaPlayerPrivateQt
Reviewed by Simon Hausmann.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):
- 4:44 AM Changeset in webkit [68771] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The case-insensitivity backreference checking isn't working with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46882
Add ignorecase checking to the Interpreter::tryConsumeBackReference() function.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::tryConsumeBackReference):
- 3:29 AM Changeset in webkit [68770] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Leave initializeRandomNumberGenerator empty.
https://bugs.webkit.org/show_bug.cgi?id=46851
On Brew MP, AEECLSID_RANDOM initializes itself.
- wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
- 2:36 AM Changeset in webkit [68769] by
-
- 3 edits in trunk/WebCore
2010-09-30 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Mark unused parameters as such.
https://bugs.webkit.org/show_bug.cgi?id=46880
- inspector/InspectorDOMAgent.cpp:
- page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
- 2:26 AM Changeset in webkit [68768] by
-
- 3 edits in trunk/WebKitTools
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload warns that I'm using Xcode when I'm not
https://bugs.webkit.org/show_bug.cgi?id=46869
String.find returns -1 when not found, so switched to "in".
- Scripts/webkitpy/common/system/user.py:
- Scripts/webkitpy/common/system/user_unittest.py:
- 2:15 AM Changeset in webkit [68767] by
-
- 15 edits2 adds in trunk/WebCore
2010-09-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
- dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
- inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
- workers/SharedWorker.cpp:
- 2:12 AM Changeset in webkit [68766] by
-
- 4 edits in trunk/WebKitTools
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch failure-reason dies if non-trunk commits are in the blame range
https://bugs.webkit.org/show_bug.cgi?id=46866
I also made failure-reason use RegressionWindow in a cleaner way.
- Scripts/webkitpy/tool/commands/queries.py:
- 1:50 AM Changeset in webkit [68765] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-30 Avi Drissman <avi@google.com>
Reviewed by Kenneth Russell.
[Chromium] Tabbing into page doesn't always select the first element
https://bugs.webkit.org/show_bug.cgi?id=46856
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setInitialFocus):
- 1:37 AM Changeset in webkit [68764] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove unnecessary cacheFlush calls from Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=46702
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer):
- 1:22 AM Changeset in webkit [68763] by
-
- 2 edits in trunk/WebCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852
Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForDocument):
- 12:48 AM Changeset in webkit [68762] by
-
- 22 edits1 copy in trunk/WebCore
2010-09-30 Michael Nordman <Michael Nordman>
Reviewed by David Levin.
Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
across threads and to compare platform specific data members of ResourceRequest.
- Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
- Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method is already present on ResourceResponseBase.
- Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base classes and extended those base classes in the platform specific headers to provide a place to hold additional fields.
- Used this mechanism to have the chromium port's data members make the hop. https://bugs.webkit.org/show_bug.cgi?id=46430
No new tests. Just plumbing.
- WebCore.exp.in: removed the symbol for the now inlined == operator
- WebCore.gypi: added chromium/ResourceResponse.cpp
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::compare):
- platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- platform/network/android/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/android/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.h:
- platform/network/chromium/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceResponse.h:
- platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::doUpdateResourceResponse): (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- 12:22 AM Changeset in webkit [68761] by
-
- 4 edits in trunk/WebKit/qt
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash if an scene with accelerated compositing layout during the paint event
https://bugs.webkit.org/show_bug.cgi?id=46812
Delay the deletion of the overlay after the current event is processed.
Removing the overlay can sometimes be done inside the rendering code of
the overlay itself. When the rendering code is using the reference after
the deletion of the overlay, WebKit crashes.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay):
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
- WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
- 12:10 AM Changeset in webkit [68760] by
-
- 2 edits in trunk/WebKit/qt
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814
Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):
- 12:08 AM Changeset in webkit [68759] by
-
- 2 edits1 move in trunk/WebKit/chromium
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Rename chromium's GraphicsContext3D.cpp to match others.
https://bugs.webkit.org/show_bug.cgi?id=46771
- WebKit.gyp:
- src/GraphicsContext3DChromium.cpp: Renamed from WebKit/chromium/src/GraphicsContext3D.cpp.
Sep 29, 2010:
- 11:52 PM Changeset in webkit [68758] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-09-29 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Rebaseline image-rescale.svg results for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=46818
- platform/chromium-win/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
- platform/chromium-win/svg/custom/image-rescale-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.png.
- platform/chromium/test_expectations.txt:
- 11:49 PM Changeset in webkit [68757] by
-
- 3 edits in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Put default initialize() and uninitialize() methods in AudioNode
https://bugs.webkit.org/show_bug.cgi?id=46767
No new tests since audio API is not yet implemented.
- webaudio/AudioNode.cpp: (WebCore::AudioNode::initialize): (WebCore::AudioNode::uninitialize):
- webaudio/AudioNode.h:
- 11:34 PM Changeset in webkit [68756] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 Adam Barth <abarth@webkit.org>
Unreviewed. See comments in the Skipped file.
- platform/mac/Skipped:
- 11:29 PM Changeset in webkit [68755] by
-
- 2 edits in trunk/WebKitTools
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests
https://bugs.webkit.org/show_bug.cgi?id=46876
This command helps us find flaky tests so we can squash them.
- Scripts/webkitpy/tool/commands/queries.py:
- 11:26 PM Changeset in webkit [68754] by
-
- 2 edits in trunk/LayoutTests
Skip plugins/plugin-document-load-prevented-userscript.html on Qt, because it doesn't
support window.layoutTestController.addUserScript yet.
Rubber-stamped by Adam Barth.
- platform/qt/Skipped:
- 11:24 PM Changeset in webkit [68753] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 Alejandro G. Castro <alex@igalia.com>
Unreviewed, LayoutTestController::addUserScript not supported in
GTK+, skip plugin-document-load-prevented-userscript.html.
- platform/gtk/Skipped:
- 10:56 PM Changeset in webkit [68752] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
- platform/chromium/test_expectations.txt:
- 10:27 PM Changeset in webkit [68751] by
-
- 2 edits in trunk/WebKitTools
2010-09-29 Simon Fraser <Simon Fraser>
Fix export to use '?' instead of 'null' for
tests with no results.
- CSSTestSuiteHarness/harness/harness.js:
- 9:41 PM Changeset in webkit [68750] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
- platform/chromium/test_expectations.txt:
- 9:22 PM Changeset in webkit [68749] by
-
- 6 edits in trunk
2010-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791
No new tests because this doesn't change any behavior.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createTypeMap):
- html/HTMLInputElement.h: Move DeprecatedInputType, deprecatedInputType() and parseToDateComponents() to the private section, make createTypeMap() a member function of HTMLInputElement. (WebCore::HTMLInputElement::deprecatedInputType):
2010-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791
- src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Accept any text field types as a username field.
- src/WebSearchableFormData.cpp: (WebCore::HasSuitableTextElement): Accept any text field types as a search query field.
- 9:14 PM Changeset in webkit [68748] by
-
- 4 edits in trunk/WebKitTools
2010-09-29 Simon Fraser <Simon Fraser>
Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.
- CSSTestSuiteHarness/harness/harness.css:
- CSSTestSuiteHarness/harness/harness.html:
- CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.processFlags):
- 9:07 PM Changeset in webkit [68747] by
-
- 4 edits in trunk/WebKitTools
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove revisions_casuing_failures
https://bugs.webkit.org/show_bug.cgi?id=46872
This function exists only to be unit tested.
- Scripts/webkitpy/common/net/failuremap.py:
- Scripts/webkitpy/common/net/failuremap_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 8:57 PM Changeset in webkit [68746] by
-
- 12 edits in trunk/WebKitTools
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should post the list of failing tests to bugs
https://bugs.webkit.org/show_bug.cgi?id=46871
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/failuremap.py:
- Scripts/webkitpy/common/net/regressionwindow.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 8:42 PM Changeset in webkit [68745] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 Eric Seidel <eric@webkit.org>
Unreviewed. Skipping crashing test to green the tree.
This crash started when I skipped some canvas tests
as part of rolling out r68568.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
- platform/mac-snowleopard/Skipped:
- 8:33 PM Changeset in webkit [68744] by
-
- 5 edits in trunk/WebKitTools
[WinCairo] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=46360
Patch by Brent Fulgham <bfulgham@webkit.org> on 2010-09-29
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json: Add
entries for a debug build of the WinCairo port.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
platform flag to configuration for wincairo (like gtk, chromium, etc.)
- Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
- Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
- 8:27 PM Changeset in webkit [68743] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
- platform/chromium/test_expectations.txt:
- 8:06 PM Changeset in webkit [68742] by
-
- 5 edits4 adds in trunk
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324
Add test which uses pushState to generate history entries while also
changing the frames that are present in the document between history
states. Add a similar test that uses fragment changes.
- fast/history/same-document-iframes-changing-fragment-expected.txt: Added.
- fast/history/same-document-iframes-changing-fragment.html: Added.
- fast/history/same-document-iframes-changing-pushstate-expected.txt: Added.
- fast/history/same-document-iframes-changing-pushstate.html: Added.
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324
Revert same document check to the way it was before r66238 for history
entries created by pushState or fragment changes. Logic fror determining
if same document navigation should be used is moved to HistoryItem.
Tests: fast/history/same-document-iframes-changing-fragment.html
fast/history/same-document-iframes-changing-pushstate.html
- history/HistoryItem.cpp: (WebCore::HistoryItem::shouldDoSameDocumentNavigationTo): (WebCore::HistoryItem::hasSameDocumentTree): (WebCore::HistoryItem::hasSameFrames):
- history/HistoryItem.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
- 8:01 PM Changeset in webkit [68741] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add removeRecursively to WebKit WebFileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46842
- public/WebFileSystem.h: (WebKit::WebFileSystem::removeRecursively): Added.
- 7:53 PM Changeset in webkit [68740] by
-
- 7 edits1 add in trunk/WebKitTools
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move more SheriffBot smarts into FailureMap
https://bugs.webkit.org/show_bug.cgi?id=46703
This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.
Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.
- Scripts/webkitpy/common/net/failuremap.py:
- Scripts/webkitpy/common/net/regressionwindow.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/mocktool.py:
- 7:49 PM Changeset in webkit [68739] by
-
- 1 edit1 copy1 move in trunk/LayoutTests
2010-09-29 Adam Barth <abarth@webkit.org>
This test result seems to be platform specific.
- platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt: Renamed from LayoutTests/plugins/plugin-initiate-popup-window-expected.txt.
- platform/mac/plugins/plugin-initiate-popup-window-expected.txt: Added.
- 7:34 PM Changeset in webkit [68738] by
-
- 2 edits in trunk/WebCore
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
WebCore::ESpeak causes missing symbol with no ENABLE_SVG
https://bugs.webkit.org/show_bug.cgi?id=46865
Moves ESpeak related function definitions outside ENABLE_SVG block.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ESpeak): (WebCore::CSSPrimitiveValue::operator EVectorEffect):
- 7:24 PM Changeset in webkit [68737] by
-
- 71 edits in trunk/LayoutTests
2010-09-29 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r68568.
http://trac.webkit.org/changeset/68568
https://bugs.webkit.org/show_bug.cgi?id=46439
Failing tests on both Leopard and Snow Leopard
- canvas/philip/tests/2d.composite.operation.darker-expected.txt:
- canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
- canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
- canvas/philip/tests/2d.drawImage.null-expected.txt:
- canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
- canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
- canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
- canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
- canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
- canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
- canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
- canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
- canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
- canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
- canvas/philip/tests/2d.imageData.create1.type-expected.txt:
- canvas/philip/tests/2d.imageData.create2.type-expected.txt:
- canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
- canvas/philip/tests/2d.imageData.get.type-expected.txt:
- canvas/philip/tests/2d.line.cap.closed-expected.txt:
- canvas/philip/tests/2d.line.join.parallel-expected.txt:
- canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
- canvas/philip/tests/2d.missingargs-expected.txt:
- canvas/philip/tests/2d.path.rect.winding-expected.txt:
- canvas/philip/tests/2d.pattern.image.broken-expected.txt:
- canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
- canvas/philip/tests/2d.pattern.image.null-expected.txt:
- canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
- canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
- canvas/philip/tests/2d.shadow.enable.x-expected.txt:
- canvas/philip/tests/2d.shadow.enable.y-expected.txt:
- canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
- canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
- canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
- canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
- canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
- canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
- canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
- canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
- canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
- canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
- canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
- canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
- canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
- canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
- canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
- canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
- canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
- canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
- canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
- canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
- canvas/philip/tests/2d.text.font.parse.system-expected.txt:
- canvas/philip/tests/2d.text.measure.width.space-expected.txt:
- canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
- canvas/philip/tests/type.prototype-expected.txt:
- platform/mac/Skipped:
- 6:27 PM Changeset in webkit [68736] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioChannelSplitter files
https://bugs.webkit.org/show_bug.cgi?id=46290
No new tests since audio API is not yet implemented.
- webaudio/AudioChannelSplitter.cpp: Added. (WebCore::AudioChannelSplitter::AudioChannelSplitter): (WebCore::AudioChannelSplitter::process): (WebCore::AudioChannelSplitter::reset):
- webaudio/AudioChannelSplitter.h: Added. (WebCore::AudioChannelSplitter::create):
- webaudio/AudioChannelSplitter.idl: Added.
- 6:16 PM Changeset in webkit [68735] by
-
- 15 edits5 adds in trunk
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadDirectory):
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
Test: fast/filesystem/read-directory.html
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::readDirectory): Changed to take DirectoryReader as a parameter.
- fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback): Added.
- fileapi/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added initializer for m_hasMore flag. (WebCore::DirectoryReader::readEntries): Changed to schedule EntriesCallback with an empty array if m_hasMore flag is set false.
- fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem): Added. (WebCore::DirectoryReader::setHasMore): Added.
- fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): (WebCore::EntriesCallbacks::EntriesCallbacks): Changed to take DirectoryReader as a parameter. (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries): Changed 1) not to trigger the second callback when hasMore is false, and 2) to update the DirectoryReader's m_hasMore flag.
- fileapi/FileSystemCallbacks.h:
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
- fast/filesystem/flags-passing.html: Updated to make it match with the updated TEMPLATE.html.
- fast/filesystem/flags-passing-expected.txt: Updated.
- fast/filesystem/read-directory.html: Added.
- fast/filesystem/read-directory-expected.txt: Added.
- fast/filesystem/resources/fs-test-util.js: Added for common test utilities.
- fast/filesystem/script-tests/TEMPLATE.html: Updated to include fs-test-util.js.
- fast/filesystem/script-tests/flags-passing.js: Updated to use jsTestIsAsync and finishJSTest (so that all the tests look alike).
- fast/filesystem/script-tests/read-directory.js: Added.
- 6:12 PM Changeset in webkit [68734] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioGainNode files
https://bugs.webkit.org/show_bug.cgi?id=46286
No new tests since audio API is not yet implemented.
- webaudio/AudioGainNode.cpp: Added. (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process): (WebCore::AudioGainNode::reset): (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
- webaudio/AudioGainNode.h: Added. (WebCore::AudioGainNode::create): (WebCore::AudioGainNode::gain):
- webaudio/AudioGainNode.idl: Added.
- 6:07 PM Changeset in webkit [68733] by
-
- 3 edits in trunk/LayoutTests
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated expectations.
- platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
- platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
- 5:55 PM Changeset in webkit [68732] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioChannelMerger files
https://bugs.webkit.org/show_bug.cgi?id=46291
No new tests since audio API is not yet implemented.
- webaudio/AudioChannelMerger.cpp: Added. (WebCore::AudioChannelMerger::AudioChannelMerger): (WebCore::AudioChannelMerger::process): (WebCore::AudioChannelMerger::reset):
- webaudio/AudioChannelMerger.h: Added. (WebCore::AudioChannelMerger::create):
- webaudio/AudioChannelMerger.idl: Added.
- 5:45 PM Changeset in webkit [68731] by
-
- 2 edits in trunk/WebKit2
Calling Connection::send/sendSync from Connection::Client::didClose should always fail
https://bugs.webkit.org/show_bug.cgi?id=46859
<rdar://problem/8212583>
Reviewed by Simon Fraser.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchConnectionDidClose):
- 5:31 PM Changeset in webkit [68730] by
-
- 2 edits in trunk/WebCore
No review. Missed file for patch.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 5:30 PM Changeset in webkit [68729] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r68340.
- 5:14 PM Changeset in webkit [68728] by
-
- 4 edits in trunk/LayoutTests
No review. Update layout tests after new CSS property.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 5:11 PM Changeset in webkit [68727] by
-
- 2 edits in trunk/WebCore
Crash at lineBreakExistsAtPosition + 125
<rdar://problem/7028809>
https://bugs.webkit.org/show_bug.cgi?id=46770
Reviewed by Darin Adler.
lineBreakExistsAtPosition is called from InsertTextCommand::input,
where we compute the downstream position of the endingSelection().
Downstream can return the original position, that comes from a VisibleSelection
but there is no guarantee that its renderer is still there. Everywhere we dereference
a renderer we check if it's null.
There is no regression test.
- editing/htmlediting.cpp:
(WebCore::lineBreakExistsAtPosition): Added check that the renderer is not null
before dereferencing it.
- 5:10 PM Changeset in webkit [68726] by
-
- 2 edits in trunk/WebKit2
2010-09-29 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Assertion then crash closing WebKit2 window with accelerated compositing in
https://bugs.webkit.org/show_bug.cgi?id=46857
Fix two issues when closing a WebKit2 window using accelerated
compositing.
The first is that the response to the sync DidChangeAcceleratedCompositing message
sent by changeAcceleratedCompositingMode() may be empty, because the corresponding
page may have been destroyed already in the UI process. In that case newDrawingAreaInfo
is not filled in, so we get a DrawingArea::Type of None. Don't attempt to make a new
drawing area in that case.
We then have to null-check the drawing area in WebPage::didReceiveMessage(),
in the case where the UI process is calling back with a SuspendPainting message,
before our page has gone away.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::didReceiveMessage):
- 5:10 PM Changeset in webkit [68725] by
-
- 6 edits2 adds in branches/safari-533.19-branch
Merge r66028.
- 5:08 PM Changeset in webkit [68724] by
-
- 3 edits in branches/safari-533.19-branch/WebCore
Merge r67288.
- 5:08 PM Changeset in webkit [68723] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r67286.
- 5:08 PM Changeset in webkit [68722] by
-
- 9 edits2 adds in branches/safari-533.19-branch
Merge r67285.
- 5:00 PM Changeset in webkit [68721] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r68278.
- 4:59 PM Changeset in webkit [68720] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r68158.
- 4:57 PM Changeset in webkit [68719] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r68485.
- 4:55 PM Changeset in webkit [68718] by
-
- 4 edits2 adds in branches/safari-533.19-branch
Merge r68408.
- 4:52 PM Changeset in webkit [68717] by
-
- 6 edits3 adds in branches/safari-533.19-branch
Merge r64780.
- 4:52 PM Changeset in webkit [68716] by
-
- 5 edits in trunk
plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown
https://bugs.webkit.org/show_bug.cgi?id=46715
<rdar://problem/8485909>
Reviewed by Darin Adler.
WebCore:
Remove exclamation points from exceptions.
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
LayoutTests:
Remove exclamation point.
- plugins/npruntime/invoke-failure-expected.txt:
- 4:51 PM Changeset in webkit [68715] by
-
- 4 edits in trunk/WebCore
Add additional checks to StringBuilder.
<rdar://problem/7761248>
Reviewed by Darin Adler.
- platform/text/StringBuilder.cpp:
(WebCore::checkAppend):
(WebCore::StringBuilder::append):
(WebCore::StringBuilder::toString):
(WebCore::StringBuilder::clear):
(WebCore::StringBuilder::length):
- platform/text/StringBuilder.h:
(WebCore::StringBuilder::StringBuilder):
(WebCore::StringBuilder::setNonNull):
(WebCore::StringBuilder::isNull):
- 4:51 PM Changeset in webkit [68714] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Update test results.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
Rebaseline GTK test after CSS change.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 4:42 PM Changeset in webkit [68713] by
-
- 4 edits4 adds in branches/safari-533.19-branch
Merge r65900.
- 4:31 PM Changeset in webkit [68712] by
-
- 6 edits2 adds in branches/safari-533.19-branch
Merge r68096.
- 4:22 PM Changeset in webkit [68711] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r61709.
- 4:20 PM Changeset in webkit [68710] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r62873.
- 4:19 PM Changeset in webkit [68709] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r67967.
- 4:13 PM Changeset in webkit [68708] by
-
- 4 edits2 adds in branches/safari-533.19-branch
Merge r68461.
- 4:09 PM Changeset in webkit [68707] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r67407.
- 4:07 PM Changeset in webkit [68706] by
-
- 5 edits2 adds in branches/safari-533.19-branch
Merge r61622.
- 4:05 PM Changeset in webkit [68705] by
-
- 2 edits in trunk/WebCore
Add additional check to Text::wholeText.
<rdar://problem/8304795>
Reviewed by Darin Adler.
- dom/Text.cpp:
(WebCore::Text::wholeText):
- 4:05 PM Changeset in webkit [68704] by
-
- 3 edits in branches/safari-533.19-branch/WebCore
Merge r65313.
- 4:04 PM Changeset in webkit [68703] by
-
- 4 edits3 adds in branches/safari-533.19-branch
Merge r65135.
- 3:59 PM Changeset in webkit [68702] by
-
- 6 edits4 adds in trunk
REGRESSION (r66129): Loading full-frame .swf file crashes with flash blocker extension enabled
<https://bugs.webkit.org/show_bug.cgi?id=46773>
<rdar://problem/8390975>
Reviewed by Brady Eidson.
WebCore:
After r66129, start scripts were run on plugin documents, and cancelling the load of a plugin
document could cause Safari to crash.
If a plugin load on an initial document is cancelled, we cancel the main resource load (where the
main resource is the plugin), and if the load is restarted and allowed, we don't go through the manual
loading path like we do on the initial load of a plugin in a plugin document.
Tests: plugins/plugin-document-load-prevented-userscript.html
plugins/plugin-document-willSendRequest-null.html
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): If the plugin load was cancelled, and this is in a
plugin document, call a function on PluginDocument that cancels the main resource load, and
sets a plugin document flag.
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes): Null check the widget's renderer, because it could be
null if the load was cancelled.
(WebCore::PluginDocument::PluginDocument): Initialize the new variable.
(WebCore::PluginDocument::cancelManualPluginLoad): Cancel the main resource load of the plugin document
(which is a plugin in the case of a plugin document).
- html/PluginDocument.h:
(WebCore::PluginDocument::shouldLoadPluginManually): Returns whether or not we should load the plugin
manually.
(WebCore::PluginDocument::setShouldLoadPluginManually): Set whether or not we should load the plugin
manually.
(WebCore::toPluginDocument):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin): Check if we should load the plugin manually according to the plugin
document.
LayoutTests:
Add tests testing how plugin documents behave when the loading of their plugins are cancelled.
- plugins/plugin-document-load-prevented-userscript-expected.txt: Added.
- plugins/plugin-document-load-prevented-userscript.html: Added. Tests cancelling the load of a
plugin in a plugin document using beforeload and preventDefault.
- plugins/plugin-document-willSendRequest-null-expected.txt: Added.
- plugins/plugin-document-willSendRequest-null.html: Added. Tests cancelling the load of a plugin
in a plugin document by having willSendRequest return null.
- 3:58 PM Changeset in webkit [68701] by
-
- 3 edits2 adds in branches/safari-533.19-branch
Merge r63138.
- 3:53 PM Changeset in webkit [68700] by
-
- 8 edits in trunk
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829
- WebKit.gyp:
- tests/ArenaTestHelpers.h: (WebCore::ArenaTestHelpers::TrackedAllocator::free):
- tests/IDBKeyPathTest.cpp: (WebCore::checkKeyPath):
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): (WebViewHost::WebViewHost):
- 3:52 PM Changeset in webkit [68699] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r63836.
- 3:52 PM Changeset in webkit [68698] by
-
- 6 edits7 adds in branches/safari-533.19-branch
Merge r63834.
- 3:51 PM Changeset in webkit [68697] by
-
- 4 edits8 adds in branches/safari-533.19-branch
Merge r59185.
- 3:22 PM Changeset in webkit [68696] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46844, make estimateLogicalTopPosition
block-flow-aware.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
- rendering/RenderBlock.h:
- 3:22 PM Changeset in webkit [68695] by
-
- 5 edits in branches/audio/WebCore
audio branch: fixes for landing in trunk
- AudioContext fix to avoid deleting very large number of AudioNodes all at once
- HRTFPanner and DelayDSPKernel cleanup
- 3:11 PM Changeset in webkit [68694] by
-
- 2 edits in branches/safari-533.19-branch/JavaScriptCore
Merge r66119.
- 3:08 PM Changeset in webkit [68693] by
-
- 6 edits1 add in branches/safari-533.19-branch
Merge r65947.
- 3:06 PM Changeset in webkit [68692] by
-
- 2 edits in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Minor cleanup to AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46843
No new tests since audio API is not yet implemented
- webaudio/AudioContext.cpp: (WebCore::AudioContext::lock): (WebCore::AudioContext::handleDeferredFinishDerefs):
- 3:06 PM Changeset in webkit [68691] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror on chromium linux webkit
https://bugs.webkit.org/show_bug.cgi?id=46821
- WebKit.gyp:
- src/gtk/WebInputEventFactory.cpp:
- 3:02 PM Changeset in webkit [68690] by
-
- 3 edits in trunk
2010-09-29 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798
There was a switch statement which missed enum entries in getPropertyCSSValue().
This change added these entries to prevent the leak.
It also added extra case statements to encourage the compiler's help.
Test: fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2010-09-29 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798
- fast/css/getComputedStyle/margin-top-bottom-collapse-alias-expected.txt: Added.
- fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html: Added.
- fast/css/getComputedStyle/script-tests/margin-top-bottom-collapse-alias.js: Added.
- 2:56 PM Changeset in webkit [68689] by
-
- 2 edits in trunk/WebCore
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Limit number of AudioNode deletions per render quantum in AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46834
No new tests since audio API is not yet implemented.
- webaudio/AudioContext.cpp: (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::deleteMarkedNodes):
- 2:46 PM Changeset in webkit [68688] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed removal of unused #define from WebHistory.h.
Chromium usage of WEBKIT_BUG_40451_IS_FIXED was removed with
http://crrev.com/50642.
- public/WebHistoryItem.h:
- 2:45 PM Changeset in webkit [68687] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46838
Reviewed by Simon Fraser.
Get rid of the marginXXXUsing/setMarginXXXUsing methods on RenderBox. I'm inverting the way these are called
and putting the methods on RenderBlock instead. The methods can be named better this way and the getters
can operate on RenderBoxModelObjects instead of just RenderBoxes.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeBlockDirectionMargins):
- rendering/RenderBox.h:
(WebCore::RenderBox::setMarginTop):
(WebCore::RenderBox::setMarginBottom):
(WebCore::RenderBox::setMarginLeft):
(WebCore::RenderBox::setMarginRight):
- 2:39 PM Changeset in webkit [68686] by
-
- 14 edits2 adds in trunk/WebKit2
Implement more of PluginProxy and PLuginControllerProxy.
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeBytes):
- Platform/CoreIPC/ArgumentDecoder.h:
Add new overload that takes a DataReference. Wrap the debug function in #ifndef NDEBUG.
- Platform/CoreIPC/ArgumentEncoder.cpp:
- Platform/CoreIPC/ArgumentEncoder.h:
Wrap the debug function in #ifndef NDEBUG.
- Platform/CoreIPC/Arguments.h:
Add new typedefs.
- Platform/CoreIPC/DataReference.cpp:
- Platform/CoreIPC/DataReference.h:
Add a DataReference class.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add new overload.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::didEvaluateJavaScript):
(WebKit::PluginControllerProxy::streamDidReceiveResponse):
(WebKit::PluginControllerProxy::streamDidReceiveData):
(WebKit::PluginControllerProxy::streamDidFinishLoading):
(WebKit::PluginControllerProxy::streamDidFail):
call Plugin member functions.
- PluginProcess/PluginControllerProxy.messages.in:
Add new messages.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add DataReference.cpp and DataReference.h
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::didEvaluateJavaScript):
(WebKit::PluginProxy::streamDidReceiveResponse):
(WebKit::PluginProxy::streamDidReceiveData):
(WebKit::PluginProxy::streamDidFinishLoading):
(WebKit::PluginProxy::streamDidFail):
Send messages.
- 2:21 PM Changeset in webkit [68685] by
-
- 10 edits in trunk/LayoutTests
2010-09-29 Stephen White <senorblanco@chromium.org>
Unreviewed; updated test results.
[CHROMIUM] New test results after r68680.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 2:12 PM Changeset in webkit [68684] by
-
- 2 edits in trunk/WebKit2
Update expected results.
- Scripts/webkit2/messages_unittest.py:
- 2:12 PM Changeset in webkit [68683] by
-
- 3 edits in trunk/WebCore
Removed input type site-specific quirk for mail.google.com
https://bugs.webkit.org/show_bug.cgi?id=46836
Reviewed by Sam Weinig.
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::needsGmailQuirk): Removed.
(WebCore::JSHTMLInputElement::type): Removed this custom getter.
- html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute
from the type attribute.
- 1:56 PM Changeset in webkit [68682] by
-
- 2 edits in trunk/WebCore
2010-09-29 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Simon Fraser.
CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777
It should not be possible to get to be in the LoadingFromSourceElement
state with a null current source node. This was a possible scenario
where the current source node was cleared but the load state was not
cleared as well. Tried and could not create a test case for this.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.
- 1:12 PM Changeset in webkit [68681] by
-
- 9 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights. Rename stretchesToViewHeight.
Reviewed by Dan Bernstein.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.
Reviewed by Dan Bernstein.
- platform/mac/fast/blockflow/root-lr-basic-expected.txt:
- 12:59 PM Changeset in webkit [68680] by
-
- 19 edits2 adds in trunk
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
Reviewed by Darin Adler.
WebCore:
Support the "speak" style as defined in
http://www.w3.org/TR/css3-speech/#speak
This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.
Test: platform/mac/accessibility/css-speech-speak.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::speakProperty):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::speakProperty):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::speak):
(WebCore::InheritedFlags::setSpeak):
(WebCore::InheritedFlags::initialSpeak):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::speak):
LayoutTests:
- platform/mac/accessibility/css-speech-speak-expected.txt: Added.
- platform/mac/accessibility/css-speech-speak.html: Added.
- 12:33 PM Changeset in webkit [68679] by
-
- 3 edits in trunk/WebCore
2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
Reviewed by Antonio Gomes.
[Curl] Fix unused and unitialized warnings.
https://bugs.webkit.org/show_bug.cgi?id=46831
No new tests since no new funcionality has been added.
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::allowsAnyHTTPSCertificateHosts):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::handleLocalReceiveResponse): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::initializeHandle):
- 12:32 PM Changeset in webkit [68678] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46824
Reviewed by Sam Weinig.
Convert layoutBlockChild (but not the functions it calls) to be block-flow-aware.
fast/blockflow/root-lr.html progresses as a result of this change.
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
- rendering/RenderBox.h:
LayoutTests:
- platform/mac/fast/blockflow/root-lr-basic-expected.txt:
- 12:17 PM Changeset in webkit [68677] by
-
- 11 edits in trunk/WebKit2
Implement LoadURL
https://bugs.webkit.org/show_bug.cgi?id=46826
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentCoders.h:
Move String argument coder here from WebCoreArgumentCoders.h. Add
argument coder for AtomicString.
- Platform/CoreIPC/Arguments.h:
Add typedefs for Arguments7.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add handleMessage overload that takes 7 parameters.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::loadURL):
Send the LoadURL message.
- Scripts/webkit2/messages.py:
(parse_parameter_string): Use rsplit in case the type name contains spaces.
(argument_coder_headers_for_type): Special case Vector.
- Scripts/webkit2/messages_unittest.py:
Update results.
- Shared/WebCoreArgumentCoders.h:
Add argument coder for HTTPHeaderMap.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::loadURL):
Ask the plug-in controller to load the URL.
- WebProcess/Plugins/PluginProxy.messages.in:
Add LoadURL message.
- 12:12 PM Changeset in webkit [68676] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
[CHROMIUM] Update test_expectations to better reflect the state of the
build.
- platform/chromium/test_expectations.txt:
- 12:08 PM Changeset in webkit [68675] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, adding one more missing change from the last patch.
https://bugs.webkit.org/show_bug.cgi?id=46524
- WebKit.gyp:
- 12:08 PM Changeset in webkit [68674] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-09-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
Avoid touching the po files automatically during the build
process. The maintainers still have the option of forcing an
update with make update-po.
- GNUmakefile.am:
- 12:07 PM Changeset in webkit [68673] by
-
- 11 edits1 copy in trunk/WebKitTools
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Record bot ID when updating queue status
https://bugs.webkit.org/show_bug.cgi?id=46764
Since we now have multiple bots handling patches from the commit queue,
we need to differentiate status updates from them, so that we can group
the queue status page in a less confusing way.
- QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
- QueueStatusServer/model/queuestatus.py: Add bot_id property
- QueueStatusServer/templates/updatestatus.html: Add bot_id input
- Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
- Scripts/webkitpy/common/net/statusserver.py: Add bot_id
- Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
- Scripts/webkitpy/tool/main.py: Add --bot-id
- Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
- 12:04 PM Changeset in webkit [68672] by
-
- 1 edit2 adds in trunk/WebKit/chromium
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, adding the new files that were supposed to be added
but I missed to include in my previous patch.
https://bugs.webkit.org/show_bug.cgi?id=46524
- src/WorkerAsyncFileSystemChromium.cpp: Added.
- src/WorkerAsyncFileSystemChromium.h: Added.
- 11:47 AM Changeset in webkit [68671] by
-
- 2 edits in trunk
Fixed reviewer names.
- 11:44 AM Changeset in webkit [68670] by
-
- 5 edits3 adds in trunk
2010-09-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue "formatBlock" always returns false
https://bugs.webkit.org/show_bug.cgi?id=21305
Implemented queryCommandValue('formatBlock'). We match the Firefox's behavior exactly
because Firefox and Internet Explorer support the same set of elements
(address, h1, h2, h3, h4, h5, h6, and p) and Firefox's behavior is more compatible with Opera.
See the bug for the detailed discussion.
WebKit's implementation returns the local name of the lowest common ancestor
of the selection with the tag name address, h1, h2, h3, h4, h5, h6, or p.
It returns "" when there is no such an ancestor or there is no selection.
Test: editing/execCommand/query-format-block.html
- editing/Editor.cpp: (WebCore::isElementForFormatBlockCommand): (WebCore::Editor::elementForFormatBlockCommand):
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::valueFormatBlock): (WebCore::createCommandMap):
2010-09-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue "formatBlock" always returns false
https://bugs.webkit.org/show_bug.cgi?id=21305
Added a test for queryCommandValue('formatBlock').
- editing/execCommand/query-format-block-expected.txt: Added.
- editing/execCommand/query-format-block.html: Added.
- editing/execCommand/script-tests/query-format-block.js: Added. (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
- 11:12 AM Changeset in webkit [68669] by
-
- 9 edits in trunk/WebKit/chromium
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Bridge all FileSystem operations on Workers to the MainThread
https://bugs.webkit.org/show_bug.cgi?id=46524
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed the worker case code to create WebFileSystemCallbacksImpl with the current ScriptExecutionContext (WorkerContext).
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a new constructor that takes ScriptExecutionContext (WorkerContext) for workers. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Added the code for workers that creates WorkerAsyncFileSystemChromium.
- src/WebFileSystemCallbacksImpl.h:
- src/WorkerAsyncFileSystemChromium.cpp: Added.
- src/WorkerAsyncFileSystemChromium.h: Added.
- src/WorkerFileSystemCallbacksBridge.cpp: Added methods for regular file system operations to proxy them to the main thread. (WebKit::WorkerFileSystemCallbacksBridge::createForOpenFileSystem): (WebKit::WorkerFileSystemCallbacksBridge::createForMove): (WebKit::WorkerFileSystemCallbacksBridge::createForCopy): (WebKit::WorkerFileSystemCallbacksBridge::createForRemove): (WebKit::WorkerFileSystemCallbacksBridge::createForReadMetadata): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateFile): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateDirectory): (WebKit::WorkerFileSystemCallbacksBridge::createForFileExists): (WebKit::WorkerFileSystemCallbacksBridge::createForDirectoryExists): (WebKit::WorkerFileSystemCallbacksBridge::createForReadDirectory): (WebKit::MainThreadFileSystemCallbacks::didSucceed): (WebKit::MainThreadFileSystemCallbacks::didReadMetadata): (WebKit::MainThreadFileSystemCallbacks::didReadDirectory): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::derefIfWorkerIsStopped):
- src/WorkerFileSystemCallbacksBridge.h:
- 11:08 AM Changeset in webkit [68668] by
-
- 3 edits in trunk/WebKit/gtk/po
2010-09-29 Miloš Popović <gpopac@gmail.com>
Reviewed by Gustavo Noronha Silva.
Serbian translations update.
- sr.po:
- sr@latin.po:
- 11:01 AM Changeset in webkit [68667] by
-
- 1 edit2 copies in branches/chromium/517
Merge 68485
BUG=56621
Review URL: http://codereview.chromium.org/3520007
- 11:01 AM Changeset in webkit [68666] by
-
- 7 edits in trunk
2010-09-29 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Remove obsolete registerExtension variants from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46683
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
2010-09-29 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Remove obsolete registerExtension variants from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46683
- public/WebScriptController.h:
- src/WebScriptController.cpp:
- 10:58 AM Changeset in webkit [68665] by
-
- 5 edits in trunk
2010-09-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
https://bugs.webkit.org/show_bug.cgi?id=46822
- platform/gtk/Skipped: Unskip a test which is no longer crashing.
2010-09-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
https://bugs.webkit.org/show_bug.cgi?id=46822
When parentObjectUnignored returns null in objectAndOffsetUnignored consider that
a failure case. Handle this failure appropriately at all call sites.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Handle the failure of objectAndOffsetUnignored. (objectAndOffsetUnignored): Always check the return value of parentObjectUnignored and return 0 to indicate failure when that happens.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Handle the failure case of objectAndOffsetUnignored.
- 10:56 AM Changeset in webkit [68664] by
-
- 2 edits2 copies in branches/chromium/517
Merge 68408
BUG=56692
Review URL: http://codereview.chromium.org/3559003
- 10:52 AM Changeset in webkit [68663] by
-
- 1 edit2 copies in branches/chromium/517
Merge 68340
BUG=56796
Review URL: http://codereview.chromium.org/3521003
- 10:46 AM Changeset in webkit [68662] by
-
- 12 edits in trunk/WebKit2
Handle getting the user agent in the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=46819
Reviewed by Sam Weinig.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add new handleMessage overload.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::create):
(WebKit::PluginControllerProxy::PluginControllerProxy):
Pass the user agent to the plug-in controller proxy.
(WebKit::PluginControllerProxy::userAgent):
Return the user agent.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin):
Pass the user agent when creating the plug-in controller proxy.
- PluginProcess/WebProcessConnection.messages.in:
Add userAgent.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent):
- WebProcess/Plugins/PluginController.h:
Remove the URL parameter to userAgent.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Pass the user agent to WebProcessConnection::CreatePlugin.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::userAgent):
Remove url parameter.
- 10:46 AM Changeset in webkit [68661] by
-
- 14 edits2 deletes in trunk/WebCore
2010-09-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68657.
http://trac.webkit.org/changeset/68657
https://bugs.webkit.org/show_bug.cgi?id=46820
reason "Breaks win debug build" (Requested by podivilov on
#webkit).
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
- dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl): (WebCore::InspectorController::characterDataModifiedImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
- inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::characterDataModified): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
- inspector/InspectorInstrumentation.cpp: Removed.
- inspector/InspectorInstrumentation.h: Removed.
- workers/SharedWorker.cpp:
- 10:32 AM Changeset in webkit [68660] by
-
- 2 edits in trunk/WebCore
2010-09-29 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Performance improvement for FontLinux.
https://bugs.webkit.org/show_bug.cgi?id=46374
Reduce new/delete operations by storing the maximum capacity of the glyph
array and use that value in subsequent HB_ShapeItem calls. (Note that a
call to HB_ShapeItem may reduce the value of m_item.num_glyphs below the
capacity.)
Also be consistent with zero'ing the glyph arrays before calling
HB_ShapeItem.
There is no functionality changes so no new tests are added.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
- 10:23 AM Changeset in webkit [68659] by
-
- 9 edits in trunk
Implement more PluginProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=46815
Reviewed by Sam Weinig.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::handleMouseEvent):
(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::setFocus):
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowFrameChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
Call the appropriate Plugin member functions.
- PluginProcess/PluginControllerProxy.messages.in:
Add new messages.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
It's OK to get a message for a plug-in controller proxy that has gone away.
(WebKit::WebProcessConnection::didReceiveSyncMessage):
Forward the message to the PluginControllerProxy handler.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::setFocus):
(WebKit::PluginProxy::windowFocusChanged):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::windowVisibilityChanged):
Send messages to the plug-in process.
(WebKit::PluginProxy::controller):
Return the plug-in controller.
- 10:19 AM Changeset in webkit [68658] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-29 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Add method which checks if a WebAccessibilityObject is in the cache.
https://bugs.webkit.org/show_bug.cgi?id=46605
- public/WebAccessibilityCache.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::isCached):
- src/WebAccessibilityCacheImpl.h:
- 10:19 AM Changeset in webkit [68657] by
-
- 14 edits2 adds in trunk/WebCore
2010-09-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
- dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
- inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
- 10:15 AM Changeset in webkit [68656] by
-
- 7 edits in trunk
2010-09-29 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Darin Fisher.
[chromium] Honor z-index specified by a plugin
https://bugs.webkit.org/show_bug.cgi?id=46223
The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- plugins/iframe-shims.html:
2010-09-29 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Darin Fisher.
[chromium] Honor z-index specified by a plugin
https://bugs.webkit.org/show_bug.cgi?id=46223
The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.
- src/WebPluginContainerImpl.cpp:
- 10:10 AM Changeset in webkit [68655] by
-
- 2 edits in trunk/WebKitTools
2010-09-29 Simon Fraser <Simon Fraser>
No review.
References always refert to a file in .xht format, even
for HTML tests, so fix their loading.
- CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
- 10:00 AM Changeset in webkit [68654] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not any functions it calls)
to be block-flow-aware.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
- rendering/RenderBlock.h:
- rendering/RenderBox.h:
(WebCore::RenderBox::scrollbarLogicalHeight):
- 9:46 AM Changeset in webkit [68653] by
-
- 2 edits in trunk/WebKit/qt
2010-09-29 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
https://bugs.webkit.org/show_bug.cgi?id=46812
Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
instead of keeping a local pointer to it.
This is cleanup for a follow-up patch.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay): (QGraphicsWebView::paint): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry):
- 9:43 AM Changeset in webkit [68652] by
-
- 4 edits in trunk
2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] General small fixes.
https://bugs.webkit.org/show_bug.cgi?id=46813
This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.
No new tests since no new funcionality has been added.
- platform/efl/SharedBufferEfl.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] General small fixes.
https://bugs.webkit.org/show_bug.cgi?id=46813
This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.
- WebCoreSupport/FullscreenVideoControllerEfl.cpp: (FullscreenVideoController::canPlay):
- 9:31 AM Changeset in webkit [68651] by
-
- 10 edits in trunk/JavaScriptCore/qt
2010-09-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QScriptEngine should have an API for creating Date objects
https://bugs.webkit.org/show_bug.cgi?id=41667
Implement newDate(), isDate() and toDateTime() functions. Use the
QDateTime::{to,set}MSecsSinceEpoch() functions to do the
calculations.
- api/qscriptengine.cpp: (QScriptEngine::newDate):
- api/qscriptengine.h:
- api/qscriptengine_p.cpp: (QScriptEnginePrivate::newDate):
- api/qscriptengine_p.h: (QScriptEnginePrivate::isDate):
- api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): need to keep track of Date Constructor and Prototype. (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): ditto. (QScriptOriginalGlobalObject::isDate): use the Date Constructor and Prototype to identify Date values.
- api/qscriptvalue.cpp: (QScriptValue::isDate): (QScriptValue::toDateTime):
- api/qscriptvalue.h:
- api/qscriptvalue_p.h: (QScriptValuePrivate::isDate): (QScriptValuePrivate::toDateTime):
- tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newDate):
- 9:06 AM Changeset in webkit [68650] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated baselines of
svg/css/getComputedStyle-basic.xhtml after the css properties
were renamed in r68561.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 8:55 AM Changeset in webkit [68649] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-29 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Next try to fix cygwin build.
- wtf/Assertions.cpp:
- 8:44 AM Changeset in webkit [68648] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-29 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Build fix for cygwin #2. Oops, it's OS(WINDOWS), not OS(WIN).
- wtf/Assertions.cpp:
- 8:35 AM Changeset in webkit [68647] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-29 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Build fix for cygwin.
- wtf/Assertions.cpp:
- 8:34 AM Changeset in webkit [68646] by
-
- 2 edits in trunk/WebKit2
Look for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug builds
Fixes <http://webkit.org/b/46809> <rdar://problem/8491809> REGRESSION
(r67979): All tests crashing on Windows WebKit2 test bot
Reviewed by Sam Weinig.
- UIProcess/Launcher/win/ProcessLauncherWin.cpp: WebKit_debug.dll is
only used in Debug_All builds (but WebKit2WebProcess_debug.exe is used
in all non-Debug_Internal debug-style builds).
- 8:11 AM Changeset in webkit [68645] by
-
- 2 edits in trunk/WebCore
2010-09-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795
Call make-values.pl once only. It seems calling it multiple times
in the same build produces a wrong CSSValueKeywordsHash.h which
has a duplicate declaration of its valueList variable. The double
call is triggered by the double targets in the Makefile rules and
makevalues.pl generates one of them, which screws up the build. A
more proper fix should be done with the advices on
http://www.cmcrossroads.com/cm-basics/12905-rules-with-multiple-outputs-in-gnu-make
- GNUmakefile.am:
- 8:06 AM Changeset in webkit [68644] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-29 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[WINCE] Buildfix for Assertions.cpp after r68511.
https://bugs.webkit.org/show_bug.cgi?id=46807
Some, but not all WinCE environments have support for IsDebuggerPresent().
Add HAVE(ISDEBUGGERPRESENT) to make this a build option.
HAVE(ISDEBUGGERPRESENT) will be 1 for all OS(WIN) by default.
- wtf/Assertions.cpp:
- wtf/Platform.h:
- 7:46 AM Changeset in webkit [68643] by
-
- 2 edits in trunk/WebCore
2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
Unreviewed build fix.
Fix CMake build for ENABLE_PROGRESS_TAG.
https://bugs.webkit.org/show_bug.cgi?id=46808
No new tests since it's a build fix.
- CMakeLists.txt:
- 6:56 AM Changeset in webkit [68642] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-09-29 Reinout van Schouwen <reinouts@gnome.org>
Reviewed by Gustavo Noronha.
[GTK] Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=46050
- nl.po:
- 6:46 AM Changeset in webkit [68641] by
-
- 2 edits in trunk/WebCore
2010-09-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
https://bugs.webkit.org/show_bug.cgi?id=46803
No new tests. It's covered by existing tests under LayoutTests/storage
- bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
- 6:45 AM Changeset in webkit [68640] by
-
- 14 edits in trunk
2010-09-29 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
https://bugs.webkit.org/show_bug.cgi?id=46799
- fast/speech/input-appearance-numberandspeech.html:
- fast/speech/input-appearance-searchandspeech.html:
- fast/speech/input-appearance-speechbutton.html:
- fast/speech/input-text-speechbutton.html:
- fast/speech/speech-button-ignore-generated-events.html:
2010-09-29 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
https://bugs.webkit.org/show_bug.cgi?id=46799
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitspeechEnabled): Rename the runtime feature flag getter.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in: Rename the css style name.
- css/html.css: Rename the css style name. (input::-webkit-input-speech-button):
- html/HTMLAttributeNames.in: Rename the @speech attribute.
- html/HTMLInputElement.cpp: Update code using the attribute. (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::isSpeechEnabled):
- html/HTMLInputElement.idl: Rename the @speech attribute.
- 5:45 AM Changeset in webkit [68639] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-29 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
JSC compile fails on 32bit platform when Regexp Tracing is enabled
https://bugs.webkit.org/show_bug.cgi?id=46713
Fix the cast of pointer in regexp tracing to avoid the warning.
- runtime/RegExp.cpp: (JSC::RegExp::match):
- 5:17 AM Changeset in webkit [68638] by
-
- 3 edits1 add in trunk/WebCore
2010-09-29 MORITA Hajime <morrita@google.com>
[Chromium] failed to build without ACCELERATED_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=46793
Moved constant definitions from inside ACCELERATED_COMPOSITING to
outside of the condition.
- WebCore.gypi:
- platform/graphics/chromium/VideoFrameChromium.cpp: Added just for defining constants.
- platform/graphics/chromium/VideoLayerChromium.cpp:
- 3:35 AM Changeset in webkit [68637] by
-
- 2 edits in trunk
[Qt] Fix the build on non-x86 platforms with gcc
Reviewed by Csaba Osztrogonác.
Don't disable -Werror on arm, that doesn't work when QT_ARCH is
for example armv6. Instead change the condition as the comment says,
enable -Werror on x86/gcc where we know it passes. On other platforms
gcc produces difference warnings, and when they're fixed we can add
them to the whitelist of -Werror-supported architectures.
- WebKit.pri:
- 2:14 AM Changeset in webkit [68636] by
-
- 10 edits3 adds in trunk/WebCore
2010-09-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [Resources panel] Need more visible "at a glance".
https://bugs.webkit.org/show_bug.cgi?id=45657
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.updateWidths): (WebInspector.DataGrid.prototype.sortNodes): (WebInspector.DataGrid.prototype._resizerDragging): (WebInspector.DataGrid.prototype._endResizerDragging): (WebInspector.DataGridNode.prototype.selectable.true.get element): (WebInspector.DataGridNode.prototype.createCells): (WebInspector.DataGridNode.prototype.refresh):
- inspector/front-end/Images/networkIcon.png: Copied from WebCore/inspector/front-end/Images/resourcesIcon.png.
- inspector/front-end/NetworkPanel.js: Added.
- inspector/front-end/Settings.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.toolbar-item.network .toolbar-icon): (.data-grid .data-container):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
- inspector/front-end/networkPanel.css: Added.
- 12:59 AM Changeset in webkit [68635] by
-
- 7 edits in trunk/WebCore
2010-09-28 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move pauseOnExceptionState under control of InspectorState
It is Inspector Protocol cleanup activity.
The actual state of this flag can be obtained as a return value of setPauseOnExceptionState command
or as a value in InspectorState object.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::pauseOnExceptionsState):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
- inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone): (WebInspector.reportProtocolError):
- 12:09 AM Changeset in webkit [68634] by
-
- 2 edits in trunk/LayoutTests
2010-09-29 James Kozianski <koz@chromium.org>
Reviewed by James Robinson.
Update test_expectations.txt from the flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=46787
Updates some canvas/philip tests in test_expectations.txt that have
started passing on the flakiness dashboard.
- platform/chromium/test_expectations.txt:
