Timeline
Oct 1, 2010:
- 11:01 PM Changeset in webkit [68973] by
-
- 4 edits in trunk/WebKitTools
2010-10-01 Simon Fraser <Simon Fraser>
Add the ability to remove results for re-testing, and
to import results.
- CSSTestSuiteHarness/harness/harness.css: (.custom button): (#overlay): (#overlay.visible): (.overlay-contents): (.overlay-contents textarea): (.overlay-contents .buttons): (.overlay-contents .note): (.overlay-contents .buttons button):
- CSSTestSuiteHarness/harness/harness.html:
- CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.importResults): (TestSuite.prototype.clearResults): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.importTestResults): (TestSuite.prototype.clearTestResults):
- 9:49 PM Changeset in webkit [68972] by
-
- 13 edits2 adds in trunk/WebCore
2010-10-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
FormatBlockCommand and IndentOutdentCommand should use the same code to iterate paragraphs
https://bugs.webkit.org/show_bug.cgi?id=46840
Added ApplyBlockElementCommand, which is an abstract class inherited by FormatBlockCommand
and IndentOutdentCommand. It is intended to be inherited by InsertListCommand as well.
ApplyBlockElementCommand's doApply verifies the current selection and exits early
if it's invalid or orphaned or if the current selection is outside editable region.
It then calls formatSelection to apply the block element after which doApply restores the selection.
formatSelection iterates through paragraphs and calls formatParagraph, a pure virtual function
implemented by FormatBlockCommand and IndentOutdentCommand, on each paragraph.
No new tests are added since this is a refactoring.
- Android.mk: Added ApplyBlockElementCommand.cpp.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Added ApplyBlockElementCommand.cpp and ApplyBlockElementCommand.h.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- editing/ApplyBlockElementCommand.cpp: Added. (WebCore::countParagraphs): Moved from IndentOutdentCommand.cpp (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): Added. (WebCore::ApplyBlockElementCommand::doApply): Moved from IndentOutdentCommand::doApply. (WebCore::ApplyBlockElementCommand::formatSelection): Moved from IndentOutdentCommand::indentRegion. (WebCore::ApplyBlockElementCommand::createBlockElement): Added. (WebCore::ApplyBlockElementCommand::splitTextNodes): Moved from IndentOutdentCommand::splitTextNodes.
- editing/ApplyBlockElementCommand.h: Added.
- editing/EditingAllInOne.cpp:
- editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
- editing/FormatBlockCommand.cpp: Removed doApply. (WebCore::FormatBlockCommand::FormatBlockCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::FormatBlockCommand::formatParagraph): Renamed from doApplyForSingleParagraph.
- editing/FormatBlockCommand.h: FormatBlockCommand inherits from ApplyBlockElementCommand. (WebCore::FormatBlockCommand::create): Uses QualifiedName for the tag name instead of AtomicString.
- editing/IndentOutdentCommand.cpp: Removed doApply, indentIntoBlockquote, and splitTextNodes. (WebCore::IndentOutdentCommand::IndentOutdentCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::IndentOutdentCommand::indentIntoBlockquote): The code to nullify targetBlockquote when the next paragraph is in a different table cell is moved to ApplyBlockElementCommand::formatSelection. (WebCore::IndentOutdentCommand::formatSelection): Added. Calls outdentRegion when outdenting. (WebCore::IndentOutdentCommand::formatParagraph): Added. Calls tryIndentingAsListItem and indentIntoBlockquote.
- editing/IndentOutdentCommand.h: IndentOutdentCommand inherits from ApplyBlockElementCommand.
- 9:01 PM Changeset in webkit [68971] by
-
- 13 edits in trunk
Build fix.
Clear the executable bit from a number of source files.
WebCore:
- page/Frame.cpp:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- platform/graphics/win/WKCACFLayerRenderer.h:
- platform/network/ResourceRawHeaders.h:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderLayerCompositor.h:
WebKit/win:
- WebView.cpp:
- WebView.h:
WebKit2:
- WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
- 8:22 PM Changeset in webkit [68970] by
-
- 2 edits in trunk/WebCore
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] r68923 broke some plugin tests
https://bugs.webkit.org/show_bug.cgi?id=47040
No longer pass focus and blur events to plugins when the "old" DOM Level
2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
that the DOM Level 3 version is always fired for this event.
No new tests, as this should cause the failing tests to pass.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): No longer pass focus and blur events to plugins when DOMFocusIn / DOMFocusOut events occur.
- 7:17 PM Changeset in webkit [68969] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Removed an expected result for a previously skipped test. This test
is skipped because it fails on 1 (out of 4) GTK+ bots. It had
started failing again after the WebSocket tests were relocated and
the skipped list was no longer up to date.
- platform/gtk/Skipped: Update skipped list to reflect new test location.
- platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
- 7:08 PM Changeset in webkit [68968] by
-
- 2 edits1 move in trunk/LayoutTests
2010-10-01 Tony Chang <tony@chromium.org>
Unreviewed. Turns out Safari Win matches Safari Mac so move the
expectation to chromium-win.
- platform/chromium-win/editing/selection/5354455-1-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/5354455-1-expected.txt.
- platform/win/Skipped:
- 7:01 PM Changeset in webkit [68967] by
-
- 3 edits in trunk/LayoutTests
2010-10-01 Tony Chang <tony@chromium.org>
Unreviewed. Updating layout test (editing/selection/5354455-1.html) after r68948.
Will fix soon.
- platform/chromium/test_expectations.txt:
- platform/win/Skipped:
- 6:54 PM Changeset in webkit [68966] by
-
- 5 edits in trunk/WebKitTools
Deploy the new WKString functions to remove most uses of CF from
the WebKitTestRunner.
Reviewed by Jon Honeycutt.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):
- WebKitTestRunner/StringFunctions.h:
(WTR::toWK):
(WTR::toJS):
(WTR::toSTD):
(WTR::operator<<):
(WTR::copyURLString):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishLoadForFrame):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- 6:46 PM Changeset in webkit [68965] by
-
- 5 edits in branches/safari-533.19-branch
Versioning.
- 6:42 PM Changeset in webkit [68964] by
-
- 1 copy in tags/Safari-533.19.1
New tag.
- 6:17 PM Changeset in webkit [68963] by
-
- 2 edits in trunk/WebKitTools
2010-10-01 Mihai Parparita <mihaip@chromium.org>
Unreviewed TestResultsServer change.
Add files introduced by http://crrev.com/61273 to the list of dashboard
files to update.
- TestResultServer/handlers/dashboardhandler.py:
- 5:45 PM Changeset in webkit [68962] by
-
- 11 edits in trunk
WebCore: Plug-ins should have access to the private browsing state.
https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>
Reviewed by Sam Weinig.
- page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged):
When iterating over all widgets, also look for PluginViewBase classes and invoke their
privateBrowsingStateChange member function.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::privateBrowsingStateChanged):
Add function.
WebKit2: Plug-ins should have access to the private browsing state.
https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle NPNVprivateModeBool.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
Call PluginController::isPrivateBrowsingEnabled.
(WebKit::NetscapePlugin::NPP_SetValue):
Add NPP_SetValue wrapper.
(WebKit::NetscapePlugin::privateBrowsingStateChanged):
Call NPP_SetValue with the updated state.
- WebProcess/Plugins/Plugin.h:
Add privateBrowsingStateChanged pure virtual member function.
- WebProcess/Plugins/PluginController.h:
Add isPrivateBrowsingEnabled pure virtual member function.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::privateBrowsingStateChanged):
Call Plugin::privateBrowsingStateChanged.
- 5:40 PM Changeset in webkit [68961] by
-
- 10 edits2 adds in trunk
WebKit2: Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
Reviewed by Anders Carlsson.
API Test: WebKit2/WKStringJSString
- Shared/API/c/WKString.cpp:
(WKStringCreateWithJSString):
(WKStringCopyJSString):
- Shared/API/c/WKStringPrivate.h: Added.
- Shared/WebString.h:
(WebKit::WebString::create):
(WebKit::WebString::createJSString):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
WebKitTools: Build Fix for Windows.
Patch by Brian Weinstein <bweinstein@apple.com> on 2010-10-01
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.
- 5:27 PM Changeset in webkit [68960] by
-
- 5 edits in trunk
Build Fix for Windows.
WebCore:
- WebCore.vcproj/WebCore.vcproj: Don't have an empty post-build step, use
WebCoreCommon.vsprops to handle post-build step.
- WebCore.vcproj/WebCoreCommon.vsprops: Set the post-build step to delete
$(WebKitOutputDir)/buildfailed.
WebKitTools:
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.
- 5:24 PM Changeset in webkit [68959] by
-
- 2 edits in trunk/WebCore
2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Segmentation fault during zoom out
https://bugs.webkit.org/show_bug.cgi?id=46984
- platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.
- 5:17 PM Changeset in webkit [68958] by
-
- 2 edits in trunk/WebCore
Another Qt build fix attempt.
- WebCore.pro:
- 5:13 PM Changeset in webkit [68957] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47021
Reviewed by Dan Bernstein.
Patch the floatBottom function and its friends. Rename them and consolidate them to be block-flow-aware.
Nothing testable yet, since most of the float code is still unpatched.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::hasOverhangingFloats):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::fitBelowFloats):
- 5:11 PM Changeset in webkit [68956] by
-
- 2 edits in trunk/WebKit/mac
Fix Snow Leopard build.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getProxy):
- 4:51 PM Changeset in webkit [68955] by
-
- 1 edit in branches/safari-533.19-branch/WebCore/editing/SelectionController.cpp
Build fix.
- 4:49 PM Changeset in webkit [68954] by
-
- 2 edits in trunk/WebCore
Fix typo.
- platform/network/qt/ProxyServerQt.cpp:
(WebCore::proxyServersForURL):
- 4:45 PM Changeset in webkit [68953] by
-
- 2 edits1 add in trunk/WebCore
Add Qt ProxyServer stub.
- WebCore.pro:
- platform/network/qt/ProxyServerQt.cpp: Added.
(WebCore::proxyServersForURL):
- 4:42 PM Changeset in webkit [68952] by
-
- 2 edits in trunk/WebKit2
Implement proxiesForURL, cookiesForURL and setCookiesForURL
https://bugs.webkit.org/show_bug.cgi?id=47029
Reviewed by Sam Weinig.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
- 4:28 PM Changeset in webkit [68951] by
-
- 9 edits3 adds in trunk
Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
https://bugs.webkit.org/show_bug.cgi?id=47022
<rdar://problem/8504712>
Reviewed by Dan Bernstein.
WebCore:
- WebCore.exp.in:
Export proxyServersForURL and toString.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- platform/network/ProxyServer.cpp: Added.
(WebCore::appendProxyServerString):
(WebCore::toString):
New function that converts a vector of ProxyServers into a PAC style string.
- platform/network/ProxyServer.h: Added.
(WebCore::ProxyServer::ProxyServer):
(WebCore::ProxyServer::type):
(WebCore::ProxyServer::hostName):
(WebCore::ProxyServer::port):
Add ProxyServer class.
- platform/network/cf/ProxyServerCFNet.cpp: Added.
(WebCore::proxyServersForURL):
(WebCore::addProxyServersForURL):
Query CFNetwork for the proxy servers given a URL.
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getProxy):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
- 4:25 PM Changeset in webkit [68950] by
-
- 25 edits in branches/safari-533.19-branch
Merge r60541.
- 4:25 PM Changeset in webkit [68949] by
-
- 26 edits in branches/safari-533.19-branch
Merge r59081.
- 4:21 PM Changeset in webkit [68948] by
-
- 5 edits1 add9 deletes in trunk/LayoutTests
2010-10-01 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
editing/selection/5354455-1 has incorrect description text
https://bugs.webkit.org/show_bug.cgi?id=44990
This test includes descriptive text that describes an OS X-specific behavior.
I almost checked in an incorrect baseline because I believed the text.
This change amends the text to describe expected behavior on Mac/Win/Linux.
Rather than requiring new baselines on all platforms, I took this opportunity
to also convert the test to a markup dump. We'll then end up with just one
Mac baseline and one non-Mac baseline.
- editing/selection/5354455-1.html:
- platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
- platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
- platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
- platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
- platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
- platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
- platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
- platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
- platform/mac/editing/selection/5354455-1-expected.png: Removed.
- platform/mac/editing/selection/5354455-1-expected.txt: Updated.
- platform/win/editing/selection/5354455-1-expected.txt: Added.
- 4:19 PM Changeset in webkit [68947] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r66269.
- 4:19 PM Changeset in webkit [68946] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r65934.
- 4:19 PM Changeset in webkit [68945] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r65683.
- 4:19 PM Changeset in webkit [68944] by
-
- 17 edits in branches/safari-533.19-branch/WebCore
Merge r65681.
- 4:17 PM Changeset in webkit [68943] by
-
- 2 edits34 adds in trunk/LayoutTests
Build fix. Not reviewed.
Add test expectations for Chromium.
- platform/chromium-linux/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/block-level-images-expected.png: Added.
- platform/chromium-linux/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/chromium-linux/fast/css/rtl-to-viewport-expected.png: Added.
- platform/chromium-linux/fast/css/rtl-to-viewport-expected.txt: Added.
- platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
- platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt: Added.
- platform/chromium-mac/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/block-level-images-expected.png: Added.
- platform/chromium-mac/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/chromium-mac/fast/css/rtl-to-viewport-expected.png: Added.
- platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
- platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt: Added.
- platform/chromium-win-xp/fast/blockflow/block-level-images-expected.png: Added.
- platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Added.
- platform/chromium-win/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/block-level-images-expected.png: Added.
- platform/chromium-win/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/chromium-win/fast/css/rtl-to-viewport-expected.png: Added.
- platform/chromium-win/fast/css/rtl-to-viewport-expected.txt: Added.
- platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
- platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt: Added.
- platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:09 PM Changeset in webkit [68942] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed a typo
- 4:09 PM Changeset in webkit [68941] by
-
- 5 edits6 adds in branches/safari-533.19-branch
- 4:08 PM Changeset in webkit [68940] by
-
- 7 edits1 add in trunk
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
texImage2D fails on 16-bit-per-channel images
https://bugs.webkit.org/show_bug.cgi?id=46947
- platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats. (WebCore::convertColor16To8): (WebCore::doPacking):
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
texImage2D fails on 16-bit-per-channel images
https://bugs.webkit.org/show_bug.cgi?id=46947
- fast/canvas/webgl/gl-teximage-expected.txt: Add a test case for loading 16-bit-per-channel images as textures.
- fast/canvas/webgl/gl-teximage.html: Ditto.
- fast/canvas/webgl/resources/green-2x2-16bit.png: Added.
- 4:01 PM Changeset in webkit [68939] by
-
- 2 adds in branches/safari-533.19-branch/LayoutTests
Add two files that were missed in the previous commit.
- 3:59 PM Changeset in webkit [68938] by
-
- 6 edits in branches/safari-533.19-branch
Merge r63048.
- 3:56 PM Changeset in webkit [68937] by
-
- 8 edits in branches/chromium/517
Merge 66992 - 2010-09-08 Andy Estes <aestes@apple.com>
TBR=abarth@google.com
TBR=dglazkov@google.com
BUG=55954
TEST=LayoutTests/fast/replaced/object-with-embed-url-param.html
Review URL: http://codereview.chromium.org/3551010
- 3:54 PM Changeset in webkit [68936] by
-
- 2 edits in branches/safari-533.19-branch/JavaScriptCore
Merge r68812.
- 3:51 PM Changeset in webkit [68935] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r68705.
- 3:49 PM Changeset in webkit [68934] by
-
- 2 edits in branches/safari-533.19-branch/WebCore
Merge r68727.
- 3:42 PM Changeset in webkit [68933] by
-
- 10 edits3 copies in branches/chromium/517
Merge 68630 - 2010-09-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292
Some windowed plugins did not handle events through EventHandler, so we
never set right gesture state for those events.
This change is to set right allowPopupsFromPlugin flag to current
execution frame, so WeKit can always get right gesture state on Mac.
From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
process, that process passes the allowPopupsFromPlugin flag to
WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
NetscapePluginInstanceProxy::evaluate.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2010-09-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292
Pass the right popupAllowed flag to current execution frame,
so WebKit can get right gesture status for popups initiated
from plugins.
This also makes v8 binding's ScriptController::processingUserGesture
match what jsc version.
Test: plugins/plugin-initiate-popup-window.html
- bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):
2010-09-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292.
Add a test to initiate popup windows from plugin during plugin is
handling mouse/keyboard event.
Disable this test on gtk/qt/win since the test plugin in those platforms
didn't implement NPP_HandleEvent.
- platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- plugins/plugin-initiate-popup-window-expected.txt: Added.
- plugins/plugin-initiate-popup-window.html: Added.
2010-09-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
- DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):
- 3:30 PM Changeset in webkit [68932] by
-
- 2 edits in trunk/LayoutTests
Build fix. Not reviewed.
Add test expectations for Chromium.
- platform/chromium/test_expectations.txt:
- 3:09 PM Changeset in webkit [68931] by
-
- 2 edits in trunk/WebCore
2010-10-01 Eric Uhrhane <ericu@chromium.org>
Reviewed by Nate Chapin.
Add v8 binding helpers to make FileWriter be an EventTarget.
https://bugs.webkit.org/show_bug.cgi?id=46910
No new tests; still waiting for the first complete implementation.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- 3:00 PM Changeset in webkit [68930] by
-
- 7 edits1 add in trunk
Add additional WKString API
https://bugs.webkit.org/show_bug.cgi?id=46958
Reviewed by Kenneth Rohde Christiansen.
WebKit2:
API Test: WebKit2/WKString
- Shared/API/c/WKString.cpp:
(WKStringCreateWithUTF8CString):
(WKStringGetMaximumUTF8CStringSize):
(WKStringGetUTF8CString):
(WKStringIsEqual):
(WKStringIsEqualToUTF8CString):
- Shared/API/c/WKString.h:
- Shared/WebString.h:
(WebKit::WebString::createFromUTF8String):
(WebKit::WebString::maximumUTF8CStringSize):
(WebKit::WebString::getUTF8CString):
(WebKit::WebString::equal):
(WebKit::WebString::equalToUTF8String):
WebKitTools:
Add basic WKStringRef tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
- 2:57 PM Changeset in webkit [68929] by
-
- 3 edits in trunk/WebKit/chromium
2010-10-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Remove WebURLLoaderClient::didFinishLoading(WebURLLoader*)
https://bugs.webkit.org/show_bug.cgi?id=47008
Now that WebURLLoaderClient::didFinishLoading(WebURLLoader*) has no
more callers, it can be removed (requires a Chromium roll to
http://crrev.com/61206, which actually removed the last usage).
- DEPS:
- public/WebURLLoaderClient.h:
- 2:43 PM Changeset in webkit [68928] by
-
- 2 edits in trunk/WebKitSite
2010-10-01 Alex Mathews <possessedpenguinbob@gmail.com>
Reviewed by Simon Fraser.
Bug 47013 - Main Web Inspector link on webkit.org links to old wiki page
https://bugs.webkit.org/show_bug.cgi?id=47013
- nav.inc: Removed the space from the web inspector wiki link.
- 2:30 PM Changeset in webkit [68927] by
-
- 2 edits1 copy in trunk/LayoutTests
Land post-XP results for fast/text/backslash-to-yen-sign-euc.html
The fonts this test uses must have changed after Windows XP
- platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:
Copied from LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt.
- platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
Updated for post-XP.
- 2:25 PM Changeset in webkit [68926] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47015
Reviewed by Sam Weinig.
Change FloatingObject to store its dimensions as a rect.
This will make it easier for logical access for block-flow later on if
top/bottom is no different from left/width. This change also simplifies
calling code a bit in places.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatBottomBelow):
(WebCore::RenderBlock::floatBottom):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::leftBottom):
(WebCore::RenderBlock::rightBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::left):
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::top):
(WebCore::RenderBlock::FloatingObject::bottom):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(WebCore::RenderBlock::FloatingObject::setLeft):
(WebCore::RenderBlock::FloatingObject::setTop):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::frameRect):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
- 2:18 PM Changeset in webkit [68925] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-10-01 Adam Barth <abarth@webkit.org>
Add a Gtk-specific baseline for a WebSocket test.
- platform/gtk/http/tests/websocket: Added.
- platform/gtk/http/tests/websocket/tests: Added.
- platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
- 2:07 PM Changeset in webkit [68924] by
-
- 1 edit4 adds in trunk/LayoutTests
Build fix. Not reviewed.
Add the dummy README file to solve build breakages in Chromium.
It should be removed once the breakage is resolved.
- websocket/tests/workers/README: Added.
- 1:50 PM Changeset in webkit [68923] by
-
- 7 edits in trunk
DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
https://bugs.webkit.org/show_bug.cgi?id=42580
<rdar://problem/8107311>
Reviewed by Darin Adler.
WebCore:
This change removes the aliased type machinery from the Event class.
We now fire the event with the new name and the oldname.
Tests: Modified fast/events/focusinout.html to check the event
type.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Event.cpp: Removed aliasedType and hasAliasedType.
- dom/Event.h: Removed aliasedType and hasAliasedType.
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners): Removed aliasedType related code.
LayoutTests:
- fast/events/focusinout.html: Modified to check the event type.
- 1:44 PM Changeset in webkit [68922] by
-
- 2 edits1 add in trunk/WebKitTools
Add makefile for TestWebKitAPI and call it from the base makefile.
Reviewed by Dan Bernstein.
- Makefile:
- TestWebKitAPI/Makefile: Added.
- 1:42 PM Changeset in webkit [68921] by
-
- 1 edit3 adds in trunk/LayoutTests
Land new Windows results for fast/text/international/bidi-mirror-he-ar.html
Fixes <http://webkit.org/b/47001> <rdar://problem/8503550>
fast/text/international/bidi-mirror-he-ar.html fails on Windows
Recommended by Dan Bernstein.
- platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
- platform/win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
- platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
- 1:29 PM Changeset in webkit [68920] by
-
- 2 edits in trunk/WebKit/efl
2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Remove check for InitLayoutCompleted on fixed_layout_size_set.
https://bugs.webkit.org/show_bug.cgi?id=47006
This check isn't needed and isn't done on the other ports. The fixed
layout property can be set before we have the first layout.
- ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set):
- 1:25 PM Changeset in webkit [68919] by
-
- 3 edits2 deletes in trunk/WebKitTools
Remove unnecessary ForwardingHeaders from test runners.
https://bugs.webkit.org/show_bug.cgi?id=47010
Reviewed by Adam Roben.
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/ForwardingHeaders: Removed.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/ForwardingHeaders: Removed.
- 1:05 PM Changeset in webkit [68918] by
-
- 4 edits in trunk/WebKit/efl
2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Call contents_resize when the main frame gets resized.
https://bugs.webkit.org/show_bug.cgi?id=47004
The previous implementation was just calling contents_resize when the
viewport size had changed. That's not enough, and contents_resize
shouldn't be called if the contents size didn't change.
Now the contents_size_changed function is called directly from the
ChromeClientEfl.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::contentsSizeChanged):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (_ewk_view_smart_calculate): (ewk_view_fixed_layout_size_set): (ewk_view_contents_size_changed):
- 12:59 PM Changeset in webkit [68917] by
-
- 12 edits7 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block-flow. This patch changes
all of the computeReplacedLogicalWidth and comuteReplacedLogicalHeight functions (and their helpers) to use logical width
and logical height instead.
Reviewed by Darin Adler.
Added fast/blockflow/block-level-images.html
WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
(WebCore::RenderReplaced::calcAspectRatioLogicalWidth):
(WebCore::RenderReplaced::calcAspectRatioLogicalHeight):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderReplaced.h:
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
- rendering/RenderSVGRoot.h:
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::computeReplacedLogicalWidth):
(WebCore::RenderVideo::computeReplacedLogicalHeight):
- rendering/RenderVideo.h:
LayoutTests:
- fast/blockflow/block-level-images.html: Added.
- fast/blockflow/resources: Added.
- fast/blockflow/resources/circle.svg: Added.
- fast/blockflow/resources/oval.png: Added.
- platform/mac/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/mac/fast/blockflow/block-level-images-expected.png: Added.
- platform/mac/fast/blockflow/block-level-images-expected.txt: Added.
- 12:52 PM Changeset in webkit [68916] by
-
- 2 edits in trunk/WebCore
2010-10-01 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Remove unused Request::buffer() and Request::m_buffer.
- loader/Request.h:
- 12:46 PM WebDevelopers edited by
- Minor update to Web Inspector link to avoid having to click through on … (diff)
- 12:40 PM Changeset in webkit [68915] by
-
- 3 edits in trunk/WebKit/chromium
2010-10-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData
https://bugs.webkit.org/show_bug.cgi?id=46937
This is a two-part patch--one to add the new methods with normalized
names that follow general WebKit convention, and a followup patch to
remove the original methods once Chromium is updated.
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::hasFileNames): renamed to containsFilenames (WebKit::WebDragData::fileNames): renamed to filenames (WebKit::WebDragData::setFileNames): renamed to setFilenames (WebKit::WebDragData::appendToFileNames): renamed to appendToFilenames (WebKit::WebDragData::containsFilenames): (WebKit::WebDragData::filenames): (WebKit::WebDragData::setFilenames): (WebKit::WebDragData::appendToFilenames): (WebKit::WebDragData::fileContentFileName): renamed to fileContentFilename (WebKit::WebDragData::setFileContentFileName): renamed to setFileContentFilename (WebKit::WebDragData::fileContentFilename): (WebKit::WebDragData::setFileContentFilename):
- 12:40 PM Changeset in webkit [68914] by
-
- 57 edits1 move in trunk
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebSocket tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=46956
Hosting the WebSocket tests using the Python HTTP server causes the
tests to time out occationally. This patch moves the tests to be
hosted by the usual Apache server.
This patch doesn't completely eliminate the flakiness. However,
testing on my local machine shows that it reduces it by a large factor.
I suspect there's more flakiness hiding in the Python server, but this
patch makes some amount of progress on the issue.
- http/tests/websocket: Copied from LayoutTests/websocket.
- http/tests/websocket/tests/alert-in-event-handler.html:
- http/tests/websocket/tests/bad-handshake-crash.html:
- http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
- http/tests/websocket/tests/bad-sub-protocol-empty.html:
- http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
- http/tests/websocket/tests/bufferedAmount-after-close.html:
- http/tests/websocket/tests/close-on-navigate-new-location.html:
- http/tests/websocket/tests/close-on-unload-and-force-gc.html:
- http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
- http/tests/websocket/tests/close-on-unload.html:
- http/tests/websocket/tests/cross-origin-expected.txt:
- http/tests/websocket/tests/cross-origin.html:
- http/tests/websocket/tests/error-detect.html:
- http/tests/websocket/tests/frame-length-longer-than-buffer.html:
- http/tests/websocket/tests/frame-length-overflow.html:
- http/tests/websocket/tests/frame-length-skip.html:
- http/tests/websocket/tests/handshake-challenge-randomness.html:
- http/tests/websocket/tests/handshake-error.html:
- http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt:
- http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
- http/tests/websocket/tests/handshake-fail-by-no-cr.html:
- http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
- http/tests/websocket/tests/httponly-cookie.pl:
- http/tests/websocket/tests/long-invalid-header.html:
- http/tests/websocket/tests/null-character.html:
- http/tests/websocket/tests/reload-crash.html:
- http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html:
- http/tests/websocket/tests/resources/close-on-unload-iframe.html:
- http/tests/websocket/tests/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post-function.js.
- http/tests/websocket/tests/resources/js-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
- http/tests/websocket/tests/resources/js-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
- http/tests/websocket/tests/resources/reload-crash-iframe.html:
- http/tests/websocket/tests/script-tests/TEMPLATE.html:
- http/tests/websocket/tests/script-tests/cross-origin.js: (endTest):
- http/tests/websocket/tests/send-after-close-on-unload.html:
- http/tests/websocket/tests/send-throw.html:
- http/tests/websocket/tests/send.html:
- http/tests/websocket/tests/simple.html:
- http/tests/websocket/tests/sub-protocol-with-space.html:
- http/tests/websocket/tests/sub-protocol.html:
- http/tests/websocket/tests/unicode.html:
- http/tests/websocket/tests/url-no-trailing-slash.html:
- http/tests/websocket/tests/url-parsing-expected.txt:
- http/tests/websocket/tests/url-parsing.html:
- http/tests/websocket/tests/url-with-credential.html:
- http/tests/websocket/tests/url-with-empty-query.html:
- http/tests/websocket/tests/url-with-query-for-no-query.html:
- http/tests/websocket/tests/url-with-query.html:
- http/tests/websocket/tests/websocket-event-target.html:
- http/tests/websocket/tests/websocket-protocol-ignored.html:
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/win/Skipped:
- websocket: Removed.
- websocket/resources: Removed.
- websocket/resources/server-failed-to-start.html: Removed.
- websocket/tests: Removed.
- websocket/tests/alert-in-event-handler-expected.txt: Removed.
- websocket/tests/alert-in-event-handler.html: Removed.
- websocket/tests/bad-handshake-crash-expected.txt: Removed.
- websocket/tests/bad-handshake-crash.html: Removed.
- websocket/tests/bad-handshake-crash_wsh.py: Removed.
- websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
- websocket/tests/bad-sub-protocol-control-chars.html: Removed.
- websocket/tests/bad-sub-protocol-empty-expected.txt: Removed.
- websocket/tests/bad-sub-protocol-empty.html: Removed.
- websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Removed.
- websocket/tests/bad-sub-protocol-non-ascii.html: Removed.
- websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
- websocket/tests/bufferedAmount-after-close.html: Removed.
- websocket/tests/close-on-navigate-new-location-expected.txt: Removed.
- websocket/tests/close-on-navigate-new-location.html: Removed.
- websocket/tests/close-on-unload-and-force-gc-expected.txt: Removed.
- websocket/tests/close-on-unload-and-force-gc.html: Removed.
- websocket/tests/close-on-unload-expected.txt: Removed.
- websocket/tests/close-on-unload-reference-in-parent-expected.txt: Removed.
- websocket/tests/close-on-unload-reference-in-parent.html: Removed.
- websocket/tests/close-on-unload.html: Removed.
- websocket/tests/close-on-unload_wsh.py: Removed.
- websocket/tests/cross-origin-expected.txt: Removed.
- websocket/tests/cross-origin.html: Removed.
- websocket/tests/echo-challenge_wsh.py: Removed.
- websocket/tests/echo-cookie_wsh.py: Removed.
- websocket/tests/echo-location_wsh.py: Removed.
- websocket/tests/echo_wsh.py: Removed.
- websocket/tests/error-detect-expected.txt: Removed.
- websocket/tests/error-detect.html: Removed.
- websocket/tests/fixed-origin_wsh.py: Removed.
- websocket/tests/frame-length-longer-than-buffer-expected.txt: Removed.
- websocket/tests/frame-length-longer-than-buffer.html: Removed.
- websocket/tests/frame-length-longer-than-buffer_wsh.py: Removed.
- websocket/tests/frame-length-overflow-expected.txt: Removed.
- websocket/tests/frame-length-overflow.html: Removed.
- websocket/tests/frame-length-overflow_wsh.py: Removed.
- websocket/tests/frame-length-skip-expected.txt: Removed.
- websocket/tests/frame-length-skip.html: Removed.
- websocket/tests/frame-length-skip_wsh.py: Removed.
- websocket/tests/frame-lengths-expected.txt: Removed.
- websocket/tests/frame-lengths.html: Removed.
- websocket/tests/handler_map.txt: Removed.
- websocket/tests/handshake-challenge-randomness-expected.txt: Removed.
- websocket/tests/handshake-challenge-randomness.html: Removed.
- websocket/tests/handshake-error-expected.txt: Removed.
- websocket/tests/handshake-error.html: Removed.
- websocket/tests/handshake-error_wsh.py: Removed.
- websocket/tests/handshake-fail-by-cross-origin-expected.txt: Removed.
- websocket/tests/handshake-fail-by-cross-origin.html: Removed.
- websocket/tests/handshake-fail-by-no-cr-expected.txt: Removed.
- websocket/tests/handshake-fail-by-no-cr.html: Removed.
- websocket/tests/handshake-fail-by-no-cr_wsh.py: Removed.
- websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
- websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Removed.
- websocket/tests/httponly-cookie-expected.txt: Removed.
- websocket/tests/httponly-cookie.pl: Removed.
- websocket/tests/long-invalid-header-expected.txt: Removed.
- websocket/tests/long-invalid-header.html: Removed.
- websocket/tests/long-invalid-header_wsh.py: Removed.
- websocket/tests/multiple-connections-expected.txt: Removed.
- websocket/tests/multiple-connections.html: Removed.
- websocket/tests/no-query_wsh.py: Removed.
- websocket/tests/null-character-expected.txt: Removed.
- websocket/tests/null-character.html: Removed.
- websocket/tests/origin-test_wsh.py: Removed.
- websocket/tests/protocol-test_wsh.py: Removed.
- websocket/tests/reload-crash-expected.txt: Removed.
- websocket/tests/reload-crash.html: Removed.
- websocket/tests/resources: Removed.
- websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Removed.
- websocket/tests/resources/close-on-unload-iframe.html: Removed.
- websocket/tests/resources/reload-crash-iframe.html: Removed.
- websocket/tests/script-tests: Removed.
- websocket/tests/script-tests/TEMPLATE.html: Removed.
- websocket/tests/script-tests/alert-in-event-handler.js: Removed.
- websocket/tests/script-tests/bad-handshake-crash.js: Removed.
- websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
- websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
- websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
- websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
- websocket/tests/script-tests/cross-origin.js: Removed.
- websocket/tests/script-tests/error-detect.js: Removed.
- websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
- websocket/tests/script-tests/frame-length-skip.js: Removed.
- websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
- websocket/tests/script-tests/handshake-error.js: Removed.
- websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
- websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
- websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
- websocket/tests/script-tests/long-invalid-header.js: Removed.
- websocket/tests/script-tests/null-character.js: Removed.
- websocket/tests/script-tests/send-throw.js: Removed.
- websocket/tests/script-tests/send.js: Removed.
- websocket/tests/script-tests/simple.js: Removed.
- websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
- websocket/tests/script-tests/sub-protocol.js: Removed.
- websocket/tests/script-tests/unicode.js: Removed.
- websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
- websocket/tests/script-tests/url-parsing.js: Removed.
- websocket/tests/script-tests/url-with-credential.js: Removed.
- websocket/tests/script-tests/url-with-empty-query.js: Removed.
- websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
- websocket/tests/script-tests/url-with-query.js: Removed.
- websocket/tests/script-tests/websocket-event-target.js: Removed.
- websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
- websocket/tests/send-after-close-on-unload-expected.txt: Removed.
- websocket/tests/send-after-close-on-unload.html: Removed.
- websocket/tests/send-expected.txt: Removed.
- websocket/tests/send-throw-expected.txt: Removed.
- websocket/tests/send-throw.html: Removed.
- websocket/tests/send.html: Removed.
- websocket/tests/send2_wsh.py: Removed.
- websocket/tests/send_wsh.py: Removed.
- websocket/tests/simple-expected.txt: Removed.
- websocket/tests/simple-stress-expected.txt: Removed.
- websocket/tests/simple-stress.html: Removed.
- websocket/tests/simple.html: Removed.
- websocket/tests/simple_wsh.py: Removed.
- websocket/tests/sub-protocol-expected.txt: Removed.
- websocket/tests/sub-protocol-with-space-expected.txt: Removed.
- websocket/tests/sub-protocol-with-space.html: Removed.
- websocket/tests/sub-protocol.html: Removed.
- websocket/tests/unicode-expected.txt: Removed.
- websocket/tests/unicode.html: Removed.
- websocket/tests/unicode_wsh.py: Removed.
- websocket/tests/unknown-frame-type_wsh.py: Removed.
- websocket/tests/url-no-trailing-slash-expected.txt: Removed.
- websocket/tests/url-no-trailing-slash.html: Removed.
- websocket/tests/url-parsing-expected.txt: Removed.
- websocket/tests/url-parsing.html: Removed.
- websocket/tests/url-with-credential-expected.txt: Removed.
- websocket/tests/url-with-credential.html: Removed.
- websocket/tests/url-with-empty-query-expected.txt: Removed.
- websocket/tests/url-with-empty-query.html: Removed.
- websocket/tests/url-with-query-expected.txt: Removed.
- websocket/tests/url-with-query-for-no-query-expected.txt: Removed.
- websocket/tests/url-with-query-for-no-query.html: Removed.
- websocket/tests/url-with-query.html: Removed.
- websocket/tests/websocket-event-target-expected.txt: Removed.
- websocket/tests/websocket-event-target.html: Removed.
- websocket/tests/websocket-pending-activity-expected.txt: Removed.
- websocket/tests/websocket-pending-activity.html: Removed.
- websocket/tests/websocket-protocol-ignored-expected.txt: Removed.
- websocket/tests/websocket-protocol-ignored.html: Removed.
- websocket/tests/workers: Removed.
- websocket/tests/workers/close-in-onmessage-crash-expected.txt: Removed.
- websocket/tests/workers/close-in-onmessage-crash.html: Removed.
- websocket/tests/workers/close-in-shared-worker-expected.txt: Removed.
- websocket/tests/workers/close-in-shared-worker.html: Removed.
- websocket/tests/workers/close-in-worker-expected.txt: Removed.
- websocket/tests/workers/close-in-worker.html: Removed.
- websocket/tests/workers/resources: Removed.
- websocket/tests/workers/resources/close-in-onmessage-crash.js: Removed.
- websocket/tests/workers/resources/close-in-worker.js: Removed.
- websocket/tests/workers/resources/echo-challenge_wsh.py: Removed.
- websocket/tests/workers/resources/echo_wsh.py: Removed.
- websocket/tests/workers/resources/simple_wsh.py: Removed.
- websocket/tests/workers/resources/worker-handshake-challenge-randomness.js: Removed.
- websocket/tests/workers/resources/worker-simple.js: Removed.
- websocket/tests/workers/shared-worker-simple-expected.txt: Removed.
- websocket/tests/workers/shared-worker-simple.html: Removed.
- websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt: Removed.
- websocket/tests/workers/worker-handshake-challenge-randomness.html: Removed.
- websocket/tests/workers/worker-simple-expected.txt: Removed.
- websocket/tests/workers/worker-simple.html: Removed.
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebSocket tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=46956
Update these tools to understand how to run the WebSocket tests off the
Apache server.
- Scripts/old-run-webkit-tests:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 12:38 PM Changeset in webkit [68913] by
-
- 2 edits in trunk/WebKitTools
Encode Executive command arguments using UTF-8 on Cygwin
Cygwin's Python's os.execv doesn't support unicode command arguments.
Cygwin's execv expects arguments to be encoded using the current code
page. But code pages are limited in what characters they can handle,
and our tests include characters that the English code page can't
handle. So for now we'll just encode everything in UTF-8 on Cygwin,
which can handle all characters but might confuse some commands, for
expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
good enough, but we can deal with that when the problem arises.
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
fails on Windows
- Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_command):
On Cygwin, encode arguments using UTF-8.
- 12:25 PM Changeset in webkit [68912] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Build fix.
Adjust test expectations for Chromium.
- platform/chromium/test_expectations.txt:
- 12:16 PM Changeset in webkit [68911] by
-
- 3 edits2 adds in trunk
<rdar://problem/7563219> Null dereference when dragging an element with generated content
https://bugs.webkit.org/show_bug.cgi?id=47005
Reviewed by Adele Peterson.
WebCore:
Test: fast/css-generated-content/drag-state.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::updateDragState): Null-check node().
LayoutTests:
- fast/css-generated-content/drag-state-expected.txt: Added.
- fast/css-generated-content/drag-state.html: Added.
- 12:07 PM Changeset in webkit [68910] by
-
- 1 edit52 adds in trunk/WebKitTools
Add simple API tester for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46953
Reviewed by Adam Roben.
This adds a very simple testing infrastructure for testing APIs exposed
through the WebKit project. It consists of two parts: 1) a project that
builds the all the tests 2) a script that searches the tests directory and
calls the tester once for each test.
This adds the infrastructure and two tests:
- Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
- Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
This currently only works on the mac, but is designed to be easily ported
to any platform.
- Scripts/run-api-tests: Added.
- Scripts/build-api-tests: Added.
Scripts to build/run the tests.
- TestWebKitAPI: Added.
- TestWebKitAPI/Configurations: Added.
- TestWebKitAPI/Configurations/Base.xcconfig: Added.
- TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
- TestWebKitAPI/ForwardingHeaders: Added.
- TestWebKitAPI/ForwardingHeaders/wtf: Added.
- TestWebKitAPI/PlatformUtilities.h: Added.
- TestWebKitAPI/PlatformWebView.h: Added.
(TestWebKitAPI::PlatformWebView::platformView):
- TestWebKitAPI/StringFunctions.h: Added.
- TestWebKitAPI/Test.h: Added.
(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):
- TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
- TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
- TestWebKitAPI/TestsController.cpp: Added.
(TestWebKitAPI::TestsController::shared):
(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):
- TestWebKitAPI/TestsController.h: Added.
- TestWebKitAPI/mac: Added.
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::createURLForResource):
- TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
- TestWebKitAPI/mac/main.mm: Added.
Infrastructure.
- TestWebKitAPI/Tests: Added.
- TestWebKitAPI/Tests/WTF: Added.
- TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
- TestWebKitAPI/Tests/WebKit2: Added.
- TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
(TestWebKitAPI::State::State):
- TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
Proof of concept tests.
- 12:03 PM Changeset in webkit [68909] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Build fix.
Change test expectations for Chromium.
- platform/chromium/test_expectations.txt:
- 11:58 AM Changeset in webkit [68908] by
-
- 2 edits in trunk/LayoutTests
Remove a test I just fixed from the Skipped file
- platform/win/Skipped:
- 11:56 AM Changeset in webkit [68907] by
-
- 2 edits in trunk/WebKitTools
Don't assume AccessibleObjectFromEvent succeeds
Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
DumpRenderTree!notificationListenerProc when running
plugins/access-after-page-destroyed.html
Reviewed by Sam Weinig.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc): Check both the return value of
AccessibleObjectFromEvent and the object it returns, as MSDN
recommends.
- 11:40 AM Changeset in webkit [68906] by
-
- 4 edits in trunk
2010-10-01 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
[Qt] Fix http/tests/loading/redirect-methods.html
Unskip http/tests/loading/redirect-methods.html
- platform/qt/Skipped:
2010-10-01 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
[Qt] Fix http/tests/loading/redirect-methods.html
Document our redirection behaviour too.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 11:31 AM Changeset in webkit [68905] by
-
- 3 edits in trunk/WebCore
Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj
WebCoreGenerated.vcproj runs on every build, while WebCore.vcproj only
runs when a .h or .cpp file changes. By moving the copying to
WebCoreGenerated, it will happen even when someone only changes a JS
file (as happened in r68887).
Fixes <http://webkit.org/b/46988> <rdar://problem/8502489> REGRESSION
(r68887): Web Inspector: inspector/extensions*.html are failing on
Windows
Reviewed by Anders Carlsson.
- WebCore.vcproj/WebCore.vcproj: Moved invocation of
copyForwardingHeaders and copyInspectorFiles from here...
- WebCore.vcproj/WebCoreGenerated.vcproj: ...to here.
- 11:25 AM Changeset in webkit [68904] by
-
- 6 edits in trunk
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Implement queryCommandState('justifyFull')
https://bugs.webkit.org/show_bug.cgi?id=46954
Implemented queryCommandState('justifyFull').
New tests are added to editing/style/inline-style-container.html
- editing/ApplyStyleCommand.cpp: (WebCore::getTextAlignment): Added support for CSSValueJustify.
- editing/EditorCommand.cpp: (WebCore::stateJustifyFull): Added. (WebCore::createCommandMap): Added stateJustifyFull.
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Implement queryCommandState('justifyFull')
https://bugs.webkit.org/show_bug.cgi?id=46954
Added tests for queryCommandState('justifyFull') to editing/execCommand/query-text-alignment.html
- editing/execCommand/query-text-alignment-expected.txt:
- editing/execCommand/script-tests/query-text-alignment.js: (queryTextAlignment): (runRangeTests):
- 11:17 AM Changeset in webkit [68903] by
-
- 3 edits in trunk/WebKitTools
2010-10-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Tony Chang.
[NRWT] Put the http and websocket tests first in the test list.
https://bugs.webkit.org/show_bug.cgi?id=46453
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 11:11 AM Changeset in webkit [68902] by
-
- 2 edits in trunk/WebCore
2010-10-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection shouldn't prompt the same correction after user has edited previous correction.
https://bugs.webkit.org/show_bug.cgi?id=46839
<rdar://problem/8476963>
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of "Replacement" marker. Since the former controls whether we draw autocorrection underline, and the latter is used to prevent autocorrection from being applied again on already auto- corrected word. So the "Replacement" shouldn't be removed.
- 11:05 AM Changeset in webkit [68901] by
-
- 3 edits in trunk/WebCore
2010-10-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Anders Carlsson.
[CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
https://bugs.webkit.org/show_bug.cgi?id=46309
- CMakeLists.txt:
- CMakeListsEfl.txt:
- 10:55 AM Changeset in webkit [68900] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the bottom of the block to
be block-flow-aware.
Reviewed by Darin Adler.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
- 10:50 AM Changeset in webkit [68899] by
-
- 7 edits in trunk
2010-10-01 Pratik Solanki <psolanki@apple.com>
Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
https://bugs.webkit.org/show_bug.cgi?id=46960
For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
- bytecompiler/BytecodeGenerator.h:
- wtf/FastMalloc.cpp:
2010-10-01 Pratik Solanki <psolanki@apple.com>
Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
https://bugs.webkit.org/show_bug.cgi?id=46960
For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
- css/CSSStyleSelector.h:
- rendering/InlineIterator.h:
- rendering/style/RenderStyle.h:
- 10:46 AM Changeset in webkit [68898] by
-
- 7 edits in trunk/WebKit2
Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
https://bugs.webkit.org/show_bug.cgi?id=46992
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::copyCString):
Helper function for allocating a string using NPN_MemAlloc.
(WebKit::NPN_GetValueForURL):
Ask the plug-in for either the proxy or the cookies given an URL.
(WebKit::NPN_SetValueForURL):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
Tell the plug-in to set the cookies for the given URL.
(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
Call the corresponding PluginController functions.
- WebProcess/Plugins/PluginController.h:
Add new pure virtual member functions.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
Add stubbed out implementations of the new PluginController functions.
- WebProcess/Plugins/PluginView.h:
- 10:43 AM Changeset in webkit [68897] by
-
- 4 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the viewport from the root element.
Reviewed by Dan Bernstein.
WebCore:
Added fast/css/rtl-to-viewport.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/css/rtl-to-viewport.html: Added.
- platform/mac/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/mac/fast/css/rtl-to-viewport-expected.png: Added.
- platform/mac/fast/css/rtl-to-viewport-expected.txt: Added.
- 10:29 AM Changeset in webkit [68896] by
-
- 3 edits4 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=44406
<rdar://problem/8310921> Application Cache crash when a fallback document has a manifest URL
Test: http/tests/appcache/foreign-fallback.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Changed ApplicationCacheResource lookup to find fallback resources correctly.
- 10:20 AM Changeset in webkit [68895] by
-
- 2 edits in trunk/WebCore
Unreviewed, Brew MP build fix.
- platform/brew/ClipboardBrew.cpp:
(WebCore::ClipboardBrew::ClipboardBrew):
- 10:01 AM Changeset in webkit [68894] by
-
- 2 edits in trunk/WebKitTools
Updated stuff.
- 9:54 AM Changeset in webkit [68893] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed.
[BREWMP] Change Collector BLOCK_SIZE to 64KB
https://bugs.webkit.org/show_bug.cgi?id=46436
Lower BLOCK_SIZE to 64KB because Brew MP runs on low end devices.
- runtime/Collector.h:
- 9:32 AM Changeset in webkit [68892] by
-
- 2 edits in trunk/WebCore
2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[CMAKE] Build fix for r68878
https://bugs.webkit.org/show_bug.cgi?id=46985
Fix name of files added to CMakeLists.txt:
SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp
No features added, so no new tests.
- CMakeLists.txt:
- 9:16 AM Changeset in webkit [68891] by
-
- 9 edits3 adds in trunk
Implement NPN_GetValue(NPNVnetscapeWindow)
Fixes <http://webkit.org/b/46726> <rdar://problem/8486319>
Right-clicking on windowless Flash plugin in WebKit2 makes a context
menu appear in the bottom-right corner of the screen
Test: platform/win/plugins/get-value-netscape-window.html
Reviewed by Anders Carlsson.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Added case for NPNVnetscapeWindow that calls
through to NetscapePlugin::containingWindow.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added containingWindow
on Windows.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow): Added. Calls through to
the PluginController.
(WebKit::NetscapePlugin::platformPostInitialize): Changed to use
containingWindow.
WebKitTools:
Test NPN_GetValue(NPNVnetscapeWindow)
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetValue): Added. Calls through to the browser.
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
(GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
(GetValueNetscapeWindow::NPP_SetWindow): Test that
NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
isn't our HWND.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added GetValueNetscapeWindow.
LayoutTests:
Support for testing NPN_GetValue(NPNVnetscapeWindow)
- platform/win/plugins/get-value-netscape-window-expected.txt: Added.
- platform/win/plugins/get-value-netscape-window.html: Added.
- 7:56 AM Changeset in webkit [68890] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt] Stack overflow on symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=40598
Move big allocation in arrayProtoFuncToString from stack to heap.
JSC::arrayProtoFuncToString function can be called recursivly and
1K allocation on stack cahse stack overflow.
Can be useful for other platforms with limited stack size.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
- 6:52 AM Changeset in webkit [68889] by
-
- 4 edits2 moves in trunk/WebCore
2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] New buttons style for Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=46920
Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
Adjust new Qt mobile style for buttons, radios, checks and combos.
- WebCore.pro:
- css/themeQtMobile.css: Adjust gradient color for buttons and combos. (select): (select:active):
- platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme. (QtMobileWebStyle::QtMobileWebStyle): (drawRectangularControlBackground): (QtMobileWebStyle::drawChecker): (QtMobileWebStyle::findChecker): (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton. (QtMobileWebStyle::findRadio): (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox. (QtMobileWebStyle::drawMultipleComboButton): (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow. (QtMobileWebStyle::getButtonImageSize): (QtMobileWebStyle::findComboButton): (QtMobileWebStyle::drawComplexControl):
- platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt):
- 6:49 AM Changeset in webkit [68888] by
-
- 1 edit4 adds in trunk/LayoutTests
Add expected Windows results for scrollbars/custom-scrollbar-with-incomplete-style.html
This test was added in r66372 without any expected results.
- platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- 6:43 AM Changeset in webkit [68887] by
-
- 8 edits in trunk
2010-10-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
https://bugs.webkit.org/show_bug.cgi?id=45954
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype): (WebInspector.injectedExtensionAPI.Resources.prototype.getPageTimings):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onGetPageTimings):
- inspector/front-end/HAREntry.js: Return page event timings as -1 if start or event time unknown. (WebInspector.HARLog.prototype._buildPages): (WebInspector.HARLog.prototype.buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource): (WebInspector.HARLog.prototype._pageEventTime):
2010-10-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
https://bugs.webkit.org/show_bug.cgi?id=45954
- inspector/extensions-api-expected.txt:
- inspector/extensions-resources-expected.txt:
- inspector/extensions-resources.html:
- 6:37 AM Changeset in webkit [68886] by
-
- 2 edits in trunk/LayoutTests
Remove the fixed test from the Skipped file, too
- platform/win/Skipped:
- 6:35 AM Changeset in webkit [68885] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove bogus Windows results for clip-path-referencing-use2.svg
Fixes <http://webkit.org/b/46919> <rdar://problem/8497626> REGRESSION?
(r65617?): svg/custom/clip-path-referencing-use2.svg fails on Windows
Rubber-stamped by Nikolas Zimmermann.
- platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
- 6:30 AM Changeset in webkit [68884] by
-
- 4 edits in trunk/LayoutTests
Make regression tests pass on machines with 16-bit displays
I made these tests require 24-bit displays in r68808 and r68809,
thinking that we didn't have any testers that had 16-bit displays. But
apparently I was wrong; at least one Windows tester has a 16-bit
display.
Fixes <http://webkit.org/b/46980>
fast/media/color-does-not-include-alpha.html failing on Windows
Reviewed by Nikolas Zimmermann.
- fast/dom/Window/window-screen-properties-expected.txt: Updated
results.
- fast/dom/Window/window-screen-properties.html: Changed to allow
either 16 or 24 bits.
- fast/media/color-does-not-include-alpha.html: Changed to allow
either 5 or 8 bits per channel.
- 6:09 AM Changeset in webkit [68883] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add GDIExtras
https://bugs.webkit.org/show_bug.cgi?id=46974
Some, but not all WinCE environments have support for AlphaBlend().
Add this files to check for AlphaBlend (and SoftLink) on WinCE.
On WinNT alphaBlendIfSupported() inlines AlphaBlend and returns true.
- platform/graphics/win/GDIExtras.cpp: Added. (WebCore::AlphaBlendPointer):
- platform/graphics/win/GDIExtras.h: Added. (WebCore::hasAlphaBlendSupport): (WebCore::alphaBlendIfSupported):
- 6:04 AM Changeset in webkit [68882] by
-
- 2 edits in trunk/WebCore
2010-10-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Use alphaBlendIfSupported in GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=46979
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):
- 5:58 AM Changeset in webkit [68881] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed rolling out r68633, because we don't need Qt specific expected results any more.
- platform/qt/canvas: Removed.
- platform/qt/canvas/philip: Removed.
- platform/qt/canvas/philip/tests: Removed.
- platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Removed.
- platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
- platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
- 5:24 AM Changeset in webkit [68880] by
-
- 2 edits in trunk/WebKitTools
2010-10-01 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, adding my webkit.org identity to reviewer list.
- Scripts/webkitpy/common/config/committers.py:
- 5:03 AM Changeset in webkit [68879] by
-
- 2 edits in trunk/LayoutTests
Add some more failing tests to the Windows Skipped file
- platform/win/Skipped:
- 4:38 AM Changeset in webkit [68878] by
-
- 8 edits4 adds in trunk/WebCore
2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add two new helper files for the new SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=46972
Refactor code from SVGTextLayoutUtilities into two seperated classes.
SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.
Doesn't affect any functionality yet, as the new classes are not used so far.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/svg/SVGTextFragment.h:
- rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added. (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
- rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
- rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added. (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing): (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning): (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
- rendering/svg/SVGTextLayoutEngineSpacing.h: Added.
- 3:50 AM Changeset in webkit [68877] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-10-01 MORITA Hajime <morrita@google.com>
Unreviewed, added a expectation.
- platform/chromium-mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:45 AM Changeset in webkit [68876] by
-
- 9 edits2 moves in trunk/WebCore
2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
https://bugs.webkit.org/show_bug.cgi?id=46971
Doesn't affect any functionality, just moves files around.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Adopt to renaming.
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
- rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
- rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
- rendering/svg/SVGTextLayoutBuilder.h: Removed.
- 3:41 AM Changeset in webkit [68875] by
-
- 2 edits in trunk/WebCore
2010-10-01 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia):
- 3:19 AM Changeset in webkit [68874] by
-
- 9 edits18 moves in trunk/WebCore
2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Move SVG text related renderers into rendering/svg/
https://bugs.webkit.org/show_bug.cgi?id=46969
Doesn't affect any functionality, just moves files around.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderSVGAllInOne.cpp:
- rendering/RenderSVGInline.cpp: Removed.
- rendering/RenderSVGInline.h: Removed.
- rendering/RenderSVGInlineText.cpp: Removed.
- rendering/RenderSVGInlineText.h: Removed.
- rendering/RenderSVGTSpan.cpp: Removed.
- rendering/RenderSVGTSpan.h: Removed.
- rendering/RenderSVGText.cpp: Removed.
- rendering/RenderSVGText.h: Removed.
- rendering/RenderSVGTextPath.cpp: Removed.
- rendering/RenderSVGTextPath.h: Removed.
- rendering/SVGInlineFlowBox.cpp: Removed.
- rendering/SVGInlineFlowBox.h: Removed.
- rendering/SVGInlineTextBox.cpp: Removed.
- rendering/SVGInlineTextBox.h: Removed.
- rendering/SVGRootInlineBox.cpp: Removed.
- rendering/SVGRootInlineBox.h: Removed.
- rendering/SVGTextQuery.cpp: Removed.
- rendering/SVGTextQuery.h: Removed.
- rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
- rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
- rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
- rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
- rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
- rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
- rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
- rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
- rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
- rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
- rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
- rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
- rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
- rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
- rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
- rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
- rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
- rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.
- 2:11 AM Changeset in webkit [68873] by
-
- 8 edits5 adds in trunk/WebCore
2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
https://bugs.webkit.org/show_bug.cgi?id=46964
The new SVG text layout engine will use these new classes.
1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.
-> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object
describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).
-> In "range of characters" mode, it returns the width/height of the range, and its length.
All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.
2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.
It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)
In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
be performed as SVGTextFragment contains all necessary information to render text / select text etc.
3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).
Quotes from SVG spec:
Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:
- Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
- Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
- Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.
An absolute position adjustment occurs in the following circumstances:
- At the start of a <text> element
- At the start of each <textPath> element
- For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly
After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
(eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).
SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.
Doesn't affect any tests, as these classes aren't used so far.
- Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/svg/SVGTextChunk.cpp: Added.
- rendering/svg/SVGTextChunk.h: Added.
- rendering/svg/SVGTextFragment.h: Added.
- rendering/svg/SVGTextMetrics.cpp: Added.
- rendering/svg/SVGTextMetrics.h: Added.
- 1:21 AM Changeset in webkit [68872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] fast/media/color-does-not-include-alpha.html fails
https://bugs.webkit.org/show_bug.cgi?id=46966
- platform/qt/Skipped: fast/media/color-does-not-include-alpha.html added until fix.
- 1:06 AM Changeset in webkit [68871] by
-
- 4 edits in trunk/WebKit/chromium
2010-10-01 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
[chromium] add an identifier method to WebFrame. The identifier can be used to identify
a given frame of a view over time. Using a pointer to the WebFrame object is fragile,
since a new frame might have been allocated at the same address as an old, deleted frame.
https://bugs.webkit.org/show_bug.cgi?id=46884
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::generateFrameIdentifier): (WebKit::WebFrameImpl::identifier): (WebKit::WebFrameImpl::WebFrameImpl):
- src/WebFrameImpl.h:
- 12:52 AM Changeset in webkit [68870] by
-
- 2 edits in trunk/LayoutTests
2010-10-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
http/tests/navigation/ping-same-origin.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=46961
This test fails by forgetting to print out the REQUEST_METHOD:
The only way this makes sense is if the file isn't finished writing by
the time it gets read. This can happen because the reader is polling
the file for existence (!) to decide whether to read it.
This patch writes to a temporary location and then moves the finished
bytes into the well-known location atomically. I haven't verified that
it fixes the flakiness, but it seems like a good bet.
- http/tests/navigation/resources/save-ping.php:
- 12:32 AM Changeset in webkit [68869] by
-
- 10 edits in trunk/WebKit/chromium
2010-09-29 John Abd-El-Malek <jam@chromium.org>
Reviewed by NOBODY (OOPS!).
[chromium] Changes to consolidate plugin zoom
https://bugs.webkit.org/show_bug.cgi?id=46550
- public/WebPlugin.h: (WebKit::WebPlugin::setZoomLevel):
- public/WebPluginContainer.h:
- public/WebView.h:
- public/WebViewClient.h: (WebKit::WebViewClient::zoomLimitsChanged): (WebKit::WebViewClient::zoomLevelChanged):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): (WebKit::WebPluginContainerImpl::zoomChanged): (WebKit::WebPluginContainerImpl::zoomLimitsChanged):
- src/WebPluginContainerImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::zoomLevel): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImpl::zoomLimitsChanged): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebView::zoomFactorToZoomLevel):
- src/WebViewImpl.h:
- 12:28 AM Changeset in webkit [68868] by
-
- 4 edits4 adds in trunk
2010-10-01 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
REGRESSION: Lots of fast canvas updates fail to completely render
https://bugs.webkit.org/show_bug.cgi?id=46319
- fast/repaint/canvas-putImageData-expected.txt: Added.
- fast/repaint/canvas-putImageData.html: Added.
- platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Added.
- platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/chromium/test_expectations.txt:
2010-10-01 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
REGRESSION: Lots of fast canvas updates fail to completely render
https://bugs.webkit.org/show_bug.cgi?id=46319
Test: fast/repaint/canvas-putImageData.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::putImageData):
- 12:16 AM Changeset in webkit [68867] by
-
- 5 edits in trunk/WebCore
2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add helper methods to cast between renderers & SVGTextContent/PositioningElement
https://bugs.webkit.org/show_bug.cgi?id=46963
Doesn't affect any tests.
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::elementFromRenderer):
- svg/SVGTextContentElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::elementFromRenderer):
- svg/SVGTextPositioningElement.h:
Sep 30, 2010:
- 11:41 PM Changeset in webkit [68866] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The WebSocket server should flush its logs
https://bugs.webkit.org/show_bug.cgi?id=46946
The WebSocket server logs are truncated because the driver just
terminates the child. It should run Python without buffering so we can
see the end of the log.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 10:58 PM Changeset in webkit [68865] by
-
- 6 edits in trunk
2010-09-30 MORITA Hajime <morrita@google.com>
Reviewed by James Robinson.
[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955
Added ifdef guard around SharedGraphicsContext3D.
No new tests. just a build fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):
2010-09-30 MORITA Hajime <morrita@google.com>
Reviewed by James Robinson.
[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955
Added ifdef guard around SharedGraphicsContext3D.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
- src/WebViewImpl.h:
- 10:33 PM WebCoreRendering edited by
- (diff)
- 10:09 PM Changeset in webkit [68864] by
-
- 3 edits in trunk/WebCore
2010-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Chris Fleizach.
[Windows] Implement <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=38381
Implement theme drawing for inner-spin-button.
No new tests. Existing tests for type=number will cover this change.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): Handle m_spinButtonTheme. (WebCore::RenderThemeWin::spinButtonTheme): ditto. (WebCore::RenderThemeWin::close): ditto. (WebCore::RenderThemeWin::determineClassicState): Add ControlSubPart parameter, and add support for InnerSpinButtonPart. (WebCore::RenderThemeWin::determineSpinButtonState): Added. (WebCore::RenderThemeWin::getClassicThemeData): Add ControlSubPart parameter, and handle InnerSpinButtonPart. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle): Set SM_CXVSCROLL value to the width. (WebCore::RenderThemeWin::paintInnerSpinButton): Call drawControl() for the upper part and the lower part.
- rendering/RenderThemeWin.h:
- 10:05 PM Changeset in webkit [68863] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Add recent failures.
- 9:51 PM Changeset in webkit [68862] by
-
- 2 edits in trunk/WebCore
Unreviewed, Windows build fix for r68854
- WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCore/html/parser/*.h.
- 8:55 PM Changeset in webkit [68861] by
-
- 4 edits in trunk/WebKitTools
2010-09-30 Simon Fraser <Simon Fraser>
Add a button to jump to the next untested test.
- CSSTestSuiteHarness/harness/harness.css: (.test-type): (.name > button):
- CSSTestSuiteHarness/harness/harness.html:
- CSSTestSuiteHarness/harness/harness.js: (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.testInfoDataLoaded): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.buildTestListForChapter): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.testCompletionStateChanged):
- 8:25 PM Changeset in webkit [68860] by
-
- 3 edits2 adds in trunk
2010-09-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
While updating :before and :after content, make sure that the generated
container is allowed to add the child type.
https://bugs.webkit.org/show_bug.cgi?id=46106
Test: fast/css-generated-content/text-before-table-col-crash.html
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
2010-09-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Tests that adding text to a :before container that is styled as a
table column group does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46106
- fast/css-generated-content/text-before-table-col-crash-expected.txt: Added.
- fast/css-generated-content/text-before-table-col-crash.html: Added.
- 6:35 PM Changeset in webkit [68859] by
-
- 2 edits41 adds in trunk/LayoutTests
Not reviewed. Build fix.
Adjust test expectations for Chromium.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
- platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:24 PM Changeset in webkit [68858] by
-
- 2 edits in trunk/WebCore
2010-09-30 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Daniel Bates.
[GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=46886
Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().
So far, this assertion made sense because it was not possible that
a call to listMarkerSuffix() happened when the style of the list
item was one of the following: Asterisks, Circle, Discm Footnotes,
NoneListStyle or Square (it's easy to figure this out by checking
the functions where listMarkerSuffix() was called).
However, since revision 68415 (about bug 45381), there's a new
place where listMarkerSuffix() is being called (the suffix()
public method), regardless of the style of the item being or not
one of those pointed out, so the aforementioned assertion in
listMarkerSuffix() would no longer be correct, as now it's ok to
reach those cases in the switch statement.
- rendering/RenderListMarker.cpp: (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().
- 6:22 PM Changeset in webkit [68857] by
-
- 5 edits in branches/safari-533.19-branch
Build fixes.
- 6:13 PM Changeset in webkit [68856] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
whitespace separators for mfenced
Reviewed by Adele Peterson.
WebCore:
Check the size of characters instead of separators in case all the
separators were whitespace.
- mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
LayoutTests:
- mathml/fenced-whitespace-separators-crash-expected.txt: Added.
- mathml/fenced-whitespace-separators-crash.html: Added.
- 5:39 PM Changeset in webkit [68855] by
-
- 4 edits in trunk/LayoutTests
2010-09-30 Simon Fraser <Simon Fraser>
Reviewed by Jon Honeycutt.
REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
https://bugs.webkit.org/show_bug.cgi?id=46913
REGRESSION (r65681): platform/win/accessibility/img-alt-attribute.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46914
<rdar://problem/8497332&8497393>
Fix two layout tests that made incorrect assumptions about the structure of the
accessibility tree.
- platform/win/Skipped:
- platform/win/accessibility/img-alt-attribute.html:
- platform/win/accessibility/selection-and-focus.html:
- 5:04 PM Changeset in webkit [68854] by
-
- 75 edits2 moves1 delete in trunk
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
Test: fast/replaced/object-param-spaces.html
- css/CSSHelper.cpp: Removed.
- css/CSSHelper.h: Removed deprecatedParseURL.
- html/parser/HTMLParserIdioms.cpp: (WebCore::stripLeadingAndTrailingHTMLSpaces): Fixed bug where the function would turn the null string into the empty string. Fixed bug where the function would not strip all trailing spaces.
- html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state instead of calling the reset function. (WebCore::CSSPreloadScanner::scan): Tweaked coding style. (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of an identical local function named isWhitespace. (WebCore::parseCSSStringOrURL): Added. This function does what deprecatedParseURL did before, and this is the only place in WebKit that needs it. The code implements the rules for a string or URL token. The real CSS parser does this with flex and the code to hook flex up to yacc, so the function is not needed there. (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit and mae it call parseCSSStringOrURL.
- bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl):
- bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
- bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]):
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
- dom/Document.cpp: (WebCore::Document::processBaseElement):
- dom/Element.cpp: (WebCore::isAttributeToRemove): (WebCore::Element::getURLAttribute): (WebCore::Element::getNonEmptyURLAttribute):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::parseMappedAttribute): (WebCore::HTMLAnchorElement::href):
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
- html/HTMLMediaElement.cpp:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::parametersForPlugin):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
- html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute):
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
- loader/FormSubmission.cpp: (WebCore::FormSubmission::Attributes::parseAction):
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::absoluteLinkURL):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
- wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
- WebCore.exp.in: Updated.
- Android.mk: Removed CSSHelper.cpp.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSElementCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- css/CSSParser.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLVideoElement.cpp:
- loader/ImageLoader.cpp:
- rendering/style/RenderStyle.h: Removed unneeded include of CSSHelper.h.
2010-09-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
- fast/replaced/object-param-spaces-expected.txt: Copied from LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
- fast/replaced/object-param-spaces.html: Copied from LayoutTests/fast/replaced/object-param-url-control-char.html.
- fast/replaced/object-param-url-control-char-expected.txt: Removed.
- fast/replaced/object-param-url-control-char.html: Removed. Changed this test to expect HTML standard space trimming, but not the WebKit-only control character stripping we had historically.
- fast/url/query-expected.txt: Updated to expect the test to pass.
- fast/url/script-tests/segments-from-data-url.js: Changed expected result to not expect stripping of newline characters.
- fast/url/script-tests/segments.js: Ditto.
- fast/url/segments-expected.txt: Updated results.
- fast/url/segments-from-data-url-expected.txt: Ditto.
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: These tests had multiple test cases with embedded control characters. These URLs no longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log messages for them. The test cases themselves need not be changed at this time.
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Updated expected results to reflect the fact that the control character is no longer stripped from the URL in these cases. The test is still valid, but these are not as interesting test cases any more since control characters do not have special handling.
- 4:41 PM Changeset in webkit [68853] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-09-30 Martin Robinson <mrobinson@igalia.com>
Unskip some tests that are passing and rebaseline a couple others.
- platform/gtk/Skipped: Unskip tests and do a little reorganization.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaselined.
- platform/gtk/fast/overflow/line-clamp-expected.txt: Added.
- 4:25 PM Changeset in webkit [68852] by
-
- 1 edit1 delete in trunk/LayoutTests
Build fix. Not reviewed.
Remove a test expectation since the problem was fixed.
- platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
- 4:18 PM Changeset in webkit [68851] by
-
- 3 edits in trunk/WebKit2
2010-09-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Background doesn't draw when entering accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=45848
LayerBackedDrawingArea::setSize() is normally called in response
to a message from the UI process, so this can come some time after
LayerBackedDrawingArea creation. Depending on the timing, we could
end up being at size 0x0 for the first invalidate and paint, resulting
in missing content.
The fix is to size the backing layer on creation, using the WebView's size.
Also changed various calls to syncCompositingStateForThisLayerOnly()
to do lazy updates via scheduleCompositingLayerSync().
Also add the fix for https://bugs.webkit.org/show_bug.cgi?id=46226 (r68028)
to the WebKit2 code, in scheduleUpdateLayoutRunLoopObserver().
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer): (WebKit::LayerBackedDrawingArea::syncCompositingLayers): (WebKit::LayerBackedDrawingArea::scheduleUpdateLayoutRunLoopObserver):
- 4:17 PM Changeset in webkit [68850] by
-
- 6 edits in trunk
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Chris Marrin.
Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850
Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
Mac and QT.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Chris Marrin.
Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850
Added a stub for GraphicsContext3D::getGraphicsResetStatusARB.
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
- 4:17 PM Changeset in webkit [68849] by
-
- 4 edits in trunk
WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>
Reviewed by Adam Roben.
WebKit2:
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Use Windows fonts on Windows.
WebKitTools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.
- 4:08 PM Changeset in webkit [68848] by
-
- 1 edit1 add in trunk/LayoutTests
Build fix. Not reviewed.
Add test expectations for Chromium.
- platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- 4:04 PM Changeset in webkit [68847] by
-
- 3 edits in trunk/LayoutTests
Build fix. Not reviewed.
Update test expectations for Chromium.
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
- 3:57 PM Changeset in webkit [68846] by
-
- 2 edits in tags/Safari-534.9.1/WebKit/mac
Merge r68266.
- 3:57 PM Changeset in webkit [68845] by
-
- 5 edits in tags/Safari-534.9.1
Versioning.
- 3:41 PM Changeset in webkit [68844] by
-
- 3 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API
Reviewed by Sam Weinig.
- Shared/API/c/WKString.cpp:
(WKStringIsEqual):
- Shared/API/c/WKString.h:
- 3:35 PM Changeset in webkit [68843] by
-
- 1 copy in tags/Safari-534.9.1
New tag.
- 3:24 PM Changeset in webkit [68842] by
-
- 10 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46938
Reviewed by Sam Weinig.
Rewrite margin collapsing to be block-flow-aware. Eliminate a bunch of the margin functions on RenderBox in favor of a single
master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock. Introduce a new
MarginValues struct to make returning the collection of 4 margin values easy.
fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
Added fast/blockflow/margin-collapse.html
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::marginValuesForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginValues::MarginValues):
(WebCore::RenderBlock::MarginValues::positiveMarginBefore):
(WebCore::RenderBlock::MarginValues::negativeMarginBefore):
(WebCore::RenderBlock::MarginValues::positiveMarginAfter):
(WebCore::RenderBlock::MarginValues::negativeMarginAfter):
(WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlock::maxPositiveMarginBefore):
(WebCore::RenderBlock::maxNegativeMarginBefore):
(WebCore::RenderBlock::maxPositiveMarginAfter):
(WebCore::RenderBlock::maxNegativeMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::positiveMargin):
(WebCore::RenderBlock::MarginInfo::negativeMargin):
(WebCore::RenderBlock::MarginInfo::margin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
- rendering/RenderBox.h:
(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
LayoutTests:
- fast/blockflow/margin-collapse.html: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum:
- platform/mac/fast/blockflow/inline-direction-positioning-expected.png:
- platform/mac/fast/blockflow/inline-direction-positioning-expected.txt:
- platform/mac/fast/blockflow/margin-collapse-expected.checksum: Added.
- platform/mac/fast/blockflow/margin-collapse-expected.png: Added.
- platform/mac/fast/blockflow/margin-collapse-expected.txt: Added.
- 3:19 PM Changeset in webkit [68841] by
-
- 2 edits in trunk/WebCore
2010-09-30 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Fix InternetGetCookie in CookieJarWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46929
If the InternetGetCookie fails the output size won't be set.
Set the default size to 0, so we always get the correct size
and check the return value of InternetGetCookie.
- platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
- 3:11 PM Changeset in webkit [68840] by
-
- 3 edits in trunk/LayoutTests
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed rebaseline for Qt and Windows platforms required by r68830.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Merged b elements.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Ditto.
- 3:08 PM Changeset in webkit [68839] by
-
- 2 edits in trunk/WebCore
2010-09-30 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=46881
Also add some missing SelectObject calls.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::createPen): (WebCore::createBrush): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- 3:06 PM Changeset in webkit [68838] by
-
- 2 edits in trunk/LayoutTests
Build fix. Not reviewed.
Update test expectations for chromium.
- platform/chromium/test_expectations.txt:
- 3:03 PM Changeset in webkit [68837] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add radar number to ChangeLog.
- 3:00 PM Changeset in webkit [68836] by
-
- 3 edits in trunk/WebCore
WebCore uses the main thread to process sleep notifications
https://bugs.webkit.org/show_bug.cgi?id=46935
Reviewed by Dan Bernstein and Darin Adler.
Rewrite the old WebCorePowerNotifier to use IOKit directly.
On Snow Leopard, set up power notifications to arrive on a dispatch queue,
so that we can handle them quickly even if the main thread is hung.
(Tiger and Leopard will still get the old behavior).
- WebCore.xcodeproj/project.pbxproj:
Link with IOKit.
- platform/mac/SharedTimerMac.mm:
(WebCore::PowerObserver::PowerObserver):
Initialize the IOKit machinery.
(WebCore::PowerObserver::~PowerObserver):
Tear down the IOKit notifications.
(WebCore::PowerObserver::didReceiveSystemPowerNotification):
Acknowledge the event immediately and then call the shared timer functions. On Snow Leopard, we
make sure to call the shared timer functions on the main thread.
- 2:55 PM Changeset in webkit [68835] by
-
- 5 edits in trunk
2010-09-30 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-expected.txt:
2010-09-30 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302
- page/Timing.cpp: (WebCore::Timing::requestEnd):
- 2:54 PM Changeset in webkit [68834] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Xiaomei Ji <xji@chromium.org>
Unreviewed, updated test_expectations.txt
- platform/chromium/test_expectations.txt:
- 2:48 PM Changeset in webkit [68833] by
-
- 4 edits in trunk
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
- platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Remove ShFinalize().
2010-09-30 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
- platform/mac-snowleopard/Skipped: Re-enable the test.
- 2:47 PM Changeset in webkit [68832] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add a factory function which returns an instance wrapped in PlatformRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=46373
A Brew MP instance has reference count 1 when it is created, so call adoptPlatformRef
to wrap the instance in PlatformRefPtr.
- wtf/brew/ShellBrew.h: (WTF::createRefPtrInstance):
- 2:43 PM Changeset in webkit [68831] by
-
- 2 edits in trunk/WebKit/mac
-[DOMDocument _documentRange] throws an exception if there is no document element
https://bugs.webkit.org/show_bug.cgi?id=46934
<rdar://problem/8169260>
Reviewed by Darin Adler.
If there is no document element, just return an empty range. Otherwise we'll try to call
Range::selectNode with a null Node which will throw a NOT_FOUND exception.
- DOM/WebDOMOperations.mm:
(-[DOMDocument _documentRange]):
- 2:37 PM Changeset in webkit [68830] by
-
- 12 edits3 adds in trunk
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568
The bug was caused by fixRangeAndApplyInlineStyle's not including fully selected ancestors,
and addInlineStyleIfNeeded's always surrounding the contents by new elements as supposed to
adding font attributes or style attribute.
Fixed the bug by extending the node range in fixRangeAndApplyInlineStyle and finding
the appropriate container node to add attributes in addInlineStyleIfNeeded.
addInlineStyleIfNeeded now tires to add font and style attributes to the inner most font and
span elements respectively.
Also added an early exit check to removeStyleFromRunBeforeApplyingStyle so that WebKit does not
modify the contents when the entire contents already have the desired style.
Test: editing/style/inline-style-container.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568
Added a test to ensure WebKit does not add extra font elements when the content already has an enclosing font element.
The test also ensures WebKit tries to add style attribute to the inner most span.
- editing/execCommand/createLink-expected.txt: The ordering of anchor and span changed.
- editing/execCommand/unlink-expected.txt: Ditto.
- editing/execCommand/query-font-size-expected.txt: Merged font elements.
- editing/execCommand/script-tests/toggle-style-2.js: The ordering of s and u elements changed.
- editing/execCommand/toggle-style-2-expected.txt: Ditto.
- editing/style/inline-style-container-expected.txt: Added.
- editing/style/inline-style-container.html: Added.
- editing/style/make-text-writing-direction-inline-expected.txt: Removed some extraneous spans added by the bug 44359.
- editing/style/script-tests/inline-style-container.js: Added. (testSingleToggle):
- editing/style/style-3690704-fix-expected.txt: Merged two b elements.
- fast/events/event-input-contentEditable-expected.txt: Merged anchor elements.
- fast/events/script-tests/event-input-contentEditable-expected.txt: Ditto.
- 2:34 PM Changeset in webkit [68829] by
-
- 1 edit14 deletes in trunk/LayoutTests
Build fix. Not reviewed.
Remove expectation files in wrong place.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png: Removed.
- 2:33 PM Changeset in webkit [68828] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Port PlatformRefPtr
https://bugs.webkit.org/show_bug.cgi?id=46370
Implement refPlatformPtr and derefPlatformPtr to use PlatformRefPtr in Brew MP.
- wtf/brew/RefPtrBrew.h: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
- 2:29 PM Changeset in webkit [68827] by
-
- 3 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Third attempt. We need a better integration test environment.
- Scripts/webkitpy/common/net/failuremap.py:
- Scripts/webkitpy/common/net/failuremap_unittest.py:
- 2:25 PM Changeset in webkit [68826] by
-
- 1 edit42 moves14 adds in trunk/LayoutTests
Build fix. Not reviewed.
Rename test expectations last submitted.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
- platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
- 2:22 PM Changeset in webkit [68825] by
-
- 9 edits2 adds in trunk
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- platform/qt/Skipped:
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. (PlainTextController::PlainTextController): (PlainTextController::plainText):
- DumpRenderTree/qt/PlainTextControllerQt.h: Added.
- 2:20 PM Changeset in webkit [68824] by
-
- 2 edits in trunk/WebCore
2010-09-30 Jarred Nicholls <jarred@sencha.com>
Reviewed by Darin Adler.
Removed unnecessary calls to ceil() on an int
Removing the call fixes MSVC build errors
https://bugs.webkit.org/show_bug.cgi?id=46931
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::calculateLayerBoundingRect):
- 2:17 PM Changeset in webkit [68823] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed. Second attempt to fix sheriffbot.
- Scripts/webkitpy/common/net/buildbot.py:
- 2:12 PM Changeset in webkit [68822] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed.
This patch should stop the sheriffbot from throwing an exception.
- Scripts/webkitpy/common/net/buildbot.py:
- 1:48 PM Changeset in webkit [68821] by
-
- 2 edits in trunk/LayoutTests
2010-09-30 Martin Robinson <mrobinson@igalia.com>
Unskip websocket tests for GTK+, as the bots should be running
a version of the Linux kernel which has support for SOCK_CLOEXEC.
- platform/gtk/Skipped: Unskip websocket tests.
- 1:37 PM Changeset in webkit [68820] by
-
- 3 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46932
Reviewed by Beth Dakin.
Get fast/blockflow/root-lr-basic.html results to be correct by patching a few more
height() calls to be logicalHeight().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleAfterSideOfBlock):
- 1:31 PM Changeset in webkit [68819] by
-
- 5 edits2 adds in trunk
2010-09-30 Cris Neckar <cdn@chromium.org>
Reviewed by Darin Adler.
Added check to test for removed counter node when calling findPlaceForCounter() in updateCounters().
Added refcounting to counternodes in countermaps.
https://bugs.webkit.org/show_bug.cgi?id=46387
Test: fast/css/counters/counter-traverse-table-cell.html
- rendering/CounterNode.cpp: (WebCore::CounterNode::create):
- rendering/CounterNode.h:
- rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters):
2010-09-30 Cris Neckar <cdn@chromium.org>
Reviewed by Darin Adler.
Tests for crash in counter nodes when traversing table cells.
https://bugs.webkit.org/show_bug.cgi?id=46387
- fast/css/counters/counter-traverse-table-cell-expected.txt: Added.
- fast/css/counters/counter-traverse-table-cell.html: Added.
- 1:01 PM Changeset in webkit [68818] by
-
- 3 edits in trunk/WebKit/chromium
Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).
Reviewed by Darin Fisher.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
- 1:01 PM Changeset in webkit [68817] by
-
- 36 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46928
Reviewed by Beth Dakin.
Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::isLeftPage):
(WebCore::CSSStyleSelector::applyProperty):
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- rendering/InlineBox.h:
(WebCore::InlineBox::isLeftToRightDirection):
(WebCore::InlineBox::caretLeftmostOffset):
(WebCore::InlineBox::caretRightmostOffset):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::direction):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::getHorizontalSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::localCaretRect):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::localCaretRect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutLegend):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp:
(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeScrollDimensions):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::markerTextWithSuffix):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::suffix):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::valuePartRect):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::valuePartRect):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::collectBorderStyles):
(WebCore::RenderTableCell::paintCollapsedBorder):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::positionLineBox):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintProgressBar):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
- rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::measureCharacter):
(WebCore::SVGInlineTextBox::buildLayoutInformation):
- rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBox):
- rendering/SVGTextLayoutUtilities.cpp:
(WebCore::svgTextRunForInlineTextBox):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isLeftToRightDirection):
- wml/WMLTableElement.cpp:
(WebCore::WMLTableElement::alignCells):
- 12:35 PM Changeset in webkit [68816] by
-
- 1 edit56 adds in trunk/LayoutTests
done
- 12:27 PM Changeset in webkit [68815] by
-
- 2 edits in trunk/WebKitTools
The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
https://bugs.webkit.org/show_bug.cgi?id=46926
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
Release Tests, and two bots running Windows Debug Tests, instead of four running both.
- 11:54 AM Changeset in webkit [68814] by
-
- 4 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46923
Reviewed by Simon Fraser.
Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
completely separate LTR/RTL cases.
Added fast/blockflow/inline-direction-positioning.html
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
LayoutTests:
- fast/blockflow/inline-direction-positioning.html: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/mac/fast/blockflow/inline-direction-positioning-expected.txt: Added.
- 11:50 AM Changeset in webkit [68813] by
-
- 2 edits in trunk/WebKitTools
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917
Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.
- Scripts/webkitpy/tool/commands/queries.py:
- 11:50 AM Changeset in webkit [68812] by
-
- 2 edits in trunk/JavaScriptCore
Add additional checks to StringBuffer.
<rdar://problem/7756381>
Reviewed by Darin Adler.
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::resize):
- 11:42 AM Changeset in webkit [68811] by
-
- 3 edits in trunk/WebKit2
Forward declare structs with 'struct' in the message headers
https://bugs.webkit.org/show_bug.cgi?id=46925
<rdar://problem/8497940>
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
(struct_or_class): New function which given a type and a namespace returns the correct
forward declaration syntax (struct or class).
- Scripts/webkit2/messages_unittest.py:
Update expected results.
- 11:32 AM Changeset in webkit [68810] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-30 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
[chromium] Fix clang error in KURLTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=46861
- tests/KURLTest.cpp: (WTF::operator<<):
- 11:28 AM Changeset in webkit [68809] by
-
- 3 edits2 adds in trunk
Fix color media queries on Windows
Fixes <http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
media query does not evaluate to true for 32bpp displays on Windows
Test: fast/media/color-does-not-include-alpha.html
Reviewed by Darin Adler.
WebCore:
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepthPerComponent): Use screenDepth instead of trying
to interpret DEVMODE directly, since screenDepth knows how to correct
for video drivers that return 32 instead of 24.
LayoutTests:
Add test for color:8 media queries
- fast/media/color-does-not-include-alpha-expected.txt: Added.
- fast/media/color-does-not-include-alpha.html: Added.
- 11:27 AM Changeset in webkit [68808] by
-
- 5 edits in trunk
Make sure screen.colorDepth/screen.pixelDepth don't include the bits used for alpha
Fixes <http://webkit.org/b/42972> <rdar://problem/8234071>
screen.colorDepth and screen.pixelDepth return 32 on Windows, but
should return 24 (according to CSSOM View and Firefox)
Reviewed by Darin Adler.
WebCore:
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepth): If Windows says there are 32 bits per pixel,
return 24 instead, as 32 includes the alpha component but this
function is supposed to ignore the alpha component.
LayoutTests:
Update screen.colorDepth/screen.pixelDepth test to not allow values
that contain bits for alpha
- fast/dom/Window/window-screen-properties-expected.txt: Updated
results.
- fast/dom/Window/window-screen-properties.html: Changed only to
expect 16 or 24.
- 11:20 AM Changeset in webkit [68807] by
-
- 15 edits in trunk
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
This is covered by existing tests.
- editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
- platform/chromium/ClipboardChromium.cpp: (WebCore::normalizeType): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::files): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::writePlainText):
- platform/chromium/ClipboardChromiumWin.cpp: (WebCore::ClipboardChromium::validateFileName):
- platform/chromium/ClipboardMimeTypes.cpp:
- platform/chromium/ClipboardMimeTypes.h:
- platform/chromium/DragDataChromium.cpp: (WebCore::containsHTML): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::canSmartReplace): (WebCore::DragData::asFragment):
- platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getURL): (WebCore::ReadableDataObject::getHTML):
- platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::clearData): (WebCore::WritableDataObject::setData): (WebCore::WritableDataObject::setURL): (WebCore::WritableDataObject::setHTML):
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::initialize): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent):
- 11:12 AM Changeset in webkit [68806] by
-
- 5 edits81 adds in trunk
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
- src/WebGraphicsContext3DDefaultImpl.cpp: Make ShaderSourceMap as <ShaderID, ShaderSourceEntry*>, so map resizing will be efficient and we don't need to worry about pointer copying. (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
- src/WebGraphicsContext3DDefaultImpl.h: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
- fast/canvas/webgl/glsl-conformance-expected.txt: Added.
- fast/canvas/webgl/glsl-conformance.html: Added.
- fast/canvas/webgl/resources/webgl-test-utils.js: Add a function to turn off console output. (WebGLTestUtils.): (WebGLTestUtils):
- fast/canvas/webgl/shaders: Added.
- fast/canvas/webgl/shaders/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/implicit: Added.
- fast/canvas/webgl/shaders/implicit/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/implicit/add_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/add_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_int_to_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec2_to_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec3_to_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/assign_ivec4_to_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/construct_struct.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/divide_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/equal_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/function_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/greater_than.vert: Added.
- fast/canvas/webgl/shaders/implicit/greater_than_equal.vert: Added.
- fast/canvas/webgl/shaders/implicit/less_than.vert: Added.
- fast/canvas/webgl/shaders/implicit/less_than_equal.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/multiply_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/not_equal_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_mat4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_int_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/subtract_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_int_float.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec2_vec2.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec3_vec3.vert: Added.
- fast/canvas/webgl/shaders/implicit/ternary_ivec4_vec4.vert: Added.
- fast/canvas/webgl/shaders/reserved: Added.
- fast/canvas/webgl/shaders/reserved/00_shaders.txt: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_field.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_function.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_struct.vert: Added.
- fast/canvas/webgl/shaders/reserved/_webgl_variable.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_field.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_function.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_struct.vert: Added.
- fast/canvas/webgl/shaders/reserved/webgl_variable.vert: Added.
- 11:04 AM Changeset in webkit [68805] by
-
- 2 edits in trunk/LayoutTests
Add some tests to the Windows Skipped list
These all have bugs filed about them.
- platform/win/Skipped:
- 10:59 AM Changeset in webkit [68804] by
-
- 1 edit in trunk/WebCore/platform/graphics/gpu/DrawingBuffer.h
Fixed chrome build issue in DrawingBuffer.h
- 10:57 AM Changeset in webkit [68803] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-30 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] WebIDBDatabase and WebIDBObjectStore are missing methods called from Chromium land.
https://bugs.webkit.org/show_bug.cgi?id=46922
The missing functions were removed in r68795.
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex):
- 10:43 AM Changeset in webkit [68802] by
-
- 21 edits2 adds in trunk
2010-09-30 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Make 2D accelerated canvas rendering build on Mac
https://bugs.webkit.org/show_bug.cgi?id=46007
Add accelerated 2D rendering files to Mac build, fix build errors,
add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
enabled, and add a skeleton of the mac specific file so it builds.
DrawingBufferMac.mm, the Mac specific file does nothing right now
other than initialize and create a layer. The rest will be added
when I do the actual implementation.
The most significant change was to SharedGraphicsContext3D, which
had a static local OwnPtr in one of the methods. This was causing
the exit time destructor warning. Getting rid of the OwnPtr fixed
the problem. Since the pointer that was being wrapped was to a
static object that would never get destroyed, the OwnPtr was not
necessary.
I also added the ACCELERATED_2D_CANVAS flag to build-webkit
and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
But right now the flag is off by default.
- 10:36 AM Changeset in webkit [68801] by
-
- 11 edits in trunk
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getPlatformTextureId): (WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
- src/WebGraphicsContext3DDefaultImpl.h:
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingEnabled):
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleComposite):
- DumpRenderTree/chromium/WebViewHost.h:
- 10:35 AM Changeset in webkit [68800] by
-
- 2 edits in trunk
[wx] Fix typo in build script.
- 10:35 AM Changeset in webkit [68799] by
-
- 2 edits in trunk/JavaScriptCore
[wx] wxMSW build fix. Make sure we copy the compiler flags and remove exception handling from
the copy so as not to alter global settings.
- 10:23 AM Changeset in webkit [68798] by
-
- 3 edits in trunk/LayoutTests
Make Windows match the Mac fallback font for the hyphen character in two tests
Fixes <http://webkit.org/b/46909> <rdar://problem/8497214> REGRESSION
(r68551): fast/text/midword-break-after-breakable-char.html and
fast/text/basic/014.html are failing on Windows
Rubber-stamped by Dan Bernstein.
- fast/text/basic/014.html:
- fast/text/midword-break-after-breakable-char.html:
Added a little @font-face magic to force the font for the hyphen
character.
- 10:21 AM Changeset in webkit [68797] by
-
- 4 edits70 adds in trunk
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Adding layout tests for feComposite dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in2-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k1-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k2-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k3-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k4-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-operator-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in2-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k1-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k2-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k3-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k4-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-operator-prop.js: Added. (executeTest):
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::svgAttributeChanged):
- svg/SVGFECompositeElement.h:
- 10:16 AM Changeset in webkit [68796] by
-
- 3 edits in trunk/WebKit/mac
Add printing SPI allowing full control over shrink-to-fit
https://bugs.webkit.org/show_bug.cgi?id=46877
Reviewed by John Sullivan.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
- WebView/WebHTMLViewPrivate.h:
- 9:55 AM Changeset in webkit [68795] by
-
- 79 edits in trunk
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
A bit of cleanup + use setVersion transactions for all of our work.
- storage/indexeddb/database-basics.html:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics.html:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Switch the rest of IndexedDB to use transactions.
Implement most of setVersion.
Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
Switch to using the standard cross thread task stuff.
Make everything threadsafe so it works with cross thread copy
(will be useful in the future).
Fix some subtle bugs in transactions.
Various bits of clean up (when I couldn't resist).
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h:
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- platform/CrossThreadCopier.cpp:
- storage/IDBAny.cpp: (WebCore::IDBAny::idbFactory): (WebCore::IDBAny::idbTransaction): (WebCore::IDBAny::set):
- storage/IDBAny.h:
- storage/IDBCallbacks.h:
- storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
- storage/IDBCursor.h: (WebCore::IDBCursor::create):
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::removeInternal):
- storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
- storage/IDBDatabase.h:
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::close):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
- storage/IDBIndex.h: (WebCore::IDBIndex::create):
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
- storage/IDBIndexBackendImpl.h:
- storage/IDBIndexBackendInterface.h:
- storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey):
- storage/IDBKey.h:
- storage/IDBKeyRange.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::removeInternal): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
- storage/IDBRequest.h: (WebCore::IDBRequest::create):
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
- storage/IDBTransactionBackendImpl.h:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Plumbing.
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::close):
- public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
- public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::close):
- src/IDBDatabaseProxy.h:
- src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
- src/IDBIndexBackendProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
- src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::close):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 9:46 AM Changeset in webkit [68794] by
-
- 2 edits in trunk/LayoutTests
Skip a crashing test on Windows
- platform/win/Skipped: Skip
fast/frames/iframe-reparenting-adopt-node.html. There's already a bug
filed about the issue.
- 9:40 AM Changeset in webkit [68793] by
-
- 3 edits in trunk/WebKitTools
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.init): Moved code here from
RaisingDelegate.init.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.init): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.
- 9:39 AM Changeset in webkit [68792] by
-
- 2 edits in trunk/WebKitTools
Fix path -> URL conversion on Cygwin
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.
- 9:31 AM Changeset in webkit [68791] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-09-30 William Siegrist <wsiegrist@apple.com>
Fix syntax error in r68744.
- 9:30 AM Changeset in webkit [68790] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg
2010-09-30 William Siegrist <wsiegrist@apple.com>
Set cache values for master.
- 9:16 AM Changeset in webkit [68789] by
-
- 2 edits in trunk/LayoutTests
Skip a test that fails on Windows due to lack of SSL support
- platform/win/Skipped: Added
http/tests/navigation/ping-cross-origin-from-https.html.
- 9:11 AM Changeset in webkit [68788] by
-
- 2 edits in trunk/WebKit2
Original patch by Zalan Bujtas.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-30
Reviewed by Antti Koivisto.
The m_readBuffer might be smaller than the incoming message size and
thus result in memory corruption. Do a similar fix as the win port,
resizing the m_readBuffer to have room for the message.
- Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
- 8:45 AM Changeset in webkit [68787] by
-
- 2 edits in trunk/WebCore
2010-09-30 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Martin Robinson.
[Gtk] build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795
makevalues.pl and makeprop.pl generate 3 files in one run.
Double or triple target is incorrect, because on a multicore
machine make processes targets in parallel.
Setting a->b->c dependencies for 3 generated files guarantees
that make doesn't execute the recipe of the rule more than one.
- GNUmakefile.am: Dependencies and missing headers added.
- 8:39 AM Changeset in webkit [68786] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/layers/video-layer.html on Windows
Fixes <http://webkit.org/b/46903> <rdar://problem/8496933> REGRESSION
(r67251): fast/layers/video-layer.html failing on Windows
- platform/win/fast/layers/video-layer-expected.txt:
- 8:18 AM Changeset in webkit [68785] by
-
- 2 edits in trunk/WebKitTools
Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once
The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.
Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows
Reviewed by Anders Carlsson.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.
- 7:55 AM Changeset in webkit [68784] by
-
- 8 edits in trunk/LayoutTests
Rebaseline Windows results for recent-ish changes
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- platform/win/html5lib/runner-expected.txt:
- 6:50 AM Changeset in webkit [68783] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fixup for the previous commit that accidently only had ChangeLog.
- 6:44 AM Changeset in webkit [68782] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-09-30 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix (marked ResourceRawHeaders.h as private).
- WebCore.xcodeproj/project.pbxproj:
- 5:53 AM Changeset in webkit [68781] by
-
- 19 edits2 copies1 add in trunk
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse):
- platform/network/ResourceRawHeaders.h: Added.
- platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting. (WebCore::ResourceRequestBase::reportRawHeaders): (WebCore::ResourceRequestBase::setReportRawHeaders): (WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/ResourceResponseBase.cpp: Added support for raw headers. (WebCore::ResourceResponseBase::resourceRawHeaders): (WebCore::ResourceResponseBase::setResourceRawHeaders):
- platform/network/ResourceResponseBase.h:
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
Added plumbing for raw headers flag and response field between chromium and WebCore.
https://bugs.webkit.org/show_bug.cgi?id=46092
- WebKit.gyp:
- public/WebResourceRawHeaders.h: Added.
- public/WebURLRequest.h:
- public/WebURLResponse.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
- src/WebResourceRawHeaders.cpp: Added. (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::addHeader): (WebKit::WebResourceRawHeaders::addRequestHeader): (WebKit::WebResourceRawHeaders::addResponseHeader):
- src/WebURLRequest.cpp: (WebKit::WebURLRequest::setReportRawHeaders): (WebKit::WebURLRequest::reportRawHeaders):
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::resourceRawHeaders): (WebKit::WebURLResponse::setResourceRawHeaders):
- src/WebURLResponsePrivate.h:
- 5:47 AM Changeset in webkit [68780] by
-
- 4 edits in trunk
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
- WebCoreSupport/InspectorServerQt.cpp:
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
- loader/PingLoader.cpp:
- 5:45 AM Changeset in webkit [68779] by
-
- 4 edits in trunk/WebCore
2010-09-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: assign the resource loading finish time which was obtained from the network stack
as the end time for the corresponding event in Timeline.
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
- inspector/InspectorTimelineAgent.h:
- 5:42 AM Changeset in webkit [68778] by
-
- 10 edits in trunk/WebCore
2010-09-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement sorting by timeline in network panel + filtering.
https://bugs.webkit.org/show_bug.cgi?id=45657
A number of drive-by fixes, sorting by timeline added,
0-based timeline for duration added, filters added,
more love for detailed view + nice headers.
- English.lproj/localizedStrings.js:
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.markColumnAsSortedBy): (WebInspector.DataGrid.prototype.headerTableHeader):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML): (WebInspector.NetworkPanel.prototype._createSortingFunctions): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._createFilterPanel): (WebInspector.NetworkPanel.prototype._showCategory): (WebInspector.NetworkPanel.prototype._hideCategory): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._createDivInTD): (WebInspector.NetworkDataGridNode.prototype._refreshURLCell): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._appendSubtitle): (WebInspector.NetworkDataGridNode.SizeComparator): (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel):
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
- inspector/front-end/inspector.css: (.data-grid th.sort-ascending > div::after): (.data-grid th.sort-descending > div::after): (.status-bar-items):
- inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid th): (.network.panel .data-grid.small th): (.network.panel .data-grid .data-container): (.network.panel .data-grid.small .data-container): (.network.panel .data-grid select): (.network.panel .data-grid td.time-column): (.network-cell-subtitle): (.network-header-subtitle): (.network-event-divider): (.network.panel .network-timeline-grid.small .network-event-divider): (.network.panel .resources-dividers-label-bar): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar): (.network.panel .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network.panel .resources-divider.first .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider.first): (#network-filter): (.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other): (.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
- 5:29 AM Changeset in webkit [68777] by
-
- 3 edits in trunk/WebCore
[Qt] Ensure we always report a valid size for the video
Reviewed by Simon Hausmann.
Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- 5:04 AM Changeset in webkit [68776] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct reviewer, Andreas was faster!
- 5:03 AM Changeset in webkit [68775] by
-
- 3 edits in trunk/WebCore
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGTextPath lacks isSVGTextPath() method
https://bugs.webkit.org/show_bug.cgi?id=46888
Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGTextPath): Return false.
- rendering/RenderSVGTextPath.h: Changed indentation of whole file. (WebCore::RenderSVGTextPath::isSVGTextPath): Return true. (WebCore::RenderSVGTextPath::renderName): (WebCore::toRenderSVGTextPath): Add helper casting methods.
- 5:00 AM Changeset in webkit [68774] by
-
- 2 edits in trunk/WebCore
[Qt] Ensure that the media player backend does not leave any resources around
Reviewed by Simon Hausmann.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
- 4:51 AM Changeset in webkit [68773] by
-
- 3 edits in trunk/WebCore
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
AffineTransform should expose methods calculating the x/y scale factors
https://bugs.webkit.org/show_bug.cgi?id=46887
Expose methods calculating the x/y scale factors for an AffineTransform.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions. (WebCore::AffineTransform::xScale): (WebCore::AffineTransform::yScale):
- platform/graphics/transforms/AffineTransform.h:
- 4:50 AM Changeset in webkit [68772] by
-
- 2 edits in trunk/WebCore
Minor cleanup of MediaPlayerPrivateQt
Reviewed by Simon Hausmann.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):
- 4:44 AM Changeset in webkit [68771] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The case-insensitivity backreference checking isn't working with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46882
Add ignorecase checking to the Interpreter::tryConsumeBackReference() function.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::tryConsumeBackReference):
- 3:29 AM Changeset in webkit [68770] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Leave initializeRandomNumberGenerator empty.
https://bugs.webkit.org/show_bug.cgi?id=46851
On Brew MP, AEECLSID_RANDOM initializes itself.
- wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
- 2:36 AM Changeset in webkit [68769] by
-
- 3 edits in trunk/WebCore
2010-09-30 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Mark unused parameters as such.
https://bugs.webkit.org/show_bug.cgi?id=46880
- inspector/InspectorDOMAgent.cpp:
- page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
- 2:26 AM Changeset in webkit [68768] by
-
- 3 edits in trunk/WebKitTools
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload warns that I'm using Xcode when I'm not
https://bugs.webkit.org/show_bug.cgi?id=46869
String.find returns -1 when not found, so switched to "in".
- Scripts/webkitpy/common/system/user.py:
- Scripts/webkitpy/common/system/user_unittest.py:
- 2:15 AM Changeset in webkit [68767] by
-
- 15 edits2 adds in trunk/WebCore
2010-09-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
- dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
- inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
- workers/SharedWorker.cpp:
- 2:12 AM Changeset in webkit [68766] by
-
- 4 edits in trunk/WebKitTools
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch failure-reason dies if non-trunk commits are in the blame range
https://bugs.webkit.org/show_bug.cgi?id=46866
I also made failure-reason use RegressionWindow in a cleaner way.
- Scripts/webkitpy/tool/commands/queries.py:
- 1:50 AM Changeset in webkit [68765] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-30 Avi Drissman <avi@google.com>
Reviewed by Kenneth Russell.
[Chromium] Tabbing into page doesn't always select the first element
https://bugs.webkit.org/show_bug.cgi?id=46856
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setInitialFocus):
- 1:37 AM Changeset in webkit [68764] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-30 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove unnecessary cacheFlush calls from Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=46702
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer):
- 1:22 AM Changeset in webkit [68763] by
-
- 2 edits in trunk/WebCore
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852
Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForDocument):
- 12:48 AM Changeset in webkit [68762] by
-
- 22 edits1 copy in trunk/WebCore
2010-09-30 Michael Nordman <Michael Nordman>
Reviewed by David Levin.
Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
across threads and to compare platform specific data members of ResourceRequest.
- Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
- Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method is already present on ResourceResponseBase.
- Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base classes and extended those base classes in the platform specific headers to provide a place to hold additional fields.
- Used this mechanism to have the chromium port's data members make the hop. https://bugs.webkit.org/show_bug.cgi?id=46430
No new tests. Just plumbing.
- WebCore.exp.in: removed the symbol for the now inlined == operator
- WebCore.gypi: added chromium/ResourceResponse.cpp
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::compare):
- platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- platform/network/android/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/android/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.h:
- platform/network/chromium/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceResponse.h:
- platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::doUpdateResourceResponse): (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- 12:22 AM Changeset in webkit [68761] by
-
- 4 edits in trunk/WebKit/qt
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash if an scene with accelerated compositing layout during the paint event
https://bugs.webkit.org/show_bug.cgi?id=46812
Delay the deletion of the overlay after the current event is processed.
Removing the overlay can sometimes be done inside the rendering code of
the overlay itself. When the rendering code is using the reference after
the deletion of the overlay, WebKit crashes.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay):
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
- WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
- 12:10 AM Changeset in webkit [68760] by
-
- 2 edits in trunk/WebKit/qt
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814
Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):
- 12:08 AM Changeset in webkit [68759] by
-
- 2 edits1 move in trunk/WebKit/chromium
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Rename chromium's GraphicsContext3D.cpp to match others.
https://bugs.webkit.org/show_bug.cgi?id=46771
- WebKit.gyp:
- src/GraphicsContext3DChromium.cpp: Renamed from WebKit/chromium/src/GraphicsContext3D.cpp.
