⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 2, 2010:

10:32 PM Changeset in webkit [68983] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

Add the ability to jump to a specific test.

  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.goToTestByName): (TestSuite.prototype.switchToFormat):
9:24 PM Changeset in webkit [68982] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

For a ref test, load the ref in the same format (HTML4 vs XHTML1)
as the test.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
9:24 PM Changeset in webkit [68981] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

Update the UI to reflect the fact that each test needs to be tested
in both HTML4 and XHTML1 format.

  • CSSTestSuiteHarness/harness/harness.js: (Test): (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.recordResult): (TestSuite.prototype.formatChanged): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus):
2:44 PM Changeset in webkit [68980] by hclam@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Build fix. Not reviewed.

Remove LayoutTests/websocket and the dummy file.

  • websocket/tests/workers/README: Removed.
2:18 PM Changeset in webkit [68979] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations because of the massive SVG change in r68976.

  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [68978] by diegohcg@webkit.org
  • 4 edits
    4 adds in trunk

[Qt] Provide Qt support for DeviceMotion/Orientation clients
​https://bugs.webkit.org/show_bug.cgi?id=47051

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Add Qt DeviceMotion/Orientation dummy clients in build system.

  • WebCore.pro:

WebKit/qt:

Dummy implementation of DeviceMotion/Orientation client classes
to make possible to hook up motion/orientation data
in further implementations.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DeviceMotionClientQt.cpp: Added.

(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::setController):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
(WebCore::DeviceMotionClientQt::deviceMotionControllerDestroyed):

  • WebCoreSupport/DeviceMotionClientQt.h: Added.

(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):

  • WebCoreSupport/DeviceOrientationClientQt.cpp: Added.

(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::setController):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):
(WebCore::DeviceOrientationClientQt::deviceOrientationControllerDestroyed):

  • WebCoreSupport/DeviceOrientationClientQt.h: Added.

(WebCore::DeviceOrientationClientQt::~DeviceOrientationClientQt):

2:26 AM Changeset in webkit [68977] by Nikolas Zimmermann
  • 67 edits in trunk/LayoutTests

2010-10-02 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Rebaseline gtk / qt / win specific SVG text results.

  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
1:08 AM Changeset in webkit [68976] by Nikolas Zimmermann
  • 331 edits
    12 adds
    8 deletes in trunk

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Modernize SVG text layout engine, split the layout process into three phases, so that each results can be cached (which will be done in a follow-up patch).

Phase #1) - SVGTextLayoutAttributesBuilder
------------------------------------------

Parse x/y/dx/dy/rotate values of the <text> subtree (<text x="30 40">A<tspan>B<tspan x="50">C</tspan></tspan></text>)
This is done by SVGTextLayoutAttributesBuilder. It builds a SVGTextLayoutAttributes object for each RenderSVGInlineText renderer, and stores it there.
Phase #1 is started from RenderSVGText::layout(), before RenderBlockLineLayout is laying out the inline children, and thus before the InlineBox tree is created.

Now we know which character has an associated absolute x or y position, denoting the start of a new text chunk. Whenever we encounter a new text chunk
RenderBlockLineLayout should create a new SVGInlineTextBox. This is very important, as BiDi reordering shouldn't happen across text chunks, as well as ligature detection.

The text chunk concept is now merged right into the InlineBox tree, so we don't need to hack around the lack of that, as done for the previous years.

Phase #2) - SVGTextLayoutEngine
------------------------------------------

RenderSVGText::layout() calls RenderBlock::layoutInlineChildren() right after phase #1 ends. The InlineBox tree is created. During that process findNextLineBreak()
decides how to split up the text into InlineTextBoxes. It has already been patched, to ask RenderSVGInlineText::characterStartsNewTextChunk(int position), whether the
current character should go in a new SVGInlineTextBox or not. This requires that phase #1 already stored these information in the RenderSVGInlineText objects.

For each <text> object a SVGRootInlineBox is created (in constructLine()) and all child boxes are added. After that SVGRootInlineBox::computePerCharacterLayoutInformation()
is called (unlike HTML text, which splits the vertical & horizontal layout in two phases, it's just one single phase for SVG). This function invokes SVGTextLayoutEngine
and starts phase #2 of the layout process.

SVGTextLayoutEngine lays out the content of each SVGInlineTextBox either on a line or a path. It contains all the logic handling, alignment-baseline, dominant-baseline,
letter-spacing, word-spacing, kerning, glyph-orientation-(horizontal|vertical), rotation, etc. etc.

As result it generates a set of SVGTextFragment objects which are stored in each SVGInlineTextBox. Each SVGTextFragment is a portion of text that can be rendered/measured
at once. Some examples to illustrate what's going on:

<text x="20">ABCD</text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 4, "ABCD" (x=20)

<text x="20 100">ABCD</text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (x=20)
  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "B" (x=100)
    • SVGTextFragment, start 1 length 2, "CD" (x=100 + advance_of_last)

<text><textPath xlink:href="#somePath">ABCD</textPath></text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (rotated!)
    • SVGTextFragment, start 1 length 1, "B" (rotated!)
    • SVGTextFragment, start 2 length 1, "C" (rotated!)
    • SVGTextFragment, start 3 length 1, "D" (rotated!)

<text x="0 50 100">A<tspan>B</tspan>C</text>

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (x=0)
  • SVGInlineFlowBox
    • SVGInlineTextBox
      • SVGTextFragment, start 0 length 1, "B" (x=50)
  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "C" (x=100)

When painting text SVGInlineTextBox just walks its fragments and paints them. Text selection works the same.
All text measurements (width/height etc.) have already been done in phase #2 and aren't required anymore while painting/selecting.
This is one of the main benefits of the new text layout engine, painting & selection is cheap now, compared to the layout process.

We're now doing phase #1 everytime RenderSVGText::layout() is called. This is not necessary, we only have to recompute these information
if the x/y/dx/dy or rotate list of an element in the <text> subtree changes or the text content itself -> this will be done in a follow-up patch.
It's likely that we'll also find ways to skip phase #2 in certain situations.

Phase #3) - SVGTextChunkBuilder
------------------------------------------

After phase #2 finished, we can post-process the text fragments. Certain operations have to be applied on a "per chunk" basis.
text-anchor should be applied to individual text chunks, as well as textLength corrections (lengthAdjust="spacing" / lengthAdjust="spacingAndGlyphs").

SVGTextChunkBuilder just walks the SVGInlineTextBox, and collects all boxes belonging to a certain chunk. For each of the chunks all fragments
are post-processed. For instance for text-anchor="middle", all x positions of all fragments are shifted by -fragmentWidth/2 (for horizonal text).

After phase #1 - #3 finished, SVGRootInlineBox::computePerCharacterLayoutInformation() utilizies the stored SVGTextFragments to lay out all child
boxes in the InlineBox tree (setWidth/Height, etc.), the size and position of the SVGRootInlineBox and it's parent RenderSVGText object.

This should give interessted readers a good summary of how the new text layout engine works.
See LayoutTests/ChangeLog for more details on test progression.

Tests: svg/custom/text-rotation.svg

svg/custom/text-x-dy-lists.svg

  • Android.mk: Add SVGTextLayoutEngine.* / SVGTextChunkBuilder.* to build. Remove SVGCharacterData.* / SVGTextChunkLayoutInfo.* / SVGTextLayoutUtilities.* from build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/InlineBox.h: (WebCore::InlineBox::isSVGInlineFlowBox): Add helper function to identify SVGInlineFlowBoxes. The variants for SVGInlineTextBox etc. already exist.
  • rendering/InlineTextBox.h: Devirtualize selectionStartEnd, SVG is no longer overriding it.
  • rendering/RenderSVGAllInOne.cpp: removes
  • rendering/RenderText.cpp: (WebCore::RenderText::setTextInternal): Remove SVG specific hacks, moved to RenderSVGInlineText.
  • rendering/SVGCharacterData.cpp: Removed.
  • rendering/SVGCharacterData.h: Removed.
  • rendering/SVGCharacterLayoutInfo.cpp: Removed.
  • rendering/SVGCharacterLayoutInfo.h: Removed.
  • rendering/SVGRenderTreeAsText.cpp: Hack DRT output to be somewhat compatible with the current output, the plan is to change it completly after this patch. (WebCore::writeRenderSVGTextBox): (WebCore::writeSVGInlineTextBox):
  • rendering/SVGTextChunkLayoutInfo.cpp: Removed.
  • rendering/SVGTextChunkLayoutInfo.h: Removed.
  • rendering/SVGTextLayoutUtilities.cpp: Removed.
  • rendering/SVGTextLayoutUtilities.h: Removed.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): Only return immediately if SVGRenderStyle::diff produced StyleDifferenceLayout, it it's sth. else be sure to ask RenderStyle itself what to do.
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::isVerticalWritingMode): New helper method, moved from SVGTextLayoutUtilities.
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::applySVGWhitespaceRules): Moved from RenderText into a SVG specific place. (WebCore::RenderSVGInlineText::RenderSVGInlineText): Use applySVGWhitespaceRules on the incoming text. (WebCore::RenderSVGInlineText::styleDidChange): Only apply SVG white space rules, when using xml:space="preserve", otherwhise the constructor already handled it. (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Create text chunks for absolute y values as well, SVG 1.1 2nd Edition demands that. (WebCore::RenderSVGInlineText::positionForPoint): New function operating on all SVGInlineTextBoxes and their SVGTextFragments.
  • rendering/svg/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::layoutAttributes): Stores the layout attributes generated by SVGTextLayoutAttributesBuilder. (WebCore::toRenderSVGInlineText): New helper methods for casting.
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Add comment, that SVGTextLayoutAttributesBuilder is just phase one of the layout process. (WebCore::RenderSVGText::positionForPoint): Simplified implementation for SVGs needs.
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paintSelectionBackground): Seperated selection background drawing from actual text rendering, to make sure selection is always in background for SVG. (WebCore::SVGInlineFlowBox::paint): Call computetextMatchMarkerRectForRenderer, before painting. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): New method.
  • rendering/svg/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::isSVGInlineFlowBox):
  • rendering/svg/SVGInlineTextBox.cpp: Completly rewritten, operates on SVGTextFragments, produced by the SVGTextLayoutEngine. Whole new concept, compared to the old hack.
  • rendering/svg/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::clearTextFragments): Only used by SVGTextLayoutEngine, to clean up previously computed fragments. (WebCore::SVGInlineTextBox::textFragments): Offers access to the fragments in the box. (WebCore::SVGInlineTextBox::startsNewTextChunk): Does this box start a new text chunk? (WebCore::SVGInlineTextBox::setStartsNewTextChunk): SVGTextLayoutEngine marks this box, if it starts a new text chunk.
  • rendering/svg/SVGRootInlineBox.cpp: Remove old code regarding text chunk parts. (WebCore::SVGRootInlineBox::paint): Selection is now painted before text, to assure it's really in the background. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use new SVGTextLayoutEngine. (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): Feed SVGTextLayoutEngine with SVGInlineTextBoxes, detect the begin/end of path layouts. (WebCore::SVGRootInlineBox::layoutChildBoxes): Use new isSVGInlineTextBox() helper method. (WebCore::SVGRootInlineBox::closestLeafChildForPosition): Simplified version for SVG.
  • rendering/svg/SVGRootInlineBox.h: Remove access to text chunks, they're now longer stored in the SVGRootInlineBox.
  • rendering/svg/SVGTextChunk.cpp: s/SVGTextChunkNew/SVGTextChunk/
  • rendering/svg/SVGTextChunk.h:
  • rendering/svg/SVGTextChunkBuilder.cpp: Added.
  • rendering/svg/SVGTextChunkBuilder.h: Added.
  • rendering/svg/SVGTextLayoutAttributes.cpp: Constify dump() method.
  • rendering/svg/SVGTextLayoutAttributes.h: (WebCore::SVGTextLayoutAttributes::textMetricsValues):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewritten, consume less memory, while building the layout attributes.
  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
  • rendering/svg/SVGTextLayoutEngine.cpp: Added.
  • rendering/svg/SVGTextLayoutEngine.h: Added.
  • rendering/svg/SVGTextQuery.cpp: Rewritten to deal with the new SVGTextFragment/SVGTextLayoutAttributes logic.
  • rendering/svg/SVGTextQuery.h:

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Rebaseline most SVGs containing text. The underlying concept has changed, I tried hard to maintain
a somewhat compatible DRT output, so it doesn't require rebaselines of _all_ tests.
The dump looks awkward now, it will always report "chunk 1", as it's hardcoded in SVGRenderTreeAsText.
Follow up patches will change the output of text dumps completly.

  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.png: baseline-shift adjustments now match Opera.
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.png: Ditto.
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.checksum:
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.png:
  • platform/mac-leopard/svg/custom/altglyph-expected.checksum:
  • platform/mac-leopard/svg/custom/altglyph-expected.png:
  • platform/mac-leopard/svg/text/multichar-glyph-expected.checksum:
  • platform/mac-leopard/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: No more blurry edges, size calculations fixed.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png: baseline-shift looks slightly different, now matches Opera.
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Vertical text now starts at correct origin, and is centered correctly.
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Ditto + baseline-shift differences.
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.checksum:
  • platform/mac/svg/batik/text/textAnchor2-expected.png: y-position adjustments start new text chunks since SVG 1.1 2nd edition (in contrary to SVG 1.2 Tiny). Left the test as is.
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration-expected.png: text-decoration defined on <text> paints with the paint sever defined on the <tspan>, test finally works!
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textDecoration2-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration2-expected.png: Ditto.
  • platform/mac/svg/batik/text/textDecoration2-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png: Just like pservers-grad-08-b.svg, no more blurry edges.
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png: Ditto.
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png: baseline-shift differences.
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Completly fixed, now aligns properly with path, matches Opera & Batik.
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.checksum:
  • platform/mac/svg/batik/text/textLayout2-expected.png: baseline-shift differences.
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPCDATA-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/combobox-expected.txt:
  • platform/mac/svg/carto.net/selectionlist-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/textbox-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
  • platform/mac/svg/css/text-shadow-multiple-expected.txt:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.png: central baseline now works as expected.
  • platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/mac/svg/custom/altglyph-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.png: ditto.
  • platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png: Kerning is now properly respected.
  • platform/mac/svg/custom/image-small-width-height-expected.txt:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/style-attribute-font-size-expected.txt:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/custom/text-letter-spacing-expected.txt:
  • platform/mac/svg/custom/text-linking-expected.txt:
  • platform/mac/svg/custom/text-rotation-expected.checksum: Added.
  • platform/mac/svg/custom/text-rotation-expected.png: Added.
  • platform/mac/svg/custom/text-rotation-expected.txt: Added.
  • platform/mac/svg/custom/text-whitespace-handling-expected.txt:
  • platform/mac/svg/custom/text-x-dx-lists-expected.txt:
  • platform/mac/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/mac/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/mac/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/text/kerning-expected.txt:
  • platform/mac/svg/text/multichar-glyph-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.checksum:
  • platform/mac/svg/text/select-x-list-1-expected.png:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.checksum:
  • platform/mac/svg/text/select-x-list-2-expected.png:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-3-expected.png:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.checksum:
  • platform/mac/svg/text/select-x-list-4-expected.png:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.checksum:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-03-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.checksum:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-05-b-expected.checksum:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.checksum:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.checksum:
  • platform/mac/svg/text/text-hkern-expected.png: Kerning now respects text chunk boundaries.
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac/svg/text/text-text-01-b-expected.checksum:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.checksum:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png: y positions now also start text chunks, finally a progression on this test!
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png: Opacity doesn't affect selection anymore, matches all other browsers.
  • platform/mac/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.checksum:
  • platform/mac/svg/text/text-vkern-expected.png: Kerning now respects text chunk boundaries.
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/textPathBoundsBug-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • svg/batik/text/xmlSpace.svg: Fixed wrong test, now the embedded SVG Font is actually used.
  • svg/custom/altglyph.svg: Fixed wrong test, xlink namespace was wrong, xlink:href for altGlyph had no effect.
  • svg/custom/glyph-setting-d-attribute-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • svg/custom/text-rotation.svg: Added.
  • svg/custom/text-x-dy-lists.svg: Added.
  • svg/custom/text-x-override-in-tspan-child.svg: Fixed wrong test, depending on a previous bug - now matches Opera.
  • svg/text/multichar-glyph.svg: Also dump end positions of characters.
  • svg/text/resources/SelectionTestCase.js: Modify the selection test cases, to draw green lines marking the computed start & end postions of the selected characters. (selectRange):
12:57 AM Changeset in webkit [68975] by hclam@chromium.org
  • 2 edits in trunk/WebCore

Build fix. Not reviewed.

An adhoc fix for a crash found by reliability bot. This will make the
reliability bot happy. A proper fix is pending commit.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::~VideoLayerChromium):

12:26 AM Changeset in webkit [68974] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Add test expectations for Chromium.

  • platform/chromium/test_expectations.txt:

Oct 1, 2010:

11:01 PM Changeset in webkit [68973] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-10-01 Simon Fraser <Simon Fraser>

Add the ability to remove results for re-testing, and
to import results.

  • CSSTestSuiteHarness/harness/harness.css: (.custom button): (#overlay): (#overlay.visible): (.overlay-contents): (.overlay-contents textarea): (.overlay-contents .buttons): (.overlay-contents .note): (.overlay-contents .buttons button):
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.importResults): (TestSuite.prototype.clearResults): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.importTestResults): (TestSuite.prototype.clearTestResults):
9:49 PM Changeset in webkit [68972] by rniwa@webkit.org
  • 13 edits
    2 adds in trunk/WebCore

2010-10-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

FormatBlockCommand and IndentOutdentCommand should use the same code to iterate paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=46840

Added ApplyBlockElementCommand, which is an abstract class inherited by FormatBlockCommand
and IndentOutdentCommand. It is intended to be inherited by InsertListCommand as well.

ApplyBlockElementCommand's doApply verifies the current selection and exits early
if it's invalid or orphaned or if the current selection is outside editable region.
It then calls formatSelection to apply the block element after which doApply restores the selection.
formatSelection iterates through paragraphs and calls formatParagraph, a pure virtual function
implemented by FormatBlockCommand and IndentOutdentCommand, on each paragraph.

No new tests are added since this is a refactoring.

  • Android.mk: Added ApplyBlockElementCommand.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added ApplyBlockElementCommand.cpp and ApplyBlockElementCommand.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/ApplyBlockElementCommand.cpp: Added. (WebCore::countParagraphs): Moved from IndentOutdentCommand.cpp (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): Added. (WebCore::ApplyBlockElementCommand::doApply): Moved from IndentOutdentCommand::doApply. (WebCore::ApplyBlockElementCommand::formatSelection): Moved from IndentOutdentCommand::indentRegion. (WebCore::ApplyBlockElementCommand::createBlockElement): Added. (WebCore::ApplyBlockElementCommand::splitTextNodes): Moved from IndentOutdentCommand::splitTextNodes.
  • editing/ApplyBlockElementCommand.h: Added.
  • editing/EditingAllInOne.cpp:
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: Removed doApply. (WebCore::FormatBlockCommand::FormatBlockCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::FormatBlockCommand::formatParagraph): Renamed from doApplyForSingleParagraph.
  • editing/FormatBlockCommand.h: FormatBlockCommand inherits from ApplyBlockElementCommand. (WebCore::FormatBlockCommand::create): Uses QualifiedName for the tag name instead of AtomicString.
  • editing/IndentOutdentCommand.cpp: Removed doApply, indentIntoBlockquote, and splitTextNodes. (WebCore::IndentOutdentCommand::IndentOutdentCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::IndentOutdentCommand::indentIntoBlockquote): The code to nullify targetBlockquote when the next paragraph is in a different table cell is moved to ApplyBlockElementCommand::formatSelection. (WebCore::IndentOutdentCommand::formatSelection): Added. Calls outdentRegion when outdenting. (WebCore::IndentOutdentCommand::formatParagraph): Added. Calls tryIndentingAsListItem and indentIntoBlockquote.
  • editing/IndentOutdentCommand.h: IndentOutdentCommand inherits from ApplyBlockElementCommand.
9:01 PM Changeset in webkit [68971] by mrowe@apple.com
  • 13 edits in trunk

Build fix.

Clear the executable bit from a number of source files.

WebCore:

  • page/Frame.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.h:
  • platform/network/ResourceRawHeaders.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:

WebKit/win:

  • WebView.cpp:
  • WebView.h:

WebKit2:

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
8:22 PM Changeset in webkit [68970] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] r68923 broke some plugin tests
​https://bugs.webkit.org/show_bug.cgi?id=47040

No longer pass focus and blur events to plugins when the "old" DOM Level
2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
that the DOM Level 3 version is always fired for this event.

No new tests, as this should cause the failing tests to pass.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): No longer pass focus and blur events to plugins when DOMFocusIn / DOMFocusOut events occur.
7:17 PM Changeset in webkit [68969] by Martin Robinson
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Removed an expected result for a previously skipped test. This test
is skipped because it fails on 1 (out of 4) GTK+ bots. It had
started failing again after the WebSocket tests were relocated and
the skipped list was no longer up to date.

  • platform/gtk/Skipped: Update skipped list to reflect new test location.
  • platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
7:08 PM Changeset in webkit [68968] by tony@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-10-01 Tony Chang <​tony@chromium.org>

Unreviewed. Turns out Safari Win matches Safari Mac so move the
expectation to chromium-win.

  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/5354455-1-expected.txt.
  • platform/win/Skipped:
7:01 PM Changeset in webkit [68967] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-01 Tony Chang <​tony@chromium.org>

Unreviewed. Updating layout test (editing/selection/5354455-1.html) after r68948.
Will fix soon.

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
6:54 PM Changeset in webkit [68966] by weinig@apple.com
  • 5 edits in trunk/WebKitTools

Deploy the new WKString functions to remove most uses of CF from
the WebKitTestRunner.

Reviewed by Jon Honeycutt.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/StringFunctions.h:

(WTR::toWK):
(WTR::toJS):
(WTR::toSTD):
(WTR::operator<<):
(WTR::copyURLString):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

6:46 PM Changeset in webkit [68965] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

6:42 PM Changeset in webkit [68964] by mrowe@apple.com
  • 1 copy in tags/Safari-533.19.1

New tag.

6:17 PM Changeset in webkit [68963] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-01 Mihai Parparita <​mihaip@chromium.org>

Unreviewed TestResultsServer change.

Add files introduced by ​http://crrev.com/61273 to the list of dashboard
files to update.

  • TestResultServer/handlers/dashboardhandler.py:
5:45 PM Changeset in webkit [68962] by andersca@apple.com
  • 11 edits in trunk

WebCore: Plug-ins should have access to the private browsing state.
​https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>

Reviewed by Sam Weinig.

  • page/Page.cpp:

(WebCore::Page::privateBrowsingStateChanged):
When iterating over all widgets, also look for PluginViewBase classes and invoke their
privateBrowsingStateChange member function.

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::privateBrowsingStateChanged):
Add function.

WebKit2: Plug-ins should have access to the private browsing state.
​https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle NPNVprivateModeBool.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
Call PluginController::isPrivateBrowsingEnabled.

(WebKit::NetscapePlugin::NPP_SetValue):
Add NPP_SetValue wrapper.

(WebKit::NetscapePlugin::privateBrowsingStateChanged):
Call NPP_SetValue with the updated state.

  • WebProcess/Plugins/Plugin.h:

Add privateBrowsingStateChanged pure virtual member function.

  • WebProcess/Plugins/PluginController.h:

Add isPrivateBrowsingEnabled pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::privateBrowsingStateChanged):
Call Plugin::privateBrowsingStateChanged.

5:40 PM Changeset in webkit [68961] by weinig@apple.com
  • 10 edits
    2 adds in trunk

WebKit2: Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.

Reviewed by Anders Carlsson.

API Test: WebKit2/WKStringJSString

  • Shared/API/c/WKString.cpp:

(WKStringCreateWithJSString):
(WKStringCopyJSString):

  • Shared/API/c/WKStringPrivate.h: Added.
  • Shared/WebString.h:

(WebKit::WebString::create):
(WebKit::WebString::createJSString):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools: Build Fix for Windows.

Patch by Brian Weinstein <​bweinstein@apple.com> on 2010-10-01

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from

WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.

5:27 PM Changeset in webkit [68960] by bweinstein@apple.com
  • 5 edits in trunk

Build Fix for Windows.

WebCore:

  • WebCore.vcproj/WebCore.vcproj: Don't have an empty post-build step, use

WebCoreCommon.vsprops to handle post-build step.

  • WebCore.vcproj/WebCoreCommon.vsprops: Set the post-build step to delete

$(WebKitOutputDir)/buildfailed.

WebKitTools:

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from

WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.

5:24 PM Changeset in webkit [68959] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Segmentation fault during zoom out
​https://bugs.webkit.org/show_bug.cgi?id=46984

  • platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.
5:17 PM Changeset in webkit [68958] by andersca@apple.com
  • 2 edits in trunk/WebCore

Another Qt build fix attempt.

  • WebCore.pro:
5:13 PM Changeset in webkit [68957] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=47021

Reviewed by Dan Bernstein.

Patch the floatBottom function and its friends. Rename them and consolidate them to be block-flow-aware.

Nothing testable yet, since most of the float code is still unpatched.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::hasOverhangingFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::fitBelowFloats):

5:11 PM Changeset in webkit [68956] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Snow Leopard build.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getProxy):

4:51 PM Changeset in webkit [68955] by mrowe@apple.com
  • 1 edit in branches/safari-533.19-branch/WebCore/editing/SelectionController.cpp

Build fix.

4:49 PM Changeset in webkit [68954] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix typo.

  • platform/network/qt/ProxyServerQt.cpp:

(WebCore::proxyServersForURL):

4:45 PM Changeset in webkit [68953] by andersca@apple.com
  • 2 edits
    1 add in trunk/WebCore

Add Qt ProxyServer stub.

  • WebCore.pro:
  • platform/network/qt/ProxyServerQt.cpp: Added.

(WebCore::proxyServersForURL):

4:42 PM Changeset in webkit [68952] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Implement proxiesForURL, cookiesForURL and setCookiesForURL
​https://bugs.webkit.org/show_bug.cgi?id=47029

Reviewed by Sam Weinig.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):

4:28 PM Changeset in webkit [68951] by andersca@apple.com
  • 9 edits
    3 adds in trunk

Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
​https://bugs.webkit.org/show_bug.cgi?id=47022
<rdar://problem/8504712>

Reviewed by Dan Bernstein.

WebCore:

  • WebCore.exp.in:

Export proxyServersForURL and toString.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • platform/network/ProxyServer.cpp: Added.

(WebCore::appendProxyServerString):
(WebCore::toString):
New function that converts a vector of ProxyServers into a PAC style string.

  • platform/network/ProxyServer.h: Added.

(WebCore::ProxyServer::ProxyServer):
(WebCore::ProxyServer::type):
(WebCore::ProxyServer::hostName):
(WebCore::ProxyServer::port):
Add ProxyServer class.

  • platform/network/cf/ProxyServerCFNet.cpp: Added.

(WebCore::proxyServersForURL):
(WebCore::addProxyServersForURL):
Query CFNetwork for the proxy servers given a URL.

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getProxy):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:forURL:value:length:]):

4:25 PM Changeset in webkit [68950] by mrowe@apple.com
  • 25 edits in branches/safari-533.19-branch

Merge r60541.

4:25 PM Changeset in webkit [68949] by mrowe@apple.com
  • 26 edits in branches/safari-533.19-branch

Merge r59081.

4:21 PM Changeset in webkit [68948] by tony@chromium.org
  • 5 edits
    1 add
    9 deletes in trunk/LayoutTests

2010-10-01 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

editing/selection/5354455-1 has incorrect description text
​https://bugs.webkit.org/show_bug.cgi?id=44990

This test includes descriptive text that describes an OS X-specific behavior.
I almost checked in an incorrect baseline because I believed the text.
This change amends the text to describe expected behavior on Mac/Win/Linux.

Rather than requiring new baselines on all platforms, I took this opportunity
to also convert the test to a markup dump. We'll then end up with just one
Mac baseline and one non-Mac baseline.

  • editing/selection/5354455-1.html:
  • platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.txt: Updated.
  • platform/win/editing/selection/5354455-1-expected.txt: Added.
4:19 PM Changeset in webkit [68947] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r66269.

4:19 PM Changeset in webkit [68946] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r65934.

4:19 PM Changeset in webkit [68945] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r65683.

4:19 PM Changeset in webkit [68944] by mrowe@apple.com
  • 17 edits in branches/safari-533.19-branch/WebCore

Merge r65681.

4:17 PM Changeset in webkit [68943] by hclam@chromium.org
  • 2 edits
    34 adds in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium-linux/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-mac/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-mac/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-mac/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-win-xp/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-win/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [68942] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a typo

4:09 PM Changeset in webkit [68941] by mrowe@apple.com
  • 5 edits
    6 adds in branches/safari-533.19-branch

Merge r67183, r67184, r67255 and r67281.

4:08 PM Changeset in webkit [68940] by zmo@google.com
  • 7 edits
    1 add in trunk

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

texImage2D fails on 16-bit-per-channel images
​https://bugs.webkit.org/show_bug.cgi?id=46947

  • platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats. (WebCore::convertColor16To8): (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

texImage2D fails on 16-bit-per-channel images
​https://bugs.webkit.org/show_bug.cgi?id=46947

  • fast/canvas/webgl/gl-teximage-expected.txt: Add a test case for loading 16-bit-per-channel images as textures.
  • fast/canvas/webgl/gl-teximage.html: Ditto.
  • fast/canvas/webgl/resources/green-2x2-16bit.png: Added.
4:01 PM Changeset in webkit [68939] by mrowe@apple.com
  • 2 adds in branches/safari-533.19-branch/LayoutTests

Add two files that were missed in the previous commit.

3:59 PM Changeset in webkit [68938] by mrowe@apple.com
  • 6 edits in branches/safari-533.19-branch

Merge r63048.

3:56 PM Changeset in webkit [68937] by dpranke@chromium.org
  • 8 edits in branches/chromium/517

Merge 66992 - 2010-09-08 Andy Estes <​aestes@apple.com>

TBR=​abarth@google.com
TBR=​dglazkov@google.com
BUG=55954
TEST=LayoutTests/fast/replaced/object-with-embed-url-param.html

Review URL: ​http://codereview.chromium.org/3551010

3:54 PM Changeset in webkit [68936] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r68812.

3:51 PM Changeset in webkit [68935] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68705.

3:49 PM Changeset in webkit [68934] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68727.

3:42 PM Changeset in webkit [68933] by commit-queue@webkit.org
  • 10 edits
    3 copies in branches/chromium/517

Merge 68630 - 2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Some windowed plugins did not handle events through EventHandler, so we
never set right gesture state for those events.
This change is to set right allowPopupsFromPlugin flag to current
execution frame, so WeKit can always get right gesture state on Mac.
From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
process, that process passes the allowPopupsFromPlugin flag to
WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
NetscapePluginInstanceProxy::evaluate.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Pass the right popupAllowed flag to current execution frame,
so WebKit can get right gesture status for popups initiated
from plugins.
This also makes v8 binding's ScriptController::processingUserGesture
match what jsc version.

Test: plugins/plugin-initiate-popup-window.html

  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292.
Add a test to initiate popup windows from plugin during plugin is
handling mouse/keyboard event.
Disable this test on gtk/qt/win since the test plugin in those platforms
didn't implement NPP_HandleEvent.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/plugin-initiate-popup-window-expected.txt: Added.
  • plugins/plugin-initiate-popup-window.html: Added.

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):

TBR=​commit-queue@webkit.org

3:30 PM Changeset in webkit [68932] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [68931] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Nate Chapin.

Add v8 binding helpers to make FileWriter be an EventTarget.
​https://bugs.webkit.org/show_bug.cgi?id=46910

No new tests; still waiting for the first complete implementation.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3:00 PM Changeset in webkit [68930] by weinig@apple.com
  • 7 edits
    1 add in trunk

Add additional WKString API
​https://bugs.webkit.org/show_bug.cgi?id=46958

Reviewed by Kenneth Rohde Christiansen.

WebKit2:

API Test: WebKit2/WKString

  • Shared/API/c/WKString.cpp:

(WKStringCreateWithUTF8CString):
(WKStringGetMaximumUTF8CStringSize):
(WKStringGetUTF8CString):
(WKStringIsEqual):
(WKStringIsEqualToUTF8CString):

  • Shared/API/c/WKString.h:
  • Shared/WebString.h:

(WebKit::WebString::createFromUTF8String):
(WebKit::WebString::maximumUTF8CStringSize):
(WebKit::WebString::getUTF8CString):
(WebKit::WebString::equal):
(WebKit::WebString::equalToUTF8String):

WebKitTools:

Add basic WKStringRef tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
2:57 PM Changeset in webkit [68929] by mihaip@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-10-01 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Remove WebURLLoaderClient::didFinishLoading(WebURLLoader*)
​https://bugs.webkit.org/show_bug.cgi?id=47008

Now that WebURLLoaderClient::didFinishLoading(WebURLLoader*) has no
more callers, it can be removed (requires a Chromium roll to
​http://crrev.com/61206, which actually removed the last usage).

  • DEPS:
  • public/WebURLLoaderClient.h:
2:43 PM Changeset in webkit [68928] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitSite

2010-10-01 Alex Mathews <​possessedpenguinbob@gmail.com>

Reviewed by Simon Fraser.

Bug 47013 - Main Web Inspector link on webkit.org links to old wiki page
​https://bugs.webkit.org/show_bug.cgi?id=47013

  • nav.inc: Removed the space from the web inspector wiki link.
2:30 PM Changeset in webkit [68927] by Adam Roben
  • 2 edits
    1 copy in trunk/LayoutTests

Land post-XP results for fast/text/backslash-to-yen-sign-euc.html

The fonts this test uses must have changed after Windows XP

  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:

Copied from LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt.

  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:

Updated for post-XP.

2:25 PM Changeset in webkit [68926] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=47015

Reviewed by Sam Weinig.

Change FloatingObject to store its dimensions as a rect.
This will make it easier for logical access for block-flow later on if
top/bottom is no different from left/width. This change also simplifies
calling code a bit in places.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatBottomBelow):
(WebCore::RenderBlock::floatBottom):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::leftBottom):
(WebCore::RenderBlock::rightBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::left):
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::top):
(WebCore::RenderBlock::FloatingObject::bottom):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(WebCore::RenderBlock::FloatingObject::setLeft):
(WebCore::RenderBlock::FloatingObject::setTop):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::frameRect):
(WebCore::RenderBlock::FloatingObject::setFrameRect):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

2:18 PM Changeset in webkit [68925] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-10-01 Adam Barth <​abarth@webkit.org>

Add a Gtk-specific baseline for a WebSocket test.

  • platform/gtk/http/tests/websocket: Added.
  • platform/gtk/http/tests/websocket/tests: Added.
  • platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
2:07 PM Changeset in webkit [68924] by hclam@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Build fix. Not reviewed.

Add the dummy README file to solve build breakages in Chromium.
It should be removed once the breakage is resolved.

  • websocket/tests/workers/README: Added.
1:50 PM Changeset in webkit [68923] by enrica@apple.com
  • 7 edits in trunk

DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
​https://bugs.webkit.org/show_bug.cgi?id=42580
<rdar://problem/8107311>

Reviewed by Darin Adler.

WebCore:

This change removes the aliased type machinery from the Event class.
We now fire the event with the new name and the oldname.

Tests: Modified fast/events/focusinout.html to check the event
type.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Event.cpp: Removed aliasedType and hasAliasedType.
  • dom/Event.h: Removed aliasedType and hasAliasedType.
  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners): Removed aliasedType related code.

LayoutTests:

  • fast/events/focusinout.html: Modified to check the event type.
1:44 PM Changeset in webkit [68922] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Add makefile for TestWebKitAPI and call it from the base makefile.

Reviewed by Dan Bernstein.

  • Makefile:
  • TestWebKitAPI/Makefile: Added.
1:42 PM Changeset in webkit [68921] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Land new Windows results for fast/text/international/bidi-mirror-he-ar.html

Fixes <​http://webkit.org/b/47001> <rdar://problem/8503550>
fast/text/international/bidi-mirror-he-ar.html fails on Windows

Recommended by Dan Bernstein.

  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
1:29 PM Changeset in webkit [68920] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove check for InitLayoutCompleted on fixed_layout_size_set.
​https://bugs.webkit.org/show_bug.cgi?id=47006

This check isn't needed and isn't done on the other ports. The fixed
layout property can be set before we have the first layout.

  • ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set):
1:25 PM Changeset in webkit [68919] by weinig@apple.com
  • 3 edits
    2 deletes in trunk/WebKitTools

Remove unnecessary ForwardingHeaders from test runners.
​https://bugs.webkit.org/show_bug.cgi?id=47010

Reviewed by Adam Roben.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/ForwardingHeaders: Removed.
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/ForwardingHeaders: Removed.
1:05 PM Changeset in webkit [68918] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Call contents_resize when the main frame gets resized.
​https://bugs.webkit.org/show_bug.cgi?id=47004

The previous implementation was just calling contents_resize when the
viewport size had changed. That's not enough, and contents_resize
shouldn't be called if the contents size didn't change.

Now the contents_size_changed function is called directly from the
ChromeClientEfl.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::contentsSizeChanged):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (_ewk_view_smart_calculate): (ewk_view_fixed_layout_size_set): (ewk_view_contents_size_changed):
12:59 PM Changeset in webkit [68917] by hyatt@apple.com
  • 12 edits
    7 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block-flow. This patch changes
all of the computeReplacedLogicalWidth and comuteReplacedLogicalHeight functions (and their helpers) to use logical width
and logical height instead.

Reviewed by Darin Adler.

Added fast/blockflow/block-level-images.html

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
(WebCore::RenderReplaced::calcAspectRatioLogicalWidth):
(WebCore::RenderReplaced::calcAspectRatioLogicalHeight):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderReplaced.h:
  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

  • rendering/RenderSVGRoot.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedLogicalWidth):
(WebCore::RenderVideo::computeReplacedLogicalHeight):

  • rendering/RenderVideo.h:

LayoutTests:

  • fast/blockflow/block-level-images.html: Added.
  • fast/blockflow/resources: Added.
  • fast/blockflow/resources/circle.svg: Added.
  • fast/blockflow/resources/oval.png: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.png: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.txt: Added.
12:52 PM Changeset in webkit [68916] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-10-01 Nate Chapin <Nate Chapin>

Reviewed by Darin Adler.

Remove unused Request::buffer() and Request::m_buffer.

​https://bugs.webkit.org/show_bug.cgi?id=47003

  • loader/Request.h:
12:46 PM WebDevelopers edited by possessedpenguinbob@gmail.com
Minor update to Web Inspector link to avoid having to click through on … (diff)
12:40 PM Changeset in webkit [68915] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData
​https://bugs.webkit.org/show_bug.cgi?id=46937

This is a two-part patch--one to add the new methods with normalized
names that follow general WebKit convention, and a followup patch to
remove the original methods once Chromium is updated.

  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::hasFileNames): renamed to containsFilenames (WebKit::WebDragData::fileNames): renamed to filenames (WebKit::WebDragData::setFileNames): renamed to setFilenames (WebKit::WebDragData::appendToFileNames): renamed to appendToFilenames (WebKit::WebDragData::containsFilenames): (WebKit::WebDragData::filenames): (WebKit::WebDragData::setFilenames): (WebKit::WebDragData::appendToFilenames): (WebKit::WebDragData::fileContentFileName): renamed to fileContentFilename (WebKit::WebDragData::setFileContentFileName): renamed to setFileContentFilename (WebKit::WebDragData::fileContentFilename): (WebKit::WebDragData::setFileContentFilename):
12:40 PM Changeset in webkit [68914] by abarth@webkit.org
  • 57 edits
    1 move in trunk

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebSocket tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=46956

Hosting the WebSocket tests using the Python HTTP server causes the
tests to time out occationally. This patch moves the tests to be
hosted by the usual Apache server.

This patch doesn't completely eliminate the flakiness. However,
testing on my local machine shows that it reduces it by a large factor.
I suspect there's more flakiness hiding in the Python server, but this
patch makes some amount of progress on the issue.

  • http/tests/websocket: Copied from LayoutTests/websocket.
  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/close-on-unload.html:
  • http/tests/websocket/tests/cross-origin-expected.txt:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-overflow.html:
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/httponly-cookie.pl:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/reload-crash.html:
  • http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html:
  • http/tests/websocket/tests/resources/close-on-unload-iframe.html:
  • http/tests/websocket/tests/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post-function.js.
  • http/tests/websocket/tests/resources/js-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
  • http/tests/websocket/tests/resources/js-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
  • http/tests/websocket/tests/resources/reload-crash-iframe.html:
  • http/tests/websocket/tests/script-tests/TEMPLATE.html:
  • http/tests/websocket/tests/script-tests/cross-origin.js: (endTest):
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing-expected.txt:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/win/Skipped:
  • websocket: Removed.
  • websocket/resources: Removed.
  • websocket/resources/server-failed-to-start.html: Removed.
  • websocket/tests: Removed.
  • websocket/tests/alert-in-event-handler-expected.txt: Removed.
  • websocket/tests/alert-in-event-handler.html: Removed.
  • websocket/tests/bad-handshake-crash-expected.txt: Removed.
  • websocket/tests/bad-handshake-crash.html: Removed.
  • websocket/tests/bad-handshake-crash_wsh.py: Removed.
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-control-chars.html: Removed.
  • websocket/tests/bad-sub-protocol-empty-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-empty.html: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii.html: Removed.
  • websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
  • websocket/tests/bufferedAmount-after-close.html: Removed.
  • websocket/tests/close-on-navigate-new-location-expected.txt: Removed.
  • websocket/tests/close-on-navigate-new-location.html: Removed.
  • websocket/tests/close-on-unload-and-force-gc-expected.txt: Removed.
  • websocket/tests/close-on-unload-and-force-gc.html: Removed.
  • websocket/tests/close-on-unload-expected.txt: Removed.
  • websocket/tests/close-on-unload-reference-in-parent-expected.txt: Removed.
  • websocket/tests/close-on-unload-reference-in-parent.html: Removed.
  • websocket/tests/close-on-unload.html: Removed.
  • websocket/tests/close-on-unload_wsh.py: Removed.
  • websocket/tests/cross-origin-expected.txt: Removed.
  • websocket/tests/cross-origin.html: Removed.
  • websocket/tests/echo-challenge_wsh.py: Removed.
  • websocket/tests/echo-cookie_wsh.py: Removed.
  • websocket/tests/echo-location_wsh.py: Removed.
  • websocket/tests/echo_wsh.py: Removed.
  • websocket/tests/error-detect-expected.txt: Removed.
  • websocket/tests/error-detect.html: Removed.
  • websocket/tests/fixed-origin_wsh.py: Removed.
  • websocket/tests/frame-length-longer-than-buffer-expected.txt: Removed.
  • websocket/tests/frame-length-longer-than-buffer.html: Removed.
  • websocket/tests/frame-length-longer-than-buffer_wsh.py: Removed.
  • websocket/tests/frame-length-overflow-expected.txt: Removed.
  • websocket/tests/frame-length-overflow.html: Removed.
  • websocket/tests/frame-length-overflow_wsh.py: Removed.
  • websocket/tests/frame-length-skip-expected.txt: Removed.
  • websocket/tests/frame-length-skip.html: Removed.
  • websocket/tests/frame-length-skip_wsh.py: Removed.
  • websocket/tests/frame-lengths-expected.txt: Removed.
  • websocket/tests/frame-lengths.html: Removed.
  • websocket/tests/handler_map.txt: Removed.
  • websocket/tests/handshake-challenge-randomness-expected.txt: Removed.
  • websocket/tests/handshake-challenge-randomness.html: Removed.
  • websocket/tests/handshake-error-expected.txt: Removed.
  • websocket/tests/handshake-error.html: Removed.
  • websocket/tests/handshake-error_wsh.py: Removed.
  • websocket/tests/handshake-fail-by-cross-origin-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-cross-origin.html: Removed.
  • websocket/tests/handshake-fail-by-no-cr-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-no-cr.html: Removed.
  • websocket/tests/handshake-fail-by-no-cr_wsh.py: Removed.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Removed.
  • websocket/tests/httponly-cookie-expected.txt: Removed.
  • websocket/tests/httponly-cookie.pl: Removed.
  • websocket/tests/long-invalid-header-expected.txt: Removed.
  • websocket/tests/long-invalid-header.html: Removed.
  • websocket/tests/long-invalid-header_wsh.py: Removed.
  • websocket/tests/multiple-connections-expected.txt: Removed.
  • websocket/tests/multiple-connections.html: Removed.
  • websocket/tests/no-query_wsh.py: Removed.
  • websocket/tests/null-character-expected.txt: Removed.
  • websocket/tests/null-character.html: Removed.
  • websocket/tests/origin-test_wsh.py: Removed.
  • websocket/tests/protocol-test_wsh.py: Removed.
  • websocket/tests/reload-crash-expected.txt: Removed.
  • websocket/tests/reload-crash.html: Removed.
  • websocket/tests/resources: Removed.
  • websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Removed.
  • websocket/tests/resources/close-on-unload-iframe.html: Removed.
  • websocket/tests/resources/reload-crash-iframe.html: Removed.
  • websocket/tests/script-tests: Removed.
  • websocket/tests/script-tests/TEMPLATE.html: Removed.
  • websocket/tests/script-tests/alert-in-event-handler.js: Removed.
  • websocket/tests/script-tests/bad-handshake-crash.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
  • websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
  • websocket/tests/script-tests/cross-origin.js: Removed.
  • websocket/tests/script-tests/error-detect.js: Removed.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
  • websocket/tests/script-tests/frame-length-skip.js: Removed.
  • websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
  • websocket/tests/script-tests/handshake-error.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
  • websocket/tests/script-tests/long-invalid-header.js: Removed.
  • websocket/tests/script-tests/null-character.js: Removed.
  • websocket/tests/script-tests/send-throw.js: Removed.
  • websocket/tests/script-tests/send.js: Removed.
  • websocket/tests/script-tests/simple.js: Removed.
  • websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
  • websocket/tests/script-tests/sub-protocol.js: Removed.
  • websocket/tests/script-tests/unicode.js: Removed.
  • websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
  • websocket/tests/script-tests/url-parsing.js: Removed.
  • websocket/tests/script-tests/url-with-credential.js: Removed.
  • websocket/tests/script-tests/url-with-empty-query.js: Removed.
  • websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
  • websocket/tests/script-tests/url-with-query.js: Removed.
  • websocket/tests/script-tests/websocket-event-target.js: Removed.
  • websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
  • websocket/tests/send-after-close-on-unload-expected.txt: Removed.
  • websocket/tests/send-after-close-on-unload.html: Removed.
  • websocket/tests/send-expected.txt: Removed.
  • websocket/tests/send-throw-expected.txt: Removed.
  • websocket/tests/send-throw.html: Removed.
  • websocket/tests/send.html: Removed.
  • websocket/tests/send2_wsh.py: Removed.
  • websocket/tests/send_wsh.py: Removed.
  • websocket/tests/simple-expected.txt: Removed.
  • websocket/tests/simple-stress-expected.txt: Removed.
  • websocket/tests/simple-stress.html: Removed.
  • websocket/tests/simple.html: Removed.
  • websocket/tests/simple_wsh.py: Removed.
  • websocket/tests/sub-protocol-expected.txt: Removed.
  • websocket/tests/sub-protocol-with-space-expected.txt: Removed.
  • websocket/tests/sub-protocol-with-space.html: Removed.
  • websocket/tests/sub-protocol.html: Removed.
  • websocket/tests/unicode-expected.txt: Removed.
  • websocket/tests/unicode.html: Removed.
  • websocket/tests/unicode_wsh.py: Removed.
  • websocket/tests/unknown-frame-type_wsh.py: Removed.
  • websocket/tests/url-no-trailing-slash-expected.txt: Removed.
  • websocket/tests/url-no-trailing-slash.html: Removed.
  • websocket/tests/url-parsing-expected.txt: Removed.
  • websocket/tests/url-parsing.html: Removed.
  • websocket/tests/url-with-credential-expected.txt: Removed.
  • websocket/tests/url-with-credential.html: Removed.
  • websocket/tests/url-with-empty-query-expected.txt: Removed.
  • websocket/tests/url-with-empty-query.html: Removed.
  • websocket/tests/url-with-query-expected.txt: Removed.
  • websocket/tests/url-with-query-for-no-query-expected.txt: Removed.
  • websocket/tests/url-with-query-for-no-query.html: Removed.
  • websocket/tests/url-with-query.html: Removed.
  • websocket/tests/websocket-event-target-expected.txt: Removed.
  • websocket/tests/websocket-event-target.html: Removed.
  • websocket/tests/websocket-pending-activity-expected.txt: Removed.
  • websocket/tests/websocket-pending-activity.html: Removed.
  • websocket/tests/websocket-protocol-ignored-expected.txt: Removed.
  • websocket/tests/websocket-protocol-ignored.html: Removed.
  • websocket/tests/workers: Removed.
  • websocket/tests/workers/close-in-onmessage-crash-expected.txt: Removed.
  • websocket/tests/workers/close-in-onmessage-crash.html: Removed.
  • websocket/tests/workers/close-in-shared-worker-expected.txt: Removed.
  • websocket/tests/workers/close-in-shared-worker.html: Removed.
  • websocket/tests/workers/close-in-worker-expected.txt: Removed.
  • websocket/tests/workers/close-in-worker.html: Removed.
  • websocket/tests/workers/resources: Removed.
  • websocket/tests/workers/resources/close-in-onmessage-crash.js: Removed.
  • websocket/tests/workers/resources/close-in-worker.js: Removed.
  • websocket/tests/workers/resources/echo-challenge_wsh.py: Removed.
  • websocket/tests/workers/resources/echo_wsh.py: Removed.
  • websocket/tests/workers/resources/simple_wsh.py: Removed.
  • websocket/tests/workers/resources/worker-handshake-challenge-randomness.js: Removed.
  • websocket/tests/workers/resources/worker-simple.js: Removed.
  • websocket/tests/workers/shared-worker-simple-expected.txt: Removed.
  • websocket/tests/workers/shared-worker-simple.html: Removed.
  • websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt: Removed.
  • websocket/tests/workers/worker-handshake-challenge-randomness.html: Removed.
  • websocket/tests/workers/worker-simple-expected.txt: Removed.
  • websocket/tests/workers/worker-simple.html: Removed.

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebSocket tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=46956

Update these tools to understand how to run the WebSocket tests off the
Apache server.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:38 PM Changeset in webkit [68913] by Adam Roben
  • 2 edits in trunk/WebKitTools

Encode Executive command arguments using UTF-8 on Cygwin

Cygwin's Python's os.execv doesn't support unicode command arguments.
Cygwin's execv expects arguments to be encoded using the current code
page. But code pages are limited in what characters they can handle,
and our tests include characters that the English code page can't
handle. So for now we'll just encode everything in UTF-8 on Cygwin,
which can handle all characters but might confuse some commands, for
expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
good enough, but we can deal with that when the problem arises.

Reviewed by Adam Barth.

Fixes <​http://webkit.org/b/46892> <rdar://problem/8496639>
webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
fails on Windows

  • Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output):
(Executive.run_command):
On Cygwin, encode arguments using UTF-8.

12:25 PM Changeset in webkit [68912] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Adjust test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
12:16 PM Changeset in webkit [68911] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7563219> Null dereference when dragging an element with generated content
​https://bugs.webkit.org/show_bug.cgi?id=47005

Reviewed by Adele Peterson.

WebCore:

Test: fast/css-generated-content/drag-state.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::updateDragState): Null-check node().

LayoutTests:

  • fast/css-generated-content/drag-state-expected.txt: Added.
  • fast/css-generated-content/drag-state.html: Added.
12:07 PM Changeset in webkit [68910] by weinig@apple.com
  • 1 edit
    52 adds in trunk/WebKitTools

Add simple API tester for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=46953

Reviewed by Adam Roben.

This adds a very simple testing infrastructure for testing APIs exposed
through the WebKit project. It consists of two parts: 1) a project that
builds the all the tests 2) a script that searches the tests directory and
calls the tester once for each test.

This adds the infrastructure and two tests:

  • Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
  • Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.

This currently only works on the mac, but is designed to be easily ported
to any platform.

  • Scripts/run-api-tests: Added.
  • Scripts/build-api-tests: Added.

Scripts to build/run the tests.

  • TestWebKitAPI: Added.
  • TestWebKitAPI/Configurations: Added.
  • TestWebKitAPI/Configurations/Base.xcconfig: Added.
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
  • TestWebKitAPI/ForwardingHeaders: Added.
  • TestWebKitAPI/ForwardingHeaders/wtf: Added.
  • TestWebKitAPI/PlatformUtilities.h: Added.
  • TestWebKitAPI/PlatformWebView.h: Added.

(TestWebKitAPI::PlatformWebView::platformView):

  • TestWebKitAPI/StringFunctions.h: Added.
  • TestWebKitAPI/Test.h: Added.

(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
  • TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
  • TestWebKitAPI/TestsController.cpp: Added.

(TestWebKitAPI::TestsController::shared):
(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):

  • TestWebKitAPI/TestsController.h: Added.
  • TestWebKitAPI/mac: Added.
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.

(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::createURLForResource):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):

  • TestWebKitAPI/mac/main.mm: Added.

Infrastructure.

  • TestWebKitAPI/Tests: Added.
  • TestWebKitAPI/Tests/WTF: Added.
  • TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
  • TestWebKitAPI/Tests/WebKit2: Added.
  • TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.

(TestWebKitAPI::State::State):

  • TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.

Proof of concept tests.

12:03 PM Changeset in webkit [68909] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Change test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [68908] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove a test I just fixed from the Skipped file

  • platform/win/Skipped:
11:56 AM Changeset in webkit [68907] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't assume AccessibleObjectFromEvent succeeds

Fixes <​http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
DumpRenderTree!notificationListenerProc when running
plugins/access-after-page-destroyed.html

Reviewed by Sam Weinig.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(notificationListenerProc): Check both the return value of
AccessibleObjectFromEvent and the object it returns, as MSDN
recommends.

11:40 AM Changeset in webkit [68906] by robert@webkit.org
  • 4 edits in trunk

2010-10-01 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Fix http/tests/loading/redirect-methods.html

​https://bugs.webkit.org/show_bug.cgi?id=41571

Unskip http/tests/loading/redirect-methods.html

  • platform/qt/Skipped:

2010-10-01 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Fix http/tests/loading/redirect-methods.html

Document our redirection behaviour too.

​https://bugs.webkit.org/show_bug.cgi?id=41571

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
11:31 AM Changeset in webkit [68905] by Adam Roben
  • 3 edits in trunk/WebCore

Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj

WebCoreGenerated.vcproj runs on every build, while WebCore.vcproj only
runs when a .h or .cpp file changes. By moving the copying to
WebCoreGenerated, it will happen even when someone only changes a JS
file (as happened in r68887).

Fixes <​http://webkit.org/b/46988> <rdar://problem/8502489> REGRESSION
(r68887): Web Inspector: inspector/extensions*.html are failing on
Windows

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Moved invocation of

copyForwardingHeaders and copyInspectorFiles from here...

  • WebCore.vcproj/WebCoreGenerated.vcproj: ...to here.
11:25 AM Changeset in webkit [68904] by rniwa@webkit.org
  • 6 edits in trunk

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Implement queryCommandState('justifyFull')
​https://bugs.webkit.org/show_bug.cgi?id=46954

Implemented queryCommandState('justifyFull').
New tests are added to editing/style/inline-style-container.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getTextAlignment): Added support for CSSValueJustify.
  • editing/EditorCommand.cpp: (WebCore::stateJustifyFull): Added. (WebCore::createCommandMap): Added stateJustifyFull.

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Implement queryCommandState('justifyFull')
​https://bugs.webkit.org/show_bug.cgi?id=46954

Added tests for queryCommandState('justifyFull') to editing/execCommand/query-text-alignment.html

  • editing/execCommand/query-text-alignment-expected.txt:
  • editing/execCommand/script-tests/query-text-alignment.js: (queryTextAlignment): (runRangeTests):
11:17 AM Changeset in webkit [68903] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

2010-10-01 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Tony Chang.

[NRWT] Put the http and websocket tests first in the test list.
​https://bugs.webkit.org/show_bug.cgi?id=46453

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:11 AM Changeset in webkit [68902] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection shouldn't prompt the same correction after user has edited previous correction.
​https://bugs.webkit.org/show_bug.cgi?id=46839
<rdar://problem/8476963>

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of "Replacement" marker. Since the former controls whether we draw autocorrection underline, and the latter is used to prevent autocorrection from being applied again on already auto- corrected word. So the "Replacement" shouldn't be removed.
11:05 AM Changeset in webkit [68901] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Anders Carlsson.

[CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
​https://bugs.webkit.org/show_bug.cgi?id=46309

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
10:55 AM Changeset in webkit [68900] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the bottom of the block to
be block-flow-aware.

Reviewed by Darin Adler.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):

10:50 AM Changeset in webkit [68899] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • bytecompiler/BytecodeGenerator.h:
  • wtf/FastMalloc.cpp:

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • css/CSSStyleSelector.h:
  • rendering/InlineIterator.h:
  • rendering/style/RenderStyle.h:
10:46 AM Changeset in webkit [68898] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
​https://bugs.webkit.org/show_bug.cgi?id=46992

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::copyCString):
Helper function for allocating a string using NPN_MemAlloc.

(WebKit::NPN_GetValueForURL):
Ask the plug-in for either the proxy or the cookies given an URL.

(WebKit::NPN_SetValueForURL):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

Tell the plug-in to set the cookies for the given URL.

(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
Call the corresponding PluginController functions.

  • WebProcess/Plugins/PluginController.h:

Add new pure virtual member functions.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
Add stubbed out implementations of the new PluginController functions.

  • WebProcess/Plugins/PluginView.h:
10:43 AM Changeset in webkit [68897] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the viewport from the root element.

Reviewed by Dan Bernstein.

WebCore:

Added fast/css/rtl-to-viewport.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/css/rtl-to-viewport.html: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.txt: Added.
10:29 AM Changeset in webkit [68896] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=44406
<rdar://problem/8310921> Application Cache crash when a fallback document has a manifest URL

Test: http/tests/appcache/foreign-fallback.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Changed ApplicationCacheResource lookup to find fallback resources correctly.
10:20 AM Changeset in webkit [68895] by kseo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed, Brew MP build fix.

  • platform/brew/ClipboardBrew.cpp:

(WebCore::ClipboardBrew::ClipboardBrew):

10:01 AM Changeset in webkit [68894] by fsamuel@chromium.org
  • 2 edits in trunk/WebKitTools

Updated stuff.

9:54 AM Changeset in webkit [68893] by kseo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed.

[BREWMP] Change Collector BLOCK_SIZE to 64KB
​https://bugs.webkit.org/show_bug.cgi?id=46436

Lower BLOCK_SIZE to 64KB because Brew MP runs on low end devices.

  • runtime/Collector.h:
9:32 AM Changeset in webkit [68892] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[CMAKE] Build fix for r68878
​https://bugs.webkit.org/show_bug.cgi?id=46985

Fix name of files added to CMakeLists.txt:
SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp

No features added, so no new tests.

  • CMakeLists.txt:
9:16 AM Changeset in webkit [68891] by Adam Roben
  • 9 edits
    3 adds in trunk

Implement NPN_GetValue(NPNVnetscapeWindow)

Fixes <​http://webkit.org/b/46726> <rdar://problem/8486319>
Right-clicking on windowless Flash plugin in WebKit2 makes a context
menu appear in the bottom-right corner of the screen

Test: platform/win/plugins/get-value-netscape-window.html

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue): Added case for NPNVnetscapeWindow that calls
through to NetscapePlugin::containingWindow.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Added containingWindow

on Windows.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow): Added. Calls through to
the PluginController.
(WebKit::NetscapePlugin::platformPostInitialize): Changed to use
containingWindow.

WebKitTools:

Test NPN_GetValue(NPNVnetscapeWindow)

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_GetValue): Added. Calls through to the browser.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
  • DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.

(GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
(GetValueNetscapeWindow::NPP_SetWindow): Test that
NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
isn't our HWND.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added GetValueNetscapeWindow.

LayoutTests:

Support for testing NPN_GetValue(NPNVnetscapeWindow)

  • platform/win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/win/plugins/get-value-netscape-window.html: Added.
7:56 AM Changeset in webkit [68890] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-01 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt] Stack overflow on symbian platform.
​https://bugs.webkit.org/show_bug.cgi?id=40598

Move big allocation in arrayProtoFuncToString from stack to heap.
JSC::arrayProtoFuncToString function can be called recursivly and
1K allocation on stack cahse stack overflow.
Can be useful for other platforms with limited stack size.

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
6:52 AM Changeset in webkit [68889] by andreas.kling@nokia.com
  • 4 edits
    2 moves in trunk/WebCore

2010-10-01 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] New buttons style for Qt Mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=46920

Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
Adjust new Qt mobile style for buttons, radios, checks and combos.

  • WebCore.pro:
  • css/themeQtMobile.css: Adjust gradient color for buttons and combos. (select): (select:active):
  • platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme. (QtMobileWebStyle::QtMobileWebStyle): (drawRectangularControlBackground): (QtMobileWebStyle::drawChecker): (QtMobileWebStyle::findChecker): (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton. (QtMobileWebStyle::findRadio): (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox. (QtMobileWebStyle::drawMultipleComboButton): (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow. (QtMobileWebStyle::getButtonImageSize): (QtMobileWebStyle::findComboButton): (QtMobileWebStyle::drawComplexControl):
  • platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt):
6:49 AM Changeset in webkit [68888] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Add expected Windows results for scrollbars/custom-scrollbar-with-incomplete-style.html

This test was added in r66372 without any expected results.

  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
6:43 AM Changeset in webkit [68887] by caseq@chromium.org
  • 8 edits in trunk

2010-10-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
​https://bugs.webkit.org/show_bug.cgi?id=45954

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype): (WebInspector.injectedExtensionAPI.Resources.prototype.getPageTimings):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onGetPageTimings):
  • inspector/front-end/HAREntry.js: Return page event timings as -1 if start or event time unknown. (WebInspector.HARLog.prototype._buildPages): (WebInspector.HARLog.prototype.buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource): (WebInspector.HARLog.prototype._pageEventTime):

2010-10-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
​https://bugs.webkit.org/show_bug.cgi?id=45954

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
6:37 AM Changeset in webkit [68886] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove the fixed test from the Skipped file, too

  • platform/win/Skipped:
6:35 AM Changeset in webkit [68885] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove bogus Windows results for clip-path-referencing-use2.svg

Fixes <​http://webkit.org/b/46919> <rdar://problem/8497626> REGRESSION?
(r65617?): svg/custom/clip-path-referencing-use2.svg fails on Windows

Rubber-stamped by Nikolas Zimmermann.

  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
6:30 AM Changeset in webkit [68884] by Adam Roben
  • 4 edits in trunk/LayoutTests

Make regression tests pass on machines with 16-bit displays

I made these tests require 24-bit displays in r68808 and r68809,
thinking that we didn't have any testers that had 16-bit displays. But
apparently I was wrong; at least one Windows tester has a 16-bit
display.

Fixes <​http://webkit.org/b/46980>
fast/media/color-does-not-include-alpha.html failing on Windows

Reviewed by Nikolas Zimmermann.

  • fast/dom/Window/window-screen-properties-expected.txt: Updated

results.

  • fast/dom/Window/window-screen-properties.html: Changed to allow

either 16 or 24 bits.

  • fast/media/color-does-not-include-alpha.html: Changed to allow

either 5 or 8 bits per channel.

6:09 AM Changeset in webkit [68883] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add GDIExtras
​https://bugs.webkit.org/show_bug.cgi?id=46974

Some, but not all WinCE environments have support for AlphaBlend().
Add this files to check for AlphaBlend (and SoftLink) on WinCE.
On WinNT alphaBlendIfSupported() inlines AlphaBlend and returns true.

  • platform/graphics/win/GDIExtras.cpp: Added. (WebCore::AlphaBlendPointer):
  • platform/graphics/win/GDIExtras.h: Added. (WebCore::hasAlphaBlendSupport): (WebCore::alphaBlendIfSupported):
6:04 AM Changeset in webkit [68882] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Use alphaBlendIfSupported in GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=46979

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):
5:58 AM Changeset in webkit [68881] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rolling out r68633, because we don't need Qt specific expected results any more.

  • platform/qt/canvas: Removed.
  • platform/qt/canvas/philip: Removed.
  • platform/qt/canvas/philip/tests: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
5:24 AM Changeset in webkit [68880] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-10-01 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed, adding my webkit.org identity to reviewer list.

  • Scripts/webkitpy/common/config/committers.py:
5:03 AM Changeset in webkit [68879] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

  • platform/win/Skipped:
4:38 AM Changeset in webkit [68878] by Nikolas Zimmermann
  • 8 edits
    4 adds in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add two new helper files for the new SVGTextLayoutEngine
​https://bugs.webkit.org/show_bug.cgi?id=46972

Refactor code from SVGTextLayoutUtilities into two seperated classes.
SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.

Doesn't affect any functionality yet, as the new classes are not used so far.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/SVGTextFragment.h:
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added. (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
  • rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added. (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing): (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning): (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • rendering/svg/SVGTextLayoutEngineSpacing.h: Added.
3:50 AM Changeset in webkit [68877] by morrita@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2010-10-01 MORITA Hajime <​morrita@google.com>

Unreviewed, added a expectation.

  • platform/chromium-mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:45 AM Changeset in webkit [68876] by Nikolas Zimmermann
  • 9 edits
    2 moves in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
​https://bugs.webkit.org/show_bug.cgi?id=46971

Doesn't affect any functionality, just moves files around.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Adopt to renaming.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
  • rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
  • rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
  • rendering/svg/SVGTextLayoutBuilder.h: Removed.
3:41 AM Changeset in webkit [68875] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-10-01 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia):
3:19 AM Changeset in webkit [68874] by Nikolas Zimmermann
  • 9 edits
    18 moves in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Move SVG text related renderers into rendering/svg/
​https://bugs.webkit.org/show_bug.cgi?id=46969

Doesn't affect any functionality, just moves files around.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSVGAllInOne.cpp:
  • rendering/RenderSVGInline.cpp: Removed.
  • rendering/RenderSVGInline.h: Removed.
  • rendering/RenderSVGInlineText.cpp: Removed.
  • rendering/RenderSVGInlineText.h: Removed.
  • rendering/RenderSVGTSpan.cpp: Removed.
  • rendering/RenderSVGTSpan.h: Removed.
  • rendering/RenderSVGText.cpp: Removed.
  • rendering/RenderSVGText.h: Removed.
  • rendering/RenderSVGTextPath.cpp: Removed.
  • rendering/RenderSVGTextPath.h: Removed.
  • rendering/SVGInlineFlowBox.cpp: Removed.
  • rendering/SVGInlineFlowBox.h: Removed.
  • rendering/SVGInlineTextBox.cpp: Removed.
  • rendering/SVGInlineTextBox.h: Removed.
  • rendering/SVGRootInlineBox.cpp: Removed.
  • rendering/SVGRootInlineBox.h: Removed.
  • rendering/SVGTextQuery.cpp: Removed.
  • rendering/SVGTextQuery.h: Removed.
  • rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
  • rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
  • rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
  • rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
  • rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
  • rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
  • rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
  • rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
  • rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
  • rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
  • rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
  • rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
  • rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
  • rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
  • rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
  • rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
  • rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
  • rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.
2:11 AM Changeset in webkit [68873] by Nikolas Zimmermann
  • 8 edits
    5 adds in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
​https://bugs.webkit.org/show_bug.cgi?id=46964

The new SVG text layout engine will use these new classes.
1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.


-> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object

describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).

-> In "range of characters" mode, it returns the width/height of the range, and its length.

All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.

2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.

It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)

In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
be performed as SVGTextFragment contains all necessary information to render text / select text etc.

3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).

Quotes from SVG spec:
Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:

  • Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
  • Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
  • Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.

An absolute position adjustment occurs in the following circumstances:

  • At the start of a <text> element
  • At the start of each <textPath> element
  • For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly

After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
(eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).

SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.

Doesn't affect any tests, as these classes aren't used so far.

  • Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/svg/SVGTextChunk.cpp: Added.
  • rendering/svg/SVGTextChunk.h: Added.
  • rendering/svg/SVGTextFragment.h: Added.
  • rendering/svg/SVGTextMetrics.cpp: Added.
  • rendering/svg/SVGTextMetrics.h: Added.
1:21 AM Changeset in webkit [68872] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/media/color-does-not-include-alpha.html fails
​https://bugs.webkit.org/show_bug.cgi?id=46966

  • platform/qt/Skipped: fast/media/color-does-not-include-alpha.html added until fix.
1:06 AM Changeset in webkit [68871] by jochen@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-10-01 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add an identifier method to WebFrame. The identifier can be used to identify
a given frame of a view over time. Using a pointer to the WebFrame object is fragile,
since a new frame might have been allocated at the same address as an old, deleted frame.
​https://bugs.webkit.org/show_bug.cgi?id=46884

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::generateFrameIdentifier): (WebKit::WebFrameImpl::identifier): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
12:52 AM Changeset in webkit [68870] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/navigation/ping-same-origin.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=46961

This test fails by forgetting to print out the REQUEST_METHOD:

​http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68727%20(18470)/http/tests/navigation/ping-same-origin-pretty-diff.html

The only way this makes sense is if the file isn't finished writing by
the time it gets read. This can happen because the reader is polling
the file for existence (!) to decide whether to read it.

This patch writes to a temporary location and then moves the finished
bytes into the well-known location atomically. I haven't verified that
it fixes the flakiness, but it seems like a good bet.

  • http/tests/navigation/resources/save-ping.php:
12:32 AM Changeset in webkit [68869] by jam@chromium.org
  • 10 edits in trunk/WebKit/chromium

2010-09-29 John Abd-El-Malek <​jam@chromium.org>

Reviewed by NOBODY (OOPS!).

[chromium] Changes to consolidate plugin zoom
​https://bugs.webkit.org/show_bug.cgi?id=46550

  • public/WebPlugin.h: (WebKit::WebPlugin::setZoomLevel):
  • public/WebPluginContainer.h:
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::zoomLimitsChanged): (WebKit::WebViewClient::zoomLevelChanged):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): (WebKit::WebPluginContainerImpl::zoomChanged): (WebKit::WebPluginContainerImpl::zoomLimitsChanged):
  • src/WebPluginContainerImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::zoomLevel): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImpl::zoomLimitsChanged): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebView::zoomFactorToZoomLevel):
  • src/WebViewImpl.h:
12:28 AM Changeset in webkit [68868] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-10-01 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

REGRESSION: Lots of fast canvas updates fail to completely render
​https://bugs.webkit.org/show_bug.cgi?id=46319

  • fast/repaint/canvas-putImageData-expected.txt: Added.
  • fast/repaint/canvas-putImageData.html: Added.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2010-10-01 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

REGRESSION: Lots of fast canvas updates fail to completely render
​https://bugs.webkit.org/show_bug.cgi?id=46319

Test: fast/repaint/canvas-putImageData.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::putImageData):
12:16 AM Changeset in webkit [68867] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add helper methods to cast between renderers & SVGTextContent/PositioningElement
​https://bugs.webkit.org/show_bug.cgi?id=46963

Doesn't affect any tests.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::elementFromRenderer):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::elementFromRenderer):
  • svg/SVGTextPositioningElement.h:
Note: See TracTimeline for information about the timeline view.