Timeline
Oct 7, 2010:
- 11:36 PM Changeset in webkit [69380] by
-
- 2 edits in trunk/WebCore
2010-10-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Kent Tamura.
[chromium] Fix indentation in ChromiumDataObject.h
https://bugs.webkit.org/show_bug.cgi?id=47396
Just a cleanup patch to make followup diffs smaller.
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::copy): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
- 11:08 PM Changeset in webkit [69379] by
-
- 3 edits in trunk/LayoutTests
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Rebaseline failing GTK+ tests.
- platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
- platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
- 10:47 PM Changeset in webkit [69378] by
-
- 23 edits in trunk/WebCore
2010-10-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Move valueAsDate and valueAsNumber implementations
https://bugs.webkit.org/show_bug.cgi?id=47327
Move the content of HTMLInputElement::valueAsDate(), setValueAsDate(),
valueAsNumber(), and setValueAsNumber() to InputType, and move
serialize() and serializeForDateTimeTypes() too
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::valueAsDate): (WebCore::BaseDateAndTimeInputType::setValueAsDate): (WebCore::BaseDateAndTimeInputType::valueAsNumber): (WebCore::BaseDateAndTimeInputType::setValueAsNumber): (WebCore::BaseDateAndTimeInputType::serialize):
- html/BaseDateAndTimeInputType.h:
- html/DateInputType.cpp: (WebCore::DateInputType::setMillisecondToDateComponents):
- html/DateInputType.h:
- html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::setMillisecondToDateComponents):
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::valueAsDate): (WebCore::DateTimeLocalInputType::setValueAsDate): (WebCore::DateTimeLocalInputType::setMillisecondToDateComponents):
- html/DateTimeLocalInputType.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::stepUpFromRenderer):
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::InputType::valueAsDate): (WebCore::InputType::setValueAsDate): (WebCore::InputType::valueAsNumber): (WebCore::InputType::setValueAsNumber): (WebCore::InputType::serialize):
- html/InputType.h:
- html/MonthInputType.cpp: (WebCore::MonthInputType::valueAsDate): (WebCore::MonthInputType::setValueAsDate): (WebCore::MonthInputType::setMillisecondToDateComponents):
- html/MonthInputType.h:
- html/NumberInputType.cpp: (WebCore::NumberInputType::valueAsNumber): (WebCore::NumberInputType::setValueAsNumber): (WebCore::NumberInputType::serialize):
- html/NumberInputType.h:
- html/RangeInputType.cpp: (WebCore::RangeInputType::valueAsNumber): (WebCore::RangeInputType::setValueAsNumber): (WebCore::RangeInputType::serialize):
- html/RangeInputType.h:
- html/TimeInputType.cpp: (WebCore::TimeInputType::setMillisecondToDateComponents):
- html/TimeInputType.h:
- html/WeekInputType.cpp: (WebCore::WeekInputType::setMillisecondToDateComponents):
- html/WeekInputType.h:
- 10:36 PM Changeset in webkit [69377] by
-
- 2 edits in trunk/LayoutTests
2010-10-07 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Add recent failures.
- 9:43 PM Changeset in webkit [69376] by
-
- 4 edits in trunk/WebKit/efl
2010-10-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Implement pageRect() function
https://bugs.webkit.org/show_bug.cgi?id=47395
Implement pageRect() in ChromeClientEfl using frameRect().
- CMakeListsEfl.txt:
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::pageRect):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (ewk_view_page_rect_get): Added.
- 9:43 PM Changeset in webkit [69375] by
-
- 2 edits in trunk/LayoutTests
2010-10-07 Zhenyao Mo <zmo@google.com>
Unreviewerd, update DRT WebGL test expectations.
- platform/chromium/drt_expectations.txt
- 9:31 PM Changeset in webkit [69374] by
-
- 1 edit6 adds in trunk/WebCore
2010-10-07 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Texmap] [Qt] Texture mapper initial implementation
Texture Mapper is an implementation of accelerated compositing that doesn't require a
platform specific scenegraph library like CA or QGraphicsView. The idea is that with
time this would replace GraphicsLayerQt, and could serve as an implementation for other
platforms that don't have a scenegraph library. The first stage of this is to add all the code to trunk,
and enable it in Qt with an opt-in build flag so that it can be easily tested. Once it reaches
an adequate level of stability, we can enable it by default and eventually have it replace GraphicsLayerQt.
This change includes only the common new files and the Qt backend; Still to come: the GL backend and integration layer.
- platform/graphics/qt/TextureMapperQt.cpp: Added.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: Added.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added.
- platform/graphics/texmap/TextureMapper.h: Added.
- platform/graphics/texmap/TextureMapperPlatformLayer.h: Added.
- 8:53 PM Changeset in webkit [69373] by
-
- 12 edits in trunk
[Mac] [DRT] implement setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=47291
Patch by Antonio Gomes <agomes@rim.com> on 2010-10-07
Reviewed by Simon Fraser.
WebCore:
Added Settings::setSpatialNavigationEnabled symbols to WebKit.exp.in
so it can be used from WebKit/mac.
- WebCore.exp.in:
WebKit/mac:
Added the needed bits to make it possible to enabled spatial navigation
for the Mac port. For now it is being only used by DRT.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences isSpatialNavigationEnabled]):
(-[WebPreferences setSpatialNavigationEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
WebKitTools:
Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
so it can track regression on the existing implementation and future improvements
we are making.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setSpatialNavigationEnabled):
LayoutTests:
Unskiping all spatial-navigation tests in fast/events/spatial-navigation but two
(snav-iframe-with-offscreen-focusable-element.html and snav-unit-overflow-and-scroll-in-direction.html).
These will be fixed on their own bugs.
- platform/mac/Skipped:
- 8:16 PM Changeset in webkit [69372] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-07 David Goodwin <david_goodwin@apple.com>
Reviewed by Oliver Hunt.
ARM JIT generates undefined operations due to partially uninitialized ShiftTypeAndAmount
https://bugs.webkit.org/show_bug.cgi?id=47356
- assembler/ARMv7Assembler.h:
- 7:31 PM Changeset in webkit [69371] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-07 Zhenyao Mo <zmo@google.com>
Unreviewed, roll chromium to r61902.
- DEPS
- 7:03 PM Changeset in webkit [69370] by
-
- 2 edits in trunk/WebCore
2010-10-07 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li
[V8] Add FileWriter to active DOM map
https://bugs.webkit.org/show_bug.cgi?id=47380
It's an ActiveDOMObject; it needs to be in the map.
- bindings/scripts/CodeGeneratorV8.pm:
- 6:51 PM Changeset in webkit [69369] by
-
- 3 edits in trunk/WebCore
2010-10-07 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47387
This ports r57741 to ThemeChromiumMac. It also reverts r66975, which is
now no longer necessary.
Should be covered by existing tests. The checkbox at
http://webkit.org/blog-files/3d-transforms/morphing-cubes.html should
now show up correctly.
- platform/chromium/ThemeChromiumMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): Create current context.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContents): Remove LocalCurrentContext, it's now no longer necessary.
- 6:44 PM Changeset in webkit [69368] by
-
- 2 edits in trunk/LayoutTests
2010-10-07 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Skipping failing test on qt because of incorrect behavior.
https://bugs.webkit.org/show_bug.cgi?id=47388
- platform/qt/Skipped:
- 6:18 PM Changeset in webkit [69367] by
-
- 2 edits in trunk/LayoutTests
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Very small reorganization of the GTK+ skipped list.
- platform/gtk/Skipped: Moved to the formdata skipped line to the beginDragWithFiles section.
- 6:00 PM Changeset in webkit [69366] by
-
- 2 edits21 moves in trunk/LayoutTests
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Move GTK+ specific baselines to the platform-specific directories. In my
last commit I mistakenly added these to the platform-independent locations.
Also fix another baseline which seems to differ on the bots because they
have a different version of DejaVu Serif than my machine.
- platform/gtk/fast/blockflow/block-level-images-expected.txt: Renamed from LayoutTests/fast/blockflow/block-level-images-expected.txt.
- platform/gtk/fast/blockflow/fieldsets-expected.txt: Renamed from LayoutTests/fast/blockflow/fieldsets-expected.txt.
- platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt: Renamed from LayoutTests/fast/blockflow/floats-in-block-layout-expected.txt.
- platform/gtk/fast/blockflow/inline-direction-positioning-expected.txt: Renamed from LayoutTests/fast/blockflow/inline-direction-positioning-expected.txt.
- platform/gtk/fast/blockflow/margin-collapse-expected.txt: Renamed from LayoutTests/fast/blockflow/margin-collapse-expected.txt.
- platform/gtk/fast/blockflow/root-lr-basic-expected.txt: Renamed from LayoutTests/fast/blockflow/root-lr-basic-expected.txt.
- platform/gtk/fast/blockflow/self-collapsing-block-expected.txt: Renamed from LayoutTests/fast/blockflow/self-collapsing-block-expected.txt.
- platform/gtk/fast/css/first-letter-punctuation-expected.txt: Renamed from LayoutTests/fast/css/first-letter-punctuation-expected.txt.
- platform/gtk/fast/css/font-face-opentype-expected.txt: Renamed from LayoutTests/fast/css/font-face-opentype-expected.txt.
- platform/gtk/fast/css/rtl-to-viewport-expected.txt: Renamed from LayoutTests/fast/css/rtl-to-viewport-expected.txt.
- platform/gtk/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/fast/css/transformed-mask-expected.txt.
- platform/gtk/fast/fonts/fontconfig-synthetic-bold-exepcted.txt: Updated baseline.
- platform/gtk/fast/forms/input-button-sizes-expected.txt: Renamed from LayoutTests/fast/forms/input-button-sizes-expected.txt.
- platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt: Renamed from LayoutTests/fast/forms/input-placeholder-focus-twice-expected.txt.
- platform/gtk/inspector/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
- platform/gtk/svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/svg/custom/image-rescale-expected.txt.
- platform/gtk/svg/custom/text-rotation-expected.txt: Renamed from LayoutTests/svg/custom/text-rotation-expected.txt.
- platform/gtk/svg/custom/text-x-dy-lists-expected.txt: Renamed from LayoutTests/svg/custom/text-x-dy-lists-expected.txt.
- platform/gtk/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/svg/custom/use-invalid-style-expected.txt.
- platform/gtk/svg/filters/filterRes1-expected.txt: Renamed from LayoutTests/svg/filters/filterRes1-expected.txt.
- platform/gtk/svg/filters/filterRes2-expected.txt: Renamed from LayoutTests/svg/filters/filterRes2-expected.txt.
- platform/gtk/svg/filters/filterRes3-expected.txt: Renamed from LayoutTests/svg/filters/filterRes3-expected.txt.
- 5:54 PM Changeset in webkit [69365] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-07 Zhenyao Mo <zmo@google.com>
Reviewed by Tony Chang.
Copy mesa lib into DumpRenderTree bundle in Mac
https://bugs.webkit.org/show_bug.cgi?id=47385
- WebKit.gyp:
- 5:49 PM Changeset in webkit [69364] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Skip the new test in those unsupported platforms.
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 5:48 PM Changeset in webkit [69363] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-10-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
rebaseline-chromium-webkit-tests relied on the filename_to_uri()
hook in the Port infrastructure to generate URIs for the files
in its summary HTML report; however, that method is supposed to only
be used for test files (and should really be renamed), so this would
crash.
This change adds a new "path" module to the system package with a
routine called abspath_to_uri() that handles converting paths to
file: URIs independently of anything in the layout_tests package,
and changes the code to use this. At some point in the near future
the layout_tests/port/* code should use this as well.
This change also deletes a bunch of unused code and fixes some
comments in rebaseline_chromium_webkit_tests.py.
- Scripts/webkitpy/common/system/path.py: Added.
- Scripts/webkitpy/common/system/path_unittest.py: Added.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- 5:47 PM Changeset in webkit [69362] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-10-07 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921
- fast/html/object-image-nested-fallback-expected.txt: Added.
- fast/html/object-image-nested-fallback.html: Added.
- 5:41 PM Changeset in webkit [69361] by
-
- 3 edits in trunk/WebKit/mac
Fix the Leopard 64-bit build.
- Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
framework search path.
- WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
- 5:35 PM Changeset in webkit [69360] by
-
- 3 edits2 adds in trunk
2010-10-07 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Postpone clearing the imageLoader when rendering certain fallback content for objects until after the attach().
https://bugs.webkit.org/show_bug.cgi?id=46921
Test: fast/html/object-image-nested-fallback.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
2010-10-07 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921
- accessibility/plugin.html:
- fast/html/object-image-nested-fallback-expected.txt: Added.
- fast/html/object-image-nested-fallback.html: Added.
- 5:31 PM Changeset in webkit [69359] by
-
- 1 edit60 adds in trunk/LayoutTests
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Add some GTK+ specific baselines.
- fast/blockflow/block-level-images-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/block-level-images-expected.txt.
- fast/blockflow/fieldsets-expected.txt: Added.
- fast/blockflow/floats-in-block-layout-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.txt.
- fast/blockflow/inline-direction-positioning-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.txt.
- fast/blockflow/margin-collapse-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.txt.
- fast/blockflow/root-lr-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.txt.
- fast/blockflow/self-collapsing-block-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.txt.
- fast/css/first-letter-punctuation-expected.txt: Added.
- fast/css/font-face-opentype-expected.txt: Added.
- fast/css/rtl-to-viewport-expected.txt: Added.
- fast/css/transformed-mask-expected.txt: Added.
- fast/forms/input-button-sizes-expected.txt: Added.
- fast/forms/input-placeholder-focus-twice-expected.txt: Added.
- inspector/console-uncaught-exception-expected.txt: Added.
- platform/gtk/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/gtk/fast/blockflow/block-level-images-expected.png: Added.
- platform/gtk/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/gtk/fast/blockflow/fieldsets-expected.png: Added.
- platform/gtk/fast/blockflow/floats-in-block-layout-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.checksum.
- platform/gtk/fast/blockflow/floats-in-block-layout-expected.png: Added.
- platform/gtk/fast/blockflow/inline-direction-positioning-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum.
- platform/gtk/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/gtk/fast/blockflow/margin-collapse-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.checksum.
- platform/gtk/fast/blockflow/margin-collapse-expected.png: Added.
- platform/gtk/fast/blockflow/root-lr-basic-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.checksum.
- platform/gtk/fast/blockflow/root-lr-basic-expected.png: Added.
- platform/gtk/fast/blockflow/self-collapsing-block-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.checksum.
- platform/gtk/fast/blockflow/self-collapsing-block-expected.png: Added.
- platform/gtk/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/gtk/fast/css/first-letter-punctuation-expected.png: Added.
- platform/gtk/fast/css/font-face-opentype-expected.checksum: Added.
- platform/gtk/fast/css/font-face-opentype-expected.png: Added.
- platform/gtk/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/gtk/fast/css/rtl-to-viewport-expected.png: Added.
- platform/gtk/fast/css/transformed-mask-expected.checksum: Added.
- platform/gtk/fast/css/transformed-mask-expected.png: Added.
- platform/gtk/fast/forms/input-button-sizes-expected.checksum: Added.
- platform/gtk/fast/forms/input-button-sizes-expected.png: Added.
- platform/gtk/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/gtk/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/gtk/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
- platform/gtk/svg/custom/image-rescale-expected.png: Added.
- platform/gtk/svg/custom/text-rotation-expected.checksum: Added.
- platform/gtk/svg/custom/text-rotation-expected.png: Added.
- platform/gtk/svg/custom/text-x-dy-lists-expected.checksum: Added.
- platform/gtk/svg/custom/text-x-dy-lists-expected.png: Added.
- platform/gtk/svg/filters/filterRes1-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes1-expected.checksum.
- platform/gtk/svg/filters/filterRes1-expected.png: Added.
- platform/gtk/svg/filters/filterRes2-expected.checksum: Added.
- platform/gtk/svg/filters/filterRes2-expected.png: Added.
- platform/gtk/svg/filters/filterRes3-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes3-expected.checksum.
- platform/gtk/svg/filters/filterRes3-expected.png: Added.
- svg/custom/image-rescale-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.txt.
- svg/custom/text-rotation-expected.txt: Added.
- svg/custom/text-x-dy-lists-expected.txt: Added.
- svg/custom/use-invalid-style-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-invalid-style-expected.txt.
- svg/filters/filterRes1-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes1-expected.txt.
- svg/filters/filterRes2-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes2-expected.txt.
- svg/filters/filterRes3-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes3-expected.txt.
- 5:28 PM Changeset in webkit [69358] by
-
- 2 edits in trunk/WebCore
2010-10-07 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix shared timers on EFL port - make them thread safe.
https://bugs.webkit.org/show_bug.cgi?id=47383
Using ecore_timer_add to create a timer from a thread that is
not the main thread isn't safe. Now we add a pipe that is used
to request a timer to be added in the main thread.
In order to reduce some delay on timers that are added with a
very small interval, the timer callback is called immediately
if the interval is smaller than the mainloop frame time.
No new features, so no tests added.
- platform/efl/SharedTimerEfl.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::timerEvent): (WebCore::processTimers): (WebCore::pipeHandlerCb): (WebCore::stopSharedTimer): (WebCore::addNewTimer): (WebCore::setSharedTimerFireTime):
- 5:16 PM Changeset in webkit [69357] by
-
- 3 edits2 adds in trunk
2010-10-07 James Kozianski <koz@chromium.org>
Reviewed by Adam Barth.
getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949
CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().
- fast/dom/css-shorthand-common-value-expected.txt: Added.
- fast/dom/css-shorthand-common-value.html: Added.
2010-10-07 James Kozianski <koz@chromium.org>
Reviewed by Adam Barth.
getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949
Test: fast/dom/css-shorthand-common-value.html
CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getCommonValue):
- 5:07 PM Changeset in webkit [69356] by
-
- 3 edits in trunk/WebKit2
<rdar://problem/8349882> Many WebProcess sandbox violations during basic browsing operations.
Patch by Ivan Krstić <ike@apple.com> on 2010-10-07
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb:
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- 4:57 PM Changeset in webkit [69355] by
-
- 4 edits in trunk
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
Fix a baseline that was merged improperly.
- platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Fix baseline.
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
Fix my latest commit, as it contained some bad changes from a merge gone wrong.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Also initialize the DevaVu Sans font.
- 4:55 PM Changeset in webkit [69354] by
-
- 9 edits4 adds in trunk
2010-10-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233
The bug was caused by our not splitting text nodes properly.
In new approach, we split text nodes in each iteration. Added rangeForParagraphSplitingTextNodesIfNeeded
to split text nodes at the start and at the end of paragraph, which also adjusts start and end positions
for moveParagraphWithClones. Added endOfNextParagrahSplittingTextNodesIfNeeded to adjust endOfNextParagraph,
start, and end to work-around moveParagraphWithClones's removing a line feed.
Tests: editing/execCommand/indent-pre-list.html
editing/execCommand/indent-pre-paragraphs.html
- editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): See above. (WebCore::isNewLineAtPosition): (WebCore::renderStyleOfEnclosingTextNode): Added. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Added. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Added.
- editing/ApplyBlockElementCommand.h:
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Takes two Positions instead of one VisiblePosition.
- editing/FormatBlockCommand.h:
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Ditto. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Ditto. (WebCore::IndentOutdentCommand::formatRange): Ditto.
- editing/IndentOutdentCommand.h:
2010-10-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233
Added tests to ensure WebKit indents texts inside pre correctly.
- editing/execCommand/indent-pre-expected.txt: This test passes if WebKit does not crash.
- editing/execCommand/indent-pre-list-expected.txt: Added.
- editing/execCommand/indent-pre-list.html: Added.
- editing/execCommand/indent-pre-paragraphs-expected.txt: Added.
- editing/execCommand/indent-pre-paragraphs.html: Added.
- 4:45 PM Changeset in webkit [69353] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Build fix.
Reflecting move of autocorrection tests made in r69351.
- platform/chromium/test_expectations.txt:
- 4:38 PM Changeset in webkit [69352] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Build fix.
The breakage of r69334 fast/css/transformed-mask.svg
- platform/chromium/test_expectations.txt:
- 4:32 PM Changeset in webkit [69351] by
-
- 5 edits4 adds4 deletes in trunk/LayoutTests
Autocorrection panel regression tests fail on Windows
https://bugs.webkit.org/show_bug.cgi?id=47341
<rdar://problem/8523631>
Patch by Jia Pu <jpu@apple.com> on 2010-10-07
Reviewed by Adele Peterson.
Move Mac specific tests to platform/mac directory.
- editing/spelling/autocorrection-delete.html: Removed.
- editing/spelling/autocorrection-removing-underline-after-paste.html: Removed.
- editing/spelling/autocorrection-removing-underline.html: Removed.
- editing/spelling/autocorrection-simple.html: Removed.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/editing/spelling/autocorrection-delete.html: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline.html: Added.
- platform/mac/editing/spelling/autocorrection-simple.html: Added.
- 4:31 PM Changeset in webkit [69350] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] http/tests/local/formdata/send-form-data-constructed-from-form.html
introduced in r69349, but eventSender.beginDragWithFiles is unimplemented.
- platform/qt/Skipped: http/tests/local/formdata/send-form-data-constructed-from-form.html added.
- 3:57 PM Changeset in webkit [69349] by
-
- 7 edits3 adds in trunk
Support generating a FormData object based on the data in an existing <form>.
https://bugs.webkit.org/show_bug.cgi?id=45929
Reviewed by Adam Barth.
WebCore:
Test: http/tests/local/formdata/send-form-data-constructed-from-form.html
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
- html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData):
- html/DOMFormData.h:
(WebCore::DOMFormData::create):
- html/DOMFormData.idl:
LayoutTests:
Add a new test to test this functionality.
- http/tests/local/formdata/resources/test.txt: Copied from LayoutTests/fast/files/resources/UTF8.txt.
- http/tests/local/formdata/send-form-data-constructed-from-form-expected.txt: Added.
- http/tests/local/formdata/send-form-data-constructed-from-form.html: Added.
- 3:51 PM Changeset in webkit [69348] by
-
- 3 edits in trunk/WebKit2
Build fix.
GCC continued to mask the fact that I still hadn't declared the correct symbol.
- Platform/Logging.cpp:
(initializeLogChannel):
- Platform/Logging.h:
- 3:36 PM Changeset in webkit [69347] by
-
- 2 edits in trunk/WebKit2
Build Fix. Fix the vcproj to make it valid and openable by Visual Studio.
- win/WebKit2.vcproj:
- 3:04 PM Changeset in webkit [69346] by
-
- 7 edits in trunk
2010-10-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227
Chromium no longer uses the deprecated methods, so delete them.
- DEPS:
- public/WebDragData.h:
- src/WebDragData.cpp:
2010-10-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227
Update DRT to use the renamed methods.
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
- DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
- 3:00 PM Changeset in webkit [69345] by
-
- 4 edits2 adds in trunk
2010-10-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Set the m_selectedChildren flag on the root inline box if one of the leaf
inline box from the bidi runs walk has a selection state. Remove the flag
setting logic from addToLine, since line boxes created in createLinesBoxes
should not be propagating selection state to root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201
Test: editing/selection/root-inlinebox-selected-children-crash.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine):
2010-10-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we don't crash while setting selected children on the root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201
- editing/selection/root-inlinebox-selected-children-crash-expected.txt: Added.
- editing/selection/root-inlinebox-selected-children-crash.html: Added.
- 2:51 PM Changeset in webkit [69344] by
-
- 2 edits in trunk/WebCore
2010-10-07 Benjamin Otte <otte@gnome.org>
Reviewed by Martin Robinson.
[GTK] Code cleanup in PluginViewGtk.cpp for transparent plugins
https://bugs.webkit.org/show_bug.cgi?id=47361
Reduce some code in PluginViewGtk.cpp by doing things with Cairo instead
of directly with X11. This should work fine with GDK double-buffering, but
if we ever disable it, we'll need to verify that this is still functioning
properly.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): Do a bit of code cleanup.
- 2:49 PM Changeset in webkit [69343] by
-
- 17 edits3 copies2 adds in trunk
Add a WKPageFindClient, hook up WKPageCountStringMatches
https://bugs.webkit.org/show_bug.cgi?id=47373
Reviewed by Sam Weinig.
WebCore:
Export find related symbols needed by WebKit2.
- WebCore.exp.in:
WebKit2:
- Shared/APIClient.h: Added.
Add an APIClient class template which can be used to reduce duplicated
code in the client wrappers.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFindClient):
Initialize the page find client.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebFindClient.cpp: Added.
(WebKit::WebFindClient::didCountStringMatches):
Call the WKPageFindClient function.
- UIProcess/WebFindClient.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeFindClient):
Initialize the WebFindClient.
(WebKit::WebPageProxy::findString):
Send a FindString message.
(WebKit::WebPageProxy::hideFindUI):
Send a HideFindUI message.
(WebKit::WebPageProxy::countStringMatches):
Send a CountStringMatches message.
(WebKit::WebPageProxy::didCountStringMatches):
Call the find client.
- UIProcess/WebPageProxy.messages.in:
Add new message.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findString):
(WebKit::WebPage::hideFindUI):
Add stubs.
(WebKit::WebPage::countStringMatches):
Figure out the number of matches and send them back in the DidCountStringMatches msessage.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Add new messages.
- win/WebKit2.vcproj:
Add new files.
WebKitTools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Remove hard coded paths.
- TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
(TestWebKitAPI::TEST):
Fix expected result.
- TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didCountStringMatches):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/find.html: Added.
Add test for WKPageCountStringMatches.
- 2:21 PM Changeset in webkit [69342] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Build fix.
r69334 broke Chromium rendering of fast/css/transformed-mask.svg.
- platform/chromium/test_expectations.txt:
- 2:16 PM Changeset in webkit [69341] by
-
- 7 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47370
Reviewed by Sam Weinig.
Make line box placement in the inline direction writing-mode-aware. Lines now set their y-position instead of x-position
when vertical.
Refactored shadow overflow to give text-shadow the same helpers in RenderStyle that box-shadow has so that the shadow-walking loop in
placeBoxesInInlineDirection can be replaced with the helper.
Overflow had to be patched to be writing-mode-aware so that the correct physical directions would be set for vertical line
boxes.
Vertical lines are still not testable until they can be placed in the block direction. Then the render tree dumps
become meaningful (even if the pixel results look horrible).
- rendering/InlineBox.h:
(WebCore::InlineBox::logicalRight):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):
- 2:16 PM Changeset in webkit [69340] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-10-07 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, updating test expectations for chromium.
- platform/chromium-win/fast/filesystem: Removed.
- platform/chromium-win/fast/filesystem/async-operations-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:10 PM Changeset in webkit [69339] by
-
- 1 edit25 adds in trunk/LayoutTests
2010-10-07 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add layout tests for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44920
Added tests for major Entry operations: copyTo, moveTo, getFile,
getDirectory, remove, createReader.readEntries, getParent.
- fast/filesystem/op-copy-expected.txt: Added.
- fast/filesystem/op-copy.html: Added.
- fast/filesystem/op-get-entry-expected.txt: Added.
- fast/filesystem/op-get-entry.html: Added.
- fast/filesystem/op-get-parent-expected.txt: Added.
- fast/filesystem/op-get-parent.html: Added.
- fast/filesystem/op-move-expected.txt: Added.
- fast/filesystem/op-move.html: Added.
- fast/filesystem/op-read-directory-expected.txt: Added.
- fast/filesystem/op-read-directory.html: Added.
- fast/filesystem/op-remove-expected.txt: Added.
- fast/filesystem/op-remove.html: Added.
- fast/filesystem/op-restricted-chars-expected.txt: Added.
- fast/filesystem/op-restricted-chars.html: Added.
- fast/filesystem/op-restricted-names-expected.txt: Added.
- fast/filesystem/op-restricted-names.html: Added.
- fast/filesystem/resources/fs-test-util.js:
- fast/filesystem/resources/op-copy.js: Added.
- fast/filesystem/resources/op-get-entry.js: Added.
- fast/filesystem/resources/op-get-parent.js: Added.
- fast/filesystem/resources/op-move.js: Added.
- fast/filesystem/resources/op-read-directory.js: Added.
- fast/filesystem/resources/op-remove.js: Added.
- fast/filesystem/resources/op-restricted-chars.js: Added.
- fast/filesystem/resources/op-restricted-names.js: Added.
- fast/filesystem/resources/op-tests-helper.js: Added.
- 2:06 PM Changeset in webkit [69338] by
-
- 2 edits in trunk/WebCore
2010-10-07 Simon Fraser <Simon Fraser>
Reviewed by Beth Dakin.
Use isIdentityOrTranslationOrFlipped() in scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=47378
Replace old code that looked at values in the CGAffineTransform
with nicely named method that does the same test.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- 2:03 PM Changeset in webkit [69337] by
-
- 2 edits2 adds in trunk/LayoutTests
[Chromium] Unreviewed. Build fix. New baseline.
- platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:59 PM Changeset in webkit [69336] by
-
- 2 edits in trunk/WebCore
<rdar://problem/8142645> REGRESSION (r47440): Printing Mail messages with large fonts does not fill page
https://bugs.webkit.org/show_bug.cgi?id=47374
Reviewed by Simon Fraser.
In the legacy (paint-time pagination) printing model, when there are overlapping lines,
adjustPageHeightDeprecated() was not idempotent, since the truncation point imposed by line n,
namely the top of line n, was above the bottom of line n-1, so in the next round, line n-1
moved the truncation point up again.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint): Consider the top of the next line when deciding if the
current line extends below the truncation point.
- 1:51 PM Changeset in webkit [69335] by
-
- 2 edits in trunk/WebKit2
Update unit tests results.
- Scripts/webkit2/messages_unittest.py:
- 1:48 PM Changeset in webkit [69334] by
-
- 3 edits4 adds in trunk
2010-10-07 Simon Fraser <Simon Fraser>
Reviewed by Beth Dakin.
Edge fringe artifact with transformed, masked elements (including reflections)
https://bugs.webkit.org/show_bug.cgi?id=19179
When drawing the mask images, use a transparency layer if the CTM
has a rotation, scale or skew in it to avoid antialiasing issues at
the edges.
Test: fast/css/transformed-mask.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): Don't bother painting the mask if painting is disabled, which also avoids an assertion in getCTM(). (WebCore::RenderBox::paintMaskImages):
- 12:59 PM Changeset in webkit [69333] by
-
- 2 edits in trunk/WebKit2
- Platform/Logging.cpp:
(initializeLogChannel): GCC optimized out the only caller of this function. Windows doesn't, and is breaking.
Reviewed by BUILD FIX for non-gcc builds.
- 12:46 PM Changeset in webkit [69332] by
-
- 3 edits5 adds in trunk/LayoutTests
[Chromium] Unreviewed. New baselines, and expectations updates.
Changing fast/frames/cached-frame-counter.html to SKIP for DEBUG
platforms since it always times out.
Upstreamed expectation:
http/tests/misc/last-modified-parsing.html
Removed expecations for these as they pass consistently:
svg/batik/text/textProperties.svg
fast/dom/Window/window-screen-properties.html
fast/media/color-does-not-include-alpha.html
fast/events/mouse-focus-imagemap.html
fast/dom/object-embed-plugin-scripting.html
fast/images/imagemap-case.html
Marked as flaky:
svg/hixie/perf/001.xml
svg/hixie/perf/002.xml
svg/W3C-SVG-1.1/animate-elem-03-t.svg
New test missing baseline:
platform/gtk/fonts/fontconfig-synthetic-bold.html
- platform/chromium-mac/fast/images/imagemap-case-expected.checksum: Added.
- platform/chromium-mac/fast/images/imagemap-case-expected.png: Added.
- platform/chromium-win/fast/filesystem/async-operations-expected.txt: Added.
- platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
- platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
- platform/chromium/test_expectations.txt:
- 12:41 PM Changeset in webkit [69331] by
-
- 4 edits in trunk/WebKit/qt
2010-10-07 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] API: ViewportConfiguration => ViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=47325
- Api/qwebpage.cpp: (QWebPage::ViewportAttributes::ViewportAttributes): (QWebPage::ViewportAttributes::~ViewportAttributes): (QWebPage::ViewportAttributes::operator=): (QWebPage::viewportAttributesForSize):
- Api/qwebpage.h:
- Api/qwebpage_p.h: (QtViewportAttributesPrivate::QtViewportAttributesPrivate):
- 12:35 PM Changeset in webkit [69330] by
-
- 2 edits in trunk/WebKit2
Fix include mistake that makes build fail with non-Objective-C.
- Shared/API/c/mac/WKCertificateInfoMac.h: Include CoreFoundation.h,
not Foundation.h.
- 12:32 PM Changeset in webkit [69329] by
-
- 27 edits1 copy1 add in trunk/WebKit2
Generate the messages sent to the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=47239
Patch by Sam Weinig <sam@webkit.org> on 2010-10-07
Reviewed by Anders Carlsson.
- DerivedSources.make:
- DerivedSources.pro:
- Platform/CoreIPC/Arguments.h:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
- Scripts/webkit2/messages.py:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.
- Shared/StringPairVector.h: Added.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::registerEditCommand):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::registerEditCommand):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::registerEditCommand):
- UIProcess/win/WebView.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
- win/WebKit2.vcproj:
- 12:29 PM Changeset in webkit [69328] by
-
- 2 edits in trunk/WebCore
2010-10-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Map non-alphabet key code to Unicode value
https://bugs.webkit.org/show_bug.cgi?id=46002
Non-alphabet key codes are not equal to the unicode values. Add conversion.
- platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::singleCharacterString):
- 12:06 PM Changeset in webkit [69327] by
-
- 2 edits in trunk/WebKit2
Forgot this to keep the build working.
Reviewed by BUILD FIX.
- WebKit2Prefix.h:
- 11:39 AM Changeset in webkit [69326] by
-
- 5 edits2 adds in trunk
2010-09-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
Added tests for this issue.
- platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
- platform/gtk/fonts/fontconfig-synthetic-bold.html: Added.
2010-10-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
Look for the FC_EMBOLDEN property of the FcPattern when constructing
FontPlatformData and use it to enable synthetic bold fonts when necessary.
Test: platform/gtk/fonts/fontconfig-synthetic-bold.html
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Properly handle the FC_EMBOLDEN property.
2010-09-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
- DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN for DejaVu Serif when there is no bold version available. This is necessary to properly test the property in layout tests.
- 11:19 AM Changeset in webkit [69325] by
-
- 6 edits1 add in trunk/WebKit2
Start stubbing out the find API
https://bugs.webkit.org/show_bug.cgi?id=47366
<rdar://problem/8524998>
Reviewed by John Sullivan.
- Shared/FindOptions.h: Added.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toFindDirection):
(WebKit::toFindOptions):
- UIProcess/API/C/WKPage.cpp:
(WKPageFindString):
(WKPageHideFindUI):
(WKPageCountStringMatches):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::hideFindUI):
(WebKit::WebPageProxy::countStringMatches):
- UIProcess/WebPageProxy.h:
- 11:09 AM Changeset in webkit [69324] by
-
- 7 edits3 adds1 delete in trunk
[Qt] Build files for the WTR's InjectedBundle
- 11:00 AM Changeset in webkit [69323] by
-
- 4 edits2 adds in trunk/WebKit2
Part of https://bugs.webkit.org/show_bug.cgi?id=47354 - Add WebCore/WebKit1 style logging channel mechanism0 to WebKit2,
including the first channel to be used for SessionState work.
Reviewed by Sam Weinig.
- Platform/Logging.cpp: Added.
(initializeLogChannelsIfNecessary):
- Platform/Logging.h: Added.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 10:56 AM Changeset in webkit [69322] by
-
- 6 edits1 add in trunk
2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363
Forgot to add the new files (Requested by kbalazs on #webkit).
- DerivedSources.pro:
2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363
Forgot to add the new files (Requested by kbalazs on #webkit).
- Scripts/webkitdirs.pm:
- WebKitTestRunner/qt/DerivedSources.pro: Added.
2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363
Forgot to add the new files (Requested by kbalazs on #webkit).
- WebKit2.pro:
- 10:56 AM Changeset in webkit [69321] by
-
- 2 edits in trunk/WebCore
2010-10-07 James Simonsen <simonjam@chromium.org>
Reviewed by Pavel Feldman.
[Web Timing] Use platform definition of responseEnd
https://bugs.webkit.org/show_bug.cgi?id=46306
No new tests. Used existing webtiming test.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didFinishLoading):
- 10:46 AM Changeset in webkit [69320] by
-
- 4 edits4 adds in trunk
2010-10-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299
Added a test to test the FontConfig synthetic oblique behavior.
- platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum: Added.
- platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png: Added.
- platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt: Added.
- platform/gtk/fonts/fontconfig-synthetic-oblique.html: Added.
2010-10-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299
Properly interpret the FC_MATRIX property from a FontConfig pattern.
FontConfig will use this property when returning fonts which have a
synthetic oblique variant configured in the fonts.conf configuration
file.
Test: platform/gtk/fonts/fontconfig-synthetic-oblique.html
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Added a constructor that takes an existing FontPlatformData and a font size. (WebCore::FontPlatformData::initializeWithFontFace): Added this helper intialization method that properly handles the FC_MATRIX property from the FcPattern.
- platform/graphics/cairo/FontPlatformDataFreeType.h: Added a declaration to the new constructor and the initializeWithFontFace.
- platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData): Use the new FontPlatformData constructor.
- 10:40 AM Changeset in webkit [69319] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47357
Reviewed by Dan Bernstein.
Make findNextLineBreak and some of the helper functions it also calls writing-mode-aware.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::getBorderPaddingMargin):
(WebCore::inlineLogicalWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::inlineFlowRequiresLineBox):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::RenderBoxModelObject::hasInlineDirectionBordersOrPadding):
- 10:39 AM Changeset in webkit [69318] by
-
- 3 edits in trunk/WebKit/mac
2010-10-06 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Screensaver starts while watching fullscreen playback.
https://bugs.webkit.org/show_bug.cgi?id=47299
<rdar://problem/8478956>
To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
- WebView/WebVideoFullscreenController.h: Added _tickleTimer.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer. (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity(). (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
or _disableTickleTimer.
- 10:32 AM Changeset in webkit [69317] by
-
- 14 edits1 add in trunk/WebKitTools
Change API tester to ask the executable for the list of all
tests instead of relying on the directory structure.
https://bugs.webkit.org/show_bug.cgi?id=47359
Reviewed by Anders Carlsson.
- Scripts/run-test-webkit-api: Added.
- Scripts/webkitdirs.pm:
Add additional script to just launch the api tester with the correct settings.
- Scripts/run-api-tests:
Change to use the new --dump-tests options to build the list of tests and change
output to reflect a (suite, testcase) tuple for each test. Also adds some color.
- TestWebKitAPI/Test.h:
(TestWebKitAPI::Test::Register::Register):
- TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WKString.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
(TestWebKitAPI::TEST):
Give each test a suite name in addition to the test name.
- TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
- TestWebKitAPI/TestsController.h:
- TestWebKitAPI/mac/main.mm:
(main):
Add option to print all registered tests.
- 10:26 AM Changeset in webkit [69316] by
-
- 7 edits in trunk
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330
user-scalable attribute was not considered in viewport meta tag handling.
- dom/ViewportArguments.cpp: (WebCore::findConfigurationForViewportData):
- dom/ViewportArguments.h:
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330
user-scalable attribute was not considered in viewport meta tag handling.
- Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330
user-scalable attribute was not considered in viewport meta tag handling.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
- 10:12 AM Changeset in webkit [69315] by
-
- 6 edits1 delete in trunk
[Qt] Build files for the WTR's InjectedBundle
- 9:58 AM Changeset in webkit [69314] by
-
- 14 edits5 adds in trunk/LayoutTests
Unreviewed. Chromium build fix.
Add new baselines for svg/hixie/perf/001.xml and
svg/hixie/perf/002.xml. After r69305, which removed the rendering
timestamp from the image, these tests are now more deterministic.
- platform/chromium-linux/svg/hixie/perf/001-expected.checksum:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.txt:
- platform/chromium-linux/svg/hixie/perf/002-expected.checksum:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.txt:
- platform/chromium-mac/svg/hixie/perf/001-expected.checksum: Added.
- platform/chromium-mac/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-mac/svg/hixie/perf/002-expected.checksum: Added.
- platform/chromium-mac/svg/hixie/perf/002-expected.png: Added.
- platform/chromium-win/svg/hixie/perf/001-expected.checksum:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.txt:
- platform/chromium-win/svg/hixie/perf/002-expected.checksum:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:23 AM Changeset in webkit [69313] by
-
- 5 edits1 copy1 add in trunk
[Qt] Hook up accelerometer data via Qt DeviceMotion
https://bugs.webkit.org/show_bug.cgi?id=47105
Reviewed by Andreas Kling.
Get accelerometer necessary data via Qt mobility library using a
provider class. Enable, also the RotationRate using the current device
orientation provider.
WebCore:
- WebCore.pro:
WebKit/qt:
- WebCoreSupport/DeviceMotionClientQt.cpp:
(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
(WebCore::DeviceMotionClientQt::changeDeviceMotion):
- WebCoreSupport/DeviceMotionClientQt.h:
- WebCoreSupport/DeviceMotionProviderQt.cpp: Added.
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):
- WebCoreSupport/DeviceMotionProviderQt.h: Added.
(WebCore::DeviceMotionProviderQt::currentDeviceMotion):
- 9:05 AM QtWebKitWeeklyBuilds edited by
- typo fix (diff)
- 8:37 AM Changeset in webkit [69312] by
-
- 8 edits in trunk
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334
WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.
- dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
- dom/ViewportArguments.h:
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334
WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.
- Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334
WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
- 8:08 AM Changeset in webkit [69311] by
-
- 4 edits2 copies in trunk/WebKit/chromium
2010-10-07 Dave Moore <davemoore@chromium.org>
Reviewed by Kent Tamura.
Add WebThemeEngine api for chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=47278
Create new linux specific version of WinThemeEngine.h and move
existing windows specific one to win directory. Keep old top
level file until chromium is updated to use the new ones.
- WebKit.gyp:
- public/WebThemeEngine.h:
- src/ChromiumBridge.cpp:
- 8:04 AM Changeset in webkit [69310] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47336
Fix and re-freeze symbols for symbian - viewportConfigurationForSize
API changed, allowGeolocationRequest removed from API, several
DumpRenderTree support calls added.
Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2010-10-07
Reviewed by Simon Hausmann.
- symbian/eabi/QtWebKitu.def:
- 7:56 AM Changeset in webkit [69309] by
-
- 5 edits in trunk/WebKit2
Bundle should expose a reportException method.
https://bugs.webkit.org/show_bug.cgi?id=46769
Reviewed by John Sullivan.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleReportException):
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::reportException):
Mimic the behavior of WebView::reportException.
- WebProcess/InjectedBundle/InjectedBundle.h:
- 7:56 AM Changeset in webkit [69308] by
-
- 2 edits in trunk/WebKitTools
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed. Do a renaming that was recommended by the reviewer
(Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
- WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::RunUntilConditionLoop): (WTR::TestController::runUntil):
- 7:44 AM Changeset in webkit [69307] by
-
- 2 edits2 adds in trunk/WebKitTools
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Watchdog timer implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47337
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out the definition of the timer type to a typedef.
- WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added. Timer implementation with QTimer and a helper QObject class. (WTR::WatchdogTimerHelper::instance): (WTR::WatchdogTimerHelper::timerFired): (WTR::WatchdogTimerHelper::WatchdogTimerHelper): (WTR::LayoutTestController::platformInitialize): (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer): (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
- 7:36 AM Changeset in webkit [69306] by
-
- 2 edits in trunk
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349
- WebKit.pro:
- 6:20 AM Changeset in webkit [69305] by
-
- 31 edits24 adds in trunk/LayoutTests
2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Reenable several skipped SVG tests on leopard & snow leopard
https://bugs.webkit.org/show_bug.cgi?id=47340
Following tests can be unskipped, as they work as expected.
On SnowLeopard:
svg/batik/paints/patternRegionA.svg
svg/custom/path-bad-data.svg
svg/custom/pattern-deep-referencing.svg
svg/hixie/perf/007.xml
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg
On Leopard:
svg/filters/filter-empty-g.svg
On both:
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/coords-trans-01-b.svg
svg/css/glyph-orientation-rounding-test.xhtml (not 100% sure about this one, I don't see any rounding problems, we may have to disable it again, if the problem shows up on the bots)
svg/custom/tiling-regular-hexagonal-crash.svg (test needs some fixes though to make sense)
svg/hixie/perf/001.xml (test needs a fix, so it doesn't dump the elapsed time)
svg/hixie/perf/002.xml (ditto)
svg/batik/text/smallFonts.svg (still not correct, but doesn't crash or hang)
- platform/mac-leopard/Skipped:
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
- platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum: Added.
- platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
- platform/mac-leopard/svg/batik/text/smallFonts-expected.checksum: Added.
- platform/mac-leopard/svg/batik/text/smallFonts-expected.png: Added.
- platform/mac-leopard/svg/custom/path-bad-data-expected.checksum: Added.
- platform/mac-leopard/svg/custom/path-bad-data-expected.png: Added.
- platform/mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
- platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.checksum: Added.
- platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.png: Added.
- platform/mac-leopard/svg/hixie/perf: Added.
- platform/mac-leopard/svg/hixie/perf/001-expected.checksum: Added.
- platform/mac-leopard/svg/hixie/perf/001-expected.png: Added.
- platform/mac-leopard/svg/hixie/perf/002-expected.checksum: Added.
- platform/mac-leopard/svg/hixie/perf/002-expected.png: Added.
- platform/mac-leopard/svg/hixie/perf/007-expected.checksum: Added.
- platform/mac-leopard/svg/hixie/perf/007-expected.png: Added.
- platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
- platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
- platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/mac-snowleopard/Skipped:
- platform/mac/Skipped:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- platform/mac/svg/batik/text/smallFonts-expected.checksum: Added.
- platform/mac/svg/batik/text/smallFonts-expected.png: Added.
- platform/mac/svg/batik/text/smallFonts-expected.txt:
- platform/mac/svg/custom/path-bad-data-expected.checksum:
- platform/mac/svg/custom/path-bad-data-expected.png:
- platform/mac/svg/custom/path-bad-data-expected.txt:
- platform/mac/svg/custom/pattern-deep-referencing-expected.checksum:
- platform/mac/svg/custom/pattern-deep-referencing-expected.png:
- platform/mac/svg/hixie/perf/001-expected.checksum:
- platform/mac/svg/hixie/perf/001-expected.png:
- platform/mac/svg/hixie/perf/001-expected.txt:
- platform/mac/svg/hixie/perf/002-expected.checksum:
- platform/mac/svg/hixie/perf/002-expected.png:
- platform/mac/svg/hixie/perf/002-expected.txt:
- platform/mac/svg/hixie/perf/007-expected.checksum:
- platform/mac/svg/hixie/perf/007-expected.png:
- platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
- platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
- platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- svg/custom/tiling-regular-hexagonal-crash.svg: Make the test actually show up the pattern.
- svg/hixie/perf/001.xml: Don't dump elapsed times, otherwhise results will be inconsistent. Add DRT waitUntilDone/notifyDone logic.
- svg/hixie/perf/002.xml: Ditto.
- 6:11 AM Changeset in webkit [69304] by
-
- 3 edits2 adds in trunk/WebKit2
2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Adam Roben.
[Qt] Webkit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47167
There were two problems when building Qt WebKit2 in Mac. The first was that
ld does not support flag -whole-archive and it needed to be replaced by flag -all_load.
The second problem was that APPLE is been used to identify safari builds and, when
building Qt in MacOS, Qt was ending up using the wrong typedef. The solution was to use
a Qt specific WKNativeEvent.h that only has the proper Qt typedef instead of the original one.
- UIProcess/API/C/qt/WKNativeEvent.h: Added.
- WebKit2.pri:
- WebKit2.pro:
- 6:01 AM Changeset in webkit [69303] by
-
- 2 edits in trunk/WebKitTools
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed buildfix for 69297 again
- WebKitTestRunner/TestController.cpp: (WTR::blankURL):
- 5:57 AM Changeset in webkit [69302] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use draw instead of expose_event in WebView when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47338
- webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw): (webkit_web_view_class_init):
- 5:44 AM Changeset in webkit [69301] by
-
- 5 edits in trunk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090
GtkObject has been removed in gtk3.
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_dispose):
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090
GtkObject has been removed in gtk3.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands):
- WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud):
- 5:42 AM Changeset in webkit [69300] by
-
- 9 edits in trunk/WebCore
2010-10-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: highlight XHR breakpoint when hit.
https://bugs.webkit.org/show_bug.cgi?id=47253
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::findEventListenerBreakpoint): (WebCore::InspectorController::findXHRBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved): (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend): (WebInspector.BreakpointManager.prototype._removeNativeBreakpointFromBackend): (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.BreakpointManager.prototype.debuggerResumed): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype.get enabled): (WebInspector.NativeBreakpoint.prototype.set enabled): (WebInspector.NativeBreakpoint.prototype.remove):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.BreakpointItem.prototype._hitStateChanged):
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus):
- inspector/front-end/inspector.css: (.breakpoint-list .breakpoint-hit):
- inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.resumedScript):
- 5:34 AM Changeset in webkit [69299] by
-
- 2 edits in trunk/WebKitTools
Unreviewed build fix for r69297
- 5:31 AM Changeset in webkit [69298] by
-
- 2 edits in trunk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Bump required gtk+-3 version to 2.91.0
- configure.ac:
- 5:30 AM QtWebKitDocContrib edited by
- (diff)
- 5:23 AM Changeset in webkit [69297] by
-
- 6 edits in trunk
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393
Use only the WebKit API for working with urls.
- WebKitTestRunner/StringFunctions.h: (WTR::createWKURL):
- WebKitTestRunner/TestController.cpp: (WTR::blankURL): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame):
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393
Introducing additional URL API.
- Shared/API/c/WKURL.cpp: (WKURLCreateWithUTF8CString): (WKURLIsEqual):
- Shared/API/c/WKURL.h:
- 5:20 AM Changeset in webkit [69296] by
-
- 5 edits in trunk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_new):
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3
- webkit/webkitwebview.cpp: (webkit_web_view_realize):
- 5:03 AM Changeset in webkit [69295] by
-
- 3 edits in trunk/WebKit/chromium
2010-10-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec
https://bugs.webkit.org/show_bug.cgi?id=47329
- public/WebResourceRawHeaders.h: (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator =):
- src/WebResourceRawHeaders.cpp: (WebKit::WebResourceRawHeaders::initialize): (WebKit::WebResourceRawHeaders::reset): (WebKit::WebResourceRawHeaders::assign):
- 4:58 AM Changeset in webkit [69294] by
-
- 2 edits in trunk/WebKitTools
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47332
- DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView):
- 4:46 AM Changeset in webkit [69293] by
-
- 7 edits in trunk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.
- platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
- platform/gtk/GtkVersioning.h:
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.
- tests/testcopyandpaste.c: (runPasteTestCallback):
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
- 4:42 AM Changeset in webkit [69292] by
-
- 155 edits157 adds in trunk/LayoutTests
2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
Finalize SVG pixel test baseline updates. We should have a clean baseline now for Leopard & Snow Leopard, that passes with --tolerance 0 (at least on my 10.5 & 10.6 systems).
- platform/mac-leopard/svg/batik/masking: Added.
- platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Added.
...
- 4:38 AM Changeset in webkit [69291] by
-
- 2 edits in trunk/WebCore
[Qt] Disconnect signals before destroying MediaPlayerPrivateQt
Reviewed by Andreas Kling.
https://bugs.webkit.org/show_bug.cgi?id=47073
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
- 4:34 AM Changeset in webkit [69290] by
-
- 3 edits in trunk/WebKit/gtk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use draw signal instead of expose_event in DragClientGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47326
- WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowDrawCallback): (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag): (WebKit::DragClient::dragIconWindowDraw):
- WebCoreSupport/DragClientGtk.h:
- 4:17 AM Changeset in webkit [69289] by
-
- 2 edits in trunk
[Qt] Re-enable the web inspector for maemo6 builds
Rubber-stamped by Tor Arne Vestbø.
Yeah, it's strange :), but they really want it.
- WebKit.pri:
- 4:14 AM Changeset in webkit [69288] by
-
- 1 edit302 deletes in trunk/LayoutTests
2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Deduplicate some resuts of my last baseline recreations.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.
...
- 4:09 AM Changeset in webkit [69287] by
-
- 3 edits in trunk/WebCore
2010-10-07 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, release build fix.
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
- inspector/InspectorStyleSheet.h: (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
- 3:37 AM Changeset in webkit [69286] by
-
- 3 edits in trunk/WebCore
2010-10-07 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix.
Build fix for r69283.
- dom/Document.cpp: (WebCore::Document::inspectorController):
- dom/Document.h:
- 2:55 AM Changeset in webkit [69285] by
-
- 4 edits in trunk
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249
Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead
- webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
- 2:53 AM Changeset in webkit [69284] by
-
- 9 edits6 adds in trunk/WebCore
2010-10-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Implement handling of CSS operations in InspectorCSSAgent.
Property toggling not implemented yet. The code is not going live.
https://bugs.webkit.org/show_bug.cgi?id=45825
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorCSSAgent.cpp: Added. (WebCore::InspectorCSSAgent::buildObjectForStyle): (WebCore::InspectorCSSAgent::parentStyleSheet): (WebCore::InspectorCSSAgent::asCSSStyleRule): (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent): (WebCore::InspectorCSSAgent::reset): (WebCore::InspectorCSSAgent::getMatchedRulesForNode2): (WebCore::InspectorCSSAgent::getMatchedPseudoRulesForNode2): (WebCore::InspectorCSSAgent::getAttributeStylesForNode2): (WebCore::InspectorCSSAgent::getInlineStyleForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): (WebCore::InspectorCSSAgent::getInheritedStylesForNode2): (WebCore::InspectorCSSAgent::getAllStyles2): (WebCore::InspectorCSSAgent::getStyleSheet2): (WebCore::InspectorCSSAgent::setStyleSheetText2): (WebCore::InspectorCSSAgent::setStyleText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2): (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::getSupportedCSSProperties): (WebCore::InspectorCSSAgent::inlineStyleElement): (WebCore::InspectorCSSAgent::populateObjectWithStyleProperties): (WebCore::InspectorCSSAgent::shorthandValue): (WebCore::InspectorCSSAgent::shorthandPriority): (WebCore::InspectorCSSAgent::longhandProperties): (WebCore::InspectorCSSAgent::asInspectorStyleSheet): (WebCore::InspectorCSSAgent::elementForId): (WebCore::InspectorCSSAgent::bindStyleSheet): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet): (WebCore::InspectorCSSAgent::styleSheetForId): (WebCore::InspectorCSSAgent::detectOrigin): (WebCore::InspectorCSSAgent::buildArrayForRuleList): (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles): (WebCore::InspectorCSSAgent::didRemoveDocument): (WebCore::InspectorCSSAgent::didRemoveDOMNode):
- inspector/InspectorCSSAgent.h: Added. (WebCore::InspectorCSSAgent::create):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setDOMListener): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::DOMListener::~DOMListener): (WebCore::InspectorDOMAgent::documents):
- inspector/InspectorStyleSheet.cpp: Added. (ParsedStyleSheet::cssStyleSheet): (ParsedStyleSheet::text): (ParsedStyleSheet::hasText): (ParsedStyleSheet::sourceData): (ParsedStyleSheet::hasSourceData): (ParsedStyleSheet::ParsedStyleSheet): (ParsedStyleSheet::setText): (ParsedStyleSheet::setSourceData): (ParsedStyleSheet::ruleSourceDataAt): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheet::~InspectorStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::setRuleSelector): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::buildObjectForStyle): (WebCore::InspectorStyleSheet::styleForId): (WebCore::InspectorStyleSheet::setStyleText): (WebCore::InspectorStyleSheet::ownerDocument): (WebCore::InspectorStyleSheet::ruleSourceDataFor): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureParsedDataReady): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::innerSetStyleSheetText): (WebCore::InspectorStyleSheet::innerSetStyleText): (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle): (WebCore::InspectorStyleSheet::findPageRuleWithStyle): (WebCore::InspectorStyleSheet::fullRuleId): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::styleSheetText): (WebCore::InspectorStyleSheet::resourceStyleSheetText): (WebCore::InspectorStyleSheet::inlineStyleSheetText): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::ownerDocument): (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady): (WebCore::InspectorStyleSheetForInlineStyle::inlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- inspector/InspectorStyleSheet.h: Added. (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheet::pageStyleSheet): (WebCore::InspectorStyleSheet::canBind): (WebCore::InspectorStyleSheet::fullRuleOrStyleId): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheet::fullStyleId): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor): (WebCore::InspectorStyleSheetForInlineStyle::ruleIndexByStyle):
- inspector/InspectorUtilities.cpp: Added. (WebCore::InspectorUtilities::resourceContentForURL):
- inspector/InspectorUtilities.h: Added.
- 2:43 AM Changeset in webkit [69283] by
-
- 27 edits in trunk/WebCore
2010-10-05 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract Inspector Instrumentation API as a class
https://bugs.webkit.org/show_bug.cgi?id=47173
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::callFunction):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- dom/Document.h:
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData):
- loader/loader.cpp: (WebCore::Loader::load):
- page/DOMTimer.cpp: (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
- page/DOMTimer.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
- page/DOMWindow.h:
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
- page/FrameView.h:
- page/Page.cpp:
- page/Page.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- 2:11 AM Changeset in webkit [69282] by
-
- 2 edits in trunk/WebCore
Windowless flash plugin is not rendered in Symbian
https://bugs.webkit.org/show_bug.cgi?id=47172
Patch by Zraly Mike <mike.zraly@nokia.com> on 2010-10-07
Reviewed by Andreas Kling.
- plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformStart):
Add call to updatePluginWidget() following changes to
platform widget. This is needed to set PluginView's
m_windowRect and m_clipRect members properly after
the proxy widget and its container get created.
- 2:05 AM Changeset in webkit [69281] by
-
- 1855 edits in trunk/LayoutTests
2010-10-06 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 2 of 2
- 1:35 AM Changeset in webkit [69280] by
-
- 1132 edits in trunk/LayoutTests
2010-10-06 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 1 of 2, since the SVN server keeps 500'ing on me during commit.
- 12:33 AM Changeset in webkit [69279] by
-
- 28 edits2 moves in trunk/WebCore
2010-10-07 Andreas Kling <kling@webkit.org>
Reviewed by Nikolas Zimmermann.
Rename (and move) RenderPath to svg/RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=47053
Also renamed RenderObject::isRenderPath() to isSVGPath()
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGPath):
- rendering/RenderPath.cpp: Removed.
- rendering/RenderPath.h: Removed.
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::hitTestClipContent):
- rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::postApplyResource):
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<): (WebCore::write):
- rendering/SVGRenderTreeAsText.h:
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
- rendering/svg/RenderSVGPath.cpp: Copied from WebCore/rendering/RenderPath.cpp. (WebCore::RenderSVGPath::RenderSVGPath): (WebCore::RenderSVGPath::fillContains): (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::layout): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::paint): (WebCore::RenderSVGPath::addFocusRingRects): (WebCore::RenderSVGPath::nodeAtFloatPoint): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded): (WebCore::RenderSVGPath::updateCachedBoundaries):
- rendering/svg/RenderSVGPath.h: Copied from WebCore/rendering/RenderPath.h. (WebCore::RenderSVGPath::isSVGPath): (WebCore::RenderSVGPath::renderName): (WebCore::toRenderSVGPath):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGGradientElement.cpp:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGStyledLocatableElement.cpp:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::createRenderer):
Oct 6, 2010:
- 11:57 PM Changeset in webkit [69278] by
-
- 2 edits in trunk/LayoutTests
2010-10-06 Alejandro G. Castro <alex@igalia.com>
Unreviewed, update GTK+ expected results.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 11:57 PM Changeset in webkit [69277] by
-
- 5 edits in trunk/JavaScriptCore
2010-10-06 Chris Evans <cevans@google.com>
Reviewed by David Levin.
Use size_t consistently in CString, to prevent theoretical trouble
with > 4GB strings on 64-bit platforms.
- wtf/text/CString.h:
- wtf/text/CString.cpp: Use size_t for string lengths.
- wtf/MD5.cpp: (WTF::expectMD5): use suitable format string + cast for size_t.
- JavaScriptCore.exp: Update symbol name.
- 11:42 PM Changeset in webkit [69276] by
-
- 4 edits in trunk/WebCore
2010-10-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: clear line highlight when switching current view
https://bugs.webkit.org/show_bug.cgi?id=47262
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearLineHighlight):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype.clearLineHighlight):
- 10:42 PM Changeset in webkit [69275] by
-
- 2 edits in trunk/WebCore
2010-10-06 Chris Evans <cevans@google.com>
Reviewed by David Levin.
Fix integer errors with enormous input strings to newline normalization APIs.
- platform/text/LineEnding.cpp: (WebCore::normalizeLineEndingsToCRLF): return the empty string upon huge input strings. (Behaves similarly to base64Encode now). (WebCore::normalizeToCROrLF): use the correct type for a string length.
- 10:31 PM Changeset in webkit [69274] by
-
- 9 edits in trunk
2010-10-06 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Remove unused accessibility functions from webkit.
https://bugs.webkit.org/attachment.cgi?bugid=46707
- public/WebAccessibilityCache.h:
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged):
- src/WebAccessibilityCacheImpl.cpp:
- src/WebAccessibilityCacheImpl.h:
2010-10-06 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Remove unused accessibility functions from webkit.
https://bugs.webkit.org/attachment.cgi?bugid=46707
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- DumpRenderTree/chromium/WebViewHost.h:
- 10:23 PM Changeset in webkit [69273] by
-
- 4 edits in trunk/WebCore
2010-10-06 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Windows build fix for r69272.
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::stepBase): Use defaultStepBase() instead of defaultStepBase.
- html/InputType.h: (WebCore::InputType::defaultStepBase): Make defaultStepBase static function.
- html/NumberInputType.cpp: (WebCore::NumberInputType::stepBase): Use defaultStepBase() instead of defaultStepBase.
- 9:49 PM Changeset in webkit [69272] by
-
- 23 edits in trunk/WebCore
2010-10-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Move range/step related functions
https://bugs.webkit.org/show_bug.cgi?id=47251
Move the content of the following functions:
- rangeUnderflow()
- rangeOverflow()
- minimum()
- maximum()
- stepMismatch()
- stepBase()
getStepParameters() was split into InputType::defaultStep() and
stepScaleFactor().
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::rangeUnderflow): (WebCore::BaseDateAndTimeInputType::rangeOverflow): (WebCore::BaseDateAndTimeInputType::stepMismatch): (WebCore::BaseDateAndTimeInputType::stepBase):
- html/BaseDateAndTimeInputType.h:
- html/DateInputType.cpp: (WebCore::DateInputType::minimum): (WebCore::DateInputType::maximum): (WebCore::DateInputType::defaultStep): (WebCore::DateInputType::stepScaleFactor): (WebCore::DateInputType::parsedStepValueShouldBeInteger):
- html/DateInputType.h:
- html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::minimum): (WebCore::DateTimeInputType::maximum): (WebCore::DateTimeInputType::defaultStep): (WebCore::DateTimeInputType::stepScaleFactor): (WebCore::DateTimeInputType::scaledStepValeuShouldBeInteger):
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::minimum): (WebCore::DateTimeLocalInputType::maximum): (WebCore::DateTimeLocalInputType::defaultStep): (WebCore::DateTimeLocalInputType::stepScaleFactor): (WebCore::DateTimeLocalInputType::scaledStepValeuShouldBeInteger):
- html/DateTimeLocalInputType.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::minimum): (WebCore::HTMLInputElement::maximum): (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::handleKeyEventForRange): (WebCore::HTMLInputElement::stepUpFromRenderer):
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::InputType::patternMismatch): (WebCore::InputType::rangeUnderflow): (WebCore::InputType::rangeOverflow): (WebCore::InputType::minimum): (WebCore::InputType::maximum): (WebCore::InputType::stepMismatch): (WebCore::InputType::stepBase): (WebCore::InputType::defaultStep): (WebCore::InputType::stepScaleFactor): (WebCore::InputType::parsedStepValueShouldBeInteger): (WebCore::InputType::scaledStepValeuShouldBeInteger):
- html/InputType.h:
- html/MonthInputType.cpp: (WebCore::MonthInputType::minimum): (WebCore::MonthInputType::maximum): (WebCore::MonthInputType::defaultStep): (WebCore::MonthInputType::stepScaleFactor): (WebCore::MonthInputType::parsedStepValueShouldBeInteger):
- html/MonthInputType.h:
- html/NumberInputType.cpp: (WebCore::NumberInputType::rangeUnderflow): (WebCore::NumberInputType::rangeOverflow): (WebCore::NumberInputType::minimum): (WebCore::NumberInputType::maximum): (WebCore::NumberInputType::stepMismatch): (WebCore::NumberInputType::stepBase): (WebCore::NumberInputType::defaultStep): (WebCore::NumberInputType::stepScaleFactor):
- html/NumberInputType.h:
- html/RangeInputType.cpp: (WebCore::RangeInputType::rangeUnderflow): (WebCore::RangeInputType::rangeOverflow): (WebCore::RangeInputType::minimum): (WebCore::RangeInputType::maximum): (WebCore::RangeInputType::stepMismatch): (WebCore::RangeInputType::stepBase): (WebCore::RangeInputType::defaultStep): (WebCore::RangeInputType::stepScaleFactor):
- html/RangeInputType.h:
- html/TimeInputType.cpp: (WebCore::TimeInputType::minimum): (WebCore::TimeInputType::maximum): (WebCore::TimeInputType::defaultStep): (WebCore::TimeInputType::stepScaleFactor): (WebCore::TimeInputType::scaledStepValeuShouldBeInteger):
- html/TimeInputType.h:
- html/WeekInputType.cpp: (WebCore::WeekInputType::minimum): (WebCore::WeekInputType::maximum): (WebCore::WeekInputType::stepBase): (WebCore::WeekInputType::defaultStep): (WebCore::WeekInputType::stepScaleFactor): (WebCore::WeekInputType::parsedStepValueShouldBeInteger):
- html/WeekInputType.h:
- 9:46 PM Changeset in webkit [69271] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-10-06 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium-linux/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/chromium-linux/fast/css/first-letter-punctuation-expected.png: Added.
- platform/chromium-mac/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/chromium-mac/fast/css/first-letter-punctuation-expected.png: Added.
- platform/chromium-win/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/chromium-win/fast/css/first-letter-punctuation-expected.png: Added.
- platform/chromium-win/fast/css/first-letter-punctuation-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:37 PM Changeset in webkit [69270] by
-
- 3 edits4 adds in trunk
2010-10-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Darin Adler.
:first-letter should apply to "punctuation" after the first letter
https://bugs.webkit.org/show_bug.cgi?id=45986
Follow the CSS 2.1 spec by allow certain kinds of punctuation before and after
the :first-letter character.
The spec does not describe whitespace behavior, and browsers are inconsistent.
This patch allows whitespace (including non-breaking spaces) before and after the
leading punctuation, and before the trailing punctuation.
Test: fast/css/first-letter-punctuation.html
- rendering/RenderBlock.cpp: (WebCore::isPunctuationForFirstLetter): (WebCore::shouldSkipForFirstLetter): (WebCore::RenderBlock::updateFirstLetter):
- 7:09 PM Changeset in webkit [69269] by
-
- 5 edits16 adds in trunk/LayoutTests
2010-10-06 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Add regression tests for autocorrection panel
https://bugs.webkit.org/show_bug.cgi?id=47308
<rdar://problem/8521243>
Added regression tests for recently added autocorrection panel on Mac platform, as implemented in <https://bugs.webkit.org/show_bug.cgi?id=44958>.
- editing/spelling/autocorrection-delete.html: Added.
- editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
- editing/spelling/autocorrection-removing-underline.html: Added.
- editing/spelling/autocorrection-simple.html: Added.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Added.
- platform/mac/editing/spelling/autocorrection-delete-expected.png: Added.
- platform/mac/editing/spelling/autocorrection-delete-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.checksum: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-expected.checksum: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-expected.png: Added.
- platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-simple-expected.checksum: Added.
- platform/mac/editing/spelling/autocorrection-simple-expected.png: Added.
- platform/mac/editing/spelling/autocorrection-simple-expected.txt: Added.
- 6:42 PM Changeset in webkit [69268] by
-
- 3 edits in trunk/WebCore
2010-10-06 Sanjeev Radhakrishnan <sanjeevr@chromium.org>
Reviewed by Darin Fisher.
Released the pluginNode in PluginDocument::detach() and prevents a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=47129
- html/PluginDocument.cpp: (WebCore::PluginDocument::detach):
- html/PluginDocument.h:
- 6:30 PM Changeset in webkit [69267] by
-
- 3 edits in branches/chromium/517/WebCore
Revert code changes of WebKit r67261 on the 517 branch, caused regressions. BUG=56150 TBR=pkasting
- 6:26 PM Changeset in webkit [69266] by
-
- 2 edits in trunk/WebCore
2010-10-06 Vincent Scheib <scheib@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Thumbnail generation asserts on zero alpha values.
https://bugs.webkit.org/show_bug.cgi?id=47292
Test: Tested manually by running debug mode, and analyzing in PIX.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- 6:18 PM Changeset in webkit [69265] by
-
- 2 edits in trunk/LayoutTests
2010-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=46912
This test is the flakiest test of all because sometimes it doesn't show
that it's using tiled layering. It seems likely that the compositor
state just hasn't synced all the time. This patch adds an explicit
display() call to force the compositor state to sync. Hopefully it
will make the test non-flaky.
- compositing/geometry/limit-layer-bounds-transformed-overflow.html:
- 6:06 PM Changeset in webkit [69264] by
-
- 2 edits in trunk/WebKitTools
2010-10-06 Lucas Forschler <Lucas Forschler>
Reviewed by Adam Roben.
Fix the sunspider-compare-results to actually use the passed in value for $root.
- Scripts/sunspider-compare-results:
- 5:43 PM Changeset in webkit [69263] by
-
- 2 edits in trunk/LayoutTests
2010-10-06 Adam Barth <abarth@webkit.org>
Update expected results. I think this should have been part of Hyatt's
patch, but I'll confirm with him via bugs.webkit.org.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:39 PM Changeset in webkit [69262] by
-
- 3 edits in trunk/WebCore
2010-10-06 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, trying to fix chromium Windows build.
Explicitly give the parameter value that has a default parameter value.
- page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem):
- 5:34 PM Changeset in webkit [69261] by
-
- 3 edits in trunk/WebCore
Try to fix Windows build.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::cachedCGColor): Put in braces to make the Windows compiler
happy with this file.
- platform/graphics/cg/ImageCG.cpp: Added include of RetainPtr.h.
- 5:19 PM Changeset in webkit [69260] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Build fix.
Cleaning up test_expectations, and marking more failures.
- platform/chromium/test_expectations.txt:
- 5:15 PM Changeset in webkit [69259] by
-
- 14 edits1 add in trunk/WebCore
2010-10-06 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Cache CGColor as we do NSColor
https://bugs.webkit.org/show_bug.cgi?id=47226
This fixes performance problems on certain web pages that use
multiple colors. Once in the past we were using NSColor. Now that
we are using CGColor, we need the same sort of caching that we have
for NSColor.
One example: <http://results.active.com/uploads/html/100759.html>.
- WebCore.xcodeproj/project.pbxproj: Add GraphicsContextCG.h.
- platform/graphics/Color.h: Replace createCGColor with cachedCGColor.
- platform/graphics/cg/ColorCG.cpp: (WebCore::cachedCGColorSpace): Added. (WebCore::leakCGColor): Added. (WebCore::cachedCGColor): Added.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): Use cachedCGColor. (WebCore::setCGStrokeColor): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Ditto.
- platform/graphics/cg/GraphicsContextCG.h: Added.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Moved the color space functions here.
- platform/graphics/cg/ImageCG.cpp: Tweaked headers and formatting.
- platform/graphics/mac/ColorMac.mm: Removed the createCGColor function.
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::drawFocusRingToContext): Removed innappropriate use of RetainPtr for the arguments to this function. (WebCore::GraphicsContext::drawFocusRing): Use cachedCGColor.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): Use cachedCGColor. (WebCore::setLayerBackgroundColor): Ditto.
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing): Ditto.
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::setLayerBorderColor): Ditto. (WebCore::setLayerBackgroundColor): Ditto.
- platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Use CGColorCreateGenericRGB for color used only for debugging.
- platform/graphics/win/WebTiledLayer.cpp: (WebCore::WebTiledLayer::addTile): Ditto.
- 5:05 PM Changeset in webkit [69258] by
-
- 2 edits in branches/chromium/517/WebCore
Merge 69257 - 2010-10-06 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson
ScrollViews without scrollbars should not eat scroll events
https://bugs.webkit.org/show_bug.cgi?id=47036
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
TBR=jamesr@google.com
BUG=56063
Review URL: http://codereview.chromium.org/3552012
- 4:56 PM Changeset in webkit [69257] by
-
- 2 edits in trunk/WebCore
2010-10-06 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson
ScrollViews without scrollbars should not eat scroll events
https://bugs.webkit.org/show_bug.cgi?id=47036
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
- 4:52 PM Changeset in webkit [69256] by
-
- 3 edits2 adds in trunk
2010-10-06 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
ASSERTION FAILURE: Attempt to cast RenderObject to RenderFrameSet
when <frameset> has CSS content property
https://bugs.webkit.org/show_bug.cgi?id=47314
Fixes an issue where sending a mouse event to an HTML Frameset Element that
whose content was replaced via the CSS content property causes an assertion
failure.
By default, HTMLFrameSetElement forwards mouse events to RenderFrameSet so as
to support resizing a frame within the set. When a <frameset> specifies an
image in its CSS content property we create a generic render object (RenderObject)
for the frame set instead of a RenderFrameSet object. The event handler code
in HTMLFrameSetElement calls WebCore::toRenderFrameSet() to cast its renderer
to type RenderFrameSet, which fails. To correct this, HTMLFrameSetElement
must check that its renderer is of type RenderFrameSet before casting to this type.
Test: fast/frames/crash-frameset-CSS-content-property.html
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Check that our renderer is of type RenderFrameSet before casting it as such.
2010-10-06 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
ASSERTION FAILURE: Attempt to cast RenderObject to RenderFrameSet
when <frameset> has CSS content property
https://bugs.webkit.org/show_bug.cgi?id=47314
Test to ensure that we don't crash when clicking on a <frameset> that specifies the CSS content property.
- fast/frames/crash-frameset-CSS-content-property-expected.txt: Added.
- fast/frames/crash-frameset-CSS-content-property.html: Added.
- 4:51 PM Changeset in webkit [69255] by
-
- 2 edits in trunk/WebCore
r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ENABLE(SVG) is false.
https://bugs.webkit.org/show_bug.cgi?id=47315
Reviewed by Andreas Kling.
Compile fix. No tests.
- platform/graphics/filters/FETile.cpp:
(WebCore::FETile::apply):
- 4:41 PM Changeset in webkit [69254] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Try to make test pass on GTK and QT.
REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832
- fast/events/mouse-focus-imagemap-expected.txt:
- fast/events/mouse-focus-imagemap.html:
- 4:28 PM Changeset in webkit [69253] by
-
- 3 edits in trunk/WebKitTools
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Runloop implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47280
- WebKitTestRunner/qt/TestControllerQt.cpp: Implemented TestController::runUntil by a timerEvent and a QEventLoop. We step into the event loop from runUntil. While we are waiting in the loop a timerEvent is periodically checking the value of the condition. Once the condition has becoming true the timerEvent wakes us up. (WTR::RunUntilLoop::start): (WTR::RunUntilLoop::RunUntilLoop): (WTR::RunUntilLoop::run): (WTR::RunUntilLoop::timerEvent): (WTR::TestController::platformInitialize): (WTR::TestController::runUntil):
- WebKitTestRunner/qt/main.cpp: Start the main event loop first and creating the TestController later. (Launcher::Launcher): (Launcher::~Launcher): (Launcher::launch): Creating the TestController. (main): Setting up a timer for calling Launcher::launch from the main event loop.
- 4:24 PM Changeset in webkit [69252] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-10-06 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, fixing screwed up ChangeLogs.
- 4:22 PM Changeset in webkit [69251] by
-
- 1 edit in trunk/WebCore/storage/IDBDatabase.cpp
[Chromium] Unreviewed build fix.
- 4:18 PM Changeset in webkit [69250] by
-
- 5 edits in trunk
2010-10-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kenneth Russell.
Add a "FIXME" to clarify that all of the tests are currently marked
"PASS FAIL" and hence we won't actually see any failures requiring
new baselines (only crashes or timeouts).
- platform/chromium-gpu/test_expectations.txt:
2010-10-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kenneth Russell.
new-run-webkit-tests: fix typo in chromium-gpu that was trying to
enable 'accelerated-composting' instead of 'accelerated-compositing'.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 4:08 PM Changeset in webkit [69249] by
-
- 53 edits9 adds1 delete in trunk
2010-10-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add FileSystemSync implementation for Worker
https://bugs.webkit.org/show_bug.cgi?id=47044
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Added a new parameter for synchronous mode.
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a parameter for synchronous mode. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Changed to creates WorkerAsyncFileSystemChromium with synchronous flag.
- src/WebFileSystemCallbacksImpl.h:
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem): Added a parameter for synchronous mode.
- src/WebWorkerBase.h:
- src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium): (WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete): Added. (WebCore::WorkerAsyncFileSystemChromium::move): (WebCore::WorkerAsyncFileSystemChromium::copy): (WebCore::WorkerAsyncFileSystemChromium::remove): (WebCore::WorkerAsyncFileSystemChromium::readMetadata): (WebCore::WorkerAsyncFileSystemChromium::createFile): (WebCore::WorkerAsyncFileSystemChromium::createDirectory): (WebCore::WorkerAsyncFileSystemChromium::fileExists): (WebCore::WorkerAsyncFileSystemChromium::directoryExists): (WebCore::WorkerAsyncFileSystemChromium::readDirectory): (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge): Updated to store the created bridge in a member variable so that we can call bridge->stop() later when the RunLoop is terminating.
- src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create): Added a new parameter for synchronous mode.
2010-10-06 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245
Recover metadata properly by adding abort tasks that
are run when a transaction aborts.
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap): (WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap): (WebCore::IDBDatabaseBackendImpl::resetVersion):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap): (WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort):
- storage/IDBTransactionBackendImpl.h:
- storage/IDBTransactionBackendInterface.h:
- storage/IDBTransactionCoordinator.h:
2010-10-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add FileSystemSync implementation for Worker
https://bugs.webkit.org/show_bug.cgi?id=47044
- fast/filesystem/async-operations.html: Added.
- fast/filesystem/resources/async-operations.js: Added.
- fast/filesystem/resources/fs-worker-test-pre.js:
- fast/filesystem/resources/sync-operations.js: Added.
- fast/filesystem/script-tests/flags-passing.js:
- fast/filesystem/workers/async-operations-expected.txt: Added.
- fast/filesystem/workers/async-operations.html: Added.
- fast/filesystem/workers/simple-persistent-sync-expected.txt:
- fast/filesystem/workers/simple-temporary-sync-expected.txt:
- fast/filesystem/workers/sync-operations-expected.txt: Added.
- fast/filesystem/workers/sync-operations.html: Added.
- 4:00 PM Changeset in webkit [69248] by
-
- 4 edits in trunk/WebKitTools
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] PlatformWebView implementation for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=47276
The implementation follows the way how
we use the API in MiniBrowser.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::wkView): (WTR::WebView::~WebView): (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus):
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 3:52 PM Changeset in webkit [69247] by
-
- 21 edits in trunk
2010-10-06 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/resources/shared.js: (unexpectedAbortCallback): (unexpectedCompleteCallback): (deleteAllObjectStores):
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
2010-10-06 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245
Recover metadata properly by adding abort tasks that
are run when a transaction aborts.
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap): (WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap): (WebCore::IDBDatabaseBackendImpl::resetVersion):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap): (WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort):
- storage/IDBTransactionBackendImpl.h:
- storage/IDBTransactionBackendInterface.h:
- storage/IDBTransactionCoordinator.h:
2010-10-06 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245
- src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::scheduleTask):
- src/IDBTransactionBackendProxy.h:
- 3:48 PM Changeset in webkit [69246] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Build fix. Mark flaky tests.
- platform/chromium/test_expectations.txt:
- 3:47 PM Changeset in webkit [69245] by
-
- 3 edits in trunk/WebKit2
Separate actually calling the member function from decoding/encoding arguments
and remove any ambiguities when calling the function.
Reviewed by Sam Weinig.
- Platform/CoreIPC/Arguments.h:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):
- 3:43 PM Changeset in webkit [69244] by
-
- 10 edits1 move6 adds in trunk
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155
Add the new subdirs.
- DerivedSources.pro:
- WebKit.pro:
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155
Parts was taken by Zoltan Horvath's patch.
- Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
- Scripts/webkitdirs.pm: Make the generated files needed by WTR.
- WebKitTestRunner/PlatformWebView.h: Addeed typedefs for PlatformWKView and PlatformWindow (void* for now). Buildfix the case when APPLE is not defined.
- WebKitTestRunner/qt/DerivedSources.pro: Added.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus):
- WebKitTestRunner/qt/TestControllerQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::TestController::runUntil): (WTR::TestController::platformInitialize): (WTR::TestController::initializeInjectedBundlePath): (WTR::TestController::initializeTestPluginDirectory): (WTR::TestController::platformInitializeContext):
- WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
- WebKitTestRunner/qt/main.cpp: Added. (main):
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155
- DerivedSources.pro: Changes according the new location of generate-forwarding-headers.pl.
- UIProcess/API/C/WebKit2.h: Do not check the value of the APPLE define if it is not defined.
- WebKit2.pro: Changes according the new location of generate-forwarding-headers.pl. Added missing files to the build that provides API that is used by WTR.
- generate-forwarding-headers.pl: Moved to WebKitTools/Scripts since from now this is not only used by WebKit2.
- 3:33 PM Changeset in webkit [69243] by
-
- 4 edits2 adds in trunk/WebKit/chromium
2010-10-06 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add webkit unit tests to chromium multi-dll build.
In chromium multi-dll build mode, compile the webkit unit tests
code in webkit.dll and export an api that runs the tests.
- WebKit.gyp:
- WebKit.gypi:
- tests/RunAllTests.cpp: (main):
- tests/WebUnitTests.cpp: Added. (WebKit::RunAllUnitTests):
- tests/WebUnitTests.h: Added.
- 3:30 PM Changeset in webkit [69242] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Make test work on QT as well as other platforms.
REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832
- fast/events/mouse-focus-imagemap-expected.txt:
- fast/events/mouse-focus-imagemap.html:
- 3:28 PM Changeset in webkit [69241] by
-
- 3 edits7 adds in trunk
[chromium] Unreviewed. Rebaseline more tests.
Linux having similar SVG failures to windows. Revision r69226 added
http/tests/appcache/main-resource-redirect.html which does not work
on chromium yet.
- platform/chromium-linux/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/fieldsets-expected.png: Added.
- platform/chromium-linux/svg/filters/feDisplacementMap-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.checksum.
- platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.png.
- platform/chromium-win/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/fieldsets-expected.png: Added.
- platform/chromium-win/fast/blockflow/fieldsets-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:15 PM Changeset in webkit [69240] by
-
- 5 edits in trunk/WebKit2
More Arguments.h cleanup.
Reviewed by Sam Weinig.
- Platform/CoreIPC/Arguments.h:
- Platform/CoreIPC/HandleMessage.h:
Remove unnecessary typedefs, simplify.
- Scripts/webkit2/messages.py:
- UIProcess/WebContext.h:
Fix clang++ build.
- 3:13 PM Changeset in webkit [69239] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47306
Reviewed by Dan Bernstein.
Convert determineStart/EndPosition and matchedEndLine to be writing-mode-aware.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
- 3:12 PM Changeset in webkit [69238] by
-
- 1 edit2 adds in trunk/LayoutTests/platform
Mac baseline for simple_paint.html. Updated test_expectations.
- 3:09 PM Changeset in webkit [69237] by
-
- 6 edits2 adds in trunk
REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832
Reviewed by Beth Dakin.
WebCore:
Test: fast/events/mouse-focus-imagemap.html
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::isKeyboardFocusable):
(WebCore::HTMLAreaElement::isMouseFocusable):
(WebCore::HTMLAreaElement::isFocusable):
(WebCore::HTMLAreaElement::updateFocusAppearance):
- html/HTMLAreaElement.h:
LayoutTests:
- fast/events/mouse-focus-imagemap-expected.txt: Added.
- fast/events/mouse-focus-imagemap.html: Added.
- fast/events/resources/tabindex-focus-blur-all.js:
(testProgrammaticFocus):
- fast/events/tabindex-focus-blur-all-expected.txt:
Update test to reflect that AREA with tabindex=-1 should not be focusable.
- 2:48 PM Changeset in webkit [69236] by
-
- 6 edits in trunk
Start cleaning up Arguments.h
https://bugs.webkit.org/show_bug.cgi?id=47304
Reviewed by Sam Weinig.
- wtf/TypeTraits.h:
- wtf/TypeTraits.cpp:
Add RemoveReference type trait.
WebKit2:
This is a first step towards simplifying all the handleMessage overloads we have.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments1):
Make Arguments1 a struct and get rid of the FirstArgumentType typedef. Instead, add a
ValueType typedef which is defined to an Arguments1 type whose type parameter is not
a reference type.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Update for the Arguments1 change. Rename "arguments" to "argumentDecoder" and "reply" to
"replyEncoder".
- 2:44 PM Changeset in webkit [69235] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47303
Reviewed by Dan Bernstein.
Convert layoutInlineChildren to be block-flow-aware. None of the functions it calls are patched yet.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::forceLayoutInlineChildren):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
(WebCore::RenderBlock::afterSideVisibleOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
- rendering/RenderBox.h:
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
- 2:27 PM Changeset in webkit [69234] by
-
- 2 edits in branches/chromium/517/LayoutTests
Merge 69167 - 2010-10-05 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/test_expectations.txt:
TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/3626003
- 2:13 PM Changeset in webkit [69233] by
-
- 6 edits in branches/chromium/517
Merge 69161 - 2010-10-05 Fady Samuel <fsamuel@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131
Added a layout test to check for paint rects that touch the border of an adjacent sell,
when border-collapse: separate is set for the table.
- fast/table/simple_paint.html:
Don't do rtl as it doesn't exercise some of the new paint code.
- fast/table/simple_paint_separate_borders-expected.checksum: Added.
- fast/table/simple_paint_separate_borders-expected.png: Added.
- fast/table/simple_paint_separate_borders-expected.txt: Added.
- fast/table/simple_paint_separate_borders.html: Added.
2010-10-05 Fady Samuel <fsamuel@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131
When border-collapse: separate property is set on the table, paintObject
may skip repainting cells, if the dirty region only touches one row/col of pixels.
Test: fast/table/simple_paint_separate_borders.html
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject):
Don't subtract one from the right and bottom of the dirty paint rect.
TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/3590023
- 2:08 PM Changeset in webkit [69232] by
-
- 3 edits in trunk/WebKit2
2010-10-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the build after API changes introduced in r69214.
- UIProcess/API/cpp/qt/WKStringQt.cpp: (WKStringCreateWithQString):
- UIProcess/API/cpp/qt/WKURLQt.cpp: (WKURLCreateWithQUrl):
- 2:02 PM Changeset in webkit [69231] by
-
- 173 edits3 copies16 adds5 deletes in trunk/LayoutTests
[chromium] Unreviewed. Rebaseline layout tests.
Rebaselining for changes caused by r69181, r69220, and a few others
in that range.
Bugs filed for the 2 tests that look like real failures.
- platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
- platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-linux/fast/forms/006-expected.checksum:
- platform/chromium-linux/fast/forms/006-expected.png:
- platform/chromium-linux/fast/forms/007-expected.checksum:
- platform/chromium-linux/fast/forms/007-expected.png:
- platform/chromium-linux/fast/forms/fieldset-align-expected.checksum:
- platform/chromium-linux/fast/forms/fieldset-align-expected.png:
- platform/chromium-linux/fast/forms/float-before-fieldset-expected.checksum:
- platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-linux/svg/custom/empty-merge-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/empty-merge-expected.png: Removed.
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.checksum:
- platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
- platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
- platform/chromium-linux/svg/custom/recursive-filter-expected.png:
- platform/chromium-linux/svg/custom/text-filter-expected.checksum:
- platform/chromium-linux/svg/custom/text-filter-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/filters/feComposite-expected.checksum:
- platform/chromium-linux/svg/filters/feComposite-expected.png:
- platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png:
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-linux/svg/filters/sourceAlpha-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
- platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Added.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum: Copied from LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
- platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/forms/006-expected.checksum:
- platform/chromium-win/fast/forms/006-expected.png:
- platform/chromium-win/fast/forms/007-expected.checksum:
- platform/chromium-win/fast/forms/007-expected.png:
- platform/chromium-win/fast/forms/fieldset-align-expected.checksum:
- platform/chromium-win/fast/forms/fieldset-align-expected.png:
- platform/chromium-win/fast/forms/float-before-fieldset-expected.checksum:
- platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
- platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect-expected.png:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/custom/convolution-crash-expected.checksum:
- platform/chromium-win/svg/custom/convolution-crash-expected.png:
- platform/chromium-win/svg/custom/empty-merge-expected.checksum:
- platform/chromium-win/svg/custom/empty-merge-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.checksum:
- platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
- platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
- platform/chromium-win/svg/custom/recursive-filter-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.checksum:
- platform/chromium-win/svg/custom/text-filter-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
- platform/chromium-win/svg/filters/feComposite-expected.checksum:
- platform/chromium-win/svg/filters/feComposite-expected.png:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
- platform/chromium-win/svg/filters/feOffset-expected.checksum:
- platform/chromium-win/svg/filters/feOffset-expected.png:
- platform/chromium-win/svg/filters/feTile-expected.checksum:
- platform/chromium-win/svg/filters/feTile-expected.png:
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/filterRes1-expected.checksum: Added.
- platform/chromium-win/svg/filters/filterRes1-expected.png: Added.
- platform/chromium-win/svg/filters/filterRes2-expected.checksum: Added.
- platform/chromium-win/svg/filters/filterRes2-expected.png: Added.
- platform/chromium-win/svg/filters/filterRes3-expected.checksum: Added.
- platform/chromium-win/svg/filters/filterRes3-expected.png: Added.
- platform/chromium-win/svg/filters/filteredImage-expected.checksum:
- platform/chromium-win/svg/filters/filteredImage-expected.png:
- platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.checksum:
- platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/svg/filters/sourceAlpha-expected.checksum:
- platform/chromium-win/svg/filters/sourceAlpha-expected.png:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
- platform/chromium/test_expectations.txt:
- 1:37 PM Changeset in webkit [69230] by
-
- 481 edits477 adds in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
Next patch updating the SVG pixel test baseline for Leopard & Snow Leopard.
- platform/mac-leopard/svg/dynamic-updates: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
...
- 1:36 PM Changeset in webkit [69229] by
-
- 27 edits1 add2 deletes in trunk/WebKit2
2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69210.
http://trac.webkit.org/changeset/69210
https://bugs.webkit.org/show_bug.cgi?id=47297
This patch broke Windows (Requested by andersca on #webkit).
- DerivedSources.make:
- DerivedSources.pro:
- Platform/CoreIPC/Arguments.h:
- Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessage):
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
- Shared/StringPairVector.h: Removed.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::registerEditCommand):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::registerEditCommand):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): (WebKit::WebEditCommandProxy::reapply):
- UIProcess/WebFormClient.cpp: (WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstLayoutForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didRemoveFrameFromHierarchy): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForMIMEType): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::mouseDidMoveOverElement): (WebKit::WebPageProxy::contentsSizeChanged): (WebKit::WebPageProxy::addItemToBackForwardList): (WebKit::WebPageProxy::goToItemInBackForwardList): (WebKit::WebPageProxy::registerEditCommandForUndo): (WebKit::WebPageProxy::registerEditCommandForRedo): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::didChangeAcceleratedCompositing):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Removed.
- UIProcess/win/WebView.cpp: (WebKit::WebView::registerEditCommand):
- UIProcess/win/WebView.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setWindowRect): (WebKit::WebChromeClient::takeFocus): (WebKit::WebChromeClient::createWindow): (WebKit::WebChromeClient::runJavaScriptAlert): (WebKit::WebChromeClient::runJavaScriptConfirm): (WebKit::WebChromeClient::runJavaScriptPrompt): (WebKit::WebChromeClient::setStatusbarText): (WebKit::WebChromeClient::contentsSizeChanged): (WebKit::WebChromeClient::mouseDidMoveOverElement): (WebKit::WebChromeClient::setToolTip): (WebKit::WebChromeClient::setCursor):
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerCommandForUndo): (WebKit::WebEditorClient::clearUndoRedoOperations):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::detachedFromParent2): (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle): (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): (WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): (WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): (WebKit::WebFrameLoaderClient::postProgressStartedNotification): (WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::WebFrameLoaderClient::postProgressFinishedNotification): (WebKit::WebFrameLoaderClient::createFrame):
- WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::addItem): (WebKit::WebBackForwardListProxy::goToItem): (WebKit::WebBackForwardListProxy::backItem): (WebKit::WebBackForwardListProxy::currentItem): (WebKit::WebBackForwardListProxy::forwardItem): (WebKit::WebBackForwardListProxy::itemAtIndex): (WebKit::WebBackForwardListProxy::backListCount): (WebKit::WebBackForwardListProxy::forwardListCount):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::sendClose): (WebKit::WebPage::mouseEvent): (WebKit::WebPage::wheelEvent): (WebKit::WebPage::keyEvent): (WebKit::WebPage::validateMenuItem): (WebKit::WebPage::touchEvent): (WebKit::WebPage::show): (WebKit::WebPage::runJavaScriptInMainFrame): (WebKit::WebPage::getRenderTreeExternalRepresentation): (WebKit::WebPage::getSourceForFrame):
- win/WebKit2.vcproj:
- 1:35 PM Changeset in webkit [69228] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47298
Reviewed by Dan Bernstein.
Rename blockHeight to blockLogicalHeight.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::adjustPosition):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::blockLogicalHeight):
(WebCore::RootInlineBox::setBlockLogicalHeight):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutRootBox):
- 1:21 PM Changeset in webkit [69227] by
-
- 2 edits in trunk/WebCore
2010-10-05 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] DRT assertion w/accel 2D canvas in PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=47242
Call PlatformContextSkia::prepareForSoftwareDraw before doing putImageData
since that call mutates the software backing store.
Test: fast/canvas/canvas-putImageData.html
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData):
- 1:14 PM Changeset in webkit [69226] by
-
- 4 edits5 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=47294
<rdar://problem/8425647>Application cache isn't consulted on redirect
Test: http/tests/appcache/main-resource-redirect.html
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterNavigationPolicy): If we have substitute data now (presumably after a redirect is served by appcache), switch to it. (WebCore::MainResourceLoader::willSendRequest): Check appcache for the new URL.
- loader/MainResourceLoader.h: Made handleDataLoadSoon() take a const ResourceRequest reference - it doesn't ever modify it, and we can call it from continueAfterNavigationPolicy() now.
- 12:54 PM Changeset in webkit [69225] by
-
- 2 edits in trunk/WebKit2
WKSerializedScriptValue.h needs to be copied over into the WEBKITOUTPUTDIR on Windows.
https://bugs.webkit.org/show_bug.cgi?id=47287
Rubber-stamped by Dan Bernstein.
- win/WebKit2Generated.make:
Copy WKSerializedScriptValue.h into $(WEBKITOUTPUTDIR)\include\WebKit2.
- 12:38 PM Changeset in webkit [69224] by
-
- 46 edits81 adds in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
Next patch updating the SVG pixel test baseline for Leopard & Snow Leopard.
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
...
- 12:37 PM Changeset in webkit [69223] by
-
- 5 edits in trunk/WebCore
2010-10-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dirk Schulze.
ContextShadow should not use the blur radius as kernel size of the
box blurs
https://bugs.webkit.org/show_bug.cgi?id=46918
Calculate the size of the kernel in the blur algorithm using the radius instead
of using the blur distance directly. Change the name of the variables to match the
terminology in the spec.
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::clear): (WebCore::ContextShadow::blurLayerImage): (WebCore::ContextShadow::calculateLayerBoundingRect):
- platform/graphics/ContextShadow.h:
- 12:26 PM Changeset in webkit [69222] by
-
- 5 edits4 copies in branches/chromium/517
Merge 68742
BUG=56591
TBR=darin@chromium.org
TEST=fast/history/same-document-iframes-changing-fragment.html
Review URL: http://codereview.chromium.org/3573012
- 12:16 PM Changeset in webkit [69221] by
-
- 3 edits in trunk/WebCore
2010-10-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Correct CamelCase of socketSentdata() in SocketStreamHandlePrivate
to fix "QMetaObject::invokeMethod: No such method" warnings in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=47284
No new tests needed.
- platform/network/qt/SocketStreamHandlePrivate.h:
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::socketSentData):
- 12:02 PM Changeset in webkit [69220] by
-
- 44 edits5 deletes in trunk
https://bugs.webkit.org/show_bug.cgi?id=47285
Reviewed by Dan Bernstein.
Update to the latest writing-mode draft. The block-flow property is gone and has been replaced with writing-mode.
Change all the code to use writingMode() instead of blockFlow() and rename all functions that referred to block flow
as appropriate.
WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
- css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
- css/CSSProperty.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):
(WebCore::RenderBlock::marginValuesForChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::avoidsFloats):
- rendering/RenderBox.h:
(WebCore::RenderBox::logicalLeft):
(WebCore::RenderBox::logicalTop):
(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalLeft):
(WebCore::RenderBox::setLogicalTop):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):
(WebCore::RenderBox::setLogicalLocation):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
(WebCore::RenderBox::stretchesToViewport):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::availableWidth):
(WebCore::RenderBox::availableHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::isWritingModeRoot):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
- rendering/RenderView.h:
(WebCore::RenderView::viewLogicalWidth):
(WebCore::RenderView::viewLogicalHeight):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginBeforeUsing):
(WebCore::RenderStyle::marginAfterUsing):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::writingMode):
(WebCore::InheritedFlags::isHorizontalWritingMode):
(WebCore::InheritedFlags::setWritingMode):
(WebCore::InheritedFlags::initialWritingMode):
- rendering/style/RenderStyleConstants.h:
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialWritingMode):
(WebCore::SVGRenderStyle::setWritingMode):
(WebCore::SVGRenderStyle::writingMode):
- rendering/style/SVGRenderStyleDefs.h:
LayoutTests:
Also hacked all of the getComputedStyle tests to just omit dashboard regions so that the results can be
cross-platform.
- fast/blockflow/auto-margins-across-boundaries.html:
- fast/blockflow/block-formatting-context.html:
- fast/blockflow/block-level-images.html:
- fast/blockflow/display-mutation.html:
- fast/blockflow/fieldsets.html:
- fast/blockflow/floats-in-block-layout.html:
- fast/blockflow/inline-direction-positioning.html:
- fast/blockflow/margin-collapse.html:
- fast/blockflow/percentage-padding.html:
- fast/blockflow/relative-positioning-percentages.html:
- fast/blockflow/root-lr-basic.html:
- fast/blockflow/self-collapsing-block.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer.html:
- fast/css/getComputedStyle/computed-style.html:
- fast/css/logical-property-resolution.html:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/mac/svg/css/getComputedStyle-basic-expected.checksum: Removed.
- platform/mac/svg/css/getComputedStyle-basic-expected.png: Removed.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic.xhtml:
- 11:59 AM Changeset in webkit [69219] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Build fix.
Update test expectations for more svg failures, and some new crashes.
- platform/chromium/test_expectations.txt:
- 11:57 AM Changeset in webkit [69218] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-06 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[EFL] Build fix for glib support.
https://bugs.webkit.org/show_bug.cgi?id=47221
If compiling with GLib support enabled, we also need to link wtf against
glib library.
- wtf/CMakeListsEfl.txt:
- 11:53 AM Changeset in webkit [69217] by
-
- 3 edits in trunk/WebKit/qt
2010-10-06 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Duplicated code in QWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=47195
Remove duplicated code from QWebPagePrivate class for QGraphicsView and QWidget's mouse events.
- Api/qwebpage.cpp: (QWebPagePrivate::mouseMoveEvent): (QWebPagePrivate::mousePressEvent): (QWebPagePrivate::mouseDoubleClickEvent): (QWebPagePrivate::mouseTripleClickEvent): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::wheelEvent): (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragLeaveEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent):
- Api/qwebpage_p.h:
- 11:31 AM Changeset in webkit [69216] by
-
- 7 edits in trunk
2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69201.
http://trac.webkit.org/changeset/69201
https://bugs.webkit.org/show_bug.cgi?id=47279
This change broke the WebKitGTK+ build for GTK+ 2.0.
(Requested by mrobinson on #webkit).
- platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
- platform/gtk/GtkVersioning.h:
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):
2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69201.
http://trac.webkit.org/changeset/69201
https://bugs.webkit.org/show_bug.cgi?id=47279
This change broke the WebKitGTK+ build for GTK+ 2.0.
(Requested by mrobinson on #webkit).
- tests/testcopyandpaste.c: (runPasteTestCallback):
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
- 11:22 AM Changeset in webkit [69215] by
-
- 3 edits in trunk/WebCore
2010-10-06 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
https://bugs.webkit.org/show_bug.cgi?id=47282
Robustify the creation of SharedGraphicsContext3D against shader
compilation failures.
Covered by any canvas 2D layout test, when opened in chrome with
--enable-accelerated-2d-canvas --in-process-webgl.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- 11:16 AM Changeset in webkit [69214] by
-
- 70 edits in trunk/WebKit2
Rename toRef/toWK to toAPI/toImpl
https://bugs.webkit.org/show_bug.cgi?id=47281
Reviewed by Sam Weinig.
- Shared/API/c/WKArray.cpp:
- Shared/API/c/WKCertificateInfo.cpp:
- Shared/API/c/WKData.cpp:
- Shared/API/c/WKDictionary.cpp:
- Shared/API/c/WKError.cpp:
- Shared/API/c/WKMutableArray.cpp:
- Shared/API/c/WKMutableDictionary.cpp:
- Shared/API/c/WKNumber.cpp:
- Shared/API/c/WKSerializedScriptValue.cpp:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/WKString.cpp:
- Shared/API/c/WKType.cpp:
- Shared/API/c/WKURL.cpp:
- Shared/API/c/WKURLRequest.cpp:
- Shared/API/c/WKURLResponse.cpp:
- Shared/API/c/cf/WKStringCF.cpp:
- Shared/API/c/cf/WKURLCF.cpp:
- Shared/API/c/cf/WKURLRequestCF.cpp:
- Shared/API/c/cf/WKURLResponseCF.cpp:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
- Shared/API/c/mac/WKURLRequestNS.mm:
- Shared/API/c/mac/WKURLResponseNS.mm:
- Shared/API/c/win/WKCertificateInfoWin.cpp:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBackForwardList.cpp:
- UIProcess/API/C/WKBackForwardListItem.cpp:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKFormSubmissionListener.cpp:
- UIProcess/API/C/WKFrame.cpp:
- UIProcess/API/C/WKFramePolicyListener.cpp:
- UIProcess/API/C/WKNavigationData.cpp:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPageNamespace.cpp:
- UIProcess/API/C/WKPreferences.cpp:
- UIProcess/API/C/WKPreferencesPrivate.cpp:
- UIProcess/API/C/win/WKContextWin.cpp:
- UIProcess/API/C/win/WKView.cpp:
- UIProcess/API/cpp/qt/WKStringQt.cpp:
- UIProcess/API/cpp/qt/WKURLQt.cpp:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/qt/ClientImpl.cpp:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/GenericCallback.h:
- UIProcess/WebContextInjectedBundleClient.cpp:
- UIProcess/WebFormClient.cpp:
- UIProcess/WebHistoryClient.cpp:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebPolicyClient.cpp:
- UIProcess/WebUIClient.cpp:
- UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
- UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
- UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
- WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
- 11:14 AM Changeset in webkit [69213] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Build fix.
Change svg test expectations after r69181
- platform/chromium/test_expectations.txt:
- 10:36 AM Changeset in webkit [69212] by
-
- 1 edit1 move1 add in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Fixed incorrect baseline for svg/custom/use-invalid-style.svg
- platform/mac-leopard/svg/custom/use-invalid-style-expected.txt: Copied from svg/custom/use-invalid-style-expected.txt.
- platform/mac/svg/custom/use-invalid-style-expected.txt: Added.
- svg/custom/use-invalid-style-expected.txt: Removed.
- 10:34 AM Changeset in webkit [69211] by
-
- 8 edits in trunk
2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
- dom/ViewportArguments.cpp: (WebCore::findConfigurationForViewportData):
- dom/ViewportArguments.h:
2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
- Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268
Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
- 10:31 AM Changeset in webkit [69210] by
-
- 27 edits2 adds1 delete in trunk/WebKit2
Generate the messages sent to the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=47239
Reviewed by Adam Roben.
- Platform/CoreIPC/Arguments.h:
Add additional typedefs.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add more handleMessage implementations.
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
Add headers for reply argument types.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.
- Shared/StringPairVector.h: Added.
This file is a hack to work around a deficiency in the generator
which can't deal with class templates with more than one argument.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebEditCommandProxy.cpp:
- UIProcess/WebFormClient.cpp:
- UIProcess/WebFormClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
Migrate to generated calls.
- UIProcess/WebPageProxy.messages.in: Added.
New messages definitions file.
- DerivedSources.make:
- DerivedSources.pro:
- win/WebKit2.vcproj:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 10:27 AM Changeset in webkit [69209] by
-
- 144 edits407 adds2 deletes in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
Generate SVG pixel test baseline for Snow Leopard (placed in platform/mac/svg) in svg/custom.
- platform/mac-leopard/svg/custom/SVGMatrix-interface-expected.checksum: Added.
- platform/mac-leopard/svg/custom/SVGMatrix-interface-expected.png: Added.
...
- 10:13 AM Changeset in webkit [69208] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
[Chromium] WebIDBKeyRange should handle null left/right pointers
https://bugs.webkit.org/show_bug.cgi?id=47247
- src/WebIDBKeyRange.cpp: (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::flags):
- 10:10 AM Changeset in webkit [69207] by
-
- 7 edits in trunk
2010-10-06 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r69202.
http://trac.webkit.org/changeset/69202
https://bugs.webkit.org/show_bug.cgi?id=46937
Broke compile of test_shell
- DEPS:
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName):
2010-10-06 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r69202.
http://trac.webkit.org/changeset/69202
https://bugs.webkit.org/show_bug.cgi?id=46937
Broke compile of test_shell
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
- DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
- 10:09 AM Changeset in webkit [69206] by
-
- 4 edits10 adds in trunk
2010-10-06 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
SVGFEMergeNodeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47181
Adding layout tests for feMergeNode dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
- svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFEMergeNodeElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEMergeNodeElement-svgdom-in-prop.js: Added. (executeTest):
2010-10-06 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
SVGFEMergeNodeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47181
Since feMergeNode doesn't have own renderer, we have to call the invalidation via its parent.
Tests: svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr.html
svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop.html
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
- svg/SVGFEMergeNodeElement.h:
- 10:04 AM Changeset in webkit [69205] by
-
- 3 edits in trunk/WebCore
2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove unused code from gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=47086
gtk2drawing.c was copied from mozilla and contains a lot of code that is not
used by WebKit. Most of that unused code is uncompatible with gtk3, so
removing it will make easier porting to gtk3.
- platform/gtk/gtk2drawing.c: (moz_gtk_get_widget_border): (moz_gtk_widget_paint): (moz_gtk_destroy_theme_parts_widgets):
- platform/gtk/gtkdrawing.h:
- 9:52 AM Changeset in webkit [69204] by
-
- 4 edits in trunk/WebCore
2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use pixbufs instead of pixmaps when creating platform cursors
https://bugs.webkit.org/show_bug.cgi?id=47087
gdk_cursor_new_from_pixmap() has been removed in gtk3. We can use a
pixbuf instead of a pixman and use gdk_cursor_new_from_pixbuf() instead
for both gtk2 and gtk3.
- platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor):
- platform/gtk/GtkVersioning.c: (gdk_cairo_format_for_content): (gdk_cairo_surface_coerce_to_image): (convert_alpha): (convert_no_alpha): (gdk_pixbuf_get_from_surface):
- platform/gtk/GtkVersioning.h:
- 9:48 AM Changeset in webkit [69203] by
-
- 10 edits in trunk/WebCore
2010-10-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add event listener breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=46738
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint.breakpoint.compareTo): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype._setOnBackend.didSet): (WebInspector.NativeBreakpoint.prototype._setOnBackend):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._showEditBreakpointDialog): (WebInspector.BreakpointItem): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._eventNameCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
- inspector/front-end/EventListenersSidebarPane.js: ():
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (ol.properties-tree): (ol.properties-tree li): (ol.properties-tree li.parent): (ol.properties-tree li.parent::before): (ol.properties-tree li.parent.expanded::before): (ol.properties-tree li .info): (ol.properties-tree ol, .stack-trace ol, ol.stack-trace): (ol.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (ol.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem):
- inspector/front-end/inspector.js: (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
- 9:45 AM Changeset in webkit [69202] by
-
- 7 edits in trunk
2010-10-06 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=46937
Chromium no longer uses the deprecated methods, so delete them.
- DEPS:
- public/WebDragData.h:
- src/WebDragData.cpp:
2010-10-06 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=46937
Update DRT to use the renamed methods.
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
- DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
- 9:40 AM Changeset in webkit [69201] by
-
- 7 edits in trunk
2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port to gtk+3 (2.91.0)
https://bugs.webkit.org/show_bug.cgi?id=47249
Do not use GdkDrawable deprecated API
Some methods of GdkDrawable are deprecated in gtk2 and have been
remmoved in gtk3. Equivalent API has been added to GdkWindow.
- platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
- platform/gtk/GtkVersioning.h:
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):
2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
Port to gtk+3 (2.91.0)
https://bugs.webkit.org/show_bug.cgi?id=47249
Do not use GdkDrawable deprecated API
Some methods of GdkDrawable are deprecated in gtk2 and have been
remmoved in gtk3. Equivalent API has been added to GdkWindow.
- tests/testcopyandpaste.c: (runPasteTestCallback):
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
- 9:35 AM Changeset in webkit [69200] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Added bug URL to ChangeLog entry.
- 9:32 AM Changeset in webkit [69199] by
-
- 3 edits1 copy1 add in trunk/WebKitTools
Move WebArchive serialization code into its own file
Reviewed by Adam Roben.
This is the first step in making webarchive tests work on
Windows.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
new files to the project.
- DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
to WebArchiveDumpSupport.mm.
- DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
- DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
(serializeWebArchiveToXML):
- 9:28 AM Changeset in webkit [69198] by
-
- 6 edits4 adds in trunk
2010-10-06 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Support Progress Tag
https://bugs.webkit.org/show_bug.cgi?id=45951
Implement to render progress tag.
No new tests. Existing tests in fast/dom/HTMLProgressElement.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::edjeGroupFromFormType): (WebCore::RenderThemeEfl::adjustProgressBarStyle): (WebCore::RenderThemeEfl::paintProgressBar):
- platform/efl/RenderThemeEfl.h:
2010-10-06 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Support Progress Tag
https://bugs.webkit.org/show_bug.cgi?id=45951
Implement progressbar.edc to support progress tag
- CMakeListsEfl.txt:
- DefaultTheme/default.edc:
- DefaultTheme/widget/progressbar: Added.
- DefaultTheme/widget/progressbar/bt_base.png: Added.
- DefaultTheme/widget/progressbar/progressbar.edc: Added.
- DefaultTheme/widget/progressbar/shelf_inset.png: Added.
- 8:58 AM Changeset in webkit [69197] by
-
- 7 edits in trunk/WebCore
2010-10-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Add KURL::protocolIsData()
https://bugs.webkit.org/show_bug.cgi?id=47219
- page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::taintsCanvas):
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
- platform/KURL.h: (WebCore::KURL::protocolIsData):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::dispatchSynchronousJob): (WebCore::ResourceHandleManager::startJob):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer):
- 8:43 AM Changeset in webkit [69196] by
-
- 9 edits in trunk/WebCore
2010-10-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
CSSParser: Enable rule selector source range extraction.
API modification followed by clients.
https://bugs.webkit.org/show_bug.cgi?id=46367
Some code removal suggested by Darin Adler.
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markSelectorListStart): (WebCore::CSSParser::markSelectorListEnd): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markRuleBodyEnd): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
- css/CSSParser.h: (WebCore::CSSParser::resetSelectorListMarks): (WebCore::CSSParser::resetRuleBodyMarks): (WebCore::CSSParser::resetPropertyMarks):
- css/CSSPropertySourceData.cpp:
- css/CSSPropertySourceData.h: (WebCore::CSSRuleSourceData::create):
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges):
- inspector/InspectorCSSStore.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData):
- 8:23 AM Changeset in webkit [69195] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-10-06 Dirk Schulze <krit@webkit.org>
Added reviewer to commit r69187.
- 8:16 AM Changeset in webkit [69194] by
-
- 2 edits in trunk/WebCore
2010-10-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feMorphology - big radii cause huge ImageBuffer sizes
https://bugs.webkit.org/show_bug.cgi?id=47263
The current code in FEMorphology::determineAbsolutePaintRect calculates the smallest paint rect by inflate the paint rect
of a previous effect with the radius. This was meant as an optimization, but I forgot to clip the calculated image size
by the maximal effect size. This caused huge image sizes for big radii.
This is covered by svg/filters/feMorphology-invalid-radius.svg and fixes the crashes on Windows and Snow Leopard bots.
- platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::determineAbsolutePaintRect):
- 7:57 AM Changeset in webkit [69193] by
-
- 2 edits in trunk/WebCore
2010-10-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dirk Schulze.
Fixed crash in gtk bots (filter-empty-g.svg) after r69181.
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
- 7:53 AM Changeset in webkit [69192] by
-
- 13 edits in trunk/WebCore
Rename HitTestResult::rectFromPoint to rectForPoint
https://bugs.webkit.org/show_bug.cgi?id=47261
Patch by Antonio Gomes <agomes@rim.org> on 2010-10-06
Reviewed by Kenneth Rohde Christiansen.
As per Kenneth Christiansen request inhttps://bugs.webkit.org/show_bug.cgi?id=46336#c20.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):
- rendering/HitTestResult.h:
(WebCore::HitTestResult::rectForPoint):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestColumns):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
- 7:44 AM Changeset in webkit [69191] by
-
- 189 edits374 adds in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
Generate SVG pixel test baseline for Snow Leopard (placed in platform/mac/svg). Where the results differ in Leopard
place new results in platform/mac-leopard/svg. As I finally have a 10.5 and 10.6 machine, we can now maintain two
baselines.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum: Added.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
...
- 6:42 AM Changeset in webkit [69190] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-10-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: test that uncaught exceptions have stack trace when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=47250
- http/tests/inspector/console-tests2.js: Added. (initialize_ConsoleTest.InspectorTest.dumpConsoleMessages): (initialize_ConsoleTest.InspectorTest.expandConsoleMessages): (initialize_ConsoleTest):
- inspector/console-uncaught-exception.html: Added.
- platform/chromium/inspector/console-uncaught-exception-expected.txt: Added.
- 6:33 AM Changeset in webkit [69189] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-10-06 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Rebased test expectations after r69185.
- inspector/report-protocol-errors-expected.txt:
- platform/mac-leopard/inspector/extensions-resources-expected.txt: Added.
- 6:06 AM Changeset in webkit [69188] by
-
- 99 edits in trunk/LayoutTests
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber stamped by Dirk Schulze.
SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526
Land new mac pixel test baseline after the filter patch.
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
- platform/mac-leopard/svg/batik/filters/feTile-expected.png:
- platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum:
- platform/mac-leopard/svg/filters/feGaussianBlur-expected.png:
- platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum:
- platform/mac-leopard/svg/filters/shadow-on-filter-expected.png:
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum:
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/mac/svg/batik/filters/filterRegions-expected.checksum:
- platform/mac/svg/batik/filters/filterRegions-expected.png:
- platform/mac/svg/batik/text/textEffect-expected.checksum:
- platform/mac/svg/batik/text/textEffect-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/batik/text/textFeatures-expected.checksum:
- platform/mac/svg/batik/text/textFeatures-expected.png:
- platform/mac/svg/custom/convolution-crash-expected.checksum:
- platform/mac/svg/custom/convolution-crash-expected.png:
- platform/mac/svg/custom/empty-merge-expected.checksum:
- platform/mac/svg/custom/empty-merge-expected.png:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/mac/svg/custom/non-opaque-filters-expected.checksum:
- platform/mac/svg/custom/non-opaque-filters-expected.png:
- platform/mac/svg/custom/recursive-filter-expected.checksum:
- platform/mac/svg/custom/recursive-filter-expected.png:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/mac/svg/custom/text-filter-expected.checksum:
- platform/mac/svg/custom/text-filter-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
- platform/mac/svg/filters/big-sized-filter-expected.checksum:
- platform/mac/svg/filters/big-sized-filter-expected.png:
- platform/mac/svg/filters/feColorMatrix-values-expected.checksum:
- platform/mac/svg/filters/feColorMatrix-values-expected.png:
- platform/mac/svg/filters/feComposite-expected.checksum:
- platform/mac/svg/filters/feComposite-expected.png:
- platform/mac/svg/filters/feDisplacementMap-expected.checksum:
- platform/mac/svg/filters/feDisplacementMap-expected.png:
- platform/mac/svg/filters/feOffset-expected.checksum:
- platform/mac/svg/filters/feOffset-expected.png:
- platform/mac/svg/filters/feTile-expected.checksum:
- platform/mac/svg/filters/feTile-expected.png:
- platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
- platform/mac/svg/filters/filter-on-tspan-expected.checksum:
- platform/mac/svg/filters/filter-on-tspan-expected.png:
- platform/mac/svg/filters/filterRes-expected.checksum:
- platform/mac/svg/filters/filterRes-expected.png:
- platform/mac/svg/filters/filterRes1-expected.checksum:
- platform/mac/svg/filters/filterRes1-expected.png:
- platform/mac/svg/filters/filterRes3-expected.checksum:
- platform/mac/svg/filters/filterRes3-expected.png:
- platform/mac/svg/filters/filteredImage-expected.checksum:
- platform/mac/svg/filters/filteredImage-expected.png:
- platform/mac/svg/filters/parent-children-with-same-filter-expected.checksum:
- platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
- platform/mac/svg/filters/sourceAlpha-expected.checksum:
- platform/mac/svg/filters/sourceAlpha-expected.png:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
- platform/mac/svg/filters/subRegion-one-effect-expected.checksum:
- platform/mac/svg/filters/subRegion-one-effect-expected.png:
- platform/mac/svg/filters/subRegion-two-effects-expected.checksum:
- platform/mac/svg/filters/subRegion-two-effects-expected.png:
- platform/mac/svg/repaint/filter-repaint-expected.checksum:
- platform/mac/svg/repaint/filter-repaint-expected.png:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
- 5:47 AM Changeset in webkit [69187] by
-
- 5 edits in trunk/WebCore
2010-10-06 Dirk Schulze <krit@webkit.org>
Unreviewed fix of Cairo ports.
SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526
Fixed issues on Cairos shadow implementation after the changes to FilterEffects.
Cairo calculates the inflation of the effect rect itself. Respect this for FEGaussianBlur.
This is just a temporary solution, since Cairo and Qt will use ContextShadow soon.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::applyPlatformShadow): (WebCore::GraphicsContext::createShadowMask): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/filters/ImageBufferFilter.cpp: (WebCore::ImageBufferFilter::ImageBufferFilter): (WebCore::ImageBufferFilter::create):
- platform/graphics/filters/ImageBufferFilter.h: (WebCore::ImageBufferFilter::filterRegion): (WebCore::ImageBufferFilter::sourceImageRect):
- 5:29 AM Changeset in webkit [69186] by
-
- 10 edits in trunk/WebCore
2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Only execute first SVG text layout phase if needed
https://bugs.webkit.org/show_bug.cgi?id=47254
The first SVG text layout phase which computes the per-character metrics and extracts
the x/y/dx/dy/rotate values from the SVG DOM is currently executed upon every RenderSVGText::layout() call.
Optimize this, by only calling it:
- if x/y/dx/dy/rotate value lists change
- the style of a RenderSVGInlineText changes (eg. font-size changes influence metrics)
- the text content of any of the children in the <text> subtree change
No change in layout tests, a pure performance change - covered by existing tests.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor(). (WebCore::clipToTextMask): Ditto.
- rendering/SVGRenderSupport.cpp:
- rendering/SVGRenderSupport.h: Move findTreeRootObject to RenderSVGText::locateRenderSVGTextAncestor().
- rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor(). (WebCore::RenderSVGInline::strokeBoundingBox): Ditto. (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): Ditto. (WebCore::RenderSVGInline::absoluteQuads): Ditto.
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange): Call setNeedsPositioningValuesUpdate() on the RenderSVGText root object, if diff == StyleDifferenceLayout.
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): Initialize m_needsPositioningValuesUpdate. (WebCore::RenderSVGText::locateRenderSVGTextAncestor): New helper function, moved from SVGRenderSupport, to a more sensible place. (WebCore::RenderSVGText::layout): Only execute the first SVG text layout phase, if m_needsPositioningValuesUpdate=true.
- rendering/svg/RenderSVGText.h: (WebCore::RenderSVGText::setNeedsPositioningValuesUpdate): (WebCore::toRenderSVGText): Add new helper casting methods, like most other renderers have.
- svg/SVGTextPositioningElement.cpp: (WebCore::updatePositioningValuesInRenderer): (WebCore::SVGTextPositioningElement::svgAttributeChanged): If x/y/dx/dy/rotate changes, call setNeedsPositioningValuesUpdate on the RenderSVGText root object. (WebCore::SVGTextPositioningElement::childrenChanged): If any children changes (addition, removal), do the same.
- svg/SVGTextPositioningElement.h:
- 5:27 AM Changeset in webkit [69185] by
-
- 14 edits in trunk
2010-10-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] Expose access to resource bodies
Added support for encoding resource in WebInspector.getResourceContent()
https://bugs.webkit.org/show_bug.cgi?id=45953
- inspector/Inspector.idl: Added encoding parameter to getResourceContent()
- inspector/InspectorController.cpp: (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: Added sourceBytes() to return encoded representation of resource's binary body. (WebCore::InspectorResource::sourceBytes):
- inspector/InspectorResource.h:
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype.getContent):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._onGetResourceContent.onContentAvailable): (WebInspector.getEncodedResourceContent):
- inspector/front-end/NetworkPanel.js: (WebInspector.getResourceContent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.getResourceContent):
2010-10-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] Expose access to resource bodies
https://bugs.webkit.org/show_bug.cgi?id=45953
- inspector/extensions-api-expected.txt:
- inspector/extensions-resources-expected.txt:
- inspector/extensions-resources.html:
- 5:10 AM Changeset in webkit [69184] by
-
- 10 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=47235
Reviewed by Dan Bernstein.
Make "lr" block-flow fieldsets work.
(1) Patched html.css rules for legends and fieldsets to use logical margins and padding.
(2) Converted just enough of computePreferredLogicalWidths to make basic examples work.
(3) Removed the extra border drawing code from fieldsets so that the "clip out the legend" approach
is now just always used. It's silly to keep the old border drawing code in (which has already gotten out
of sync with the base class) just to avoid a save/restore and some clipping.
(4) Modified the layout/painting routines to place the legend properly and to be able to draw it in
both the top and the left borders.
Added fast/blockflow/fieldsets.html
WebCore:
- css/html.css:
(legend):
(fieldset):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::computePreferredLogicalWidths):
- rendering/RenderBlock.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutLegend):
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h:
LayoutTests:
- fast/blockflow/fieldsets.html: Added.
- platform/mac/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/mac/fast/blockflow/fieldsets-expected.png: Added.
- platform/mac/fast/blockflow/fieldsets-expected.txt: Added.
- platform/mac/fast/forms/fieldset-align-expected.checksum:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- 3:59 AM Changeset in webkit [69183] by
-
- 6 edits2 adds in trunk/WebCore
2010-10-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Move parseDataUrl() from CURL into own file
https://bugs.webkit.org/show_bug.cgi?id=41462
Move the data URL parsing algorithm into a new file to use it in ResourceHandleWin too.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- platform/network/DataURL.cpp: Added. (WebCore::handleDataURL):
- platform/network/DataURL.h: Added.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::dispatchSynchronousJob): (WebCore::ResourceHandleManager::startJob):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer):
- 3:40 AM Changeset in webkit [69182] by
-
- 3 edits in trunk/LayoutTests
2010-10-06 Dirk Schulze <krit@webkit.org>
Unreviewed new baseline for Qt.
SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- 2:45 AM Changeset in webkit [69181] by
-
- 44 edits12 adds in trunk
2010-10-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526
SVG filter effects need smarter size calculation
https://bugs.webkit.org/show_bug.cgi?id=31370
SVG elements use Filters before own transformations
https://bugs.webkit.org/show_bug.cgi?id=32486
Calculate all filter results in device space instead of the filtered objects user space. This change is similar to
the patches for SVG Pattern and SVG Masker before. It avoids pixelation and guarantees smooth filter results for
every scale level and is independent of any transformation to the target element or any ancester of the target.
The second part of this patch reduces the size of every effect to the smallest affected region instead of the complete
filter primitive subregion (http://www.w3.org/TR/SVG/filters.html#FilterPrimitiveSubRegion). We just use the subregion
as clipping region, like mentioned in the SVG specification, to make the affected region even smaller now.
This is a huge speed up. The ECMA cloud (http://ejohn.org/files/ecma-cloud.svg) is more than 100 times faster on Gtk and
renders in less than a second.
Some examples on svg-wow.org can be viewed the first time now, since the subregions were much bigger than the affected
region.
There's still more potential to speed up filters, by further reducing the ImageBuffer sizes.
Renamed repaintRectInLocalCoordinates to absolutePaintRect, since all coordinates are in device space instead of the
user space now.
The absolute paint rect is calculated by determineAbsolutePaintRect() and gets called by FilterEffect::effectContext() on
applying the effect.
Partly rewrote filter resolution (http://www.w3.org/TR/SVG/filters.html#FilterElementFilterResAttribute) to work with the
new concept. This also corrects the old behavior to match the SVG specification.
Tests: svg/filters/filterRes1.svg
svg/filters/filterRes2.svg
svg/filters/filterRes3.svg
- platform/graphics/cairo/GraphicsContextCairo.cpp: Call setAbsolutePaintRect instead of setRepaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
- platform/graphics/filters/FEBlend.cpp: Renamed repaintRectInLocalCoordinates to absolutePaintRect. (WebCore::FEBlend::apply):
- platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::determineAbsolutePaintRect): (WebCore::FEComposite::apply):
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::apply):
- platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
- platform/graphics/filters/FEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::apply):
- platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
- platform/graphics/filters/FEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
- platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
- platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::calculateKernelSize): (WebCore::FEGaussianBlur::determineAbsolutePaintRect): (WebCore::FEGaussianBlur::apply):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp: Ditto. (WebCore::FELighting::apply):
- platform/graphics/filters/FEMerge.cpp: Ditto. (WebCore::FEMerge::apply):
- platform/graphics/filters/FEMorphology.cpp: Ditto. (WebCore::FEMorphology::determineAbsolutePaintRect): (WebCore::FEMorphology::apply):
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FEOffset.cpp: Ditto. (WebCore::FEOffset::determineAbsolutePaintRect): (WebCore::FEOffset::apply):
- platform/graphics/filters/FEOffset.h:
- platform/graphics/filters/FETile.cpp: Ditto. (WebCore::FETile::determineFilterPrimitiveSubregion): (WebCore::FETile::apply):
- platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
- platform/graphics/filters/FETurbulence.cpp: Ditto. (WebCore::FETurbulence::apply):
- platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
- platform/graphics/filters/Filter.h: (WebCore::Filter::applyHorizontalScale): Map horizontal effect values to absolute coordinates. (WebCore::Filter::applyVerticalScale): Map vertical effect values to absolute coordinates. (WebCore::Filter::mapAbsolutePointToLocalPoint): (WebCore::Filter::filterRegionInUserSpace):
- platform/graphics/filters/FilterEffect.cpp: Ditto. (WebCore::FilterEffect::determineFilterPrimitiveSubregion): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::requestedRegionOfInputImageData): (WebCore::FilterEffect::drawingRegionOfInputImage): (WebCore::FilterEffect::effectContext):
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::absolutePaintRect): (WebCore::FilterEffect::setAbsolutePaintRect): (WebCore::FilterEffect::maxEffectRect): The subregion in absolute coordinates for SVG. (WebCore::FilterEffect::setMaxEffectRect):
- platform/graphics/filters/SourceAlpha.cpp: Ditto. (WebCore::SourceAlpha::determineAbsolutePaintRect): (WebCore::SourceAlpha::apply):
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp: Ditto. (WebCore::SourceGraphic::determineAbsolutePaintRect): (WebCore::SourceGraphic::apply):
- platform/graphics/filters/SourceGraphic.h:
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/RenderSVGResourceFilter.h: (WebCore::FilterData::FilterData):
- svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h: (WebCore::FEImage::determineAbsolutePaintRect):
- svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): (WebCore::SVGFilter::applyHorizontalScale): (WebCore::SVGFilter::applyVerticalScale): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::effectBoundingBoxMode): (WebCore::SVGFilter::filterRegionInUserSpace): (WebCore::SVGFilter::filterRegion): (WebCore::SVGFilter::mapAbsolutePointToLocalPoint): Map absolute point to local point in userspace. (WebCore::SVGFilter::sourceImageRect): (WebCore::SVGFilter::maxImageSize):
2010-10-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526
Added three new tests for SVGs filterRes.
Shadow tests for SVG Filter needed an update. Current tests didn't respect
primitiveUnits "objectBoundingBox" for stdDeviation on feGaussianBlur correctly.
- platform/mac/svg/filters/filterRes1-expected.checksum: Added.
- platform/mac/svg/filters/filterRes1-expected.png: Added.
- platform/mac/svg/filters/filterRes1-expected.txt: Added.
- platform/mac/svg/filters/filterRes2-expected.checksum: Added.
- platform/mac/svg/filters/filterRes2-expected.png: Added.
- platform/mac/svg/filters/filterRes2-expected.txt: Added.
- platform/mac/svg/filters/filterRes3-expected.checksum: Added.
- platform/mac/svg/filters/filterRes3-expected.png: Added.
- platform/mac/svg/filters/filterRes3-expected.txt: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- svg/filters/filterRes1.svg: Added.
- svg/filters/filterRes2.svg: Added.
- svg/filters/filterRes3.svg: Added.
- svg/filters/shadow-on-filter.svg:
- svg/filters/shadow-on-rect-with-filter.svg:
- 1:55 AM QtWebKitDocContrib edited by
- (diff)
- 1:36 AM QtWebKitDocContrib edited by
- (diff)
- 1:17 AM Changeset in webkit [69180] by
-
- 3 edits in trunk/WebCore
2010-10-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add "Set Breakpoint" item to XHR resource context menu.
https://bugs.webkit.org/show_bug.cgi?id=47085
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._contextMenu):
- 12:37 AM Changeset in webkit [69179] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-10-06 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Add Chromium results for r69176.
- platform/chromium-linux/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/chromium-linux/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/chromium-mac/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
- platform/chromium/test_expectations.txt:
