Timeline
Oct 10, 2010:
- 11:58 PM Changeset in webkit [69478] by
-
- 1 edit1 add in trunk/LayoutTests
2010-10-10 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Rebaseline overhanging-floats-removed test for GTK platform.
- platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
- 11:34 PM Changeset in webkit [69477] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added Radar ULR
- 11:29 PM Changeset in webkit [69476] by
-
- 3 edits4 adds in trunk
2010-10-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Overhanging floats are not added to flexible boxes since they behave like
block formatting contexts. This causes the intruding floats added in siblings
to not get cleared. Enforce the float release by checking if the parent is a
flexible box and if yes, use that as the outermost block.
Test: fast/flexbox/overhanging-floats-removed.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2010-10-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Tests that intruding floats get properly cleared in flexible box layout.
https://bugs.webkit.org/show_bug.cgi?id=47104
- fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
- fast/flexbox/overhanging-floats-removed-expected.png: Added.
- fast/flexbox/overhanging-floats-removed-expected.txt: Added.
- fast/flexbox/overhanging-floats-removed.html: Added.
- 3:57 PM Changeset in webkit [69475] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-10 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Windows build fix after r69472.
- wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
- 3:18 PM Changeset in webkit [69474] by
-
- 3 edits2 adds in trunk
2010-10-10 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443
- platform/mac/accessibility/live-region-on-span-expected.txt: Added.
- platform/mac/accessibility/live-region-on-span.html: Added.
2010-10-10 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
AX: if aria-live is on a <span> or ignored element, live regions don't work
https://bugs.webkit.org/show_bug.cgi?id=47443
If an element has aria attributes, but has no other native role associated with it,
accessibility should fallback to exposing that element as an AXGroup.
Test: platform/mac/accessibility/live-region-on-span.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- 2:05 PM Changeset in webkit [69473] by
-
- 2 edits in trunk/WebKitTools
2010-10-10 Robert Hogan <robert@webkit.org>
Unreviewed, fix failing test from r69468.
[Qt] Put all DRT-created pages in a page group
Fix on r69468.
Because we don't delete closed pages immediately in DRT we need
to remove them from the page group explicitly instead.
Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
- 1:19 PM Changeset in webkit [69472] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Use WTF::StringHasher in WTF::CaseFoldingHash
https://bugs.webkit.org/show_bug.cgi?id=46523
- wtf/text/StringHash.h: (WTF::CaseFoldingHash::foldCase): (WTF::CaseFoldingHash::hash):
- 1:00 PM Changeset in webkit [69471] by
-
- 2 edits in trunk/WebKitTools
2010-10-10 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Barth.
commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
EFL-EWS bot is up and running.
https://bugs.webkit.org/show_bug.cgi?id=47277
- QueueStatusServer/handlers/statusbubble.py:
- 12:48 PM Changeset in webkit [69470] by
-
- 5 edits in trunk
2010-10-10 Daniel Cheng <dcheng@chromium.org>
Reviewed by Adam Barth.
[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
https://bugs.webkit.org/show_bug.cgi?id=47419
This was a regression introduced in r68807. Updated the layout test to
check for this case.
- editing/pasteboard/dataTransfer-setData-getData-expected.txt:
- editing/pasteboard/script-tests/dataTransfer-setData-getData.js: (runTest):
2010-10-10 Daniel Cheng <dcheng@chromium.org>
Reviewed by Adam Barth.
[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
https://bugs.webkit.org/show_bug.cgi?id=47419
This was a regression introduced in r68807. mimeTypeText had the incorrect
value.
Test: editing/pasteboard/dataTransfer-setData-getData.html
- platform/chromium/ClipboardMimeTypes.cpp:
- 12:46 PM Changeset in webkit [69469] by
-
- 3 edits1 add in trunk/LayoutTests
2010-10-10 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
<a ping> tests are slow
https://bugs.webkit.org/show_bug.cgi?id=47431
The ping tests showed up as being flaky in Adam Barth's email; this
might just be due to them being on the slow side due to the 1 second
refresh in check-ping.php. We can instead switch to using file_exists
in a loop if we invalidate the file status cache. Running the three
ping tests with --iterations=10 now takes 4 seconds instead of 23.
This surfaces a race condition in image-load-in-unload-handler.html
(we don't start sending data till we get the ping, but unload handlers
(where the ping is sent) aren't run till we start getting data). Fixed
by adding a dummy page in between.
- http/tests/navigation/resources/check-ping.php:
- http/tests/navigation/image-load-in-unload-handler.html:
- http/tests/navigation/resources/ping-redirect.html: Added.
- 10:44 AM Changeset in webkit [69468] by
-
- 4 edits in trunk
2010-10-10 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Put all DRT-created pages in a page group
Unskip:
http/tests/security/frameNavigation/not-opener.html
http/tests/navigation/target-frame-from-window.html
- platform/qt/Skipped:
2010-10-10 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Put all DRT-created pages in a page group
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow):
- 7:23 AM Changeset in webkit [69467] by
-
- 5 edits in trunk
This reverts commit http://trac.webkit.org/changeset/69465
Debug statments that should not be committed.
- 7:14 AM Changeset in webkit [69466] by
-
- 2 edits1 add2 deletes in trunk/LayoutTests
2010-10-10 Antonio Gomes <agomes@rim.com>
Reviewed by Andreas Kling.
editing/selection/extend-after-mouse-selection.html should useLayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=47468
Changed editing/selection/extend-after-mouse-selection.html to use the LayoutTestController::setEditingBehavior
machinary. It makes it possible to remove platform dependent test results by testing through all
platform-specific codepath's we have.
- editing/selection/extend-after-mouse-selection.html:
- platform/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
- platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
- 7:14 AM Changeset in webkit [69465] by
-
- 5 edits in trunk
tmp
Oct 9, 2010:
- 9:17 PM Changeset in webkit [69464] by
-
- 2 edits in trunk/BugsSite
2010-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Exception in committers-autocomplete in Firefox
https://bugs.webkit.org/show_bug.cgi?id=47456
Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for
the long-term health of the web, but that's a discussion for another
patch.
- committers-autocomplete.js:
- 7:15 PM Changeset in webkit [69463] by
-
- 2 edits in trunk/WebCore
2010-10-09 Eric Uhrhane <ericu@chromium.org>
Reviewed by Andreas Kling.
FileWriter sends write event instead of progress event
https://bugs.webkit.org/show_bug.cgi?id=47454
No new tests; FileWriter tests will be added shortly, but currently
there's no implementation capable of running them.
- fileapi/FileWriter.cpp: (WebCore::FileWriter::didWrite):
- 4:56 PM Changeset in webkit [69462] by
-
- 2 edits in trunk/WebCore
2010-10-09 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fast-path in Path::clear() for already empty paths
https://bugs.webkit.org/show_bug.cgi?id=47460
The only way to clear a QPainterPath is to assign QPainterPath() to it.
Avoid creating a temporary object etc if the path is already empty.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::clear):
- 4:18 PM Changeset in webkit [69461] by
-
- 8 edits1 add in trunk
WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
<rdar://problem/8173667>
https://bugs.webkit.org/show_bug.cgi?id=47461
Reviewed by Dan Bernstein.
WebKit2:
API Test: WebKit2/FailedLoad
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
Set the frame load state to LoadStateFinished for both didFailProvisionalLoadForFrame
and didFailLoadForFrame.
WebKitTools:
- TestWebKitAPI/PlatformUtilities.h:
- TestWebKitAPI/Test.h:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::URLForNonExistentResource):
Adds a test for the frame load state after a failed provisional load. I wanted to test
the frame load state after a committed load failed, but I don't believe that is possible
to do without hooking up the http server to serve a long loading page.
- 2:58 PM Changeset in webkit [69460] by
-
- 12 edits in trunk
Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
<rdar://problem/8447690>
https://bugs.webkit.org/show_bug.cgi?id=47459
Reviewed by Dan Bernstein.
WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::canRunBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebUIClient::runBeforeUnloadConfirmPanel):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
Pipe calls through to the UIProcess.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(runBeforeUnloadConfirmPanel):
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 2:30 PM Changeset in webkit [69459] by
-
- 8 edits in trunk/WebKit/chromium
2010-10-09 Varun Jain <varunjain@chromium.org>
Reviewed by Darin Fisher.
Adding one method to the WebView interface: method to inform the
renderer to scroll the currently focused element into view, for
instance, when it is hidden due to window resizing.
Also adding methods to WebNode and WebElement to expose more
features of the underlying WebCore::Node.
https://bugs.webkit.org/show_bug.cgi?id=46296
- public/WebElement.h:
- public/WebNode.h:
- public/WebView.h:
- src/WebElement.h: (WebKit::WebElement::isTextFormControlElement):
- src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
- src/WebViewImpl.h:
- 1:59 PM Changeset in webkit [69458] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-09 Pratik Solanki <psolanki@apple.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=47445
Remove unused function WTFThreadData::initializeIdentifierTable()
- wtf/WTFThreadData.h:
- 1:32 PM Changeset in webkit [69457] by
-
- 31 edits1 add in trunk
Need implementation of ChromeClient windowRect related functions.
<rdar://problem/8469476>
https://bugs.webkit.org/show_bug.cgi?id=47386
Reviewed by Dan Bernstein.
WebKit2:
- Shared/API/c/WKGeometry.h: Added.
Adds WKPoint, WKSize and WKRect structs.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toImpl):
(WebKit::toAPI):
Add conversion functions for WKRect.
- Shared/WebCoreArgumentCoders.h:
Add encoding for FloatPoint, FloatSize and FloatRect.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::transformToDeviceSpace):
(WebKit::PageClientImpl::transformToUserSpace):
- UIProcess/API/mac/WKView.mm:
(-[WKView _transformToDeviceSpace:]):
(-[WKView _transformToUserSpace:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::transformToDeviceSpace):
(QWKPagePrivate::transformToUserSpace):
(QWKPage::QWKPage):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::setWindowFrame):
(WebKit::WebUIClient::windowFrame):
- UIProcess/WebUIClient.h:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setEditCommandState):
(WebKit::WebView::transformToDeviceSpace):
(WebKit::WebView::transformToUserSpace):
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setWindowFrame):
(WebKit::WebChromeClient::windowFrame):
Pipe calls through to the UIProcess, and give ports a chance to transform
the rect (via the PageClient) before it is passed on.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(getWindowFrame):
(setWindowFrame):
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
- 1:26 PM Changeset in webkit [69456] by
-
- 10 edits in trunk/LayoutTests
2010-10-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix.
Reverted changes to platform/*/editing that were accidently committed in r69453.
- platform/chromium-win/editing/inserting/editable-html-element-expected.txt:
- platform/chromium-win/editing/selection/editable-html-element-expected.txt:
- platform/chromium-win/editing/selection/editable-links-expected.txt:
- platform/chromium-win/editing/selection/focus_editable_html-expected.txt:
- platform/chromium-win/editing/style/designmode-expected.txt:
- platform/qt/editing/inserting/editable-html-element-expected.txt:
- platform/qt/editing/selection/editable-html-element-expected.txt:
- platform/qt/editing/selection/focus_editable_html-expected.txt:
- platform/qt/editing/style/designmode-expected.txt:
- 1:21 PM Changeset in webkit [69455] by
-
- 1 edit12 adds in trunk/LayoutTests
2010-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
CSS: style attributes on closing tags gets applied to element
https://bugs.webkit.org/show_bug.cgi?id=14423
We fixed these bugs with the HTML5 parser. Go us.
- fast/parser/stray-end-tags-with-attributes-001-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-001-quirks-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-001-quirks.html: Added.
- fast/parser/stray-end-tags-with-attributes-001.html: Added.
- fast/parser/stray-end-tags-with-attributes-002-alt-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-002-alt-quirks-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-002-alt-quirks.html: Added.
- fast/parser/stray-end-tags-with-attributes-002-alt.html: Added.
- fast/parser/stray-end-tags-with-attributes-002-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-002-quirk-expected.txt: Added.
- fast/parser/stray-end-tags-with-attributes-002-quirk.html: Added.
- fast/parser/stray-end-tags-with-attributes-002.html: Added.
- 12:57 PM Changeset in webkit [69454] by
-
- 1 edit in trunk/WebCore/ChangeLog
Unreviewed. Removed WebCore::ApplyStyleCommand::printStyle from WebCore/ChangeLog.
- 12:49 PM Changeset in webkit [69453] by
-
- 13 edits2 adds in trunk
2010-10-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Redo in ReplaceNodeWithSpanCommand is broken
https://bugs.webkit.org/show_bug.cgi?id=47428
The bug was caused by ReplaceNodeWithSpanCommand's inheriting from CompositeEditCommand,
and ReplaceNodeWithSpanCommand's not implementing doReapply. Because ReplaceNodeWithSpanCommand's doApply
directly modifies DOM and does not use simple edit commands while CompositeEditCommand's doReapply
only calls reapply of compositing simple edit commands, ReplaceNodeWithSpanCommand's doReapply was no-op.
Fixed the bug by changing the base class of ReplaceNodeWithSpanCommand to SimpleEditCommand.
This allows ReplaceNodeWithSpanCommand's doReapply to call its doApply, which already supports redo operation.
Test: editing/undo/replace-by-span-then-remove.html
- editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::printStyle):
- editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
- editing/ReplaceNodeWithSpanCommand.h:
2010-10-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Redo in ReplaceNodeWithSpanCommand is broken
https://bugs.webkit.org/show_bug.cgi?id=47428
Added a test to ensure replacing a node with span can be redone,
and doing so does not disrupt subsequent redo's.
- editing/undo/replace-by-span-then-remove-expected.txt: Added.
- editing/undo/replace-by-span-then-remove.html: Added.
- 11:36 AM Changeset in webkit [69452] by
-
- 4 edits1 add in trunk
2010-10-09 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement subregion rendering in WebView when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=47411
- GNUmakefile.am:
- platform/graphics/FloatRect.h:
- platform/graphics/cairo/FloatRectCairo.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator cairo_rectangle_t):
- 11:25 AM Changeset in webkit [69451] by
-
- 1 edit8 adds in trunk/LayoutTests
2010-10-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix url conversion in QWebHistory
Add results for:
http/tests/navigation/error404-basic.html
http/tests/navigation/error404-goback.html
http/tests/navigation/error404-subframeload.html
http/tests/navigation/javascriptlink-frames.html
http/tests/navigation/postredirect-basic.html
http/tests/navigation/postredirect-frames.html
http/tests/navigation/postredirect-goback1.html
- platform/qt/http/tests/navigation/error404-basic-expected.txt: Added.
- platform/qt/http/tests/navigation/error404-goback-expected.txt: Added.
- platform/qt/http/tests/navigation/error404-subframeload-expected.txt: Added.
- platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
- platform/qt/http/tests/navigation/postredirect-basic-expected.txt: Added.
- platform/qt/http/tests/navigation/postredirect-frames-expected.txt: Added.
- platform/qt/http/tests/navigation/postredirect-goback1-expected.txt: Added.
- 11:11 AM Changeset in webkit [69450] by
-
- 2 edits in trunk/WebCore
2010-10-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture
https://bugs.webkit.org/show_bug.cgi?id=47114
PlatformContextSkia's m_uploadTexture is used only in code guarded with ENABLE(ACCELERATED_2D_CANVAS).
- platform/graphics/skia/PlatformContextSkia.h:
- 8:32 AM Changeset in webkit [69449] by
-
- 2 edits in trunk/WebCore
2010-10-09 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Use WTF::StringHasher for hashing MappedAttributeKey
https://bugs.webkit.org/show_bug.cgi?id=46516
- dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
- 8:24 AM Changeset in webkit [69448] by
-
- 2 edits in trunk/WebCore
2010-10-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Non-rectangular buttons have a square background behind them
https://bugs.webkit.org/show_bug.cgi?id=23569
Remove some code which was clearing pieces of the GdkDrawable if it was
currently mapped to a window. In our case it is unnecessary, because the
platform-independent parts of the render have already cleared this section
if it is needed.
Mozilla must not trip this code path, which means they are probably rendering
most often to a non-mapped GdkPixmap.
No new tests as some themed rendering is covered by existing tests that
render buttons. This particular bug is very hard to test as it only appears
with certain GTK+ themes and we currently have no mechanism to test different
themes in DRT.
- platform/gtk/gtk2drawing.c: (moz_gtk_button_paint): Remove unnecessary code.
- 8:17 AM Changeset in webkit [69447] by
-
- 3 edits2 adds in trunk
2010-10-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435
Added a pixel test result for this issue.
- platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
- platform/gtk/fast/forms/slider-padding-expected.png: Added.
2010-10-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Slider padding translate into a larger track rect
https://bugs.webkit.org/show_bug.cgi?id=47435
Instead of painting the track rectangle for ranges onto the entire RenderBox
rectangle, simply paint it on the content rectangle. This prevents misrendering
sliders with padding.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect of the slider instead of the entire area (which includes padding).
- 6:49 AM Changeset in webkit [69446] by
-
- 3 edits in trunk/WebCore
Unreviewed, trivial regression fix for r69445.
RangeInputType::supportsRequired() should return false.
https://bugs.webkit.org/show_bug.cgi?id=47405
- html/RangeInputType.cpp:
(WebCore::RangeInputType::supportsRequired):
- html/RangeInputType.h:
- 6:27 AM Changeset in webkit [69445] by
-
- 36 edits in trunk/WebCore
Refactor HTMLInputElement: Move typeMismatch(), valueMissing(),
isRequiredFormControl(), and recalcWillValidate()
https://bugs.webkit.org/show_bug.cgi?id=47405
Reviewed by Dimitri Glazkov.
Also make checkedRadioButtons() an inline member function of
HTMLInputElement in order that RadioInputType can use it.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::typeMismatchFor):
(WebCore::BaseDateAndTimeInputType::typeMismatch):
- html/BaseDateAndTimeInputType.h:
- html/ButtonInputType.cpp:
(WebCore::ButtonInputType::supportsValidation):
- html/ButtonInputType.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::valueMissing):
- html/CheckboxInputType.h:
- html/ColorInputType.cpp:
(WebCore::isValidColorString):
(WebCore::ColorInputType::typeMismatchFor):
(WebCore::ColorInputType::typeMismatch):
(WebCore::ColorInputType::supportsRequired):
- html/ColorInputType.h:
- html/EmailInputType.cpp:
(WebCore::isValidEmailAddress):
(WebCore::EmailInputType::typeMismatchFor):
(WebCore::EmailInputType::typeMismatch):
- html/EmailInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::valueMissing):
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::isValidValue):
(WebCore::HTMLInputElement::typeMismatch):
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::isRequiredFormControl):
(WebCore::HTMLInputElement::recalcWillValidate):
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::checkedRadioButtons):
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::supportsValidation):
- html/HiddenInputType.h:
- html/ImageInputType.cpp:
(WebCore::ImageInputType::supportsValidation):
- html/ImageInputType.h:
- html/InputType.cpp:
(WebCore::InputType::supportsValidation):
(WebCore::InputType::typeMismatchFor):
(WebCore::InputType::typeMismatch):
(WebCore::InputType::supportsRequired):
(WebCore::InputType::valueMissing):
- html/InputType.h:
- html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::supportsRequired):
- html/IsIndexInputType.h:
- html/NumberInputType.cpp:
(WebCore::NumberInputType::typeMismatchFor):
(WebCore::NumberInputType::typeMismatch):
- html/NumberInputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::valueMissing):
- html/RadioInputType.h:
- html/ResetInputType.cpp:
(WebCore::ResetInputType::supportsValidation):
- html/ResetInputType.h:
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::supportsValidation):
- html/SubmitInputType.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::valueMissing):
- html/TextFieldInputType.h:
- html/URLInputType.cpp:
(WebCore::URLInputType::typeMismatchFor):
(WebCore::URLInputType::typeMismatch):
- html/URLInputType.h:
- html/ValidityState.cpp:
(WebCore::ValidityState::typeMismatch):
- 3:28 AM Changeset in webkit [69444] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-09 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Removed unused callback in webkitwebview
https://bugs.webkit.org/show_bug.cgi?id=47092
In webkit_web_view_forward_context_menu_event() a callback is
connected for the destroy signal of the popup menu, however we
reuse the same menu always, holding a ref to it, so it's not
destroyed when withdrawn by the user.
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 1:39 AM Changeset in webkit [69443] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed fix after r69413.
[Qt] Add platform specific expected result, because this test passes.
Compared to Mac png files and Mac expected files.
- platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
- 12:11 AM Changeset in webkit [69442] by
-
- 2 edits in trunk/WebCore
2010-10-09 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=47450
Crash in WebCore::SocketStreamHandle::chooseProxyFromArray because proxyArray passed is nil
<rdar://problem/8244376>
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxyFromArray): If proxyArray is NULL, return early to avoid crash.
