⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 11, 2010:

11:17 PM Changeset in webkit [69561] by hamaji@chromium.org
  • 5 edits in trunk/WebKit/win

2010-10-11 Shinichiro Hamaji <​hamaji@chromium.org>

Attempt to fix windows build failure.

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=47523

  • Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
  • Interfaces/WebKit.idl: Touched.
  • WebFrame.cpp: s/unused1/unused2/ (WebFrame::unused2):
  • WebFrame.h: s/unused1/unused2/
9:08 PM Changeset in webkit [69560] by dumi@chromium.org
  • 5 edits
    2 adds in trunk

2010-10-11 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
​https://bugs.webkit.org/show_bug.cgi?id=47318

Without this reference, the Blob might get garbage-collected from JS
before the write has completed, which would be quite unintuitive to the
user. I just grab a RefPtr to the Blob at write(), then clear it when
we're done.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::stop): (WebCore::FileWriter::write): (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didFail):
  • fileapi/FileWriter.h:

2010-10-11 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
​https://bugs.webkit.org/show_bug.cgi?id=47318

Added the first FileWriter test to cover this.
Problem #1: it's not a deterministic problem; the test might or might
not catch the error, but at least it won't ever trigger a false
positive.
Problem #2: no platform fully implements FileWriter yet, so this test
must start out completely supressed. All non-chromium platforms
already skip all filesystem tests, so I'm only adding a suppression in
chromium.

  • fast/filesystem/file-writer-gc-blob-expected.txt: Added.
  • fast/filesystem/file-writer-gc-blob.html: Added.
  • platform/chromium/test_expectations.txt:
7:42 PM Changeset in webkit [69559] by beidson@apple.com
  • 5 edits in trunk/WebKit2

Address some of Darin's review feedback in ​https://bugs.webkit.org/show_bug.cgi?id=47354
that wasn't left till after my original commit.

Reviewed by Darin Adler of the past.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopySessionState): Nuke the temporary variable.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: Fix up function declarations.


  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Use sizeof(UInt32) instead of 4.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:41 PM Changeset in webkit [69558] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some failing GTK+ tests.

  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
7:25 PM Changeset in webkit [69557] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating test_expectations.txt for passing tests.

  • platform/chromium/test_expectations.txt:
7:19 PM Changeset in webkit [69556] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Build fix for Windows in ​https://bugs.webkit.org/show_bug.cgi?id=47354

Reviewed by BUILD FIX.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Change to use CF APIs that exist on Windows.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:18 PM Changeset in webkit [69555] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. More expectation changes for green canary.

More expectations resulting from r69517.

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [69554] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 James Kozianski <​koz@chromium.org>

Reviewed by Simon Fraser.

Remove superflous comments from a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=47521

  • fast/css-generated-content/malformed-url.html:
7:12 PM Changeset in webkit [69553] by msaboff@apple.com
  • 18 edits
    2 adds in trunk

2010-10-11 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Added and changed tests to verify that DOMWindow objects are
create with appropriate constructors and that those constructors
are not callable directly.
​https://bugs.webkit.org/show_bug.cgi?id=47422

  • fast/dom/Window/window-constructor-expected.txt: Added.
  • fast/dom/Window/window-constructor.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/constructors-cached.js:
  • fast/dom/wrapper-classes-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put.html:
  • inspector/console-dir-global-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:

2010-10-11 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Changed DOMWindow to have a constructor. Updated the code generator
to add security checks to the constructors if CheckDomainSecurity is
set. Also changed the constructor generation code to use
globalObject->prototype() for DOMWindow object prototypes instead
of "self".
​https://bugs.webkit.org/show_bug.cgi?id=47422

Test: fast/dom/Window/window-constructor.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
7:04 PM Changeset in webkit [69552] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-11 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
​https://bugs.webkit.org/show_bug.cgi?id=47513

bugs.webkit.org suggests ​mrobinson@igalia.com as an autocomplete,
which doesn't actually work.

  • Scripts/webkitpy/common/config/committers.py:
6:52 PM Changeset in webkit [69551] by commit-queue@webkit.org
  • 15 edits
    2 copies in trunk

2010-10-11 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
​https://bugs.webkit.org/show_bug.cgi?id=44992

In order to allow a graceful transition, ChromiumDataObject has been
reimplemented as a wrapper around the three different types of data
objects that the Chrome port uses:

  1. ChromiumDataObjectLegacy -- this is the original ChromiumDataObject. All the data that ClipboardChromium/DragDataChromium can potentially use is copied over, regardless of whether or not it is needed.
  2. ReadableDataObject -- used for dragging in and pasting into WebKit. For efficiency, it caches an optimistic list of types it believes it can handle. When getData() is called, a browser IPC is called to retrieve the appropriate data.
  3. WritableDataObject -- similar to ChromiumDataObjectLegacy in that it buffers all data when dragging out of WebKit or copying/cutting. Unfortunately, there is a difference between dragging out and copying/cutting--on drag outs, the data is buffered and flushed out when startDrag() is called. For copy/cut, any calls to setData() result in a browser IPC right away, so calls to setData() in one copy/cut event are not atomic.

Copy and paste has been changed to use the new data objects. Dragging
out uses the legacy data object, and dragging in now has two potential
entry points--one using the legacy data object, and one using
ReadableDataObject. Once Chromium transitions to using the new drag-in
interface, the old interface will be removed.

This change is covered by existing tests.

  • WebCore.gypi:
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject): (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::createReadable): (WebCore::ChromiumDataObject::createWritable): (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ChromiumDataObjectLegacy.cpp: Copied from ChromiumDataObject.cpp (WebCore::ChromiumDataObjectLegacy::clearData): (WebCore::ChromiumDataObjectLegacy::clearAll): (WebCore::ChromiumDataObjectLegacy::clearAllExceptFiles): (WebCore::ChromiumDataObjectLegacy::hasData): (WebCore::ChromiumDataObjectLegacy::types): (WebCore::ChromiumDataObjectLegacy::getData): (WebCore::ChromiumDataObjectLegacy::setData): (WebCore::ChromiumDataObjectLegacy::ChromiumDataObjectLegacy):
  • platform/chromium/ChromiumDataObjectLegacy.h: Copied from ChromiumDataObject.h (WebCore::ChromiumDataObjectLegacy::create): (WebCore::ChromiumDataObjectLegacy::copy): (WebCore::ChromiumDataObjectLegacy::urlTitle): (WebCore::ChromiumDataObjectLegacy::setUrlTitle): (WebCore::ChromiumDataObjectLegacy::htmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::setHtmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::containsFilenames): (WebCore::ChromiumDataObjectLegacy::filenames): (WebCore::ChromiumDataObjectLegacy::setFilenames): (WebCore::ChromiumDataObjectLegacy::fileExtension): (WebCore::ChromiumDataObjectLegacy::setFileExtension): (WebCore::ChromiumDataObjectLegacy::fileContentFilename): (WebCore::ChromiumDataObjectLegacy::setFileContentFilename): (WebCore::ChromiumDataObjectLegacy::fileContent): (WebCore::ChromiumDataObjectLegacy::setFileContent):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):

2010-10-11 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
​https://bugs.webkit.org/show_bug.cgi?id=44992

Add a new entry point for drag in to allow a graceful transition
from the legacy drag and drop model, where all data is copied in at the
beginning of a drag, to a model where data is retrieved on demand via
IPCs. The rationale for this is when we begin supporting arbitrary MIME
types in dataTransfer, we don't want to be copying aribtrary amounts of
data over for each start drag IPC.

  • public/WebView.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize): Use the legacy data object. (WebKit::WebDragData::ensureMutable): Change the if to an ASSERT.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew): New entry point.
  • src/WebViewImpl.h:
6:39 PM Changeset in webkit [69550] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-11 Prasad Tammana <​prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=46759

  • platform/chromium/drt_expectations.txt: Removed show-modal-dialog tests.

2010-10-11 Prasad Tammana <​prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=46759

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop. (WebViewHost::runModal): Start a nested message loop and remember that. (WebViewHost::WebViewHost): Initialize m_inModalLoop.
  • DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop.
6:31 PM Changeset in webkit [69549] by andersca@apple.com
  • 19 edits
    8 deletes in trunk

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=47523

Reviewed by Darin Adler.

WebCore:

Remove all traces of the WebCore IconFetcher class. It's SPI that nobody uses.

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconFetcher.cpp: Removed.
  • loader/icon/IconFetcher.h: Removed.

WebKit:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Misc/WebIconFetcher.h: Removed.
  • Misc/WebIconFetcher.mm: Removed.
  • Misc/WebIconFetcherInternal.h: Removed.
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

WebKit/win:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebIconFetcher.idl: Removed.
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:

(WebFrame::unused1):

  • WebFrame.h:
  • WebIconFetcher.cpp: Removed.
  • WebIconFetcher.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
6:21 PM Changeset in webkit [69548] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

Should commit pending autocorrection before next round of text checking.
​https://bugs.webkit.org/show_bug.cgi?id=46986
<rdar://problem/8424535>

  1. Apply pending autocorrection before calling markAllMisspellingsAndBadGrammarInRanges().
  2. Remove unneccessary calls to dismissCorrectionPanel(), since the panel is dismissed when selection changes, which occurs after every typing command.
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Apply pending autocorrection. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Store current correction replacement in m_correctionReplacementString. (WebCore::Editor::startCorrectionPanelTimer): Remove call to dismissCorrectionPanel().
  • editing/Editor.h: Add m_correctionReplacementString to store proposed autocorrection string.
6:05 PM Changeset in webkit [69547] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Marking linux expectations as failues missed during the SVG sweep.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [69546] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam Barth.

Make fast/canvas/webgl/glsl-conformance pass again
​https://bugs.webkit.org/show_bug.cgi?id=47525

Remove incorrect call to glGetShaderiv, so it is only
called in the case where we don't have our own simulated
log.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getShaderInfoLog):
5:53 PM Changeset in webkit [69545] by weinig@apple.com
  • 7 edits in trunk

WebCore: Add WebKit2 equivalents for setValueForUser and setAutoFilled
<rdar://problem/8475934>
​https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Add needed export.

WebKit2: Add WebKit2 equivalents for setValueForUser and setAutofilled
<rdar://problem/8475934>
​https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleSetHTMLInputElementValueForUser):
(WKBundleNodeHandleSetHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
5:34 PM Changeset in webkit [69544] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Add a needed include.

  • UIProcess/cf/WebPageProxyCF.cpp:
5:33 PM Changeset in webkit [69543] by ajwong@chromium.org
  • 993 edits
    524 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed. Build Fix.

Submit 1506 new rebaselines due to changes for all elipse/circle
drawing code caused by r69517. Changelog compressed to list the
number of files changed per directory.

  • LayoutTests/platform/chromium-linux/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/: 96 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-linux/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/custom/: 104 changed.
  • LayoutTests/platform/chromium-linux/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/fast/backgrounds/: 6 changed.
  • LayoutTests/platform/chromium-mac/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-mac/fast/images/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/: 101 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/masking/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/paints/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/carto.net/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/clip-path/: 50 changed.
  • LayoutTests/platform/chromium-mac/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/custom/: 118 changed.
  • LayoutTests/platform/chromium-mac/svg/dynamic-updates/: 184 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/text/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-win-xp/fast/blockflow/: 1 changed.
  • LayoutTests/platform/chromium-win-xp/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win-xp/svg/custom/: 1 changed.
  • LayoutTests/platform/chromium-win/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/: 107 changed.
  • LayoutTests/platform/chromium-win/svg/batik/masking/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-win/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-win/svg/custom/: 114 changed.
  • LayoutTests/platform/chromium-win/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/page/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium/: 1 changed.
  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [69542] by bweinstein@apple.com
  • 3 edits in trunk/WebKit2

Windows build fix. Wrap calls to CFSTR in parentheses.

  • UIProcess/cf/WebBackForwardListCF.cpp:
  • UIProcess/cf/WebPageProxyCF.cpp:
5:19 PM Changeset in webkit [69541] by jorlow@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-10-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Add plumbing for synchronous indexedDB exceptions
​https://bugs.webkit.org/show_bug.cgi?id=47511

Add a WebExceptionCode file (already run by fishd) and add versions of
each applicable method that take such a parameter. A follow up patch
will be posted with the meat.

  • WebKit.gyp:
  • public/WebExceptionCode.h: Added.
  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion): (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openKeyCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::getKey):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
5:16 PM Changeset in webkit [69540] by andreip@google.com
  • 32 edits in trunk

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
5:05 PM Changeset in webkit [69539] by weinig@apple.com
  • 11 edits
    1 add in trunk

Add ability to convert from a JSObjectRef back to a WKBundleNodeHandleRef
​https://bugs.webkit.org/show_bug.cgi?id=47509

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export toNode.

WebKit2:

Add SPI to convert a JSObjectRef to a WKBundleNodeHandleRef.

  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
5:01 PM Changeset in webkit [69538] by beidson@apple.com
  • 9 edits
    3 adds in trunk/WebKit2

<rdar://problem/8262202> and ​https://bugs.webkit.org/show_bug.cgi?id=47354
Need WKPage API for serializing and restoring a page's state

Reviewed by Darin Adler and Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • WebKit2Prefix.h: Add DEFINE_STATIC_GETTER convenience.
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState): Change to use a filter function to allow the API client to decide what

types of things get serialized as session state. For now it only filters based on URL in
session history entries.

(WKPageRestoreFromSessionState):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::restoredCurrentURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionStateData): Leave stubs for non-CF platform builds.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

  • UIProcess/WebPageProxy.h:
  • UIProcess/cf: Added.
  • UIProcess/cf/WebBackForwardListCF.cpp: Added.

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Store back/forward list info CF property list style.
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Restore from that data - but for now we don't

actually put the back/forward list back into place and instead only remember the current URL.

  • UIProcess/cf/WebPageProxyCF.cpp: Added.

(WebKit::WebPageProxy::sessionStateData): Create the sessions state date CF property list style, plus a version header.
(WebKit::WebPageProxy::restoreFromSessionStateData): Restore from that property list style session state data.

5:01 PM Changeset in webkit [69537] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-11 Tony Chang <​tony@chromium.org>

Unreviewed, roll chromium DEPS to pick up Dave's fix for
scrollbar painting. This will be needed by an upcoming patch.

  • DEPS:
4:45 PM Changeset in webkit [69536] by abarth@webkit.org
  • 14 edits in trunk/LayoutTests

2010-10-11 Adam Barth <​abarth@webkit.org>

Rebaseline SVG expectations.
Rubber-stamped by Mr. kling.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
4:30 PM Changeset in webkit [69535] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Clang build fix after r69472.
​https://bugs.webkit.org/show_bug.cgi?id=46523

  • wtf/text/StringHash.h:
3:42 PM Changeset in webkit [69534] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating test_expectations for a passing test.

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [69533] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Undo last minute change to 32bit build.

3:15 PM Changeset in webkit [69532] by Adam Roben
  • 3 edits in trunk/WebKit2

Implement SharedMemory on Windows

This makes visited links be colored correctly.

Fixes <​http://webkit.org/b/47499> <rdar://problem/8422725>.

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h: Add Windows-specific members to

SharedMemory and SharedMemory::Handle.

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::Handle): Initialize our members.
(WebKit::SharedMemory::Handle::~Handle): Close our HANDLE if we have
one.
(WebKit::SharedMemory::Handle::encode): Encode our size, HANDLE, and
PID. Null out our HANDLE member, as it is now the receiving process's
responsibility to close the HANDLE.
(WebKit::SharedMemory::Handle::decode): Copy the handle from the
sending process into the receiving process and close the HANDLE the
sending process gave us.
(WebKit::SharedMemory::create): Map some memory and store it in a new
SharedMemory object.
(WebKit::accessRights): Helper function to convert a
SharedMemory::Protection to a file-mapping access right.
(WebKit::SharedMemory::create): Map the memory represented by the
Handle, and adopt the HANDLE from it.
(WebKit::SharedMemory::~SharedMemory): Clean up our memory mapping.
(WebKit::SharedMemory::createHandle): Give the Handle a copy of our
HANDLE with the specified protection.

3:14 PM Changeset in webkit [69531] by Adam Roben
  • 2 edits in trunk/WebKit2

Make it possible to restart a RunLoop::Timer on Windows

Fixes <​http://webkit.org/b/47505> RunLoop::Timer only ever fires once
on Windows

Reviewed by Anders Carlsson.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Remove non-repeating timers from the
set of active timers when they fire, just like we do when stopping
them manually.

3:12 PM Changeset in webkit [69530] by Martin Robinson
  • 8 edits in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=47244

Unskip the freshly passing test and add a baseline which has a PASS for all
tests.

  • platform/gtk/Skipped: Unskip passing test.
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=47244

Store the URI list as a String in DataObjectGtk, so that non-URI elements
are preserved when getData(...) is called. This necessitates some other
changes, including adding a m_filenames member to DataObjectGtk to store
filenames extracted during setURIList(...). The logic in getData(...) has
also changed to set success = true no matter what to match the spec. A
followup patch will remove this parameter completely for all platforms.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::getData): Always succeed to match the HTML5 spec and Firefox. Simply return the uriList string from the DataObject instead of reconstructing it from a vector of KURLs. (WebCore::ClipboardGtk::setData): The DataObject now accepts a string for the uriList parameter. (WebCore::ClipboardGtk::types): Predicate the "Files" member on DataObjectGtk::hasFilenames(). (WebCore::ClipboardGtk::files): Update to reflect the change from DataObjectGtk::files() to DataObjectGtk::filenames().
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::setURIList): Expanded this setter to find the first valid URL to use as the m_url member and also extract a list of filenames from the URI list. (WebCore::DataObjectGtk::setURL): Updated to reflect changes to m_uriList. (WebCore::DataObjectGtk::clear): Updated to reflect changes to m_uriList and also leave a comment explaining why we do not clear filenames here.
  • platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::url): This implementation is now a simple getter. (WebCore::DataObjectGtk::uriList): Ditto. (WebCore::DataObjectGtk::filenames): Added. (WebCore::DataObjectGtk::hasURL): Now a simple check. (WebCore::DataObjectGtk::hasFilenames): Added. (WebCore::DataObjectGtk::clearURIList): Simple setter. (WebCore::DataObjectGtk::clearURL): Ditto.
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles): Updated to access DataObjectGtk::hasFilenames(). (WebCore::DragData::asFilenames): Updated to access DataObjectGtk::filenames().
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): Use the uriList as a string now. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Ditto.
3:10 PM Changeset in webkit [69529] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-10-11 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=47241

Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.

Test: fast/canvas/access-zero-sized-canvas.html

fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html

with --accelerated-compositing and --accelerated-2d-canvas

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
2:56 PM Changeset in webkit [69528] by Martin Robinson
  • 9 edits
    6 adds in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Unskip some tests that lacked baselines before (they used cursive and fantasy font
families) and regenerate some correct baselines for the synthetic oblique test.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/fonts/cursive-expected.txt: Added.
  • platform/gtk/fonts/default-expected.txt: Added.
  • platform/gtk/fonts/fantasy-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png:
  • platform/gtk/fonts/monospace-expected.txt: Added.
  • platform/gtk/fonts/sans-serif-expected.txt: Added.
  • platform/gtk/fonts/serif-expected.txt: Added.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Do some miscellaneous cleanup work in the Freetype font font selection backend.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::getFamilyNameStringFromFontDescriptionAndFamily): Modified this method to return a WebCore String. (WebCore::FontCache::createFontPlatformData): Do a bit of cleanup in this method: properly handle cursive and fantasy as fallback-like fonts. Instead of using raw CStrings do string comparisons using WebCore Strings. Remove a large block comment that originated from a Apache-licensed file.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Update DRT to set values for the cursive and fantasy font families, so
that we can generate consistent results for tests that use these families.
Add some missing information to fonts.conf.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always set the fantasy and cursive font family names.
  • DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts to our default serif font. Eventually we may want to import or require some "real" fonts, but this should at least ensure consistent rendering during test runs. Also add aliases for some other commonly used fonts in tests (Arial and Lucida Grande). Finally, add a missing oblique specification for DejaVu Serif, which was resulting in some incorrect baselines for the synthetic oblique test.
2:32 PM Changeset in webkit [69527] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Temporary patch for SVG changes from r69517.

Update test expectations to fail all SVG tests with different output
after r69517's changes. Rebaselines coming later.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [69526] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Buttons activated with the keyboard should be painted as clicked
​https://bugs.webkit.org/show_bug.cgi?id=18364

When a button is pressed, force it into the hovered state as far as the
Mozilla theme drawing code is concerned. This bug also seems to be an
issue for Firefox. When we switch away from the Mozilla theme drawing
code this work-around should no longer be necessary.

No new tests. I was not able to generate a pixel test for this issue. It
seems that our DRT does not have the necessary infrastructure to generate a
pixel dump while a button is in the pressed state.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintRenderObject):
2:15 PM Changeset in webkit [69525] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix for Windows. Add a necessary export from r69516.

2:08 PM Changeset in webkit [69524] by jberlin@webkit.org
  • 10 edits in trunk

Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
representation of a WebKit1 WebSerializedJSValue.
​https://bugs.webkit.org/show_bug.cgi?id=47439

Reviewed by Darin Adler.

WebKit/mac:

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue internalRepresentation]):

  • WebView/WebSerializedJSValuePrivate.h:

WebKit/win:

  • Interfaces/IWebSerializedJSValuePrivate.idl:

Because it is taking a void parameter, getInternalRepresentation must be declared [local].

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::getInternalRepresentation):

  • WebSerializedJSValue.h:

WebKit2:

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueCreateWithInternalRepresentation):
Use the existing WebSerializedScriptValue constructor that takes a pointer to the internal
representation (a WebCore::SerializedScriptValue).

  • Shared/API/c/WKSerializedScriptValuePrivate.h:
1:58 PM Changeset in webkit [69523] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Unreviewed. Build fix.

  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
1:28 PM Changeset in webkit [69522] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix interpreter build -- was broken by incorrect merge.

1:20 PM Changeset in webkit [69521] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed WinCairo build fixes.

  • platform/network/curl/ResourceResponse.h: Correct forward declaration

for CFURLResponseRef.

  • rendering/RenderMediaControls.h: Add ENABLE(VIDEO) guard to new

header file to avoid build failure on non-VIDEO builds.

1:16 PM Changeset in webkit [69520] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Add File API feature guard to all typed array files
​https://bugs.webkit.org/show_bug.cgi?id=47437

Reviewed by Adam Barth.

Since we're going to add ArrayBuffer support to FileReader and BlobBuilder,
we need to update all type array files to include File API feature guard
in addition to the existing 3D_CANVAS guard. When ArrayBuffer is used in
XMLHttpRequest, we will then remove all the guards. This is per the
discussion on webkit-dev mailing list:
​https://lists.webkit.org/pipermail/webkit-dev/2010-October/014716.html

  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
12:50 PM Changeset in webkit [69519] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Build fix (implicit float conversion in Path.cpp)

  • platform/graphics/Path.cpp:
12:45 PM Changeset in webkit [69518] by Girish Ramakrishnan
  • 3 edits in trunk/WebCore

[Qt] Refactor Plugin X Pixmap painting code to a separate function

Reviewed by Kenneth Rohde Christiansen.

The refactored function will be used for rendering by the Accelerated
Composition enabled graphics layer.

​https://bugs.webkit.org/show_bug.cgi?id=35524

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingXPixmap):
(WebCore::PluginView::paint):

12:19 PM Changeset in webkit [69517] by andreas.kling@nokia.com
  • 35 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

SVG: Remove "create" methods and use port-specific "add" counterparts
​https://bugs.webkit.org/show_bug.cgi?id=46052

Circles and ellipses will be significantly faster on platforms that
implement Path::addEllipse() in a sane fashion.

Also, a lot of Path copying has been factored out by changing functions
that would return Paths to take Path& arguments instead (toPathData, toClipPath)

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::addRoundedRect):
  • platform/graphics/Path.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadowWithoutTiling): (WebCore::ContextShadow::drawRectShadow):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::toPathData):
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::toPathData):
  • svg/SVGEllipseElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::toPathData):
  • svg/SVGLineElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::toPathData):
  • svg/SVGPathElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::toPathData):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::toPathData):
  • svg/SVGPolylineElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData):
  • svg/SVGRectElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::toClipPath):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
  • svg/SVGUseElement.h:
12:12 PM Changeset in webkit [69516] by oliver@apple.com
  • 60 edits
    5 adds in trunk

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Initial strict mode implementation. This is the simplest
implementation that could possibly work and adds (hopefully)
all of the restrictions required by strict mode. There are
a number of inefficiencies, especially in the handling of
arguments and eval as smart implementations would make this
patch more complicated.

The SyntaxChecker AST builder has become somewhat more complex
as strict mode does require more parse tree information to
validate the syntax.

Summary of major changes to the parser:

  • We track when we enter strict mode (this may come as a surprise)
  • Strict mode actually requires a degree of AST knowledge to validate so the SyntaxChecker now produces values that can be used to distinguish "node" types.
  • We now track variables that are written to. We do this to statically identify writes to global properties that don't exist and abort at that point. This should actually make it possible to optimise some other cases in the future but for now it's purely for validity checking. Currently writes are only tracked in strict mode code.
  • Labels are now tracked as it is now a syntax error to jump to a label that does not exist (or to use break, continue, or return in a context where they would be invalid).

Runtime changes:

  • In order to get correct hanlding of the Arguments object all strict mode functions that reference arguments create and tearoff the arguments object on entry. This is not strictly necessary but was the least work necessary to get the correct behaviour.
  • PutPropertySlot now tracks whether it is being used for a strict mode write, and if so Object::put will throw when a write can't be completed.
  • StrictEvalActivation was added as an "activation" object for strict mode eval (so that strict eval does not introduce new variables into the containing scope).
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isStrictMode):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::createArgumentsIfNecessary): (JSC::BytecodeGenerator::emitReturn):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::isStrictMode): (JSC::BytecodeGenerator::makeFunction):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emitSlow_op_convert_this_strict):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_pnames):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • parser/ASTBuilder.h: (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::isResolve):
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::startLoop): (JSC::JSParser::endLoop): (JSC::JSParser::startSwitch): (JSC::JSParser::endSwitch): (JSC::JSParser::setStrictMode): (JSC::JSParser::strictMode): (JSC::JSParser::isValidStrictMode): (JSC::JSParser::declareParameter): (JSC::JSParser::breakIsValid): (JSC::JSParser::pushLabel): (JSC::JSParser::popLabel): (JSC::JSParser::hasLabel): (JSC::JSParser::DepthManager::DepthManager): (JSC::JSParser::DepthManager::~DepthManager): (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::startSwitch): (JSC::JSParser::Scope::endSwitch): (JSC::JSParser::Scope::startLoop): (JSC::JSParser::Scope::endLoop): (JSC::JSParser::Scope::inLoop): (JSC::JSParser::Scope::breakIsValid): (JSC::JSParser::Scope::pushLabel): (JSC::JSParser::Scope::popLabel): (JSC::JSParser::Scope::hasLabel): (JSC::JSParser::Scope::isFunction): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::declareWrite): (JSC::JSParser::Scope::deleteProperty): (JSC::JSParser::Scope::declareParameter): (JSC::JSParser::Scope::setNeedsFullActivation): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::getUncapturedWrittenVariables): (JSC::JSParser::Scope::getDeletedVariables): (JSC::JSParser::Scope::setStrictMode): (JSC::JSParser::Scope::strictMode): (JSC::JSParser::Scope::isValidStrictMode): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::declareVariable): (JSC::JSParser::declareWrite): (JSC::JSParser::deleteProperty): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseStrictObjectLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h:
  • parser/Lexer.cpp: (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::isReparsing):
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • parser/Nodes.h: (JSC::ScopeNode::isStrictMode):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/Arguments.cpp: (JSC::Arguments::createStrictModeCallerIfNecessary): (JSC::Arguments::createStrictModeCalleeIfNecessary): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • runtime/Arguments.h: (JSC::Arguments::Arguments):
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction): (JSC::StrictModeTypeErrorFunction::constructThrowTypeError): (JSC::StrictModeTypeErrorFunction::getConstructData): (JSC::StrictModeTypeErrorFunction::callThrowTypeError): (JSC::StrictModeTypeErrorFunction::getCallData): (JSC::createTypeErrorFunction):
  • runtime/Error.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode): (JSC::ProgramExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable): (JSC::ScriptExecutable::isStrictMode): (JSC::EvalExecutable::create): (JSC::FunctionExecutable::create):
  • runtime/JSActivation.cpp: (JSC::JSActivation::toStrictThisObject):
  • runtime/JSActivation.h:
  • runtime/JSFunction.cpp: (JSC::createDescriptorForThrowingProperty): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::getOwnPropertyDescriptor): (JSC::JSFunction::put):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::internalFunctionStructure):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::toStrictThisObject): (JSC::throwTypeError):
  • runtime/JSObject.h: (JSC::JSObject::isStrictModeFunction): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSValue::putDirect): (JSC::JSValue::toStrictThisObject):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::toStrictThisObject):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h: (JSC::JSZombie::toStrictThisObject):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::isStrictMode):
  • runtime/StrictEvalActivation.cpp: Added. (JSC::StrictEvalActivation::StrictEvalActivation): (JSC::StrictEvalActivation::deleteProperty): (JSC::StrictEvalActivation::toThisObject): (JSC::StrictEvalActivation::toStrictThisObject):
  • runtime/StrictEvalActivation.h: Added.

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Tests for the many different behaviours we get in strict mode.

  • fast/js/basic-strict-mode-expected.txt: Added.
  • fast/js/basic-strict-mode.html: Added.
  • fast/js/script-tests/basic-strict-mode.js: Added. (testThis): (testGlobalAccess):

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Test: fast/js/basic-strict-mode.html

Override toStrictThisObject on the domwindow so that
it correctly provides the shell object when used as this
in a strict mode function.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::toStrictThisObject):
  • bindings/js/JSDOMWindowBase.h:
12:09 PM Changeset in webkit [69515] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior
​https://bugs.webkit.org/show_bug.cgi?id=47472

Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Modified with resutls for all editing behaviors, i.e. mac and win.
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js: ():
  • platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
12:03 PM Changeset in webkit [69514] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-10-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=46777

Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
12:00 PM Changeset in webkit [69513] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix.

Fixed design-mode-spellcheck-off.html so that it passes on platforms that do not support textInputController.

  • editing/spelling/design-mode-spellcheck-off.html:
11:38 AM Changeset in webkit [69512] by crogers@google.com
  • 43 edits
    2 adds in branches/audio/WebCore

audio branch: lots of cleanup for landing into trunk

  • HRTFPanner and EqualPowerPanner last cleanup before landing
  • HighPass2Filter and LowPass2Filter last cleanup before landing
  • AudioBasicProcessorNode, AudioPannerNode, BiquadDSPKernel, BiquadProcess, last cleanup before landing
  • lots of cleanup and thread safety work for AudioNodeInput and AudioNodeOutput
  • add AudioUtilities
  • general cleanup: AudioResampler, AudioBufferSourceNode, AudioGainNode, RealtimeAnalyser, RealtimeAnalyserNode
11:32 AM Changeset in webkit [69511] by mthole@apple.com
  • 9 edits in trunk

Rename WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()
​https://bugs.webkit.org/show_bug.cgi?id=47495

Reviewed by Darin Adler.

WebKit2:

  • Shared/API/c/mac/WKCertificateInfoMac.h:

Renamed WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()

  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoGetCertificateChain): Updated for name change.

  • Shared/mac/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::certificateChain): Renamed from peerCertificates()

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Updated for name change.
(WebKit::PlatformCertificateInfo::encode): Ditto.
(WebKit::PlatformCertificateInfo::decode): Ditto.
(WebKit::PlatformCertificateInfo::dump): Ditto.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:29 AM Changeset in webkit [69510] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Issue a warning when an InjectedBundle can't be loaded.
​https://bugs.webkit.org/show_bug.cgi?id=47497

The original author of the patch is Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>.

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::load):
11:12 AM Changeset in webkit [69509] by rniwa@webkit.org
  • 20 edits
    2 adds in trunk

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
​https://bugs.webkit.org/show_bug.cgi?id=39978

The bug was caused by WebKit's setting focus to html element rather than body element in design mode.
Because we disable spell-check only if ancestor nodes of the focused element had spellcheck=false,
this caused us to ignore body element's spellcheck attribute.

Fixed the bug by overriding supportsFocus in HTMLBodyElement to make body element focusable
when the parent node of body elements (namely html element) is editable.

Test: editing/spelling/design-mode-spellcheck-off.html

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus): Added.
  • html/HTMLBodyElement.h:

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
​https://bugs.webkit.org/show_bug.cgi?id=39978

Added a test to ensure Webkit respects spellcheck=off on body element.
Rebaselined are due to our setting the focus to body element rather than html element in design mode.

  • editing/spelling/design-mode-spellcheck-off-expected.txt: Added.
  • editing/spelling/design-mode-spellcheck-off.html: Added.
  • editing/inserting/space-after-removeformat-expected.txt: Editing delegates change due to focus moving to body.
  • platform/chromium-win/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-links-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/chromium-win/editing/style/designmode-expected.txt: Ditto.
  • platform/mac/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/designmode-no-caret-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-links-expected.txt: Ditto.
  • platform/mac/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/mac/editing/style/designmode-expected.txt: Ditto.
  • platform/qt/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/qt/editing/style/designmode-expected.txt: Ditto.
11:12 AM Changeset in webkit [69508] by weinig@apple.com
  • 11 edits in trunk/WebKit2

Rename transformToDeviceSpace to convertToDeviceSpace and
transformToUserSpace to convertToUserSpace at Simon's request.

Reviewed by Simon Fraser.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::convertToDeviceSpace):
(QWKPagePrivate::convertToUserSpace):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):

  • UIProcess/win/WebView.h:
10:54 AM Changeset in webkit [69507] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix -- I thought i had killed the prior commit in time to allow me to add this

10:44 AM Changeset in webkit [69506] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Andreas Kling.

Incorrect handling of 0 length logs in GraphicsContext3DOpenGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=47494

Working on another patch I found that there was some screwy behaviour
when dealing with logs from GL. GL_INFO_LOG_LENGTH is defined as being
zero if there is no log message, but we did not check for that case and
simply perfomed a zero sized alloc and passed the resultant buffer to
glGetShaderInfoLog, etc. glGetShaderInfoLog would then write a null
terminator to the buffer, thus causing an overflow. This is obviously
not a problem in practice as allocations are at least 4 bytes long in
all common allocators, but it is still a bug.

I also removed some unnecessary null checks following calls to fastMalloc.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderInfoLog):
10:27 AM Changeset in webkit [69505] by Nikolas Zimmermann
  • 13 edits in trunk/WebCore

2010-10-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Kill Path::debugString()
​https://bugs.webkit.org/show_bug.cgi?id=47493

Remove the obsolete Path::debugString() method. DRT now dumps paths in a platform independant way.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/openvg/PathOpenVG.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/wince/PathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.h:
  • platform/graphics/wx/PathWx.cpp:
  • svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::operator==):
10:13 AM Changeset in webkit [69504] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Try to fix the Mac release build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _transformToDeviceSpace:]):
(-[WKView _transformToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:07 AM Changeset in webkit [69503] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebProcess ASSERTs with a null application cache dir creation parameter
​https://bugs.webkit.org/show_bug.cgi?id=47489

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
9:38 AM Changeset in webkit [69502] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unlink the files used for I/O mapped memory as soon as they are
created.

Reviewed by Andreas Kling.

  • Shared/qt/UpdateChunk.cpp:

(WebKit::mapMemory):
(WebKit::mapFile):

9:24 AM Changeset in webkit [69501] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 68819

BUG=56206
Review URL: ​http://codereview.chromium.org/3674004

9:21 AM Changeset in webkit [69500] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/517

Merge 69476

BUG=57200
Review URL: ​http://codereview.chromium.org/3662002

9:19 AM Changeset in webkit [69499] by inferno@chromium.org
  • 7 edits
    2 copies in branches/chromium/517

Merge 69043

BUG=55346
Review URL: ​http://codereview.chromium.org/3691003

9:14 AM Changeset in webkit [69498] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 69345

BUG=58008
Review URL: ​http://codereview.chromium.org/3692003

9:08 AM Changeset in webkit [69497] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Build fix when using MeeGo Touch

Rubberstamped by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:
8:55 AM Changeset in webkit [69496] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Use raster for the QtWebProcess.

Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

8:24 AM Changeset in webkit [69495] by Martin Robinson
  • 3 edits
    2 adds in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
​https://bugs.webkit.org/show_bug.cgi?id=47441

Add a pixel dump result which tests the fix.

  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png: Added.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
​https://bugs.webkit.org/show_bug.cgi?id=47441

Center search field icons vertically in the search field.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::centerRectVerticallyInParentInputElement): Added this helper. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Center the search field icon by adjusting its drawing rect relative to the containing search field. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
8:18 AM Changeset in webkit [69494] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-10-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix event listener breakpoints sidebar pane style
​https://bugs.webkit.org/show_bug.cgi?id=47487

  • inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):
8:07 AM Changeset in webkit [69493] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Avoid QPainterPath::operator=(QPainterPath()) when possible

Same concept as <​http://trac.webkit.org/changeset/69462>, do nothing
when clearing an already empty QPainterPath. Avoids one delete+new.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::clearCurrentPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::beginPath):
8:02 AM Changeset in webkit [69492] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Remove unnecessary GTK+ and Pango includes.

  • platform/gtk/FileChooserGtk.cpp:
  • platform/gtk/Language.cpp:
7:43 AM Changeset in webkit [69491] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed win build fix.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
7:12 AM Changeset in webkit [69490] by kenneth@webkit.org
  • 15 edits in trunk/WebKit2

Adding Qt WebKit2 API for dealing with viewport meta info
​https://bugs.webkit.org/show_bug.cgi?id=47202

Reviewed by Sam Weinig.

Add new API for setting scale and layout viewport given the data
provided by the viewport meta tag.

Any Qt view components who wants to support this, will need to
compute the viewport attributes before first load using
viewportAttributesForSize(..), and then again everytime
the viewport attributes gets invalidates (loading a new page,
navigating page cache) or every time on of the browser
attributes change, such as when the device is rotates (which
changes the actual visible viewport). A signal
viewportChangeRequested() is provided for the former.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewportArguments):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setViewportArguments):
(QWKPage::ViewportAttributes::ViewportAttributes):
(QWKPage::ViewportAttributes::~ViewportAttributes):
(QWKPage::ViewportAttributes::operator=):
(QWKPage::viewportAttributesForSize):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QtViewportAttributesPrivate::QtViewportAttributesPrivate):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didChangeViewportData):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setViewportArguments):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportDataDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
6:56 AM WebKit Team edited by tonikitoo@webkit.org
(diff)
6:41 AM Changeset in webkit [69489] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-margins-inside-editable-div.js to use LayoutTestController::setEditingBeh avior
​https://bugs.webkit.org/show_bug.cgi?id=47471

Patch converts the editing/selection/click-in-margins-inside-editable-div to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js: ():
  • platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
6:19 AM Changeset in webkit [69488] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

2010-10-11 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

[Qt] WebKit2 build scripts are buggy
​https://bugs.webkit.org/show_bug.cgi?id=47377

Generated sources must depends on WebKit2/Scripts/webkit2/messages.py too.

  • DerivedSources.pro: Missing dependencies added.
5:36 AM Changeset in webkit [69487] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Disable fast/filesystem/op-remove.html for chromium-win.

  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [69486] by apavlov@chromium.org
  • 5 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux and chromium-mac.

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
4:21 AM Changeset in webkit [69485] by kinuko@chromium.org
  • 31 edits in trunk

2010-10-11 Kinuko Yasuda <​kinuko@google.com>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::removeRecursively): Added.
  • src/AsyncFileSystemChromium.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::removeRecursively): Added.
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): Added. (WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread): Added.
  • src/WorkerFileSystemCallbacksBridge.h:

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

Also disallows remove/removeRecursively on the root directory.

Test: fast/filesystem/op-remove.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::removeRecursively): Added.
  • fileapi/DOMFileSystemBase.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::removeRecursively): Added.
  • fileapi/DirectoryEntry.h:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::removeRecursively): Added.
  • fileapi/DirectoryEntrySync.h:
  • fileapi/DirectoryEntrySync.idl:
  • platform/AsyncFileSystem.h:

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/fs-test-util.js: (removeAllInDirectory): renamed from removeRecursively and changed the implemntation to use DirectoryEntry.removeRecursively.
  • fast/filesystem/resources/fs-worker-common.js: (removeAllInDirectorySync): ditto.
  • fast/filesystem/resources/op-remove.js: Added removeRecursively test.
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.removeRecursively): Added.
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/script-tests/file-from-file-entry.js:
  • fast/filesystem/script-tests/read-directory.js:
4:03 AM Changeset in webkit [69484] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux.
Fix bad expectation.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium/test_expectations.txt:
3:38 AM Changeset in webkit [69483] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Update more test expectations.

  • platform/chromium/test_expectations.txt:
2:56 AM Changeset in webkit [69482] by krit@webkit.org
  • 6 edits in trunk

2010-10-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
​https://bugs.webkit.org/show_bug.cgi?id=47464

Determine the smallest effect region for SVGFEImage by taking preserveAspectRatio into account.

  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::determineAbsolutePaintRect): (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:

2010-10-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
​https://bugs.webkit.org/show_bug.cgi?id=47464

Needs a new baseline for svg/W3C-SVG-1.1-SE/filters-image-03-f.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
2:19 AM Changeset in webkit [69481] by apavlov@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline overhanging-floats-removed for chromium-win and chromium-linux platforms.

  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.png: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.png: Added.
1:26 AM QtWebKitContrib edited by jocelyn.turcotte@nokia.com
Remove running the tests from the steps. (diff)
1:22 AM Changeset in webkit [69480] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-11 Adam Barth <​abarth@webkit.org>

Unreviewed.

Fix sheriffbot not to crash when there are failing tests. It turns out
Python sets don't support the + operator. We need to use union
instead. There's a more elegant way to do this in Python 2.6, but we
need this code to work in 2.5.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
12:17 AM Changeset in webkit [69479] by inferno@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-10-11 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Commit r69478 put the expected file in wrong platform. Correcting that.

  • platform/gtk/fast/flexbox: Added.
  • platform/gtk/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.

Oct 10, 2010:

11:58 PM Changeset in webkit [69478] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-10-10 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Rebaseline overhanging-floats-removed test for GTK platform.

  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
11:34 PM Changeset in webkit [69477] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Added Radar ULR

11:29 PM Changeset in webkit [69476] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2010-10-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Overhanging floats are not added to flexible boxes since they behave like
block formatting contexts. This causes the intruding floats added in siblings
to not get cleared. Enforce the float release by checking if the parent is a
flexible box and if yes, use that as the outermost block.


​https://bugs.webkit.org/show_bug.cgi?id=47104

Test: fast/flexbox/overhanging-floats-removed.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2010-10-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that intruding floats get properly cleared in flexible box layout.
​https://bugs.webkit.org/show_bug.cgi?id=47104

  • fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • fast/flexbox/overhanging-floats-removed-expected.png: Added.
  • fast/flexbox/overhanging-floats-removed-expected.txt: Added.
  • fast/flexbox/overhanging-floats-removed.html: Added.
3:57 PM Changeset in webkit [69475] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-10 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Windows build fix after r69472.

  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
3:18 PM Changeset in webkit [69474] by Chris Fleizach
  • 3 edits
    2 adds in trunk

2010-10-10 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: if aria-live is on a <span> or ignored element, live regions don't work
​https://bugs.webkit.org/show_bug.cgi?id=47443

  • platform/mac/accessibility/live-region-on-span-expected.txt: Added.
  • platform/mac/accessibility/live-region-on-span.html: Added.

2010-10-10 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: if aria-live is on a <span> or ignored element, live regions don't work
​https://bugs.webkit.org/show_bug.cgi?id=47443

If an element has aria attributes, but has no other native role associated with it,
accessibility should fallback to exposing that element as an AXGroup.

Test: platform/mac/accessibility/live-region-on-span.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2:05 PM Changeset in webkit [69473] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-10 Robert Hogan <​robert@webkit.org>

Unreviewed, fix failing test from r69468.

[Qt] Put all DRT-created pages in a page group

Fix on r69468.

Because we don't delete closed pages immediately in DRT we need
to remove them from the page group explicitly instead.

Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html

​https://bugs.webkit.org/show_bug.cgi?id=47469

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
1:19 PM Changeset in webkit [69472] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Use WTF::StringHasher in WTF::CaseFoldingHash
​https://bugs.webkit.org/show_bug.cgi?id=46523

  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::foldCase): (WTF::CaseFoldingHash::hash):
1:00 PM Changeset in webkit [69471] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-10 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Barth.

commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
EFL-EWS bot is up and running.
​https://bugs.webkit.org/show_bug.cgi?id=47277

  • QueueStatusServer/handlers/statusbubble.py:
12:48 PM Changeset in webkit [69470] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-10 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Adam Barth.

[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
​https://bugs.webkit.org/show_bug.cgi?id=47419

This was a regression introduced in r68807. Updated the layout test to
check for this case.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • editing/pasteboard/script-tests/dataTransfer-setData-getData.js: (runTest):

2010-10-10 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Adam Barth.

[chromium] Clipboard no longer accepts 'text' as a synonym for 'text/plain'
​https://bugs.webkit.org/show_bug.cgi?id=47419

This was a regression introduced in r68807. mimeTypeText had the incorrect
value.

Test: editing/pasteboard/dataTransfer-setData-getData.html

  • platform/chromium/ClipboardMimeTypes.cpp:
12:46 PM Changeset in webkit [69469] by mihaip@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

2010-10-10 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

<a ping> tests are slow
​https://bugs.webkit.org/show_bug.cgi?id=47431

The ping tests showed up as being flaky in Adam Barth's email; this
might just be due to them being on the slow side due to the 1 second
refresh in check-ping.php. We can instead switch to using file_exists
in a loop if we invalidate the file status cache. Running the three
ping tests with --iterations=10 now takes 4 seconds instead of 23.

This surfaces a race condition in image-load-in-unload-handler.html
(we don't start sending data till we get the ping, but unload handlers
(where the ping is sent) aren't run till we start getting data). Fixed
by adding a dummy page in between.

  • http/tests/navigation/resources/check-ping.php:
  • http/tests/navigation/image-load-in-unload-handler.html:
  • http/tests/navigation/resources/ping-redirect.html: Added.
10:44 AM Changeset in webkit [69468] by robert@webkit.org
  • 4 edits in trunk

2010-10-10 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Put all DRT-created pages in a page group

Unskip:

http/tests/security/frameNavigation/not-opener.html
http/tests/navigation/target-frame-from-window.html

​https://bugs.webkit.org/show_bug.cgi?id=47469

  • platform/qt/Skipped:

2010-10-10 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Put all DRT-created pages in a page group

​https://bugs.webkit.org/show_bug.cgi?id=47469

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow):
7:23 AM Changeset in webkit [69467] by tonikitoo@webkit.org
  • 5 edits in trunk

This reverts commit ​http://trac.webkit.org/changeset/69465

Debug statments that should not be committed.

7:14 AM Changeset in webkit [69466] by tonikitoo@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

editing/selection/extend-after-mouse-selection.html should useLayoutTestController::setEditingBehavior
​https://bugs.webkit.org/show_bug.cgi?id=47468

Changed editing/selection/extend-after-mouse-selection.html to use the LayoutTestController::setEditingBehavior
machinary. It makes it possible to remove platform dependent test results by testing through all
platform-specific codepath's we have.

  • editing/selection/extend-after-mouse-selection.html:
  • platform/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
7:14 AM Changeset in webkit [69465] by tonikitoo@webkit.org
  • 5 edits in trunk

tmp

Note: See TracTimeline for information about the timeline view.