⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 16, 2010:

9:47 PM Changeset in webkit [69921] by tonikitoo@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests/platform/gtk/fast/frames/flattening

2010-10-16 Antonio Gomes <​agomes@rim.com>

Complementary to r69919.

Unreviewed expectation update for frame flattening tests from the Gtk+ bots.

Basically 3px difference between the results generated on my machine and the ones
from the Gtk+ bots.

  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
9:43 PM Changeset in webkit [69920] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-10-16 Kyusun Kim <​maniagoon@company100.net>

Reviewed by Alexey Proskuryakov.

Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=47758

  • wtf/CurrentTime.h:
  • wtf/DateMath.h:
8:51 PM Changeset in webkit [69919] by tonikitoo@webkit.org
  • 8 edits
    11 adds in trunk

[Gtk]: DRT does not support frame flattening testing
​https://bugs.webkit.org/show_bug.cgi?id=38650

Reviewed by Martin Robinson and Xan Lopez.
Patch by Antonio Gomes <​agomes@rim.com>

WebKit/gtk:

Implement enable-frame-flattening API for Gtk+.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

WebKitTools:

Implement DRT's support for toggling on/off frame flattening
support.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests:

Unskipping passing frame flattening tests and adding expected results
for them.

  • platform/gtk/Skipped:
6:54 PM Changeset in webkit [69918] by dbates@webkit.org
  • 10 edits
    25 adds in trunk/LayoutTests

2010-10-16 Alex Milowski <​alex@milowski.com>

Reviewed by Daniel Bates.

New MathML Baseline for GTK Port
​https://bugs.webkit.org/show_bug.cgi?id=47774

New baseline for MathML tests for GTK port.

  • platform/gtk/mathml/presentation/attributes-expected.checksum: Added.
  • platform/gtk/mathml/presentation/attributes-expected.png: Added.
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/gtk/mathml/presentation/fractions-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fractions-expected.png: Added.
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.checksum: Added.
  • platform/gtk/mathml/presentation/mo-expected.png: Added.
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.checksum: Added.
  • platform/gtk/mathml/presentation/over-expected.png: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.checksum: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.png: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.checksum: Added.
  • platform/gtk/mathml/presentation/row-expected.png: Added.
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.checksum: Added.
  • platform/gtk/mathml/presentation/style-expected.png: Added.
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.checksum: Added.
  • platform/gtk/mathml/presentation/tokenElements-expected.png: Added.
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.checksum: Added.
  • platform/gtk/mathml/presentation/under-expected.png: Added.
  • platform/gtk/mathml/presentation/underover-expected.checksum: Added.
  • platform/gtk/mathml/presentation/underover-expected.png: Added.
  • platform/gtk/mathml/presentation/underover-expected.txt:
2:04 PM Changeset in webkit [69917] by kseo@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

[BREWMP] Port TextCodec
​https://bugs.webkit.org/show_bug.cgi?id=45797

Reviewed by Kent Tamura.

Implement TextCodec with Brew MP's ICharsetConv.
Only UTF-8 is supported for now.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):

  • platform/text/brew/TextCodecBrew.cpp: Added.

(WebCore::newTextCodecBrew):
(WebCore::TextCodecBrew::registerBaseEncodingNames):
(WebCore::TextCodecBrew::registerBaseCodecs):
(WebCore::TextCodecBrew::registerExtendedEncodingNames):
(WebCore::TextCodecBrew::registerExtendedCodecs):
(WebCore::TextCodecBrew::TextCodecBrew):
(WebCore::TextCodecBrew::~TextCodecBrew):
(WebCore::TextCodecBrew::decode):
(WebCore::TextCodecBrew::encode):

  • platform/text/brew/TextCodecBrew.h: Added.
1:07 PM Changeset in webkit [69916] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-16 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for !ENABLE(INSPECTOR) after r69844.

  • inspector/InspectorState.h: Added ENABLE(INSPECTOR) guard.
1:00 PM Changeset in webkit [69915] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-16 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix.

WinCE build fix for r69798.

  • platform/text/wince/TextCodecWinCE.cpp: Added missing include.
9:48 AM Changeset in webkit [69914] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-16 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
​https://bugs.webkit.org/show_bug.cgi?id=47593

Test: fast/forms/input-file-not-open-without-gesture.html

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2010-10-16 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
​https://bugs.webkit.org/show_bug.cgi?id=47593

  • fast/forms/input-file-not-open-without-gesture-expected.txt: Added.
  • fast/forms/input-file-not-open-without-gesture.html: Added.
8:37 AM Changeset in webkit [69913] by commit-queue@webkit.org
  • 40 edits
    4 adds in trunk

2010-10-16 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

The tests were re-baselined as operator padding was adjusted.

  • mathml/presentation/fenced-mi.xhtml: Added.

A test for mi vertical alignment in mfenced.

  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.checksum:
  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.checksum: Added.
  • platform/mac/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/mac/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.checksum:
  • platform/mac/mathml/presentation/style-expected.png:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.checksum:
  • platform/mac/mathml/presentation/tokenElements-expected.png:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-10-16 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Changed the vertical alignment within mfenced to baseline to
match the rest of the containers (e.g. mrow) and adjusted the
operator spacing to 0.1em.

Test: mathml/presentation/fenced-mi.xhtml

  • css/mathml.css:
  • mathml/RenderMathMLFenced.cpp:
3:45 AM Changeset in webkit [69912] by Patrick Gansterer
  • 8 edits
    3 moves in trunk

2010-10-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
​https://bugs.webkit.org/show_bug.cgi?id=47200

Now StringHasherFunctions.h only contains the StringHasher class, so rename it to the correct name.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/StringHashFunctions.h: Removed.
  • wtf/StringHasher.h: Copied from JavaScriptCore/wtf/StringHashFunctions.h.
  • wtf/text/StringHash.h:
  • wtf/text/StringImpl.h:

2010-10-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
​https://bugs.webkit.org/show_bug.cgi?id=47200

  • ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
  • ForwardingHeaders/wtf/StringHasher.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/StringHashFunctions.h.

2010-10-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
​https://bugs.webkit.org/show_bug.cgi?id=47200

  • ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
  • ForwardingHeaders/wtf/StringHasher.h: Copied from WebCore/ForwardingHeaders/wtf/StringHashFunctions.h.

Oct 15, 2010:

10:09 PM Changeset in webkit [69911] by kinuko@chromium.org
  • 14 edits
    6 copies
    1 delete in branches/chromium/552

Merge 69907 - 2010-10-15 Kinuko Yasuda <​kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

TBR=​kinuko@chromium.org

9:10 PM Changeset in webkit [69910] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
​https://bugs.webkit.org/show_bug.cgi?id=47424

The bug was caused by our not extracting styles when the anchor element is removed by removeInlineStyle.
Because we removed the element without pushing its inline style down, we lost style information.

Fixed the bug by pushing down styles in removeInlineStyle as done in pushDownInlineStyleAroundNode.
Also fixed a bug in addInlineStyleIfNeeded where StyleChange incorrectly removed styles of the container
node as supposed to that of startNode from the style to apply when startNode is not an element.

Test: editing/execCommand/toggle-unlink.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): To prevent a similar bug in the future, added an assert that extractedStyle is specified whenever we're removing a styled element. (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
​https://bugs.webkit.org/show_bug.cgi?id=47424

Added a test to ensure execCommand('unlink', false, null) preserves the inline style declaration.

  • editing/execCommand/script-tests/toggle-unlink.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastTwoWords): (selectLastWord):
  • editing/execCommand/toggle-unlink-expected.txt: Added.
  • editing/execCommand/toggle-unlink.html: Added.
  • editing/style/script-tests/make-text-writing-direction-inline.js: Specifies both direction and unicode-bidi properties instead of just direction property.
8:16 PM Changeset in webkit [69909] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

serializeNodesWithNamespaces should be in MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=47749

Moved serializeNodesWithNamespaces to MarkupAccumulator, and renamed it to serializeNodes.
MarkupAccumulator::serializeNode now returns the resultant string instead of having a separate takeResults().
Added several helper functions to MarkupAccumulator.

No new tests are added since this is a cleanup.

  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodes): Wrapper for serializeNodes and concatenateMarkup. (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Moved from markup.cpp (WebCore::MarkupAccumulator::appendStartTag): Calls appendString instead of appending into m_succeedingMarkup directly. (WebCore::MarkupAccumulator::appendEndTag): Ditto. (WebCore::MarkupAccumulator::totalLength): Added; extracted from takeResults. (WebCore::MarkupAccumulator::concatenateMarkup): Ditto.
  • editing/MarkupAccumulator.h: (WebCore::MarkupAccumulator::length): Added; calls totalLength.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): Added; calls MarkupAccumulator's appendString. (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendString. (WebCore::StyledMarkupAccumulator::takeResults): Calls length, totalLength, and concatenateMarkup. (WebCore::StyledMarkupAccumulator::serializeNodes): Became a member function. (WebCore::createMarkup): Uses MarkupAccumulator.
7:17 PM Changeset in webkit [69908] by thakis@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 69901 - 2010-10-15 Nico Weber <​thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
​https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):

TBR=​thakis@chromium.org

7:05 PM Changeset in webkit [69907] by kinuko@chromium.org
  • 14 edits
    1 move
    5 adds in trunk

2010-10-15 Kinuko Yasuda <​kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Added.
  • fileapi/DOMFileSystem.h:
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Added.
  • fileapi/DOMFileSystemSync.h:
  • fileapi/DirectoryReaderBase.h: Added 'virtual path' comment.
  • fileapi/EntryBase.h: Added 'virtual path' comment.
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file): Changed to use DOMFileSystem::createFile.
  • fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::file): Implemented.
  • fileapi/FileEntrySync.h:
  • fileapi/FileEntrySync.idl: Added file().

2010-10-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

  • fast/filesystem/file-from-file-entry-expected.txt:
  • fast/filesystem/file-from-file-entry.html:
  • fast/filesystem/resources/file-from-file-entry-sync.js: Added.
  • fast/filesystem/resources/file-from-file-entry.js: Added.
  • fast/filesystem/script-tests/file-from-file-entry.js: Moved to resources to make it available for workers tests too.
  • fast/filesystem/workers/file-from-file-entry-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync.html: Added.
  • fast/filesystem/workers/file-from-file-entry.html: Added.
6:50 PM Changeset in webkit [69906] by oliver@apple.com
  • 4 edits
    3 adds in trunk

2010-10-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

Automatic Semicolon Insertion incorrectly inserts semicolon after break, continue, and return followed by a newline
​https://bugs.webkit.org/show_bug.cgi?id=47762

The old YACC parser depended on the lexer for some classes of semicolon insertion.
The new parser handles ASI entirely on its own so when the lexer inserts a semicolon
on its own the net result is a spurious semicolon in the input stream. This can result
in incorrect parsing in some cases:

if (0)

break

;else {}

Would result in a parse failure as the output from the lexer is essentially

if (0)

break

;;else

So the second semicolon is interpreted as a empty statement, which terminates the if,
making the else an error.

  • parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement): Parsing of throw statement was wrong, and only worked due to the weird behaviour in the lexer
  • parser/Lexer.cpp: (JSC::Lexer::lex): Remove bogus semicolon insertion from the newline handling

2010-10-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

ASI incorrectly inserts semicolon after break, continue, and return followed by a newline
​https://bugs.webkit.org/show_bug.cgi?id=47762

tests for correct ASI following break, continue, and return

  • fast/js/break-ASI-expected.txt: Added.
  • fast/js/break-ASI.html: Added.
  • fast/js/script-tests/break-ASI.js: Added.
6:31 PM Changeset in webkit [69905] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

mocktool.MockOptions is inheriting from Mock, which has the side
effect of defaulting any attribute to another MockObject. So,
MockOptions().foo would always evaluate to true. This was
covering over bugs in the unit tests, and is probably the wrong
default behavior for anything attempting to mock out the options
argument returned from optparse.parse_args().

This patch changes the default behavior. The new MockOptions()
class takes an optional list of keyword parameters to set; this
patch doesn't use that feature but the fix for bug 47510 will.

Also, this patch just fills in the default values necessary to
get all of the tests to pass; I didn't stare at each test by
hand to determine the "right" values. We can either fix that in
subsequent patches or let me know if we want to do that now (and
give me some guidance on what those values might want to be).

​https://bugs.webkit.org/show_bug.cgi?id=47709

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
6:15 PM Changeset in webkit [69904] by crogers@google.com
  • 56 edits
    2 adds in branches/audio/WebCore

audio branch: changes in preparation for landing into trunk

  • massive munge to change to proper license
  • cleanup of delay-related files
  • add AudioResamplerKernel files
  • lots of cleanup for AudioNodeInput and AudioNodeOutput
  • cleanup of AudioResampler
  • lots of cleanup for AudioBufferSourceNode

audio branch: last minute cleanup

6:08 PM Changeset in webkit [69903] by jamesr@google.com
  • 21 edits
    20 copies in trunk/LayoutTests

2010-10-15 Mihai Parparita <​mihaip@chromium.org>

Reviewed by James Robinson.

css2.1/ layout tests need new Mac baselines for Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=47760

Rebaseline 10 css2.1/ test for Snow Leopard using the experimental
local rebaselining tool.

  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.png.
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum:
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.png:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.png:
  • platform/mac/css2.1/t040103-case-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-case-00-b-expected.png:
  • platform/mac/css2.1/t040103-case-01-c-expected.checksum:
  • platform/mac/css2.1/t040103-case-01-c-expected.png:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.png:
6:01 PM Changeset in webkit [69902] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createPopupMenuProxy):

5:56 PM Changeset in webkit [69901] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-10-15 Nico Weber <​thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
​https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):
5:50 PM Changeset in webkit [69900] by bweinstein@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
​https://bugs.webkit.org/show_bug.cgi?id=47753
<rdar://problem/8558242>

Reviewed by Sam Weinig.

WebCore:

r69850 switched over to a different way of concatenating WebCore strings, but ran into an issue
where some Windows calls were returning null terminated strings, and this breaks the new
method of concatenation.

GetLocaleInfo returns a null-terminated string, but WebCore strings are non-null terminated,
so once we create our WebCore string, we want to trim off the null terminating character before
we return the localeInfo.

Test: fast/dom/navigator-userAgent.html

  • platform/win/Language.cpp:

(WebCore::localeInfo):

WebKit/win:

VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
when we turn it into a WebCore string, or else concatenation using this string will break.

  • WebView.cpp:

LayoutTests:

Add a test to make sure that the user agent has some important parts, and is fully formed.
This test tests that the user agent has Mozilla, AppleWebKit, and KHML, like Gecko. If the
user agent has all of these components, the string concatenation worked correctly, and this
bug is fixed.

  • fast/dom/navigator-userAgent-expected.txt: Added.
  • fast/dom/navigator-userAgent.html: Added.
5:47 PM Changeset in webkit [69899] by weinig@apple.com
  • 22 edits
    9 adds in trunk/WebKit2

Popup widget support (<select>)
<rdar://problem/8147746>
​https://bugs.webkit.org/show_bug.cgi?id=47740

Reviewed by Anders Carlsson.

Add initial support for popup menus. Only works on the mac at this time.

  • Shared/WebPopupItem.cpp: Added.

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h: Added.

Serializable representation of a menu item.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy):
Create a WebPopupMenuProxyMac.

  • UIProcess/API/qt/qwkpage.cpp:

(WebView::createPopupMenuProxy):

  • UIProcess/API/qt/qwkpage_p.h:

Create a WebPopupMenuProxyQt (which is just a stub right now).

(WebKit::WebPopupMenuProxyWin::create):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy):

  • UIProcess/win/WebView.h:

Create a WebPopupMenuProxyWin (which is just a stub right now).

  • UIProcess/PageClient.h:

Add new client function to get a platform specific WebPopupMenuProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Pipe through calls to set up the menu.

  • UIProcess/mac/WebPopupMenuProxyMac.h: Added.

(WebKit::WebPopupMenuProxyMac::create):

  • UIProcess/mac/WebPopupMenuProxyMac.mm: Added.

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::~WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
(WebKit::WebPopupMenuProxyMac::hidePopupMenu):
Add UI process side implementation. Currently this does not support
custom fonts as the old implementation did.

  • UIProcess/qt/WebPopupMenuProxyQt.cpp: Added.

(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::~WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):

  • UIProcess/qt/WebPopupMenuProxyQt.h: Added.

(WebKit::WebPopupMenuProxyQt::create):

  • UIProcess/win/WebPopupMenuProxyWin.cpp: Added.

(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::~WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::hidePopupMenu):

  • UIProcess/win/WebPopupMenuProxyWin.h: Added.

Add stubbed out implementations for Qt and windows.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
Pass the page in the create function.

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::create):
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::disconnectFromPage):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::create):
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::setActivePopupMenu):
(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe through calls to set up the menu.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

5:40 PM Changeset in webkit [69898] by ap@apple.com
  • 4 edits in trunk/WebCore

Trying to fix crashes on Leopard buildbot.

  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): Moved logging higher in the function - it seems that CachedResource can be already destroyed.
  • platform/Logging.cpp: (WebCore::getChannelFromName):
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize the new channel (oops).
5:14 PM Changeset in webkit [69897] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):

4:39 PM Changeset in webkit [69896] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-10-15 Mike Lawther <​mikelawther@chromium.org>

Reviewed by James Robinson.

iframes keep getting scrollbars with scrolling="no"
​https://bugs.webkit.org/show_bug.cgi?id=29240

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

  • fast/frames/iframe-scrolling-attribute-overflowscroll-expected.txt: Added.
  • fast/frames/iframe-scrolling-attribute-overflowscroll.html: Added.

2010-10-15 Mike Lawther <​mikelawther@chromium.org>

Reviewed by James Robinson.

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

iframes keep getting scrollbars with scrolling="no"
​https://bugs.webkit.org/show_bug.cgi?id=29240

Test: fast/frames/iframe-scrolling-attribute-overflowscroll.html

  • page/FrameView.cpp: (WebCore::FrameView::calculateScrollbarModesForLayout) (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h: (WebCore::FrameView::calculateScrollbarModesForLayout)
4:33 PM Changeset in webkit [69895] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Make the find indicator window fade out when requested
​https://bugs.webkit.org/show_bug.cgi?id=47747

Reviewed by Sam Weinig.

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

Add WebFindIndicatorWindowAnimation - an NSAnimation subclass that takes two
C++ member function pointers and invokes them the animation progress changes and
when the animation stops.

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):
Call the _animationProgressCallback.

(-[WebFindIndicatorWindowAnimation animationDidEnd:]):
Call the _animationDidEndCallback.

(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize the fade out start timer.

(WebKit::FindIndicatorWindow::setFindIndicator):
When asked to fade out, we start the fade out timer.

(WebKit::FindIndicatorWindow::closeWindow):
Stop the fade out timer and the fade out animation.

(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
Create a fade out animation.

(WebKit::FindIndicatorWindow::fadeOutAnimationCallback):
Update the window alpha.

(WebKit::FindIndicatorWindow::fadeOutAnimationDidEnd):
Close the window.

3:52 PM Changeset in webkit [69894] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <Simon Fraser>

Fix the build; need to add new slot to PageUIClient callbacks.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
3:43 PM Changeset in webkit [69893] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <Simon Fraser>

Add Matt Delaney to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
3:33 PM Changeset in webkit [69892] by Simon Fraser
  • 8 edits in trunk/WebKit2

2010-10-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Add 'didDraw' callback for framerate tracking
​https://bugs.webkit.org/show_bug.cgi?id=47478

Hook up the 'didDraw' callback for WebKit2 on Mac.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didDraw):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::didDraw):
  • UIProcess/WebUIClient.h:
3:28 PM Changeset in webkit [69891] by jianli@chromium.org
  • 6 edits in branches/chromium/552

Merge 69883 - FileReader.readAsDataURL should take Blob object
​https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

BUG=59409
TEST=none

TBR=​jianli@chromium.org

3:27 PM Changeset in webkit [69890] by mitz@apple.com
  • 2 edits in trunk/WebCore

Clean up RenderFlexibleBox::applyLineClamp()
​https://bugs.webkit.org/show_bug.cgi?id=47743

Reviewed by Adele Peterson.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

3:17 PM Changeset in webkit [69889] by ap@apple.com
  • 2 edits in trunk

Correct ChangeLogs.

3:14 PM Changeset in webkit [69888] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 69865 - 2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.

BUG=58832
TBR=​rniwa@webkit.org

3:12 PM Changeset in webkit [69887] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=47736
<rdar://problem/8429396> WebCore cache gets corrupted if revalidation request starts at a wrong time

Test: http/tests/cache/stopped-revalidation.html

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Copied logic for revalidation requests from didFail().
3:05 PM Changeset in webkit [69886] by ap@apple.com
  • 6 edits in trunk/WebCore

2010-10-15 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler in <​https://bugs.webkit.org/show_bug.cgi?id=47736>.

Add a logging channel for WebCore cache and resource loading.

Test: http/tests/cache/stopped-revalidation.html

  • platform/Logging.cpp:
  • platform/Logging.h: Added a logging channel for Cache and Loader.
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationFailed): (WebCore::Cache::evict):
  • loader/CachedResource.cpp: (WebCore::CachedResource::setResourceToRevalidate): (WebCore::CachedResource::switchClientsToRevalidatedResource): (WebCore::CachedResource::mustRevalidate): Added logging.
  • loader/loader.cpp: (WebCore::Loader::load): Added logging. (WebCore::Loader::scheduleServePendingRequests): Ditto. (WebCore::Loader::requestTimerFired): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::Host::servePendingRequests): Changed logging to use the new channel. (WebCore::Loader::Host::didFinishLoading): Changed logging to use the new channel. (WebCore::Loader::Host::didFail): Added logging.
2:58 PM Changeset in webkit [69885] by Nate Chapin
  • 41 edits
    24 adds in trunk/LayoutTests

2010-10-15 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

Update results for ​http://trac.webkit.org/changeset/69872.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
2:57 PM Changeset in webkit [69884] by noam.rosenthal@nokia.com
  • 7 edits in trunk/WebCore

2010-10-15 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Add public functions to serialize TransformOperations.
​https://bugs.webkit.org/show_bug.cgi?id=47728

Added public accessors to the internal data of the TransformOperations.

No new tests. These functions are enablers for WebKit2.

  • platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::matrix):
  • platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::matrix):
  • platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::perspective):
  • platform/graphics/transforms/RotateTransformOperation.h: (WebCore::RotateTransformOperation::x): (WebCore::RotateTransformOperation::y): (WebCore::RotateTransformOperation::z):
  • platform/graphics/transforms/SkewTransformOperation.h: (WebCore::SkewTransformOperation::angleX): (WebCore::SkewTransformOperation::angleY):
  • platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::x): (WebCore::TranslateTransformOperation::y): (WebCore::TranslateTransformOperation::z):
2:46 PM Changeset in webkit [69883] by jianli@chromium.org
  • 8 edits in trunk

FileReader.readAsDataURL should take Blob object
​https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

WebCore:

Test cases have been added into read-blob-test-cases.js.

  • fileapi/FileReader.idl: Update per the latest File API spec.

LayoutTests:

  • fast/files/read-blob-async-expected.txt:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSingleTextBlobAsDataURL):
(testReadingSingleTextBlobAsDataURL2):
(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-sync-expected.txt:
2:38 PM Changeset in webkit [69882] by jianli@chromium.org
  • 1 edit in branches/chromium/552/WebKit/chromium/public/WebBlobRegistry.h

Merge 69615 - Unreview. Build fix for chromium.

  • public/WebBlobRegistry.h:

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:36 PM Changeset in webkit [69881] by jianli@chromium.org
  • 5 edits
    2 copies
    2 deletes in branches/chromium/552/WebKit/chromium

Merge 69611 - [chromium] Update WebBlobData to adapt to BlobData change in terms of
handling string data item.
​https://bugs.webkit.org/show_bug.cgi?id=47423

Reviewed by Darin Fisher.

Also remove unneeded methods in WebBlobData. WebBlobStorageData.* are
also removed since they're not longer needed.

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:34 PM Changeset in webkit [69880] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-10-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move MarkupAccumulator from markup.cpp to its own file
​https://bugs.webkit.org/show_bug.cgi?id=47734

This patch moves the MarkupAccumulator class into its own file.
There's a lot of clean up left to do, but this patch is a step in the
right direction.

No behavior change.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/markup.cpp: (WebCore::elementCannotHaveEndTag):
  • editing/markup.h:
  • editing/MarkupAccumulator.h: Added.
  • editing/MarkupAccumulator.cpp: Added.
2:34 PM Changeset in webkit [69879] by jianli@chromium.org
  • 9 edits in branches/chromium/552/WebCore

Merge 69610 - Fix passing blob data with string data item between threads.
​https://bugs.webkit.org/show_bug.cgi?id=46543

Reviewed by David Levin.

The fix is to use a thread-safe ref-counted Vector<char> to store the
string data. This also makes us be able to store any binary data in it.

I've also fix BlobBuilder and BlobRegistryImpl to avoid some additional
copies to make blob handling faster.

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:31 PM Changeset in webkit [69878] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Move find indicator window logic to WKView
​https://bugs.webkit.org/show_bug.cgi?id=47739

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Call -[WKView _setFindIndicator:fadeOut:].

  • UIProcess/API/mac/WKView.mm:

(-[WKView renewGState]):
Hide the find indicator.

(-[WKView _setFindIndicator:fadeOut:]):
Move the find indicator logic here.

2:05 PM Changeset in webkit [69877] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Hide the find indicator/overlay when necessary
​https://bugs.webkit.org/show_bug.cgi?id=47737

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Hide the find indicator.

(WebKit::WebChromeClient::scroll):
Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Hide the find indicator and the find overlay.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
Always hide all previous find matches. Only clear the selection if the string
not found wasn't empty.

(WebKit::FindController::hideFindUI):
Uninstall the page overlay and hide the find indicator.

(WebKit::FindController::hideFindIndicator):
Rename resetFindIndicator to hideFindIndicator.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::uninstallPageOverlay):
Invalidate the entire page.

1:53 PM Changeset in webkit [69876] by rniwa@webkit.org
  • 9 edits in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
​https://bugs.webkit.org/show_bug.cgi?id=47712

Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
to FormatBlockCommand.cpp

Tests are added to editing/execCommand/query-format-block.html

  • editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand. (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
  • editing/FormatBlockCommand.cpp: (WebCore::isElementForFormatBlock): (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element. (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp. Takes Range* instead of accessing selection directly. (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::didApply): Added.

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
​https://bugs.webkit.org/show_bug.cgi?id=47712

Added queryCommandValue('formatBlock') tests for support article, aside, blockquote, dd, dl, div,
dl, dt, dl, footer, header, hgroup, nav, and section.

Also added tests to ensure we don't return tag name for a subset of unsupported elements.

  • editing/execCommand/query-format-block-expected.txt:
  • editing/execCommand/script-tests/query-format-block.js: (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
1:39 PM Changeset in webkit [69875] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline two GTK+ tests.

  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt:
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt:
1:02 PM Changeset in webkit [69874] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-10-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
​https://bugs.webkit.org/show_bug.cgi?id=16090

Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
differ, do nothing if not.
Also added caching of the repaint rect to avoid multiple calculations.

Test: svg/custom/repaint-on-constant-size-change.svg

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): Update repaint rect on layout. (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.

2010-10-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
​https://bugs.webkit.org/show_bug.cgi?id=16090

Added a repaint example to make sure that setting the attributes x, y, width or height
doens't cause a repaint if the boundaries don't change.

  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
  • svg/custom/repaint-on-constant-size-change.svg: Added.
12:57 PM Changeset in webkit [69873] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro in a file that does not include config.h
12:46 PM Changeset in webkit [69872] by krit@webkit.org
  • 21 edits
    20 adds in trunk/LayoutTests

2010-10-15 Dirk Schulze <​krit@webkit.org>

Unreviewed rebaseline of Snow Leopard.

Moved current results for SVGFEConvolveMatrixElement to mac-leopard.

  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
12:16 PM Changeset in webkit [69871] by andersca@apple.com
  • 6 edits
    1 copy
    1 add in trunk

Add FindIndicatorWindow class
​https://bugs.webkit.org/show_bug.cgi?id=47731

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by the FindIndicator in WebKit2.

  • WebCore.exp.in:

WebKit2:

  • UIProcess/API/mac/FindIndicatorWindow.h: Added.
  • UIProcess/API/mac/FindIndicatorWindow.mm: Added.

(-[WebFindIndicatorView _initWithFindIndicator:WebKit::]):
Initialize the find indicator view.

(-[WebFindIndicatorView drawRect:]):
Ask the find indicator to draw.

(-[WebFindIndicatorView isFlipped]):
Return YES.

(WebKit::FindIndicatorWindow::~FindIndicatorWindow):
Make sure to close the window.

(WebKit::FindIndicatorWindow::setFindIndicator):
Update the find indicator window.

(WebKit::FindIndicatorWindow::closeWindow):
Close and release the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Create a find indicator window.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

11:48 AM Changeset in webkit [69870] by tony@chromium.org
  • 5 edits
    3 adds in trunk

2010-10-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn

Fix an include dir so we can compile in a chromium checkout.

2010-10-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • DumpRenderTree/DumpRenderTree.gypi: files to compile
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
11:42 AM Changeset in webkit [69869] by leandro@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

Add new files needed by the Soup network backend, and #ifdef a
GTK+-port only include in soup-cache.h.

  • CMakeListsEfl.txt:
  • platform/network/soup/cache/webkit/soup-cache.h:
11:30 AM Changeset in webkit [69868] by Darin Adler
  • 73 edits in trunk/WebCore

2010-10-14 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Use more specific types for node pointers, especially when calling node insertion and removal functions
​https://bugs.webkit.org/show_bug.cgi?id=47702

Refactoring. No new tests.

While developing this patch I temporarily removed the node insertion and
removal member functions from the Node class and fixed almost all call sites
so they call it directly on the ContainerNode class, which will be important
once we make the functions non-virtual.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next):
  • dom/Text.cpp: (WebCore::Text::replaceWholeText):
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousNode):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.h:
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doUnapply):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
  • editing/RemoveNodeCommand.h:
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doReapply):
  • editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries):
  • editing/htmlediting.cpp: (WebCore::enclosingList):
  • editing/markup.cpp: (WebCore::serializeNodes): (WebCore::ancestorToRetainStructureAndAppearance): (WebCore::createMarkup):
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::updateFocusAppearance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::associatedControl):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::recalcSelectOptions): (WebCore::HTMLOptGroupElement::ownerSelectElement):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::insertRow):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::containsNode):
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement):
  • svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement):
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::childrenChanged):
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::updateContainerOffsets):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
  • wml/WMLOptionElement.cpp: (WebCore::ownerSelectElement):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use ContainerNode* for the result of the parentNode function now that it returns a ContainerNode*. In the past it used to return just Node*.
  • dom/ContainerNode.h: Added toContainerNode.
  • dom/Element.h: Use ContainerNode*. Added toElement.
  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment): Explcitly cast to HTMLElement* in the case that handles <html> and <body> elements. (WebCore::Element::baseURI): Use ContainerNode*.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*. (WebCore::Node::isDescendantOf): Ditto. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::setTextContent): Use already-typecast pointer in a call to appendChild. (WebCore::Node::ancestorElement): Use ContainerNode*.
  • dom/Range.cpp: (WebCore::Range::compareNode): Use ContainerNode*. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases where we previously checked that the node in question has a child. Any node that returns a non-zero value for firstChild is a ContainerNode. (WebCore::Range::checkNodeBA): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::surroundContents): Ditto.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use more specific types, document instead of doc, and paragraph instead of par.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Use ContainerNode*. (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes): Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function took a Node argument and had Node in its name.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode. (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes): Renamed and changed to take HTMLElement. Also use ContainerNode. (WebCore::CompositeEditCommand::prune): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
  • editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node. (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement. (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes. (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
  • editing/ReplaceNodeWithSpanCommand.h: Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result of insertFragmentForTestRendering since that's what it returns. (WebCore::ReplacementFragment::removeNode): Use ContainerNode. (WebCore::ReplacementFragment::insertNodeBefore): Ditto. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement. Use HTMLElement for body. (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take StyledElement. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode. (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for the cloned span, since the clone will be a sspan too. (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since the list item has a child, and that proves it is a ContainerNode.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): Use ContainerNode and also removed an unnneded local variable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText): Use ContainerNode. (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make the logic a little simpler. (WebCore::contextElementForInsertion): Use ContainerNode. (WebCore::HTMLElement::findFormAncestor): Ditto.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode. (WebCore::InspectorDOMAgent::changeTagName): Ditto. (WebCore::InspectorDOMAgent::setOuterHTML): Ditto. (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of nodeType. We should almost never use nodeType inside the engine. (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode. (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
  • wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore, replaceChild, removeChild, appendChild, and removeChildren functions. Ths already overrides childrenChanged, that is called by all of the above, and it does the same thing these functions did. (WebCore::ownerSelectElement): Use ContainerNode.
  • wml/WMLOptGroupElement.h: Ditto.
11:18 AM Changeset in webkit [69867] by jam@chromium.org
  • 2 edits in branches/chromium/552/WebKit/chromium

2010-10-14 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Tony Chang.

[chromium] null check the widget before sending it data as calling didReceiveData might delete it
​https://bugs.webkit.org/show_bug.cgi?id=47708

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
11:12 AM Changeset in webkit [69866] by andersca@apple.com
  • 3 edits in trunk/WebKit2

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

Patch by Sergio Villar Senin <​svillar@igalia.com> on 2010-10-15
Reviewed by Martin Robinson.

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:
11:05 AM Changeset in webkit [69865] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.
10:53 AM Changeset in webkit [69864] by alex
  • 2 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped flaky tests, added followup bug:
​https://bugs.webkit.org/show_bug.cgi?id=47727

  • platform/gtk/Skipped:
10:37 AM Changeset in webkit [69863] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

build-webkit: Should die when make fails when build a CMake project
​https://bugs.webkit.org/show_bug.cgi?id=47726

  • Scripts/webkitdirs.pm: If make fails, die immediately.
10:27 AM Changeset in webkit [69862] by andersca@apple.com
  • 19 edits
    1 copy
    1 add in trunk

Add a FindIndicator class
​https://bugs.webkit.org/show_bug.cgi?id=47635

Reviewed by Sam Weinig.

WebCore:

Make Gradient.h and Generator.h private headers; they're used by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

  • Shared/BackingStore.h:

(WebKit::BackingStore::bounds):
New function that returns the bounds of the backing store.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Add stub.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setFindIndicator):
Add stub.

  • UIProcess/FindIndicator.cpp: Added.
  • UIProcess/FindIndicator.h:
  • UIProcess/PageClient.h:

Add setFindIndicator client member function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
Call PageClient::setFindIndicator.

  • UIProcess/WebPageProxy.messages.in:

Add a fadeOut boolean to the message.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator):
Add stub.

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::resetFindIndicator):

  • WebProcess/WebPage/FindController.h:
  • win/WebKit2.vcproj:
10:12 AM Changeset in webkit [69861] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
​https://bugs.webkit.org/show_bug.cgi?id=29299

Tests that 302 redirections without Location do not ignore the
body for redirection purpouses (the body could have a meta
http-equiv=refresh)

  • http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
  • http/tests/navigation/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.pl: Added.

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
​https://bugs.webkit.org/show_bug.cgi?id=29299

Body is now provided to WebKitGtk+ in some redirections (like 302)
because it could be used by servers to perform clunky redirections
for example using http-equiv=REFRESH

Test: http/tests/navigation/redirect302-metaredirect.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::finishedCallback):
10:06 AM Changeset in webkit [69860] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-10-15 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Add failing tests from r69824 and r69833.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [69859] by jorlow@chromium.org
  • 57 edits in branches/chromium/552

BUG=58992

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

Reviewed by Nate Chapin.

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

WebCore:

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):

  • storage/IDBCursor.h:

(WebCore::IDBCursor::continueFunction):

  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):

  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.h:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):

  • storage/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):

  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

WebKit/chromium:

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):

  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp:

(WebCore::IDBCursorBackendProxy::update):
(WebCore::IDBCursorBackendProxy::continueFunction):
(WebCore::IDBCursorBackendProxy::remove):

  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp:

(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):

  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp:

(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::openKeyCursor):
(WebCore::IDBIndexBackendProxy::get):
(WebCore::IDBIndexBackendProxy::getKey):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp:

(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):

  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::update):
(WebKit::WebIDBCursorImpl::continueFunction):
(WebKit::WebIDBCursorImpl::remove):

  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::setVersion):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::openKeyCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):

  • src/WebIDBObjectStoreImpl.h:

Merge 69721 - 2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h: (WebCore::IDBFactory::open):
  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:

TBR=​jorlow@chromium.org

9:48 AM Changeset in webkit [69858] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

WebKitSoupCacheType was incorrectly registered twice. Renamed to
WebKitSoupCacheTypeType for the enumerated type.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_type_get_type):
9:43 AM WebKitGtkLayoutTests edited by kov@webkit.org
(diff)
9:30 AM Changeset in webkit [69857] by commit-queue@webkit.org
  • 5 edits
    3 deletes in trunk

2010-10-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
​http://trac.webkit.org/changeset/69809
​https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • WebKit.gyp:

2010-10-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
​http://trac.webkit.org/changeset/69809
​https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
9:27 AM Changeset in webkit [69856] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-15 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] window.close() doesn't work in qt
​https://bugs.webkit.org/show_bug.cgi?id=46186

Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:
8:56 AM Changeset in webkit [69855] by Martin Robinson
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Fix my rebaseline sanfu.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-get-expected.txt.
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-put-expected.txt.
8:34 AM Changeset in webkit [69854] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few other failing tests. They differ because
dumpAsText output depends on whether or not certain content
reaches the edge of the view and wraps.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
8:20 AM Changeset in webkit [69853] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-10-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.

This is a part of Inspector protocol sanitization activity.
We want to populate console messages only if it is required by frontend.

​https://bugs.webkit.org/show_bug.cgi?id=46802

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setConsoleMessagesEnabled): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone):
8:11 AM Changeset in webkit [69852] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

Windows build fix. Unreviewed.

  • WebCoreSupport/WebInspectorClient.cpp:

Add a missing include.

6:56 AM Changeset in webkit [69851] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-15 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unbreak scrolling the ContentsLayer with QWebView

r69777 broke scrolling the contents layer in QWebView by not restoring
the painter clip after painting each part of the dirty region.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
5:29 AM Changeset in webkit [69850] by Nikolas Zimmermann
  • 17 edits in trunk

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • wtf/text/StringConcatenate.h: Add UChar specific StringTypeAdapter, to accept single UChars in makeString().

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach):
  • src/LocalizedStrings.cpp: (WebCore::imageTitle):
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebsettings.cpp: (webkitOSVersion): (webkitUserAgent):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::updateWindowTitle):
  • WebView.cpp: (WebView::standardUserAgentWithApplicationName): (osVersion):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::imageTitle): (PlatformStrategiesWinCE::multipleFileUploadText):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
5:23 AM Changeset in webkit [69849] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-15 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Nikolas Zimmermann.

[EFL] REGRESSION(69798) UCHAR can't be converted to String.
​https://bugs.webkit.org/show_bug.cgi?id=47698

Create String value using String(const char*, 1) instead of operator[].

No tests. No functionality changed.

  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createWindowsKeyMap):
3:39 AM Changeset in webkit [69848] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Do a stricter check for invalid base64 dataURLs
​https://bugs.webkit.org/show_bug.cgi?id=47717

Restore the strict base64 decoding we added in
​https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
in ​https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
test. The actual issue was that we were not finishing the load of
the resource gracefully when an error happened.

Loading invalid base64-encoded data:// URLs are now handled
properly.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
2:04 AM Changeset in webkit [69847] by loislo@chromium.org
  • 2 edits in trunk/JavaScriptCore

2010-10-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Debug Leopard which is failng to compile after r69842.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):
1:47 AM Changeset in webkit [69846] by alex
  • 3 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Rebaseline some failing tests to the former results, apparently
they are flaky, skip if they continue failing.

  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
1:33 AM Changeset in webkit [69845] by alex
  • 3 edits in trunk/WebCore

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

compile fail with gtk >= 2.22
​https://bugs.webkit.org/show_bug.cgi?id=47483

  • platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation, it was added long time ago and currently it is not adding any real area to the clip vertically, actually the gtk3 shrink version did not work. (WebCore::Font::drawComplexText):
  • platform/gtk/gtk2drawing.c: Undef the deprecation flags, this file is full of gtk2 stuff, and it does not seem interesting to upgrade because we are already creating a new version of the file for gtk3.
1:31 AM Changeset in webkit [69844] by loislo@chromium.org
  • 15 edits
    2 adds in trunk

2010-10-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector settings/properties/states management
should be extracted into separate class.

We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.

​https://bugs.webkit.org/show_bug.cgi?id=47275

WebCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::searchingForNodeInPage): (WebCore::InspectorController::resourceTrackingEnabled): (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::mouseDidMoveOverElement): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorState.cpp: Added. (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::generateStateObjectForFrontend): (WebCore::InspectorState::loadFromSettings): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h: Added. (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
1:20 AM Changeset in webkit [69843] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Adam Barth <​abarth@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on Linux
​https://bugs.webkit.org/show_bug.cgi?id=47713

The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.

  • Scripts/webkitpy/tool/mocktool.py:
12:59 AM Changeset in webkit [69842] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=46893

Patch by Peter Varga <​pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.

Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

Note: See TracTimeline for information about the timeline view.