⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 24, 2010:

11:25 PM Changeset in webkit [70439] by kinuko@chromium.org
  • 40 edits in branches/chromium/552

Merge 70438 - 2010-10-20 Kinuko Yasuda <​kinuko@chromium.org>

BUG=60520

TBR=​kinuko@chromium.org

10:53 PM Changeset in webkit [70438] by kinuko@chromium.org
  • 40 edits in trunk

2010-10-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
​https://bugs.webkit.org/show_bug.cgi?id=47936

  • public/WebFileError.h:
  • src/AssertMatchingEnums.cpp:
  • src/AsyncFileWriterChromium.cpp: (WebCore::AsyncFileWriterChromium::didFail):

2010-10-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
​https://bugs.webkit.org/show_bug.cgi?id=47936

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): Added FileExceptionType case.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Added FileExceptionType case.
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription): Added code for FileException.
  • dom/ExceptionCode.h:
  • fileapi/AsyncFileWriterClient.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): (WebCore::DirectoryEntry::getDirectory): (WebCore::DirectoryEntry::removeRecursively):
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::getFile): (WebCore::DirectoryEntrySync::getDirectory): (WebCore::DirectoryEntrySync::removeRecursively):
  • fileapi/DirectoryReaderSync.cpp: (WebCore::DirectoryReaderSync::readEntries):
  • fileapi/Entry.cpp: (WebCore::Entry::getMetadata): (WebCore::Entry::moveTo): (WebCore::Entry::copyTo): (WebCore::Entry::remove): (WebCore::Entry::getParent):
  • fileapi/EntrySync.cpp: (WebCore::EntrySync::getMetadata): (WebCore::EntrySync::moveTo): (WebCore::EntrySync::copyTo): (WebCore::EntrySync::remove):
  • fileapi/FileError.h: Added error code enum. (WebCore::FileError::create): (WebCore::FileError::code): (WebCore::FileError::FileError):
  • fileapi/FileError.idl: Rebased error code numbers.
  • fileapi/FileException.h: Added exception code enum. (WebCore::FileException::ErrorCodeToExceptionCode): Added.
  • fileapi/FileException.idl: Rebased exception code numbers.
  • fileapi/FileReader.cpp: (WebCore::FileReader::abort): (WebCore::FileReader::failed): (WebCore::FileReader::httpStatusCodeToErrorCode): Changed from httpStatuCodeToExceptionCode.
  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.cpp: (WebCore::FileReaderSyncLoader::start):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didFail):
  • fileapi/FileWriter.cpp: (WebCore::FileWriter::write): (WebCore::FileWriter::seek): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): (WebCore::FileWriter::didFail): (WebCore::FileWriter::setError):
  • fileapi/FileWriter.h:
  • fileapi/SyncCallbackHelper.h: (WebCore::SyncCallbackHelper::SyncCallbackHelper): (WebCore::SyncCallbackHelper::getResult): (WebCore::SyncCallbackHelper::setError):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): (WebCore::WorkerContext::requestFileSystemSync):

2010-10-20 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
​https://bugs.webkit.org/show_bug.cgi?id=47936

Updated test expectations to match with the new error code.

  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-sync-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
  • fast/files/workers/worker-read-file-sync-expected.txt:
  • fast/filesystem/op-copy-expected.txt:
  • fast/filesystem/op-get-entry-expected.txt:
  • fast/filesystem/op-move-expected.txt:
  • fast/filesystem/op-remove-expected.txt:
  • fast/filesystem/op-restricted-chars-expected.txt:
  • fast/filesystem/op-restricted-names-expected.txt:
10:29 PM Changeset in webkit [70437] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-24 Adam Barth <​abarth@webkit.org>

Reviewed by David Kilzer.

webkit-patch upload fails when the patch removes a file
​https://bugs.webkit.org/show_bug.cgi?id=48187

We need to use "--" to separate file names from the rest of the
command.

  • Scripts/webkitpy/common/checkout/scm.py:
10:28 PM Changeset in webkit [70436] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • Interfaces/WebKit.idl: Touched.
10:17 PM Changeset in webkit [70435] by mitz@apple.com
  • 10 edits in trunk

Expose HitTestResult::absoluteMediaURL() via WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=48219

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export HitTestResult::absoluteMediaURL().

WebKit/mac:

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
_absoluteMediaURL.
(-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().

  • WebKit.exp: Export WebElementMediaURLKey.
  • WebView/WebView.mm: Define WebElementMediaURLKey.
  • WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.

WebKit/win:

  • Interfaces/IWebView.idl: Added WebElementMediaURLKey.
  • WebElementPropertyBag.cpp:

(WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().

9:39 PM Changeset in webkit [70434] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-24 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

Check endianness with BIG_ENDIAN in RVCT.
​https://bugs.webkit.org/show_bug.cgi?id=46122

RVCT defines BIG_ENDIAN if compiling for a big-endian target.

  • wtf/Platform.h:
8:45 PM Changeset in webkit [70433] by mitz@apple.com
  • 1 edit
    1 delete in trunk/JavaScriptCore

Removed empty directories.

Rubber-stamped by Dave Kilzer.

8:12 PM Changeset in webkit [70432] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-10-24 MORITA Hajime <​morrita@google.com>

Unreviewed skip.

Added editing/spelling/spelling-linebreak.html to skip,
which was originally tested against a wrong expectation.

  • platform/gtk/Skipped:
7:29 PM Changeset in webkit [70431] by tkent@chromium.org
  • 1 edit
    7 deletes in trunk/LayoutTests

2010-10-24 Kent Tamura <​tkent@chromium.org>

Reviewed by David Kilzer.

Remove unnecessary test results.
​https://bugs.webkit.org/show_bug.cgi?id=47711

The following tests were converted to dumpAsText() in
​http://trac.webkit.org/changeset/47608. So corresponding PNG files
are unnecessary.

  • editing/execCommand/italicizeByCharacter.html
  • editing/execCommand/modifyForeColorByCharacter.html
  • editing/execCommand/strikethroughSelection.html

The following tests were converted to dumpAsText() in
​http://trac.webkit.org/changeset/47543.

  • editing/style/remove-underline-across-paragraph.html
  • editing/style/remove-underline-across-paragraph-in-bold.html

The following tests were converted to dumpAsText() in
​http://trac.webkit.org/changeset/47542.

  • editing/style/remove-underline-after-paragraph.html
  • editing/style/remove-underline-after-paragraph-in-bold.html
  • platform/mac/editing/execCommand/italicizeByCharacter-expected.png: Removed.
  • platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.png: Removed.
  • platform/mac/editing/execCommand/strikethroughSelection-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-after-paragraph-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.png: Removed.
7:18 PM Changeset in webkit [70430] by yuzo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70361.
​http://trac.webkit.org/changeset/70361
​https://bugs.webkit.org/show_bug.cgi?id=48217

Chromium tests NoInitialAutocompleteForReadOnly and
InitialAutocomplete don't complete (Requested by yuzo on
#webkit).

  • public/WebDocument.h:
6:21 PM Changeset in webkit [70429] by morrita@google.com
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2010-10-22 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Text test conversion: editing/spelling/spelling-linebreak.html
​https://bugs.webkit.org/show_bug.cgi?id=47649

Rewrote verification part using hasSpellingMarker().

  • editing/spelling/spelling-linebreak-expected.txt: Added.
  • editing/spelling/spelling-linebreak.html:
  • platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Removed.
  • platform/mac/editing/spelling/spelling-linebreak-expected.checksum: Removed.
  • platform/mac/editing/spelling/spelling-linebreak-expected.png: Removed.
  • platform/mac/editing/spelling/spelling-linebreak-expected.txt: Removed.
6:10 PM Changeset in webkit [70428] by weinig@apple.com
  • 10 edits in trunk

Need a way to determine the screen rect for a form control in WebKit2
<rdar://problem/8530670>
​https://bugs.webkit.org/show_bug.cgi?id=48216

Reviewed by Dan Bernstein.

WebCore:

  • WebCore.exp.in: Add export.
  • dom/Element.cpp:

(WebCore::Element::boundsInWindowSpace):

  • dom/Element.h:

Add function to return the bounding box in window (in ScrollView terminology) space,
this is the same space as the root viewport.

WebKit2:

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
Add conversion from IntRect to WKRect.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetElementBounds):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

Add SPI to get the rect in window space. The client can then convert this to screen
space if they wish to.

5:38 PM Changeset in webkit [70427] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Unreviewed, fix typo of last build fix.

  • wtf/DateMath.cpp:
5:29 PM Changeset in webkit [70426] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for chromium.

  • wtf/DateMath.cpp: Added missing include.
4:20 PM Changeset in webkit [70425] by Patrick Gansterer
  • 8 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add WTF_ARRAY_LENGTH macro to WTF
​https://bugs.webkit.org/show_bug.cgi?id=32828

Unify the different implementations and usages.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString): (JSC::Stringifier::toJSON): (JSC::Stringifier::appendStringifiedValue):
  • runtime/UString.cpp: (JSC::UString::number):
  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters):
  • wtf/StdLibExtras.h:
2:08 PM Changeset in webkit [70424] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-24 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] ImageBuffer::platformTransformColorSpace is unnecessarily slow
​https://bugs.webkit.org/show_bug.cgi?id=48211

Grab the QImage::bits() and do direct access instead of going through
QImage::pixel() and QImage::setPixel().

This is a performance optimization, so no new tests.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
12:49 PM Changeset in webkit [70423] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70413.
​http://trac.webkit.org/changeset/70413
​https://bugs.webkit.org/show_bug.cgi?id=48210

It broke Qt minimal build (Requested by Ossy on #webkit).

  • Scripts/build-webkit:
12:31 PM Changeset in webkit [70422] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Removed deprecated methods from the WebHTMLHighlighter private protocol.

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
unconditionally.
(WebChromeClient::paintCustomHighlight): Call
-paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.

  • WebView/WebHTMLViewPrivate.h:
12:24 PM Changeset in webkit [70421] by krit@webkit.org
  • 12 edits in trunk

2010-10-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Filter example Chiseled from SVG Wow! is slow
​https://bugs.webkit.org/show_bug.cgi?id=48174

Added 'using WTF::ByteArray;' at the end of ByteArray.h

  • wtf/ByteArray.h:

2010-10-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Filter example Chiseled from SVG Wow! is slow
​https://bugs.webkit.org/show_bug.cgi?id=48174

Use a pointer to the ByteArray instead of the ref counted CanvasPixelArray or ImageData directly
to access the data for pixel manipulation on SVG Filters or SVG Masker. This is a
performance increase since the recurring use of the -> operator can be avoided.
FEConvolveMatrix and FELighting still need to change in a followup patch.

No functionality was changed. So, no new tests.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::luminance): (WebCore::effectType): (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic): (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
  • platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
11:58 AM Changeset in webkit [70420] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-10-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: polish network panel UI.
​https://bugs.webkit.org/show_bug.cgi?id=48205

  • inspector/front-end/Images/frame.png:
  • inspector/front-end/Images/networkIcon.png:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._toggleGridMode):
  • inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid.small td): (#network-views .resource-view.headers-visible .resource-view-content): (#network-views.small .resource-view.headers-visible .resource-view-content): (#network-views .resource-view-headers): (#network-views.small .resource-view-headers): (#network-views .resource-view .tabbed-pane-header): (#network-views.small .resource-view .tabbed-pane-header):
11:53 AM Changeset in webkit [70419] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Inline WTF::bitwise_cast and fix style
​https://bugs.webkit.org/show_bug.cgi?id=48208

  • wtf/StdLibExtras.h: (WTF::bitwise_cast): (WTF::bitCount):
10:15 AM Changeset in webkit [70418] by commit-queue@webkit.org
  • 2 edits in trunk

2010-10-24 Anders Bakken <​agbakken@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Disable enable_fast_mobile_scrolling for QWS
​https://bugs.webkit.org/show_bug.cgi?id=48006

Turning this on breaks the acidtests for QWS/DirectFB and QWS/QVFB

  • WebKit.pri:
9:59 AM Changeset in webkit [70417] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-24 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
​https://bugs.webkit.org/show_bug.cgi?id=48141

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView): (LauncherWindow::toggleWebView):
9:58 AM Changeset in webkit [70416] by dbates@webkit.org
  • 2 edits
    1 add
    11 deletes in trunk/LayoutTests

2010-10-24 Daniel Bates <​dbates@rim.com>

Reviewed by Antonio Gomes.

Convert layout test fast/frame/frame-src-attribute.html from
render-tree/pixel test to text-only test
​https://bugs.webkit.org/show_bug.cgi?id=48200

Modified the test case LayoutTests/fast/frame/frame-src-attribute.html
to dump its output as text.

Currently, the test produces a render-tree dump. Instead, it is sufficient
for this test to dump as text since it is a PASS/FAIL-style test. This will
also make the test results platform-independent.

  • fast/frames/frame-src-attribute-expected.txt: Added.
  • fast/frames/frame-src-attribute.html: Modified to dump its output as text.
  • platform/chromium-linux/fast/frames/frame-src-attribute-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/frame-src-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/frames/frame-src-attribute-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/frame-src-attribute-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-src-attribute-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/frame-src-attribute-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-src-attribute-expected.txt: Removed.
  • platform/gtk/fast/frames/frame-src-attribute-expected.txt: Removed.
  • platform/mac/fast/frames/frame-src-attribute-expected.checksum: Removed.
  • platform/mac/fast/frames/frame-src-attribute-expected.png: Removed.
  • platform/mac/fast/frames/frame-src-attribute-expected.txt: Removed.
  • platform/qt/fast/frames/frame-src-attribute-expected.txt: Removed.
9:54 AM Changeset in webkit [70415] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-10-24 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

Fix Perl uninitialized warnings in VCSUtils::svnStatus()
and VCSUtils::removeEOL().
​https://bugs.webkit.org/show_bug.cgi?id=48196

VCSUtils::svnStatus() concatenates the output of svn status with
a new line character and svn status may return no output (say for
a file that has not been added, deleted, or modified). We should
only concatenate the output of svn status if there is some.

Also, VCSUtils::removeEOL() should ensure that its argument
is initialized before performing a string substitution.

  • Scripts/VCSUtils.pm:
    • Modified removeEOL() to return "" if its argument is undefined.
    • Exported removeEOL() so that it can be tested.
  • Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.
9:12 AM Changeset in webkit [70414] by Nikolas Zimmermann
  • 7 edits in trunk

2010-10-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

Fix WebGL tests. Accept 'boolean' as valid numeric type in StrictTypeChecking mode.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:

2010-10-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

It turns out the CodeGenerator changes are right, and the webgl tests have a problem, since StrictTypeChecking was enabled for numeric types.
When calling gl.bindAttribLocation() be sure to pass the second argument as integer, not as string.
Fixes all failing webgl tests on the snow leopard bot.

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils):
  • fast/canvas/webgl/resources/webgl-test.js: (createProgram):
6:59 AM Changeset in webkit [70413] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit: Added support for --progress-tag switch.

It should have been added with r57051.

6:49 AM Changeset in webkit [70412] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability

Reviewed by Daniel Bates.

  • Scripts/build-webkit: Alphabetized the @features array based

on the name of the feature. Reformatted the list of support
variables so that they match the order of @features, and so that
each has its own line. This makes it easy to add new variables
in the correct order.

4:58 AM Changeset in webkit [70411] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-10-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

Speculative fix for the WebGL tests, I was not aware they're not run on Leopard, so I missed the breakage.

  • bindings/scripts/CodeGeneratorJS.pm: Restore the order of type checking in the 'StrictTypeChecking' code.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
3:38 AM Changeset in webkit [70410] by Nikolas Zimmermann
  • 25 edits
    4 adds in trunk

2010-10-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

Rewrite SVGAngle to use the new SVGPropertyTearOff concept, and consume much less memory.
Down from two floats, one string and an ushort to one float and one ushort. Synchronize value/valueInSpecifiedUnits/valueAsString on demand.

Adding an extensive SVGAngle test, that required to implement 'StrictTypeChecking' for attribute setters (was only implemented in V8/JSC for function cals so far).

Test: svg/dom/SVGAngle.html

  • GNUmakefile.am: Add SVGAnimatedAngle.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Split IsPrimitiveType in IsPrimitiveType and IsNumericType.
  • bindings/scripts/CodeGeneratorJS.pm: Implement 'StrictTypeChecking' for setters and recognize SVGAngle as new SVGPropertyTearOff type.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAngle handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedAngle handling.
  • svg/SVGAngle.cpp: Rewrite, to consume less memory and to operate more efficient.
  • svg/SVGAngle.h: Ditto.
  • svg/SVGAngle.idl: Add 'StrictTypeChecking' to the value/valueInSpecifiedUnits methods.
  • svg/SVGAnimatedAngle.h: Added.
  • svg/SVGAnimatedAngle.idl: Mark as [SVGAnimatedProperty].
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): SVGAngle::setValueAsString() now takes an ExceptionCode parameter.
  • svg/SVGMarkerElement.h: s/ANIMATED_PROPERTY/ANIMATED_PROPERTY_NEW/ for the SVGAngle type.
  • svg/SVGNumber.idl: Remove exception setter exceptions, which aren't needed. As we're now generating exception handlers in the bindings, it would lead to compile errors.
  • svg/SVGPoint.idl: Ditto.
  • svg/SVGRect.idl: Ditto.
  • svg/SVGSVGElement.idl: Remove obsolete [SVGLiveProperty] flag.

2010-10-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

Add an extensive SVGAngle test, checking all getter/setters & methods, with valid and invalid arguments.
The test exposes bugs in Opera & FireFox, we now pass them all.

  • svg/dom/SVGAngle-expected.txt: Added.
  • svg/dom/SVGAngle.html: Added.
  • svg/dom/script-tests/SVGAngle.js: Added.
  • svg/dom/svg-element-attribute-js-null-expected.txt:
  • svg/dom/svg-element-attribute-js-null.xhtml: Update incorrect test, setting valueAsString to null, should not result in "0deg" but "0".

Oct 23, 2010:

9:44 PM Changeset in webkit [70409] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

EWS never removes invalid patch ids
​https://bugs.webkit.org/show_bug.cgi?id=48173

This is just sticking another finger in the dam.
However this adds more unit testing which will help
us make sure we're always releasing patches once we
redesign the release_patch API and call these from
a more central place.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
    • Added the ability to request invalid patches. Log a warning message to make sure we don't ever have tests use invalid patch fetches by mistake.
9:34 PM Changeset in webkit [70408] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-10-23 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] Unbreak build by removing duplicate test expectations.

  • platform/chromium/drt_expectations.txt: Removed duplicates.
7:19 PM Changeset in webkit [70407] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-23 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
​https://bugs.webkit.org/show_bug.cgi?id=48197

With the landing of the patch for bug #45365 in
changeset 67182 <​http://trac.webkit.org/changeset/67182>,
HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed.
Therefore, we remove it.

Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach
callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182
removed this callback.

No functionality was changed. So, no new tests.

  • html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback().
  • html/HTMLFrameElementBase.h: Ditto.
4:49 PM Changeset in webkit [70406] by xan@webkit.org
  • 28 edits in trunk

2010-10-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

Unify globalData APIs
​https://bugs.webkit.org/show_bug.cgi?id=47969

Make JSGlobalObject::globalData return a reference and adapt
callers. This unifies the API with the existing
CallFrame::globalData, which also returns a reference.

  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):
  • jsc.cpp: (runWithScripts):
  • parser/JSParser.cpp: (JSC::jsParse):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • runtime/Error.cpp: (JSC::createError): (JSC::createEvalError): (JSC::createRangeError): (JSC::createReferenceError): (JSC::createSyntaxError): (JSC::createTypeError): (JSC::createURIError):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::globalData):

WebCore:

2010-10-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

Unify globalData APIs
​https://bugs.webkit.org/show_bug.cgi?id=47969

Adapt code to JSGlobalObject::globalData returning a reference
instead of a pointer.

  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::markChildren):
  • bindings/js/JSWorkerContextErrorHandler.cpp: (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):

WebKit2:

2010-10-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

Unify globalData APIs
​https://bugs.webkit.org/show_bug.cgi?id=47969

Adapt code to JSGlobalObject::globalData returning a reference
instead of a pointer.

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateJSObject): (WebKit::NPRuntimeObjectMap::evaluate):

WebKit/mac:

2010-10-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

Unify globalData APIs
​https://bugs.webkit.org/show_bug.cgi?id=47969

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct):
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):
4:47 PM Changeset in webkit [70405] by ap@apple.com
  • 2 edits in trunk/WebCore

2010-10-23 Alexey Proskuryakov <​ap@apple.com>

Windows debug build fix.

  • platform/network/cf/CookieStorageCFNet.cpp: Include MainThread.h for isMainThread().
4:24 PM Changeset in webkit [70404] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Add stub implementations for required NSDraggingInfo methods.

  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:

(-[DumpRenderTreeDraggingInfo draggingFormation]):
(-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
(-[DumpRenderTreeDraggingInfo animatesToDestination]):
(-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
(-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
(-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
(-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):

4:21 PM Changeset in webkit [70403] by ddkilzer@apple.com
  • 5 edits
    2 deletes in trunk

2010-10-23 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header

Reviewed by Sam Weinig.

The only method defined in WebHTMLRepresentationInternal.h is
also defined in WebHTMLRepresentation.h, so use that instead.

  • WebKit.xcodeproj/project.pbxproj: Removed references to WebHTMLRepresentationInternal.h.

2010-10-23 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header

Reviewed by Sam Weinig.

The only method defined in WebHTMLRepresentationInternal.h is
also defined in WebHTMLRepresentation.h, so use that instead.

  • WebView/WebHTMLRepresentationInternal.h: Removed.

2010-10-23 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header

Reviewed by Sam Weinig.

The only method defined in WebHTMLRepresentationInternal.h is
also defined in WebHTMLRepresentation.h, so use that instead.

  • DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
  • DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use WebHTMLRepresentation.h.
4:18 PM Changeset in webkit [70402] by ap@apple.com
  • 3 edits in trunk/WebKitLibraries

2010-10-23 Alexey Proskuryakov <​ap@apple.com>

Windows build fix.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
3:32 PM Changeset in webkit [70401] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): It's adoptCF, not adoptPtr.
3:17 PM Changeset in webkit [70400] by ap@apple.com
  • 30 edits
    2 adds in trunk

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=48083
<rdar://problem/8489082> Need WebKit2 API for private browsing (48083)

1:53 PM Changeset in webkit [70399] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2010-10-23 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/48181> Add missing include of MacErrors.h

Reviewed by Alexey Proskuryakov.

  • platform/network/mac/FormDataStreamMac.mm: Added #import of <MacErrors.h> for iOS since the formOpen() method uses "fnfErr", which was added in r55670. The same header is included through <CoreServices/CoreServices.h> on Mac OS X.
1:02 PM Changeset in webkit [70398] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

[WINCE] Port COMPtr.h to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48190

Don't include guiddef.h on WinCE. It's not required and only creates build problems.

  • platform/win/COMPtr.h:
11:58 AM Changeset in webkit [70397] by Patrick Gansterer
  • 4 edits in trunk/WebCore

2010-10-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

[WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create
​https://bugs.webkit.org/show_bug.cgi?id=48180

Also use better arguments for the create function.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::getTransparentLayerBitmap): (WebCore::TransparentLayerDC::TransparentLayerDC): (WebCore::GraphicsContext::drawFrameControl):
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBufferData::ImageBufferData):
  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
11:08 AM Changeset in webkit [70396] by mihaip@chromium.org
  • 9 edits
    6 copies
    2 adds in trunk/LayoutTests

2010-10-23 Mihai Parparita <​mihaip@chromium.org>

css2.1/ layout tests need new Mac baselines for Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=47760

Unreviewed rebaseline of remaining 5 css2.1/ tests for Snow Leopard
using the experimental local rebaselining tool.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.checksum.
  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.png.
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.checksum.
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.png.
  • platform/mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum.
  • platform/mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png.
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum:
  • platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png:
  • platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Added.
  • platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
10:14 AM Changeset in webkit [70395] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-23 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a test after r70391.

  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
10:05 AM Changeset in webkit [70394] by Dimitri Glazkov
  • 13 edits
    1 delete in trunk

2010-10-23 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70369.
​http://trac.webkit.org/changeset/70369
​https://bugs.webkit.org/show_bug.cgi?id=47974

Caused weird artifacts in expected results.

  • wtf/Platform.h:

2010-10-23 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70369.
​http://trac.webkit.org/changeset/70369
​https://bugs.webkit.org/show_bug.cgi?id=47974

Caused weird artifacts in expected results.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • platform/graphics/ImageSource.h:
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: Removed.
  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
9:51 AM Changeset in webkit [70393] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-10-23 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] Remove duplicate expectations.

  • platform/chromium/drt_expectations.txt: Unduplicated.
9:48 AM Changeset in webkit [70392] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-23 Adam Barth <​abarth@webkit.org>

Reviewed by Andreas Kling.

WebP decoding hits ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=48168

Calling reserveCapacity only allocates the memory. It doesn't actually
set the length. When you try to access the zeroth element, you hit an
ASSERT.

Covered by fast/images/webp-image-decoding.html in debug.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
8:29 AM Changeset in webkit [70391] by Martin Robinson
  • 5 edits
    27 adds in trunk

2010-10-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menu list buttons do react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=48099

Rebaseline menu list button tests and add pixel results. There
are still issues with padding around separators, but these will
be fixed in a further patch.

  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-clip-expected.png: Added.
  • platform/gtk/fast/forms/menulist-clip-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png: Added.
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png: Added.
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-option-wrap-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/gtk/fast/forms/menulist-option-wrap-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-style-color-expected.png: Added.
  • platform/gtk/fast/forms/menulist-style-color-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum: Added.
  • platform/gtk/fast/forms/menulist-width-change-expected.png: Added.
  • platform/gtk/fast/forms/menulist-width-change-expected.txt: Added.

2010-10-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menu list buttons do react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=48099

Correct the way that menu list buttons get their necessary padding from
GTK+. Instead of resetting the padding to these values, return them via
the popupInternalPadding* methods. Add implementations for *MenuListButton*
methods.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::getComboBoxPadding): Added. (WebCore::RenderThemeGtk::popupInternalPaddingLeft): Added. (WebCore::RenderThemeGtk::popupInternalPaddingRight): Added. (WebCore::RenderThemeGtk::popupInternalPaddingTop): Added. (WebCore::RenderThemeGtk::popupInternalPaddingBottom): Added. (WebCore::RenderThemeGtk::adjustMenuListStyle): Do not reset CSS properties, instead rely on the poupInternalPadding* methods. (WebCore::RenderThemeGtk::adjustMenuListButtonStyle): Added. (WebCore::RenderThemeGtk::paintMenuListButton): Added.
  • platform/gtk/RenderThemeGtk.h: Added new method declarations.
8:08 AM Changeset in webkit [70390] by Martin Robinson
  • 2 edits in trunk/JavaScriptCore

2010-10-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Crashes randomly in cairo_scaled_font_destroy
​https://bugs.webkit.org/show_bug.cgi?id=46794

Make PlatformRefPtr aware of hashTableDeletedValue. When PlatformRefPtr
goes away this should probably be handled in the future via some special
hooks in RefCounted (or its contained type).

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::~PlatformRefPtr): (WTF::PlatformRefPtr::clear): (WTF::::operator):
8:08 AM Changeset in webkit [70389] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-10-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add Gradient::hasAlpha
​https://bugs.webkit.org/show_bug.cgi?id=48183

WinCE can do some performance improvements if the gradient is opaque.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::hasAlpha):
  • platform/graphics/Gradient.h:
7:40 AM Changeset in webkit [70388] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-23 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by David Kilzer.

[EFL] Implement platformDefaultLanguage()
​https://bugs.webkit.org/show_bug.cgi?id=48113

Implement the platformDefaultLanguage() function for EFL port.

  • platform/efl/LanguageEfl.cpp: (WebCore::platformDefaultLanguage):
7:22 AM Changeset in webkit [70387] by timothy@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

Stub out WebInspectorFrontendClient.

​https://bugs.webkit.org/show_bug.cgi?id=48091

Reviewed by Adam Roben.

  • WebKit2.pro: Added WebInspectorFrontendClient.{cpp,h}.
  • WebKit2.xcodeproj/project.pbxproj: Added WebInspectorFrontendClient.{cpp,h}.
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: Added.

(WebKit::WebInspectorFrontendClient::windowObjectCleared): Added.
(WebKit::WebInspectorFrontendClient::frontendLoaded): Added.
(WebKit::WebInspectorFrontendClient::moveWindowBy): Added.
(WebKit::WebInspectorFrontendClient::localizedStringsURL): Added.
(WebKit::WebInspectorFrontendClient::hiddenPanels): Added.
(WebKit::WebInspectorFrontendClient::bringToFront): Added.
(WebKit::WebInspectorFrontendClient::closeWindow): Added.
(WebKit::WebInspectorFrontendClient::disconnectFromBackend): Added.
(WebKit::WebInspectorFrontendClient::requestAttachWindow): Added.
(WebKit::WebInspectorFrontendClient::requestDetachWindow): Added.
(WebKit::WebInspectorFrontendClient::changeAttachedWindowHeight): Added.
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Added.
(WebKit::WebInspectorFrontendClient::sendMessageToBackend): Added.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: Added.

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient): Added.

  • win/WebKit2.vcproj: Added WebInspectorFrontendClient.{cpp,h}.
7:22 AM Changeset in webkit [70386] by timothy@apple.com
  • 3 edits in trunk/WebKit2

Remove stale stubs that are not longer part of InspectorClient.

​https://bugs.webkit.org/show_bug.cgi?id=48090

Reviewed by Adam Roben.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
12:44 AM Changeset in webkit [70385] by commit-queue@webkit.org
  • 18 edits
    2 deletes in trunk

2010-10-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70367.
​http://trac.webkit.org/changeset/70367
​https://bugs.webkit.org/show_bug.cgi?id=48176

It made 8-10 tests crash on Qt bot (Requested by Ossy on
#webkit).

  • fast/loader/decide-policy-for-mime-type-async-expected.txt: Removed.
  • fast/loader/decide-policy-for-mime-type-async.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-10-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70367.
​http://trac.webkit.org/changeset/70367
​https://bugs.webkit.org/show_bug.cgi?id=48176

It made 8-10 tests crash on Qt bot (Requested by Ossy on
#webkit).

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::setDefersLoading):
  • loader/MainResourceLoader.h:

2010-10-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70367.
​http://trac.webkit.org/changeset/70367
​https://bugs.webkit.org/show_bug.cgi?id=48176

It made 8-10 tests crash on Qt bot (Requested by Ossy on
#webkit).

  • DumpRenderTree/LayoutTestController.cpp: (setCustomPolicyDelegateCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCustomPolicyDelegate):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCustomPolicyDelegate):
  • DumpRenderTree/mac/PolicyDelegate.h:
  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): (-[PolicyDelegate setPermissive:]): (-[PolicyDelegate setControllerToNotifyDone:]):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCustomPolicyDelegate):
12:18 AM Changeset in webkit [70384] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70381.
​http://trac.webkit.org/changeset/70381
​https://bugs.webkit.org/show_bug.cgi?id=48175

"Fails in the 32bit debug bot" (Requested by xan_ on #webkit).

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.