Context Navigation

← Previous Period
Next Period →

Timeline

Oct 25, 2010:

9:45 PM Changeset in webkit [70512] by morrita@google.com

12 edits in trunk

2010-10-22 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spellcheck= should be the same as spellcheck="true"
https://bugs.webkit.org/show_bug.cgi?id=25539

editing/spelling/spellcheck-attribute-expected.txt:
editing/spelling/spellcheck-attribute.html:

2010-10-24 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spellcheck= should be the same as spellcheck="true"
https://bugs.webkit.org/show_bug.cgi?id=25539

Added a check for empty string and missing attribute.
Extracted the check to Element::spellCheckingEnabled()
Introduced SpellcheckAttributeState enum to represent the states for spellcheck attributes.

dom/Element.cpp: (WebCore::Element::spellcheckAttributeState): Added. (WebCore::Element::isSpellCheckingEnabled): Added.
dom/Element.h:
editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Renamed, partly extracted to Element::isSpellCheckingEnabled() (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
editing/Editor.h:
platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-10-25 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spellcheck= should be the same as spellcheck="true"
https://bugs.webkit.org/show_bug.cgi?id=25539

Followed API rename in WebCore.

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::shouldSpellcheckByDefault):

7:27 PM Changeset in webkit [70511] by tkent@chromium.org

30 edits
4 copies in trunk/WebCore

2010-10-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Refactor HTMLInputElement: Move createRender(), appendFormData(),
saveFormControlState() and restoreFormControlState() to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=47834

This change adds BaseButtonInputType and BaseCheckableInputType. They
are super classes of some concrete InputType classes.

No new tests. Just a code refactoring.

CMakeLists.txt: Add BaseButtonInputType and BaseCheckableInputType files.
GNUmakefile.am: ditto.
WebCore.gypi: ditto.
WebCore.pro: ditto.
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.
html/BaseButtonInputType.cpp: Added. (WebCore::BaseButtonInputType::appendFormData): (WebCore::BaseButtonInputType::createRenderer):
html/BaseButtonInputType.h: Added. (WebCore::BaseButtonInputType::BaseButtonInputType):
html/BaseCheckableInputType.cpp: Added. (WebCore::BaseCheckableInputType::saveFormControlState): (WebCore::BaseCheckableInputType::restoreFormControlState): (WebCore::BaseCheckableInputType::appendFormData):
html/BaseCheckableInputType.h: Added. (WebCore::BaseCheckableInputType::BaseCheckableInputType):
html/ButtonInputType.h: Change the super class. (WebCore::ButtonInputType::ButtonInputType):
html/CheckboxInputType.h: Change the super class. (WebCore::CheckboxInputType::CheckboxInputType):
html/FileInputType.cpp: (WebCore::FileInputType::appendFormData): (WebCore::FileInputType::createRenderer):
html/FileInputType.h: Change the super class. (WebCore::FileInputType::FileInputType):
html/HTMLFormControlElement.h: Make placeholderShouldBeVisible() public for access from TextFieldInputType.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData):
html/HTMLInputElement.h: Add the following functions for ImageInputType and SubmitInputType. (WebCore::HTMLInputElement::xPosition): (WebCore::HTMLInputElement::yPosition):
html/HiddenInputType.cpp: (WebCore::HiddenInputType::createRenderer):
html/HiddenInputType.h:
html/ImageInputType.cpp: (WebCore::ImageInputType::isFormDataAppendable): (WebCore::ImageInputType::appendFormData): (WebCore::ImageInputType::createRenderer):
html/ImageInputType.h: Change the super class. (WebCore::ImageInputType::ImageInputType):
html/InputType.cpp: (WebCore::InputType::saveFormControlState): (WebCore::InputType::restoreFormControlState): (WebCore::InputType::isFormDataAppendable): (WebCore::InputType::appendFormData): (WebCore::InputType::createRenderer):
html/InputType.h:
html/PasswordInputType.cpp: (WebCore::PasswordInputType::saveFormControlState): (WebCore::PasswordInputType::restoreFormControlState):
html/PasswordInputType.h:
html/RadioInputType.h: Change the super class. (WebCore::RadioInputType::RadioInputType):
html/RangeInputType.cpp: (WebCore::RangeInputType::createRenderer):
html/RangeInputType.h:
html/ResetInputType.h: (WebCore::ResetInputType::ResetInputType):
html/SubmitInputType.cpp: (WebCore::SubmitInputType::appendFormData):
html/SubmitInputType.h: Change the super class. (WebCore::SubmitInputType::SubmitInputType):
html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::createRenderer):
html/TextFieldInputType.h:

6:51 PM Changeset in webkit [70510] by andersca@apple.com

3 edits in trunk/WebKit2

WebKit2 callbacks for findString() and countMatchesForString() should report whether the match count was exceeded
https://bugs.webkit.org/show_bug.cgi?id=48285
<rdar://problem/8576318>

Reviewed by Sam Weinig.

UIProcess/API/C/WKPage.h:

Add a kWKMoreThanMaximumMatchCount constant.

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
If we get back more matches than allowed, send kWKMoreThanMaximumMatchCount as the match constant.

6:06 PM Changeset in webkit [70509] by Simon Fraser

6 edits
5 adds in trunk

2010-10-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix scrolling of noncomposited iframes within composited document
https://bugs.webkit.org/show_bug.cgi?id=47391

When an iframe that is painting into a compositing layer is scrolled,
we need to repaint via the RenderObject (which dirties the compositing layer contents),
rather than going out to hostWindow.

Test: compositing/iframes/composited-iframe-scroll.html

page/FrameView.cpp: (WebCore::FrameView::scrollContentsSlowPath):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsSlowPath):
platform/ScrollView.h:

5:10 PM Changeset in webkit [70508] by kbr@google.com

2 edits in trunk/LayoutTests

2010-10-25 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update. Mark WebGL layout test
glsl-conformance.html as also failing after Mesa 7.9 upgrade.

platform/chromium/test_expectations.txt:

5:07 PM Changeset in webkit [70507] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

2010-10-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

execCommand('removeFormat') adds extra styles inside tables
https://bugs.webkit.org/show_bug.cgi?id=29164

Added a test to ensure RemoveFormat command does not add erroneous style attribute
when removing styles inside a table cell.

editing/execCommand/remove-format-in-table-cell-expected.txt: Added.
editing/execCommand/remove-format-in-table-cell.html: Added.

4:52 PM Changeset in webkit [70506] by mitz@apple.com

2 edits in trunk/WebKit2

Non-Carbon build fix.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowFrameChanged):

4:47 PM Changeset in webkit [70505] by kbr@google.com

2 edits in trunk/LayoutTests

2010-10-25 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update. Temporarily WebGL layout
tests gl-object-get-calls.html and uniform-location.html as
failing per http://crbug.com/60651 after Mesa 7.9 upgrade until
the failures can be investigated.

platform/chromium/test_expectations.txt:

4:43 PM Changeset in webkit [70504] by timothy@apple.com

14 edits
1 copy
5 adds in trunk/WebKit2

Stub out WebInspector objects and WKInspectorRef API.

https://webkit.org/b/48265

Reviewed by Anders Carlsson.

Platform/CoreIPC/MessageID.h: Added MessageClassWebInspector and MessageClassWebInspectorProxy.
Shared/API/c/WKBase.h: Added WKInspectorRef.
Shared/APIObject.h: Added TypeInspector.
UIProcess/API/C/WKAPICast.h: Added WKInspectorRef to WebInspectorProxy mapping.
UIProcess/API/C/WKInspector.cpp: Added.

(WKInspectorGetTypeID):
(WKInspectorGetPage):

UIProcess/API/C/WKInspector.h: Added.
UIProcess/API/C/WKPage.cpp:

(WKPageGetInspector): Added.

UIProcess/API/C/WKPage.h:
UIProcess/WebInspectorProxy.cpp: Added.

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::~WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):

UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::create):
(WebKit::WebInspectorProxy::page):
(WebKit::WebInspectorProxy::type):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::inspector): Lazily create the WebInspectorProxy.

UIProcess/WebPageProxy.h:
WebKit2.pro: Added new files.
WebKit2.xcodeproj/project.pbxproj: Added new files.
WebProcess/WebPage/WebInspector.cpp: Added.

(WebKit::WebInspector::WebInspector):

WebProcess/WebPage/WebInspector.h: Added.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::inspector): Lazily create the WebInspector.

WebProcess/WebPage/WebPage.h:
win/WebKit2.vcproj: Added new files.

4:32 PM Changeset in webkit [70503] by rniwa@webkit.org

4 edits in trunk/WebCore

2010-10-25 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt build fix for r70496.

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::numberValue):
bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapWidthField::valueFromInstance): (JSC::Bindings::QtPixmapHeightField::valueFromInstance):
bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):

4:25 PM Changeset in webkit [70502] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-10-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch should clean up svn locks when passed --force-clean
https://bugs.webkit.org/show_bug.cgi?id=48269

Scripts/webkitpy/common/checkout/scm.py:

4:22 PM Changeset in webkit [70501] by weinig@apple.com

2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

Rubber-stamped by Anders Carlsson.

platform/mac-wk2/Skipped:

4:03 PM Changeset in webkit [70500] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

2010-10-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

execCommand removeFormat is blowing away text outside the selection
https://bugs.webkit.org/show_bug.cgi?id=21843

Added a test to ensure executing RemoveFormant command on an orphaned list item
does not remove non-orphaned list items preceding the orphaned item.

editing/execCommand/remove-format-orphaned-list-item-expected.txt: Added.
editing/execCommand/remove-format-orphaned-list-item.html: Added.

3:59 PM Changeset in webkit [70499] by andersca@apple.com

4 edits in trunk/WebKit2

Update the fake Carbon window when the window frame changes
https://bugs.webkit.org/show_bug.cgi?id=48273

Reviewed by Dan Bernstein.

UIProcess/API/mac/WKView.mm:

(screenForWindow):
(-[WKView _updateWindowFrame]):
Pass the window frame in Carbon coordinates.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowFrameChanged):
Update the window bounds.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setWindowFrame):
Call the plug-in.

(WebKit::PluginView::platformLayer):
Fix a crash when WebCore asked for the layer before it was initialized.

3:59 PM Changeset in webkit [70498] by Csaba Osztrogonác

2 edits
1 delete in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

Remove incorrect Qt specific expected file for http/tests/security/mixedContent/insecure-css-in-main-frame.html.
Platform independent is the correct one.

Add http/tests/security/mixedContent/insecure-css-in-main-frame.html
to the Skipped list, because it is a flakey test due to this bug.

platform/qt/Skipped:
platform/qt/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Removed.

3:48 PM Changeset in webkit [70497] by aestes@apple.com

3 edits
2 adds in trunk

2010-10-25 Andy Estes <aestes@apple.com>

Reviewed by Simon Fraser.

Source change by Simon Fraser.

Setting an element's visibility property to visible has no effect when
it has a hidden parent.
https://bugs.webkit.org/show_bug.cgi?id=48267

Test: fast/layers/visible-layer-with-hidden-parent.html

When a layer is hidden, there is an optimization that removes it from
the layer tree. If the layer is made visible again, it would only mark
its own stacking context's z-order list as dirty. If there are hidden
parent layers, they need to be marked dirty as well so layers with
visible descendents are re-added to the layer tree.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Dirty the z-order lists of all parent stacking context render layers up to and including the first visible stacking context.

2010-10-25 Andy Estes <aestes@apple.com>

Reviewed by Simon Fraser.

Setting an element's visibility property to visible has no effect when
it has a hidden parent.
https://bugs.webkit.org/show_bug.cgi?id=48267

fast/layers/visible-layer-with-hidden-parent-expected.txt: Added.
fast/layers/visible-layer-with-hidden-parent.html: Added.

3:40 PM Changeset in webkit [70496] by oliver@apple.com

83 edits in trunk

2010-10-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove exec and globalData arguments from jsNumber
https://bugs.webkit.org/show_bug.cgi?id=48270

Remove the now unused exec and globalData arguments from jsNumber
and mechanically update all users of jsNumber.

API/JSValueRef.cpp: (JSValueMakeNumber):
bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod):
jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_mod):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
jsc.cpp: (functionRun):
runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor):
runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
runtime/CachedTranscendentalFunction.h: (JSC::CachedTranscendentalFunction::operator()):
runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
runtime/DatePrototype.cpp: (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
runtime/Error.cpp: (JSC::addErrorSourceInfo): (JSC::addErrorDivotInfo):
runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor):
runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
runtime/JSByteArray.h: (JSC::JSByteArray::getIndex):
runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertyDescriptor):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat):
runtime/JSNumberCell.h: (JSC::JSValue::JSValue): (JSC::jsNaN): (JSC::JSValue::toJSNumber):
runtime/JSONObject.cpp: (JSC::unwrapBoxedPrimitive): (JSC::PropertyNameForFunctionCall::value): (JSC::JSONStringify):
runtime/JSString.cpp: (JSC::JSString::getStringPropertyDescriptor):
runtime/JSString.h: (JSC::JSString::getStringPropertySlot):
runtime/JSValue.h: (JSC::jsDoubleNumber): (JSC::jsNumber): (JSC::jsNaN): (JSC::JSValue::JSValue): (JSC::JSValue::toJSNumber):
runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
runtime/MathObject.cpp: (JSC::MathObject::MathObject): (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue): (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
runtime/Operations.cpp: (JSC::jsAddSlowCase):
runtime/Operations.h: (JSC::jsAdd):
runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): (JSC::RegExpMatchesArray::fillArrayInstance):
runtime/RegExpObject.cpp: (JSC::regExpObjectLastIndex):
runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype): (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncLocaleCompare):

2010-10-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove exec and globalData arguments from jsNumber
https://bugs.webkit.org/show_bug.cgi?id=48270

Don't pass exec to jsNumber

JSUtils.cpp: (JSObjectKJSValue):
UserObjectImp.cpp: (UserObjectImp::toPrimitive):

2010-10-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove exec and globalData arguments from jsNumber
https://bugs.webkit.org/show_bug.cgi?id=48270

Mechanical removal of exec parameter to jsNumber.

bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
bindings/js/JSCoordinatesCustom.cpp: (WebCore::JSCoordinates::altitude): (WebCore::JSCoordinates::altitudeAccuracy): (WebCore::JSCoordinates::heading): (WebCore::JSCoordinates::speed):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject): (WebCore::JSDeviceMotionEvent::interval):
bindings/js/JSDeviceOrientationEventCustom.cpp: (WebCore::JSDeviceOrientationEvent::alpha): (WebCore::JSDeviceOrientationEvent::beta): (WebCore::JSDeviceOrientationEvent::gamma):
bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::watchPosition):
bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::selectionEnd):
bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::length):
bindings/js/JSIDBKeyCustom.cpp: (WebCore::toJS):
bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value):
bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::callUID):
bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS):
bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
bindings/js/JSWorkerContextErrorHandler.cpp: (WebCore::JSWorkerContextErrorHandler::handleEvent):
bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallArgumentHandler::appendArgument):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):
bindings/scripts/CodeGeneratorJS.pm:
bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::numberValue):
bridge/c/c_utility.cpp: (JSC::Bindings::convertNPVariantToValue):
bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::numberValue): (JavaInstance::invokeMethod):
bridge/objc/objc_instance.mm: (ObjcInstance::numberValue):
bridge/objc/objc_utility.mm: (JSC::Bindings::convertObjcValueToValue):
bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter):
bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter):

2010-10-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove exec and globalData arguments from jsNumber
https://bugs.webkit.org/show_bug.cgi?id=48270

Mechanical removal of exec parameter to jsNumber

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::numberValue):

2010-10-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove exec and globalData arguments from jsNumber
https://bugs.webkit.org/show_bug.cgi?id=48270

Mechanical removal of exec parameter to jsNumber

WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::convertNPVariantToJSValue):

3:21 PM Changeset in webkit [70495] by mihaip@chromium.org

109 edits
108 copies
10 adds in trunk/LayoutTests

2010-10-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Snow Leopard rebaseline of animations, compositing, css1,
css3, dom, and fast/backgrounds.

platform/mac-leopard/animations/state-at-end-event-expected.checksum: Copied from LayoutTests/platform/mac/animations/state-at-end-event-expected.checksum.
platform/mac-leopard/animations/state-at-end-event-expected.png: Copied from LayoutTests/platform/mac/animations/state-at-end-event-expected.png.
platform/mac-leopard/compositing/generated-content-expected.checksum: Copied from LayoutTests/platform/mac/compositing/generated-content-expected.checksum.
platform/mac-leopard/compositing/generated-content-expected.png: Copied from LayoutTests/platform/mac/compositing/generated-content-expected.png.
platform/mac-leopard/compositing/geometry/composited-html-size-expected.checksum: Copied from LayoutTests/platform/mac/compositing/geometry/composited-html-size-expected.checksum.
platform/mac-leopard/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/mac/compositing/geometry/composited-html-size-expected.png.
platform/mac-leopard/compositing/geometry/outline-change-expected.checksum: Copied from LayoutTests/platform/mac/compositing/geometry/outline-change-expected.checksum.
platform/mac-leopard/compositing/geometry/outline-change-expected.png: Copied from LayoutTests/platform/mac/compositing/geometry/outline-change-expected.png.
platform/mac-leopard/compositing/iframes/composited-iframe-alignment-expected.checksum: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-alignment-expected.checksum.
platform/mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-alignment-expected.png.
platform/mac-leopard/compositing/iframes/iframe-in-composited-layer-expected.checksum: Copied from LayoutTests/platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum.
platform/mac-leopard/compositing/iframes/iframe-in-composited-layer-expected.png: Copied from LayoutTests/platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png.
platform/mac-leopard/compositing/overflow/parent-overflow-expected.checksum: Copied from LayoutTests/platform/mac/compositing/overflow/parent-overflow-expected.checksum.
platform/mac-leopard/compositing/overflow/parent-overflow-expected.png: Copied from LayoutTests/platform/mac/compositing/overflow/parent-overflow-expected.png.
platform/mac-leopard/compositing/sibling-positioning-expected.checksum: Copied from LayoutTests/platform/mac/compositing/sibling-positioning-expected.checksum.
platform/mac-leopard/compositing/sibling-positioning-expected.png: Copied from LayoutTests/platform/mac/compositing/sibling-positioning-expected.png.
platform/mac-leopard/css1/box_properties/acid_test-expected.checksum: Copied from LayoutTests/platform/mac/css1/box_properties/acid_test-expected.checksum.
platform/mac-leopard/css1/box_properties/acid_test-expected.png: Copied from LayoutTests/platform/mac/css1/box_properties/acid_test-expected.png.
platform/mac-leopard/css1/box_properties/float_margin-expected.checksum: Copied from LayoutTests/platform/mac/css1/box_properties/float_margin-expected.checksum.
platform/mac-leopard/css1/box_properties/float_margin-expected.png: Copied from LayoutTests/platform/mac/css1/box_properties/float_margin-expected.png.
platform/mac-leopard/css1/box_properties/width-expected.checksum: Copied from LayoutTests/platform/mac/css1/box_properties/width-expected.checksum.
platform/mac-leopard/css1/box_properties/width-expected.png: Copied from LayoutTests/platform/mac/css1/box_properties/width-expected.png.
platform/mac-leopard/css1/conformance/forward_compatible_parsing-expected.checksum: Copied from LayoutTests/platform/mac/css1/conformance/forward_compatible_parsing-expected.checksum.
platform/mac-leopard/css1/conformance/forward_compatible_parsing-expected.png: Copied from LayoutTests/platform/mac/css1/conformance/forward_compatible_parsing-expected.png.
platform/mac-leopard/css1/font_properties/font_variant-expected.checksum: Copied from LayoutTests/platform/mac/css1/font_properties/font_variant-expected.checksum.
platform/mac-leopard/css1/font_properties/font_variant-expected.png: Copied from LayoutTests/platform/mac/css1/font_properties/font_variant-expected.png.
platform/mac-leopard/css3/css3-modsel-33-expected.checksum: Copied from LayoutTests/platform/mac/css3/css3-modsel-33-expected.checksum.
platform/mac-leopard/css3/css3-modsel-33-expected.png: Copied from LayoutTests/platform/mac/css3/css3-modsel-33-expected.png.
platform/mac-leopard/css3/css3-modsel-35-expected.checksum: Copied from LayoutTests/platform/mac/css3/css3-modsel-35-expected.checksum.
platform/mac-leopard/css3/css3-modsel-35-expected.png: Copied from LayoutTests/platform/mac/css3/css3-modsel-35-expected.png.
platform/mac-leopard/css3/css3-modsel-36-expected.checksum: Copied from LayoutTests/platform/mac/css3/css3-modsel-36-expected.checksum.
platform/mac-leopard/css3/css3-modsel-36-expected.png: Copied from LayoutTests/platform/mac/css3/css3-modsel-36-expected.png.
platform/mac-leopard/css3/css3-modsel-37-expected.checksum: Copied from LayoutTests/platform/mac/css3/css3-modsel-37-expected.checksum.
platform/mac-leopard/css3/css3-modsel-37-expected.png: Copied from LayoutTests/platform/mac/css3/css3-modsel-37-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/documentgetinputencoding03-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/documentgetinputencoding03-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/entitygetinputencoding02-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/entitygetinputencoding02-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/entitygetxmlversion02-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/entitygetxmlversion02-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri05-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri05-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri07-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri07-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri09-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri09-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri10-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri10-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri11-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri11-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri15-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri15-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri17-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri17-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri18-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodegetbaseuri18-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png.
platform/mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.checksum: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodelookupprefix19-expected.checksum.
platform/mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/nodelookupprefix19-expected.png.
platform/mac-leopard/fast/backgrounds/001-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/001-expected.checksum.
platform/mac-leopard/fast/backgrounds/001-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/001-expected.png.
platform/mac-leopard/fast/backgrounds/animated-gif-as-background-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/animated-gif-as-background-expected.checksum.
platform/mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/animated-gif-as-background-expected.png.
platform/mac-leopard/fast/backgrounds/background-clip-text-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/background-clip-text-expected.checksum.
platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/background-clip-text-expected.png.
platform/mac-leopard/fast/backgrounds/background-inherit-color-bug-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/background-inherit-color-bug-expected.checksum.
platform/mac-leopard/fast/backgrounds/background-inherit-color-bug-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/background-inherit-color-bug-expected.png.
platform/mac-leopard/fast/backgrounds/background-origin-root-element-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/background-origin-root-element-expected.checksum.
platform/mac-leopard/fast/backgrounds/background-origin-root-element-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/background-origin-root-element-expected.png.
platform/mac-leopard/fast/backgrounds/background-position-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/background-position-1-expected.checksum.
platform/mac-leopard/fast/backgrounds/background-position-1-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/background-position-1-expected.png.
platform/mac-leopard/fast/backgrounds/background-position-rounding-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/background-position-rounding-expected.checksum.
platform/mac-leopard/fast/backgrounds/background-position-rounding-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/background-position-rounding-expected.png.
platform/mac-leopard/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum.
platform/mac-leopard/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png.
platform/mac-leopard/fast/backgrounds/opacity-on-document-element-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/opacity-on-document-element-expected.checksum.
platform/mac-leopard/fast/backgrounds/opacity-on-document-element-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/opacity-on-document-element-expected.png.
platform/mac-leopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum.
platform/mac-leopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png.
platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum.
platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize02-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize02-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize02-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize02-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize04-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize04-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize04-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize04-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize13-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize13-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize13-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize13-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize14-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize14-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize14-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize14-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize15-expected.png.
platform/mac-leopard/fast/backgrounds/size/backgroundSize16-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/backgroundSize16-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize16-expected.png.
platform/mac-leopard/fast/backgrounds/size/zero-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/size/zero-expected.checksum.
platform/mac-leopard/fast/backgrounds/size/zero-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/size/zero-expected.png.
platform/mac-leopard/fast/backgrounds/solid-color-context-restore-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/solid-color-context-restore-expected.checksum.
platform/mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/solid-color-context-restore-expected.png.
platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum.
platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-1-expected.png.
platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum.
platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-3-expected.png.
platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum.
platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-5-expected.png.
platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum.
platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.png.
platform/mac-leopard/fast/backgrounds/svg-as-mask-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-mask-expected.checksum.
platform/mac-leopard/fast/backgrounds/svg-as-mask-expected.png: Copied from LayoutTests/platform/mac/fast/backgrounds/svg-as-mask-expected.png.
platform/mac/animations/state-at-end-event-expected.checksum:
platform/mac/animations/state-at-end-event-expected.png:
platform/mac/compositing/generated-content-expected.checksum:
platform/mac/compositing/generated-content-expected.png:
platform/mac/compositing/geometry/composited-html-size-expected.checksum:
platform/mac/compositing/geometry/composited-html-size-expected.png:
platform/mac/compositing/geometry/outline-change-expected.checksum:
platform/mac/compositing/geometry/outline-change-expected.png:
platform/mac/compositing/geometry/tall-page-composited-expected.checksum: Added.
platform/mac/compositing/geometry/tall-page-composited-expected.png: Added.
platform/mac/compositing/iframes/composited-iframe-alignment-expected.checksum:
platform/mac/compositing/iframes/composited-iframe-alignment-expected.png:
platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum:
platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png:
platform/mac/compositing/overflow/parent-overflow-expected.checksum:
platform/mac/compositing/overflow/parent-overflow-expected.png:
platform/mac/compositing/sibling-positioning-expected.checksum:
platform/mac/compositing/sibling-positioning-expected.png:
platform/mac/css1/box_properties/acid_test-expected.checksum:
platform/mac/css1/box_properties/acid_test-expected.png:
platform/mac/css1/box_properties/float_margin-expected.checksum:
platform/mac/css1/box_properties/float_margin-expected.png:
platform/mac/css1/box_properties/width-expected.checksum:
platform/mac/css1/box_properties/width-expected.png:
platform/mac/css1/conformance/forward_compatible_parsing-expected.checksum:
platform/mac/css1/conformance/forward_compatible_parsing-expected.png:
platform/mac/css1/font_properties/font_variant-expected.checksum:
platform/mac/css1/font_properties/font_variant-expected.png:
platform/mac/css3/css3-modsel-33-expected.checksum:
platform/mac/css3/css3-modsel-33-expected.png:
platform/mac/css3/css3-modsel-35-expected.checksum:
platform/mac/css3/css3-modsel-35-expected.png:
platform/mac/css3/css3-modsel-36-expected.checksum:
platform/mac/css3/css3-modsel-36-expected.png:
platform/mac/css3/css3-modsel-37-expected.checksum:
platform/mac/css3/css3-modsel-37-expected.png:
platform/mac/dom/xhtml/level3/core/documentgetinputencoding03-expected.checksum:
platform/mac/dom/xhtml/level3/core/documentgetinputencoding03-expected.png:
platform/mac/dom/xhtml/level3/core/entitygetinputencoding02-expected.checksum:
platform/mac/dom/xhtml/level3/core/entitygetinputencoding02-expected.png:
platform/mac/dom/xhtml/level3/core/entitygetxmlversion02-expected.checksum:
platform/mac/dom/xhtml/level3/core/entitygetxmlversion02-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri05-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri05-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri07-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri07-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri09-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri09-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri10-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri10-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri11-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri11-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri15-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri15-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri17-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri17-expected.png:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri18-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodegetbaseuri18-expected.png:
platform/mac/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png:
platform/mac/dom/xhtml/level3/core/nodelookupprefix19-expected.checksum:
platform/mac/dom/xhtml/level3/core/nodelookupprefix19-expected.png:
platform/mac/fast/backgrounds/001-expected.checksum:
platform/mac/fast/backgrounds/001-expected.png:
platform/mac/fast/backgrounds/animated-gif-as-background-expected.checksum:
platform/mac/fast/backgrounds/animated-gif-as-background-expected.png:
platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
platform/mac/fast/backgrounds/background-clip-text-expected.png:
platform/mac/fast/backgrounds/background-inherit-color-bug-expected.checksum:
platform/mac/fast/backgrounds/background-inherit-color-bug-expected.png:
platform/mac/fast/backgrounds/background-origin-root-element-expected.checksum:
platform/mac/fast/backgrounds/background-origin-root-element-expected.png:
platform/mac/fast/backgrounds/background-position-1-expected.checksum:
platform/mac/fast/backgrounds/background-position-1-expected.png:
platform/mac/fast/backgrounds/background-position-rounding-expected.checksum:
platform/mac/fast/backgrounds/background-position-rounding-expected.png:
platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum:
platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
platform/mac/fast/backgrounds/opacity-on-document-element-expected.checksum:
platform/mac/fast/backgrounds/opacity-on-document-element-expected.png:
platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize02-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize02-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize04-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize04-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize13-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize13-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize14-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize14-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
platform/mac/fast/backgrounds/size/zero-expected.checksum:
platform/mac/fast/backgrounds/size/zero-expected.png:
platform/mac/fast/backgrounds/solid-color-context-restore-expected.checksum:
platform/mac/fast/backgrounds/solid-color-context-restore-expected.png:
platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
platform/mac/fast/backgrounds/svg-as-mask-expected.png:

3:19 PM Changeset in webkit [70494] by satish@chromium.org

2 edits in trunk/WebKit/chromium

2010-10-25 Satish Sampath <satish@chromium.org>

Unreviewed, fix for a build break caused by my earlier patch.

public/WebSpeechInputListener.h: (WebKit::WebSpeechInputListener::setRecognitionResult): Explicitly invoking the correct constructor.

3:17 PM Changeset in webkit [70493] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

2010-10-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Unformat deletes images
https://bugs.webkit.org/show_bug.cgi?id=17926

editing/execCommand/remove-format-image-expected.txt: Added.
editing/execCommand/remove-format-image.html: Added.

2:37 PM Changeset in webkit [70492] by Dimitri Glazkov

1 edit
9 adds in trunk/LayoutTests

2010-10-25 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Added expectations for r70482.
https://bugs.webkit.org/show_bug.cgi?id=48257

platform/chromium-linux/fast/blockflow/english-bt-text-expected.checksum: Added.
platform/chromium-linux/fast/blockflow/english-rl-text-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/english-bt-text-expected.checksum: Added.
platform/chromium-win/fast/blockflow/english-bt-text-expected.checksum: Added.
platform/chromium-win/fast/blockflow/english-bt-text-expected.png: Added.
platform/chromium-win/fast/blockflow/english-bt-text-expected.txt: Added.
platform/chromium-win/fast/blockflow/english-rl-text-expected.checksum: Added.
platform/chromium-win/fast/blockflow/english-rl-text-expected.png: Added.
platform/chromium-win/fast/blockflow/english-rl-text-expected.txt: Added.

2:29 PM Changeset in webkit [70491] by andersca@apple.com

8 edits in trunk/WebKit2

Replace matchCountDidChange with didFindString/didFailToFindString
https://bugs.webkit.org/show_bug.cgi?id=48262
<rdar://problem/8568928>

Reviewed by Darin Adler.

UIProcess/API/C/WKPage.h:
UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::didFindString):
(WebKit::WebFindClient::didFailToFindString):

UIProcess/WebFindClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFindString):
(WebKit::WebPageProxy::didFailToFindString):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):

2:10 PM Changeset in webkit [70490] by satish@chromium.org

19 edits
4 adds in trunk

2010-10-21 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Allow embedder to pass on all the speech recognition results to the input element.
https://bugs.webkit.org/show_bug.cgi?id=48068

No new tests added as functionality has not changed, tests will be added in the next
patch where these results are exposed as an attribute to scripts.

Android.mk: Added new source files.
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
page/SpeechInput.cpp: (WebCore::SpeechInput::setRecognitionResult): Accept an array instead of a single string.
page/SpeechInput.h:
page/SpeechInputListener.h:
page/SpeechInputResult.cpp: Added, defines a class for managing a speech input result. (WebCore::SpeechInputResult::create): (WebCore::SpeechInputResult::SpeechInputResult): (WebCore::SpeechInputResult::confidence): (WebCore::SpeechInputResult::utterance):
page/SpeechInputResult.h: Added.
platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::timerFired):
rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
rendering/TextControlInnerElements.h:

2010-10-21 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Allow embedder to pass on all the speech recognition results to the input element.
https://bugs.webkit.org/show_bug.cgi?id=48068

WebKit.gyp: Added new files
public/WebSpeechInputListener.h:
public/WebSpeechInputResult.h: Added, wrapper around WebCore::SpeechInputResult (WebKit::WebSpeechInputResult::WebSpeechInputResult): (WebKit::WebSpeechInputResult::~WebSpeechInputResult):
src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::setRecognitionResult): Accepts an array instead of a single string.
src/SpeechInputClientImpl.h:
src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult):
src/WebSpeechInputControllerMockImpl.h:
src/WebSpeechInputResult.cpp: Added. (WebKit::WebSpeechInputResult::reset): (WebKit::WebSpeechInputResult::WebSpeechInputResult): (WebKit::WebSpeechInputResult::set): (WebKit::WebSpeechInputResult::operator PassRefPtr<WebCore::SpeechInputResult>):

2:02 PM Changeset in webkit [70489] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2010-10-25 Dimitri Glazkov <Dimitri Glazkov>

Added more flakiness expectations.
https://bugs.webkit.org/show_bug.cgi?id=48263

platform/chromium/test_expectations.txt: Added flaky timeout.

1:45 PM Changeset in webkit [70488] by jianli@chromium.org

9 edits in trunk

Support appending an ArrayBuffer object in BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=47701

Reviewed by David Levin.

WebCore:

Test cases have been added to read-blob-test-cases.js.

fileapi/BlobBuilder.cpp:

(WebCore::BlobBuilder::getBuffer):
(WebCore::BlobBuilder::append): Removed bool return values since they
weren't used.

fileapi/BlobBuilder.h:
fileapi/BlobBuilder.idl:

LayoutTests:

fast/files/read-blob-async-expected.txt:
fast/files/resources/read-blob-test-cases.js:

(testReadingSingleArrayBufferBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingMultipleArrayBufferBlob):
(testReadingHybridBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

fast/files/workers/worker-read-blob-async-expected.txt:
fast/files/workers/worker-read-blob-sync-expected.txt:

1:43 PM Changeset in webkit [70487] by noam.rosenthal@nokia.com

10 edits in trunk

2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Glue layer (WebCoreSupport) changes to allow connecting TextureMapper to a Qt PageClient, i.e.
a QWebView or a QGraphicsWebView. This enables the new type, TextureMapperPlatformLayer, to be recognized both by
the compositor and by the page client.
Note that this is temporarily an opt-in, under USE(TEXTURE_MAPPER)

No new tests: the existing tests under LayoutTests/compositing already cover this.

platform/graphics/GraphicsLayer.h:
platform/qt/QWebPageClient.h: (QWebPageClient::setRootGraphicsLayer):

2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Glue layer (WebCoreSupport) changes to allow connecting TextureMapper to a Qt PageClient, i.e.
a QWebView or a QGraphicsWebView. This enables the new type, TextureMapperPlatformLayer, to be recognized both by
the compositor and by the page client.
Note that this is temporarily an opt-in, under USE(TEXTURE_MAPPER)

Api/qwebframe.h:
Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
Api/qwebpage.cpp: (QWebPage::setView):
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::attachRootGraphicsLayer):
WebCoreSupport/PageClientQt.cpp: (WebCore::PlatformLayerProxyQt::PlatformLayerProxyQt): (WebCore::PlatformLayerProxyQt::~PlatformLayerProxyQt): (WebCore::PlatformLayerProxyQt::setSizeChanged): (WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget): (WebCore::PlatformLayerProxyQWidget::eventFilter): (WebCore::PlatformLayerProxyQWidget::setNeedsDisplay): (WebCore::PlatformLayerProxyQWidget::setNeedsDisplayInRect): (WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsWidget): (WebCore::PlatformLayerProxyQGraphicsObject::setNeedsDisplay): (WebCore::PlatformLayerProxyQGraphicsObject::setNeedsDisplayInRect): (WebCore::PageClientQWidget::setRootGraphicsLayer): (WebCore::PageClientQWidget::markForSync): (WebCore::PageClientQWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

1:36 PM Changeset in webkit [70486] by weinig@apple.com

2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

platform/mac-wk2/Skipped:

1:20 PM Changeset in webkit [70485] by noam.rosenthal@nokia.com

2 edits in trunk/WebCore

2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Add a config flag and a define (WTF_USE_TEXTURE_MAPPER) to WebCore, to enable opt-in compilation of texture-mapper with Qt.

No new tests: WIP for a new implementation.

WebCore.pro:

1:11 PM Changeset in webkit [70484] by jianli@chromium.org

4 edits
2 adds in trunk

Calling FileReader.abort during reading could cause crash
https://bugs.webkit.org/show_bug.cgi?id=48163

Reviewed by David Levin.

WebCore:

Test: fast/files/file-reader-abort.html

fileapi/FileReader.cpp:

(WebCore::delayedAbort):
(WebCore::FileReader::abort): Schedule to do the abort later to work
around the case that abort() could be called from event handler.
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFail): Do not go with normal error handling
when we are in the process of aborting.
(WebCore::FileReader::failed):
(WebCore::FileReader::readyState):

fileapi/FileReader.h:

LayoutTests:

fast/files/file-reader-abort-expected.txt: Added.
fast/files/file-reader-abort.html: Added.

1:08 PM Changeset in webkit [70483] by Patrick Gansterer

2 edits in trunk/WebCore

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Buildfix for NetworkStateNotifier
https://bugs.webkit.org/show_bug.cgi?id=48240

WinCE does not support RegisterWaitForSingleObject, so disable it for now.

platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):

1:06 PM Changeset in webkit [70482] by hyatt@apple.com

11 edits
8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48257

Reviewed by Dan Bernstein.

WebCore:

Make "rl" and "bt" writing-modes work for blocks and lines. InlineTextBox is refactored to compute the correct
top left corner and left baseline edge once so that can be passed down to all the painting functions instead of
tx and ty.

adjustment helpers have been added that can be called before painting children or lines and that fix up
the coordinates from flipped to physical.

Added fast/blockflow/english-rl-text.html and fast/blockflow/english-bt-text.html

rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

rendering/InlineBox.h:
rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
(WebCore::InlineTextBox::paintCompositionUnderline):

rendering/InlineTextBox.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):

rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):

rendering/RenderBox.h:
rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isFlippedBlocksWritingMode):

LayoutTests:

fast/blockflow/english-bt-text.html: Added.
fast/blockflow/english-rl-text.html: Added.
platform/mac/fast/blockflow/english-bt-text-expected.checksum: Added.
platform/mac/fast/blockflow/english-bt-text-expected.png: Added.
platform/mac/fast/blockflow/english-bt-text-expected.txt: Added.
platform/mac/fast/blockflow/english-rl-text-expected.checksum: Added.
platform/mac/fast/blockflow/english-rl-text-expected.png: Added.
platform/mac/fast/blockflow/english-rl-text-expected.txt: Added.

1:04 PM Changeset in webkit [70481] by chang.shu@nokia.com

4 edits in trunk/LayoutTests

2010-10-25 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Should use eventSender for simulating keyboard events instead of using js
event.initKeyboardEvent. Otherwise, inside WebCore, the keyboardevent
object does not have a "PlatformKeyboardEvent" associated with it and this
results different behavior as the real key press.
This code change unveils that test snav-multiple-select.html is broken. It
alos causes snav-single-select.html hangs on Mac. These will be fixed in
seperate patches.
https://bugs.webkit.org/show_bug.cgi?id=48134

fast/events/spatial-navigation/resources/spatial-navigation-utils.js: (doMove):
fast/events/spatial-navigation/snav-multiple-select-expected.txt:
platform/mac/Skipped:

12:54 PM Changeset in webkit [70480] by andersca@apple.com

9 edits in trunk

Add a pageDidScroll BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=48260
<rdar://problem/8531159>

Reviewed by Adam Roben.

WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::pageDidScroll):
Call the pageDidScroll callback.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
(WebKit::WebChromeClient::scroll):
Call pageDidScroll.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageDidScroll):
Hide the find banner UI and call the BundleUIClient pageDidScroll callback.

WebKitTools:

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

12:49 PM Changeset in webkit [70479] by bweinstein@apple.com

2 edits in trunk/WebKit2

Control + Mousewheel shouldn't be handled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48253

Reviewed by Adam Roben.

Don't handle a wheel event if Control is pressed, pass the message back to DefWindowProc.

UIProcess/win/WebView.cpp:

(WebKit::WebView::onWheelEvent):

12:48 PM Changeset in webkit [70478] by benm@google.com

3 edits in trunk/WebCore

2010-10-25 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Build break with ENABLE(BLOB) and not ENABLE(3D_CANVAS)
https://bugs.webkit.org/show_bug.cgi?id=48243

Build fix only so no new tests.

bindings/generic/RuntimeEnabledFeatures.h: Guard appropriately.
bindings/v8/custom/V8ArrayBufferViewCustom.h: ditto.

12:38 PM Changeset in webkit [70477] by inferno@chromium.org

1 edit
2 copies in branches/chromium/552

Merge 70473

BUG=60327

12:37 PM Changeset in webkit [70476] by mihaip@chromium.org

50 edits
47 copies
61 adds in trunk/LayoutTests

2010-10-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed checksum rebaseline for Snow Leopard.

platform/mac-leopard/compositing/overflow/ancestor-overflow-expected.checksum: Copied from LayoutTests/platform/mac/compositing/overflow/ancestor-overflow-expected.checksum.
platform/mac-leopard/compositing/overflow/ancestor-overflow-expected.png: Added.
platform/mac-leopard/compositing/overflow/scrollbar-painting-expected.checksum: Copied from LayoutTests/platform/mac/compositing/overflow/scrollbar-painting-expected.checksum.
platform/mac-leopard/compositing/overflow/scrollbar-painting-expected.png: Added.
platform/mac-leopard/compositing/transitions/singular-scale-transition-expected.checksum: Copied from LayoutTests/platform/mac/compositing/transitions/singular-scale-transition-expected.checksum.
platform/mac-leopard/compositing/transitions/singular-scale-transition-expected.png: Added.
platform/mac-leopard/editing/selection/select-text-overflow-ellipsis-expected.checksum: Copied from LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum.
platform/mac-leopard/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
platform/mac-leopard/editing/selection/transformed-selection-rects-expected.checksum: Copied from LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.checksum.
platform/mac-leopard/editing/selection/transformed-selection-rects-expected.png: Added.
platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum: Copied from LayoutTests/platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum.
platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png: Added.
platform/mac-leopard/fast/block/float/avoidance-percent-width-compat-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum.
platform/mac-leopard/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
platform/mac-leopard/fast/block/float/avoidance-percent-width-strict-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum.
platform/mac-leopard/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-backgrounds-and-text-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum.
platform/mac-leopard/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-expected.checksum.
platform/mac-leopard/fast/css/color-correction-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-on-background-image-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-on-background-image-expected.checksum.
platform/mac-leopard/fast/css/color-correction-on-background-image-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-on-backgrounds-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum.
platform/mac-leopard/fast/css/color-correction-on-backgrounds-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-on-box-shadow-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum.
platform/mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-on-text-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-on-text-expected.checksum.
platform/mac-leopard/fast/css/color-correction-on-text-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-on-text-shadow-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum.
platform/mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
platform/mac-leopard/fast/css/color-correction-untagged-images-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/color-correction-untagged-images-expected.checksum.
platform/mac-leopard/fast/css/color-correction-untagged-images-expected.png: Added.
platform/mac-leopard/fast/css/namespaces/namespaces-comments-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum.
platform/mac-leopard/fast/css/namespaces/namespaces-comments-expected.png: Added.
platform/mac-leopard/fast/css/namespaces/namespaces-empty-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum.
platform/mac-leopard/fast/css/namespaces/namespaces-empty-expected.png: Added.
platform/mac-leopard/fast/css/namespaces/namespaces-escapes-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum.
platform/mac-leopard/fast/css/namespaces/namespaces-escapes-expected.png: Added.
platform/mac-leopard/fast/css/namespaces/namespaces-invalid-at-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum.
platform/mac-leopard/fast/css/namespaces/namespaces-invalid-at-expected.png: Added.
platform/mac-leopard/fast/css/variables/misplaced-import-test-expected.checksum: Copied from LayoutTests/platform/mac/fast/css/variables/misplaced-import-test-expected.checksum.
platform/mac-leopard/fast/css/variables/misplaced-import-test-expected.png: Added.
platform/mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Copied from LayoutTests/platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum.
platform/mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
platform/mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Copied from LayoutTests/platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum.
platform/mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
platform/mac-leopard/fast/lists/anonymous-items-expected.checksum: Copied from LayoutTests/platform/mac/fast/lists/anonymous-items-expected.checksum.
platform/mac-leopard/fast/lists/anonymous-items-expected.png: Added.
platform/mac-leopard/fast/overflow/line-clamp-expected.checksum: Copied from LayoutTests/platform/mac/fast/overflow/line-clamp-expected.checksum.
platform/mac-leopard/fast/overflow/line-clamp-expected.png: Added.
platform/mac-leopard/fast/overflow/position-fixed-transform-clipping-expected.checksum: Copied from LayoutTests/platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum.
platform/mac-leopard/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
platform/mac-leopard/fast/reflections/abs-position-in-reflection-expected.checksum: Copied from LayoutTests/platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum.
platform/mac-leopard/fast/reflections/abs-position-in-reflection-expected.png: Added.
platform/mac-leopard/fast/reflections/opacity-reflection-transform-expected.checksum: Copied from LayoutTests/platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum.
platform/mac-leopard/fast/reflections/opacity-reflection-transform-expected.png: Added.
platform/mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum.
platform/mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
platform/mac-leopard/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum.
platform/mac-leopard/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
platform/mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum.
platform/mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
platform/mac-leopard/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum.
platform/mac-leopard/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
platform/mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum.
platform/mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
platform/mac-leopard/fast/table/fixed-table-with-small-percent-width-expected.checksum: Copied from LayoutTests/platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum.
platform/mac-leopard/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
platform/mac-leopard/fast/text/sticky-typesetting-features-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.checksum.
platform/mac-leopard/fast/text/sticky-typesetting-features-expected.png: Added.
platform/mac-leopard/http/tests/misc/slow-loading-mask-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/misc/slow-loading-mask-expected.checksum.
platform/mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
platform/mac-leopard/plugins/embed-attributes-style-expected.checksum: Copied from LayoutTests/platform/mac/plugins/embed-attributes-style-expected.checksum.
platform/mac-leopard/plugins/embed-attributes-style-expected.png: Added.
platform/mac-leopard/tables/mozilla/bugs/bug106158-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum.
platform/mac-leopard/tables/mozilla/bugs/bug106158-1-expected.png: Added.
platform/mac-leopard/tables/mozilla/bugs/bug106158-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum.
platform/mac-leopard/tables/mozilla/bugs/bug106158-2-expected.png: Added.
platform/mac-leopard/tables/mozilla/bugs/bug34176-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug34176-expected.checksum.
platform/mac-leopard/tables/mozilla/bugs/bug34176-expected.png: Added.
platform/mac-leopard/tables/mozilla/bugs/bug6674-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug6674-expected.checksum.
platform/mac-leopard/tables/mozilla/bugs/bug6674-expected.png: Added.
platform/mac-leopard/transforms/2d/transform-fixed-container-expected.checksum: Copied from LayoutTests/platform/mac/transforms/2d/transform-fixed-container-expected.checksum.
platform/mac-leopard/transforms/2d/transform-fixed-container-expected.png: Added.
platform/mac/compositing/masks/direct-image-mask-expected.checksum:
platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
platform/mac/compositing/overflow/scrollbar-painting-expected.checksum:
platform/mac/compositing/transitions/singular-scale-transition-expected.checksum:
platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum:
platform/mac/editing/selection/transformed-selection-rects-expected.checksum:
platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum:
platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum:
platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum:
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum:
platform/mac/fast/css/color-correction-expected.checksum:
platform/mac/fast/css/color-correction-on-background-image-expected.checksum:
platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum:
platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
platform/mac/fast/css/color-correction-on-text-expected.checksum:
platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum:
platform/mac/fast/css/color-correction-untagged-images-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum:
platform/mac/fast/css/variables/misplaced-import-test-expected.checksum:
platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum:
platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum:
platform/mac/fast/lists/anonymous-items-expected.checksum:
platform/mac/fast/overflow/line-clamp-expected.checksum:
platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum:
platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum:
platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum:
platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum:
platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum:
platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum:
platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum:
platform/mac/fast/text/sticky-typesetting-features-expected.checksum:
platform/mac/http/tests/misc/slow-loading-mask-expected.checksum:
platform/mac/plugins/embed-attributes-style-expected.checksum:
platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
platform/mac/tables/mozilla/bugs/bug6674-expected.checksum:
platform/mac/transforms/2d/transform-fixed-container-expected.checksum:
platform/mac/transitions/move-after-transition-expected.checksum:

12:32 PM Changeset in webkit [70475] by inferno@chromium.org

1 edit
2 copies in branches/chromium/517

Merge 70473

BUG=60327
Review URL: http://codereview.chromium.org/4065007

12:30 PM Changeset in webkit [70474] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-10-25 David Tapuska <dtapuska@rim.com>

Reviewed by David Kilzer.

Enable VFP if our compiler settings indicated we had a hardware
VFP.

https://bugs.webkit.org/show_bug.cgi?id=46096

assembler/MacroAssemblerARM.cpp: (JSC::isVFPPresent):

12:17 PM Changeset in webkit [70473] by inferno@chromium.org

3 edits
2 adds in trunk

2010-10-25 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Added check to ensure that events with the type "mousedown" are mouse events before dispatching.
https://bugs.webkit.org/show_bug.cgi?id=48159

Test: fast/events/keyboardevent-mousedown-crash.html

dom/Node.cpp: (WebCore::Node::defaultEventHandler):

2010-10-25 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Tests for a crash when an event with the type "mousedown" is not a MouseEvent.
https://bugs.webkit.org/show_bug.cgi?id=48159

fast/events/keyboardevent-mousedown-crash-expected.txt: Added.
fast/events/keyboardevent-mousedown-crash.html: Added.

12:14 PM Changeset in webkit [70472] by kseo@webkit.org

1 edit
1 add in trunk/WebCore

Unreviewed build fix for r70400.

Add dummy setCookieStoragePrivateBrowsingEnabled.

platform/brew/TemporaryLinkStubs.cpp: Added.

(WebCore::setCookieStoragePrivateBrowsingEnabled):

12:07 PM Changeset in webkit [70471] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2010-10-25 Dimitri Glazkov <Dimitri Glazkov>

Add a flaky test to expectations.
https://bugs.webkit.org/show_bug.cgi?id=48256

platform/chromium/test_expectations.txt: Moar flakes :(.

12:03 PM Changeset in webkit [70470] by commit-queue@webkit.org

16 edits in trunk

2010-10-25 Johnny Ding <jnd@chromium.org>

Reviewed by Tony Chang.

Dump the gesture status of frame in frame load callbacks in DumpRenderTree
by adding a new method dumpUserGestureInFrameLoadCallbacks.
Now only dump the gesture status in "DidStartProvisionalLoad" callback.
https://bugs.webkit.org/show_bug.cgi?id=47849

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpUserGestureInFrameLoader):
WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
WebCoreSupport/FrameLoaderClientQt.h:

2010-10-25 Johnny Ding <jnd@chromium.org>

Reviewed by Tony Chang.

Dump the gesture status of frame in frame load callbacks in DumpRenderTree
by adding a new method dumpUserGestureInFrameLoadCallbacks.
Now only dump the gesture status in "DidStartProvisionalLoad" callback.
https://bugs.webkit.org/show_bug.cgi?id=47849

DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpUserGestureInFrameLoadCallbacksCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpUserGestureInFrameLoadCallbacks): (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks):
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpUserGestureInFrameLoadCallbacks): (LayoutTestController::reset):
DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks): (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks):
DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpUserGestureInFrameLoadCallbacks):
DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didStartProvisionalLoad): (WebViewHost::printFrameUserGestureStatus):
DumpRenderTree/chromium/WebViewHost.h:
DumpRenderTree/mac/FrameLoadDelegate.mm: (-[WebFrame _drt_printFrameUserGestureStatus]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
DumpRenderTree/qt/LayoutTestControllerQt.h:

11:45 AM Changeset in webkit [70469] by Patrick Gansterer

2 edits in trunk/WebCore

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Use default implementation of AXObjectCache::platformGenerateAXID
https://bugs.webkit.org/show_bug.cgi?id=48239

WinCE does not support NotifyWinEvent, so use the default implementation.

accessibility/AXObjectCache.cpp:

11:44 AM Changeset in webkit [70468] by weinig@apple.com

2 edits in trunk/WebCore

Need WebKit2 API to figure out if a frame can provide source
<rdar://problem/8424632>
https://bugs.webkit.org/show_bug.cgi?id=48252

Reviewed by Anders Carlsson.

WebCore.exp.in:

11:41 AM Changeset in webkit [70467] by weinig@apple.com

2 edits in trunk/WebKit2

cancelledError for WebKit2 on windows should use kCFErrorDomainCFNetwork instead of webKitErrorDomain
https://bugs.webkit.org/show_bug.cgi?id=48254

Reviewed by Dan Bernstein.

WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::cancelledError): Use kCFErrorDomainCFNetwork instead of webKitErrorDomain and switch over
to using kCFURLErrorCancelled instead of a hard coded constant.

11:22 AM Changeset in webkit [70466] by weinig@apple.com

5 edits in trunk/WebKit2

Need WebKit2 API to figure out if a frame can provide source
<rdar://problem/8424632>
https://bugs.webkit.org/show_bug.cgi?id=48252

Reviewed by Anders Carlsson.

UIProcess/API/C/WKFrame.cpp:

(WKFrameCanProvideSource):

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canProvideSource):

UIProcess/WebFrameProxy.h:

Add API to figure out if a frame can provide source based on its
MIME type.

11:20 AM Changeset in webkit [70465] by mihaip@chromium.org

21 edits
1 copy
1 add in trunk/LayoutTests

2010-10-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed checksum rebaseline for animations/ and compositing/ for Snow
Leopard.

platform/mac-leopard/animations/3d/state-at-end-event-transform-expected.checksum: Copied from LayoutTests/platform/mac/animations/3d/state-at-end-event-transform-expected.checksum.
platform/mac-leopard/animations/3d/state-at-end-event-transform-expected.png: Added.
platform/mac/animations/3d/change-transform-in-end-event-expected.checksum:
platform/mac/animations/3d/state-at-end-event-transform-expected.checksum:
platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum:
platform/mac/compositing/compositing-visible-descendant-expected.checksum:
platform/mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
platform/mac/compositing/geometry/fixed-position-expected.checksum:
platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum:
platform/mac/compositing/geometry/partial-layout-update-expected.checksum:
platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum:
platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
platform/mac/compositing/reflections/reflection-in-composited-expected.checksum:
platform/mac/compositing/reflections/reflection-ordering-expected.checksum:
platform/mac/compositing/reflections/simple-composited-reflections-expected.checksum:
platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum:
platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
platform/mac/compositing/repaint/layer-repaint-expected.checksum:
platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
platform/mac/compositing/repaint/opacity-between-absolute-expected.checksum:
platform/mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
platform/mac/compositing/repaint/overflow-into-content-expected.checksum:

10:58 AM Changeset in webkit [70464] by andersca@apple.com

9 edits in trunk/WebKit2

Java applets don't display on the page
https://bugs.webkit.org/show_bug.cgi?id=48251
<rdar://problem/8483759>

Reviewed by Dan Bernstein.

Add WKPreferencesSetJavaEnabled and initialize it to true by default, matching old WebKit.

Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
Initialize javaEnabled.

(WebKit::WebPreferencesStore::encode):
Encode javaEnabled.

(WebKit::WebPreferencesStore::decode):
Decode javaEnabled.

Shared/WebPreferencesStore.h:

Add javaEnabled.

UIProcess/API/C/WKPreferences.cpp:

(WKPReferencesSetJavaEnabled):
(WKPReferencesGetJavaEnabled):
Call the WebPreferences functions.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Just call createPlugin.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Call Settings::setJavaEnabled.

10:44 AM Changeset in webkit [70463] by commit-queue@webkit.org

33 edits
3 deletes in trunk

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70451.
http://trac.webkit.org/changeset/70451
https://bugs.webkit.org/show_bug.cgi?id=48249

Broke set-unloaded-frame-location.html under Qt (Requested by
caseq on #webkit).

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/text/TextPosition.h: Removed.

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70451.
http://trac.webkit.org/changeset/70451
https://bugs.webkit.org/show_bug.cgi?id=48249

Broke set-unloaded-frame-location.html under Qt (Requested by
caseq on #webkit).

ForwardingHeaders/wtf/text/TextPosition.h: Removed.

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70451.
http://trac.webkit.org/changeset/70451
https://bugs.webkit.org/show_bug.cgi?id=48249

Broke set-unloaded-frame-location.html under Qt (Requested by
caseq on #webkit).

ForwardingHeaders/wtf/text/TextPosition.h: Removed.
bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
bindings/v8/ScriptController.h:
bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine):
bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
bindings/v8/V8Proxy.h:
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
bindings/v8/WorkerContextExecutionProxy.h:
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingLineNumber):
dom/ScriptableDocumentParser.h:
dom/XMLDocumentParser.h:
dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber):
dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::columnNumber):
html/parser/HTMLDocumentParser.h:
html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
html/parser/HTMLScriptRunner.h:
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
html/parser/HTMLTreeBuilder.h:

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70451.
http://trac.webkit.org/changeset/70451
https://bugs.webkit.org/show_bug.cgi?id=48249

Broke set-unloaded-frame-location.html under Qt (Requested by
caseq on #webkit).

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):

10:25 AM Changeset in webkit [70462] by mihaip@chromium.org

47 edits
46 copies
2 adds in trunk/LayoutTests

2010-10-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed rebaseline for fast/block for Snow Leopard.

platform/mac-leopard/fast/block/basic/001-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/001-expected.checksum.
platform/mac-leopard/fast/block/basic/001-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/001-expected.png.
platform/mac-leopard/fast/block/basic/002-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/002-expected.checksum.
platform/mac-leopard/fast/block/basic/002-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/002-expected.png.
platform/mac-leopard/fast/block/basic/003-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/003-expected.checksum.
platform/mac-leopard/fast/block/basic/003-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/003-expected.png.
platform/mac-leopard/fast/block/basic/004-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/004-expected.checksum.
platform/mac-leopard/fast/block/basic/004-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/004-expected.png.
platform/mac-leopard/fast/block/basic/005-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/005-expected.checksum.
platform/mac-leopard/fast/block/basic/005-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/005-expected.png.
platform/mac-leopard/fast/block/basic/006-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/006-expected.checksum.
platform/mac-leopard/fast/block/basic/006-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/006-expected.png.
platform/mac-leopard/fast/block/basic/007-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/007-expected.checksum.
platform/mac-leopard/fast/block/basic/007-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/007-expected.png.
platform/mac-leopard/fast/block/basic/008-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/008-expected.checksum.
platform/mac-leopard/fast/block/basic/008-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/008-expected.png.
platform/mac-leopard/fast/block/basic/009-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/009-expected.checksum.
platform/mac-leopard/fast/block/basic/009-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/009-expected.png.
platform/mac-leopard/fast/block/basic/011-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/011-expected.checksum.
platform/mac-leopard/fast/block/basic/011-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/011-expected.png.
platform/mac-leopard/fast/block/basic/012-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/012-expected.checksum.
platform/mac-leopard/fast/block/basic/012-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/012-expected.png.
platform/mac-leopard/fast/block/basic/013-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/013-expected.checksum.
platform/mac-leopard/fast/block/basic/013-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/013-expected.png.
platform/mac-leopard/fast/block/basic/014-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/014-expected.checksum.
platform/mac-leopard/fast/block/basic/014-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/014-expected.png.
platform/mac-leopard/fast/block/basic/015-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/015-expected.checksum.
platform/mac-leopard/fast/block/basic/015-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/015-expected.png.
platform/mac-leopard/fast/block/basic/018-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/018-expected.checksum.
platform/mac-leopard/fast/block/basic/018-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/018-expected.png.
platform/mac-leopard/fast/block/basic/019-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/019-expected.checksum.
platform/mac-leopard/fast/block/basic/019-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/019-expected.png.
platform/mac-leopard/fast/block/basic/020-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/020-expected.checksum.
platform/mac-leopard/fast/block/basic/020-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/020-expected.png.
platform/mac-leopard/fast/block/basic/021-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/021-expected.checksum.
platform/mac-leopard/fast/block/basic/021-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/021-expected.png.
platform/mac-leopard/fast/block/basic/adding-near-anonymous-block-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum.
platform/mac-leopard/fast/block/basic/adding-near-anonymous-block-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png.
platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.checksum.
platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png.
platform/mac-leopard/fast/block/basic/quirk-height-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/quirk-height-expected.checksum.
platform/mac-leopard/fast/block/basic/quirk-height-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/quirk-height-expected.png.
platform/mac-leopard/fast/block/basic/text-indent-rtl-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/text-indent-rtl-expected.checksum.
platform/mac-leopard/fast/block/basic/text-indent-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/text-indent-rtl-expected.png.
platform/mac-leopard/fast/block/basic/white-space-pre-wraps-expected.checksum: Copied from LayoutTests/platform/mac/fast/block/basic/white-space-pre-wraps-expected.checksum.
platform/mac-leopard/fast/block/basic/white-space-pre-wraps-expected.png: Copied from LayoutTests/platform/mac/fast/block/basic/white-space-pre-wraps-expected.png.
platform/mac/fast/block/basic/001-expected.checksum:
platform/mac/fast/block/basic/001-expected.png:
platform/mac/fast/block/basic/002-expected.checksum:
platform/mac/fast/block/basic/002-expected.png:
platform/mac/fast/block/basic/003-expected.checksum:
platform/mac/fast/block/basic/003-expected.png:
platform/mac/fast/block/basic/004-expected.checksum:
platform/mac/fast/block/basic/004-expected.png:
platform/mac/fast/block/basic/005-expected.checksum:
platform/mac/fast/block/basic/005-expected.png:
platform/mac/fast/block/basic/006-expected.checksum:
platform/mac/fast/block/basic/006-expected.png:
platform/mac/fast/block/basic/007-expected.checksum:
platform/mac/fast/block/basic/007-expected.png:
platform/mac/fast/block/basic/008-expected.checksum:
platform/mac/fast/block/basic/008-expected.png:
platform/mac/fast/block/basic/009-expected.checksum:
platform/mac/fast/block/basic/009-expected.png:
platform/mac/fast/block/basic/011-expected.checksum:
platform/mac/fast/block/basic/011-expected.png:
platform/mac/fast/block/basic/012-expected.checksum:
platform/mac/fast/block/basic/012-expected.png:
platform/mac/fast/block/basic/013-expected.checksum:
platform/mac/fast/block/basic/013-expected.png:
platform/mac/fast/block/basic/014-expected.checksum:
platform/mac/fast/block/basic/014-expected.png:
platform/mac/fast/block/basic/015-expected.checksum:
platform/mac/fast/block/basic/015-expected.png:
platform/mac/fast/block/basic/018-expected.checksum:
platform/mac/fast/block/basic/018-expected.png:
platform/mac/fast/block/basic/019-expected.checksum:
platform/mac/fast/block/basic/019-expected.png:
platform/mac/fast/block/basic/020-expected.checksum:
platform/mac/fast/block/basic/020-expected.png:
platform/mac/fast/block/basic/021-expected.checksum:
platform/mac/fast/block/basic/021-expected.png:
platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum:
platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png:
platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
platform/mac/fast/block/basic/quirk-height-expected.checksum:
platform/mac/fast/block/basic/quirk-height-expected.png:
platform/mac/fast/block/basic/text-indent-rtl-expected.checksum:
platform/mac/fast/block/basic/text-indent-rtl-expected.png:
platform/mac/fast/block/basic/white-space-pre-wraps-expected.checksum:
platform/mac/fast/block/basic/white-space-pre-wraps-expected.png:

10:13 AM Changeset in webkit [70461] by kseo@webkit.org

2 edits
1 add in trunk/WebCore

Unreviewed build fix for r70095.

Provide platformDefaultLanguage().

platform/brew/LanguageBrew.cpp: Added.

(WebCore::platformDefaultLanguage):

platform/brew/LocalizedStringsBrew.cpp:

10:03 AM Changeset in webkit [70460] by Patrick Gansterer

15 edits in trunk

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229

wtf/Platform.h:

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229

platform/win/FileSystemWin.cpp: (WebCore::openTemporaryFile):
platform/wince/FileSystemWinCE.cpp: (WebCore::openTemporaryFile):
plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPathsFromRegistry): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229

WebCoreSupport/WebContextMenuClient.cpp: (isPreInspectElementTagSafari):
WebView.cpp: (WebView::interpretKeyEvent):

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229

WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::interpretKeyEvent):

2010-10-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229

UIProcess/Launcher/win/ProcessLauncherWin.cpp: (WebKit::ProcessLauncher::launchProcess):
UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::safariPluginsDirectory): (WebKit::addMozillaPluginDirectories): (WebKit::addWindowsMediaPlayerPluginDirectory): (WebKit::addAdobeAcrobatPluginDirectory): (WebKit::addMacromediaPluginDirectories): (WebKit::addPluginPathsFromRegistry):
WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::interpretKeyEvent):

9:29 AM Changeset in webkit [70459] by Adam Roben

2 edits in trunk/WebKit2

Stop copying .messages.in files into WebKit2's framework bundle

Fixes <http://webkit.org/b/48232> Several .messages.in files end up in
WebKit2's framework bundle

Reviewed by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj:

9:12 AM Changeset in webkit [70458] by commit-queue@webkit.org

3 edits in trunk/WebKitTools

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70442.
http://trac.webkit.org/changeset/70442
https://bugs.webkit.org/show_bug.cgi?id=48248

http locking doesn't work on Windows (Requested by Ossy on
#webkit).

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

9:08 AM Changeset in webkit [70457] by abecsi@webkit.org

1 edit
1 add
1 delete in trunk/WebKit2

2010-10-25 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the WebKit2 build after sheriffbot messed up the rollout patch.
https://bugs.webkit.org/show_bug.cgi?id=48238

Shared/qt/MappedMemory.h: Renamed from WebKit2/Platform/qt/MappedMemoryPool.h. (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree): (WebKit::MappedMemory::data):

9:05 AM Changeset in webkit [70456] by hyatt@apple.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=48246

Reviewed by Sam Weinig.

Make selectionRect() on InlineTextBox give the right value for a vertical line. Selection is still too broken
to test anything though.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):

9:04 AM Changeset in webkit [70455] by benjamin.poulain@nokia.com

2 edits in trunk/WebCore

2010-10-25 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antonio Gomes.

Typo in the TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=48241

Fix the typo.

platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::TextureMapperGL):

9:01 AM Changeset in webkit [70454] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-10-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: slowly make old resources panel optional (continued).
https://bugs.webkit.org/show_bug.cgi?id=48207

inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set url):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.get toolbarItemLabel): (WebInspector.StoragePanel.prototype.showResource): (WebInspector.StoragePanel.prototype.searchMatchFound): (WebInspector.StoragePanel.prototype._findTreeElementForResource): (WebInspector.StoragePanel.prototype._findTreeElementForResource.getParent): (WebInspector.BaseStorageTreeElement.prototype.onattach):
inspector/front-end/inspector.css: (.storage.panel .sidebar): (.storage.panel .sidebar li): (.storage.panel .sidebar li.parent): (.storage.panel .sidebar li.selected): (.storage.panel .sidebar li .selection): (.storage.panel .sidebar :focus li .selection): (body.inactive .storage.panel .sidebar li .selection): (.storage.panel .sidebar .icon):

8:14 AM Changeset in webkit [70453] by commit-queue@webkit.org

6 edits
1 add
1 delete in trunk/WebKit2

2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70450.
http://trac.webkit.org/changeset/70450
https://bugs.webkit.org/show_bug.cgi?id=48238

Causes WTR to crash on tests which use SharedMemory.
(Requested by bbandix on #webkit).

Platform/SharedMemory.h:
Platform/qt/MappedMemoryPool.cpp: Removed.
Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
Shared/qt/MappedMemory.h: Renamed from WebKit2/Platform/qt/MappedMemoryPool.h. (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree): (WebKit::MappedMemory::data):
Shared/qt/MappedMemoryPool.cpp: Added. (WebKit::MappedMemoryPool::MappedMemoryPool): (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::size): (WebKit::MappedMemoryPool::at): (WebKit::MappedMemoryPool::append): (WebKit::MappedMemoryPool::cleanUp):
Shared/qt/UpdateChunk.cpp: (WebKit::mapMemory): (WebKit::mapFile): (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::decode):
Shared/qt/UpdateChunk.h:
WebKit2.pro:

7:53 AM Changeset in webkit [70452] by noam.rosenthal@nokia.com

1 edit
2 adds in trunk/WebCore

2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
This patch adds the OpenGL implementation of TextureMapper. See the other entries from bug 47070 for details.
https://bugs.webkit.org/show_bug.cgi?id=47070

No new tests. Part of a new implementation.

platform/graphics/opengl/TextureMapperGL.cpp: Added.
platform/graphics/opengl/TextureMapperGL.h: Added.

7:15 AM Changeset in webkit [70451] by caseq@chromium.org

32 edits
3 adds in trunk

2010-10-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Adds TextPosition* classes -- a structure that stores line/column/generation
level coordinates inside text document. Adds *BasedNumber classes -- typesafe int
wrappers that emphasize whether int number is used as zero-based or
one-based.

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/text/TextPosition.h: Added. (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition): (WTF::ZeroBasedNumber::fromZeroBasedInt): (WTF::ZeroBasedNumber::ZeroBasedNumber): (WTF::ZeroBasedNumber::zeroBasedInt): (WTF::ZeroBasedNumber::base): (WTF::ZeroBasedNumber::belowBase): (WTF::OneBasedNumber::fromOneBasedInt): (WTF::OneBasedNumber::OneBasedNumber): (WTF::OneBasedNumber::oneBasedInt): (WTF::OneBasedNumber::convertAsZeroBasedInt): (WTF::OneBasedNumber::convertToZeroBased): (WTF::OneBasedNumber::base): (WTF::OneBasedNumber::belowBase): (WTF::toZeroBasedTextPosition): (WTF::toOneBasedTextPosition): (WTF::ZeroBasedNumber::convertToOneBased):

2010-10-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces line number with TextPosition struct so that script engine
gets script starting line/column.

ForwardingHeaders/wtf/text/TextPosition.h: Added.
bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerPosition):
bindings/v8/ScriptController.h:
bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::startPosition):
bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
bindings/v8/V8Proxy.h:
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
bindings/v8/WorkerContextExecutionProxy.h:
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingPosition):
dom/ScriptableDocumentParser.h:
dom/XMLDocumentParser.h:
dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased):
dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::textPosition):
html/parser/HTMLDocumentParser.h:
html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
html/parser/HTMLScriptRunner.h:
html/parser/HTMLTreeBuilder.cpp: (WebCore::uninitializedPositionValue1): (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
html/parser/HTMLTreeBuilder.h:

2010-10-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces script line number with TextPosition structure.

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):

6:54 AM BuildingQtOnLinux edited by Ademar Reis

(diff)

6:48 AM Changeset in webkit [70450] by zoltan@webkit.org

6 edits
2 moves in trunk/WebKit2

[Qt] Implement SharedMemory for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=47345

Reviewed by Kenneth Rohde Christiansen.

Implement unimplemented functions in SharedMemoryQt.cpp.
Rename MappedMemory.h to MappedMemoryPool.h, move MappedMemoryPool.{h|cpp} from
Shared/qt to Platform/qt. Modify affected lines of WebKit2.pro.
Move MappedMemory implementation into MappedMemoryPool. Remove unnecessary
methods of MappedMemoryPool.

Platform/SharedMemory.h: Add a handle member for Qt.
Platform/qt/MappedMemoryPool.cpp: Copied from WebKit2/Shared/qt/MappedMemoryPool.cpp.

(WebKit::MappedMemoryPool::searchForMappedMemory):
(WebKit::MappedMemoryPool::mapMemory):
(WebKit::MappedMemoryPool::mapFile):

Platform/qt/MappedMemoryPool.h: Copied from WebKit2/Shared/qt/MappedMemory.h.

(WebKit::MappedMemoryPool::MappedMemory::mapSize):
(WebKit::MappedMemoryPool::MappedMemory::markUsed):
(WebKit::MappedMemoryPool::MappedMemory::markFree):
(WebKit::MappedMemoryPool::MappedMemory::isFree):
(WebKit::MappedMemoryPool::MappedMemory::data):
(WebKit::MappedMemoryPool::MappedMemoryPool):
Move MappedMemory implementation into MappedMemoryPool.

Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::Handle::Handle): Implement.
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull): Implement.
(WebKit::SharedMemory::Handle::encode): Implement.
(WebKit::SharedMemory::Handle::decode): Implement.
(WebKit::SharedMemory::create): Implement.
(WebKit::mapProtection): Added.
(WebKit::SharedMemory::~SharedMemory): Implement.
(WebKit::SharedMemory::createHandle): Implement.
(WebKit::SharedMemory::systemPageSize): Implement.

Shared/qt/MappedMemory.h: Removed.
Shared/qt/MappedMemoryPool.cpp: Removed.
Shared/qt/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::decode):
Modify to use MappedMemoryPool.

Shared/qt/UpdateChunk.h:
WebKit2.pro:

Modify affected lines.

6:34 AM Changeset in webkit [70449] by Adam Roben

2 edits in trunk/LayoutTests

Land new XP results for backslash-to-yen-sign-euc.html

These match the changes made in r69568 for other platforms.

platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:

5:31 AM Changeset in webkit [70448] by commit-queue@webkit.org

3 edits
2 adds
21 deletes in trunk/LayoutTests

2010-10-25 Benjamin Kalman <kalman@chromium.org>

Reviewed by Kent Tamura.

Make editing/deleting/5390681.html and
editing/deleting/delete-mixed-editable-content-001.html use Markup
instead of render tree.
https://bugs.webkit.org/show_bug.cgi?id=48112

editing/deleting/5390681-expected.txt: Added.
editing/deleting/5390681.html: Updated to use Markup instead of render tree.
editing/deleting/delete-mixed-editable-content-001-expected.txt: Added.
editing/deleting/delete-mixed-editable-content-001.html: Updated to use Markup instead of render tree.
platform/chromium-linux/editing/deleting/5390681-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/5390681-expected.png: Removed.
platform/chromium-linux/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Removed.
platform/chromium-linux/editing/deleting/delete-mixed-editable-content-001-expected.png: Removed.
platform/chromium-win/editing/deleting/5390681-expected.checksum: Removed.
platform/chromium-win/editing/deleting/5390681-expected.png: Removed.
platform/chromium-win/editing/deleting/5390681-expected.txt: Removed.
platform/chromium-win/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Removed.
platform/chromium-win/editing/deleting/delete-mixed-editable-content-001-expected.png: Removed.
platform/chromium-win/editing/deleting/delete-mixed-editable-content-001-expected.txt: Removed.
platform/gtk/editing/deleting/5390681-expected.txt: Removed.
platform/mac-leopard/editing/deleting/5390681-expected.checksum: Removed.
platform/mac-leopard/editing/deleting/5390681-expected.png: Removed.
platform/mac/editing/deleting/5390681-expected.checksum: Removed.
platform/mac/editing/deleting/5390681-expected.png: Removed.
platform/mac/editing/deleting/5390681-expected.txt: Removed.
platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Removed.
platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.png: Removed.
platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt: Removed.
platform/qt/editing/deleting/5390681-expected.txt: Removed.
platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt: Removed.

3:09 AM Changeset in webkit [70447] by ariya@webkit.org

3 edits in trunk/LayoutTests

2010-10-25 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Update the baseline for blur shadow test
https://bugs.webkit.org/show_bug.cgi?id=48223

After the blur radius fix in r68145, the baseline needs to be updated.

platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
platform/qt/fast/box-shadow/basic-shadows-expected.png:

2:50 AM Changeset in webkit [70446] by pfeldman@chromium.org

7 edits in trunk/WebCore

2010-10-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: slowly make old resources panel optional.
https://bugs.webkit.org/show_bug.cgi?id=48207

inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
inspector/front-end/ResourcesPanel.js:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone): (WebInspector.openResource): (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.removeResource): (WebInspector.displayNameForURL): (WebInspector._choosePanelToShowSourceLine): (WebInspector.doPerformSearch):

2:36 AM Changeset in webkit [70445] by pfeldman@chromium.org

8 edits in trunk/WebCore

2010-10-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add support for errors, warnings and search to the storage panel.
https://bugs.webkit.org/show_bug.cgi?id=48206

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set errors): (WebInspector.Resource.prototype.set warnings): (WebInspector.Resource.prototype.get searchMatches): (WebInspector.Resource.prototype.set searchMatches): (WebInspector.Resource.prototype.clearErrorsAndWarnings):
inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype._createResource): (WebInspector.ResourceManager.prototype._appendRedirect): (WebInspector.ResourceManager.prototype.didReceiveResponse): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): (WebInspector.ResourceManager.prototype.frameDetachedFromParent): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceManager.prototype.resourceForURL): (WebInspector.ResourceManager.prototype.addConsoleMessage): (WebInspector.ResourceManager.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.get toolbarItemLabel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.removeFrame): (WebInspector.StoragePanel.prototype.canShowSourceLine): (WebInspector.StoragePanel.prototype.showSourceLine): (WebInspector.StoragePanel.prototype.showResource): (WebInspector.StoragePanel.prototype._showResourceView): (WebInspector.StoragePanel.prototype.updateMainViewWidth): (WebInspector.StoragePanel.prototype.get searchableViews.callback): (WebInspector.StoragePanel.prototype.get searchableViews): (WebInspector.StoragePanel.prototype._forAllResourceTreeElements): (WebInspector.StoragePanel.prototype.searchMatchFound): (WebInspector.StoragePanel.prototype.searchCanceled.callback): (WebInspector.StoragePanel.prototype.searchCanceled): (WebInspector.StoragePanel.prototype.performSearch): (WebInspector.StoragePanel.prototype.showView): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.BaseStorageTreeElement.prototype.set titleText): (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.ondblclick): (WebInspector.FrameResourceTreeElement.prototype.onattach): (WebInspector.FrameResourceTreeElement.prototype._ondragstart): (WebInspector.FrameResourceTreeElement.prototype._setBubbleText): (WebInspector.FrameResourceTreeElement.prototype._resetBubble): (WebInspector.FrameResourceTreeElement.prototype._searchMatchesUpdated): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
inspector/front-end/inspector.css: (.storage.panel .sidebar): (.storage.panel .outline-disclosure li): (.storage.panel .outline-disclosure li.parent): (.storage.panel .outline-disclosure li .selection): (.storage.panel .outline-disclosure .icon): (.storage.panel .base-storage-tree-element-title): (.storage.panel .status): (.storage.panel li .status .bubble): (li .status): (li .status:empty): (li .status .bubble): (li .status .bubble:empty): (li.selected .status .bubble): (:focus li.selected .status .bubble): (body.inactive li.selected .status .bubble): (li.selected .bubble.search-matches): (:focus li.selected .bubble.search-matches): (body.inactive li.selected .bubble.search-matches):

2:11 AM Changeset in webkit [70444] by yuzo@google.com

2 edits in trunk/LayoutTests

2010-10-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

editing/spelling/spellcheck-attribute.html now passes for Mac.

platform/chromium/test_expectations.txt:

2:06 AM Changeset in webkit [70443] by yuzo@google.com

2 edits in trunk/LayoutTests

2010-10-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/frames/frame-src-attribute.html now passes for Mac.

platform/chromium/test_expectations.txt:

12:56 AM Changeset in webkit [70442] by Csaba Osztrogonác

3 edits in trunk/WebKitTools

Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-10-25
Reviewed by Ojan Vafai.

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

12:25 AM Changeset in webkit [70441] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

<http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
(Re-landing r70413 after Qt minimal buildfix: r70440.)

Patch by David Kilzer <ddkilzer@apple.com> on 2010-10-25
Reviewed by Kenneth Rohde Christiansen.

Scripts/build-webkit: Added support for --progress-tag switch.

It should have been added with r57051.

12:16 AM Changeset in webkit [70440] by Csaba Osztrogonác

2 edits in trunk/WebCore

Fix Qt minimal build break revealed by r70413.
https://bugs.webkit.org/show_bug.cgi?id=48185

Reviewed by David Kilzer.

rendering/RenderMeter.h: Missing include added, needless include removed.

Oct 24, 2010:

11:25 PM Changeset in webkit [70439] by kinuko@chromium.org

40 edits in branches/chromium/552

Merge 70438 - 2010-10-20 Kinuko Yasuda <kinuko@chromium.org>

BUG=60520

TBR=kinuko@chromium.org

10:53 PM Changeset in webkit [70438] by kinuko@chromium.org

40 edits in trunk

2010-10-20 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
https://bugs.webkit.org/show_bug.cgi?id=47936

public/WebFileError.h:
src/AssertMatchingEnums.cpp:
src/AsyncFileWriterChromium.cpp: (WebCore::AsyncFileWriterChromium::didFail):

2010-10-20 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
https://bugs.webkit.org/show_bug.cgi?id=47936

bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): Added FileExceptionType case.
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Added FileExceptionType case.
dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription): Added code for FileException.
dom/ExceptionCode.h:
fileapi/AsyncFileWriterClient.h:
fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): (WebCore::DirectoryEntry::getDirectory): (WebCore::DirectoryEntry::removeRecursively):
fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::getFile): (WebCore::DirectoryEntrySync::getDirectory): (WebCore::DirectoryEntrySync::removeRecursively):
fileapi/DirectoryReaderSync.cpp: (WebCore::DirectoryReaderSync::readEntries):
fileapi/Entry.cpp: (WebCore::Entry::getMetadata): (WebCore::Entry::moveTo): (WebCore::Entry::copyTo): (WebCore::Entry::remove): (WebCore::Entry::getParent):
fileapi/EntrySync.cpp: (WebCore::EntrySync::getMetadata): (WebCore::EntrySync::moveTo): (WebCore::EntrySync::copyTo): (WebCore::EntrySync::remove):
fileapi/FileError.h: Added error code enum. (WebCore::FileError::create): (WebCore::FileError::code): (WebCore::FileError::FileError):
fileapi/FileError.idl: Rebased error code numbers.
fileapi/FileException.h: Added exception code enum. (WebCore::FileException::ErrorCodeToExceptionCode): Added.
fileapi/FileException.idl: Rebased exception code numbers.
fileapi/FileReader.cpp: (WebCore::FileReader::abort): (WebCore::FileReader::failed): (WebCore::FileReader::httpStatusCodeToErrorCode): Changed from httpStatuCodeToExceptionCode.
fileapi/FileReader.h:
fileapi/FileReaderSync.cpp: (WebCore::FileReaderSyncLoader::start):
fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didFail):
fileapi/FileWriter.cpp: (WebCore::FileWriter::write): (WebCore::FileWriter::seek): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): (WebCore::FileWriter::didFail): (WebCore::FileWriter::setError):
fileapi/FileWriter.h:
fileapi/SyncCallbackHelper.h: (WebCore::SyncCallbackHelper::SyncCallbackHelper): (WebCore::SyncCallbackHelper::getResult): (WebCore::SyncCallbackHelper::setError):
page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): (WebCore::WorkerContext::requestFileSystemSync):

2010-10-20 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Renumber FileError/FileException error codes per latest File API spec changes
https://bugs.webkit.org/show_bug.cgi?id=47936

Updated test expectations to match with the new error code.

fast/files/read-blob-async-expected.txt:
fast/files/read-file-async-expected.txt:
fast/files/workers/worker-read-blob-async-expected.txt:
fast/files/workers/worker-read-blob-sync-expected.txt:
fast/files/workers/worker-read-file-async-expected.txt:
fast/files/workers/worker-read-file-sync-expected.txt:
fast/filesystem/op-copy-expected.txt:
fast/filesystem/op-get-entry-expected.txt:
fast/filesystem/op-move-expected.txt:
fast/filesystem/op-remove-expected.txt:
fast/filesystem/op-restricted-chars-expected.txt:
fast/filesystem/op-restricted-names-expected.txt:

10:29 PM Changeset in webkit [70437] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-10-24 Adam Barth <abarth@webkit.org>

Reviewed by David Kilzer.

webkit-patch upload fails when the patch removes a file
https://bugs.webkit.org/show_bug.cgi?id=48187

We need to use "--" to separate file names from the rest of the
command.

Scripts/webkitpy/common/checkout/scm.py:

10:28 PM Changeset in webkit [70436] by mitz@apple.com

2 edits in trunk/WebKit/win

Build fix.

Interfaces/WebKit.idl: Touched.

10:17 PM Changeset in webkit [70435] by mitz@apple.com

10 edits in trunk

Expose HitTestResult::absoluteMediaURL() via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=48219

Reviewed by Anders Carlsson.

WebCore:

WebCore.exp.in: Export HitTestResult::absoluteMediaURL().

WebKit/mac:

Misc/WebElementDictionary.mm:

(+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
_absoluteMediaURL.
(-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().

WebKit.exp: Export WebElementMediaURLKey.
WebView/WebView.mm: Define WebElementMediaURLKey.
WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.

WebKit/win:

Interfaces/IWebView.idl: Added WebElementMediaURLKey.
WebElementPropertyBag.cpp:

(WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().

9:39 PM Changeset in webkit [70434] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-10-24 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

Check endianness with BIG_ENDIAN in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=46122

RVCT defines BIG_ENDIAN if compiling for a big-endian target.

wtf/Platform.h:

8:45 PM Changeset in webkit [70433] by mitz@apple.com

1 edit
1 delete in trunk/JavaScriptCore

Removed empty directories.

Rubber-stamped by Dave Kilzer.

JavaScriptCore: Removed.
JavaScriptCore/runtime: Removed.

8:12 PM Changeset in webkit [70432] by morrita@google.com

2 edits in trunk/LayoutTests

2010-10-24 MORITA Hajime <morrita@google.com>

Unreviewed skip.

Added editing/spelling/spelling-linebreak.html to skip,
which was originally tested against a wrong expectation.

platform/gtk/Skipped:

7:29 PM Changeset in webkit [70431] by tkent@chromium.org

1 edit
7 deletes in trunk/LayoutTests

2010-10-24 Kent Tamura <tkent@chromium.org>

Reviewed by David Kilzer.

Remove unnecessary test results.
https://bugs.webkit.org/show_bug.cgi?id=47711

The following tests were converted to dumpAsText() in
http://trac.webkit.org/changeset/47608. So corresponding PNG files
are unnecessary.

editing/execCommand/italicizeByCharacter.html
editing/execCommand/modifyForeColorByCharacter.html
editing/execCommand/strikethroughSelection.html

The following tests were converted to dumpAsText() in
http://trac.webkit.org/changeset/47543.

editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline-across-paragraph-in-bold.html

The following tests were converted to dumpAsText() in
http://trac.webkit.org/changeset/47542.

editing/style/remove-underline-after-paragraph.html
editing/style/remove-underline-after-paragraph-in-bold.html

platform/mac/editing/execCommand/italicizeByCharacter-expected.png: Removed.
platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.png: Removed.
platform/mac/editing/execCommand/strikethroughSelection-expected.png: Removed.
platform/mac/editing/style/remove-underline-across-paragraph-expected.png: Removed.
platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.png: Removed.
platform/mac/editing/style/remove-underline-after-paragraph-expected.png: Removed.
platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.png: Removed.

7:18 PM Changeset in webkit [70430] by yuzo@google.com

2 edits in trunk/WebKit/chromium

2010-10-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70361.
http://trac.webkit.org/changeset/70361
https://bugs.webkit.org/show_bug.cgi?id=48217

Chromium tests NoInitialAutocompleteForReadOnly and
InitialAutocomplete don't complete (Requested by yuzo on
#webkit).

public/WebDocument.h:

6:21 PM Changeset in webkit [70429] by morrita@google.com

2 edits
1 add
4 deletes in trunk/LayoutTests

2010-10-22 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

Text test conversion: editing/spelling/spelling-linebreak.html
https://bugs.webkit.org/show_bug.cgi?id=47649

Rewrote verification part using hasSpellingMarker().

editing/spelling/spelling-linebreak-expected.txt: Added.
editing/spelling/spelling-linebreak.html:
platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Removed.
platform/mac/editing/spelling/spelling-linebreak-expected.checksum: Removed.
platform/mac/editing/spelling/spelling-linebreak-expected.png: Removed.
platform/mac/editing/spelling/spelling-linebreak-expected.txt: Removed.

6:10 PM Changeset in webkit [70428] by weinig@apple.com

10 edits in trunk

Need a way to determine the screen rect for a form control in WebKit2
<rdar://problem/8530670>
https://bugs.webkit.org/show_bug.cgi?id=48216

Reviewed by Dan Bernstein.

WebCore:

WebCore.exp.in: Add export.
dom/Element.cpp:

(WebCore::Element::boundsInWindowSpace):

dom/Element.h:

Add function to return the bounding box in window (in ScrollView terminology) space,
this is the same space as the root viewport.

WebKit2:

Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
Add conversion from IntRect to WKRect.

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetElementBounds):

WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

Add SPI to get the rect in window space. The client can then convert this to screen
space if they wish to.

5:38 PM Changeset in webkit [70427] by Patrick Gansterer

2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Unreviewed, fix typo of last build fix.

wtf/DateMath.cpp:

5:29 PM Changeset in webkit [70426] by Patrick Gansterer

2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for chromium.

wtf/DateMath.cpp: Added missing include.

4:20 PM Changeset in webkit [70425] by Patrick Gansterer

8 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add WTF_ARRAY_LENGTH macro to WTF
https://bugs.webkit.org/show_bug.cgi?id=32828

Unify the different implementations and usages.

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString): (JSC::Stringifier::toJSON): (JSC::Stringifier::appendStringifiedValue):
runtime/UString.cpp: (JSC::UString::number):
wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters):
wtf/StdLibExtras.h:

2:08 PM Changeset in webkit [70424] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-10-24 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] ImageBuffer::platformTransformColorSpace is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=48211

Grab the QImage::bits() and do direct access instead of going through
QImage::pixel() and QImage::setPixel().

This is a performance optimization, so no new tests.

platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):

12:49 PM Changeset in webkit [70423] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-10-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70413.
http://trac.webkit.org/changeset/70413
https://bugs.webkit.org/show_bug.cgi?id=48210

It broke Qt minimal build (Requested by Ossy on #webkit).

Scripts/build-webkit:

12:31 PM Changeset in webkit [70422] by mitz@apple.com

3 edits in trunk/WebKit/mac

Removed deprecated methods from the WebHTMLHighlighter private protocol.

Reviewed by Simon Fraser.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
unconditionally.
(WebChromeClient::paintCustomHighlight): Call
-paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.

WebView/WebHTMLViewPrivate.h:

12:24 PM Changeset in webkit [70421] by krit@webkit.org

12 edits in trunk

2010-10-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Filter example Chiseled from SVG Wow! is slow
https://bugs.webkit.org/show_bug.cgi?id=48174

Added 'using WTF::ByteArray;' at the end of ByteArray.h

wtf/ByteArray.h:

2010-10-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Filter example Chiseled from SVG Wow! is slow
https://bugs.webkit.org/show_bug.cgi?id=48174

Use a pointer to the ByteArray instead of the ref counted CanvasPixelArray or ImageData directly
to access the data for pixel manipulation on SVG Filters or SVG Masker. This is a
performance increase since the recurring use of the -> operator can be avoided.
FEConvolveMatrix and FELighting still need to change in a followup patch.

No functionality was changed. So, no new tests.

platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
platform/graphics/filters/FEColorMatrix.cpp: (WebCore::luminance): (WebCore::effectType): (WebCore::FEColorMatrix::apply):
platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic): (WebCore::FEComposite::apply):
platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):
platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

11:58 AM Changeset in webkit [70420] by pfeldman@chromium.org

5 edits in trunk/WebCore

2010-10-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: polish network panel UI.
https://bugs.webkit.org/show_bug.cgi?id=48205

inspector/front-end/Images/frame.png:
inspector/front-end/Images/networkIcon.png:
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._toggleGridMode):
inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid.small td): (#network-views .resource-view.headers-visible .resource-view-content): (#network-views.small .resource-view.headers-visible .resource-view-content): (#network-views .resource-view-headers): (#network-views.small .resource-view-headers): (#network-views .resource-view .tabbed-pane-header): (#network-views.small .resource-view .tabbed-pane-header):

11:53 AM Changeset in webkit [70419] by Patrick Gansterer

2 edits in trunk/JavaScriptCore

2010-10-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Inline WTF::bitwise_cast and fix style
https://bugs.webkit.org/show_bug.cgi?id=48208

wtf/StdLibExtras.h: (WTF::bitwise_cast): (WTF::bitCount):

10:15 AM Changeset in webkit [70418] by commit-queue@webkit.org

2 edits in trunk

2010-10-24 Anders Bakken <agbakken@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Disable enable_fast_mobile_scrolling for QWS
https://bugs.webkit.org/show_bug.cgi?id=48006

Turning this on breaks the acidtests for QWS/DirectFB and QWS/QVFB

WebKit.pri:

9:59 AM Changeset in webkit [70417] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-10-24 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
https://bugs.webkit.org/show_bug.cgi?id=48141

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView): (LauncherWindow::toggleWebView):

9:58 AM Changeset in webkit [70416] by dbates@webkit.org

2 edits
1 add
11 deletes in trunk/LayoutTests

2010-10-24 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Convert layout test fast/frame/frame-src-attribute.html from
render-tree/pixel test to text-only test
https://bugs.webkit.org/show_bug.cgi?id=48200

Modified the test case LayoutTests/fast/frame/frame-src-attribute.html
to dump its output as text.

Currently, the test produces a render-tree dump. Instead, it is sufficient
for this test to dump as text since it is a PASS/FAIL-style test. This will
also make the test results platform-independent.

fast/frames/frame-src-attribute-expected.txt: Added.
fast/frames/frame-src-attribute.html: Modified to dump its output as text.
platform/chromium-linux/fast/frames/frame-src-attribute-expected.checksum: Removed.
platform/chromium-linux/fast/frames/frame-src-attribute-expected.png: Removed.
platform/chromium-mac/fast/frames/frame-src-attribute-expected.checksum: Removed.
platform/chromium-mac/fast/frames/frame-src-attribute-expected.png: Removed.
platform/chromium-win/fast/frames/frame-src-attribute-expected.checksum: Removed.
platform/chromium-win/fast/frames/frame-src-attribute-expected.png: Removed.
platform/chromium-win/fast/frames/frame-src-attribute-expected.txt: Removed.
platform/gtk/fast/frames/frame-src-attribute-expected.txt: Removed.
platform/mac/fast/frames/frame-src-attribute-expected.checksum: Removed.
platform/mac/fast/frames/frame-src-attribute-expected.png: Removed.
platform/mac/fast/frames/frame-src-attribute-expected.txt: Removed.
platform/qt/fast/frames/frame-src-attribute-expected.txt: Removed.

9:54 AM Changeset in webkit [70415] by dbates@webkit.org

2 edits
1 add in trunk/WebKitTools

2010-10-24 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

Fix Perl uninitialized warnings in VCSUtils::svnStatus()
and VCSUtils::removeEOL().
https://bugs.webkit.org/show_bug.cgi?id=48196

VCSUtils::svnStatus() concatenates the output of svn status with
a new line character and svn status may return no output (say for
a file that has not been added, deleted, or modified). We should
only concatenate the output of svn status if there is some.

Also, VCSUtils::removeEOL() should ensure that its argument
is initialized before performing a string substitution.

Scripts/VCSUtils.pm:
- Modified removeEOL() to return "" if its argument is undefined.
- Exported removeEOL() so that it can be tested.
Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.

9:12 AM Changeset in webkit [70414] by Nikolas Zimmermann

7 edits in trunk

2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
https://bugs.webkit.org/show_bug.cgi?id=48179

Fix WebGL tests. Accept 'boolean' as valid numeric type in StrictTypeChecking mode.

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:

2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
https://bugs.webkit.org/show_bug.cgi?id=48179

It turns out the CodeGenerator changes are right, and the webgl tests have a problem, since StrictTypeChecking was enabled for numeric types.
When calling gl.bindAttribLocation() be sure to pass the second argument as integer, not as string.
Fixes all failing webgl tests on the snow leopard bot.

fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils):
fast/canvas/webgl/resources/webgl-test.js: (createProgram):

6:59 AM Changeset in webkit [70413] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch

Reviewed by Kenneth Rohde Christiansen.

Scripts/build-webkit: Added support for --progress-tag switch.

It should have been added with r57051.

6:49 AM Changeset in webkit [70412] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability

Reviewed by Daniel Bates.

Scripts/build-webkit: Alphabetized the @features array based

on the name of the feature. Reformatted the list of support
variables so that they match the order of @features, and so that
each has its own line. This makes it easy to add new variables
in the correct order.

4:58 AM Changeset in webkit [70411] by Nikolas Zimmermann

3 edits in trunk/WebCore

2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
https://bugs.webkit.org/show_bug.cgi?id=48179

Speculative fix for the WebGL tests, I was not aware they're not run on Leopard, so I missed the breakage.

bindings/scripts/CodeGeneratorJS.pm: Restore the order of type checking in the 'StrictTypeChecking' code.
bindings/scripts/CodeGeneratorV8.pm: Ditto.

3:38 AM Changeset in webkit [70410] by Nikolas Zimmermann

25 edits
4 adds in trunk

2010-10-23 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
https://bugs.webkit.org/show_bug.cgi?id=48179

Rewrite SVGAngle to use the new SVGPropertyTearOff concept, and consume much less memory.
Down from two floats, one string and an ushort to one float and one ushort. Synchronize value/valueInSpecifiedUnits/valueAsString on demand.

Adding an extensive SVGAngle test, that required to implement 'StrictTypeChecking' for attribute setters (was only implemented in V8/JSC for function cals so far).

Test: svg/dom/SVGAngle.html

GNUmakefile.am: Add SVGAnimatedAngle.h to build.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/scripts/CodeGenerator.pm: Split IsPrimitiveType in IsPrimitiveType and IsNumericType.
bindings/scripts/CodeGeneratorJS.pm: Implement 'StrictTypeChecking' for setters and recognize SVGAngle as new SVGPropertyTearOff type.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.
bindings/scripts/CodeGeneratorV8.pm: Ditto.
svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAngle handling.
svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedAngle handling.
svg/SVGAngle.cpp: Rewrite, to consume less memory and to operate more efficient.
svg/SVGAngle.h: Ditto.
svg/SVGAngle.idl: Add 'StrictTypeChecking' to the value/valueInSpecifiedUnits methods.
svg/SVGAnimatedAngle.h: Added.
svg/SVGAnimatedAngle.idl: Mark as [SVGAnimatedProperty].
svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): SVGAngle::setValueAsString() now takes an ExceptionCode parameter.
svg/SVGMarkerElement.h: s/ANIMATED_PROPERTY/ANIMATED_PROPERTY_NEW/ for the SVGAngle type.
svg/SVGNumber.idl: Remove exception setter exceptions, which aren't needed. As we're now generating exception handlers in the bindings, it would lead to compile errors.
svg/SVGPoint.idl: Ditto.
svg/SVGRect.idl: Ditto.
svg/SVGSVGElement.idl: Remove obsolete [SVGLiveProperty] flag.

2010-10-23 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
https://bugs.webkit.org/show_bug.cgi?id=48179

Add an extensive SVGAngle test, checking all getter/setters & methods, with valid and invalid arguments.
The test exposes bugs in Opera & FireFox, we now pass them all.

svg/dom/SVGAngle-expected.txt: Added.
svg/dom/SVGAngle.html: Added.
svg/dom/script-tests/SVGAngle.js: Added.
svg/dom/svg-element-attribute-js-null-expected.txt:
svg/dom/svg-element-attribute-js-null.xhtml: Update incorrect test, setting valueAsString to null, should not result in "0deg" but "0".

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed