⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 27, 2010:

11:15 PM Changeset in webkit [70748] by aestes@apple.com
  • 5 edits
    2 adds in trunk

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.

Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html

  • html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

  • fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
  • fast/dom/object-plugin-hides-properties.html: Ditto.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
10:12 PM Changeset in webkit [70747] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
​https://bugs.webkit.org/show_bug.cgi?id=48500

This doesn't fix the problem, but it makes things slightly better.
Each git svn find-rev call takes about .25 seconds on my desktop.
This patch uses a new memoized class to avoid those calls when possible.

The real slowness is still git log on some files, like:
git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
I'm not yet sure how to make the pathological git logs better.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/memoized.py: Added.
  • Scripts/webkitpy/common/memoized_unittest.py: Added.
9:00 PM Changeset in webkit [70746] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
8:57 PM Changeset in webkit [70745] by commit-queue@webkit.org
  • 12 edits
    1 copy in trunk

2010-10-27 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[Chromium] Metadata queries should return full file info, not just modification time
​https://bugs.webkit.org/show_bug.cgi?id=48098

LayoutTests that use this functionality via WorkerAsyncFileWriter are in review.

Build file changes to add FileMetadata.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

The rest of the changes here just pass the new FileMetadata object through calls that used to take a modification time.

  • platform/FileMetadata.h: Added. (WebCore::FileMetadata::FileMetadata):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didReadMetadata): (WebCore::MetadataCallbacks::didReadMetadata):
  • fileapi/FileSystemCallbacks.h:
  • platform/AsyncFileSystemCallbacks.h:

2010-10-27 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[Chromium] Metadata queries should return full file info, not just modification time
​https://bugs.webkit.org/show_bug.cgi?id=48098

  • src/AssertMatchingEnums.cpp: Ensure WebFileInfo and FileMetadata use the same values for file/directory indicators.
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadMetadata): Pass through the new information.
8:48 PM Changeset in webkit [70744] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, update drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
8:38 PM Changeset in webkit [70743] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add VectorMath files
​https://bugs.webkit.org/show_bug.cgi?id=48467

No new tests since audio API is not yet implemented.

  • platform/audio/VectorMath.cpp: Added. (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd):
  • platform/audio/VectorMath.h: Added.
8:21 PM Changeset in webkit [70742] by crogers@google.com
  • 15 edits in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fixup files affected by VectorMath and related API changes
​https://bugs.webkit.org/show_bug.cgi?id=48481

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp:
  • platform/audio/AudioChannel.cpp:
  • platform/audio/Biquad.cpp:
  • platform/audio/FFTConvolver.cpp:
  • platform/audio/FFTConvolver.h:
  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Reverb.cpp: (WebCore::calculateNormalizationScale): (WebCore::Reverb::initialize): (WebCore::Reverb::process):
  • platform/audio/ReverbAccumulationBuffer.cpp:
  • platform/audio/ReverbAccumulationBuffer.h:
  • platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver): (WebCore::ReverbConvolver::process):
  • platform/audio/ReverbConvolver.h:
  • platform/audio/ReverbConvolverStage.cpp: (WebCore::ReverbConvolverStage::ReverbConvolverStage):
  • platform/audio/ReverbConvolverStage.h:
  • platform/audio/ReverbInputBuffer.h:
8:18 PM Changeset in webkit [70741] by kinuko@chromium.org
  • 24 edits
    3 adds in trunk

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

DOMFileSystem's reference should be kept while there're any active Entries/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=47535

Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.

Test: fast/filesystem/filesystem-reference.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::readDirectory): Changed to pass/take PassRefPtr but not a raw pointer.
  • fileapi/DOMFileSystemBase.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::DirectoryEntry): Ditto. (WebCore::DirectoryEntry::createReader):
  • fileapi/DirectoryEntry.h: (WebCore::DirectoryEntry::create): Ditto.
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::DirectoryEntrySync): Ditto.
  • fileapi/DirectoryEntrySync.h: (WebCore::DirectoryEntrySync::create): Ditto.
  • fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem):
  • fileapi/DirectoryReaderBase.h: (WebCore::DirectoryReaderBase::filesystem):
  • fileapi/Entry.cpp: (WebCore::Entry::Entry): Ditto.
  • fileapi/Entry.h: (WebCore::Entry::filesystem):
  • fileapi/EntryBase.h: (WebCore::EntryBase::filesystem): (WebCore::EntryBase::EntryBase): Ditto.
  • fileapi/EntrySync.cpp: (WebCore::EntrySync::create): Ditto. (WebCore::EntrySync::getParent): (WebCore::EntrySync::EntrySync): Ditto.
  • fileapi/EntrySync.h: (WebCore::EntrySync::filesystem):
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::FileEntry): Ditto.
  • fileapi/FileEntry.h: (WebCore::FileEntry::create): Ditto.
  • fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::FileEntrySync): Ditto.
  • fileapi/FileEntrySync.h: (WebCore::FileEntrySync::create): Ditto.
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): Ditto. (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto.
  • fileapi/FileSystemCallbacks.h:

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

DOMFileSystem's reference should be kept while there're any active Entries/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=47535

  • fast/filesystem/filesystem-reference-expected.txt: Added.
  • fast/filesystem/filesystem-reference.html: Added.
  • fast/filesystem/script-tests/filesystem-reference.js: Added.
8:11 PM Changeset in webkit [70740] by yuzo@google.com
  • 4 edits
    2 adds in trunk

2010-10-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=48310

  • svg/custom/font-face-name-without-name-attr-expected.txt: Added.
  • svg/custom/font-face-name-without-name-attr.svg: Added.

2010-10-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=48310

Test: svg/custom/font-face-name-without-name-attr.svg

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't create src property if the src value list is empty.
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue): Don't add empty src values to the src value list.
8:02 PM Changeset in webkit [70739] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Allow AudioDSPKernel to function without an AudioDSPKernelProcessor
​https://bugs.webkit.org/show_bug.cgi?id=48472

No new tests since audio API is not yet implemented.

  • platform/audio/AudioDSPKernel.h: (WebCore::AudioDSPKernel::AudioDSPKernel): (WebCore::AudioDSPKernel::sampleRate):
7:37 PM Changeset in webkit [70738] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/API/mac/PageClientImpl.mm: Reference the file using the correct case.
6:44 PM Changeset in webkit [70737] by andersca@apple.com
  • 7 edits in trunk

Find indicators do not bounce
​https://bugs.webkit.org/show_bug.cgi?id=48490
<rdar://problem/8564276>

Reviewed by Sam Weinig.

WebKit2:

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationDuration:animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
Add an animationDuration parameter.

(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize m_bounceAnimationContext.

(WebKit::FindIndicatorWindow::setFindIndicator):
Create a bounce animation and start it.

(WebKit::FindIndicatorWindow::closeWindow):
Stop the bounce animation and destroy the bounce animation context.

(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
pass the fade out duration.

(WebKit::FindIndicatorWindow::bounceAnimationCallback):
Set the bounce animation progress.

(WebKit::FindIndicatorWindow::bounceAnimationDidEnd):
Destroy the bounce animation context.

WebKitLibraries:

Add bounce animation context functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
6:30 PM Changeset in webkit [70736] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-27 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

Support emit_op_mod() for MIPS on JSVALUE32_64
​https://bugs.webkit.org/show_bug.cgi?id=46511

This patch uses MIPS div instructions for op_mod to improve performance.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_mod):
6:07 PM Changeset in webkit [70735] by senorblanco@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-10-27 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] Unskip the failing tests in chromium-gpu, and adjust the
expectations to match reality.
​https://bugs.webkit.org/show_bug.cgi?id=48473


Some bugs were already fixed and the test lines could be removed, some
tests have started newly-failing. Rebaselined one test that had a bad
checksum.

  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
5:55 PM Changeset in webkit [70734] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Remove the reference to the pageNamespace in the QWKPagePrivate.
Access it though the WebPageProxy instead which holds a strong
ref to it.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::preferences):
  • UIProcess/API/qt/qwkpage_p.h:
5:48 PM Changeset in webkit [70733] by andersca@apple.com
  • 8 edits in trunk/WebKit2

More work on downloads
​https://bugs.webkit.org/show_bug.cgi?id=48480

Reviewed by Sam Weinig.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::~Download):
Call platformInvalidate().

(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
Add empty stubs.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
Create a Download object and insert it into the m_downloads map.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::platformInvalidate):
Add empty stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::platformInvalidate):
Tell the WKDownloadAsDelegate object that we're being invalidated.

(-[WKDownloadAsDelegate downloadDidBegin:]):
Call Download::didBegin.

(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
Call Download::didReceiveData.

(-[WKDownloadAsDelegate downloadDidFinish:]):
Call Download::didFinish.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::platformInvalidate):
Add empty stub.

5:42 PM Changeset in webkit [70732] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-10-27 Pratik Solanki <​psolanki@apple.com>

Reviewed by Darin Adler.

Improve memSize calculation in [WebView _setCacheModel]
​https://bugs.webkit.org/show_bug.cgi?id=48484

  • WebView/WebView.mm: (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2. (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next bigger power of 2. Also update WebCore cache settings.
5:05 PM Changeset in webkit [70731] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

EWS bots should not use --quiet when running build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48482

--quiet is only correct when the sub-process does the error reporting.
In the case of _can_build() the parent process is reporting the error.
We'd like the full build log at queues.webkit.org so someone can look
at the log and understand why the EWS is failing to build trunk.

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
5:04 PM Changeset in webkit [70730] by enrica@apple.com
  • 18 edits in trunk

WebCore: Support Appkit key bindings and custom key bindings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>

Reviewed by Alexey Proskuryakov.

  • dom/KeyboardEvent.h:

(WebCore::KeypressCommand::KeypressCommand): Added default constructor and modified assert for text
insertion command constructor to support WebKit2 scenarios.
The default constructor is needed to support the generated WebKit2 message processing code.

WebKit2: Support Appkit key bindings and custom key bindings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>

Reviewed by Alexey Proskuryakov.

We need to support AppKit key bindings and custom key bindings in WebKit2.
Every keyboard event is first sent to the WebProcess and we inform AppKit that
we don't need further processing. When the event is processed by the WebProcess and no handler consumes it,
we send a synchronous message back to the UI process to let AppKit perform the key bindings.
This operation can result in one or more editing commands to execute or a noop.
The WebProcess then replies back to the UI process to inform whether further processing is required, in
which case the event is sent back to the application to be mapped.
There is a potential for a race condition: in case the WebProcess is very slow to process the key events, the UI
process could be in a completely different state when the event is being resent (for example it might not have the
keyboard focus anymore) and the command could be lost. We should look out for user experience impact.

  • Scripts/webkit2/messages.py: Added header file in the generated file.
  • Shared/WebCoreArgumentCoders.h: Added encoder/decoder for KeypressCommand.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::interceptKeyEvent): Pass-through call to WKView.
(WebKit::PageClientImpl::didNotHandleKeyEvent): Added logic to resend the event to the application.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Changed the default return value to YES, otherwise no menu shortcut is performed.
(-[WKView doCommandBySelector:]): Added.
(-[WKView insertText:]): Added.
(-[WKView _handleStyleKeyEquivalent:]): Added to handle command-B and command-I.
(-[WKView performKeyEquivalent:]): Added to intercept key binding sequences.
(-[WKView _setEventBeingResent:]):
(-[WKView _interceptKeyEvent:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::interpretKeyEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm: Moved handleKeyboardEvent and handleInputMethodKeydown

to the Mac specific implementation.
(WebKit::WebPage::interceptEditingKeyboardEvent): Added.

4:56 PM Changeset in webkit [70729] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 70652 - 2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.

BUG=60688
TBR=​jschuh@chromium.org

4:53 PM Changeset in webkit [70728] by bweinstein@apple.com
  • 4 edits in trunk

WebKit2: More Windows build fixage. Copy another new header into WebKitOutputDir.

  • win/WebKit2Generated.make:

WebKitTools: More Windows build fixage. Rename a variable that was named string.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasPrefix):

4:52 PM Changeset in webkit [70727] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 70652 - 2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.

BUG=60688
TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/4133004

4:40 PM Changeset in webkit [70726] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed build correction.

  • wtf/Platform.h: Make sure ACCELERATED_COMPOSITING is

turned off in the WinCairo port. This isn't supported (yet.)

4:39 PM Changeset in webkit [70725] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Copy a new header into WebKitOutputDir.

  • win/WebKit2Generated.make:
4:33 PM Changeset in webkit [70724] by ojan@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Make the test results server store which master the bot is on
​https://bugs.webkit.org/show_bug.cgi?id=48478

The chromium bots recently changed so that there are multiple slaves with
the same name on different masters. Up till now, the test results server
assumed slave names were unique. Adds a master field to the file in order
to distinguish.

Also, for files that currently lack a master or testtype, set them appropriately.

  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/index.yaml:
  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/testfile.py:
  • TestResultServer/templates/showfilelist.html:
  • TestResultServer/templates/uploadform.html:
4:18 PM Changeset in webkit [70723] by Darin Adler
  • 61 edits
    8 copies in trunk

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • History/WebBackForwardList.mm: (core): Return BackForwardListImpl. (kit): Take BackForwardListImpl. (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl. (-[WebBackForwardList dealloc]): Ditto. (-[WebBackForwardList finalize]): Ditto. (-[WebBackForwardList description]): Ditto. (-[WebBackForwardList setPageCacheSize:]): Ditto. (-[WebBackForwardList pageCacheSize]): Ditto.
  • History/WebBackForwardListInternal.h: Ditto.
  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Ditto.
  • WebView/WebView.mm: (-[WebView initWithCoder:]): Ditto. (-[WebView encodeWithCoder:]): Ditto. (-[WebView backForwardList]): Ditto. (-[WebView setMaintainsBackForwardList:]): Ditto.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • WebCore.exp.in: Updated exports.
  • history/BackForwardList.h: Added comments about future refactoring. Moved functions that are not called inside WebCore into a separate section, to be removed later. Added an isActive function to replace the use of enabled() and entries().
  • history/BackForwardListImpl.h: Removed isBackForwardListImpl. Marked virtual function overrides virtual explicitly, except for the ones that will be non-virtual once we make the changes above. Added the isActive function.
  • history/PageCache.cpp: (WebCore::logCanCachePageDecision): Use isActive. (WebCore::PageCache::canCache): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check using currentItem, backItem, and forwardItem instead of using entries.
  • page/Settings.cpp: (WebCore::Settings::setUsesPageCache): Loop through the back/forward list entries using backListCount and forwardListCount instead of using entries.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • platform/mac-wk2/Skipped: Resorted some test lists. Removed the section listing all the tests that were blocked by dumpBackForwardList.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Renamed the product to WebKitTestRunnerInjectedBundle to avoid name conflicts in the build directory.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpBackForwardList and clearBackForwardList.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage. (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages instead of m_mainPage and m_otherPages. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::page): Ditto. (WTR::InjectedBundle::beginTesting): Ditto. (WTR::InjectedBundle::done): Ditto. (WTR::InjectedBundle::closeOtherPages): Ditto. (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed page function to longer be inline, and pageCount function to use m_pages. Added dumpBackForwardListsForAllPages, and removed some underscores. Replaced m_mainPage and m_otherPageas with m_pages.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::adoptWK): Added. (WTR::hasPrefix): Added. (WTR::InjectedBundlePage::reset): Added code to set up m_previousTestBackForwardListItem. (WTR::InjectedBundlePage::dump): Added code to call dumpBackForwardListsForAllPages. (WTR::compareByTargetName): Added. (WTR::dumpBackForwardListItem): Added. (WTR::InjectedBundlePage::dumpBackForwardList): Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpBackForwardList and m_previousTestBackForwardListItem.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpBackForwardListsForAllWindows to false. (WTR::LayoutTestController::clearBackForwardList): Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added dumpBackForwardList, clearBackForwardList, shouldDumpBackForwardListsForAllWindows, and m_shouldDumpBackForwardListsForAllWindows.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set up didReceiveSynchronousMessageFromInjectedBundle. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Added.
  • WebKitTestRunner/TestController.h: Ditto.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added.
  • WebKitTestRunner/TestInvocation.h: Ditto.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::initializeInjectedBundlePath): Ditto.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • Shared/API/c/WKBase.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
  • Shared/API/c/WKURL.cpp: (WKURLCopyString): Added.
  • Shared/API/c/WKURL.h: Added WKURLCopyString.
  • Shared/API/c/cf/WKURLCF.h: Fixed incorrect argument name.
  • Shared/APIObject.h: Added TypeBundleBackForwardList and TypeBundleBackForwardListItem.
  • Shared/ImmutableArray.h: Marked destructor virtual explicitly.
  • Shared/ImmutableDictionary.h: Ditto.
  • UIProcess/WebBackForwardListItem.h: Ditto.
  • UIProcess/WebContext.h: Ditto.
  • UIProcess/WebFrameProxy.h: Ditto.
  • UIProcess/WebNavigationData.h: Ditto.
  • UIProcess/WebPageNamespace.h: Ditto.
  • UIProcess/WebPreferences.h: Ditto.
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Ditto.
  • UIProcess/WebBackForwardList.cpp: Removed unneeded backListWithLimit and forwardListWithLimit functions. (WebKit::WebBackForwardList::clear): Added.
  • UIProcess/WebBackForwardList.h: Marked destructor virtual explicitly. Added clear, removed backListWithLimit and forwardListWithLimit functions.
  • UIProcess/WebPageProxy.cpp: Removed unneeded backForwardBackItem, backForwardCurrentItem, and backForwardForwardItem functions. (WebKit::WebPageProxy::backForwardClear): Added.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • WebKit2.pro: Added new files.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp: Started with a copy of from WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardList.h.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetBackForwardList): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Ditto.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardList.cpp.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/WebBackForwardList.h.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.cpp.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.h.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed many unneeded functions. (WebKit::WebBackForwardListProxy::WebBackForwardListProxy): Removed unneeded initialization of m_closed. (WebKit::WebBackForwardListProxy::addItem): Added a check for the case of a capacity of 0. (WebKit::WebBackForwardListProxy::goToItem): Added a check for when the proxy outlives its page. (WebKit::WebBackForwardListProxy::itemAtIndex): Ditto. (WebKit::WebBackForwardListProxy::backListCount): Ditto. (WebKit::WebBackForwardListProxy::forwardListCount): Ditto. (WebKit::WebBackForwardListProxy::close): Removed unneeded code setting m_closed. (WebKit::WebBackForwardListProxy::isActive): Added. (WebKit::WebBackForwardListProxy::clear): Added.
  • WebProcess/WebPage/WebBackForwardListProxy.h: Added clear, isActive, and detach functions. Removed many other unneeded function and data members.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::~WebPage): Added call to detach on the back/forward list. (WebKit::WebPage::backForwardList): Added.
  • WebProcess/WebPage/WebPage.h: Added backForwardList function and m_backForwardList data member.
3:44 PM Changeset in webkit [70722] by crogers@google.com
  • 9 edits in trunk

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

No new tests since flag is disabled.

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Scripts/build-webkit:
3:38 PM Changeset in webkit [70721] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some GTK+ tests after r70688.

  • platform/gtk/fast/css/font-face-opentype-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
3:37 PM Changeset in webkit [70720] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Unreviewed.

build-webkit should collect Visual Studio Express logs and display them
​https://bugs.webkit.org/show_bug.cgi?id=39199

It turns out my previous patch wasn't actually working on the win-ews
machine. So I've fixed my mistakes from before.

  • Scripts/build-webkit:
    • Windows VSE builds change the CWD while building. Why? Who knows.
  • Scripts/print-vse-failure-logs:
    • windows VSE builds don't use Debug/Release as I expected, so I've moved off of --configuration to --top-level and added the /obj optimization while I was there.
3:28 PM Changeset in webkit [70719] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioResamplerKernel files
​https://bugs.webkit.org/show_bug.cgi?id=47624

No new tests since audio API is not yet implemented.

  • platform/audio/AudioResamplerKernel.cpp: Added. (WebCore::AudioResamplerKernel::AudioResamplerKernel): (WebCore::AudioResamplerKernel::getSourcePointer): (WebCore::AudioResamplerKernel::process): (WebCore::AudioResamplerKernel::reset): (WebCore::AudioResamplerKernel::rate):
  • platform/audio/AudioResamplerKernel.h: Added.
2:57 PM Changeset in webkit [70718] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

Test some appendChild cases that didn't have coverage before.

  • fast/dom/allowed-children-expected.txt: Added.
  • fast/dom/allowed-children.html: Added.

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.

Test: fast/dom/allowed-children.html

  • dom/Node.cpp: (WebCore::isChildTypeAllowed):
2:53 PM Changeset in webkit [70717] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] WebGL does not work with the compositor in test_shell
​https://bugs.webkit.org/show_bug.cgi?id=48470

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
    • Properly restore the draw framebuffer after resolving.

(WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture):

  • Make the context current before calling resolveMultisampledFramebuffer.
2:46 PM Changeset in webkit [70716] by Beth Dakin
  • 19 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
SPI to scale a WebView
-and corresponding-
<rdar://problem/8107667>

Reviewed by Darin Adler.

WebCore:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor. The scale factor is factored into the RenderStyle's
transform.

Set the current pageScale for the document.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

Frame keeps track of the page scale factor. When
scalePage() is called, it modifies the RenderView's style to
include a transform of the appropriate scale and forces a style
recalc.

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::scalePage):

  • page/Frame.h:

(WebCore::Frame::pageScaleFactor):

  • WebCore.exp.in:

Add a scale to the transformation matrix.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setPageScaleTransform):

  • rendering/style/RenderStyle.h:

WebKit/mac:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.

  • WebView/WebView.mm:

(-[WebView _scaleWebView:]):
(-[WebView _viewScaleFactor]):

  • WebView/WebViewPrivate.h:

WebKit2:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.

Implement scaleWebView(), which tells WebCore::Frame to scale, and
viewScaleFactor() which returns the current scale factor.

  • Shared/API/c/WKSharedAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):
(WKPageGetViewScaleFactor):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::scaleWebView):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::viewScaleFactor):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaleWebView):
(WebKit::WebPage::viewScaleFactor):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:45 PM Changeset in webkit [70715] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for test added in r70692

This test isn't rendering correctly. That's covered by
<​http://webkit.org/b/48459>.

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/win/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt: Added.
2:38 PM Changeset in webkit [70714] by mitz@apple.com
  • 7 edits in trunk

REGRESSION (r70335): Incorrect article layout in Safari Reader
​https://bugs.webkit.org/show_bug.cgi?id=48436

Reviewed by Darin Adler.

WebCore:

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the cross-origin
check is disabled.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize m_crossOriginCheckInGetMatchedCSSRulesDisabled.

  • page/Settings.h:

(WebCore::Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled): Added this accessor.
(WebCore::Settings::crossOriginCheckInGetMatchedCSSRulesDisabled): Ditto.

WebKit/mac:

  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
  • WebView/WebView.mm:

(-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
(-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
based on the above.

2:38 PM Changeset in webkit [70713] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by David Levin.

Include caps lock state when converting NSEvent modifiers to
WebInputEvent

​https://bugs.webkit.org/show_bug.cgi?id=47917

  • src/mac/WebInputEventFactory.mm: (WebKit::modifiersFromEvent):
2:35 PM Changeset in webkit [70712] by crogers@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by James Robinson.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=48465

  • features.gypi:
2:33 PM Changeset in webkit [70711] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • jit/JITStubs.cpp:

(JSC::jitThrow):

2:27 PM Changeset in webkit [70710] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Add Qt specific expected results after r70657.

  • platform/qt/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/qt/animations/missing-values-last-keyframe-expected.txt: Added.
2:22 PM Changeset in webkit [70709] by Dimitri Glazkov
  • 2 edits
    6 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations after r70692.

  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Tweaked.
2:21 PM Changeset in webkit [70708] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

2010-10-18 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Safari fullscreen media element tickles when it should not.


​https://bugs.webkit.org/show_bug.cgi?id=47861

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController updatePowerAssertions]):
2:16 PM Changeset in webkit [70707] by Adam Roben
  • 1 edit
    3 deletes in trunk/LayoutTests

Remove som unnecessary Windows-specific results

These should have been removed back in r70630.

  • platform/win/fast/blockflow/english-lr-text-expected.checksum: Removed.
  • platform/win/fast/blockflow/english-lr-text-expected.png: Removed.
  • platform/win/fast/blockflow/english-lr-text-expected.txt: Removed.
2:10 PM UsingGitWithWebKit edited by Adam Roben
Clarified that you still need Cygwin's git even if you use msysgit … (diff)
2:09 PM Changeset in webkit [70706] by zmo@google.com
  • 4 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=47027

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking): ASSERT false if undefined format is passed in.
  • platform/graphics/GraphicsContext3D.h: Add kSourceFormatUndefined enum.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): Decide source data format from componentsPerPixel, alpha format, bitsPerComponet, etc. (WebCore::GraphicsContext3D::getImageData): Refactor the code to use getSourceDataFormat and remove nested switches.
2:08 PM UsingGitWithWebKit edited by Adam Roben
Remove extraneous backticks (diff)
2:05 PM Changeset in webkit [70705] by Patrick Gansterer
  • 14 edits in trunk/WebCore

2010-10-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Use WTF::StringHasher::createBlobHash where possible
​https://bugs.webkit.org/show_bug.cgi?id=48228

Replace StringImpl::computeHash with StringHasher::createBlobHash.
This removes many duplicated code.

  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfoHash::hash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/gtk/FontPlatformDataPango.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::computeHash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/DeprecatedSVGAnimatedTemplate.h: (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
2:04 PM UsingGitWithWebKit edited by Adam Roben
Added instructions for maintaining good performance (diff)
2:00 PM UsingGitWithWebKit edited by Adam Roben
Make some instructions msysgit-compatible (diff)
1:58 PM UsingGitWithWebKit edited by Adam Roben
Add instructions for installing and setting up msysgit (diff)
1:48 PM Changeset in webkit [70704] by jianli@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 70484 - Calling FileReader.abort during reading could cause crash
​https://bugs.webkit.org/show_bug.cgi?id=48163

BUG=60979

Reviewed by David Levin.

WebCore:

Test: fast/files/file-reader-abort.html

  • fileapi/FileReader.cpp:

(WebCore::delayedAbort):
(WebCore::FileReader::abort): Schedule to do the abort later to work
around the case that abort() could be called from event handler.
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFail): Do not go with normal error handling
when we are in the process of aborting.
(WebCore::FileReader::failed):
(WebCore::FileReader::readyState):

  • fileapi/FileReader.h:

LayoutTests:

  • fast/files/file-reader-abort-expected.txt: Added.
  • fast/files/file-reader-abort.html: Added.

TBR=​jianli@chromium.org

1:46 PM Changeset in webkit [70703] by barraclough@apple.com
  • 22 edits in trunk/JavaScriptCore

Bug 48365 - Remove output parameters from JITStackFrame

Reviewed by Oliver Hunt.

The JIT stub functions presently use the stackframe to provide a couple of additional return values.

  • In the case of uncaught exceptions the exception value is returned on the stackframe.exception property.
  • In the case of caught exceptions the updated value for the callFrame register is returned on the stackframe.callFrame property.

Change exception returns such that exceptions are always returned on JSGlobalData::exception.
Change op_catch such that the new CallFrame value is returned from op_throw / vm_throw in regT0.

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):
(JSC::CachedCall::call):

  • interpreter/CallFrame.h:

(JSC::ExecState::exception):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JITCode.h:

(JSC::JITCode::execute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::jitThrow):
(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

  • runtime/CallData.cpp:

(JSC::call):

  • runtime/Completion.cpp:

(JSC::evaluate):

  • runtime/ConstructData.cpp:

(JSC::construct):

  • runtime/ExceptionHelpers.cpp:

(JSC::createErrorForInvalidGlobalAssignment):
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::sort):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

1:38 PM Changeset in webkit [70702] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

Fix the WebKit2 API tests.
​https://bugs.webkit.org/show_bug.cgi?id=48461

Reviewed by Sam Weinig.

The API tests were failing because the tests expect to be able to send messages before the
WebProcess finishes launching.

Instead of dispatching the pending messages in processDidFinishLaunching, dispatch them in
ensureWebProcess but do not make messages pending if the process is launching.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching):
Move dispatching the pending messages back from here ...
(WebKit::WebContext::ensureWebProcess):
... to here.
(WebKit::WebContext::postMessageToInjectedBundle):
Check whether the process can send messages in order to determine if a message needs to be
sent later.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::canSendMessage):
The WebProcessProxy can send a message if it is valid or if it is launching.

1:34 PM Changeset in webkit [70701] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-10-27 Tony Chang <​tony@chromium.org>

Unreviewed, build fix after r70692.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
1:32 PM Changeset in webkit [70700] by Simon Fraser
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-10-27 Simon Fraser <Simon Fraser>

Remove Leopard-specific results that are no longer required.

  • platform/mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/mac-leopard/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
1:32 PM Changeset in webkit [70699] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-10-27 Gabor Loki <​loki@webkit.org>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=48060
Speed up op_jeq_null and op_jneq_null.

For both opcodes the NullTag and UndefinedTag are checked to control the
jump. These values can be simply checked by AboveOrEqual or Below
condition if they are the two highest unsigned integers from JSValue's
Tag field.

  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null):
  • runtime/JSValue.h:
1:16 PM Changeset in webkit [70698] by Adam Roben
  • 1 edit
    6 adds in trunk/LayoutTests

Add Windows-specific results for tests added in r70664

These tests aren't rendering correctly. That's covered by
<​http://webkit.org/b/48459>.

  • platform/win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/win/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.txt: Added.
1:15 PM Changeset in webkit [70697] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed. Build fix after r70651.

  • CMakeListsEfl.txt: Add SoupURIUtils.cpp.
1:10 PM Changeset in webkit [70696] by andersca@apple.com
  • 3 edits in trunk/WebKit2

WebPageProxy::isValid should return false if the page has been explicitly closed
​https://bugs.webkit.org/show_bug.cgi?id=48458

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isValid):
(WebKit::WebPageProxy::relaunch):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isClosed):

12:58 PM CSS21Results edited by aestes@apple.com
(diff)
12:53 PM Changeset in webkit [70695] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Crystal Zhang <​haizhang@rim.com>

Reviewed by Eric Carlson.

​https://bugs.webkit.org/show_bug.cgi?id=48446

Fix an issue where we were passing the wrong parameter
to MIMETypeRegistry::getMIMETypeForExtension().

  • platform/MIMETypeRegistry.cpp:
12:52 PM Changeset in webkit [70694] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 70681

BUG=60695

12:49 PM Changeset in webkit [70693] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 70681

BUG=60695
Review URL: ​http://codereview.chromium.org/4091006

12:48 PM Changeset in webkit [70692] by hyatt@apple.com
  • 4 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48449

Reviewed by Beth Dakin.

Make border drawing work correctly with vertical inline flows. The top and bottom edge have to be omitted
rather than the left and right edges.

Also discovered that border-radius is broken with the new path-based-drawing code for all inline flows. This
is a regression from the old drawing code. I patched the code to be correct rather than clipping out stuff
that it shouldn't and applying border-radii on lines that don't even have them.

Added fast/blockflow/border-vertical-lr.html and fast/borders/border-radius-inline-flow.html

WebCore:

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow/border-vertical-lr.html: Added.
  • fast/borders/border-radius-inline-flow.html: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.txt: Added.
12:43 PM Changeset in webkit [70691] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some failing tests on Windows

The tests don't fail in a reliable way, so skipping them is our best
option for now.

  • platform/win/Skipped:
12:39 PM Changeset in webkit [70690] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-27 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_QWebFrame::popupFocus().
​https://bugs.webkit.org/show_bug.cgi?id=48432

  • Call setFocus() before show() to work around a but in Qt.
  • Remove the check on combo at the end since hidePopup() leads indirectly to its destruction and segfault.
  • tests/qwebframe/tst_qwebframe.cpp:
12:35 PM Changeset in webkit [70689] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Add GTK+-specific baselines for a couple tests.

  • platform/gtk/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/gtk/animations/missing-values-last-keyframe-expected.txt: Added.
12:31 PM Changeset in webkit [70688] by Martin Robinson
  • 4 edits
    5 adds in trunk

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] Font fallback determination is very ineffecient
​https://bugs.webkit.org/show_bug.cgi?id=42052

Added a test which verifies the correct result rendering with a custom
font that is missing many glyphs.

  • platform/gtk/fonts/custom-font-missing-glyphs-expected.checksum: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.png: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs.html: Added.
  • platform/gtk/fonts/resources/mostly-empty-font.ttf: Added. A font that I created in fotnforge which is composed of empty glyphs, except for 'A' which has a lonely polyhedron for a glyph.

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] Font fallback determination is very ineffecient
​https://bugs.webkit.org/show_bug.cgi?id=42052

When choosing a fallback font in FontCache::getFontDataForCharacters, use FontConfig's
mechanism for searching the fallback list directly, instead of scanning the list manually.
If the font is a custom font or any other font with no FontConfig pattern associated with
it, as FontConfig for a font that can supply the missing glyphs.

Test: platform/gtk/fonts/custom-font-missing-glyphs.html

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::createFontConfigPatternForCharacters): Added this helper which turns a collection of unicode characters into a FontConfig pattern. (WebCore::findBestFontGivenFallbacks): Using a FontConfig pattern created with th above helper and a FcFontSet of fallback fonts, this helper will find a font in the set which fulfills the requirments. (WebCore::FontCache::getFontDataForCharacters): Given an existing font with missing glyphs, either find an appropriate fallback font from the list of FontConfig fallbacks or ask FontConfig directly for an appropriate font.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Made a member mutable, as it is initialized lazily.
12:21 PM Changeset in webkit [70687] by andersca@apple.com
  • 9 edits
    4 copies
    4 adds in trunk/WebKit2

Begin stubbing out the Download class
​https://bugs.webkit.org/show_bug.cgi?id=48447

Reviewed by Adam Roben.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebKit2Prefix.h:

Include WebCore/EmptyProtocolDefinitions.h

  • WebProcess/Downloads/Download.cpp: Added.
  • WebProcess/Downloads/Download.h: Added.
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
Create a Download object and start it.

  • WebProcess/Downloads/mac/DownloadMac.mm: Added.

(WebKit::Download::start):
Create an NSURLDownload.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
Ask the download manager to start downloading.

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:

Add new files.

12:09 PM Changeset in webkit [70686] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

2010-10-27 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

preserveAlpha attributes were misspeled in SVGFEConcolveMatrixElement tests.
​https://bugs.webkit.org/show_bug.cgi?id=48403

Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
For checking preserveAlpha attribute we have already a dom test which is not affected by this patch.

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js:
12:05 PM Changeset in webkit [70685] by Adam Roben
  • 3 edits in trunk/WebKit2

Don't allow setting NetscapePlugin::m_isWindowed after NPP_New has completed

In Firefox, Chrome, and WebKit1 trying to set this value after NPP_New
does not actually affect whether the plugin is windowed.

Fixes <​http://webkit.org/b/46673> <rdar://problem/8484211> Assertion
failure in NetscapePlugin::platformDestroy when running
plugins/mouse-events.html in WebKit2 on Windows

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setIsWindowed): Moved here from the header.
Bail out if m_isStarted is true, indicating that NPP_New has already
finished.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Removed the

implementation of setIsWindowed.

12:02 PM Changeset in webkit [70684] by Dimitri Glazkov
  • 2 edits
    8 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70664.

  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [70683] by Dimitri Glazkov
  • 3 edits in trunk/WebKitTools

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70674.
​http://trac.webkit.org/changeset/70674
​https://bugs.webkit.org/show_bug.cgi?id=48053

Broke Chromium Windows build.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11:53 AM Changeset in webkit [70682] by apavlov@chromium.org
  • 8 edits in trunk

2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
11:46 AM Changeset in webkit [70681] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Add a function to make sure child is allowed before adding to a
render view.
​https://bugs.webkit.org/show_bug.cgi?id=48328

Test: fast/inline/inline-child-height-width-calc-crash.html

  • rendering/RenderView.cpp: (WebCore::RenderView::isChildAllowed):
  • rendering/RenderView.h:

2010-10-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that adding a br element to a new document does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=48328

  • fast/inline/inline-child-height-width-calc-crash-expected.txt: Added.
  • fast/inline/inline-child-height-width-calc-crash.html: Added.
11:45 AM Changeset in webkit [70680] by timothy@apple.com
  • 8 edits in trunk/WebKit2

Add API for enabling the developer extras (Web Inspector).

​http://webkit.org/b/48439

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDeveloperExtrasEnabled):
(WKPreferencesGetDeveloperExtrasEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setDeveloperExtrasEnabled):
(WebKit::WebPreferences::developerExtrasEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:42 AM Changeset in webkit [70679] by tony@chromium.org
  • 6 edits in trunk

2010-10-25 Tony Chang <​tony@chromium.org>

Reviewed by Anders Carlsson.

compile TestNetscapePlugIn on chromium linux
​https://bugs.webkit.org/show_bug.cgi?id=48274

  • WebKit.gyp: Enable compilation of TestNetscapePlugIn on Linux.

2010-10-25 Tony Chang <​tony@chromium.org>

Reviewed by Anders Carlsson.

compile TestNetscapePlugIn on chromium linux
​https://bugs.webkit.org/show_bug.cgi?id=48274

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Initialize): On Linux, plugin funcs are set in initialize. (NPP_New): Mark the plugin as windowless. (NPP_GetValue): Handle mime type values. (NP_GetMIMEDescription): (NP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
11:36 AM Changeset in webkit [70678] by Dimitri Glazkov
  • 2 edits
    16 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70664 and r70657.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.checksum: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.checksum: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.checksum: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.checksum: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:36 AM Changeset in webkit [70677] by Martin Robinson
  • 4 edits in trunk/WebCore

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
​https://bugs.webkit.org/show_bug.cgi?id=48445

Pass the pageClient GtkWidget* to gtk_xtbin_new instead of the
GdkWindow*. The pageClient is used to get the proper visual for the
plugin container widget.

No new tests. This patch should prevent plugins/null-npp-getvalue-pointer.html
from crashing.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Pass the widget instead of the window.
  • plugins/gtk/gtk2xtbin.c: Accept the widget instead of the window. (gtk_xtbin_new):
  • plugins/gtk/gtk2xtbin.h: Update the declaration.
11:19 AM Changeset in webkit [70676] by kenneth@webkit.org
  • 14 edits in trunk

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Anders Carlsson.

Move contentsSizeChange from the UIClient into the PageClient and
and make it a private Qt-only API in the process.

Make WKPageContentsSizeChangedCallback be a private API
​https://bugs.webkit.org/show_bug.cgi?id=48409

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didChangeContentsSize): (QWKPage::QWKPage):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeContentsSize):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Anders Carlsson.

Remove contentSizeChanged callbacks as it is no longer
part of the public UIClient.

Make WKPageContentsSizeChangedCallback be a private API
​https://bugs.webkit.org/show_bug.cgi?id=48409

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
11:05 AM Changeset in webkit [70675] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-10-27 Kwang Yul Seo <​skyul@company100.net>

Reviewed by James Robinson.

[BREWMP] Port graphics backend
​https://bugs.webkit.org/show_bug.cgi?id=40275

Add PLATFORM(BREWMP) guard to skia's FontCustomPlatformData
to share OS(LINUX) implementation.

  • loader/CachedFont.cpp:
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h:
11:02 AM Changeset in webkit [70674] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Make http locking default in NRWT.
​https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:59 AM Changeset in webkit [70673] by ggaren@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

Reviewed by Oliver Hunt.

SunSpider reports no change.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException): Walk the stack to calculate the high
water mark currently in use. It's not safe to assume that the current
CallFrame's high water mark is the highest high water mark because
calls do not always set up at the end of a CallFrame. A large caller
CallFrame can encompass a small callee CallFrame.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Make sure to set a 0 CodeBlock
in the CallFrame of a host call, like the Interpreter does, instead of
leaving the CodeBlock field uninitialized. The backtracing code requires
a valid CodeBlock field in each CallFrame.

LayoutTests: Added a test for:

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

  • fast/js/exception-registerfile-shrink-expected.txt: Added.
  • fast/js/exception-registerfile-shrink.html: Added.
  • fast/js/script-tests/exception-registerfile-shrink.js: Added.
10:51 AM Changeset in webkit [70672] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-27 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Tony Chang.

[NRWT] Fix http lock on Windows platform
​https://bugs.webkit.org/show_bug.cgi?id=48321

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
10:50 AM Changeset in webkit [70671] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; grouped editing test failures in one place.

  • platform/chromium/test_expectations.txt:
10:48 AM Changeset in webkit [70670] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r70546.

  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/qt/fast/blockflow/self-collapsing-block-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.checksum:
  • platform/qt/fast/multicol/nested-columns-expected.png:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
10:46 AM Changeset in webkit [70669] by satish@chromium.org
  • 30 edits
    2 deletes in trunk

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • fast/speech/input-text-language-tag-expected.txt: Removed.
  • fast/speech/input-text-language-tag.html: Removed.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult):
10:26 AM Changeset in webkit [70668] by hyatt@apple.com
  • 8 edits in trunk/LayoutTests

Change the results to account for a typo in the Japanese text string.

10:25 AM Changeset in webkit [70667] by Dimitri Glazkov
  • 61 edits in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70654.
​https://bugs.webkit.org/show_bug.cgi?id=48347

  • platform/chromium-*/svg/dynamic-updates/*: Updated.
10:24 AM Changeset in webkit [70666] by zmo@google.com
  • 4 edits in trunk

2010-10-27 ZHenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
​https://bugs.webkit.org/show_bug.cgi?id=45908

  • src/WebGraphicsContext3DDefaultImpl.cpp: Enable for chromium --in-process-webgl port. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):

2010-10-27 ZHenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
​https://bugs.webkit.org/show_bug.cgi?id=45908

  • platform/graphics/mac/GraphicsContext3DMac.mm: Enable for Mac port. (WebCore::GraphicsContext3D::GraphicsContext3D):
10:19 AM Changeset in webkit [70665] by satish@chromium.org
  • 30 edits
    2 adds in trunk

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
​https://bugs.webkit.org/show_bug.cgi?id=47089

  • fast/speech/input-text-language-tag-expected.txt: Added.
  • fast/speech/input-text-language-tag.html: Added.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see ​http://codereview.chromium.org/3615005/show and
​http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
​https://bugs.webkit.org/show_bug.cgi?id=48225.

Test: fast/speech/input-text-language-tag.html

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see ​http://codereview.chromium.org/3615005/show and
​http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
​https://bugs.webkit.org/show_bug.cgi?id=48225.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
​https://bugs.webkit.org/show_bug.cgi?id=47089

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
10:16 AM Changeset in webkit [70664] by hyatt@apple.com
  • 6 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48381

Reviewed by Dan Bernstein.

Make basic layer positioning work with vertical-lr writing-mode.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

  • fast/blockflow/japanese-lr-text.html: Added.
  • fast/blockflow/japanese-rl-text.html: Added.
10:14 AM Changeset in webkit [70663] by zmo@google.com
  • 2 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

object-deletion-behaviour.html fails with mesa backend
​https://bugs.webkit.org/show_bug.cgi?id=46667

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): If object_type is 0, we return early because object_name should be always be 0.
10:13 AM Changeset in webkit [70662] by Adam Roben
  • 6 edits in trunk/WebKitTools

Reset TestNetscapePlugIn's NPP_GetValue pointer when NullNPPGetValuePointer finishes running

Fixes <​http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
tests are failing on Qt

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_Destroy):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

Added a do-nothing NPP_Destroy implementation.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:

(NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
it later.
(NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
NPP_GetValue pointer so it can be used in other tests.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_destroy_instance):
Call through to the PluginTest when NPP_Destroy is called.

10:10 AM Changeset in webkit [70661] by zmo@google.com
  • 3 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

If WebGL is running on top of a strict version of OpenGL ES it should make sure attribs have buffers assigned at all times
​https://bugs.webkit.org/show_bug.cgi?id=47964

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Minimum checking: if input <= 0, only check if each enabled vertex attribute is bound to a buffer. (WebCore::WebGLRenderingContext::drawArrays): If underlying GL performs bounds checking, we still need to do the minimum checking using validateRenderingState. (WebCore::WebGLRenderingContext::drawElements): Ditto.
  • html/canvas/WebGLRenderingContext.h: Add a comment for input <= 0 in validateRenderingState.
10:04 AM Changeset in webkit [70660] by Dimitri Glazkov
  • 2 edits
    5 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update results after r70569.

  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:00 AM Changeset in webkit [70659] by andersca@apple.com
  • 5 edits
    3 adds in trunk/WebKit2

Add DownloadManager class
​https://bugs.webkit.org/show_bug.cgi?id=48388

Reviewed by Sam Weinig.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/DownloadManager.cpp: Added.

(WebKit::DownloadManager::shared):
(WebKit::DownloadManager::DownloadManager):

  • WebProcess/Downloads/DownloadManager.h: Added.
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:

Add new files.

9:56 AM Changeset in webkit [70658] by bweinstein@apple.com
  • 5 edits
    1 add in trunk

WebKit2 shouldn't try to send an empty user agent
​https://bugs.webkit.org/show_bug.cgi?id=48397

Reviewed by Adam Roben.

WebKit2:

Change the check of the custom user agent to an empty check instead of a null check. When the client application
sets a custom user agent and then resets it, the custom user agent is set to an empty string. If all we do
is check for a null string, then we will think we have a custom user agent (which is empty) and send an empty
user agent.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userAgent):

WebKitTools:

Add a test that when we set our custom user agent to an empty string, we don't send
an empty user agent.

  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.

(TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
(TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
9:47 AM Changeset in webkit [70657] by Simon Fraser
  • 3 edits
    8 adds in trunk

2010-10-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Accelerated animation with missing values in keyframes is broken
​https://bugs.webkit.org/show_bug.cgi?id=48395

r66339 changed the behavior of keyframe animations such that if a property
is missing from a keyframe, the property will be interpolated between those
keyframes that do have a value for the property. If a value is missing
from the first or last keyframes, the element's unanimated style supplies
that value.

However, accelerated animations had a bug where if a value was missing
from the first (and maybe subsequent) or last (and maybe preceding) keyframes,
the animation data given to the GraphicsLayer would be missing the style from the
first or final keyframe.

Tests: animations/missing-values-first-keyframe.html

animations/missing-values-last-keyframe.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
9:37 AM Changeset in webkit [70656] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Moved the tests with WONTFIX to the WONTFIX list.

  • platform/chromium/test_expectations.txt:
9:12 AM Changeset in webkit [70655] by Adam Roben
  • 2 edits in trunk/WebKitTools

Check in file I forgot in r70653

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
so we can be naughty and modify it later.

9:10 AM Changeset in webkit [70654] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

Calling the super class of RenderSVGImage::updateFromElement is missing
​https://bugs.webkit.org/show_bug.cgi?id=48347

RenderSVGImage::updateFromElement is an inherited function of RenderSVGModelObject what needs calling its ancestor.
Lack of this call caused filters were not invalidated at SVGImage objects.

No new tests, because this modification is covered by SVGFEConvolveMatrixElement's dynamic update tests.

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
9:08 AM Changeset in webkit [70653] by Adam Roben
  • 11 edits
    3 adds in trunk

Don't call NPP_GetValue if the plugin didn't provide an implementation

Fixes <​http://webkit.org/b/48433> Crash in
NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
WebKit2 on Windows

Reviewed by Eric Carlson.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_GetValue): Null-check the getvalue pointer
before using it to call NPP_GetValue.

WebKitTools:

Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added NullNPPGetValuePointer.cpp.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:

Set up a place to store the NPPluginFuncs struct the browser passed to us.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.

(NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
NPP_GetValue pointer we passed to the browser to simulate a plugin that
doesn't implement NPP_GetValue.
(NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
function is called, it means that WebKit has changed in a way that
makes this test invalid.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
to us so we can be naughty and modify it later.

LayoutTests:

Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer

  • plugins/null-npp-getvalue-pointer-expected.txt: Added.
  • plugins/null-npp-getvalue-pointer.html: Added.
9:02 AM Changeset in webkit [70652] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.
8:58 AM Changeset in webkit [70651] by Martin Robinson
  • 7 edits
    2 adds in trunk

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

  • platform/gtk/Skipped: removed test from skipped list

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

Added a new utility function that turns SoupURIs into
KURLs. That addresses some issues with SoupURIs like for example
soup_uri_to_string ignoring the URI password. Basic authentication
using URL credentials should work now.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
  • platform/network/soup/SoupURIUtils.cpp: Added. (WebCore::soupURIToKURL):
  • platform/network/soup/SoupURIUtils.h: Added.
8:56 AM Changeset in webkit [70650] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Andreas Kling.

Remove references to ancient QGVLauncher and QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=48430

  • manual-tests/plugins/windowed.html: change to QtTestBrowser
  • manual-tests/plugins/windowless.html: ditto

2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Andreas Kling.

Remove references to ancient QGVLauncher and QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=48430

QtTestBrowser substitutes both and has checks enabled.

  • Scripts/webkitpy/style/checker.py: remove references
  • Scripts/webkitpy/style/checker_unittest.py: ditto
8:51 AM Changeset in webkit [70649] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a couple tests after r70569.

  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.txt:
8:48 AM Changeset in webkit [70648] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[NRWT] Don't use image hash when it's no need in single test mode.
​https://bugs.webkit.org/show_bug.cgi?id=48326

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
8:43 AM Changeset in webkit [70647] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2010-10-27 David Kilzer <​ddkilzer@apple.com>

Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()

Reviewed by Adam Roben.

Follow-up fix for: <​https://bugs.webkit.org/show_bug.cgi?id=48278>

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a leak introduced in r70613.
8:30 AM Changeset in webkit [70646] by Patrick Gansterer
  • 1 edit
    1 add in trunk/WebCore

2010-10-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

[WINCE] Buildfix after r70400.
​https://bugs.webkit.org/show_bug.cgi?id=48419

  • platform/wince/TemporaryLinkStubs.cpp: Added. (WebCore::setCookieStoragePrivateBrowsingEnabled):
8:22 AM Changeset in webkit [70645] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Assert due to multiple initialization of WebPlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=48327

Reviewed by Andreas Kling.

We are using the LocalizationStrategy in the UI process
so the previous attempt to fix this (​http://trac.webkit.org/changeset/70620)
was wrong.

  • UIProcess/API/qt/qwkpage.cpp:

(initializePlatformStrategiesIfNeeded):
Call WebPlatformStrategies::initialize exactly once.
(QWKPagePrivate::QWKPagePrivate):

8:16 AM Changeset in webkit [70644] by satish@chromium.org
  • 2 edits in trunk/WebCore

2010-10-27 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Add runtime flag check before enabling speech input in code.
​https://bugs.webkit.org/show_bug.cgi?id=48426

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
7:37 AM Changeset in webkit [70643] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-27 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[NRWT] Add platform specific baseline search paths for Qt port
​https://bugs.webkit.org/show_bug.cgi?id=48428

  • Scripts/webkitpy/layout_tests/port/qt.py:
7:05 AM WebKitGtkLayoutTests edited by nicolas.dufresne@collabora.co.uk
Add FreeType hinting note (diff)
6:48 AM Changeset in webkit [70642] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-27 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Add cmn to branch32(reg, imm) on ARM
​https://bugs.webkit.org/show_bug.cgi?id=48062

The conditional comparison can be done with cmn if the imm value is
negative and can fit into the cmn instruction.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
6:15 AM Changeset in webkit [70641] by Adam Roben
  • 2 edits in trunk/WebCore

Only decompress pixel buffers when needed (and fix a crash in the process)

Fixes <​http://webkit.org/b/48417> Crash when running
compositing/video/video-background-color.html on Windows

Reviewed by Anders Carlsson.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
decompress the pixel buffer when it has an incompatible format. This
also has the benefit of only decompressing the buffer when a
QTDecompressionSession has been created! (I assume this was just a typo
from when this code was added in r70252.)

6:13 AM Changeset in webkit [70640] by Adam Roben
  • 2 edits in trunk/WebKitTools

Catch exceptions when checking if we're inside a git working directory

Fixes <​http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
fails on systems without git installed

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/net/credentials.py:

(Credentials._credentials_from_git): Put the call to
Git.in_working_directory inside the try/except since it, too, attempts
to execute git and thus will throw on systems that don't have git
installed.

5:46 AM Changeset in webkit [70639] by mario@webkit.org
  • 1 edit in trunk/WebKit/gtk/tests/testatk.c

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added missing line in testatk.c to add an unit test.

This fixes a mistake that happened when landing reviewed patch for
bug 47365, while addressing a minor issue before committing it.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

  • tests/testatk.c: (main):
5:35 AM Changeset in webkit [70638] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Check in new Windows results for svg/custom/use-on-symbol-inside-pattern.svg

Windows has slightly different rounding behavior from Mac on this test.

  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.checksum: Added.
  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
5:07 AM Changeset in webkit [70637] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] WebKit2 UI process crashes if web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=48400

Check the success of socket write operations.
Avoids crashing the UI process if web process has crashed.
Qt socket code segfaults when write is called for a socket
that has had an error.

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Reset m_socket after deletion.

(CoreIPC::Connection::sendOutgoingMessage):
Check error status of write operations and
invalidate socket if writes fail.

4:52 AM Changeset in webkit [70636] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed, fix english-lr-text expectations that I've messed up.

  • platform/chromium/test_expectations.txt:
4:48 AM Changeset in webkit [70635] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Type mismatch while serializing/deserializing message id size
​https://bugs.webkit.org/show_bug.cgi?id=48401

Use correct types when reading data from connection buffer.

The message id is written as uint32_t, thus the buffer size should be
calculated based on sizeof(uint32_t) and not sizeof(MessageID).

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
4:15 AM Changeset in webkit [70634] by mario@webkit.org
  • 4 edits in trunk

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

Properly consider text under a non-text renderer in textForObject.

We need to check all the children under a non-text renderer, if
any, to consider when current object is not a text object but some
of its children are, in order not to miss those portions of text
by not properly handling those situations.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForRenderer): New. Get the text for a RenderObject's children. (textForObject): Use the new textForRenderer function.

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

New test to make sure this bug is actually fixed.

  • tests/testatk.c: (testWebkitAtkLinksWithInlineImages): New test. (main): Added new test.
4:14 AM Changeset in webkit [70633] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix for r70622.

  • inspector/storage-panel-dom-storage.html:
3:29 AM Changeset in webkit [70632] by jorlow@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB test/tutorial
​https://bugs.webkit.org/show_bug.cgi?id=48067

This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.

  • storage/indexeddb/tutorial-expected.txt: Added.
  • storage/indexeddb/tutorial.html: Added.
3:26 AM Changeset in webkit [70631] by Nikolas Zimmermann
  • 31 edits
    4 adds in trunk

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect.
Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators.

Test: svg/dom/SVGRect.html

  • GNUmakefile.am: Add SVGAnimatedRect.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAngle.idl: Remove [SVGProperty] flag.
  • svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag.
  • svg/SVGAnimatedLength.idl: Ditto.
  • svg/SVGAnimatedLengthList.idl: Ditto.
  • svg/SVGAnimatedRect.h: Added.
  • svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code.
  • svg/SVGLength.idl: Remove [SVGProperty] flag.
  • svg/SVGMarkerElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes.
  • svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. (WebCore::SVGSVGElement::currentView): (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/SVGSymbolElement.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: Take a SVGElement as context element. (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
  • svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it.

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Added new test verifying that StrictTypeChecking is enabled for SVGRect.

  • svg/dom/SVGRect-expected.txt: Added.
  • svg/dom/SVGRect.html: Added.
  • svg/dom/script-tests/SVGRect.js: Added.
3:22 AM Changeset in webkit [70630] by Adam Roben
  • 5 edits
    3 deletes in trunk/LayoutTests

Update Windows results for vertical-text tests after r70569

  • platform/win/fast/blockflow/english-rl-text-expected.checksum: Removed.
  • platform/win/fast/blockflow/english-rl-text-expected.png: Removed.
  • platform/win/fast/blockflow/english-rl-text-expected.txt: Removed.
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/win/fast/text/international/vertical-text-metrics-test-expected.txt:
3:21 AM Changeset in webkit [70629] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

2010-10-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by David Kilzer.

Convert DumpRenderTree webarchive code to CoreFoundation
​https://bugs.webkit.org/show_bug.cgi?id=48278

CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.

These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData):
3:05 AM Changeset in webkit [70628] by mnaganov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update -- add test results for Mac after r70619.

  • platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
2:28 AM Changeset in webkit [70627] by mnaganov@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update -- add test results after r70619.

  • platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
2:22 AM Changeset in webkit [70626] by pfeldman@chromium.org
  • 1 edit in branches/chromium/552/WebCore/inspector/front-end/InjectedScript.js

Merge 70565 - 2010-10-26 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn't work in closures when window is overrode
​https://bugs.webkit.org/show_bug.cgi?id=48320

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

TBR=​podivilov@chromium.org
BUG=60540

2:13 AM Changeset in webkit [70625] by pfeldman@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 69752 - 2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

Test: inspector/debugger-eval-on-call-frame.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.

2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

  • inspector/debugger-eval-on-call-frame-expected.txt: Added.
  • inspector/debugger-eval-on-call-frame.html: Added.

TBR=​yurys@chromium.org

2:04 AM Changeset in webkit [70624] by podivilov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog
2:04 AM Changeset in webkit [70623] by podivilov@chromium.org
  • 1 edit in trunk/WebCore/inspector/InspectorState.h

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix line endings in InspectorState.h

  • inspector/InspectorState.h:
1:52 AM Changeset in webkit [70622] by podivilov@chromium.org
  • 15 edits in trunk/WebCore

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move frontend settings to local storage
​https://bugs.webkit.org/show_bug.cgi?id=47715

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createStatusbarButtons):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Settings.prototype.installProjectSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set): (WebInspector.Settings.prototype._getProjectSetting): (WebInspector.Settings.prototype._setProjectSetting): (WebInspector.Settings.prototype._formatProjectKey):
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reset):
1:52 AM Changeset in webkit [70621] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
1:19 AM Changeset in webkit [70620] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Multiple WebPlatformStrategy initialization triggers assert in WebCore/PlatformStrategies.
Remove the code for now, as it is not used at all.
​https://bugs.webkit.org/show_bug.cgi?id=48327

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate):
1:18 AM Changeset in webkit [70619] by aestes@apple.com
  • 3 edits
    1 move
    3 adds
    3 deletes in trunk

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by David Hyatt.

Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
​https://bugs.webkit.org/show_bug.cgi?id=48396

Test: fast/block/float/clear-element-too-wide-for-containing-block.html

WebKit did not clear elements adjacent to floats if they were wider than
the containing block, instead keeping them on the same line and allowing
them to spill out the right side of the containing block. We should
match the spec in this regard and clear the element below the float even
if it is too wide for the containing block. Doing this seems to also
match IE's and Firefox's behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta): Continue to compute the clear delta even if the child's minimum preferred width is greater than the containing block's available width.

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by David Hyatt.

Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
​https://bugs.webkit.org/show_bug.cgi?id=48396

  • fast/block/float/clear-element-too-wide-for-containing-block.html: Copied from LayoutTests/fast/block/float/tableshifting.html.
  • fast/block/float/tableshifting.html: Removed.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
  • platform/mac/fast/block/float/tableshifting-expected.checksum: Removed.
  • platform/mac/fast/block/float/tableshifting-expected.png: Removed.
  • platform/mac/fast/block/float/tableshifting-expected.txt: Removed.
12:21 AM Changeset in webkit [70618] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add some tests to the Skipeed list, because of unimplemented
LayoutTestController and EventSender features.

  • platform/qt-wk2/Skipped:

Oct 26, 2010:

11:38 PM Changeset in webkit [70617] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

2010-10-26 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Title-Element has no popup on <svg>-Elements, but on <g>
​https://bugs.webkit.org/show_bug.cgi?id=47669

Allow tooltips on non-root svg elements.

No new tests.

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
11:15 PM Changeset in webkit [70616] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-26 Antonio Gomes <​agomes@rim.com>

Reviewed by Martin Robinson.

Remove the absolute path used to include DumpRenderTreeSupportGtk.h from LayoutTestController.h

It turns out this is rather unneeded since WebKitTools/GNUMakefile.am has WebKit/gtk/ in its include
path, and then we can just do #include "WebCoreSupport/DumpRenderTreeSupportGtk.h"

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
10:42 PM Changeset in webkit [70615] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-26 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

constraint validation: stepMismatch (rounding error)
​https://bugs.webkit.org/show_bug.cgi?id=48220

  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:

2010-10-26 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

constraint validation: stepMismatch (rounding error)
​https://bugs.webkit.org/show_bug.cgi?id=48220

  1. Changed the computation to achieve difference from a integral multiple of the allowed value step.

The previous fmod(doubleValue, step) sometimes returned unacceptable
remainder. For example,

double doubleValue = 1.005; Actually, near to 1.005
double step = 0.005; Actually, near to 0.005
fmod(doubleValue, step) ==> (near to) 0.005

It's a case that doubleValue is a little smaller than 1.005 and step is
a little larger than 0.005.

  1. Changed the error threshold.

Number values in HTML5 are expressed in IEEE 754 single-precision.
Too precise comparison sometimes leads unintended errors.

For example, I found a case :

remainder = 0.00000000000000022204460

acceptableError = 0.00000000000000007105427

  • html/NumberInputType.cpp: (WebCore::NumberInputType::stepMismatch):
10:29 PM Changeset in webkit [70614] by ddkilzer@apple.com
  • 2 edits
    2 moves
    1 add in trunk/WebKitTools

Rename WebArchiveDumpSupport.mm to WebArchiveDumpSupport.cpp

Reviewed by Adam Roben.

Part 4 of 4: <​http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Updated for file moves and renames.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.mm.
  • DumpRenderTree/cf/WebArchiveDumpSupport.h: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.h.
10:29 PM Changeset in webkit [70613] by ddkilzer@apple.com
  • 5 edits in trunk/WebKitTools

Convert WebArchiveDumpSupport.mm from NS objects to CF types

Reviewed by Adam Roben.

Part 3 of 4: <​http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation

In order to share WebArchive code between the Mac and Windows
ports, the code in WebArchiveDumpSupport.mm was converted from
Cocoa to C++ using CoreFoundation (CF) types.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump): Renamed serializeWebArchiveToXML() to
createXMLStringFromWebArchiveData() and added HardAutorelease()
to prevent leaks.

  • DumpRenderTree/mac/WebArchiveDumpSupport.h:

(createXMLStringFromWebArchiveData): Renamed from
serializeWebArchiveToXML(). Changed to use CF types.
(createCFURLResponseFromResponseData): Renamed from
unarchiveNSURLResponseFromResponseData(). Changed to use CF
types for its parameter and return type.

  • DumpRenderTree/mac/WebArchiveDumpSupport.mm: Replaced use of

NS objects with CF types. It will be renamed to *.cpp in a
future commit.
(convertMIMEType): Changed to use case-insensitive string
comparisons.
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):

  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData): Renamed from
unarchiveNSURLResponseFromResponseData(). Changed to use CF
types for its parameter and return type.

10:29 PM Changeset in webkit [70612] by ddkilzer@apple.com
  • 4 edits in trunk/WebKitTools

Extract use of NSKeyedUnarchiver from WebArchiveDumpSupport.mm

Reviewed by Adam Roben.

Part 2 of 4: <​http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation

There is no equivalent to NSKeyedUnarchiver in CoreFoundation,
so extract it into a platform-specific source file.

  • DumpRenderTree/mac/WebArchiveDumpSupport.h:

(unarchiveNSURLResponseFromResponseData): Added declaration.

  • DumpRenderTree/mac/WebArchiveDumpSupport.mm:

(convertWebResourceResponseToDictionary): Extracted code to
unarchiveNSURLResponseFromResponseData() in
WebArchiveDumpSupportMac.mm. Updated logic to return early if
nil is returned from unarchiveNSURLResponseFromResponseData().

  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:

(unarchiveNSURLResponseFromResponseData): Added. Extracted
code from convertWebResourceResponseToDictionary() in
WebArchiveDumpSupport.mm.

10:29 PM Changeset in webkit [70611] by ddkilzer@apple.com
  • 4 edits
    1 copy in trunk/WebKitTools

Extract call to -[WebHTMLRepresentation supportedNonImageMIMETypes] from WebArchiveDumpSupport.mm

Reviewed by Adam Roben.

Part 1 of 4: <​http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation

The call to -[WebHTMLRepresentation supportedNonImageMIMETypes]
is not cross-platform between Mac and Windows, so extract it
into a platform-specific source file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added

WebArchiveDumpSupportMac.mm to the project.

  • DumpRenderTree/mac/WebArchiveDumpSupport.h:

(supportedNonImageMIMETypes): Added declaration.

  • DumpRenderTree/mac/WebArchiveDumpSupport.mm:

(convertWebResourceDataToString): Replaced call to
-[WebHTMLRepresentation supportedNonImageMIMETypes] with
supportedNonImageMIMETypes().

  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Added.

(supportedNonImageMIMETypes): Added. Extracted from
WebArchiveDumpSupport.mm.

10:26 PM Changeset in webkit [70610] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-26 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Fix compile when ACCELERATED_COMPOSITING flag is not set
​https://bugs.webkit.org/show_bug.cgi?id=48373

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): (WebKit::WebMediaPlayerClientImpl::readyStateChanged): (WebKit::WebMediaPlayerClientImpl::load):
  • src/WebMediaPlayerClientImpl.h:
10:22 PM Changeset in webkit [70609] by tonikitoo@webkit.org
  • 10 edits
    2 adds in trunk

[GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
​https://bugs.webkit.org/show_bug.cgi?id=48199

Reviewed by Martin Robinson.
Patch by Antonio Gomes <​agomes@rim.com>

.:

  • GNUmakefile.am: Added WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h to GTK+'s build system;
  • autotools/symbols.filter: Added DumpRenderTreeSupportGtk symbols to symbols.filter so they do not get filtered and get visible by DRT.

WebKit/gtk:

Implemented an initial version of the DumpRenderTreeSupportGtk class.
The main idea is that it groups together the bodies of many LayoutTestController
methods, so they can directly access WebCore features. This way we eliminate the
need of adding APIs to WebKitGTK just to expand its test coverage through DRT.

The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey
property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and
to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::tabsToLinks):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added.

(DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk):
(DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk):
(DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled):
(DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property.
(DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property.
(DumpRenderTreeSupportGtk::linksIncludedInFocusChain):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Added.

WebKitTools:

Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
(createWebView):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • platform/gtk/Skipped: Unskiped fast/events/tab-focus-anchor.html.
9:31 PM Changeset in webkit [70608] by ariya@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed, change the order of my emails for bugzilla autocompletion.

  • Scripts/webkitpy/common/config/committers.py:
9:29 PM Changeset in webkit [70607] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-10-26 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

build-webkit should collect Visual Studio Express logs and display them
​https://bugs.webkit.org/show_bug.cgi?id=39199

  • Scripts/build-webkit:
  • Scripts/print-vse-failure-logs: Added.
  • Scripts/webkitdirs.pm:
9:06 PM Changeset in webkit [70606] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch

Reviewed by Csaba Osztrogonác.

  • Scripts/build-webkit: Added support for --meter-tag switch.

It should have been added with r60820.

8:50 PM Changeset in webkit [70605] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-10-26 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add DelayNode files
​https://bugs.webkit.org/show_bug.cgi?id=47516

No new tests since audio API is not yet implemented.

  • webaudio/DelayNode.cpp: Added. (WebCore::DelayNode::DelayNode): (WebCore::DelayNode::delayTime):
  • webaudio/DelayNode.h: Added. (WebCore::DelayNode::create): (WebCore::DelayNode::delayProcessor):
  • webaudio/DelayNode.idl: Added.
8:35 PM Changeset in webkit [70604] by crogers@google.com
  • 6 edits in trunk/WebCore

2010-10-26 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

AudioContext and AudioNode followup changes for AudioNodeInput/AudioNodeOutput thread safety
​https://bugs.webkit.org/show_bug.cgi?id=47504

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::isAudioThread): (WebCore::AudioContext::isGraphOwner): (WebCore::AudioContext::handlePreRenderTasks): (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::deleteMarkedNodes): (WebCore::AudioContext::markAudioNodeInputDirty): (WebCore::AudioContext::markAudioNodeOutputDirty): (WebCore::AudioContext::handleDirtyAudioNodeInputs): (WebCore::AudioContext::handleDirtyAudioNodeOutputs):
  • webaudio/AudioContext.h:
  • webaudio/AudioNode.cpp:
  • webaudio/AudioNode.h: (WebCore::AudioNode::isMarkedForDeletion):
  • webaudio/AudioNode.idl:
8:21 PM Changeset in webkit [70603] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-26 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add DelayProcessor files
​https://bugs.webkit.org/show_bug.cgi?id=47517

No new tests since audio API is not yet implemented.

  • webaudio/DelayProcessor.cpp: Added. (WebCore::DelayProcessor::DelayProcessor): (WebCore::DelayProcessor::~DelayProcessor): (WebCore::DelayProcessor::createKernel):
  • webaudio/DelayProcessor.h: Added. (WebCore::DelayProcessor::delayTime):
7:31 PM Changeset in webkit [70602] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-26 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNodeOutput files
​https://bugs.webkit.org/show_bug.cgi?id=45581

No new tests since audio API is not yet implemented.

  • webaudio/AudioNodeOutput.cpp: Added. (WebCore::AudioNodeOutput::AudioNodeOutput): (WebCore::AudioNodeOutput::setNumberOfChannels): (WebCore::AudioNodeOutput::setInternalBus): (WebCore::AudioNodeOutput::updateRenderingState): (WebCore::AudioNodeOutput::updateNumberOfChannels): (WebCore::AudioNodeOutput::propagateChannelCount): (WebCore::AudioNodeOutput::pull): (WebCore::AudioNodeOutput::bus): (WebCore::AudioNodeOutput::renderingFanOutCount): (WebCore::AudioNodeOutput::fanOutCount): (WebCore::AudioNodeOutput::addInput): (WebCore::AudioNodeOutput::removeInput): (WebCore::AudioNodeOutput::disconnectAllInputs): (WebCore::AudioNodeOutput::disable): (WebCore::AudioNodeOutput::enable):
  • webaudio/AudioNodeOutput.h: Added. (WebCore::AudioNodeOutput::node): (WebCore::AudioNodeOutput::context): (WebCore::AudioNodeOutput::numberOfChannels): (WebCore::AudioNodeOutput::isChannelCountKnown):
7:01 PM Changeset in webkit [70601] by tkent@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge a part of 70555 -

2010-10-26 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Input Method inserts conversion candidates unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=46868

Calls updateStyleIfNeeded() before setting selection for the composition to
avoid inserting the previous composition text into a content editable element
which has an event handler that changes the style of the element.

Test: platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html

  • editing/Editor.cpp: (WebCore::Editor::setComposition): calls updateStyleIfNeeded() before setting selection.

TBR=​tkent@chromium.org
BUG=56759

7:01 PM Changeset in webkit [70600] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-26 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Dumitru Daniliuc.

check-webkit-style fails on operator+=, operator-=, ... methods
​https://bugs.webkit.org/show_bug.cgi?id=48258

  • Scripts/webkitpy/style/checkers/cpp.py: Added exceptions
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests
6:59 PM Changeset in webkit [70599] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-26 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNodeInput files
​https://bugs.webkit.org/show_bug.cgi?id=45577

No new tests since audio API is not yet implemented.

  • webaudio/AudioNodeInput.cpp: Added. (WebCore::AudioNodeInput::AudioNodeInput): (WebCore::AudioNodeInput::connect): (WebCore::AudioNodeInput::disconnect): (WebCore::AudioNodeInput::disable): (WebCore::AudioNodeInput::enable): (WebCore::AudioNodeInput::changedOutputs): (WebCore::AudioNodeInput::updateRenderingState): (WebCore::AudioNodeInput::numberOfChannels): (WebCore::AudioNodeInput::numberOfRenderingChannels): (WebCore::AudioNodeInput::bus): (WebCore::AudioNodeInput::internalSummingBus): (WebCore::AudioNodeInput::sumAllConnections): (WebCore::AudioNodeInput::pull):
  • webaudio/AudioNodeInput.h: Added. (WebCore::AudioNodeInput::node): (WebCore::AudioNodeInput::context): (WebCore::AudioNodeInput::numberOfRenderingConnections): (WebCore::AudioNodeInput::renderingOutput): (WebCore::AudioNodeInput::isConnected): (WebCore::AudioNodeInput::numberOfConnections):
6:56 PM Changeset in webkit [70598] by morrita@google.com
  • 12 edits in trunk

2010-10-26 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Rolling in r70512 again.

spellcheck= should be the same as spellcheck="true"
​https://bugs.webkit.org/show_bug.cgi?id=25539

  • editing/spelling/spellcheck-attribute-expected.txt:
  • editing/spelling/spellcheck-attribute.html:

2010-10-26 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Rolling in r70512 again, added missing null-check to
Editor::isSpellCheckingEnabled().
​http://trac.webkit.org/changeset/70512

spellcheck= should be the same as spellcheck="true"
​https://bugs.webkit.org/show_bug.cgi?id=25539

  • dom/Element.cpp: (WebCore::Element::spellcheckAttributeState): (WebCore::Element::isSpellCheckingEnabled):
  • dom/Element.h:
  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/Editor.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-10-26 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Rolling in r70512 again.

spellcheck= should be the same as spellcheck="true"
​https://bugs.webkit.org/show_bug.cgi?id=25539

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::shouldSpellcheckByDefault):
6:41 PM Changeset in webkit [70597] by bfulgham@webkit.org
  • 9 edits in trunk

WebCore: Unreviewed build fixes.

  • WebCore.vcproj/WebCore.vcproj: Turn off several non-WinCairo

files. We don't support CoreAnimation!

  • WebCore.vcproj/WebCoreCairo.vsprops: Add missing include path

for 'image-decoders/webp'

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookieStoragePrivateBrowsingEnabled): Add build stub.

WebKit/win: Unreviewed build fix.

  • WebView.cpp: Conditionalize includes for CFNetwork-specific

Cookie implementation.

  • WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.

WinCairo doesn't use CoreAnimation.

WebKit2: Unreviewed build fix.

  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::cancelledError): Conditionalize use of CFNetwork calls
and includes.

6:30 PM Changeset in webkit [70596] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 70594

BUG=51602
Review URL: ​http://codereview.chromium.org/4182003

6:28 PM Changeset in webkit [70595] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 70594

BUG=51602

5:49 PM Changeset in webkit [70594] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Crash in CompositeEditCommand::splitTreeToNode
​https://bugs.webkit.org/show_bug.cgi?id=48349

Reviewed by Kent Tamura.

WebCore:

The bug was caused by indentIntoBlockquote's passing null pointer to splitTreeToNode.
Fixed the crash by adding early exits.

Test: editing/execCommand/indent-node-to-split-to-crash.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::splitTreeToNode):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Added a test to ensure WebKit does not crash when indenting.

  • editing/execCommand/indent-node-to-split-to-crash-expected.txt: Added.
  • editing/execCommand/indent-node-to-split-to-crash.html: Added.
5:42 PM Changeset in webkit [70593] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r67170): crash in removeImplicitlyStyledElement
​https://bugs.webkit.org/show_bug.cgi?id=48389

Fixed the crash by adding a null pointer check.

Test: editing/style/invalid-font-size.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):

2010-10-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r67170): crash in removeImplicitlyStyledElement
​https://bugs.webkit.org/show_bug.cgi?id=48389

Added a test to ensure WebKit does not crash when changing the font size
of text inside a font element with an invalid size attribute.

  • editing/style/invalid-font-size-expected.txt: Added.
  • editing/style/invalid-font-size.html: Added.
5:37 PM Changeset in webkit [70592] by tkent@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Update the ChangeLog entry for r70549 so that the description contains
"form controls."

5:31 PM HackingGtk edited by Martin Robinson
Delete obsolete information and link to up to date sources (diff)
5:15 PM Changeset in webkit [70591] by mitz@apple.com
  • 2 edits in trunk/WebKit

Build fix.

  • WebKit.xcodeproj/project.pbxproj: Allow deprecated methods to be used in NetscapePluginHostProxy.mm.
5:08 PM Changeset in webkit [70590] by ojan@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

remove DEFER support from new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=48387

DEFER was needed when we were trying to ship Chrome beta.
Now it's just extra complication.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4:45 PM Changeset in webkit [70589] by crogers@google.com
  • 28 edits
    1 copy in branches/audio/WebCore

audio branch: changes in preparation for landing in trunk

  • added thread safety to ConvolverNode
  • throw exception for invalid arguments in connect() / disconnect()
  • Cleanup JavaScriptAudioNode, AudioResampler, RealtimeAnalyser and RealtimeAnalyserNode, AudioBufferSourceNode
  • add AudioBusMac for loadPlatformResource() method and switch HRTFElevation to use this method
  • add comments about Chrome resource abstraction layers
  • add custom markChildren() method to JavaScriptAudioNode (fixes bug where "onaudioprocess" was anonymous function)
  • minor cleanup in JS and V8 custom bindings
4:39 PM Changeset in webkit [70588] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Interpreter build fix.

4:19 PM Changeset in webkit [70587] by ap@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Modified original file, not its framework copy this time.
4:15 PM Changeset in webkit [70586] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-26 Eric Seidel <​eric@webkit.org>

Unreviewed. Adding import with_statement to fix python 2.5.

Teach webkit-patch how to read credentials from the environment
​https://bugs.webkit.org/show_bug.cgi?id=48275

  • Scripts/webkitpy/common/net/credentials_unittest.py:
    • import with_statement to fix python 2.5.
4:05 PM Changeset in webkit [70585] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Pass a downloadID to the web process whenever a download is requested
​https://bugs.webkit.org/show_bug.cgi?id=48380

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::generateDownloadID):
Generate a unique download ID.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Pass along a download ID if needed.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):
Call the web frame member function.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::WebFrame):
Initialize m_policyDownloadID.

(WebKit::WebFrame::invalidatePolicyListener):
Reset m_policyDownloadID.

(WebKit::WebFrame::didReceivePolicyDecision):
Set m_policyDownloadID.

(WebKit::WebFrame::startDownload):
Assert that m_policyDownloadID is not zero.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):
Pass along the download ID.

  • WebProcess/WebPage/WebPage.messages.in:

Add the download ID.

4:00 PM Changeset in webkit [70584] by ap@apple.com
  • 17 edits in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=48375
<rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have
loaded insecure content

Added the delegate. Just like the bundle version, it misses WebOrigin parameter that Mac
delegate call used to have. It doesn't seem necessary for clients.

3:57 PM Changeset in webkit [70583] by crogers@google.com
  • 1130 edits
    625 copies
    117 deletes in branches/audio

audio branch: merge 65473:70545 from trunk: remaining files

3:53 PM Changeset in webkit [70582] by senorblanco@chromium.org
  • 2 edits
    199 adds in trunk/LayoutTests

2010-10-26 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Added new baselines and expectations for the canvas GPU tests.
​https://bugs.webkit.org/show_bug.cgi?id=48383

Added fast/canvas layout test results for platforms chromium-gpu-win
and chromium-gpu-linux. Copied list of expected fast/canvas and
canvas/philip failures from main test_expectations.txt (unfortunate,
but necessary for now). Added the tests actually failing on the GPU
which don't fail in the software path to chromium-gpu's
test_expectations.txt.

Covered by, well, everything you see here. :)

  • platform/chromium-gpu-linux/fast: Added.
  • platform/chromium-gpu-linux/fast/canvas: Added.
  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.txt: Added.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.txt: Added.
  • platform/chromium-gpu-win/fast: Added.
  • platform/chromium-gpu-win/fast/canvas: Added.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
3:35 PM Changeset in webkit [70581] by Dimitri Glazkov
  • 31 edits
    4 deletes in trunk

2010-10-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70573.
​http://trac.webkit.org/changeset/70573
​https://bugs.webkit.org/show_bug.cgi?id=48204

Broke 39 tests on Chromium

  • svg/dom/SVGRect-expected.txt: Removed.
  • svg/dom/SVGRect.html: Removed.
  • svg/dom/script-tests/SVGRect.js: Removed.

2010-10-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70573.
​http://trac.webkit.org/changeset/70573
​https://bugs.webkit.org/show_bug.cgi?id=48204

Broke 39 tests on Chromium

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • svg/DeprecatedSVGAnimatedPropertyTraits.h:
  • svg/DeprecatedSVGAnimatedTemplate.h:
  • svg/SVGAngle.idl:
  • svg/SVGAnimatedAngle.idl:
  • svg/SVGAnimatedLength.idl:
  • svg/SVGAnimatedLengthList.idl:
  • svg/SVGAnimatedRect.h: Removed.
  • svg/SVGFitToViewBox.h:
  • svg/SVGLength.idl:
  • svg/SVGMarkerElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGRect.idl:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentView): (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
  • svg/SVGSymbolElement.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h: (WebCore::SVGViewSpec::contextElement):
  • svg/SVGZoomEvent.idl:
  • svg/properties/SVGAnimatedPropertyMacros.h:
3:26 PM Changeset in webkit [70580] by inferno@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 70550

BUG=60769

3:24 PM Changeset in webkit [70579] by inferno@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/InspectorDOMStorageResource.cpp

Merge 70550

BUG=60769
Review URL: ​http://codereview.chromium.org/4130003

3:11 PM Changeset in webkit [70578] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove DEFER from test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=48378

DEFER is no longer meaningful. We originally used it
to defer tests we didn't need to pass for our beta launch.
Now it just adds noise. I'll remove the python support for
it in a followup patch.

  • platform/chromium/test_expectations.txt:
2:41 PM Changeset in webkit [70577] by crogers@google.com
  • 249 edits
    41 copies
    9 deletes in branches/audio/JavaScriptCore

audio branch: merge 65473:70545 from trunk: JavaScriptCore

2:34 PM Changeset in webkit [70576] by crogers@google.com
  • 2126 edits
    714 copies
    260 deletes in branches/audio/WebCore

audio branch: merge 65473:70545 from trunk: WebCore

2:30 PM Changeset in webkit [70575] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix 32-bit build.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

2:10 PM Changeset in webkit [70574] by commit-queue@webkit.org
  • 40 edits
    2 adds in trunk

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • fast/frames/iframe-reparenting-fail-load-expected.txt: Added.
  • fast/frames/iframe-reparenting-fail-load.html: Added.
  • platform/mac/Skipped: Re-enabled test that failed due to this bug.

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

Test: fast/frames/iframe-reparenting-fail-load.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::transferLoadingResourcesFromPage): Added method that notifies the client to update resource tracking for loading resources that have been transferred to a different page.
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage): Empty method.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: Added method that triggers resource tracking updates. This wraps the DocumentLoader method as it appears DocumentLoader is opaque to Frame.
  • loader/FrameLoaderClient.h: Added API to notify the client to update resource tracking for a loading resource that has been transferred to a different page.
  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): Update resource tracking if page has changed.

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage): Empty method.
  • src/FrameLoaderClientImpl.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage): Empty method.
  • WebCoreSupport/FrameLoaderClientEfl.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): Empty method.
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage): Empty method.
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didTransferChildFrameToNewDocument): Empty method. (WebFrameLoaderClient::transferLoadingResourceFromPage): Update resource tracking for a resource load that has been transferred to a new page.

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage): Emtpy method.
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transferLoadingResourceFromPage): Empty method.
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage): Empty method.
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage): Empty method.
  • WebKitSupport/FrameLoaderClientWx.h:

2010-10-26 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Resource tracking failure when trying to move a frame between documents
​https://bugs.webkit.org/show_bug.cgi?id=44713

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage): Empty method.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
1:56 PM Changeset in webkit [70573] by Nikolas Zimmermann
  • 31 edits
    4 adds in trunk

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect.
Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators.

Test: svg/dom/SVGRect.html

  • GNUmakefile.am: Add SVGAnimatedRect.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAngle.idl: Remove [SVGProperty] flag.
  • svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag.
  • svg/SVGAnimatedLength.idl: Ditto.
  • svg/SVGAnimatedLengthList.idl: Ditto.
  • svg/SVGAnimatedRect.h: Added.
  • svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code.
  • svg/SVGLength.idl: Remove [SVGProperty] flag.
  • svg/SVGMarkerElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes.
  • svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. (WebCore::SVGSVGElement::currentView): (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/SVGSymbolElement.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: Take a SVGElement as context element. (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
  • svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it.

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Added new test verifying that StrictTypeChecking is enabled for SVGRect.

  • svg/dom/SVGRect-expected.txt: Added.
  • svg/dom/SVGRect.html: Added.
  • svg/dom/script-tests/SVGRect.js: Added.
1:56 PM Changeset in webkit [70572] by Adam Roben
  • 3 edits in trunk/WebKitTools

Clear up confusion between "3D rendering" and "accelerated compositing"

WebKit has no software-based 3D rendering implementation, so 3D
rendering can only be enabled when accelerated compositing is. But DRT
was falsely reporting that 3D rendering was available on machines that
don't support accelerated compositing, leading to much confusion.

Reviewed by Darin Adler.

Fixes <​http://webkit.org/b/48370> REGRESSION (r70540): Many
transforms/3d tests are failing on the XP bots

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main): When ENABLE(3D_RENDERING) is turned on, only report that 3D
rendering is available when acclerated compositing is also available.

  • Scripts/old-run-webkit-tests: Skip tests that use the

-webkit-transform-3d media query when 3D rendering is disabled,
rather than when accelerated compositing is disabled.

1:52 PM Changeset in webkit [70571] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-10-26 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Indicate that the test only passes on Chromium/DRT.
​https://bugs.webkit.org/show_bug.cgi?id=46868

  • platform/chromium/test_expectations.txt: Tweaked.
1:47 PM Changeset in webkit [70570] by eric@webkit.org
  • 12 edits
    3 deletes in trunk/WebKitTools

2010-10-26 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Remove rietveld code now that it's unused
​https://bugs.webkit.org/show_bug.cgi?id=48359

Was cool that we added this support, but now that it's
not used it makes little sense to keep it around.
We can always restore this code from SVN if we need it.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/rietveld.py: Removed.
  • Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
  • Scripts/webkitpy/thirdparty/init.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
1:47 PM Changeset in webkit [70569] by hyatt@apple.com
  • 16 edits in trunk

Advances are wrong and glyphs are rotated improperly in vertical writing
​https://bugs.webkit.org/show_bug.cgi?id=48315

Patch by takano takumi <​takano1@asia.apple.com> on 2010-10-26
Reviewed by Dave Hyatt.

WebCore:

We shouldn't use vertical metrics for Roman fonts. Also, we should rotate vertical variant
glyphs back on drawing as the whole run has already been rotated beforehand.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData): Changed to ignore vertical orientation when the font doesn't support vertical metrics.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Changed to rotate glyphs -90 degree for vertical variants.
(WebCore::Font::drawGlyphs):

LayoutTests:

Changed tests to check more glyphs and updated results.

  • fast/text/international/vertical-text-glyph-test.html:
  • fast/text/international/vertical-text-metrics-test.html:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/mac/fast/text/international/vertical-text-metrics-test-expected.txt:
1:46 PM Changeset in webkit [70568] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Post any pending messages to the Injected Bundle in WebContext::processDidFinishLaunching
instead of in WebContext::ensureWebProcess.
​https://bugs.webkit.org/show_bug.cgi?id=48367

Reviewed by Darin Adler.

Send pending injected bundle messages after the process finished launching instead of of
directly after creating it.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Move the logic to dispatch pending injected bundle messages from here ...
(WebKit::WebContext::processDidFinishLaunching):
... to here.
Also use a reference instead of a pointer when sending the pending messages.

1:40 PM Changeset in webkit [70567] by satish@chromium.org
  • 16 edits in trunk

2010-10-26 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add a 'grammar' attribute for speech input.
​https://bugs.webkit.org/show_bug.cgi?id=48339

To differentiate between various types of speech input, we add a 'x-webkit-grammar' attribute to a
speech enabled input element. This is passed without validation to the speech recognizer. Typical values
could be "builtin:search", "builtin:dictation" and even an externally hosted SRGS grammar XML file URI.
It is up to the recognizer to interpret the value and use it as an aid in recognition.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled):
  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.idl:
  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

2010-10-26 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add a 'grammar' attribute for speech input.
​https://bugs.webkit.org/show_bug.cgi?id=48339

To differentiate between various types of speech input, we add a 'x-webkit-grammar' attribute to a
speech enabled input element. This is passed without validation to the speech recognizer. Typical values
could be "builtin:search", "builtin:dictation" and even an externally hosted SRGS grammar XML file URI.
It is up to the recognizer to interpret the value and use it as an aid in recognition.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
1:37 PM Changeset in webkit [70566] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: console does not work after two reloads.
​https://bugs.webkit.org/show_bug.cgi?id=48318

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend):
1:29 PM Changeset in webkit [70565] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-10-26 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn't work in closures when window is overrode
​https://bugs.webkit.org/show_bug.cgi?id=48320

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
1:28 PM Changeset in webkit [70564] by andersca@apple.com
  • 12 edits in trunk

WebKit2: pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
​https://bugs.webkit.org/show_bug.cgi?id=48366

Reviewed by Sam Weinig.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Add zero initializer.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageDidScroll):
Call the pageDidScroll client function.

  • UIProcess/WebPageProxy.messages.in:

Add PageDidScroll message.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageDidScroll):
Send the PageDidScroll message.

WebKitTools: pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
​https://bugs.webkit.org/show_bug.cgi?id=48366
<rdar://problem/8595202>

Reviewed by Sam Weinig.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

1:26 PM Changeset in webkit [70563] by Dimitri Glazkov
  • 11 edits
    1 delete in trunk/LayoutTests

[Chromium] Add/change baselines after r70546 and added Chromium-mac
specific test to expectations.
​https://bugs.webkit.org/show_bug.cgi?id=48157
​https://bugs.webkit.org/show_bug.cgi?id=46868

  • platform/chromium-linux/fast/blockflow/english-rl-text-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Updated.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png: Updated.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Removed.
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Updated.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png: Updated.
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt: Updated.
  • platform/chromium/test_expectations.txt: Tweaked.
1:19 PM Changeset in webkit [70562] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-26 Eric Seidel <​eric@webkit.org>

Reviewed by Tony Chang.

Teach webkit-patch how to read credentials from the environment
​https://bugs.webkit.org/show_bug.cgi?id=48275

This makes it possible for svn users to have their bugzilla credentials
stored in their environment instead of typing them every time.

We need this for making it easy to run the win-ews bot (which currently
uses svn instead of git).

  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
1:16 PM Changeset in webkit [70561] by bweinstein@apple.com
  • 5 edits in trunk/WebKit2

Need a way to retrieve custom user agent from a WKPage
​https://bugs.webkit.org/show_bug.cgi?id=48360
<rdar://problem/8466537>

Reviewed by Darin Adler.

Add an exported function on WKPage to get the page's custom user agent.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyCustomUserAgent): Exported function that returns the custom user

agent.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Clear the custom user agent string.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::setCustomUserAgent): Add a new early return if we're setting

the custom user agent to what it was before, and set the custom user agent member
variable.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::customUserAgent): Returns the custom user agent.

1:08 PM Changeset in webkit [70560] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-10-26 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add yet another flake.
​https://bugs.webkit.org/show_bug.cgi?id=48352

  • platform/chromium/test_expectations.txt: Added flakey test.
1:01 PM Changeset in webkit [70559] by hans@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-10-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: update stale comments referring to WebIndexedDatabase.
​https://bugs.webkit.org/show_bug.cgi?id=48325

WebIndexedDatabase was renamed to WebIDBFactory in
​http://trac.webkit.org/changeset/64344, but some comments referring to
it were left unchanged.

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBIndex.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • src/WebIDBDatabaseImpl.h:
12:49 PM Changeset in webkit [70558] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-26 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Skipping popup focus test for symbian
​https://bugs.webkit.org/show_bug.cgi?id=48324

  • tests/qwebframe/tst_qwebframe.cpp:
12:47 PM Changeset in webkit [70557] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

2010-10-26 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix an assert with QtPixmapInstance creation.
​https://bugs.webkit.org/show_bug.cgi?id=48323

This places the newly refcounted QtPixmapInstance in a RefPtr
to prevent an assert on the first ref() call.

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
12:35 PM Changeset in webkit [70556] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-10-26 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

[Qt] Unit tests: setHtml("data:text/html,...") -> load(QUrl("data:text/html,..."))
​https://bugs.webkit.org/show_bug.cgi?id=48319

These tests were failing since the new HTML parser.
This patch removes the content type from the error page as well.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnViewlessWebPages):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::frame):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadFinished): (ErrorPage::extension): (tst_QWebPage::errorPageExtension): (tst_QWebPage::errorPageExtensionInIFrames): (tst_QWebPage::errorPageExtensionInFrameset):
12:25 PM Changeset in webkit [70555] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2010-10-26 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Input Method inserts conversion candidates unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=46868

Adds a test.

  • platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html: Added.

2010-10-26 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Input Method inserts conversion candidates unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=46868

Calls updateStyleIfNeeded() before setting selection for the composition to
avoid inserting the previous composition text into a content editable element
which has an event handler that changes the style of the element.

Test: platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html

  • editing/Editor.cpp: (WebCore::Editor::setComposition): calls updateStyleIfNeeded() before setting selection.

2010-10-26 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Input Method inserts conversion candidates unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=46868

Adds setComposition() to TextInputController to make DRT emulate
an input method behavior.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::setComposition): Added.
  • DumpRenderTree/chromium/TextInputController.h:
12:19 PM Changeset in webkit [70554] by commit-queue@webkit.org
  • 14 edits in trunk

2010-10-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Layout tables should indicate that they are not data tables via an object attribute
​https://bugs.webkit.org/show_bug.cgi?id=35422

Set the 'layout-guess' attribute to 'true' for data tables.

Reorganized some code in AccessibilityTable so now the function
isDataTable() is more coherent by just answering that very
specific question, regardless of whether the table is being
exposed or not to Assistive Technologies.

Hence, now it's possible to make two questions separately instead
of just one, meaning that the new function isAccessibleTable() is
now what we formerly defined as the isDataTable() function.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isAccessibilityTable):

New function to allow asking tables both whether they are
exposed and whether they are data tables, which are different
questions whose answers might be the same in many situations,
but different sometimes (as it can happen in the GTK port).

  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::hasARIARole):

New, checks whether the table has a valid ARIA role.

(WebCore::AccessibilityTable::isAccessibilityTable):

New, returns the value of m_isAccessibilityTable. It's
basically the former isDataTable() function renamed.

(WebCore::AccessibilityTable::isDataTable):

Changed behaviour. Instead of just returning the value of
m_isAccessibilityTable as it did so far (which was confusing
because of that's not what the name suggests), focus on
checking whether it's a data table or not and return a bool
value accordingly. It's basically a rename of the former
isTableExposableThroughAccessibility() function, but withouth
the GTK-specific if-endif region (which didn't make sense
here now, because that was answering the question "is the table
exposed in the GTK port?", instead of "is it a data table?").

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

Uses the hasAriaRole(), and isDataTable() to determine whether
a table should be exposed or not. Also includes the GTK-specific
if-region coming from the former implementation of the function
isTableExposableThroughAccessibility() not to check whether it's
a data table in case the rest of the checks succeeded (all
tables are exposed in the GTK port).

(WebCore::AccessibilityTable::addChildren):

Replace usage of isDataTable() with isAccessibilityTable(), to
keep exactly the same behaviour happening before this patch.

(WebCore::AccessibilityTable::roleValue): Ditto.
(WebCore::AccessibilityTable::accessibilityIsIgnored): Ditto.
(WebCore::AccessibilityTable::title): Ditto.

Updated usage of the former function isDataTable() everywhere
else, replacing it with the new isAccessibilityTable(), so keeping
exactly the same behaviour happening before this patch.

  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::addChildren):

Use isAccessibilityTable() instead of isDataTable().

  • accessibility/AccessibilityARIAGridCell.cpp: (WebCore::AccessibilityARIAGridCell::parentTable): Ditto.
  • accessibility/AccessibilityARIAGridRow.cpp: (WebCore::AccessibilityARIAGridRow::disclosedRows): Ditto. (WebCore::AccessibilityARIAGridRow::disclosedByRow): Ditto. (WebCore::AccessibilityARIAGridRow::parentTable): Ditto.
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::isTableCell):

Use isAccessibilityTable() instead of isDataTable().

  • accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren): Ditto.
  • accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::isTableRow): Ditto
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

Use isAccessibilityTable() instead of isDataTable().

(-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): Ditto.
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.

Use the new function isAccessibilityTable() together with the
modified implementation of isDataTable() to set the 'layout-guess'
attribute when needed.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_attributes):

Set the 'layout-guess' attribute to 'true' to help Assistive
Technologies guessing which tables are not data tables.

2010-10-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Layout tables should indicate that they are not data tables via an object attribute
​https://bugs.webkit.org/show_bug.cgi?id=35422

New unit test to check the 'layout-guess' attribute in tables.

  • tests/testatk.c: (atkAttributeSetAttributeNameHasValue): New, looks for a attribute with a specific value, by the name of attribute. (atkAttributeSetContainsAttributeName): New, just checks whether an attribute with a specified name is present in the set. (atkAttributeSetAttributeHasValue): Modified to relay on the new function atkAttributeSetAttributeNameHasValue(). (testWebkitAtkLayoutAndDataTables): New test. (main): Added the new test.
12:11 PM Changeset in webkit [70553] by cmarrin@apple.com
  • 4 edits
    2 adds in trunk

2010-10-26 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Resuming animations causes webkitAnimationStart events to be fired
​https://bugs.webkit.org/show_bug.cgi?id=46540

Added a flag that makes sure start animation event is only ever
fired once.

Test: animations/suspend-resume-animation-events.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation): (WebCore::KeyframeAnimation::sendAnimationEvent):
  • page/animation/KeyframeAnimation.h:
12:01 PM Changeset in webkit [70552] by senorblanco@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-10-22 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement copy-texture-to-parent-texture API for WebGraphicsContext3DDefaultImpl.
​https://bugs.webkit.org/show_bug.cgi?id=48152


This allows the in-process implementation to do accelerated canvas and
accelerated compositing together. It requires some changes landed
in chromium 63528, so this patch also rolls chromium DEPS to 63722
(current LKGR).

Covered by fast/canvas/arc360.html, and many more when run with
--accelerated-compositing and --accelerated-2d-canvas.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): Add member vars to save the currently-bound texture and for the texture-to-texture FBO. (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): Delete the texture-to-texture FBO on destruction.

(WebKit::WebGraphicsContext3DDefaultImpl::initialize):
Generate the texture-to-texture FBO.
(WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM):
Check for support of the glGetTexLevelParameteriv function (required
for this implementation).
(WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
Implement the extension: bind the FBO, bind the child texture, then
do a glCopyTexImage2D() into the parent texture.
(WebKit::WebGraphicsContext3DDefaultImpl::bindTexture):
Record the newly-bound texture in m_boundTexture.

  • src/WebGraphicsContext3DDefaultImpl.h: Add the two new member variables.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::graphicsContext3D): Make sure the graphics context is reshaped to the correct size on all platforms.
11:57 AM Changeset in webkit [70551] by Martin Robinson
  • 6 edits
    485 adds in trunk/LayoutTests

2010-10-26 Martin Robinson <​mrobinson@igalia.com>

Add baselines for some GTK+ tests, unskip passing tests and organize
failing tests in preparation for landing GTK+ form control fixes.

  • platform/gtk/Skipped: Organization.
  • platform/gtk/fast/forms/001-expected.checksum: Added.
  • platform/gtk/fast/forms/001-expected.png: Added.
  • platform/gtk/fast/forms/001-expected.txt: Added.
  • platform/gtk/fast/forms/002-expected.checksum: Added.
  • platform/gtk/fast/forms/002-expected.png: Added.
  • platform/gtk/fast/forms/002-expected.txt: Added.
  • platform/gtk/fast/forms/003-expected.checksum: Added.
  • platform/gtk/fast/forms/003-expected.png: Added.
  • platform/gtk/fast/forms/003-expected.txt: Added.
  • platform/gtk/fast/forms/004-expected.checksum: Added.
  • platform/gtk/fast/forms/004-expected.png: Added.
  • platform/gtk/fast/forms/004-expected.txt: Added.
  • platform/gtk/fast/forms/005-expected.checksum: Added.
  • platform/gtk/fast/forms/005-expected.png: Added.
  • platform/gtk/fast/forms/005-expected.txt: Added.
  • platform/gtk/fast/forms/006-expected.checksum: Added.
  • platform/gtk/fast/forms/006-expected.png: Added.
  • platform/gtk/fast/forms/006-expected.txt: Added.
  • platform/gtk/fast/forms/007-expected.checksum: Added.
  • platform/gtk/fast/forms/007-expected.png: Added.
  • platform/gtk/fast/forms/007-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label05-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png: Added.
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
  • platform/gtk/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/gtk/fast/forms/basic-buttons-expected.png: Added.
  • platform/gtk/fast/forms/basic-buttons-expected.txt: Added.
  • platform/gtk/fast/forms/basic-inputs-expected.checksum: Added.
  • platform/gtk/fast/forms/basic-inputs-expected.png: Added.
  • platform/gtk/fast/forms/basic-inputs-expected.txt: Added.
  • platform/gtk/fast/forms/basic-selects-expected.checksum: Added.
  • platform/gtk/fast/forms/basic-selects-expected.png: Added.
  • platform/gtk/fast/forms/basic-selects-expected.txt: Added.
  • platform/gtk/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/gtk/fast/forms/basic-textareas-expected.png: Added.
  • platform/gtk/fast/forms/basic-textareas-expected.txt: Added.
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum: Added.
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: Added.
  • platform/gtk/fast/forms/blankbuttons-expected.checksum: Added.
  • platform/gtk/fast/forms/blankbuttons-expected.png: Added.
  • platform/gtk/fast/forms/blankbuttons-expected.txt: Added.
  • platform/gtk/fast/forms/button-align-expected.checksum: Added.
  • platform/gtk/fast/forms/button-align-expected.png: Added.
  • platform/gtk/fast/forms/button-align-expected.txt: Added.
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt: Added.
  • platform/gtk/fast/forms/button-default-title-expected.checksum: Added.
  • platform/gtk/fast/forms/button-default-title-expected.png: Added.
  • platform/gtk/fast/forms/button-default-title-expected.txt: Added.
  • platform/gtk/fast/forms/button-generated-content-expected.checksum: Added.
  • platform/gtk/fast/forms/button-generated-content-expected.png: Added.
  • platform/gtk/fast/forms/button-generated-content-expected.txt: Added.
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.checksum: Added.
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt: Added.
  • platform/gtk/fast/forms/button-positioned-expected.checksum: Added.
  • platform/gtk/fast/forms/button-positioned-expected.png: Added.
  • platform/gtk/fast/forms/button-positioned-expected.txt: Added.
  • platform/gtk/fast/forms/button-sizes-expected.checksum: Added.
  • platform/gtk/fast/forms/button-sizes-expected.png: Added.
  • platform/gtk/fast/forms/button-sizes-expected.txt: Added.
  • platform/gtk/fast/forms/button-submit-expected.checksum: Added.
  • platform/gtk/fast/forms/button-submit-expected.png: Added.
  • platform/gtk/fast/forms/button-submit-expected.txt: Added.
  • platform/gtk/fast/forms/button-table-styles-expected.checksum: Added.
  • platform/gtk/fast/forms/button-table-styles-expected.png: Added.
  • platform/gtk/fast/forms/button-table-styles-expected.txt: Added.
  • platform/gtk/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/gtk/fast/forms/button-text-transform-expected.png: Added.
  • platform/gtk/fast/forms/button-text-transform-expected.txt: Added.
  • platform/gtk/fast/forms/button-white-space-expected.checksum: Added.
  • platform/gtk/fast/forms/button-white-space-expected.png: Added.
  • platform/gtk/fast/forms/button-white-space-expected.txt: Added.
  • platform/gtk/fast/forms/caret-rtl-expected.checksum: Added.
  • platform/gtk/fast/forms/caret-rtl-expected.png: Added.
  • platform/gtk/fast/forms/caret-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.checksum: Added.
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.png: Added.
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt: Added.
  • platform/gtk/fast/forms/control-clip-expected.checksum: Added.
  • platform/gtk/fast/forms/control-clip-expected.png: Added.
  • platform/gtk/fast/forms/control-clip-expected.txt: Added.
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum: Added.
  • platform/gtk/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum: Added.
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt: Added.
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum: Added.
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt: Added.
  • platform/gtk/fast/forms/encoding-test-expected.checksum: Added.
  • platform/gtk/fast/forms/encoding-test-expected.png: Added.
  • platform/gtk/fast/forms/encoding-test-expected.txt: Added.
  • platform/gtk/fast/forms/fieldset-align-expected.checksum: Added.
  • platform/gtk/fast/forms/fieldset-align-expected.png: Added.
  • platform/gtk/fast/forms/fieldset-align-expected.txt: Added.
  • platform/gtk/fast/forms/fieldset-with-float-expected.checksum: Added.
  • platform/gtk/fast/forms/fieldset-with-float-expected.png: Added.
  • platform/gtk/fast/forms/fieldset-with-float-expected.txt: Added.
  • platform/gtk/fast/forms/file-input-direction-expected.checksum: Added.
  • platform/gtk/fast/forms/file-input-direction-expected.png: Added.
  • platform/gtk/fast/forms/file-input-direction-expected.txt: Added.
  • platform/gtk/fast/forms/file-input-disabled-expected.checksum: Added.
  • platform/gtk/fast/forms/file-input-disabled-expected.png: Added.
  • platform/gtk/fast/forms/file-input-disabled-expected.txt: Added.
  • platform/gtk/fast/forms/float-before-fieldset-expected.checksum: Added.
  • platform/gtk/fast/forms/float-before-fieldset-expected.png: Added.
  • platform/gtk/fast/forms/float-before-fieldset-expected.txt: Added.
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.checksum: Added.
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.png: Added.
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt: Added.
  • platform/gtk/fast/forms/form-added-to-table-expected.checksum: Added.
  • platform/gtk/fast/forms/form-added-to-table-expected.png: Added.
  • platform/gtk/fast/forms/form-added-to-table-expected.txt: Added.
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum: Added.
  • platform/gtk/fast/forms/form-element-geometry-expected.png: Added.
  • platform/gtk/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/gtk/fast/forms/form-hides-table-expected.checksum: Added.
  • platform/gtk/fast/forms/form-hides-table-expected.png: Added.
  • platform/gtk/fast/forms/form-hides-table-expected.txt: Added.
  • platform/gtk/fast/forms/form-in-malformed-markup-expected.checksum: Added.
  • platform/gtk/fast/forms/form-in-malformed-markup-expected.png: Added.
  • platform/gtk/fast/forms/form-in-malformed-markup-expected.txt: Added.
  • platform/gtk/fast/forms/formmove-expected.checksum: Added.
  • platform/gtk/fast/forms/formmove-expected.png: Added.
  • platform/gtk/fast/forms/formmove-expected.txt: Added.
  • platform/gtk/fast/forms/formmove2-expected.checksum: Added.
  • platform/gtk/fast/forms/formmove2-expected.png: Added.
  • platform/gtk/fast/forms/formmove2-expected.txt: Added.
  • platform/gtk/fast/forms/formmove3-expected.checksum: Added.
  • platform/gtk/fast/forms/formmove3-expected.png: Added.
  • platform/gtk/fast/forms/formmove3-expected.txt: Added.
  • platform/gtk/fast/forms/hidden-input-file-expected.checksum: Added.
  • platform/gtk/fast/forms/hidden-input-file-expected.png: Added.
  • platform/gtk/fast/forms/hidden-input-file-expected.txt: Added.
  • platform/gtk/fast/forms/hidden-listbox-expected.checksum: Added.
  • platform/gtk/fast/forms/hidden-listbox-expected.png: Added.
  • platform/gtk/fast/forms/hidden-listbox-expected.txt: Added.
  • platform/gtk/fast/forms/image-border-expected.checksum: Added.
  • platform/gtk/fast/forms/image-border-expected.png: Added.
  • platform/gtk/fast/forms/image-border-expected.txt: Added.
  • platform/gtk/fast/forms/indeterminate-expected.checksum: Added.
  • platform/gtk/fast/forms/indeterminate-expected.png: Added.
  • platform/gtk/fast/forms/indeterminate-expected.txt: Added.
  • platform/gtk/fast/forms/input-align-expected.checksum: Added.
  • platform/gtk/fast/forms/input-align-expected.png: Added.
  • platform/gtk/fast/forms/input-align-expected.txt: Added.
  • platform/gtk/fast/forms/input-align-image-expected.checksum: Added.
  • platform/gtk/fast/forms/input-align-image-expected.png: Added.
  • platform/gtk/fast/forms/input-align-image-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-disabled-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-focus-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-height-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-height-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-height-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-readonly-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-selection-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-visibility-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-width-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-width-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-width-expected.txt: Added.
  • platform/gtk/fast/forms/input-baseline-expected.checksum: Added.
  • platform/gtk/fast/forms/input-baseline-expected.png: Added.
  • platform/gtk/fast/forms/input-baseline-expected.txt: Added.
  • platform/gtk/fast/forms/input-disabled-color-expected.checksum: Added.
  • platform/gtk/fast/forms/input-disabled-color-expected.png: Added.
  • platform/gtk/fast/forms/input-disabled-color-expected.txt: Added.
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/gtk/fast/forms/input-field-text-truncated-expected.checksum: Added.
  • platform/gtk/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt: Added.
  • platform/gtk/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/gtk/fast/forms/input-first-letter-expected.png: Added.
  • platform/gtk/fast/forms/input-first-letter-expected.txt: Added.
  • platform/gtk/fast/forms/input-no-renderer-expected.checksum: Added.
  • platform/gtk/fast/forms/input-no-renderer-expected.png: Added.
  • platform/gtk/fast/forms/input-no-renderer-expected.txt: Added.
  • platform/gtk/fast/forms/input-paste-undo-expected.checksum: Added.
  • platform/gtk/fast/forms/input-paste-undo-expected.png: Added.
  • platform/gtk/fast/forms/input-paste-undo-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.checksum:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.png:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt: Added.
  • platform/gtk/fast/forms/input-readonly-empty-expected.checksum: Added.
  • platform/gtk/fast/forms/input-readonly-empty-expected.png: Added.
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt: Added.
  • platform/gtk/fast/forms/input-selectedoption-expected.txt: Added.
  • platform/gtk/fast/forms/input-spaces-expected.checksum: Added.
  • platform/gtk/fast/forms/input-spaces-expected.png: Added.
  • platform/gtk/fast/forms/input-spaces-expected.txt: Added.
  • platform/gtk/fast/forms/input-table-expected.checksum: Added.
  • platform/gtk/fast/forms/input-table-expected.png: Added.
  • platform/gtk/fast/forms/input-table-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-click-inside-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-click-outside-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-double-click-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-double-click-expected.png: Added.
  • platform/gtk/fast/forms/input-text-double-click-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-option-delete-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-option-delete-expected.png: Added.
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.png: Added.
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt: Added.
  • platform/gtk/fast/forms/input-text-word-wrap-expected.checksum: Added.
  • platform/gtk/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt: Added.
  • platform/gtk/fast/forms/input-type-change-expected.checksum: Added.
  • platform/gtk/fast/forms/input-type-change-expected.png: Added.
  • platform/gtk/fast/forms/input-type-change-expected.txt: Added.
  • platform/gtk/fast/forms/input-type-change2-expected.checksum: Added.
  • platform/gtk/fast/forms/input-type-change2-expected.png: Added.
  • platform/gtk/fast/forms/input-type-change2-expected.txt: Added.
  • platform/gtk/fast/forms/input-type-text-min-width-expected.checksum: Added.
  • platform/gtk/fast/forms/input-type-text-min-width-expected.png: Added.
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt: Added.
  • platform/gtk/fast/forms/input-value-expected.checksum: Added.
  • platform/gtk/fast/forms/input-value-expected.png: Added.
  • platform/gtk/fast/forms/input-value-expected.txt: Added.
  • platform/gtk/fast/forms/input-width-expected.checksum: Added.
  • platform/gtk/fast/forms/input-width-expected.png: Added.
  • platform/gtk/fast/forms/input-width-expected.txt: Added.
  • platform/gtk/fast/forms/isindex-placeholder-expected.checksum: Added.
  • platform/gtk/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt: Added.
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum: Added.
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt: Added.
  • platform/gtk/fast/forms/listbox-clip-expected.checksum: Added.
  • platform/gtk/fast/forms/listbox-clip-expected.png: Added.
  • platform/gtk/fast/forms/listbox-clip-expected.txt: Added.
  • platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
  • platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
  • platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • platform/gtk/fast/forms/listbox-width-change-expected.checksum: Added.
  • platform/gtk/fast/forms/listbox-width-change-expected.png: Added.
  • platform/gtk/fast/forms/listbox-width-change-expected.txt: Added.
  • platform/gtk/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/gtk/fast/forms/minWidthPercent-expected.png: Added.
  • platform/gtk/fast/forms/minWidthPercent-expected.txt: Added.
  • platform/gtk/fast/forms/negativeLineHeight-expected.checksum: Added.
  • platform/gtk/fast/forms/negativeLineHeight-expected.png: Added.
  • platform/gtk/fast/forms/negativeLineHeight-expected.txt: Added.
  • platform/gtk/fast/forms/option-index-expected.checksum: Added.
  • platform/gtk/fast/forms/option-index-expected.png: Added.
  • platform/gtk/fast/forms/option-index-expected.txt: Added.
  • platform/gtk/fast/forms/option-script-expected.checksum: Added.
  • platform/gtk/fast/forms/option-script-expected.png: Added.
  • platform/gtk/fast/forms/option-script-expected.txt: Added.
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum: Added.
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt: Added.
  • platform/gtk/fast/forms/option-text-clip-expected.checksum: Added.
  • platform/gtk/fast/forms/option-text-clip-expected.png: Added.
  • platform/gtk/fast/forms/option-text-clip-expected.txt: Added.
  • platform/gtk/fast/forms/password-placeholder-expected.checksum: Added.
  • platform/gtk/fast/forms/password-placeholder-expected.png: Added.
  • platform/gtk/fast/forms/password-placeholder-expected.txt: Added.
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.checksum: Added.
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.png: Added.
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-set-value-expected.checksum: Added.
  • platform/gtk/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt: Added.
  • platform/gtk/fast/forms/plaintext-mode-2-expected.checksum: Added.
  • platform/gtk/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/gtk/fast/forms/radio-attr-order-expected.checksum: Added.
  • platform/gtk/fast/forms/radio-attr-order-expected.png: Added.
  • platform/gtk/fast/forms/radio-attr-order-expected.txt: Added.
  • platform/gtk/fast/forms/radio-nested-labels-expected.checksum: Added.
  • platform/gtk/fast/forms/radio-nested-labels-expected.png: Added.
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt: Added.
  • platform/gtk/fast/forms/radio_checked-expected.checksum: Added.
  • platform/gtk/fast/forms/radio_checked-expected.png: Added.
  • platform/gtk/fast/forms/radio_checked-expected.txt: Added.
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.checksum: Added.
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.png: Added.
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt: Added.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Added.
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.checksum: Added.
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.png: Added.
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt: Added.
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.checksum: Added.
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt: Added.
  • platform/gtk/fast/forms/search-rtl-expected.checksum: Added.
  • platform/gtk/fast/forms/search-rtl-expected.png: Added.
  • platform/gtk/fast/forms/search-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/search-styled-expected.checksum: Added.
  • platform/gtk/fast/forms/search-styled-expected.png: Added.
  • platform/gtk/fast/forms/search-styled-expected.txt: Added.
  • platform/gtk/fast/forms/search-transformed-expected.checksum: Added.
  • platform/gtk/fast/forms/search-transformed-expected.png: Added.
  • platform/gtk/fast/forms/search-transformed-expected.txt: Added.
  • platform/gtk/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/gtk/fast/forms/search-zoomed-expected.checksum: Added.
  • platform/gtk/fast/forms/search-zoomed-expected.png: Added.
  • platform/gtk/fast/forms/search-zoomed-expected.txt: Added.
  • platform/gtk/fast/forms/searchfield-heights-expected.checksum: Added.
  • platform/gtk/fast/forms/searchfield-heights-expected.png: Added.
  • platform/gtk/fast/forms/searchfield-heights-expected.txt: Added.
  • platform/gtk/fast/forms/select-align-expected.checksum: Added.
  • platform/gtk/fast/forms/select-align-expected.png: Added.
  • platform/gtk/fast/forms/select-align-expected.txt: Added.
  • platform/gtk/fast/forms/select-baseline-expected.checksum: Added.
  • platform/gtk/fast/forms/select-baseline-expected.png: Added.
  • platform/gtk/fast/forms/select-baseline-expected.txt: Added.
  • platform/gtk/fast/forms/select-block-background-expected.checksum: Added.
  • platform/gtk/fast/forms/select-block-background-expected.png: Added.
  • platform/gtk/fast/forms/select-block-background-expected.txt: Added.
  • platform/gtk/fast/forms/select-change-listbox-size-expected.checksum: Added.
  • platform/gtk/fast/forms/select-change-listbox-size-expected.png: Added.
  • platform/gtk/fast/forms/select-change-listbox-size-expected.txt: Added.
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • platform/gtk/fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
  • platform/gtk/fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum: Added.
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt: Added.
  • platform/gtk/fast/forms/select-display-none-style-resolve-expected.checksum: Added.
  • platform/gtk/fast/forms/select-display-none-style-resolve-expected.png: Added.
  • platform/gtk/fast/forms/select-display-none-style-resolve-expected.txt: Added.
  • platform/gtk/fast/forms/select-empty-option-height-expected.checksum: Added.
  • platform/gtk/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt: Added.
  • platform/gtk/fast/forms/select-initial-position-expected.checksum: Added.
  • platform/gtk/fast/forms/select-initial-position-expected.png: Added.
  • platform/gtk/fast/forms/select-initial-position-expected.txt: Added.
  • platform/gtk/fast/forms/select-item-background-clip-expected.checksum: Added.
  • platform/gtk/fast/forms/select-item-background-clip-expected.png: Added.
  • platform/gtk/fast/forms/select-item-background-clip-expected.txt: Added.
  • platform/gtk/fast/forms/select-list-box-with-height-expected.checksum: Added.
  • platform/gtk/fast/forms/select-list-box-with-height-expected.png: Added.
  • platform/gtk/fast/forms/select-list-box-with-height-expected.txt: Added.
  • platform/gtk/fast/forms/select-selected-expected.checksum: Added.
  • platform/gtk/fast/forms/select-selected-expected.png: Added.
  • platform/gtk/fast/forms/select-selected-expected.txt: Added.
  • platform/gtk/fast/forms/select-size-expected.checksum: Added.
  • platform/gtk/fast/forms/select-size-expected.png: Added.
  • platform/gtk/fast/forms/select-size-expected.txt: Added.
  • platform/gtk/fast/forms/select-style-expected.checksum: Added.
  • platform/gtk/fast/forms/select-style-expected.png: Added.
  • platform/gtk/fast/forms/select-style-expected.txt: Added.
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum: Added.
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt: Added.
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum: Added.
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt: Added.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.checksum: Added.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Added.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.checksum: Added.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Added.
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt: Added.
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/gtk/fast/forms/targeted-frame-submission-expected.checksum: Added.
  • platform/gtk/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt: Added.
  • platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
  • platform/gtk/fast/forms/text-style-color-expected.checksum: Added.
  • platform/gtk/fast/forms/text-style-color-expected.png: Added.
  • platform/gtk/fast/forms/text-style-color-expected.txt: Added.
  • platform/gtk/fast/forms/textAreaLineHeight-expected.checksum: Added.
  • platform/gtk/fast/forms/textAreaLineHeight-expected.png: Added.
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-align-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-align-expected.png: Added.
  • platform/gtk/fast/forms/textarea-align-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-metrics-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-scroll-height-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-scroll-height-expected.png: Added.
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-scrollbar-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-scrollbar-expected.png: Added.
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.png: Added.
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-width-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-width-expected.png: Added.
  • platform/gtk/fast/forms/textarea-width-expected.txt: Added.
  • platform/gtk/fast/forms/textfield-focus-ring-expected.checksum:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.png:
  • platform/gtk/fast/forms/textfield-outline-expected.checksum: Added.
  • platform/gtk/fast/forms/textfield-outline-expected.png: Added.
  • platform/gtk/fast/forms/textfield-outline-expected.txt: Added.
  • platform/gtk/fast/forms/textfield-overflow-expected.checksum: Added.
  • platform/gtk/fast/forms/textfield-overflow-expected.png: Added.
  • platform/gtk/fast/forms/textfield-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/thumbslider-crash-expected.checksum: Added.
  • platform/gtk/fast/forms/thumbslider-crash-expected.png: Added.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.png: Added.
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt: Added.
11:55 AM Changeset in webkit [70550] by inferno@chromium.org
  • 3 edits in trunk/WebCore

2010-10-26 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Added checks to ensure that events types are right before casting.
​https://bugs.webkit.org/show_bug.cgi?id=48345

  • html/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
11:47 AM Changeset in webkit [70549] by commit-queue@webkit.org
  • 12 edits in trunk

2010-10-26 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Number values should be in the range of IEEE 754 single-precision floating point number
​https://bugs.webkit.org/show_bug.cgi?id=48221

Changed tests and test expectations for number values to fit in the
range of IEEE 754 single-precision

  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/input-valueasnumber-number-expected.txt:
  • fast/forms/input-valueasnumber-range-expected.txt:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/input-valueasnumber-number.js:
  • fast/forms/script-tests/input-valueasnumber-range.js:

2010-10-26 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Number values should be in the range of IEEE 754 single-precision floating point number
​https://bugs.webkit.org/show_bug.cgi?id=48221

Changed the range of number values to fit in IEEE 754 single-precision

  • html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
  • html/NumberInputType.cpp:
11:38 AM Changeset in webkit [70548] by Simon Fraser
  • 11 edits in trunk

2010-10-26 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Support layoutTestController.layerTreeAsText in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42145

Implement layerTreeAsText() in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::layerTreeAsText):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2010-10-26 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Support layoutTestController.layerTreeAsText in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42145

Expose layerTreeAsText() as private API so that
WebKitTestRunner can use it.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyLayerTreeAsText):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::numberOfActiveAnimations): (WebKit::WebFrame::layerTreeAsText): (WebKit::WebFrame::pendingUnloadCount):
  • WebProcess/WebPage/WebFrame.h:

2010-10-26 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Support layoutTestController.layerTreeAsText in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42145

Unskip tests that relied on layerTreeAsText(), but skip
two compositing tests that continue to be flakey.

  • platform/mac-wk2/Skipped:
11:36 AM Changeset in webkit [70547] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch rollout produces incorrect patch when using svn move
​https://bugs.webkit.org/show_bug.cgi?id=48244

We need to flush our caches when we modify the working copy.

  • Scripts/webkitpy/tool/steps/revertrevision.py:
11:32 AM Changeset in webkit [70546] by hyatt@apple.com
  • 13 edits
    16 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48157

Reviewed by Sam Weinig.

Direction and writing-mode should propagate from the <body> to the <html> to the initial containing block.
Modify the existing code that propagates from the document element to also propagate from the body.

Fix the buggy code that was trying to dirty the body when the view changed size if it stretched to fill the
viewport. The code didn't consider the root element, and it only worked with one axis. I pulled it
out of calculateScrollbarModesForLayout, since it should never have been put there in the first place.

Added four new tests in fast/blockflow.

WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::directionSetOnDocumentElement):
(WebCore::Document::writingModeSetOnDocumentElement):
(WebCore::Document::setDirectionSetOnDocumentElement):
(WebCore::Document::setWritingModeSetOnDocumentElement):

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

LayoutTests:

  • fast/blockflow/body-direction-propagation-blocked.html: Added.
  • fast/blockflow/body-direction-propagation.html: Added.
  • fast/blockflow/body-writing-mode-propagation-blocked.html: Added.
  • fast/blockflow/body-writing-mode-propagation.html: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-blocked-expected.checksum: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-blocked-expected.png: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-expected.checksum: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-expected.png: Added.
  • platform/mac/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-blocked-expected.checksum: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-blocked-expected.png: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-expected.checksum: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-expected.png: Added.
  • platform/mac/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/mac/fast/blockflow/english-rl-text-expected.checksum:
  • platform/mac/fast/blockflow/english-rl-text-expected.png:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/mac/fast/blockflow/self-collapsing-block-expected.txt:
11:30 AM Changeset in webkit [70545] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-10-26 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Fix Cache::dumpStats formatting
​https://bugs.webkit.org/show_bug.cgi?id=48286

This updates the column width in the dumpStats output to be wide enough
for all the titles. Previously one of the titles was too wide and crept
into later column space.

  • loader/Cache.cpp: (WebCore::Cache::dumpStats): make columns 13 characters wide.
11:23 AM Changeset in webkit [70544] by andersca@apple.com
  • 5 edits in trunk

Enable the plug-in process on Mac
​https://bugs.webkit.org/show_bug.cgi?id=48350

Reviewed by Sam Weinig.

WebKit2:

  • WebKit2Prefix.h:

Flip the switch and enable the plug-in process on Mac.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformDestroy):
Fix a bogus assert.

LayoutTests:

  • platform/mac-wk2/Skipped:

Update WebKit2 mac skipped list.

11:18 AM Changeset in webkit [70543] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-26 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Check getGraphicsResetStatusARB and reinitialize the
renderer in an error is returned.
​https://bugs.webkit.org/show_bug.cgi?id=47848

Tested by failure injection (stopping in the debugger and issuing a
jump as if an error has occurred).

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setLayerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::transferRootLayer): added

2010-10-26 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Check getGraphicsResetStatusARB and reinitialize the
renderer in an error is returned.
​https://bugs.webkit.org/show_bug.cgi?id=47848

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): added getGraphicsResetStatusARB check (WebKit::WebViewImpl::reallocateRenderer): added
  • src/WebViewImpl.h:
11:14 AM Changeset in webkit [70542] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Disabling inspector audits tests on Qt.
Will figure out what is wrong with it later.

  • platform/qt/Skipped:
11:13 AM Changeset in webkit [70541] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue flaky test message can list the same author more than once
​https://bugs.webkit.org/show_bug.cgi?id=48268

tonikitoo reported to me over IRC this morning that he's seen
the commit-queue report flaky tests with author lists like:
"adam, adam and adam", suggesting we're not uniquing authors
before writing the message.

I fixed the uniquing and added a bunch more unit testing.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
11:04 AM Changeset in webkit [70540] by Adam Roben
  • 3 edits in trunk/WebKitTools

Pull in the FeatureDefines*.vsprops files when building DRT

This ensures that various ENABLE() macros will get set correctly.
(Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag
through wtf/Platform.h.)

Fixes <​http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree
says 3D_RENDERING is disabled even when it is enabled

Reviewed by Ada Chan.

  • DumpRenderTree/win/DumpRenderTree.vcproj: Added

FeaturesDefines*.vsprops to all configurations.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild.
11:04 AM Changeset in webkit [70539] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Fix duplicate vsprops name

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Renamed to

"FeatureDefinesCairo" to match the filename.

11:01 AM Changeset in webkit [70538] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Fix minor typo.

  • storage/indexeddb/objectstore-basics-expected.txt:
10:54 AM Changeset in webkit [70537] by commit-queue@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-26 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Dimitri Glazkov.

Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X
is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control
of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this

--js-flags="--xxx,--noxxx --yyy,--noyyy"

First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by
V8 to turn off the flag).

The changes to the Python test runner will be in a separate change.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::runFileTest): (TestShell::testFinished):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::loadCount): (TestShell::setLoadCount): (TestShell::javaScriptFlagsForLoad): (TestShell::setJavaScriptFlags): (TestShell::setDumpWhenFinished):
10:52 AM Changeset in webkit [70536] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-10-26 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add another flaky test to expectations.
​https://bugs.webkit.org/show_bug.cgi?id=48341

  • platform/chromium/test_expectations.txt: Added flaky crash.
10:42 AM Changeset in webkit [70535] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Touching inspector controller to kick gtk build, removing comments.

  • inspector/InspectorController.cpp:
  • inspector/front-end/ResourceManager.js:
  • inspector/front-end/ScriptsPanel.js:
10:40 AM WebKit2 edited by Simon Fraser
(diff)
10:28 AM Changeset in webkit [70534] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-26 Kenneth Russell <​kbr@google.com>

Reviewed by Andreas Kling.

Valgrind failure in GraphicsContext3DInternal::reshape
​https://bugs.webkit.org/show_bug.cgi?id=48284

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
10:15 AM Changeset in webkit [70533] by mitz@apple.com
  • 151 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of recently-added PNG files to image/png.

10:06 AM Changeset in webkit [70532] by pfeldman@chromium.org
  • 20 edits in trunk

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: continue making resources panel optional.
​https://bugs.webkit.org/show_bug.cgi?id=48261

This refactoring makes console, audits and extensions tests pass while taking data from
resources panel. Network panel as a source is to follow.

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain.populateResourcesForDocuments): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResources): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype.buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype.get resources): (WebInspector.NetworkPanel.prototype.addResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set category):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory): (WebInspector.ResourceCategory.prototype.toString):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.addResource): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._breakpointAdded):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
  • inspector/front-end/inspector.js: (WebInspector._updateFocusedNode): (WebInspector.get networkResources): (WebInspector.forAllResources): (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.removeResource): (WebInspector.reset): (WebInspector.displayNameForURL): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode.callback): (WebInspector.resourceURLForRelatedNode):

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: continue making resources panel optional.
​https://bugs.webkit.org/show_bug.cgi?id=48261

This refactoring makes console, audits and extensions tests pass while taking data from
resources panel. Network panel as a source is to follow.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.addResult): (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking): (initialize_InspectorTest.InspectorTest.findDOMNode): (initialize_InspectorTest.InspectorTest._addSniffer):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:
10:03 AM Changeset in webkit [70531] by jorlow@chromium.org
  • 27 edits in trunk

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB crashes
​https://bugs.webkit.org/show_bug.cgi?id=48266

Test all the changes made in WebCore.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.
Fix IndexedDB crashes
​https://bugs.webkit.org/show_bug.cgi?id=48266

If IDBKey returns null, type conversion failed. Handle this case
in the bindings.

Change UNKNOWN_ERR to be 1 since 0 is hard coded to mean no error.
This is just a stop-gap move until we get it figured out in standards
land.

IDBObjectStore needs to handle null ranges.

It's actually OK for m_transaction to be non-null when hitting the
destructor. We just need to then remove it from the set of pending
transactions.

The transaction can become aborted in the middle of processing a
list of tasks. Fix this.

All changes (except the last 2 races) are tested in LayoutTests.
I couldn't find a way to reliably reproduce the races.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::idbKeyCallback):
  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::timerFired):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB crashes
​https://bugs.webkit.org/show_bug.cgi?id=48266

Make WebIDBObjectStoreImpl match the way that WebIDBIndexImpl passes
in cursor parameters (which is the correct way). KeyRange knows how
to convert itself to a WebCore type--even if the value is null.

  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::openCursor):
9:55 AM Changeset in webkit [70530] by Adam Roben
  • 1 edit
    11 adds in trunk/LayoutTests

Land expected Windows results for new vertical text tests

  • platform/win/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/win/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/win/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/win/fast/blockflow/english-rl-text-expected.checksum: Added.
  • platform/win/fast/blockflow/english-rl-text-expected.png: Added.
  • platform/win/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum: Added.
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/win/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
9:24 AM Changeset in webkit [70529] by caseq@chromium.org
  • 9 edits in trunk/WebCore

2010-10-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show cookie data in the request headers in network pane
​https://bugs.webkit.org/show_bug.cgi?id=16531

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): Factor out common cookies grid logic to CookiesTable (WebInspector.CookieItemsView.prototype._populateDataGrid):
  • inspector/front-end/CookieParser.js: Store cookie type (request/response) within a cookie. (WebInspector.CookieParser.prototype.parseCookie): (WebInspector.CookieParser.prototype.parseSetCookie): (WebInspector.CookieParser.prototype._addCookie): (WebInspector.Cookie):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.autoSizeColumns): Optionally, traverse nested nodes when looking for max field widths. (WebInspector.DataGrid.prototype._enumerateChildren): (WebInspector.DataGrid.prototype.updateWidths): Skip attempt to calculate column widths if grid is not attached to DOM tree yet.
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.resize):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype.resize): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectCookiesTab): (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders): (WebInspector.ResourceView.prototype._refreshCookies): (WebInspector.ResourceCookiesTab): (WebInspector.ResourceCookiesTab.prototype.set requestCookies): (WebInspector.ResourceCookiesTab.prototype.set responseCookies): (WebInspector.ResourceCookiesTab.prototype._populateDataGrid): (WebInspector.ResourceCookiesTab.prototype._populateCookies): (WebInspector.ResourceCookiesTab.prototype._createFolder):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.resize):
  • inspector/front-end/inspector.css: (.resource-view .resource-view-cookies): (.resource-view.headers-visible .resource-view-cookies): (.resource-view-cookies.table .data-grid): (.resource-view-cookies .data-grid .row-group):
9:15 AM Changeset in webkit [70528] by Adam Roben
  • 2 edits in trunk/WebKitTools

Skip more tests that depend on accelerated compositing when accelerated compositing is disabled

Fixes <​http://webkit.org/b/48329> Some tests fail when accelerated
compositing is disabled

Reviewed by John Sullivan.

  • Scripts/old-run-webkit-tests: Added more tests to skip when

accelerated compositing is disable. The tests all have output that
changes depending on whether accelerated compositing is enabled.

9:10 AM Changeset in webkit [70527] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 70517

BUG=60238

9:06 AM Changeset in webkit [70526] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 70517

BUG=60238
Review URL: ​http://codereview.chromium.org/4188001

8:59 AM Changeset in webkit [70525] by jorlow@chromium.org
  • 20 edits in trunk

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70518.
​http://trac.webkit.org/changeset/70518
​https://bugs.webkit.org/show_bug.cgi?id=48332

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.addResult): (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking): (initialize_InspectorTest.InspectorTest.findDOMNode): (initialize_InspectorTest.InspectorTest._addSniffer):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70518.
​http://trac.webkit.org/changeset/70518
​https://bugs.webkit.org/show_bug.cgi?id=48332

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResources): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype.buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype.addResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set category):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory): (WebInspector.ResourceCategory.prototype.toString): (WebInspector.ResourceCategory.prototype.addResource): (WebInspector.ResourceCategory.prototype.removeResource): (WebInspector.ResourceCategory.prototype.removeAllResources):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.addResource): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._breakpointAdded):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
  • inspector/front-end/inspector.js: (WebInspector._updateFocusedNode): (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.removeResource): (WebInspector.reset): (WebInspector.displayNameForURL): (WebInspector.resourceForURL): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode):
8:50 AM Changeset in webkit [70524] by jorlow@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70521.
​http://trac.webkit.org/changeset/70521
​https://bugs.webkit.org/show_bug.cgi?id=48334

This patch depends on another not yet committed. (Requested by
jorlow on #webkit).

  • storage/indexeddb/tutorial-expected.txt: Removed.
  • storage/indexeddb/tutorial.html: Removed.
8:47 AM Changeset in webkit [70523] by satish@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-26 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Remove obsolete public/API methods in chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=48330

  • public/WebSpeechInputListener.h:
8:21 AM Changeset in webkit [70522] by jorlow@chromium.org
  • 17 edits
    1 copy
    4 adds
    1 delete in trunk

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Quota for IndexedDB should be per origin not per database
​https://bugs.webkit.org/show_bug.cgi?id=48064

Verify our backing database can handle multiple indexes, objectStores,
items in the index/object stores, etc within databases of different
names.

Also adjust the quota test so it doesn't fail with subtle differences
in the backing db (which can change the size a bit).

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt: Added.
  • storage/indexeddb/duplicates.html: Added.

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Quota for IndexedDB should be per origin not per database
​https://bugs.webkit.org/show_bug.cgi?id=48064

Merge all databases for each origin into a single SQLiteDatabase.

Replace the awkward metaData table with a Database table.

Create a new IDBSQLiteDatabase class that wraps SQLiteDatabase
and implements weak pointer semantics for IDBFactory. It's ref
counted so multiple IDBDatabaseBackendImpls can share one.

Fix uniqueness constraints that were overly conservitive.

Get rid of the code that blows away existing data every time
the database is opened.

Get rid of the fairly useless indexedDB manual test and replace
it with one that verifies data persists.

Use name+origin (not just name) in our cache of IDBDatabaseBackend
objects (so one origin can't access anothers' data).

Test: storage/indexeddb/duplicates.html

  • WebCore.gypi:
  • manual-tests/indexed-database.html: Removed.
  • manual-tests/indexeddb-persists.html: Added.
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setDescription): (WebCore::IDBDatabaseBackendImpl::sqliteDatabase): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create): (WebCore::IDBDatabaseBackendImpl::id):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::removeSQLiteDatabase): (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::databaseFileName):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::putObjectStoreData): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBSQLiteDatabase.cpp: Added. (WebCore::IDBSQLiteDatabase::IDBSQLiteDatabase): (WebCore::IDBSQLiteDatabase::~IDBSQLiteDatabase):
  • storage/IDBSQLiteDatabase.h: Added. (WebCore::IDBSQLiteDatabase::create): (WebCore::IDBSQLiteDatabase::db):

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Quota for IndexedDB should be per origin not per database
​https://bugs.webkit.org/show_bug.cgi?id=48064

  • public/WebIDBFactory.h:
  • public/WebSecurityOrigin.h:
  • src/WebIDBFactory.cpp: (WebKit::WebIDBFactory::databaseFileName):
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::get):
8:19 AM Changeset in webkit [70521] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB test/tutorial
​https://bugs.webkit.org/show_bug.cgi?id=48067

This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.

  • storage/indexeddb/tutorial-expected.txt: Added.
  • storage/indexeddb/tutorial.html: Added.
8:02 AM Changeset in webkit [70520] by zoltan@webkit.org
  • 6 edits
    2 moves in trunk/WebKit2

[Qt] Implement SharedMemory for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=47345

Reviewed by Kenneth Rohde Christiansen.

Implement unimplemented functions in SharedMemoryQt.cpp.
Rename MappedMemory.h to MappedMemoryPool.h, move MappedMemoryPool.{h|cpp} from
Shared/qt to Platform/qt. Modify affected lines of WebKit2.pro.
Move MappedMemory implementation into MappedMemoryPool. Remove unnecessary
methods of MappedMemoryPool.

  • Platform/SharedMemory.h: Add a handle member for Qt.
  • Platform/qt/MappedMemoryPool.cpp: Copied from WebKit2/Shared/qt/MappedMemoryPool.cpp.

(WebKit::MappedMemoryPool::searchForMappedMemory):
(WebKit::MappedMemoryPool::mapMemory):
(WebKit::MappedMemoryPool::mapFile):

  • Platform/qt/MappedMemoryPool.h: Copied from WebKit2/Shared/qt/MappedMemory.h.

(WebKit::MappedMemoryPool::MappedMemory::mapSize):
(WebKit::MappedMemoryPool::MappedMemory::markUsed):
(WebKit::MappedMemoryPool::MappedMemory::markFree):
(WebKit::MappedMemoryPool::MappedMemory::isFree):
(WebKit::MappedMemoryPool::MappedMemory::data):
(WebKit::MappedMemoryPool::MappedMemoryPool):
Move MappedMemory implementation into MappedMemoryPool.

  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::Handle::Handle): Implement.
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull): Implement.
(WebKit::SharedMemory::Handle::encode): Implement.
(WebKit::SharedMemory::Handle::decode): Implement.
(WebKit::SharedMemory::create): Implement.
(WebKit::mapProtection): Added.
(WebKit::SharedMemory::~SharedMemory): Implement.
(WebKit::SharedMemory::createHandle): Implement.
(WebKit::SharedMemory::systemPageSize): Implement.

  • Shared/qt/MappedMemory.h: Removed.
  • Shared/qt/MappedMemoryPool.cpp: Removed.
  • Shared/qt/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::decode):
Modify to use MappedMemoryPool.

  • Shared/qt/UpdateChunk.h:
  • WebKit2.pro:

Modify affected lines.

7:18 AM Changeset in webkit [70519] by caseq@chromium.org
  • 12 edits in trunk/WebCore

2010-10-20 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Inspector needs to use cached resources to display image resources.
​https://bugs.webkit.org/show_bug.cgi?id=16395

  • inspector/Inspector.idl: Add base64Encode parameter to getContent
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.contentTabSelected.onResourceContent): (WebInspector.ImageView.prototype.contentTabSelected):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell.): (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set finished): (WebInspector.Resource.prototype.getContent): (WebInspector.Resource.prototype.get contentURL): (WebInspector.Resource.prototype._requestContent.onResourceContent): (WebInspector.Resource.prototype._requestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.createIconElement.): (WebInspector.ResourceSidebarTreeElement.prototype.createIconElement):
  • inspector/front-end/Settings.js: Added useDataURLForResourceImageIcons
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
6:52 AM Changeset in webkit [70518] by pfeldman@chromium.org
  • 20 edits in trunk

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: continue making resources panel optional.
​https://bugs.webkit.org/show_bug.cgi?id=48261

This refactoring makes console, audits and extensions tests pass while taking data from
resources panel. Network panel as a source is to follow.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.addResult): (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking): (initialize_InspectorTest.InspectorTest.findDOMNode): (initialize_InspectorTest.InspectorTest._addSniffer):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: continue making resources panel optional.
​https://bugs.webkit.org/show_bug.cgi?id=48261

This refactoring makes console, audits and extensions tests pass while taking data from
resources panel. Network panel as a source is to follow.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.addResult): (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking): (initialize_InspectorTest.InspectorTest.findDOMNode): (initialize_InspectorTest.InspectorTest._addSniffer):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:
6:29 AM Changeset in webkit [70517] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-26 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Protect the frame from being blown away in loadWithDocumentLoader function call.
dispatchBeforeLoadEvent can cause the frame to be freed, which gets later used in
continueLoadAfterNavigationPolicy call.
​https://bugs.webkit.org/show_bug.cgi?id=48281

Test: fast/events/form-iframe-target-before-load-crash.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader):

2010-10-26 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that submit the form on a removed target iframe does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=48281

  • fast/events/form-iframe-target-before-load-crash-expected.txt: Added.
  • fast/events/form-iframe-target-before-load-crash.html: Added.
4:37 AM Changeset in webkit [70516] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-10-26 Xan Lopez <​xlopez@igalia.com>

Restore another mix-up in copy&paste error. Use height for the
vertical adjustments instead of width.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setVerticalAdjustment):
3:53 AM Changeset in webkit [70515] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-10-26 Xan Lopez <​xlopez@igalia.com>

Restore early return accidentally removed in previous
patch. Should make API tests pass again.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setHorizontalAdjustment): (WebCore::ScrollView::setVerticalAdjustment):
1:37 AM Changeset in webkit [70514] by xan@webkit.org
  • 5 edits in trunk

WebCore:

2010-10-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port to new GtkScrollable interface in GTK+ 3.x
​https://bugs.webkit.org/show_bug.cgi?id=48202

The new GtkScrollable API sets the adjustments individually, so
adjust the code for this fact.

  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setHorizontalAdjustment): new method to set the horizontal adjustment. (WebCore::ScrollView::setVerticalAdjustment): new method to set the vertical adjustment. (WebCore::ScrollView::setGtkAdjustments): make this just call the other two methods.

WebKit/gtk:

2010-10-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port to new GtkScrollable interface in GTK+ 3.x
​https://bugs.webkit.org/show_bug.cgi?id=48202

Use the new GtkScrollable interface when compiling against GTK+
3.x.

  • webkit/webkitwebview.cpp: (setHorizontalAdjustment): (setVerticalAdjustment): (getHorizontalAdjustment): (getVerticalAdjustment): (webkit_web_view_get_property): (webkit_web_view_set_property): (webkit_web_view_class_init):
1:27 AM Changeset in webkit [70513] by morrita@google.com
  • 12 edits in trunk

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70512.
​http://trac.webkit.org/changeset/70512
​https://bugs.webkit.org/show_bug.cgi?id=48314

crashes many tests (Requested by inferno-sec on #webkit).

  • editing/spelling/spellcheck-attribute-expected.txt:
  • editing/spelling/spellcheck-attribute.html:

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70512.
​http://trac.webkit.org/changeset/70512
​https://bugs.webkit.org/show_bug.cgi?id=48314

crashes many tests (Requested by inferno-sec on #webkit).

  • dom/Element.cpp:
  • dom/Element.h:
  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::spellCheckingEnabledInFocusedNode): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/Editor.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-10-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70512.
​http://trac.webkit.org/changeset/70512
​https://bugs.webkit.org/show_bug.cgi?id=48314

crashes many tests (Requested by inferno-sec on #webkit).

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::shouldSpellcheckByDefault):
Note: See TracTimeline for information about the timeline view.